ntpdate: Add a deprecation message to syslog

[ziaee]

Summary

ntpdate is deprecated for generations. I never tried to do this before,
looking at ntpdate it uses it's own syslog function. I wanted to use a
LOG_WARN but it isn't possible with that, and I figured "it needs to be
how it is".

I'm not sure we shouldn't take this upstream first?

Suggested by: emaste

[cy]

Why put the message here, now? It is not we (FreeBSD) who will deprecated it in a certain amount of time. It is nwtime.org that will. Should we not try to upstream this by submitting a patch to them first? Before we apply this patch here?

Not to mention our sources diverge from theirs, meaning whoever (probably me) has to remember that we did and why. I think this is a little premature ATM.

Let's you and I put our heads together and submit a patch here --> https://bugs.ntp.org/index.cgi, first. Let's hear what they have to say first.

[ziaee]

Why put the message here, now?

I put this here (on phab) to show you guys (people i know interested in ntp lately) because I have no idea what I'm doing.

At $dayjob we finished building the datacenter too fast, so during the downtime I've been taking a class on C, and I've finally gotten far enough that I can imagine how to enact this suggestion emaste gave me several months ago, but I don't know if it's reasonable or not.

Let's you and I put our heads together and submit a patch here --> https://bugs.ntp.org/index.cgi, first. Let's hear what they have to say first.

Agree! I put these here first because I wanted to get your thoughts before proceeding, since I think Harlan is even more overworked and understaffed than us.

Throwing up on phab is cozy because I don't have to start a desktop :P

[cy]

I sent (cc you) an email to Harlan Stenn, the primary developer at nwtime.org. (nwtime.org is replacing the ntp.org). Let's see what he says.

[cy]

Can you also please submit a review for the port?

contrib/ntp/ntpdate/ntpdate.c

302

I think the error should be worded like this:

ntpdate is deprecated and scheduled for removal in ntp 4.4, use ntpd -gq instead

[ziaee]

Can you also please submit a review for the port?

once we get this figured out, absolutely!

contrib/ntp/ntpdate/ntpdate.c

302

the first part is much better, but i am concerned about recommending -gq right off the bat because the manpage says it's a safety override

[cy]

contrib/ntp/ntpdate/ntpdate.c

302

How about this?

+ msyslog(LOG_NOTICE,"ntpdate is deprecated and scheduled for removal in ntp 4.4, use ntpd -g instead");

Also, I don't think this rises to the level of LOG_ERR. This is not an error that causes ntpdate to fail. LOG_NOTICE says we are giving notice that this utility is deprecated.

[ziaee]

(not sure if i wrapped this correctly)

[cy]

Good to go.

Please submit a review or bugzilla bug for the port too.