Awesome! I will merge this on Monday if nobody else has anything to add/does it sooner. Thank you so much, this is a great feature!

the nit is good, thanks @ivy

oops, previous diff ammended the wrong commit, sorry for the noise

the nit is good, thanks @ivy

fix typo, thanks @kevans!

use logic inspired from @lwhsu to prevent reboot if nothing happened. compare the file size in bytes of the pkg database instead of using pkg inf and checksum to save water/coal. tested on my laptop

implement bootstrap pkg if it is not done so already, based on lwhsu feedback, thanks! note, i like a blank line at the end of scripts for cat reasons. if we don't want this, i can remove it, but it doesn't hurt anything and we do it all over the place.

remove all reasoning and simply state that this requires -f.

Ping, all other doc has been updated, but I feel like I can't commit this without some approval because core was tagged.

I am committing this due to feedback timeout. If we want to improve this more, I am absolutely happy to do so, but this is 1. a needed bugfix and 2. obstructing other work.

use non-breaking spaces for unit sizes, unless we already use a hyphen on that page.

! In D54882#1291723, @guest-seuros wrote:
@ziaee , shall we name this driver intelthermal or intel_thermal to mirror acpi_thermal < already in tree ?

missed another spot

missed a spot, thanks bbaovanc!

drop the IEC, it's technically an anachronism, and "binary byte sizes"
isn't any less clear.

Currently, wiki is in both documentation and developers sidebar. I would prefer that it is just in the developers sidebar so people do not confuse it with what wiki means in other projects.

Looks pretty good on android phone and firefox desktop.

LGTM from manpages. If you have a moment the https://reviews.freebsd.org/D56153 you requested is awaiting your review.

I know most people are using graphical desktop fonts which are missing this character, but I've been working on just getting it into our vt console font instead.

Don't be, I'm glad I can help! Please let me know if there's anything else I can do to support you!

I didn't get very far yet, but a few comments so far. Thanks for inviting me!

I don't really understand how the .po files work, @ebrandi usually regenerates them all at once every few months.

merged without review

ping

Is this ready?

remove log prefix overquoting and add autoclean to pkg. thanks @delphij!
overquoting is ugly and confusing, and autoclean is definitely ideal.
the space savings will be a lot across the entire cloud.

apply bapt feedback. note that a bogus repo being specified will abort all the others. im not sure if i need to initialize the empty variable first, but that's what i did. thanks @bapt!

adjust logic to accept a firstboot_pkg_upgrade_repos variable that
limits the repos to specific repos if provided. i adapted the logic
from sysutils/firstboot-pkgs, but this is the most complex rc.d script
ive tried to write, so i don't know what i dont know. thanks Colin!

Limited to FreeBSD-base repo and tested on my laptop. Thanks Colin!

ok, i figured out how to test this, and fixed the errors. it's working
on my machine by touching /firstboot. this may be ready for review now.

update to incorporate device.hints

Ping? I think this is important info, so if you're busy, I'd be happy to take it and finish it for you?

Couple of minor nits, thank you so much for doing this! Also, don't forget to add this manual to the Makefile!

Thanks for looking it over @emaste, how about this?

In D56300#1290712, @michaelo wrote:

@ziaee, I have cleaned up ports some time ago.

remove HTTP_TIMEOUT since I didn't see that in the pkg code. Add -y so
that pkg upg can run non-interactive.

In D54881#1290624, @guest-seuros wrote:

@ziaee, the reason I put it on the second line was to keep it grepable. If you run head -n3 on driver files, you almost always land in the license header instead of anything useful, for example:
here and sys/fs/ext2fs/ext2_dir.h and many others.

Some files don't even have a license header at all, e.g. sys/arm64/arm64/bus_machdep.c.

PS: there are more files with the SPDX header , and my IDE show me warning because it don't follow the conventions most codebase had
coreboot
linux

The copyright line becomes problematic when there are multiple authors, since the license block keeps getting pushed further down.

The FreeBSD Project aims to produce a complete, BSD-licensed operating system allowing consumers of the system to produce derivative products without constraint or further license obligations.

A fork will inevitably change the structure once they start adding more contributors. Checking if someone altered the version, is not diffable.

---

I will update this diff and thermal once i get the naming is final.

add buildworld and split out update-packages; forgot about that, sorry.

Ping

In D32450#1290560, @emaste wrote:

OBE. I'd still like us to provide some more clarity on releases -- right now 15.0 and 14.4 are "Production Releases" with no advice on how to pick one or the other. But the specific issue related to this review is gone.

Thanks @carlavilla !