You have thrown out the baby with the bathwater.
Integrated, offline, semantically tagged documentation subsystem is better than your dependency-riddled, half baked webapp of the day.
And I'm going to to prove it.
You have thrown out the baby with the bathwater.
Integrated, offline, semantically tagged documentation subsystem is better than your dependency-riddled, half baked webapp of the day.
And I'm going to to prove it.
This is a huge patch, very impressive.
see i told you guys 20 was too short :-P
In D60989#1414100, @ptudor_ptudor.net wrote:Thanks for the list and for going through the man page. I’ll address all you mentioned.
ok heres for the manpage
yes, three people have said we should avoid trailing digits in a device driver name if possible. please do not do this, it can be very confusing, and i suggested three names which all seem perfectly sensible to me, but i am not stuck on them. while that is being worked on, i will now go through the manpage.
fix pre-existing missing freebsd filename macro for .xinitrc
In D61595#1411898, @vladlen wrote:I will look into this patch, could you give me some time.
oops! thanks @carlavilla. the "is" was a typo. the "an", well... i do not have concrete rules i can explain but as a native speaker "an" feels much more natural in this case, but if phrased slightly differently it wouldn't.
also thanks for tagging me!
I think this is really nicely written, I have only the trivialest of style nits, but... at least i have backups for why! recommend still having someone familiar with the underlying subject look at it too
the reason i was wondering that is in case people want to put them in loader.conf. if you put these in loader.conf they just silently do nothing since they are sysctl only.
Forgot to add Reported by: Chris Davidson <christopher.davidson@gmail.com>, PR: 207625, and MFC after: 3 days trailers.
Wow, cool! We've been talking about this for a long time!
It would be very useful for posterity to mention in this commit message when the behavior changed to render the example invalid with a Fixes: tag.
Thanks so much for doing this, please merge this asap with the following changes!
Accepted with the following nit. Also, please please please use Relnotes: yes. New user visible things belong in the release notes, this is very important to show the doc project is working.
forgot to bump portrevision. i didn't test all consumers yet because i only have 16.6kbit internet at home, so, I'm not committing this yet.
fixup
There was an alternate patch which is very short, but it uses "newer" features in CSS and would loose support of internet browsers before 2023, which seemed like a bad option.
In D42106#1411520, @kfv wrote:The manpage isn't actually wrong, just ambiguous, and I think that stems from the "fill" wording. By "filling columns" it means stepping through the column positions, which matches the code, but I agree hardly anyone will read it that way. The current wording misleads the end user, where the proposed wording misleads anyone reading the source, so IMHO it doesn't remove the ambiguity, it just moves it elsewhere. I'd rather we drop "fill" altogether and borrow something similar to ls(1); e.g. "Entries are arranged down the columns" for the default behaviour and "Arrange entries across, rather than down, the columns" for -x, or something like that.
+ add 999,999 lines of context as suggested by bcr, thanks! Unrelated, I wish there was a full context option, 999999 just seems so excessive.
Hm, git-arc update removed bcr as a subscriber!
+ s.freebsd-git-arc.devel/freebsd-git-arc.
+ keep old anchor
+ fix typo in committers guide anchor
Please use commit message title like freebsd-update-server: Pkgbase rewrite
Wow, after the editorial work this is like, old school freebsd quality! Also it was fun reading it in your voice.
Thanks!
In D61334#1409036, @glebius wrote:Thanks! I don't think such trivial changes need review process.
Doesn't apply cleanly to main, can you rebase?
Please add a history section saying when this interface became available.
fix typos; tweak line wrapping
Sorry this one fell through the cracks, thanks Artem!
I wrote this to look good on a numbered 80x25 console as well as the rendering on phorges with a phone web browser, such as https://ron-dev.freebsd.org/FreeBSD/doc . I have an old one up at https://github.com/concussious/freebsd-doc , but since then I added the bit about sending us pings based on the talk today by @amy.vargas_netapp.com
thanks @vvd!