Page MenuHomeFreeBSD

cperciva (Colin Percival)
User

Projects

User Details

User Since
Jun 3 2014, 6:45 PM (318 w, 4 d)

Recent Activity

Tue, Jun 30

cperciva committed rS362791: Make EC2 AMIs use portsnap and freebsd-update mirrors hosted in AWS.
Make EC2 AMIs use portsnap and freebsd-update mirrors hosted in AWS
Tue, Jun 30, 6:14 AM
cperciva closed D25498: Make EC2 AMIs use portsnap and freebsd-update mirrors hosted in AWS.
Tue, Jun 30, 6:14 AM

Mon, Jun 29

cperciva added a comment to D25498: Make EC2 AMIs use portsnap and freebsd-update mirrors hosted in AWS.

We're using route53 for portsnap right now; not for freebsd-update. But yes, I'll be looking into adjusting the existing portsnap DNS records to send traffic to these -- at very least in place of the old portsnap mirrors I've had in EC2 for many years.

Mon, Jun 29, 1:26 AM

Sun, Jun 28

cperciva requested review of D25498: Make EC2 AMIs use portsnap and freebsd-update mirrors hosted in AWS.
Sun, Jun 28, 7:26 PM

Fri, Jun 26

cperciva accepted D18482: Amazon EC2: Disable floppy devices (fdc0, fd0,) and parallel port device (pp0).

Ah, on t2.micro I see warnings about fdc (but not about ppc). Normally I aim to minimize the difference between EC2 and "stock" FreeBSD, but I guess there's no harm in making this change even if it only affects older instance types.

Fri, Jun 26, 12:55 AM · Contributor Reviews (base)

Thu, Jun 25

cperciva added a comment to D18482: Amazon EC2: Disable floppy devices (fdc0, fd0,) and parallel port device (pp0).

Which instance type are you seeing this on? I haven't been able to reproduce it.

Thu, Jun 25, 9:09 PM · Contributor Reviews (base)

Tue, Jun 23

cperciva committed rS362557: Clean up some function and variable names..
Clean up some function and variable names.
Tue, Jun 23, 9:12 PM
cperciva closed D25403: Fix fallout from the emancipation of dump(8) workers.
Tue, Jun 23, 9:11 PM
cperciva accepted D25373: Fix AccessWidth and BitWidth parsing in SPCR table.

Looks good to me. Might be worth mentioning in the commit message that EFI_ACPI_6_0_UNDEFINED handling is needed to work around a buggy SPCR table on EC2 x86 "bare metal" instances, just in case someone looks at the code a few years from now and wonders why we're doing this.

Tue, Jun 23, 6:27 PM · x86, arm64
cperciva closed D24791: Add /etc/autofs/special_efs to EC2 images.
Tue, Jun 23, 3:19 AM
cperciva requested review of D24791: Add /etc/autofs/special_efs to EC2 images.
Tue, Jun 23, 3:17 AM
cperciva closed D24583: Set use_nvd=0 in EC2 AMIs.
Tue, Jun 23, 3:16 AM
cperciva requested review of D24583: Set use_nvd=0 in EC2 AMIs.
Tue, Jun 23, 3:15 AM
cperciva added inline comments to D25373: Fix AccessWidth and BitWidth parsing in SPCR table.
Tue, Jun 23, 2:48 AM · x86, arm64

Mon, Jun 22

cperciva requested review of D25403: Fix fallout from the emancipation of dump(8) workers.
Mon, Jun 22, 8:37 PM
cperciva added inline comments to D25373: Fix AccessWidth and BitWidth parsing in SPCR table.
Mon, Jun 22, 8:07 PM · x86, arm64

Sat, Jun 20

cperciva added inline comments to D25373: Fix AccessWidth and BitWidth parsing in SPCR table.
Sat, Jun 20, 4:27 PM · x86, arm64

Jun 8 2020

cperciva accepted D24517: sysutils/firstboot-pkgs: Bootstrap and update pkg unconditionally.

Looks good to me. Please commit.

Jun 8 2020, 5:10 PM

May 30 2020

cperciva committed rS361653: Insta-merge r361652 from stable/11: Expand EC2 AMI UFS partition to 2.9 GB..
Insta-merge r361652 from stable/11: Expand EC2 AMI UFS partition to 2.9 GB.
May 30 2020, 6:02 PM
cperciva committed rS361652: Bump the UFS partition in the EC2 AMI up to 2.9 GB; this doesn't affect.
Bump the UFS partition in the EC2 AMI up to 2.9 GB; this doesn't affect
May 30 2020, 5:43 PM
cperciva committed rS361645: Direct commit to stable/12: Only install ebsnvme-id on amd64 for now..
Direct commit to stable/12: Only install ebsnvme-id on amd64 for now.
May 30 2020, 2:56 AM
cperciva committed rS361644: MFC r361350: Add ebsnvme-id to EC2 AMIs and enable /dev/aws/disk.
MFC r361350: Add ebsnvme-id to EC2 AMIs and enable /dev/aws/disk
May 30 2020, 2:52 AM
cperciva committed rS361643: MFC r361143: Add /etc/autofs/special_efs to EC2 AMIs.
MFC r361143: Add /etc/autofs/special_efs to EC2 AMIs
May 30 2020, 2:50 AM

May 21 2020

cperciva added inline comments to D24065: Add Arm pl061 GPIO driver.
May 21 2020, 7:28 PM

May 19 2020

cperciva committed rS361235: MFC r361114:.
MFC r361114:
May 19 2020, 1:41 AM
cperciva committed rS361234: MFC r361097:.
MFC r361097:
May 19 2020, 1:39 AM

May 18 2020

cperciva accepted D24872: sysutils/amazon-ssm-agent: update to v2.3.1205.0.

Looks good, thanks! You can commit this, right?

May 18 2020, 9:08 PM
cperciva committed rS361150: Add ebsnvme-id to EC2 AMIs and enable /dev/aws/disk.
Add ebsnvme-id to EC2 AMIs and enable /dev/aws/disk
May 18 2020, 2:14 AM

May 17 2020

cperciva committed rS361143: Add /etc/autofs/special_efs to EC2 AMIs.
Add /etc/autofs/special_efs to EC2 AMIs
May 17 2020, 9:55 PM
cperciva abandoned D24763: Support multiple auto_master files.
May 17 2020, 9:38 PM
cperciva abandoned D24764: Split auto_master file into /etc/autofs/master_*.
May 17 2020, 9:37 PM
cperciva added a comment to D24764: Split auto_master file into /etc/autofs/master_*.

Good point about automount -L. I do like the idea of rc.conf as a "master control file" because I think it's easier for users (especially new users) if they can configure as much as possible from a single place, but the fact that automount is invoked directly rather than always via the rc.d system makes this problematic.

May 17 2020, 9:37 PM
cperciva added inline comments to D24872: sysutils/amazon-ssm-agent: update to v2.3.1205.0.
May 17 2020, 9:03 PM

May 16 2020

cperciva committed rS361114: Move the devmatch rc.d script before netif in the boot process..
Move the devmatch rc.d script before netif in the boot process.
May 16 2020, 6:38 PM
cperciva committed rS361097: Send Lid status notification via devd from acpi_lid_status_update..
Send Lid status notification via devd from acpi_lid_status_update.
May 16 2020, 1:50 AM

May 13 2020

cperciva committed rP535080: Use uidfix in sysutils/ebsnvme-id.
Use uidfix in sysutils/ebsnvme-id
May 13 2020, 5:03 AM

May 10 2020

cperciva added a comment to D24791: Add /etc/autofs/special_efs to EC2 images.

My policy thus far has been to avoid having EC2-specific code in "stock" FreeBSD as much as possible. (There have been exceptions, like the NFS "oneopenown" option, but those were unavoidable.)

May 10 2020, 7:29 PM
cperciva added a comment to D24791: Add /etc/autofs/special_efs to EC2 images.

If D24763 and D24764 are accepted, I'll also add a /etc/autofs/master_efs file to EC2 instances, so that EFS can be enabled simply by adding

May 10 2020, 3:38 AM

May 8 2020

cperciva added a comment to D24764: Split auto_master file into /etc/autofs/master_*.

Depends on D24763.

May 8 2020, 5:57 PM
cperciva requested review of D24764: Split auto_master file into /etc/autofs/master_*.
May 8 2020, 5:57 PM
cperciva requested review of D24763: Support multiple auto_master files.
May 8 2020, 5:52 PM
cperciva closed D8965: Avoid ESTALE if directory deleted by same NFS client.
May 8 2020, 5:46 PM

May 7 2020

cperciva committed rP534294: IGNORE on FreeBSD without NVME_GET_NSID..
IGNORE on FreeBSD without NVME_GET_NSID.
May 7 2020, 9:39 PM

May 5 2020

cperciva committed rP534017: Add ebsnvme-id 1.0..
Add ebsnvme-id 1.0.
May 5 2020, 3:21 AM

May 2 2020

cperciva committed rP533702: Update to 20200418..
Update to 20200418.
May 2 2020, 8:03 PM
cperciva closed D24490: Update graphics/intel-backlight.
May 2 2020, 8:03 PM

Apr 27 2020

cperciva committed rS360396: Set use_nvd=0 in EC2 AMIs..
Set use_nvd=0 in EC2 AMIs.
Apr 27 2020, 9:44 PM

Apr 26 2020

cperciva added a comment to D24583: Set use_nvd=0 in EC2 AMIs.

Warner: We discussed this on IRC; please confirm that the comment in the code and what I wrote in the "summary" above make sense.

Apr 26 2020, 11:56 PM

Apr 24 2020

cperciva added a comment to D24517: sysutils/firstboot-pkgs: Bootstrap and update pkg unconditionally.
In D24517#540205, @bapt wrote:

I'm not sure I understand the logic behind this.

If I understand correctly, a problem arises when the local copy of the repository catalogue is a very old version. If this is the case, couldn't we also have problems if the local database of *installed* packages is an old version?

your understanding is correct, but it cannot happen because I make sure pkg is backward compatible regarding the local database and always able to upgrade an old version of the database.

Apr 24 2020, 6:00 PM

Apr 23 2020

cperciva added a comment to D24517: sysutils/firstboot-pkgs: Bootstrap and update pkg unconditionally.

I'm not sure I understand the logic behind this.

Apr 23 2020, 10:09 PM

Apr 22 2020

cperciva created D24546: Use smaller jumbo mbufs in ENA as needed.
Apr 22 2020, 11:29 PM

Apr 19 2020

cperciva committed rS360089: MFC r360025: Alert devd when acpi_video brightness changes.
MFC r360025: Alert devd when acpi_video brightness changes
Apr 19 2020, 2:49 AM

Apr 18 2020

cperciva created D24490: Update graphics/intel-backlight.
Apr 18 2020, 10:14 PM

Apr 16 2020

cperciva committed rS360025: Alert devd when acpi_video brightness changes.
Alert devd when acpi_video brightness changes
Apr 16 2020, 9:57 PM
cperciva closed D24424: Alert devd when acpi_video brightness changes.
Apr 16 2020, 9:57 PM

Apr 15 2020

cperciva added a comment to D24256: Avoid concurrent nvme_qpair_process_completions runs.

Updating in case anyone looks back at this later: This fixes some instability on EC2 instances, and helped me to figure out what's going on. It looks like something -- probably the ENA device -- is monopolizing a CPU and starving the nvme completion ithread, and we were getting timeouts despite the interrupt having in fact fired successfully.

Apr 15 2020, 8:18 PM

Apr 14 2020

cperciva created D24424: Alert devd when acpi_video brightness changes.
Apr 14 2020, 8:33 PM

Apr 12 2020

cperciva committed rP531481: Belatedly bump PORTREVISION due to the fix in the spiped UIDs entry.
Belatedly bump PORTREVISION due to the fix in the spiped UIDs entry
Apr 12 2020, 5:18 AM

Apr 11 2020

cperciva committed rP531444: Use canonical spelling of "/nonexistent"..
Use canonical spelling of "/nonexistent".
Apr 11 2020, 5:48 PM

Apr 10 2020

cperciva committed rP531388: Update to 1.3.1..
Update to 1.3.1.
Apr 10 2020, 11:07 PM
cperciva committed rP531280: Update spiped to 1.6.1..
Update spiped to 1.6.1.
Apr 10 2020, 1:33 AM

Apr 8 2020

cperciva committed rP531085: Update bsdec2-image-upload to 1.3.0..
Update bsdec2-image-upload to 1.3.0.
Apr 8 2020, 3:27 AM

Apr 3 2020

cperciva added inline comments to D24284: Revamp nvme recovery.
Apr 3 2020, 11:48 PM

Apr 2 2020

cperciva added inline comments to D24256: Avoid concurrent nvme_qpair_process_completions runs.
Apr 2 2020, 9:57 PM
cperciva added inline comments to D24256: Avoid concurrent nvme_qpair_process_completions runs.
Apr 2 2020, 9:31 PM
cperciva added inline comments to D24256: Avoid concurrent nvme_qpair_process_completions runs.
Apr 2 2020, 8:31 PM
cperciva added inline comments to D24256: Avoid concurrent nvme_qpair_process_completions runs.
Apr 2 2020, 7:10 PM
cperciva added inline comments to D24256: Avoid concurrent nvme_qpair_process_completions runs.
Apr 2 2020, 5:45 PM
cperciva added a comment to D24256: Avoid concurrent nvme_qpair_process_completions runs.
In D24256#533690, @imp wrote:

If we need this lock, we've already lost....
What's the root cause of the timeout issue?
I suspect that we're racing because we have multiple outstanding I/Os, one times out and while we're running the completion code either that unwedges the card...

Apr 2 2020, 5:39 PM

Apr 1 2020

cperciva created D24256: Avoid concurrent nvme_qpair_process_completions runs.
Apr 1 2020, 11:42 PM

Mar 20 2020

cperciva added a comment to D23860: x11/libxkbcommon: switch to evdev rules (upstream default).

Changing this setting via export XKB_DEFAULT_RULES=evdev fixes KDE on my new laptop (Dell Latitude 7390). Can this change be committed to modify the default soon?

Mar 20 2020, 3:17 AM

Mar 14 2020

cperciva committed rS358990: MFC r358478: Add -N option to powerd(8) to ignore "nice" time..
MFC r358478: Add -N option to powerd(8) to ignore "nice" time.
Mar 14 2020, 6:58 AM

Feb 29 2020

cperciva committed rS358478: Add -N option to powerd(8) to ignore "nice" time..
Add -N option to powerd(8) to ignore "nice" time.
Feb 29 2020, 10:31 PM
cperciva closed D23868: Add -N option to powerd to ignore time spent on nice processes.
Feb 29 2020, 10:31 PM

Feb 28 2020

cperciva created D23868: Add -N option to powerd to ignore time spent on nice processes.
Feb 28 2020, 5:13 AM

Feb 25 2020

cperciva committed rS358303: MFC r357750: Mount /dev while deinstalling pkg inside EC2 AMIs..
MFC r357750: Mount /dev while deinstalling pkg inside EC2 AMIs.
Feb 25 2020, 12:37 AM
cperciva committed rS358302: MFC r357749: Remove /qemu from EC2 ARM AMIs..
MFC r357749: Remove /qemu from EC2 ARM AMIs.
Feb 25 2020, 12:36 AM

Feb 14 2020

cperciva committed rS357901: MFC r353022:.
MFC r353022:
Feb 14 2020, 2:31 AM

Feb 11 2020

cperciva committed rS357750: Mount /dev while deinstalling pkg inside EC2 AMIs..
Mount /dev while deinstalling pkg inside EC2 AMIs.
Feb 11 2020, 4:06 AM
cperciva committed rS357749: Remove /qemu from EC2 ARM AMIs.
Remove /qemu from EC2 ARM AMIs
Feb 11 2020, 4:03 AM

Jan 27 2020

cperciva committed rP524248: Add imds-filterd..
Add imds-filterd.
Jan 27 2020, 9:01 AM

Jan 26 2020

cperciva created D23374: [new port] security/imds-filterd.
Jan 26 2020, 9:40 PM

Nov 2 2019

cperciva committed rP516361: MFH: r516289.
MFH: r516289
Nov 2 2019, 6:09 PM
cperciva committed rP516289: Add -rdynamic to ezmlm-idx's conf-ld. This flag was added in ezmlm-idx.
Add -rdynamic to ezmlm-idx's conf-ld. This flag was added in ezmlm-idx
Nov 2 2019, 7:24 AM

Oct 9 2019

cperciva added a comment to D21948: Support hotplug of PCI devices on EC2..

I wonder... if we add a "hw.pci.acpi_hotplug" boot tunable and check it in acpi_pci_{attach,detach} before doing anything, could we get this merged for 12.1? I would turn that tunable on in EC2 AMIs (since I've tested it there) but we could leave it turned off by default elsewhere.

Oct 9 2019, 10:21 PM
cperciva accepted D21948: Support hotplug of PCI devices on EC2..

This is now working perfectly in my tests on EC2. When I attach a disk it shows up immediately; when I detach a disk it goes away from FreeBSD and EC2 recognizes that it has successfully detached (and without needing a "force detach"); and I can cycle the same disk attached/detached many times without issues.

Oct 9 2019, 10:14 PM
cperciva added a comment to D21948: Support hotplug of PCI devices on EC2..

With the above changes (s/ACPI_NOTIFY_DEVICE_EJECT_REQUEST/ACPI_NOTIFY_EJECT_REQUEST/ and s/handle/h/) I can attach a disk and detach it, but I get

Oct 9 2019, 8:48 PM
cperciva added a comment to D21948: Support hotplug of PCI devices on EC2..

Patch does not compile.

Oct 9 2019, 8:35 PM
cperciva added a comment to D21948: Support hotplug of PCI devices on EC2..

I can now attach a disk:

Oct 9 2019, 12:54 AM

Oct 8 2019

cperciva added a comment to D21948: Support hotplug of PCI devices on EC2..

Thanks, with that fix the Notify handler is getting called:

Oct 8 2019, 11:54 PM
cperciva added a comment to D21948: Support hotplug of PCI devices on EC2..

With an added printf I see:

Oct 8 2019, 11:21 PM
cperciva added a comment to D21948: Support hotplug of PCI devices on EC2..

Running with

Oct 8 2019, 10:38 PM

Oct 2 2019

cperciva committed rS353022: Switch EC2 AMIs from using the dual-dhclient script to using the new.
Switch EC2 AMIs from using the dual-dhclient script to using the new
Oct 2 2019, 9:35 PM
cperciva committed rP513630: Add net/dual-dhclient-daemon port..
Add net/dual-dhclient-daemon port.
Oct 2 2019, 9:31 PM

Sep 19 2019

cperciva added a comment to D21579: freebsd-update: Fix src component detection.

Yeah, that's a good point. Also "config_Components_src" would get called if someone has a line in freebsd-update.conf starting with "Components_src" which is not what we want (it should be an error).

Sep 19 2019, 11:22 AM

Sep 14 2019

cperciva abandoned D21653: scrypt 1.3.0.
Sep 14 2019, 7:42 PM

Sep 13 2019

cperciva committed rP511993: Update to 1.3.0. This adds a libscrypt-kdf header and shared library..
Update to 1.3.0. This adds a libscrypt-kdf header and shared library.
Sep 13 2019, 10:29 PM
cperciva created D21653: scrypt 1.3.0.
Sep 13 2019, 10:17 PM

Jun 27 2019

cperciva added inline comments to D20780: Add support for getting early entropy from the UEFI RNG protocol.
Jun 27 2019, 11:59 PM · security, arm64
cperciva added inline comments to D20780: Add support for getting early entropy from the UEFI RNG protocol.
Jun 27 2019, 4:58 PM · security, arm64