Page MenuHomeFreeBSD

cperciva (Colin Percival)
User

Projects

User Details

User Since
Jun 3 2014, 6:45 PM (267 w, 1 d)

Recent Activity

Thu, Jun 27

cperciva added inline comments to D20780: Add support for getting early entropy from the UEFI RNG protocol.
Thu, Jun 27, 11:59 PM · security, arm64
cperciva added inline comments to D20780: Add support for getting early entropy from the UEFI RNG protocol.
Thu, Jun 27, 4:58 PM · security, arm64

Jun 15 2019

cperciva committed rS349079: MFC r348681: Only respond to the PCIe Attention Button if a device is.
MFC r348681: Only respond to the PCIe Attention Button if a device is
Jun 15 2019, 8:26 PM
cperciva committed rS349078: MFC r347370: Bump EC2 AMI filesystem size up to 4000 MB..
MFC r347370: Bump EC2 AMI filesystem size up to 4000 MB.
Jun 15 2019, 8:24 PM

Jun 5 2019

cperciva committed rS348681: Only respond to the PCIe Attention Button if a device is already plugged in..
Only respond to the PCIe Attention Button if a device is already plugged in.
Jun 5 2019, 4:58 AM
cperciva closed D20499: Only respond to Attention Button if device is already plugged in.
Jun 5 2019, 4:58 AM

Jun 3 2019

cperciva added inline comments to D20499: Only respond to Attention Button if device is already plugged in.
Jun 3 2019, 9:40 PM
cperciva updated the diff for D20499: Only respond to Attention Button if device is already plugged in.

Moved test to the !PCIB_DETACH_PENDING case and added an explanatory comment.

Jun 3 2019, 9:39 PM
cperciva created D20499: Only respond to Attention Button if device is already plugged in.
Jun 3 2019, 12:37 AM

May 28 2019

cperciva committed rS348342: MFC r345405,345406,346228,346657,348195,348198: UART SPCR fixes..
MFC r345405,345406,346228,346657,348195,348198: UART SPCR fixes.
May 28 2019, 10:22 PM

May 23 2019

cperciva committed rS348195: Use ACPI SPCR on x86.
Use ACPI SPCR on x86
May 23 2019, 7:56 PM
cperciva closed D20357: Use ACPI SPCR on x86.
May 23 2019, 7:56 PM
cperciva added inline comments to D20357: Use ACPI SPCR on x86.
May 23 2019, 5:35 PM

May 22 2019

cperciva added a comment to D20357: Use ACPI SPCR on x86.

Patch also available at https://github.com/cperciva/freebsd/tree/spcr

May 22 2019, 7:03 PM
cperciva created D20357: Use ACPI SPCR on x86.
May 22 2019, 6:11 PM

May 16 2019

cperciva committed rP501759: Update amazon-ssm-agent to 2.3.612.0..
Update amazon-ssm-agent to 2.3.612.0.
May 16 2019, 1:10 AM

May 8 2019

cperciva committed rS347370: Bump EC2 AMI filesystem size up to 4000 MB..
Bump EC2 AMI filesystem size up to 4000 MB.
May 8 2019, 9:03 PM

Apr 27 2019

cperciva committed rS346793: MFC r345407,r345408: Add nvme to arm64 GENERIC, and build if_ena on arm64..
MFC r345407,r345408: Add nvme to arm64 GENERIC, and build if_ena on arm64.
Apr 27 2019, 7:48 PM
cperciva committed rS346792: On non-x86 systems, use "quarterly" packages..
On non-x86 systems, use "quarterly" packages.
Apr 27 2019, 7:45 PM
cperciva committed rS346780: MFC r346628: Split the pkg configuration file FreeBSD.conf into versions.
MFC r346628: Split the pkg configuration file FreeBSD.conf into versions
Apr 27 2019, 4:01 AM

Apr 24 2019

cperciva committed rS346628: Keep two versions of the FreeBSD.conf pkg configuration file; one which.
Keep two versions of the FreeBSD.conf pkg configuration file; one which
Apr 24 2019, 6:25 AM

Apr 18 2019

cperciva committed rS346340: Fix cross-building VMs with a non-/usr/src source directory..
Fix cross-building VMs with a non-/usr/src source directory.
Apr 18 2019, 12:39 AM

Apr 17 2019

cperciva committed rS346309: MFC r345316, r345317, r345858:.
MFC r345316, r345317, r345858:
Apr 17 2019, 12:35 PM
cperciva committed rS346308: MFC r345316, r345317, r345858:.
MFC r345316, r345317, r345858:
Apr 17 2019, 7:47 AM

Apr 3 2019

cperciva committed rS345858: Add support for cross-building cloudware images..
Add support for cross-building cloudware images.
Apr 3 2019, 9:54 PM

Mar 22 2019

cperciva closed D19657: Enable NVMe on aarch64.
Mar 22 2019, 6:36 AM · arm64
cperciva committed rS345408: Add nvme support to the arm64 GENERIC kernel..
Add nvme support to the arm64 GENERIC kernel.
Mar 22 2019, 6:36 AM
cperciva committed rS345407: Build if_ena.ko on arm64..
Build if_ena.ko on arm64.
Mar 22 2019, 6:33 AM
cperciva committed rS345406: Initialize uart_bus_space_mem..
Initialize uart_bus_space_mem.
Mar 22 2019, 6:28 AM
cperciva committed rS345405: Obey SPCR AccessWidth parameter..
Obey SPCR AccessWidth parameter.
Mar 22 2019, 6:21 AM

Mar 21 2019

cperciva committed rS345369: Recognize the Amazon PCI serial device found in a1.* EC2 instances.
Recognize the Amazon PCI serial device found in a1.* EC2 instances
Mar 21 2019, 8:54 AM
cperciva added a comment to D19641: Add bus_release_resource() method to nexus on arm64.

Works for me. Please commit, unless anyone more familiar with ARMy things says there's a reason why this code was missing...

Mar 21 2019, 4:08 AM · arm64
cperciva added a comment to D19655: Do not activate admin interrupt in ENA.

Works in my testing. Please commit.

Mar 21 2019, 4:06 AM · network

Mar 20 2019

cperciva added a comment to D19657: Enable NVMe on aarch64.

Aside from the whitespace issue, I'm ready to commit this unless any of the arm-y people object.

Mar 20 2019, 6:00 PM · arm64
cperciva committed rS345317: Only install amazon-ssm-agent into amd64 AMIs..
Only install amazon-ssm-agent into amd64 AMIs.
Mar 20 2019, 7:24 AM
cperciva committed rS345316: Pass --arm64 to bsdec2-image-upload when building ARM64 AMIs..
Pass --arm64 to bsdec2-image-upload when building ARM64 AMIs.
Mar 20 2019, 7:19 AM
cperciva committed rP496311: Update bsdec2-image-upload to version 1.2.2..
Update bsdec2-image-upload to version 1.2.2.
Mar 20 2019, 6:19 AM

Feb 26 2019

cperciva committed rS344563: MFC r344315:.
MFC r344315:
Feb 26 2019, 5:38 AM
cperciva committed rS344557: MFC r344315:.
MFC r344315:
Feb 26 2019, 1:30 AM

Feb 19 2019

cperciva committed rS344315: Fix sed script to insert Amazon NTP server into ntp.conf once rather.
Fix sed script to insert Amazon NTP server into ntp.conf once rather
Feb 19 2019, 11:24 PM

Feb 16 2019

cperciva committed rS344210: MFC r343918: Teach /etc/rc.d/growfs how to handle systems running ZFS..
MFC r343918: Teach /etc/rc.d/growfs how to handle systems running ZFS.
Feb 16 2019, 9:50 AM

Feb 8 2019

cperciva committed rS343918: Teach /etc/rc.d/growfs how to handle systems running ZFS..
Teach /etc/rc.d/growfs how to handle systems running ZFS.
Feb 8 2019, 7:19 PM
cperciva closed D19095: Teach /etc/rc.d/growfs to handle disks with ZFS.
Feb 8 2019, 7:19 PM

Feb 7 2019

cperciva added a comment to D19095: Teach /etc/rc.d/growfs to handle disks with ZFS.

Updated patch, using a case statement instead of if/elif/else.

Feb 7 2019, 7:56 PM
cperciva updated the diff for D19095: Teach /etc/rc.d/growfs to handle disks with ZFS.

Use case statements to select between filesystem types.

Feb 7 2019, 7:56 PM
cperciva added a comment to D19095: Teach /etc/rc.d/growfs to handle disks with ZFS.

You're right that this doesn't handle multi-disk situations -- but it really isn't intended to, and the script currently doesn't handle those for UFS either. In an ideal world it would probably know how to grow GELI encrypted disks too, for that matter... but my goal right now is simply to provide "feature parity" between ZFS and UFS, i.e., to handle the case of a single unencrypted disk.

Feb 7 2019, 9:24 AM
cperciva created D19095: Teach /etc/rc.d/growfs to handle disks with ZFS.
Feb 7 2019, 1:41 AM

Jan 16 2019

cperciva committed rS343070: MFC r342875: Turn off ec2_ephemeralswap for now.
MFC r342875: Turn off ec2_ephemeralswap for now
Jan 16 2019, 1:33 AM

Jan 9 2019

cperciva committed rS342875: Turn off ec2_ephemeralswap for now.
Turn off ec2_ephemeralswap for now
Jan 9 2019, 3:55 AM

Oct 30 2018

cperciva committed rS339903: Unbreak FreeBSD Update mirroring code for OpenSSL 1.1.
Unbreak FreeBSD Update mirroring code for OpenSSL 1.1
Oct 30 2018, 1:39 AM

Sep 24 2018

cperciva committed rS338921: Recognize the Amazon PCI serial device found in i3.metal EC2 instances.
Recognize the Amazon PCI serial device found in i3.metal EC2 instances
Sep 24 2018, 10:15 PM
cperciva closed D17250: Add support for EC2 i3.metal serial port.
Sep 24 2018, 10:15 PM

Sep 19 2018

cperciva added reviewers for D17250: Add support for EC2 i3.metal serial port: imp, mmacy, sbruno, emaste.

Adding some reviewers who have touched this recently and may be able to tell me if I'm doing this right and/or what I'm missing.

Sep 19 2018, 9:28 PM
cperciva created D17250: Add support for EC2 i3.metal serial port.
Sep 19 2018, 9:26 PM

Sep 7 2018

cperciva accepted D17061: ix(4), ixv(4): Add VLAN tag strip check when receiving packets; ixv(4): Fix support for VLAN_HWTAGGING and VLAN_HWFILTER flags.

Works in all of my testing. Please commit!

Sep 7 2018, 6:32 PM · Intel Networking

Sep 6 2018

cperciva added a comment to D17013: xen: fix setting vcpu id for APs.

Awesome, this fixes the boot on all the EC2 instances I've tried. Please commit!

Sep 6 2018, 6:35 PM
cperciva added a comment to D17013: xen: fix setting vcpu id for APs.

Hmm, I guess filling in vcpu_id after xen_hvm_cpu_init returns won't work, since we use that value in the "Set the vCPU info." code at the end of that function.

Sep 6 2018, 12:25 PM
cperciva added a comment to D17013: xen: fix setting vcpu id for APs.

Still doesn't work. We have a chicken-and-egg problem between launching CPUs and recording their IDs, it seems...

Sep 6 2018, 12:24 PM
cperciva added a comment to D17013: xen: fix setting vcpu id for APs.

I wonder, can we make this work by changing the lines

Sep 6 2018, 12:24 PM

Sep 4 2018

cperciva added a comment to D17013: xen: fix setting vcpu id for APs.

Hmm, I agree that it looks like this *should* fix the problem, but I'm still seeing the instance hang waiting for TLB shootdown IPIs to complete. Maybe there's something else going on here.

Sep 4 2018, 6:38 PM

Aug 26 2018

cperciva committed rS338323: MFC r336420,336433,336593,336621,336622,336624,337394,337401,338141.
MFC r336420,336433,336593,336621,336622,336624,337394,337401,338141
Aug 26 2018, 5:28 AM
cperciva committed rS338322: MFC r336420,336433,336593,336621,336622,336624,337394,337401,338141.
MFC r336420,336433,336593,336621,336622,336624,337394,337401,338141
Aug 26 2018, 4:33 AM
cperciva committed rS338321: Disable atkbd0 and atkdbc0 in EC2 AMIs. This has the effect of skipping.
Disable atkbd0 and atkdbc0 in EC2 AMIs. This has the effect of skipping
Aug 26 2018, 3:57 AM

Aug 25 2018

cperciva committed rS338316: Speed up vt(4) by keeping a record of the most recently drawn character and.
Speed up vt(4) by keeping a record of the most recently drawn character and
Aug 25 2018, 4:15 PM
cperciva closed D16723: Cache the most recently drawn text on vt and don't re-draw it.
Aug 25 2018, 4:15 PM

Aug 21 2018

cperciva added inline comments to D16723: Cache the most recently drawn text on vt and don't re-draw it.
Aug 21 2018, 6:06 PM
cperciva committed rS338141: Quieten the svn (or svnlite) commands used to extract information from an.
Quieten the svn (or svnlite) commands used to extract information from an
Aug 21 2018, 3:30 PM

Aug 17 2018

cperciva added a comment to D16723: Cache the most recently drawn text on vt and don't re-draw it.

On my laptop, this cuts the time spent in _vprintf during the kernel boot from 970 ms down to 155 ms.

Aug 17 2018, 10:01 AM

Aug 15 2018

cperciva created D16723: Cache the most recently drawn text on vt and don't re-draw it.
Aug 15 2018, 3:42 PM

Aug 7 2018

cperciva committed rS337411: Replace a pair of 8-bit writes to VGA memory with a single 16-bit write..
Replace a pair of 8-bit writes to VGA memory with a single 16-bit write.
Aug 7 2018, 8:33 AM
cperciva committed rS337401: Fix copy-and-paste error in previous commit..
Fix copy-and-paste error in previous commit.
Aug 7 2018, 12:52 AM

Aug 6 2018

cperciva committed rS337394: Add EC2PUBLICSNAP option to EC2 builds; this passes a (recently added).
Add EC2PUBLICSNAP option to EC2 builds; this passes a (recently added)
Aug 6 2018, 7:21 PM

Aug 1 2018

cperciva committed rP476203: Update to version 1.2.1. This brings two changes:.
Update to version 1.2.1. This brings two changes:
Aug 1 2018, 10:06 PM

Jul 21 2018

cperciva committed rS336593: Use svn or svnlite, or ${SVN_CMD} if set, for extracting the SVN branch.
Use svn or svnlite, or ${SVN_CMD} if set, for extracting the SVN branch
Jul 21 2018, 10:55 PM

Jul 17 2018

cperciva committed rS336433: Check that EC2SNSTOPIC and EC2PUBLIC are non-empty, along with being.
Check that EC2SNSTOPIC and EC2PUBLIC are non-empty, along with being
Jul 17 2018, 11:16 PM
cperciva committed rS336420: Teach EC2 AMI release code to send an SNS notification after publishing.
Teach EC2 AMI release code to send an SNS notification after publishing
Jul 17 2018, 7:05 PM
cperciva committed rP474781: Update bsdec2-image-upload to version 1.2..
Update bsdec2-image-upload to version 1.2.
Jul 17 2018, 7:37 AM

Jul 1 2018

cperciva committed rP473645: Update to 1.1. Add dependency on devel/gdb for FreeBSD versions which.
Update to 1.1. Add dependency on devel/gdb for FreeBSD versions which
Jul 1 2018, 12:12 AM
cperciva committed rS335829: Add /usr/local/bin to $PATH so that panicmail can use gdb from ports..
Add /usr/local/bin to $PATH so that panicmail can use gdb from ports.
Jul 1 2018, 12:07 AM

Jun 30 2018

cperciva committed rS335828: MFC r335553: Make CLOCK_PROCESS_CPUTIME_ID more accurate by including.
MFC r335553: Make CLOCK_PROCESS_CPUTIME_ID more accurate by including
Jun 30 2018, 9:36 PM

Jun 24 2018

cperciva committed rP473189: Update bsdec2-image-upload to version 1.1.4..
Update bsdec2-image-upload to version 1.1.4.
Jun 24 2018, 8:46 AM

Jun 22 2018

cperciva committed rS335553: Improve the accuracy of the POSIX "process CPU-time" clocks by adding the.
Improve the accuracy of the POSIX "process CPU-time" clocks by adding the
Jun 22 2018, 10:23 AM

Apr 25 2018

cperciva committed rS332982: MFC r332663: Move panic-related settings from sysctl.conf to loader.conf so.
MFC r332663: Move panic-related settings from sysctl.conf to loader.conf so
Apr 25 2018, 1:54 AM

Apr 23 2018

cperciva added a comment to D15153: Add device_quiet_children() and device_has_quiet_children().

Tested on EC2 x1.32xlarge (72 CPUs) and c5.18xlarge (128 CPUs) instances. Aside from making the console output far less verbose, the c5.18xlarge kernel boot time (measured from entering hammer_time to when init enters userland) dropped from 18.78 s to 11.75 s, and the x1.32xlarge kernel boot time dropped from 45.71 s to 36.33 s.

Apr 23 2018, 8:15 PM

Apr 21 2018

cperciva added a comment to D15153: Add device_quiet_children() and device_has_quiet_children().

Works for me. Two minor questions about the code (see comments inline).

Apr 21 2018, 11:14 PM

Apr 18 2018

cperciva committed rS332663: Move debug.{trace,debugger}_on_panic and kern.panic_reboot_wait_time in.
Move debug.{trace,debugger}_on_panic and kern.panic_reboot_wait_time in
Apr 18 2018, 5:58 AM

Mar 5 2018

cperciva added a comment to D14500: Implement getrandom(2) and getentropy(3).

Not looking at the code, but on the design front:

Mar 5 2018, 10:07 PM

Mar 4 2018

cperciva committed rS330417: MFC r320367: Add "Terminus BSD Console" size 32.
MFC r320367: Add "Terminus BSD Console" size 32
Mar 4 2018, 9:59 PM

Feb 28 2018

cperciva added a comment to D14275: Add pkg_bootstrap firstboot script..

Absolutely fine with me. When I wrote this (and also firstboot-freebsd-update) I was anticipating that it might end up in the base system if people found it useful -- I have a long history of using the ports tree as a staging area like this. :-)

Feb 28 2018, 8:36 PM

Feb 9 2018

cperciva added a comment to D14275: Add pkg_bootstrap firstboot script..

You're aware of sysutils/firstboot-pkgs in the ports tree, right? Wouldn't it make sense to migrate that into the base system rather than adding a new script?

Feb 9 2018, 9:20 AM

Dec 31 2017

cperciva committed rS327447: Wrap includes in sys/tslog.h with #ifdef TSLOG..
Wrap includes in sys/tslog.h with #ifdef TSLOG.
Dec 31 2017, 9:00 PM
cperciva committed rS327432: Use the TSLOG framework to record entry/exit timestamps for DELAY and.
Use the TSLOG framework to record entry/exit timestamps for DELAY and
Dec 31 2017, 9:24 AM
cperciva committed rS327431: Instrument thread creations for the the benefit of the TSLOG framework..
Instrument thread creations for the the benefit of the TSLOG framework.
Dec 31 2017, 9:24 AM
cperciva committed rS327430: Instrument "boot holds" for the benefit of the TSLOG framework. These.
Instrument "boot holds" for the benefit of the TSLOG framework. These
Dec 31 2017, 9:24 AM
cperciva committed rS327429: Use the TSLOG framework to record entry/exit timestamps for VFS_MOUNT calls..
Use the TSLOG framework to record entry/exit timestamps for VFS_MOUNT calls.
Dec 31 2017, 9:23 AM
cperciva committed rS327428: Teach makeobjops.awk to accept PROLOG and EPILOG blocks before.
Teach makeobjops.awk to accept PROLOG and EPILOG blocks before
Dec 31 2017, 9:23 AM
cperciva committed rS327427: Use the TSLOG framework to record SYSINIT entry/exit timestamps..
Use the TSLOG framework to record SYSINIT entry/exit timestamps.
Dec 31 2017, 9:23 AM
cperciva committed rS327426: Use the TSLOG framework to record entry/exit timestamps for machine.
Use the TSLOG framework to record entry/exit timestamps for machine
Dec 31 2017, 9:22 AM
cperciva committed rS327425: Use the TSLOG framework to record entry/exit timestamps for hammer_time..
Use the TSLOG framework to record entry/exit timestamps for hammer_time.
Dec 31 2017, 9:22 AM
cperciva committed rS327424: Connect kern_tslog.c to the build and add TSLOG / TSLOGSIZE kernel options..
Connect kern_tslog.c to the build and add TSLOG / TSLOGSIZE kernel options.
Dec 31 2017, 9:21 AM