Page MenuHomeFreeBSD

cperciva (Colin Percival)
User

Projects

User Details

User Since
Jun 3 2014, 6:45 PM (415 w, 4 d)

Recent Activity

Mon, May 2

cperciva added a comment to D35109: freebsd-update: restart sshd after upgrade.

Right. The only time I have ever seen sshd terminate an active connection is when reloading pf(4) rules or restarting pf(4).

Mon, May 2, 6:36 PM
cperciva added a comment to D35109: freebsd-update: restart sshd after upgrade.

Thanks! I was having nightmares of ssh sessions being terminated and leaving people with half-upgraded systems which they couldn't ssh into.

Mon, May 2, 6:34 PM
cperciva added a comment to D35109: freebsd-update: restart sshd after upgrade.

Dumb question, I'm sure, but doesn't restarting sshd kill current ssh sessions?

Mon, May 2, 6:25 PM

Apr 18 2022

cperciva abandoned D34951: bmake: Only handle .POSIX: in the right place.

Never mind, NetBSD already has a fix for this: https://github.com/NetBSD/src/commit/686b9d31508b5cf03b7362f4e2f8a28d78bef7d8

Apr 18 2022, 9:36 PM
cperciva requested review of D34951: bmake: Only handle .POSIX: in the right place.
Apr 18 2022, 9:34 PM

Apr 12 2022

cperciva committed R10:0967f7030c67: Install the recently added posix.mk file (authored by cperciva).
Install the recently added posix.mk file
Apr 12 2022, 8:07 PM
cperciva committed R11:4364cf0fef39: security/Makefile: add py-yara-python-dex (authored by cperciva).
security/Makefile: add py-yara-python-dex
Apr 12 2022, 7:30 PM

Apr 5 2022

cperciva committed R10:ce528519ec6e: uart(4): Add a concept of "unique" serial devices (authored by cperciva).
uart(4): Add a concept of "unique" serial devices
Apr 5 2022, 1:33 PM

Apr 4 2022

cperciva committed R10:5cc5cd739ef1: uart(4): Add a concept of "unique" serial devices (authored by cperciva).
uart(4): Add a concept of "unique" serial devices
Apr 4 2022, 7:13 PM
cperciva committed R10:7d160dc9a1a2: sysctl(8): Mention CTLFLAG_SKIP (authored by cperciva).
sysctl(8): Mention CTLFLAG_SKIP
Apr 4 2022, 7:12 PM
cperciva committed R10:794e30fcfe2b: tslog: Add CTLFLAG_SKIP to sysctls (authored by cperciva).
tslog: Add CTLFLAG_SKIP to sysctls
Apr 4 2022, 7:12 PM

Mar 31 2022

cperciva committed R10:ad93649d2304: uart(4): Add a concept of "unique" serial devices (authored by cperciva).
uart(4): Add a concept of "unique" serial devices
Mar 31 2022, 11:03 PM
cperciva closed D34703: uart(4): Add a concept of "unique" serial devices.
Mar 31 2022, 11:02 PM
cperciva added a comment to D34703: uart(4): Add a concept of "unique" serial devices.

Thanks!

Mar 31 2022, 11:01 PM
cperciva updated the diff for D34703: uart(4): Add a concept of "unique" serial devices.

Updated to add comments, use the table size instead of a sentinel,
and eliminate an unnecessary 'valid' flag.

Mar 31 2022, 1:57 AM
cperciva added inline comments to D34703: uart(4): Add a concept of "unique" serial devices.
Mar 31 2022, 1:55 AM

Mar 30 2022

cperciva added inline comments to D34703: uart(4): Add a concept of "unique" serial devices.
Mar 30 2022, 5:49 AM

Mar 29 2022

cperciva added a comment to D34703: uart(4): Add a concept of "unique" serial devices.

Third try. It's a bit hacky, but in discussions with EC2 folks it sounds like this is the best way to identify that the UART we discovered is the console we configured from SPCR.

Mar 29 2022, 8:00 AM
cperciva added a reviewer for D34703: uart(4): Add a concept of "unique" serial devices: greg_unrelenting.technology.
Mar 29 2022, 7:59 AM
cperciva requested review of D34703: uart(4): Add a concept of "unique" serial devices.
Mar 29 2022, 7:59 AM

Mar 20 2022

cperciva closed D34615: sysctl(8): Mention CTLFLAG_SKIP.
Mar 20 2022, 6:32 PM
cperciva closed D34616: tslog: Add CTLFLAG_SKIP to sysctls.
Mar 20 2022, 6:32 PM
cperciva committed R10:1dee7c74d1ab: sysctl(8): Mention CTLFLAG_SKIP (authored by cperciva).
sysctl(8): Mention CTLFLAG_SKIP
Mar 20 2022, 6:32 PM
cperciva committed R10:2406867f5b17: tslog: Add CTLFLAG_SKIP to sysctls (authored by cperciva).
tslog: Add CTLFLAG_SKIP to sysctls
Mar 20 2022, 6:32 PM
cperciva updated the diff for D34615: sysctl(8): Mention CTLFLAG_SKIP.

Add missing .Dd bump

Mar 20 2022, 6:11 PM
cperciva updated the diff for D34615: sysctl(8): Mention CTLFLAG_SKIP.

Use .Dv

Mar 20 2022, 6:09 PM
cperciva requested review of D34616: tslog: Add CTLFLAG_SKIP to sysctls.
Mar 20 2022, 5:45 PM
cperciva requested review of D34615: sysctl(8): Mention CTLFLAG_SKIP.
Mar 20 2022, 5:45 PM

Mar 14 2022

cperciva committed R10:de4045353b14: Add support for getting early entropy from UEFI (authored by cperciva).
Add support for getting early entropy from UEFI
Mar 14 2022, 9:27 PM

Mar 11 2022

cperciva committed R10:dd6c1475a63a: Add support for getting early entropy from UEFI (authored by cperciva).
Add support for getting early entropy from UEFI
Mar 11 2022, 2:13 AM

Mar 4 2022

cperciva accepted D34430: tslog.4: Document TSLOG.

Approved with src-committer hat.

Mar 4 2022, 7:29 PM

Mar 3 2022

cperciva added inline comments to D34430: tslog.4: Document TSLOG.
Mar 3 2022, 9:49 PM

Feb 28 2022

cperciva accepted D34400: release: Remove references to ChallengeResponseAuthentication.

Thanks for catching this!

Feb 28 2022, 11:10 PM
cperciva committed R11:3f3b9dcc128b: sysutils/tarsnap: Enable zsh completion (authored by cperciva).
sysutils/tarsnap: Enable zsh completion
Feb 28 2022, 8:21 PM

Feb 25 2022

cperciva added a comment to D34367: x86: Probe the TSC frequency earlier.

If the concern is systems where the i8254 doesn't work, should we change tsc_freq_8254 to be more robust?

On such systems we aren't using the 8254 to calibrate the TSC at all, we get the frequency, or something close to it, from CPUID leaves.

Feb 25 2022, 2:00 AM

Feb 24 2022

cperciva added a comment to D34367: x86: Probe the TSC frequency earlier.

If the concern is systems where the i8254 doesn't work, should we change tsc_freq_8254 to be more robust?

Feb 24 2022, 9:26 PM

Feb 17 2022

cperciva closed D20780: Add support for getting early entropy from the UEFI RNG protocol.
Feb 17 2022, 9:12 PM · csprng, security, arm64
cperciva committed R10:5c73b3e0a3db: Add support for getting early entropy from UEFI (authored by cperciva).
Add support for getting early entropy from UEFI
Feb 17 2022, 9:12 PM
cperciva added a comment to D20780: Add support for getting early entropy from the UEFI RNG protocol.

I'll do the commit. Thanks to Greg for writing this and to everyone who helped to review it!

Feb 17 2022, 9:11 PM · csprng, security, arm64

Feb 16 2022

cperciva added a comment to D34294: Use PCI bus+slot for matching UARTs to consoles.

Thanks Warner! I wasn't sure that this was the right approach, and now I'm even more doubtful.

Feb 16 2022, 7:44 AM
cperciva added a comment to D20780: Add support for getting early entropy from the UEFI RNG protocol.

Is this ready to be committed? I'm happy to do it myself but markm said he was going to commit (prior to the latest round of changes) -- don't want to commit prematurely if you're still waiting for something.

Feb 16 2022, 12:50 AM · csprng, security, arm64
cperciva added a comment to D34294: Use PCI bus+slot for matching UARTs to consoles.

This is inspired by D19896, but I moved the matching from uart_bus_pci.c into uart_core.c to join the existing uart/console matching code. I also dropped the PCI VendorId / DeviceId since I don't think they're needed, and added a 'valid' field to the PCI data struct to avoid problems if we have a uart in slot #0 of bus #0.

Feb 16 2022, 12:46 AM
cperciva added reviewers for D34294: Use PCI bus+slot for matching UARTs to consoles: greg_unrelenting.technology, imp, andrew.
Feb 16 2022, 12:44 AM
cperciva requested review of D34294: Use PCI bus+slot for matching UARTs to consoles.
Feb 16 2022, 12:43 AM

Feb 12 2022

cperciva committed R11:f87d559e09c8: sysutils/tarsnap: Update to 1.0.40 (authored by cperciva).
sysutils/tarsnap: Update to 1.0.40
Feb 12 2022, 8:31 PM

Feb 11 2022

cperciva committed R10:baee6cc1814b: x86: Speed up clock calibration (authored by cperciva).
x86: Speed up clock calibration
Feb 11 2022, 6:52 AM
cperciva committed R10:51e77b34e4bf: TSC: Use 0x40000010 CPUID leaf for all VM types (authored by cperciva).
TSC: Use 0x40000010 CPUID leaf for all VM types
Feb 11 2022, 6:52 AM
cperciva committed R10:a605a66017ec: Use CPUID leaf 0x40000010 for local APIC freq (authored by cperciva).
Use CPUID leaf 0x40000010 for local APIC freq
Feb 11 2022, 6:52 AM
cperciva committed R10:eb28df303b06: Detect CPU type before asking VMWare for TSC freq (authored by cperciva).
Detect CPU type before asking VMWare for TSC freq
Feb 11 2022, 6:52 AM

Jan 20 2022

cperciva accepted D33956: clockcalib: Fix an overflow bug.

Oops! Thanks for catching this.

Jan 20 2022, 5:49 AM

Jan 16 2022

cperciva committed R10:a04376045ddb: Fix variable name: freq_khz -> freq (authored by cperciva).
Fix variable name: freq_khz -> freq
Jan 16 2022, 5:35 AM
cperciva committed R10:7299cefe3949: Skip TSC calibration if exact value known (authored by cperciva).
Skip TSC calibration if exact value known
Jan 16 2022, 5:35 AM

Jan 15 2022

cperciva added a comment to D20780: Add support for getting early entropy from the UEFI RNG protocol.

Thanks! Can you also MFC it to stable/13 after a week?

Jan 15 2022, 5:48 PM · csprng, security, arm64
cperciva closed D33893: Detect CPU type before asking VMWare for TSC freq.

Committed. (I forgot to include the Differential Revision tag in the commit message.)

Jan 15 2022, 1:32 AM
cperciva closed D33894: TSC: Use 0x40000010 CPUID leaf for all VM types.

Committed. (I forgot to include the Differential Revision tag in the commit message.)

Jan 15 2022, 1:32 AM
cperciva closed D33895: Use CPUID leaf 0x40000010 for local APIC freq.

Committed. (I forgot to include the Differential Revision tag in the commit message.)

Jan 15 2022, 1:32 AM
cperciva committed R10:de1292c6ff8a: Use CPUID leaf 0x40000010 for local APIC freq (authored by cperciva).
Use CPUID leaf 0x40000010 for local APIC freq
Jan 15 2022, 1:31 AM
cperciva committed R10:4a432614f68c: TSC: Use 0x40000010 CPUID leaf for all VM types (authored by cperciva).
TSC: Use 0x40000010 CPUID leaf for all VM types
Jan 15 2022, 1:31 AM
cperciva committed R10:fd980feb574d: Detect CPU type before asking VMWare for TSC freq (authored by cperciva).
Detect CPU type before asking VMWare for TSC freq
Jan 15 2022, 1:31 AM

Jan 14 2022

Herald added a reviewer for D20780: Add support for getting early entropy from the UEFI RNG protocol: manu.

Is this waiting for anything else before it gets committed?

Jan 14 2022, 10:14 PM · csprng, security, arm64
cperciva added inline comments to D33894: TSC: Use 0x40000010 CPUID leaf for all VM types.
Jan 14 2022, 9:48 PM
cperciva added inline comments to D33895: Use CPUID leaf 0x40000010 for local APIC freq.
Jan 14 2022, 9:48 PM
cperciva updated the diff for D33895: Use CPUID leaf 0x40000010 for local APIC freq.

Fix overflow bug

Jan 14 2022, 9:47 PM
cperciva updated the diff for D33894: TSC: Use 0x40000010 CPUID leaf for all VM types.

Fix overflow bug

Jan 14 2022, 9:47 PM
cperciva abandoned D24256: Avoid concurrent nvme_qpair_process_completions runs.

Overcome by events.

Jan 14 2022, 6:34 AM
cperciva abandoned D32758: Speed up tsc_calib.

Reworked as D33802, which has now been committed.

Jan 14 2022, 6:34 AM
cperciva requested review of D33895: Use CPUID leaf 0x40000010 for local APIC freq.
Jan 14 2022, 6:32 AM
cperciva requested review of D33894: TSC: Use 0x40000010 CPUID leaf for all VM types.
Jan 14 2022, 6:32 AM
cperciva requested review of D33893: Detect CPU type before asking VMWare for TSC freq.
Jan 14 2022, 6:32 AM

Jan 12 2022

cperciva committed R10:c2705ceaeb09: x86: Speed up clock calibration (authored by cperciva).
x86: Speed up clock calibration
Jan 12 2022, 8:37 PM
cperciva closed D33802: x86: Speed up clock calibration.
Jan 12 2022, 8:37 PM
cperciva committed R10:72f61780a47d: vfs_mountroot: Wait for GEOM idle post root holds (authored by cperciva).
vfs_mountroot: Wait for GEOM idle post root holds
Jan 12 2022, 7:31 PM
cperciva committed R10:972796d007c2: vfs_mountroot: Check for root dev before waiting (authored by cperciva).
vfs_mountroot: Check for root dev before waiting
Jan 12 2022, 7:31 PM
cperciva committed R10:d4724934f2e4: vfs_mountroot: Skip 'Root mount waiting' < 1 s (authored by cperciva).
vfs_mountroot: Skip 'Root mount waiting' < 1 s
Jan 12 2022, 7:31 PM
cperciva added inline comments to D33802: x86: Speed up clock calibration.
Jan 12 2022, 6:12 AM
cperciva updated the diff for D33802: x86: Speed up clock calibration.

Fixes per reviews.

Jan 12 2022, 4:17 AM
cperciva added inline comments to D33802: x86: Speed up clock calibration.
Jan 12 2022, 4:15 AM

Jan 10 2022

cperciva added reviewers for D33802: x86: Speed up clock calibration: imp, jhb, kib, markj, jrtc27.
Jan 10 2022, 1:30 AM
cperciva requested review of D33802: x86: Speed up clock calibration.
Jan 10 2022, 1:29 AM

Jan 7 2022

cperciva committed R11:688bd028652d: emulators/qemu-user-static: Fix build on recent FreeBSD (authored by cperciva).
emulators/qemu-user-static: Fix build on recent FreeBSD
Jan 7 2022, 4:33 AM

Jan 3 2022

cperciva added a comment to D33730: x86: Skip late calibration if our reference timer has low quality.

Some AMD Geode-based systems end up using the 8254 PIT to calibrate the
TSC during late calibration, which doesn't work because that
timecounter's mask (65535) is much smaller than its frequency (1193182).
Moreover, early calibration is done against the 8254 timer anyway.

Jan 3 2022, 11:19 PM

Jan 2 2022

cperciva added a comment to D33695: Skip TSC calibration if exact value known.

We could possibly also skip late calibration if CPUID leaf 0x15 is present, as I believe it is also supposed to provide an authoritative value.

Jan 2 2022, 9:10 PM
cperciva closed D33696: Fix variable name: freq_khz -> freq.
Jan 2 2022, 9:09 PM
cperciva committed R10:698727d63734: Fix variable name: freq_khz -> freq (authored by cperciva).
Fix variable name: freq_khz -> freq
Jan 2 2022, 9:09 PM
cperciva closed D33695: Skip TSC calibration if exact value known.
Jan 2 2022, 9:09 PM
cperciva committed R10:9cb3288287ba: Skip TSC calibration if exact value known (authored by cperciva).
Skip TSC calibration if exact value known
Jan 2 2022, 9:09 PM

Dec 30 2021

cperciva added a comment to D33695: Skip TSC calibration if exact value known.

Thanks! Does it look good now?

Dec 30 2021, 7:47 PM
cperciva updated the diff for D33695: Skip TSC calibration if exact value known.

Adjust per markj's comments

Dec 30 2021, 7:46 PM
cperciva retitled D33696: Fix variable name: freq_khz -> freq from Fix varible name: freq_khz -> freq to Fix variable name: freq_khz -> freq.
Dec 30 2021, 7:20 AM
cperciva requested review of D33696: Fix variable name: freq_khz -> freq.
Dec 30 2021, 7:19 AM
cperciva added a comment to D33695: Skip TSC calibration if exact value known.

Darius (Daniel O'Connor) has tested and confirms that this operates as expected under VMWare -- the TSC-low timecounter is set up correctly, but the 1 second of calibration time is gone.

Dec 30 2021, 7:07 AM
cperciva added a reviewer for D33695: Skip TSC calibration if exact value known: markj.
Dec 30 2021, 3:29 AM
cperciva requested review of D33695: Skip TSC calibration if exact value known.
Dec 30 2021, 3:28 AM

Dec 29 2021

cperciva committed R10:57e897ec3d49: Only trigger read-ahead if two adjacent blocks have been requested. (authored by sobomax).
Only trigger read-ahead if two adjacent blocks have been requested.
Dec 29 2021, 11:07 PM
cperciva committed R10:3684bb89d520: MFC: Improve readahead in loader (authored by cperciva).
MFC: Improve readahead in loader
Dec 29 2021, 11:07 PM
cperciva committed R10:cdbcf636d3e0: EFI loader: Don't free bcache for DEVT_DISK devs (authored by cperciva).
EFI loader: Don't free bcache for DEVT_DISK devs
Dec 29 2021, 11:07 PM
cperciva committed R10:f388ad85c2aa: Add _sleep to TSLOG (authored by cperciva).
Add _sleep to TSLOG
Dec 29 2021, 11:07 PM
cperciva committed R10:45156a946877: loader: Set twiddle globaldiv to 16 by default (authored by cperciva).
loader: Set twiddle globaldiv to 16 by default
Dec 29 2021, 11:07 PM
cperciva committed R10:b80a1b584f26: MFC: Add TSLOG to loader sprintf (authored by cperciva).
MFC: Add TSLOG to loader sprintf
Dec 29 2021, 11:07 PM
cperciva committed R10:c2de5317816e: MFC: arm64 fixes for TSLOG (authored by cperciva).
MFC: arm64 fixes for TSLOG
Dec 29 2021, 11:07 PM