Page MenuHomeFreeBSD

cperciva (Colin Percival)
User

Projects

User Details

User Since
Jun 3 2014, 6:45 PM (338 w, 6 d)

Recent Activity

Wed, Nov 25

cperciva added inline comments to D27354: Address issue pointed out in CVE-2020-25705.
Wed, Nov 25, 6:20 PM

Wed, Nov 11

cperciva added a comment to D26911: bsdiff: fix off-by-one error.

Looks good to me. This is a bug introduced in r303285; the original qsufsort sorted oldsize+1 strings including an implicit empty string, but it looks like the divsufsort which replaced it doesn't do this.

Wed, Nov 11, 4:45 PM

Oct 31 2020

cperciva closed D27002: freebsd-boot is not always the first partition.
Oct 31 2020, 3:37 AM
cperciva committed rS367195: Attempt to defuse a land mine before anyone else steps on it: The.
Attempt to defuse a land mine before anyone else steps on it: The
Oct 31 2020, 3:37 AM

Oct 30 2020

cperciva added a comment to D27002: freebsd-boot is not always the first partition.

If booting from EFI, updating gptzfsboot won't do anything. We likely need additional documentation on actually updating the contents of the ESP as well.

Oct 30 2020, 1:17 AM

Oct 29 2020

cperciva added a reviewer for D27002: freebsd-boot is not always the first partition: allanjude.
Oct 29 2020, 4:52 AM
cperciva requested review of D27002: freebsd-boot is not always the first partition.
Oct 29 2020, 4:51 AM

Oct 14 2020

cperciva committed rP552299: MFH: r551555.
MFH: r551555
Oct 14 2020, 4:29 AM

Oct 6 2020

cperciva committed rP551555: Update ebsnvme-id to 1.0.1..
Update ebsnvme-id to 1.0.1.
Oct 6 2020, 3:22 AM

Sep 28 2020

cperciva committed rS366232: MFS r366028: Spawn the DHCPv6 client in EC2 instances via rtsold..
MFS r366028: Spawn the DHCPv6 client in EC2 instances via rtsold.
Sep 28 2020, 5:32 PM
cperciva committed rS366214: MFS r366178: Move finalize_components_config from get_params to cmd_*..
MFS r366178: Move finalize_components_config from get_params to cmd_*.
Sep 28 2020, 12:55 AM
cperciva committed rS366213: MFS r366179: Make nvmecontrol work with nda like it does with nvd, and.
MFS r366179: Make nvmecontrol work with nda like it does with nvd, and
Sep 28 2020, 12:54 AM
cperciva committed rS366212: MFS r366009: Include ebsnvme-id in arm64 AMIs..
MFS r366009: Include ebsnvme-id in arm64 AMIs.
Sep 28 2020, 12:52 AM

Sep 26 2020

cperciva committed rS366179: MFC r360483,360484: Make nvmecontrol work with nda like it does with.
MFC r360483,360484: Make nvmecontrol work with nda like it does with
Sep 26 2020, 12:58 AM
cperciva committed rS366178: MFC r365898: Move finalize_components_config from get_params to cmd_*..
MFC r365898: Move finalize_components_config from get_params to cmd_*.
Sep 26 2020, 12:41 AM

Sep 22 2020

cperciva committed rS366028: MFC r365696: Spawn the DHCPv6 client in EC2 instances via rtsold..
MFC r365696: Spawn the DHCPv6 client in EC2 instances via rtsold.
Sep 22 2020, 11:13 PM
cperciva committed rS366009: Revert r361645. The current quarterly ports branch contains ebsnvme-id,.
Revert r361645. The current quarterly ports branch contains ebsnvme-id,
Sep 22 2020, 6:19 PM

Sep 19 2020

cperciva committed rS365898: Move finalize_components_config from get_params to cmd_*..
Move finalize_components_config from get_params to cmd_*.
Sep 19 2020, 2:16 AM
cperciva closed D26432: Move finalize_components_config from get_params to cmd_*..
Sep 19 2020, 2:16 AM

Sep 15 2020

cperciva added a comment to D3527: Suppress harmless warning if running in 'cron' mode.

I think https://reviews.freebsd.org/D26432 is a better fix here.

Sep 15 2020, 5:07 AM
cperciva requested review of D26432: Move finalize_components_config from get_params to cmd_*..
Sep 15 2020, 5:07 AM

Sep 13 2020

cperciva committed rS365696: Spawn the DHCPv6 client in EC2 instances via rtsold..
Spawn the DHCPv6 client in EC2 instances via rtsold.
Sep 13 2020, 7:57 PM
cperciva committed rS365695: Bump the size of EC2 AMIs up to 5 GB..
Bump the size of EC2 AMIs up to 5 GB.
Sep 13 2020, 7:12 PM

Aug 26 2020

cperciva committed rS364832: Remove whitespace which accidentaly snuck into r364831..
Remove whitespace which accidentaly snuck into r364831.
Aug 26 2020, 7:28 PM
cperciva closed D26005: Add -w option to lockf(1).
Aug 26 2020, 7:27 PM
cperciva committed rS364831: Add -w option to lockf(1)..
Add -w option to lockf(1).
Aug 26 2020, 7:27 PM
cperciva added inline comments to D26005: Add -w option to lockf(1).
Aug 26 2020, 7:24 PM

Aug 8 2020

cperciva added a comment to D26005: Add -w option to lockf(1).

No rush -- this has been sitting on my to-do list ever since we discussed it in mid-June.

Aug 8 2020, 1:49 AM
cperciva requested review of D26005: Add -w option to lockf(1).
Aug 8 2020, 1:27 AM

Aug 3 2020

cperciva committed rS363786: MFC r362791:.
MFC r362791:
Aug 3 2020, 1:00 AM

Jul 31 2020

cperciva committed rP543843: Remove __BSD_VISIBLE from spiped build.
Remove __BSD_VISIBLE from spiped build
Jul 31 2020, 3:31 AM

Jul 30 2020

cperciva added a comment to D25881: Mention loading wifi interface driver in loader.conf for lagg..

The issue only exists on 12.1 (and 12.0, I suppose, but that's EoL) and the fix is "load the wifi driver explicitly rather than relying on devmatch" -- either loader.conf or rc.conf will work.

Are you positive (eg, have you tested) that loading the driver in rc.conf will work as well? That's not what you seemed to me to be saying in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246506 and my notes from our IRC conversation, in both of which you mention loader.conf but not rc.conf.

Jul 30 2020, 12:21 AM

Jul 29 2020

cperciva added a comment to D25881: Mention loading wifi interface driver in loader.conf for lagg..

Ah, I see. In that case, let's take mention of 11.3 and 11.4 out of this entirely -- on those systems, any way of loading the wifi drivers (loader.conf or rc.conf) will get them loaded early enough to have the device present before lagg is initialized.

Jul 29 2020, 11:09 PM
cperciva added a comment to D25881: Mention loading wifi interface driver in loader.conf for lagg..

I don't know what &rel121.current; &rel114.current; and &rel113.current; refer to -- are those 12.1-RELEASE, 11.4-RELEASE, and 11.3-RELEASE?

Jul 29 2020, 7:08 PM

Jun 30 2020

cperciva committed rS362791: Make EC2 AMIs use portsnap and freebsd-update mirrors hosted in AWS.
Make EC2 AMIs use portsnap and freebsd-update mirrors hosted in AWS
Jun 30 2020, 6:14 AM
cperciva closed D25498: Make EC2 AMIs use portsnap and freebsd-update mirrors hosted in AWS.
Jun 30 2020, 6:14 AM

Jun 29 2020

cperciva added a comment to D25498: Make EC2 AMIs use portsnap and freebsd-update mirrors hosted in AWS.

We're using route53 for portsnap right now; not for freebsd-update. But yes, I'll be looking into adjusting the existing portsnap DNS records to send traffic to these -- at very least in place of the old portsnap mirrors I've had in EC2 for many years.

Jun 29 2020, 1:26 AM

Jun 28 2020

cperciva requested review of D25498: Make EC2 AMIs use portsnap and freebsd-update mirrors hosted in AWS.
Jun 28 2020, 7:26 PM

Jun 26 2020

cperciva accepted D18482: Amazon EC2: Disable floppy devices (fdc0, fd0,) and parallel port device (pp0).

Ah, on t2.micro I see warnings about fdc (but not about ppc). Normally I aim to minimize the difference between EC2 and "stock" FreeBSD, but I guess there's no harm in making this change even if it only affects older instance types.

Jun 26 2020, 12:55 AM · Contributor Reviews (base)

Jun 25 2020

cperciva added a comment to D18482: Amazon EC2: Disable floppy devices (fdc0, fd0,) and parallel port device (pp0).

Which instance type are you seeing this on? I haven't been able to reproduce it.

Jun 25 2020, 9:09 PM · Contributor Reviews (base)

Jun 23 2020

cperciva committed rS362557: Clean up some function and variable names..
Clean up some function and variable names.
Jun 23 2020, 9:12 PM
cperciva closed D25403: Fix fallout from the emancipation of dump(8) workers.
Jun 23 2020, 9:11 PM
cperciva accepted D25373: Fix AccessWidth and BitWidth parsing in SPCR table.

Looks good to me. Might be worth mentioning in the commit message that EFI_ACPI_6_0_UNDEFINED handling is needed to work around a buggy SPCR table on EC2 x86 "bare metal" instances, just in case someone looks at the code a few years from now and wonders why we're doing this.

Jun 23 2020, 6:27 PM · x86, arm64
cperciva closed D24791: Add /etc/autofs/special_efs to EC2 images.
Jun 23 2020, 3:19 AM
cperciva requested review of D24791: Add /etc/autofs/special_efs to EC2 images.
Jun 23 2020, 3:17 AM
cperciva closed D24583: Set use_nvd=0 in EC2 AMIs.
Jun 23 2020, 3:16 AM
cperciva requested review of D24583: Set use_nvd=0 in EC2 AMIs.
Jun 23 2020, 3:15 AM
cperciva added inline comments to D25373: Fix AccessWidth and BitWidth parsing in SPCR table.
Jun 23 2020, 2:48 AM · x86, arm64

Jun 22 2020

cperciva requested review of D25403: Fix fallout from the emancipation of dump(8) workers.
Jun 22 2020, 8:37 PM
cperciva added inline comments to D25373: Fix AccessWidth and BitWidth parsing in SPCR table.
Jun 22 2020, 8:07 PM · x86, arm64

Jun 20 2020

cperciva added inline comments to D25373: Fix AccessWidth and BitWidth parsing in SPCR table.
Jun 20 2020, 4:27 PM · x86, arm64

Jun 8 2020

cperciva accepted D24517: sysutils/firstboot-pkgs: Bootstrap and update pkg unconditionally.

Looks good to me. Please commit.

Jun 8 2020, 5:10 PM

May 30 2020

cperciva committed rS361653: Insta-merge r361652 from stable/11: Expand EC2 AMI UFS partition to 2.9 GB..
Insta-merge r361652 from stable/11: Expand EC2 AMI UFS partition to 2.9 GB.
May 30 2020, 6:02 PM
cperciva committed rS361652: Bump the UFS partition in the EC2 AMI up to 2.9 GB; this doesn't affect.
Bump the UFS partition in the EC2 AMI up to 2.9 GB; this doesn't affect
May 30 2020, 5:43 PM
cperciva committed rS361645: Direct commit to stable/12: Only install ebsnvme-id on amd64 for now..
Direct commit to stable/12: Only install ebsnvme-id on amd64 for now.
May 30 2020, 2:56 AM
cperciva committed rS361644: MFC r361350: Add ebsnvme-id to EC2 AMIs and enable /dev/aws/disk.
MFC r361350: Add ebsnvme-id to EC2 AMIs and enable /dev/aws/disk
May 30 2020, 2:52 AM
cperciva committed rS361643: MFC r361143: Add /etc/autofs/special_efs to EC2 AMIs.
MFC r361143: Add /etc/autofs/special_efs to EC2 AMIs
May 30 2020, 2:50 AM

May 21 2020

cperciva added inline comments to D24065: Add Arm pl061 GPIO driver.
May 21 2020, 7:28 PM

May 19 2020

cperciva committed rS361235: MFC r361114:.
MFC r361114:
May 19 2020, 1:41 AM
cperciva committed rS361234: MFC r361097:.
MFC r361097:
May 19 2020, 1:39 AM

May 18 2020

cperciva accepted D24872: sysutils/amazon-ssm-agent: update to v2.3.1205.0.

Looks good, thanks! You can commit this, right?

May 18 2020, 9:08 PM
cperciva committed rS361150: Add ebsnvme-id to EC2 AMIs and enable /dev/aws/disk.
Add ebsnvme-id to EC2 AMIs and enable /dev/aws/disk
May 18 2020, 2:14 AM

May 17 2020

cperciva committed rS361143: Add /etc/autofs/special_efs to EC2 AMIs.
Add /etc/autofs/special_efs to EC2 AMIs
May 17 2020, 9:55 PM
cperciva abandoned D24763: Support multiple auto_master files.
May 17 2020, 9:38 PM
cperciva abandoned D24764: Split auto_master file into /etc/autofs/master_*.
May 17 2020, 9:37 PM
cperciva added a comment to D24764: Split auto_master file into /etc/autofs/master_*.

Good point about automount -L. I do like the idea of rc.conf as a "master control file" because I think it's easier for users (especially new users) if they can configure as much as possible from a single place, but the fact that automount is invoked directly rather than always via the rc.d system makes this problematic.

May 17 2020, 9:37 PM
cperciva added inline comments to D24872: sysutils/amazon-ssm-agent: update to v2.3.1205.0.
May 17 2020, 9:03 PM

May 16 2020

cperciva committed rS361114: Move the devmatch rc.d script before netif in the boot process..
Move the devmatch rc.d script before netif in the boot process.
May 16 2020, 6:38 PM
cperciva committed rS361097: Send Lid status notification via devd from acpi_lid_status_update..
Send Lid status notification via devd from acpi_lid_status_update.
May 16 2020, 1:50 AM

May 13 2020

cperciva committed rP535080: Use uidfix in sysutils/ebsnvme-id.
Use uidfix in sysutils/ebsnvme-id
May 13 2020, 5:03 AM

May 10 2020

cperciva added a comment to D24791: Add /etc/autofs/special_efs to EC2 images.

My policy thus far has been to avoid having EC2-specific code in "stock" FreeBSD as much as possible. (There have been exceptions, like the NFS "oneopenown" option, but those were unavoidable.)

May 10 2020, 7:29 PM
cperciva added a comment to D24791: Add /etc/autofs/special_efs to EC2 images.

If D24763 and D24764 are accepted, I'll also add a /etc/autofs/master_efs file to EC2 instances, so that EFS can be enabled simply by adding

May 10 2020, 3:38 AM

May 8 2020

cperciva added a comment to D24764: Split auto_master file into /etc/autofs/master_*.

Depends on D24763.

May 8 2020, 5:57 PM
cperciva requested review of D24764: Split auto_master file into /etc/autofs/master_*.
May 8 2020, 5:57 PM
cperciva requested review of D24763: Support multiple auto_master files.
May 8 2020, 5:52 PM
cperciva closed D8965: Avoid ESTALE if directory deleted by same NFS client.
May 8 2020, 5:46 PM

May 7 2020

cperciva committed rP534294: IGNORE on FreeBSD without NVME_GET_NSID..
IGNORE on FreeBSD without NVME_GET_NSID.
May 7 2020, 9:39 PM

May 5 2020

cperciva committed rP534017: Add ebsnvme-id 1.0..
Add ebsnvme-id 1.0.
May 5 2020, 3:21 AM

May 2 2020

cperciva committed rP533702: Update to 20200418..
Update to 20200418.
May 2 2020, 8:03 PM
cperciva closed D24490: Update graphics/intel-backlight.
May 2 2020, 8:03 PM

Apr 27 2020

cperciva committed rS360396: Set use_nvd=0 in EC2 AMIs..
Set use_nvd=0 in EC2 AMIs.
Apr 27 2020, 9:44 PM

Apr 26 2020

cperciva added a comment to D24583: Set use_nvd=0 in EC2 AMIs.

Warner: We discussed this on IRC; please confirm that the comment in the code and what I wrote in the "summary" above make sense.

Apr 26 2020, 11:56 PM

Apr 24 2020

cperciva added a comment to D24517: sysutils/firstboot-pkgs: Bootstrap and update pkg unconditionally.
In D24517#540205, @bapt wrote:

I'm not sure I understand the logic behind this.

If I understand correctly, a problem arises when the local copy of the repository catalogue is a very old version. If this is the case, couldn't we also have problems if the local database of *installed* packages is an old version?

your understanding is correct, but it cannot happen because I make sure pkg is backward compatible regarding the local database and always able to upgrade an old version of the database.

Apr 24 2020, 6:00 PM

Apr 23 2020

cperciva added a comment to D24517: sysutils/firstboot-pkgs: Bootstrap and update pkg unconditionally.

I'm not sure I understand the logic behind this.

Apr 23 2020, 10:09 PM

Apr 22 2020

cperciva created D24546: Use smaller jumbo mbufs in ENA as needed.
Apr 22 2020, 11:29 PM

Apr 19 2020

cperciva committed rS360089: MFC r360025: Alert devd when acpi_video brightness changes.
MFC r360025: Alert devd when acpi_video brightness changes
Apr 19 2020, 2:49 AM

Apr 18 2020

cperciva created D24490: Update graphics/intel-backlight.
Apr 18 2020, 10:14 PM

Apr 16 2020

cperciva committed rS360025: Alert devd when acpi_video brightness changes.
Alert devd when acpi_video brightness changes
Apr 16 2020, 9:57 PM
cperciva closed D24424: Alert devd when acpi_video brightness changes.
Apr 16 2020, 9:57 PM

Apr 15 2020

cperciva added a comment to D24256: Avoid concurrent nvme_qpair_process_completions runs.

Updating in case anyone looks back at this later: This fixes some instability on EC2 instances, and helped me to figure out what's going on. It looks like something -- probably the ENA device -- is monopolizing a CPU and starving the nvme completion ithread, and we were getting timeouts despite the interrupt having in fact fired successfully.

Apr 15 2020, 8:18 PM

Apr 14 2020

cperciva created D24424: Alert devd when acpi_video brightness changes.
Apr 14 2020, 8:33 PM

Apr 12 2020

cperciva committed rP531481: Belatedly bump PORTREVISION due to the fix in the spiped UIDs entry.
Belatedly bump PORTREVISION due to the fix in the spiped UIDs entry
Apr 12 2020, 5:18 AM

Apr 11 2020

cperciva committed rP531444: Use canonical spelling of "/nonexistent"..
Use canonical spelling of "/nonexistent".
Apr 11 2020, 5:48 PM

Apr 10 2020

cperciva committed rP531388: Update to 1.3.1..
Update to 1.3.1.
Apr 10 2020, 11:07 PM
cperciva committed rP531280: Update spiped to 1.6.1..
Update spiped to 1.6.1.
Apr 10 2020, 1:33 AM

Apr 8 2020

cperciva committed rP531085: Update bsdec2-image-upload to 1.3.0..
Update bsdec2-image-upload to 1.3.0.
Apr 8 2020, 3:27 AM

Apr 3 2020

cperciva added inline comments to D24284: Revamp nvme recovery.
Apr 3 2020, 11:48 PM

Apr 2 2020

cperciva added inline comments to D24256: Avoid concurrent nvme_qpair_process_completions runs.
Apr 2 2020, 9:57 PM
cperciva added inline comments to D24256: Avoid concurrent nvme_qpair_process_completions runs.
Apr 2 2020, 9:31 PM
cperciva added inline comments to D24256: Avoid concurrent nvme_qpair_process_completions runs.
Apr 2 2020, 8:31 PM