- User Since
- Jul 9 2015, 9:56 PM (241 w, 8 h)
Wed, Feb 19
Sun, Feb 16
Sat, Feb 15
Fri, Feb 14
Thu, Feb 13
Wed, Feb 12
Fri, Feb 7
WIP, I'm in progress of drafting a private email response as well.
My questions on the initial review were never really answered...
Generally please upload phabricator diffs with more context. The arcanist tool can help do that easily. Or if you prefer the manual process, please generate patches with -U99999.
Thu, Feb 6
Wed, Feb 5
Tue, Feb 4
I don't see any reason auditd cannot just use the default stop action, which sends SIGTERM. auditd handles sigterm and performs more or less the same shutdown actions as those triggered by audit -t (AUDIT_TRIGGER_CLOSE_AND_DIE). I would suggest just removing the auditd_stop() function entirely.
Seems like there is a possible race condition here where $rc_pid exits and is recycled before we check for exit.
Mon, Feb 3
Sat, Feb 1
I don't object to /root mode 750. This seems to line up with, e.g., Fedora Linux defaults.
Fri, Jan 31
Thu, Jan 30
Hm, I don't understand where we unlock in the rest of the chunks without the changes. Maybe the breaks intentionally return a locked context, but the continues seem obviously wrong. I don't see an unlock in, e.g., libusb_hotplug_filter() which would make that safe.
Updated patch LGTM :-). I see philip has already committed it, great!
LGTM other than the indentation
Wed, Jan 29
Tue, Jan 28
LGTM. 8kB is overkill for the key, but mostly harmless.
Mon, Jan 27
Thanks! LGTM other than the remaining EINVAL <-> ACPI_STATUS conflict in the revision.
Sun, Jan 26
Oh whoops I forgot about the error handling issue.
Thanks, the updates look great. I'm still curious about the disassembly of the methods if you can get it, but I don't think that's a blocker issue.
LGTM modulo whitespace nit and ACPI_STATUS return to userspace in set.
Add sysctl knob to disable VDSO page ABI.
Sat, Jan 25
Fix pasto in ifndef conditional
Fri, Jan 24
Thu, Jan 23
Wed, Jan 22
Jan 21 2020
Thanks for the quick reviews, Mark!
Jan 20 2020
Jan 19 2020
Jan 18 2020
Jan 17 2020
Thanks, looks good to me except for one concern below.