Page MenuHomeFreeBSD

cem (Conrad Meyer)
User

Projects

User Details

User Since
Jul 9 2015, 9:56 PM (294 w, 12 h)

Recent Activity

Tue, Feb 23

cem accepted D28889: Fix ptrace_test:ptrace__syscall_args after ATF upgrade.
Tue, Feb 23, 4:33 PM

Thu, Feb 18

cem accepted D28700: nvdimm(4): Export NVDIMM health flags via sysctl.

Still accepted from earlier

Thu, Feb 18, 10:12 PM
cem added a comment to D28756: ossl: Add ChaCha20 cipher support..

Outside of ossl_chacha20.c, everything looks fine.

Thu, Feb 18, 2:23 AM
cem added a comment to D28755: The ChaCha20 counter is little endian, not big endian..

Hm, it is little endian, but I'm not confident about the two sentences prior.

Thu, Feb 18, 2:17 AM
cem added inline comments to D28754: ossl: Add Poly1305 digest support..
Thu, Feb 18, 2:14 AM
cem accepted D28752: cryptosoft: Support per-op keys for AES-GCM and AES-CCM..
Thu, Feb 18, 2:00 AM
cem accepted D27838: cryptocheck: Add Chacha20-Poly1305 AEAD coverage..
Thu, Feb 18, 1:58 AM
cem accepted D28700: nvdimm(4): Export NVDIMM health flags via sysctl.
Thu, Feb 18, 1:57 AM

Wed, Feb 17

cem accepted D28753: cryptocheck: Free generated IV after each GMAC test..
Wed, Feb 17, 11:59 PM
cem added inline comments to D28700: nvdimm(4): Export NVDIMM health flags via sysctl.
Wed, Feb 17, 4:19 PM
cem accepted D28684: libc: Fix t_spawn_fileactions test after ATF update.
Wed, Feb 17, 4:03 PM

Tue, Feb 16

cem edited P483 Masterwork From Distant Lands.
Tue, Feb 16, 1:52 AM

Mon, Feb 15

cem accepted D28690: Export various 128 bit long double functions from libgcc_s.so.1.
Mon, Feb 15, 10:14 PM
cem accepted D28683: Fix two failing tests after ATF update.

The analysis makes sense and the fix looks fine to me. You could allocate two fds and check socketpair against both (instead of just low) in the final test, but I don't think there's much marginal value in that. (Frankly, I'm not a fan of unix' must-assign-lowest-fd behavior in general, but we have to abide by it.)

Mon, Feb 15, 6:54 PM

Sat, Feb 13

cem accepted D28605: fusefs: set d_off during VOP_READDIR.
Sat, Feb 13, 4:44 AM
cem added inline comments to D28605: fusefs: set d_off during VOP_READDIR.
Sat, Feb 13, 3:57 AM
cem added inline comments to D28605: fusefs: set d_off during VOP_READDIR.
Sat, Feb 13, 1:46 AM

Fri, Feb 12

cem added a comment to D28605: fusefs: set d_off during VOP_READDIR.

In the commit summary, is this a typo?

Fri, Feb 12, 5:18 PM
cem added inline comments to D28607: fusefs: forward the server's reported optimal transfer size to statfs.
Fri, Feb 12, 4:49 PM

Mon, Feb 8

cem added inline comments to D27946: fusefs: protect fufh table and cached attributes with the vnode lock.
Mon, Feb 8, 4:44 AM
cem added inline comments to D27946: fusefs: protect fufh table and cached attributes with the vnode lock.
Mon, Feb 8, 2:12 AM
cem added a comment to D28528: cherry pick openpam update.

No objection in principle, but the diff is basically unreviewable as-is for me; it's like 90% autoconf generated shell.

Mon, Feb 8, 1:48 AM

Tue, Feb 2

cem accepted D28461: contribreadelf: do not trucate section name with -W.

LGTM, thanks.

Tue, Feb 2, 3:11 PM

Mon, Feb 1

cem accepted D28395: tests/sys/kern/crc32: Check for SSE4.2 before using it.

Looks great to me!

Mon, Feb 1, 3:56 PM
cem added a comment to D28395: tests/sys/kern/crc32: Check for SSE4.2 before using it.

Turns out the bug was that I messed up the size being passed to the SSE4.2 version. It does work correctly.

Mon, Feb 1, 3:48 PM
cem added inline comments to D28395: tests/sys/kern/crc32: Check for SSE4.2 before using it.
Mon, Feb 1, 3:22 PM
cem added inline comments to D28395: tests/sys/kern/crc32: Check for SSE4.2 before using it.
Mon, Feb 1, 3:14 PM

Fri, Jan 29

cem added inline comments to D28395: tests/sys/kern/crc32: Check for SSE4.2 before using it.
Fri, Jan 29, 4:43 PM

Thu, Jan 28

cem added a comment to D28375: Fix getblk() with GB_NOCREAT returning false-negatives..
In D28375#634909, @cem wrote:

incore has always been able to produce false negatives, FWIW. It's fundamentally racy. I think it's mostly used as a heuristic for avoiding unnecessary prefetch.

That's true, but it's possible for callers to depend on the instantaneous result being correct because some external synchronization guarantees that the result is stable. For instance, some lock might serialize calls to getblk() for a particular vnode, so holding that lock ensures that incore() returns a stable result. I'm worried about false negatives caused by reassignbuf() in cases like this.

Thu, Jan 28, 7:18 PM
cem requested changes to D28395: tests/sys/kern/crc32: Check for SSE4.2 before using it.
Thu, Jan 28, 4:29 PM
cem accepted D28395: tests/sys/kern/crc32: Check for SSE4.2 before using it.

I think QEMU provides a basic amd64 CPU by default which does not include any newer features (wikipedia suggests SSE4.2 was introduced ~2008).

Thu, Jan 28, 2:31 PM
cem requested changes to D28395: tests/sys/kern/crc32: Check for SSE4.2 before using it.

I think the idea here is that CRC32 is part of SSE4.2, which is part of the base feature set of amd64. If you're hitting SIGILL in QEMU in amd64 mode, that suggests QEMU's amd64 emulation is somewhat invalid. However, it's certainly optional on at least some early models of i386.

Thu, Jan 28, 1:51 PM
cem added a comment to D28375: Fix getblk() with GB_NOCREAT returning false-negatives..

Hmm. It's not really obvious to me that all callers handle false negatives correctly. Some callers simply call getblk() in that case, but others like ufs_bmaparray() are more complicated.

Thu, Jan 28, 12:15 AM

Wed, Jan 27

cem accepted D28375: Fix getblk() with GB_NOCREAT returning false-negatives..

I think incore was already always racy? The race scenarios may have changed slightly.

Wed, Jan 27, 8:34 PM

Jan 26 2021

cem accepted D27542: stand: lua: enhance lfs.dir() to speed up kernels_autodetect.

Excellent. Thanks!

Jan 26 2021, 3:08 PM

Jan 23 2021

cem added inline comments to D25782: Add unlocked/SMR fast path to getblk().
Jan 23 2021, 5:25 AM
cem added inline comments to D25782: Add unlocked/SMR fast path to getblk().
Jan 23 2021, 12:16 AM
cem added inline comments to D25782: Add unlocked/SMR fast path to getblk().
Jan 23 2021, 12:14 AM

Jan 22 2021

cem added a comment to D28260: Define PNP info after defining driver modules.

I think maybe we should revert the change, if it is truly unfounded and was only observed on 12. If this wasn't ever a problem on CURRENT, the commit message rationale is wrong and misleading. Reverting is the canonical way to correct that kind of thing.

Jan 22 2021, 9:32 PM
cem added a comment to D28260: Define PNP info after defining driver modules.

Hmm, the kldxref change doesn't fully fix the problem as I understand it (not that my commit does). The real problem is that the pnp info structure doesn't contain the module name, so devmatch(8) doesn't know which PNP info goes with which module. The kldxref change at least ensures that devmatch won't try to process a PNP info definition without having seen an MDT_MODULE record.

Jan 22 2021, 1:56 PM
cem added a comment to D28260: Define PNP info after defining driver modules.

Wait, kldxref should be ordering these correctly since rS348309. Why isn't it?

Jan 22 2021, 1:41 AM

Jan 17 2021

cem committed R10:ddf61156132b: fstyp(8): fix exfat detection (authored by cem).
fstyp(8): fix exfat detection
Jan 17 2021, 7:58 PM

Jan 14 2021

cem accepted D28159: opencrypto: Fix assignment of crypto completions to worker threads.

πŸ‘

Jan 14 2021, 5:37 PM
cem accepted D28158: opencrypto: Embed the driver softc in the session structure.

Sure, seems fine to me.

Jan 14 2021, 5:08 PM

Jan 9 2021

cem added inline comments to D27838: cryptocheck: Add Chacha20-Poly1305 AEAD coverage..
Jan 9 2021, 1:47 AM

Jan 8 2021

cem accepted D28047: gitignore: update cscope rules.

I don’t know anything about cscope but it looks fine. Ideally files that would only be found in the root (eg tinderbox crap) are β€œ/β€œ prefixed to reduce the search cost in subdirectories. Orthogonal to this change.

Jan 8 2021, 11:11 PM

Jan 4 2021

cem added inline comments to D24933: implement W^X for mmap and mprotect.
Jan 4 2021, 7:14 PM
cem added inline comments to D27946: fusefs: protect fufh table and cached attributes with the vnode lock.
Jan 4 2021, 2:51 PM
cem added inline comments to D27947: Fix LK_TRYUPGRADE.
Jan 4 2021, 2:37 PM
cem added inline comments to D27947: Fix LK_TRYUPGRADE.
Jan 4 2021, 2:36 PM
cem added inline comments to D27946: fusefs: protect fufh table and cached attributes with the vnode lock.
Jan 4 2021, 1:03 AM

Jan 3 2021

cem committed R10:98689d0ffb0a: libprivatezstd: Restrict symbol visibility similar to upstream (authored by cem).
libprivatezstd: Restrict symbol visibility similar to upstream
Jan 3 2021, 7:27 PM
cem accepted D27944: bitset.9: add missing MLINKS.
Jan 3 2021, 6:54 PM
cem added a comment to D27943: ccp: add new PCI ID for Zen 2/3.

Well, wouldn't mixing an extra source be better?

Jan 3 2021, 6:30 PM
cem removed reviewers for D27943: ccp: add new PCI ID for Zen 2/3: cem, Contributor Reviews (base).

See d7b665dfd7a6 / rS368542 / 7cda7375e629 / rS366943.

Jan 3 2021, 5:19 PM
cem accepted D27938: Fix vnode locking bug in fuse_vnop_copy_file_range.
Jan 3 2021, 4:50 PM
cem committed R10:bcae12b591d9: zstd: Fix non-FreeBSD CI libzstd build (authored by cem).
zstd: Fix non-FreeBSD CI libzstd build
Jan 3 2021, 3:43 PM
cem edited P471 git log -1 --pretty=raw.
Jan 3 2021, 1:16 PM
cem accepted D27936: Fix a vnode locking bug in fuse_vnop_advlock..

Ok, so the bug was that we never took any lock at all? But we're also moving a block of code surrounding the new vn_lock(); operation, which isn't related to our not-locking-the-vp-bug. It looks like we want to reject EINVAL flags before we start locking, which is fine. I would just like to see a better commit message than "fix a [non-specific] bug." Something like "add missing lock in fuse advlock. also, reject invalid parameters sooner (style)."

Jan 3 2021, 12:58 PM
cem accepted D27939: fusefs: only check vnode locks with DEBUG_VFS_LOCKS.

The other nice thing about this routine (ok, conditional on debug.vfs_badlock_vnode=1, but it is the default) β€” or VNASSERT(), VPASS() β€” is that they'll print out details of the vp. MPASS can't do that.

Jan 3 2021, 12:48 PM
cem added inline comments to D27938: Fix vnode locking bug in fuse_vnop_copy_file_range.
Jan 3 2021, 12:43 PM

Dec 30 2020

cem accepted D27818: fusefs: implement FUSE_COPY_FILE_RANGE..
Dec 30 2020, 4:23 PM
cem accepted D27804: fusefs: update FUSE protocol to 7.24 and implement FUSE_LSEEK.

Thanks!

Dec 30 2020, 2:54 PM
cem added a comment to D27837: Add an implementation of CHACHA20_POLY1035 to cryptosoft..

The make-bits and other integration look fine. I didn't have time to verify the meat of the implementation (and probably won't).

Dec 30 2020, 2:34 AM
cem accepted D27836: Add an OCF algorithm for ChaCha20-Poly1035 AEAD..
Dec 30 2020, 2:26 AM
cem accepted D27835: Tidy some crypto-related lines in sys/conf/files..
Dec 30 2020, 2:17 AM
cem accepted D27834: Reject AES-GCM and AES-CCM sessions with per-op keys..
Dec 30 2020, 2:16 AM
cem added a comment to D27804: fusefs: update FUSE protocol to 7.24 and implement FUSE_LSEEK.

Mostly LGTM, thanks!

Dec 30 2020, 1:58 AM
cem added inline comments to D27804: fusefs: update FUSE protocol to 7.24 and implement FUSE_LSEEK.
Dec 30 2020, 1:58 AM

Dec 27 2020

cem removed a reviewer for D27787: tcgetwinsize(3): man page: cem.
Dec 27 2020, 9:55 PM

Dec 25 2020

cem committed R10:f7cd7fe51c41: sys/contrib/zstd: Import zstd 1.4.8 (authored by cem).
sys/contrib/zstd: Import zstd 1.4.8
Dec 25 2020, 3:57 PM
cem committed R10:f6ae97673c28: Import zstd 1.4.8 (authored by cem).
Import zstd 1.4.8
Dec 25 2020, 3:32 PM

Dec 24 2020

cem accepted D27770: fusefs: delete some dead code.

Awesome, thanks!

Dec 24 2020, 10:03 PM
cem accepted D27770: fusefs: delete some dead code.
Dec 24 2020, 9:15 PM

Dec 22 2020

cem accepted D27644: gdb(4): allow bulk write and single read of registers.

Thanks!

Dec 22 2020, 8:37 PM

Dec 17 2020

cem accepted D27642: amd64: allow gdb(4) to write to most registers.
Dec 17 2020, 9:01 PM
cem added a comment to D27633: Initial version of git commit message preparation hook.

Re: hyphenated metadata attribute names β€” I'd just keep our annotations the same as they are now. If we were starting from scratch as a git project, sure, we should adopt the common git scheme. But the annotations are not special in git (just part of the commit message), and any FreeBSD tooling has to understand our previous annotations anyway.

Dec 17 2020, 12:08 AM

Dec 16 2020

cem added a comment to D27644: gdb(4): allow bulk write and single read of registers.

(Otherwise, lgtm)

Dec 16 2020, 10:32 PM
cem added inline comments to D27644: gdb(4): allow bulk write and single read of registers.
Dec 16 2020, 10:32 PM
cem added a comment to D27642: amd64: allow gdb(4) to write to most registers.

Can we lift the condition out and just have two switches? Not sure if that’s any better but it seems sort of ugly as is.

Dec 16 2020, 10:23 PM

Dec 12 2020

cem added inline comments to D27588: amd64 pmap: fix pcid invalidations.
Dec 12 2020, 8:52 PM
cem committed rS368587: amdtemp(4): Add missing Family 17h models.
amdtemp(4): Add missing Family 17h models
Dec 12 2020, 7:44 PM
cem added a comment to D27552: amdsmn,amdtemp: add support for Family 19h (Zen 3).

Thanks!

Dec 12 2020, 7:44 PM
cem closed D27552: amdsmn,amdtemp: add support for Family 19h (Zen 3).
Dec 12 2020, 7:34 PM
cem committed rS368586: amdsmn(4), amdtemp(4): add support for Family 19h (Zen 3).
amdsmn(4), amdtemp(4): add support for Family 19h (Zen 3)
Dec 12 2020, 7:34 PM
cem accepted D27552: amdsmn,amdtemp: add support for Family 19h (Zen 3).
Dec 12 2020, 6:52 PM
cem accepted D27588: amd64 pmap: fix pcid invalidations.
Dec 12 2020, 6:49 PM

Dec 11 2020

cem added a comment to D27542: stand: lua: enhance lfs.dir() to speed up kernels_autodetect.

I like the approach, thanks!

Dec 11 2020, 9:43 PM
cem requested changes to D27552: amdsmn,amdtemp: add support for Family 19h (Zen 3).
Dec 11 2020, 7:30 PM
cem added a comment to D27552: amdsmn,amdtemp: add support for Family 19h (Zen 3).

Thanks for adding the new hardware. Seems like a reasonable approach to me.

Dec 11 2020, 5:36 PM

Dec 10 2020

cem accepted D27553: ntb: quiet gcc -Wreturn-type.
Dec 10 2020, 7:37 PM
cem added a comment to D27542: stand: lua: enhance lfs.dir() to speed up kernels_autodetect.

Is kernel.KERNCONF actually a convention? I tend to use INSTKERNNAME and 'test.KERNCONF'.

Dec 10 2020, 4:40 PM

Dec 9 2020

cem added a comment to D27513: fd: Plug a race between fd table free and several loops.

I'm not sure I understand the solution, but totally believe there's a bug in this area.

Dec 9 2020, 2:32 AM

Dec 8 2020

cem added inline comments to D27376: msdosfs(5): WIP/PoC exFAT support.
Dec 8 2020, 9:36 PM

Dec 6 2020

cem added a comment to D27376: msdosfs(5): WIP/PoC exFAT support.
In D27376#614415, @kib wrote:

Goal is to give/show it to users earlier, while not degrading existing old FAT support while continuing the development. E.g. the issue with the (virtually) contiguous bitmap alloc makes it unfeasible to allow any form of automatic mounting of exFAT with the current patch IMO. But on the other hand I do not see why don't you want to get reports of compat issues with real-world filesystems.

At the moment where you feel that the code is mature enough, I expect that the exFAT module will be removed together with MSDOS_EXFAT option.

Dec 6 2020, 11:54 PM

Dec 5 2020

cem closed D27489: atkbd(4): Just use nitems() for quirk enumeration.
Dec 5 2020, 10:04 PM
cem added a comment to D27489: atkbd(4): Just use nitems() for quirk enumeration.

Thanks for the quick look, folks!

Dec 5 2020, 10:04 PM
cem committed rS368374: atkbd(4): Just use nitems() for quirk enumeration.
atkbd(4): Just use nitems() for quirk enumeration
Dec 5 2020, 10:04 PM
cem requested review of D27489: atkbd(4): Just use nitems() for quirk enumeration.
Dec 5 2020, 8:44 PM
cem added a comment to D27387: Add CFI start/end proc directives to arm64, i386, and ppc.

I'm fine with it on readthrough, I just hadn't gotten around to the actual tests. If it broke anything in powerpc land, it should be easy to fix. Thanks for tidying up the procedure annotations!

Dec 5 2020, 3:21 AM