Page MenuHomeFreeBSD

cem (Conrad Meyer)
User

Projects

User Details

User Since
Jul 9 2015, 9:56 PM (280 w, 6 d)

Recent Activity

Yesterday

cem updated the test plan for D27376: msdosfs(5): WIP/PoC exFAT support.
Wed, Nov 25, 11:54 PM
cem added a comment to D27376: msdosfs(5): WIP/PoC exFAT support.

Unfortunately, no readable diff between specifications as far as I know. (I don't know of any great VFAT specification off-hand.) exFAT is relatively well defined at https://docs.microsoft.com/en-us/windows/win32/fileio/exfat-specification .

Wed, Nov 25, 10:24 PM
cem requested review of D27376: msdosfs(5): WIP/PoC exFAT support.
Wed, Nov 25, 9:32 PM
cem added inline comments to D27354: Address issue pointed out in CVE-2020-25705.
Wed, Nov 25, 6:25 PM
cem added inline comments to D27354: Address issue pointed out in CVE-2020-25705.
Wed, Nov 25, 5:49 PM
cem added a comment to D27367: Remove uses of CRIOGET in OCF tests after r368005..

Lgtm.

Wed, Nov 25, 1:50 AM

Sun, Nov 22

cem updated the summary of D26654: Support immutable motd when /var/run is tmpfs.
Sun, Nov 22, 10:16 PM
cem accepted D26654: Support immutable motd when /var/run is tmpfs.

Code change seems good. The doc change is possibly incomplete (still potentially confusing) but I don't consider that blocking.

Sun, Nov 22, 10:15 PM

Fri, Nov 20

cem created P460 (An Untitled Masterwork).
Fri, Nov 20, 8:24 PM

Thu, Nov 19

cem created P459 (An Untitled Masterwork).
Thu, Nov 19, 9:25 PM
cem added a reviewer for D26654: Support immutable motd when /var/run is tmpfs: delphij.

Sure. Warner or Xin Li (CC'd, involved in earlier part of this design IIRC) might prefer something else, so you could also wait to see if they have an opinion.

Thu, Nov 19, 9:21 PM
cem added a comment to D26654: Support immutable motd when /var/run is tmpfs.

I'm not super keen on this design. It makes the file type of /etc/motd more confusing, turns _PATH_MOTDFILE into a symlink for the default case, and I'm unclear why you're modifying the motd rc script at all if your proposal involves update_motd="NO".

Thu, Nov 19, 6:40 PM
cem accepted D27271: Add an option for entering KDB on recursive panics.
Thu, Nov 19, 5:47 PM

Wed, Nov 18

cem accepted D27271: Add an option for entering KDB on recursive panics.

The idea seems good to me. It seems like the implementation may also be tripped by concurrent panic, not just recursive panic. I've usually (only?) seen concurrent panics in the context of unhandled MCA/MCE exceptions, and maybe that was an oddity of that particular FreeBSD derivative. I don't think that's a significant (or new) problem with this change.

Wed, Nov 18, 9:36 PM
cem committed rS367817: msdosfs(5): Fix debug-only format string.
msdosfs(5): Fix debug-only format string
Wed, Nov 18, 8:20 PM
cem closed D27037: Split out cwd/root/jail, cmask state from filedesc table.

Should have been automatically closed by rS367777, but wasn't for some reason.

Wed, Nov 18, 7:48 PM
cem created P457 (An Untitled Masterwork).
Wed, Nov 18, 7:38 PM

Tue, Nov 17

cem committed rD54690: Document __FreeBSD_version 1300130.
Document __FreeBSD_version 1300130
Tue, Nov 17, 9:35 PM
cem closed D27016: linux(4) clone(2): Correctly handle CLONE_FS and CLONE_FILES.
Tue, Nov 17, 9:20 PM
cem committed rS367778: linux(4) clone(2): Correctly handle CLONE_FS and CLONE_FILES.
linux(4) clone(2): Correctly handle CLONE_FS and CLONE_FILES
Tue, Nov 17, 9:20 PM
cem committed rS367777: Split out cwd/root/jail, cmask state from filedesc table.
Split out cwd/root/jail, cmask state from filedesc table
Tue, Nov 17, 9:14 PM
cem edited P456 Masterwork From Distant Lands.
Tue, Nov 17, 9:02 PM
cem abandoned D23551: nvdimm(4): Prototype real basic NVDIMM-N health info.

(Just FYI, Bryan. If there's interested in upstreaming this stuff to the FreeBSD nvdimm layer and eventually rebasing Isilon's nvdimm journal on nvdimm(4), this might be a place to start.)

Tue, Nov 17, 8:03 PM
cem closed D27084: unix(4): Enhance LOCAL_CREDS_PERSISTENT ABI.
Tue, Nov 17, 8:01 PM
cem committed rS367776: unix(4): Enhance LOCAL_CREDS_PERSISTENT ABI.
unix(4): Enhance LOCAL_CREDS_PERSISTENT ABI
Tue, Nov 17, 8:01 PM
cem closed D27136: linprocfs(5): Add rudimentary /proc/<pid>/mountinfo.
Tue, Nov 17, 7:57 PM
cem committed rS367775: linprocfs(5): Add rudimentary /proc/<pid>/mountinfo.
linprocfs(5): Add rudimentary /proc/<pid>/mountinfo
Tue, Nov 17, 7:57 PM
cem committed rS367774: 'make sysent' for r367773.
'make sysent' for r367773
Tue, Nov 17, 7:54 PM
cem closed D27111: linux(4): Implement name_to_handle_at(), open_by_handle_at().
Tue, Nov 17, 7:52 PM
cem committed rS367773: linux(4): Implement name_to_handle_at(), open_by_handle_at().
linux(4): Implement name_to_handle_at(), open_by_handle_at()
Tue, Nov 17, 7:51 PM
cem added a comment to D27236: Retrieve LOCALBASE with getlocalbase().
In D27236#608678, @imp wrote:

If you ktrace a regular application starting up you already see a lot of system calls, so I think adding one more is fine.

Except there's many efforts to reduce this. At present, this function is called by a tiny number of binaries, so I'd rather have any overhead be limited to those programs that use it.

Tue, Nov 17, 6:24 PM
cem added a comment to D27243: bhyve: Advance RIP after userspace instruction decode.

Some notes I sent Adam earlier, might be useful for someone in the future:

Tue, Nov 17, 5:39 PM
cem accepted D27243: bhyve: Advance RIP after userspace instruction decode.
Tue, Nov 17, 5:31 PM

Mon, Nov 16

cem added a comment to D27236: Retrieve LOCALBASE with getlocalbase().

The user.localbase sysctl seems like a poor design, and doesn't exist at the moment. That needs to be resolved before this change is committed.

Mon, Nov 16, 5:21 PM

Fri, Nov 13

cem added a comment to D26792: [tests] Fix "unused variable" warning-to-error on gcc-6.4.
In D26792#607459, @kib wrote:

Does anybody looked at the resulting asm to confirm that memory access is indeed generated ?

Fri, Nov 13, 7:23 PM
cem added inline comments to D26792: [tests] Fix "unused variable" warning-to-error on gcc-6.4.
Fri, Nov 13, 6:21 PM
cem added inline comments to D26792: [tests] Fix "unused variable" warning-to-error on gcc-6.4.
Fri, Nov 13, 6:18 PM
cem added inline comments to D26792: [tests] Fix "unused variable" warning-to-error on gcc-6.4.
Fri, Nov 13, 6:09 PM

Thu, Nov 12

cem updated the test plan for D27037: Split out cwd/root/jail, cmask state from filedesc table.
Thu, Nov 12, 11:08 PM
cem edited P456 Masterwork From Distant Lands.
Thu, Nov 12, 11:08 PM
cem added a reviewer for D27037: Split out cwd/root/jail, cmask state from filedesc table: kib.
Thu, Nov 12, 11:07 PM
cem added a comment to D27037: Split out cwd/root/jail, cmask state from filedesc table.

Lsof appears to use libkvm on modern FreeBSD, but not libproc. So it needs the equivalent change to procstat_getfiles_kvm() and I think that's it.

Thu, Nov 12, 10:59 PM
cem accepted D27197: df: Remove support for mounting devices.
Thu, Nov 12, 7:37 PM

Tue, Nov 10

cem added a comment to D23843: Return ENOTSUP for mmap/mprotect with prot not subset of prot_max.

Hm, that kind of check is usually EINVAL.

Tue, Nov 10, 5:50 PM
cem added a comment to D23843: Return ENOTSUP for mmap/mprotect with prot not subset of prot_max.

I agree that something else may make more sense. I'd suggest EPERM (as opposed to EACCES, which explicitly mentions file access permissions) or EINVAL (generic bogus argument) as possibilities. I don't oppose EACCES either. I think EDOOFUS is pretty much always wrong.

Tue, Nov 10, 5:41 PM

Mon, Nov 9

cem updated the diff for D27084: unix(4): Enhance LOCAL_CREDS_PERSISTENT ABI.
  • Version sockcred2 structure
Mon, Nov 9, 8:28 PM
cem updated the diff for D27037: Split out cwd/root/jail, cmask state from filedesc table.
  • uma -> malloc
  • drop shared lock macros
Mon, Nov 9, 8:13 PM

Sat, Nov 7

cem requested review of D27136: linprocfs(5): Add rudimentary /proc/<pid>/mountinfo.
Sat, Nov 7, 7:38 PM

Fri, Nov 6

cem closed D27124: linux(4): Fix loadable modules after r367395.
Fri, Nov 6, 10:05 PM
cem committed rS367433: linux(4): Fix loadable modules after r367395.
linux(4): Fix loadable modules after r367395
Fri, Nov 6, 10:05 PM
cem added inline comments to D27124: linux(4): Fix loadable modules after r367395.
Fri, Nov 6, 10:02 PM
cem updated the summary of D27124: linux(4): Fix loadable modules after r367395.
Fri, Nov 6, 7:51 PM
cem added a comment to D27124: linux(4): Fix loadable modules after r367395.

This tinderboxes and both modules load without issue on amd64. I was able to run a 64-bit binary fine.

Fri, Nov 6, 7:51 PM
cem updated the diff for D27124: linux(4): Fix loadable modules after r367395.

Move MI dummy stubs and SDT definition into linux_common.

Fri, Nov 6, 7:50 PM
cem updated the test plan for D27037: Split out cwd/root/jail, cmask state from filedesc table.
Fri, Nov 6, 6:37 PM
cem added inline comments to D27037: Split out cwd/root/jail, cmask state from filedesc table.
Fri, Nov 6, 6:36 PM
cem updated the test plan for D27111: linux(4): Implement name_to_handle_at(), open_by_handle_at().
Fri, Nov 6, 5:59 PM
cem requested review of D27124: linux(4): Fix loadable modules after r367395.
Fri, Nov 6, 5:35 PM
cem requested review of D27111: linux(4): Implement name_to_handle_at(), open_by_handle_at().
Fri, Nov 6, 3:24 AM

Thu, Nov 5

cem closed D27099: linux(4): Deduplicate unimpl/dummy syscall handlers.
Thu, Nov 5, 8:10 PM
cem committed rS367395: linux(4): Deduplicate unimpl/dummy syscall handlers.
linux(4): Deduplicate unimpl/dummy syscall handlers
Thu, Nov 5, 8:10 PM
cem added a comment to D27099: linux(4): Deduplicate unimpl/dummy syscall handlers.

Thanks!

Thu, Nov 5, 6:40 PM
cem added a comment to D27099: linux(4): Deduplicate unimpl/dummy syscall handlers.

I like it. Some of the per-architecture DUMMY() should probably get moved to the MI file too - statx for example - but that's better done later on.

Thu, Nov 5, 5:55 PM
cem closed D27047: Add sbuf streaming mode to pseudofs(9), use in linprocfs(5).
Thu, Nov 5, 6:49 AM
cem committed rS367362: Add sbuf streaming mode to pseudofs(9), use in linprocfs(5).
Add sbuf streaming mode to pseudofs(9), use in linprocfs(5)
Thu, Nov 5, 6:49 AM
cem requested review of D27099: linux(4): Deduplicate unimpl/dummy syscall handlers.
Thu, Nov 5, 6:44 AM

Wed, Nov 4

cem added a comment to D27084: unix(4): Enhance LOCAL_CREDS_PERSISTENT ABI.
In D27084#604733, @kib wrote:
In D27084#604727, @cem wrote:
In D27084#604715, @kib wrote:>

If you add new fields after sc_groups[], there is no need in SCM_CREDS2.

I don't think that's true. How does a consumer reliably distinguish between cmsgcred, original sockcred, and new sockcred with extra fields?

Consumer does not need to. If LOCAL_CREDS_PERSISTENT was set, it is always new sockcred. The option is per-socket so it should be fine for older library to get older sockcred on other sockets.

Wed, Nov 4, 9:10 PM
cem added a comment to D27084: unix(4): Enhance LOCAL_CREDS_PERSISTENT ABI.
In D27084#604715, @kib wrote:
In D27084#604710, @cem wrote:
In D27084#604700, @kib wrote:

Hm, if we do this for existing SCM_CREDS, one difficulty is that statically sized buffers (e.g., SOCKCREDSIZE(CMGROUP_MAX)) in existing binaries would potentially no longer be big enough. Correct code would not overrun a buffer, but could fail to receive SCM_CREDS messages that used to work.

CMGROUP_MAX is silly, and probably makes sc_groups not too useful. That said, it is probably fine to fail to add the message if there is no space. App setting the 'new creds' flag should be aware.

Wed, Nov 4, 8:41 PM
cem added a comment to D27084: unix(4): Enhance LOCAL_CREDS_PERSISTENT ABI.
In D27084#604700, @kib wrote:

You can add fields after sc_groups[], without introducing sockcred2. The receiver would need to check something to understand that kernel supplies that addon, e.g. p_osrel is the obvious candidate.

Wed, Nov 4, 7:51 PM
cem added reviewers for D27084: unix(4): Enhance LOCAL_CREDS_PERSISTENT ABI: kib, jhb.

I think changing the value of SCM_CREDS is probably good enough though. This might be a question for the mailing lists; the proposed patch makes an already-confusing API even more complicated.

Wed, Nov 4, 6:22 PM
cem added a comment to D27084: unix(4): Enhance LOCAL_CREDS_PERSISTENT ABI.
Wed, Nov 4, 6:19 PM
cem added inline comments to D27047: Add sbuf streaming mode to pseudofs(9), use in linprocfs(5).
Wed, Nov 4, 5:54 PM
cem updated the diff for D27084: unix(4): Enhance LOCAL_CREDS_PERSISTENT ABI.

Fix misnamed LOCAL_CREDS in socket.h comment

Wed, Nov 4, 12:00 AM

Tue, Nov 3

cem requested review of D27084: unix(4): Enhance LOCAL_CREDS_PERSISTENT ABI.
Tue, Nov 3, 11:57 PM
cem updated the diff for D27047: Add sbuf streaming mode to pseudofs(9), use in linprocfs(5).
  • Fix sbuf drain length math when a partial seek occurred
  • Early terminate pseudofs auto-drain fill routines when caller's uio is fully consumed
Tue, Nov 3, 10:27 PM
cem added inline comments to D27047: Add sbuf streaming mode to pseudofs(9), use in linprocfs(5).
Tue, Nov 3, 9:53 PM
cem added inline comments to D27047: Add sbuf streaming mode to pseudofs(9), use in linprocfs(5).
Tue, Nov 3, 9:22 PM
cem added inline comments to D27047: Add sbuf streaming mode to pseudofs(9), use in linprocfs(5).
Tue, Nov 3, 9:13 PM
cem updated the diff for D27037: Split out cwd/root/jail, cmask state from filedesc table.
  • Convert pwddesc lock to mutex (required shuffling chroot_refuse_vdir_fds() lock order)
Tue, Nov 3, 7:53 PM
cem committed rS367303: linux(4): Improve netlink diagnostics.
linux(4): Improve netlink diagnostics
Tue, Nov 3, 7:51 PM
cem updated the diff for D27037: Split out cwd/root/jail, cmask state from filedesc table.
  • Mechanically rename pathsdesc to pwddesc. No functional change.
Tue, Nov 3, 5:48 AM
cem closed D27015: linux(4) prctl(2): Implement PR_[GS]ET_DUMPABLE.
Tue, Nov 3, 2:11 AM
cem committed rS367290: linux(4) prctl(2): Implement PR_[GS]ET_DUMPABLE.
linux(4) prctl(2): Implement PR_[GS]ET_DUMPABLE
Tue, Nov 3, 2:11 AM
cem closed D27012: linux(4): Emulate Linux SOL_SOCKET:SO_PASSCRED.
Tue, Nov 3, 1:19 AM
cem committed rS367288: linux(4): Emulate Linux SOL_SOCKET:SO_PASSCRED.
linux(4): Emulate Linux SOL_SOCKET:SO_PASSCRED
Tue, Nov 3, 1:19 AM
cem closed D27011: unix(4): Add SOL_LOCAL:LOCAL_PASSCRED.
Tue, Nov 3, 1:17 AM
cem committed rS367287: unix(4): Add SOL_LOCAL:LOCAL_CREDS_PERSISTENT.
unix(4): Add SOL_LOCAL:LOCAL_CREDS_PERSISTENT
Tue, Nov 3, 1:17 AM
cem updated the diff for D27011: unix(4): Add SOL_LOCAL:LOCAL_PASSCRED.
  • Fix PCB lock leak
  • Fix 'error' assignment operator
Tue, Nov 3, 1:15 AM
cem added inline comments to D27011: unix(4): Add SOL_LOCAL:LOCAL_PASSCRED.
Tue, Nov 3, 1:12 AM
cem committed rS367286: linux(4): style: Eliminate dead 'break' after 'return'.
linux(4): style: Eliminate dead 'break' after 'return'
Tue, Nov 3, 1:10 AM
cem updated the diff for D27015: linux(4) prctl(2): Implement PR_[GS]ET_DUMPABLE.
  • Unify return style of GET/SET cases in switch
Tue, Nov 3, 1:08 AM
cem added inline comments to D27015: linux(4) prctl(2): Implement PR_[GS]ET_DUMPABLE.
Tue, Nov 3, 1:05 AM

Mon, Nov 2

cem updated the diff for D27012: linux(4): Emulate Linux SOL_SOCKET:SO_PASSCRED.

Rebase on parent revision changes.

Mon, Nov 2, 9:19 PM
cem updated the diff for D27011: unix(4): Add SOL_LOCAL:LOCAL_PASSCRED.
  • Rename WANTCRED => WANTCRED_ONESHOT
  • Rename LOCAL_PASSCRED to LOCAL_CREDS_PERSISTENT
  • Make LOCAL_CREDS{,_PERSISTENT} mutually exlusive (EINVAL from setsockopt) and document in manual page.
Mon, Nov 2, 9:18 PM
cem updated the diff for D27047: Add sbuf streaming mode to pseudofs(9), use in linprocfs(5).
  • Fix buflen+1 logic. As a side effect, the maximal limit for pfs fill routines is one byte smaller (of 1MB).
  • Drop compound literal for struct initialization.
Mon, Nov 2, 8:47 PM
cem added inline comments to D27047: Add sbuf streaming mode to pseudofs(9), use in linprocfs(5).
Mon, Nov 2, 8:42 PM
cem updated the diff for D27015: linux(4) prctl(2): Implement PR_[GS]ET_DUMPABLE.
  • Fix PID passed to kern_procctl. Previously, the syscall would manipulate the tracability of the kernel 0 process, which is probably meaningless and certainly not intended.
Mon, Nov 2, 8:30 PM
cem added inline comments to D27015: linux(4) prctl(2): Implement PR_[GS]ET_DUMPABLE.
Mon, Nov 2, 8:09 PM
cem closed D27050: linux(4): Quiesce unrecognized ioctl warning for F2FS query.
Mon, Nov 2, 6:46 PM
cem committed rS367279: linux(4): Quiesce unrecognized ioctl warning for F2FS query.
linux(4): Quiesce unrecognized ioctl warning for F2FS query
Mon, Nov 2, 6:46 PM