- User Since
- Jul 9 2015, 9:56 PM (140 w, 3 d)
Rather than churning all of the locations that use a 2-argument timespecfoo(), did you consider a compatibility implementation like this?
Sat, Mar 17
Fix IV size and passthrough to underlying implementation. With this change,
cryptocheck (with added chacha20 mode, linked aginst openssl-devel 1.1 from
Following up, as this one is still open and it's been a while.
Fix logic error in key size validation and improve CRYPTDEBUG() while here.
I didn't look at parse_dir_md() yet.
Fri, Mar 16
Sure, thanks for reviewing!
Update with feedback from delphij:
Incorporate delphij's feedback:
Thu, Mar 15
Ping — this one is pretty short and sweet. I'd like to get this in before the other change, if there's no objection.
Anything else for this review?
Incorporate Mark's feedback:
Thanks for taking a look!
Fix build on powerpc.
Wed, Mar 14
Tue, Mar 13
New review for randomdev changes is at https://reviews.freebsd.org/D14684 .
Remove randomdev.c changes from this review.
Mon, Mar 12
Address CR feedback:
- Allow interruption of very large random(4) / getrandom(2) read requests (check is performed at the 10MB boundary). (delphij)
- Style fixes and test robustness enhancement. (markj)
I'd suggest skipping over sys/contrib/libb2 entirely; it's uninteresting and just a direct import of files from libb2 from Github. You can verify 1:1 if you want.
conf/files: Also build in blake2 for ipsec | ipsec_support (forced by
Sun, Mar 11
Sat, Mar 10
Thu, Mar 8
I was going to test the behavior re: interruption on Linux with the following test program, but I do not have enough free RAM on my Linux system because it is also running Chrome 😂 😂 😂 . If anyone else has 2GB of RAM spare, the following test might be interesting (try pressing Ctrl+C after starting it):
Wed, Mar 7
Ditto Warner — polling /etc/localtime is probably the wrong approach. Sure, you've gotten rid of stat(2) on every single ctime() invocation, but instead we clock_gettime(2) every time instead (and poll the file every 10 seconds). I would also suggest a kqueue/kevent monitor.
Ping @secteam, it's been about a week. This change is pretty trivially correct. I'm ready to "Approved by: secteam (timeout)". Thanks.
(Secteam blessing needed only for trivial dev/random change.)
Add getrandom to truss(1).
Tue, Mar 6
Incorporate delphij's suggestions:
Remove duplicate freebsd32_getrandom and just re-use sys_getrandom -- jhb's
I am still not a fan of the giant macro approach, but I won't stand in the way of committing more tftpd tests. Go ahead, just don't include me in 'Reviewed by.'
Mon, Mar 5
Sat, Mar 3
Keep in mind the compat32 and Linux syscall tables could benefit from a very similar treatment.
Seems fine in principle. I haven't audited the entire table for correctness. It would be good to document the available annotations and what they mean somewhere (a manual page?).