Page MenuHomeFreeBSD

cem (Conrad Meyer)
User

Projects

User Details

User Since
Jul 9 2015, 9:56 PM (192 w, 6 d)

Recent Activity

Yesterday

cem accepted D19663: DTF_REWIND does nothing (since rS247236), so retire its use.
Wed, Mar 20, 11:40 PM
cem created D19665: x86: Use XSAVEOPT for fpusave(), when available.
Wed, Mar 20, 9:53 PM
cem accepted D19649: Rename fuse(4) to fusefs(4).
Wed, Mar 20, 9:44 PM
cem added a comment to D19649: Rename fuse(4) to fusefs(4).

Looks good other than sys/conf/files

Wed, Mar 20, 6:51 PM
cem requested changes to D19651: Add a fusefs(5) man page.
Wed, Mar 20, 4:38 AM

Tue, Mar 19

cem accepted D19651: Add a fusefs(5) man page.

Ah thanks for the catch on attilio's actual @freebsd address

Tue, Mar 19, 11:21 PM
cem added a comment to D19649: Rename fuse(4) to fusefs(4).

The moduledata changes, sysctl changes, jail changes, renaming the kld, etc, look good to me. And the backwards compat symlink is a nice touch as well. But please don't move the filesystem sources.

Tue, Mar 19, 10:24 PM
cem requested changes to D19649: Rename fuse(4) to fusefs(4).

Please don't move the directory from sys/fs/fuse to sys/fs/fusefs. It just adds needless churn to the history.

Tue, Mar 19, 10:10 PM
cem added a comment to D19651: Add a fusefs(5) man page.

Thanks for doing this. We've needed a page for a while. Have you run it past the igor tool?

Tue, Mar 19, 10:08 PM

Sat, Mar 16

cem accepted D13910: `make buildkernel' should display the build time in seconds.

Thanks, LGTM

Sat, Mar 16, 5:43 PM · Contributor Reviews (base)

Fri, Mar 15

cem committed rS345206: stack(9): Drop unused API mode and comment that referenced it.
stack(9): Drop unused API mode and comment that referenced it
Fri, Mar 15, 10:40 PM
cem closed D19601: stack(9): Drop unused API mode and comment that referenced it.
Fri, Mar 15, 10:40 PM
cem created D19601: stack(9): Drop unused API mode and comment that referenced it.
Fri, Mar 15, 9:55 PM
cem added inline comments to D19596: VOP_INACTIVE(9): clarify wording.
Fri, Mar 15, 6:11 PM
cem added inline comments to D19596: VOP_INACTIVE(9): clarify wording.
Fri, Mar 15, 5:50 PM
cem added inline comments to D19596: VOP_INACTIVE(9): clarify wording.
Fri, Mar 15, 5:48 PM
cem added inline comments to D19596: VOP_INACTIVE(9): clarify wording.
Fri, Mar 15, 5:44 PM
cem added inline comments to D19596: VOP_INACTIVE(9): clarify wording.
Fri, Mar 15, 5:43 PM

Thu, Mar 14

cem committed rS345158: bhyve(8): Fix uart emulation bug.
bhyve(8): Fix uart emulation bug
Thu, Mar 14, 9:09 PM

Tue, Mar 12

cem added inline comments to D19548: Add fileargs_lstat to cap_fileargs service.
Tue, Mar 12, 2:52 PM

Mon, Mar 11

cem added a comment to D19548: Add fileargs_lstat to cap_fileargs service.

I did not look too closely at the caching bits. The rest looks mostly good. Some feedback below.

Mon, Mar 11, 10:59 PM
cem accepted D13911: `make buildworld' should display the build time in seconds.
Mon, Mar 11, 5:54 PM · Contributor Reviews (base)
cem accepted D19531: ports.7: Add an example of how to use flavors.

Looks good to me. Thank you!

Mon, Mar 11, 5:51 PM
cem requested changes to D19531: ports.7: Add an example of how to use flavors.

Thanks for doing this, I really appreciate it!

Mon, Mar 11, 1:27 AM

Fri, Mar 8

cem added a comment to D16856: Initial proposed patch for SSL root bundle in base.

The build system mechanics look good to me. I haven't looked at the Perl script, and frankly, I find Perl pretty inscrutable and may not be best at spotting bugs in it.

Fri, Mar 8, 8:40 PM
cem closed D19494: www/chromium: Remove reference to obsolete FreeBSD.
Fri, Mar 8, 4:10 PM
cem committed rP495053: www/chromium: Remove reference to obsolete FreeBSD.
www/chromium: Remove reference to obsolete FreeBSD
Fri, Mar 8, 4:10 PM
cem added inline comments to D19495: bhyve - Snapshot Save and Restore.
Fri, Mar 8, 3:56 PM · bhyve
cem committed rS344913: Fortuna: Add Chacha20 as an alternative stream cipher.
Fortuna: Add Chacha20 as an alternative stream cipher
Fri, Mar 8, 1:17 AM
cem closed D19475: Fortuna: Add Chacha20 as an alternative stream cipher.
Fri, Mar 8, 1:17 AM

Thu, Mar 7

cem updated the diff for D19475: Fortuna: Add Chacha20 as an alternative stream cipher.

Put non-negative logical case first, for clarity. Thanks delphij@

Thu, Mar 7, 10:18 PM
cem planned changes to D19475: Fortuna: Add Chacha20 as an alternative stream cipher.
Thu, Mar 7, 10:07 PM
cem committed rS344891: seq(1): Require user-provided format strings to contain a conversion.
seq(1): Require user-provided format strings to contain a conversion
Thu, Mar 7, 6:24 PM
cem created D19494: www/chromium: Remove reference to obsolete FreeBSD.
Thu, Mar 7, 3:36 PM
cem added a reviewer for D19475: Fortuna: Add Chacha20 as an alternative stream cipher: secteam.

Need secteam blessing to touch dev/random. Thanks!

Thu, Mar 7, 3:27 PM
cem abandoned D19332: fuse: switch from DFLTPHYS/MAXBSIZE to maxcachebuf.

rS344865

Thu, Mar 7, 12:56 AM
cem committed rS344865: fuse: switch from DFLTPHYS/MAXBSIZE to maxcachebuf.
fuse: switch from DFLTPHYS/MAXBSIZE to maxcachebuf
Thu, Mar 7, 12:56 AM

Wed, Mar 6

cem committed rS344857: FUSE: Prevent trivial panic.
FUSE: Prevent trivial panic
Wed, Mar 6, 10:57 PM
cem updated the diff for D19475: Fortuna: Add Chacha20 as an alternative stream cipher.

Fix a 'doh!' copy/paste error on archs without a uint128 type.

Wed, Mar 6, 4:17 PM
cem updated the test plan for D19475: Fortuna: Add Chacha20 as an alternative stream cipher.
Wed, Mar 6, 4:12 PM
cem added a comment to D19475: Fortuna: Add Chacha20 as an alternative stream cipher.

Nice work! Out for interest, why make the output generator selectable? Why not switch completely to Chacha20?

Wed, Mar 6, 3:42 PM
cem updated the test plan for D19475: Fortuna: Add Chacha20 as an alternative stream cipher.
Wed, Mar 6, 6:00 AM
cem created D19475: Fortuna: Add Chacha20 as an alternative stream cipher.
Wed, Mar 6, 5:58 AM

Fri, Mar 1

cem added a comment to D19265: libctf, dtrace: Plumb through support for CONSTVAL values.

So probably we're mishandling a request for an argument value beyond the end of the valid parameters list.

Fri, Mar 1, 11:36 PM
cem committed rS344714: Embedded chacha: Add 0-bit iv + 128-bit counter mode.
Embedded chacha: Add 0-bit iv + 128-bit counter mode
Fri, Mar 1, 11:30 PM
cem closed D19410: Embedded chacha: Add 0-bit iv + 128-bit counter build mode.
Fri, Mar 1, 11:30 PM
cem committed rS344713: fortuna: Deduplicate kernel vs user includes.
fortuna: Deduplicate kernel vs user includes
Fri, Mar 1, 10:52 PM
cem closed D19409: fortuna: Deduplicate kernel vs user includes.
Fri, Mar 1, 10:52 PM
cem added a comment to D19409: fortuna: Deduplicate kernel vs user includes.

Thanks!

Fri, Mar 1, 10:49 PM
cem committed rS344710: Fortuna: push CTR-mode loop down into randomdev hash.h interface.
Fortuna: push CTR-mode loop down into randomdev hash.h interface
Fri, Mar 1, 7:22 PM
cem closed D19411: Fortuna: push CTR-mode loop down into randomdev hash.h interface.
Fri, Mar 1, 7:22 PM
cem added a comment to D19411: Fortuna: push CTR-mode loop down into randomdev hash.h interface.

Thanks!

Fri, Mar 1, 7:04 PM
cem added reviewers for D19411: Fortuna: push CTR-mode loop down into randomdev hash.h interface: secteam, Core Team, gordon.

Need secteam/so/core blessing.

Fri, Mar 1, 7:02 PM
cem added reviewers for D19409: fortuna: Deduplicate kernel vs user includes: secteam, Core Team, gordon.

I guess I need blessing from secteam, so@, or core to touch dev/random. Can one of y'all quickly bless this non-functional change?

Fri, Mar 1, 7:01 PM
cem added a comment to D19265: libctf, dtrace: Plumb through support for CONSTVAL values.

My notion is that any time a script refers to a constval args[n], libdtrace would emit the "load immediate" DIF instruction which loads the constant value into a register, and any time it refers to a non-constval args[n+1], libdtrace knows to emit DIF with the ABI argument index shifted to take into account the fact that args[n] isn't represented in the ABI.

...
I haven't yet tried to figure that out.

Fri, Mar 1, 6:41 PM
cem added a comment to D19411: Fortuna: push CTR-mode loop down into randomdev hash.h interface.

I like this!

Fri, Mar 1, 6:03 PM
cem created D19411: Fortuna: push CTR-mode loop down into randomdev hash.h interface.
Fri, Mar 1, 5:12 AM
cem added reviewers for D19410: Embedded chacha: Add 0-bit iv + 128-bit counter build mode: markm, delphij.
Fri, Mar 1, 2:53 AM
cem created D19410: Embedded chacha: Add 0-bit iv + 128-bit counter build mode.
Fri, Mar 1, 2:52 AM
cem created D19409: fortuna: Deduplicate kernel vs user includes.
Fri, Mar 1, 1:58 AM
cem committed rS344678: cxgb(4): Netdump: only reference allocated qsets.
cxgb(4): Netdump: only reference allocated qsets
Fri, Mar 1, 1:57 AM
cem closed D17274: cxgb(4): Netdump: only reference allocated qsets.
Fri, Mar 1, 1:57 AM
cem added a comment to D19265: libctf, dtrace: Plumb through support for CONSTVAL values.
In D19265#414685, @cem wrote:

My notion is that any time a script refers to a constval args[n], libdtrace would emit the "load immediate" DIF instruction which loads the constant value into a register, and any time it refers to a non-constval args[n+1], libdtrace knows to emit DIF with the ABI argument index shifted to take into account the fact that args[n] isn't represented in the ABI.

Fri, Mar 1, 1:30 AM
cem updated the diff for D19264: ctf: Add support for typed constant values.

Use C99 initializers in a few more dispatch tables and clarify wording of ctfdump CONSTVAL type output

Fri, Mar 1, 1:05 AM
cem added inline comments to D19264: ctf: Add support for typed constant values.
Fri, Mar 1, 12:46 AM

Thu, Feb 28

cem added inline comments to D19407: Port openrsync to FreeBSD using capsicum.
Thu, Feb 28, 11:21 PM
cem added inline comments to D19264: ctf: Add support for typed constant values.
Thu, Feb 28, 11:17 PM
cem added inline comments to D19407: Port openrsync to FreeBSD using capsicum.
Thu, Feb 28, 10:52 PM
cem added inline comments to D19407: Port openrsync to FreeBSD using capsicum.
Thu, Feb 28, 10:20 PM
cem added inline comments to D19407: Port openrsync to FreeBSD using capsicum.
Thu, Feb 28, 8:55 PM

Wed, Feb 27

cem added a comment to D19265: libctf, dtrace: Plumb through support for CONSTVAL values.
In D19265#413165, @cem wrote:

Sorry, I was in a rush when I wrote that and should have said more. To me, this fix would ideally not touch the kernel components at all: the kernel's notion of function arguments should be limited to the ABI.

Wed, Feb 27, 3:16 AM
cem added a reviewer for D19372: Have cryptocheck toggle kern.cryptodevallowsoft as needed: jhb.

Seems unobjectionable to me. Ok by you, John?

Wed, Feb 27, 12:12 AM

Mon, Feb 25

cem accepted D19266: Modularize xz..
Mon, Feb 25, 10:34 PM

Sun, Feb 24

cem created D19332: fuse: switch from DFLTPHYS/MAXBSIZE to maxcachebuf.
Sun, Feb 24, 8:53 PM
cem committed rP493797: graphics/libheif: Correct license, OPTIONize, add jpeg support.
graphics/libheif: Correct license, OPTIONize, add jpeg support
Sun, Feb 24, 6:42 PM
cem closed D18802: graphics/libheif: Clean up Makefile, add JPEG by default.
Sun, Feb 24, 6:42 PM
cem updated the diff for D19264: ctf: Add support for typed constant values.
  • Pull out !hasconst case and de-indent
  • Use designated initializers in a few more places
Sun, Feb 24, 6:31 PM

Sat, Feb 23

cem added a comment to D19265: libctf, dtrace: Plumb through support for CONSTVAL values.

Thanks for taking a look!

Sat, Feb 23, 3:52 AM
cem added inline comments to D19264: ctf: Add support for typed constant values.
Sat, Feb 23, 3:34 AM
cem added inline comments to D19245: Add support for legacy 512-byte block size MBRs on 4K block size disks.
Sat, Feb 23, 12:42 AM

Fri, Feb 22

cem accepted D11482: Make compiler-rt's quad-math routines available to libgcc_s.
Fri, Feb 22, 7:04 PM
cem added a comment to D19105: CID 1008620: Logically dead code in newsyslog.c.
In D19105#412978, @dab wrote:

As @cem pointed out, the memory is going to get freed anyway and there are other code paths that will still "leak" the memory. After I'd committed the changes there was additional discussion on the mailing list that convinced me it was a bad idea to sprinkle the free() calls around that would deallocate this memory.

Fri, Feb 22, 6:26 PM
cem added a comment to D19266: Modularize xz..

geom_uzip(4) uses zlib module without the need to add dummy "device zlib" into kernel, why xz code should be any different?

Fri, Feb 22, 4:58 AM

Thu, Feb 21

cem accepted D19273: Fix a hash table lookup race in fasttrap_pid_probe()..
Thu, Feb 21, 4:38 AM
cem added a comment to D19231: Fix few issues in ioat(4) driver..

To summarize: LGTM

Thu, Feb 21, 4:33 AM
cem added a comment to D19231: Fix few issues in ioat(4) driver..

Thanks! I really appreciate additional eyes/interest and improvement for this driver.

Thu, Feb 21, 4:26 AM
cem accepted D19273: Fix a hash table lookup race in fasttrap_pid_probe()..
In D19273#412540, @cem wrote:

Solve the race using a per-process generation counter which gets updated
before a tracepoint is removed from the hash table, and after it is
removed from the target process' vmspace.

We do the latter, but I think we're missing the former.

Why? The code immediately after the increment updates the hash table.

Thu, Feb 21, 3:52 AM
cem committed rS344407: fuse: Fix a regression introduced in r337165.
fuse: Fix a regression introduced in r337165
Thu, Feb 21, 2:42 AM
cem requested changes to D19273: Fix a hash table lookup race in fasttrap_pid_probe()..

I wasn't careful about preserving #ifdefs here: fasttrap has been virtually untouched upstream for the past 5 years, so once this commit is in I'm going to get rid of illumos ifdefs there in an attempt to make the code a bit easier to read.

Thu, Feb 21, 2:02 AM
cem accepted D19266: Modularize xz..
Thu, Feb 21, 12:58 AM

Wed, Feb 20

cem requested changes to D19245: Add support for legacy 512-byte block size MBRs on 4K block size disks.
Wed, Feb 20, 11:33 PM
cem added a reviewer for D19273: Fix a hash table lookup race in fasttrap_pid_probe().: cem.
Wed, Feb 20, 11:11 PM
cem added a comment to D19264: ctf: Add support for typed constant values.

Prior to this change, ctfdump shows [2] FUNC (kern_chflagsat) returns: 1 args: (1173, 1, 5, 142, 91, 1); ... <142> ENUM uio_seg (i.e., no idea it's been const-ed out of the ABI).

Wed, Feb 20, 4:59 PM
cem added a comment to D19264: ctf: Add support for typed constant values.

Can you provide an example DIE where this occurs? Which compiler are you using?

Wed, Feb 20, 4:49 PM
cem updated the test plan for D19265: libctf, dtrace: Plumb through support for CONSTVAL values.
Wed, Feb 20, 7:00 AM
cem added a parent revision for D19265: libctf, dtrace: Plumb through support for CONSTVAL values: D19264: ctf: Add support for typed constant values.
Wed, Feb 20, 6:57 AM
cem added a child revision for D19264: ctf: Add support for typed constant values: D19265: libctf, dtrace: Plumb through support for CONSTVAL values.
Wed, Feb 20, 6:57 AM
cem created D19265: libctf, dtrace: Plumb through support for CONSTVAL values.
Wed, Feb 20, 6:57 AM
cem created D19264: ctf: Add support for typed constant values.
Wed, Feb 20, 6:50 AM
cem committed rS344334: Fuse: whitespace and style(9) cleanup.
Fuse: whitespace and style(9) cleanup
Wed, Feb 20, 2:49 AM