Page MenuHomeFreeBSD

cem (Conrad Meyer)
User

Projects

User Details

User Since
Jul 9 2015, 9:56 PM (178 w, 4 d)

Recent Activity

Today

cem planned changes to D18506: efirt: When present, attempt to use EFI runtime services to shutdown.

Netflix doesn't use efi_system_reset() in our version of FreeBSD. Changing the signature is likely fine.

Tue, Dec 11, 7:58 AM
cem added reviewers for D18506: efirt: When present, attempt to use EFI runtime services to shutdown: imp, byuu_tutanota.com.
Tue, Dec 11, 2:25 AM
cem created D18506: efirt: When present, attempt to use EFI runtime services to shutdown.
Tue, Dec 11, 2:23 AM
cem committed rS341803: rc.subr: Implement list_vars without using 'read'.
rc.subr: Implement list_vars without using 'read'
Tue, Dec 11, 1:39 AM
cem closed D18481: rc.subr: Implement list_vars without using 'read'.
Tue, Dec 11, 1:39 AM

Yesterday

cem added inline comments to D18481: rc.subr: Implement list_vars without using 'read'.
Mon, Dec 10, 11:47 PM
cem updated the diff for D18481: rc.subr: Implement list_vars without using 'read'.

Put 'local' variables on the same line; just forgot to do this last revision.

Mon, Dec 10, 7:11 PM
cem added inline comments to D18481: rc.subr: Implement list_vars without using 'read'.
Mon, Dec 10, 7:08 PM
cem resigned from D18495: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.

I'm not familiar with this tool or the test anymore, and not interested in studying it again now. I'm sure your fix is fine, but I am not a good reviewer.

Mon, Dec 10, 6:58 PM
cem added inline comments to D18481: rc.subr: Implement list_vars without using 'read'.
Mon, Dec 10, 12:22 AM

Sat, Dec 8

cem added inline comments to D18481: rc.subr: Implement list_vars without using 'read'.
Sat, Dec 8, 11:57 PM
cem updated the diff for D18481: rc.subr: Implement list_vars without using 'read'.
  • comment the full behavior of 'local -' rather than the subset used in this function, per dteske
  • Use the slightly more explicit 'set -o noglob', in preference to 'set -f', per jilles
  • De-indent cases, to match existing style (per dteske and jilles)
  • Drop case body statements to independent lines -- unlike in C, there is a lot going on in the 'case' itself
Sat, Dec 8, 10:46 PM
cem added inline comments to D18481: rc.subr: Implement list_vars without using 'read'.
Sat, Dec 8, 10:32 PM
cem accepted D18458: Capsicumize savecore(8)..

I didn't know we built a rescue savecore!

Sat, Dec 8, 7:35 PM
cem updated the test plan for D18481: rc.subr: Implement list_vars without using 'read'.
Sat, Dec 8, 2:34 AM

Fri, Dec 7

cem updated the test plan for D18481: rc.subr: Implement list_vars without using 'read'.
Fri, Dec 7, 10:52 PM
cem updated the diff for D18481: rc.subr: Implement list_vars without using 'read'.
  • set -f
  • s/LINE/line/
Fri, Dec 7, 10:45 PM
cem created D18481: rc.subr: Implement list_vars without using 'read'.
Fri, Dec 7, 10:35 PM
cem added inline comments to D9759: amdtemp driver update.
Fri, Dec 7, 7:50 PM · x86
cem accepted D18458: Capsicumize savecore(8)..
Fri, Dec 7, 6:47 PM
cem accepted D18458: Capsicumize savecore(8)..
Fri, Dec 7, 5:19 PM
cem added inline comments to D18458: Capsicumize savecore(8)..
Fri, Dec 7, 5:16 PM
cem added inline comments to D18458: Capsicumize savecore(8)..
Fri, Dec 7, 4:22 PM
cem committed rS341674: gmirror: Evaluate mirror components against newest metadata copy.
gmirror: Evaluate mirror components against newest metadata copy
Fri, Dec 7, 2:46 AM
cem accepted D18458: Capsicumize savecore(8)..

Generally LGTM. Thanks for doing this.

Fri, Dec 7, 2:43 AM
cem committed rS341672: Revert r341665 due to tinderbox breakage.
Revert r341665 due to tinderbox breakage
Fri, Dec 7, 12:47 AM

Thu, Dec 6

cem committed rS341665: gmirror: Evaluate mirror components against newest metadata copy.
gmirror: Evaluate mirror components against newest metadata copy
Thu, Dec 6, 11:56 PM
cem closed D18062: gmirror: Evaluate mirror components against newest metadata copy.
Thu, Dec 6, 11:56 PM
cem accepted D18459: Const poison the command interface.
Thu, Dec 6, 10:43 PM
cem added inline comments to D18062: gmirror: Evaluate mirror components against newest metadata copy.
Thu, Dec 6, 10:20 PM
cem accepted D18455: Dynamically load .so modules to expand functionality.

LGTM. I still find the 'mirror' name confusing, but maybe that's a personal problem ;-).

Thu, Dec 6, 10:09 PM
cem added inline comments to D18062: gmirror: Evaluate mirror components against newest metadata copy.
Thu, Dec 6, 10:04 PM
cem accepted D18460: Move intel and wdc files to their own modules.
Thu, Dec 6, 8:04 PM
cem added a comment to D18455: Dynamically load .so modules to expand functionality.

Mostly LGTM, thanks.

Thu, Dec 6, 8:03 PM
cem updated the diff for D18062: gmirror: Evaluate mirror components against newest metadata copy.

Test code:

  • Remove extraneous sleeps
  • Check that generation ids compare in expectated order
  • Add additional tests that mirror components are evicted during STARTING, prior to 'gmirror status', via geom reference counts.
  • Use gmirror label -h and insert -h instead of gnop -o 512
Thu, Dec 6, 7:27 PM
cem updated the test plan for D18322: Expose threads-per-core and physical core count information.
Thu, Dec 6, 5:15 PM
cem added inline comments to D18322: Expose threads-per-core and physical core count information.
Thu, Dec 6, 5:14 PM
cem updated the diff for D18062: gmirror: Evaluate mirror components against newest metadata copy.

Fix brain-o in cleanup leading to tty-read stall / kyua failure.

Thu, Dec 6, 3:33 AM
cem added inline comments to D18322: Expose threads-per-core and physical core count information.
Thu, Dec 6, 3:28 AM
cem added inline comments to D18062: gmirror: Evaluate mirror components against newest metadata copy.
Thu, Dec 6, 2:51 AM
cem added inline comments to D18062: gmirror: Evaluate mirror components against newest metadata copy.
Thu, Dec 6, 2:23 AM
cem updated the diff for D18062: gmirror: Evaluate mirror components against newest metadata copy.

Add a basic test case showing we evict stale mirror components (on the basis of
genid, anyway).

Thu, Dec 6, 2:00 AM

Wed, Dec 5

cem added a comment to D18062: gmirror: Evaluate mirror components against newest metadata copy.
In D18062#392769, @pho wrote:

I have started the tests.

Wed, Dec 5, 8:14 PM
cem updated the diff for D18062: gmirror: Evaluate mirror components against newest metadata copy.
  • gmirrors -> mirrors in sysctl description
  • drop g_mirror_ctl.c change for now
Wed, Dec 5, 6:29 PM
cem updated the diff for D18062: gmirror: Evaluate mirror components against newest metadata copy.

Move metadata kickout loop above quorum check.

Wed, Dec 5, 2:44 AM
cem added inline comments to D18062: gmirror: Evaluate mirror components against newest metadata copy.
Wed, Dec 5, 1:11 AM

Tue, Dec 4

cem added inline comments to D18048: Introduce driver for TPM 2.0 in CRB and FIFO (TIS) modes..
Tue, Dec 4, 5:09 PM
cem added a comment to D14409: Sandbox head(1) with fileargs..
In D14409#392398, @mmel wrote:

if you run 'head' on

**kernel**  compiled  without 'option CAPSICUM' then it fail with 'function not implemented'.
Tue, Dec 4, 5:02 PM

Mon, Dec 3

cem abandoned D18327: graphics/drm-next-kmod: Add hack to help make AMD drivers usable.

This isn't the leak, and radeon crashed on me too many times for non-memleak reasons. Now happily using the nvidia binary driver with the 610 GT I had lying around :-).

Mon, Dec 3, 5:42 PM
cem added a comment to D18048: Introduce driver for TPM 2.0 in CRB and FIFO (TIS) modes..

Some initial comments. I'm not necessarily a good reviewer to wait on for this, sorry. I'm unfamiliar with TPM and don't have time to study it now.

Mon, Dec 3, 5:13 PM

Sun, Dec 2

cem accepted D18403: Move nvmecontrol to using linker sets.

The new changes LGTM. The scope of this review is getting broader than I'd prefer, though. It'd be easier on me as a reviewer if any future scope increases went into a new review. (I understand that's more work for you as long as this portion is in flux, but maybe that's motivation for getting this batch committed first? :-))

Sun, Dec 2, 6:13 PM
cem accepted D18403: Move nvmecontrol to using linker sets.
In D18403#391655, @imp wrote:

Thanks for the feedback. I'll see how much I can include in my next round as some of them are asking for more structural changes beyond the scope of this set of changes (the suggestions are good, btw, just am keen to avoid too much scope creep).

Sun, Dec 2, 1:03 AM

Sat, Dec 1

cem added a comment to D18403: Move nvmecontrol to using linker sets.

Mostly looks good to me. A few suggestions but nothing show-stopping other than the "Unknown command" thing. Thanks!

Sat, Dec 1, 11:08 PM
cem committed rS341389: pmcr: Fix pstate setting on Power8.
pmcr: Fix pstate setting on Power8
Sat, Dec 1, 9:38 PM
cem committed rS341388: Restore build of the kernel, removed through r341377.
Restore build of the kernel, removed through r341377
Sat, Dec 1, 9:28 PM
cem added a comment to D18380: Fix a number of style issues with trim(8).

There is nothing GEOM-specific in this ioctl and 'G' in the name seems to be kind of mistake in the retrospection (it was not 11 years ago).

Sat, Dec 1, 2:19 AM

Fri, Nov 30

cem added inline comments to D18380: Fix a number of style issues with trim(8).
Fri, Nov 30, 5:57 PM
cem added inline comments to D18380: Fix a number of style issues with trim(8).
Fri, Nov 30, 5:54 PM
cem added a comment to D18380: Fix a number of style issues with trim(8).

First, DIOCGDELETE is not GEOM-specific ioctl()

Fri, Nov 30, 5:36 PM
cem added inline comments to D18380: Fix a number of style issues with trim(8).
Fri, Nov 30, 6:11 AM
cem edited P239 Masterwork From Distant Lands.
Fri, Nov 30, 6:11 AM
cem added inline comments to D18380: Fix a number of style issues with trim(8).
Fri, Nov 30, 5:50 AM

Wed, Nov 28

cem added inline comments to D18062: gmirror: Evaluate mirror components against newest metadata copy.
Wed, Nov 28, 9:45 PM
cem added inline comments to D18062: gmirror: Evaluate mirror components against newest metadata copy.
Wed, Nov 28, 3:09 AM

Tue, Nov 27

cem updated the diff for D18062: gmirror: Evaluate mirror components against newest metadata copy.
  • Restore stale component kick-out to g_mirror_device_update, but relocate it *prior* to determining whether or not we have quorum to RUN the mirrorset.
  • Perform sanity check assertions re: accumulated sc_genid and sc_syncid at the same time.
  • For now, continue to kill mismatched md_all components *of the quorum genid*. Newer genid md_all components will override mirrorset configuration at taste time.
  • Skip stale mirrors during g_mirror_add_disk prior to attempting to refresh from them.
  • Remove stale component kick-out from g_mirror_add_disk. As Markj@ points out, g_mirror_add_disk synchronously invokes g_mirror_disk_update and g_mirror_device_update via g_mirror_event_send() in the middle of g_mirror_add_disk. So we might as well centralize back in g_mirror_device_update.
  • Simplify early exit logic in g_mirror_refresh_device(), per markj@.
Tue, Nov 27, 5:41 AM
cem planned changes to D18062: gmirror: Evaluate mirror components against newest metadata copy.
Tue, Nov 27, 5:24 AM

Mon, Nov 26

cem added inline comments to D18062: gmirror: Evaluate mirror components against newest metadata copy.
Mon, Nov 26, 7:54 PM
cem added inline comments to D18062: gmirror: Evaluate mirror components against newest metadata copy.
Mon, Nov 26, 5:50 PM
cem updated the diff for D18062: gmirror: Evaluate mirror components against newest metadata copy.
  • Fix indentation
  • Common subroutine for softc field initialization from md
Mon, Nov 26, 5:46 PM
cem planned changes to D18327: graphics/drm-next-kmod: Add hack to help make AMD drivers usable.
Mon, Nov 26, 5:01 PM
cem committed rP485945: www/elinks: Fix build on OpenSSL 1.1.1.
www/elinks: Fix build on OpenSSL 1.1.1
Mon, Nov 26, 4:40 PM
cem closed D18325: www/elinks: Fix build on OpenSSL 1.1.1.
Mon, Nov 26, 4:40 PM
cem added a comment to D18325: www/elinks: Fix build on OpenSSL 1.1.1.

No problem!

Mon, Nov 26, 4:33 PM
cem added a comment to D18327: graphics/drm-next-kmod: Add hack to help make AMD drivers usable.

Mark might be on to something. I went back and looked at my syslog from before the system totally hung and guess what? After a bunch of swap_pager_getswapspace spam (seriously, 62567/69256 log lines between Nov 19 and 24 are this message), and buried a little (it's not in the bottom 100 lines or so prior to the shutdown due to more swap_pager lines), we see:

Mon, Nov 26, 1:10 AM

Sun, Nov 25

cem added a comment to D18327: graphics/drm-next-kmod: Add hack to help make AMD drivers usable.
In D18327#389053, @jmd wrote:

Thanks for figuring this out!

We'd prefer to have the TTM patch directly in our github to forward carry it easily and also apply it to all existing branches and ports - could you make a PR there for the TTM change? If not, I'm happy to do that.

Sun, Nov 25, 11:37 PM
cem added a comment to D18327: graphics/drm-next-kmod: Add hack to help make AMD drivers usable.

it's a last resort mechanism, as opposed to the regular PID-controller pagedaemons

It should run regularly (with a 10s period) whenever the pagedaemon is attempting to reclaim pages.

Sun, Nov 25, 11:37 PM
cem added a comment to D18062: gmirror: Evaluate mirror components against newest metadata copy.

Ideally this would come with a regression test.

Sun, Nov 25, 10:21 PM
cem added inline comments to D18062: gmirror: Evaluate mirror components against newest metadata copy.
Sun, Nov 25, 8:26 PM

Sat, Nov 24

cem created D18327: graphics/drm-next-kmod: Add hack to help make AMD drivers usable.
Sat, Nov 24, 11:13 PM
cem created D18325: www/elinks: Fix build on OpenSSL 1.1.1.
Sat, Nov 24, 8:32 PM
cem created D18322: Expose threads-per-core and physical core count information.
Sat, Nov 24, 6:16 AM

Fri, Nov 23

cem committed rS340844: Revert r340843 - addressed independently in r340842!.
Revert r340843 - addressed independently in r340842!
Fri, Nov 23, 6:27 PM
cem committed rS340843: rtld: Silence a false positive GCC 6.4.0 warning.
rtld: Silence a false positive GCC 6.4.0 warning
Fri, Nov 23, 6:23 PM

Thu, Nov 22

cem added inline comments to D18294: netdump: Add ddb 'show netdumpconf' command.
Thu, Nov 22, 5:59 PM

Wed, Nov 21

cem created D18294: netdump: Add ddb 'show netdumpconf' command.
Wed, Nov 21, 11:57 PM
cem added inline comments to D18036: Fix style nits in strings.
Wed, Nov 21, 11:36 PM
cem added inline comments to D18036: Fix style nits in strings.
Wed, Nov 21, 4:37 PM
cem created D18062: gmirror: Evaluate mirror components against newest metadata copy.
Wed, Nov 21, 6:42 AM

Tue, Nov 20

cem accepted D18051: Ensure that all values of ns, us and ms work for {n,u,m}stosbt.

Works for me, thanks. Could we use a similar trick for userspace asserts?

Tue, Nov 20, 2:57 AM

Mon, Nov 19

cem accepted D18051: Ensure that all values of ns, us and ms work for {n,u,m}stosbt.

LGTM!

Mon, Nov 19, 11:11 PM
cem accepted D18051: Ensure that all values of ns, us and ms work for {n,u,m}stosbt.

LGTM modulo nits and assuming that test case will be committed shortly.

Mon, Nov 19, 10:47 PM

Sun, Nov 18

cem accepted D18036: Fix style nits in strings.
Sun, Nov 18, 11:41 PM
cem accepted D18038: Capsicumize strings.
Sun, Nov 18, 11:38 PM
cem accepted D18037: Do not depend on stdin..

I like the change. All of my comments describe existing issues in the code, nothing you introduced in this change. Maybe they can be addressed separately.

Sun, Nov 18, 11:30 PM
cem accepted D18025: Get rid of the special "default" value for dumpon's -g parameter..

Looks great to me, thanks!

Sun, Nov 18, 12:47 AM
cem accepted D18025: Get rid of the special "default" value for dumpon's -g parameter..
Sun, Nov 18, 12:06 AM

Sat, Nov 17

cem added a comment to D18013: Add warning to rc script of files not included by default newsyslog.conf.

I'm not a fan of the general concept. As far as execution goes, I don't believe stdout from rc scripts is logged? So someone would have to be watching boot to notice this? If we must do this, put it in a log file.

Sat, Nov 17, 8:03 AM

Thu, Nov 15

cem accepted D17975: Add taskqueue_quiesce()..

The code and documentation look good; I'm just not sure if we want a new API for this, or if changing taskqueue_drain_all()'s behavior to match this would be unobjectionable.

Thu, Nov 15, 5:34 PM

Wed, Nov 14

cem committed rS340426: amdtemp(4): Fix temperature reporting on AMD 2990WX.
amdtemp(4): Fix temperature reporting on AMD 2990WX
Wed, Nov 14, 4:50 AM
cem closed D16855: Fix temperature reporting on AMD 2990WX.
Wed, Nov 14, 4:50 AM