- User Since
- Jul 9 2015, 9:56 PM (167 w, 10 h)
Wed, Sep 19
Tue, Sep 18
This changes keg cursor advancement behavior slightly. I'm not sure that matters.
Sat, Sep 15
Fri, Sep 14
Looks like kmem_back() can now be entirely removed.
ifdef _KERNEL failpoint sites
Thu, Sep 13
Request for acceptance into head during freeze
Wed, Sep 12
Looks great to me.
Functionality looks good to me. Some minor style suggestions follow.
Tue, Sep 11
Mon, Sep 10
Looks great to me, thanks. Any other reviewers want to take a pass?
Sun, Sep 9
+1 to the general idea from me, and thanks Ed for taking on the work. I will review the patch later.
Hmm. I'm definitely ok rejecting the (hidden) names .sample or .pkgnew, and I think probably rejecting all hidden (dot-prefixed) names would be reasonable.
Sat, Sep 8
Looks great to me! All of my comments below are just style or message suggestions, nothing functional.
Thu, Sep 6
Mostly looks good to me! I had a couple concerns and suggestions, see below. Thanks for the patch.
I realize this is a very bikesheddy ask but would it be at all possible to make the library name longer? libveriexec or something (I don't care in particular). The vast majority of libraries have descriptive names and I don't think scrimping on a few letters is making anyone's life better.
Hi Yuichiro NAITO,
Decode signal return codes from run() more nicely in printed errors.
Wed, Sep 5
Removed extraneous comma, 'else's per feedback
Tue, Sep 4
Do any corresponding .9 man pages need updating?
Sat, Sep 1
Drop extra bzero of hash context, as I pointed out earlier but forgot about
:-). Thanks markm@.
Document 'thread' (entirely absent) and 'show thread' tid behavior.
Thu, Aug 30
To provide some context in case anyone is curious:
Per kib, mention that devvn version of refthread correctly handles parallel
Wed, Aug 29
Update a couple CR feedback
Tue, Aug 28
Mon, Aug 27
- Try to address CR comments
- Include in build
Sun, Aug 26
Perfect, looks great to me! Thanks for adding this.
Sat, Aug 25
Excellent! Again, thanks for taking care of this.
Changes mostly look good to me! Most of my concerns were addressed. The only outstanding issue I raised earlier but didn't feel was addressed is the bit around __packed. And just a couple new nits with the new patch below:
Thanks! Mostly looks good to me. A few quibbles:
Mostly looks good to me! Some minor doc, style, and one or two functional suggestions below.
Fri, Aug 24
LGTM with the caveat that I am mostly unfamiliar with x86 interrupt gory details. I did not look closely at the Xen bits.
Looking very good! Some nits and doc suggestions below.
Thu, Aug 23
I think the improvement is conservatively correct re: my reading of Fortuna, and no need to let perfect be the enemy of good for now.
Copied from earlier review D16866: