Page MenuHomeFreeBSD

cem (Conrad Meyer)
User

Projects

User Details

User Since
Jul 9 2015, 9:56 PM (261 w, 4 d)

Recent Activity

Thu, Jul 9

cem accepted D25596: g_concat_find_device: trim /dev/ if it is present, like other GEOM classes..
Thu, Jul 9, 7:34 AM

Mon, Jul 6

cem accepted D25565: sys/geom: consistently use _PATH_DEV instead of hardcoding "/dev/"..

LGTM!

Mon, Jul 6, 11:41 AM

Sat, Jul 4

cem accepted D25563: Use KERN_MAXPHYS..
Sat, Jul 4, 8:28 PM
cem accepted D25562: Use static_assert..
Sat, Jul 4, 8:26 PM
cem added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
Sat, Jul 4, 6:57 PM
cem added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
Sat, Jul 4, 6:55 PM
cem requested changes to D25487: kern.tty_info_kstacks: add a compact format.
Sat, Jul 4, 6:05 PM

Fri, Jul 3

cem committed rS362913: Add domain policy allocation for amd64 fpu_kern_ctx.
Add domain policy allocation for amd64 fpu_kern_ctx
Fri, Jul 3, 2:55 PM
cem closed D22053: Add domainset policy allocation for fpu_kern_ctx.
Fri, Jul 3, 2:55 PM

Wed, Jul 1

cem requested changes to D25312: Relax the rule against declaring variables in nested scopes..

The first hunk is fine and should go in on its own. Again, I'd prefer a vague "prefer top-level default" / don't overdo it, folks, but whatever. It's ok.

Wed, Jul 1, 11:25 PM
cem accepted D25540: www/chromium: Update to 83.0.4103.116, which includes two security fixes.

Rene reported build success on CURRENT-amd64 as well. Small update, LGTM.

Wed, Jul 1, 6:30 PM
cem added a comment to D25409: AMD Passthrough DMA Engine Driver.

Thanks @cem for taking time to review the code.

Wed, Jul 1, 3:12 PM
cem committed rS362823: geom(4): Kill GEOM_PART_EBR_COMPAT option.
geom(4): Kill GEOM_PART_EBR_COMPAT option
Wed, Jul 1, 2:16 AM
cem closed D24939: geom(4): Kill GEOM_PART_EBR_COMPAT option.
Wed, Jul 1, 2:16 AM
cem added a comment to D25417: Add a driver for the SafeXcel EIP-97..

Can this device also be used to offload generic DMA copies? Just curious.

Wed, Jul 1, 2:13 AM
cem committed rS362818: Replace OPENSSL_NO_SSL3_METHODs with dummies.
Replace OPENSSL_NO_SSL3_METHODs with dummies
Wed, Jul 1, 12:59 AM
cem closed D25493: Replace OPENSSL_NO_SSL3_METHODs with dummies.
Wed, Jul 1, 12:59 AM
cem updated the diff for D25493: Replace OPENSSL_NO_SSL3_METHODs with dummies.
  • Drop copyright/license header
  • static string
Wed, Jul 1, 12:51 AM
cem added a comment to D25493: Replace OPENSSL_NO_SSL3_METHODs with dummies.
In D25493#564116, @kib wrote:
In D25493#563935, @jhb wrote:

I believe this is correct. I think you only put things in Symbol.map if you want them public for when you link new binaries. We use __sym_compat without any corresponding Symbol.map entries for other compat shims in libc (e.g. fts* symbols in lib/libc/gen/Symbol.map are only the latest FBSD1.5 version and don't include the legacy versions for FBSD1.0 and FBSD1.1.)

You can check readelf -Ds output to verify that there are symbols with name@OPENSSL_1_1_0 version but not name@@OPENSSL_1_1_0. @@ denotes default version used by static linker to record version into the consumer. If there is no '@@' definition, ld(1) refuses to link with the symbol if reference does not specify wanted version.

Wed, Jul 1, 12:48 AM

Tue, Jun 30

cem added inline comments to D25514: Add a new security/isal-kmod port..
Tue, Jun 30, 1:54 AM
cem added a comment to D25515: savecore: fix memory leaks.

All memory is freed at program exit.

Tue, Jun 30, 1:53 AM
cem updated the diff for D25493: Replace OPENSSL_NO_SSL3_METHODs with dummies.
  • Don't print only sizeof(void*) bytes of the warning.
Tue, Jun 30, 1:50 AM
cem added a comment to D25493: Replace OPENSSL_NO_SSL3_METHODs with dummies.

Let's go that direction.

Tue, Jun 30, 1:49 AM
cem updated the diff for D25493: Replace OPENSSL_NO_SSL3_METHODs with dummies.

Don't abort/kill, just warn once and NULL stub per consensus.

Tue, Jun 30, 1:35 AM

Mon, Jun 29

cem added a comment to D25493: Replace OPENSSL_NO_SSL3_METHODs with dummies.

It's probably somewhat unfair, but I wrote an SSL scanner a while ago that uses this behavior:
https://github.com/tetlowgm/sslscan

Mon, Jun 29, 6:17 PM
cem added a comment to D25493: Replace OPENSSL_NO_SSL3_METHODs with dummies.

If you know of an example of some software that explicitly invokes every version it knows about (and tries SSLv3 before a TLS version), I've love to see an example.

Mon, Jun 29, 5:08 PM
cem closed D25283: vm: Add missing WITNESS warnings for M_WAITOK allocation.
Mon, Jun 29, 4:54 PM
cem committed rS362784: vm: Add missing WITNESS warnings for M_WAITOK allocation.
vm: Add missing WITNESS warnings for M_WAITOK allocation
Mon, Jun 29, 4:54 PM
cem accepted D25500: savecore: accept device names without the /dev/ prefix.

Just style/typo nits. Functionally, it looks good.

Mon, Jun 29, 4:26 AM

Sat, Jun 27

cem requested review of D25493: Replace OPENSSL_NO_SSL3_METHODs with dummies.
Sat, Jun 27, 6:42 PM
cem added a comment to D25451: Revert OPENSSL_NO_SSL3_METHOD to keep ABI compatibility..

We could provide dummy implementations of these symbols, rather than enabling SSLv3 code in 2020 in our unreleased development version of FreeBSD.

Sat, Jun 27, 5:33 PM
cem added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
Sat, Jun 27, 4:59 PM
cem added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
Sat, Jun 27, 3:13 PM
cem added a comment to D25487: kern.tty_info_kstacks: add a compact format.

I’m not keen on the short format but I prefer it to “off.”

Sat, Jun 27, 3:07 PM

Fri, Jun 26

cem accepted D25464: Remove CRYPTO_TIMING..
Fri, Jun 26, 4:19 PM
cem accepted D25465: Remove unused 32-bit compatibility structures from cryptodev..
Fri, Jun 26, 4:17 PM
cem added a comment to D25466: Convert cryptostats to a counter_u64 array..

I’m not keen on the struct <-> array coercion

Fri, Jun 26, 4:15 PM
cem added a comment to D25409: AMD Passthrough DMA Engine Driver.

Some general comments: Usually, you would just put this in sys/dev/ptdma (and sys/modules/ptdma) rather than adding a directory level.

Fri, Jun 26, 3:35 AM
cem accepted D24997: Don't log normal login_getpwclass(3) result..
Fri, Jun 26, 3:03 AM

Thu, Jun 25

cem added a comment to D25451: Revert OPENSSL_NO_SSL3_METHOD to keep ABI compatibility..

Sure, and sometimes that's fine.

Thu, Jun 25, 9:24 PM
cem added a comment to D25451: Revert OPENSSL_NO_SSL3_METHOD to keep ABI compatibility..

Because you cannot get stable branches ABI-stable if head is not.

Thu, Jun 25, 8:26 PM
cem added a comment to D25451: Revert OPENSSL_NO_SSL3_METHOD to keep ABI compatibility..

Er, why? CURRENT is not ABI stable and SSLv3 is very broken. Applications that want to use a broken cipher can get that from ports.

Thu, Jun 25, 8:12 PM
cem added a comment to D25449: www/chromium: Update to 83.0.4103.106 and fix synchronization.

Builds on 13-current

Thu, Jun 25, 8:07 PM
cem accepted D25449: www/chromium: Update to 83.0.4103.106 and fix synchronization.

Thanks! I haven't test-built it yet but can start that.

Thu, Jun 25, 1:52 PM
cem added a comment to D25168: geom(4): Look for aliases when searching for providers by name.

Were you able to find out why GPT partitions are not showing up in the /dev/diskid directory (e.g. /dev/diskid/DISK-BHYVE-2613-8EFD-BAF4p2), or are you not seeing similar behavior (since it might be specific to my usage, details in Message-ID: <cb21f4a0-f9d4-db5d-287a-0cb29c023b75@delphij.net>)?

Thu, Jun 25, 1:48 PM
cem added a comment to D25449: www/chromium: Update to 83.0.4103.106 and fix synchronization.

Thanks!

Thu, Jun 25, 1:21 PM
cem accepted D25062: domain: give domains a chance to probe for availability.

Seems broadly reasonable to me. I'm not super familiar with the domains logic myself but nothing looks wrong.

Thu, Jun 25, 3:09 AM
cem edited P401 Masterwork From Distant Lands.
Thu, Jun 25, 1:01 AM
cem resigned from D25443: Simplify IPsec transform-specific teardown..
Thu, Jun 25, 12:44 AM
cem resigned from D25442: Use zfree() to explicitly zero IPsec keys..

No interest in ipsec.

Thu, Jun 25, 12:44 AM
cem closed D24464: bhyve(8): For prototyping, reattempt decode in userspace.
Thu, Jun 25, 12:18 AM
cem committed rS362600: bhyve(8): For prototyping, reattempt decode in userspace.
bhyve(8): For prototyping, reattempt decode in userspace
Thu, Jun 25, 12:18 AM
cem accepted D25435: Use zfree() instead of explicit_bzero() and free()..

LGTM to me, other than the one question. Approved by: csprng(cem) for the random(4) change.

Thu, Jun 25, 12:17 AM
cem accepted D25437: Use zfree() instead of bzero() and free()..
Thu, Jun 25, 12:12 AM
cem added a comment to P398 Masterwork From Distant Lands.

Oh ffs I'm missing vmm_instruction_emul.h

Thu, Jun 25, 12:10 AM
cem added a comment to P398 Masterwork From Distant Lands.
cat /obj/usr/src/amd64.amd64/usr.sbin/bhyve/.depend.bhyverun.o | grep vmm
  /usr/src/sys/amd64/vmm/intel/vmcs.h \
  /obj/usr/src/amd64.amd64/tmp/usr/include/machine/vmm.h \
  /obj/usr/src/amd64.amd64/tmp/usr/include/machine/vmm_dev.h \
  /obj/usr/src/amd64.amd64/tmp/usr/include/vmmapi.h \
Thu, Jun 25, 12:00 AM

Wed, Jun 24

cem added a comment to P398 Masterwork From Distant Lands.

Nope, even without -DMAKE_JUST_WORLDS it fails to find the new header:

Wed, Jun 24, 11:54 PM
cem added a comment to P398 Masterwork From Distant Lands.

Ah, I was doing tinderbox with -DMAKE_JUST_WORLDS, which I guess skips toolchain bootstrap?

Wed, Jun 24, 11:52 PM
cem committed rS362596: Clang-format: Avoid hardcoded LLVM include-order style.
Clang-format: Avoid hardcoded LLVM include-order style
Wed, Jun 24, 11:22 PM
cem edited P400 Masterwork From Distant Lands.
Wed, Jun 24, 11:16 PM
cem committed rS362595: Update .clang-format type and foreach macros lists.
Update .clang-format type and foreach macros lists
Wed, Jun 24, 10:43 PM
cem closed D25429: Update .clang-format sys/tree, sys/queue, and sys/arb macros.
Wed, Jun 24, 10:43 PM
cem edited P399 Masterwork From Distant Lands.
Wed, Jun 24, 9:42 PM
cem added inline comments to D25431: Add a few atf tests for sendfile, with and without I/O errors..
Wed, Jun 24, 6:47 PM
cem updated the diff for D25429: Update .clang-format sys/tree, sys/queue, and sys/arb macros.

Add CPU, VM_MAP_ENTRY FOREACH; SMR_POINTER

Wed, Jun 24, 6:44 PM
cem committed rS362590: Update .clang-format with style(9) header-sorting.
Update .clang-format with style(9) header-sorting
Wed, Jun 24, 6:40 PM
cem closed D25428: Update .clang-format with style(9) header-sorting.
Wed, Jun 24, 6:40 PM
cem requested review of D25429: Update .clang-format sys/tree, sys/queue, and sys/arb macros.
Wed, Jun 24, 5:51 PM
cem updated the diff for D25428: Update .clang-format with style(9) header-sorting.

Drop miscfs/msdosfs and add nfs{client,server} to top-level include-ordering rule.

Wed, Jun 24, 5:36 PM
cem committed rS362588: Regenerate src.conf.5 after r362587.
Regenerate src.conf.5 after r362587
Wed, Jun 24, 5:31 PM
cem committed rS362587: Add WITH_CLANG_FORMAT option.
Add WITH_CLANG_FORMAT option
Wed, Jun 24, 5:03 PM
cem closed D25427: Add WITH_CLANG_FORMAT option.
Wed, Jun 24, 5:03 PM
cem added a comment to D25428: Update .clang-format with style(9) header-sorting.

(This is definitely not a complete style(9) .clang-format; the working goal is "less wrong than it was before.")

Wed, Jun 24, 5:00 PM
cem updated the test plan for D25428: Update .clang-format with style(9) header-sorting.
Wed, Jun 24, 4:58 PM
cem updated the diff for D25428: Update .clang-format with style(9) header-sorting.

vm/vm.h must come before vm/pmap.h (and likely all other vm/ headers).

Wed, Jun 24, 4:57 PM
cem updated the test plan for D25428: Update .clang-format with style(9) header-sorting.
Wed, Jun 24, 4:55 PM
cem updated the test plan for D25428: Update .clang-format with style(9) header-sorting.
Wed, Jun 24, 4:52 PM
cem requested review of D25428: Update .clang-format with style(9) header-sorting.
Wed, Jun 24, 4:51 PM
cem updated the diff for D25427: Add WITH_CLANG_FORMAT option.

Reorder EXTRAS, FORMAT

Wed, Jun 24, 4:39 PM
cem requested review of D25427: Add WITH_CLANG_FORMAT option.
Wed, Jun 24, 4:32 PM
cem added a comment to D24464: bhyve(8): For prototyping, reattempt decode in userspace.

Need to figure out a way to get the userspace build to observe the new kernel headers. The <machine/foo> symlink headers aren't pointing at the ones in SRCTOP. I guess I could put __FreeBSD_version conditional dummy prototypes in a userspace header and bump that?

Wed, Jun 24, 12:35 AM
cem edited P398 Masterwork From Distant Lands.
Wed, Jun 24, 12:34 AM

Tue, Jun 23

cem committed rS362549: kmod.mk: Don't split out debug symbols if requested.
kmod.mk: Don't split out debug symbols if requested
Tue, Jun 23, 6:25 PM
cem closed D24835: kmod.mk: Don't split out debug symbols if requested.
Tue, Jun 23, 6:25 PM
cem added a comment to D24856: cam: scsi_enc_ses: Remove an unnecessary VLA construction.
In D24856#560905, @jhb wrote:

*shrug* Given the function already defines variables in scope I'm not sure it really matters to pull it out to the top-level (esp in light of the recent style(9) change Warner is working on).

Tue, Jun 23, 5:01 PM
cem committed rS362545: sort(1): Fix two wchar-related bugs in radixsort.
sort(1): Fix two wchar-related bugs in radixsort
Tue, Jun 23, 4:44 PM
cem added a comment to D24835: kmod.mk: Don't split out debug symbols if requested.

Seems reasonable to me, although I'd also argue that ports ought not set MK_KERNEL_SYMBOLS=no.

Tue, Jun 23, 12:55 PM
cem requested review of D24836: x11/nvidia-driver: Respect WITH_DEBUG.
Tue, Jun 23, 3:28 AM
cem requested review of D25249: x86: Scale default msi/msix vector limit with MAXCPU.
Tue, Jun 23, 3:21 AM
cem requested review of D25168: geom(4): Look for aliases when searching for providers by name.
Tue, Jun 23, 3:21 AM
cem closed D23392: More Secure Permissions for /root.
Tue, Jun 23, 3:21 AM
cem requested review of D24856: cam: scsi_enc_ses: Remove an unnecessary VLA construction.
Tue, Jun 23, 3:19 AM
cem requested review of D24836: x11/nvidia-driver: Respect WITH_DEBUG.
Tue, Jun 23, 3:18 AM
cem requested review of D24835: kmod.mk: Don't split out debug symbols if requested.
Tue, Jun 23, 3:17 AM
cem closed D24786: clang: Reject %n for __attribute__((format(__freebsd_kprintf__))).
Tue, Jun 23, 3:17 AM
cem requested review of D24786: clang: Reject %n for __attribute__((format(__freebsd_kprintf__))).
Tue, Jun 23, 3:17 AM

Mon, Jun 22

cem accepted D25403: Fix fallout from the emancipation of dump(8) workers.

Diff looks good to me, thanks. I would suggest not using "emancipation" in the commit subject.

Mon, Jun 22, 8:50 PM
cem accepted D22493: Support for bcm2838 RNG.

LGTM. A few minor style nits.

Mon, Jun 22, 5:22 PM · arm64
cem added a comment to D22493: Support for bcm2838 RNG.

Please upload diffs with full context — either using the arcanist tool, or with diff -U999999 (The 9s are just a stand-in for infinity).

Mon, Jun 22, 5:02 PM · arm64

Sun, Jun 21

cem updated the diff for D24464: bhyve(8): For prototyping, reattempt decode in userspace.

Minor update: In the seemingly impossible case where inst_length is zero, don't
leave trash in the vie->num_valid field.

Sun, Jun 21, 6:24 PM