Page MenuHomeFreeBSD

cem (Conrad Meyer)
User

Projects

User Details

User Since
Jul 9 2015, 9:56 PM (167 w, 10 h)

Recent Activity

Yesterday

cem created D17252: random(4): Match enabled sources mask to build options.
Thu, Sep 20, 5:25 AM

Wed, Sep 19

cem accepted D17235: amd64 pmap: remove tautological assert..

CID 1395727 , fwiw

Wed, Sep 19, 3:00 PM

Tue, Sep 18

cem accepted D17209: Only update the domain cursor once in keg_fetch_slab()..

This changes keg cursor advancement behavior slightly. I'm not sure that matters.

Tue, Sep 18, 12:29 AM

Sat, Sep 15

cem accepted D17175: Fix memguard when options NUMA is configured..
Sat, Sep 15, 6:18 PM

Fri, Sep 14

cem accepted D17175: Fix memguard when options NUMA is configured..

Looks like kmem_back() can now be entirely removed.

Fri, Sep 14, 9:36 PM
cem updated the diff for D17047: Fortuna: Add failpoints to simulate initial seeding conditions.

ifdef _KERNEL failpoint sites

Fri, Sep 14, 4:30 AM

Thu, Sep 13

cem added a reviewer for D17144: ZSTDIO: Correctly initialize zstd context with provided 'level': releng.

Request for acceptance into head during freeze

Thu, Sep 13, 4:56 PM
cem created D17144: ZSTDIO: Correctly initialize zstd context with provided 'level'.
Thu, Sep 13, 4:17 AM
cem accepted D17128: [sshd 7.8p1] avoid to violate capability mode.

👍

Thu, Sep 13, 1:39 AM · capsicum

Wed, Sep 12

cem accepted D17128: [sshd 7.8p1] avoid to violate capability mode.

Looks great to me.

Wed, Sep 12, 2:49 PM · capsicum
cem accepted D17128: [sshd 7.8p1] avoid to violate capability mode.

Functionality looks good to me. Some minor style suggestions follow.

Wed, Sep 12, 4:09 AM · capsicum

Tue, Sep 11

cem added a comment to D17056: [sshd] add wrapper function of login_getpwclass.

I found one problem that sshd fails to reverse resolve hostname if server is set UseDNS yes .

Tue, Sep 11, 3:14 PM · capsicum
cem added inline comments to D16335: Build libve for loader and sbin/veriexec.
Tue, Sep 11, 12:27 AM

Mon, Sep 10

cem accepted D17056: [sshd] add wrapper function of login_getpwclass.

Looks great to me, thanks. Any other reviewers want to take a pass?

Mon, Sep 10, 3:46 PM · capsicum
cem added a comment to D17083: Alter the prototype of qsort_r(3) to match glibc..
In D17083#364500, @ed wrote:

I did some tests, but C++ is something we don't need to worry about, right?

Mon, Sep 10, 3:33 PM

Sun, Sep 9

cem added a comment to D17083: Alter the prototype of qsort_r(3) to match glibc..

+1 to the general idea from me, and thanks Ed for taking on the work. I will review the patch later.

Sun, Sep 9, 7:09 PM
cem added a comment to D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.

Hmm. I'm definitely ok rejecting the (hidden) names .sample or .pkgnew, and I think probably rejecting all hidden (dot-prefixed) names would be reasonable.

Sun, Sep 9, 4:00 PM

Sat, Sep 8

cem added a comment to D16335: Build libve for loader and sbin/veriexec.
In D16335#363841, @sjg wrote:

I have no objection to and indeed welcome better names.
Sadly libveriexec is already taken.

Sat, Sep 8, 4:52 AM
cem accepted D17056: [sshd] add wrapper function of login_getpwclass.

Looks great to me! All of my comments below are just style or message suggestions, nothing functional.

Sat, Sep 8, 1:38 AM · capsicum
cem planned changes to D17047: Fortuna: Add failpoints to simulate initial seeding conditions.
Sat, Sep 8, 1:24 AM

Thu, Sep 6

cem added inline comments to D16334: Build libbearssl for loader and sbin/veriexec.
Thu, Sep 6, 7:49 PM
cem added inline comments to D16335: Build libve for loader and sbin/veriexec.
Thu, Sep 6, 7:44 PM
cem requested changes to D17056: [sshd] add wrapper function of login_getpwclass.

Mostly looks good to me! I had a couple concerns and suggestions, see below. Thanks for the patch.

Thu, Sep 6, 5:03 PM · capsicum
cem added a reviewer for D17056: [sshd] add wrapper function of login_getpwclass: des.

Hi Conrad.
Thanks for the advice. I regenerated patch file. It seems good differential.

Thu, Sep 6, 4:38 PM · capsicum
cem added a comment to D16335: Build libve for loader and sbin/veriexec.

I realize this is a very bikesheddy ask but would it be at all possible to make the library name longer? libveriexec or something (I don't care in particular). The vast majority of libraries have descriptive names and I don't think scrimping on a few letters is making anyone's life better.

Thu, Sep 6, 4:35 PM
cem accepted D17059: Enable options NUMA on amd64 GENERIC/MINIMAL:.
Thu, Sep 6, 2:25 PM · NUMA
cem added a comment to D17056: [sshd] add wrapper function of login_getpwclass.

Hi Yuichiro NAITO,

Thu, Sep 6, 12:25 PM · capsicum
cem created D17049: random(4): Squash non-error timeout codes from tsleep(9).
Thu, Sep 6, 12:24 PM
cem updated the summary of D17049: random(4): Squash non-error timeout codes from tsleep(9).
Thu, Sep 6, 12:24 PM
cem created D17050: getentropy(3): Trap non-API errnos from getrandom(2) and abort.
Thu, Sep 6, 12:24 PM
cem updated the test plan for D17049: random(4): Squash non-error timeout codes from tsleep(9).
Thu, Sep 6, 12:24 PM
cem created D17047: Fortuna: Add failpoints to simulate initial seeding conditions.
Thu, Sep 6, 12:24 PM
cem updated the diff for D17035: mdmfs(8): Check for other types of helper-program failure.

Decode signal return codes from run() more nicely in printed errors.

Thu, Sep 6, 12:24 PM
cem added inline comments to D17035: mdmfs(8): Check for other types of helper-program failure.
Thu, Sep 6, 12:24 PM

Wed, Sep 5

cem updated the diff for D17035: mdmfs(8): Check for other types of helper-program failure.

Removed extraneous comma, 'else's per feedback

Wed, Sep 5, 2:08 AM
cem accepted D17029: Remove hardclock() and related subroutines..
Wed, Sep 5, 2:05 AM
cem created D17035: mdmfs(8): Check for other types of helper-program failure.
Wed, Sep 5, 1:49 AM

Tue, Sep 4

cem accepted D17029: Remove hardclock() and related subroutines..

Do any corresponding .9 man pages need updating?

Tue, Sep 4, 8:38 PM

Sat, Sep 1

cem updated the diff for D16986: fortuna: Drop global lock to zero stack variables.

Drop extra bzero of hash context, as I pointed out earlier but forgot about
:-). Thanks markm@.

Sat, Sep 1, 7:23 PM
cem added inline comments to D16986: fortuna: Drop global lock to zero stack variables.
Sat, Sep 1, 7:21 PM
cem created D16986: fortuna: Drop global lock to zero stack variables.
Sat, Sep 1, 7:01 PM
cem added inline comments to D16983: random(4): Correct a bare zero to the appropriate enum.
Sat, Sep 1, 6:59 PM
cem created D16985: Fortuna: fix a correctness issue in reseed (fortuna_pre_read).
Sat, Sep 1, 5:22 AM
cem created D16984: Fortuna: Fix a race to prevent reseed spamming.
Sat, Sep 1, 5:07 AM
cem created D16983: random(4): Correct a bare zero to the appropriate enum.
Sat, Sep 1, 4:45 AM
cem created D16982: random(4): Translate a comment requirement into a compile-time invariant.
Sat, Sep 1, 4:39 AM
cem updated the diff for D16962: ddb: Enable 'thread <address>'.

Document 'thread' (entirely absent) and 'show thread' tid behavior.

Sat, Sep 1, 4:19 AM
cem added a comment to D10487: Bug 218861 - libelf elf_update fails when adding sections.

I'm not sure what you mean by the invariant. All this patch does is detect a violation and report an error in that case.

Sat, Sep 1, 3:43 AM

Thu, Aug 30

cem created D16962: ddb: Enable 'thread <address>'.
Thu, Aug 30, 10:56 PM
cem edited P216 Masterwork From Distant Lands.
Thu, Aug 30, 10:28 PM
cem added a comment to D16959: Don't load ccp automatically..

To provide some context in case anyone is curious:

Thu, Aug 30, 10:12 PM
cem accepted D16959: Don't load ccp automatically..

LGTM, thanks.

Thu, Aug 30, 9:33 PM
cem updated the diff for D16897: First draft dev_refthread.9..

Per kib, mention that devvn version of refthread correctly handles parallel
vnode reclamation.

Thu, Aug 30, 3:30 AM

Wed, Aug 29

cem added inline comments to D16934: Fortuna: Clean up reseeding key material to closer match FS&K.
Wed, Aug 29, 7:32 PM
cem added inline comments to D16935: rijndael (AES): Avoid leaking sensitive data on kernel stack.
Wed, Aug 29, 7:25 PM
cem added a comment to D16937: Fortuna: trivial static variable cleanup.

This would increase stack usage for /dev/random read by 32 bytes, but I think it's small enough and make the code easier to reason for MP safety (the buffer is not meant to be shared by two different threads), so consider this a LGTM from secteam@ as long as there is no objection raised by September 1st.

Wed, Aug 29, 6:15 PM
cem created D16937: Fortuna: trivial static variable cleanup.
Wed, Aug 29, 4:43 AM
cem created D16936: Fortuna: Add trivial assert to match FS&K definition.
Wed, Aug 29, 4:35 AM
cem created D16935: rijndael (AES): Avoid leaking sensitive data on kernel stack.
Wed, Aug 29, 4:28 AM
cem created D16934: Fortuna: Clean up reseeding key material to closer match FS&K.
Wed, Aug 29, 4:19 AM
cem added inline comments to D16897: First draft dev_refthread.9..
Wed, Aug 29, 4:05 AM
cem updated the diff for D16897: First draft dev_refthread.9..

Update a couple CR feedback

Wed, Aug 29, 4:05 AM
cem accepted D16690: make device_printf use sbuf.
Wed, Aug 29, 1:18 AM

Tue, Aug 28

cem added inline comments to D16690: make device_printf use sbuf.
Tue, Aug 28, 9:39 PM
cem accepted D16690: make device_printf use sbuf.

LGTM

Tue, Aug 28, 6:12 PM

Mon, Aug 27

cem updated the diff for D16897: First draft dev_refthread.9..
  • Try to address CR comments
  • Include in build
Mon, Aug 27, 4:40 AM
cem added inline comments to D16897: First draft dev_refthread.9..
Mon, Aug 27, 4:36 AM

Sun, Aug 26

cem accepted D16855: Fix temperature reporting on AMD 2990WX.

Perfect, looks great to me! Thanks for adding this.

Sun, Aug 26, 1:30 AM

Sat, Aug 25

cem accepted D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..

Excellent! Again, thanks for taking care of this.

Sat, Aug 25, 11:01 PM
cem added a comment to D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..

Changes mostly look good to me! Most of my concerns were addressed. The only outstanding issue I raised earlier but didn't feel was addressed is the bit around __packed. And just a couple new nits with the new patch below:

Sat, Aug 25, 10:15 PM
cem requested changes to D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
Sat, Aug 25, 10:15 PM
cem added a comment to D16855: Fix temperature reporting on AMD 2990WX.

Thanks! Mostly looks good to me. A few quibbles:

Sat, Aug 25, 9:48 PM
cem added inline comments to D13528: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_* (logic only)..
Sat, Aug 25, 9:37 PM
cem accepted D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..

Mostly looks good to me! Some minor doc, style, and one or two functional suggestions below.

Sat, Aug 25, 8:55 PM
cem added inline comments to D16856: Initial proposed patch for SSL root bundle in base.
Sat, Aug 25, 6:48 AM
cem added a child revision for D16885: dev_refthread: Do not initialize *ref when reference was not acquired: D16897: First draft dev_refthread.9..
Sat, Aug 25, 6:26 AM
cem added a parent revision for D16897: First draft dev_refthread.9.: D16885: dev_refthread: Do not initialize *ref when reference was not acquired.
Sat, Aug 25, 6:26 AM
cem created D16897: First draft dev_refthread.9..
Sat, Aug 25, 6:26 AM
cem added inline comments to D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..
Sat, Aug 25, 2:12 AM

Fri, Aug 24

cem added inline comments to D15119: Handle overflow of uid or gid in arguments for chown.
Fri, Aug 24, 8:31 PM · Contributor Reviews (base)
cem added inline comments to D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..
Fri, Aug 24, 8:22 PM
cem added a comment to D16885: dev_refthread: Do not initialize *ref when reference was not acquired.
In D16885#359928, @kib wrote:

I do not object but I must note that unconditional *ref = 1 looks strange to me. And since I am the author of that line, I believe that I added it that way for some reason which I cannot remember now. Most likely it was a compatibility issue with some third-party code. At least I looked at all in-tree callers and they looks fine.

Fri, Aug 24, 8:11 PM
cem added inline comments to D16690: make device_printf use sbuf.
Fri, Aug 24, 8:09 PM
cem created D16885: dev_refthread: Do not initialize *ref when reference was not acquired.
Fri, Aug 24, 7:08 PM
cem added a comment to D16861: Dynamically allocate IRQ ranges on x86..

Thanks!

Fri, Aug 24, 4:13 PM
cem accepted D15119: Handle overflow of uid or gid in arguments for chown.
Fri, Aug 24, 4:07 PM · Contributor Reviews (base)
cem added a comment to D15259: Add netdump hooks for mlxen(4)..

We have this patched queued internally for testing and review. You'd like to have it in before 12 is out?

Fri, Aug 24, 4:00 PM
cem accepted D16861: Dynamically allocate IRQ ranges on x86..

LGTM with the caveat that I am mostly unfamiliar with x86 interrupt gory details. I did not look closely at the Xen bits.

Fri, Aug 24, 6:17 AM
cem added a comment to D16690: make device_printf use sbuf.

Looking very good! Some nits and doc suggestions below.

Fri, Aug 24, 3:19 AM
cem added a comment to D15259: Add netdump hooks for mlxen(4)..

Hi Hans,

Fri, Aug 24, 1:20 AM

Thu, Aug 23

cem added inline comments to D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..
Thu, Aug 23, 6:37 PM
cem accepted D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..

I think the improvement is conservatively correct re: my reading of Fortuna, and no need to let perfect be the enemy of good for now.

Thu, Aug 23, 5:24 PM
cem accepted D16872: Fix excessive reseed rate in random(4)..

Copied from earlier review D16866:

Thu, Aug 23, 5:14 PM
cem added a parent revision for D16866: Fix excessive reseeding in random(4).: D16872: Fix excessive reseed rate in random(4)..
Thu, Aug 23, 5:14 PM
cem added a child revision for D16872: Fix excessive reseed rate in random(4).: D16866: Fix excessive reseeding in random(4)..
Thu, Aug 23, 5:14 PM
cem requested changes to D16855: Fix temperature reporting on AMD 2990WX.
In D16855#359281, @cem wrote:

Yeah, like I said earlier, I think that's a pretty clear typo for 255C. The temperature scale does not change between the modes and 206+49=255.

Thu, Aug 23, 5:12 PM
cem added a comment to D16855: Fix temperature reporting on AMD 2990WX.

Thank you so much for the pointer to the docs!!! It is much nicer to write from real docs, rather than crib from undocumented changes in another project.

Thu, Aug 23, 4:47 PM
cem accepted D16869: tftp(1): switch default transfer mode to binary.
Thu, Aug 23, 4:45 PM
cem added a comment to D16866: Fix excessive reseeding in random(4)..

Split into two separate commits as per review request.

Thu, Aug 23, 4:43 PM
cem added a comment to D16866: Fix excessive reseeding in random(4)..

(Approved — phab won't let me mark it as such because it is "closed.")

Thu, Aug 23, 4:40 PM