Page MenuHomeFreeBSD

cem (Conrad Meyer)
User

Projects

User Details

User Since
Jul 9 2015, 9:56 PM (241 w, 8 h)

Recent Activity

Wed, Feb 19

cem accepted D23765: clamp kernel dump compression level when using gzip.
Wed, Feb 19, 11:29 PM

Sun, Feb 16

cem added a comment to D23659: x86: Fix scheduler topology assumptions about uniformity.
In D23659#520598, @jeff wrote:

So this looks to me like we made a bad topology and then worked around it by weakening the search.

Sun, Feb 16, 4:31 PM

Sat, Feb 15

cem committed rS357975: random(6): Re-add undocumented support for floating point denominators.
random(6): Re-add undocumented support for floating point denominators
Sat, Feb 15, 7:13 PM

Fri, Feb 14

cem accepted D23689: add chachapoly to kernel.

Seems fine to me.

Fri, Feb 14, 7:58 PM

Thu, Feb 13

cem created D23659: x86: Fix scheduler topology assumptions about uniformity.
Thu, Feb 13, 2:48 AM

Wed, Feb 12

cem committed rP525917: security/vuxml: Document sysutils/grub2-bhyve escalations.
security/vuxml: Document sysutils/grub2-bhyve escalations
Wed, Feb 12, 4:18 PM
cem committed rP525916: sysutils/grub2-bhyve: Neutralize privileged guest commands.
sysutils/grub2-bhyve: Neutralize privileged guest commands
Wed, Feb 12, 3:32 PM
cem accepted D23648: style.9: update C99 commentary.
Wed, Feb 12, 3:19 PM

Fri, Feb 7

cem added a comment to D23551: nvdimm(4): Prototype real basic NVDIMM-N health info.

WIP, I'm in progress of drafting a private email response as well.

Fri, Feb 7, 5:04 PM
cem added inline comments to D23555: acpi_hpet: Add Hygon Dhyana support.
Fri, Feb 7, 4:39 PM
cem added a comment to D23559: amdsmn: Add Hygon Dhyana support.

My questions on the initial review were never really answered...

Fri, Feb 7, 3:42 PM
cem added a comment to D23560: amdtemp: Add Hygon Dhyana support.

Generally please upload phabricator diffs with more context. The arcanist tool can help do that easily. Or if you prefer the manual process, please generate patches with -U99999.

Fri, Feb 7, 3:38 PM
cem created D23551: nvdimm(4): Prototype real basic NVDIMM-N health info.
Fri, Feb 7, 7:18 AM

Thu, Feb 6

cem added inline comments to D23531: replace strncpy with memcpy when copying full string.
Thu, Feb 6, 7:53 PM
cem added inline comments to D23531: replace strncpy with memcpy when copying full string.
Thu, Feb 6, 6:39 PM

Wed, Feb 5

cem added inline comments to D22963: Expand generic subword atomic primitives.
Wed, Feb 5, 9:00 PM
cem added inline comments to D22963: Expand generic subword atomic primitives.
Wed, Feb 5, 6:13 PM

Tue, Feb 4

cem updated subscribers of D23223: auditd_stop: wait_for_pids instead of sleeping.

This sounds reasonable to me, I just wasn't personally confident enough that it was true. Is there a maintainer who can speak to this? There seems to be a difference, e.g. auditd_reap_children(), and whatever is going on with launchd (but doesn't apply to us?).

Tue, Feb 4, 11:40 PM
cem added a comment to D23223: auditd_stop: wait_for_pids instead of sleeping.

I don't see any reason auditd cannot just use the default stop action, which sends SIGTERM. auditd handles sigterm and performs more or less the same shutdown actions as those triggered by audit -t (AUDIT_TRIGGER_CLOSE_AND_DIE). I would suggest just removing the auditd_stop() function entirely.

Tue, Feb 4, 10:09 PM
cem added a comment to D23223: auditd_stop: wait_for_pids instead of sleeping.

Seems like there is a possible race condition here where $rc_pid exits and is recycled before we check for exit.

Tue, Feb 4, 10:02 PM

Mon, Feb 3

cem committed rS357425: netinet/libalias: Fix typo in debug message.
netinet/libalias: Fix typo in debug message
Mon, Feb 3, 5:20 AM
cem closed D23365: libalias: Use correct case for GetNewPort in debug message in alias_db.c.
Mon, Feb 3, 5:20 AM

Sat, Feb 1

cem accepted D23392: More Secure Permissions for /root.

I don't object to /root mode 750. This seems to line up with, e.g., Fedora Linux defaults.

Sat, Feb 1, 8:47 PM
cem committed rS357386: tpm(4): Fix 'go ready' in TPM 2.0 TIS driver.
tpm(4): Fix 'go ready' in TPM 2.0 TIS driver
Sat, Feb 1, 8:38 PM
cem closed D23081: Fix bug in TPM 2.0 TIS driver..
Sat, Feb 1, 8:38 PM
cem committed rS357382: rand(3): Replace implementation with one backed by random(3) algorithm.
rand(3): Replace implementation with one backed by random(3) algorithm
Sat, Feb 1, 8:33 PM
cem closed D23290: rand(3): Replace implementation with one backed by random(3) algorithm.
Sat, Feb 1, 8:33 PM
cem committed rS357381: hwpstate_intel(4): Save admin-set EPP/EPB and restore after suspend.
hwpstate_intel(4): Save admin-set EPP/EPB and restore after suspend
Sat, Feb 1, 8:12 PM
cem committed rS357380: hwpstate_intel(4): Print failure message only on failure.
hwpstate_intel(4): Print failure message only on failure
Sat, Feb 1, 8:11 PM
cem committed rS357379: hwpstate_intel(4): Detect and support PKG variant.
hwpstate_intel(4): Detect and support PKG variant
Sat, Feb 1, 7:50 PM
cem committed rS357378: hwpstate_intel(4): Add fallback EPP using PERF_BIAS MSR.
hwpstate_intel(4): Add fallback EPP using PERF_BIAS MSR
Sat, Feb 1, 7:49 PM
cem committed rS357377: x86: Add/amend some power-management comments/macros.
x86: Add/amend some power-management comments/macros
Sat, Feb 1, 7:46 PM
cem committed rS357376: hwpstate_intel(4): Error check epp sysctl & bail if HW does not support feature.
hwpstate_intel(4): Error check epp sysctl & bail if HW does not support feature
Sat, Feb 1, 7:45 PM
cem committed rS357373: intel_hwpstate(4): Use identcpu-cached cpuid 6 leaf.
intel_hwpstate(4): Use identcpu-cached cpuid 6 leaf
Sat, Feb 1, 5:55 PM
cem committed rS357372: intel_hwpstate(4): Don't leak bound thread in error conditions.
intel_hwpstate(4): Don't leak bound thread in error conditions
Sat, Feb 1, 5:31 PM

Fri, Jan 31

cem committed rS357336: hwpstate(4): Ignore CurPstateLimit by default.
hwpstate(4): Ignore CurPstateLimit by default
Fri, Jan 31, 5:41 PM

Thu, Jan 30

cem committed rS357301: contrib/apr: Rip out bogus [CS]PRNG implementation.
contrib/apr: Rip out bogus [CS]PRNG implementation
Thu, Jan 30, 6:13 PM
cem committed rS357300: aic7xxx(4): Fix unintended sign extension in ahd_inq().
aic7xxx(4): Fix unintended sign extension in ahd_inq()
Thu, Jan 30, 6:12 PM
cem committed rS357299: contrib/apr: Remove scope leak UB.
contrib/apr: Remove scope leak UB
Thu, Jan 30, 5:51 PM
cem accepted D23430: libusb: libusb10_hotplug: Remove lock leaks, locked sleep.
Thu, Jan 30, 5:28 PM
cem added a comment to D23430: libusb: libusb10_hotplug: Remove lock leaks, locked sleep.

Hm, I don't understand where we unlock in the rest of the chunks without the changes. Maybe the breaks intentionally return a locked context, but the continues seem obviously wrong. I don't see an unlock in, e.g., libusb_hotplug_filter() which would make that safe.

Thu, Jan 30, 5:23 PM
cem created D23430: libusb: libusb10_hotplug: Remove lock leaks, locked sleep.
Thu, Jan 30, 4:59 PM
cem added a comment to D23370: acpi_ibm: add support for ThinkPad PrivacyGuard.

Updated patch LGTM :-). I see philip has already committed it, great!

Thu, Jan 30, 3:58 PM
cem accepted D23370: acpi_ibm: add support for ThinkPad PrivacyGuard.

LGTM other than the indentation

Thu, Jan 30, 5:44 AM

Wed, Jan 29

cem committed rS357273: Revert r357246.
Revert r357246
Wed, Jan 29, 10:37 PM
cem committed rS357249: ypldap(8): Fix absent va_end() in 'goto fail' path.
ypldap(8): Fix absent va_end() in 'goto fail' path
Wed, Jan 29, 5:59 AM
cem committed rS357248: bnxt(4): Eliminate wrong sizeof() expression in memset().
bnxt(4): Eliminate wrong sizeof() expression in memset()
Wed, Jan 29, 5:42 AM
cem committed rS357247: ixgbe(4): Eliminate bogus sizeof() expressions.
ixgbe(4): Eliminate bogus sizeof() expressions
Wed, Jan 29, 5:31 AM
cem committed rS357246: qmath(3) test: Replace overcomplicated abomination with arc4random(3).
qmath(3) test: Replace overcomplicated abomination with arc4random(3)
Wed, Jan 29, 5:25 AM
cem committed rS357245: qlxge(4): Ditto r357244.
qlxge(4): Ditto r357244
Wed, Jan 29, 4:43 AM
cem committed rS357244: qlxgb(4): Use defined evaluation order.
qlxgb(4): Use defined evaluation order
Wed, Jan 29, 4:41 AM
cem committed rS357243: libpmc: jevents: Go ahead and use snprintf(3).
libpmc: jevents: Go ahead and use snprintf(3)
Wed, Jan 29, 4:34 AM
cem committed rS357241: libpmc: jevents: Partial style(9) pass.
libpmc: jevents: Partial style(9) pass
Wed, Jan 29, 4:31 AM
cem committed rS357240: hwpstate_intel(4): Silence/fix Coverity reports.
hwpstate_intel(4): Silence/fix Coverity reports
Wed, Jan 29, 3:15 AM

Tue, Jan 28

cem added inline comments to D23370: acpi_ibm: add support for ThinkPad PrivacyGuard.
Tue, Jan 28, 11:32 PM
cem added inline comments to D23370: acpi_ibm: add support for ThinkPad PrivacyGuard.
Tue, Jan 28, 11:31 PM
cem accepted D23400: geli: add a test case for attaching multiple providers with 1 command.

LGTM. 8kB is overkill for the key, but mostly harmless.

Tue, Jan 28, 5:25 PM
cem committed rS357194: amdtemp(4): Remove dead code that snuck in with r357190.
amdtemp(4): Remove dead code that snuck in with r357190
Tue, Jan 28, 3:27 AM
cem committed rS357190: amdtemp(4): Add support for Family 17h CCD sensors.
amdtemp(4): Add support for Family 17h CCD sensors
Tue, Jan 28, 1:40 AM
cem committed rS357189: amdtemp(4): Refactor shared temperature calculation logic.
amdtemp(4): Refactor shared temperature calculation logic
Tue, Jan 28, 1:39 AM
cem committed rS357188: x86: identcpu: Decode new Intel Structured Extended feature bits.
x86: identcpu: Decode new Intel Structured Extended feature bits
Tue, Jan 28, 1:37 AM
cem committed rS357187: x86: identcpu: Decode new Zen2 AMD Feature2 bit.
x86: identcpu: Decode new Zen2 AMD Feature2 bit
Tue, Jan 28, 1:37 AM

Mon, Jan 27

cem added a comment to D23370: acpi_ibm: add support for ThinkPad PrivacyGuard.

Thanks! LGTM other than the remaining EINVAL <-> ACPI_STATUS conflict in the revision.

Mon, Jan 27, 8:20 PM
cem committed rS357165: hwpstate(4): Log a debug line when throttled.
hwpstate(4): Log a debug line when throttled
Mon, Jan 27, 6:04 AM

Sun, Jan 26

cem added inline comments to D23370: acpi_ibm: add support for ThinkPad PrivacyGuard.
Sun, Jan 26, 10:38 PM
cem requested changes to D23370: acpi_ibm: add support for ThinkPad PrivacyGuard.

Oh whoops I forgot about the error handling issue.

Sun, Jan 26, 10:20 PM
cem accepted D23370: acpi_ibm: add support for ThinkPad PrivacyGuard.

Thanks, the updates look great. I'm still curious about the disassembly of the methods if you can get it, but I don't think that's a blocker issue.

Sun, Jan 26, 10:19 PM
cem added a comment to D23370: acpi_ibm: add support for ThinkPad PrivacyGuard.

LGTM modulo whitespace nit and ACPI_STATUS return to userspace in set.

Sun, Jan 26, 6:30 PM
cem added inline comments to D22839: random(4) fenestrasX: Push root seed version to arc4random(3).
Sun, Jan 26, 7:07 AM
cem updated the diff for D22839: random(4) fenestrasX: Push root seed version to arc4random(3).

Add sysctl knob to disable VDSO page ABI.

Sun, Jan 26, 7:07 AM

Sat, Jan 25

cem added inline comments to D22963: Expand generic subword atomic primitives.
Sat, Jan 25, 7:23 AM
cem updated the diff for D22963: Expand generic subword atomic primitives.

Fix pasto in ifndef conditional

Sat, Jan 25, 7:22 AM

Fri, Jan 24

cem committed rS357066: random(3): Abstract routines into _r versions on explicit state.
random(3): Abstract routines into _r versions on explicit state
Fri, Jan 24, 1:39 AM
cem closed D23289: random(3): Abstract routines into _r versions on explicit state.
Fri, Jan 24, 1:39 AM
cem committed rS357065: random(3): Abstract state into a single context object.
random(3): Abstract state into a single context object
Fri, Jan 24, 1:32 AM
cem closed D23288: random(3): Abstract state into a single context object.
Fri, Jan 24, 1:32 AM

Thu, Jan 23

cem committed rS357063: cpufreq(4): Fix missing MODULE_DEPEND on hwpstate_intel.
cpufreq(4): Fix missing MODULE_DEPEND on hwpstate_intel
Thu, Jan 23, 11:53 PM

Wed, Jan 22

cem committed rS357002: cpufreq(4): Add support for Intel Speed Shift.
cpufreq(4): Add support for Intel Speed Shift
Wed, Jan 22, 11:29 PM
cem closed D18028: Add support for Intel Speed Shift.
Wed, Jan 22, 11:29 PM

Jan 21 2020

cem added inline comments to D23290: rand(3): Replace implementation with one backed by random(3) algorithm.
Jan 21 2020, 7:10 PM
cem added a comment to D23289: random(3): Abstract routines into _r versions on explicit state.

I had some concerns about providing *_r variants of these that match names from glibc but aren't compatible, but I see the ultimate plan is that these aren't intended to be exported from libc at all- this seems OK.

Jan 21 2020, 7:09 PM
cem added a comment to D23290: rand(3): Replace implementation with one backed by random(3) algorithm.

Thanks for the quick reviews, Mark!

Jan 21 2020, 6:38 PM
cem created D23290: rand(3): Replace implementation with one backed by random(3) algorithm.
Jan 21 2020, 2:07 AM
cem created D23289: random(3): Abstract routines into _r versions on explicit state.
Jan 21 2020, 2:07 AM
cem created D23288: random(3): Abstract state into a single context object.
Jan 21 2020, 2:07 AM

Jan 20 2020

cem committed rS356935: random.3: Some minor improvements to wording/clarity.
random.3: Some minor improvements to wording/clarity
Jan 20 2020, 11:44 PM
cem committed rS356934: libc: Delete unused rand.c ifdef TEST code.
libc: Delete unused rand.c ifdef TEST code
Jan 20 2020, 11:44 PM
cem committed rS356922: qsort.3: Bump Dd and note that Annex K is optional.
qsort.3: Bump Dd and note that Annex K is optional
Jan 20 2020, 6:43 PM

Jan 19 2020

cem committed rS356901: mps(4): add missing cam(4) dependency.
mps(4): add missing cam(4) dependency
Jan 19 2020, 10:52 PM
cem closed D23272: mps: add missing cam dependency.
Jan 19 2020, 10:52 PM
cem accepted D23272: mps: add missing cam dependency.
Jan 19 2020, 9:34 PM
cem added inline comments to D22493: Support for bcm2838 RNG.
Jan 19 2020, 2:14 AM · arm64

Jan 18 2020

cem added inline comments to D22493: Support for bcm2838 RNG.
Jan 18 2020, 6:30 PM · arm64
cem committed rS356861: GEOM label: strip leading/trailing space synthesizing devfs names.
GEOM label: strip leading/trailing space synthesizing devfs names
Jan 18 2020, 3:34 AM
cem resigned from D23224: bsdinstall: Provide help text for partitioning options.
Jan 18 2020, 1:09 AM

Jan 17 2020

cem committed rS356852: net80211: Move rate printing in amrr_node_stats() to a separate method.
net80211: Move rate printing in amrr_node_stats() to a separate method
Jan 17 2020, 10:04 PM
cem closed D22318: net80211: Move rate printing in amrr_node_stats() to a separate method.
Jan 17 2020, 10:04 PM
cem added inline comments to D12773: Manage thread signal mask using a shared word, instead of syscall..
Jan 17 2020, 8:51 PM
cem added a comment to D12773: Manage thread signal mask using a shared word, instead of syscall..

Thanks, looks good to me except for one concern below.

Jan 17 2020, 8:43 PM
cem removed a reviewer for D23110: Introduce CTLFLAG_NEEDGIANT: cem.
Jan 17 2020, 4:59 PM