cem (Conrad Meyer)
User

Projects

User Details

User Since
Jul 9 2015, 9:56 PM (131 w, 6 d)

Recent Activity

Yesterday

cem committed rS328100: Convert ls(1) to not use libxo(3).
Convert ls(1) to not use libxo(3)
Wed, Jan 17, 10:48 PM
cem closed D13959: Convert ls(1) to not use libxo(3)..
Wed, Jan 17, 10:48 PM
cem added a reviewer for D13959: Convert ls(1) to not use libxo(3).: kmacy.
Wed, Jan 17, 9:12 PM
cem created D13959: Convert ls(1) to not use libxo(3)..
Wed, Jan 17, 8:52 PM

Tue, Jan 16

cem added a reviewer for D13940: Bug 225159 - `make installkernel’ should display a “completed” message if done: bdrewery.

I'd like to see someone with make/build experience review this (Bryan?) but assuming they approve it, I approve it.

Tue, Jan 16, 10:23 PM
cem updated the diff for D12723: Add ccp(4): experimental driver for AMD Crypto Co-Processor.

Rebase past smaller changes pulled out and committed already.

Tue, Jan 16, 6:11 PM
cem accepted D13923: Fix kldxref failing for modules with a short mc_cval.
Tue, Jan 16, 5:59 PM
cem added a comment to D13925: random: Add CCP random source.

iid test on RAW and SEED:

Tue, Jan 16, 5:48 PM
cem added a comment to D13925: random: Add CCP random source.

noniid on RAW and SEED samples:

Tue, Jan 16, 6:07 AM
cem added a comment to D13925: random: Add CCP random source.

iid on conditioned output samples:

Tue, Jan 16, 5:43 AM
cem added a comment to D13925: random: Add CCP random source.

What's the output when you grab the TRNG_RAW? Would that be an interesting assessment as it would get the DRBG input and assess the quality of that entropy?

Tue, Jan 16, 5:25 AM
cem added a comment to D13925: random: Add CCP random source.

The noniid test has completed:

Tue, Jan 16, 5:01 AM
cem added a comment to D13925: random: Add CCP random source.

Conrad, thanks for the details. I also looked at the code in the other review and it looks good. I’d expect whitened output from the ctr-aes drbg to measure ~6.5 bits when put through the sp800-90b tool. That’s roughly what you get out of 1000000 samples from RDRND on Intel.

Tue, Jan 16, 4:10 AM
cem updated subscribers of D12723: Add ccp(4): experimental driver for AMD Crypto Co-Processor.

CCing (maybe :-)) interested parties for the random source portion of this driver.

Tue, Jan 16, 3:04 AM
cem committed rS328038: random(4): Add CCP random source definitions.
random(4): Add CCP random source definitions
Tue, Jan 16, 2:56 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Tue, Jan 16, 2:56 AM
cem added a comment to D13925: random: Add CCP random source.

The implementation is in the associated review. We read a 32 bit register (TRNG_OUT) and get a new value every time. Here's some documentation from the device manual on how those bits are created and treated:

Tue, Jan 16, 2:53 AM

Mon, Jan 15

cem added a comment to D12723: Add ccp(4): experimental driver for AMD Crypto Co-Processor.

Put trivial random changes in independent review for secteam: https://reviews.freebsd.org/D13925

Mon, Jan 15, 11:36 PM
cem added a reviewer for D13925: random: Add CCP random source: secteam.
Mon, Jan 15, 11:35 PM
cem created D13925: random: Add CCP random source.
Mon, Jan 15, 11:35 PM
cem added a comment to D12723: Add ccp(4): experimental driver for AMD Crypto Co-Processor.

I think the driver is more or less ready to go in now.

Mon, Jan 15, 11:29 PM
cem updated the diff for D12723: Add ccp(4): experimental driver for AMD Crypto Co-Processor.

Accidentally posted two patches; remove accidentally added patch.

Mon, Jan 15, 11:27 PM
cem updated the diff for D12723: Add ccp(4): experimental driver for AMD Crypto Co-Processor.

Hide debugging (and especially sensitive content printing) behind special
macros. DPRINTF is debug spam and can be enabled at runtime. INSECURE_DEBUG()
prints sensitive material and is compiled out by default.

Mon, Jan 15, 11:24 PM
cem added inline comments to D13923: Fix kldxref failing for modules with a short mc_cval.
Mon, Jan 15, 10:10 PM
cem added inline comments to D13923: Fix kldxref failing for modules with a short mc_cval.
Mon, Jan 15, 9:56 PM
cem accepted D13921: sysutils/devcpu-data: Migrate our microcode update on Intel to use precreated files..

No objection, although my blessing is meaningless in ports.

Mon, Jan 15, 6:04 PM

Sun, Jan 14

cem added a comment to D13910: `make buildkernel' should display the build time in seconds.

Thanks. Please re-upload with context. You can either use arc diff --create or simply generate a patch with huge amounts of context ([git] diff -U999999).

Sun, Jan 14, 8:37 PM · Contributor Reviews (base)

Sat, Jan 13

cem added a comment to D12723: Add ccp(4): experimental driver for AMD Crypto Co-Processor.

Committed MAXADDR 48bit separately.

Sat, Jan 13, 5:55 PM
cem committed rS327932: amd64: Add a 48-bit MAXADDR constant.
amd64: Add a 48-bit MAXADDR constant
Sat, Jan 13, 5:55 PM
cem updated the summary of D12723: Add ccp(4): experimental driver for AMD Crypto Co-Processor.
Sat, Jan 13, 5:48 PM
cem added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..
In D13832#290897, @cem wrote:

Your CPU, "family 0xf model 0xb stepping 0x2 extfamily 0 extmodel 0x6" should be 0x60fb2 -- which, yeah, isn't one of 0x600f20, 0x610f01, or 0x600f12. So this microcode file doesn't have an update for your CPU, as I understand it.

I am not sure whether you are correct in this assumption.
The name mangling that is done by ucode-tool is bad and confusing. Imho ucode-tool should be retired, as it is legacy stuff, and the vendor-supplied binary files be used instead for more consistency.
I have done a write-up about this topic on the FreeBSD forums here, where I analyze why the microcode_update thing seems to be broken due to a fundamentally wrong approach.

Sat, Jan 13, 4:19 PM

Fri, Jan 12

cem added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..
In D13832#290895, @cy wrote:

Using the old unmodified port with split AMD firmwares:

Fri, Jan 12, 7:38 AM
cem committed rS327866: aesni(4): Quiesce spurious GCC 6.3.0 -Wmaybe-uninitialized warnings.
aesni(4): Quiesce spurious GCC 6.3.0 -Wmaybe-uninitialized warnings
Fri, Jan 12, 6:41 AM

Thu, Jan 11

cem removed a reviewer for D13837: Wider adoption of mallocarray(9).: cem.
Thu, Jan 11, 6:49 PM
cem committed rS327807: Zstd: Add bswap intrinsics for small MIPS systems (e.g., Onion Omega).
Zstd: Add bswap intrinsics for small MIPS systems (e.g., Onion Omega)
Thu, Jan 11, 6:31 AM
cem added a comment to D13837: Wider adoption of mallocarray(9)..
In D13837#290292, @pfg wrote:

For the M_NOWAIT case this matches the calloc(3) and reallocarray(3) behaviour

Thu, Jan 11, 12:40 AM
cem added a comment to D13837: Wider adoption of mallocarray(9)..
In D13837#290288, @pfg wrote:

It is now the case that it panics right

Thu, Jan 11, 12:21 AM

Wed, Jan 10

cem added a comment to D13837: Wider adoption of mallocarray(9)..

Was this mechanical (with e.g. coccinelle)?

Wed, Jan 10, 11:46 PM
cem accepted D13845: Don't hang on crashes with dumps to ada devices..

Thanks.

Wed, Jan 10, 11:23 PM
cem committed rS327802: Add encrypt+authenticate modes to cryptotest tool.
Add encrypt+authenticate modes to cryptotest tool
Wed, Jan 10, 11:19 PM
cem added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

Is there any way to check the microcode version currently in use?

Wed, Jan 10, 10:42 PM
cem committed rS327801: x86: Document purpose of _safe variants of {rd,wr}msr().
x86: Document purpose of _safe variants of {rd,wr}msr()
Wed, Jan 10, 10:41 PM
cem committed rS327800: malloc.9: Fix minor typo from rewording in r327796.
malloc.9: Fix minor typo from rewording in r327796
Wed, Jan 10, 10:21 PM
cem accepted D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

Using spectre PoC here: https://gist.githubusercontent.com/jedisct1/3bbb6e50b768968c30629bf734ea49c6/raw/6ede3c9a3356a4a55a27febaf38157897c4fed09/spectre.c/spectre.c

Wed, Jan 10, 10:04 PM
cem added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

Patch applies cleanly to my ports tree. Builds ok.

Wed, Jan 10, 9:52 PM
cem committed rS327796: mallocarray(9): panic if the requested allocation would overflow.
mallocarray(9): panic if the requested allocation would overflow
Wed, Jan 10, 9:50 PM
cem committed rS327763: Finally, fix Zstd kernel build on MIPS and RISC-V.
Finally, fix Zstd kernel build on MIPS and RISC-V
Wed, Jan 10, 6:31 AM
cem added inline comments to D13633: Add support for zstd to subr_compressor.c..
Wed, Jan 10, 1:54 AM
cem added a comment to P158 (An Untitled Masterwork).

Thanks -- incorporated.

Wed, Jan 10, 1:53 AM
cem added inline comments to D13633: Add support for zstd to subr_compressor.c..
Wed, Jan 10, 1:46 AM
cem added inline comments to D13633: Add support for zstd to subr_compressor.c..
Wed, Jan 10, 1:45 AM
cem added inline comments to D13633: Add support for zstd to subr_compressor.c..
Wed, Jan 10, 1:44 AM
cem added a comment to P158 (An Untitled Masterwork).

Thanks Ravi. How is this?

Wed, Jan 10, 1:22 AM
cem created P158 (An Untitled Masterwork).
Wed, Jan 10, 1:04 AM
cem created P157 (An Untitled Masterwork).
Wed, Jan 10, 12:52 AM
cem created P156 (An Untitled Masterwork).
Wed, Jan 10, 12:40 AM

Tue, Jan 9

cem edited P155 Masterwork From Distant Lands.
Tue, Jan 9, 8:59 PM
cem committed rS327738: Fix Zstd x86 kernel build with -march=<specific>.
Fix Zstd x86 kernel build with -march=<specific>
Tue, Jan 9, 8:53 PM
cem committed rS327715: Fix Zstd kernel build with GCC 4.2.
Fix Zstd kernel build with GCC 4.2
Tue, Jan 9, 3:28 AM

Mon, Jan 8

cem added a comment to D13633: Add support for zstd to subr_compressor.c..

If by "other pieces" you mean D13632, I am going to commit them momentarily. :)

Mon, Jan 8, 9:03 PM
cem added a comment to D13633: Add support for zstd to subr_compressor.c..

Yes, this is only the kernel code changes from your original patch. Sorry for not specifying that.

Mon, Jan 8, 8:52 PM
cem added a comment to D13633: Add support for zstd to subr_compressor.c..

We're missing savecore support, manual page additions, as well as inclusion in GENERIC, right?

Mon, Jan 8, 8:41 PM
cem committed rS327706: Integrate zstd into the kernel.
Integrate zstd into the kernel
Mon, Jan 8, 8:14 PM
cem closed D10407: Modify zstd so it can be built into the kernel as well.
Mon, Jan 8, 8:14 PM
cem accepted D13632: Rework the gzio API..

LGTM, modulo disagreement about default-compress disable. Ok to commit — we can discuss later if and how default-compress would be implemented.

Mon, Jan 8, 8:00 PM
cem added a comment to D13797: PTI for amd64..
In D13797#289001, @imp wrote:

PTI means what?

Mon, Jan 8, 5:43 PM
cem added inline comments to D13528: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_* (logic only)..
Mon, Jan 8, 5:31 PM

Sat, Jan 6

cem added a comment to D13784: Make loader.efi dual boot, step 1.

What's dual boot mean in this context? Thanks.

Sat, Jan 6, 6:12 PM
cem accepted D13632: Rework the gzio API..
Sat, Jan 6, 1:47 AM

Fri, Jan 5

cem added a comment to D10407: Modify zstd so it can be built into the kernel as well.

Please commit this :-).

Fri, Jan 5, 11:50 PM
cem added inline comments to D13528: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_* (logic only)..
Fri, Jan 5, 11:48 PM
cem accepted D13737: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_* (cosmetic only)..
Fri, Jan 5, 11:38 PM

Tue, Jan 2

cem closed D13732: rpcbind: Fix race in signal termination.

r327495

Tue, Jan 2, 5:28 PM
cem committed rS327495: rpcbind: Fix race in signal termination.
rpcbind: Fix race in signal termination
Tue, Jan 2, 5:25 PM
cem updated the diff for D13732: rpcbind: Fix race in signal termination.

Abort nice program shutdown on unexpected pipefd write(2) failure.

Tue, Jan 2, 5:23 AM
cem added inline comments to D13732: rpcbind: Fix race in signal termination.
Tue, Jan 2, 5:21 AM
cem created D13732: rpcbind: Fix race in signal termination.
Tue, Jan 2, 2:05 AM
cem committed rS327483: rpcbind: Fix build.
rpcbind: Fix build
Tue, Jan 2, 1:48 AM
cem committed rS327482: rpcbind: Do not use signal-unsafe functions in SIGTERM handler.
rpcbind: Do not use signal-unsafe functions in SIGTERM handler
Tue, Jan 2, 12:48 AM
cem closed D13728: PR 224503: rpcbind: Do not use signal-unsafe functions in SIGTERM handler.
Tue, Jan 2, 12:48 AM
cem updated the diff for D13728: PR 224503: rpcbind: Do not use signal-unsafe functions in SIGTERM handler.

Move shutdown code to main loop and use signal-safe flag to induce shutdown.

Tue, Jan 2, 12:09 AM

Mon, Jan 1

cem updated the diff for D12723: Add ccp(4): experimental driver for AMD Crypto Co-Processor.

Implement AES-XTS.

Mon, Jan 1, 10:48 PM
cem added a comment to D13728: PR 224503: rpcbind: Do not use signal-unsafe functions in SIGTERM handler.
In D13728#287214, @kib wrote:

This change makes the WARMSTART option non-functional.

Proper fix would be to set a flag in the signal handler and check for it in my_svc_run() loop, doing the dump of the rpc registrations in the context of the main loop.

Mon, Jan 1, 10:16 PM
cem created D13728: PR 224503: rpcbind: Do not use signal-unsafe functions in SIGTERM handler.
Mon, Jan 1, 9:40 PM

Sun, Dec 31

cem added inline comments to D13682: Add memset_s(3) doc to memset(3) man page..
Sun, Dec 31, 10:22 PM

Fri, Dec 29

cem committed rS327364: Add AHCI/XHCI device IDs found on AMD 1950X+X399 system.
Add AHCI/XHCI device IDs found on AMD 1950X+X399 system
Fri, Dec 29, 10:24 PM
cem committed rS327362: find(1): Fix -newer and -samefile to conform to POSIX[0].
find(1): Fix -newer and -samefile to conform to POSIX[0]
Fri, Dec 29, 10:09 PM
cem added inline comments to D13682: Add memset_s(3) doc to memset(3) man page..
Fri, Dec 29, 9:31 PM
cem added inline comments to D13682: Add memset_s(3) doc to memset(3) man page..
Fri, Dec 29, 9:28 PM
cem added inline comments to D13682: Add memset_s(3) doc to memset(3) man page..
Fri, Dec 29, 8:53 PM

Tue, Dec 26

cem added inline comments to D13559: Fix gmirror BIO_FLUSH and sync collision queuing..
Tue, Dec 26, 5:44 PM

Sat, Dec 23

cem added a comment to D10407: Modify zstd so it can be built into the kernel as well.

Please go ahead and commit this, after fixing the easy issues brought up by Warner. :-)

Sat, Dec 23, 7:06 PM
cem added inline comments to D13101: Add support for Zstd-compressed kernel and userspace dumps.
Sat, Dec 23, 7:05 PM

Fri, Dec 22

cem added a reviewer for D13559: Fix gmirror BIO_FLUSH and sync collision queuing.: cem.

I've only looked at this first half of this patch. Most of my comments aren't requests for any change, but clarifying questions for me, as someone not very familiar with gmirror. Gotta run, will look more later.

Fri, Dec 22, 2:36 PM
cem accepted D13578: humanize_number(3): fix edge case for rounding 999.5+.
In D13578#283989, @cem wrote:

I don't understand the actual algorithmic change, but given the strong test coverage, I think I'm ok with this. Some style nits below.

Issue was caused by the way the final value was calculated in snprintf call, where remainder and divisor/2 was added back to the divided number. If remainder + divisor/2 was larger than 1024, it added 1 to the final value. If the final value as already 999 (as in the example reported), that brought it to 1000. If the buffer length provided was 4 (as is the case with ls), that left no space for the unit character.
Same issue was also present for other numbers if too small buffer lengths where used.

The fix continues the division of the original number if the above case happens -- added the appropriate check to the for loop performing the division. This lowers the value shown, to make it fit into the buffer space provided (1.0M for 4 character buffer, as used by ls).

Fri, Dec 22, 3:55 AM · tests

Thu, Dec 21

cem added a comment to D13578: humanize_number(3): fix edge case for rounding 999.5+.

I don't understand the actual algorithmic change, but given the strong test coverage, I think I'm ok with this. Some style nits below.

Thu, Dec 21, 9:47 PM · tests

Dec 19 2017

cem added inline comments to D13528: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_* (logic only)..
Dec 19 2017, 3:24 AM
cem committed rS326956: Implement ACPI CPU support when Processor object is not present.
Implement ACPI CPU support when Processor object is not present
Dec 19 2017, 2:49 AM
cem closed D13457: Implement ACPI CPU support when Processor object is not present.
Dec 19 2017, 2:49 AM

Dec 15 2017

cem added a comment to D13487: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_*..
In D13487#282200, @fsu wrote:

So, may be let wait some time the comments from @cem, if not I will send the patch to @pfg for approve.

Dec 15 2017, 5:30 PM