- User Since
- Jul 9 2015, 9:56 PM (201 w, 4 d)
Thanks for taking a look, Xin!
Need ports committer blessing to fix.
Now with patches 'svn add'ed
The changes look straightforward and correct to me, modulo stylistic nits. I agree with everything Mark has already said.
Sun, May 19
Need secteam approval.
Add default-off (for now) knob to enable/disable the feature
- Add comment to genrandom justifying not rekeying Chacha (caveat, this whole
function is removed in the following differential, but I did try to flesh out a
similar comment in the relevant place there)
Looks great, thanks for doing this!
I think to actually land this, it probably makes sense to hide this behavior behind a non-default tunable. I don't think that complicates things too much, but please discuss. It's certainly a "Relnotes: yes". Is that acceptable from a secteam perspective, @delphij ?
Thanks Mark for taking a look at both of these differentials!
Note that the fast path doesn't work on real systems with SMAP. (It worked in a bhyve VM, of course.) I'm not sure vslock provides sufficient protection against concurrent modification of the UVA to copy directly into it, and the actual difference was not large (2-3%). So I will probably revert that portion. The rest is useful for the follow-up patch, see child revision.
Sat, May 18
Thanks for doing this! It mostly looks great to me, just some minor const and bool style quibbles below.
Thu, May 16
Committed in r347888.
Mon, May 13
Thanks for reviewing, Xin!
Sun, May 12
Sat, May 11
Fix lock recursion; didn't recall that pre_read invoked seeded().
Fri, May 10
- Add and use netdump_enabled() predicate. We rely on sx_assert neutering
during kdb/panic to obviate the lock assertion during the dump-time code, which
generally does not take locks.
- Refactor de-configuration into netdump_unconfigure() routine
- Rebase on D20233
Thu, May 9
Huh, I figured linker failure would prevent MOD_LOAD and thus it wouldn't matter. I had thought about providing a 3rd panic function like this but didn't know if it was required and couldn't think of a reason it might be. Guess I was mistaken :-).
So, I think this was an intentional feature and there are automatically generated numerical nodes which are not actually present in the tree structure.
Wed, May 8
Thanks Mark and Xin!
- Drop ifndef wat
- Drop bangbang "operator" -- bool implicitly coerces on assignment already
Tue, May 7
Now that some of the dust has settled around random, I'd like to work on getting this in.