Page MenuHomeFreeBSD

cem (Conrad Meyer)
User

Projects

User Details

User Since
Jul 9 2015, 9:56 PM (218 w, 3 d)

Recent Activity

Today

cem added inline comments to D21669: mtod macro: Drop the type argument.
Mon, Sep 16, 5:04 AM
cem updated the test plan for D21669: mtod macro: Drop the type argument.
Mon, Sep 16, 5:01 AM
cem created D21669: mtod macro: Drop the type argument.
Mon, Sep 16, 4:59 AM

Yesterday

cem added inline comments to D20477: Introduce stats(3).
Sun, Sep 15, 9:32 PM
cem added a comment to D20477: Introduce stats(3).

Some drive by comments — I haven't had time to read the 3-4 thousand lines of code in this review fully.

Sun, Sep 15, 9:29 PM
cem added inline comments to D18028: Summary: Add support for Intel Speed Shift.
Sun, Sep 15, 7:52 PM

Fri, Sep 13

cem added inline comments to D21541: debugnet(4): Add optional full-duplex mode.
Fri, Sep 13, 10:08 PM
cem added a comment to D20324: Introduce the ARB tree(3) macros.

I'm still skeptical of the need to memcpy out a tree structure (are we doing queries on both sides? one side necessarily being stale?). This has never really been addressed?

Fri, Sep 13, 9:41 PM
cem added inline comments to D21541: debugnet(4): Add optional full-duplex mode.
Fri, Sep 13, 9:36 PM

Thu, Sep 12

cem added a comment to D21427: vfs: remove flags argument from VOP_UNLOCK.

Can you post the coccinelle script used somewhere? Thanks.

Thu, Sep 12, 10:27 PM

Wed, Sep 11

cem committed rS352233: buf: Add B_INVALONERR flag to discard data.
buf: Add B_INVALONERR flag to discard data
Wed, Sep 11, 9:24 PM
cem closed D21539: buf: Add bfinval() routine to discard data.
Wed, Sep 11, 9:24 PM
cem updated the diff for D21539: buf: Add bfinval() routine to discard data.

Drop bfinval, add B_INVALONERR flag with appropriate behavior.

Wed, Sep 11, 5:01 PM

Tue, Sep 10

cem added inline comments to D21482: debugnet(4): Infer non-server connection parameters.
Tue, Sep 10, 5:20 AM
cem added a comment to D21460: Add ddb(4) 'netdump' command to netdump a core without preconfiguration.

@markj I've moved over discussion of netdump_configure() / CURVNET / etc from D21482 to here. I'll admit I don't understand VNETs at all, so I'm pretty naive about what is reasonable where. Given you have some idea of what the right thing to do is, I'm totally happy to do just do that.

Tue, Sep 10, 5:19 AM
cem committed rS352113: Appease Clang false-positive Werrors in r352112.
Appease Clang false-positive Werrors in r352112
Tue, Sep 10, 1:57 AM

Mon, Sep 9

cem added inline comments to D21568: Implement NetGDB(4).
Mon, Sep 9, 11:49 PM
cem added a reviewer for D21568: Implement NetGDB(4): emaste.
Mon, Sep 9, 10:55 PM
cem committed rS352112: ddb(4): Add 'show route <dest>' and 'show routetable [<af>]'.
ddb(4): Add 'show route <dest>' and 'show routetable [<af>]'
Mon, Sep 9, 10:54 PM
cem closed D21510: ddb(4): Add 'show route <dest>' and 'show routetable [<af>]'.
Mon, Sep 9, 10:54 PM
cem added inline comments to D21510: ddb(4): Add 'show route <dest>' and 'show routetable [<af>]'.
Mon, Sep 9, 10:53 PM
cem added a comment to D21510: ddb(4): Add 'show route <dest>' and 'show routetable [<af>]'.

I have no objection. I plan to review the pending diffs in the next day or so, but am swamped this week and not particularly qualified to review this particular one, so please don't wait on me if you're in a hurry.

Mon, Sep 9, 10:27 PM
cem added a comment to D21510: ddb(4): Add 'show route <dest>' and 'show routetable [<af>]'.

Any objection in principle? Planning to review or ENOTIME? Suggestions for reviewers with free time and interest in this layer of the network stack?

Mon, Sep 9, 10:07 PM
cem committed rS352075: ddb(4): Add some support for lexing IPv6 addresses.
ddb(4): Add some support for lexing IPv6 addresses
Mon, Sep 9, 4:32 PM
cem closed D21509: ddb(4): Add some support for lexing IPv6 addresses.
Mon, Sep 9, 4:32 PM
cem committed rS352074: ddb(4): Enhance lexer functionality for specialized commands.
ddb(4): Enhance lexer functionality for specialized commands
Mon, Sep 9, 4:31 PM
cem closed D21459: ddb(4): Enhance functionality for specialized ddb commands.
Mon, Sep 9, 4:31 PM
cem created D21568: Implement NetGDB(4).
Mon, Sep 9, 5:55 AM
cem committed rS352053: ddb(4): Move an extern variable declaration to a header.
ddb(4): Move an extern variable declaration to a header
Mon, Sep 9, 1:33 AM

Sun, Sep 8

cem committed rS352050: gdb(4): Root a sysctl tree at 'debug.gdb.'.
gdb(4): Root a sysctl tree at 'debug.gdb.'
Sun, Sep 8, 10:53 PM

Sat, Sep 7

cem accepted D20752: Add support for zstd to libarchive.
Sat, Sep 7, 10:02 PM

Fri, Sep 6

cem committed rS351952: Fix build after r351934.
Fix build after r351934
Fri, Sep 6, 6:33 PM
cem committed rS351929: ufs: Remove redundant brelse() after r294954.
ufs: Remove redundant brelse() after r294954
Fri, Sep 6, 8:09 AM
cem committed rS351928: msdosfs: Remove redundant brelse() after r294954.
msdosfs: Remove redundant brelse() after r294954
Fri, Sep 6, 8:08 AM
cem committed rS351927: cd9660: Remove redundant brelse() after r294954.
cd9660: Remove redundant brelse() after r294954
Fri, Sep 6, 8:07 AM
cem committed rS351926: ext2fs: Remove redundant brelse() after r294954.
ext2fs: Remove redundant brelse() after r294954
Fri, Sep 6, 8:07 AM
cem added inline comments to D21539: buf: Add bfinval() routine to discard data.
Fri, Sep 6, 8:03 AM
cem updated the diff for D21539: buf: Add bfinval() routine to discard data.
  • Take kib's suggestion of using incore() in place of getblk(). Not sure if it is obviously an improvement, but it seems to work (same tests pass).
  • (Style concern about C99 declaration is obviated by removal of variable.)
Fri, Sep 6, 3:21 AM
cem added inline comments to D21539: buf: Add bfinval() routine to discard data.
Fri, Sep 6, 2:56 AM
cem created D21541: debugnet(4): Add optional full-duplex mode.
Fri, Sep 6, 12:53 AM

Thu, Sep 5

cem updated the diff for D21539: buf: Add bfinval() routine to discard data.
  • Fix race in the msdosfs ro->rw upgrade case by permitting a variant of markvoldirty to bypass the msdosfs RONLY flag otherwise preventing writes
Thu, Sep 5, 10:00 PM
cem committed rS351899: Remove long-dead BUF_ASSERT_{,UN}HELD assertions.
Remove long-dead BUF_ASSERT_{,UN}HELD assertions
Thu, Sep 5, 9:43 PM
cem committed rS351898: msdosfs: Drop an unneeded brelse in bread error condition.
msdosfs: Drop an unneeded brelse in bread error condition
Thu, Sep 5, 9:31 PM
cem added inline comments to D21539: buf: Add bfinval() routine to discard data.
Thu, Sep 5, 9:22 PM
cem updated the test plan for D21539: buf: Add bfinval() routine to discard data.
Thu, Sep 5, 8:52 PM
cem created D21539: buf: Add bfinval() routine to discard data.
Thu, Sep 5, 7:55 PM
cem added a comment to D21535: patch(1): give /dev/null patches special treatment.

I had thought about this and I think I had a reason for not going that route. I don't recall now why, though, so I'll revisit.

Thu, Sep 5, 5:03 PM
cem accepted D21535: patch(1): give /dev/null patches special treatment.
Thu, Sep 5, 5:02 PM
cem added a comment to D21535: patch(1): give /dev/null patches special treatment.

Meta-question: Does /dev/null need special treatment or should we reject on the basis of "zero matching lines of context" anyway? Like, if the added hunk starts at @@ 0,0 @@ or whatever and the prior contents are empty...

Thu, Sep 5, 4:51 PM
cem committed rS351835: sys/mount.h: Comment on distinction between vfs_{c,}mount.
sys/mount.h: Comment on distinction between vfs_{c,}mount
Thu, Sep 5, 12:56 AM

Wed, Sep 4

cem updated the diff for D21510: ddb(4): Add 'show route <dest>' and 'show routetable [<af>]'.

Rebase on lexer changes.

Wed, Sep 4, 12:26 AM
cem updated the diff for D21509: ddb(4): Add some support for lexing IPv6 addresses.

Switch to per-lex flags for the hexadecimal numbers mode (instead of a global).

Wed, Sep 4, 12:25 AM
cem updated the diff for D21482: debugnet(4): Infer non-server connection parameters.

Rebase on lexer API change.

Wed, Sep 4, 12:24 AM
cem updated the diff for D21460: Add ddb(4) 'netdump' command to netdump a core without preconfiguration.

Rebase on lexer API change.

Wed, Sep 4, 12:23 AM
cem updated the diff for D21459: ddb(4): Enhance functionality for specialized ddb commands.

Switch from globals to per-lex flags.

Wed, Sep 4, 12:23 AM

Tue, Sep 3

cem planned changes to D21459: ddb(4): Enhance functionality for specialized ddb commands.

Is there some reason it isn't easy to add a variant of db_read_token() that will optionally return tWSPACE and can take a caller-supplied radix? That would seem cleaner than adding more global state.

Tue, Sep 3, 10:48 PM
cem created D21510: ddb(4): Add 'show route <dest>' and 'show routetable [<af>]'.
Tue, Sep 3, 5:32 PM
cem created D21509: ddb(4): Add some support for lexing IPv6 addresses.
Tue, Sep 3, 5:27 PM
cem added a comment to D21459: ddb(4): Enhance functionality for specialized ddb commands.

I'd like to go ahead and commit this one independent of netdump/debugnet/netgdb, actually, because I have other lexer extensions and ddb commands orthogonal to netdump/debugnet that stack on this. Can I get some eyeballs on this review, please?

Tue, Sep 3, 5:24 PM

Mon, Sep 2

cem added a comment to D21448: Add a very limited DDB dumpon(8)-alike to MI dumper code.

I'm not sure the "_static" suffix really adds anything, FWIW.

Mon, Sep 2, 5:44 PM

Sun, Sep 1

cem created D21482: debugnet(4): Infer non-server connection parameters.
Sun, Sep 1, 8:38 AM

Fri, Aug 30

cem added a comment to D21460: Add ddb(4) 'netdump' command to netdump a core without preconfiguration.

I think I got all the oustanding issues, let me know if you see any others or need more time. (I still have more WIP that will go to phab before any of this goes into SVN, so, no big hurry). Thanks for the review.

Fri, Aug 30, 10:46 PM
D21460: Add ddb(4) 'netdump' command to netdump a core without preconfiguration now requires review to proceed.
  • wording
  • check supported before UP
  • newline
Fri, Aug 30, 8:45 PM
cem added inline comments to D21460: Add ddb(4) 'netdump' command to netdump a core without preconfiguration.
Fri, Aug 30, 8:37 PM
cem added inline comments to D21460: Add ddb(4) 'netdump' command to netdump a core without preconfiguration.
Fri, Aug 30, 8:34 PM
cem added a comment to D21460: Add ddb(4) 'netdump' command to netdump a core without preconfiguration.
  • document in netdump.4 as well
Fri, Aug 30, 8:29 PM
D21460: Add ddb(4) 'netdump' command to netdump a core without preconfiguration now requires review to proceed.
  • Drop unneeded ref, but add comment about why we don't need it
  • Fako -> Fake
  • Document in ddb.4; mild organizational changes while there to make sense of sometimes non-alphabetical command sorting.
Fri, Aug 30, 8:25 PM
cem added inline comments to D21460: Add ddb(4) 'netdump' command to netdump a core without preconfiguration.
Fri, Aug 30, 5:00 PM
cem added a comment to D21460: Add ddb(4) 'netdump' command to netdump a core without preconfiguration.

Thanks!

Fri, Aug 30, 4:37 PM

Thu, Aug 29

cem added a comment to D21421: Split out a more generic panicnet(4) from netdump(4).

I'm not crazy about the fact that debugnet subsumes most the netdump protocol itself:

  • netdump defines some message types that are not in the main debugnet header, so if you define a new debugnet message type, you have to be careful not to collide with netdump.
Thu, Aug 29, 8:57 PM
cem created D21460: Add ddb(4) 'netdump' command to netdump a core without preconfiguration.
Thu, Aug 29, 12:17 AM

Wed, Aug 28

cem created D21459: ddb(4): Enhance functionality for specialized ddb commands.
Wed, Aug 28, 10:06 PM
D21448: Add a very limited DDB dumpon(8)-alike to MI dumper code now requires review to proceed.

Rename the routines.

Wed, Aug 28, 10:04 PM
cem added a comment to D21421: Split out a more generic panicnet(4) from netdump(4).

I generally agree with the style(9) argument, however, if_t explicitly was introduced in r266974 as part of the - back then - new API:
"This commit introduces the 'if_t' type to replace 'struct ifnet *'as the type of a network interface."

Wed, Aug 28, 7:54 PM
cem added a comment to D21448: Add a very limited DDB dumpon(8)-alike to MI dumper code.

Thanks — I'll plan to make the name change. Re: the flag, the idea is that this type of dumper is only added to the list during db/panic time, when no external event would cause a dumper_remove (unless I'm forgetting something). And then removed before normal context resumes (if !panic). So maybe the flag is redundant? It wouldn't hurt to add in any case.

Wed, Aug 28, 7:49 PM
cem added a comment to D21448: Add a very limited DDB dumpon(8)-alike to MI dumper code.

Looks like some code is missing?

Wed, Aug 28, 5:23 PM
cem added a comment to D21421: Split out a more generic panicnet(4) from netdump(4).

Could you please consistently use if_t instead of struct ifnet * in debugnet(4) components and its support code in e. g. drivers?

Wed, Aug 28, 5:22 PM
cem created D21448: Add a very limited DDB dumpon(8)-alike to MI dumper code.
Wed, Aug 28, 3:08 AM
D21287: fusefs: fix list size calculation bug in fuse_vnop_listextattr is now accepted and ready to land.

This approach looks technically correct to me, and it simplifies the logic, but there is definitely some microbenchmark cost to exiting to userspace every retry instead of doing so "a few times" in the kernel (with some algorithm). But this is maybe just premature optimization on my part.

Wed, Aug 28, 12:50 AM

Tue, Aug 27

cem added inline comments to D21421: Split out a more generic panicnet(4) from netdump(4).
Tue, Aug 27, 10:40 PM
cem added a comment to D21421: Split out a more generic panicnet(4) from netdump(4).

Address review feedback:

Tue, Aug 27, 10:37 PM
cem added a comment to D21421: Split out a more generic panicnet(4) from netdump(4).

One missed boring name change. No functional change.

Tue, Aug 27, 9:42 PM
cem added a comment to D21421: Split out a more generic panicnet(4) from netdump(4).

Just rename to debugnet, etc. No other changes included in this revision.

Tue, Aug 27, 9:02 PM

Mon, Aug 26

cem added inline comments to D21287: fusefs: fix list size calculation bug in fuse_vnop_listextattr.
Mon, Aug 26, 9:24 PM
cem added a comment to D21287: fusefs: fix list size calculation bug in fuse_vnop_listextattr.

Sorry about the long delay — life has been busy.

Mon, Aug 26, 9:04 PM
cem added a comment to D21421: Split out a more generic panicnet(4) from netdump(4).

I'll do the big name change as a single step first, then work on addressing the other good feedback (to make it easier to use Differential's revision comparison feature). Please continue to submit feedback.

Mon, Aug 26, 7:02 PM
cem added a comment to D21421: Split out a more generic panicnet(4) from netdump(4).

I think net/ is justifiable from the perspective that netinet/netinet6 are files for the production IPv4/IPv6 stacks, while netdump/panicnet/debugnet is really a stripped-down special-purpose stack.

Mon, Aug 26, 6:57 PM
cem added inline comments to D21421: Split out a more generic panicnet(4) from netdump(4).
Mon, Aug 26, 6:37 PM
cem added a comment to D21421: Split out a more generic panicnet(4) from netdump(4).
In D21421#466125, @jhb wrote:

Is the intention to support remote GDB over this?

Mon, Aug 26, 6:08 PM
cem updated the test plan for D21421: Split out a more generic panicnet(4) from netdump(4).
Mon, Aug 26, 5:20 PM
cem created D21421: Split out a more generic panicnet(4) from netdump(4).
Mon, Aug 26, 5:16 PM

Sat, Aug 24

cem added a comment to D21389: Stop using des_cblock * for arguments to DES functions..

Bit sad to be fixing DES in 2019 but unfortunately, this looks correct to me...

Sat, Aug 24, 1:37 AM

Thu, Aug 22

cem added a comment to D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED..

I'd like the commit message to provide more context but the change is good.

Thu, Aug 22, 8:15 PM
cem added a comment to D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED..
In D21362#464855, @jhb wrote:
In D21362#464773, @mjg wrote:

I disagree with mixing up LA_ and MA_ namespaces.

This is to avoid having lookup tables in every single lc_assert method.

Thu, Aug 22, 5:04 PM
cem accepted D21363: Properly update FSInfo block after generation..
Thu, Aug 22, 3:13 PM
cem committed rS351381: Fix i386 build after r351368.
Fix i386 build after r351368
Thu, Aug 22, 4:31 AM
cem committed rS351370: gdb(4): Style.
gdb(4): Style
Thu, Aug 22, 12:36 AM
cem committed rS351369: gdb(4):amd64: Bump MI GDB_BUFSZ for more efficient transfers.
gdb(4):amd64: Bump MI GDB_BUFSZ for more efficient transfers
Thu, Aug 22, 12:35 AM
cem committed rS351368: gdb(4): Implement qXfer:threads:read.
gdb(4): Implement qXfer:threads:read
Thu, Aug 22, 12:34 AM
cem added a comment to D21351: ping: do reverse DNS lookup for a reply by default.

Personally, I could go either way for the default. What's most important IMHO is that ping and ping6 have the same default. Until now, they didn't.

Thu, Aug 22, 12:29 AM