Page MenuHomeFreeBSD

cem (Conrad Meyer)
User

Projects

User Details

User Since
Jul 9 2015, 9:56 PM (188 w, 6 d)

Recent Activity

Today

cem accepted D19273: Fix a hash table lookup race in fasttrap_pid_probe()..
In D19273#412540, @cem wrote:

Solve the race using a per-process generation counter which gets updated
before a tracepoint is removed from the hash table, and after it is
removed from the target process' vmspace.

We do the latter, but I think we're missing the former.

Why? The code immediately after the increment updates the hash table.

Thu, Feb 21, 3:52 AM
cem committed rS344407: fuse: Fix a regression introduced in r337165.
fuse: Fix a regression introduced in r337165
Thu, Feb 21, 2:42 AM
cem requested changes to D19273: Fix a hash table lookup race in fasttrap_pid_probe()..

I wasn't careful about preserving #ifdefs here: fasttrap has been virtually untouched upstream for the past 5 years, so once this commit is in I'm going to get rid of illumos ifdefs there in an attempt to make the code a bit easier to read.

Thu, Feb 21, 2:02 AM
cem accepted D19266: Modularize xz..
Thu, Feb 21, 12:58 AM

Yesterday

cem requested changes to D19245: Add support for legacy 512-byte block size MBRs on 4K block size disks.
Wed, Feb 20, 11:33 PM
cem added a reviewer for D19273: Fix a hash table lookup race in fasttrap_pid_probe().: cem.
Wed, Feb 20, 11:11 PM
cem added a comment to D19264: ctf: Add support for typed constant values.

Prior to this change, ctfdump shows [2] FUNC (kern_chflagsat) returns: 1 args: (1173, 1, 5, 142, 91, 1); ... <142> ENUM uio_seg (i.e., no idea it's been const-ed out of the ABI).

Wed, Feb 20, 4:59 PM
cem added a comment to D19264: ctf: Add support for typed constant values.

Can you provide an example DIE where this occurs? Which compiler are you using?

Wed, Feb 20, 4:49 PM
cem updated the test plan for D19265: libctf, dtrace: Plumb through support for CONSTVAL values.
Wed, Feb 20, 7:00 AM
cem added a parent revision for D19265: libctf, dtrace: Plumb through support for CONSTVAL values: D19264: ctf: Add support for typed constant values.
Wed, Feb 20, 6:57 AM
cem added a child revision for D19264: ctf: Add support for typed constant values: D19265: libctf, dtrace: Plumb through support for CONSTVAL values.
Wed, Feb 20, 6:57 AM
cem created D19265: libctf, dtrace: Plumb through support for CONSTVAL values.
Wed, Feb 20, 6:57 AM
cem created D19264: ctf: Add support for typed constant values.
Wed, Feb 20, 6:50 AM
cem committed rS344334: Fuse: whitespace and style(9) cleanup.
Fuse: whitespace and style(9) cleanup
Wed, Feb 20, 2:49 AM
cem committed rS344333: fuse: add descriptions for remaining sysctls.
fuse: add descriptions for remaining sysctls
Wed, Feb 20, 2:49 AM
cem added a comment to D19231: Fix few issues in ioat(4) driver..

Thanks, the locking around the global ioat list seems more robust. How much testing have you been able to perform with this patch? Do you have a test that can induce an error condition?

Wed, Feb 20, 1:39 AM

Tue, Feb 19

cem added inline comments to D19245: Add support for legacy 512-byte block size MBRs on 4K block size disks.
Tue, Feb 19, 9:27 PM
cem accepted D19246: svn: support building as PIE.

Why is the MK_PIE PIE_SUFFIX “_pic”? That seems inconsistent. Otherwise, LGTM.

Tue, Feb 19, 5:56 PM

Mon, Feb 18

cem updated subscribers of D19231: Fix few issues in ioat(4) driver..

+CC jimharris@, who might have some feedback or ability to help facilitate access to NDA'd register documents

Mon, Feb 18, 8:32 PM
Herald added a reviewer for D8920: libdwarf: Add DW_AT_specification handling to dwarf_attrval_*: manpages.

I realize this is old, but I figure the same group is still likely to be interested. I think we'll need more like this to support GCC6+ ctfconvert. E.g.,

Mon, Feb 18, 7:20 AM

Sat, Feb 16

cem added a reviewer for D18028: Summary: Add support for Intel Speed Shift: cem.
Sat, Feb 16, 10:09 PM
cem added a comment to D18028: Summary: Add support for Intel Speed Shift.

Thanks for doing this, Ben! I'm sorry it took me so long to take a look and appreciate your patience.

Sat, Feb 16, 10:08 PM
cem added inline comments to D18028: Summary: Add support for Intel Speed Shift.
Sat, Feb 16, 12:51 AM
cem added inline comments to D18028: Summary: Add support for Intel Speed Shift.
Sat, Feb 16, 12:46 AM

Fri, Feb 15

cem committed rS344189: Fixup bsd.prog.mk after r344182.
Fixup bsd.prog.mk after r344182
Fri, Feb 15, 11:42 PM
cem abandoned D19088: FUSE: Respect userspace FS "do-not-cache" of file attributes.

r344183

Fri, Feb 15, 10:57 PM
cem abandoned D19089: FUSE: Respect userspace FS "do-not-cache" of path components.

r344184

Fri, Feb 15, 10:57 PM
cem abandoned D19161: FUSE: Only "dirty" cached file size when data is dirty.

r344185

Fri, Feb 15, 10:56 PM
cem abandoned D19162: FUSE: The FUSE design expects writethrough caching.

r344186

Fri, Feb 15, 10:56 PM
cem abandoned D19163: FUSE: Refresh cached file size when it changes (lookup).

r344187

Fri, Feb 15, 10:56 PM
cem committed rS344187: FUSE: Refresh cached file size when it changes (lookup).
FUSE: Refresh cached file size when it changes (lookup)
Fri, Feb 15, 10:55 PM
cem committed rS344186: FUSE: The FUSE design expects writethrough caching.
FUSE: The FUSE design expects writethrough caching
Fri, Feb 15, 10:53 PM
cem committed rS344185: FUSE: Only "dirty" cached file size when data is dirty.
FUSE: Only "dirty" cached file size when data is dirty
Fri, Feb 15, 10:51 PM
cem committed rS344184: FUSE: Respect userspace FS "do-not-cache" of path components.
FUSE: Respect userspace FS "do-not-cache" of path components
Fri, Feb 15, 10:50 PM
cem committed rS344183: FUSE: Respect userspace FS "do-not-cache" of file attributes.
FUSE: Respect userspace FS "do-not-cache" of file attributes
Fri, Feb 15, 10:49 PM

Thu, Feb 14

cem accepted D19090: Add AES-CCM encryption.

LGTM, thanks

Thu, Feb 14, 9:19 PM
cem added a comment to D19090: Add AES-CCM encryption.

All of the changes since the initial patch LGTM; I count 4 issues from my initial pass that I'd consider unresolved for now (all commented on in the previous update, should be pretty clear). Like before, mostly LGTM, minus the few relatively minor issues.

Thu, Feb 14, 8:43 PM
cem added inline comments to D19090: Add AES-CCM encryption.
Thu, Feb 14, 8:39 PM

Tue, Feb 12

cem created D19163: FUSE: Refresh cached file size when it changes (lookup).
Tue, Feb 12, 9:43 AM
cem created D19162: FUSE: The FUSE design expects writethrough caching.
Tue, Feb 12, 9:41 AM
cem created D19161: FUSE: Only "dirty" cached file size when data is dirty.
Tue, Feb 12, 9:40 AM

Mon, Feb 11

cem added a comment to D3715: Add "rcorder -p"..
In D3715#409480, @trasz wrote:

Okay, so apart from implementation problems, there's actually a major architectural issue here: the fact that we wait for all the scripts from the previous generation. Do you see any way to actually fix it, or should we perhaps just scrap it and go back to the drawing board?

Mon, Feb 11, 5:31 PM
cem accepted D18592: Add CBC-MAC authentication code.
Mon, Feb 11, 8:21 AM
cem added a comment to D18592: Add CBC-MAC authentication code.

Looks good except for one remaining item.

Mon, Feb 11, 6:27 AM
cem committed rS343991: gbde(8) - simplify randomisation with arc4random_buf.
gbde(8) - simplify randomisation with arc4random_buf
Mon, Feb 11, 12:11 AM

Sun, Feb 10

cem committed rS343985: Prevent overflow for usertime/systime in caclru1.
Prevent overflow for usertime/systime in caclru1
Sun, Feb 10, 11:08 PM
cem committed rS343949: Revert r343713 temporarily.
Revert r343713 temporarily
Sun, Feb 10, 7:54 AM
cem added a comment to D3715: Add "rcorder -p"..
In D3715#409280, @imp wrote:

I wonder: why not leverage tsort?

Sun, Feb 10, 1:34 AM

Sat, Feb 9

cem added a comment to D3715: Add "rcorder -p"..
In D3715#409266, @cem wrote:

I suspect the rcorder -p mode could be implemented much less invasively than this change. It's fundamentally the same graph algorithm. I'll give it a shot.

Sat, Feb 9, 11:27 PM
cem added a comment to D3715: Add "rcorder -p"..

I suspect the rcorder -p mode could be implemented much less invasively than this change. It's fundamentally the same graph algorithm. I'll give it a shot.

Sat, Feb 9, 11:01 PM

Fri, Feb 8

cem accepted D19105: CID 1008620: Logically dead code in newsyslog.c.
Fri, Feb 8, 4:39 AM

Thu, Feb 7

cem added a comment to D19109: CID 1009492: Logically dead code in sys/cam/scsi/scsi_xpt.c.
In D19109#408718, @mav wrote:

I think I would remove this code completely, together with above NULL assignments. One way or another, this check is at least incomplete, since just in if block before execution can go to out bypassing this check.

Thu, Feb 7, 9:43 PM
cem accepted D19109: CID 1009492: Logically dead code in sys/cam/scsi/scsi_xpt.c.
Thu, Feb 7, 7:17 PM
cem added a comment to D19105: CID 1008620: Logically dead code in newsyslog.c.

My guess is that the author intended for defconf input to parse_file() to be a *reference* rather than a bare pointer. If you look at parse_file(), you can see it initializes its copy of defconf_p when the special entry "<default>" is encountered in a file. However, that pointer is never stored anywhere and is leaked when parse_file() returns.

Thu, Feb 7, 7:15 PM
cem accepted D19109: CID 1009492: Logically dead code in sys/cam/scsi/scsi_xpt.c.

Two ideas (just spitballing) re: forward compatibility.

Thu, Feb 7, 6:54 PM

Wed, Feb 6

cem requested changes to D19090: Add AES-CCM encryption.
Wed, Feb 6, 10:01 PM
cem added a comment to D19090: Add AES-CCM encryption.

Thanks, mostly looks good! The feedback is a bit verbose but I try to go over crypto code with a fine-toothed comb. I'll try to get some time to look at the latest version of the previous change.

Wed, Feb 6, 10:01 PM

Tue, Feb 5

cem created D19089: FUSE: Respect userspace FS "do-not-cache" of path components.
Tue, Feb 5, 8:34 PM
cem created D19088: FUSE: Respect userspace FS "do-not-cache" of file attributes.
Tue, Feb 5, 8:30 PM
cem added a comment to D15567: amdtemp and amdsmn update for new devices.

I think this one can be closed, a version of this was committed in r340425

Tue, Feb 5, 8:19 PM
cem committed rS343762: extattr_list_vp: Narrow locked section somewhat.
extattr_list_vp: Narrow locked section somewhat
Tue, Feb 5, 4:47 AM
cem closed D19083: extattr_list_vp: Narrow locked section somewhat.
Tue, Feb 5, 4:47 AM
cem created D19083: extattr_list_vp: Narrow locked section somewhat.
Tue, Feb 5, 3:35 AM
cem committed rS343761: extattr_list_vp: Only take shared vnode lock.
extattr_list_vp: Only take shared vnode lock
Tue, Feb 5, 3:33 AM
cem closed D19082: extattr_list_vp: Only take shared vnode lock.
Tue, Feb 5, 3:33 AM
cem added a comment to D19082: extattr_list_vp: Only take shared vnode lock.
In D19082#408030, @mjg wrote:

Lock acquisition can be moved few lines later, after branching on data. Similarly, unlock can be done earlier.

Tue, Feb 5, 3:31 AM
cem created D19082: extattr_list_vp: Only take shared vnode lock.
Tue, Feb 5, 1:51 AM

Fri, Feb 1

cem committed rS343670: qlnxr(4), qlnxe(4): Unbreak gcc build.
qlnxr(4), qlnxe(4): Unbreak gcc build
Fri, Feb 1, 11:05 PM
cem added a comment to D18592: Add CBC-MAC authentication code.
In D18592#407487, @sef wrote:
In D18592#407486, @cem wrote:
In D18592#400076, @sef wrote:

NB: This is mostly tested simply by compilation, as I've still got some more feedback to incorporate.

Is this still the case or do you figure you've finished that? I was waiting for that to wrap up before I took another look.

It's not plumbed into the rest of OCF, since that was requested to be a different review.

Fri, Feb 1, 9:04 PM
cem added a comment to D18592: Add CBC-MAC authentication code.
In D18592#400076, @sef wrote:

NB: This is mostly tested simply by compilation, as I've still got some more feedback to incorporate.

Fri, Feb 1, 9:01 PM
cem added a comment to D18592: Add CBC-MAC authentication code.
In D18592#407465, @sef wrote:

Switch to using a single type macro.

Fri, Feb 1, 8:51 PM

Fri, Jan 25

cem added a comment to D16164: Make options IFLIB a real configuration option..

To elaborate a bit more, the stated commit log:

Fri, Jan 25, 7:28 PM
cem removed a reviewer for D18950: Remove references to pdwait4(2) and `CAP_PDWAIT` from rights(4): cem.
Fri, Jan 25, 12:29 AM

Wed, Jan 23

cem committed rS343347: gmirror: Relocate DEVICE_FLAGS to adjacent lines.
gmirror: Relocate DEVICE_FLAGS to adjacent lines
Wed, Jan 23, 4:44 PM

Jan 18 2019

cem committed rS343166: vmm(4): Mask Spectre feature bits on AMD hosts.
vmm(4): Mask Spectre feature bits on AMD hosts
Jan 18 2019, 11:55 PM

Jan 17 2019

cem committed rS343125: ioat(4): Set __result_use_check on ioat_acquire_reserve.
ioat(4): Set __result_use_check on ioat_acquire_reserve
Jan 17 2019, 11:21 PM
cem added a comment to D18880: Extend mmap(2) API to specify the max page protections..

I really like this, even if it isn't ready to land yet.

Jan 17 2019, 10:16 PM
cem committed rS343120: Add definitions for AMD Spectre/Meltdown CPUID information.
Add definitions for AMD Spectre/Meltdown CPUID information
Jan 17 2019, 7:45 PM

Jan 16 2019

cem committed rS343075: vmm(4): Take steps towards multicore bhyve AMD support.
vmm(4): Take steps towards multicore bhyve AMD support
Jan 16 2019, 2:19 AM
cem abandoned D18749: vmm(4): Partially unfuck multicore AMD support.
Jan 16 2019, 1:33 AM
cem changed the visibility for D18749: vmm(4): Partially unfuck multicore AMD support.
Jan 16 2019, 1:20 AM

Jan 12 2019

cem committed rS342977: amdtemp(4): Add support for Family 15h, Model >=60h.
amdtemp(4): Add support for Family 15h, Model >=60h
Jan 12 2019, 10:36 PM

Jan 10 2019

cem resigned from D18794: Introduce Build options for Secure Boot.
Jan 10 2019, 12:58 AM
cem resigned from D18799: Create binsign tool to sign binary files for Secure Boot.
Jan 10 2019, 12:58 AM

Jan 9 2019

cem added a comment to D18765: Add EINTEGRITY as new error number.

It is useful to the application or user to distinguish EINTEGRITY from EIO. With EIO they know that the underlying media has failed and there is really nothing they can do. With EINTEGRITY the individual file has become corrupted, but if they still have its contents, they can remove it and rewrite it as the filesystem media itself is still working. Alternatively they can request the system administrator to run a check of the filesystem to attempt to clean up the file.

Jan 9 2019, 11:59 PM
cem added a comment to D18765: Add EINTEGRITY as new error number.

Mount is just one of the places that can return EINTEGRITY. It can also come back when accessing a file or directory whose meta information fails a check-hash.

Jan 9 2019, 11:52 PM
cem created D18802: graphics/libheif: Clean up Makefile, add JPEG by default.
Jan 9 2019, 10:52 PM
cem added inline comments to D18765: Add EINTEGRITY as new error number.
Jan 9 2019, 8:48 PM

Jan 8 2019

cem abandoned D18566: net/rdesktop: Fix build with OpenSSL 1.1.0.
Jan 8 2019, 11:54 PM
cem added a comment to D18774: Add AMD NTB Hardware Driver for AMD SoC.

I didn't really look at this driver thoroughly and don't plan to, but just skimmed through and pointed out some possible improvements.

Jan 8 2019, 1:08 AM

Jan 7 2019

cem added a comment to D18765: Add EINTEGRITY as new error number.

(Lua lerrno.c change looks fine.)

Jan 7 2019, 9:03 PM
cem added a comment to D18765: Add EINTEGRITY as new error number.

Mirror might be able to read both sides but find that they have different values. So it would not know which one to return.

Jan 7 2019, 8:57 PM
cem committed rS342852: powerpc: Fix regression introduced in r342771.
powerpc: Fix regression introduced in r342771
Jan 7 2019, 7:39 PM
cem closed D18777: powerpc: Fix regression introduced in r342771.
Jan 7 2019, 7:39 PM
cem added a comment to D18777: powerpc: Fix regression introduced in r342771.

Thanks for the quick review and test!

Jan 7 2019, 7:34 PM
cem created D18777: powerpc: Fix regression introduced in r342771.
Jan 7 2019, 6:45 PM
cem added a comment to D18765: Add EINTEGRITY as new error number.

This proposal is to create a new EINTEGRITY error number. EINTEGRITY's purpose is to respond to errors where an integrity check such as a check-hash or a cross-correlation has failed. For example, an uncorrectable error has been found in a filesystem or a disk subsystem such as gmirror(8) or graid3(8).

Jan 7 2019, 5:07 AM

Jan 6 2019

cem committed rP489439: mail/fetchmail: backport less-old TLS support from Fedora.
mail/fetchmail: backport less-old TLS support from Fedora
Jan 6 2019, 7:21 AM

Jan 5 2019

cem updated the test plan for D18749: vmm(4): Partially unfuck multicore AMD support.
Jan 5 2019, 5:44 AM
cem retitled D18749: vmm(4): Partially unfuck multicore AMD support from vmm(4): Partially fix multicore AMD support to vmm(4): Partially unfuck multicore AMD support.
Jan 5 2019, 5:35 AM