- User Since
- Jul 9 2015, 9:56 PM (131 w, 6 d)
Tue, Jan 16
I'd like to see someone with make/build experience review this (Bryan?) but assuming they approve it, I approve it.
Rebase past smaller changes pulled out and committed already.
iid test on RAW and SEED:
noniid on RAW and SEED samples:
iid on conditioned output samples:
The noniid test has completed:
CCing (maybe :-)) interested parties for the random source portion of this driver.
The implementation is in the associated review. We read a 32 bit register (TRNG_OUT) and get a new value every time. Here's some documentation from the device manual on how those bits are created and treated:
Mon, Jan 15
Put trivial random changes in independent review for secteam: https://reviews.freebsd.org/D13925
I think the driver is more or less ready to go in now.
Accidentally posted two patches; remove accidentally added patch.
Hide debugging (and especially sensitive content printing) behind special
macros. DPRINTF is debug spam and can be enabled at runtime. INSECURE_DEBUG()
prints sensitive material and is compiled out by default.
No objection, although my blessing is meaningless in ports.
Sun, Jan 14
Thanks. Please re-upload with context. You can either use arc diff --create or simply generate a patch with huge amounts of context ([git] diff -U999999).
Sat, Jan 13
Committed MAXADDR 48bit separately.
Fri, Jan 12
Thu, Jan 11
Wed, Jan 10
Was this mechanical (with e.g. coccinelle)?
Patch applies cleanly to my ports tree. Builds ok.
Tue, Jan 9
Mon, Jan 8
We're missing savecore support, manual page additions, as well as inclusion in GENERIC, right?
LGTM, modulo disagreement about default-compress disable. Ok to commit — we can discuss later if and how default-compress would be implemented.
Sat, Jan 6
What's dual boot mean in this context? Thanks.
Fri, Jan 5
Please commit this :-).
Tue, Jan 2
Abort nice program shutdown on unexpected pipefd write(2) failure.
Move shutdown code to main loop and use signal-safe flag to induce shutdown.
Mon, Jan 1
Sun, Dec 31
Fri, Dec 29
Tue, Dec 26
Sat, Dec 23
Please go ahead and commit this, after fixing the easy issues brought up by Warner. :-)
Fri, Dec 22
I've only looked at this first half of this patch. Most of my comments aren't requests for any change, but clarifying questions for me, as someone not very familiar with gmirror. Gotta run, will look more later.
Thu, Dec 21
I don't understand the actual algorithmic change, but given the strong test coverage, I think I'm ok with this. Some style nits below.