- User Since
- Jul 9 2015, 9:56 PM (192 w, 6 d)
Looks good other than sys/conf/files
Tue, Mar 19
Ah thanks for the catch on attilio's actual @freebsd address
The moduledata changes, sysctl changes, jail changes, renaming the kld, etc, look good to me. And the backwards compat symlink is a nice touch as well. But please don't move the filesystem sources.
Please don't move the directory from sys/fs/fuse to sys/fs/fusefs. It just adds needless churn to the history.
Thanks for doing this. We've needed a page for a while. Have you run it past the igor tool?
Sat, Mar 16
Fri, Mar 15
Thu, Mar 14
Tue, Mar 12
Mon, Mar 11
I did not look too closely at the caching bits. The rest looks mostly good. Some feedback below.
Looks good to me. Thank you!
Thanks for doing this, I really appreciate it!
Fri, Mar 8
The build system mechanics look good to me. I haven't looked at the Perl script, and frankly, I find Perl pretty inscrutable and may not be best at spotting bugs in it.
Thu, Mar 7
Put non-negative logical case first, for clarity. Thanks delphij@
Need secteam blessing to touch dev/random. Thanks!
Wed, Mar 6
Fix a 'doh!' copy/paste error on archs without a uint128 type.
Fri, Mar 1
So probably we're mishandling a request for an argument value beyond the end of the valid parameters list.
Need secteam/so/core blessing.
I guess I need blessing from secteam, so@, or core to touch dev/random. Can one of y'all quickly bless this non-functional change?
Use C99 initializers in a few more dispatch tables and clarify wording of ctfdump CONSTVAL type output
Thu, Feb 28
Wed, Feb 27
Seems unobjectionable to me. Ok by you, John?
Mon, Feb 25
Sun, Feb 24
- Pull out !hasconst case and de-indent
- Use designated initializers in a few more places
Sat, Feb 23
Thanks for taking a look!
Fri, Feb 22
Thu, Feb 21
To summarize: LGTM
Thanks! I really appreciate additional eyes/interest and improvement for this driver.
Wed, Feb 20
Prior to this change, ctfdump shows  FUNC (kern_chflagsat) returns: 1 args: (1173, 1, 5, 142, 91, 1); ... <142> ENUM uio_seg (i.e., no idea it's been const-ed out of the ABI).