Page MenuHomeFreeBSD

cem (Conrad Meyer)
User

Projects

User Details

User Since
Jul 9 2015, 9:56 PM (227 w, 5 d)

Recent Activity

Today

cem added inline comments to D22455: random/ivy: Provide mechanism to read independent seed values from rdrand.
Wed, Nov 20, 2:48 AM
cem added a reviewer for D22454: random/ivy: Trivial refactoring: csprng.
Wed, Nov 20, 2:41 AM
cem added a reviewer for D22455: random/ivy: Provide mechanism to read independent seed values from rdrand: csprng.
Wed, Nov 20, 2:41 AM
cem created D22455: random/ivy: Provide mechanism to read independent seed values from rdrand.
Wed, Nov 20, 2:40 AM
cem created D22454: random/ivy: Trivial refactoring.
Wed, Nov 20, 2:39 AM

Yesterday

cem committed rS354847: unifdef(1): Improve worst-case bound on symbol resolution.
unifdef(1): Improve worst-case bound on symbol resolution
Tue, Nov 19, 4:30 AM
cem committed rS354843: unifdef(1): Kill totally useless header.
unifdef(1): Kill totally useless header
Tue, Nov 19, 3:15 AM

Mon, Nov 18

cem committed rS354801: Link in NetBSD's unifdef(1) tests.
Link in NetBSD's unifdef(1) tests
Mon, Nov 18, 4:03 AM

Sat, Nov 16

cem committed rS354777: Update to Zstandard 1.4.4.
Update to Zstandard 1.4.4
Sat, Nov 16, 4:39 PM

Fri, Nov 15

cem added a comment to D22363: Increase number of algorithms that can be initialized in cryptosoft.

It seems like ESNs are just AAD in integrity modes and maybe sometimes plaintext or sometimes AAD in other ipsec modes. I’m not sure why they’d be considered an algorithm? I think this will be easier to express in the rework branch so I’m glad to hear John plans to circulate it soon.

Fri, Nov 15, 7:09 PM
cem added a comment to D22363: Increase number of algorithms that can be initialized in cryptosoft.
In D22363#489261, @mw wrote:

Hi @jhb - so this patch will not apply onto your solution, right? When do you expect to push it?
Do you have some open repo to see and try it?

Fri, Nov 15, 3:14 AM

Thu, Nov 14

cem added reviewers for D22362: Add CRYPTO_ESN, CRD_F_ESN flags and appropriate fields in cryptodev: cem, jhb.
Thu, Nov 14, 3:32 PM
cem added a comment to D22362: Add CRYPTO_ESN, CRD_F_ESN flags and appropriate fields in cryptodev.

Can you provide more background of ESNs and motivation for including them as an ocf transformation? Thanks!

Thu, Nov 14, 3:31 PM
cem updated subscribers of D22363: Increase number of algorithms that can be initialized in cryptosoft.

The majority of ocf drivers aren’t ready for this. Can you give me some context on what ESNs are and why they ought to be part of doing an OCF transform? Have you considered integrating these in @jhb’s OCF rework branch?

Thu, Nov 14, 2:24 PM

Wed, Nov 13

cem added a comment to D22319: Avoid double bus_dmamap_load() in ioat(4)..

(The changes look good to me, aside from the question.)

Wed, Nov 13, 6:29 PM
cem added inline comments to D22319: Avoid double bus_dmamap_load() in ioat(4)..
Wed, Nov 13, 6:28 PM

Tue, Nov 12

cem accepted D22253: nvdimm(4): Fix various problems when the using the second label index block.
Tue, Nov 12, 1:52 AM
cem accepted D21987: nvdimm(4): Only expose namespaces for accessible data SPAs.
Tue, Nov 12, 1:30 AM

Mon, Nov 11

cem added a comment to D22311: Fix netstat -gs with ip_mroute module and/or vnet.

So this fixes a single live && MROUTING && VIMAGE case, but leaves the !live && MROUTING && VIMAGE case broken, with the same misleading print, as well as any other !live && VIMAGE code. It seems like a better solution might be teaching it about VIMAGE.

Mon, Nov 11, 5:58 AM
cem accepted D22253: nvdimm(4): Fix various problems when the using the second label index block.

Change looks functionally correct to me, my suggestions are all stylistic.

Mon, Nov 11, 4:52 AM
cem added inline comments to D22253: nvdimm(4): Fix various problems when the using the second label index block.
Mon, Nov 11, 4:49 AM

Sat, Nov 9

cem created P335 chrome crap.
Sat, Nov 9, 2:54 AM

Thu, Nov 7

cem accepted D22271: Create /etc/os-release file..
Thu, Nov 7, 9:34 PM
cem accepted D22271: Create /etc/os-release file..

Any reason to avoid generating to a temporary file first (possibly in tmpfs) and installing with install -C (i.e., don't re-write or bump mtime if the contents did not change)? Slightly more friendly to low-endurance media /var devices.

Thu, Nov 7, 6:54 PM
cem accepted D22272: Build tests-dbg.txz distfile.

With the caveat that I am unfamiliar with this part of the build, looks reasonable to me. (And I am supportive of the objective.)

Thu, Nov 7, 3:57 PM

Wed, Nov 6

cem committed rS354418: clang: Enable unwind tables on !amd64.
clang: Enable unwind tables on !amd64
Wed, Nov 6, 11:44 PM
cem closed D22252: clang: Enable unwind tables on !amd64.
Wed, Nov 6, 11:44 PM
cem added a comment to D22252: clang: Enable unwind tables on !amd64.

Maybe not, here's where the GNU one was removed: https://github.com/llvm/llvm-project/commit/e8bd4e50e4a30e1a046b4f6a8768dce8569a982f There's a comment in CrossWindows.cpp that "LLVM currently does not know how to emit" non-x86 unwind tables still.

Wed, Nov 6, 7:12 PM
cem added a comment to D22252: clang: Enable unwind tables on !amd64.

Also how does this interact with (32-bit) arm which uses its own unwind format?

Wed, Nov 6, 7:04 PM
cem added a comment to D22252: clang: Enable unwind tables on !amd64.

I am not sure if we should instead default to off everywhere though, and enable it via cmdline flags.

Wed, Nov 6, 6:30 PM
cem added a comment to D22259: blacklist: update to NetBSD snapshot on 20191106.

Carrying around an openssh patch is far from ideal. Is there any chance it can be upstreamed?

Wed, Nov 6, 3:54 PM
cem added a comment to D22252: clang: Enable unwind tables on !amd64.

FWIW, tinderbox is clean.

Wed, Nov 6, 7:07 AM
cem added a reviewer for D22253: nvdimm(4): Fix various problems when the using the second label index block: kib.

Some initial tentative feedback and CCing kib@. Caveat, I haven't yet consulted any official documentation nor have I looked at the adjacent code to understand what it is doing, so my comments may just be uninformed. But, provisionally, I don't understand the motivation for some of this changeset.

Wed, Nov 6, 7:07 AM
cem committed rS354373: zstd: Add an Xlist and document use during import.
zstd: Add an Xlist and document use during import
Wed, Nov 6, 6:50 AM
cem committed rS354372: Tag Zstd 1.4.4.
Tag Zstd 1.4.4
Wed, Nov 6, 6:43 AM
cem committed rS354371: Import Zstd 1.4.4.
Import Zstd 1.4.4
Wed, Nov 6, 6:42 AM
cem created D22252: clang: Enable unwind tables on !amd64.
Wed, Nov 6, 12:47 AM

Tue, Nov 5

cem committed rS354348: armv6, armv7: Switch to llvm-libunwind by default.
armv6, armv7: Switch to llvm-libunwind by default
Tue, Nov 5, 3:22 AM
cem committed rS354347: Fix llvm-libunwind userspace build on ARM.
Fix llvm-libunwind userspace build on ARM
Tue, Nov 5, 3:20 AM

Sun, Nov 3

cem committed rS354290: Take arm.arm (armv5) out of universe.
Take arm.arm (armv5) out of universe
Sun, Nov 3, 7:36 PM
cem committed rS354289: armv6: Switch to LLD by default.
armv6: Switch to LLD by default
Sun, Nov 3, 7:34 PM

Fri, Nov 1

cem added inline comments to D22212: truss: centralize pointer-constructing casts..
Fri, Nov 1, 8:30 PM
cem added a comment to D22212: truss: centralize pointer-constructing casts..

Is "not terrible" the bar now?

Fri, Nov 1, 4:08 PM
cem added a comment to D22212: truss: centralize pointer-constructing casts..

This is a weird and not obviously better change for FreeBSD. I assume it makes sense for some particular reason on CHERI, but CHERI isn't even a Tier 4 FreeBSD arch. Most of the changes are just obfuscating formatted prints rather than any actual change to casts.

Fri, Nov 1, 5:30 AM

Wed, Oct 30

cem committed rS354167: amd64: Fix typo: RDPRU bit is 0x10, not 0x04.
amd64: Fix typo: RDPRU bit is 0x10, not 0x04
Wed, Oct 30, 4:01 AM
cem committed rS354162: amd64: Define and decode new AMD64 feature bits.
amd64: Define and decode new AMD64 feature bits
Wed, Oct 30, 1:41 AM

Tue, Oct 29

cem accepted D18028: Add support for Intel Speed Shift.

Looks good to me, thanks!

Tue, Oct 29, 11:38 PM
cem added a comment to D18028: Add support for Intel Speed Shift.

ah sorry, here's the same patch, but with context restored.

Tue, Oct 29, 11:29 PM
cem committed rS354151: libexecinfo test: Don't strip installed test.
libexecinfo test: Don't strip installed test
Tue, Oct 29, 6:24 PM
cem added inline comments to D21324: Add stats(3) support to nc(1).
Tue, Oct 29, 5:49 PM
cem added a comment to D22173: Install test binaries not stripped.

Perhaps we can add STRIP= to this this case first and then discuss the global setting.

Tue, Oct 29, 5:47 PM
cem added a comment to D22173: Install test binaries not stripped.

I’m not sure it’s a good idea to default no-strip all tests. It likely fixes my test in particular, but my test could add STRIP= in isolation.

Tue, Oct 29, 4:46 PM
cem added a comment to D18028: Add support for Intel Speed Shift.

The new patch doesn't have context, so phabricator doesn't know how to show inter-diff and us casual readers cannot expand adjacent code in the web interface. Would you mind uploading a diff with full context (i.e., diff -U99999 ... or using the arc utility)? Thanks!

Tue, Oct 29, 2:01 AM

Mon, Oct 28

cem committed rS354135: Remove bogus requirement from libexecinfo test.
Remove bogus requirement from libexecinfo test
Mon, Oct 28, 5:13 PM

Sun, Oct 27

cem committed rS354126: libexecinfo: Integrate NetBSD test into FreeBSD.
libexecinfo: Integrate NetBSD test into FreeBSD
Sun, Oct 27, 5:32 AM

Sat, Oct 26

cem committed rS354112: Sync up with NetBSD libexecinfo changes 2014-2019.
Sync up with NetBSD libexecinfo changes 2014-2019
Sat, Oct 26, 7:00 AM

Thu, Oct 24

cem accepted D21324: Add stats(3) support to nc(1).

I didn't look too closely but this look a lot better, thanks. One question below.

Thu, Oct 24, 4:57 PM
cem added a comment to D18028: Add support for Intel Speed Shift.

Thanks, this is kinda weird but I like it better than before.

Thu, Oct 24, 12:19 AM

Wed, Oct 23

cem committed rS353959: amd64: Add CFI directives for libc syscall stubs.
amd64: Add CFI directives for libc syscall stubs
Wed, Oct 23, 7:03 PM
cem closed D22122: amd64: Add CFI directives for libc syscall stubs.
Wed, Oct 23, 7:03 PM
cem committed rS353958: libthr: Add missing END() directive for umtx_op_err (amd64).
libthr: Add missing END() directive for umtx_op_err (amd64)
Wed, Oct 23, 6:27 PM
cem committed rS353934: Prevent a panic when a driver provides bogus debugnet parameters.
Prevent a panic when a driver provides bogus debugnet parameters
Wed, Oct 23, 4:48 PM
cem committed rS353929: libm: Add missing END() directives for amd64 routines.
libm: Add missing END() directives for amd64 routines
Wed, Oct 23, 4:06 PM
cem added inline comments to D22122: amd64: Add CFI directives for libc syscall stubs.
Wed, Oct 23, 3:28 PM
cem added a comment to D22122: amd64: Add CFI directives for libc syscall stubs.
Wed, Oct 23, 3:21 PM
cem added a comment to D22122: amd64: Add CFI directives for libc syscall stubs.

I think you could go ahead and commit the END() additions independently in any case?

Wed, Oct 23, 3:11 PM
cem updated the diff for D22122: amd64: Add CFI directives for libc syscall stubs.

Fix a number of ENTRY()s without matched END()s.

Wed, Oct 23, 3:17 AM
cem created D22122: amd64: Add CFI directives for libc syscall stubs.
Wed, Oct 23, 1:04 AM

Mon, Oct 21

cem edited P330 siginfo stacks.
Mon, Oct 21, 4:25 AM
cem created P330 siginfo stacks.
Mon, Oct 21, 4:16 AM

Oct 19 2019

cem accepted D22089: Fix compilation of kernel without VNET support.

Looks good to me, thanks.

Oct 19 2019, 8:41 PM
cem added inline comments to D22089: Fix compilation of kernel without VNET support.
Oct 19 2019, 7:51 PM
cem added inline comments to D22089: Fix compilation of kernel without VNET support.
Oct 19 2019, 7:11 PM
cem added inline comments to D22089: Fix compilation of kernel without VNET support.
Oct 19 2019, 6:03 PM
cem committed rS353767: hw.intrbalance: Make sysctl tunable.
hw.intrbalance: Make sysctl tunable
Oct 19 2019, 4:38 PM

Oct 18 2019

cem committed rS353742: Fix debugnet(4) link/build fallout on some configurations.
Fix debugnet(4) link/build fallout on some configurations
Oct 18 2019, 10:03 PM
cem committed rS353740: nvdimm(4): Persist unit numbers in cdev.
nvdimm(4): Persist unit numbers in cdev
Oct 18 2019, 9:33 PM
cem committed rS353714: nvdimm_e820: Fix braino in size=all SPA hint.
nvdimm_e820: Fix braino in size=all SPA hint
Oct 18 2019, 3:01 AM
cem committed rS353713: x86: Remove unused variable from r353712.
x86: Remove unused variable from r353712
Oct 18 2019, 2:25 AM
cem committed rS353712: x86: Fetch and save standard CPUID leaf 6 in identcpu.
x86: Fetch and save standard CPUID leaf 6 in identcpu
Oct 18 2019, 2:18 AM
cem requested changes to D18028: Add support for Intel Speed Shift.

Scott, thanks for picking this up! I'm really glad to see this being driven towards commit. I also really appreciate the cf_dev -> dev revert; keeping name changes divorced from functional changes reduces the size of the patch and increases clarity of what has changed.

Oct 18 2019, 12:07 AM

Oct 17 2019

cem closed D21761: gdb(4): Implement support for NoAckMode.
Oct 17 2019, 10:37 PM
cem committed rS353702: gdb(4): Implement support for NoAckMode.
gdb(4): Implement support for NoAckMode
Oct 17 2019, 10:37 PM
cem closed D21568: Implement NetGDB(4).
Oct 17 2019, 9:33 PM
cem committed rS353700: Implement NetGDB(4).
Implement NetGDB(4)
Oct 17 2019, 9:33 PM
cem committed rS353696: debugnet(4): Add optional full-duplex mode.
debugnet(4): Add optional full-duplex mode
Oct 17 2019, 8:25 PM
cem closed D21541: debugnet(4): Add optional full-duplex mode.
Oct 17 2019, 8:25 PM
cem committed rS353694: debugnet(4): Infer non-server connection parameters.
debugnet(4): Infer non-server connection parameters
Oct 17 2019, 8:10 PM
cem closed D21482: debugnet(4): Infer non-server connection parameters.
Oct 17 2019, 8:10 PM
cem committed rS353693: acpica: Fix for the fix, unfortunately.
acpica: Fix for the fix, unfortunately
Oct 17 2019, 7:54 PM
cem committed rS353692: Add ddb(4) 'netdump' command to netdump a core without preconfiguration.
Add ddb(4) 'netdump' command to netdump a core without preconfiguration
Oct 17 2019, 7:49 PM
cem closed D21460: Add ddb(4) 'netdump' command to netdump a core without preconfiguration.
Oct 17 2019, 7:49 PM
cem committed rS353691: acpica: Match ID_PROBE default implementation to interface.
acpica: Match ID_PROBE default implementation to interface
Oct 17 2019, 6:45 PM
cem abandoned D21421: Split out a more generic debugnet(4) from netdump(4).

(Committed, link/revision above.)

Oct 17 2019, 6:35 PM
cem added a comment to D21421: Split out a more generic debugnet(4) from netdump(4).

For some reason Phabricator is not auto-closing some reviews.

Oct 17 2019, 6:33 PM
cem committed rS353690: Add a very limited DDB dumpon(8)-alike to MI dumper code.
Add a very limited DDB dumpon(8)-alike to MI dumper code
Oct 17 2019, 6:29 PM
cem closed D21448: Add a very limited DDB dumpon(8)-alike to MI dumper code.
Oct 17 2019, 6:29 PM
cem committed rS353689: debugnet: Respond to broadcast ARP requests.
debugnet: Respond to broadcast ARP requests
Oct 17 2019, 5:48 PM
cem added a comment to D21421: Split out a more generic debugnet(4) from netdump(4).

Committed in r353685, I'm not sure why Phabricator has not closed this yet.

Oct 17 2019, 5:33 PM
cem committed rS353688: debugnet(4): Check hardware-validated UDP checksums.
debugnet(4): Check hardware-validated UDP checksums
Oct 17 2019, 5:19 PM