fstyp: Remove __packed from struct exfat_de_label.
ClosedPublic
Actions

Authored by jhb on Sep 25 2021, 6:29 PM.

Details

Reviewers

cem
pstef

Commits

rGecd5ade6dcf7: fstyp: Remove __packed from struct exfat_de_label.
rG58862c0bea66: fstyp: Remove __packed from struct exfat_de_label.

Summary

This fixes a -Waddress-of-packed-member warning about a possibly
unaligned pointer from GCC 9 when calling convert_label().

__packed has to be removed from struct exfat_dirent as well to fix an
alignment warning when casting from a struct exfat_dirent pointer to a
struct exfat_de_label pointer.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 25 2021, 6:29 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 25 2021, 6:29 PM

jhb requested review of this revision.Sep 25 2021, 6:29 PM

Harbormaster completed remote builds in B41763: Diff 95733.Sep 25 2021, 6:29 PM

Address of packed member? How?

Nothing functionally wrong with the change but I don’t understand the warning here.

usr.sbin/fstyp/exfat.c
224–225	Comment is now stale

This revision is now accepted and ready to land.Sep 25 2021, 6:33 PM

jhb added inline comments.Sep 27 2021, 5:51 PM

usr.sbin/fstyp/exfat.c
309	The warning is triggered here as the type of the `lde` structure is packed.

cem added inline comments.Sep 27 2021, 6:32 PM

usr.sbin/fstyp/exfat.c
309	Oh. That structure could also just have packed removed.

First of all, sorry about this - I believe I caused this issue by bumping WARNS to default without first testing the change with gcc. I have now installed gcc9 in order to test future changes like this, in the hope that I can avoid making mess like this.

As for the issue at hand, this change looks good to me, but if you want my opinion, I'm in favor of removing the packed attribute from the struct.

Remove __packed instead.

This revision now requires review to proceed.Feb 1 2022, 12:57 AM

Harbormaster completed remote builds in B44206: Diff 102188.Feb 1 2022, 12:57 AM

jhb retitled this revision from fstyp: Use a void pointer for the ucs2label argument to convert_label. to fstyp: Remove __packed from struct exfat_de_label..Feb 1 2022, 1:06 AM

jhb edited the summary of this revision. (Show Details)

cem accepted this revision.Feb 1 2022, 1:12 AM

This revision is now accepted and ready to land.Feb 1 2022, 1:12 AM

Closed by commit rG58862c0bea66: fstyp: Remove __packed from struct exfat_de_label. (authored by jhb). · Explain WhyFeb 1 2022, 1:34 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG58862c0bea66: fstyp: Remove __packed from struct exfat_de_label..

jhb added a commit: rGecd5ade6dcf7: fstyp: Remove __packed from struct exfat_de_label..May 11 2022, 12:30 AM