Page MenuHomeFreeBSD

jhb (John Baldwin)
User

Projects (10)

User Details

User Since
Mar 11 2014, 8:46 PM (638 w, 5 h)

Recent Activity

Thu, May 28

jhb accepted D57270: ctld: More consistent error messages.
Thu, May 28, 4:46 PM
jhb added inline comments to D57283: ctld: Simplify handling of non-iSCSI and non-NVMe kernel ports.
Thu, May 28, 4:41 PM
jhb added inline comments to D57270: ctld: More consistent error messages.
Thu, May 28, 4:40 PM

Wed, May 27

jhb committed rG887841731be6: ctl: Use CAM_PRIORITY_NORMAL for queued CCBs (authored by jhb).
ctl: Use CAM_PRIORITY_NORMAL for queued CCBs
Wed, May 27, 9:01 PM
jhb committed rGd1a8fa2e0f41: ctld: Only check physical port linking in a single configuration context (authored by jhb).
ctld: Only check physical port linking in a single configuration context
Wed, May 27, 9:01 PM
jhb committed rGcaef3c50ac06: ctld: Refactor ioctl port handling (authored by jhb).
ctld: Refactor ioctl port handling
Wed, May 27, 9:01 PM
jhb committed rG7a436d378951: ctld: Don't ignore pp/vp values of kernel ports with pp == 0 but vp != 0 (authored by jhb).
ctld: Don't ignore pp/vp values of kernel ports with pp == 0 but vp != 0
Wed, May 27, 9:01 PM
jhb closed D56995: ctl: Use CAM_PRIORITY_NORMAL for queued CCBs.
Wed, May 27, 9:01 PM
jhb closed D57093: ctld: Only check physical port linking in a single configuration context.
Wed, May 27, 9:00 PM
jhb closed D57092: ctld: Refactor ioctl port handling.
Wed, May 27, 9:00 PM
jhb added a comment to D57093: ctld: Only check physical port linking in a single configuration context.

I was able to effectively test this today using pre-existing ioctl ports.

Wed, May 27, 8:54 PM
jhb retitled D57093: ctld: Only check physical port linking in a single configuration context from ctld: Only check physical port linking within a single configuration context to ctld: Only check physical port linking in a single configuration context.
Wed, May 27, 8:53 PM
jhb added a comment to D57092: ctld: Refactor ioctl port handling.

I was able to test this directly today playing around with ioctl ports.

Wed, May 27, 8:53 PM
jhb updated the summary of D57092: ctld: Refactor ioctl port handling.
Wed, May 27, 8:52 PM
jhb updated the diff for D57092: ctld: Refactor ioctl port handling.

Permit using ioctl/0/0

Wed, May 27, 8:51 PM
jhb requested review of D57283: ctld: Simplify handling of non-iSCSI and non-NVMe kernel ports.
Wed, May 27, 8:50 PM
jhb committed rG4f876cec30af: riscv64: Move pcb out of kstack into a new UMA zone (authored by jhb).
riscv64: Move pcb out of kstack into a new UMA zone
Wed, May 27, 3:00 PM
jhb committed rGd0b10df718e3: arm64: Move pcb out of kstack into a new UMA zone (authored by jhb).
arm64: Move pcb out of kstack into a new UMA zone
Wed, May 27, 3:00 PM
jhb committed rGdcae0f7d7aa6: sys: Consistently use ptoa() with td_kstack_pages (authored by jhb).
sys: Consistently use ptoa() with td_kstack_pages
Wed, May 27, 3:00 PM
jhb committed rG8b9023cfc185: sys: Add td_kstack_top inline helper function (authored by jhb).
sys: Add td_kstack_top inline helper function
Wed, May 27, 3:00 PM
jhb committed rGfce595344c51: arm64 locore: Fix a comment typo: Of -> If (authored by jhb).
arm64 locore: Fix a comment typo: Of -> If
Wed, May 27, 3:00 PM
jhb committed rGf7524d8fcbd7: amd64: Inline set_top_of_stack_td into cpu_thread_new_kstack (authored by jhb).
amd64: Inline set_top_of_stack_td into cpu_thread_new_kstack
Wed, May 27, 3:00 PM
jhb committed rGa1e07f21dc74: arm64: Adjust the kernel stack pointer at the end of fork_trampoline (authored by alfredo.mazzinghi_cl.cam.ac.uk).
arm64: Adjust the kernel stack pointer at the end of fork_trampoline
Wed, May 27, 3:00 PM
jhb committed rG2893bb741b4b: cpu_thread_new_kstack: Introduce new MD callback (authored by jhb).
cpu_thread_new_kstack: Introduce new MD callback
Wed, May 27, 3:00 PM
jhb committed rG59d67f2868b1: amd64/i386: Remove dead code to clear XSAVE header (authored by jhb).
amd64/i386: Remove dead code to clear XSAVE header
Wed, May 27, 3:00 PM
jhb committed rG187b46e1c4d7: cpu_fork: Remove redundant assignments to td_pcb and td_frame (authored by jhb).
cpu_fork: Remove redundant assignments to td_pcb and td_frame
Wed, May 27, 3:00 PM
jhb committed rG860aaecf1bb6: amd64: Don't set an initial FPU state save size (authored by jhb).
amd64: Don't set an initial FPU state save size
Wed, May 27, 3:00 PM
jhb committed rGd01e5afbbf9b: arm64: Remove unneeded declaration from <machine/pcpu.h> (authored by jhb).
arm64: Remove unneeded declaration from <machine/pcpu.h>
Wed, May 27, 2:59 PM

Tue, May 26

jhb committed rG00b96a777845: amd64: Drop segment descriptor details from trap messsages (authored by jhb).
amd64: Drop segment descriptor details from trap messsages
Tue, May 26, 5:28 PM
jhb closed D56989: amd64: Drop segment descriptor details from trap messsages.
Tue, May 26, 5:28 PM
jhb updated the diff for D56989: amd64: Drop segment descriptor details from trap messsages.

Add p_comm

Tue, May 26, 4:06 PM
jhb committed rG9823698a48d3: RELNOTES: Add entries for various commits through early March 2026 (authored by jhb).
RELNOTES: Add entries for various commits through early March 2026
Tue, May 26, 3:53 PM
jhb closed D56485: RELNOTES: Add entries for various commits through early March 2026.
Tue, May 26, 3:52 PM

Wed, May 20

jhb requested review of D57139: ppp: Reject FSM messages whose length is smaller than the message header.
Wed, May 20, 7:54 PM
jhb requested review of D57138: ppp: Permit CHAP challenges up to 255 bytes.
Wed, May 20, 7:31 PM
jhb requested review of D57137: ppp: Don't fetch a non-existent variadic argument.
Wed, May 20, 7:31 PM
jhb added a comment to D57136: cd9660: Add various length checks when parsing RRIP extensions.

While the previous patch in this stack fixes a reproducer from Robert, this followup patch is intended as additional robustness. With both of these I was able to still mount a FreeBSD install CD and all of the attributes reported by find /mnt -ls were the same before and after the patches.

Wed, May 20, 7:15 PM
jhb requested review of D57136: cd9660: Add various length checks when parsing RRIP extensions.
Wed, May 20, 7:09 PM
jhb requested review of D57135: cd9660: Don't parse RRIP records whose length overflows the sector boundary.
Wed, May 20, 7:09 PM

Tue, May 19

jhb committed rGd84a691a3590: powerpc: Remove stale include line from MPC85XX (authored by jhb).
powerpc: Remove stale include line from MPC85XX
Tue, May 19, 7:57 PM
jhb committed rG8de34a84224b: arm64/iommu: Add a missing close parenthesis (authored by jhb).
arm64/iommu: Add a missing close parenthesis
Tue, May 19, 5:32 PM
jhb committed rG8c9dc47b5fca: vnic: Add missing #include (authored by jhb).
vnic: Add missing #include
Tue, May 19, 5:19 PM
jhb requested review of D57093: ctld: Only check physical port linking in a single configuration context.
Tue, May 19, 3:14 PM
jhb requested review of D57092: ctld: Refactor ioctl port handling.
Tue, May 19, 3:14 PM

Mon, May 18

jhb committed rG63d7b7fad2dd: ctld: Mark a few more isns_* methods in the conf class private (authored by jhb).
ctld: Mark a few more isns_* methods in the conf class private
Mon, May 18, 7:52 PM
jhb committed rGf1c5de5fab9d: ctld: Add a dedicated conf method for shutting down (authored by jhb).
ctld: Add a dedicated conf method for shutting down
Mon, May 18, 7:52 PM
jhb committed rG9306d0449ba6: ctld: Simplify pidfile rename handling in conf::apply (authored by jhb).
ctld: Simplify pidfile rename handling in conf::apply
Mon, May 18, 7:52 PM
jhb committed rG4f90de093321: ctld: Remove redundant call to conf::isns_schedule_update (authored by jhb).
ctld: Remove redundant call to conf::isns_schedule_update
Mon, May 18, 7:51 PM
jhb closed D56533: ctld: Simplify pidfile rename handling in conf::apply.
Mon, May 18, 7:51 PM
jhb closed D56531: ctld: Mark a few more isns_* methods in the conf class private.
Mon, May 18, 7:51 PM
jhb closed D56532: ctld: Add a dedicated conf method for shutting down.
Mon, May 18, 7:51 PM
jhb closed D56530: ctld: Remove redundant call to conf::isns_schedule_update.
Mon, May 18, 7:51 PM
jhb committed rGbe4f245e1e4f: sys: Use is_pci_device instead of checking device or devclass names (authored by jhb).
sys: Use is_pci_device instead of checking device or devclass names
Mon, May 18, 6:54 PM
jhb committed rG6dc813301a17: sys: Use is_pci_device instead of direct comparisons to devclasses (authored by jhb).
sys: Use is_pci_device instead of direct comparisons to devclasses
Mon, May 18, 6:54 PM
jhb committed rGffcf5e356644: pci: Add is_pci_device helper function (authored by jhb).
pci: Add is_pci_device helper function
Mon, May 18, 6:54 PM
jhb committed rG6a043d0814a2: LinuxKPI: Check the devclass of the parent device in dev_is_pci (authored by jhb).
LinuxKPI: Check the devclass of the parent device in dev_is_pci
Mon, May 18, 6:54 PM
jhb closed D56998: sys: Use is_pci_device instead of checking device or devclass names.
Mon, May 18, 6:53 PM
jhb closed D56997: sys: Use is_pci_device instead of direct comparisons to devclasses.
Mon, May 18, 6:53 PM
jhb closed D56996: pci: Add is_pci_device helper function.
Mon, May 18, 6:53 PM
jhb closed D57066: LinuxKPI: Check the devclass of the parent device in dev_is_pci.
Mon, May 18, 6:53 PM
jhb added a comment to D56996: pci: Add is_pci_device helper function.
In D56996#1305937, @bz wrote:

I was contemplating the name but I couldn't come up with anything nice that started with pci_ ..

Mon, May 18, 6:44 PM
jhb added a comment to D57066: LinuxKPI: Check the devclass of the parent device in dev_is_pci.
In D57066#1307689, @bz wrote:

We assume that parent it is not a drmn device. Given I added this, it was for mt76 back then likely, so this was clearly a bug.

Mon, May 18, 6:43 PM
jhb updated the diff for D56997: sys: Use is_pci_device instead of direct comparisons to devclasses.

Rebase on top of LinuxKPI fixup

Mon, May 18, 3:23 PM
jhb requested review of D57066: LinuxKPI: Check the devclass of the parent device in dev_is_pci.
Mon, May 18, 3:22 PM
jhb updated the diff for D56989: amd64: Drop segment descriptor details from trap messsages.

Restore seg reg values

Mon, May 18, 2:50 PM
jhb retitled D56989: amd64: Drop segment descriptor details from trap messsages from amd64: Drop segment details from trap messsages to amd64: Drop segment descriptor details from trap messsages.
Mon, May 18, 2:50 PM

Thu, May 14

jhb updated the diff for D56485: RELNOTES: Add entries for various commits through early March 2026.

A few fixes

Thu, May 14, 9:09 PM
jhb added inline comments to D56485: RELNOTES: Add entries for various commits through early March 2026.
Thu, May 14, 9:06 PM
jhb added a comment to D56989: amd64: Drop segment descriptor details from trap messsages.
In D56989#1305907, @kib wrote:

For me, the segment registers values from the trap frame appeared to be very useful and sometimes even instrumental, e.g. during the recent FRED work. If the kernel idea of the trap frame address is misaligned with the location where the hardware put it, segment values are canaries that allow to see that immediately. Also, bugs with segments handling in doreti or fred_gouser are relatively obvious then. I am asking to keep that in the frame dump.

Thu, May 14, 1:19 PM
jhb added inline comments to D56997: sys: Use is_pci_device instead of direct comparisons to devclasses.
Thu, May 14, 1:18 PM
jhb added a reviewer for D56997: sys: Use is_pci_device instead of direct comparisons to devclasses: kib.
Thu, May 14, 1:16 PM
jhb added inline comments to D56997: sys: Use is_pci_device instead of direct comparisons to devclasses.
Thu, May 14, 1:16 PM

Wed, May 13

jhb requested review of D56998: sys: Use is_pci_device instead of checking device or devclass names.
Wed, May 13, 8:27 PM
jhb requested review of D56997: sys: Use is_pci_device instead of direct comparisons to devclasses.
Wed, May 13, 8:27 PM
jhb requested review of D56996: pci: Add is_pci_device helper function.
Wed, May 13, 8:27 PM
jhb added a comment to D56994: nvme: Fix broken ahci attachment.

In terms of accessors in general: I recently added a new "has" wrapper method to __BUS_ACCESSOR, but it only works if your IVAR is using a "global" number and not the private range. All of the PCI IVARs are in the private range.

Wed, May 13, 8:13 PM · drivers
jhb added inline comments to D56994: nvme: Fix broken ahci attachment.
Wed, May 13, 7:31 PM · drivers
jhb requested review of D56995: ctl: Use CAM_PRIORITY_NORMAL for queued CCBs.
Wed, May 13, 7:15 PM
jhb committed rG52fa2f9f8d57: clock_gettime.2: Fix a couple of typos (authored by jhb).
clock_gettime.2: Fix a couple of typos
Wed, May 13, 6:12 PM
jhb closed D56990: clock_gettime.2: Fix a couple of typos.
Wed, May 13, 6:12 PM
jhb committed rG04987aa1d809: arm64/vmm: Enforce a data barrier before tlbi for non-VHE (authored by jhb).
arm64/vmm: Enforce a data barrier before tlbi for non-VHE
Wed, May 13, 4:34 PM
jhb committed rG8766e2122ac0: mandoc: Updating FreeBSD thead library descriptions (authored by jhb).
mandoc: Updating FreeBSD thead library descriptions
Wed, May 13, 4:34 PM
jhb committed rG538f0564c119: mandoc: Add an entry for libsys to lib.in (authored by jhb).
mandoc: Add an entry for libsys to lib.in
Wed, May 13, 4:34 PM
jhb closed D56855: arm64/vmm: Enforce a data barrier before tlbi for non-VHE.
Wed, May 13, 4:34 PM
jhb closed D56850: mandoc: Updating FreeBSD thead library descriptions.
Wed, May 13, 4:34 PM
jhb closed D56849: mandoc: Add an entry for libsys to lib.in.
Wed, May 13, 4:34 PM
jhb added a comment to D56989: amd64: Drop segment descriptor details from trap messsages.

Sample output:

Wed, May 13, 4:31 PM
jhb requested review of D56990: clock_gettime.2: Fix a couple of typos.
Wed, May 13, 4:31 PM
jhb requested review of D56989: amd64: Drop segment descriptor details from trap messsages.
Wed, May 13, 4:30 PM

Mon, May 11

jhb added a comment to D56250: kvm: introduce kvm_convert_to_elf().
In D56250#1295915, @jhb wrote:

Hmmm, cross debugging of cross-architectures does work on a FreeBSD host?

Oh, I meant debugging across different operating systems (e.g. FreeBSD arm64 dump on Linux amd64 LLDB). This was something we wanted since the foundation sponsored LLDB's kernel debugging project, but the approach at that time was to port libkvm to other OSes (libfbsdvmcore). The end result was portable libkvm, but the issue was that most distros didn't ship LLDB with that third-party library, hence debugging FreeBSD crash dump was impossible without building LLDB from source with that library included. Also libfbsdvmcore had to catch up with libkvm, but it has been unmaintained for years.

Mon, May 11, 3:47 PM

Fri, May 8

jhb added inline comments to D54586: mdoc: Standardize SYNOPISIS section for drivers.
Fri, May 8, 2:36 PM

Thu, May 7

jhb abandoned D55156: googletest: Link the gmock and gtest libraries against compiler_rt for aarch64.

Supplanted by rGe63eee84cad59f63338a539e73bed07917932088.

Thu, May 7, 2:16 PM

Wed, May 6

jhb closed D56625: kobj: Use M_WAITOK in kobj_init.
Wed, May 6, 8:55 PM
jhb committed rG5df7dae10dc0: kobj: Use M_WAITOK in kobj_init (authored by jhb).
kobj: Use M_WAITOK in kobj_init
Wed, May 6, 8:55 PM
jhb closed D56624: kobj: Assert class passed to kobj_init_static is compiled.
Wed, May 6, 8:54 PM
jhb committed rG5a6e5954d14b: kobj: Assert class passed to kobj_init_static is compiled (authored by jhb).
kobj: Assert class passed to kobj_init_static is compiled
Wed, May 6, 8:54 PM
jhb requested review of D56855: arm64/vmm: Enforce a data barrier before tlbi for non-VHE.
Wed, May 6, 4:44 PM
jhb requested review of D56850: mandoc: Updating FreeBSD thead library descriptions.
Wed, May 6, 2:44 PM
jhb requested review of D56849: mandoc: Add an entry for libsys to lib.in.
Wed, May 6, 2:44 PM

May 2 2026

jhb closed D56628: ctl_ioctl_frontend: Reject out-of-range initiator IDs.
May 2 2026, 4:51 PM