Page MenuHomeFreeBSD

jhb (John Baldwin)
User

Projects (7)

User Details

User Since
Mar 11 2014, 8:46 PM (240 w, 4 d)

Recent Activity

Wed, Oct 17

jhb accepted D17424: Support for 2nd scheme of PTE A and D bits management.

My last note is a suggestion, it's also fine as-is. I will probably work on changing the pmap to honor VM_PROT_EXECUTE next which will alter this a bit anyway and might use that approach then.

Wed, Oct 17, 5:08 PM
jhb added inline comments to D17424: Support for 2nd scheme of PTE A and D bits management.
Wed, Oct 17, 5:06 PM

Tue, Oct 16

jhb committed rS339392: MFC 326138,326436,326852: Style fixes to kdump..
MFC 326138,326436,326852: Style fixes to kdump.
Tue, Oct 16, 8:53 PM
jhb added a comment to D17424: Support for 2nd scheme of PTE A and D bits management.

I think I would perhaps reword the commit message as "2nd Scheme" isn't very descriptive. Maybe something like:

Tue, Oct 16, 4:32 PM
jhb accepted D17583: Fix pmap_invalidate_all().
Tue, Oct 16, 3:02 PM

Mon, Oct 15

jhb committed rS339367: Various fixes for TLB management on RISC-V..
Various fixes for TLB management on RISC-V.
Mon, Oct 15, 6:57 PM
jhb closed D17414: Various fixes for TLB management on RISC-V..
Mon, Oct 15, 6:57 PM
jhb committed rS339364: Reload the LDT selector after an AMD-v #VMEXIT..
Reload the LDT selector after an AMD-v #VMEXIT.
Mon, Oct 15, 6:12 PM

Thu, Oct 11

jhb committed rS339315: MFC 338055: Remove some vestiges of IPI_LAZYPMAP on i386..
MFC 338055: Remove some vestiges of IPI_LAZYPMAP on i386.
Thu, Oct 11, 7:08 PM
jhb committed rS339312: Fully restore the GDTR, IDTR, and LDTR after VT-x VM exits..
Fully restore the GDTR, IDTR, and LDTR after VT-x VM exits.
Thu, Oct 11, 6:27 PM
jhb accepted D17482: bhyve: emulate CLFLUSH and CLFLUSHOPT..
Thu, Oct 11, 6:09 PM
jhb updated the diff for D17414: Various fixes for TLB management on RISC-V..
  • Drop commented out fence at the end of sfence_vma.
  • Use static instead of PMAP_INLINE for pmap_invalidate_*().
  • Use the SBI interface for remote fence.i for pmap_sync_icache.
  • Flush the i-cache on all harts before writing a new PTE for an executable mapping.
  • Don't use SFENCE.VMA after changing a mapping from invalid to valid.
Thu, Oct 11, 6:06 PM
jhb added inline comments to D17414: Various fixes for TLB management on RISC-V..
Thu, Oct 11, 5:28 PM

Wed, Oct 10

jhb committed rS339293: Disable the KASSERT for curcpu == 0 in netisr for EARLY_AP_STARTUP..
Disable the KASSERT for curcpu == 0 in netisr for EARLY_AP_STARTUP.
Wed, Oct 10, 9:28 PM
jhb added inline comments to D17414: Various fixes for TLB management on RISC-V..
Wed, Oct 10, 5:07 PM
jhb added inline comments to D17414: Various fixes for TLB management on RISC-V..
Wed, Oct 10, 4:41 PM
jhb added inline comments to D17414: Various fixes for TLB management on RISC-V..
Wed, Oct 10, 4:17 PM
jhb accepted D17493: Check for td_epochnest when an ithread sleeps.
Wed, Oct 10, 3:44 PM

Tue, Oct 9

jhb added inline comments to D17424: Support for 2nd scheme of PTE A and D bits management.
Tue, Oct 9, 11:23 PM
jhb committed rS339273: MFC 338976: Don't clear DR6 for debug exceptions from userland..
MFC 338976: Don't clear DR6 for debug exceptions from userland.
Tue, Oct 9, 10:35 PM
jhb updated the diff for D17414: Various fixes for TLB management on RISC-V..
  • Fix whitespace in sbi_call().
  • Drop fence() before single-threaded fence_i().
  • Trim parens.
Tue, Oct 9, 9:31 PM
jhb added inline comments to D17414: Various fixes for TLB management on RISC-V..
Tue, Oct 9, 9:26 PM
jhb added inline comments to D17424: Support for 2nd scheme of PTE A and D bits management.
Tue, Oct 9, 8:42 PM
jhb accepted D17481: Makefile.inc1: handle dependencies across libevent migration.
Tue, Oct 9, 6:14 PM
jhb accepted D17481: Makefile.inc1: handle dependencies across libevent migration.
Tue, Oct 9, 6:00 PM
jhb added a comment to D17481: Makefile.inc1: handle dependencies across libevent migration.

Hmm, so this should actually be part of the commit to libntpevent if we do that independent of the openssl merge (which I think we should)

Tue, Oct 9, 6:00 PM
jhb committed rS339260: Update sendmail to work with the OpenSSL 1.1 API..
Update sendmail to work with the OpenSSL 1.1 API.
Tue, Oct 9, 5:44 PM
jhb committed rS339256: Update Apache Serf to 1.3.9 to support OpenSSL 1.1.1..
Update Apache Serf to 1.3.9 to support OpenSSL 1.1.1.
Tue, Oct 9, 3:28 PM

Mon, Oct 8

jhb committed rS339246: crypto: Don't limit to TLSv1 only.
crypto: Don't limit to TLSv1 only
Mon, Oct 8, 11:23 PM
jhb accepted D17461: truss: handle shm_open's special SHM_ANON value better..
Mon, Oct 8, 9:09 PM
jhb added a comment to D17439: Make it possible to disable NUMA support with a tunable..

My only suggestion might be to consider an explicit "disabled" tunable. For SMP we have 'kern.smp.disabled=1'. Having 'vm.numa.disabled=1' or 'kern.numa.disabled=1' might be more intuitive than setting ndomains to 1. (The implementation might be that you set ndomains to 1 if the tunable is set, but it's the UI I'm thinking of).

Mon, Oct 8, 7:31 PM
jhb added inline comments to D13865: Improve comment in socketvar.h.
Mon, Oct 8, 7:27 PM
jhb committed rS339242: Add support for relocations in RISC-V kernel modules to kldxref..
Add support for relocations in RISC-V kernel modules to kldxref.
Mon, Oct 8, 7:16 PM
jhb closed D17415: Add support for relocations in RISC-V kernel modules to kldxref..
Mon, Oct 8, 7:16 PM
jhb created D17474: A couple of style fixes in recent TCP changes..
Mon, Oct 8, 6:18 PM
jhb committed rS339239: MFC 338021: Use 'bool' instead of 'int' for various boolean flags..
MFC 338021: Use 'bool' instead of 'int' for various boolean flags.
Mon, Oct 8, 5:22 PM
jhb committed rS339238: MFC 337400: Remove spurious ABI tags from kdump output..
MFC 337400: Remove spurious ABI tags from kdump output.
Mon, Oct 8, 5:19 PM
jhb added inline comments to D17461: truss: handle shm_open's special SHM_ANON value better..
Mon, Oct 8, 4:04 PM
jhb accepted D17461: truss: handle shm_open's special SHM_ANON value better..

Looks good apart from a sorting nit.

Mon, Oct 8, 4:03 PM

Fri, Oct 5

jhb committed rS339210: MFC 338022: Fix casts between 64-bit physical addresses and pointers in EFI..
MFC 338022: Fix casts between 64-bit physical addresses and pointers in EFI.
Fri, Oct 5, 9:10 PM
jhb added a comment to D17424: Support for 2nd scheme of PTE A and D bits management.

Hmm, I think for this we want to actually wait to set PTE_A and PTE_D for user mappings until we get a fault? Presumably we'd want to check in the page fault handler if f the PTE was already valid before calling vm_fault and if it was set PTE_A (and PTE_D for a write) and then retry?

Fri, Oct 5, 4:40 PM
jhb committed rS339198: Update the existing heimdal implementation for OpenSSL 1.1..
Update the existing heimdal implementation for OpenSSL 1.1.
Fri, Oct 5, 4:35 PM
jhb closed D17276: Update heimdal to build against OpenSSL 1.1..
Fri, Oct 5, 4:35 PM

Thu, Oct 4

jhb accepted D17397: Consolidate identical ELF auxargs type defintions..
Thu, Oct 4, 9:08 PM
jhb created D17415: Add support for relocations in RISC-V kernel modules to kldxref..
Thu, Oct 4, 6:16 PM
jhb created D17414: Various fixes for TLB management on RISC-V..
Thu, Oct 4, 5:43 PM
jhb added a comment to D17397: Consolidate identical ELF auxargs type defintions..

Actually, my plan is to just change them on powerpc and have them unified across the board. They should then really just live in sys/elf_common.h. I think if we want to move them now we should just move them and maybe add some #ifdef powerpc that we eventually remove when renumbering powerpc's vectors. I think the actual renumbering change is probably too big of a change during code freeze.

Thu, Oct 4, 4:19 PM

Wed, Oct 3

jhb updated the diff for D17276: Update heimdal to build against OpenSSL 1.1..
  • Fix build on mips (32-bit and using GCC instead of clang)
Wed, Oct 3, 5:03 PM
jhb accepted D17390: openssh config.h: update for OpenSSL 1.1.1 compat patch.

Just commit already. openssh isn't buildable without this. :-P Note that if we merge this to head before openssl is updated we'd need a different config.h in head.

Wed, Oct 3, 4:35 PM

Tue, Oct 2

jhb committed rS339099: Update obsolete files list for OpenSSL 1.1.1..
Update obsolete files list for OpenSSL 1.1.1.
Tue, Oct 2, 9:41 PM
jhb closed D17384: Update obsolete files list for OpenSSL 1.1.1..
Tue, Oct 2, 9:41 PM
jhb added inline comments to D17276: Update heimdal to build against OpenSSL 1.1..
Tue, Oct 2, 7:05 PM
jhb updated the diff for D17276: Update heimdal to build against OpenSSL 1.1..
  • More bjk feedback.
Tue, Oct 2, 7:05 PM
jhb created D17384: Update obsolete files list for OpenSSL 1.1.1..
Tue, Oct 2, 6:34 PM
jhb accepted D17378: Move 32-bit compat support for CDIOREADTOCENTRYS to the right place..

Thanks

Tue, Oct 2, 4:39 PM
jhb accepted D17380: libelf: correct mips64 test to use ELF header.

Use "mips64el" instead of "mips64le" in the commit message. Good sleuthing!

Tue, Oct 2, 2:29 AM

Mon, Oct 1

jhb added inline comments to D17378: Move 32-bit compat support for CDIOREADTOCENTRYS to the right place..
Mon, Oct 1, 6:45 PM

Fri, Sep 28

jhb committed rS339003: MFC 337673: Add an overview section to bus_dma.9..
MFC 337673: Add an overview section to bus_dma.9.
Fri, Sep 28, 5:40 PM
jhb committed rS339002: Regenerate after UNIMPL -> OBSOL changes in r339001..
Regenerate after UNIMPL -> OBSOL changes in r339001.
Fri, Sep 28, 5:25 PM
jhb committed rS339001: Mark various removed system calls as OBSOL instead of UNIMPL..
Mark various removed system calls as OBSOL instead of UNIMPL.
Fri, Sep 28, 5:24 PM
jhb closed D17344: Mark various removed system calls as OBSOL instead of UNIMPL..
Fri, Sep 28, 5:24 PM
jhb committed rS339000: Run 32-bit compat ldconfig on mips64..
Run 32-bit compat ldconfig on mips64.
Fri, Sep 28, 5:01 PM
jhb closed D17342: Run 32-bit compat ldconfig on mips64..
Fri, Sep 28, 5:01 PM
jhb added a comment to D17344: Mark various removed system calls as OBSOL instead of UNIMPL..
In D17344#369936, @kib wrote:

Are the real changes only in syscall.masters ? The syscall.master' diffs look fine.

Fri, Sep 28, 4:09 PM
jhb created D17344: Mark various removed system calls as OBSOL instead of UNIMPL..
Fri, Sep 28, 12:26 AM

Thu, Sep 27

jhb added inline comments to D16635: Summary: acpi: fix acpi_ec_probe to only check EC devices.
Thu, Sep 27, 8:45 PM
jhb added a comment to D17324: Centralize compat support for PCIOCGETCONF..

Agree with kib on the general point that all of freebsd32_ioctl is probably busted and should be moved to the actual ioctl handlers.

Thu, Sep 27, 5:39 PM
jhb created D17342: Run 32-bit compat ldconfig on mips64..
Thu, Sep 27, 5:36 PM
jhb committed rS338976: Don't clear DR6 for debug exceptions from userland..
Don't clear DR6 for debug exceptions from userland.
Thu, Sep 27, 5:34 PM
jhb closed D17319: Don't clear DR6 for debug exceptions from userland..
Thu, Sep 27, 5:34 PM

Tue, Sep 25

jhb added inline comments to D17315: Add a "live" mode to ktrdump..
Tue, Sep 25, 8:56 PM
jhb created D17319: Don't clear DR6 for debug exceptions from userland..
Tue, Sep 25, 7:24 PM
jhb updated the diff for D17276: Update heimdal to build against OpenSSL 1.1..
  • Various fixes from bjk@
Tue, Sep 25, 7:12 PM
jhb added inline comments to D17276: Update heimdal to build against OpenSSL 1.1..
Tue, Sep 25, 7:11 PM
jhb created D17315: Add a "live" mode to ktrdump..
Tue, Sep 25, 6:07 PM

Mon, Sep 24

jhb committed rS338916: Restore the API of the kf_sa_local and kf_sa_peer members..
Restore the API of the kf_sa_local and kf_sa_peer members.
Mon, Sep 24, 6:20 PM
jhb closed D17262: Restore the API of the kf_sa_local and kf_sa_peer members..
Mon, Sep 24, 6:20 PM
jhb committed rS338914: Implement pmap_sync_icache()..
Implement pmap_sync_icache().
Mon, Sep 24, 5:41 PM
jhb closed D17139: Implement pmap_sync_icache()..
Mon, Sep 24, 5:41 PM
jhb committed rP480613: Upgrade to 8.2..
Upgrade to 8.2.
Mon, Sep 24, 5:23 PM
jhb closed D17085: devel/gdb: Upgrade to 8.2..
Mon, Sep 24, 5:23 PM

Sat, Sep 22

jhb added a comment to D17276: Update heimdal to build against OpenSSL 1.1..

I did some very simple testing which seemed to work:

Sat, Sep 22, 12:38 AM

Fri, Sep 21

jhb updated the diff for D17276: Update heimdal to build against OpenSSL 1.1..

Fixed the various issues I noted earlier.

Fri, Sep 21, 8:52 PM
jhb added inline comments to D17276: Update heimdal to build against OpenSSL 1.1..
Fri, Sep 21, 8:49 PM
jhb added inline comments to D17276: Update heimdal to build against OpenSSL 1.1..
Fri, Sep 21, 7:12 PM
jhb created D17276: Update heimdal to build against OpenSSL 1.1..
Fri, Sep 21, 6:53 PM

Sep 21 2018

jhb added a comment to D17262: Restore the API of the kf_sa_local and kf_sa_peer members..

So the fact that some things were updated for the new name and that it clashed with the old name made just reverting to the old name messy. I already had done the union change as a followup to remove the compat macros, and it occurred to me that since I had it, I could actually go back to using kf_sa_local/peer in both places which would let both the old and new names work at the same time. This in theory shouldn't require reverting any of the ports changes or upstream port changes while still preserving the existing API. We could even go back and fix the kf_sock_ variants to remove the trailing '0' now if we wished to as well.

Sep 21 2018, 12:41 AM
jhb updated the diff for D17262: Restore the API of the kf_sa_local and kf_sa_peer members..
  • Use an anonymous union and struct for FreeBSD 11 compat fields.
  • Rename the kf_un.kf_sock variants back to their original names.
Sep 21 2018, 12:38 AM

Sep 20 2018

jhb updated the diff for D17139: Implement pmap_sync_icache()..
  • Use a regular 'fence' in pmap_sync_icache() before the IPI.
Sep 20 2018, 8:46 PM
jhb added a comment to D17262: Restore the API of the kf_sa_local and kf_sa_peer members..

exp-run requested at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231525

Sep 20 2018, 6:39 PM
jhb updated the diff for D17262: Restore the API of the kf_sa_local and kf_sa_peer members..
  • Use kf_sock_local/peer instead of kf_sa_local0/peer0.
Sep 20 2018, 6:32 PM
jhb added inline comments to D17262: Restore the API of the kf_sa_local and kf_sa_peer members..
Sep 20 2018, 6:23 PM
jhb created D17262: Restore the API of the kf_sa_local and kf_sa_peer members..
Sep 20 2018, 6:15 PM
jhb committed rS338833: MFC 337270: Install the 32-bit compat sanitizer libraries..
MFC 337270: Install the 32-bit compat sanitizer libraries.
Sep 20 2018, 4:44 PM
jhb accepted D17253: vfs: remove lookup_shared tunable.

Originally it was useful to disable this when a bug was encountered, but the window where that was useful probably ended several years ago.

Sep 20 2018, 4:15 PM

Sep 19 2018

jhb committed rS338814: Various fixes for floating point on RISC-V..
Various fixes for floating point on RISC-V.
Sep 19 2018, 11:45 PM
jhb closed D17141: Various fixes for floating point on RISC-V..
Sep 19 2018, 11:45 PM
jhb committed rS338813: Clear all of the VFP state in fill_fpregs()..
Clear all of the VFP state in fill_fpregs().
Sep 19 2018, 10:54 PM
jhb closed D17140: Clear all of the VFP state in fill_fpregs()..
Sep 19 2018, 10:54 PM
jhb added a comment to D17139: Implement pmap_sync_icache()..
In D17139#365780, @jhb wrote:

"To make a store to instruction memory visible to all RISC-V harts, the writing hart has to execute a data FENCE before requesting that all remote RISC-V harts execute a FENCE.I."

Doesn't that imply that we should execute a bare "fence" before the SMP rendezvous?

Mmm, yes, though I wonder if smp_rendezvous doesn't already do a fence already? Doesn't hurt to be explicit though.

BTW, there are some intrinsics in cpufunc_asm.S, but I don't think there's a good reason for them to be proper subroutines. It might be nice to make a fence_i(void) inline function in cpufunc.h, similar to what we have on amd64.

Sorry, I had a pending comment for that that didn't get published until just now. Also, it seems like the existing use of fence.i doesn't have a fence?

How about having cpu_icache_sync_range() issue a fence and fence.i, and modify pmap_sync_icache() to issue the fence before the smp_rendezvous()?

Sep 19 2018, 10:32 PM