Page MenuHomeFreeBSD

jhb (John Baldwin)
User

Projects (9)

User Details

User Since
Mar 11 2014, 8:46 PM (583 w, 1 d)

Recent Activity

Yesterday

jhb added a comment to D45552: create sticky bit /usr/obj/home dir.

I'd rather not add new uses of the sticky bit.

and pw(8) could offer to do that as @markj suggests

Do you mean adduser? pw isn't interactive.

From a sysadm's perspective, I also not very sure it's a good idea to add one more (and uncommon) place other than /tmp (and /var/tmp) where non-superuser can write files to by default. It might cause a DoS issue to the system.

Maybe /usr/obj/home/foo can be a symlink to /home/foo/obj instead, though that's perhaps a bit sneaky.

Wed, May 14, 7:45 PM
jhb added a comment to D48812: ppt: Fix panic when configuring unavailable MSI-X vector.

Oh yes, and I even accepted this when I said it. :)

Wed, May 14, 7:42 PM
jhb added a comment to D50345: libproc: Remove SIG2STR_MAX..

It seems libproc's proc_signame() is just buggy in FreeBSD. illumos calls str2sig(): https://github.com/illumos/illumos-gate/blob/1b1703a43cdfe482965d40a4baae758d05844ac2/usr/src/lib/libproc/common/proc_names.c#L106

Wed, May 14, 7:41 PM
jhb added a comment to D50089: Don't define NULL to nullptr in C++11 mode.

FWIW, of the two ports that broke, one had already fixed itself upstream but we just have an ancient version in the ports tree.

Wed, May 14, 4:25 PM
jhb added a comment to D50345: libproc: Remove SIG2STR_MAX..

libproc is a Solaris interface, so I think it's documented there. proc_signame() is functionally equivalent to strsignal() AFAIK.

Wed, May 14, 4:20 PM
jhb requested review of D50351: games/pink-pony: Pass nullptr instead of NULL to auto_ptr constructor.
Wed, May 14, 3:04 PM
jhb added a comment to D50350: devel/py-pyopencl: Pass nullptr instead of NULL to unique_ptr constructor.

This could also be fixed by updating to a newer version, but that involves other change as it doesn't build the same, etc. so I punted on that. The latest release is 2025.1, so the port is about 7 years out of date.

Wed, May 14, 3:03 PM
jhb requested review of D50350: devel/py-pyopencl: Pass nullptr instead of NULL to unique_ptr constructor.
Wed, May 14, 3:02 PM
jhb added a comment to D48812: ppt: Fix panic when configuring unavailable MSI-X vector.

Do we still need this after fixing the PCI bus driver to stop caching the message count?

Wed, May 14, 1:16 PM
jhb accepted D50294: e6000sw: fix bus ordering; don't panic if miibus devices are destroyed.
Wed, May 14, 1:11 PM
jhb added a comment to D50345: libproc: Remove SIG2STR_MAX..

The dtrace use is under #ifdef illumos but that should probably be fixed to always be enabled as proc_signame() exists in libproc. The plockstat use is enabled on both FreeBSD and illumos (and is also for a call to proc_signame()).

Wed, May 14, 1:00 PM
jhb added a comment to D50345: libproc: Remove SIG2STR_MAX..

Hmm, my grep found a few uses in cddl tools for dtrace:

Wed, May 14, 12:56 PM

Tue, May 13

jhb added a comment to D40816: bsdinstall: protect disk label and zfsboot on Auto ZFS+MBR.

If this works I'm fine with landing it.

Tue, May 13, 3:06 PM
jhb committed rG2befd0658832: cxgbe nic TLS: Fix requests with 8 bytes of immediate data padding (authored by jhb).
cxgbe nic TLS: Fix requests with 8 bytes of immediate data padding
Tue, May 13, 2:12 PM

Thu, May 8

jhb added inline comments to D50104: crypto: Remove uses of CRYPTO_F_DONE.
Thu, May 8, 6:37 PM
jhb accepted D49709: pci: Ignore PCRx devices resources.
Thu, May 8, 6:30 PM
jhb accepted D50104: crypto: Remove uses of CRYPTO_F_DONE.
Thu, May 8, 6:27 PM
jhb accepted D50238: krb5: Fix handling of transient crypto request failures.
Thu, May 8, 6:26 PM

Wed, May 7

jhb added a comment to D50222: nvmf: Auto-reconnect periodically after a disconnect.

Also, not sure if it's worth saying, but I chose to use a devctl event that triggers nvmecontrol reconnect rather than adding a new nvmfd daemon to the system similar to iscsid. One reason is that nvmfd is already taken (though I plan to add nvmf support to ctld and retire nvmfd eventually), but adding an nvmfd would also mean either duplicating a bunch of code from nvmecontrol or having to factor it out into a library, etc. I also find the design of iscsid a bit odd as iscsictl basically sends message to iscsid via ioctls using the kernel as a kind of proxy. With this approach, the additional state of a timer for reconnects is kept in the kernel instead, but I think overall that this is simpler.

Wed, May 7, 6:01 PM
jhb committed rGf22326c73eeb: nvmf.4: Remove obsolete bug (authored by jhb).
nvmf.4: Remove obsolete bug
Wed, May 7, 1:48 PM
jhb closed D50175: devd.8: Document monitoring devd.pipe via cat.
Wed, May 7, 1:47 PM
jhb committed rG38a5520692d8: devd.8: Document monitoring devd.pipe via cat (authored by jhb).
devd.8: Document monitoring devd.pipe via cat
Wed, May 7, 1:47 PM

Tue, May 6

jhb added a comment to D50222: nvmf: Auto-reconnect periodically after a disconnect.

Also, devctl events seem to be rather inconsistent in naming (upper vs lower case for system, etc.)

Tue, May 6, 9:36 PM
jhb added a comment to D50222: nvmf: Auto-reconnect periodically after a disconnect.

The events from devd look like:

Tue, May 6, 9:35 PM
jhb requested review of D50222: nvmf: Auto-reconnect periodically after a disconnect.
Tue, May 6, 9:33 PM
jhb updated the diff for D50175: devd.8: Document monitoring devd.pipe via cat.

Use Dl

Tue, May 6, 9:33 PM
jhb added inline comments to D48693: build/development.7: System building examples.
Tue, May 6, 9:24 PM
jhb accepted D50136: sys: don't panic on ifm_status being NULL.

I think EDOOFUS is fine.

Tue, May 6, 9:16 PM
jhb added inline comments to D50175: devd.8: Document monitoring devd.pipe via cat.
Tue, May 6, 9:09 PM
jhb added a comment to D50104: crypto: Remove uses of CRYPTO_F_DONE.

So maybe one commit to update the krb5 code to use crp_opaque = NULL and then you can just remove the flag entirely in a second commit? The changes look ok to me though (I'm just also fine with now removing the flag entirely)

Tue, May 6, 9:04 PM

Mon, May 5

jhb requested review of D50175: devd.8: Document monitoring devd.pipe via cat.
Mon, May 5, 7:54 PM

Sun, May 4

jhb added inline comments to D50104: crypto: Remove uses of CRYPTO_F_DONE.
Sun, May 4, 12:49 AM

Sat, May 3

jhb committed rG26d4ac7a2725: kyua: Don't pass NULL to unique_ptr constructors (authored by jhb).
kyua: Don't pass NULL to unique_ptr constructors
Sat, May 3, 3:59 PM
jhb committed rGd61c8bca8648: kyua: Don't pass NULL to std::unique_ptr<>::reset() (authored by jhb).
kyua: Don't pass NULL to std::unique_ptr<>::reset()
Sat, May 3, 3:59 PM
jhb closed D50090: kyua: Don't pass NULL to unique_ptr constructors.
Sat, May 3, 3:59 PM
jhb closed D50091: kyua: Don't pass NULL to std::unique_ptr<>::reset().
Sat, May 3, 3:59 PM
jhb added a comment to D50136: sys: don't panic on ifm_status being NULL.

I just wonder if the panic is a feature that the driver is broken? That is, does the driver still work ok if the ordering is wrong and this patch is applied?

Sat, May 3, 3:57 PM

Wed, Apr 30

jhb added a comment to D50089: Don't define NULL to nullptr in C++11 mode.

exp-run requested at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=286477

Wed, Apr 30, 5:19 PM
jhb added a comment to D50089: Don't define NULL to nullptr in C++11 mode.

This probably needs an exp run, I don’t know how many ports depend on this behaviour.

Wed, Apr 30, 5:14 PM
jhb added a comment to D50091: kyua: Don't pass NULL to std::unique_ptr<>::reset().

Also included in https://github.com/freebsd/kyua/pull/265

Wed, Apr 30, 5:02 PM
jhb added a comment to D50090: kyua: Don't pass NULL to unique_ptr constructors.

This fixes the build with GCC.

Wed, Apr 30, 5:01 PM
jhb added a comment to D50089: Don't define NULL to nullptr in C++11 mode.

This makes C++ on FreeBSD less of a special snowflake. In particular, once this is reverted, clang fails the same way GCC fails currently on kyua. Had this not been in place, I wouldn't have pushed a broken patchset to kyua. :(

Wed, Apr 30, 5:01 PM
jhb added a reviewer for D50089: Don't define NULL to nullptr in C++11 mode: dim.
Wed, Apr 30, 4:59 PM
jhb added a reverting change for rG3033610f5dfd: Define NULL to nullptr in C++11 mode (not strictly required, but it makes: D50089: Don't define NULL to nullptr in C++11 mode.
Wed, Apr 30, 4:58 PM
jhb requested review of D50091: kyua: Don't pass NULL to std::unique_ptr<>::reset().
Wed, Apr 30, 4:57 PM
jhb requested review of D50090: kyua: Don't pass NULL to unique_ptr constructors.
Wed, Apr 30, 4:57 PM
jhb requested review of D50089: Don't define NULL to nullptr in C++11 mode.
Wed, Apr 30, 4:57 PM
jhb committed rG6f0aa2343b1d: ObsoleteFiles.inc: Fix the path to libdevinfo.so.6 (authored by jhb).
ObsoleteFiles.inc: Fix the path to libdevinfo.so.6
Wed, Apr 30, 2:55 PM

Tue, Apr 29

jhb committed rG51e6e35947fc: Update example from gcc6 to gcc13 (authored by imp).
Update example from gcc6 to gcc13
Tue, Apr 29, 8:44 PM
jhb committed rG02663a236080: .cirrus-ci: Update the non-manual GCC build job to GCC 14 (authored by jhb).
.cirrus-ci: Update the non-manual GCC build job to GCC 14
Tue, Apr 29, 8:44 PM
jhb committed rG06ecf26346fa: universe: Update the default GCC toolchain to GCC 14 (authored by jhb).
universe: Update the default GCC toolchain to GCC 14
Tue, Apr 29, 8:44 PM
jhb committed rG00c8c5e2c358: pcib: Clear any pending slot status events during attach (authored by jhb).
pcib: Clear any pending slot status events during attach
Tue, Apr 29, 8:34 PM
jhb committed rG37032a39c5e9: pcib: Ignore power fault detected if a power controller is not present (authored by jhb).
pcib: Ignore power fault detected if a power controller is not present
Tue, Apr 29, 8:33 PM
jhb committed rGeef4e44a41e4: telnet: Prevent buffer overflow in the user prompt for SRA (authored by jhb).
telnet: Prevent buffer overflow in the user prompt for SRA
Tue, Apr 29, 8:33 PM
jhb committed rG3357c016c79c: nvmecontrol.8: Fix markup of default transport for the discover command (authored by jhb).
nvmecontrol.8: Fix markup of default transport for the discover command
Tue, Apr 29, 8:13 PM
jhb committed rGb4cc8079a759: devd.conf.5: memrory -> memory (authored by jhb).
devd.conf.5: memrory -> memory
Tue, Apr 29, 8:13 PM
jhb committed rG14cb4636358f: pcib: Clear any pending slot status events during attach (authored by jhb).
pcib: Clear any pending slot status events during attach
Tue, Apr 29, 6:31 PM
jhb committed rG4373c15f1fa2: pcib: Ignore power fault detected if a power controller is not present (authored by jhb).
pcib: Ignore power fault detected if a power controller is not present
Tue, Apr 29, 6:31 PM
jhb committed rG7485e6a867ab: telnet: Prevent buffer overflow in the user prompt for SRA (authored by jhb).
telnet: Prevent buffer overflow in the user prompt for SRA
Tue, Apr 29, 6:31 PM
jhb committed rGa2de254b2007: acpi_pci: Use pci_has_pm and pci_clear_pme (authored by jhb).
acpi_pci: Use pci_has_pm and pci_clear_pme
Tue, Apr 29, 6:31 PM
jhb committed rG6f27822152e4: dev: Use recently added improvements to PME# support to simplify drivers (authored by jhb).
dev: Use recently added improvements to PME# support to simplify drivers
Tue, Apr 29, 6:31 PM
jhb committed rGb8b5dbdb93f8: pci: Add helper routines to manage PME in device drivers (authored by jhb).
pci: Add helper routines to manage PME in device drivers
Tue, Apr 29, 6:31 PM
jhb committed rG6fb471682aa9: rwmlock/rwlock/sx: Print the pointer of destroyed locks in panic messages (authored by jhb).
rwmlock/rwlock/sx: Print the pointer of destroyed locks in panic messages
Tue, Apr 29, 6:31 PM
jhb committed rGb5bc47f1e1ab: pci: Clear active PME# and disable PME# generation (authored by jhb).
pci: Clear active PME# and disable PME# generation
Tue, Apr 29, 6:31 PM
jhb committed rG33bf58fbd8e5: lockmgr/rmlock/rwlock/sx: Make various assertions more robust (authored by jhb).
lockmgr/rmlock/rwlock/sx: Make various assertions more robust
Tue, Apr 29, 6:31 PM
jhb committed rGd9ce37179a2f: mtx: Include the mutex pointer in the panic message for destroyed locks (authored by jhb).
mtx: Include the mutex pointer in the panic message for destroyed locks
Tue, Apr 29, 6:31 PM
jhb committed rG7a7a7cd85090: mtx: Make idle thread assertions more robust (authored by jhb).
mtx: Make idle thread assertions more robust
Tue, Apr 29, 6:31 PM
jhb committed rGab9e7d209ac5: hdaa: Don't hold a mutex while creating child devices (authored by jhb).
hdaa: Don't hold a mutex while creating child devices
Tue, Apr 29, 6:31 PM
jhb committed rG27fb895f9e81: mtx: Avoid nested panics on lock class mismatch assertions (authored by jhb).
mtx: Avoid nested panics on lock class mismatch assertions
Tue, Apr 29, 6:31 PM
jhb committed rG207e58ce8a6d: sdhci: Use bus_topo_lock and taskqueue_bus for hotplug events (authored by jhb).
sdhci: Use bus_topo_lock and taskqueue_bus for hotplug events
Tue, Apr 29, 6:31 PM
jhb committed rGee08e8455170: mmc: Use bus_topo_lock and taskqueue_bus while adding/removing child devices (authored by jhb).
mmc: Use bus_topo_lock and taskqueue_bus while adding/removing child devices
Tue, Apr 29, 6:31 PM
jhb committed rG50c1d075dc8e: pcib: Use taskqueue_bus for hot-plug events instead of a private taskqueue (authored by jhb).
pcib: Use taskqueue_bus for hot-plug events instead of a private taskqueue
Tue, Apr 29, 6:31 PM
jhb committed rG34f9dca1917b: pci: avoid accidental clobbering of regs on some fdt platforms (authored by kevans).
pci: avoid accidental clobbering of regs on some fdt platforms
Tue, Apr 29, 6:31 PM
jhb committed rG3a54ca5e28d8: new-bus: Add taskqueue_bus to process hot-plug device events (authored by jhb).
new-bus: Add taskqueue_bus to process hot-plug device events
Tue, Apr 29, 6:31 PM
jhb committed rG7bc852d94dbf: pci: propagate vpd read error (authored by rlibby).
pci: propagate vpd read error
Tue, Apr 29, 6:31 PM
jhb committed rG0a515a8d36ad: pci: Don't cache the count of MSI/MSI-X messages before allocation (authored by jhb).
pci: Don't cache the count of MSI/MSI-X messages before allocation
Tue, Apr 29, 6:31 PM
jhb committed rG14749f40c193: pci: Cosmetic cleanups to MSI/MSI-X routines (authored by jhb).
pci: Cosmetic cleanups to MSI/MSI-X routines
Tue, Apr 29, 6:31 PM
jhb committed rGcbaa32c28a05: pci_host_generic: Use SYS_RES_MEMORY for the parent of I/O resource ranges (authored by jhb).
pci_host_generic: Use SYS_RES_MEMORY for the parent of I/O resource ranges
Tue, Apr 29, 6:31 PM
jhb accepted D50068: fts: Fix GCC compile error.

In block_abi.h there is a GET_BLOCK_FUNCTION macro, and I sort of wonder if a GET_BLOCK_ISA wouldn't be useful instead (maybe if we ever have to fix this sort of thing in the future it will be useful to factor out such a macro)? OTOH, I can't see any other reason for the typedef DECLARE_BLOCK in fts.c except to handle this case, so I think this patch is fine as-is.

Tue, Apr 29, 2:56 PM
jhb added a comment to D50016: subr_devmap: Reduce the use of the static devmap.

Thanks, this is great.

To me it is preferable to replace the repeated #ifdef __arm__ instances with a named flag, e.g. #ifdef DEVMAP_HAS_STATIC. If it is annoying to achieve then no problem.

Tue, Apr 29, 2:33 PM
jhb added a comment to D49970: queue: Consistent single space after all #define.
In D49970#1141669, @jhb wrote:

Originally it ways always tab. The change to permit spaces is recent, and older code from BSD should probably stay as it was to avoid churn. It seems the recent additions to this file just failed to follow the part about "match the existing style".

FWIW, I've added the corresponding commit to .git-blame-ignore-revs (as requested by markj@) so that it doesn't show up in git blame (provided git is so configured).

Would you like me to switch to all tabs instead?

Tue, Apr 29, 2:30 PM

Mon, Apr 28

jhb added a comment to D49970: queue: Consistent single space after all #define.
In D49970#1141594, @jhb wrote:

Hmm, isn't this backwards as style(9) requires tabs? Probably not worth swapping back at this point, but maybe avoid future style regressions?

I thought that was OK:
"Put a single space or tab character between the #define and the macro name, but be consistent within a file."

There was a mix of tabs and spaces, with a slight majority of spaces (and using spaces is my personal preference as well, as TABs sometimes cause misalignment in diffs).

Mon, Apr 28, 8:00 PM
jhb added a comment to D50008: LinuxKPI: pci: properly define PCI_ANY_ID.

The registers are 16-bit in the hardware. Linux might be using 32-bit ints just to be more efficient on architectures that don't handle shorts as well. What do the relevant APIs in Linux itself use for the types?

Mon, Apr 28, 7:56 PM
jhb added a comment to D50020: openssh: Add ${SKSRCS} to libssh.

This isn't about namespacing though. Even without the namespacing you'd just have undefined symbols for the symbol without the prefix. Doesn't this just revert your earlier change though, and shouldn't we now drop all of the SKSRCS in all of the other Makefiles (not just the ones I added) since they are now redundant?

Mon, Apr 28, 7:54 PM
jhb committed rG4e2616b74cb7: cross-build: Workaround system-provided strchrnul on macOS 15.4+ (authored by jhb).
cross-build: Workaround system-provided strchrnul on macOS 15.4+
Mon, Apr 28, 5:11 PM
jhb closed D49893: cross-build: Workaround system-provided strchrnul on macOS 15.4+.
Mon, Apr 28, 5:11 PM
jhb committed rGdcb2a1ae46ad: <net/sff8472.h>: Conditionally export table of ID names (authored by jhb).
<net/sff8472.h>: Conditionally export table of ID names
Mon, Apr 28, 5:08 PM
jhb closed D49955: <net/sff8472.h>: Conditionally export table of ID names.
Mon, Apr 28, 5:08 PM
jhb committed rGac3110dc9ec0: <net/if_strings.h>: Conditionally export table of bit names (authored by jhb).
<net/if_strings.h>: Conditionally export table of bit names
Mon, Apr 28, 5:08 PM
jhb closed D49954: <net/if_strings.h>: Conditionally export table of bit names.
Mon, Apr 28, 5:08 PM
jhb added a comment to D49955: <net/sff8472.h>: Conditionally export table of ID names.
In D49955#1139102, @jhb wrote:

If this header is used outside of base and the _id[] array is used from it, then we might need to instead disable the warning for this header during the test-includes phase.

Yes. That's why this approach seems somewhat impractical, and also ad-hoc as we would have to do that anytime we add some static constant to some header. This is a rare case, and right now I'm not really sure why we would need to do that. Perhaps to simplify cases where the same header is used in the kernel and in userland?

From D49830, I gather you also tried to disable -Wunused-variable. Isn't that approach enough? It has the benefit to be more generic. That said, the macro guard is anyway needed if the header is included by userspace and the constant not used.

Mon, Apr 28, 5:05 PM
jhb committed rGb392a90ba4e5: kyua: Switch from std::auto_ptr<> to std::unique_ptr<> (authored by jhb).
kyua: Switch from std::auto_ptr<> to std::unique_ptr<>
Mon, Apr 28, 5:03 PM
jhb closed D49790: kyua: Switch from std::auto_ptr<> to std::unique_ptr<>.
Mon, Apr 28, 5:03 PM
jhb added a comment to D49970: queue: Consistent single space after all #define.

Hmm, isn't this backwards as style(9) requires tabs? Probably not worth swapping back at this point, but maybe avoid future style regressions?

Mon, Apr 28, 3:40 PM

Wed, Apr 23

jhb accepted D49849: pci: Add hw.pci.intx_reroute sysctl/tunable.
Wed, Apr 23, 2:45 PM

Tue, Apr 22

jhb added inline comments to D49960: Makefile.inc1: Let the buildetc target run outside of etc.
Tue, Apr 22, 6:45 PM
jhb added a comment to D49955: <net/sff8472.h>: Conditionally export table of ID names.

If this header is used outside of base and the _id[] array is used from it, then we might need to instead disable the warning for this header during the test-includes phase.

Tue, Apr 22, 3:06 AM
jhb added a comment to D49830: kernel/gcc: turn off -Werror=unused-variable.

See D49954 and D49955 for one approach. I also tested patching tools/build/test-includes/Makefile to add -Wno-unused-variable to CFLAGS for these specific headers.

Tue, Apr 22, 3:05 AM
jhb requested review of D49955: <net/sff8472.h>: Conditionally export table of ID names.
Tue, Apr 22, 3:04 AM
jhb requested review of D49954: <net/if_strings.h>: Conditionally export table of bit names.
Tue, Apr 22, 3:04 AM