Page MenuHomeFreeBSD

jhb (John Baldwin)
User

Projects (8)

User Details

User Since
Mar 11 2014, 8:46 PM (392 w, 6 d)

Recent Activity

Yesterday

jhb closed D32000: devel/gdb: Update to 11.1..
Mon, Sep 20, 8:47 PM
jhb committed R11:242d3697fdfa: devel/gdb: Update to 11.1. (authored by jhb).
devel/gdb: Update to 11.1.
Mon, Sep 20, 8:47 PM
jhb added inline comments to D19831: Add PT_GETREGSET.
Mon, Sep 20, 8:27 PM
jhb accepted D32029: Convert consumers to use the CPU_FOREACH_SET() macro.
Mon, Sep 20, 8:19 PM
jhb accepted D32011: pci_pci: Support growing bus ranges in bus_adjust_resource for NEW_PCIB.
Mon, Sep 20, 8:13 PM
jhb added a comment to D31957: sys/x86: check for out of range interrupt allocations.

I would probably keep this as a KASSERT(). pic_vector itself returns an int rather than a u_int. vector should match that, so I would say either explicitly check for vector < 0' in the KASSERT, or change pic_vector` and the various implementations of it to return a u_int in addition to changing vector. (Calling it pic_first_irq while at it might be even better)

Mon, Sep 20, 8:12 PM
jhb accepted D32001: riscv: Add vt and kbdmux to GENERIC for video console support.
Mon, Sep 20, 8:07 PM
jhb added inline comments to D31954: amd64: stop using top of the thread' kernel stack for FPU user save area.
Mon, Sep 20, 7:02 PM
jhb accepted D31954: amd64: stop using top of the thread' kernel stack for FPU user save area.
Mon, Sep 20, 6:59 PM
jhb accepted D32023: aio_fsync_vnode: handle ERELOOKUP after VOP_FSYNC().
Mon, Sep 20, 5:01 PM

Fri, Sep 17

jhb accepted D32008: Remove support for FreeBSD 11.4.

security/isal-kmod is ok.

Fri, Sep 17, 8:06 PM
jhb committed R10:c6efcb1281f3: bhyve: Support setting the disk serial number for VirtIO block devices. (authored by jhb).
bhyve: Support setting the disk serial number for VirtIO block devices.
Fri, Sep 17, 4:56 PM
jhb closed D31983: bhyve: Support setting the disk serial number for VirtIO block devices..
Fri, Sep 17, 4:56 PM
jhb updated the diff for D32000: devel/gdb: Update to 11.1..
  • Update to newer libcxx-gdbpy.
Fri, Sep 17, 2:57 PM
jhb added a comment to D32000: devel/gdb: Update to 11.1..

I have some other changes to libcxx-gdbpy I need to push to GitHub and update the hash in here again to add pretty printers for std::deque<> and std::stack<>.

Fri, Sep 17, 12:42 AM
jhb requested review of D32000: devel/gdb: Update to 11.1..
Fri, Sep 17, 12:40 AM

Thu, Sep 16

jhb accepted D31991: minidump: Use provided msgbuf pointer.
Thu, Sep 16, 7:50 PM
jhb added a comment to D31983: bhyve: Support setting the disk serial number for VirtIO block devices..

I think the goal was to also be similar to the name used for the AHCI and NVMe device models which both use "ser" for this.

Thu, Sep 16, 6:14 PM
jhb updated the diff for D27463: Extend the VMM stats interface to support a dynamic count of statistics..
  • Rebase.
  • COMPAT_FREEBSD12 -> COMPAT_FREEBSD13.
  • Reject negative 'index' and 'count'.
Thu, Sep 16, 4:43 PM
jhb added a comment to D31983: bhyve: Support setting the disk serial number for VirtIO block devices..

Whoops, sorry, this isn't NVMe. :)

Thu, Sep 16, 4:31 PM
jhb added inline comments to D31977: ktls: Fix error/mode confusion in TCP_*TLS_MODE getsockopt handlers.
Thu, Sep 16, 3:44 PM
jhb added a comment to D31983: bhyve: Support setting the disk serial number for VirtIO block devices..

@chuck, would you be able to test this easily?

Thu, Sep 16, 3:31 PM
jhb added a reviewer for D31983: bhyve: Support setting the disk serial number for VirtIO block devices.: chuck.
Thu, Sep 16, 3:31 PM
jhb requested review of D31983: bhyve: Support setting the disk serial number for VirtIO block devices..
Thu, Sep 16, 1:58 PM

Wed, Sep 15

jhb accepted D31976: socket: Handle shutdown(2) with AIO jobs in flight.
Wed, Sep 15, 11:24 PM
jhb accepted D31968: Remove PT_GET_SC_ARGS_ALL.
Wed, Sep 15, 11:15 PM
jhb accepted D31977: ktls: Fix error/mode confusion in TCP_*TLS_MODE getsockopt handlers.

I think this is fine, just one thought.

Wed, Sep 15, 11:15 PM
jhb closed D31892: iscsi: Abort data-out tasks queued on a terminating session..
Wed, Sep 15, 8:30 PM
jhb committed R10:0cd6e85e242b: iscsi: Abort data-out tasks queued on a terminating session. (authored by jhb).
iscsi: Abort data-out tasks queued on a terminating session.
Wed, Sep 15, 8:30 PM
jhb closed D31891: iscsi: Add a helper routine to abort a data-out task..
Wed, Sep 15, 8:30 PM
jhb committed R10:529364b032d7: iscsi: Add a helper routine to abort a data-out task. (authored by jhb).
iscsi: Add a helper routine to abort a data-out task.
Wed, Sep 15, 8:30 PM
jhb added inline comments to D31962: linux: For better compatibility, provide compatible endian.h.
Wed, Sep 15, 5:29 PM
jhb accepted D31964: endian.h: Use the __bswap* versions.
Wed, Sep 15, 5:25 PM
jhb accepted D31968: Remove PT_GET_SC_ARGS_ALL.
Wed, Sep 15, 5:25 PM
jhb added a comment to D31954: amd64: stop using top of the thread' kernel stack for FPU user save area.

I'd be happy btw with fixing i386 to stop using alloca() rather than my GCC warning hack. I do wonder why we can't just use the normal save area though?

Wed, Sep 15, 5:23 PM
jhb added inline comments to D19831: Add PT_GETREGSET.
Wed, Sep 15, 5:18 PM
jhb abandoned D31572: Add a switch structure for send tags..

Not sure why this didn't auto close. I committed a version that folded in the changes to move 'type' into the switch structure.

Wed, Sep 15, 5:08 PM
jhb committed R10:857dc1c0ecfb: arm64: Pass the right label to END() for handle_empty_exception. (authored by jhb).
arm64: Pass the right label to END() for handle_empty_exception.
Wed, Sep 15, 4:07 PM
jhb committed R10:8753039a8f23: arm64: Fix a logic bug in is_load_instr(). (authored by jhb).
arm64: Fix a logic bug in is_load_instr().
Wed, Sep 15, 4:07 PM
jhb committed R10:d99c87c8d54a: evdev: Add parentheses around '-' expression in operand of '&'. (authored by jhb).
evdev: Add parentheses around '-' expression in operand of '&'.
Wed, Sep 15, 4:07 PM
jhb committed R10:cd16a848d1b3: posixshmtest: Fix various warnings raised by GCC. (authored by jhb).
posixshmtest: Fix various warnings raised by GCC.
Wed, Sep 15, 4:07 PM
jhb committed R10:df005aa9b3d8: pf: Remove duplicate declaration of pf_ioctl_maxcount. (authored by jhb).
pf: Remove duplicate declaration of pf_ioctl_maxcount.
Wed, Sep 15, 4:07 PM
jhb committed R10:44126818d2ec: infiniband: Disable -Wredundant-decl warnings. (authored by jhb).
infiniband: Disable -Wredundant-decl warnings.
Wed, Sep 15, 4:07 PM
jhb committed R10:9553c6af881e: <linux/overflow.h>: Don't use __has_builtin(). (authored by jhb).
<linux/overflow.h>: Don't use __has_builtin().
Wed, Sep 15, 4:07 PM
jhb closed D31950: arm64: Pass the right label to END() for handle_empty_exception..
Wed, Sep 15, 4:07 PM
jhb committed R10:b14cd3a8339e: efitable: Don't pass NULL as a format string to xo_err(). (authored by jhb).
efitable: Don't pass NULL as a format string to xo_err().
Wed, Sep 15, 4:07 PM
jhb closed D31949: arm64: Fix a logic bug in is_load_instr()..
Wed, Sep 15, 4:07 PM
jhb committed R10:4c9cb057bd96: top: Remove a duplicate extern declaration for show_args. (authored by jhb).
top: Remove a duplicate extern declaration for show_args.
Wed, Sep 15, 4:07 PM
jhb closed D31947: evdev: Add parentheses around '-' expression in operand of '&'..
Wed, Sep 15, 4:07 PM
jhb closed D31944: pf: Remove duplicate declaration of pf_ioctl_maxcount..
Wed, Sep 15, 4:07 PM
jhb closed D31946: posixshmtest: Fix various warnings raised by GCC..
Wed, Sep 15, 4:06 PM
jhb committed R10:5ac4ac85ca20: Remove an always-true check. (authored by jhb).
Remove an always-true check.
Wed, Sep 15, 4:06 PM
jhb committed R10:11647befcbb8: Only define sanitizer wrappers for unsized bus space operations once. (authored by jhb).
Only define sanitizer wrappers for unsized bus space operations once.
Wed, Sep 15, 4:06 PM
jhb closed D31943: infiniband: Disable -Wredundant-decl warnings..
Wed, Sep 15, 4:06 PM
jhb closed D31942: <linux/overflow.h>: Don't use __has_builtin()..
Wed, Sep 15, 4:06 PM
jhb closed D31939: efitable: Don't pass NULL as a format string to xo_err()..
Wed, Sep 15, 4:06 PM
jhb committed R10:45cb7671133e: Only define sanitizer wrappers for atomic fences once. (authored by jhb).
Only define sanitizer wrappers for atomic fences once.
Wed, Sep 15, 4:06 PM
jhb committed R10:d2bc7754a226: Assert that invalid bus widths can't be passed to bus_width_str(). (authored by jhb).
Assert that invalid bus widths can't be passed to bus_width_str().
Wed, Sep 15, 4:06 PM
jhb closed D31936: Remove an always-true check..
Wed, Sep 15, 4:06 PM
jhb closed D31937: top: Remove a duplicate extern declaration for show_args..
Wed, Sep 15, 4:06 PM
jhb closed D31966: Only define sanitizer wrappers for unsized bus space operations once..
Wed, Sep 15, 4:06 PM
jhb closed D31965: Only define sanitizer wrappers for atomic fences once..
Wed, Sep 15, 4:06 PM
jhb closed D31935: Assert that invalid bus widths can't be passed to bus_width_str()..
Wed, Sep 15, 4:06 PM
jhb closed D31932: Remove nonexistent include path for arm64 crypto files..
Wed, Sep 15, 4:06 PM
jhb committed R10:828f257277bd: Remove nonexistent include path for arm64 crypto files. (authored by jhb).
Remove nonexistent include path for arm64 crypto files.
Wed, Sep 15, 4:06 PM
jhb requested review of D31969: arm64, riscv: Fix TRAF_PC() to return the PC, not the return address..
Wed, Sep 15, 4:02 PM
jhb added a comment to D31949: arm64: Fix a logic bug in is_load_instr()..

I have no idea if this is needed or not TBH.

Wed, Sep 15, 3:58 PM
jhb added inline comments to D31948: mana: Cast an unused value to void to quiet a warning..
Wed, Sep 15, 3:57 PM
jhb added inline comments to D31946: posixshmtest: Fix various warnings raised by GCC..
Wed, Sep 15, 3:55 PM
jhb added inline comments to D31945: libmd: Only define SHA256_Transform_c when using the ARM64 ifunc..
Wed, Sep 15, 3:54 PM
jhb added a comment to D31942: <linux/overflow.h>: Don't use __has_builtin()..
In D31942#720643, @imp wrote:

As an alternative, you could define __has_builtin(x) to 1 and suffer with a less precise error message should x not actually be supported.

Wed, Sep 15, 3:51 PM
jhb added a comment to D31941: Use a char * to avoid alignment warnings..

The build fails with GCC on all architectures.

Wed, Sep 15, 3:50 PM
jhb requested review of D31966: Only define sanitizer wrappers for unsized bus space operations once..
Wed, Sep 15, 2:39 AM
jhb requested review of D31965: Only define sanitizer wrappers for atomic fences once..
Wed, Sep 15, 2:38 AM

Tue, Sep 14

jhb committed R10:9affbb0f5271: cxgbe tom: Enter network epoch in t4_aiotx_task(). (authored by jhb).
cxgbe tom: Enter network epoch in t4_aiotx_task().
Tue, Sep 14, 8:48 PM
jhb committed R10:5dbf8c1588da: cxgbe tom: Update rcv_nxt for a FIN after handle_ddp_close(). (authored by jhb).
cxgbe tom: Update rcv_nxt for a FIN after handle_ddp_close().
Tue, Sep 14, 8:47 PM
jhb committed R10:1ecbc1d8e9d3: cxgbe tom: Don't queue AIO requests on listen sockets. (authored by jhb).
cxgbe tom: Don't queue AIO requests on listen sockets.
Tue, Sep 14, 8:47 PM
jhb committed R10:c782ea8bb50b: Add a switch structure for send tags. (authored by jhb).
Add a switch structure for send tags.
Tue, Sep 14, 6:52 PM

Mon, Sep 13

jhb requested review of D31950: arm64: Pass the right label to END() for handle_empty_exception..
Mon, Sep 13, 6:30 PM
jhb requested review of D31949: arm64: Fix a logic bug in is_load_instr()..
Mon, Sep 13, 6:30 PM
jhb added a comment to D31945: libmd: Only define SHA256_Transform_c when using the ARM64 ifunc..

This is definitely a workaround, and I don't fully understand why the tail call messes up this way when using GCC.

Mon, Sep 13, 6:29 PM
jhb added a comment to D31948: mana: Cast an unused value to void to quiet a warning..

Adding an atomic_inc() wrapper might be a cleaner way of fixing this.

Mon, Sep 13, 6:29 PM
jhb requested review of D31948: mana: Cast an unused value to void to quiet a warning..
Mon, Sep 13, 6:28 PM
jhb requested review of D31947: evdev: Add parentheses around '-' expression in operand of '&'..
Mon, Sep 13, 6:28 PM
jhb requested review of D31946: posixshmtest: Fix various warnings raised by GCC..
Mon, Sep 13, 6:26 PM
jhb requested review of D31945: libmd: Only define SHA256_Transform_c when using the ARM64 ifunc..
Mon, Sep 13, 6:25 PM
jhb requested review of D31944: pf: Remove duplicate declaration of pf_ioctl_maxcount..
Mon, Sep 13, 6:25 PM
jhb requested review of D31943: infiniband: Disable -Wredundant-decl warnings..
Mon, Sep 13, 6:24 PM
jhb requested review of D31942: <linux/overflow.h>: Don't use __has_builtin()..
Mon, Sep 13, 6:23 PM
jhb requested review of D31941: Use a char * to avoid alignment warnings..
Mon, Sep 13, 6:23 PM
jhb requested review of D31939: efitable: Don't pass NULL as a format string to xo_err()..
Mon, Sep 13, 6:21 PM
jhb requested review of D31938: bhyve: Add an empty case for event types in mevent_kq_fflags()..
Mon, Sep 13, 6:20 PM
jhb requested review of D31937: top: Remove a duplicate extern declaration for show_args..
Mon, Sep 13, 6:19 PM
jhb requested review of D31936: Remove an always-true check..
Mon, Sep 13, 6:19 PM
jhb requested review of D31935: Assert that invalid bus widths can't be passed to bus_width_str()..
Mon, Sep 13, 6:12 PM
jhb requested review of D31934: kernel: Disable errors for -Walloca-larger-than for GCC..
Mon, Sep 13, 6:10 PM
jhb requested review of D31933: hyperv storvsc: Don't abuse struct sglist to hold virtual addresses..
Mon, Sep 13, 6:09 PM
jhb requested review of D31932: Remove nonexistent include path for arm64 crypto files..
Mon, Sep 13, 6:03 PM
jhb committed R10:93d6fa53c995: Disable -Woverflow errors for i386 for GCC 9. (authored by jhb).
Disable -Woverflow errors for i386 for GCC 9.
Mon, Sep 13, 6:02 PM
jhb closed D26201: Disable -Woverflow errors for i386 for GCC 9..
Mon, Sep 13, 6:02 PM