Page MenuHomeFreeBSD

jhb (John Baldwin)
User

Projects (9)

User Details

User Since
Mar 11 2014, 8:46 PM (297 w, 2 d)

Recent Activity

Yesterday

jhb committed rP518116: Use clang 7 as compiler on 11.x and 12.x to fix build..
Use clang 7 as compiler on 11.x and 12.x to fix build.
Thu, Nov 21, 10:22 PM
jhb closed D22486: devel/mdb: Use clang 7 as compiler on 11.x and 12.x to fix build..
Thu, Nov 21, 10:22 PM
jhb committed rS354974: NIC KTLS for Chelsio T6 adapters..
NIC KTLS for Chelsio T6 adapters.
Thu, Nov 21, 7:31 PM
jhb created D22486: devel/mdb: Use clang 7 as compiler on 11.x and 12.x to fix build..
Thu, Nov 21, 7:07 PM
jhb created D22483: Expand net epoch in the cxgbe TOE driver to satisfy assertions..
Thu, Nov 21, 6:29 PM
jhb committed rS354971: Use kmod.opts.mk to fix standalone build..
Use kmod.opts.mk to fix standalone build.
Thu, Nov 21, 6:21 PM
jhb closed D22118: Add a kmod.opts.mk..
Thu, Nov 21, 6:18 PM
jhb committed rS354970: Add a kmod.opts.mk..
Add a kmod.opts.mk.
Thu, Nov 21, 6:14 PM
jhb committed rD53619: Rewrite the platform Tier definitions..
Rewrite the platform Tier definitions.
Thu, Nov 21, 5:41 PM
jhb closed D22439: Rewrite the platform Tier definitions..
Thu, Nov 21, 5:41 PM
jhb updated the diff for D22118: Add a kmod.opts.mk..

Rebase after r354968.

Thu, Nov 21, 5:29 PM
jhb added a comment to D21707: Add VIRTIO_BLK_T_DISCARD (TRIM) support to the bhyve virtio-blk backend.

Ping. Can you confirm that this works ok with Linux guests? Also, any sense of making forward progress on using block_if_can_delete()?

Thu, Nov 21, 5:14 PM

Wed, Nov 20

jhb added a comment to D22144: Introduce bsd.sysdir.mk to consolidate looking for the kernel..

Ping.

Wed, Nov 20, 11:37 PM
jhb committed rP518059: Use per-architecture packing list files for architecture-specific files..
Use per-architecture packing list files for architecture-specific files.
Wed, Nov 20, 10:46 PM
jhb closed D22451: Use per-architecture packing list files for architecture-specific files..
Wed, Nov 20, 10:46 PM
jhb closed D22450: Permit multiple packing list files to be listed in PLIST..
Wed, Nov 20, 10:44 PM
jhb committed rP518058: Permit multiple packing list files to be listed in PLIST..
Permit multiple packing list files to be listed in PLIST.
Wed, Nov 20, 10:44 PM
jhb added a comment to D22450: Permit multiple packing list files to be listed in PLIST..

Ok, I did do some test builds of a "normal" port when testing this as well (just using default PLIST), and I do think it's true that if this broke it would break everything.

Wed, Nov 20, 10:40 PM
jhb added a comment to D22450: Permit multiple packing list files to be listed in PLIST..

I think this probably warrants an exp-run before committing?

Wed, Nov 20, 10:03 PM

Tue, Nov 19

jhb added a comment to D22450: Permit multiple packing list files to be listed in PLIST..

There may be better ways of doing this, this was just a first cut. You can see an example of this being used in the child revision in the stack (D22451)

Tue, Nov 19, 11:29 PM
jhb created D22451: Use per-architecture packing list files for architecture-specific files..
Tue, Nov 19, 11:28 PM
jhb created D22450: Permit multiple packing list files to be listed in PLIST..
Tue, Nov 19, 11:27 PM
jhb closed D22147: Add freebsd-gcc6 port..
Tue, Nov 19, 6:53 PM
jhb committed rP517976: Add freebsd-gcc6 port..
Add freebsd-gcc6 port.
Tue, Nov 19, 6:53 PM
jhb accepted D22440: bhyve: virtio-net: disable receive until features are negotiated.
Tue, Nov 19, 6:15 PM
jhb added inline comments to D22440: bhyve: virtio-net: disable receive until features are negotiated.
Tue, Nov 19, 5:17 PM

Mon, Nov 18

jhb committed rS354827: Check for errors from copyout() and suword*() in sv_copyout_args/strings..
Check for errors from copyout() and suword*() in sv_copyout_args/strings.
Mon, Nov 18, 8:08 PM
jhb closed D22401: Check for errors from copyout() and suword*() in sv_copyout_args/strings..
Mon, Nov 18, 8:08 PM
jhb added inline comments to D22401: Check for errors from copyout() and suword*() in sv_copyout_args/strings..
Mon, Nov 18, 7:15 PM
jhb updated the diff for D22401: Check for errors from copyout() and suword*() in sv_copyout_args/strings..
  • Use 'if (error != 0)'
Mon, Nov 18, 7:15 PM
jhb created D22439: Rewrite the platform Tier definitions..
Mon, Nov 18, 7:09 PM

Sat, Nov 16

jhb created D22401: Check for errors from copyout() and suword*() in sv_copyout_args/strings..
Sat, Nov 16, 12:47 AM

Fri, Nov 15

jhb updated subscribers of D22356: Use a sv_copyout_auxargs hook in the Linux ELF ABIs..
Fri, Nov 15, 11:56 PM
jhb added a comment to D22147: Add freebsd-gcc6 port..

A pre-commit hook says I can't commit anything using FLAVORS without portmgr approval, so adding portmgr.

Fri, Nov 15, 11:44 PM
jhb added a reviewer for D22147: Add freebsd-gcc6 port.: portmgr.
Fri, Nov 15, 11:43 PM
jhb committed rS354754: Use a sv_copyout_auxargs hook in the Linux ELF ABIs..
Use a sv_copyout_auxargs hook in the Linux ELF ABIs.
Fri, Nov 15, 11:02 PM
jhb closed D22356: Use a sv_copyout_auxargs hook in the Linux ELF ABIs..
Fri, Nov 15, 11:02 PM
jhb added a comment to D17002: Fix compilation with upstream clang builtin headers.

Does this work with GCC? Seems no:

Fri, Nov 15, 9:51 PM
jhb closed D22357: Combine ELF sysvecs for MIPS to reduce code duplication..
Fri, Nov 15, 7:00 PM
jhb committed rS354744: Combine ELF sysvecs for MIPS to reduce code duplication..
Combine ELF sysvecs for MIPS to reduce code duplication.
Fri, Nov 15, 7:00 PM
jhb added a comment to D22357: Combine ELF sysvecs for MIPS to reduce code duplication..

I will make it static for commit.

Fri, Nov 15, 6:44 PM
jhb added a comment to D22356: Use a sv_copyout_auxargs hook in the Linux ELF ABIs..

@emaste would you be able to test this on arm64?

Fri, Nov 15, 6:44 PM
jhb committed rS354741: Add a sv_copyout_auxargs() hook in sysentvec..
Add a sv_copyout_auxargs() hook in sysentvec.
Fri, Nov 15, 6:42 PM
jhb closed D22355: Add a sv_copyout_auxargs() hook in sysentvec..
Fri, Nov 15, 6:42 PM
jhb added a comment to D22363: Increase number of algorithms that can be initialized in cryptosoft.

TLS has a similar requirement btw of requiring AAD data that isn't present in the on-wire data in the buffer. The way I would handle TLS if we added support for TLS proper in the ocf_rework branch would be to add a new "mode" CSP_MODE_TLS along with some TLS-specific parameters to the session structure such as the TLS version and the TLS sequence number to 'struct cryptop'. I think that same approach would work well with ESN, but it's a bit invasive for drivers. (One reason I considered CSP_MODE_TLS is that some hardware accelerators such as ccr(4) can do TLS "natively", but that isn't true of ESN AFAIK). I will spend some more time thinking about ESN, but I've just rebased the rework branch and gotten the remaining drivers converted this week, so am going to send out a call for testing today or early next week (I can't run-time test all the drivers). The current framework is far too limited in that real hardware needs to know if it is doing ETA or MTE, etc. and the current OCF has no way to express that. It also has no way to express variable sized IVs (which we really need for the full suite of GCM and CCM NIST KAT vectors). The linked-list approach is also quite clumsy to work with on the driver side (a lot of boilerplate code gets removed from drivers trying to maintain a state machine to validate sessions in the current model that turns into simpler checks on a flat structure in the rework).

Fri, Nov 15, 5:03 PM

Thu, Nov 14

jhb added a comment to D22363: Increase number of algorithms that can be initialized in cryptosoft.

I do plan to land my ocf_rework branch soon which completely reworks the data structures (e.g. removing the linked list of cryptoini and cryptodesc). Some pointers to what ESNs are and how they are used would be useful to ensure that the new approach can work with it. The new approach uses a single, flat structure to describe both sessions and operations with explicit modes for combined operations (e.g. an ETA mode for Encrypt-then-Authenticate used by IPSec and TLS with ETM).

Thu, Nov 14, 5:10 PM
jhb updated the diff for D21962: NIC KTLS for Chelsio T6 adapters..
  • Rebase and update after t4_keyctx.c commit.
Thu, Nov 14, 1:11 AM
jhb committed rP517553: Update security/razorback-api to compile with OpenSSL 1.1.x..
Update security/razorback-api to compile with OpenSSL 1.1.x.
Thu, Nov 14, 1:04 AM
jhb closed D20844: Update security/razorback-api to compile with OpenSSL 1.1.x..
Thu, Nov 14, 1:04 AM
jhb added inline comments to D22356: Use a sv_copyout_auxargs hook in the Linux ELF ABIs..
Thu, Nov 14, 12:54 AM
jhb accepted D22144: Introduce bsd.sysdir.mk to consolidate looking for the kernel..
Thu, Nov 14, 12:40 AM

Wed, Nov 13

jhb added inline comments to D22357: Combine ELF sysvecs for MIPS to reduce code duplication..
Wed, Nov 13, 11:52 PM
jhb added inline comments to D22355: Add a sv_copyout_auxargs() hook in sysentvec..
Wed, Nov 13, 11:45 PM
jhb created D22357: Combine ELF sysvecs for MIPS to reduce code duplication..
Wed, Nov 13, 11:05 PM
jhb created D22356: Use a sv_copyout_auxargs hook in the Linux ELF ABIs..
Wed, Nov 13, 11:04 PM
jhb added a reviewer for D22355: Add a sv_copyout_auxargs() hook in sysentvec.: emaste.
Wed, Nov 13, 11:03 PM
jhb created D22355: Add a sv_copyout_auxargs() hook in sysentvec..
Wed, Nov 13, 11:03 PM
jhb closed D22350: Refine r354661 to unbreak the GCC_BOOTSTRAP case..
Wed, Nov 13, 9:50 PM
jhb committed rS354693: Refine r354661 to unbreak the GCC_BOOTSTRAP case..
Refine r354661 to unbreak the GCC_BOOTSTRAP case.
Wed, Nov 13, 9:50 PM
jhb created D22350: Refine r354661 to unbreak the GCC_BOOTSTRAP case..
Wed, Nov 13, 8:11 PM
jhb accepted D22326: RISC-V: add support for SBI spec v0.2.
Wed, Nov 13, 5:08 PM
jhb committed rS354686: Add t4_keyctx.c to sys/conf/files for the non-module build..
Add t4_keyctx.c to sys/conf/files for the non-module build.
Wed, Nov 13, 5:06 PM
jhb committed rS354667: Create a file to hold shared routines for dealing with T6 key contexts..
Create a file to hold shared routines for dealing with T6 key contexts.
Wed, Nov 13, 12:54 AM
jhb closed D22156: Create a file to hold shared routines for dealing with T6 key contexts..
Wed, Nov 13, 12:54 AM
jhb accepted D22338: Fix a typo in the PMAP_PTE_SET_CACHE_BITS macro..
Wed, Nov 13, 12:42 AM
jhb accepted D22327: RISC-V: Print SBI info at startup.
Wed, Nov 13, 12:36 AM
jhb accepted D22325: RISC-V: pass arg6 in sbi_call.
Wed, Nov 13, 12:30 AM

Tue, Nov 12

jhb added a comment to D22147: Add freebsd-gcc6 port..

Any further thoughts? I could perhaps work on the PLIST thing as a followup and then split up the plist after that

Tue, Nov 12, 11:58 PM
jhb closed D22333: Sync target triple generation with the version in Makefile.inc1..
Tue, Nov 12, 9:35 PM
jhb committed rS354662: Sync target triple generation with the version in Makefile.inc1..
Sync target triple generation with the version in Makefile.inc1.
Tue, Nov 12, 9:35 PM
jhb added a comment to D22333: Sync target triple generation with the version in Makefile.inc1..

Oh, and yes, for riscv it always ends up as 'riscv64-unknown-freebsd13.0' for both riscv64 and riscv64sf. We add -msoft-float to CFLAGS in bsd.cpu.mk for riscv64sf. I'm not sure if there's a way to encode the float ABI in the target triple. (For 32-bit arm at least there are ABI variants you can put into the triple)

Tue, Nov 12, 9:34 PM
jhb added a comment to D22333: Sync target triple generation with the version in Makefile.inc1..

It would be nice if there was some way to centralize this modifier, maybe by using an approach like __LLVM_TARGET_FILT since it is used twice in Makefile.inc1 and twice here. The POWER9 folks have some other review open that centralizes target triple generation I thought, but I haven't looked at it recently.

Tue, Nov 12, 9:32 PM
jhb committed rS354661: Force MK_CLANG_IS_CC on in XMAKE..
Force MK_CLANG_IS_CC on in XMAKE.
Tue, Nov 12, 9:30 PM
jhb closed D22332: Force MK_CLANG_IS_CC on in XMAKE..
Tue, Nov 12, 9:30 PM
jhb added a comment to D22332: Force MK_CLANG_IS_CC on in XMAKE..

It shouldn't. The only thing that honors MK_CLANG_IS_CC is the clang Makefile, and during XMAKE we only enter that subdirectory if MK_CLANG_BOOSTRAP is yes, and we shouldn't have both that and MK_GCC_BOOTSTRAP as yes at the same time.

Tue, Nov 12, 9:28 PM
jhb committed rS354660: Enable the RISC-V LLVM backend by default..
Enable the RISC-V LLVM backend by default.
Tue, Nov 12, 9:27 PM
jhb closed D22284: Enable the RISCV LLVM backend by default..
Tue, Nov 12, 9:27 PM
jhb created D22333: Sync target triple generation with the version in Makefile.inc1..
Tue, Nov 12, 5:10 PM
jhb created D22332: Force MK_CLANG_IS_CC on in XMAKE..
Tue, Nov 12, 5:07 PM
jhb updated the diff for D22284: Enable the RISCV LLVM backend by default..
  • Enable building of clang by default on riscv.
Tue, Nov 12, 5:06 PM

Mon, Nov 11

jhb added a comment to D22303: db_nextframe/i386: reduce the number of special frame types.

Note that gdb also knows which symbols have which behavior, so changing the stack frame layout will break kgdb, and then kgdb would have to somehow detect which i386 kernels had which behavior. We've done that once before by peeking at instructions [1], but I think it's not worth spending that much effort on i386 and easier to just let the frame layouts stay as-is. The reason for the enums was to handle the separate cases as you note for args. I don't mind changing this to use 'narg'.

Mon, Nov 11, 4:46 PM
jhb accepted D22302: amd64: move gdt into pcpu.

I wish one could use PCPU_GET(gdt) instead of *PCPU_PTR(gdt) to look more readable, but I understand why we can't do that.

Mon, Nov 11, 4:28 PM

Sat, Nov 9

jhb added inline comments to D22286: bhyve: rework mevent processing to fix a race condition.
Sat, Nov 9, 6:37 PM

Fri, Nov 8

jhb added inline comments to D22284: Enable the RISCV LLVM backend by default..
Fri, Nov 8, 10:10 PM
jhb created D22284: Enable the RISCV LLVM backend by default..
Fri, Nov 8, 5:58 PM
jhb accepted D21315: bhyve: tap: add support for offloads.
Fri, Nov 8, 5:26 PM
jhb accepted D21007: bhyve: add support for virtio-net mergeable rx buffers.
Fri, Nov 8, 5:24 PM

Thu, Nov 7

jhb added a comment to D22147: Add freebsd-gcc6 port..

I think all you have to do to support multiple files in PLIST would be one of the following in the generate-plist target in bsd.port.mk:

Thu, Nov 7, 6:25 PM
jhb updated the diff for D22147: Add freebsd-gcc6 port..
  • Move FLAVORS section earlier.
Thu, Nov 7, 5:53 PM
jhb added a comment to D21007: bhyve: add support for virtio-net mergeable rx buffers.

This looks ok to me generally. Do you need to refresh this after other recent commits?

Thu, Nov 7, 5:24 PM
jhb added inline comments to D21315: bhyve: tap: add support for offloads.
Thu, Nov 7, 5:17 PM
jhb added a comment to D22144: Introduce bsd.sysdir.mk to consolidate looking for the kernel..

Ping. The kmod.opts.mk change is a prerequisite for bhyve save/restore, so I'd like to either commit that one as-is and do this cleanup afterwards, or get this one unstuck to make forward progress. I still have questions about the KERNBUILDDIR stuff as I don't fully understand the implications of removing those checks.

Thu, Nov 7, 5:02 PM
jhb added inline comments to D22231: amd64: move common_tss into pcpu.
Thu, Nov 7, 4:57 PM

Wed, Nov 6

jhb added inline comments to D22258: Update devel/binutils to 2.33.1 and FLAVORIZED it.
Wed, Nov 6, 8:12 PM
jhb added a comment to D22258: Update devel/binutils to 2.33.1 and FLAVORIZED it.
In D22258#486564, @bapt wrote:
In D22258#486560, @jhb wrote:

Heh, I had thought about just doing this for the ones used by xtoolchain, but this looks more complete.
One thing that might really be nice would be to have an easy way to have multiple PLIST files so that one could have something like:

PLIST_FILES= ${.CURDIR}/pkg-plist ${.CURDIR}/pkg-plist.${TARGETARCH}

And put "common" files in pkg-plist and ARCH-specific files in the sub-plists rather than duplicating lots of plist content. For freebsd6-gcc I used a unified plist with PLIST_SUB's for ARCH-specific files, but having a nice way to have pkg-plist.${FOO} in addition to pkg-plist would be nicer IMO.

Agreed on that, but that requires some work on the framework which I will probably do later, if the use case becomes common ;)

Wed, Nov 6, 8:07 PM
jhb added a comment to D22251: libcompat: build 32-bit rtld and ldd as part of "everything".

If this permits easily doing something like 'make buildenv; cd rtld-elf32; make' then this really will be nicer than our current approach.

Wed, Nov 6, 7:53 PM
jhb accepted D22231: amd64: move common_tss into pcpu.
Wed, Nov 6, 7:46 PM
jhb added a comment to D22147: Add freebsd-gcc6 port..
In D22147#486621, @imp wrote:

Nothing caught my eye, though the PLIST is getting to be rather long and a bit of a PITA to deal with :(

Wed, Nov 6, 6:46 PM
jhb updated subscribers of D22147: Add freebsd-gcc6 port..

@brooks suggested he would consider merging the llvm-xtoolchain ports into the llvm ports as well. I think it is nice that you can 'pkg install <foo>' to get the bits for 'make CROSS_TOOLCHAIN=<foo>'

Wed, Nov 6, 6:45 PM
jhb retitled D22147: Add freebsd-gcc6 port. from Add freebsd-gcc6 and freebsd-xtoolchain-gcc6 ports. to Add freebsd-gcc6 port..
Wed, Nov 6, 6:44 PM