Page MenuHomeFreeBSD

jhb (John Baldwin)
User

Projects (7)

User Details

User Since
Mar 11 2014, 8:46 PM (248 w, 3 d)

Recent Activity

Yesterday

jhb accepted D18563: pmap_l1() won't return a NULL pointer..
Fri, Dec 14, 8:28 PM
jhb accepted D18562: Avoid needless TLB invalidations in pmap_remove_pages()..
Fri, Dec 14, 8:27 PM
jhb accepted D18561: Add some more checking to the page fault handler..
Fri, Dec 14, 8:25 PM
jhb accepted D18559: Enable WITNESS on RISC-V..
Fri, Dec 14, 8:23 PM
jhb accepted D18560: Add a QEMU config..
Fri, Dec 14, 8:22 PM
jhb accepted D18557: atomic_fcmpset* return int, not the type of *..

Same fixes as in rS332891 :)

Fri, Dec 14, 5:34 PM

Thu, Dec 13

jhb accepted D18464: Clean up initialization of phys_avail..

Sorry, I missed the last upload of this.

Thu, Dec 13, 10:04 PM

Wed, Dec 12

jhb added inline comments to D18534: Enable separate flavors for different python versions..
Wed, Dec 12, 11:16 PM
jhb created D18534: Enable separate flavors for different python versions..
Wed, Dec 12, 9:16 PM
jhb closed D18515: Fix packing list .pyc files when using Python 3.2+..
Wed, Dec 12, 5:35 PM
jhb committed rP487307: Fix packing list .pyc files when using Python 3.2+..
Fix packing list .pyc files when using Python 3.2+.
Wed, Dec 12, 5:35 PM

Tue, Dec 11

jhb added a comment to D18520: Update opencrypto for ZFS crypto.

It would be great to add "ccm" to tools/crypto/cryptocheck.c as well. It does comparisons of /dev/crypto vs OpenSSL's software algorithms. If the NIST-KAT tests include tests for AES-CCM it would also be good to update the nist-kat port to install those (if it doesn't already) and update the python opencrypto tests to run the CCM tests.

Tue, Dec 11, 11:17 PM
jhb created D18515: Fix packing list .pyc files when using Python 3.2+..
Tue, Dec 11, 6:01 PM
jhb added inline comments to D17874: libvmmapi: Separate MI from MD code.
Tue, Dec 11, 5:50 PM

Mon, Dec 10

jhb committed rS341802: Validate the string size parameter passed to -s..
Validate the string size parameter passed to -s.
Mon, Dec 10, 9:47 PM
jhb committed rS341800: Don't report stale signal information for non-signal events in ptrace_lwpinfo..
Don't report stale signal information for non-signal events in ptrace_lwpinfo.
Mon, Dec 10, 7:39 PM
jhb closed D18487: Don't report stale signal information for non-signal events in ptrace_lwpinfo..
Mon, Dec 10, 7:39 PM
jhb added a comment to D18481: rc.subr: Implement list_vars without using 'read'.

FWIW, this did fix the multi-hour delay in a formal model simulator.

Mon, Dec 10, 7:06 PM
jhb accepted D18486: Free bootstacks after AP startup..

I also think it is worth it.

Mon, Dec 10, 7:02 PM
jhb committed rP487193: Various fixes for GDB's data directory..
Various fixes for GDB's data directory.
Mon, Dec 10, 5:23 PM
jhb closed D18476: Various fixes for GDB's data directory..
Mon, Dec 10, 5:23 PM

Sun, Dec 9

jhb created D18487: Don't report stale signal information for non-signal events in ptrace_lwpinfo..
Sun, Dec 9, 12:41 AM

Fri, Dec 7

jhb added a comment to D18481: rc.subr: Implement list_vars without using 'read'.

FYI, this booted in a very simple MFS root (no real networking other than lo0)

Fri, Dec 7, 11:53 PM
jhb accepted D18461: Rename pmap_is_write() to pmap_l3_writable()..
Fri, Dec 7, 11:47 PM
jhb updated the summary of D18478: Reject new sessions if the necessary queues aren't initialized..
Fri, Dec 7, 7:36 PM
jhb created D18478: Reject new sessions if the necessary queues aren't initialized..
Fri, Dec 7, 7:29 PM
jhb created D18476: Various fixes for GDB's data directory..
Fri, Dec 7, 6:40 PM

Thu, Dec 6

jhb added inline comments to D18461: Rename pmap_is_write() to pmap_l3_writable()..
Thu, Dec 6, 11:13 PM
jhb added a comment to D18464: Clean up initialization of phys_avail..

This is inspired by PR 231515?

Thu, Dec 6, 11:08 PM
jhb accepted D18463: Update the description of the address space layout on RISC-V..
Thu, Dec 6, 10:51 PM
jhb accepted D18462: Rename sptbr to satp..
Thu, Dec 6, 10:49 PM
jhb added inline comments to D18461: Rename pmap_is_write() to pmap_l3_writable()..
Thu, Dec 6, 10:48 PM
jhb committed rS341656: Rename riscv64-freebsd.c to riscv-freebsd.c..
Rename riscv64-freebsd.c to riscv-freebsd.c.
Thu, Dec 6, 10:35 PM
jhb committed rP486773: Speed up devel/gdb startup on FreeBSD.
Speed up devel/gdb startup on FreeBSD
Thu, Dec 6, 5:56 PM
jhb closed D17426: Speed up devel/gdb startup on FreeBSD.
Thu, Dec 6, 5:56 PM

Wed, Dec 5

jhb accepted D18441: Further simplify arguments to init..

Thanks

Wed, Dec 5, 6:57 PM
jhb commandeered D17426: Speed up devel/gdb startup on FreeBSD.
Wed, Dec 5, 6:49 PM
jhb updated the diff for D17426: Speed up devel/gdb startup on FreeBSD.

Drop ChangeLog diff.

Wed, Dec 5, 6:48 PM

Sat, Dec 1

jhb added inline comments to D15469: Remove a needlessly clever hack to start init with sys_exec()..
Sat, Dec 1, 1:13 AM
jhb added inline comments to D15469: Remove a needlessly clever hack to start init with sys_exec()..
Sat, Dec 1, 12:11 AM

Fri, Nov 30

jhb added a reviewer for D17426: Speed up devel/gdb startup on FreeBSD: luca.pizzamiglio_gmail.com.
Fri, Nov 30, 11:25 PM
jhb updated the diff for D17426: Speed up devel/gdb startup on FreeBSD.
  • Use patch from upstream commit.
  • Bump PORTREVISION.
Fri, Nov 30, 11:25 PM
jhb added a comment to D17426: Speed up devel/gdb startup on FreeBSD.

I've merged a similar change upstream to gdb in commit 93579f6f90. We can pull that into the port as a commit-<foo> patch.

Fri, Nov 30, 11:22 PM
jhb accepted D16730: Committers Guide: Add a section encouraging pre-commit review..
Fri, Nov 30, 3:59 PM

Thu, Nov 29

jhb committed rS341270: Make most of the CLIP code conditional on #ifdef INET6..
Make most of the CLIP code conditional on #ifdef INET6.
Thu, Nov 29, 11:17 PM
jhb closed D18384: Make most of the CLIP code conditional on #ifdef INET6..
Thu, Nov 29, 11:17 PM
jhb created D18384: Make most of the CLIP code conditional on #ifdef INET6..
Thu, Nov 29, 11:04 PM
jhb committed rS341172: Move CLIP table handling out of TOM and into the base driver..
Move CLIP table handling out of TOM and into the base driver.
Thu, Nov 29, 1:17 AM
jhb closed D18010: Move CLIP table handling out of TOM and into the base driver..
Thu, Nov 29, 1:17 AM

Tue, Nov 27

jhb committed rS341098: Add read-only sysctls for all tunables in the cxgbe(4) driver..
Add read-only sysctls for all tunables in the cxgbe(4) driver.
Tue, Nov 27, 10:03 PM
jhb closed D18360: Add read-only sysctls for all tunables in the cxgbe(4) driver..
Tue, Nov 27, 10:03 PM
jhb accepted D18361: Improve sigonstack()..

One nit: s/sigaltstack/sigonstack/ in the commit message.

Tue, Nov 27, 7:37 PM
jhb added a comment to D18360: Add read-only sysctls for all tunables in the cxgbe(4) driver..

Some sample output:

Tue, Nov 27, 5:22 PM
jhb created D18360: Add read-only sysctls for all tunables in the cxgbe(4) driver..
Tue, Nov 27, 5:08 PM
jhb accepted D18354: Fix style nit.
Tue, Nov 27, 4:37 PM
jhb added a comment to D18347: Fix reporting of SS_ONSTACK.
In D18347#389943, @kib wrote:
In D18347#389623, @jhb wrote:

The difference is that the sigonstack() can override ss_flags. sendsig() functions call sigonstack() passing in the current stack pointer. I think this function tries to determine if the current stack pointer is already in the signal stack. If it is, it returns 0 to force a nested signal to use the normal thread stack instead of the signal stack.

Are you sure ? From my reading, it returns 1 if TDP_ALTSTACK is set _and_ current %sp is inside the alt stack address range. Well, it would be cleaner if the check was added for sp < ss_sp, otherwise it depends on ss_size comparision with unsigned overflow.

Tue, Nov 27, 4:01 PM

Mon, Nov 26

jhb added a comment to D18347: Fix reporting of SS_ONSTACK.

The difference is that the sigonstack() can override ss_flags. sendsig() functions call sigonstack() passing in the current stack pointer. I think this function tries to determine if the current stack pointer is already in the signal stack. If it is, it returns 0 to force a nested signal to use the normal thread stack instead of the signal stack.

Mon, Nov 26, 11:06 PM
jhb added a reviewer for D18347: Fix reporting of SS_ONSTACK: kib.
Mon, Nov 26, 10:49 PM
jhb added inline comments to D18349: Simplify some of the logic for external GCC toolchain packages..
Mon, Nov 26, 9:57 PM
jhb added a child revision for D18348: devel/i386-gcc: Remove spurious macro assignment.: D18349: Simplify some of the logic for external GCC toolchain packages..
Mon, Nov 26, 9:56 PM
jhb created D18349: Simplify some of the logic for external GCC toolchain packages..
Mon, Nov 26, 9:56 PM
jhb added a parent revision for D18349: Simplify some of the logic for external GCC toolchain packages.: D18348: devel/i386-gcc: Remove spurious macro assignment..
Mon, Nov 26, 9:56 PM
jhb created D18348: devel/i386-gcc: Remove spurious macro assignment..
Mon, Nov 26, 9:49 PM
jhb accepted D18311: Summary: acpi/ec: Fix regression caused by r340644.

So the device_disable() should have made the probe return of 0 vs ENXIO harmless since device_attach shouldn't have been called either way.

Mon, Nov 26, 7:00 PM

Sun, Nov 18

jhb committed rS340545: MFC 339312,339364: Restore more descriptors during VM exits..
MFC 339312,339364: Restore more descriptors during VM exits.
Sun, Nov 18, 1:07 AM
jhb committed rS340534: MFC 338511: bhyve: Use MAP_GUARD when mapping guest memory ranges..
MFC 338511: bhyve: Use MAP_GUARD when mapping guest memory ranges.
Sun, Nov 18, 12:11 AM

Fri, Nov 16

jhb committed rS340488: Axe MINIMUM_MSI_INT..
Axe MINIMUM_MSI_INT.
Fri, Nov 16, 11:40 PM
jhb closed D17991: Axe MINIMUM_MSI_INT..
Fri, Nov 16, 11:40 PM
jhb added a comment to D2549: Add missing pieces for mips32 gcc-4.9 kernel build!.

I've compiled kernels fine using mips-gcc. I've fixed the port to default to mips3 also, so I think this change is probably OBE. Also, march=mips32/64 is actually a much newer march than mips3.

Fri, Nov 16, 11:31 PM
jhb added a comment to D18010: Move CLIP table handling out of TOM and into the base driver..

Sample output:

Fri, Nov 16, 7:45 PM
jhb added a reviewer for D18010: Move CLIP table handling out of TOM and into the base driver.: krishna2_chelsio.com.
Fri, Nov 16, 7:41 PM
jhb created D18010: Move CLIP table handling out of TOM and into the base driver..
Fri, Nov 16, 7:40 PM
jhb committed rS340486: Consolidate on a single set of constants for SCMD fields..
Consolidate on a single set of constants for SCMD fields.
Fri, Nov 16, 7:09 PM
jhb updated the diff for D17991: Axe MINIMUM_MSI_INT..
  • Add a read-only sysctl for first_msi_irq.
Fri, Nov 16, 5:58 PM
jhb committed rS340473: Restore the <sys/vmem.h> header to fix build of cxgbe(4) TOM..
Restore the <sys/vmem.h> header to fix build of cxgbe(4) TOM.
Fri, Nov 16, 1:27 AM

Thu, Nov 15

jhb committed rS340469: Remove bogus roundup2() of the key programming work request header..
Remove bogus roundup2() of the key programming work request header.
Thu, Nov 15, 11:31 PM
jhb committed rS340468: Change the quantum for TLS key addresses to 32 bytes..
Change the quantum for TLS key addresses to 32 bytes.
Thu, Nov 15, 11:10 PM
jhb committed rS340466: Move the TLS key map into the adapter softc so non-TOE code can use it..
Move the TLS key map into the adapter softc so non-TOE code can use it.
Thu, Nov 15, 11:00 PM
jhb committed rS340465: Use sbsndptr_adv() instead of sbsndptr() for TOE TLS..
Use sbsndptr_adv() instead of sbsndptr() for TOE TLS.
Thu, Nov 15, 10:47 PM
jhb abandoned D2559: Add initial process/thread NUMA policy configuration and management utility.

This was committed in the noted commit.

Thu, Nov 15, 9:30 PM
jhb commandeered D2559: Add initial process/thread NUMA policy configuration and management utility.
Thu, Nov 15, 9:29 PM
jhb added 1 commit(s) for D2559: Add initial process/thread NUMA policy configuration and management utility: rS285387: Add an initial NUMA affinity/policy configuration for threads and processes..
Thu, Nov 15, 9:28 PM
jhb added an edge to rS285387: Add an initial NUMA affinity/policy configuration for threads and processes.: D2559: Add initial process/thread NUMA policy configuration and management utility.
Thu, Nov 15, 9:28 PM
jhb added a comment to D17675: Suspend to idle support.

Is this one ready to be reviewed?

Thu, Nov 15, 6:57 PM
jhb accepted D16635: Summary: acpi: fix acpi_ec_probe to only check EC devices.
Thu, Nov 15, 6:51 PM
jhb committed rS340460: Convert the number of MSI IRQs on x86 from a constant to a tunable..
Convert the number of MSI IRQs on x86 from a constant to a tunable.
Thu, Nov 15, 6:38 PM
jhb closed D17977: Convert the number of MSI IRQs on x86 from a constant to a tunable..
Thu, Nov 15, 6:38 PM

Nov 14 2018

jhb updated the diff for D17991: Axe MINIMUM_MSI_INT..

Rebase.

Nov 14 2018, 8:32 PM
jhb updated the diff for D17977: Convert the number of MSI IRQs on x86 from a constant to a tunable..
  • Adjust other overflow checks.
Nov 14 2018, 8:22 PM
jhb added a comment to D17991: Axe MINIMUM_MSI_INT..

It is perhaps debatable if we want this change since it will change the IRQ values users see (and users might be used to >= 256 meaning MSI), and I probably won't MFC it if we do decide we want it in HEAD for those reasons.

Nov 14 2018, 8:05 PM
jhb created D17991: Axe MINIMUM_MSI_INT..
Nov 14 2018, 8:04 PM
jhb added inline comments to D17977: Convert the number of MSI IRQs on x86 from a constant to a tunable..
Nov 14 2018, 7:43 PM
jhb updated the diff for D17977: Convert the number of MSI IRQs on x86 from a constant to a tunable..
  • Rework the Xen overflow check due to size_t promotion.
Nov 14 2018, 7:42 PM
jhb added inline comments to D17977: Convert the number of MSI IRQs on x86 from a constant to a tunable..
Nov 14 2018, 7:18 PM
jhb updated the diff for D17977: Convert the number of MSI IRQs on x86 from a constant to a tunable..
  • Fixes from markj.
  • Add overflow checks.
Nov 14 2018, 7:16 PM
jhb added inline comments to D17977: Convert the number of MSI IRQs on x86 from a constant to a tunable..
Nov 14 2018, 7:16 PM
jhb committed rS340441: Revert r332735 and fix MSI-X to properly fail allocations when full..
Revert r332735 and fix MSI-X to properly fail allocations when full.
Nov 14 2018, 6:45 PM
jhb closed D17976: Revert r332735 and fix MSI-X to properly fail allocations when full..
Nov 14 2018, 6:45 PM
jhb added a comment to D17860: <<Two NVMe Bootup hang>.

I agree that this seems like a workaround for some other problem. Without EARLY_AP_STARTUP the IRQs aren't actually moved until much later during boot (the late SI_SUB_SMP), so you can only see this earlier in boot if EARLY_AP_STARTUP is enabled, but then sched_bind should work fine. Useful strategies for debugging this would be to add KTR to your kernel config and break into DDB when it hangs and examine KTR traces. KTR_INTR and KTR_PROC are probably the useful masks to trace.

Nov 14 2018, 5:28 PM

Nov 13 2018

jhb added inline comments to D17940: x86/acpica/srat.c: Add API for parsing proximity tables.
Nov 13 2018, 7:24 PM · arm64