jhb (John Baldwin)
User

Projects (7)

User Details

User Since
Mar 11 2014, 8:46 PM (227 w, 1 d)

Recent Activity

Mon, Jul 16

jhb added a comment to D14621: Fix a potential use after free in getsockopt() access to inp_options.

I think this looks fine of course since it is what I suggested (:-P), but would prefer to have someone else from transport sign off on it as well.

Mon, Jul 16, 5:03 PM
jhb accepted D16264: Retrospectively document SVN branch points for stable-11 and its releases..
Mon, Jul 16, 4:43 PM
jhb accepted D16262: Retrospectively document SVN branch point for stable-11.
Mon, Jul 16, 4:42 PM
jhb accepted D16263: Retrospectively document SVN branch point for stable-10 and its releases..
Mon, Jul 16, 4:42 PM

Fri, Jul 13

jhb added a comment to D15917: uefi stand: Guess the console better.

I think this is ok as far as I can tell.

Fri, Jul 13, 10:14 PM
jhb added a comment to D16199: Address the COW problem in pmap_enter() on mips.

My usage of MIPS is confined to qemu for CHERI stuff. CheriBSD has various pmap changes for MIPS though none that fix the issue kib@ noted. In particular CheriBSD has a new map for mips64 that is derived from the amd64 pmap and supports superpages. It also supports using large pages for the kstack which is really needed for newer compilers which bloat kstack usage. (Though one thing that isn't clear to me is why we don't just contigalloc kstacks for mips and then use kseg0 addresses rather than relying on pinned TLB entries for the kstack?)

Fri, Jul 13, 9:42 PM

Thu, Jul 12

jhb created D16250: Add support for amd64 and i386 to base/binutils and base/gcc..
Thu, Jul 12, 8:10 PM
jhb added a comment to D16228: Add ports for an i386 external GCC toolchain..

Update: I've done a buildworld (though newer gcc is pickier about some things that I need to post some src patches for review) and have built base/binutils and base/gcc using this as a CROSS_TOOLCHAIN.

Thu, Jul 12, 6:42 PM
jhb added inline comments to D16228: Add ports for an i386 external GCC toolchain..
Thu, Jul 12, 4:38 PM
jhb added inline comments to D16228: Add ports for an i386 external GCC toolchain..
Thu, Jul 12, 4:11 PM

Wed, Jul 11

jhb added reviewers for D16073: Drop builtin float.h for amd64-gcc.: bapt, bdrewery.
Wed, Jul 11, 5:02 PM
jhb updated the diff for D16073: Drop builtin float.h for amd64-gcc..
  • Rework to explicitly remove this header so that this is check-plist friendly.
  • Bump portrevision.
Wed, Jul 11, 5:02 PM
jhb committed rP474469: Enable .init_array and .fini_array with xtoolchain GCC..
Enable .init_array and .fini_array with xtoolchain GCC.
Wed, Jul 11, 4:50 PM
jhb closed D16014: Enable .init_array and .fini_array with xtoolchain GCC..
Wed, Jul 11, 4:50 PM
jhb added a dependency for D16228: Add ports for an i386 external GCC toolchain.: D16227: devel/powerpc64-gcc: Properly set CONFIGURE_TARGET for when amd64 is either the host or target..
Wed, Jul 11, 4:36 PM
jhb added a dependent revision for D16227: devel/powerpc64-gcc: Properly set CONFIGURE_TARGET for when amd64 is either the host or target.: D16228: Add ports for an i386 external GCC toolchain..
Wed, Jul 11, 4:36 PM
jhb created D16228: Add ports for an i386 external GCC toolchain..
Wed, Jul 11, 4:36 PM
jhb created D16227: devel/powerpc64-gcc: Properly set CONFIGURE_TARGET for when amd64 is either the host or target..
Wed, Jul 11, 4:31 PM
jhb committed rP474460: Remove an unused variable..
Remove an unused variable.
Wed, Jul 11, 4:23 PM
jhb closed D16213: devel/amd64-binutils: Remove an unused variable..
Wed, Jul 11, 4:23 PM
jhb added a comment to D16013: devel/gdb: Fixes for kgdb including initial FreeBSD/arm support..

Normally @pizzamig is quite responsive on reviews for devel/gdb, so I wonder if he might be on vacation or some such?

Wed, Jul 11, 4:00 PM
jhb accepted D16211: run(4): Add a new USB device ID..

You can put 'Approved by: jhb' and I'll take any fallout. Ed is on vacation this week AFAIK.

Wed, Jul 11, 1:20 AM
jhb updated the diff for D16014: Enable .init_array and .fini_array with xtoolchain GCC..
  • Don't enable init_array/fini_array for arm-none-eabi-gcc and aarch64-none-elf-gcc.
Wed, Jul 11, 1:05 AM
jhb updated the summary of D16014: Enable .init_array and .fini_array with xtoolchain GCC..
Wed, Jul 11, 12:56 AM

Tue, Jul 10

jhb created D16213: devel/amd64-binutils: Remove an unused variable..
Tue, Jul 10, 11:25 PM
jhb added a comment to D14248: Make sys/mips/include/stdarg.h compatible with clang's builtin headers.

I think this one can be abandoned now?

Tue, Jul 10, 9:20 PM
jhb accepted D15931: Add LPIT parsing to acpidump.

Don't forget to update the date (Dd) in the manpage before committing. I would probably not include the sample output in the commit message but instead send a reply e-mail to the commit mail that includes the sample output. For future reference, jkim@ is probably a good person to add on any ACPI-related reviews.

Tue, Jul 10, 9:19 PM
jhb accepted D16161: Improve bhyve exit(3) error code..

Oof, I failed to realize that some of these errors are not startup related, so maybe just '4 exited due to an error' in the manpage. I do think the earlier changes to use err() were also good changes, I would just stick with '4' for the exit value. However, if you want to commit this as-is for now and adopt err() in place of fprintf/perror + exit as a later change that is ok with me as well. This is fine with me with the manpage tweak (or some similar tweak).

Tue, Jul 10, 9:17 PM

Mon, Jul 9

jhb added inline comments to D15919: msun: add ld80/ld128 powl, cpow, cpowf, cpowl from openbsd.
Mon, Jul 9, 11:46 PM
jhb added a comment to D16161: Improve bhyve exit(3) error code..

err(errno) is probably not going to work well. For example ENOENT is 2 which maps to "2 halted" in the manpage.

Mon, Jul 9, 10:22 PM
jhb committed rD51984: Tidy the core alumni list..
Tidy the core alumni list.
Mon, Jul 9, 7:50 PM

Fri, Jul 6

jhb committed rS336053: Export a breakpoint() function to userland for arm and arm64..
Export a breakpoint() function to userland for arm and arm64.
Fri, Jul 6, 11:49 PM
jhb closed D15191: Export a breakpoint() function to userland..
Fri, Jul 6, 11:49 PM
jhb added a comment to D16013: devel/gdb: Fixes for kgdb including initial FreeBSD/arm support..

Ping

Fri, Jul 6, 4:54 PM

Thu, Jul 5

jhb added inline comments to D15919: msun: add ld80/ld128 powl, cpow, cpowf, cpowl from openbsd.
Thu, Jul 5, 2:51 PM

Tue, Jul 3

jhb created D16119: emulators/virtualbox-ose-kmod: Tie the virtualbox kernel module to a specific release branch..
Tue, Jul 3, 11:26 PM
jhb added inline comments to D15933: Back pcpu zone with domain correct pages.
Tue, Jul 3, 11:15 PM
jhb committed rS335913: Use 'e' instead of 'i' constraints with 64-bit atomic operations on amd64..
Use 'e' instead of 'i' constraints with 64-bit atomic operations on amd64.
Tue, Jul 3, 10:03 PM
jhb added a comment to D12298: libc: remove gets.

Can this be committed already? :)

Tue, Jul 3, 6:27 PM
jhb committed rS335898: Clean up the vcs ID strings in libc's gen/ directory..
Clean up the vcs ID strings in libc's gen/ directory.
Tue, Jul 3, 5:32 PM
jhb closed D15831: Clean up the vcs ID strings in libc's gen/ directory..
Tue, Jul 3, 5:32 PM
jhb committed rP473849: Make devel/riscv64-binutils a slave of devel/binutils..
Make devel/riscv64-binutils a slave of devel/binutils.
Tue, Jul 3, 5:25 PM
jhb closed D16053: Make devel/riscv64-binutils a slave of devel/binutils..
Tue, Jul 3, 5:25 PM
jhb closed D15830: Strip __RCSID() and __SCCSID() strings by default when building libc..
Tue, Jul 3, 4:46 PM
jhb committed rS335897: Strip __RCSID() and __SCCSID() strings by default when building libc..
Strip __RCSID() and __SCCSID() strings by default when building libc.
Tue, Jul 3, 4:46 PM
jhb committed rS335892: Don't specify the desired march/mabi for RISC-V in ACFLAGS..
Don't specify the desired march/mabi for RISC-V in ACFLAGS.
Tue, Jul 3, 3:24 PM
jhb closed D16054: Don't specify the desired march/mabi for RISC-V in ACFLAGS..
Tue, Jul 3, 3:24 PM
jhb accepted D16091: Committer guide: avoid confusing maintainers with hats.
Tue, Jul 3, 2:50 PM
jhb added inline comments to D16091: Committer guide: avoid confusing maintainers with hats.
Tue, Jul 3, 2:50 PM

Mon, Jul 2

jhb added a reviewer for D16100: Raise a proper SIGTRAP / TRAP_TRACE signal for a PT_STEP step on arm.: ARM.
Mon, Jul 2, 6:13 PM
jhb added a comment to D15191: Export a breakpoint() function to userland..

Have verified via ptrace_test on arm64 as well now, so both arm and arm64 have been runtime tested.

Mon, Jul 2, 6:12 PM
jhb added a comment to D16091: Committer guide: avoid confusing maintainers with hats.

I think this page might have referred to some of these folks in the past, but those individuals have been purged by now (at least the ones mentioned explicitly in the text). Do we have any other references to things like re@ owning release branches (and other branches during freezes?) or secteam@ owning certain parts of the tree?

Mon, Jul 2, 6:10 PM
jhb added inline comments to D16090: Comitter guide: rewrite the section on testing..
Mon, Jul 2, 6:06 PM
jhb accepted D16089: committer guide: update rules for contrib software..

I would also add a bullet in the commit log to say "Remove comments specific to CVS". Taking files off of the vendor branch and some of the other language was CVS specific and it's good that you are removing it.

Mon, Jul 2, 5:53 PM
jhb created D16100: Raise a proper SIGTRAP / TRAP_TRACE signal for a PT_STEP step on arm..
Mon, Jul 2, 5:44 PM
jhb added a comment to D16054: Don't specify the desired march/mabi for RISC-V in ACFLAGS..

I've reworked this change to just remove ACFLAGS instead. No other platforms set anything in ACFLAGS in bsd.cpu.mk so I think this is more consistent. We could perhaps set AFLAGS, but I don't think anything uses AFLAGS in the tree, so I'd rather wait to add that until a real need arises.

Mon, Jul 2, 5:05 PM
jhb retitled D16054: Don't specify the desired march/mabi for RISC-V in ACFLAGS. from Specify the desired march/mabi for RISC-V in ACFLAGS as well. to Don't specify the desired march/mabi for RISC-V in ACFLAGS..
Mon, Jul 2, 5:02 PM
jhb updated the diff for D16054: Don't specify the desired march/mabi for RISC-V in ACFLAGS..
  • Drop ACFLAGS entirely.
Mon, Jul 2, 4:59 PM
jhb added a comment to D16053: Make devel/riscv64-binutils a slave of devel/binutils..

I don't think we need the STATIC thing, and it's not really clear to me why aarch64 needs it either (supposedly something to do with cross-building under poudriere who I heard from someone (but I can't remember who) and the reasoning seemed a bit dubious).

Mon, Jul 2, 4:57 PM
jhb updated the diff for D16053: Make devel/riscv64-binutils a slave of devel/binutils..
  • Update pkg-plist to fix orphans
Mon, Jul 2, 4:55 PM

Fri, Jun 29

jhb updated the diff for D15191: Export a breakpoint() function to userland..
  • Updated to use 'udf' on 32-bit arm and tested on 32-bit arm.
  • Still need to verify arm64.
Fri, Jun 29, 9:23 PM
jhb created D16073: Drop builtin float.h for amd64-gcc..
Fri, Jun 29, 8:38 PM
jhb added inline comments to D16014: Enable .init_array and .fini_array with xtoolchain GCC..
Fri, Jun 29, 6:40 PM
jhb updated the diff for D16014: Enable .init_array and .fini_array with xtoolchain GCC..
  • Make init/fini conditional on OSVERSION for base/gcc.
  • Add PORTREVISION bumps.
Fri, Jun 29, 6:39 PM
jhb closed D15813: Use a unified packing list for base/binutils..
Fri, Jun 29, 6:11 PM
jhb added an edge to rP473568: Use a unified packing list for base/binutils.: D15813: Use a unified packing list for base/binutils..
Fri, Jun 29, 6:11 PM
jhb added 1 commit(s) for D15813: Use a unified packing list for base/binutils.: rP473568: Use a unified packing list for base/binutils..
Fri, Jun 29, 6:11 PM
jhb committed rP473568: Use a unified packing list for base/binutils..
Use a unified packing list for base/binutils.
Fri, Jun 29, 6:07 PM
jhb updated the diff for D16053: Make devel/riscv64-binutils a slave of devel/binutils..

Remove pkg-descr and distinfo.

Fri, Jun 29, 5:58 PM
jhb added a comment to D16054: Don't specify the desired march/mabi for RISC-V in ACFLAGS..

Actually, I wonder if ACFLAGS shouldn't be removed from bsd.cpu.mk instead. ACFLAGS is always included in addition CFLAGS, so the settings in ACFLAGS are redundant with CFLAGS in bsd.cpu.mk. (There is a separate AFLAGS for flags passed to a standalone assembler. Perhaps the ACFLAGS in bsd.cpu.mk was supposed to be AFLAGS instead?)

Fri, Jun 29, 3:45 PM
jhb added a comment to D16053: Make devel/riscv64-binutils a slave of devel/binutils..

I believe the pkg-plist is still correct? All the other devel/<foo>-binutils ports use their own pkg-plist as well.

Fri, Jun 29, 3:22 PM

Thu, Jun 28

jhb committed rS335783: Support 2GB of memory on Malta systems with FreeBSD/mips..
Support 2GB of memory on Malta systems with FreeBSD/mips.
Thu, Jun 28, 9:27 PM
jhb closed D16027: Support 2GB of memory on Malta systems with FreeBSD/mips..
Thu, Jun 28, 9:27 PM
jhb committed rS335782: Remove the various build flag hacks for GCC cross-compile..
Remove the various build flag hacks for GCC cross-compile.
Thu, Jun 28, 9:26 PM
jhb closed D16055: Remove the various build flag hacks for GCC cross-compile..
Thu, Jun 28, 9:26 PM
jhb added inline comments to D16055: Remove the various build flag hacks for GCC cross-compile..
Thu, Jun 28, 9:20 PM
jhb created D16055: Remove the various build flag hacks for GCC cross-compile..
Thu, Jun 28, 8:21 PM
jhb added a comment to D16053: Make devel/riscv64-binutils a slave of devel/binutils..

The build failure is fixed by D16054.

Thu, Jun 28, 8:10 PM
jhb added a dependency for D16053: Make devel/riscv64-binutils a slave of devel/binutils.: D16054: Don't specify the desired march/mabi for RISC-V in ACFLAGS..
Thu, Jun 28, 8:10 PM
jhb added a dependent revision for D16054: Don't specify the desired march/mabi for RISC-V in ACFLAGS.: D16053: Make devel/riscv64-binutils a slave of devel/binutils..
Thu, Jun 28, 8:10 PM
jhb created D16054: Don't specify the desired march/mabi for RISC-V in ACFLAGS..
Thu, Jun 28, 8:09 PM
jhb added a comment to D16053: Make devel/riscv64-binutils a slave of devel/binutils..

So it seems that .S files built as part of the kernel use a special rule from config(8) that doesn't include ACFLAGS, but .S files built as part of a kernel module do honor ACFLAGS. I'm testing a fix to sys/conf/kern.mk to append the same soft-float march/mabi lines to ACFLAGS that we currently append to CFLAGS.gcc. Not sure why the old binutils didn't flag this, maybe it was just less picky about the ABIs matching and this is fixed in the newer binutils.

Thu, Jun 28, 7:32 PM
jhb added a comment to D16053: Make devel/riscv64-binutils a slave of devel/binutils..

So comparing the compile output lines, dtrace.o uses '-mabi=lp64' from CFLAGS. dtrace_asm.o includes a second set of -march/-mabi (presumably from AFLAGS) that uses -mabi=lp64d

Thu, Jun 28, 7:18 PM
jhb added a comment to D16053: Make devel/riscv64-binutils a slave of devel/binutils..

Details on the error I get from the kernel build:

Thu, Jun 28, 7:17 PM
jhb created D16053: Make devel/riscv64-binutils a slave of devel/binutils..
Thu, Jun 28, 7:09 PM
jhb added inline comments to D15919: msun: add ld80/ld128 powl, cpow, cpowf, cpowl from openbsd.
Thu, Jun 28, 6:48 PM
jhb committed rS335769: Include existing MAKE_PARAMS_<target> when determining the universe toolchain..
Include existing MAKE_PARAMS_<target> when determining the universe toolchain.
Thu, Jun 28, 6:20 PM
jhb closed D16049: Include existing MAKE_PARAMS_<target> when determining the universe toolchain..
Thu, Jun 28, 6:20 PM
jhb added a comment to D16049: Include existing MAKE_PARAMS_<target> when determining the universe toolchain..

While my tinderbox is still running, the riscv64 buildworld is now compiling things with the right compiler (previously it died trying to compile the very first thing in libcompiler_rt and it's beyond that stage now)

Thu, Jun 28, 5:42 PM
jhb updated subscribers of D16049: Include existing MAKE_PARAMS_<target> when determining the universe toolchain..
Thu, Jun 28, 5:41 PM
jhb created D16049: Include existing MAKE_PARAMS_<target> when determining the universe toolchain..
Thu, Jun 28, 5:18 PM

Wed, Jun 27

jhb committed rS335717: Fix GCC 4.2.1 to honor --sysroot for includes..
Fix GCC 4.2.1 to honor --sysroot for includes.
Wed, Jun 27, 6:14 PM
jhb closed D15127: Fix GCC 4.2.1 to honor --sysroot for includes..
Wed, Jun 27, 6:14 PM
jhb committed rS335716: Don't hardcode the TOOLS_PREFIX for the startfiles directories..
Don't hardcode the TOOLS_PREFIX for the startfiles directories.
Wed, Jun 27, 6:11 PM
jhb closed D14780: Don't hardcode the TOOLS_PREFIX for the startfiles directories..
Wed, Jun 27, 6:11 PM
jhb added inline comments to D15127: Fix GCC 4.2.1 to honor --sysroot for includes..
Wed, Jun 27, 3:47 PM
jhb added a comment to D16027: Support 2GB of memory on Malta systems with FreeBSD/mips..
In D16027#339568, @kib wrote:

Where the overflow occurs ? In this line ?

		phys_avail[3] = 0x90000000 + (ememsize - memsize);
Wed, Jun 27, 3:38 PM

Tue, Jun 26

jhb created D16027: Support 2GB of memory on Malta systems with FreeBSD/mips..
Tue, Jun 26, 11:44 PM
jhb added a comment to D16014: Enable .init_array and .fini_array with xtoolchain GCC..

Yes, they probably will need those. I wanted to get feedback for the idea of how these are enabled (if we wanted to do something with OSVERSION, etc.) first and then add the bumps to the final candidate patch.

Tue, Jun 26, 7:26 PM
jhb created D16014: Enable .init_array and .fini_array with xtoolchain GCC..
Tue, Jun 26, 12:34 AM