Page MenuHomeFreeBSD

jhb (John Baldwin)
User

Projects (8)

User Details

User Since
Mar 11 2014, 8:46 PM (288 w, 7 h)

Recent Activity

Mon, Sep 16

jhb accepted D21661: Support EARLY_AP_STARTUP on RISC-V.
Mon, Sep 16, 8:00 AM

Fri, Sep 13

jhb retitled D21444: Disable REPRODUCIBLE_BUILD for kernel builds. from Revert r350550 and disable REPRODUCIBLE_BUILD for kernel builds. to Disable REPRODUCIBLE_BUILD for kernel builds..
Fri, Sep 13, 5:06 AM
jhb updated the diff for D21444: Disable REPRODUCIBLE_BUILD for kernel builds..
  • Drop src.opts.mk change.
Fri, Sep 13, 5:05 AM
jhb added a comment to D21547: ix, ixv: Read msix_bar from device configuration.

If the BAR varies across devices, I think using pci_msix_table_bar is probably the simplest thing to do.

Fri, Sep 13, 5:03 AM
jhb added a comment to D17884: Mapping the EFI frame buffer with the WriteCombined memory type can cause packet loss.

I think what we want to do is have a loader tunable to control this. We probably want to default to WC still, but a loader tunable makes it easy to toggle this for cases that need UC instead.

Fri, Sep 13, 4:27 AM
jhb added a comment to D20973: bhyve: support for enabling/disabling the net backend.

So I don't see any uses of mevent_add_disabled() in this change? If that is used in a future change it might be best to defer that to the future change and just add the new hook(s) in the backend interface for now?

Fri, Sep 13, 4:27 AM

Wed, Sep 11

jhb created D21608: Disable build of LOCAL_MODULES for cross-builds by default..
Wed, Sep 11, 7:09 PM

Sat, Aug 31

jhb added a comment to D21446: New port: security/ktls_isa-l_crypto..
  • Use bsd.post.port.mk at bottom.
  • Add missing svn props on intel_isakern.c.
Sat, Aug 31, 12:12 AM

Fri, Aug 30

D21446: New port: security/ktls_isa-l_crypto. now requires review to proceed.
  • Use LOCALBASE for yasm.
  • Make portlint mostly happy.
  • Use IGNORE instead of BROKEN.
  • Use PLIST_FILES instead of 1-line pkg-plist.
Fri, Aug 30, 10:22 PM
jhb added inline comments to D21446: New port: security/ktls_isa-l_crypto..
Fri, Aug 30, 9:41 PM
jhb added inline comments to D21461: Add ability to fetch kernel threads from cores in kvm_getprocs in libkvm.
Fri, Aug 30, 9:39 PM
jhb committed rS351625: Add entries for unmapped mbufs and KTLS..
Add entries for unmapped mbufs and KTLS.
Fri, Aug 30, 4:30 PM

Thu, Aug 29

jhb added a comment to D21461: Add ability to fetch kernel threads from cores in kvm_getprocs in libkvm.

Does this fix anything in the base system? I thought 'ps H' worked on vmcores already? Hmm, just tried it on one and indeed it does not.

Thu, Aug 29, 8:55 PM
jhb closed D20365: simplify bhyve vlapic ESR logic.
Thu, Aug 29, 6:23 PM · bhyve
jhb committed rS351609: Simplify bhyve vlapic ESR logic..
Simplify bhyve vlapic ESR logic.
Thu, Aug 29, 6:23 PM

Wed, Aug 28

jhb committed rS351591: Use get_pcpu() to fetch the current CPU's pcpu pointer..
Use get_pcpu() to fetch the current CPU's pcpu pointer.
Wed, Aug 28, 11:41 PM

Tue, Aug 27

jhb created D21446: New port: security/ktls_isa-l_crypto..
Tue, Aug 27, 10:54 PM
jhb created D21444: Disable REPRODUCIBLE_BUILD for kernel builds..
Tue, Aug 27, 10:26 PM
jhb committed rS351558: Only define the 'tls' member of sfio in KERN_TLS is defined..
Only define the 'tls' member of sfio in KERN_TLS is defined.
Tue, Aug 27, 10:21 PM
jhb committed rS351557: Adjust the deprecated warnings for /dev/crypto to be less noisy..
Adjust the deprecated warnings for /dev/crypto to be less noisy.
Tue, Aug 27, 9:29 PM
jhb closed D21277: Add kernel-side support for in-kernel TLS..
Tue, Aug 27, 12:39 AM
D21277: Add kernel-side support for in-kernel TLS. is now accepted and ready to land.
Tue, Aug 27, 12:39 AM
jhb committed rS351523: MFC 349474: Reject attempts to register a TCP stack being unloaded..
MFC 349474: Reject attempts to register a TCP stack being unloaded.
Tue, Aug 27, 12:29 AM
jhb committed rS351522: Add kernel-side support for in-kernel TLS..
Add kernel-side support for in-kernel TLS.
Tue, Aug 27, 12:02 AM

Mon, Aug 26

D21277: Add kernel-side support for in-kernel TLS. now requires review to proceed.
  • Rebasing on today's head.
Mon, Aug 26, 11:52 PM
jhb added a comment to D21421: Split out a more generic panicnet(4) from netdump(4).

Is the intention to support remote GDB over this? If so, that seems super nifty. My only question is on the name. If this is truly restricted to only be used during panics, then panicnet is fine. OTOH, if you could use this even on a non-panicked machine (e.g. if you could configure a dedicated interface that you could attach remote GDB to or that you could send netdumps over from DDB via 'dump' before doing a continue), then maybe something like 'debugnet' is more apt?

Mon, Aug 26, 5:36 PM
jhb committed rS351513: Stop using des_cblock * for arguments to DES functions..
Stop using des_cblock * for arguments to DES functions.
Mon, Aug 26, 5:25 PM
Herald added a reviewer for D21389: Stop using des_cblock * for arguments to DES functions.: jmg.
Mon, Aug 26, 5:25 PM
jhb added inline comments to D21359: Define PCIV_INTEL and use it where drivers and other things use ad-hoc definitions of this..
Mon, Aug 26, 5:07 PM
D21387: cxgbe/t4_tom: Initialize all TOE connection parameters in one place. is now accepted and ready to land.

This looks ok to me. I assume you've tested DDP and TLS?

Mon, Aug 26, 5:01 PM
jhb added inline comments to D21418: Centralize __pcpu definitions..
Mon, Aug 26, 4:55 PM
jhb added inline comments to D21389: Stop using des_cblock * for arguments to DES functions..
Mon, Aug 26, 4:52 PM

Sat, Aug 24

jhb committed rS351449: MFC 350551:.
MFC 350551:
Sat, Aug 24, 12:36 AM
jhb created D21389: Stop using des_cblock * for arguments to DES functions..
Sat, Aug 24, 12:11 AM

Fri, Aug 23

jhb committed rS351439: MFC 339432: Do not flush cache for PCIe config window..
MFC 339432: Do not flush cache for PCIe config window.
Fri, Aug 23, 10:04 PM
jhb closed D21264: Fix universe to include arm LINT kernel configs..
Fri, Aug 23, 6:26 PM
jhb committed rS351434: Fix universe to include arm LINT kernel configs..
Fix universe to include arm LINT kernel configs.
Fri, Aug 23, 6:26 PM
D21382: It turns out the duplication is only mostly harmless. is now accepted and ready to land.

This stuff is a bit too fragile in general, but if I fixed it, I would do a larger rototill by having MODUL_DEPEND only specify the version it is compiled against and then having modules advertise the versions they have compatible shims for (so instead of modules trying to guess a __FreeBSD_version range of kernels they are compatible with, the kernel would say which range of values it could handle modules from, and to handle things like virtual box and drm-kmod that want to use VM internals we might have a freebsd_vm "module" for which kernels advertise a smaller compatible range).

Fri, Aug 23, 5:48 PM
D21378: Turn off -Werror for gcc 4.2.1 is now accepted and ready to land.
Fri, Aug 23, 3:51 PM
jhb added a comment to D21277: Add kernel-side support for in-kernel TLS..

https://github.com/openssl/openssl/compare/OpenSSL_1_1_1-stable...bsdjhb:kern_tls_1_1_1 contains patches close to what has been used previously in production but updated against changes made while upstreaming. It is not against a FreeBSD source tree, but against openssl directly.

Fri, Aug 23, 12:46 AM

Thu, Aug 22

jhb added a comment to D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED..

I think add a comment as @mjg requests and the existing patch is good to go. Thanks Xin Li!

Thu, Aug 22, 11:18 PM
jhb accepted D21330: mips: hide regnum definitions behind _KERNEL/_WANT_MIPS_REGNUM.
Thu, Aug 22, 8:33 PM
jhb added inline comments to D21330: mips: hide regnum definitions behind _KERNEL/_WANT_MIPS_REGNUM.
Thu, Aug 22, 6:46 PM
jhb added a comment to D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED..
In D21362#464861, @mjg wrote:

All other routines are read-write and I presume should translate automatically. Looks like everything is just redefined in terms LA_ macros anyway. If they are to mix, what's the point of having all the redefinitions?

Thu, Aug 22, 6:44 PM
jhb added a comment to D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED..
In D21362#464856, @cem wrote:
In D21362#464855, @jhb wrote:
In D21362#464773, @mjg wrote:

I disagree with mixing up LA_ and MA_ namespaces.

This is to avoid having lookup tables in every single lc_assert method.

Thanks, I was also curious about the motivation / context for the change.

The linux lockdep API assumes LA_LOCKED semantics (meaning either a shared lock or write lock is ok). lc_assert isn't widely used in the tree, so this just hasn't been hit before.

Would it make more sense to add a LC_SHARED to lock_class::lc_flags and define a short wrapper in sys/lock.h?

static inline void
lock_assert(const struct lock_object *lo, int la_what)
{
    if ((lo->lc_flags & LC_SHARED) == 0 && (la_what & LA_LOCKED) != 0) {
        la_what &= ~LA_LOCKED;
        la_what |= LA_XLOCKED;
    }
    lo->lc_assert(lo, la_what);
}
Thu, Aug 22, 6:39 PM
jhb added inline comments to D21330: mips: hide regnum definitions behind _KERNEL/_WANT_MIPS_REGNUM.
Thu, Aug 22, 5:05 PM
jhb added a comment to D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED..
In D21362#464773, @mjg wrote:

I disagree with mixing up LA_ and MA_ namespaces.

Thu, Aug 22, 4:51 PM
jhb added a comment to D21362: assert_mtx: treat LA_LOCKED as the same of LA_XLOCKED..

I would just use hselasky's approach of extending the case statements, but this is also ok.

Thu, Aug 22, 4:47 PM
jhb committed rS351364: Use 'const' for keys and IVs passed to software encryption algorithms..
Use 'const' for keys and IVs passed to software encryption algorithms.
Thu, Aug 22, 12:02 AM
Herald added a reviewer for D21347: Use 'const' for keys and IVs passed to software encryption algorithms.: jmg.
Thu, Aug 22, 12:02 AM

Wed, Aug 21

jhb committed rS351362: MFC 350666:.
MFC 350666:
Wed, Aug 21, 11:45 PM
jhb added a comment to D21264: Fix universe to include arm LINT kernel configs..

Ping

Wed, Aug 21, 10:44 PM
jhb committed rS351358: MFC 348970,348974:.
MFC 348970,348974:
Wed, Aug 21, 10:42 PM

Tue, Aug 20

jhb created D21347: Use 'const' for keys and IVs passed to software encryption algorithms..
Tue, Aug 20, 9:39 PM
jhb added inline comments to D21330: mips: hide regnum definitions behind _KERNEL/_WANT_MIPS_REGNUM.
Tue, Aug 20, 9:24 PM
jhb committed rS351246: MFC 348876: Add warnings to /dev/crypto for deprecated algorithms..
MFC 348876: Add warnings to /dev/crypto for deprecated algorithms.
Tue, Aug 20, 1:30 AM
jhb committed rS351243: MFC 348875:.
MFC 348875:
Tue, Aug 20, 12:50 AM

Mon, Aug 19

jhb committed rS351242: MFC 349616: Fix description of debug.obsolete_panic..
MFC 349616: Fix description of debug.obsolete_panic.
Mon, Aug 19, 11:57 PM
jhb committed rS351236: MFC 349467: Hold an explicit reference on the socket for the aiotx task..
MFC 349467: Hold an explicit reference on the socket for the aiotx task.
Mon, Aug 19, 10:31 PM
jhb committed rS351234: MFC 348874: Remove an overly-aggressive assertion..
MFC 348874: Remove an overly-aggressive assertion.
Mon, Aug 19, 9:59 PM
jhb committed rS351228: MFC 348791: Fix debug trace after removal of pdu_overhead..
MFC 348791: Fix debug trace after removal of pdu_overhead.
Mon, Aug 19, 6:51 PM
jhb committed rS351224: Trim a spurious blank line I added in r348969..
Trim a spurious blank line I added in r348969.
Mon, Aug 19, 5:28 PM
jhb committed rS351222: MFC 348969: Document sysctl nodes that translate their values..
MFC 348969: Document sysctl nodes that translate their values.
Mon, Aug 19, 5:27 PM
D21326: Don't set the string "unknown" as a device's location_str is now accepted and ready to land.
Mon, Aug 19, 5:15 PM
D21323: Remove manual wire_count adjustments. is now accepted and ready to land.
Mon, Aug 19, 5:02 PM

Aug 16 2019

jhb added a comment to D21277: Add kernel-side support for in-kernel TLS..
  • Use VM_ALLOC_NORMAL and VM_ALLOC_WIRED.
  • Use const bool for hw_tls.
Aug 16 2019, 7:25 PM
jhb added inline comments to D21277: Add kernel-side support for in-kernel TLS..
Aug 16 2019, 7:23 PM
jhb added inline comments to D21277: Add kernel-side support for in-kernel TLS..
Aug 16 2019, 6:59 PM
jhb added a comment to D21060: Stop installing clang, clang++, and clang-cpp hardlinks in /usr/bin..

FWIW, gcc4.2.1 does get installed as /usr/bin/gcc on platforms that use it as /usr/bin/cc, and the base/gcc port that installs gcc6 as /usr/bin/cc also installs it as /usr/bin/gcc. I think gcc may be slightly different though in that autoconf scripts tend to look specifically for gcc sometimes instead of cc. I haven't run into similar configure scripts that look specifically for 'clang'. In my experience they look for 'cc' which happens to be clang.

Aug 16 2019, 6:17 PM

Aug 15 2019

jhb added a comment to D21277: Add kernel-side support for in-kernel TLS..
  • Bump __FreeBSD_version.
Aug 15 2019, 6:18 PM
jhb added a comment to D21277: Add kernel-side support for in-kernel TLS..
  • Spelling nit noticed by arc.
Aug 15 2019, 6:02 PM
jhb created D21277: Add kernel-side support for in-kernel TLS..
Aug 15 2019, 6:00 PM

Aug 14 2019

jhb committed rS351060: MFC 348695: Support MSI-X for passthrough devices with a separate PBA BAR..
MFC 348695: Support MSI-X for passthrough devices with a separate PBA BAR.
Aug 14 2019, 11:32 PM
jhb committed rS351059: MFC 348694: Don't simulate PBA access if the PBA is in a separate BAR..
MFC 348694: Don't simulate PBA access if the PBA is in a separate BAR.
Aug 14 2019, 11:28 PM
jhb committed rS351058: MFC 347465: Apply r280991 to ip6_fragment..
MFC 347465: Apply r280991 to ip6_fragment.
Aug 14 2019, 11:26 PM
jhb committed rS351057: MFC 346360: Push down INP_WLOCK slightly in tcp_ctloutput..
MFC 346360: Push down INP_WLOCK slightly in tcp_ctloutput.
Aug 14 2019, 11:06 PM
jhb created D21264: Fix universe to include arm LINT kernel configs..
Aug 14 2019, 10:21 PM
jhb committed rS351054: Stop listing "on motherboard" as the parent of nexus devices on x86..
Stop listing "on motherboard" as the parent of nexus devices on x86.
Aug 14 2019, 10:13 PM
jhb closed D21256: Stop listing "on motherboard" as the parent of nexus devices on x86..
Aug 14 2019, 10:13 PM

Aug 13 2019

jhb created D21256: Stop listing "on motherboard" as the parent of nexus devices on x86..
Aug 13 2019, 10:18 PM
jhb committed rP508877: Install kernel module sources for drm-current-kmod..
Install kernel module sources for drm-current-kmod.
Aug 13 2019, 9:51 PM
jhb closed D20990: graphics/drm-current-kmod: Install kernel module sources..
Aug 13 2019, 9:51 PM
jhb committed rS351003: Fix build with DRM and INVARIANTS enabled..
Fix build with DRM and INVARIANTS enabled.
Aug 13 2019, 9:16 PM
jhb closed D20992: Fix build with DRM and INVARIANTS enabled..
Aug 13 2019, 9:16 PM
jhb added inline comments to D21250: Move phys_avail and dump_avail into MI code..
Aug 13 2019, 5:49 PM
jhb added a comment to D20992: Fix build with DRM and INVARIANTS enabled..
  • Map lockdep_is_held 1 for !INVARIANTS.
Aug 13 2019, 4:10 PM
jhb added a comment to D20992: Fix build with DRM and INVARIANTS enabled..

@jhb : OK, if you can move lockdep_is_held() under #ifdef INVARIANTS and otherwise define lockdep_is_held() as 1, I think we are in-line.

Aug 13 2019, 4:07 PM
jhb added inline comments to D21248: Move the identical x86 lines to files.x86.
Aug 13 2019, 3:29 PM
jhb added a comment to D21248: Move the identical x86 lines to files.x86.

There were several other things that looked like they were also identical (e.g. several agp drivers, all the atkbdc stuff, acpi_wmi_if.m). Those can be followup commits though.

Aug 13 2019, 2:57 PM

Aug 12 2019

jhb added a comment to D21236: MFV r350898: 8423 8199 7432 Implement large_dnode pool feature.

I think you did an svn merge or the like that set a crap ton of properties on lots of subdirectories? The affected files list from the original e-mail seemed to start off by listing every single directory in the source tree.

Aug 12 2019, 10:49 PM
jhb accepted D21233: Move sc out of the global file.
Aug 12 2019, 10:08 PM
D21210: Create files.x86 is now accepted and ready to land.
Aug 12 2019, 10:06 PM
jhb added inline comments to D21233: Move sc out of the global file.
Aug 12 2019, 6:00 PM
jhb added a comment to D21233: Move sc out of the global file.

If you wanted to be super crazy you could have a NOTES.syscons file, but that is perhaps over engineering just for syscons. If you did that, I would put the screen savers in it as well and then sparc64 would keep the few 'nodevice foo_saver' it has currently.

Aug 12 2019, 5:59 PM
D21203: Start to split out the really x86 specific NOTES from the global notes file. Start with COMPAT_43, since it's really only relevant to x86. is now accepted and ready to land.
Aug 12 2019, 5:57 PM
jhb added a comment to D21210: Create files.x86.

Oh, I thought it seemed to be there from the code I read on Friday:

Aug 12 2019, 5:56 PM
jhb added a comment to D21210: Create files.x86.

Ah, I had thought we would use 'include' in files.i386 and files.amd64 rather than DEFAULTS, but either way is fine with me.

Aug 12 2019, 5:01 PM
jhb accepted D21208: Floppy driver really only works on x86.
Aug 12 2019, 5:00 PM
jhb added a comment to D21203: Start to split out the really x86 specific NOTES from the global notes file. Start with COMPAT_43, since it's really only relevant to x86..

OTOH, I wonder if what we might not want instead is a 'NOTES_EXTRA'. You would modify makeLINT.mk to do something like this:

Aug 12 2019, 4:58 PM
jhb accepted D21207: Move screen saver stuff to x86 NOTES.
Aug 12 2019, 4:56 PM