Page MenuHomeFreeBSD

jhb (John Baldwin)
User

Projects (8)

User Details

User Since
Mar 11 2014, 8:46 PM (279 w, 2 d)

Recent Activity

Yesterday

jhb added a comment to D20991: Fix LOCAL_MODULES and improve the make output..

Sample output from the tail of a NO_KERNELCLEAN=yes build with nothing to do:

Thu, Jul 18, 10:06 PM
jhb added inline comments to D20990: graphics/drm-current-kmod: Install kernel module sources..
Thu, Jul 18, 10:04 PM
jhb created D20992: Fix build with DRM and INVARIANTS enabled..
Thu, Jul 18, 10:00 PM
jhb created D20991: Fix LOCAL_MODULES and improve the make output..
Thu, Jul 18, 9:58 PM
jhb created D20990: graphics/drm-current-kmod: Install kernel module sources..
Thu, Jul 18, 9:55 PM

Wed, Jul 17

D20335: bhyve could be more precise with vPIT is now accepted and ready to land.
Wed, Jul 17, 8:49 PM · bhyve

Tue, Jul 16

jhb committed rS350069: Use PT_GET_SC_ARGS and PT_GET_SC_RET in truss..
Use PT_GET_SC_ARGS and PT_GET_SC_RET in truss.
Tue, Jul 16, 10:59 PM
jhb closed D20963: Use PT_GET_SC_ARGS and PT_GET_SC_RET in truss..
Tue, Jul 16, 10:59 PM
jhb added inline comments to D20963: Use PT_GET_SC_ARGS and PT_GET_SC_RET in truss..
Tue, Jul 16, 5:46 PM
jhb added inline comments to D20963: Use PT_GET_SC_ARGS and PT_GET_SC_RET in truss..
Tue, Jul 16, 4:49 PM

Mon, Jul 15

jhb created D20963: Use PT_GET_SC_ARGS and PT_GET_SC_RET in truss..
Mon, Jul 15, 10:17 PM
Herald added a reviewer for D20901: Add ptrace op PT_GET_SC_RET.: manpages.
Mon, Jul 15, 9:48 PM
jhb committed rS350017: Add ptrace op PT_GET_SC_RET..
Add ptrace op PT_GET_SC_RET.
Mon, Jul 15, 9:48 PM
jhb closed D20905: Don't pass error from syscallenter() to syscallret()..
Mon, Jul 15, 9:28 PM
jhb committed rS350014: Add a test for PT_GET_SC_ARGS..
Add a test for PT_GET_SC_ARGS.
Mon, Jul 15, 9:27 PM
jhb closed D20899: Add a test for PT_GET_SC_ARGS..
Mon, Jul 15, 9:27 PM
jhb committed rS350013: Don't pass error from syscallenter() to syscallret()..
Don't pass error from syscallenter() to syscallret().
Mon, Jul 15, 9:25 PM
Herald added a reviewer for D2090: Fix grammar in epair(4): manpages.
Mon, Jul 15, 9:25 PM
jhb committed rS350012: Always set td_errno to the error value of a system call..
Always set td_errno to the error value of a system call.
Mon, Jul 15, 9:16 PM
jhb closed D20898: Always set td_errno to the error value of a system call..
Mon, Jul 15, 9:16 PM
D19422: if_vxlan(4) Allow set MTU more than 1500 bytes. is now accepted and ready to land.

Thanks!

Mon, Jul 15, 7:52 PM
D20945: bhyve: update the NVMe CQ based on the status is now accepted and ready to land.
Mon, Jul 15, 7:50 PM

Sat, Jul 13

jhb committed rS349962: MFC 347238: vmm(4): Pass through RDSEED feature bit to guests.
MFC 347238: vmm(4): Pass through RDSEED feature bit to guests
Sat, Jul 13, 12:51 AM
jhb committed rS349961: MFC 343068:.
MFC 343068:
Sat, Jul 13, 12:23 AM
jhb committed rS349959: Add Capsicumification of the virtio_console device model..
Add Capsicumification of the virtio_console device model.
Sat, Jul 13, 12:12 AM

Fri, Jul 12

jhb committed rS349958: MFC 339911,339936,343075,343166,348592: Various AMD CPU-specific fixes..
MFC 339911,339936,343075,343166,348592: Various AMD CPU-specific fixes.
Fri, Jul 12, 10:31 PM
jhb added a comment to D20928: Handle stacked CPU binding..

Ok. I will trust your judgement on what is the best approach.

Fri, Jul 12, 9:48 PM
jhb added a comment to D20928: Handle stacked CPU binding..

I think moving and moving back probably doesn't break anything, so if this is the simplest approach I'm ok. For NUMA allocation I was kind of hoping we could have a way other than PCPU_GET(cpuid) to specify a preferred domain when we really want NUMA allocation, but maybe binding and pcpu is simpler than the other possibilities (e.g. could you set a temporary numa policy on curthread in place of sched_bind? Not sure if we have the bits for that though.)

Fri, Jul 12, 8:49 PM
jhb committed rS349955: MFC 348210: Add a constant for the LS config MSR on AMD CPUs..
MFC 348210: Add a constant for the LS config MSR on AMD CPUs.
Fri, Jul 12, 8:05 PM
jhb added inline comments to D20924: Increase VM name limit.
Fri, Jul 12, 7:17 PM
D19905: bhyve: Add EUI64 to NVMe device is now accepted and ready to land.
Fri, Jul 12, 5:48 PM
jhb added inline comments to D20924: Increase VM name limit.
Fri, Jul 12, 5:43 PM
jhb added a comment to D19422: if_vxlan(4) Allow set MTU more than 1500 bytes..

I agree that we can't handle this in ether_ioctl as it varies too much by real hardware.

Fri, Jul 12, 5:33 PM
jhb added a comment to D20928: Handle stacked CPU binding..

Hmm, do you require this going forward? I think it's probably fine, but changing the binding is going to possibly break some assumption in the calling code and the purpose of the panic was to force the calling code to be aware of that and handle it (e.g. by unbinding before calling bus_bind_intr() or the like so that then the calling code is aware of the change and can handle the migration if needed.)

Fri, Jul 12, 5:21 PM
jhb added inline comments to D20924: Increase VM name limit.
Fri, Jul 12, 4:56 PM

Thu, Jul 11

jhb added a comment to D20327: Don't reset memory attributes when mapping physical addresses for ACPI..
  • Style fixes.
Thu, Jul 11, 12:35 AM
jhb added inline comments to D20327: Don't reset memory attributes when mapping physical addresses for ACPI..
Thu, Jul 11, 12:28 AM

Wed, Jul 10

D20910: Enforce a 4GB DMA boundary on isci(4) is now accepted and ready to land.
Wed, Jul 10, 10:22 PM
jhb added a comment to D20805: fusefs: merge from projects/fuse2.

The random non-changes to files in bhyve, etc. is odd. I think this comes from using svn merge which I think is usually a bad idea for non-MFC's as it often screws up.

Wed, Jul 10, 6:41 PM
jhb created D20905: Don't pass error from syscallenter() to syscallret()..
Wed, Jul 10, 6:07 PM
jhb added a comment to D20898: Always set td_errno to the error value of a system call..
  • Rebase.
  • Style fixes from kib.
  • Move td_errno into zeroed section of struct thread.
Wed, Jul 10, 6:06 PM
jhb added inline comments to D20898: Always set td_errno to the error value of a system call..
Wed, Jul 10, 4:41 PM
jhb added inline comments to D20898: Always set td_errno to the error value of a system call..
Wed, Jul 10, 4:19 PM
jhb added inline comments to D20901: Add ptrace op PT_GET_SC_RET..
Wed, Jul 10, 12:04 AM

Tue, Jul 9

jhb closed D20902: A few more wording tweaks to the section on ENs..
Tue, Jul 9, 11:59 PM
jhb committed rD53242: A few more wording tweaks to the section on ENs..
A few more wording tweaks to the section on ENs.
Tue, Jul 9, 11:59 PM
jhb committed rS349871: Use 'retval' label for first error in syscallenter()..
Use 'retval' label for first error in syscallenter().
Tue, Jul 9, 11:58 PM
jhb closed D20897: Use 'retval' label for first error in syscallenter()..
Tue, Jul 9, 11:58 PM
jhb created D20902: A few more wording tweaks to the section on ENs..
Tue, Jul 9, 11:47 PM
jhb added inline comments to D20898: Always set td_errno to the error value of a system call..
Tue, Jul 9, 11:37 PM
jhb added a comment to D20901: Add ptrace op PT_GET_SC_RET..
  • Document PT_GET_SC_RET.
Tue, Jul 9, 11:31 PM
jhb created D20901: Add ptrace op PT_GET_SC_RET..
Tue, Jul 9, 11:06 PM
jhb created D20899: Add a test for PT_GET_SC_ARGS..
Tue, Jul 9, 11:04 PM
jhb created D20898: Always set td_errno to the error value of a system call..
Tue, Jul 9, 11:03 PM
jhb created D20897: Use 'retval' label for first error in syscallenter()..
Tue, Jul 9, 11:02 PM
jhb added a comment to D20894: Correct definitions in sys.opencrypto.runtests.main for 32bit platform.

Nice. I was just planning on looking why these tests fail on i386. Thanks!

Tue, Jul 9, 7:11 PM
jhb added a comment to D20895: Flip REPRODUCIBLE_BUILD back to off by default in head..

Ed, I believe you had mentioned doing this for head once the 12.0 cycle was done? Right now you can't find the svn revision for a build of a clean tree (which is often a useful bit of info when reporting bugs on current@, etc.). I also commonly export trees into VMs using NFS and build inside the VM and newvers.sh fails to recognize dirty trees since the VCS may not be installed in the VM or the VM may be mounting a subdirectory of an svn checkout and thus not see the .svn, etc.

Tue, Jul 9, 7:00 PM
jhb created D20895: Flip REPRODUCIBLE_BUILD back to off by default in head..
Tue, Jul 9, 6:57 PM

Mon, Jul 8

D20874: bhyve: add missing license identifiers in net_utils and net_backend is now accepted and ready to land.
Mon, Jul 8, 9:38 PM
D20883: bhyve: net_backends.c: add missing __FBSDID is now accepted and ready to land.
Mon, Jul 8, 9:38 PM
D20873: Program the MSI-X vector control field for MSI-X table entries without loading the previous content of the vector control word. is now accepted and ready to land.
Mon, Jul 8, 6:32 PM
jhb added inline comments to D20880: Fix gcc build for superio(4).
Mon, Jul 8, 6:08 PM
jhb added inline comments to D20880: Fix gcc build for superio(4).
Mon, Jul 8, 6:00 PM
jhb added a comment to D20873: Program the MSI-X vector control field for MSI-X table entries without loading the previous content of the vector control word..

One thing to consider is moving the new comment up above 'pci_mask_msix' function and just listing it once.

Mon, Jul 8, 5:52 PM
jhb added inline comments to D20880: Fix gcc build for superio(4).
Mon, Jul 8, 5:27 PM
jhb added a comment to D20327: Don't reset memory attributes when mapping physical addresses for ACPI..

Rather than conflating the renaming of pmap_mapbios with this change, I've just altered the semantics of the existing function for now. I do think a separate followup to rename pmap_mapbios to pmap_mapphys might be nice, but I don't think we need yet another variant of pmap_mapdev.

Mon, Jul 8, 4:51 PM
jhb updated the summary of D20327: Don't reset memory attributes when mapping physical addresses for ACPI..
Mon, Jul 8, 4:50 PM
jhb added a comment to D20873: Program the MSI-X vector control field for MSI-X table entries without loading the previous content of the vector control word..

(My 3.0 is older than Warners which is somewhat unfortunate, but I think the requirement for RMW still stands)

Mon, Jul 8, 4:48 PM
jhb added a comment to D20873: Program the MSI-X vector control field for MSI-X table entries without loading the previous content of the vector control word..

The newest spec I have (3.0) say this about the upper 31 bits of VCTRL:

Mon, Jul 8, 4:47 PM
D20879: Fix gcc build for cxgbe(4) is now accepted and ready to land.
Mon, Jul 8, 4:33 PM
jhb added inline comments to D20874: bhyve: add missing license identifiers in net_utils and net_backend.
Mon, Jul 8, 4:32 PM
D20327: Don't reset memory attributes when mapping physical addresses for ACPI. now requires review to proceed.
  • Rename back to pmap_mapbios.
  • Change pmap_mapbios on i386 to not change attributes.
  • Don't look for an existing page for pre-init mappings.
  • Don't rewrite PTEs for pmap_mapbios of "low" mappings.
Mon, Jul 8, 3:38 PM

Wed, Jul 3

jhb added a comment to D20844: Update security/razorback-api to compile with OpenSSL 1.1.x..

Simplify by using stubs for old OpenSSL versions.

Wed, Jul 3, 6:46 PM
jhb created D20844: Update security/razorback-api to compile with OpenSSL 1.1.x..
Wed, Jul 3, 6:21 PM
jhb committed rS349649: Use unmapped (M_NOMAP) mbufs for zero-copy AIO writes via TOE..
Use unmapped (M_NOMAP) mbufs for zero-copy AIO writes via TOE.
Wed, Jul 3, 4:06 PM
jhb closed D20839: Use unmapped (M_NOMAP) mbufs for zero-copy AIO writes via TOE..
Wed, Jul 3, 4:06 PM
jhb accepted D20794: Save the last callout function executed on each CPU.
Wed, Jul 3, 3:55 PM
D20839: Use unmapped (M_NOMAP) mbufs for zero-copy AIO writes via TOE. now requires review to proceed.
  • Use ext_arg1 instead of ext_arg2.
Wed, Jul 3, 3:52 PM
jhb added inline comments to D20839: Use unmapped (M_NOMAP) mbufs for zero-copy AIO writes via TOE..
Wed, Jul 3, 3:33 PM

Tue, Jul 2

jhb added a comment to D20839: Use unmapped (M_NOMAP) mbufs for zero-copy AIO writes via TOE..

I added Mark to be aware of another place using held pages that the pending wire count patch would touch. Drew in case you are curious as this is another use for M_NOMAP.

Tue, Jul 2, 11:22 PM
jhb created D20839: Use unmapped (M_NOMAP) mbufs for zero-copy AIO writes via TOE..
Tue, Jul 2, 11:16 PM
jhb committed rS349617: Invoke ext_free function when freeing an unmapped mbuf..
Invoke ext_free function when freeing an unmapped mbuf.
Tue, Jul 2, 10:58 PM
jhb committed rS349616: Fix description of debug.obsolete_panic..
Fix description of debug.obsolete_panic.
Tue, Jul 2, 10:57 PM

Sat, Jun 29

jhb committed rS349534: Add support for IFCAP_NOMAP to mlx5(4)..
Add support for IFCAP_NOMAP to mlx5(4).
Sat, Jun 29, 12:53 AM
jhb committed rS349533: Add support for IFCAP_NOMAP to cxgbe(4)..
Add support for IFCAP_NOMAP to cxgbe(4).
Sat, Jun 29, 12:52 AM
jhb committed rS349532: Support IFCAP_NOMAP in vlan(4)..
Support IFCAP_NOMAP in vlan(4).
Sat, Jun 29, 12:51 AM
jhb committed rS349531: Compress pending socket buffer data once it is marked ready..
Compress pending socket buffer data once it is marked ready.
Sat, Jun 29, 12:50 AM
jhb closed D20616: Add a new external mbuf type that holds multiple unmapped pages..
Sat, Jun 29, 12:49 AM
jhb committed rS349530: Add support for using unmapped mbufs with sendfile(2)..
Add support for using unmapped mbufs with sendfile(2).
Sat, Jun 29, 12:49 AM
jhb committed rS349529: Add an external mbuf buffer type that holds multiple unmapped pages..
Add an external mbuf buffer type that holds multiple unmapped pages.
Sat, Jun 29, 12:48 AM

Fri, Jun 28

jhb committed rS349516: Sync mbuf flags, types, and external buffer types with <sys/mbuf.h>..
Sync mbuf flags, types, and external buffer types with <sys/mbuf.h>.
Fri, Jun 28, 7:49 PM
jhb committed rS349515: Use a tab after #define for EXT_* constants..
Use a tab after #define for EXT_* constants.
Fri, Jun 28, 7:38 PM
jhb added a comment to D20796: Add tests for expand_number(3)..

One more question, should we fail for trailing garbage? I think we should but we don't currently.

Fri, Jun 28, 7:21 PM
D20798: cxgbe/t4_tom: the aio tx job queue must be empty by the time the toepcb is freed. is now accepted and ready to land.

On further thought, I think this is ok. If the jobq isn't empty, then at least one job exists, and that job would hold a reference on the struct file and thus keep the socket "open".

Fri, Jun 28, 7:19 PM
jhb added inline comments to D20798: cxgbe/t4_tom: the aio tx job queue must be empty by the time the toepcb is freed..
Fri, Jun 28, 7:15 PM
D20797: Additional info in cxgbe's AIO related CTRs. is now accepted and ready to land.
Fri, Jun 28, 7:12 PM
jhb created D20796: Add tests for expand_number(3)..
Fri, Jun 28, 6:17 PM
jhb added inline comments to D20616: Add a new external mbuf type that holds multiple unmapped pages..
Fri, Jun 28, 4:25 PM
jhb created D20791: expand_number(3) parses suffixes, not prefixes. While here, tidy the opening sentence a bit..
Fri, Jun 28, 1:01 PM

Thu, Jun 27

jhb added inline comments to D16913: vmrun: add -x flag to disable reboot loop.
Thu, Jun 27, 11:06 PM