Page MenuHomeFreeBSD

jhb (John Baldwin)
User

Projects (8)

User Details

User Since
Mar 11 2014, 8:46 PM (350 w, 2 d)

Recent Activity

Wed, Nov 25

jhb closed D27272: Add a manpage for kernel TLS..
Wed, Nov 25, 11:17 PM
jhb committed rS368040: Add a manpage for kernel TLS..
Add a manpage for kernel TLS.
Wed, Nov 25, 11:17 PM
jhb added a comment to D27306: Detect ACPI early by FADT, not SPCR.

I looked and on x86 we use acpi_identify() for this sort of thing, though a bit later when deciding which nexus driver to attach (on x86, we either use an ACPI "nexus0" device when using ACPI, or we use a legacy "nexus0" device). acpi_identify() honors 'hint.acpi.0.disabled=1' as well as applying sanity checks on the RSDP and RSDT/XSDT. Here, kern.cfg.order seems to duplicate some of that functionality but in a different way.

Wed, Nov 25, 10:37 PM
jhb added a comment to D27306: Detect ACPI early by FADT, not SPCR.

In the description, do you mean has_acpi is set "before" walking the XDST (rather than "by")? If so, I think Andrew's suggestion of AcpiOsRootPointer() would be good. I think it's a bit more readable than a bare resource_int_fetch, and it more closely matches what OF does for example (calling OF_peer() rather than making use of it's implementation details).

Wed, Nov 25, 10:03 PM
jhb added inline comments to D27367: Remove uses of CRIOGET in OCF tests after r368005..
Wed, Nov 25, 9:58 PM
jhb closed D27367: Remove uses of CRIOGET in OCF tests after r368005..
Wed, Nov 25, 1:31 AM
jhb committed rS368008: Remove uses of CRIOGET in OCF tests after r368005..
Remove uses of CRIOGET in OCF tests after r368005.
Wed, Nov 25, 1:31 AM
jhb added a comment to D27367: Remove uses of CRIOGET in OCF tests after r368005..

Passes running tests. I'm going to merge this to unbreak the build.

Wed, Nov 25, 1:23 AM
jhb requested review of D27367: Remove uses of CRIOGET in OCF tests after r368005..
Wed, Nov 25, 1:13 AM
jhb committed rS368007: Remove a reference to CRIOGET missed in r368005..
Remove a reference to CRIOGET missed in r368005.
Wed, Nov 25, 1:10 AM
jhb closed D27302: Remove the cloned file descriptors for /dev/crypto..
Wed, Nov 25, 12:11 AM
jhb committed rS368005: Remove the cloned file descriptors for /dev/crypto..
Remove the cloned file descriptors for /dev/crypto.
Wed, Nov 25, 12:11 AM

Tue, Nov 24

jhb closed D27301: Pull the check for VM ownership into ppt_find()..
Tue, Nov 24, 11:56 PM
jhb committed rS368004: Pull the check for VM ownership into ppt_find()..
Pull the check for VM ownership into ppt_find().
Tue, Nov 24, 11:56 PM
jhb accepted D27348: Fix bhyve type19 SMBIOS handling to avoid losing 4GB.
Tue, Nov 24, 11:49 PM
jhb accepted D27343: mips: Fix sub-word atomics implementation.
Tue, Nov 24, 11:43 PM
jhb added inline comments to D26933: virtio_pci: Use the table BAR and PBA BAR from MSI-X cap.
Tue, Nov 24, 11:34 PM
jhb closed D27212: Honor the disabled setting for MSI-X interrupts for passthrough devices..
Tue, Nov 24, 11:19 PM
jhb committed rS368003: Honor the disabled setting for MSI-X interrupts for passthrough devices..
Honor the disabled setting for MSI-X interrupts for passthrough devices.
Tue, Nov 24, 11:19 PM
jhb updated the diff for D27302: Remove the cloned file descriptors for /dev/crypto..
  • Tweak the comment a bit further.
Tue, Nov 24, 11:06 PM
jhb updated the diff for D27302: Remove the cloned file descriptors for /dev/crypto..
  • Use refcount_load().
  • Note limitations of CRIOGET compat shim.
Tue, Nov 24, 11:03 PM
jhb committed rS368002: Correct entries for manpages removed in r359374..
Correct entries for manpages removed in r359374.
Tue, Nov 24, 10:52 PM
jhb added reviewers for D27363: Various fixes for the MIPS DDB stack unwinder.: arichardson, jrtc27.
Tue, Nov 24, 9:57 PM
jhb added reviewers for D27362: Check that the frame pointer is within the current stack.: andrew, markj.
Tue, Nov 24, 9:57 PM
jhb added a comment to D27361: Use uintptr_t instead of uint64_t for pointers in stack frames..

This will be useful for Morello (CHERI aarch64) support where these will be capabilities instead of uint64_t for a pure-cap kernel.

Tue, Nov 24, 9:56 PM
jhb added a reviewer for D27361: Use uintptr_t instead of uint64_t for pointers in stack frames.: andrew.
Tue, Nov 24, 9:56 PM
jhb added a reviewer for D27360: Use uintptr_t for pointers in stack frames.: mhorne.
Tue, Nov 24, 9:55 PM
jhb added reviewers for D27359: Avoid use of inline assembly to read initial PC in unwinders.: arichardson, jrtc27.
Tue, Nov 24, 9:55 PM
jhb added reviewers for D27358: Make stack_save*() more robust on MIPS.: jrtc27, arichardson, brooks.
Tue, Nov 24, 9:55 PM
jhb added reviewers for D27357: Stack unwinding robustness fixes for RISC-V.: mhorne, jrtc27, markj.
Tue, Nov 24, 9:54 PM
jhb added reviewers for D27356: Add a kstack_contains() helper function.: kib, markj.
Tue, Nov 24, 9:54 PM
jhb added a comment to D27362: Check that the frame pointer is within the current stack..

RISC-V has similar changes in D27357

Tue, Nov 24, 9:53 PM
jhb requested review of D27363: Various fixes for the MIPS DDB stack unwinder..
Tue, Nov 24, 9:49 PM
jhb requested review of D27362: Check that the frame pointer is within the current stack..
Tue, Nov 24, 9:49 PM
jhb requested review of D27361: Use uintptr_t instead of uint64_t for pointers in stack frames..
Tue, Nov 24, 9:49 PM
jhb requested review of D27360: Use uintptr_t for pointers in stack frames..
Tue, Nov 24, 9:49 PM
jhb requested review of D27359: Avoid use of inline assembly to read initial PC in unwinders..
Tue, Nov 24, 9:48 PM
jhb requested review of D27358: Make stack_save*() more robust on MIPS..
Tue, Nov 24, 9:48 PM
jhb requested review of D27357: Stack unwinding robustness fixes for RISC-V..
Tue, Nov 24, 9:48 PM
jhb requested review of D27356: Add a kstack_contains() helper function..
Tue, Nov 24, 9:48 PM

Sat, Nov 21

jhb requested review of D27302: Remove the cloned file descriptors for /dev/crypto..
Sat, Nov 21, 12:47 AM

Fri, Nov 20

jhb requested review of D27301: Pull the check for VM ownership into ppt_find()..
Fri, Nov 20, 11:59 PM
jhb added inline comments to D27212: Honor the disabled setting for MSI-X interrupts for passthrough devices..
Fri, Nov 20, 8:06 PM

Thu, Nov 19

jhb updated the diff for D27272: Add a manpage for kernel TLS..
  • Fix a few nits reported by mandoc.
Thu, Nov 19, 7:07 PM
jhb added a comment to D27272: Add a manpage for kernel TLS..

@gbe Hmm, igor was happy, but mandoc found a couple of nits. tcp.4 has many other existing mandoc complaints but I will let those be.

Thu, Nov 19, 7:06 PM
jhb updated subscribers of D27272: Add a manpage for kernel TLS..
Thu, Nov 19, 7:02 PM

Wed, Nov 18

jhb requested review of D27272: Add a manpage for kernel TLS..
Wed, Nov 18, 11:55 PM
jhb closed D27261: Fix a few nits in vn_printf()..
Wed, Nov 18, 4:21 PM
jhb committed rS367806: Fix a few nits in vn_printf()..
Fix a few nits in vn_printf().
Wed, Nov 18, 4:21 PM
jhb requested review of D27261: Fix a few nits in vn_printf()..
Wed, Nov 18, 1:26 AM

Tue, Nov 17

jhb added inline comments to D27212: Honor the disabled setting for MSI-X interrupts for passthrough devices..
Tue, Nov 17, 4:27 PM

Mon, Nov 16

jhb accepted D27188: LACP: When suppressing distributing, return ENOBUFS rather than ENETDOWN to preserve TCP conns.
Mon, Nov 16, 11:57 PM
jhb added inline comments to D26933: virtio_pci: Use the table BAR and PBA BAR from MSI-X cap.
Mon, Nov 16, 11:53 PM
jhb accepted D27177: Add .cfi_{start,end}proc for RISC-V assembly functions.
Mon, Nov 16, 11:48 PM

Fri, Nov 13

jhb requested review of D27212: Honor the disabled setting for MSI-X interrupts for passthrough devices..
Fri, Nov 13, 11:21 PM
jhb closed D27172: Switch xcscope.el to a separately-maintained version..
Fri, Nov 13, 12:10 AM
jhb committed rP554996: Switch xcscope.el to a separately-maintained version..
Switch xcscope.el to a separately-maintained version.
Fri, Nov 13, 12:10 AM

Wed, Nov 11

jhb updated the diff for D27172: Switch xcscope.el to a separately-maintained version..
  • Reorder to satisfy portlint.
Wed, Nov 11, 8:59 PM
jhb added a comment to D27172: Switch xcscope.el to a separately-maintained version..

Added a bug for the xcscope.el breakage here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251029

Wed, Nov 11, 1:06 AM
jhb requested review of D27172: Switch xcscope.el to a separately-maintained version..
Wed, Nov 11, 1:01 AM

Tue, Nov 10

jhb closed D27028: Clear tp->tod in t4_pcb_detach()..
Tue, Nov 10, 7:55 PM
jhb committed rS367578: Clear tp->tod in t4_pcb_detach()..
Clear tp->tod in t4_pcb_detach().
Tue, Nov 10, 7:54 PM
jhb closed D27127: Add C startup code tests for PIE binaries..
Tue, Nov 10, 7:09 PM
jhb committed rS367576: Add C startup code tests for PIE binaries..
Add C startup code tests for PIE binaries.
Tue, Nov 10, 7:09 PM
jhb closed D27126: Fix dso_handle_check for PIE executables..
Tue, Nov 10, 7:07 PM
jhb committed rS367575: Fix dso_handle_check for PIE executables..
Fix dso_handle_check for PIE executables.
Tue, Nov 10, 7:07 PM
jhb closed D27125: Rename __JCR_LIST__ to __JCR_END__ in crtend.c..
Tue, Nov 10, 7:05 PM
jhb committed rS367574: Rename __JCR_LIST__ to __JCR_END__ in crtend.c..
Rename __JCR_LIST__ to __JCR_END__ in crtend.c.
Tue, Nov 10, 7:05 PM

Sat, Nov 7

jhb committed rS367449: MFC 366296: Avoid a dubious assignment to bio_data in aio_qbio()..
MFC 366296: Avoid a dubious assignment to bio_data in aio_qbio().
Sat, Nov 7, 4:20 PM

Fri, Nov 6

jhb committed rS367437: Update copies of ioctl structures to match recent changes in head..
Update copies of ioctl structures to match recent changes in head.
Fri, Nov 6, 11:38 PM
jhb closed D27065: Use void * in place of caddr_t..
Fri, Nov 6, 6:10 PM
jhb committed rS367426: Use void * in place of caddr_t..
Use void * in place of caddr_t.
Fri, Nov 6, 6:09 PM
jhb closed D27070: Group session management routines together before first use..
Fri, Nov 6, 6:05 PM
jhb committed rS367425: Group session management routines together before first use..
Group session management routines together before first use.
Fri, Nov 6, 6:05 PM
jhb requested review of D27127: Add C startup code tests for PIE binaries..
Fri, Nov 6, 6:03 PM
jhb requested review of D27126: Fix dso_handle_check for PIE executables..
Fri, Nov 6, 6:03 PM
jhb requested review of D27125: Rename __JCR_LIST__ to __JCR_END__ in crtend.c..
Fri, Nov 6, 6:03 PM
jhb committed rS367424: MFC 365642: Add constant for the DE_CFG MSR on AMD CPUs..
MFC 365642: Add constant for the DE_CFG MSR on AMD CPUs.
Fri, Nov 6, 5:52 PM
jhb closed D27069: Move cryptof_ioctl() below the routines it calls..
Fri, Nov 6, 12:16 AM
jhb committed rS367410: Move cryptof_ioctl() below the routines it calls..
Move cryptof_ioctl() below the routines it calls.
Fri, Nov 6, 12:16 AM
jhb added a comment to D27068: Split logic to create new sessions into a separate function..

Trimmed ARGSUSED in the followup commit that moves the function.

Fri, Nov 6, 12:15 AM
jhb closed D27068: Split logic to create new sessions into a separate function..
Fri, Nov 6, 12:11 AM
jhb committed rS367409: Split logic to create new sessions into a separate function..
Split logic to create new sessions into a separate function.
Fri, Nov 6, 12:11 AM
jhb committed rS367408: MFC 365842,365844: Remove support for setting some obscure fields..
MFC 365842,365844: Remove support for setting some obscure fields.
Fri, Nov 6, 12:08 AM

Thu, Nov 5

jhb added inline comments to D27068: Split logic to create new sessions into a separate function..
Thu, Nov 5, 11:46 PM
jhb closed D27067: Move cryptodev_cb earlier before it is used..
Thu, Nov 5, 11:43 PM
jhb committed rS367407: Move cryptodev_cb earlier before it is used..
Move cryptodev_cb earlier before it is used.
Thu, Nov 5, 11:43 PM
jhb committed rS367406: Check cipher key lengths during probesession..
Check cipher key lengths during probesession.
Thu, Nov 5, 11:32 PM
jhb committed rS367405: MFC 365280: Pass a valid mode with O_CREATE to open(2)..
MFC 365280: Pass a valid mode with O_CREATE to open(2).
Thu, Nov 5, 11:29 PM
jhb closed D27066: Style fixes for function prototypes and definitions..
Thu, Nov 5, 11:28 PM
jhb committed rS367404: Style fixes for function prototypes and definitions..
Style fixes for function prototypes and definitions.
Thu, Nov 5, 11:28 PM
jhb closed D27064: Don't modify the destination pointer in ioctl requests..
Thu, Nov 5, 11:26 PM
jhb committed rS367403: Don't modify the destination pointer in ioctl requests..
Don't modify the destination pointer in ioctl requests.
Thu, Nov 5, 11:26 PM
jhb added a comment to D27064: Don't modify the destination pointer in ioctl requests..

Sorry, missed this comment earlier.

In D27064#603981, @jhb wrote:

Arguably we shouldn't really be checking for NULL pointers to control copyout as if you request an operation that needs to write output and submit a NULL pointer you should get EFAULT rather than success but the output data is lost. That is, we should be writing to the output always for operations that generate output (everything but CSP_MODE_DIGEST I think which only writes to the mac pointer).

I agree.

We should perhaps reject request with EINVAL if they pass in non-NULL pointers for fields that should be NULL as well (e.g. dst for a digest operation should be NULL, and the iv should be NULL for operations that don't use an iv).

That seems reasonable to me. The only argument against it is that it might break existing software. We could perhaps introduce new ioctls with stricter behaviour and deprecate the old ones.

Thu, Nov 5, 11:16 PM
jhb committed rS367401: MFC 365055: Fix a buffer overrun..
MFC 365055: Fix a buffer overrun.
Thu, Nov 5, 10:36 PM
jhb committed rS367396: MFC 361810: Refer to AES-CBC as "aes-cbc" rather than "rijndael-cbc" for IPsec..
MFC 361810: Refer to AES-CBC as "aes-cbc" rather than "rijndael-cbc" for IPsec.
Thu, Nov 5, 8:10 PM

Wed, Nov 4

jhb committed rS367336: MFC 359263: Use the newer EINTEGRITY error when authentication fails..
MFC 359263: Use the newer EINTEGRITY error when authentication fails.
Wed, Nov 4, 5:22 PM

Tue, Nov 3

jhb added inline comments to D27064: Don't modify the destination pointer in ioctl requests..
Tue, Nov 3, 10:54 PM
jhb closed D27063: Remove unnecessary __DECONST()..
Tue, Nov 3, 10:53 PM
jhb committed rS367311: Remove unnecessary __DECONST()..
Remove unnecessary __DECONST().
Tue, Nov 3, 10:53 PM