Page MenuHomeFreeBSD

jhb (John Baldwin)
User

Projects (8)

User Details

User Since
Mar 11 2014, 8:46 PM (373 w, 2 d)

Recent Activity

Yesterday

jhb added inline comments to D30138: Assume OCF is the only KTLS software backend..
Thu, May 6, 11:25 PM
jhb added inline comments to D30136: crypto: Add a new type of crypto buffer for a single mbuf..
Thu, May 6, 11:23 PM
jhb added a comment to D30135: sglist: Add sglist_append_single_mbuf()..

I kind of wish "sglist_append_mbuf" was the "single" version and there was a separate name for the "append a mbuf chain" variant, but that ship has sailed I think.

Thu, May 6, 11:08 PM
jhb added inline comments to D30134: Support unmapped mbufs in crypto buffers..
Thu, May 6, 11:07 PM
jhb added inline comments to D30132: Extend m_apply() to support unmapped mbufs..
Thu, May 6, 10:57 PM

Wed, May 5

jhb requested review of D30139: Include the trailer in the original dst_iov..
Wed, May 5, 9:30 PM
jhb requested review of D30138: Assume OCF is the only KTLS software backend..
Wed, May 5, 9:30 PM
jhb requested review of D30137: ktls_ocf: Fix a few places to not hardcode the GMAC hash length..
Wed, May 5, 9:30 PM
jhb requested review of D30136: crypto: Add a new type of crypto buffer for a single mbuf..
Wed, May 5, 9:30 PM
jhb requested review of D30135: sglist: Add sglist_append_single_mbuf()..
Wed, May 5, 9:30 PM
jhb requested review of D30133: Extend m_copyback() to support unmapped mbufs..
Wed, May 5, 9:29 PM
jhb requested review of D30134: Support unmapped mbufs in crypto buffers..
Wed, May 5, 9:29 PM
jhb requested review of D30132: Extend m_apply() to support unmapped mbufs..
Wed, May 5, 9:29 PM
jhb committed R10:1b2806931ae3: src.conf.5: Regen. (authored by jhb).
src.conf.5: Regen.
Wed, May 5, 9:12 PM
jhb closed D30107: src.conf.5: Regen..
Wed, May 5, 9:12 PM
jhb committed R10:0ac711e07ece: Add a description for WITH_SVNLITE. (authored by jhb).
Add a description for WITH_SVNLITE.
Wed, May 5, 9:12 PM
jhb closed D30106: Add a description for WITH_SVNLITE..
Wed, May 5, 9:12 PM
jhb committed R10:a2bc17474b96: Disable building svnlite(1) by default. (authored by jhb).
Disable building svnlite(1) by default.
Wed, May 5, 9:12 PM
jhb abandoned D30108: RELNOTES: Document disabling svnlite(1)..

Hmm, but since this will probably be MFC'd it's kind of messy I guess.

Wed, May 5, 9:12 PM
jhb closed D30105: Disable building svnlite(1) by default..
Wed, May 5, 9:12 PM
jhb added inline comments to D29893: Use thunks for compat ioctls using struct ifgroupreq..
Wed, May 5, 9:03 PM
jhb committed R10:9c87db4b3c5b: Group all compat shim structures together to consolidate #ifdef's. (authored by jhb).
Group all compat shim structures together to consolidate #ifdef's.
Wed, May 5, 9:00 PM
jhb committed R10:01e9cbc4c56d: Use thunks for compat ioctls using struct ifgroupreq. (authored by jhb).
Use thunks for compat ioctls using struct ifgroupreq.
Wed, May 5, 9:00 PM
jhb committed R10:d61d98f4ed68: Add freebsd32 compat shims for SIOC[GS]DRVSPEC. (authored by jhb).
Add freebsd32 compat shims for SIOC[GS]DRVSPEC.
Wed, May 5, 9:00 PM
jhb closed D29894: Group all compat shim structures together to consolidate #ifdef's..
Wed, May 5, 9:00 PM
jhb closed D29893: Use thunks for compat ioctls using struct ifgroupreq..
Wed, May 5, 9:00 PM
jhb closed D29892: Add freebsd32 compat shims for SIOC[GS]DRVSPEC..
Wed, May 5, 9:00 PM
jhb closed D29891: Rework compat shims in ifioctl()..
Wed, May 5, 9:00 PM
jhb committed R10:d17e0940f79f: Rework compat shims in ifioctl(). (authored by jhb).
Rework compat shims in ifioctl().
Wed, May 5, 9:00 PM
jhb added a comment to D30108: RELNOTES: Document disabling svnlite(1)..

From my experience hacking on the 13.0 release notes, this file is far more friendly to composing good release notes than trolling through commit logs.

Wed, May 5, 8:10 PM
jhb added a comment to D30105: Disable building svnlite(1) by default..

I think we can merge this to stable/13 ok? I would agree with not touching 12.

Wed, May 5, 8:07 PM

Tue, May 4

jhb abandoned D14634: [new port] security/openssl-chelsio: SSL and crypto library supporting Chelsio TLS offload.
Tue, May 4, 6:39 PM
jhb requested review of D30108: RELNOTES: Document disabling svnlite(1)..
Tue, May 4, 6:37 PM
jhb requested review of D30107: src.conf.5: Regen..
Tue, May 4, 6:37 PM
jhb requested review of D30106: Add a description for WITH_SVNLITE..
Tue, May 4, 6:37 PM
jhb requested review of D30105: Disable building svnlite(1) by default..
Tue, May 4, 6:37 PM
jhb updated the diff for D29893: Use thunks for compat ioctls using struct ifgroupreq..
  • Review feedback.
Tue, May 4, 6:26 PM
jhb updated the diff for D29892: Add freebsd32 compat shims for SIOC[GS]DRVSPEC..
  • Review feedback.
Tue, May 4, 6:26 PM
jhb updated the diff for D29891: Rework compat shims in ifioctl()..
  • Update for review feedback.
Tue, May 4, 6:25 PM
jhb added inline comments to D29891: Rework compat shims in ifioctl()..
Tue, May 4, 5:57 PM
jhb added inline comments to D29891: Rework compat shims in ifioctl()..
Tue, May 4, 5:56 PM

Fri, Apr 30

jhb added inline comments to D29893: Use thunks for compat ioctls using struct ifgroupreq..
Fri, Apr 30, 6:53 PM
jhb added a comment to D30050: Adds uuid validation to bhyve(8) arg parsing.

In head this code has changed a bit, and you'd rather want to check at the place that the associated config file is used (so that you'd catch invalid UUID strings from config files).

Fri, Apr 30, 6:42 PM

Thu, Apr 29

jhb accepted D30037: bhyve: Set SO_REUSEADDR on the gdb stub socket.
Thu, Apr 29, 4:54 PM
jhb accepted D29935: ioccom: define ioctl cmd value that can never be valid.
Thu, Apr 29, 4:43 PM

Wed, Apr 28

jhb accepted D30017: libsysdecode vmprot should accept underscores in bit names.

I tended to use fairly conservative regexes in mktables, but this is ok with me.

Wed, Apr 28, 3:24 PM

Tue, Apr 27

jhb added inline comments to D29607: byhve: add option to specify IP address for gdb.
Tue, Apr 27, 3:21 PM

Mon, Apr 26

jhb committed R10:57d9ae2a4489: cxgbe: Ignore doomed virtual interfaces when updating the clip table. (authored by jhb).
cxgbe: Ignore doomed virtual interfaces when updating the clip table.
Mon, Apr 26, 7:05 PM
jhb committed R10:0d4d5e9fe0c6: iscsi: Kick threads out of iscsi_ioctl() during unload. (authored by jhb).
iscsi: Kick threads out of iscsi_ioctl() during unload.
Mon, Apr 26, 7:05 PM
jhb committed R10:c2e295647ea5: cxgbe: Add counters for iSCSI PDUs transmitted via TOE. (authored by jhb).
cxgbe: Add counters for iSCSI PDUs transmitted via TOE.
Mon, Apr 26, 7:05 PM
jhb committed R10:27395a69d100: cxgbe: Make the TOE TLS stats per-queue instead of per-port. (authored by jhb).
cxgbe: Make the TOE TLS stats per-queue instead of per-port.
Mon, Apr 26, 7:05 PM
jhb committed R10:4e4ec8a9cc26: cxgbe: Add a struct sge_ofld_txq type. (authored by jhb).
cxgbe: Add a struct sge_ofld_txq type.
Mon, Apr 26, 7:05 PM
jhb committed R10:d6ee411d428e: cxgbei: Enter network epoch and set vnet around t4_push_pdus(). (authored by jhb).
cxgbei: Enter network epoch and set vnet around t4_push_pdus().
Mon, Apr 26, 7:05 PM
jhb committed R10:bcd7b64748d8: cxgbe ddp: Use CPL_COOKIE_DDP* instead of DDP_BUF*_INVALIDATED. (authored by jhb).
cxgbe ddp: Use CPL_COOKIE_DDP* instead of DDP_BUF*_INVALIDATED.
Mon, Apr 26, 7:05 PM
jhb committed R10:345bf0b368fb: cxgbei: Pass ULP submode directly to set_ulp_mode_iscsi(). (authored by jhb).
cxgbei: Pass ULP submode directly to set_ulp_mode_iscsi().
Mon, Apr 26, 7:04 PM
jhb committed R10:278db4ba3c49: cxgbei: Move some function prototypes to cxgbei.h. (authored by jhb).
cxgbei: Move some function prototypes to cxgbei.h.
Mon, Apr 26, 7:04 PM
jhb committed R10:cc76018cdd89: cxgbe(4): Read the rx 'c' channel for a port and make it available. (authored by np).
cxgbe(4): Read the rx 'c' channel for a port and make it available.
Mon, Apr 26, 7:04 PM
jhb committed R10:483bcffad704: cxgbei: Set vnet around tcp_drop() in do_rx_iscsi_ddp(). (authored by jhb).
cxgbei: Set vnet around tcp_drop() in do_rx_iscsi_ddp().
Mon, Apr 26, 7:04 PM
jhb committed R10:efe985058d5d: Fix a typo in a comment: frame -> framework. (authored by jhb).
Fix a typo in a comment: frame -> framework.
Mon, Apr 26, 7:04 PM
jhb committed R10:c0b22e146845: ccr: Disable requests on port 1 when needed to workaround a firmware bug. (authored by jhb).
ccr: Disable requests on port 1 when needed to workaround a firmware bug.
Mon, Apr 26, 7:04 PM
jhb committed R10:ea511d5a5b91: ccr: Add per-port stats of queued and completed requests. (authored by jhb).
ccr: Add per-port stats of queued and completed requests.
Mon, Apr 26, 7:04 PM
jhb committed R10:9cdd43808ccd: ccr: Set the RX channel ID correctly in work requests. (authored by jhb).
ccr: Set the RX channel ID correctly in work requests.
Mon, Apr 26, 7:04 PM
jhb committed R10:8130bdab382d: Handle negative return values from syncache_expand(). (authored by jhb).
Handle negative return values from syncache_expand().
Mon, Apr 26, 7:04 PM
jhb accepted D29997: newbus: remove support for SINGLETON.
Mon, Apr 26, 5:28 PM
jhb committed R10:5eb9c93a20d7: etcupdate: Add -D destdir to usage for 'extract'. (authored by jhb).
etcupdate: Add -D destdir to usage for 'extract'.
Mon, Apr 26, 4:52 PM

Fri, Apr 23

jhb committed R10:b0df36580d5b: etcupdate: Remove the old pre-world tree when rotating for -p. (authored by jhb).
etcupdate: Remove the old pre-world tree when rotating for -p.
Fri, Apr 23, 4:45 PM

Thu, Apr 22

jhb added inline comments to D29895: Reduce code duplication in machine/_types.h.
Thu, Apr 22, 10:55 PM
jhb added a comment to D29927: linux(4): fix ptrace(2) to properly handle orig_rax.

In general Linux extends GPR regsets with 'orig_foo' that stores the syscall code. Presumably i386 should be doing the same for orig_eax?

Thu, Apr 22, 10:00 PM
jhb added a comment to D29925: linux: make ptrace(2) return EIO when trying to peek invalid address.

I agree with Mark. I think EFAULT is perhaps the better error code for the native case.

Thu, Apr 22, 9:59 PM
jhb added inline comments to D27637: truss: fix handling of 64-bit arguments/return values for compat32.
Thu, Apr 22, 9:57 PM
jhb requested review of D29940: cxgbei: Handle target transfers with excess unsolicited data..
Thu, Apr 22, 9:28 PM
jhb requested review of D29939: cxgbei: Explicitly clear the page pode reservation pointer after freeing it..
Thu, Apr 22, 9:28 PM
jhb added inline comments to D29893: Use thunks for compat ioctls using struct ifgroupreq..
Thu, Apr 22, 6:18 PM
jhb added inline comments to D29891: Rework compat shims in ifioctl()..
Thu, Apr 22, 6:17 PM
jhb accepted D29926: bhyve: Gracefully handle virtio-scsi with no conf.
Thu, Apr 22, 3:13 PM
jhb added inline comments to D29904: cxgbe tom: Set the tid in the work requests to program page pods for iSCSI..
Thu, Apr 22, 12:02 AM

Wed, Apr 21

jhb requested review of D29912: cxgbei: Don't clamp iSCSI PDUs to 8K..
Wed, Apr 21, 11:59 PM
jhb requested review of D29911: cxgbei: Don't leak resources for an aborted target transfer..
Wed, Apr 21, 11:59 PM
jhb requested review of D29910: cxgbei: Add support for zero-copy iSCSI target transmission/read..
Wed, Apr 21, 11:59 PM
jhb requested review of D29909: cxgbei: Rework the pdu_append_data hook to support M_WAITOK..
Wed, Apr 21, 11:59 PM
jhb requested review of D29908: cxgbei: Support DDP for target I/O S/G lists with more than one entry..
Wed, Apr 21, 11:59 PM
jhb requested review of D29907: cxgbe tom: Account for pre-iSCSI mode data on suspended connections..
Wed, Apr 21, 11:59 PM
jhb requested review of D29906: cxgbei: Whitespace fixes, comment typo, and rewrap a comment..
Wed, Apr 21, 11:58 PM
jhb requested review of D29905: cxgbei: Use hardware RX flow control for offloaded iSCSI connections..
Wed, Apr 21, 11:58 PM
jhb requested review of D29904: cxgbe tom: Set the tid in the work requests to program page pods for iSCSI..
Wed, Apr 21, 11:58 PM
jhb requested review of D29903: cxgbe: Make the TOE ISCSI RX stats per-queue instead of per adapter..
Wed, Apr 21, 11:58 PM
jhb added a comment to D29791: newbus: Update docs on child_pnpinfo_str and child_location_str.
In D29791#668246, @imp wrote:

Sadly, there appears to be no man page for either of these functions.

Wed, Apr 21, 10:00 PM
jhb committed R10:6a3a6fe34bf3: riscv: Assert that SUM is not set in SSTATUS for exceptions. (authored by jhb).
riscv: Assert that SUM is not set in SSTATUS for exceptions.
Wed, Apr 21, 8:58 PM
jhb closed D29764: riscv: Assert that SUM is not set in SSTATUS for exceptions..
Wed, Apr 21, 8:58 PM
jhb committed R10:753bcca440a4: riscv: Clear SUM in SSTATUS for supervisor mode exceptions. (authored by jhb).
riscv: Clear SUM in SSTATUS for supervisor mode exceptions.
Wed, Apr 21, 8:58 PM
jhb closed D29763: riscv: Clear SUM in SSTATUS for supervisor mode exceptions..
Wed, Apr 21, 8:58 PM
jhb accepted D29896: libkiconv: address memory leak in a not-found case.

RAII would be nice.

Wed, Apr 21, 6:25 PM
jhb requested review of D29894: Group all compat shim structures together to consolidate #ifdef's..
Wed, Apr 21, 5:36 PM
jhb requested review of D29893: Use thunks for compat ioctls using struct ifgroupreq..
Wed, Apr 21, 5:36 PM
jhb requested review of D29892: Add freebsd32 compat shims for SIOC[GS]DRVSPEC..
Wed, Apr 21, 5:35 PM
jhb requested review of D29891: Rework compat shims in ifioctl()..
Wed, Apr 21, 5:35 PM
jhb updated the diff for D29763: riscv: Clear SUM in SSTATUS for supervisor mode exceptions..
  • Use csrc.
Wed, Apr 21, 4:01 PM

Tue, Apr 20

jhb committed R10:e15bf05e0abc: bhyve: Be explicit that setting config.dump will not start a VM. (authored by jhb).
bhyve: Be explicit that setting config.dump will not start a VM.
Tue, Apr 20, 8:35 PM
jhb closed D29738: bhyve: Be explicit that setting config.dump will not start a VM..
Tue, Apr 20, 8:35 PM
jhb committed R10:ba30215ae0ef: etcupdate: Add a revert mode to restore one or more stock files. (authored by jhb).
etcupdate: Add a revert mode to restore one or more stock files.
Tue, Apr 20, 8:24 PM