Page MenuHomeFreeBSD

jhb (John Baldwin)
User

Projects (7)

User Details

User Since
Mar 11 2014, 8:46 PM (257 w, 3 d)

Recent Activity

Yesterday

jhb committed rP493011: Fix a regression for devel/amd64-gcc introduced in r488642..
Fix a regression for devel/amd64-gcc introduced in r488642.
Fri, Feb 15, 10:04 PM
jhb closed D19126: Fix a regression for devel/amd64-gcc introduced in r488642..
Fri, Feb 15, 10:04 PM
jhb committed rP493010: Add missing plist entries..
Add missing plist entries.
Fri, Feb 15, 10:00 PM
jhb closed D19125: devel/arm-none-eabi-gcc: Add missing plist entries..
Fri, Feb 15, 10:00 PM
jhb updated subscribers of D19126: Fix a regression for devel/amd64-gcc introduced in r488642..
Fri, Feb 15, 9:45 PM
jhb updated subscribers of D19125: devel/arm-none-eabi-gcc: Add missing plist entries..
Fri, Feb 15, 9:45 PM
jhb closed D19087: [new port] devel/libcxx-gdb: libc++ pretty printers for GDB..
Fri, Feb 15, 6:44 PM
jhb committed rP493008: Include pretty printers for libc++ when Python is enabled..
Include pretty printers for libc++ when Python is enabled.
Fri, Feb 15, 6:44 PM
jhb added a comment to D19203: Replace two-operand instruction aliases that clang does not understand with the three-operand instructions..

I haven't needed this when building mips64 on clang 6. clang 7 can't build mips due to a different regression (but not in this file).

Fri, Feb 15, 6:13 PM

Thu, Feb 14

jhb accepted D19202: bhyve(8) pci_xhci.c elliminate possible double free of uopt.
Thu, Feb 14, 8:15 PM
jhb accepted D19090: Add AES-CCM encryption.
Thu, Feb 14, 7:47 PM
jhb added a comment to D19090: Add AES-CCM encryption.

I would probably not fiddle with the sysctl in crypto check FWIW. I originally wrote it to test ccr0, not "soft". Will look at other parts of the patch in a bit.

Thu, Feb 14, 7:39 PM
jhb accepted D19200: bhyve(8) block_if.c remove multiple freeing of nopt added in r340042.
Thu, Feb 14, 7:37 PM

Wed, Feb 13

jhb updated the diff for D19087: [new port] devel/libcxx-gdb: libc++ pretty printers for GDB..
  • Merge into devel/gdb port under the python option.
Wed, Feb 13, 5:29 PM

Tue, Feb 12

jhb accepted D16730: Committers Guide: Add a section encouraging pre-commit review..
Tue, Feb 12, 7:01 PM
jhb added a comment to D19087: [new port] devel/libcxx-gdb: libc++ pretty printers for GDB..

The only reason I have it separate is that I anticipate (hope) that it will change more quickly than gdb if other people contribute more pretty printers, etc. (It only covers a few STL classes now and has large gaps) Having a separate port just means people can update that package independently. That said, the .pyc thing (in case you run gdb as root against a C++ program) is a valid point (and one that can't really be solved as a separate port), and probably there just won't be but so many port revision bumps. I don't mind moving it into devel/gdb. Would you want it as a separate option (that "implies" python in ports speak) or just have it be part of the existing python option?

Tue, Feb 12, 4:40 PM

Mon, Feb 11

jhb created D19152: Various cleanups to the management of multiple TCP stacks..
Mon, Feb 11, 11:47 PM
jhb updated the diff for D19087: [new port] devel/libcxx-gdb: libc++ pretty printers for GDB..
  • Rename port to devel/libcxx-gdbpy to match github repository. This also makes %%DATADIR%% patch the data directory perfectly simplifying the plist.
  • Remove one layer of directories in the installed tree.
  • Reverse the dependency with regards to gdb by making devel/gdb depend on this port if python is enabled in the gdb build. This means that folks installing gdb will get libc++ helpers out of the box on platforms using libc++. This assumes that these helpers are useful.
Mon, Feb 11, 11:44 PM
jhb accepted D18874: Implement per-CPU pmap activation tracking..
Mon, Feb 11, 10:29 PM
jhb committed rS344022: Enable PCI BAR reallocation by default..
Enable PCI BAR reallocation by default.
Mon, Feb 11, 8:47 PM
jhb closed D18965: Enable PCI bar reallocation by default..
Mon, Feb 11, 8:47 PM
jhb accepted D19122: mdmfs: Fix many bugs in automatic md(4) creation..
Mon, Feb 11, 8:14 PM
jhb added inline comments to D19087: [new port] devel/libcxx-gdb: libc++ pretty printers for GDB..
Mon, Feb 11, 5:40 PM

Sat, Feb 9

jhb added inline comments to D19122: mdmfs: Fix many bugs in automatic md(4) creation..
Sat, Feb 9, 12:20 AM
jhb added a comment to D19122: mdmfs: Fix many bugs in automatic md(4) creation..

It's probably fine, but I wonder if it wouldn't be more readable to just use getline() instead. I think you'd end up with something like:

Sat, Feb 9, 12:19 AM

Fri, Feb 8

jhb updated the diff for D19129: Permit base/gcc to be built as a native package..

Testing arcanist.

Fri, Feb 8, 11:53 PM
jhb added inline comments to D19087: [new port] devel/libcxx-gdb: libc++ pretty printers for GDB..
Fri, Feb 8, 9:58 PM
jhb added a comment to D19087: [new port] devel/libcxx-gdb: libc++ pretty printers for GDB..

Arguably the dependency should perhaps go the other way with the GDB port having an option to install this package as a dependency.

Fri, Feb 8, 9:17 PM
jhb updated subscribers of D19087: [new port] devel/libcxx-gdb: libc++ pretty printers for GDB..
Fri, Feb 8, 9:17 PM
jhb created D19129: Permit base/gcc to be built as a native package..
Fri, Feb 8, 7:41 PM
jhb created D19128: Permit base/binutils to be built as a native package..
Fri, Feb 8, 7:39 PM
jhb created D19126: Fix a regression for devel/amd64-gcc introduced in r488642..
Fri, Feb 8, 7:34 PM
jhb created D19125: devel/arm-none-eabi-gcc: Add missing plist entries..
Fri, Feb 8, 7:08 PM

Thu, Feb 7

jhb added a comment to D17848: Update review requests for bhyve..

I think listing a lot of folks will start to get unreadable. I think we can start with the existing language and just use some common sense (if a couple of folks who aren't random committers approve userland changes, then that's probably fine). If we have to nail it down further in the future we can revisit it then.

Thu, Feb 7, 6:29 PM
jhb added a comment to D18965: Enable PCI bar reallocation by default..

Ping?

Thu, Feb 7, 5:57 PM

Tue, Feb 5

jhb accepted D18592: Add CBC-MAC authentication code.

I'm generally happy with this. The #if 0 -> #ifdef CRYPTO_DEBUG change still seems unrelated, but I don't care strongly about it either way.

Tue, Feb 5, 7:10 PM
jhb created D19087: [new port] devel/libcxx-gdb: libc++ pretty printers for GDB..
Tue, Feb 5, 7:03 PM

Fri, Feb 1

jhb added inline comments to D18592: Add CBC-MAC authentication code.
Fri, Feb 1, 7:14 PM

Thu, Jan 31

jhb added inline comments to D18592: Add CBC-MAC authentication code.
Thu, Jan 31, 11:52 PM
jhb closed D19040: Don't set IFCAP_TXRTLMT during lagg_clone_create()..
Thu, Jan 31, 9:36 PM
jhb committed rS343620: Don't set IFCAP_TXRTLMT during lagg_clone_create()..
Don't set IFCAP_TXRTLMT during lagg_clone_create().
Thu, Jan 31, 9:36 PM

Wed, Jan 30

jhb created D19040: Don't set IFCAP_TXRTLMT during lagg_clone_create()..
Wed, Jan 30, 9:36 PM

Tue, Jan 29

jhb added inline comments to D18592: Add CBC-MAC authentication code.
Tue, Jan 29, 6:24 PM

Fri, Jan 25

jhb committed rS343456: Fix a few more places to handle ofld tx queues for RATELIMIT..
Fix a few more places to handle ofld tx queues for RATELIMIT.
Fri, Jan 25, 8:54 PM
jhb closed D18966: Fix a few more places to handle ofld tx queues for RATELIMIT..
Fri, Jan 25, 8:54 PM
jhb committed rP491173: Override the library search directories for external GCC toolchains..
Override the library search directories for external GCC toolchains.
Fri, Jan 25, 7:05 PM
jhb closed D18677: Override the library search directories for external GCC toolchains..
Fri, Jan 25, 7:05 PM
jhb created D18966: Fix a few more places to handle ofld tx queues for RATELIMIT..
Fri, Jan 25, 6:43 PM
jhb created D18965: Enable PCI bar reallocation by default..
Fri, Jan 25, 6:40 PM

Wed, Jan 23

jhb added a comment to D18932: Bump SPECNAMELEN to MAXNAMLEN..

Looks good to me.

Wed, Jan 23, 9:16 PM

Tue, Jan 22

jhb added inline comments to D18874: Implement per-CPU pmap activation tracking..
Tue, Jan 22, 10:45 PM
jhb accepted D18868: RISC-V superpage support, part 6/6..

(This one I understand well enough to sign off on)

Tue, Jan 22, 10:29 PM
jhb added inline comments to D18867: RISC-V superpage support, part 5/6..
Tue, Jan 22, 10:26 PM
jhb added inline comments to D18864: RISC-V superpage support, part 2/6..
Tue, Jan 22, 10:21 PM
jhb added inline comments to D18863: RISC-V superpage support, part 1/6..
Tue, Jan 22, 10:16 PM

Jan 15 2019

jhb committed rS343064: MFC 340469: Remove bogus roundup2() of the key programming work request header..
MFC 340469: Remove bogus roundup2() of the key programming work request header.
Jan 15 2019, 9:43 PM
jhb committed rS343063: MFC 340468: Change the quantum for TLS key addresses to 32 bytes..
MFC 340468: Change the quantum for TLS key addresses to 32 bytes.
Jan 15 2019, 9:41 PM
jhb committed rS343062: MFC 340466,340473: Move the TLS key map into the adapter softc..
MFC 340466,340473: Move the TLS key map into the adapter softc.
Jan 15 2019, 9:33 PM
jhb committed rS343061: MFC 340206: Treat the memory lengths for CHELSIO_T4_GET_MEM as unsigned..
MFC 340206: Treat the memory lengths for CHELSIO_T4_GET_MEM as unsigned.
Jan 15 2019, 9:07 PM
jhb added a comment to D18677: Override the library search directories for external GCC toolchains..
In D18677#402462, @kan wrote:

I wonder what this does to, say, arm-none-eabi-gcc? It, in somewhat misguided manner, uses powerpc64-gcc as the base.

Jan 15 2019, 9:05 PM
jhb committed rS343056: Reject new sessions if the necessary queues aren't initialized..
Reject new sessions if the necessary queues aren't initialized.
Jan 15 2019, 6:53 PM
jhb closed D18478: Reject new sessions if the necessary queues aren't initialized..
Jan 15 2019, 6:53 PM
jhb accepted D18744: Simplify capsicumization of bhyve..

Thanks! Hopefully this means 'grep -c ENOSYS' in bhyve is now zero. :)

Jan 15 2019, 6:32 PM
jhb committed rS343048: Update the note about the need for COMPAT_FREEBSD<n> kernel options..
Update the note about the need for COMPAT_FREEBSD<n> kernel options.
Jan 15 2019, 6:20 PM
jhb closed D18740: Update the note about the need for COMPAT_FREEBSD<n> kernel options..
Jan 15 2019, 6:20 PM
jhb added a comment to D18677: Override the library search directories for external GCC toolchains..

Adding bdrewery@ and bapt@ in hope of getting some review. Not sure if there is another person who would be qualified to review GCC patches.

Jan 15 2019, 6:16 PM
jhb added reviewers for D18677: Override the library search directories for external GCC toolchains.: bdrewery, bapt.
Jan 15 2019, 6:15 PM
jhb committed rP490337: Enable separate flavors for different python versions..
Enable separate flavors for different python versions.
Jan 15 2019, 1:42 AM
jhb closed D18534: Enable separate flavors for different python versions..
Jan 15 2019, 1:42 AM

Jan 4 2019

jhb added a comment to D18744: Simplify capsicumization of bhyve..

I stopped saying "same" after a while to avoid being too repetitious. I think it would make sense to have one commit that first fixes existing places not yet using helpers to use the helpers by replacing all uses of cap_rights_limit and cap_ioctls_limit with the helper variants. I would keep the == -1 checks though. The syscalls are defined to return -1 on error, not a random -ve value. From cap_rights_limit(2):

Jan 4 2019, 5:12 PM
jhb committed rS342751: MFC 340022: Add support for port unit wiring to cxgbe(4)..
MFC 340022: Add support for port unit wiring to cxgbe(4).
Jan 4 2019, 1:19 AM
jhb committed rS342750: MFC 340021: Assert that reclaim_tx_descs() is always making forward progress..
MFC 340021: Assert that reclaim_tx_descs() is always making forward progress.
Jan 4 2019, 12:06 AM

Jan 3 2019

jhb created D18740: Update the note about the need for COMPAT_FREEBSD<n> kernel options..
Jan 3 2019, 11:37 PM
jhb committed rS342748: MFC 340018: Compile cryptocheck with in-tree openssl again..
MFC 340018: Compile cryptocheck with in-tree openssl again.
Jan 3 2019, 10:51 PM
jhb committed rS342746: MFC 339890: Add support for "plain" (non-HMAC) SHA digests..
MFC 339890: Add support for "plain" (non-HMAC) SHA digests.
Jan 3 2019, 10:49 PM
jhb committed rS342745: MFC 339666: Support the SHA224 HMAC algorithm in ccr(4)..
MFC 339666: Support the SHA224 HMAC algorithm in ccr(4).
Jan 3 2019, 10:42 PM
jhb accepted D18738: Don't enable interrupts in init_secondary()..
Jan 3 2019, 10:38 PM
jhb committed rS342744: MFC 339665: Add sha224 to the authctx union..
MFC 339665: Add sha224 to the authctx union.
Jan 3 2019, 10:32 PM
jhb accepted D18730: Remove excessive invalidations from pmap_remove()..

On SMP systems the invalidate_range()'s here would seem to be more efficient since you can batch up the IPI's. I almost wonder if it wouldn't even be better to just do a single invalidate_range at the end instead of dealing with va_next and trying to be perfect about avoiding invalidation of ranges that weren't mapped. The only other call to pmap_remove_l3() in pmap_ts_referenced() is also followed by a call to pmap_invalidate_page(), so I wonder if removing pmap_invalidate_page() wouldn't be the better change?

Jan 3 2019, 9:36 PM
jhb accepted D18732: Fix PTE_D handling in pmap_remove_write()..
Jan 3 2019, 9:28 PM
jhb added a comment to D18592: Add CBC-MAC authentication code.

To avoid the need for 3 separate constants you could just make the software crypto code switch on the key size to pick an auth_hash *. This would require the key during session setup, but that's ok I think. GCM already requires it I believe. It would be ok I think to have the .type members of the 3 auth_hash's all use the same value. Eventually in my ocf_rework branch the goal would be just to say that you use AES-CCM (or AES-GCM) as your cipher and the corresponding MAC is implied without needing to be specified explicitly (so the 3 constants then become unused entirely). However, we aren't there yet, so we probably need at least one constant for now.

Jan 3 2019, 5:46 PM
jhb added a comment to D18592: Add CBC-MAC authentication code.

In regard to KAT vectors. I think it would be fine to use the approach in the python tester. It pulls the test vectors from a security/nist-kat port, so you would need to update the port to include the relevant test vectors (if it doesn't already) and then modify the python script Conrad mentioned earlier to exercise the new vectors. I think you can probably look at how the script handles GCM to get a sense of what is needed.

Jan 3 2019, 5:43 PM
jhb committed rS342712: MFC 339899: Make battery emptying rate available as sysctl variable..
MFC 339899: Make battery emptying rate available as sysctl variable.
Jan 3 2019, 1:39 AM

Jan 2 2019

jhb committed rS342709: MFC 339894: Teach procstat -x about the AT_EHDRFLAGS ELF auxiliary vector..
MFC 339894: Teach procstat -x about the AT_EHDRFLAGS ELF auxiliary vector.
Jan 2 2019, 11:57 PM
jhb accepted D18719: Fix some issues with pmap_protect()..
Jan 2 2019, 11:55 PM
jhb accepted D18718: Set PTE_U in pmap_enter_quick_locked()..
Jan 2 2019, 11:51 PM
jhb added inline comments to D18717: Use regular stores for updating PTEs..
Jan 2 2019, 11:50 PM
jhb accepted D18721: Synchronize access to the allpmaps list..
Jan 2 2019, 11:45 PM
jhb accepted D18720: Fix a use-after-free in pmap_release()..

One weird oddity. mips uses vm_page_free_zero() for it's top-level page but it doesn't zero it first. arm64 does the same. 32-bit arm v6 just leaks the pages (???), i386 uses vm_page_free() instead of vm_page_free_zero(). sparc64 uses vm_page_free_zero() without zero'ing the pages.

Jan 2 2019, 11:42 PM
jhb accepted D18715: Set HZ=100 for QEMU..
Jan 2 2019, 11:26 PM
jhb committed rS342708: MFC 341802: Validate the string size parameter passed to -s..
MFC 341802: Validate the string size parameter passed to -s.
Jan 2 2019, 8:50 PM
jhb committed rS342706: MFC 339620: Add a "live" mode to ktrdump..
MFC 339620: Add a "live" mode to ktrdump.
Jan 2 2019, 7:48 PM
jhb committed rS342705: MFC 339620: Add a "live" mode to ktrdump..
MFC 339620: Add a "live" mode to ktrdump.
Jan 2 2019, 7:46 PM
jhb committed rS342704: MFC 341800: Don't report stale signal information in ptrace_lwpinfo..
MFC 341800: Don't report stale signal information in ptrace_lwpinfo.
Jan 2 2019, 7:12 PM

Dec 31 2018

jhb committed rS342658: Correct variable name in two panic messages: num_msi_irq -> num_msi_irqs..
Correct variable name in two panic messages: num_msi_irq -> num_msi_irqs.
Dec 31 2018, 10:46 PM
jhb committed rS342656: MFC 340460: Convert the number of MSI IRQs on x86 from a constant to a tunable..
MFC 340460: Convert the number of MSI IRQs on x86 from a constant to a tunable.
Dec 31 2018, 10:09 PM
jhb committed rS342655: MFC 340465: Use sbsndptr_adv() instead of sbsndptr() for TOE TLS..
MFC 340465: Use sbsndptr_adv() instead of sbsndptr() for TOE TLS.
Dec 31 2018, 9:55 PM

Dec 29 2018

jhb committed rS342587: MFC 340441: Revert r332735 and fix MSI-X to properly fail allocations when full..
MFC 340441: Revert r332735 and fix MSI-X to properly fail allocations when full.
Dec 29 2018, 1:19 AM
jhb created D18677: Override the library search directories for external GCC toolchains..
Dec 29 2018, 12:55 AM
jhb committed rP488642: Simplify some of the logic for external GCC toolchain packages..
Simplify some of the logic for external GCC toolchain packages.
Dec 29 2018, 12:44 AM