Page MenuHomeFreeBSD

christos (Christos Margiolis)
User

Projects

User Details

User Since
Jul 2 2021, 4:03 PM (275 w, 6 d)

Recent Activity

Yesterday

christos committed rGa045cfb0c45d: sound: Remove obsolete comment from sound.h (authored by christos).
sound: Remove obsolete comment from sound.h
Thu, Oct 15, 9:22 AM

Wed, Oct 14

christos committed rG29449b3e468c: snd_hda: use the pin ELD to select DisplayPort audio framing (authored by David Bidner <david@crap.solutions>).
snd_hda: use the pin ELD to select DisplayPort audio framing
Wed, Oct 14, 12:00 PM
christos added a comment to D60120: sound: Drain the dsp cdev before freeing resources.

Friendly bump for this and the rest of the stack.

Wed, Oct 14, 11:26 AM
christos accepted D60554: sound: Revalidate after reacquiring locks when resizing buffers.
Wed, Oct 14, 11:25 AM
christos added a comment to D60553: sound: Check for errors from sndbuf_resize().

Also please include a small paragraph about the chn_resizebuf() changes in the commit message and/or in the code.

Wed, Oct 14, 11:18 AM
christos accepted D60553: sound: Check for errors from sndbuf_resize().
Wed, Oct 14, 11:18 AM
christos accepted D60678: bhyve: Improve HDA stream descriptor validation.

From what I understand, the issue is that because this is not bhyve-internal memory, but entries we read from the guest's memory, we want to make sure these values are read at that point exactly, so that we don't let the compiler re-read them later when the value might have been changed?

Wed, Oct 14, 11:11 AM
christos committed rG680957e950fc: rc.d/mountd: Do not require /etc/exports (authored by christos).
rc.d/mountd: Do not require /etc/exports
Wed, Oct 14, 9:32 AM
christos committed rGfa4f5cc47d36: pcm.4: Remove DIAGNOSTICS section (authored by christos).
pcm.4: Remove DIAGNOSTICS section
Wed, Oct 14, 9:32 AM

Mon, Oct 12

christos closed D60410: Status/2026Q3/cuse.adoc: Add report.
Mon, Oct 12, 4:29 PM
christos closed D60409: Status/2026Q3/audio.adoc: Add report.
Mon, Oct 12, 4:29 PM
christos committed R9:850fe1262851: Status/2026Q3/cuse.adoc: Add report (authored by christos).
Status/2026Q3/cuse.adoc: Add report
Mon, Oct 12, 4:29 PM
christos committed R9:9ed7f2c29bb4: Status/2026Q3/audio.adoc: Add report (authored by christos).
Status/2026Q3/audio.adoc: Add report
Mon, Oct 12, 4:29 PM

Sat, Oct 10

christos updated the diff for D60527: snd_hda: Enable the headset microphone on Framework ALC295 laptops.

Address Ed's comments. Note that hdaa_update_coef() now closely resembles
Linux's equivalent:

Sat, Oct 10, 8:24 AM

Fri, Oct 9

christos added a comment to D49002: snd_hda(4): Add quirks for Lenovo ThinkBooks and ASUS TUFs.

I had to add hda_update_coef() for a patch I'm working on (D60527), so we can hold off this one, and rebase it once I commit it.

Fri, Oct 9, 2:43 PM
christos requested review of D60527: snd_hda: Enable the headset microphone on Framework ALC295 laptops.
Fri, Oct 9, 2:40 PM
christos requested review of D60518: sound: Busy the device in mixer_oss_mixerinfo().
Fri, Oct 9, 11:22 AM
christos requested review of D60517: sound: Document the locking protocol.
Fri, Oct 9, 11:07 AM
christos requested review of D60515: sound: Retire PCM_LOCK in sound_oss_card_info().
Fri, Oct 9, 10:11 AM
christos requested review of D60514: sound: Retire PCM_LOCK in SNDCTL_DSP_GETCAPS.
Fri, Oct 9, 10:11 AM
christos requested review of D60513: sound: Protect channels.pcm.opened with the sx alone.
Fri, Oct 9, 9:41 AM
christos requested review of D60512: sound: Stop taking PCM_LOCK to create and destroy channels.
Fri, Oct 9, 9:33 AM
christos requested review of D60509: sound: Busy the device in sysctl_dev_pcm_mode().
Fri, Oct 9, 9:12 AM
christos requested review of D60507: sound: Busy devices before giving up the topology lock.
Fri, Oct 9, 8:48 AM
christos abandoned D60506: sound: Drop the topology lock after busying the device.

Sorry for the noise.

Fri, Oct 9, 8:44 AM
christos requested review of D60506: sound: Drop the topology lock after busying the device.
Fri, Oct 9, 8:41 AM
christos abandoned D60466: sound: Hold the topology lock across dsp_oss_audioinfo().
Fri, Oct 9, 8:41 AM
christos abandoned D60465: sound: Busy the device being inspected, not the caller's.
Fri, Oct 9, 8:41 AM
christos updated the diff for D60465: sound: Busy the device being inspected, not the caller's.

Stop taking the sx unnecessarily for the device the ioctl has been issued on,
and instead take it for every device being inspected when needed.

Fri, Oct 9, 8:40 AM
christos retitled D60465: sound: Busy the device being inspected, not the caller's from sound: Drop the topology lock after busying the device to sound: Busy the device being inspected, not the caller's.
Fri, Oct 9, 8:39 AM
christos updated the diff for D60410: Status/2026Q3/cuse.adoc: Add report.

Address Joe's comment.

Fri, Oct 9, 8:23 AM
christos requested review of D60505: sound: Shut the channels down with the device busied.
Fri, Oct 9, 7:43 AM

Thu, Oct 8

christos committed rG20381bce4b63: sound: Remove obsolete comment from sound.h (authored by christos).
sound: Remove obsolete comment from sound.h
Thu, Oct 8, 1:12 PM
christos requested review of D60466: sound: Hold the topology lock across dsp_oss_audioinfo().
Thu, Oct 8, 1:10 PM
christos requested review of D60465: sound: Busy the device being inspected, not the caller's.
Thu, Oct 8, 1:09 PM
christos added a comment to D60442: sound: Whitespace cleanup.

I am aware of the first 2 MFCs, I'm holding off to commit them along with the 1 month ones.

Thu, Oct 8, 12:45 PM
christos requested review of D60464: snd_maestro3: Do not hold sc_lock across the hwvol handlers.
Thu, Oct 8, 12:28 PM
christos retitled D60129: sound: Move channel teardown functions from sound.c to channel.c from sound: Move channel teardown functions from sound.c to sound.c to sound: Move channel teardown functions from sound.c to channel.c.
Thu, Oct 8, 12:06 PM
christos updated the diff for D60128: sound: Convert the SD_F_BUSY cv to an sx.

Merge with D60127 and address Mark's comments from there.

Thu, Oct 8, 12:02 PM
christos abandoned D60127: sound: Do not take PCM_LOCK just to busy the device.
Thu, Oct 8, 12:02 PM
christos updated the summary of D60128: sound: Convert the SD_F_BUSY cv to an sx.
Thu, Oct 8, 12:02 PM

Wed, Oct 7

christos updated the diff for D60120: sound: Drain the dsp cdev before freeing resources.

Address Mark's comment and also use PCM_ACQUIRE_QUICK() before pcm_killchans() instead of duplicating what it does.

Wed, Oct 7, 5:00 PM
christos accepted D60442: sound: Whitespace cleanup.

Please make sure to MFC this. Thanks.

Wed, Oct 7, 4:54 PM
christos committed rG26203cca5262: rc.d/mountd: Do not require /etc/exports (authored by christos).
rc.d/mountd: Do not require /etc/exports
Wed, Oct 7, 4:54 PM
christos closed D60044: rc.d/mountd: Do not require /etc/exports.
Wed, Oct 7, 4:54 PM
christos updated the diff for D60044: rc.d/mountd: Do not require /etc/exports.

Address Mateusz's and Rick's comments.

Wed, Oct 7, 11:08 AM
christos retitled D60044: rc.d/mountd: Do not require /etc/exports from rc.d/mountd: Require /etc/exports only when there is no other exports file to rc.d/mountd: Do not require /etc/exports.
Wed, Oct 7, 11:08 AM
christos accepted D60408: dwatch(1): Use mdo(1) instead of sudo(8) when configured.
Wed, Oct 7, 10:54 AM
christos committed rG25faf861089c: pcm.4: Remove DIAGNOSTICS section (authored by christos).
pcm.4: Remove DIAGNOSTICS section
Wed, Oct 7, 7:04 AM
christos accepted D60197: audio/pulseaudio: improve OSS support.

The mixer knobs are a bit confusing since they are part of the legacy OSS API, but typically vol controls the hardware master volume, and pcm the software volume, usually from applications and sound(4) virtual channels.

Wed, Oct 7, 6:59 AM
christos added inline comments to D60127: sound: Do not take PCM_LOCK just to busy the device.
Wed, Oct 7, 6:40 AM
christos added inline comments to D49002: snd_hda(4): Add quirks for Lenovo ThinkBooks and ASUS TUFs.
Wed, Oct 7, 6:32 AM
christos committed rG2cb963ee8d15: cuse: Implement hot-unload (authored by christos).
cuse: Implement hot-unload
Wed, Oct 7, 6:25 AM
christos committed rGc97799277650: cuse: Rename cuse_server_free() to cuse_server_dtor() (authored by christos).
cuse: Rename cuse_server_free() to cuse_server_dtor()
Wed, Oct 7, 6:25 AM
christos committed rG58ca5e461c6e: cuse: Assert the server refcount (authored by christos).
cuse: Assert the server refcount
Wed, Oct 7, 6:25 AM
christos committed rG1c6b48130d9a: cuse: Use make_dev_s() to create client devices (authored by christos).
cuse: Use make_dev_s() to create client devices
Wed, Oct 7, 6:25 AM
christos committed rGf9669d9986a1: cuse: Retire unnecessary CUSE_VERSION (authored by christos).
cuse: Retire unnecessary CUSE_VERSION
Wed, Oct 7, 6:25 AM
christos committed rG8b462fa2d3e7: cuse: Remove unnecessary semicolon in cuse_convert_error() (authored by christos).
cuse: Remove unnecessary semicolon in cuse_convert_error()
Wed, Oct 7, 6:25 AM
christos committed rGba847a03d607: cuse: Improve server cleanup (authored by christos).
cuse: Improve server cleanup
Wed, Oct 7, 6:25 AM
christos committed rG4772247a4f74: cuse: Actually use cuse_modevent() (authored by christos).
cuse: Actually use cuse_modevent()
Wed, Oct 7, 6:25 AM
christos committed rGb1aea70753bc: cuse: Fix hang on readv(2) and writev(2) with multiple iovecs (authored by christos).
cuse: Fix hang on readv(2) and writev(2) with multiple iovecs
Wed, Oct 7, 6:25 AM
christos committed rG598eb6719091: cuse: Create /dev/cuse with MAKEDEV_CHECKNAME (authored by christos).
cuse: Create /dev/cuse with MAKEDEV_CHECKNAME
Wed, Oct 7, 6:25 AM

Tue, Oct 6

christos requested review of D60410: Status/2026Q3/cuse.adoc: Add report.
Tue, Oct 6, 2:14 PM
christos requested review of D60409: Status/2026Q3/audio.adoc: Add report.
Tue, Oct 6, 2:14 PM

Mon, Oct 5

christos added inline comments to D60127: sound: Do not take PCM_LOCK just to busy the device.
Mon, Oct 5, 5:29 PM

Wed, Sep 30

christos committed rGb55b6e1d727b: cuse: Rename cuse_server_free() to cuse_server_dtor() (authored by christos).
cuse: Rename cuse_server_free() to cuse_server_dtor()
Wed, Sep 30, 9:52 AM
christos committed rGf96c4f45f791: cuse: Assert the server refcount (authored by christos).
cuse: Assert the server refcount
Wed, Sep 30, 9:52 AM
christos committed rGd38ef1aca969: cuse: Implement hot-unload (authored by christos).
cuse: Implement hot-unload
Wed, Sep 30, 9:52 AM
christos committed rGfad756fd200b: cuse: Use make_dev_s() to create client devices (authored by christos).
cuse: Use make_dev_s() to create client devices
Wed, Sep 30, 9:52 AM
christos committed rG34b00da59b8f: cuse: Retire unnecessary CUSE_VERSION (authored by christos).
cuse: Retire unnecessary CUSE_VERSION
Wed, Sep 30, 9:52 AM
christos committed rGe923a30ecf2a: cuse: Remove unnecessary semicolon in cuse_convert_error() (authored by christos).
cuse: Remove unnecessary semicolon in cuse_convert_error()
Wed, Sep 30, 9:52 AM
christos committed rG40431ec4da1d: cuse: Improve server cleanup (authored by christos).
cuse: Improve server cleanup
Wed, Sep 30, 9:52 AM
christos committed rG3b3e6473b130: cuse: Create /dev/cuse with MAKEDEV_CHECKNAME (authored by christos).
cuse: Create /dev/cuse with MAKEDEV_CHECKNAME
Wed, Sep 30, 9:52 AM
christos closed D60043: cuse: Assert the server refcount.
Wed, Sep 30, 9:52 AM
christos closed D60022: cuse: Implement hot-unload.
Wed, Sep 30, 9:52 AM
christos committed rG2fd8d2eb7bb9: cuse: Actually use cuse_modevent() (authored by christos).
cuse: Actually use cuse_modevent()
Wed, Sep 30, 9:52 AM
christos closed D59874: cuse: Use make_dev_s() to create client devices.
Wed, Sep 30, 9:51 AM
christos committed rG872c36cb6f2d: cuse: Fix hang on readv(2) and writev(2) with multiple iovecs (authored by christos).
cuse: Fix hang on readv(2) and writev(2) with multiple iovecs
Wed, Sep 30, 9:51 AM
christos closed D59872: cuse: Improve server cleanup.
Wed, Sep 30, 9:51 AM
christos closed D59863: cuse: Create /dev/cuse with MAKEDEV_CHECKNAME.
Wed, Sep 30, 9:51 AM
christos closed D59862: cuse: Actually use cuse_modevent().
Wed, Sep 30, 9:51 AM
christos closed D59822: cuse: Fix hang on readv(2) and writev(2) with multiple iovecs.
Wed, Sep 30, 9:51 AM

Tue, Sep 29

christos requested review of D60129: sound: Move channel teardown functions from sound.c to channel.c.
Tue, Sep 29, 1:42 PM
christos retitled D60127: sound: Do not take PCM_LOCK just to busy the device from sound: Do not take PCM_LOCK just to mark the device busy to sound: Do not take PCM_LOCK just to busy the device.
Tue, Sep 29, 1:20 PM
christos requested review of D60128: sound: Convert the SD_F_BUSY cv to an sx.
Tue, Sep 29, 1:19 PM
christos requested review of D60127: sound: Do not take PCM_LOCK just to busy the device.
Tue, Sep 29, 1:19 PM
christos requested review of D60121: sound: Retire pcm_channel->sleeping.
Tue, Sep 29, 12:26 PM
christos added a comment to D60120: sound: Drain the dsp cdev before freeing resources.

This fixes the issues mentioned in https://ron-dev.freebsd.org/FreeBSD/src/pulls/13.

Tue, Sep 29, 12:02 PM
christos requested review of D60120: sound: Drain the dsp cdev before freeing resources.
Tue, Sep 29, 12:02 PM
christos added a comment to D60022: cuse: Implement hot-unload.

Thanks, if you can, give D59872 a review as well and I will commit those now. :)

Tue, Sep 29, 11:02 AM
christos added a comment to D60022: cuse: Implement hot-unload.
In D60022#1379019, @kib wrote:

Just a question, did you tested d_purge with the WITNESS kernel?

Tue, Sep 29, 10:32 AM
christos added a comment to D60044: rc.d/mountd: Do not require /etc/exports.

@rmacklem I see that you have many commits to NFS, so the question would better be what do you think is best here. I'm not sure what is best either. My patch looks like a hack on one hand, but I do agree about the empty file being mistaken for unnecessary. Could you document this with a comment inside the empty file?

Tue, Sep 29, 10:27 AM
christos committed rG77b75400324d: snd_uaudio: Read the UAC2 sample rate back after setting it (authored by christos).
snd_uaudio: Read the UAC2 sample rate back after setting it
Tue, Sep 29, 10:16 AM

Mon, Sep 28

christos updated the diff for D60044: rc.d/mountd: Do not require /etc/exports.

Address Rick's comments.

Mon, Sep 28, 11:18 AM
christos updated the summary of D60044: rc.d/mountd: Do not require /etc/exports.
Mon, Sep 28, 11:16 AM
christos updated the diff for D59872: cuse: Improve server cleanup.

Address Konstantin's comments.

Mon, Sep 28, 10:38 AM
christos added inline comments to D59872: cuse: Improve server cleanup.
Mon, Sep 28, 10:36 AM
christos updated the diff for D60043: cuse: Assert the server refcount.

Assert that ref == 0 when the server is freed.

Mon, Sep 28, 10:35 AM
christos retitled D60043: cuse: Assert the server refcount from cuse: Assert that the server refcount does not underflow to cuse: Assert the server refcount.
Mon, Sep 28, 10:34 AM
christos updated the diff for D60022: cuse: Implement hot-unload.

Use d_purge.

Mon, Sep 28, 10:05 AM