User Details
- User Since
- Jul 2 2021, 4:03 PM (231 w, 5 d)
Yesterday
Linux defines eventfd_ctx as:
struct eventfd_ctx {
struct kref kref;
wait_queue_head_t wqh;
/*
* Every time that a write(2) is performed on an eventfd, the
* value of the __u64 being written is added to "count" and a
* wakeup is performed on "wqh". If EFD_SEMAPHORE flag was not
* specified, a read(2) will return the "count" value to userspace,
* and will reset "count" to zero. The kernel side eventfd_signal()
* also, adds to the "count" counter and issue a wakeup.
*/
__u64 count;
unsigned int flags;
int id;
};This is quite different from our version. Although ugly, wouldn't it be safer to either explicitly alias it in LinuxKPI or even translate it there?
Mon, Dec 8
Abandoned D54134. Update.
LGTM. Please take a look at the inline comments.
Sat, Dec 6
Thu, Dec 4
Refer to xo_options(7), not libxo(3).
We can have this check for SNDCTL_DSP_CHANNELS as well. Also the commit title and message have to be adapted.
Tue, Dec 2
You can extend this to the rest of the settings in this patch.
Update man page as well.
Bump. Again, this is problematic when running with -v parallelism because it might unload snd_dummy when the other tests are using it.
Are you working on the timing issues? I haven't really looked into those.
Fri, Nov 28
I think this needs to be rebased since we committed the oss.h changes.
Thu, Nov 27
Wed, Nov 26
Mon, Nov 24
Sun, Nov 23
Fri, Nov 21
Bring back lock.h
PCM_ACQUIRE() sets the SD_F_BUSY flag, which more or less works as a sleepable lock. I do not really see the purpose of doing that here. Also I do not see the purpose of locking at the start of the function, just to read d->flags & SD_F_BITPERFECT.
- Bring back sys/types.h in midi.h.
- Do not include sys/types.h where sys/param.h is included.
- Sort includes alphabetically after sys/param.h and sys/systm.h.