Fix typos.

Fix struct indentation.

Fix return offset handling.

Forgot to update the second table as well.

Address yuripv's comment.

Address comments.

Address comments.

Address Mark's comment.

Address comments, fix stuff that was also fixed in riscv.

Update

Address Mark's comments. Depends on D40962.

Explain why ADR and ADRP are disabled.

Improve state chaching. Depends on D40962.

Free trampoline when the probe is destroyed. Declare kinst_cpu_state to support
the double-breakpoint mechanism.

Explain why

cpu_switch() was able to be traced in arm64 and riscv, and as is expected, resulted in crashes.

Mention unsafe-to-trace functions and instructions, as well as ADR/ADRP bug in
arm64.

Disable adr/adrp emulation.

Remove BUGS section since per-probe trampolines seem to have fixed it.

Use per-probe trampolines. Depends on D40962

s/vm_page_mvqueue/critical_enter/

Updated description, still some unsolved bugs, but mostly done.

Had no idea this existed. Thanks!

In D39884#930242, @jrtc27 wrote:

Is it just a case of needing to smp_rendezvous a fence_i since it's not broadcast by the hardware like on arm64?

In D39884#930225, @mhorne wrote:

In D39884#928340, @markj wrote:

This provider can trigger what appears to be a QEMU/TCG bug. The test case:

• boot a riscv VM with more than one vCPU
• run dtrace -q -n 'kinst::riscv_cpu_intr:', i.e., trace all instructions in riscv_cpu_intr()

Seems I was a bit slow to report my findings, but I did observe some of the same kinds of panics on real hardware that I saw in QEMU. I will update to the committed version and provide a more detailed answer of what is still not working.

Updates.

Retain CDDL license.

Retain original CDDL license.

In D40875#930146, @markj wrote:

At least kinst.* was derived from an existing CDDL-licensed provider, so I think it's not so clear-cut. I would keep that file CDDL-licensed. kinst_isa.* and trampoline.* could be relicensed, but I'll leave it up to you.

Forgot to link arch(7).

Address Mark's comments.

In D40875#930131, @markj wrote:

You are changing the license from CDDL (i.e., derived from illumos dtrace code) to BSD. I believe the correct change would be to retain the existing license and simply add the foundation's copyright.

Restore original trampoline size.

Improve BUGS section.

Add arm64 here as well

Improve description.

WIP.

Address comments, update LICENSE headers, split some changes to other PRs.

Address Mitchell's comment.