Address Mark's comments.

In D60517#1396598, @markj wrote:

Seems ok. It would be nicer to annotate individual fields like we do for other structures, see struct vm_page for instance.

Address Mark's comments.

Address Mark's comments.

Reopening after discussion in D61141.

Address Mark's comments.

Squashed.

Remove "KERNEL".

Bug reported is happy with the patch.

In D61141#1402118, @markj wrote:

Certainly this commit should be MFCed to stable/15 and 14 at minimum.

In D61141#1401766, @markj wrote:

This is fine, but it won't help older versions of FreeBSD which use vmm to boot a newer FreeBSD guest. I think this will still need a workaround in hwpmc, gated on vm_guest == VM_GUEST_BHYVE.

@markj I haven't tested this patch yet. If you can spin up a -CURRENT host and try it today please let me know, otherwise I can test it tomorrow.

In D61133#1401454, @kib wrote:

No, I do not think this is right. The problem is that VMM declare the capability while it does not implement it. So the fix must be in bhyve and not in consumers.

In D60527#1389035, @christos wrote:

Address Ed's comments. Note that hdaa_update_coef() now closely resembles
Linux's equivalent:

static void __alc_update_coefex_idx(struct hda_codec *codec, hda_nid_t nid,
				    unsigned int coef_idx, unsigned int mask,
				    unsigned int bits_set)
{
	unsigned int val = __alc_read_coefex_idx(codec, nid, coef_idx);

	if (val != -1)
		__alc_write_coefex_idx(codec, nid, coef_idx,
				       (val & ~mask) | bits_set);
}

@emaste, could that be a problem?

Also updated the commit message but it doesn't update automatically. I removed
the "Obtained by:" and added the following lines:

Linux commit 5a36767 used as a reference.

See also:       https://github.com/torvalds/linux/commit/5a36767a41650518f35ea0bae9a2d6e775f1aed1

LGTM. Did you test that everything works properly now?

I renamed the commit "sound examples" instead of just "sound", so make sure to update it in your local tree as well. That being said, unless I'm missing something, the commit message is misleading. You are saying "don't trigger the device unconditionally" but your patch removes triggering altogether. I know the syncgroup will do the triggering itself, but the title suggests that we keep some manual triggering, just not unconditionally, which is not exactly the case.

In D60442#1387035, @christos wrote:

I am aware of the first 2 MFCs, I'm holding off to commit them along with the 1 month ones.

Friendly bump for this and the rest of the stack.

Also please include a small paragraph about the chn_resizebuf() changes in the commit message and/or in the code.

From what I understand, the issue is that because this is not bhyve-internal memory, but entries we read from the guest's memory, we want to make sure these values are read at that point exactly, so that we don't let the compiler re-read them later when the value might have been changed?

Address Ed's comments. Note that hdaa_update_coef() now closely resembles
Linux's equivalent:

I had to add hda_update_coef() for a patch I'm working on (D60527), so we can hold off this one, and rebase it once I commit it.

Sorry for the noise.

Stop taking the sx unnecessarily for the device the ioctl has been issued on,
and instead take it for every device being inspected when needed.

Address Joe's comment.