Page MenuHomeFreeBSD

christos (Christos Margiolis)
User

Projects

User Details

User Since
Jul 2 2021, 4:03 PM (210 w, 5 d)

Recent Activity

Yesterday

christos updated the diff for D50070: snd_hda: Implement automatic redirection between associations.

Publish rebased version. I had it rebased but forgot to update the diff here...

Tue, Jul 15, 7:48 PM
christos added a comment to D51240: snd_uaudio.4: Rework SYNOPSIS, add HARDWARE, SPDX.

I am actually not sure why we need to show default values in the SYNOPSIS section. As is explained in SYSCTL VARIABLES, sometimes a value of 0 has special meaning. I am actually not sure of the advantage of including those in the SYNOPSIS in the first place, since we enumerate right below almost. But if we are to list them, I do not think we should provide values as well.

Tue, Jul 15, 1:14 PM
christos accepted D50922: dtrace_fbt.4: Document the DTrace fbt provider.
Tue, Jul 15, 1:11 PM · DTrace

Mon, Jul 14

christos accepted D51278: dtrace_profile.4: Document the DTrace profile provider.
Mon, Jul 14, 3:47 PM
christos accepted D51301: dtrace.1: Document evaltime.
Mon, Jul 14, 3:46 PM
christos added inline comments to D51301: dtrace.1: Document evaltime.
Mon, Jul 14, 3:21 PM
christos added a comment to D51301: dtrace.1: Document evaltime.

In the first paragraph it is not immediately clear (to me at least) what this variable actually does. I especially get quite confused with what "newly started child process" means. Does it refer to the command defined in -c cmd? Or is it something else? I think the wording needs some improvement there.

Mon, Jul 14, 3:05 PM
christos accepted D51268: d.7: Document the DTrace scripting language.
Mon, Jul 14, 12:26 PM · docs, DTrace
christos committed rGb5ec6cda9380: fortune: Fix typo in dmesgd.nycbug.org example (authored by christos).
fortune: Fix typo in dmesgd.nycbug.org example
Mon, Jul 14, 12:18 PM
christos added inline comments to D51268: d.7: Document the DTrace scripting language.
Mon, Jul 14, 12:17 PM · docs, DTrace

Sun, Jul 13

christos committed rG697bf0f416e4: fortune: Fix typo in dmesgd.nycbug.org example (authored by christos).
fortune: Fix typo in dmesgd.nycbug.org example
Sun, Jul 13, 9:27 PM
christos closed D51293: fortune: Fix typo in dmesgd.nycbug.org example.
Sun, Jul 13, 9:27 PM
christos added a comment to D51293: fortune: Fix typo in dmesgd.nycbug.org example.

I think in this case we could still commit this for correctness.

Sun, Jul 13, 9:24 PM
christos added a comment to D51293: fortune: Fix typo in dmesgd.nycbug.org example.
In D51293#1171363, @imp wrote:

I think this is good.

Sun, Jul 13, 7:39 PM
christos added a comment to D51293: fortune: Fix typo in dmesgd.nycbug.org example.

This is actually a question patch. I'm not sure if this is really a typo or not.

Sun, Jul 13, 6:50 PM
christos requested review of D51293: fortune: Fix typo in dmesgd.nycbug.org example.
Sun, Jul 13, 6:49 PM
christos added a comment to D50070: snd_hda: Implement automatic redirection between associations.

Regarding @jrtc27's recommendation to let audio/virtual_oss install the devd script to /usr/local/etc, since virtual_oss will be ported to base soon, we can leave it as is.

Sun, Jul 13, 6:31 PM
christos added inline comments to D51240: snd_uaudio.4: Rework SYNOPSIS, add HARDWARE, SPDX.
Sun, Jul 13, 6:29 PM
christos accepted D51267: dtrace_dtrace.4: Document the DTrace dtrace provider.

I haven't checked mandoc -Tlint, but make sure there are no errors there as well.

Sun, Jul 13, 4:29 PM · docs, DTrace
christos added inline comments to D51240: snd_uaudio.4: Rework SYNOPSIS, add HARDWARE, SPDX.
Sun, Jul 13, 4:28 PM
christos added inline comments to D51240: snd_uaudio.4: Rework SYNOPSIS, add HARDWARE, SPDX.
Sun, Jul 13, 3:06 PM
christos added inline comments to D51267: dtrace_dtrace.4: Document the DTrace dtrace provider.
Sun, Jul 13, 3:04 PM · docs, DTrace
christos added inline comments to D50922: dtrace_fbt.4: Document the DTrace fbt provider.
Sun, Jul 13, 2:59 PM · DTrace
christos added inline comments to D51278: dtrace_profile.4: Document the DTrace profile provider.
Sun, Jul 13, 2:47 PM
christos added inline comments to D51268: d.7: Document the DTrace scripting language.
Sun, Jul 13, 2:40 PM · docs, DTrace
christos accepted D51262: HW Relnotes: Move uaudio to Sound.
Sun, Jul 13, 2:29 PM
christos closed D51040: Status/2025Q2/audio.adoc: Add report.

I accidentally committed without git-arc-stage... apologies.

Sun, Jul 13, 2:29 PM
christos committed R9:88a97b663a28: Status/2025Q2/audio.adoc: Add report (authored by christos).
Status/2025Q2/audio.adoc: Add report
Sun, Jul 13, 2:28 PM

Mon, Jul 7

christos added a comment to D51040: Status/2025Q2/audio.adoc: Add report.

Bump.

Mon, Jul 7, 10:24 PM

Sun, Jul 6

christos committed rG3ba480f41801: sound: Retire SND_DEV_* (authored by christos).
sound: Retire SND_DEV_*
Sun, Jul 6, 1:10 PM
christos committed rG92336491ccc2: sound: Remove dead printfs from midi/mpu401.c (authored by christos).
sound: Remove dead printfs from midi/mpu401.c
Sun, Jul 6, 1:10 PM
christos committed rG9a138abb21e1: sound: Remove unused midi_cmdname() (authored by christos).
sound: Remove unused midi_cmdname()
Sun, Jul 6, 1:10 PM
christos committed rGc566edbceb69: sound: Remove unnecessary comments from midi/midi.c (authored by christos).
sound: Remove unnecessary comments from midi/midi.c
Sun, Jul 6, 1:10 PM
christos committed rGfa20737ed1b7: sound: Remove unused mpu_if methods (authored by christos).
sound: Remove unused mpu_if methods
Sun, Jul 6, 1:09 PM
christos committed rG17b38023ea25: sound: Remove duplicate mpu_if.h include (authored by christos).
sound: Remove duplicate mpu_if.h include
Sun, Jul 6, 1:09 PM
christos committed rG0ca9410eab24: sound: Retire unused MIDI sysctls (authored by christos).
sound: Retire unused MIDI sysctls
Sun, Jul 6, 1:09 PM
christos closed D50690: sound: Retire SND_DEV_*.
Sun, Jul 6, 1:09 PM
christos closed D50617: sound: Remove dead printfs from midi/mpu401.c.
Sun, Jul 6, 1:09 PM
christos committed rG7f1426971e30: sound: Retire /dev/midistat (authored by christos).
sound: Retire /dev/midistat
Sun, Jul 6, 1:09 PM
christos closed D50616: sound: Remove unused midi_cmdname().
Sun, Jul 6, 1:09 PM
christos committed rG6cdd3226c718: sound: Retire midisynth (authored by christos).
sound: Retire midisynth
Sun, Jul 6, 1:09 PM
christos closed D50615: sound: Remove unnecessary comments from midi/midi.c.
Sun, Jul 6, 1:09 PM
christos closed D50613: sound: Remove duplicate mpu_if.h include.
Sun, Jul 6, 1:09 PM
christos closed D50612: sound: Remove unused mpu_if methods.
Sun, Jul 6, 1:09 PM
christos committed rG79b968063998: sound: Retire the MIDI sequencer (authored by christos).
sound: Retire the MIDI sequencer
Sun, Jul 6, 1:09 PM
christos closed D50611: sound: Retire unused MIDI sysctls.
Sun, Jul 6, 1:09 PM
christos closed D50610: sound: Retire /dev/midistat.
Sun, Jul 6, 1:09 PM
christos closed D50609: sound: Retire midisynth.
Sun, Jul 6, 1:09 PM
christos closed D50605: sound: Retire the MIDI sequencer.
Sun, Jul 6, 1:09 PM

Tue, Jul 1

christos added a comment to D38825: libdtrace: Implement inline function tracing for kinst.

Bump.

Tue, Jul 1, 3:48 PM · DTrace

Sun, Jun 29

christos updated the test plan for D50070: snd_hda: Implement automatic redirection between associations.
Sun, Jun 29, 2:02 PM
christos added a comment to D50070: snd_hda: Implement automatic redirection between associations.

Bump. Please let me know in case you test.

Sun, Jun 29, 2:01 PM
christos updated the diff for D51040: Status/2025Q2/audio.adoc: Add report.

Address comments.

Sun, Jun 29, 1:49 PM

Sat, Jun 28

christos accepted D50946: style.mdoc.5: xref mdoc extended documentation.

LGTM. Shouldn't you also the bump the date?

Sat, Jun 28, 2:18 PM
christos added a reviewer for D50615: sound: Remove unnecessary comments from midi/midi.c: vishwin.
Sat, Jun 28, 2:17 PM
christos added a reviewer for D50612: sound: Remove unused mpu_if methods: vishwin.
Sat, Jun 28, 2:17 PM
christos added a reviewer for D50611: sound: Retire unused MIDI sysctls: vishwin.
Sat, Jun 28, 2:16 PM
christos added a reviewer for D50610: sound: Retire /dev/midistat: vishwin.
Sat, Jun 28, 2:16 PM
christos added a reviewer for D50609: sound: Retire midisynth: vishwin.
Sat, Jun 28, 2:16 PM

Wed, Jun 25

christos requested review of D51040: Status/2025Q2/audio.adoc: Add report.
Wed, Jun 25, 2:06 PM

Fri, Jun 20

christos added inline comments to D50922: dtrace_fbt.4: Document the DTrace fbt provider.
Fri, Jun 20, 1:42 PM · DTrace

Thu, Jun 19

christos added a comment to D50046: snd_hda: Apply fixes for Macbook Air 6,1 and 6,2.

@adrian Bump.

Thu, Jun 19, 12:33 AM
christos added a comment to D50605: sound: Retire the MIDI sequencer.

Bump (also for the other MIDI patches).

Thu, Jun 19, 12:33 AM
christos added a comment to D50922: dtrace_fbt.4: Document the DTrace fbt provider.
  • A few lines can be merged and still not exceed 80 columns.
  • I feel like the underlying message in the DESCRIPTION and IMPLEMENTATION NOTES paragraphs is that FBT should be used with caution, and that's it particularly hard to use. Maybe we should improve the wording on that.
Thu, Jun 19, 12:31 AM · DTrace

Tue, Jun 17

christos accepted D50709: beep: Capsicumize.
Tue, Jun 17, 6:11 PM

Jun 14 2025

christos accepted D50854: tracing.7: Add a single reference point for tracing facilities in FreeBSD.
Jun 14 2025, 6:45 PM
christos added inline comments to D50854: tracing.7: Add a single reference point for tracing facilities in FreeBSD.
Jun 14 2025, 5:57 PM
christos requested changes to D50854: tracing.7: Add a single reference point for tracing facilities in FreeBSD.
Jun 14 2025, 5:53 PM
christos accepted D50854: tracing.7: Add a single reference point for tracing facilities in FreeBSD.

LGTM with some minor nitpicks.

Jun 14 2025, 5:47 PM
christos accepted D50852: dtrace.1: Mention providers in SEE ALSO.
Jun 14 2025, 5:29 PM

Jun 13 2025

christos committed rG4027e17c1795: snd_hda: Patch Lenovo T420s (authored by christos).
snd_hda: Patch Lenovo T420s
Jun 13 2025, 12:32 PM
christos committed rGf482411563d6: snd_hda: fix attaching to some AMD Radeon GPUs (authored by se).
snd_hda: fix attaching to some AMD Radeon GPUs
Jun 13 2025, 12:32 PM

Jun 12 2025

christos committed rG84e730744127: snd_hda: Patch Lenovo T420s (authored by christos).
snd_hda: Patch Lenovo T420s
Jun 12 2025, 11:03 PM
christos added a comment to D50605: sound: Retire the MIDI sequencer.

Radio silence in the mailing lists. I take this as we are good to go. :-)

Jun 12 2025, 1:57 PM
christos added a comment to D50737: Make HDMI audio work on some AMD graphic cards.

I will take care of MFC'ing this to stable/14. Thanks.

Jun 12 2025, 1:24 PM
christos accepted D48503: snd_hda.4: Improve HARDWARE for HW Relnotes.
Jun 12 2025, 12:50 AM
christos committed rG65b472e58cd5: sound: Add AFMT_FLOAT to feed_volume_info_tab (authored by christos).
sound: Add AFMT_FLOAT to feed_volume_info_tab
Jun 12 2025, 12:47 AM
christos accepted D50737: Make HDMI audio work on some AMD graphic cards.

My own Radeon HDMI worked fine even before the patch, but with the patch it still works.

Jun 12 2025, 12:46 AM
christos added inline comments to D48503: snd_hda.4: Improve HARDWARE for HW Relnotes.
Jun 12 2025, 12:16 AM

Jun 11 2025

christos added a reviewer for D50605: sound: Retire the MIDI sequencer: vishwin.
Jun 11 2025, 5:12 PM
christos committed rG4a7b8cd7057f: sound: Add AFMT_FLOAT to feed_volume_info_tab (authored by christos).
sound: Add AFMT_FLOAT to feed_volume_info_tab
Jun 11 2025, 5:11 PM
christos closed D50793: sound: Add AFMT_FLOAT to feed_volume_info_tab.
Jun 11 2025, 5:11 PM
christos added a comment to D50737: Make HDMI audio work on some AMD graphic cards.

The right diff's path seems messed up ("i/sys/..."), could you please fix that first?

Jun 11 2025, 3:32 PM
christos requested review of D50793: sound: Add AFMT_FLOAT to feed_volume_info_tab.
Jun 11 2025, 2:35 PM

Jun 6 2025

christos added a comment to D50690: sound: Retire SND_DEV_*.

I assume it just works fine? :-)

Jun 6 2025, 3:19 PM
christos added a reviewer for D50690: sound: Retire SND_DEV_*: imp.
Jun 6 2025, 3:03 PM
christos added a comment to D50709: beep: Capsicumize.

What is the rationale behind this change?

Jun 6 2025, 3:02 PM

Jun 4 2025

christos requested review of D50690: sound: Retire SND_DEV_*.
Jun 4 2025, 7:45 PM
christos closed D50689: audio/virtual_oss: Fix rc script style.
Jun 4 2025, 7:18 PM
christos committed R11:8ea5313ee87c: audio/virtual_oss: Fix rc script style (authored by christos).
audio/virtual_oss: Fix rc script style
Jun 4 2025, 7:18 PM
christos requested review of D50689: audio/virtual_oss: Fix rc script style.
Jun 4 2025, 7:13 PM
christos added a comment to D50605: sound: Retire the MIDI sequencer.

Does this removal warrant some post on -current or so to make sure no one's using it?

Jun 4 2025, 4:22 PM

Jun 3 2025

christos closed D50635: audio/virtual_oss: Start service after ldconfig.
Jun 3 2025, 10:32 AM
christos committed R11:7b5548779bb1: audio/virtual_oss: Start service after ldconfig (authored by christos).
audio/virtual_oss: Start service after ldconfig
Jun 3 2025, 10:32 AM

Jun 2 2025

christos added a comment to D50605: sound: Retire the MIDI sequencer.

Does this removal warrant some post on -current or so to make sure no one's using it?

Jun 2 2025, 4:52 PM

Jun 1 2025

christos requested review of D50635: audio/virtual_oss: Start service after ldconfig.
Jun 1 2025, 2:40 PM

May 31 2025

christos committed rGab9c9443eec5: sound: Deprecate the MIDI sequencer (authored by christos).
sound: Deprecate the MIDI sequencer
May 31 2025, 7:30 PM

May 30 2025

christos updated the diff for D50617: sound: Remove dead printfs from midi/mpu401.c.

Remove all dead printfs from this file.

May 30 2025, 6:58 PM
christos retitled D50617: sound: Remove dead printfs from midi/mpu401.c from sound: Remove unused D() macro from midi/mpu401.c to sound: Remove dead printfs from midi/mpu401.c.
May 30 2025, 6:58 PM
christos requested review of D50617: sound: Remove dead printfs from midi/mpu401.c.
May 30 2025, 6:56 PM