Page MenuHomeFreeBSD

christos (Christos Margiolis)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 2 2021, 4:03 PM (65 w, 5 d)

Recent Activity

Tue, Oct 4

christos accepted D36851: kinst: Initial revision.
Tue, Oct 4, 5:32 PM

Sun, Oct 2

christos accepted D36853: kinst: Add a manual page.
Sun, Oct 2, 12:32 PM
christos accepted D36852: libdtrace: Add kinst support.

LGTM

Sun, Oct 2, 12:32 PM
christos added inline comments to D36851: kinst: Initial revision.
Sun, Oct 2, 12:27 PM

Sat, Oct 1

christos abandoned D35827: dtrace: implement kinst.

Moved to D36851

Sat, Oct 1, 3:57 PM
christos accepted D36799: dtrace: Add a "regs" variable.

LGTM!

Sat, Oct 1, 10:33 AM

Aug 16 2022

christos added a comment to D35281: dtrace, drti, libdtrace: fix type redefintion errors.

Bump.

Aug 16 2022, 12:33 PM

Jul 16 2022

christos added inline comments to D35827: dtrace: implement kinst.
Jul 16 2022, 1:58 PM

Jul 15 2022

christos requested review of D35827: dtrace: implement kinst.
Jul 15 2022, 4:57 PM

Jun 1 2022

christos added a comment to D35101: mixer: remove volume backwards compat, add % interpretation.

One more bump for good measure. :-)

Jun 1 2022, 6:55 PM
christos updated the diff for D35281: dtrace, drti, libdtrace: fix type redefintion errors.
Jun 1 2022, 6:53 PM
christos updated the diff for D35381: dtrace: add warning for /dev/dtrace/prototype.
Jun 1 2022, 4:57 PM
christos requested review of D35381: dtrace: add warning for /dev/dtrace/prototype.
Jun 1 2022, 4:46 PM
christos requested review of D35380: dtrace: remove /dev/dtrace/profile.
Jun 1 2022, 4:38 PM
christos requested review of D35379: dtrace: remove /dev/dtrace/dtmalloc.
Jun 1 2022, 4:37 PM
christos requested review of D35377: dtrace: remove /dev/dtrace/fbt.
Jun 1 2022, 4:19 PM

May 24 2022

christos added a comment to D35281: dtrace, drti, libdtrace: fix type redefintion errors.

I think this is probably right. The build shouldn't be setting the include path this way. libdtrace and drti need similar patches.

May 24 2022, 4:29 PM

May 21 2022

christos added a comment to D35101: mixer: remove volume backwards compat, add % interpretation.

Bump.

May 21 2022, 7:52 PM
christos requested review of D35281: dtrace, drti, libdtrace: fix type redefintion errors.
May 21 2022, 7:42 PM

Apr 30 2022

christos accepted D35101: mixer: remove volume backwards compat, add % interpretation.

LGTM!

Apr 30 2022, 3:21 PM
christos added inline comments to D35101: mixer: remove volume backwards compat, add % interpretation.
Apr 30 2022, 10:45 AM
christos added a comment to D35101: mixer: remove volume backwards compat, add % interpretation.

Getting rid of the backwards compatibility which allows for both normalized
floats and the 0-100 OSS values is a good idea.

Apr 30 2022, 10:41 AM

Apr 2 2022

christos updated the diff for D34738: x11/nfy: update to newer version.

Last update. Changed WWW.

Apr 2 2022, 4:18 PM
christos updated the diff for D34738: x11/nfy: update to newer version.

Yeap, I had to distclean. Works now.

Apr 2 2022, 2:55 PM

Apr 1 2022

christos updated the diff for D34738: x11/nfy: update to newer version.
Apr 1 2022, 10:17 PM
christos updated the diff for D34738: x11/nfy: update to newer version.
Apr 1 2022, 10:13 PM
christos requested review of D34738: x11/nfy: update to newer version.
Apr 1 2022, 8:19 PM

Mar 20 2022

christos updated the diff for D34617: mixer(8): fix shorthand syntax bug.

Done.

Mar 20 2022, 6:59 PM · multimedia
christos updated the diff for D34617: mixer(8): fix shorthand syntax bug.

Combine conditions.

Mar 20 2022, 6:17 PM · multimedia
christos requested review of D34617: mixer(8): fix shorthand syntax bug.
Mar 20 2022, 6:10 PM · multimedia
christos abandoned D34613: mixer(8): move control defines into an enum.
Mar 20 2022, 6:06 PM · multimedia
christos added a comment to D34603: mixer: fix mandoc -Tlint errors.

Documented the new shorthand syntax in D34614. Depends on this revision.

Mar 20 2022, 5:17 PM · multimedia
christos requested review of D34614: mixer.8: document shorthand syntax for volume setting.
Mar 20 2022, 5:16 PM · multimedia
christos added a comment to D34603: mixer: fix mandoc -Tlint errors.

Yes.

Mar 20 2022, 4:32 PM · multimedia
christos added a comment to D34612: mixer(8): add shorthand syntax for setting the volume.

Don't push it. I also forgot to add suport for [+|-].

Mar 20 2022, 4:32 PM · multimedia
christos retitled D34613: mixer(8): move control defines into an enum from mixer(8): add control defines into an enum to mixer(8): move control defines into an enum.
Mar 20 2022, 4:28 PM · multimedia
christos requested review of D34613: mixer(8): move control defines into an enum.
Mar 20 2022, 4:27 PM · multimedia
christos updated the diff for D34612: mixer(8): add shorthand syntax for setting the volume.

Accept floating point numbers as input.

Mar 20 2022, 4:21 PM · multimedia
christos added inline comments to D34612: mixer(8): add shorthand syntax for setting the volume.
Mar 20 2022, 4:13 PM · multimedia
christos added a comment to D34591: mixer(8): remove [.volume] string from default printout.

D34612 depends on this revision.

Mar 20 2022, 4:07 PM · multimedia
christos requested review of D34612: mixer(8): add shorthand syntax for setting the volume.
Mar 20 2022, 4:05 PM · multimedia

Mar 18 2022

christos added a comment to D33609: x11/nfy: change maintainer address.

No worries!

Mar 18 2022, 7:38 PM
christos updated the diff for D34603: mixer: fix mandoc -Tlint errors.

Ran igor(1) on both mixer.8 and mixer.3. The line changes were made because mandoc -Tlint was printing warnings, so I wanted them to go away. :-)

Mar 18 2022, 2:56 PM · multimedia
christos updated the diff for D34603: mixer: fix mandoc -Tlint errors.

Fixed.

Mar 18 2022, 2:44 PM · multimedia
christos added a reviewer for D34603: mixer: fix mandoc -Tlint errors: 0mp.
Mar 18 2022, 1:54 PM · multimedia
christos requested review of D34603: mixer: fix mandoc -Tlint errors.
Mar 18 2022, 1:51 PM · multimedia
christos abandoned D32499: sound(4): Apply mixer patches in 13.0-RELEASE.

Alright then, we can abandon it!

Mar 18 2022, 1:25 PM · multimedia
christos added a comment to D32499: sound(4): Apply mixer patches in 13.0-RELEASE.

Mostly for completeness, but we can abandon it if 13.1 is close to release.

Mar 18 2022, 1:08 PM · multimedia
christos added a comment to D33609: x11/nfy: change maintainer address.

I don't, the @FreeBSD.org alias was given to me for GSoC.

Mar 18 2022, 1:04 PM
christos added a comment to D32499: sound(4): Apply mixer patches in 13.0-RELEASE.

Since these are just the kernel patches, would it break anything if we push them in 13.0-RELEASE as well?

Mar 18 2022, 1:02 PM · multimedia

Mar 17 2022

christos added a comment to D33609: x11/nfy: change maintainer address.

Can we get this through? It's already accepted. :-)

Mar 17 2022, 8:22 PM
christos added a comment to D32499: sound(4): Apply mixer patches in 13.0-RELEASE.

Bump.

Mar 17 2022, 8:20 PM · multimedia
christos updated the summary of D32499: sound(4): Apply mixer patches in 13.0-RELEASE.
Mar 17 2022, 8:20 PM · multimedia
christos added a reviewer for D34378: mixer(3): fix typo in man page: hselasky.
Mar 17 2022, 8:18 PM
christos added a comment to D34378: mixer(3): fix typo in man page.

Bump.

Mar 17 2022, 8:18 PM
christos added a comment to D34591: mixer(8): remove [.volume] string from default printout.

Looks good. Are there more patches coming?

Mar 17 2022, 5:34 PM · multimedia
christos requested review of D34591: mixer(8): remove [.volume] string from default printout.
Mar 17 2022, 5:19 PM · multimedia

Mar 13 2022

christos accepted D34545: Chase mixer(8) command-line interface changes.
Mar 13 2022, 2:22 PM
christos added a comment to D34545: Chase mixer(8) command-line interface changes.

LGTM!

Mar 13 2022, 2:22 PM

Feb 25 2022

christos requested review of D34378: mixer(3): fix typo in man page.
Feb 25 2022, 6:02 PM

Jan 24 2022

christos added a reviewer for D33609: x11/nfy: change maintainer address: tcberner.
Jan 24 2022, 1:00 AM
christos added a comment to D33609: x11/nfy: change maintainer address.

Bump

Jan 24 2022, 12:58 AM

Jan 3 2022

christos added a reviewer for D33609: x11/nfy: change maintainer address: imp.
Jan 3 2022, 9:56 PM
christos requested review of D33732: mixer(3): Move unnecessary includes out of header file.
Jan 3 2022, 9:55 PM · multimedia

Dec 21 2021

christos requested review of D33609: x11/nfy: change maintainer address.
Dec 21 2021, 10:02 PM

Nov 29 2021

christos abandoned D33142: mixer(3): Remove useless comments.
Nov 29 2021, 2:13 PM · multimedia

Nov 28 2021

christos added a comment to D33142: mixer(3): Remove useless comments.

Comments sometimes help verify that the code has been implemented correctly.

Nov 28 2021, 4:32 PM · multimedia
christos added a comment to D33142: mixer(3): Remove useless comments.

Can you explain a bit more the motivation here?

Nov 28 2021, 1:23 PM · multimedia
christos requested review of D33142: mixer(3): Remove useless comments.
Nov 28 2021, 2:27 AM · multimedia

Nov 19 2021

christos added a comment to D33027: mixer: make .Dt tags uppercase.

@gbe you should probably commit this yourself since I don't have commit rights. :-)

Nov 19 2021, 11:02 PM · multimedia

Nov 16 2021

christos requested review of D33027: mixer: make .Dt tags uppercase.
Nov 16 2021, 10:22 PM · multimedia

Nov 10 2021

christos retitled D32506: kldstat(8): style(9) fix from kldstat(8): Minor code changes to kldstat(8): style(9) fix.
Nov 10 2021, 2:40 PM
christos added inline comments to D32506: kldstat(8): style(9) fix.
Nov 10 2021, 2:25 PM
christos updated the diff for D32506: kldstat(8): style(9) fix.

Added braces to multiline printf statements.

Nov 10 2021, 2:25 PM
christos added inline comments to D32506: kldstat(8): style(9) fix.
Nov 10 2021, 11:57 AM

Oct 22 2021

christos updated the diff for D32506: kldstat(8): style(9) fix.

Add braces to getopt loop.

Oct 22 2021, 2:52 PM

Oct 20 2021

christos requested review of D32582: service(8): Fix typo in man page.
Oct 20 2021, 3:40 PM · manpages
christos abandoned D32520: mixer(8): Document -h option to man page.
Oct 20 2021, 3:27 PM · multimedia

Oct 18 2021

christos requested review of D32548: mixer(3): Fix comment.
Oct 18 2021, 1:53 PM · multimedia

Oct 17 2021

christos updated the diff for D32520: mixer(8): Document -h option to man page.

Improve message.

Oct 17 2021, 12:16 PM · multimedia
christos added a comment to D32520: mixer(8): Document -h option to man page.
Oct 17 2021, 12:14 PM · multimedia

Oct 16 2021

christos added a reviewer for D32506: kldstat(8): style(9) fix: imp.
Oct 16 2021, 11:44 AM
christos updated the summary of D32520: mixer(8): Document -h option to man page.
Oct 16 2021, 11:32 AM · multimedia
christos requested review of D32520: mixer(8): Document -h option to man page.
Oct 16 2021, 11:32 AM · multimedia

Oct 15 2021

christos requested review of D32508: mixer(8): Add -h option.
Oct 15 2021, 3:30 PM · multimedia
christos requested review of D32507: mixer(8): Print usage to stderr.
Oct 15 2021, 1:34 PM · multimedia
christos updated the diff for D32506: kldstat(8): style(9) fix.

Include whole file in diff.

Oct 15 2021, 1:03 PM
christos updated the diff for D32502: kldstat(8): Fix indentation.

Include whole file in diff.

Oct 15 2021, 1:00 PM
christos updated the diff for D32501: echo(1): Replace errexit() with err(3).

Include whole file in diff.

Oct 15 2021, 12:57 PM
christos requested review of D32506: kldstat(8): style(9) fix.
Oct 15 2021, 12:27 PM
christos retitled D32502: kldstat(8): Fix indentation from kldstat(8): Fix style to kldstat(8): Fix indentation.
Oct 15 2021, 12:25 PM
christos added a comment to D32501: echo(1): Replace errexit() with err(3).

So errexit() was introduced when they wanted to avoid using
stdio. Now err(3) was already being used, so is this really a revert?
Also this cannot be a performance issue -- both errexit() and err(3)
would only get called once after all.

Oct 15 2021, 12:11 PM
christos added a reviewer for D32499: sound(4): Apply mixer patches in 13.0-RELEASE: imp.
Oct 15 2021, 12:10 PM · multimedia
christos updated the diff for D32502: kldstat(8): Fix indentation.

Minor fix in indentation.

Oct 15 2021, 11:54 AM
christos updated the diff for D32502: kldstat(8): Fix indentation.

Indentation only.

Oct 15 2021, 11:51 AM
christos added a comment to D32502: kldstat(8): Fix indentation.

You should separate bare whitespace changes and code changes into two different commits.

Oct 15 2021, 11:40 AM
christos added a comment to D32501: echo(1): Replace errexit() with err(3).

Is this a revert of a previous commit? Then it should be mentioned.

Oct 15 2021, 11:39 AM

Oct 14 2021

christos requested review of D32502: kldstat(8): Fix indentation.
Oct 14 2021, 11:21 PM
christos updated the diff for D32501: echo(1): Replace errexit() with err(3).

Remove progname.

Oct 14 2021, 10:41 PM
christos added reviewers for D32501: echo(1): Replace errexit() with err(3): hselasky, imp.
Oct 14 2021, 10:37 PM