User Details
User Details
- User Since
- Jul 2 2021, 4:03 PM (65 w, 5 d)
Tue, Oct 4
Tue, Oct 4
Sun, Oct 2
Sun, Oct 2
christos added inline comments to D36851: kinst: Initial revision.
Sat, Oct 1
Sat, Oct 1
Aug 16 2022
Aug 16 2022
christos added a comment to D35281: dtrace, drti, libdtrace: fix type redefintion errors.
Bump.
Jul 16 2022
Jul 16 2022
christos added inline comments to D35827: dtrace: implement kinst.
Jul 15 2022
Jul 15 2022
christos requested review of D35827: dtrace: implement kinst.
Jun 1 2022
Jun 1 2022
christos added a comment to D35101: mixer: remove volume backwards compat, add % interpretation.
One more bump for good measure. :-)
christos updated the diff for D35281: dtrace, drti, libdtrace: fix type redefintion errors.
christos updated the diff for D35381: dtrace: add warning for /dev/dtrace/prototype.
christos requested review of D35381: dtrace: add warning for /dev/dtrace/prototype.
christos requested review of D35380: dtrace: remove /dev/dtrace/profile.
christos requested review of D35379: dtrace: remove /dev/dtrace/dtmalloc.
christos requested review of D35377: dtrace: remove /dev/dtrace/fbt.
May 24 2022
May 24 2022
christos added a comment to D35281: dtrace, drti, libdtrace: fix type redefintion errors.
May 21 2022
May 21 2022
christos added a comment to D35101: mixer: remove volume backwards compat, add % interpretation.
Bump.
christos requested review of D35281: dtrace, drti, libdtrace: fix type redefintion errors.
Apr 30 2022
Apr 30 2022
LGTM!
christos added inline comments to D35101: mixer: remove volume backwards compat, add % interpretation.
christos added a comment to D35101: mixer: remove volume backwards compat, add % interpretation.
Getting rid of the backwards compatibility which allows for both normalized
floats and the 0-100 OSS values is a good idea.
Apr 2 2022
Apr 2 2022
christos updated the diff for D34738: x11/nfy: update to newer version.
Last update. Changed WWW.
christos updated the diff for D34738: x11/nfy: update to newer version.
Yeap, I had to distclean. Works now.
Apr 1 2022
Apr 1 2022
christos updated the diff for D34738: x11/nfy: update to newer version.
christos updated the diff for D34738: x11/nfy: update to newer version.
christos requested review of D34738: x11/nfy: update to newer version.
Mar 20 2022
Mar 20 2022
christos updated the diff for D34617: mixer(8): fix shorthand syntax bug.
Done.
christos updated the diff for D34617: mixer(8): fix shorthand syntax bug.
Combine conditions.
christos requested review of D34617: mixer(8): fix shorthand syntax bug.
christos added a comment to D34603: mixer: fix mandoc -Tlint errors.
Documented the new shorthand syntax in D34614. Depends on this revision.
christos requested review of D34614: mixer.8: document shorthand syntax for volume setting.
christos added a comment to D34603: mixer: fix mandoc -Tlint errors.
Yes.
christos added a comment to D34612: mixer(8): add shorthand syntax for setting the volume.
Don't push it. I also forgot to add suport for [+|-].
christos retitled D34613: mixer(8): move control defines into an enum from mixer(8): add control defines into an enum to mixer(8): move control defines into an enum.
christos requested review of D34613: mixer(8): move control defines into an enum.
christos updated the diff for D34612: mixer(8): add shorthand syntax for setting the volume.
Accept floating point numbers as input.
christos added inline comments to D34612: mixer(8): add shorthand syntax for setting the volume.
christos added a comment to D34591: mixer(8): remove [.volume] string from default printout.
D34612 depends on this revision.
christos requested review of D34612: mixer(8): add shorthand syntax for setting the volume.
Mar 18 2022
Mar 18 2022
christos added a comment to D33609: x11/nfy: change maintainer address.
No worries!
christos updated the diff for D34603: mixer: fix mandoc -Tlint errors.
Ran igor(1) on both mixer.8 and mixer.3. The line changes were made because mandoc -Tlint was printing warnings, so I wanted them to go away. :-)
christos updated the diff for D34603: mixer: fix mandoc -Tlint errors.
Fixed.
christos requested review of D34603: mixer: fix mandoc -Tlint errors.
Alright then, we can abandon it!
christos added a comment to D32499: sound(4): Apply mixer patches in 13.0-RELEASE.
Mostly for completeness, but we can abandon it if 13.1 is close to release.
christos added a comment to D33609: x11/nfy: change maintainer address.
I don't, the @FreeBSD.org alias was given to me for GSoC.
christos added a comment to D32499: sound(4): Apply mixer patches in 13.0-RELEASE.
Since these are just the kernel patches, would it break anything if we push them in 13.0-RELEASE as well?
Mar 17 2022
Mar 17 2022
christos added a comment to D33609: x11/nfy: change maintainer address.
Can we get this through? It's already accepted. :-)
christos added a comment to D32499: sound(4): Apply mixer patches in 13.0-RELEASE.
Bump.
christos updated the summary of D32499: sound(4): Apply mixer patches in 13.0-RELEASE.
christos added a comment to D34591: mixer(8): remove [.volume] string from default printout.
christos requested review of D34591: mixer(8): remove [.volume] string from default printout.
Mar 13 2022
Mar 13 2022
christos added a comment to D34545: Chase mixer(8) command-line interface changes.
LGTM!
Feb 25 2022
Feb 25 2022
christos requested review of D34378: mixer(3): fix typo in man page.
Jan 24 2022
Jan 24 2022
Jan 3 2022
Jan 3 2022
christos requested review of D33732: mixer(3): Move unnecessary includes out of header file.
Dec 21 2021
Dec 21 2021
christos requested review of D33609: x11/nfy: change maintainer address.
Nov 29 2021
Nov 29 2021
Nov 28 2021
Nov 28 2021
christos added a comment to D33142: mixer(3): Remove useless comments.
christos added a comment to D33142: mixer(3): Remove useless comments.
Can you explain a bit more the motivation here?
christos requested review of D33142: mixer(3): Remove useless comments.
Nov 19 2021
Nov 19 2021
christos added a comment to D33027: mixer: make .Dt tags uppercase.
@gbe you should probably commit this yourself since I don't have commit rights. :-)
Nov 16 2021
Nov 16 2021
christos requested review of D33027: mixer: make .Dt tags uppercase.
Nov 10 2021
Nov 10 2021
christos retitled D32506: kldstat(8): style(9) fix from kldstat(8): Minor code changes to kldstat(8): style(9) fix.
christos added inline comments to D32506: kldstat(8): style(9) fix.
christos updated the diff for D32506: kldstat(8): style(9) fix.
Added braces to multiline printf statements.
christos added inline comments to D32506: kldstat(8): style(9) fix.
Oct 22 2021
Oct 22 2021
christos updated the diff for D32506: kldstat(8): style(9) fix.
Add braces to getopt loop.
Oct 20 2021
Oct 20 2021
christos requested review of D32582: service(8): Fix typo in man page.
Oct 18 2021
Oct 18 2021
christos requested review of D32548: mixer(3): Fix comment.
Oct 17 2021
Oct 17 2021
christos updated the diff for D32520: mixer(8): Document -h option to man page.
Improve message.
christos added a comment to D32520: mixer(8): Document -h option to man page.
Oct 16 2021
Oct 16 2021
christos updated the summary of D32520: mixer(8): Document -h option to man page.
christos requested review of D32520: mixer(8): Document -h option to man page.
Oct 15 2021
Oct 15 2021
christos requested review of D32508: mixer(8): Add -h option.
christos requested review of D32507: mixer(8): Print usage to stderr.
christos updated the diff for D32506: kldstat(8): style(9) fix.
Include whole file in diff.
christos updated the diff for D32502: kldstat(8): Fix indentation.
Include whole file in diff.
christos updated the diff for D32501: echo(1): Replace errexit() with err(3).
Include whole file in diff.
christos requested review of D32506: kldstat(8): style(9) fix.
christos retitled D32502: kldstat(8): Fix indentation from kldstat(8): Fix style to kldstat(8): Fix indentation.
christos added a comment to D32501: echo(1): Replace errexit() with err(3).
So errexit() was introduced when they wanted to avoid using
stdio. Now err(3) was already being used, so is this really a revert?
Also this cannot be a performance issue -- both errexit() and err(3)
would only get called once after all.
christos updated the diff for D32502: kldstat(8): Fix indentation.
Minor fix in indentation.
christos updated the diff for D32502: kldstat(8): Fix indentation.
Indentation only.
Oct 14 2021
Oct 14 2021
christos requested review of D32502: kldstat(8): Fix indentation.
christos updated the diff for D32501: echo(1): Replace errexit() with err(3).
Remove progname.