Page MenuHomeFreeBSD

christos (Christos Margiolis)
User

Projects

User Details

User Since
Jul 2 2021, 4:03 PM (231 w, 5 d)

Recent Activity

Yesterday

christos abandoned D54135: sound: Do not free snd_midi->{in,out}q unconditionally in midi_uninit().
Wed, Dec 10, 2:39 PM
christos accepted D50853: linuxkpi: Add eventfd_*().
Wed, Dec 10, 2:17 PM
christos added a reviewer for D50848: eventfd: Rename `struct eventfd` to `struct eventfd_ctx`: christos.
Wed, Dec 10, 2:07 PM
christos added a comment to D50848: eventfd: Rename `struct eventfd` to `struct eventfd_ctx`.

Linux defines eventfd_ctx as:

struct eventfd_ctx {
	struct kref kref;
	wait_queue_head_t wqh;
	/*
	 * Every time that a write(2) is performed on an eventfd, the
	 * value of the __u64 being written is added to "count" and a
	 * wakeup is performed on "wqh". If EFD_SEMAPHORE flag was not
	 * specified, a read(2) will return the "count" value to userspace,
	 * and will reset "count" to zero. The kernel side eventfd_signal()
	 * also, adds to the "count" counter and issue a wakeup.
	 */
	__u64 count;
	unsigned int flags;
	int id;
};

This is quite different from our version. Although ugly, wouldn't it be safer to either explicitly alias it in LinuxKPI or even translate it there?

Wed, Dec 10, 2:06 PM

Mon, Dec 8

christos updated the summary of D54126: sound: Retire midi_devs and mstat_lock.
Mon, Dec 8, 6:47 PM
christos requested review of D54141: sound: Take device type into account in sndstat.
Mon, Dec 8, 6:40 PM
christos requested review of D54140: sound: Move sndstat out of pcm/.
Mon, Dec 8, 6:20 PM
christos updated the diff for D54135: sound: Do not free snd_midi->{in,out}q unconditionally in midi_uninit().

Abandoned D54134. Update.

Mon, Dec 8, 5:55 PM
christos abandoned D54134: sound: Retire M_MIDI and use M_DEVBUF.
Mon, Dec 8, 5:54 PM
christos requested review of D54135: sound: Do not free snd_midi->{in,out}q unconditionally in midi_uninit().
Mon, Dec 8, 5:53 PM
christos requested review of D54134: sound: Retire M_MIDI and use M_DEVBUF.
Mon, Dec 8, 5:50 PM
christos committed rGebe7b241662b: sound examples: Check if setting property was successful (authored by meka_tilda.center).
sound examples: Check if setting property was successful
Mon, Dec 8, 5:22 PM
christos closed D54038: sound examples: Check if setting property was successful.
Mon, Dec 8, 5:21 PM
christos accepted D54038: sound examples: Check if setting property was successful.

LGTM. Please take a look at the inline comments.

Mon, Dec 8, 5:18 PM
christos requested review of D54131: sound: Improve snd_midi->{in,out}q allocation.
Mon, Dec 8, 5:13 PM
christos requested review of D54130: sound: Unlock around uiomove() in midi_{read,write}().
Mon, Dec 8, 4:03 PM
christos requested review of D54129: sound: Retire snd_midi->qlock.
Mon, Dec 8, 4:00 PM
christos added a comment to D54125: sound: Stop building midi as a module.

But now unload errors can't be reported.

Mon, Dec 8, 3:32 PM
christos requested review of D54127: snd_dummy: Initial MIDI support.
Mon, Dec 8, 3:31 PM
christos requested review of D54126: sound: Retire midi_devs and mstat_lock.
Mon, Dec 8, 3:31 PM
christos added a comment to D54102: snd_uaudio: Do not use pcm_channel->lock to protect uaudio_chan.

What problem does this fix?

Mon, Dec 8, 2:52 PM
christos requested review of D54125: sound: Stop building midi as a module.
Mon, Dec 8, 2:38 PM
christos added inline comments to D54038: sound examples: Check if setting property was successful.
Mon, Dec 8, 1:49 PM

Sat, Dec 6

christos requested review of D54103: sound: Retire pcm_feeder->desc_static.
Sat, Dec 6, 3:39 PM
christos requested review of D54102: snd_uaudio: Do not use pcm_channel->lock to protect uaudio_chan.
Sat, Dec 6, 2:52 PM
christos committed rG643a606fa274: sndctl(8): Do not free and re-open device (authored by christos).
sndctl(8): Do not free and re-open device
Sat, Dec 6, 2:29 PM
christos closed D54031: sndctl(8): Do not free and re-open device.
Sat, Dec 6, 2:29 PM
christos added a comment to D54032: sndctl(8): Add libxo support.

Bump.

Sat, Dec 6, 2:29 PM
christos added inline comments to D54038: sound examples: Check if setting property was successful.
Sat, Dec 6, 2:26 PM
christos committed rG26365bf2516f: sound: Retire snd_mixer->busy (authored by christos).
sound: Retire snd_mixer->busy
Sat, Dec 6, 1:36 PM

Thu, Dec 4

christos added inline comments to D54032: sndctl(8): Add libxo support.
Thu, Dec 4, 4:41 PM
christos updated the diff for D54032: sndctl(8): Add libxo support.

Refer to xo_options(7), not libxo(3).

Thu, Dec 4, 4:41 PM
christos added inline comments to D54032: sndctl(8): Add libxo support.
Thu, Dec 4, 4:22 PM
christos added inline comments to D54032: sndctl(8): Add libxo support.
Thu, Dec 4, 4:04 PM
christos added inline comments to D54038: sound examples: Check if setting property was successful.
Thu, Dec 4, 3:46 PM
christos accepted D54071: uio.h: Indent struct uio according to style(9).
Thu, Dec 4, 3:17 PM
christos added inline comments to D54038: sound examples: Check if setting property was successful.
Thu, Dec 4, 3:16 PM
christos added a reviewer for D54032: sndctl(8): Add libxo support: mckusick.
Thu, Dec 4, 3:10 PM
christos added inline comments to D54038: sound examples: Check if setting property was successful.
Thu, Dec 4, 3:07 PM
christos added a comment to D54038: sound examples: Check if setting property was successful.

We can have this check for SNDCTL_DSP_CHANNELS as well. Also the commit title and message have to be adapted.

Thu, Dec 4, 11:14 AM

Tue, Dec 2

christos added a comment to D54038: sound examples: Check if setting property was successful.

You can extend this to the rest of the settings in this patch.

Tue, Dec 2, 8:38 PM
christos updated the diff for D54032: sndctl(8): Add libxo support.

Update man page as well.

Tue, Dec 2, 1:29 PM
christos requested review of D54032: sndctl(8): Add libxo support.
Tue, Dec 2, 1:20 PM
christos requested review of D54031: sndctl(8): Do not free and re-open device.
Tue, Dec 2, 1:20 PM
christos added a comment to D53614: sound tests: Test hot-unload.

Bump. Again, this is problematic when running with -v parallelism because it might unload snd_dummy when the other tests are using it.

Tue, Dec 2, 11:02 AM
christos added a comment to D53749: sound examples: Add mmap example.

Are you working on the timing issues? I haven't really looked into those.

Tue, Dec 2, 10:45 AM

Fri, Nov 28

christos added a comment to D53749: sound examples: Add mmap example.

I think this needs to be rebased since we committed the oss.h changes.

Fri, Nov 28, 3:10 PM
christos committed rG7587270512d1: sound examples: Fix buffer mapping/allocation (authored by meka_tilda.center).
sound examples: Fix buffer mapping/allocation
Fri, Nov 28, 2:37 PM
christos committed rGe5d50a679aa1: sound: Retire snd_mixer->busy (authored by christos).
sound: Retire snd_mixer->busy
Fri, Nov 28, 2:36 PM
christos committed rGb1e9512cba83: sound: Fix revents in midi_poll() (authored by Nicolas Provost <dev@nicolas-provost.fr>).
sound: Fix revents in midi_poll()
Fri, Nov 28, 2:36 PM
christos committed rG47bb49b54098: sound: Retire snd_mtx* wrappers (authored by christos).
sound: Retire snd_mtx* wrappers
Fri, Nov 28, 2:36 PM
christos committed rG839da868a5f9: sound: Merge PCM_ALIVE() with PCM_REGISTERED() (authored by christos).
sound: Merge PCM_ALIVE() with PCM_REGISTERED()
Fri, Nov 28, 2:36 PM
christos closed D53859: sound: Retire snd_mixer->busy.
Fri, Nov 28, 2:36 PM
christos committed rGefb513fc19c8: sound: Clean up midi/ includes (authored by christos).
sound: Clean up midi/ includes
Fri, Nov 28, 2:36 PM
christos committed rG48765e9306e9: sound: Simplify logic in dsp_io_ops() (authored by christos).
sound: Simplify logic in dsp_io_ops()
Fri, Nov 28, 2:36 PM
christos added inline comments to D53859: sound: Retire snd_mixer->busy.
Fri, Nov 28, 2:31 PM

Thu, Nov 27

christos committed rG068b20e200fb: sound: Fix KASSERT panics in chn_read() and chn_write() (authored by christos).
sound: Fix KASSERT panics in chn_read() and chn_write()
Thu, Nov 27, 12:34 AM
christos committed rG3cf8333f877d: sound: Remove vchan_passthrough() and hw.snd.passthrough_verbose (authored by christos).
sound: Remove vchan_passthrough() and hw.snd.passthrough_verbose
Thu, Nov 27, 12:34 AM

Wed, Nov 26

christos committed rGebf1d98d6072: sound examples: Fix buffer mapping/allocation (authored by meka_tilda.center).
sound examples: Fix buffer mapping/allocation
Wed, Nov 26, 7:34 PM
christos closed D53939: sound examples: Fix buffer mapping/allocation.
Wed, Nov 26, 7:34 PM
christos accepted D53939: sound examples: Fix buffer mapping/allocation.
Wed, Nov 26, 7:30 PM

Mon, Nov 24

christos committed rG8f8b8e4af91d: sound: Fix revents in midi_poll() (authored by Nicolas Provost <dev@nicolas-provost.fr>).
sound: Fix revents in midi_poll()
Mon, Nov 24, 1:36 PM
christos added inline comments to D53896: snd_hdsp*: Fix M_NOWAIT malloc(9) calls.
Mon, Nov 24, 1:18 PM
christos added inline comments to D53749: sound examples: Add mmap example.
Mon, Nov 24, 12:31 PM
christos retitled D53896: snd_hdsp*: Fix M_NOWAIT malloc(9) calls from snd_hdsp*: Fix some M_NOWAIT malloc(9) calls to snd_hdsp*: Fix M_NOWAIT malloc(9) calls.
Mon, Nov 24, 12:30 PM
christos requested review of D53896: snd_hdsp*: Fix M_NOWAIT malloc(9) calls.
Mon, Nov 24, 12:30 PM
christos committed rG4991bb6a5c45: snd_hda: Patch Lenovo V15 (authored by christos).
snd_hda: Patch Lenovo V15
Mon, Nov 24, 12:26 PM
christos committed rG120f8a4c2ae8: arm: Add missing argument in mtx_init() calls (authored by christos).
arm: Add missing argument in mtx_init() calls
Mon, Nov 24, 12:22 PM

Sun, Nov 23

christos added a reverting change for rGe254ef87a30b: sound: Merge chn_intr() with chn_intr_locked(): rG5cc34a83e1cc: Revert "sound: Merge chn_intr() with chn_intr_locked()".
Sun, Nov 23, 1:51 PM
christos committed rG5cc34a83e1cc: Revert "sound: Merge chn_intr() with chn_intr_locked()" (authored by christos).
Revert "sound: Merge chn_intr() with chn_intr_locked()"
Sun, Nov 23, 1:51 PM
christos added a reverting change for D53854: sound: Merge chn_intr() with chn_intr_locked(): rG5cc34a83e1cc: Revert "sound: Merge chn_intr() with chn_intr_locked()".
Sun, Nov 23, 1:51 PM

Fri, Nov 21

christos closed D53855: sound: Retire snd_mtx* wrappers.
Fri, Nov 21, 9:10 PM
christos requested review of D53859: sound: Retire snd_mixer->busy.
Fri, Nov 21, 5:05 PM
christos committed rG9d18115ca0ab: sound: Retire snd_mtx* wrappers (authored by christos).
sound: Retire snd_mtx* wrappers
Fri, Nov 21, 4:15 PM
christos committed rGe254ef87a30b: sound: Merge chn_intr() with chn_intr_locked() (authored by christos).
sound: Merge chn_intr() with chn_intr_locked()
Fri, Nov 21, 4:15 PM
christos committed rG3107b952f534: sound: Merge PCM_ALIVE() with PCM_REGISTERED() (authored by christos).
sound: Merge PCM_ALIVE() with PCM_REGISTERED()
Fri, Nov 21, 4:15 PM
christos committed rGb4c32d67d40a: sound: Simplify logic in dsp_io_ops() (authored by christos).
sound: Simplify logic in dsp_io_ops()
Fri, Nov 21, 4:15 PM
christos committed rG4e8eb778803a: sound: Clean up midi/ includes (authored by christos).
sound: Clean up midi/ includes
Fri, Nov 21, 4:15 PM
christos closed D53854: sound: Merge chn_intr() with chn_intr_locked().
Fri, Nov 21, 4:15 PM
christos closed D53841: sound: Clean up midi/ includes.
Fri, Nov 21, 4:15 PM
christos closed D53736: sound: Simplify logic in dsp_io_ops().
Fri, Nov 21, 4:15 PM
christos updated the diff for D53841: sound: Clean up midi/ includes.

Bring back lock.h

Fri, Nov 21, 3:48 PM
christos added inline comments to D53736: sound: Simplify logic in dsp_io_ops().
Fri, Nov 21, 3:47 PM
christos added a comment to D53736: sound: Simplify logic in dsp_io_ops().

What does this mean?

Fri, Nov 21, 3:41 PM
christos added inline comments to D53841: sound: Clean up midi/ includes.
Fri, Nov 21, 3:38 PM
christos requested review of D53855: sound: Retire snd_mtx* wrappers.
Fri, Nov 21, 12:53 PM
christos abandoned D53853: sound: Do not lock in sound_oss_card_info().
Fri, Nov 21, 11:31 AM
christos abandoned D53852: sound: Do not lock in sysctl_dev_pcm_mode().
Fri, Nov 21, 11:30 AM
christos abandoned D53851: sound: Simplify locking in sysctl_dev_pcm_bitperfect().
Fri, Nov 21, 11:30 AM
christos added inline comments to D53851: sound: Simplify locking in sysctl_dev_pcm_bitperfect().
Fri, Nov 21, 11:26 AM
christos requested review of D53854: sound: Merge chn_intr() with chn_intr_locked().
Fri, Nov 21, 11:04 AM
christos updated the summary of D53853: sound: Do not lock in sound_oss_card_info().
Fri, Nov 21, 10:35 AM
christos requested review of D53853: sound: Do not lock in sound_oss_card_info().
Fri, Nov 21, 10:34 AM
christos added inline comments to D53851: sound: Simplify locking in sysctl_dev_pcm_bitperfect().
Fri, Nov 21, 10:13 AM
christos added inline comments to D53851: sound: Simplify locking in sysctl_dev_pcm_bitperfect().
Fri, Nov 21, 10:03 AM
christos requested review of D53852: sound: Do not lock in sysctl_dev_pcm_mode().
Fri, Nov 21, 9:59 AM
christos added a comment to D53851: sound: Simplify locking in sysctl_dev_pcm_bitperfect().

PCM_ACQUIRE() sets the SD_F_BUSY flag, which more or less works as a sleepable lock. I do not really see the purpose of doing that here. Also I do not see the purpose of locking at the start of the function, just to read d->flags & SD_F_BITPERFECT.

Fri, Nov 21, 9:51 AM
christos requested review of D53851: sound: Simplify locking in sysctl_dev_pcm_bitperfect().
Fri, Nov 21, 9:49 AM
christos added inline comments to D53841: sound: Clean up midi/ includes.
Fri, Nov 21, 9:22 AM
christos updated the diff for D53841: sound: Clean up midi/ includes.
  • Bring back sys/types.h in midi.h.
  • Do not include sys/types.h where sys/param.h is included.
  • Sort includes alphabetically after sys/param.h and sys/systm.h.
Fri, Nov 21, 9:13 AM