User Details
- User Since
- Jul 2 2021, 4:03 PM (275 w, 6 d)
Yesterday
Wed, Oct 14
Friendly bump for this and the rest of the stack.
Also please include a small paragraph about the chn_resizebuf() changes in the commit message and/or in the code.
From what I understand, the issue is that because this is not bhyve-internal memory, but entries we read from the guest's memory, we want to make sure these values are read at that point exactly, so that we don't let the compiler re-read them later when the value might have been changed?
Mon, Oct 12
Sat, Oct 10
Address Ed's comments. Note that hdaa_update_coef() now closely resembles
Linux's equivalent:
Fri, Oct 9
I had to add hda_update_coef() for a patch I'm working on (D60527), so we can hold off this one, and rebase it once I commit it.
Sorry for the noise.
Stop taking the sx unnecessarily for the device the ioctl has been issued on,
and instead take it for every device being inspected when needed.
Address Joe's comment.
Thu, Oct 8
I am aware of the first 2 MFCs, I'm holding off to commit them along with the 1 month ones.
Merge with D60127 and address Mark's comments from there.
Wed, Oct 7
Address Mark's comment and also use PCM_ACQUIRE_QUICK() before pcm_killchans() instead of duplicating what it does.
Please make sure to MFC this. Thanks.
Address Mateusz's and Rick's comments.
The mixer knobs are a bit confusing since they are part of the legacy OSS API, but typically vol controls the hardware master volume, and pcm the software volume, usually from applications and sound(4) virtual channels.
Tue, Oct 6
Mon, Oct 5
Wed, Sep 30
Tue, Sep 29
This fixes the issues mentioned in https://ron-dev.freebsd.org/FreeBSD/src/pulls/13.
Thanks, if you can, give D59872 a review as well and I will commit those now. :)
@rmacklem I see that you have many commits to NFS, so the question would better be what do you think is best here. I'm not sure what is best either. My patch looks like a hack on one hand, but I do agree about the empty file being mistaken for unnecessary. Could you document this with a comment inside the empty file?
Mon, Sep 28
Address Rick's comments.
Address Konstantin's comments.
Assert that ref == 0 when the server is freed.