Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

christos updated the diff for D32520: mixer(8): Document -h option to man page.

Improve message.

Sun, Oct 17, 12:16 PM · multimedia
christos added a comment to D32520: mixer(8): Document -h option to man page.
Sun, Oct 17, 12:14 PM · multimedia

Sat, Oct 16

christos added a reviewer for D32506: kldstat(8): Minor code changes: imp.
Sat, Oct 16, 11:44 AM
christos updated the summary of D32520: mixer(8): Document -h option to man page.
Sat, Oct 16, 11:32 AM · multimedia
christos requested review of D32520: mixer(8): Document -h option to man page.
Sat, Oct 16, 11:32 AM · multimedia

Fri, Oct 15

christos requested review of D32508: mixer(8): Add -h option.
Fri, Oct 15, 3:30 PM · multimedia
christos requested review of D32507: mixer(8): Print usage to stderr.
Fri, Oct 15, 1:34 PM · multimedia
christos updated the diff for D32506: kldstat(8): Minor code changes.

Include whole file in diff.

Fri, Oct 15, 1:03 PM
christos updated the diff for D32502: kldstat(8): Fix indentation.

Include whole file in diff.

Fri, Oct 15, 1:00 PM
christos updated the diff for D32501: echo(1): Replace errexit() with err(3).

Include whole file in diff.

Fri, Oct 15, 12:57 PM
christos requested review of D32506: kldstat(8): Minor code changes.
Fri, Oct 15, 12:27 PM
christos retitled D32502: kldstat(8): Fix indentation from kldstat(8): Fix style to kldstat(8): Fix indentation.
Fri, Oct 15, 12:25 PM
christos added a comment to D32501: echo(1): Replace errexit() with err(3).

So errexit() was introduced when they wanted to avoid using
stdio. Now err(3) was already being used, so is this really a revert?
Also this cannot be a performance issue -- both errexit() and err(3)
would only get called once after all.

Fri, Oct 15, 12:11 PM
christos added a reviewer for D32499: sound(4): Apply mixer patches in 13.0-RELEASE: imp.
Fri, Oct 15, 12:10 PM · multimedia
christos updated the diff for D32502: kldstat(8): Fix indentation.

Minor fix in indentation.

Fri, Oct 15, 11:54 AM
christos updated the diff for D32502: kldstat(8): Fix indentation.

Indentation only.

Fri, Oct 15, 11:51 AM
christos added a comment to D32502: kldstat(8): Fix indentation.

You should separate bare whitespace changes and code changes into two different commits.

Fri, Oct 15, 11:40 AM
christos added a comment to D32501: echo(1): Replace errexit() with err(3).

Is this a revert of a previous commit? Then it should be mentioned.

Fri, Oct 15, 11:39 AM

Thu, Oct 14

christos requested review of D32502: kldstat(8): Fix indentation.
Thu, Oct 14, 11:21 PM
christos updated the diff for D32501: echo(1): Replace errexit() with err(3).

Remove progname.

Thu, Oct 14, 10:41 PM
christos added reviewers for D32501: echo(1): Replace errexit() with err(3): hselasky, imp.
Thu, Oct 14, 10:37 PM
christos requested review of D32501: echo(1): Replace errexit() with err(3).
Thu, Oct 14, 10:36 PM
christos requested review of D32500: mixer(8): Fix empty output case.
Thu, Oct 14, 10:06 PM · multimedia
christos abandoned D32236: mixer(3): temporary fix in mixer_open().
Thu, Oct 14, 9:58 PM · multimedia
christos added a comment to D32236: mixer(3): temporary fix in mixer_open().

Since virtual_oss can create arbitrary virtual devices, this patch might
not work as expected in those cases. It's better that we leave it as is then.
Closing the revision.

Thu, Oct 14, 9:57 PM · multimedia
christos requested review of D32499: sound(4): Apply mixer patches in 13.0-RELEASE.
Thu, Oct 14, 9:54 PM · multimedia

Fri, Oct 1

christos abandoned D32253: mixer: change `dunit` to `default_unit`.
Fri, Oct 1, 3:26 PM · multimedia
christos added a comment to D32253: mixer: change `dunit` to `default_unit`.

BTW: If you first expand dunit -> default_unit, there are many other function names you should treat the same:

nmixers->num_mixers ?
recsrc -> recording_source

????

Fri, Oct 1, 3:20 PM · multimedia
christos added a comment to D32253: mixer: change `dunit` to `default_unit`.

I think "dunit" is just as good as "default_unit".

Fri, Oct 1, 3:18 PM · multimedia
christos added a comment to D32253: mixer: change `dunit` to `default_unit`.

Since the library is so new, do we need to do this and not just rename the
symbols to keep it clean, at least this time?

I see this more of an exercise for you.

The problem is that 3rd parties may already be using this stuff, even though it has just existed for a week, and I don't want to continue breaking stuff :-)

This is what makes FreeBSD great sometimes.

--HPS

Fri, Oct 1, 3:15 PM · multimedia
christos added a comment to D32253: mixer: change `dunit` to `default_unit`.

Can you also update the Symbol versioning file with the new symbol, while not removing the old one!

MLINKS+= needs an update too.

In the C-code you need to add:

symver(mixer_get_default_unit, mixer_get_dunit, FBSD_1.7);
symver(mixer_set_default_unit, mixer_set_dunit, FBSD_1.7);

From now on, such changes must be backwards compatible.

Fri, Oct 1, 3:07 PM · multimedia
christos updated the diff for D32253: mixer: change `dunit` to `default_unit`.

Change Makefile and Symbol.map names as well.

Fri, Oct 1, 3:02 PM · multimedia
christos updated the diff for D32254: mixer(3): add symbol versioning.

Fix namespace and referencing.

Fri, Oct 1, 10:55 AM · multimedia
christos updated the diff for D32254: mixer(3): add symbol versioning.

Remove macros and MLINKS.

Fri, Oct 1, 10:25 AM · multimedia
christos requested review of D32254: mixer(3): add symbol versioning.
Fri, Oct 1, 10:20 AM · multimedia
christos requested review of D32253: mixer: change `dunit` to `default_unit`.
Fri, Oct 1, 10:07 AM · multimedia
christos added a comment to D32236: mixer(3): temporary fix in mixer_open().

Try:

pkg install virtual_oss
man virtual_oss

Maybe you find the answer. Else let me know.

Fri, Oct 1, 9:57 AM · multimedia

Thu, Sep 30

christos updated the diff for D32236: mixer(3): temporary fix in mixer_open().

Removed strdup().

Thu, Sep 30, 2:04 PM · multimedia
christos added a comment to D32236: mixer(3): temporary fix in mixer_open().

What about virtual_oss in ports? It can create any such device ....

Thu, Sep 30, 2:04 PM · multimedia
christos added a comment to D32236: mixer(3): temporary fix in mixer_open().

Why do you need to do a strdup() when you are not writing the string? Or did I miss something?

Thu, Sep 30, 2:03 PM · multimedia
christos requested review of D32236: mixer(3): temporary fix in mixer_open().
Thu, Sep 30, 1:53 PM · multimedia

Wed, Sep 22

christos added a comment to R10:903873ce1560: Implement and use new mixer(3) library for FreeBSD..

Done. Anything more?

Wed, Sep 22, 8:16 PM
christos added a comment to R10:903873ce1560: Implement and use new mixer(3) library for FreeBSD..

We also need to modify /etc/rc.d/mixer:

Wed, Sep 22, 7:56 PM
christos added inline comments to R10:903873ce1560: Implement and use new mixer(3) library for FreeBSD..
Wed, Sep 22, 7:28 PM

Aug 27 2021

christos added inline comments to D31636: gsoc-2021 final review: sound mixer improvements.
Aug 27 2021, 1:10 PM

Aug 26 2021

christos added inline comments to D31636: gsoc-2021 final review: sound mixer improvements.
Aug 26 2021, 2:10 PM
christos updated the diff for D31636: gsoc-2021 final review: sound mixer improvements.

mixer(3): fixed post assignment check in mixer_remove_ctl.
mixer(8): added error handling in initctls.

Aug 26 2021, 2:09 PM

Aug 25 2021

christos updated the diff for D31636: gsoc-2021 final review: sound mixer improvements.

Added $FreeBSD$ tags.

Aug 25 2021, 3:05 PM
christos updated the diff for D31636: gsoc-2021 final review: sound mixer improvements.

mixer.3: updated MIX_VOLDENORM definition.

Aug 25 2021, 2:06 PM
christos updated the diff for D31636: gsoc-2021 final review: sound mixer improvements.

Removed math.h dependency.

Aug 25 2021, 2:02 PM

Aug 23 2021

christos updated the diff for D31636: gsoc-2021 final review: sound mixer improvements.

Removed useless files.

Aug 23 2021, 1:32 PM
christos added inline comments to D31636: gsoc-2021 final review: sound mixer improvements.
Aug 23 2021, 1:29 PM

Aug 22 2021

christos requested review of D31636: gsoc-2021 final review: sound mixer improvements.
Aug 22 2021, 5:50 PM

Jul 31 2021

christos updated the diff for D31320: sound(4): implement playback/recording mode sysctl.

Replaced PCM_MODE_NONE with PCM_MODE_MIXER.

Jul 31 2021, 2:14 PM

Jul 29 2021

christos updated the diff for D31320: sound(4): implement playback/recording mode sysctl.

Fixed sysctl description.

Jul 29 2021, 7:26 AM

Jul 28 2021

christos added a comment to D31320: sound(4): implement playback/recording mode sysctl.

Yes, MIDI devices are also PCM devices, but there is no /dev/dspX device.

Let me have a look. Do you have a USB MIDI device at hand?

--HPS

Jul 28 2021, 3:34 PM
christos added a comment to D31320: sound(4): implement playback/recording mode sysctl.

PCM_MODE_NONE usually means MIDI. Could you investigate that a bit?

Jul 28 2021, 3:16 PM
christos added a comment to D31320: sound(4): implement playback/recording mode sysctl.

What is the motivation for changing this?

Jul 28 2021, 2:37 PM
christos updated the diff for D31320: sound(4): implement playback/recording mode sysctl.

Fixed flag handling.

Jul 28 2021, 2:04 PM
christos added a comment to D31320: sound(4): implement playback/recording mode sysctl.

OK! Can you update the patch to use "mode"?

Jul 28 2021, 11:05 AM
christos updated the diff for D31320: sound(4): implement playback/recording mode sysctl.
Jul 28 2021, 11:04 AM
christos added a comment to D31320: sound(4): implement playback/recording mode sysctl.

Does the word "mode" make sense to you?

Jul 28 2021, 10:47 AM
christos added a comment to D31320: sound(4): implement playback/recording mode sysctl.

Could you check an english dictionary with synonyms?

Jul 28 2021, 10:14 AM

Jul 27 2021

christos added a comment to D31320: sound(4): implement playback/recording mode sysctl.

Are there other options for naming.

Status is usually something that can change. But this is more like a property.

Jul 27 2021, 12:51 PM
christos added a comment to D31320: sound(4): implement playback/recording mode sysctl.

I think s/status/feature/ is a better word?

What do you think?

--HPS

Jul 27 2021, 12:36 PM
christos updated the diff for D31320: sound(4): implement playback/recording mode sysctl.
Jul 27 2021, 12:23 PM
christos updated the summary of D31320: sound(4): implement playback/recording mode sysctl.
Jul 27 2021, 11:52 AM
christos requested review of D31320: sound(4): implement playback/recording mode sysctl.
Jul 27 2021, 11:52 AM

Jul 20 2021

christos updated the diff for D31130: sound(4): mixer: implement (un)muting.

Added Hans' changes.

Jul 20 2021, 10:11 PM

Jul 11 2021

christos added inline comments to D31130: sound(4): mixer: implement (un)muting.
Jul 11 2021, 12:21 PM
christos added inline comments to D31130: sound(4): mixer: implement (un)muting.
Jul 11 2021, 11:37 AM

Jul 10 2021

christos added a reviewer for D31130: sound(4): mixer: implement (un)muting: hselasky.
Jul 10 2021, 11:55 AM
christos updated the diff for D31130: sound(4): mixer: implement (un)muting.
Jul 10 2021, 11:52 AM
christos updated the summary of D31130: sound(4): mixer: implement (un)muting.
Jul 10 2021, 11:40 AM
christos requested review of D31130: sound(4): mixer: implement (un)muting.
Jul 10 2021, 11:07 AM