snd_dummy: Fix callout(9) races
Needs ReviewPublic
Actions

Authored by christos on Tue, Nov 5, 9:27 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Summary

Use callout_init_mtx(9) to associate the callback with the driver's
lock. Also make sure the callout is stopped properly during detach.

While here, get rid of some unnecessary if statements in
dummy_chan_trigger().

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60708
Build 57592: arc lint + arc unit

Event Timeline

christos created this revision.Tue, Nov 5, 9:27 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Nov 5, 9:27 PM

christos requested review of this revision.Tue, Nov 5, 9:27 PM

Harbormaster completed remote builds in B60412: Diff 146076.Tue, Nov 5, 9:27 PM

christos added a child revision: D47460: snd_dummy: Avoid NULL dereferences in dummy_chan_io().Tue, Nov 5, 9:27 PM

christos mentioned this in D47462: sound: Fix hot-unload panics.Tue, Nov 5, 9:31 PM

markj accepted this revision.Sat, Nov 9, 7:40 PM

This revision is now accepted and ready to land.Sat, Nov 9, 7:40 PM

christos mentioned this in D47460: snd_dummy: Avoid NULL dereferences in dummy_chan_io().Sun, Nov 10, 3:50 PM

dev_submerge.ch accepted this revision.Thu, Nov 14, 6:34 PM

Fix one more race by moving pcm_unregister() before callout_stop() and
callout_drain().

This revision now requires review to proceed.Wed, Nov 20, 7:16 PM

Harbormaster completed remote builds in B60708: Diff 146761.Wed, Nov 20, 7:16 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

dummy.c

17 lines

Diff 146761

View Options

snd_dummy: Fix callout(9) racesNeeds ReviewPublicActions