snd_dummy: Avoid NULL dereferences in dummy_chan_io()
AbandonedPublic
Actions

Authored by christos on Nov 5 2024, 9:27 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60413
Build 57297: arc lint + arc unit

Event Timeline

christos created this revision.Nov 5 2024, 9:27 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 5 2024, 9:27 PM

christos requested review of this revision.Nov 5 2024, 9:27 PM

Harbormaster completed remote builds in B60413: Diff 146077.Nov 5 2024, 9:27 PM

christos added a parent revision: D47459: snd_dummy: Fix callout(9) races.Nov 5 2024, 9:27 PM

christos added a child revision: D47461: sound: Fix chn_trigger() and vchan_trigger() races.

christos mentioned this in D47462: sound: Fix hot-unload panics.Nov 5 2024, 9:31 PM

When are these fields null?

In D47460#1083229, @markj wrote:

When are these fields null?

I couldn't pinpoint exactly, but I am pretty sure D47462 and D47459 fixed the cases where these fields could end up null. However, I think it wouldn't hurt to be extra safe here.

There may be cases where NULL checks like these eliminate some crashes but leave races that still exist but are harder to hit.

In D47460#1083443, @emaste wrote:

There may be cases where NULL checks like these eliminate some crashes but leave races that still exist but are harder to hit.

As I said, the two patches mentioned most likely fix those races, so I guess we could abandon this one.

christos abandoned this revision.Nov 10 2024, 4:22 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

dummy.c

2 lines

Diff 146077

View Options

snd_dummy: Avoid NULL dereferences in dummy_chan_io()AbandonedPublicActions