sound: Remove early SD_F_SIMPLEX and SD_F_AUTOVCHAN assignments
ClosedPublic
Actions

Authored by christos on Oct 28 2024, 10:30 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rGc874fcc4ca62: sound: Remove early SD_F_SIMPLEX and SD_F_AUTOVCHAN assignments
rG3a7d40c69262: sound: Remove early SD_F_SIMPLEX and SD_F_AUTOVCHAN assignments

Summary

These flags are properly set in pcm_setstatus(), once the primary
channels have been created. The existing comment already states that
this is wrong.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Oct 28 2024, 10:30 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 28 2024, 10:30 PM

christos requested review of this revision.Oct 28 2024, 10:30 PM

Harbormaster completed remote builds in B60233: Diff 145569.Oct 28 2024, 10:30 PM

christos added a parent revision: D47323: sound: Move sndstat_register() call to pcm_setstatus().Oct 28 2024, 10:31 PM

christos added a child revision: D47325: sound: Make device registration more intuitive.

dev_submerge.ch accepted this revision.Oct 30 2024, 9:47 AM

This revision is now accepted and ready to land.Oct 30 2024, 9:47 AM

markj accepted this revision.Oct 30 2024, 12:59 PM

Closed by commit rG3a7d40c69262: sound: Remove early SD_F_SIMPLEX and SD_F_AUTOVCHAN assignments (authored by christos). · Explain WhyNov 3 2024, 7:05 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG3a7d40c69262: sound: Remove early SD_F_SIMPLEX and SD_F_AUTOVCHAN assignments.

christos added a commit: rGc874fcc4ca62: sound: Remove early SD_F_SIMPLEX and SD_F_AUTOVCHAN assignments.Nov 5 2024, 9:45 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

sound.c

10 lines

Diff 145956

View Options

sound: Remove early SD_F_SIMPLEX and SD_F_AUTOVCHAN assignmentsClosedPublicActions