Page MenuHomeFreeBSD

sound: Move sysctl and /dev/dspX creation to pcm_setstatus()
ClosedPublic

Authored by christos on Oct 28 2024, 10:30 PM.
Tags
None
Referenced Files
F154954225: D47322.id145567.diff
Thu, Apr 30, 7:25 AM
Unknown Object (File)
Wed, Apr 29, 8:36 AM
Unknown Object (File)
Wed, Apr 29, 8:30 AM
Unknown Object (File)
Mon, Apr 27, 5:03 AM
Unknown Object (File)
Sun, Apr 26, 2:37 PM
Unknown Object (File)
Sun, Apr 26, 6:21 AM
Unknown Object (File)
Tue, Apr 21, 8:53 AM
Unknown Object (File)
Mon, Apr 20, 2:01 AM
Subscribers

Details

Summary

Create the sysctl and /dev/dsp* nodes in pcm_setstatus(), which is
responsible for finalizing the device initialization, instead of doing
this in the middle of the initialization.

For the sysctl creation specifically, move them into pcm_sysinit(),
since this is where we create the rest of the sysctl nodes anyway.

A side effect of this change is, that we avoid the possibility of racing
in between pcm_register() and pcm_setstatus() by accessing /dev/dspX or
the sysctls within that window.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable