Page MenuHomeFreeBSD

sound: Move sysctl and /dev/dspX creation to pcm_setstatus()
ClosedPublic

Authored by christos on Mon, Oct 28, 10:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 3:32 AM
Unknown Object (File)
Wed, Nov 6, 8:43 AM
Unknown Object (File)
Tue, Nov 5, 11:25 PM
Unknown Object (File)
Mon, Nov 4, 1:38 AM
Unknown Object (File)
Fri, Nov 1, 1:11 PM
Subscribers

Details

Summary

Create the sysctl and /dev/dsp* nodes in pcm_setstatus(), which is
responsible for finalizing the device initialization, instead of doing
this in the middle of the initialization.

For the sysctl creation specifically, move them into pcm_sysinit(),
since this is where we create the rest of the sysctl nodes anyway.

A side effect of this change is, that we avoid the possibility of racing
in between pcm_register() and pcm_setstatus() by accessing /dev/dspX or
the sysctls within that window.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable