Excellent. Once we have TCP own socket buffer, it could be part of soisdisconnected() method of TCP. Now it just sits next to this call.

You don't need a special sysctl for that. You can use kern.osreldate, which is generic sysctl designed exactly for such kind of problems.

This is great. And it looks like there's more wired up than just -z for apm.

only remove the rc.d script

And to answer your other question: only suspend works

In D56629#1296825, @ivy wrote:

are you sure? /usr/sbin/zzz appears to be a shell script that controls ACPI via acpiconf(8), and only falls back to using apm(8) if the machdep.apm_suspend_delay sysctl exists, which it doesn't on my machine; i assume this comes from apm(4).

are there other functions of apm(8) that work on ACPI systems?

are you sure? /usr/sbin/zzz appears to be a shell script that controls ACPI via acpiconf(8), and only falls back to using apm(8) if the machdep.apm_suspend_delay sysctl exists, which it doesn't on my machine; i assume this comes from apm(4).

Apm, the program, works on any acpi machine. It's what is installed as zzz and still works. Apmd only talks to APM BIOS machines which are 20years dead at this point. Apm, the program, calls a generic interface for sleeping...

In D56291#1289983, @ngie wrote:

@fluffy : I was hoping sunpoet@ would have done the commit, but I've gone and just pushed the change to :main . I'll handle the MFC after 3 days.

Address review feedback by moving this into tcp_twstart()

LGTM!

In D56560#1296780, @rmacklem wrote:

In D56560#1296776, @bz wrote:

Sorry but I don't know this code specifically and what these macros are doing or not in the end; unless I am going to read it all to understand I cannot help given there is no high level description of what you are trying to (de-)virtualize here.

I had initially asked if it was possible to run NFS exports from within jails. Rick made that happen in 2003(?). And that's kind-of as much as I know. I believe I had not reviewed any of that code back then; you may want to talk to people who did -- I think @markj , @jamie and @mjg did in the end when it came to jails and mounted and some other bits got refined. But that's just from vague memory.

Well, my vague memory is that you (bz@) requested that the vnet macros
be hidden behind other macros because you thought you might want
to do something different than that happen.
All the macros like KRPC_CURVNET_SET() do is CURVNET_SET(), etc.

Oh, and it happens a few years ago (closer to 2023 than 2003).

If you (bz@) don't want/need the macros, they can go away.

review from chuck

as a proposal -

Oh that's fun

Great stuff! Thanks!

In D55191#1296317, @des wrote:

In D55191#1295909, @bdrewery wrote:

read -t 0.250 isn't supported. Best we can do is 1 second. One of the reads does not time out while the other does. So this change reduces 2 seconds of sleep in the test suite.

In D56560#1296776, @bz wrote:

Sorry but I don't know this code specifically and what these macros are doing or not in the end; unless I am going to read it all to understand I cannot help given there is no high level description of what you are trying to (de-)virtualize here.

I had initially asked if it was possible to run NFS exports from within jails. Rick made that happen in 2003(?). And that's kind-of as much as I know. I believe I had not reviewed any of that code back then; you may want to talk to people who did -- I think @markj , @jamie and @mjg did in the end when it came to jails and mounted and some other bits got refined. But that's just from vague memory.

There also was NFSD_VNET_NAME et al intially btw (a quick grep says some still exists from ed03776ca7f43de8275da80cfa89a9ecc4732f82 ).

Sorry but I don't know this code specifically and what these macros are doing or not in the end; unless I am going to read it all to understand I cannot help given there is no high level description of what you are trying to (de-)virtualize here.

Rename ENA_RX_BUDGET to ENA_RX_DESC_BUDGET to match new meaning.

Fix assertions; correct assertion

IMHO, Vova's plan sounds better than a sysctl.

Good catch. Is this something that can be triggered with libcam?

rebase and maybe push the fixes that mmel wanted

OK. Updated a while ago...

oh! Yea, this is wrong. The return type may be wrong for things like lseek, but this isn't how to fix it.

Quite a trivial way to detect if we have ipfw ABI from 15.x - rely on IP_FW3_OPVER_1 for basic commands (add or get):

Coded VIRF_KNOTE.