• devel/llvm*: restore _BE_LIBS_[BACKWARDS_]Mips

In D55176#1274177, @emaste wrote:

I've reverted d99f16276e06736ceff9ea3ae5a1ac09135bcfdc for now. Let's get this change fixed up and in to src and we can then reapply it.

@imp This initial driver is basic for now and expose activity/timing that happen since power-on. You can see the Dram training, and any delay on the EUFI/Bios

• x11-wm/sway*: 14.3-RELEASE still needs extra-patch-wordexp
• net-p2p/tremotesf: simplify as per maintainer suggestion
• filesystems/fusefs-libs3: remove now unused extra-patch

Rebase, process comments.

I only see the "upgrading to write fault" for many processes. Tested with both xfce and plasma. Seems like all the apps that initiate graphics get reported by the message (xfwm4, firefox, plasmashell, Xorg, etc)

I've reverted d99f16276e06736ceff9ea3ae5a1ac09135bcfdc for now. Let's get this change fixed up and in to src and we can then reapply it.

I have no objections.
Thanks.

I agree we can drop support for the GPLv2 binutils.

• Apply Kostik's & Mark's suggestions

Convert caddr_t to char * for pointer arithmetic. (@glebius)

@glebius this revision is an extention of GRAND which only affects anycast and proxy ipv6 addresses.
Could you please review it c-wise?

I think this has implemented the suggested changes to my suggested changes that @jrtc27 suggested.

@bz I would really appreciate it if you could review this when you have some free time.

In D55539#1273814, @kib wrote:

In particular, I believe that you should not see the problem e.g. on tmpfs, am I right?

If PKG_CREATE_THREADS_NUMBER <= 0, it gets kern.smp.cores || nproc. But aren't -T0 and -T$(sysctl kern.smp.cores) expected to mean the same thing?

1. 0 is a perfectly valid value for -T, as your comment notes. But if that's what the user requests, it gets overwritten by...
2. kern.smp.cores, which should be identical to just doing -T0 but with an extra shell call.

I will and report back.

use adamw's suggestions. I appreciate the attention to detail!

This is cool functionality. Are there any of the tagged data times that the boot loader should be looking at to pass into the kernel via its metadata interface that we get from other locations and coreboot doesn't provide those interfaces so we leave it blank?
Or are we already doing this, and this commit just exposes the data in a new way.
love 'dmesg for coreboot' parts especially.

Wow, this is interesting. I've been running FreeBSD coreboot for many years, I'll test this next week on my APU2.

In D55651#1274046, @ziaee wrote:

See ls for similar language.

See ls for similar language.

I'm a little confused by the logic.

Hopefully, fixed.

• Remove unneeded != 0 expression.
• Use proper full context diff. Do *not* let --no-prefix anywhere near the diff. :)

In D55605#1274023, @scf wrote:

In D55605#1273962, @christos wrote:

Something is messed up with the file paths here. (dev/sound instead of sys/dev/sound).

I am not sure what happened. The diff starts with:

diff --git sys/dev/sound/pcm/feeder_volume.c sys/dev/sound/pcm/feeder_volume.c
index fc4ed1bbb0a5..c1a33dcdd8a3 100644
--- sys/dev/sound/pcm/feeder_volume.c
+++ sys/dev/sound/pcm/feeder_volume.c
@@ -1,350 +1,360 @@
 /*-
  * SPDX-License-Identifier: BSD-2-Clause

I have not used git-arc, but it looks like I need to try it.

In D55653#1273825, @kib wrote:

In D55653#1273824, @obiwac wrote:

In D55653#1273804, @kib wrote:

Why is this needed? Size is end-start.
Note that there are huge amount of scripts used by people who parse procstat vm output based on the text format, with the fixed assignment of the columns. The output layout for text is kind of ABI, due to this.

If you insist that it is must be added, it probably fine for structured output like json/xml, but even less useful because its parsing already requires some full language that can do end-start. For the text columnar format, the new column perhaps requires a new option to enable it.

In which case maybe we add size to the very end? this wasn't mentioned in the review description, but this is related to bug https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=293416 for context

Note that the field in the last column, which contains the path, might be empty. This makes additions after it even worse than just breaking the layout as proposed in patch.

I do suggest to add an option to enable the size column.

In D55605#1273962, @christos wrote:

Something is messed up with the file paths here. (dev/sound instead of sys/dev/sound).

In D55667#1273924, @olce wrote:

(Alternative: Don't compile this on 32-bit architectures at all, if if_iwx in reality does not support those.)

Set a variable to check if we need to skip userret

i'm sorry, I must resign from this revision. I wish you the best of luck in getting this accepted into posix!