Add a line in description to tell developers not to make an assumption.
Sorry I took so long - I confused your note that it should be reverted with a note that it *had been* reverted.
This could be MFCed, as zero_region is from FreeBSD 9 era.
Just committed this. I agree about 13.0 -- I was planning to merge to stable/13 after 13.0 has branched and smoke-test this in HEAD for a bit in the meantime.
@0mp sorry about that. More thorough testing has been carried out and the results are in the updated Test Plan.
afaict it's ok, but we should update all of them, or change the comments
I found that all website/data/en/events/events*.toml have entries in chronological order.
Need to check if changing this affect the display in events block of https://www.freebsd.org and https://www.freebsd.org/events/
I've already added this in https://cgit.freebsd.org/doc/commit/?id=9cc036198be8b6cc0844326f897e84f8faaddd63
It appears that this change should be MFC'ed to 12.
@jhb Are you MFC'ing this to stable/13 and/or releng/13.0?
Filter the unrelated things out, please, and we're good.
Add back chunk that's required, as advised by imp@.
The ZFS bits look good, just one question about the change in zfs_freebsd_bmap.
I'd commit all but the flagged one.
The flagged one, if someone can confirm my code tracing, changes things. Don't know if the change is a breakage or just a benign change, but I think it requires additional study (and maybe a comment about why it's needed, or the flow needs to change to call it after the flagged ata_do_identify, but even then I've not chased down all branches.
All but one of these are easily seen to be redundant now.
Is this work also available in a git repo?
Need to use a cache zone after all.
+1 for removing and not MFCin.
Man page fixes.
Rework review to address outstanding issues with examples
It looks great now! Since this changes core libc functions, can you perform a buildworld on a system with the modified libc installed to confirm everything works fine?
LGTM from manpages . Did you run igor and 'mandoc -Tlint' against the man page?
I just checked it against mandoc -Tlint, and did some fixes.
The output from mandoc -Tlint in the current form is:mandoc: share/man/man9/zero_region.9:80:28: STYLE: consider using OS macro: Fx
The output of igor is:$ igor -R share/man/man9/zero_region.9 zero_region.9:28:date not today, February 25, 2021:.Dd February 24, 2021
- Avoid VOP_GETATTR when the object type is OBJT_VNODE.
- Add a short comment explaining why we prefer the pager size.
I'll commit with the updated comment of yours.