Done. Thanks mat.
Add missing USES=gl and fix a typo on a USE_GL+=gl
Fix order of options in Makefiles
If we can assume an interface route also implies an on-link prefix, just installing an on-link prefix list entry upon installing an interface route is more reasonable to me than looking up the routing table because the current code uses the prefix list to determine if an address is a neighbor or not.
ln(1) -r should ideally not error out if we're creating a link to a file that doesn't exist -- we can't do that at the moment, because it's using realpath(3) on it. Switching certctl to install(1) instead
I rewrote lazy smr to lazily update s_wr_seq but otherwise use the rest
of the machinery for normal smr. The read side lost a branch and the
code is better contained. ticks now gates s_wr_seq updates similar
to deferred mode. There are some annoying conditions around 0 and
very stale state. In the process I refactored some code because poll()
is getting very long due to comments.
I have no strong objection to allow a prefix route with no gateway, but I think the case pointed out in Bug 194485 can be solved by just adding an address with the delegated prefix on the interface (EUI-64 always works as the interface id). Is there any specific reason for DHCP-PD (or another use case) to have an interface route?
Thank you for looking into this!
Indeed, I should have provided a more accurate description. The problem is a bit bigger than just DHCPv6.
In general, RFC 5942 advocates for the explicit split between address management and prefix assignment:
Lint the makefile
In any case I tested 10 different combinations:
@imp the requested changes have been applied. Please check. Thanks!
Collapse .if/.else/.endif into one liner.
Sorry, I didn’t have time to test the patch. But as for the code, I have no questions.
The manifests are basically already a plist which post-install just transforms into our plist format. Not sure if we want to loosen control over it. The only downside I can see is that that files that are outside of the manifests will not be flagged as extra files by Poudriere.
Simplify the code to compute the global cache limits
per @kevans request
I took maintainership as suggested by firstname.lastname@example.org in a private mail.
This has been accepted to the GitHub repo; please commit at-will.
Simplify by storing 0 corrected ticks in td_wr_seq. This gives no branches
in the enter section and simpler code elsewhere.