Page MenuHomeFreeBSD

maxim (Maxim Konovalov)
User

Projects

User is not a member of any projects.

User Details

User Since
Jul 2 2019, 12:53 PM (384 w, 5 d)

Recent Activity

Today

maxim committed rGe550130c07ce: tcp/rack: reject wma_divisor values <= 0.
Mon, Nov 16, 3:31 AM
maxim added a comment to D61606: traceroute: do not use a stale or NULL quoted header with -E.

Reproducible on macOS as well. Thank you!

Mon, Nov 16, 2:36 AM
maxim added a reviewer for D61606: traceroute: do not use a stale or NULL quoted header with -E: kevin_your.org.
Mon, Nov 16, 1:08 AM
maxim added a reviewer for D61607: traceroute6: do not print an ECN report for an echo reply: kevin_your.org.
Mon, Nov 16, 1:08 AM
maxim requested review of D61607: traceroute6: do not print an ECN report for an echo reply.
Mon, Nov 16, 1:06 AM
maxim requested review of D61606: traceroute: do not use a stale or NULL quoted header with -E.
Mon, Nov 16, 1:05 AM

Yesterday

maxim requested review of D61588: ipfw: print the log, not the config, for "nat <name> show log".
Sun, Nov 15, 5:11 AM
maxim added a comment to D61587: ipfw_nat: fix the buffer length check in IP_FW_NAT44_XGETLOG.

Just for the record: I've made secteam (markj) aware of this issue.

Sun, Nov 15, 4:26 AM
maxim added a reviewer for D61587: ipfw_nat: fix the buffer length check in IP_FW_NAT44_XGETLOG: kevin_your.org.
Sun, Nov 15, 4:25 AM
maxim requested review of D61587: ipfw_nat: fix the buffer length check in IP_FW_NAT44_XGETLOG.
Sun, Nov 15, 4:24 AM

Thu, Nov 12

maxim committed rG1681aa4cd5e5: bsnmp: zero-fill the destination on a short ASN.1 IpAddress (authored by ojanerif_amd.com).
Thu, Nov 12, 1:29 AM

Mon, Nov 9

maxim committed rG3c6c65bbb258: tests/sys/file: add tests for the lowest fd after fork.
Mon, Nov 9, 4:36 AM

Fri, Nov 6

maxim accepted D61254: README: Scrap and write a new one in Markdown.

It doesn't address all Amy's concerns but it is good enough per se.

Fri, Nov 6, 3:37 PM

Thu, Nov 5

maxim committed R9:766c7b5cdfc7: doceng.adoc: typo fix.
Thu, Nov 5, 9:00 PM

Tue, Nov 3

maxim added a comment to D61149: TCP RACK: fix RSM computation for TCP fast open.

Hi Michael,

Tue, Nov 3, 12:34 AM

Mon, Nov 2

maxim committed rGf9f4abe8c9f8: tests/sys/file: add tests for the lowest fd after fork.
Mon, Nov 2, 9:13 PM
maxim closed D61124: tests/sys/file: add tests for the lowest fd after fork.
Mon, Nov 2, 9:13 PM
maxim updated the summary of D61124: tests/sys/file: add tests for the lowest fd after fork.
Mon, Nov 2, 2:57 AM
maxim updated the diff for D61124: tests/sys/file: add tests for the lowest fd after fork.

add Co-authored-by

Mon, Nov 2, 2:51 AM
maxim requested review of D61124: tests/sys/file: add tests for the lowest fd after fork.
Mon, Nov 2, 2:46 AM

Sun, Nov 1

maxim committed rG5c4757194391: jail.8: fix a typo, sort Xr.
Sun, Nov 1, 5:06 AM

Fri, Oct 30

maxim committed rG0928867b4cc1: tcpsso: fix the level error messages.
Fri, Oct 30, 2:35 AM
maxim committed rG6983e233ee62: intro.9: deduplicate vm_page Xrs.
Fri, Oct 30, 2:35 AM

Thu, Oct 29

maxim committed rGb5e57452b62e: bsnmp: zero-fill the destination on a short ASN.1 IpAddress (authored by ojanerif_amd.com).
Thu, Oct 29, 9:00 PM
maxim closed D60923: bsnmp: zero-fill the destination on a short ASN.1 IpAddress.
Thu, Oct 29, 8:59 PM
maxim added a comment to D60923: bsnmp: zero-fill the destination on a short ASN.1 IpAddress.

Also, please confirm that the Author line looks good to you

Thu, Oct 29, 6:07 PM
maxim added a comment to D60923: bsnmp: zero-fill the destination on a short ASN.1 IpAddress.

Hey Osvaldo,

Thu, Oct 29, 5:55 PM
maxim committed rGb9585475ee62: jail.8: fix a typo, sort Xr.
Thu, Oct 29, 8:43 AM

Thu, Oct 22

maxim committed rG49f56f3a6cff: ping: fix test timestamp_origin when tstamprepl is disabled (authored by olivier).
Thu, Oct 22, 12:46 AM
maxim committed rG0a9e5c679ff0: tests/ping: Fix date(1) invocations (authored by markj).
Thu, Oct 22, 12:46 AM
maxim committed rG6c604ba42861: ping: use CLOCK_REALTIME for ICMP Originate Timestamp.
Thu, Oct 22, 12:46 AM
maxim committed rG4292233234f3: ping: do a better job with what we received from the net, part 2.
Thu, Oct 22, 12:46 AM
maxim committed rG43e0c9c1ed40: ping: do a better job checking what we receive from the net.
Thu, Oct 22, 12:46 AM

Wed, Oct 21

maxim committed R9:d89283ff3d6d: boot-loader-improvements: a typo fix.
Wed, Oct 21, 9:24 PM
maxim added a comment to D60923: bsnmp: zero-fill the destination on a short ASN.1 IpAddress.

Yep, it looks like a brain-o. Should be harmless as both bsnmpd (main.c:511) and libbsnmp (snmpclient.c:1466) zero out a pdu.

As this is a contrib, we probably want to notify the upstream.

It looks like most of the recent changes in bsnmp have been directly in the src repo, but I believe @harti is the authority there.

Wed, Oct 21, 7:26 PM
maxim committed R9:5a9a613d6c3a: Status/2026Q3: spell and whitespace police.
Wed, Oct 21, 5:07 PM

Tue, Oct 20

maxim updated the summary of D60932: snmp_wlan: several fixes in mac policy handling.
Tue, Oct 20, 10:51 PM
maxim requested review of D60932: snmp_wlan: several fixes in mac policy handling.
Tue, Oct 20, 10:49 PM
maxim added a comment to D60923: bsnmp: zero-fill the destination on a short ASN.1 IpAddress.

Just reading through the bsnmp ASN.1 decoder looking for length bugs. In the
short-IpAddress case the zero-padding loop never runs, so the trailing bytes
are left uninitialised. Agreed it's harmless in practice since the callers
zero the pdu -- just a correctness fix.

Tue, Oct 20, 9:31 PM
maxim added a comment to D60923: bsnmp: zero-fill the destination on a short ASN.1 IpAddress.

By the way, how did you find this issue?

Tue, Oct 20, 8:32 PM
maxim accepted D60923: bsnmp: zero-fill the destination on a short ASN.1 IpAddress.

Yep, it looks like a brain-o. Should be harmless as both bsnmpd (main.c:511) and libbsnmp (snmpclient.c:1466) zero out a pdu.

Tue, Oct 20, 8:23 PM
maxim committed R9:a43347db6360: bugmeister.adoc: fix a typo.
Tue, Oct 20, 5:57 PM

Sun, Oct 18

maxim added reviewers for D60833: jail: fix leaked persistent prisons on failed jail_set(2) create: jamie, markj.
Sun, Oct 18, 5:12 AM
maxim requested review of D60833: jail: fix leaked persistent prisons on failed jail_set(2) create.
Sun, Oct 18, 5:09 AM

Sat, Oct 17

maxim committed rG7668705cb983: tcp/rack: reject wma_divisor values <= 0.
Sat, Oct 17, 6:22 PM
maxim closed D60759: tcp/rack: reject wma_divisor values <= 0.
Sat, Oct 17, 6:21 PM
maxim added inline comments to D60759: tcp/rack: reject wma_divisor values <= 0.
Sat, Oct 17, 5:02 AM

Oct 16 2026

maxim committed rGbfb7ee5ef00f: tcpsso.8: fix a cosmetic nit and make mandoc -Tlint happy.
Oct 16 2026, 9:47 PM
maxim committed rGc7cf285bb206: tcpsso: fix the level error messages.
Oct 16 2026, 9:47 PM
maxim added inline comments to D60759: tcp/rack: reject wma_divisor values <= 0.
Oct 16 2026, 8:54 PM
maxim added inline comments to D60759: tcp/rack: reject wma_divisor values <= 0.
Oct 16 2026, 8:11 PM
maxim added inline comments to D60759: tcp/rack: reject wma_divisor values <= 0.
Oct 16 2026, 7:34 PM
maxim updated the diff for D60759: tcp/rack: reject wma_divisor values <= 0.
  • make the variable and sysctl unsigned (glebius)
  • reject values above INT32_MAX
  • pass 0 instead of 8 (tuexen)
  • drop the double space
Oct 16 2026, 6:48 PM
maxim committed R9:47580922c886: pdptrace 2026q3 report: fix a typo.
Oct 16 2026, 6:12 PM
maxim requested review of D60759: tcp/rack: reject wma_divisor values <= 0.
Oct 16 2026, 12:49 AM

Oct 11 2026

maxim accepted D60611: Status/2026Q3/frdp.adoc: Add report.

Looks good

Oct 11 2026, 6:08 PM · status

Oct 8 2026

maxim committed rGcb2711b163ba: tcpdrop.8: Xr mod_cc(4).
Oct 8 2026, 7:47 PM
maxim committed rGb2b9be7c2ab3: tcpdrop.8: spell newreno.
Oct 8 2026, 7:47 PM

Oct 6 2026

maxim committed rG0154a0df90c7: bsnmpget: initialise the suboption value in getsubopt1().
Oct 6 2026, 5:40 PM
maxim committed rG2da109690be8: dummynet: do not overflow the points[ED_MAX_SAMPLES_NO] array.
Oct 6 2026, 5:40 PM
maxim committed rGde5689d1e6ea: bsnmp: validate the lower bound of error_index in responses.
Oct 6 2026, 5:40 PM

Oct 1 2026

maxim accepted D60210: tcpdrop: improve handling of -C and -S.

Yeah, it did the trick. Thanks.

Oct 1 2026, 6:48 PM
maxim committed rGcdb4538d7f6b: tcpdrop.8: spell newreno.
Oct 1 2026, 4:24 PM
maxim committed rG9279dd3c15fb: tcpdrop.8: Xr mod_cc(4).
Oct 1 2026, 4:24 PM

Sep 30 2026

maxim accepted D60182: status/2026Q3/doceng: Add doc project report.

The report looks good.

Sep 30 2026, 7:33 PM
maxim added a comment to D60182: status/2026Q3/doceng: Add doc project report.

This is probably not the right forum to discuss this but I cannot help but comment:

Sep 30 2026, 7:31 PM

Sep 29 2026

maxim committed rGda0067ded585: ipfw: guard against NULL deref with clat/plat prefixes without length.
Sep 29 2026, 1:49 AM

Sep 26 2026

maxim committed rG10bd16d4e827: ihwpstate_intel: update dev.hwpstate_intel.%d.epp sysctl description.
Sep 26 2026, 2:44 AM

Sep 24 2026

maxim committed rG784f5708fd0f: split.1: grammar.
Sep 24 2026, 2:03 AM
maxim committed rGc5cc084a34a3: ipfw.8: clarify a difference between reset and reset6 actions.
Sep 24 2026, 12:46 AM
maxim committed rG1511b29a097e: ipfw.8: more grammar fixes.
Sep 24 2026, 12:46 AM
maxim committed rGfd3ded8c0143: ipfw.8: grammar.
Sep 24 2026, 12:46 AM
maxim committed rGf38dfbf66b70: ipfw.8: whitespace police.
Sep 24 2026, 12:46 AM

Sep 22 2026

maxim committed rG5d169b5365b1: bsnmpget: initialise the suboption value in getsubopt1().
Sep 22 2026, 10:57 PM
maxim committed rG7b7ef798bfc5: bsd-family-tree: add NetBSD 10.2.
Sep 22 2026, 10:11 PM
maxim committed rG296e3fd54ca8: bsnmp: validate the lower bound of error_index in responses.
Sep 22 2026, 9:50 PM
maxim committed rG04fcf3096126: dummynet: do not overflow the points[ED_MAX_SAMPLES_NO] array.
Sep 22 2026, 2:37 AM

Sep 17 2026

maxim committed rG0b9434d707c7: ping: do a better job with what we received from the net, part 2.
Sep 17 2026, 12:37 AM
maxim committed rGaa6683207d18: ping: do a better job checking what we receive from the net.
Sep 17 2026, 12:37 AM
maxim closed D59556: ping: do a better job with what we received from the net, part 2.
Sep 17 2026, 12:37 AM
maxim closed D59555: ping: do a better job checking what we receive from the net.
Sep 17 2026, 12:37 AM
maxim accepted D59582: ping: tests: Add test for D59556.

Looks good to me

Sep 17 2026, 12:36 AM

Sep 15 2026

maxim committed rG47b02ace19c5: ipfw: guard against NULL deref with clat/plat prefixes without length.
Sep 15 2026, 6:04 PM

Sep 12 2026

maxim added a comment to D59582: ping: tests: Add test for D59556.

Hi Jose,

Sep 12 2026, 3:28 AM

Sep 11 2026

maxim added a comment to D59556: ping: do a better job with what we received from the net, part 2.

Please see the suggested test (D59582). Ideally it should be squashed with this change. Thank you!

Sep 11 2026, 4:19 AM
maxim added a comment to D59555: ping: do a better job checking what we receive from the net.

I don't object to the change, but IMHO better to not be afraid of improving the old code.

Sep 11 2026, 4:16 AM

Sep 10 2026

maxim added a comment to D59555: ping: do a better job checking what we receive from the net.

The call to pr_pack() is preceded by < 0 check of return of recvmsg() and then with another == 0 check. Thus, the cc is always positive. I would suggest to change prototype of pr_pack to unsigned type of cc. This will allow to operate with unsigned types for all lengths in the function and remove existing (ssize_t) casts as well as avoid adding new such casts.

Sep 10 2026, 6:03 PM
maxim committed rG009940e3d4d3: ipfw.8: clarify a difference between reset and reset6 actions.
Sep 10 2026, 5:00 PM
maxim added reviewers for D59556: ping: do a better job with what we received from the net, part 2: asomers, glebius.
Sep 10 2026, 3:10 AM
maxim requested review of D59556: ping: do a better job with what we received from the net, part 2.
Sep 10 2026, 3:09 AM
maxim added reviewers for D59555: ping: do a better job checking what we receive from the net: asomers, glebius.
Sep 10 2026, 3:05 AM
maxim requested review of D59555: ping: do a better job checking what we receive from the net.
Sep 10 2026, 3:04 AM

Sep 9 2026

maxim committed rGb31db8d8de67: ipfw.8: more grammar fixes.
Sep 9 2026, 5:56 PM
maxim committed rGb891252f209b: ipfw.8: whitespace police.
Sep 9 2026, 5:42 PM
maxim committed rG055a726ca632: ipfw.8: grammar.
Sep 9 2026, 5:42 PM

Sep 8 2026

maxim committed rGae458518935e: bsd-family-tree: add NetBSD 9.5 and FreeBSD 14.5.
Sep 8 2026, 4:04 AM

Aug 3 2026

maxim committed rG396e6d699556: bsd-family-tree: add NetBSD 11.0.
Aug 3 2026, 6:09 PM

Aug 1 2026

maxim committed R9:b5bc268a69c4: Status/2026Q2/pdopenpid.adoc: man references markup fixes.
Aug 1 2026, 12:55 AM

Jul 24 2026

maxim added inline comments to D58446: website: ports freeze news translated to Russian.
Jul 24 2026, 11:39 PM · docs

Jul 20 2026

maxim committed R9:363d64c6f2f4: Status/2026Q2: grammar.
Jul 20 2026, 4:45 PM