Added back atf_skip for i386/armv7 to jail_cleanup

In D43591#994155, @kevans wrote:

Seems to LGTM. At some point we may want to update lbh->bootonce as new environments are activated/deactivated, but this is sufficient for bectl's needs and we don't really make many guarantees about the caching (or lack thereof) that occurs in the handle today, IIRC.

1. Adds test cases for destroy and rename cases
2. Fix bootonce leak

Handles destroying bootonce case

In D43591#994147, @kevans wrote:

Can you add a test for this in sbin/bectl/tests/bectl_test.sh as well, please? Presumably you could use zfsbootcfg -z rather than checking the bectl list output.

I note that we should also do something on destroy of the bootonce dataset.

Thanks for that. LGTM

This looks good to me.

In D41436#976157, @jlduran_gmail.com wrote:

In D41436#976151, @rcm wrote:

In D41436#976128, @jlduran_gmail.com wrote:

In D41436#976125, @rcm wrote:

Would it be possible to also get a v6 case?

Line 29?

ah yes, I should have scrolled up.

Is that really testing for the same case?

# setup_vnet(pytest:TestRtNlRoute:test_add_route4_ll_gw)
run: '/sbin/sysctl net.inet6.ip6.dad_count=0'
run: '/sbin/ifconfig epair0a up'
run: '/usr/sbin/ndp -i epair0a -disabled'
run: '/sbin/ifconfig epair0a inet6 2001:db8::1/64'
run: '/sbin/ifconfig epair0a inet6'
run: '/sbin/ifconfig tun create'

The whole point of D41330 was to handle the case where the interface doesn't have a v4/v6 address.

I'm working on adding it. Just like the IPv4 one (using tun, without a gateway), I'll name the tests add_route{4,6}_ll_if_gw.

In D41436#976128, @jlduran_gmail.com wrote:

In D41436#976125, @rcm wrote:

Would it be possible to also get a v6 case?

Line 29?

Would it be possible to also get a v6 case?

@kp and I actually discussed this back in June in response to an internal need. In fact, he pointed me towards this exact interface ifconfig_get_orig_name.

Thanks for doing that. LGTM

Added @jrtc27 and @mhorne to chime in concerning @imp's question concerning risc-v (and possibly armv7)

In D42459#969394, @imp wrote:

I generally like this change, one or two quibbles to work out.
I'd also split the lua and other stuff into separate commits (the old lua code will work with the new loader.efi, which I like as well).
But I can do the splitting if that's a hassle. This is otherwise fairly clean so I wouldn't mind a small amount of extra work.

Stripped out lua diff to submit separately

In D42415#969126, @arichardson wrote:

I see you have a reduced test case, would it be possible to turn it into a regression test for in the ld-elf tests?

Address Warner's comment regarding legacy hints and update the man page as suggested by Kyle

remove the entire if statement

Thanks for suggestions.

collapse tmp = *where + tmp -> tmp += *where

In D42415#968208, @jrtc27 wrote:

If IE is fixed then lib/libc/Makefile probably should enable it on arm as a follow-up, which I *think* is the only architecture not covered by that if statement, unless I'm missing something

Ensure we update tmp for dbg output

I have now reduced the diff down to the minimum. Thanks all for your continued comments.

I studied what NetBSD is doing here. Here is an updated test program:

LGTM

Add missing \n on the l3_addr format string

typo

Perform NULL-check on lle->lle_tbl

Fix regression in forward6:fwd_ip6_gu_icmp_gw_ll_slow_success

In D41882#954742, @kp wrote:

I've not dug into it yet, but it looks like this causes the sys/netinet6 forward6:fwd_ip6_gu_icmp_gw_ll_fast_success and forward6:fwd_ip6_gu_icmp_gw_ll_slow_success tests to fail.

Sample output:

(kp@freebsd_current_zfs)  /usr/tests/sys/netinet6 % sudo kyua debug forward6:fwd_ip6_gu_icmp_gw_ll_slow_success                                                                    [11:05]
Executing command [ jexec v6t-fff4--8373 route add -6 -host 2001:db8:6666:0000::fff4:4:8373 fe80::6c:e4ff:fe29:e20a%epair0b ]
v6t-fff4--8373: removed
Fail: stderr not empty
--- /dev/null   2023-09-17 09:06:00.862100000 +0000
+++ /tmp/kyua.6ZklLH/2/work/check.jwEAdR/stderr 2023-09-17 09:06:00.859014000 +0000
@@ -0,0 +1 @@
+route: message indicates error: No error: 0
Files left in work directory after failure: created_interfaces.lst, created_jails.lst
ifconfig: interface epair0a does not exist
forward6:fwd_ip6_gu_icmp_gw_ll_slow_success  ->  failed: atf-check failed; see the output of the test for details

I'm not sure if this is because there's something wrong with the patch or because there's something wrong with the test though.

Removed the unnecessary userspace filtering by-interface, the kernel is already doing
that now which I accidentally fixed by calling print_entries_nl with a valid (non-zero) ifindex

I have updated the diff with the style(9) changes suggested

Added full context