Page MenuHomeFreeBSD

rcm (R. Christian McDonald)
User

Projects

User Details

User Since
Apr 13 2023, 7:00 PM (45 w, 18 h)

Recent Activity

Mon, Jan 29

rcm committed rG5086b6ec32d5: libbe: handle destroying/renaming temporary/bootonce boot environments (authored by rcm).
libbe: handle destroying/renaming temporary/bootonce boot environments
Mon, Jan 29, 3:09 PM
rcm closed D43591: libbe: handle destroying/renaming temporary/bootonce boot environments.
Mon, Jan 29, 3:09 PM

Fri, Jan 26

rcm updated the diff for D43591: libbe: handle destroying/renaming temporary/bootonce boot environments.

Added back atf_skip for i386/armv7 to jail_cleanup

Fri, Jan 26, 2:04 PM

Thu, Jan 25

rcm added inline comments to D43591: libbe: handle destroying/renaming temporary/bootonce boot environments.
Thu, Jan 25, 11:41 PM
rcm added inline comments to D43591: libbe: handle destroying/renaming temporary/bootonce boot environments.
Thu, Jan 25, 10:28 PM
rcm added a comment to D43591: libbe: handle destroying/renaming temporary/bootonce boot environments.

Seems to LGTM. At some point we may want to update lbh->bootonce as new environments are activated/deactivated, but this is sufficient for bectl's needs and we don't really make many guarantees about the caching (or lack thereof) that occurs in the handle today, IIRC.

Thu, Jan 25, 5:11 PM
rcm updated the diff for D43591: libbe: handle destroying/renaming temporary/bootonce boot environments.
  1. Adds test cases for destroy and rename cases
  2. Fix bootonce leak
Thu, Jan 25, 5:10 PM
rcm retitled D43591: libbe: handle destroying/renaming temporary/bootonce boot environments from libbe: handle renaming temporary/bootonce boot environments to libbe: handle destroying/renaming temporary/bootonce boot environments.
Thu, Jan 25, 4:31 PM
rcm updated the diff for D43591: libbe: handle destroying/renaming temporary/bootonce boot environments.

Handles destroying bootonce case

Thu, Jan 25, 4:31 PM
rcm added a comment to D43591: libbe: handle destroying/renaming temporary/bootonce boot environments.

Can you add a test for this in sbin/bectl/tests/bectl_test.sh as well, please? Presumably you could use zfsbootcfg -z rather than checking the bectl list output.

I note that we should also do something on destroy of the bootonce dataset.

Thu, Jan 25, 4:15 PM
rcm requested review of D43591: libbe: handle destroying/renaming temporary/bootonce boot environments.
Thu, Jan 25, 3:50 PM

Dec 11 2023

rcm committed R11:1062ecb900bc: devel/simdjson: update to v3.6.2 (authored by rcm).
devel/simdjson: update to v3.6.2
Dec 11 2023, 2:48 PM

Nov 30 2023

rcm updated rcm.
Nov 30 2023, 5:03 PM

Nov 28 2023

rcm closed D41436: netlink: Add tests when adding an interface route.
Nov 28 2023, 9:54 PM
rcm committed rG1db64f89363c: netlink: Add tests when adding an interface route (authored by jlduran_gmail.com).
netlink: Add tests when adding an interface route
Nov 28 2023, 9:54 PM
rcm committed rGca7edd0d2c33: route: introduce add interface route test cases (authored by rcm).
route: introduce add interface route test cases
Nov 28 2023, 9:17 PM
rcm committed rGf818559774cb: netlink: fix adding an interface route (authored by takahiro.kurosawa_gmail.com).
netlink: fix adding an interface route
Nov 28 2023, 9:14 PM
rcm closed D41330: netlink: fix adding an interface route.
Nov 28 2023, 9:14 PM
rcm accepted D41436: netlink: Add tests when adding an interface route.

Thanks for that. LGTM

Nov 28 2023, 7:57 PM
rcm accepted D41330: netlink: fix adding an interface route.

This looks good to me.

Nov 28 2023, 6:00 PM
rcm added a comment to D41436: netlink: Add tests when adding an interface route.
In D41436#976151, @rcm wrote:
In D41436#976125, @rcm wrote:

Would it be possible to also get a v6 case?

Line 29?

ah yes, I should have scrolled up.

Is that really testing for the same case?

# setup_vnet(pytest:TestRtNlRoute:test_add_route4_ll_gw)
run: '/sbin/sysctl net.inet6.ip6.dad_count=0'
run: '/sbin/ifconfig epair0a up'
run: '/usr/sbin/ndp -i epair0a -disabled'
run: '/sbin/ifconfig epair0a inet6 2001:db8::1/64'
run: '/sbin/ifconfig epair0a inet6'
run: '/sbin/ifconfig tun create'

The whole point of D41330 was to handle the case where the interface doesn't have a v4/v6 address.

I'm working on adding it. Just like the IPv4 one (using tun, without a gateway), I'll name the tests add_route{4,6}_ll_if_gw.

Nov 28 2023, 5:52 PM
rcm added a comment to D41436: netlink: Add tests when adding an interface route.
In D41436#976125, @rcm wrote:

Would it be possible to also get a v6 case?

Line 29?

Nov 28 2023, 5:41 PM
rcm requested changes to D41436: netlink: Add tests when adding an interface route.

Would it be possible to also get a v6 case?

Nov 28 2023, 5:22 PM
rcm added a reviewer for D41330: netlink: fix adding an interface route: rcm.
Nov 28 2023, 2:40 PM

Nov 22 2023

rcm added reviewers for D42721: ifconfig: add -D option to print driver name for interface: kp, rcm.

@kp and I actually discussed this back in June in response to an internal need. In fact, he pointed me towards this exact interface ifconfig_get_orig_name.

Nov 22 2023, 5:04 PM

Nov 21 2023

rcm accepted D42699: stand/efi: Consolidate integer types.

Thanks for doing that. LGTM

Nov 21 2023, 8:31 PM

Nov 20 2023

pi renamed rcm from rcm_rcm.sh to rcm.
Nov 20 2023, 8:06 PM
rcm committed rGe0f3dc82727f: loader: improve lua ACPI detection and handling (authored by rcm).
loader: improve lua ACPI detection and handling
Nov 20 2023, 7:06 PM
rcm closed D42483: loader: improve lua ACPI detection and handling.
Nov 20 2023, 7:06 PM · Loader
rcm closed D42459: loader: fix EFI ACPI detection.
Nov 20 2023, 7:05 PM · Loader
rcm committed rG0b01d45783c3: loader: fix EFI ACPI detection (authored by rcm).
loader: fix EFI ACPI detection
Nov 20 2023, 7:05 PM
rcm committed R9:91518bde5761: pgpkeys: fix rcm typo (authored by rcm).
pgpkeys: fix rcm typo
Nov 20 2023, 5:31 PM
rcm committed R9:88c426676623: New src committer: R. Christian McDonald (authored by rcm).
New src committer: R. Christian McDonald
Nov 20 2023, 4:56 PM
rcm committed R9:6644ce200f82: pgpkeys: add key for rcm (authored by rcm).
pgpkeys: add key for rcm
Nov 20 2023, 4:56 PM
rcm committed rG34de1d507b53: committers-src: Add rcm as a src committer and kp as mentor (authored by rcm).
committers-src: Add rcm as a src committer and kp as mentor
Nov 20 2023, 4:38 PM

Nov 6 2023

rcm added inline comments to D42483: loader: improve lua ACPI detection and handling.
Nov 6 2023, 7:01 PM · Loader
rcm updated the diff for D42483: loader: improve lua ACPI detection and handling.
Nov 6 2023, 7:01 PM · Loader
rcm added inline comments to D42459: loader: fix EFI ACPI detection.
Nov 6 2023, 6:37 PM · Loader
rcm added a comment to D42459: loader: fix EFI ACPI detection.

Added @jrtc27 and @mhorne to chime in concerning @imp's question concerning risc-v (and possibly armv7)

Nov 6 2023, 5:43 PM · Loader
rcm added reviewers for D42459: loader: fix EFI ACPI detection: mhorne, jrtc27.
Nov 6 2023, 5:42 PM · Loader
rcm requested review of D42483: loader: improve lua ACPI detection and handling.
Nov 6 2023, 5:31 PM · Loader
rcm added inline comments to D42459: loader: fix EFI ACPI detection.
Nov 6 2023, 5:27 PM · Loader
rcm added a comment to D42459: loader: fix EFI ACPI detection.
In D42459#969394, @imp wrote:

I generally like this change, one or two quibbles to work out.
I'd also split the lua and other stuff into separate commits (the old lua code will work with the new loader.efi, which I like as well).
But I can do the splitting if that's a hassle. This is otherwise fairly clean so I wouldn't mind a small amount of extra work.

Nov 6 2023, 5:20 PM · Loader
rcm retitled D42459: loader: fix EFI ACPI detection from loader: fix efi ACPI detection to loader: fix EFI ACPI detection.
Nov 6 2023, 5:19 PM · Loader
rcm updated the diff for D42459: loader: fix EFI ACPI detection.

Stripped out lua diff to submit separately

Nov 6 2023, 5:19 PM · Loader

Nov 5 2023

rcm closed D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.

I see you have a reduced test case, would it be possible to turn it into a regression test for in the ld-elf tests?

Nov 5 2023, 1:53 PM · ARM

Nov 3 2023

rcm updated the diff for D42459: loader: fix EFI ACPI detection.

Address Warner's comment regarding legacy hints and update the man page as suggested by Kyle

Nov 3 2023, 7:47 PM · Loader
rcm added inline comments to D42459: loader: fix EFI ACPI detection.
Nov 3 2023, 7:35 PM · Loader
rcm updated rcm.
Nov 3 2023, 6:36 PM
rcm updated rcm.
Nov 3 2023, 6:35 PM
rcm retitled D42459: loader: fix EFI ACPI detection from loader/: fix ACPI detection and lua system default handling to loader: fix ACPI detection and lua system default handling.
Nov 3 2023, 6:30 PM · Loader
rcm requested review of D42459: loader: fix EFI ACPI detection.
Nov 3 2023, 6:29 PM · Loader

Nov 2 2023

rcm updated the diff for D42445: libc: enable initial-exec (IE) as default thread-local storage model on arm.

remove the entire if statement

Nov 2 2023, 3:41 PM · ARM
rcm requested review of D42445: libc: enable initial-exec (IE) as default thread-local storage model on arm.
Nov 2 2023, 1:52 PM · ARM
rcm added a comment to D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.

Thanks for suggestions.

Nov 2 2023, 1:03 PM · ARM
rcm updated the diff for D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.
Nov 2 2023, 1:03 PM · ARM
rcm updated the diff for D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.

collapse tmp = *where + tmp -> tmp += *where

Nov 2 2023, 1:02 PM · ARM

Nov 1 2023

rcm retitled D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation from rtld/arm: fix thread-local storage relocation to rtld/arm: fix initial-exec (IE) thread-local storage relocation.
Nov 1 2023, 7:59 PM · ARM
rcm added a comment to D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.

If IE is fixed then lib/libc/Makefile probably should enable it on arm as a follow-up, which I *think* is the only architecture not covered by that if statement, unless I'm missing something

Nov 1 2023, 7:51 PM · ARM
rcm updated the diff for D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.

Ensure we update tmp for dbg output

Nov 1 2023, 7:48 PM · ARM
rcm added inline comments to D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.
Nov 1 2023, 7:41 PM · ARM
rcm updated the diff for D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.

I have now reduced the diff down to the minimum. Thanks all for your continued comments.

Nov 1 2023, 7:37 PM · ARM
rcm added inline comments to D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.
Nov 1 2023, 7:32 PM · ARM
rcm updated the diff for D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.

I studied what NetBSD is doing here. Here is an updated test program:

Nov 1 2023, 7:10 PM · ARM
rcm added inline comments to D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.
Nov 1 2023, 3:55 PM · ARM
rcm added inline comments to D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.
Nov 1 2023, 1:25 PM · ARM

Oct 31 2023

rcm added a member for arm64: rcm.
Oct 31 2023, 7:18 PM
rcm added a reviewer for D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation: brd.
Oct 31 2023, 6:53 PM · ARM
rcm requested review of D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.
Oct 31 2023, 6:49 PM · ARM

Oct 21 2023

rcm updated the summary of D42316: ndp: improve -c and -d handling in ndp_netlink.
Oct 21 2023, 2:03 AM

Oct 20 2023

rcm added inline comments to D42307: netlink: fix potential llentry lock leak in newneigh handler.
Oct 20 2023, 3:31 PM
rcm updated the summary of D42316: ndp: improve -c and -d handling in ndp_netlink.
Oct 20 2023, 2:39 PM
rcm retitled D42316: ndp: improve -c and -d handling in ndp_netlink from ndp: improve -d and -c handling in ndp_netlink to ndp: improve -c and -d handling in ndp_netlink.
Oct 20 2023, 2:01 PM
rcm requested review of D42316: ndp: improve -c and -d handling in ndp_netlink.
Oct 20 2023, 1:58 PM

Oct 19 2023

rcm requested review of D42307: netlink: fix potential llentry lock leak in newneigh handler.
Oct 19 2023, 6:27 PM

Oct 17 2023

rcm updated the diff for D42269: ndp: fix timestamp display output.
Oct 17 2023, 6:38 PM
rcm requested review of D42269: ndp: fix timestamp display output.
Oct 17 2023, 6:31 PM
rcm accepted D42244: libbe: don't hardcode /tmp.

LGTM

Oct 17 2023, 6:10 PM
rcm updated the diff for D42253: lltable: fix ddb show llentry l3_addr pretty printer.

Add missing \n on the l3_addr format string

Oct 17 2023, 3:10 PM
rcm updated the diff for D42253: lltable: fix ddb show llentry l3_addr pretty printer.

typo

Oct 17 2023, 3:01 PM
rcm updated the diff for D42253: lltable: fix ddb show llentry l3_addr pretty printer.

Perform NULL-check on lle->lle_tbl

Oct 17 2023, 2:59 PM
rcm requested review of D42253: lltable: fix ddb show llentry l3_addr pretty printer.
Oct 17 2023, 2:12 PM

Sep 18 2023

rcm updated the diff for D41882: route(8): fix `route not found` exit code and warn with netlink.

Fix regression in forward6:fwd_ip6_gu_icmp_gw_ll_slow_success

Sep 18 2023, 6:11 PM

Sep 17 2023

rcm added a comment to D41882: route(8): fix `route not found` exit code and warn with netlink.
In D41882#954742, @kp wrote:

I've not dug into it yet, but it looks like this causes the sys/netinet6 forward6:fwd_ip6_gu_icmp_gw_ll_fast_success and forward6:fwd_ip6_gu_icmp_gw_ll_slow_success tests to fail.

Sample output:

(kp@freebsd_current_zfs)  /usr/tests/sys/netinet6 % sudo kyua debug forward6:fwd_ip6_gu_icmp_gw_ll_slow_success                                                                    [11:05]
Executing command [ jexec v6t-fff4--8373 route add -6 -host 2001:db8:6666:0000::fff4:4:8373 fe80::6c:e4ff:fe29:e20a%epair0b ]
v6t-fff4--8373: removed
Fail: stderr not empty
--- /dev/null   2023-09-17 09:06:00.862100000 +0000
+++ /tmp/kyua.6ZklLH/2/work/check.jwEAdR/stderr 2023-09-17 09:06:00.859014000 +0000
@@ -0,0 +1 @@
+route: message indicates error: No error: 0
Files left in work directory after failure: created_interfaces.lst, created_jails.lst
ifconfig: interface epair0a does not exist
forward6:fwd_ip6_gu_icmp_gw_ll_slow_success  ->  failed: atf-check failed; see the output of the test for details

I'm not sure if this is because there's something wrong with the patch or because there's something wrong with the test though.

Sep 17 2023, 11:42 AM

Sep 15 2023

rcm updated the diff for D41882: route(8): fix `route not found` exit code and warn with netlink.
Sep 15 2023, 8:29 PM
rcm requested review of D41882: route(8): fix `route not found` exit code and warn with netlink.
Sep 15 2023, 8:27 PM

Sep 13 2023

rcm retitled D41839: arp(8): fix by-interface and by-host filtering when using netlink from arp(8): implement by-interface and by-host filtering with netlink to arp(8): fix by-interface and by-host filtering when using netlink.
Sep 13 2023, 5:08 PM
rcm updated the diff for D41839: arp(8): fix by-interface and by-host filtering when using netlink.

Removed the unnecessary userspace filtering by-interface, the kernel is already doing
that now which I accidentally fixed by calling print_entries_nl with a valid (non-zero) ifindex

Sep 13 2023, 4:43 PM
rcm added a member for network: rcm.
Sep 13 2023, 3:54 PM
rcm added inline comments to D41839: arp(8): fix by-interface and by-host filtering when using netlink.
Sep 13 2023, 3:11 PM
rcm retitled D41839: arp(8): fix by-interface and by-host filtering when using netlink from arp(8): implement by interface and by host filtering with netlink to arp(8): implement by-interface and by-host filtering with netlink.
Sep 13 2023, 8:46 AM
rcm requested review of D41839: arp(8): fix by-interface and by-host filtering when using netlink.
Sep 13 2023, 12:30 AM

Jul 12 2023

rcm added a comment to D40972: libbe: recursively promote deep BE datasets.

I have updated the diff with the style(9) changes suggested

Jul 12 2023, 12:38 PM
rcm updated the diff for D40972: libbe: recursively promote deep BE datasets.
Jul 12 2023, 12:31 PM

Jul 11 2023

rcm added inline comments to D40972: libbe: recursively promote deep BE datasets.
Jul 11 2023, 9:06 PM
rcm updated the diff for D40972: libbe: recursively promote deep BE datasets.
Jul 11 2023, 9:03 PM
rcm updated the diff for D40972: libbe: recursively promote deep BE datasets.
Jul 11 2023, 9:02 PM
rcm updated the diff for D40972: libbe: recursively promote deep BE datasets.
Jul 11 2023, 8:26 PM
rcm updated the diff for D40972: libbe: recursively promote deep BE datasets.

Added full context

Jul 11 2023, 6:43 PM
rcm added a comment to D40972: libbe: recursively promote deep BE datasets.

For future diffs, please include full context (-U999999) or use arc

Jul 11 2023, 6:38 PM