Start the burst before the receive loop rather than after it, and end it on the error path too, so that packets tcp_lro_queue_mbuf() hands to if_input() from inside the loop are covered; that happens whenever LRO is enabled with IP forwarding on, and igc, em, igb, ix and ixl enable LRO by default.

removed extraneous space

The diff is now just the functional change, the early return in iflib_txd_db_check() when ift_db_pending is 0. The inversion will be posted separately as a no-functional-change follow-up.

In D60290#1384499, @kbowling wrote:

I'm about to leave on a business trip so I can't give a proper affirmative review, but one thing jumps out without digging into anything.. the multi-line comment and another control flow make it somewhat unpleasing to me. I would investigate a couple ways of writing this, either build the ring decision up with single statement ifs (and line comments as needed), or use de morgans to move true or false around so there are early exits and only one ring decision (perhaps de-indented.. whatever ends up feeling clean after playing with it.

add full-context diff. no other changes.

In D60284#1383431, @kbowling wrote:

I thought the idea of d9c55b2e8cd6b79f6926278e10a79f1bcca27a4b was to get rid of most of the ifdef. rss_gethashconfig is a public function, why not just apply what you have in the ifdef RSS section always?

pivoted to just removing these getters entirely

In D60248#1382592, @kp wrote:

I wonder if we shouldn't just remove these versions of the get_states functions altogether.

This version is unhelpful because it doesn't take the pfctl_handle. There's a _h variant which does, and which should get used instead.

The first version made room for NLMSG_DONE by overwriting completed messages in the writer's buffer, which could discard replies to earlier requests from the same send() and still left non-dump requests without an ack. This version drops that: nlmsg_ack() now waits for memory and reports ENOMEM for any reply that ran out of it, so a failed dump ends with NLMSG_ERROR after its complete messages and every request gets an answer.

Prefer parser test as per kp@

Made dup a bool set from RB_INSERT(...) != NULL, as suggested. I agree; that reads better.