Page MenuHomeFreeBSD
Differential D42253

lltable: fix ddb show llentry l3_addr pretty printer
ClosedPublic
Actions

Authored by rcm on Oct 17 2023, 2:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 1:19 AM
Unknown Object (File)
Sun, May 5, 8:12 PM
Unknown Object (File)
Sat, May 4, 5:33 AM
Unknown Object (File)
Sat, May 4, 5:13 AM
Unknown Object (File)
Tue, Apr 30, 5:52 AM
Unknown Object (File)
Tue, Apr 30, 5:50 AM
Unknown Object (File)
Tue, Apr 30, 5:13 AM
Unknown Object (File)
Tue, Apr 30, 5:10 AM
View All 33 Files
Subscribers
ae
glebius
imp
pfsense

Details

Reviewers
kp
melifaro
Group Reviewers
network
Commits
rG6e281255ea35: lltable: fix ddb show llentry l3_addr pretty printer
Summary

The ddb commands for lltable do not produce useful l3_addr information.

This fixes the llentry pretty printer to correctly display the l3_addr

Sponsored by: Rubicon Communications, LLC ("Netgate")

Test Plan

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rcm created this revision.Oct 17 2023, 2:12 PM
Herald added subscribers: glebius, ae, imp. · View Herald TranscriptOct 17 2023, 2:12 PM
rcm requested review of this revision.Oct 17 2023, 2:12 PM
kp added inline comments.Oct 17 2023, 2:44 PM
sys/net/if_llatbl.c
1095–1099

It might be worth NULL-checking lle->lle_tbl here first.

rcm updated this revision to Diff 128926.Oct 17 2023, 2:59 PM

Perform NULL-check on lle->lle_tbl

rcm updated this revision to Diff 128929.Oct 17 2023, 2:59 PM
rcm marked an inline comment as done.

typo

rcm updated this revision to Diff 128933.Oct 17 2023, 3:10 PM

Add missing \n on the l3_addr format string

kp accepted this revision as: kp.Oct 17 2023, 3:52 PM

LGTM.

I'll give melifaro@ a little more time to comment before I push this.

This revision is now accepted and ready to land.Oct 17 2023, 3:52 PM
Closed by commit rG6e281255ea35: lltable: fix ddb show llentry l3_addr pretty printer (authored by rcm, committed by kp). · Explain WhyOct 17 2023, 7:16 PM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG6e281255ea35: lltable: fix ddb show llentry l3_addr pretty printer.

Revision Contents
Changeset List

PathSize
sys/
net/
39 lines

Diff 128953

View Options

sys/net/if_llatbl.c

Loading...