networkUmbrella
ActivePublic

Recent Activity

Yesterday

emaste added a comment to D15168: Microchip's LAN78XX driver for FreeBSD.

Please align the constants in the header file

Mon, Apr 23, 7:58 PM · network
arshankhanifar_gmail.com created D15168: Microchip's LAN78XX driver for FreeBSD.
Mon, Apr 23, 2:01 PM · network
emeric.poupon_stormshield.eu updated the diff for D15050: Add a SPD cache to speed up lookups.

ae's remarks

Mon, Apr 23, 9:23 AM · network
emeric.poupon_stormshield.eu added inline comments to D15050: Add a SPD cache to speed up lookups.
Mon, Apr 23, 8:21 AM · network

Fri, Apr 20

ae added inline comments to D15050: Add a SPD cache to speed up lookups.
Fri, Apr 20, 3:41 PM · network
emeric.poupon_stormshield.eu added inline comments to D15050: Add a SPD cache to speed up lookups.
Fri, Apr 20, 3:05 PM · network
ae added inline comments to D15050: Add a SPD cache to speed up lookups.
Fri, Apr 20, 1:33 PM · network
emeric.poupon_stormshield.eu updated the diff for D15050: Add a SPD cache to speed up lookups.

Update the maxentries sysctl once the hashtable has been init in order to reflect the actual size used.

Fri, Apr 20, 12:35 PM · network

Fri, Apr 13

emeric.poupon_stormshield.eu added a comment to D15050: Add a SPD cache to speed up lookups.
In D15050#317087, @ae wrote:

Can you provide some numbers what benefits you have with this patch?

Fri, Apr 13, 8:59 AM · network

Thu, Apr 12

ae added a comment to D15050: Add a SPD cache to speed up lookups.

Can you provide some numbers what benefits you have with this patch?

Thu, Apr 12, 6:08 PM · network
emeric.poupon_stormshield.eu created D15050: Add a SPD cache to speed up lookups.
Thu, Apr 12, 1:11 PM · network

Wed, Apr 11

kristof added a comment to D14536: Set DSCP bits in ip_carp.

Sorry I thought I had already replied to this. I have issues with keeping that as the default value as it has been deprecated since 1998. As such it's not really a sane default and not compatible with much modern routing gear. The setting I choose comes directly our of the RFC for this type of traffic.

Well, as I said, I have no views on what the value should be. I defaulted to keeping the old value, but if you've got a good reason to change it that's fine by me.

Wed, Apr 11, 3:22 PM · network
darkfiberiru_gmail.com added a comment to D14536: Set DSCP bits in ip_carp.

I have no specific views on what the value should be. The remark mostly comes from the desire to avoid having the kernel enforce policy. It's only a small extra step here for more flexibility.
I think I'd make net.inet.carp.dscp be an integer, with a default value of (the value of) IPTOS_LOWDELAY.

Wed, Apr 11, 3:03 PM · network

Tue, Apr 10

Dinislam.Salikhov_kaspersky.com added a comment to D5017: More than 65K connection from single application.

AFAIU, the patch has been neither finished nor submitted to master.
The last activity was more than a year ago, so should it be considered as abandoned?
Are there any plans to add the feature into the kernel?

Tue, Apr 10, 12:07 PM · network

Fri, Apr 6

kmacy abandoned D12101: swfw_sync DELAY -> sleep conversion.

Split in to many separate reviews.

Fri, Apr 6, 1:09 AM · network

Thu, Apr 5

0mp added a comment to D14966: rsu(4) does not require legal.realtek.license_ack=1.
In D14966#314881, @bcr wrote:

Bump the .Dd when you do the actual commit (once network has approved, too).

Thu, Apr 5, 10:58 AM · manpages
bcr accepted D14966: rsu(4) does not require legal.realtek.license_ack=1.

OK from manpages. Bump the .Dd when you do the actual commit (once network has approved, too). Thanks for working on this!

Thu, Apr 5, 10:35 AM · manpages

Wed, Apr 4

0mp created D14966: rsu(4) does not require legal.realtek.license_ack=1.
Wed, Apr 4, 10:19 PM · manpages

Mar 23 2018

Diffusion closed D13715: netpfil: Introduce PFIL_FWD flag.
Mar 23 2018, 4:57 PM · network

Mar 21 2018

kevans accepted D13715: netpfil: Introduce PFIL_FWD flag.
Mar 21 2018, 6:49 PM · network
ae accepted D13715: netpfil: Introduce PFIL_FWD flag.

Looks good to me.

Mar 21 2018, 10:38 AM · network

Mar 20 2018

kmacy abandoned D12102: add tunable to eliminate conflict misses when frequently acccessing the first cache line of mbuf & cluster.

I've made it work with additional changes, but don't have a workload + hardware combo that benefits from the reduction in cache misses.

Mar 20 2018, 11:34 PM · network

Mar 19 2018

kristof updated the diff for D13715: netpfil: Introduce PFIL_FWD flag.

Keep the old hooks so other pfil users don't need to change. Allow pf to use the new style of hook, with the flags argument.

Mar 19 2018, 9:12 AM · network

Mar 14 2018

loos requested changes to D3133: Fixes on Bridge+CARP crashes/freezes.
Mar 14 2018, 5:40 PM · network
loos added inline comments to D3133: Fixes on Bridge+CARP crashes/freezes.
Mar 14 2018, 5:39 PM · network

Mar 3 2018

kristof added a reviewer for D14536: Set DSCP bits in ip_carp: glebius.

I have no specific views on what the value should be. The remark mostly comes from the desire to avoid having the kernel enforce policy. It's only a small extra step here for more flexibility.
I think I'd make net.inet.carp.dscp be an integer, with a default value of (the value of) IPTOS_LOWDELAY.

Mar 3 2018, 9:46 AM · network

Mar 2 2018

darkfiberiru_gmail.com added a comment to D14536: Set DSCP bits in ip_carp.

Would it make sense to set the DSCP value to the value configured in 'net.inet.carp.dscp' rather than a hardcoded value?

Mar 2 2018, 6:21 PM · network
kristof added a comment to D14536: Set DSCP bits in ip_carp.

Would it make sense to set the DSCP value to the value configured in 'net.inet.carp.dscp' rather than a hardcoded value?

Mar 2 2018, 2:37 PM · network

Feb 27 2018

mav accepted D14536: Set DSCP bits in ip_carp.
Feb 27 2018, 11:00 PM · network
darkfiberiru_gmail.com updated the diff for D14536: Set DSCP bits in ip_carp.

Fixed default setting of new sysctl in man page.

Feb 27 2018, 9:44 PM · network
darkfiberiru_gmail.com created D14536: Set DSCP bits in ip_carp.
Feb 27 2018, 6:10 PM · network

Jan 31 2018

kristof added a comment to D13715: netpfil: Introduce PFIL_FWD flag.
In D13715#296796, @ae wrote:

I think someone from pfSense or openSense already reworked PF to work "inplace" like ipfw does, i.e. it returns mbuf back to the function from where pfil was invoked.

Jan 31 2018, 10:36 PM · network
ae added a comment to D13715: netpfil: Introduce PFIL_FWD flag.

I'd like to fix the issue where pf can't reliably figure out if it should call ip6_forward() or ip6_output(). I'd like to do so without negatively affecting the general forwarding performance (with or without pf).

Jan 31 2018, 9:54 AM · network
kristof added a comment to D13715: netpfil: Introduce PFIL_FWD flag.
In D13715#296702, @eri wrote:
In D13715#295449, @eri wrote:

While i have not much time lately to spend on this, i still think this is the wrong way of doing things since it just creates confusion.

I'm not sure I see how this would create confusion. This merely presents more information about the packet, and where the netpfil hook being called from.

pf(4) already has a loop detection mechanism that i created to support divert(9) and dummunet(9), not sure if the later ever made it into FreeBSD.

Now I'm confused. This isn't about loop detection. This is about detecting if a PFIL_OUT packet is being forwarded or output.

Jan 31 2018, 5:58 AM · network
eri added a comment to D13715: netpfil: Introduce PFIL_FWD flag.
In D13715#295449, @eri wrote:

While i have not much time lately to spend on this, i still think this is the wrong way of doing things since it just creates confusion.

I'm not sure I see how this would create confusion. This merely presents more information about the packet, and where the netpfil hook being called from.

Jan 31 2018, 4:35 AM · network

Jan 30 2018

ae added a comment to D13715: netpfil: Introduce PFIL_FWD flag.

I'm against the last proposal. It is not costless to tag each forwarded packet and then remove the tag. This will seriously hit the performance.

Jan 30 2018, 11:12 AM · network

Jan 29 2018

kevans added a comment to D13715: netpfil: Introduce PFIL_FWD flag.

(Apologies; last comment on this matter)

Jan 29 2018, 6:08 PM · network
kevans added a comment to D13715: netpfil: Introduce PFIL_FWD flag.

I guess the "cost should be relatively low" comment is kind of wrong. OUT hooks that care about whether it's forwarded or not will take a hit if it's not forwarded and the tag is not present, but I have no idea how heavy this would be- I have no notion of how heavily used mbuf tags are. =)

Jan 29 2018, 3:52 PM · network
kevans added a comment to D13715: netpfil: Introduce PFIL_FWD flag.
In D13715#295449, @eri wrote:

pf(4) has already knows about mbuf_tag(9) and uses it. I would strongly suggest using them until a proper _FWD hook comes to life and allows removing all the 'hacks' in pf(4) and possibly elsewhere.

My gut reaction (i.e. without benchmarks) is that there'd be a performance penalty for tagging all forwarded packets.

Jan 29 2018, 3:47 PM · network

Jan 27 2018

kristof added a comment to D13715: netpfil: Introduce PFIL_FWD flag.
In D13715#295449, @eri wrote:

While i have not much time lately to spend on this, i still think this is the wrong way of doing things since it just creates confusion.

I'm not sure I see how this would create confusion. This merely presents more information about the packet, and where the netpfil hook being called from.

Jan 27 2018, 5:14 AM · network
eri added a comment to D13715: netpfil: Introduce PFIL_FWD flag.

While i have not much time lately to spend on this, i still think this is the wrong way of doing things since it just creates confusion.
pf(4) has already knows about mbuf_tag(9) and uses it. I would strongly suggest using them until a proper _FWD hook comes to life and allows removing all the 'hacks' in pf(4) and possibly elsewhere.

Jan 27 2018, 2:54 AM · network

Jan 26 2018

kevans accepted D13715: netpfil: Introduce PFIL_FWD flag.

Having had time to review it again, I think it looks good. This iteration exposes it as a flag to describes the path the packet's taken, rather than exposing it as the direction the packet is going in and having places where it was necessary to then mask that fact by flipping dir back to OUT where paths didn't yet know about FWD

Jan 26 2018, 2:42 AM · network
kevans added a comment to D13715: netpfil: Introduce PFIL_FWD flag.

Sorry, removal of manpages was unintentional- caches, grrrr.

Jan 26 2018, 12:58 AM · network
kevans edited reviewers for D13715: netpfil: Introduce PFIL_FWD flag, added: kevans; removed: manpages.
Jan 26 2018, 12:54 AM · network
kristof updated the diff for D13715: netpfil: Introduce PFIL_FWD flag.

Based around a suggestion from Kyle Evans (who also did all of the work), introduce a flags variable to the pfil callbacks. Keep using PFIL_OUT for forwarded packets, but set the PFIL_FWD flag for them. This allows pf to work out if a packet is being forwarded or not, with essentially no changes to other netpfil consumers.

Jan 26 2018, 12:51 AM · network

Jan 6 2018

kristof added a comment to D13715: netpfil: Introduce PFIL_FWD flag.
In D13715#288702, @eri wrote:

While this is needed i do not agree that the modifications on the stack and packet filters should be so hackish.

Jan 6 2018, 8:20 PM · network
kristof updated the diff for D13715: netpfil: Introduce PFIL_FWD flag.

More context. No changes to the diff.

Jan 6 2018, 8:17 PM · network
eri added a comment to D13715: netpfil: Introduce PFIL_FWD flag.

While this is needed i do not agree that the modifications on the stack and packet filters should be so hackish.

Jan 6 2018, 6:58 PM · network
ae added a comment to D13715: netpfil: Introduce PFIL_FWD flag.

Can you please update the patch with additional context according to https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface

Jan 6 2018, 4:54 PM · network

Dec 31 2017

kristof created D13715: netpfil: Introduce PFIL_FWD flag.
Dec 31 2017, 4:38 PM · network