eadler (Eitan Adler)Administrator
Janitor

Projects (15)

User Details

User Since
May 10 2014, 4:24 PM (219 w, 4 h)
Roles
Administrator

Recent Activity

Sat, Jul 14

eadler accepted D16223: Remove not particularly recognizable sites.
Sat, Jul 14, 4:23 PM

Wed, Jul 11

eadler added a comment to D16211: run(4): Add a new USB device ID..

Don't forget to bump .Dd when you commit btw

Wed, Jul 11, 1:36 AM
eadler added a comment to D16211: run(4): Add a new USB device ID..

(I'm assuming its been tested by at least one person)

Wed, Jul 11, 1:19 AM
eadler accepted D16211: run(4): Add a new USB device ID..
Wed, Jul 11, 1:19 AM

Tue, Jul 10

eadler added inline comments to D16095: add a new port: textproc/tttcmds.
Tue, Jul 10, 3:41 AM

Sat, Jul 7

eadler added a comment to D15801: top(1): reimplement header formatting as sbuf.

Thanks for the quick reply - I don't know if you saw my edit, but for some stupid reason I missed your previous reply when I replied.

Sat, Jul 7, 11:30 PM
eadler added a comment to D15801: top(1): reimplement header formatting as sbuf.

Steal space from RES and SIZE; incrase username

I can't stress how much I hated this. It's 2018, can we do something smarter than assuming the terminal has a fixed width of 80 characters instead of squeezing space unconditionally?

Sat, Jul 7, 10:45 PM

Fri, Jul 6

eadler accepted D16083: Changed to eliminate the upper limit of command length displayed by "-a" and expand to match terminal width.

I'll probably spend some time to sbufize this, but this change is good for now.

Fri, Jul 6, 10:41 AM
eadler added a comment to D16134: Fix French spelling in English docs.
Fri, Jul 6, 3:41 AM
eadler accepted D16134: Fix French spelling in English docs.
Fri, Jul 6, 2:29 AM

Thu, Jul 5

eadler added a reviewer for D16132: New cmb(3) library and cmb(1) utility: eadler.
Thu, Jul 5, 3:45 AM
eadler added a reviewer for D16132: New cmb(3) library and cmb(1) utility: eadler.
Thu, Jul 5, 3:20 AM
eadler requested changes to D16083: Changed to eliminate the upper limit of command length displayed by "-a" and expand to match terminal width.
Thu, Jul 5, 2:03 AM

Tue, Jul 3

eadler added inline comments to D16091: Committer guide: avoid confusing maintainers with hats.
Tue, Jul 3, 2:57 PM
eadler added a comment to D16092: Committer guide: add note about private discussions.

@eadler :, I understand, and no problem. I think you're hitting on something that would be good to formalize, but I want to make sure that what gets prescribed as a community rule of thumb is accurate and strikes the right balance. I think we'd all collectively take something that's an improvement and incremental over something that is perfect. "Perfect is the enemy of good." :~] Also, if you want to hit me up on Slack or IRC to talk in a higher-bandwidth medium than a review, feel free.

Tue, Jul 3, 3:48 AM
eadler added a comment to D16091: Committer guide: avoid confusing maintainers with hats.
In D16091#341256, @jhb wrote:

I think this page might have referred to some of these folks in the past, but those individuals have been purged by now (at least the ones mentioned explicitly in the text). Do we have any other references to things like re@ owning release branches (and other branches during freezes?) or secteam@ owning certain parts of the tree?

Tue, Jul 3, 2:42 AM
eadler accepted D16105: vm_map.9: Update to match the struct layout in sys/vm/vm_map.h.
Tue, Jul 3, 2:37 AM

Mon, Jul 2

eadler added a comment to D16092: Committer guide: add note about private discussions.

Thank you for carrying this discussion forward into a separate review, @eadler.

It seems as though this revision doesn't include an element of what you had intended with your original patch. Can you elaborate on the change that you are hoping for? I want to make sure I understand the position that you're advocating for and that I'm hearing your concerns, or that whatever point it is you're trying to make is heard.

Mon, Jul 2, 3:27 PM
eadler updated the diff for D16092: Committer guide: add note about private discussions.
Mon, Jul 2, 6:31 AM
eadler planned changes to D16092: Committer guide: add note about private discussions.
Mon, Jul 2, 6:31 AM
eadler added a comment to D16080: Multiple updates for the committer guide.
In D16080#341072, @imp wrote:

I am not dropping this discussion, just going to split this review up. Expect to see an updated review, with your comments addressed, in the next week or so

It isn't about your views. It's about the project's views and core's notions of where to put and not put emphasis on in a guide to fellow committers.

Mon, Jul 2, 3:07 AM
eadler added a comment to D16080: Multiple updates for the committer guide.

ref D16089 D16090 D16091 D16092

Mon, Jul 2, 2:02 AM
eadler planned changes to D16092: Committer guide: add note about private discussions.
Mon, Jul 2, 2:00 AM
eadler created D16092: Committer guide: add note about private discussions.
Mon, Jul 2, 2:00 AM
eadler created D16091: Committer guide: avoid confusing maintainers with hats.
Mon, Jul 2, 1:59 AM
eadler created D16090: Comitter guide: rewrite the section on testing..
Mon, Jul 2, 1:58 AM
eadler created D16089: committer guide: update rules for contrib software..
Mon, Jul 2, 1:58 AM
eadler abandoned D16080: Multiple updates for the committer guide.

I am not dropping this discussion, just going to split this review up. Expect to see an updated review, with your comments addressed, in the next week or so

Mon, Jul 2, 1:56 AM
eadler committed rD51942: Committer guide: expand ports-secteam blanket.
Committer guide: expand ports-secteam blanket
Mon, Jul 2, 1:51 AM
eadler added a comment to D16083: Changed to eliminate the upper limit of command length displayed by "-a" and expand to match terminal width.

I'd like to move away from using static sizes and limits. This is fine as a stop-gap, but please consider changes that remove such static sizes.

Mon, Jul 2, 1:47 AM

Sun, Jul 1

eadler committed rS335851: find(1): deLINTify.
find(1): deLINTify
Sun, Jul 1, 8:10 PM
eadler committed rS335852: find(1): use correct type for readlink.
find(1): use correct type for readlink
Sun, Jul 1, 8:10 PM
eadler committed rS335850: top(1): permit infinite length for command.
top(1): permit infinite length for command
Sun, Jul 1, 7:44 PM
eadler committed rS335849: find(1): remove portability ifdefs.
find(1): remove portability ifdefs
Sun, Jul 1, 7:44 PM
eadler added a comment to D15801: top(1): reimplement header formatting as sbuf.

Steal space from RES and SIZE; incrase username

I can't stress how much I hated this. It's 2018, can we do something smarter than assuming the terminal has a fixed width of 80 characters instead of squeezing space unconditionally?

Sun, Jul 1, 5:42 PM
eadler added a comment to D16080: Multiple updates for the committer guide.

(fwiw, If there only contentious part is the new words about private discussions, I'd like approval to commit the other parts first. This will make it easier to track and review)

Sun, Jul 1, 3:48 AM
eadler created D16081: tools/build/beinstall.sh: Use some slightly better shell syntax; reduce duplication.
Sun, Jul 1, 3:28 AM
eadler added inline comments to D16080: Multiple updates for the committer guide.
Sun, Jul 1, 3:13 AM
eadler updated the diff for D16080: Multiple updates for the committer guide.

Reduce preachyness, and give more actionable advice

Sun, Jul 1, 3:12 AM
eadler added inline comments to D16080: Multiple updates for the committer guide.
Sun, Jul 1, 12:05 AM
eadler added a reviewer for D16080: Multiple updates for the committer guide: Core Team.
Sun, Jul 1, 12:04 AM
eadler created D16080: Multiple updates for the committer guide.
Sun, Jul 1, 12:04 AM

Sat, Jun 30

eadler accepted D16075: rup: Fix -Wcast-align warnings.

For my edification: the two possible solutions to cast alignment are (a) memcpy and (b) aligned_alloc. The issue with the latter is that the compiler likely won't understand it, and thus still warn.

Sat, Jun 30, 1:54 PM
eadler committed rD51939: Developer's handbook: bump some version numbers.
Developer's handbook: bump some version numbers
Sat, Jun 30, 10:57 AM
eadler committed rD51938: Developer's handbook: remove games/ reference.
Developer's handbook: remove games/ reference
Sat, Jun 30, 10:45 AM
eadler committed rD51937: Committers guide: remove about hrs being maintainer of relnotes.
Committers guide: remove about hrs being maintainer of relnotes
Sat, Jun 30, 10:36 AM
eadler committed rD51936: Administration: sync with mail aliases.
Administration: sync with mail aliases
Sat, Jun 30, 10:02 AM
eadler committed rD51935: Committers guide: simplification of the vendor merge section.
Committers guide: simplification of the vendor merge section
Sat, Jun 30, 8:18 AM
eadler committed rD51934: Committers guide: pet igor.
Committers guide: pet igor
Sat, Jun 30, 8:02 AM
eadler committed rD51933: Committers guide: wordsmith the section on maintainers.
Committers guide: wordsmith the section on maintainers
Sat, Jun 30, 5:56 AM
eadler committed rD51932: Committer's guide: update the ssh_config.
Committer's guide: update the ssh_config
Sat, Jun 30, 5:33 AM
eadler committed rS335812: iwn: Add the missing IWN_SDID_6035_5 subdevice.
iwn: Add the missing IWN_SDID_6035_5 subdevice
Sat, Jun 30, 4:30 AM
eadler committed rS335811: bsd-family-tree: Announce DragonFly version 5.2.2.
bsd-family-tree: Announce DragonFly version 5.2.2
Sat, Jun 30, 1:04 AM
eadler committed rS335810: bsd-family-tree: Announce DragonFly version 5.2.2.
bsd-family-tree: Announce DragonFly version 5.2.2
Sat, Jun 30, 1:03 AM

Fri, Jun 29

eadler accepted D16064: Add conv=direct.
Fri, Jun 29, 4:12 PM
eadler added a comment to D16058: top(1) - support UTF-8 display.

It is a bit late for me, so this is just an initial scan.

Fri, Jun 29, 8:08 AM
eadler committed rD51926: Explaining BSD: remove a false statement.
Explaining BSD: remove a false statement
Fri, Jun 29, 7:34 AM

Thu, Jun 28

eadler committed rS335785: iwn: Correct Centrino Advanced-N 6235 constants.
iwn: Correct Centrino Advanced-N 6235 constants
Thu, Jun 28, 9:59 PM
eadler accepted D16047: Allow jail names (not just IDs) to be specified for: cpuset(1), ipfw(8), sockstat(1), ugidfw(8).

I had a memory of some utilities supporting any or -1 for "in a jail" (i.e. jid != 0). Might be worth looking at doing this too

Thu, Jun 28, 7:23 PM

Wed, Jun 27

eadler committed rS335695: MFC r302776, r302799:.
MFC r302776, r302799:
Wed, Jun 27, 4:59 AM
eadler committed rS335694: MFC r302776, r302799:.
MFC r302776, r302799:
Wed, Jun 27, 4:56 AM
eadler committed rS335693: MFC r302776, r302799:.
MFC r302776, r302799:
Wed, Jun 27, 4:37 AM
eadler committed rS335686: MFC r334208:.
MFC r334208:
Wed, Jun 27, 3:29 AM
eadler committed rS335683: powerd: correct ifdef check for ppc.
powerd: correct ifdef check for ppc
Wed, Jun 27, 1:28 AM

Tue, Jun 26

eadler accepted D16006: top(1): increased the maximum length of command shown by "-a".
Tue, Jun 26, 2:00 PM

Mon, Jun 25

eadler committed rS335638: rusers: modernize a bit.
rusers: modernize a bit
Mon, Jun 25, 11:45 AM
eadler committed rS335637: rup: compile with WARNS=6.
rup: compile with WARNS=6
Mon, Jun 25, 11:45 AM
eadler committed rS335636: users(1): Use capsicum helpers for users.
users(1): Use capsicum helpers for users
Mon, Jun 25, 11:44 AM
eadler committed rS335612: dhclient: recorrect __progname to getprogname().
dhclient: recorrect __progname to getprogname()
Mon, Jun 25, 1:30 AM

Sun, Jun 24

eadler committed rS335602: dhclient: build with WARNS=6.
dhclient: build with WARNS=6
Sun, Jun 24, 1:23 PM
eadler committed rS335601: top(1): increase field with width for W/CPU column.
top(1): increase field with width for W/CPU column
Sun, Jun 24, 1:14 PM
eadler updated the summary of D15994: paths.h chase rcmds removal.
Sun, Jun 24, 10:20 AM
eadler retitled D15994: paths.h chase rcmds removal from change rcmds removal to paths.h chase rcmds removal.
Sun, Jun 24, 10:09 AM
eadler created D15994: paths.h chase rcmds removal.
Sun, Jun 24, 10:02 AM
eadler abandoned D15993: change rcmds removal.

too many files

Sun, Jun 24, 9:59 AM
eadler created D15993: change rcmds removal.
Sun, Jun 24, 9:58 AM
eadler committed rS335598: Makefiles: remove outdated comments.
Makefiles: remove outdated comments
Sun, Jun 24, 9:40 AM
eadler committed rS335597: newfs: clean up warnings.
newfs: clean up warnings
Sun, Jun 24, 5:41 AM

Sat, Jun 23

eadler abandoned D15786: Mark functions as __pure and __pure2.
Sat, Jun 23, 10:49 PM
eadler committed rS335590: top(1): Convert process listing to sbuf too.
top(1): Convert process listing to sbuf too
Sat, Jun 23, 10:45 PM
eadler committed rS335591: top(1): Restructure printing of process states.
top(1): Restructure printing of process states
Sat, Jun 23, 10:45 PM
eadler committed rS335589: top(1): Use basename instead of a homegrown alternative.
top(1): Use basename instead of a homegrown alternative
Sat, Jun 23, 10:45 PM
eadler added a comment to D15960: top(1): Start parsing colors.
In D15960#338171, @bcr wrote:

Would it make sense to add an EXAMPLES section that shows how to define a proper TOPCOLOR?

Sat, Jun 23, 6:59 PM
eadler committed rS331665: [iwm] Add support for iwm 3168 cards.
[iwm] Add support for iwm 3168 cards
Sat, Jun 23, 5:12 AM
eadler committed rS335576: top(1): show CPU state breakdown on first run.
top(1): show CPU state breakdown on first run
Sat, Jun 23, 3:17 AM

Fri, Jun 22

eadler committed rS335552: top(1): increase warnings.
top(1): increase warnings
Fri, Jun 22, 10:20 AM
eadler committed rS335551: top(1): garbage collect.
top(1): garbage collect
Fri, Jun 22, 10:17 AM
eadler committed rS335550: top(1): increase size of 'C' column.
top(1): increase size of 'C' column
Fri, Jun 22, 10:17 AM
eadler committed rS335547: top(1): remove special handling of load > 5.
top(1): remove special handling of load > 5
Fri, Jun 22, 9:45 AM
eadler closed D15801: top(1): reimplement header formatting as sbuf.
Fri, Jun 22, 9:21 AM
eadler committed rS335539: top(1): reimplement header formatting as sbuf.
top(1): reimplement header formatting as sbuf
Fri, Jun 22, 9:21 AM
eadler committed rS335535: su(1): build with WARNS=6.
su(1): build with WARNS=6
Fri, Jun 22, 9:11 AM
eadler added a comment to D15961: Fixed typo in epoch(9) man page.

Thanks for your report. Fixed along with a couple of other issues noticed.

Fri, Jun 22, 6:05 AM
eadler committed rS335532: epoch.9: bump Dd.
epoch.9: bump Dd
Fri, Jun 22, 6:05 AM
eadler committed rS335531: epoch.9: fix some style and speeling issues.
epoch.9: fix some style and speeling issues
Fri, Jun 22, 6:04 AM
eadler closed D15961: Fixed typo in epoch(9) man page.
Fri, Jun 22, 6:04 AM
eadler accepted D15961: Fixed typo in epoch(9) man page.
Fri, Jun 22, 5:59 AM
eadler committed rS335530: MFC r334472:.
MFC r334472:
Fri, Jun 22, 4:55 AM
eadler added a comment to D15801: top(1): reimplement header formatting as sbuf.

I am planning on committing this unless I hear otherwise by EoD today.

Fri, Jun 22, 1:33 AM
eadler added reviewers for D15960: top(1): Start parsing colors: allanjude, rgrimes.
Fri, Jun 22, 1:29 AM