- User Since
- May 10 2014, 4:24 PM (219 w, 4 h)
Sat, Jul 14
Wed, Jul 11
Don't forget to bump .Dd when you commit btw
(I'm assuming its been tested by at least one person)
Tue, Jul 10
Sat, Jul 7
Fri, Jul 6
I'll probably spend some time to sbufize this, but this change is good for now.
Thu, Jul 5
Tue, Jul 3
Mon, Jul 2
- Take @seanc's text verbatim
I am not dropping this discussion, just going to split this review up. Expect to see an updated review, with your comments addressed, in the next week or so
I'd like to move away from using static sizes and limits. This is fine as a stop-gap, but please consider changes that remove such static sizes.
Sun, Jul 1
(fwiw, If there only contentious part is the new words about private discussions, I'd like approval to commit the other parts first. This will make it easier to track and review)
Reduce preachyness, and give more actionable advice
Sat, Jun 30
For my edification: the two possible solutions to cast alignment are (a) memcpy and (b) aligned_alloc. The issue with the latter is that the compiler likely won't understand it, and thus still warn.
Fri, Jun 29
It is a bit late for me, so this is just an initial scan.
Thu, Jun 28
I had a memory of some utilities supporting any or -1 for "in a jail" (i.e. jid != 0). Might be worth looking at doing this too
Wed, Jun 27
Tue, Jun 26
Mon, Jun 25
Sun, Jun 24
Sat, Jun 23
Fri, Jun 22
Thanks for your report. Fixed along with a couple of other issues noticed.
I am planning on committing this unless I hear otherwise by EoD today.