- Most notably don't require talking to core@ to take on maintainership.
- Merge an FAQ into the main body of the text
- Wordsmith
- Remove references to CVS
Details
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 18365 Build 18081: arc lint + arc unit
Event Timeline
I would also add a bullet in the commit log to say "Remove comments specific to CVS". Taking files off of the vendor branch and some of the other language was CVS specific and it's good that you are removing it.
I'd be tempted to also add a requirement to use the vendor import process when committing to those areas (since we've had a few commits recently that didn't do real merges), but I don't think we really need that right now.
en_US.ISO8859-1/articles/committers-guide/article.xml | ||
---|---|---|
3506–3510 | s/for when/when/ | |
3512–3521 | s/comitting/committing/ |
en_US.ISO8859-1/articles/committers-guide/article.xml | ||
---|---|---|
3515 | Can we strengthen the language here slightly? Something like:
| |
3524 |
If we don't have a maintainer for something it's also worth providing a small hint that we can also reexamine whether or not we want the code in contrib/ at all. This advice isn't limited to contrib/ but bears repetition because our forks are always inherently out of date with the canonical upstream repository. |
en_US.ISO8859-1/articles/committers-guide/article.xml | ||
---|---|---|
3524 | I'd rather not add this. It leads to the "What should be in base" debate. Unless and until we have a meaningful standard for that, this will just result in bikesheds. |
Ping? Ravi's comments are good, but i think with those changes this should be committed.