Page MenuHomeFreeBSD

seanc (Sean Chittenden)
User

Projects

User Details

User Since
Jul 26 2015, 3:06 PM (225 w, 5 d)

Recent Activity

Aug 15 2019

seanc accepted D21060: Stop installing clang, clang++, and clang-cpp hardlinks in /usr/bin..
Aug 15 2019, 7:31 PM

Jul 12 2019

seanc committed rS349952: usr.sbin/bhyve: close backend file descriptor during tap init error.
usr.sbin/bhyve: close backend file descriptor during tap init error
Jul 12 2019, 6:51 PM
seanc committed rS349949: usr.sbin/bhyveload: don't leak an fd if a device can't be opened.
usr.sbin/bhyveload: don't leak an fd if a device can't be opened
Jul 12 2019, 6:38 PM
seanc committed rS349947: usr.sbin/bhyve: only unassign a pt device after obtaining bus/slot/func.
usr.sbin/bhyve: only unassign a pt device after obtaining bus/slot/func
Jul 12 2019, 6:34 PM
seanc committed rS349946: usr.sbin/bhyve: free resources when erroring out of pci_vtcon_sock_add().
usr.sbin/bhyve: free resources when erroring out of pci_vtcon_sock_add()
Jul 12 2019, 6:21 PM
seanc committed rS349945: usr.sbin/bhyve: prevent use-after-free in virtio scsi request handling.
usr.sbin/bhyve: prevent use-after-free in virtio scsi request handling
Jul 12 2019, 6:18 PM
seanc committed rS349944: usr.sbin/bhyve: don't leak a FD if the device is not a tty.
usr.sbin/bhyve: don't leak a FD if the device is not a tty
Jul 12 2019, 6:14 PM
seanc committed rS349937: usr.sbin/bhyve: unconditionally initialize the NVMe completion status.
usr.sbin/bhyve: unconditionally initialize the NVMe completion status
Jul 12 2019, 5:53 AM
seanc committed rS349935: usr.sbin/bhyve: free resources when erroring out of pci_vtnet_init().
usr.sbin/bhyve: free resources when erroring out of pci_vtnet_init()
Jul 12 2019, 5:19 AM

Jul 11 2019

seanc committed rS349925: usr.sbin/bhyve: send an initialized value to wake up blocking kqueue.
usr.sbin/bhyve: send an initialized value to wake up blocking kqueue
Jul 11 2019, 11:55 PM
seanc committed rS349919: usr.sbin/bhyve: commit miss from r349918.
usr.sbin/bhyve: commit miss from r349918
Jul 11 2019, 7:51 PM
seanc committed rS349918: usr.sbin/bhyve: free leaked memory during option parsing.
usr.sbin/bhyve: free leaked memory during option parsing
Jul 11 2019, 7:41 PM
seanc committed rS349915: usr.sbin/bhyve: initialize return value in xhci device interrupt handler.
usr.sbin/bhyve: initialize return value in xhci device interrupt handler
Jul 11 2019, 7:26 PM
seanc committed rS349914: usr.sbin/bhyve: free resources if there is an initialization error in rfb.
usr.sbin/bhyve: free resources if there is an initialization error in rfb
Jul 11 2019, 7:08 PM

Jul 6 2019

seanc added a comment to D16698: First draft HID over I2C support (Mouse only).

@marc.priggemeyer_gmail.com or @markj, is what's here sufficient for now, or do the edev fixes need to go in, too? It looked like suspend/resume was the biggest issue. I'm worried about this review being a casualty of perfection vs making incremental, usable progress. Given the successes reported so far, I'm trying to gauge what's mandatory vs what should be done next post-commit.

Jul 6 2019, 7:02 AM · Contributor Reviews (base)

Jul 3 2019

seanc committed rS349656: bhyve/audio: don't leak resources on failed initialization..
bhyve/audio: don't leak resources on failed initialization.
Jul 3 2019, 5:24 PM
seanc committed rD53213: www: add Google site verification for YouTube.
www: add Google site verification for YouTube
Jul 3 2019, 4:22 AM

Jun 28 2019

seanc committed rS349528: Temporary suspension..
Temporary suspension.
Jun 28 2019, 11:41 PM

Jun 25 2019

seanc added a comment to D20761: Add BSD+Patent.

Looks good, but potentially a suggestion.

Jun 25 2019, 5:42 PM

May 28 2019

seanc added a comment to D20394: Ports Tree Base Packages.

Integrity of the base distfiles is left to the administrator. Maintaining the chain of trust is outside of the scope of building base packages, whereas pkg for ports packages and distfiles does require pkg to maintain a chain of trust. Source code acquisition via ssh, https, or fetching tarballs and comparing the SHAs all seem like prerequisites for building a package base system, therefore out of scope for the proposed set of patches here. Said differently, if a release engineer can't ensure integrity of the source used to build a jail, the release engineer has bigger problems.

May 28 2019, 6:51 PM

May 24 2019

seanc committed rD53050: Bump the documented EoL date for 12-STABLE to June 30, 2024..
Bump the documented EoL date for 12-STABLE to June 30, 2024.
May 24 2019, 10:09 PM
seanc committed rS348252: Release rgrimes@ from mentorship..
Release rgrimes@ from mentorship.
May 24 2019, 8:36 PM

May 16 2019

seanc committed rD53033: Tweak the news item pointing to the survey and remove the link..
Tweak the news item pointing to the survey and remove the link.
May 16 2019, 1:25 AM

Apr 29 2019

seanc closed D20100: Update share/news to include CFT for new pkgbase.
Apr 29 2019, 10:40 PM
seanc committed rD52968: share/news: add the CFT for TrueOS's approach to pkgbase.
share/news: add the CFT for TrueOS's approach to pkgbase
Apr 29 2019, 10:40 PM
seanc created D20100: Update share/news to include CFT for new pkgbase.
Apr 29 2019, 10:34 PM

Apr 27 2019

seanc closed D20083: Add the FreeBSD + ZoL CFT to the news section.
Apr 27 2019, 9:58 PM
seanc committed rD52962: share/news: add a link to the CFT for FreeBSD+ZoL.
share/news: add a link to the CFT for FreeBSD+ZoL
Apr 27 2019, 9:58 PM
seanc updated the diff for D20083: Add the FreeBSD + ZoL CFT to the news section.
Apr 27 2019, 9:57 PM
seanc updated the diff for D20083: Add the FreeBSD + ZoL CFT to the news section.

Terse explanation of what this actually means.

Apr 27 2019, 9:53 PM
seanc created D20083: Add the FreeBSD + ZoL CFT to the news section.
Apr 27 2019, 9:52 PM
seanc committed rD52961: share/press: add the most recent Phoronix ZoL benchmarks.
share/press: add the most recent Phoronix ZoL benchmarks
Apr 27 2019, 8:59 PM
seanc closed D20082: Add Phoronix ZoL benchmark....
Apr 27 2019, 8:59 PM
seanc added a comment to D20082: Add Phoronix ZoL benchmark....

Benchmarks that aren't horribly flawed are candidates for publication (e.g. thinks that aren't compiled with -O0 or other invasive debugging flags that create unfair comparisons).

Apr 27 2019, 8:59 PM
seanc closed D20081: Add 2019 community survey to the news section..
Apr 27 2019, 8:53 PM
seanc committed rD52960: share/news: Add a news item for the 2019 Community Survey.
share/news: Add a news item for the 2019 Community Survey
Apr 27 2019, 8:53 PM
seanc updated the diff for D20081: Add 2019 community survey to the news section..

Update the title page to be more succinct.

Apr 27 2019, 8:50 PM
seanc updated the diff for D20081: Add 2019 community survey to the news section..

Trim the second event that was accidentally copy/pasted.

Apr 27 2019, 8:32 PM
seanc created D20082: Add Phoronix ZoL benchmark....
Apr 27 2019, 6:53 PM
seanc created D20081: Add 2019 community survey to the news section..
Apr 27 2019, 6:50 PM
seanc added a comment to D14103: Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4).

Can someone summarize what's preventing this patch from being committed?

Apr 27 2019, 6:18 PM
seanc added a comment to D16698: First draft HID over I2C support (Mouse only).

Can someone summarize what's left or preventing this from being committed?

Apr 27 2019, 6:15 PM · Contributor Reviews (base)

Apr 25 2019

seanc committed rP500045: Update security/teleport to 3.2.2.
Update security/teleport to 3.2.2
Apr 25 2019, 6:02 PM
seanc closed D20042: Update security/teleport to 3.2.2.
Apr 25 2019, 6:02 PM

Apr 24 2019

seanc created D20042: Update security/teleport to 3.2.2.
Apr 24 2019, 9:08 PM
seanc abandoned D16938: Update devel/protobuf to 3.6.1.

3.7.1 is already in the tree.

Apr 24 2019, 9:06 PM

Apr 20 2019

seanc created D19981: Upgrade sysutils/direnv....
Apr 20 2019, 6:14 AM

Apr 13 2019

seanc committed rD52920: Commit miss from r52919.
Commit miss from r52919
Apr 13 2019, 5:43 PM
seanc committed rD52919: Additoinal cleanup from r52910.
Additoinal cleanup from r52910
Apr 13 2019, 4:54 PM

Apr 1 2019

seanc accepted D19778: Reap idle src bits.
Apr 1 2019, 9:44 PM
seanc accepted D19778: Reap idle src bits.
Apr 1 2019, 9:33 PM
seanc accepted D19782: jhb@ will take over as mentor to anish@.
Apr 1 2019, 9:30 PM

Aug 29 2018

seanc updated the diff for D16940: Update sysutils/circonus-agent to 0.16.0.

I pasted the wrong diff into the circonus-agent update, disregard the previous revision. The correct revision is now present in this review.

Aug 29 2018, 8:16 AM
seanc updated the diff for D16938: Update devel/protobuf to 3.6.1.

Update Makefile variables per suggestion from @mat

Aug 29 2018, 8:09 AM
seanc updated the diff for D16940: Update sysutils/circonus-agent to 0.16.0.

Reorder variables in Makefile per suggestion from @mat

Aug 29 2018, 8:08 AM
seanc committed rP478341: Upgrade security/teleport to 2.7.4..
Upgrade security/teleport to 2.7.4.
Aug 29 2018, 7:56 AM
seanc closed D16939: Update security/teleport to 2.7.4.
Aug 29 2018, 7:56 AM
seanc created D16940: Update sysutils/circonus-agent to 0.16.0.
Aug 29 2018, 7:54 AM
seanc created D16939: Update security/teleport to 2.7.4.
Aug 29 2018, 7:37 AM
seanc created D16938: Update devel/protobuf to 3.6.1.
Aug 29 2018, 7:14 AM

Aug 21 2018

seanc added a comment to D16823: [new port] graphics/drm-legacy-kmod: legacy DRM modules for the linuxkpi-based KMS components.

The one thing I would say, however, is I'm looking forward to the metaport that will assume the name of drm-kmod and will do the right thing for users based on their architecture. I know that's next, I'm just stating the obvious for future onlookers.

Aug 21 2018, 6:50 PM
seanc accepted D16823: [new port] graphics/drm-legacy-kmod: legacy DRM modules for the linuxkpi-based KMS components.
Aug 21 2018, 5:40 PM

Jul 18 2018

seanc committed rP474836: Update security/teleport to 2.6.7.
Update security/teleport to 2.6.7
Jul 18 2018, 7:03 AM
seanc closed D16311: Update security/teleport to 2.6.7....
Jul 18 2018, 7:03 AM
seanc added a comment to D16311: Update security/teleport to 2.6.7....
In D16311#346083, @mat wrote:

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Jul 18 2018, 7:01 AM

Jul 17 2018

seanc created D16311: Update security/teleport to 2.6.7....
Jul 17 2018, 8:15 PM

Jul 13 2018

seanc added a comment to D16111: Add setproctitle_fast() for frequent callers..

Thank you @munro_ip9.org !

Jul 13 2018, 12:32 AM

Jul 9 2018

seanc added inline comments to D16089: committer guide: update rules for contrib software..
Jul 9 2018, 1:54 AM

Jul 5 2018

seanc committed rS335987: Update with the members of the 10th core team, core.x..
Update with the members of the 10th core team, core.x.
Jul 5 2018, 3:40 PM

Jul 4 2018

seanc committed rS335959: Complete my vertex even though edges were in place..
Complete my vertex even though edges were in place.
Jul 4 2018, 4:51 PM
seanc added inline comments to D16096: Update administration.xml and contrib.corealumni.xml for core.x.
Jul 4 2018, 1:43 AM

Jul 2 2018

seanc added a comment to D16092: Committer guide: add note about private discussions.

@eadler :, I understand, and no problem. I think you're hitting on something that would be good to formalize, but I want to make sure that what gets prescribed as a community rule of thumb is accurate and strikes the right balance. I think we'd all collectively take something that's an improvement and incremental over something that is perfect. "Perfect is the enemy of good." :~] Also, if you want to hit me up on Slack or IRC to talk in a higher-bandwidth medium than a review, feel free.

Jul 2 2018, 5:06 PM
seanc committed rP473756: Optimize teleport build further and reuse the same sed invocation..
Optimize teleport build further and reuse the same sed invocation.
Jul 2 2018, 4:59 PM
seanc committed rP473745: Optimize teleport build steps by invoking sed(1) and find(1) only once..
Optimize teleport build steps by invoking sed(1) and find(1) only once.
Jul 2 2018, 2:56 PM
seanc accepted D16092: Committer guide: add note about private discussions.

Thank you for carrying this discussion forward into a separate review, @eadler.

Jul 2 2018, 7:11 AM
seanc committed rP473704: Upgrade gravitational teleport to 2.6.6..
Upgrade gravitational teleport to 2.6.6.
Jul 2 2018, 5:26 AM
seanc closed D15311: Improve security/teleport build.
Jul 2 2018, 5:26 AM
seanc updated the diff for D15311: Improve security/teleport build.

Incorporate @swills' feedback. Work around daemon(8)'s lack of syslog functionality in 10-STABLE.

Jul 2 2018, 1:53 AM

Jul 1 2018

seanc requested changes to D16080: Multiple updates for the committer guide.

Provide some feedback and suggested some alternate wording.

Jul 1 2018, 9:20 PM

Jun 12 2018

seanc added a comment to D15722: Update sysutils/gomplate to 2.6.0.

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Sorry, I keep forgetting you prefer full context patches to review.

I like to be able to review the changes, to review the changes, it is easier to be able to see the whole files.

Jun 12 2018, 10:09 PM
seanc committed rP472271: Update sysutils/gomplate to 2.6.0.
Update sysutils/gomplate to 2.6.0
Jun 12 2018, 10:06 PM
seanc closed D15722: Update sysutils/gomplate to 2.6.0.
Jun 12 2018, 10:06 PM

Jun 11 2018

seanc added a comment to D15722: Update sysutils/gomplate to 2.6.0.
In D15722#332860, @mat wrote:

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Jun 11 2018, 12:46 PM
seanc updated the diff for D15722: Update sysutils/gomplate to 2.6.0.

Full context

Jun 11 2018, 12:41 PM

Jun 9 2018

seanc created D15722: Update sysutils/gomplate to 2.6.0.
Jun 9 2018, 8:33 PM
seanc added a reviewer for D15719: databases/cockroach: Update to 2.0.2: riggs.
Jun 9 2018, 8:24 PM
seanc created D15719: databases/cockroach: Update to 2.0.2.
Jun 9 2018, 7:44 PM

May 25 2018

seanc accepted D15481: Create a default wlan for wireless NICs if no wlans are specified..
May 25 2018, 11:08 PM
seanc committed rP470874: Update www/fabio to 1.5.9.
Update www/fabio to 1.5.9
May 25 2018, 11:05 PM
seanc closed D15464: www/fabio: upgrade to 1.5.9.
May 25 2018, 11:05 PM

May 21 2018

seanc added a comment to D15464: www/fabio: upgrade to 1.5.9.

No, I sent a note to the maintainer to get approval for this change after submitting the review. I will open a PR in a day or two if I don't hear back from the maintainer.

May 21 2018, 7:27 PM

May 17 2018

seanc created D15464: www/fabio: upgrade to 1.5.9.
May 17 2018, 5:06 PM
seanc added a comment to D15311: Improve security/teleport build.

Agreed, and I have already removed ${LOCALBASE}/bin/go from BUILD_DEPENDS - I wasn't arguing with you, I was only explaining why I added it in the first place. :)

May 17 2018, 4:05 PM

May 15 2018

seanc added inline comments to D15311: Improve security/teleport build.
May 15 2018, 6:51 PM
seanc updated the diff for D15311: Improve security/teleport build.

Paste with context

May 15 2018, 6:49 PM
seanc reopened D15311: Improve security/teleport build.
May 15 2018, 5:56 PM
seanc added inline comments to D15311: Improve security/teleport build.
May 15 2018, 5:56 PM
seanc updated the diff for D15311: Improve security/teleport build.

Updated port with feedback from @mat

May 15 2018, 5:56 PM
seanc added a comment to D15430: make unix socket locking finer grained.

I want to point out that the lack of code formatting tool like clang-format resulted in @markj spending some of his precious cycles reviewing not the substance of the patch, but instead commenting on style nits (correct according to style(9) - thank you @markj).

May 15 2018, 5:03 PM

May 14 2018

seanc committed rP469948: New port: www/kurly.
New port: www/kurly
May 14 2018, 6:45 PM