- User Since
- Jul 26 2015, 3:06 PM (274 w, 3 d)
Jul 30 2020
Jun 23 2020
Jun 17 2020
+1 for relaxing style(9) to match what available tooling can support.
Jun 9 2020
I just find the mixed-case thing personally amusing, nothing else. As long as it's consistent, I'm fine with it. Let's ship this!
Jun 3 2020
@cem Thanks! Updated.
Dec 13 2019
Aug 15 2019
Jul 12 2019
Jul 11 2019
Jul 6 2019
@marc.priggemeyer_gmail.com or @markj, is what's here sufficient for now, or do the edev fixes need to go in, too? It looked like suspend/resume was the biggest issue. I'm worried about this review being a casualty of perfection vs making incremental, usable progress. Given the successes reported so far, I'm trying to gauge what's mandatory vs what should be done next post-commit.
Jul 3 2019
Jun 28 2019
Jun 25 2019
Looks good, but potentially a suggestion.
May 28 2019
Integrity of the base distfiles is left to the administrator. Maintaining the chain of trust is outside of the scope of building base packages, whereas pkg for ports packages and distfiles does require pkg to maintain a chain of trust. Source code acquisition via ssh, https, or fetching tarballs and comparing the SHAs all seem like prerequisites for building a package base system, therefore out of scope for the proposed set of patches here. Said differently, if a release engineer can't ensure integrity of the source used to build a jail, the release engineer has bigger problems.
May 24 2019
May 16 2019
Apr 29 2019
Apr 27 2019
Terse explanation of what this actually means.
Benchmarks that aren't horribly flawed are candidates for publication (e.g. thinks that aren't compiled with -O0 or other invasive debugging flags that create unfair comparisons).
Update the title page to be more succinct.
Trim the second event that was accidentally copy/pasted.
Can someone summarize what's preventing this patch from being committed?
Can someone summarize what's left or preventing this from being committed?
Apr 25 2019
Apr 24 2019
3.7.1 is already in the tree.
Apr 20 2019
Apr 13 2019
Apr 1 2019
Aug 29 2018
I pasted the wrong diff into the circonus-agent update, disregard the previous revision. The correct revision is now present in this review.
Update Makefile variables per suggestion from @mat
Reorder variables in Makefile per suggestion from @mat
Aug 21 2018
The one thing I would say, however, is I'm looking forward to the metaport that will assume the name of drm-kmod and will do the right thing for users based on their architecture. I know that's next, I'm just stating the obvious for future onlookers.
Jul 18 2018
Jul 17 2018
Jul 13 2018
Thank you @munro_ip9.org !
Jul 9 2018
Jul 5 2018
Jul 4 2018
Jul 2 2018
@eadler :, I understand, and no problem. I think you're hitting on something that would be good to formalize, but I want to make sure that what gets prescribed as a community rule of thumb is accurate and strikes the right balance. I think we'd all collectively take something that's an improvement and incremental over something that is perfect. "Perfect is the enemy of good." :~] Also, if you want to hit me up on Slack or IRC to talk in a higher-bandwidth medium than a review, feel free.
Thank you for carrying this discussion forward into a separate review, @eadler.
Incorporate @swills' feedback. Work around daemon(8)'s lack of syslog functionality in 10-STABLE.
Jul 1 2018
Provide some feedback and suggested some alternate wording.
Jun 12 2018
Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.
Sorry, I keep forgetting you prefer full context patches to review.
I like to be able to review the changes, to review the changes, it is easier to be able to see the whole files.
Jun 11 2018