Page MenuHomeFreeBSD

seanc (Sean Chittenden)
User

Projects

User Details

User Since
Jul 26 2015, 3:06 PM (168 w, 4 d)

Recent Activity

Aug 29 2018

seanc updated the diff for D16940: Update sysutils/circonus-agent to 0.16.0.

I pasted the wrong diff into the circonus-agent update, disregard the previous revision. The correct revision is now present in this review.

Aug 29 2018, 8:16 AM
seanc updated the diff for D16938: Update devel/protobuf to 3.6.1.

Update Makefile variables per suggestion from @mat

Aug 29 2018, 8:09 AM
seanc updated the diff for D16940: Update sysutils/circonus-agent to 0.16.0.

Reorder variables in Makefile per suggestion from @mat

Aug 29 2018, 8:08 AM
seanc committed rP478341: Upgrade security/teleport to 2.7.4..
Upgrade security/teleport to 2.7.4.
Aug 29 2018, 7:56 AM
seanc closed D16939: Update security/teleport to 2.7.4.
Aug 29 2018, 7:56 AM
seanc created D16940: Update sysutils/circonus-agent to 0.16.0.
Aug 29 2018, 7:54 AM
seanc created D16939: Update security/teleport to 2.7.4.
Aug 29 2018, 7:37 AM
seanc created D16938: Update devel/protobuf to 3.6.1.
Aug 29 2018, 7:14 AM

Aug 21 2018

seanc added a comment to D16823: [new port] graphics/drm-legacy-kmod: legacy DRM modules for the linuxkpi-based KMS components.

The one thing I would say, however, is I'm looking forward to the metaport that will assume the name of drm-kmod and will do the right thing for users based on their architecture. I know that's next, I'm just stating the obvious for future onlookers.

Aug 21 2018, 6:50 PM
seanc accepted D16823: [new port] graphics/drm-legacy-kmod: legacy DRM modules for the linuxkpi-based KMS components.
Aug 21 2018, 5:40 PM

Jul 18 2018

seanc committed rP474836: Update security/teleport to 2.6.7.
Update security/teleport to 2.6.7
Jul 18 2018, 7:03 AM
seanc closed D16311: Update security/teleport to 2.6.7....
Jul 18 2018, 7:03 AM
seanc added a comment to D16311: Update security/teleport to 2.6.7....
In D16311#346083, @mat wrote:

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Jul 18 2018, 7:01 AM

Jul 17 2018

seanc created D16311: Update security/teleport to 2.6.7....
Jul 17 2018, 8:15 PM

Jul 13 2018

seanc added a comment to D16111: Add setproctitle_fast() for frequent callers..

Thank you @munro_ip9.org !

Jul 13 2018, 12:32 AM

Jul 9 2018

seanc added inline comments to D16089: committer guide: update rules for contrib software..
Jul 9 2018, 1:54 AM

Jul 5 2018

seanc committed rS335987: Update with the members of the 10th core team, core.x..
Update with the members of the 10th core team, core.x.
Jul 5 2018, 3:40 PM

Jul 4 2018

seanc committed rS335959: Complete my vertex even though edges were in place..
Complete my vertex even though edges were in place.
Jul 4 2018, 4:51 PM
seanc added inline comments to D16096: Update administration.xml and contrib.corealumni.xml for core.x.
Jul 4 2018, 1:43 AM

Jul 2 2018

seanc added a comment to D16092: Committer guide: add note about private discussions.

@eadler :, I understand, and no problem. I think you're hitting on something that would be good to formalize, but I want to make sure that what gets prescribed as a community rule of thumb is accurate and strikes the right balance. I think we'd all collectively take something that's an improvement and incremental over something that is perfect. "Perfect is the enemy of good." :~] Also, if you want to hit me up on Slack or IRC to talk in a higher-bandwidth medium than a review, feel free.

Jul 2 2018, 5:06 PM
seanc committed rP473756: Optimize teleport build further and reuse the same sed invocation..
Optimize teleport build further and reuse the same sed invocation.
Jul 2 2018, 4:59 PM
seanc committed rP473745: Optimize teleport build steps by invoking sed(1) and find(1) only once..
Optimize teleport build steps by invoking sed(1) and find(1) only once.
Jul 2 2018, 2:56 PM
seanc accepted D16092: Committer guide: add note about private discussions.

Thank you for carrying this discussion forward into a separate review, @eadler.

Jul 2 2018, 7:11 AM
seanc committed rP473704: Upgrade gravitational teleport to 2.6.6..
Upgrade gravitational teleport to 2.6.6.
Jul 2 2018, 5:26 AM
seanc closed D15311: Improve security/teleport build.
Jul 2 2018, 5:26 AM
seanc updated the diff for D15311: Improve security/teleport build.

Incorporate @swills' feedback. Work around daemon(8)'s lack of syslog functionality in 10-STABLE.

Jul 2 2018, 1:53 AM

Jul 1 2018

seanc requested changes to D16080: Multiple updates for the committer guide.

Provide some feedback and suggested some alternate wording.

Jul 1 2018, 9:20 PM

Jun 12 2018

seanc added a comment to D15722: Update sysutils/gomplate to 2.6.0.

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Sorry, I keep forgetting you prefer full context patches to review.

I like to be able to review the changes, to review the changes, it is easier to be able to see the whole files.

Jun 12 2018, 10:09 PM
seanc committed rP472271: Update sysutils/gomplate to 2.6.0.
Update sysutils/gomplate to 2.6.0
Jun 12 2018, 10:06 PM
seanc closed D15722: Update sysutils/gomplate to 2.6.0.
Jun 12 2018, 10:06 PM

Jun 11 2018

seanc added a comment to D15722: Update sysutils/gomplate to 2.6.0.
In D15722#332860, @mat wrote:

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Jun 11 2018, 12:46 PM
seanc updated the diff for D15722: Update sysutils/gomplate to 2.6.0.

Full context

Jun 11 2018, 12:41 PM

Jun 9 2018

seanc created D15722: Update sysutils/gomplate to 2.6.0.
Jun 9 2018, 8:33 PM
seanc added a reviewer for D15719: databases/cockroach: Update to 2.0.2: riggs.
Jun 9 2018, 8:24 PM
seanc created D15719: databases/cockroach: Update to 2.0.2.
Jun 9 2018, 7:44 PM

May 25 2018

seanc accepted D15481: Create a default wlan for wireless NICs if no wlans are specified..
May 25 2018, 11:08 PM
seanc committed rP470874: Update www/fabio to 1.5.9.
Update www/fabio to 1.5.9
May 25 2018, 11:05 PM
seanc closed D15464: www/fabio: upgrade to 1.5.9.
May 25 2018, 11:05 PM

May 21 2018

seanc added a comment to D15464: www/fabio: upgrade to 1.5.9.

No, I sent a note to the maintainer to get approval for this change after submitting the review. I will open a PR in a day or two if I don't hear back from the maintainer.

May 21 2018, 7:27 PM

May 17 2018

seanc created D15464: www/fabio: upgrade to 1.5.9.
May 17 2018, 5:06 PM
seanc added a comment to D15311: Improve security/teleport build.

Agreed, and I have already removed ${LOCALBASE}/bin/go from BUILD_DEPENDS - I wasn't arguing with you, I was only explaining why I added it in the first place. :)

May 17 2018, 4:05 PM

May 15 2018

seanc added inline comments to D15311: Improve security/teleport build.
May 15 2018, 6:51 PM
seanc updated the diff for D15311: Improve security/teleport build.

Paste with context

May 15 2018, 6:49 PM
seanc reopened D15311: Improve security/teleport build.
May 15 2018, 5:56 PM
seanc added inline comments to D15311: Improve security/teleport build.
May 15 2018, 5:56 PM
seanc updated the diff for D15311: Improve security/teleport build.

Updated port with feedback from @mat

May 15 2018, 5:56 PM
seanc added a comment to D15430: make unix socket locking finer grained.

I want to point out that the lack of code formatting tool like clang-format resulted in @markj spending some of his precious cycles reviewing not the substance of the patch, but instead commenting on style nits (correct according to style(9) - thank you @markj).

May 15 2018, 5:03 PM

May 14 2018

seanc committed rP469948: New port: www/kurly.
New port: www/kurly
May 14 2018, 6:45 PM
seanc closed D15332: New port: www/kurly.
May 14 2018, 6:45 PM

May 11 2018

seanc committed rP469694: Update sysutils/circonus-agent to 0.13.0.
Update sysutils/circonus-agent to 0.13.0
May 11 2018, 8:40 PM
seanc closed D15179: Update sysutils/circonus-agent to 0.13.0.
May 11 2018, 8:40 PM
seanc committed rP469693: Upgrade gravitational teleport to 2.5.7..
Upgrade gravitational teleport to 2.5.7.
May 11 2018, 8:36 PM
seanc closed D15311: Improve security/teleport build.
May 11 2018, 8:36 PM
seanc committed rP469692: New port: sysutils/gomplate.
New port: sysutils/gomplate
May 11 2018, 8:34 PM
seanc closed D15327: New port: sysutils/gomplate.
May 11 2018, 8:34 PM
seanc committed rP469691: Add a new port: sysutils/sockaddr.
Add a new port: sysutils/sockaddr
May 11 2018, 8:30 PM
seanc closed D14570: New port: sysutils/sockaddr.
May 11 2018, 8:30 PM
seanc updated the diff for D15327: New port: sysutils/gomplate.

Remove unnecessary post-patch step.

May 11 2018, 7:04 PM
seanc updated the diff for D15179: Update sysutils/circonus-agent to 0.13.0.

Remove the use of :DEFAULT

May 11 2018, 6:53 PM
seanc requested review of D14570: New port: sysutils/sockaddr.
May 11 2018, 6:47 PM
seanc planned changes to D14570: New port: sysutils/sockaddr.
May 11 2018, 6:47 PM
seanc added inline comments to D14570: New port: sysutils/sockaddr.
May 11 2018, 6:46 PM
seanc updated the diff for D14570: New port: sysutils/sockaddr.

Updated and addresses all known feedback from @mat .

May 11 2018, 6:46 PM

May 9 2018

seanc added a comment to D15311: Improve security/teleport build.
In D15311#323813, @mat wrote:

You need to bump PORTREVISION.

Also, could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

May 9 2018, 8:57 PM
seanc updated the diff for D15311: Improve security/teleport build.

Upgrade gravitational teleport to 2.5.7.

May 9 2018, 8:56 PM
seanc committed rP469455: Use post-patch instead of pre-patch and do-patch when stamping the version..
Use post-patch instead of pre-patch and do-patch when stamping the version.
May 9 2018, 5:20 PM
seanc closed D15159: New Port: devel/mage.
May 9 2018, 5:20 PM

May 7 2018

seanc created D15332: New port: www/kurly.
May 7 2018, 12:29 AM

May 6 2018

seanc created D15327: New port: sysutils/gomplate.
May 6 2018, 5:04 PM
seanc added a comment to D15179: Update sysutils/circonus-agent to 0.13.0.

Do you pass portlint -Aac? Also does it build on {10.4, 11.2, CURRENT}-{i386,amd64} with poudriere testport?

May 6 2018, 12:17 AM
seanc updated the diff for D14570: New port: sysutils/sockaddr.

Staged diff via svn diff

May 6 2018, 12:07 AM
seanc created D15311: Improve security/teleport build.
May 6 2018, 12:00 AM

Apr 26 2018

seanc requested review of D14570: New port: sysutils/sockaddr.
Apr 26 2018, 7:23 PM
seanc planned changes to D14570: New port: sysutils/sockaddr.
Apr 26 2018, 7:22 PM
seanc updated the diff for D15179: Update sysutils/circonus-agent to 0.13.0.

Updated to 0.13.0

Apr 26 2018, 6:20 PM
seanc updated the diff for D14570: New port: sysutils/sockaddr.

Updated to use a date for DISTVERSION.

Apr 26 2018, 5:53 PM
seanc committed rP468360: Add new port: security/teleport.
Add new port: security/teleport
Apr 26 2018, 5:32 PM
seanc closed D14576: New port: security/teleport.
Apr 26 2018, 5:32 PM
seanc committed rS333020: Add myself back to the ranks of being mentored.
Add myself back to the ranks of being mentored
Apr 26 2018, 5:14 PM

Apr 24 2018

seanc created D15179: Update sysutils/circonus-agent to 0.13.0.
Apr 24 2018, 5:15 AM

Apr 23 2018

seanc committed rP468102: Update ICBM coordinates now that I'm no longer full-time in the Bay Area..
Update ICBM coordinates now that I'm no longer full-time in the Bay Area.
Apr 23 2018, 4:26 PM
seanc closed D15165: Update xearth markers for seanc.
Apr 23 2018, 4:26 PM
seanc added a comment to D14576: New port: security/teleport.

@pi /@mat: could you give this another once over based on the feedback and changes above?

Apr 23 2018, 9:16 AM
seanc reopened D15159: New Port: devel/mage.
Apr 23 2018, 9:04 AM
seanc updated the diff for D15159: New Port: devel/mage.

Address feedback from @mat and use post-patch instead of pre-patch and do-patch.

Apr 23 2018, 9:03 AM
seanc committed rD51585: Chase bugzilla product rename to just Services..
Chase bugzilla product rename to just Services.
Apr 23 2018, 7:49 AM
seanc closed D15163: Catch up to Bugzilla product name change....
Apr 23 2018, 7:49 AM
seanc created D15165: Update xearth markers for seanc.
Apr 23 2018, 7:38 AM
seanc updated the diff for D14570: New port: sysutils/sockaddr.

Additional tweak found via portlint -A

Apr 23 2018, 7:24 AM
seanc updated the diff for D14576: New port: security/teleport.

portlint -A turned up some items that weren't visible previously with just portlint.

Apr 23 2018, 7:20 AM
seanc updated the test plan for D15163: Catch up to Bugzilla product name change....
Apr 23 2018, 6:56 AM
seanc created D15163: Catch up to Bugzilla product name change....
Apr 23 2018, 6:53 AM
seanc committed rP468073: Add new port: net/grpcurl.
Add new port: net/grpcurl
Apr 23 2018, 6:07 AM
seanc closed D15158: New port: net/grpcurl.
Apr 23 2018, 5:55 AM
seanc committed rP468067: Add new port: devel/mage.
Add new port: devel/mage
Apr 23 2018, 12:22 AM
seanc closed D15159: New Port: devel/mage.
Apr 23 2018, 12:22 AM
seanc committed rD51583: Update my status and PGP information..
Update my status and PGP information.
Apr 23 2018, 12:14 AM
seanc added inline comments to D15158: New port: net/grpcurl.
Apr 23 2018, 12:06 AM
seanc updated the diff for D15158: New port: net/grpcurl.

Updated after using portlint -A

Apr 23 2018, 12:06 AM

Apr 22 2018

seanc created D15159: New Port: devel/mage.
Apr 22 2018, 10:40 PM