Page MenuHomeFreeBSD

eugen_grosbein.net (Eugene Grosbein)
User

Projects

User Details

User Since
Nov 6 2015, 7:38 AM (162 w, 1 d)

Recent Activity

Yesterday

eugen_grosbein.net accepted D18546: dhclient(8) issues unneeded ioctl(SIOCSIFMTU) on every lease renew.

That makes sense, thanks.

Fri, Dec 14, 8:58 PM · network
eugen_grosbein.net added a comment to D18546: dhclient(8) issues unneeded ioctl(SIOCSIFMTU) on every lease renew.
Fri, Dec 14, 8:08 PM · network
eugen_grosbein.net added a comment to D18546: dhclient(8) issues unneeded ioctl(SIOCSIFMTU) on every lease renew.

Hmm, there was https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229432 and corresponding commit https://svnweb.freebsd.org/base?view=revision&revision=336195 fixing the problem.

Was it insufficient or your tree does not have that fix?

Yes, you are right. We were looking at the FreeBSD 11.2 code here, I have not noticed there is another change in a trunk to fix the same issue. :(

Fri, Dec 14, 8:06 PM · network
eugen_grosbein.net added a comment to D18546: dhclient(8) issues unneeded ioctl(SIOCSIFMTU) on every lease renew.

Hmm, there was https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229432 and corresponding commit https://svnweb.freebsd.org/base?view=revision&revision=336195 fixing the problem.

Fri, Dec 14, 2:30 AM · network
eugen_grosbein.net added a comment to D18535: Allow ng_nat to be attached to a ethernet interface directly via ng_ether(4) and such.

Yes, it requires corruption of private node memory. As owner of multiple routers mass servicing thousands of customers using multiple NETGRAPH nodes I can assure you that panic is not appropriatie action. Appropriate action is some form of block for traffic flow trough the node in question (with logging) leaving other nodes working.

Well, that's where I respectively disagree. As an owner of hundreds of FreeBSD systems servicing many millions of customers I think that rebooting the system immediately after any slight kernel heap/stack memory corruption is detected is not just appropriate but the only sane action available. Shutting down particular netgraph node and hope for the best would just leave the service down indefinitely with no hope for any sorts of automatic recovery.

Fri, Dec 14, 2:02 AM · network

Thu, Dec 13

eugen_grosbein.net added a comment to D18535: Allow ng_nat to be attached to a ethernet interface directly via ng_ether(4) and such.

Looks good with one exception: additional plain panic(). Can it be replaced with KASSERT?

IDK, there is no way this option to be set to anything but DLT_RAW or DLT_EN10MB in the course of normal operation of the node. So it would require some form of memory corruption to actually happen. IDK, panic(9) seems an appropriate action in that case. There are other panic(9) call in the code in similar situations.

Thu, Dec 13, 4:20 PM · network
eugen_grosbein.net added a reviewer for D18535: Allow ng_nat to be attached to a ethernet interface directly via ng_ether(4) and such: eugen_grosbein.net.

Looks good with one exception: additional plain panic(). Can it be replaced with KASSERT?

Thu, Dec 13, 7:58 AM · network

Sat, Dec 1

eugen_grosbein.net added a comment to D18380: Fix a number of style issues with trim(8).
In D18380#391441, @imp wrote:

I'm pissed this was committed. It wasn't ready and in total breach of protocol.
This matter is *NOT* settled and you're lucky I don't just remove it from the tree.

Sat, Dec 1, 3:23 AM
eugen_grosbein.net reopened D18380: Fix a number of style issues with trim(8).

Closed prematurely.

Sat, Dec 1, 2:55 AM
eugen_grosbein.net added inline comments to D18380: Fix a number of style issues with trim(8).
Sat, Dec 1, 2:52 AM

Fri, Nov 30

eugen_grosbein.net added a comment to D18380: Fix a number of style issues with trim(8).
In D18380#391343, @cem wrote:

First, DIOCGDELETE is not GEOM-specific ioctl()

I don't know why you say that. It was created specifically for GEOM (r169284). That's what the 'G' in the name represents, along with other similar ioctls (r92698).

Fri, Nov 30, 9:34 PM
eugen_grosbein.net added inline comments to D18380: Fix a number of style issues with trim(8).
Fri, Nov 30, 9:13 PM
eugen_grosbein.net added inline comments to D18380: Fix a number of style issues with trim(8).
Fri, Nov 30, 9:10 PM
eugen_grosbein.net added inline comments to D18380: Fix a number of style issues with trim(8).
Fri, Nov 30, 8:45 PM
eugen_grosbein.net added a comment to D18380: Fix a number of style issues with trim(8).

I strongly disagree against GEOM'ifying or CAM'ifyng such simple code.

Fri, Nov 30, 10:41 AM

Thu, Nov 29

eugen_grosbein.net added a comment to D18380: Fix a number of style issues with trim(8).

I'm fine with rest of changes.

Thu, Nov 29, 6:22 PM
eugen_grosbein.net added a comment to D18380: Fix a number of style issues with trim(8).

The check for CHR and SBLK is to issue nice and correct error message in case of pilot error instead of generic and obscure error after ioctl() so I'd prefer to keep it.

Thu, Nov 29, 6:18 PM
eugen_grosbein.net added a comment to D18380: Fix a number of style issues with trim(8).

The operation in question is dangerous and can easily result in loss of data if used by unexperienced root. This is why I want it to NOT defaults to -f but instead defaults to verbose dry-run mode. Hence the need for -f and -q.

Thu, Nov 29, 6:18 PM

Mon, Nov 26

eugen_grosbein.net accepted D18338: Fix possible panic during ifnet detach in rtsock .
Mon, Nov 26, 11:55 AM

Oct 28 2018

eugen_grosbein.net updated the diff for D17719: Improve ipfw.8 manual page with more clear layer2 processing documentation.

Use .Cm instead of .Nm for keyword. Begin sentences with new line.

Oct 28 2018, 7:24 PM

Oct 27 2018

eugen_grosbein.net updated the summary of D17719: Improve ipfw.8 manual page with more clear layer2 processing documentation.
Oct 27 2018, 3:46 PM
eugen_grosbein.net created D17719: Improve ipfw.8 manual page with more clear layer2 processing documentation.
Oct 27 2018, 3:16 PM

Oct 21 2018

eugen_grosbein.net accepted D17299: PR231649: pw: make checks in boolean_str() match reality.
Oct 21 2018, 12:43 PM

Oct 18 2018

eugen_grosbein.net added inline comments to D17598: Properly handle case when system is out of network interface numbers.
Oct 18 2018, 7:49 PM

Oct 16 2018

eugen_grosbein.net accepted D17575: pw: file == NULL check in read_userconfig() is always false.
Oct 16 2018, 11:04 AM
eugen_grosbein.net added a comment to D17575: pw: file == NULL check in read_userconfig() is always false.

Looks good. While you are here, please also replace last "/etc" literal in the pw.c's main() function with _PATH_PWD used with all other places of pw(1) sources.

Oct 16 2018, 8:48 AM

Oct 15 2018

eugen_grosbein.net accepted D17566: PR231653: pw doesn't respect -V when writing pw.conf.
Oct 15 2018, 2:35 PM
eugen_grosbein.net added a comment to D17566: PR231653: pw doesn't respect -V when writing pw.conf.

While the change seems to be semantically right, I don't really like we have more and more places with hard-coded "pw.conf" in the pw(8) sources.

Could you please to add #define _PW_CONF "pw.conf" to pw.h and use "%s/" _PW_CONF (concatenation of C string literals) instead of "%s/pw.conf" ? And make same change to pw_utils.c' get_userconfig() function too, while you are here.

Sure, done.

Oct 15 2018, 2:24 PM
eugen_grosbein.net added a comment to D17566: PR231653: pw doesn't respect -V when writing pw.conf.

While the change seems to be semantically right, I don't really like we have more and more places with hard-coded "pw.conf" in the pw(8) sources.

Oct 15 2018, 2:00 PM
eugen_grosbein.net added a reviewer for D17566: PR231653: pw doesn't respect -V when writing pw.conf: bapt.
Oct 15 2018, 1:48 PM

Sep 30 2018

eugen_grosbein.net accepted D17299: PR231649: pw: make checks in boolean_str() match reality.
Sep 30 2018, 10:56 AM
eugen_grosbein.net added a reviewer for D17299: PR231649: pw: make checks in boolean_str() match reality: eugen_grosbein.net.
Sep 30 2018, 10:56 AM
eugen_grosbein.net added a comment to D17299: PR231649: pw: make checks in boolean_str() match reality.

Just as a comment: boolean_str() problem seems to be a left-over after my change r326848 that changed magic values -2 .. 1 to symbols P_NONE etc. but missed a change for boolean_str().

Sep 30 2018, 10:55 AM

Sep 10 2018

eugen_grosbein.net added a comment to D17111: Address jtl's review feedback from D17065..

Why is it acceptable to break KBI here adding new member to struct inpcblbgroup not to its end?

Sep 10 2018, 7:46 PM
eugen_grosbein.net added a comment to D17100: Extend ifaddr_event to pass ifaddr and event type to handler.

This also needs an update for share/man/man9/EVENTHANDLER.9

Sep 10 2018, 3:26 PM

Sep 5 2018

eugen_grosbein.net added a reviewer for D17039: Implement "ipfw fwd" for incoming IPv4 packets on fast forwarding path: ae.
Sep 5 2018, 6:11 AM
eugen_grosbein.net updated the diff for D17039: Implement "ipfw fwd" for incoming IPv4 packets on fast forwarding path.

Same code, more context.

Sep 5 2018, 6:11 AM
eugen_grosbein.net created D17039: Implement "ipfw fwd" for incoming IPv4 packets on fast forwarding path.
Sep 5 2018, 5:13 AM

Aug 30 2018

eugen_grosbein.net added reviewers for D16951: mount_msdosfs(8) should not fail if kernel already has needed kiconv(3) parts: avg, mav.
Aug 30 2018, 12:39 PM
eugen_grosbein.net created D16951: mount_msdosfs(8) should not fail if kernel already has needed kiconv(3) parts.
Aug 30 2018, 12:11 PM

Aug 20 2018

eugen_grosbein.net added a comment to D16789: lang/go: flavorize; add -nosse2 flavor for older i386 CPUs lacking SSE2 support.
In D16789#357757, @mat wrote:
In D16789#357744, @mat wrote:

The flavor does not make much sense.

First because it is only needed for i386 processors before pentium 4, so it only concerns on i386 architecture, so having a flavor on all other archs is bogus.

I was also wondering if it would be possible to somehow declare this flavor arch-specific (i386-only).

I think you could get away with doing something like this:

FLAVORS= ${FLAVORS_${ARCH}}
FLAVORS_i386= blah
FLAVOR?= ${FLAVORS:[1]}

But I am still not sure this is a good idea to begin with.

Second, do you have real example of people actually running Go on machines from last century?

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230731

That is completely insane.

Aug 20 2018, 2:43 PM

Jul 31 2018

eugen_grosbein.net added a comment to D1858: Improvement for MAC address uniqueness of if_epair(4).

This was fixed long time ago, please close.

Jul 31 2018, 5:42 AM
eugen_grosbein.net added a comment to D13426: Extend stripeoffset and stripesize of GEOMs from u_int to off_t.

I'm going to commit this soon unless an objection is raised.

Jul 31 2018, 5:40 AM
eugen_grosbein.net added a comment to D16459: bsnmpd(1): optimize interface description processing.

I'm going to commit latest revision soon unless an objection is raised.

Jul 31 2018, 5:35 AM

Jul 28 2018

eugen_grosbein.net updated the diff for D16459: bsnmpd(1): optimize interface description processing.

The only change comparing with previous revision is added truncation of interface description obtained with sysctl(3) if it appears longer than 64 octets.

Jul 28 2018, 6:18 AM

Jul 27 2018

eugen_grosbein.net added a comment to D16459: bsnmpd(1): optimize interface description processing.
In D16459#349483, @avg wrote:

Well, the standard says (0 ..64) and that means from zero to 64.
Also, my impression is that, according to the RFC, ifAlias is something that should be settable over SNMP and it should be persistent.

Jul 27 2018, 6:06 AM
eugen_grosbein.net added a comment to D16459: bsnmpd(1): optimize interface description processing.
In D16459#349416, @bz wrote:
Jul 27 2018, 3:38 AM

Jul 26 2018

eugen_grosbein.net added a comment to D16459: bsnmpd(1): optimize interface description processing.
In D16459#349396, @bz wrote:

Hmm RFC 2863 says:

ifAlias OBJECT-TYPE

SYNTAX      DisplayString (SIZE(0..64))
Jul 26 2018, 7:01 PM
eugen_grosbein.net updated the diff for D16459: bsnmpd(1): optimize interface description processing.

Style changes.

Jul 26 2018, 4:11 PM
eugen_grosbein.net added inline comments to D16459: bsnmpd(1): optimize interface description processing.
Jul 26 2018, 4:09 PM
eugen_grosbein.net created D16459: bsnmpd(1): optimize interface description processing.
Jul 26 2018, 3:23 PM

May 19 2018

eugen_grosbein.net added a comment to D15488: If reading the routing table fails, retry up to 10 times.

While the intention is good, I'm curious why someone would want to use "netstat -rn" these days for BGPv4 full view having about 700 thousands prefixes?

May 19 2018, 5:22 PM

May 17 2018

eugen_grosbein.net updated the test plan for D15247: Add rcorder(8) support to /etc/rc.resume.
May 17 2018, 7:20 PM

May 13 2018

eugen_grosbein.net added a comment to D15247: Add rcorder(8) support to /etc/rc.resume.

It seems that rc.shutdown.8 is just an alias for rc.8, do we add a cross-references in such a case?

May 13 2018, 5:07 PM
eugen_grosbein.net added a comment to D15247: Add rcorder(8) support to /etc/rc.resume.

NAME

rc - command scripts for auto-reboot and daemon startup
May 13 2018, 5:02 PM

May 11 2018

eugen_grosbein.net accepted D15329: Improvement for MAC address uniqueness of if_epair(4).

Looks just fine.

May 11 2018, 10:19 AM

May 9 2018

eugen_grosbein.net updated the diff for D15247: Add rcorder(8) support to /etc/rc.resume.

Add reference to rcorder(8) manual page.

May 9 2018, 5:12 PM
eugen_grosbein.net added inline comments to D15329: Improvement for MAC address uniqueness of if_epair(4).
May 9 2018, 3:02 PM
eugen_grosbein.net added a comment to D15329: Improvement for MAC address uniqueness of if_epair(4).

sizeof counts in octets (bytes), not bits
and you do not need complexity of "if (sizeof...)" but simply cast hostid to uint64_t unconditionally first.

May 9 2018, 10:45 AM
eugen_grosbein.net added a comment to D15247: Add rcorder(8) support to /etc/rc.resume.

Do you have any idea how to mention rc.resume in rc(8) correctly?

as mentioned before, add some cross referencing in the related man pages. Use the "See also" sections.

May 9 2018, 10:07 AM

May 8 2018

eugen_grosbein.net added a comment to D15329: Improvement for MAC address uniqueness of if_epair(4).

It's probably worth a little bit of thought as to what is the more common case, a zillion epair interfaces on one host (read: half a zillion vnet jails) or a much smaller number of epairs on a larger number of hosts. It sounds like you are well placed to assign your own addresses, whatever the default may be.

May 8 2018, 1:59 PM
eugen_grosbein.net added a comment to D15247: Add rcorder(8) support to /etc/rc.resume.
In D15247#323501, @avg wrote:

It would be nice to add a mention of rc.resume and the new resume keyword to rc(8) as Julian suggested.

May 8 2018, 1:34 PM
eugen_grosbein.net updated the diff for D15247: Add rcorder(8) support to /etc/rc.resume.

We have only one manual page acpiconf(8) that mentions /etc/rc.resume with exception of ancient apmd(8) page that is installed for i386 systems only. I've added needed description to acpiconf(8).

May 8 2018, 12:20 PM
eugen_grosbein.net added inline comments to D15329: Improvement for MAC address uniqueness of if_epair(4).
May 8 2018, 8:52 AM

May 7 2018

eugen_grosbein.net added a comment to D15329: Improvement for MAC address uniqueness of if_epair(4).

Well, I have many hosts having over housand of ngXXX interfaces, so yes, two bytes are needed at least.

May 7 2018, 3:21 PM
eugen_grosbein.net accepted D15329: Improvement for MAC address uniqueness of if_epair(4).
May 7 2018, 2:15 PM
eugen_grosbein.net added a comment to D15112: In snmp_mibII module assume that virtual interfaces can work at maximum speed available in the system.

How does it do that? The problem is whether a 64-bit increment or add is atomic with regard to a read from another CPU.

May 7 2018, 12:37 PM
eugen_grosbein.net added inline comments to D15329: Improvement for MAC address uniqueness of if_epair(4).
May 7 2018, 12:32 PM
eugen_grosbein.net added a reviewer for D15329: Improvement for MAC address uniqueness of if_epair(4): eugen_grosbein.net.

Using hostid should be fine as it adds protection against inter-jail MAC collisions. Just reuse it when possible instead of calling second time for it.

May 7 2018, 12:26 PM

May 6 2018

eugen_grosbein.net added a comment to D15329: Improvement for MAC address uniqueness of if_epair(4).

Why do you bother calling getcredhostid (which involves mutex lock/inlock) and arc4random second time while creating second interface?
Can't you just use already computed values from scb->oifp->if_hw_addr ?

May 6 2018, 9:52 PM

May 2 2018

eugen_grosbein.net accepted D15249: Security Update to gitlab 10.6.5.
May 2 2018, 9:09 AM
eugen_grosbein.net added a reviewer for D15249: Security Update to gitlab 10.6.5: eugen_grosbein.net.
May 2 2018, 9:09 AM
eugen_grosbein.net accepted D15248: Entry for security problem in gitlab.
May 2 2018, 9:06 AM
eugen_grosbein.net added a reviewer for D15248: Entry for security problem in gitlab: eugen_grosbein.net.

The change passes "make validation" tests.

May 2 2018, 9:06 AM

May 1 2018

eugen_grosbein.net created D15247: Add rcorder(8) support to /etc/rc.resume.
May 1 2018, 3:04 AM

Apr 17 2018

eugen_grosbein.net accepted D15112: In snmp_mibII module assume that virtual interfaces can work at maximum speed available in the system.
Apr 17 2018, 1:53 PM

Apr 16 2018

eugen_grosbein.net accepted D15083: Use pointer to fake bpf_if structure after bpfdetach().
Apr 16 2018, 11:05 AM

Mar 6 2018

eugen_grosbein.net added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.
In D14547#306289, @pi wrote:

Also, why don't you just use "ifconfig em0 x.y.z.A/24 -alias; ifconfig em1 x.y.z.B/24 alias" to perform the switch? It should just work.

This has a short timewindow, during which packets will be rejected. On high-traffic ports this will cause connection drops or losses.

Mar 6 2018, 1:23 AM

Mar 5 2018

eugen_grosbein.net added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

I don't think that this conversation is going to go anywhere productive.

Mar 5 2018, 6:19 PM
eugen_grosbein.net added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

Care to elaborate what are you trying to achieve by moving subnet route between interfaces?

My customer is using it as a lame form of failover. If the interface with address A goes down, we can fail over the subnet route to address B (on a different interface) and address B remains functional (address A remains down, of course. I did same it was a lame form of failover).

I have no ability to push back on the customer on this point. Their position is that this configuration was supported on previous versions and therefore must remain supported.

Mar 5 2018, 5:52 PM
eugen_grosbein.net added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.
Mar 5 2018, 5:36 PM

Mar 1 2018

eugen_grosbein.net added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.
Mar 1 2018, 10:07 PM

Feb 28 2018

eugen_grosbein.net added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

And you do you insist in doing things manually while moving IP (first route change, then reassign IP) instead of just allowing system do all housekeeping for you by reassigning IP first?

Feb 28 2018, 8:33 PM
eugen_grosbein.net added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

What FreeBSD version (including revision) do you use for TEST PLAN script, e.g. what is your "stock FreeBSD"?

Feb 28 2018, 8:22 PM
eugen_grosbein.net added a reviewer for D14547: Allow IPv4 subnet routes to move to a different ifa: network.
Feb 28 2018, 8:18 PM
eugen_grosbein.net added a reviewer for D14547: Allow IPv4 subnet routes to move to a different ifa: eugen_grosbein.net.
Feb 28 2018, 8:17 PM

Feb 16 2018

eugen_grosbein.net added a comment to D14385: Wrap a vlan's parent's if_output in a separate function..

I vote to block it for now. We can re-think it in case some useful example of real case came up.

Feb 16 2018, 9:54 PM

Feb 15 2018

eugen_grosbein.net added a comment to D14385: Wrap a vlan's parent's if_output in a separate function..

Indeed, people sometimes tend to do strange things with their network and that's nothing wrong with it (I do sometimes, too). But we should have a distinction for supported configuration and unsupported ones (leading to panic or anothe misbehavour). For example, we do not support assigning IP address to lagg or bridge member - one can do that but that won't work generally.

Feb 15 2018, 8:32 PM
eugen_grosbein.net added a comment to D14385: Wrap a vlan's parent's if_output in a separate function..

Why don't we just reject creation of vlan interface on lagg member (as opposed to lagg itself)?

Feb 15 2018, 6:52 PM

Feb 10 2018

eugen_grosbein.net accepted D14291: Allow route change requests to not specify the gateway..

Do you really need to mix whitespace change with the fix (last chunk)?

Feb 10 2018, 11:49 AM

Jan 15 2018

eugen_grosbein.net added a comment to D13801: Reject the absurd user and group names "." and ".."..

Initial submitter of the PR 224556 is a bit too rash.

Jan 15 2018, 7:44 PM

Dec 8 2017

eugen_grosbein.net added a comment to D13426: Extend stripeoffset and stripesize of GEOMs from u_int to off_t.
In D13426#280534, @kib wrote:

Does this change break ABI or KBI ? Or both ?

Dec 8 2017, 10:54 PM
eugen_grosbein.net added a comment to D13426: Extend stripeoffset and stripesize of GEOMs from u_int to off_t.
In D13426#280611, @kib wrote:

nop and others not mentioned in the diff use "off_t" internaly already.

Look at the argument types for g_nop_create() as an example.

Dec 8 2017, 10:38 PM
eugen_grosbein.net updated the diff for D13426: Extend stripeoffset and stripesize of GEOMs from u_int to off_t.

More changes: geom_nop, geom_stripe and geom_redboot.

Dec 8 2017, 10:34 PM
eugen_grosbein.net added a comment to D13426: Extend stripeoffset and stripesize of GEOMs from u_int to off_t.
In D13426#280612, @imp wrote:
Dec 8 2017, 10:31 PM
eugen_grosbein.net updated the summary of D13426: Extend stripeoffset and stripesize of GEOMs from u_int to off_t.
Dec 8 2017, 9:07 PM
eugen_grosbein.net added a comment to D13426: Extend stripeoffset and stripesize of GEOMs from u_int to off_t.
In D13426#280534, @kib wrote:

Does this change break ABI or KBI ? Or both ?

Dec 8 2017, 8:51 PM
eugen_grosbein.net retitled D13426: Extend stripeoffset and stripesize of GEOMs from u_int to off_t from Extend stripeoffset and stripesize of GEOMs from uint_t to off_t to Extend stripeoffset and stripesize of GEOMs from u_int to off_t.
Dec 8 2017, 8:49 PM
eugen_grosbein.net added inline comments to D13426: Extend stripeoffset and stripesize of GEOMs from u_int to off_t.
Dec 8 2017, 8:47 PM
eugen_grosbein.net added a comment to D13426: Extend stripeoffset and stripesize of GEOMs from u_int to off_t.
In D13426#280534, @kib wrote:

Does this change break ABI or KBI ? Or both ?

Some providers take stripesize/offset in create, e.g. nop. Do they need a fix included into the change ?

Dec 8 2017, 8:40 PM