Page MenuHomeFreeBSD
People dim

dim (Dimitry Andric)
User

Projects

User Details

User Since
Jan 7 2014, 10:13 PM (308 w, 5 d)

Recent Activity
View All

Today

dim committed rD53670: Attempt to appease the Jenkins job that builds the porter's handbook..
Attempt to appease the Jenkins job that builds the porter's handbook.
Mon, Dec 9, 8:13 PM
dim committed rD53669: Document __FreeBSD_version value 1300064..
Document __FreeBSD_version value 1300064.
Mon, Dec 9, 7:22 PM
dim closed D22735: Correctly check for C++17 and higher when declaring timespec_get().
Mon, Dec 9, 7:18 PM
dim committed rS355568: Correctly check for C++17 and higher when declaring timespec_get().
Correctly check for C++17 and higher when declaring timespec_get()
Mon, Dec 9, 7:18 PM
dim created D22735: Correctly check for C++17 and higher when declaring timespec_get().
Mon, Dec 9, 6:33 PM

Wed, Dec 4

dim committed rS355397: Merge commit 241cbf201 from llvm git (by Nemanja Ivanovic):.
Merge commit 241cbf201 from llvm git (by Nemanja Ivanovic):
Wed, Dec 4, 6:39 PM
dim committed rS355395: r355120 | dim | 2019-11-26 23:01:09 +0100 (Tue, 26 Nov 2019) | 32 lines.
r355120 | dim | 2019-11-26 23:01:09 +0100 (Tue, 26 Nov 2019) | 32 lines
Wed, Dec 4, 5:45 PM

Thu, Nov 28

dim committed rS355189: MFC r354908:.
MFC r354908:
Thu, Nov 28, 8:09 PM

Tue, Nov 26

dim committed rS355120: The fdlibm hypot() implementations shouldn't potentially left-shift.
The fdlibm hypot() implementations shouldn't potentially left-shift
Tue, Nov 26, 10:01 PM
dim closed D22354: The fdlibm hypot() implementations shouldn't potentially left-shift negative numbers (invoking undefined behavior).
Tue, Nov 26, 10:01 PM

Sat, Nov 23

dim accepted D22354: The fdlibm hypot() implementations shouldn't potentially left-shift negative numbers (invoking undefined behavior).

Ok, if the long double part is dropped, the tests succeed. So LGTM.

Sat, Nov 23, 8:02 PM
dim committed rS355034: libclang_rt: enable on powerpc*.
libclang_rt: enable on powerpc*
Sat, Nov 23, 7:35 PM
dim closed D22425: libclang_rt: enable on powerpc*.
Sat, Nov 23, 7:35 PM

Thu, Nov 21

dim committed rS354985: Merge commit a751f557d from llvm git (by Simon Atanasyan):.
Merge commit a751f557d from llvm git (by Simon Atanasyan):
Thu, Nov 21, 8:36 PM
dim committed rS354984: Merge commit 0d14656b9 from llvm git (by Simon Atanasyan):.
Merge commit 0d14656b9 from llvm git (by Simon Atanasyan):
Thu, Nov 21, 8:36 PM
dim committed rS354983: Merge commit e578d0fd2 from llvm git (by Simon Atanasyan):.
Merge commit e578d0fd2 from llvm git (by Simon Atanasyan):
Thu, Nov 21, 8:32 PM
dim committed rS354982: Merge commit 3552d3e0f from llvm git (by Simon Atanasyan):.
Merge commit 3552d3e0f from llvm git (by Simon Atanasyan):
Thu, Nov 21, 8:26 PM
dim committed rS354981: Merge commit bf996f761 from llvm git (by Simon Atanasyan):.
Merge commit bf996f761 from llvm git (by Simon Atanasyan):
Thu, Nov 21, 8:25 PM
dim committed rS354980: Merge commit 3718102d4 from llvm git (by Simon Atanasyan):.
Merge commit 3718102d4 from llvm git (by Simon Atanasyan):
Thu, Nov 21, 8:23 PM
dim committed rS354979: Merge commit 7bed381ea from llvm git (by Simon Atanasyan):.
Merge commit 7bed381ea from llvm git (by Simon Atanasyan):
Thu, Nov 21, 8:22 PM
dim added a comment to D22425: libclang_rt: enable on powerpc*.

@pkubaj if you can't commit it, I will be happy to do so.

Thu, Nov 21, 6:50 PM

Wed, Nov 20

dim committed rS354910: Fix typo: deprected -> deprecated..
Fix typo: deprected -> deprecated.
Wed, Nov 20, 7:07 PM
dim accepted D22425: libclang_rt: enable on powerpc*.

LGTM.

Wed, Nov 20, 7:04 PM
dim committed rS354908: Add explanatory comments for the different SRCS_xxx variables used in.
Add explanatory comments for the different SRCS_xxx variables used in
Wed, Nov 20, 6:12 PM

Mon, Nov 18

dim committed rS354803: MFC r354724:.
MFC r354724:
Mon, Nov 18, 7:05 AM

Sat, Nov 16

dim added inline comments to D22354: The fdlibm hypot() implementations shouldn't potentially left-shift negative numbers (invoking undefined behavior).
Sat, Nov 16, 8:37 PM
dim added a comment to D22354: The fdlibm hypot() implementations shouldn't potentially left-shift negative numbers (invoking undefined behavior).
In D22354#489981, @lwhsu wrote:

Assertion failed: (creall(result) == ldexpl(14 * 0x1p-4, exp / 2)), function test_overflow, file /usr/home/lwhsu/freebsd-src/lib/msun/tests/csqrt_test.c, line 236.

Sat, Nov 16, 7:57 PM

Fri, Nov 15

dim committed rS354724: Merge commit 5bbb604bb from llvm git (by Craig Topper):.
Merge commit 5bbb604bb from llvm git (by Craig Topper):
Fri, Nov 15, 6:56 AM

Tue, Nov 12

dim accepted D22284: Enable the RISCV LLVM backend by default..
Tue, Nov 12, 6:03 PM
dim accepted D22333: Sync target triple generation with the version in Makefile.inc1..

I'm fine with this, though the substitution expression is getting more and more unreadable... I'm having difficulty to figure out what the actual triple is going to end up as; is it risc64-x-y ?

Tue, Nov 12, 5:33 PM

Mon, Nov 11

dim committed rS354626: MFC r354625:.
MFC r354625:
Mon, Nov 11, 5:45 PM
dim committed rS354625: Merge commit 371ea70bb from llvm git (by Louis Dionne):.
Merge commit 371ea70bb from llvm git (by Louis Dionne):
Mon, Nov 11, 5:42 PM

Sun, Nov 10

dim committed rD53580: Document __FreeBSD_version values 1201501 and 1103501..
Document __FreeBSD_version values 1201501 and 1103501.
Sun, Nov 10, 7:02 PM
dim committed rD53579: Fill in real revnumber entries for releng/12.1 related rows..
Fill in real revnumber entries for releng/12.1 related rows.
Sun, Nov 10, 7:00 PM
dim committed rD53578: Consistently use <revnumber> entries without 'r' prefixes..
Consistently use <revnumber> entries without 'r' prefixes.
Sun, Nov 10, 6:55 PM
dim committed rS354598: MFC r354460:.
MFC r354460:
Sun, Nov 10, 6:41 PM
dim committed rS354596: MFC r354255:.
MFC r354255:
Sun, Nov 10, 5:33 PM

Nov 8 2019

dim accepted D22284: Enable the RISCV LLVM backend by default..

LGTM.

Nov 8 2019, 6:20 PM

Nov 7 2019

dim committed rS354469: Merge commit f596f4507 from llvm git (by Sam Elliott):.
Merge commit f596f4507 from llvm git (by Sam Elliott):
Nov 7 2019, 7:54 PM
dim committed rD53566: Document __FreeBSD version values 1300047 through 1300056..
Document __FreeBSD version values 1300047 through 1300056.
Nov 7 2019, 7:01 PM
dim committed rS354460: Merge commit e8316372b from llvm git (by Louis Dionne):.
Merge commit e8316372b from llvm git (by Louis Dionne):
Nov 7 2019, 6:26 PM
dim committed rS354429: Merge commit 8e34dd941 from llvm git (by Sanjay Patel):.
Merge commit 8e34dd941 from llvm git (by Sanjay Patel):
Nov 7 2019, 6:59 AM

Nov 6 2019

dim accepted D22252: clang: Enable unwind tables on !amd64.

Yeah, I'm fine with this too. And indeed, we need to upstream this (with tests). :)

Nov 6 2019, 9:41 PM

Nov 4 2019

dim committed rS354339: Merge commit 97e362607 from llvm git (by Nemanja Ivanovic):.
Merge commit 97e362607 from llvm git (by Nemanja Ivanovic):
Nov 4 2019, 7:38 PM

Nov 2 2019

dim committed rS354255: Add __isnan()/__isnanf() aliases for compatibility with glibc and CUDA.
Add __isnan()/__isnanf() aliases for compatibility with glibc and CUDA
Nov 2 2019, 5:00 PM

Oct 29 2019

dim committed rS354146: Pull in r373338 from upstream llvm trunk (by Simon Pilgrim):.
Pull in r373338 from upstream llvm trunk (by Simon Pilgrim):
Oct 29 2019, 4:51 PM

Oct 28 2019

dim committed rS354136: MFC r353933:.
MFC r353933:
Oct 28 2019, 6:37 PM

Oct 25 2019

dim committed rS354097: Pull in r372186 from upstream llvm trunk (by Eli Friedman):.
Pull in r372186 from upstream llvm trunk (by Eli Friedman):
Oct 25 2019, 9:01 PM

Oct 23 2019

dim committed rS353950: Vendor import of stripped lld trunk r375505, the last commit before the.
Vendor import of stripped lld trunk r375505, the last commit before the
Oct 23 2019, 5:59 PM
dim committed rS353954: Vendor import of stripped LLVM openmp trunk r375505, the last commit.
Vendor import of stripped LLVM openmp trunk r375505, the last commit
Oct 23 2019, 5:59 PM
dim committed rS353941: Tag stripped llvm trunk r375505, the last commit before the upstream.
Tag stripped llvm trunk r375505, the last commit before the upstream
Oct 23 2019, 5:57 PM
dim committed rS353953: Tag stripped lldb trunk r375505, the last commit before the upstream.
Tag stripped lldb trunk r375505, the last commit before the upstream
Oct 23 2019, 5:56 PM
dim committed rS353943: Tag stripped clang trunk r375505, the last commit before the upstream.
Tag stripped clang trunk r375505, the last commit before the upstream
Oct 23 2019, 5:56 PM
dim committed rS353945: Tag stripped compiler-rt trunk r375505, the last commit before the.
Tag stripped compiler-rt trunk r375505, the last commit before the
Oct 23 2019, 5:56 PM
dim committed rS353952: Vendor import of stripped lldb trunk r375505, the last commit before the.
Vendor import of stripped lldb trunk r375505, the last commit before the
Oct 23 2019, 5:55 PM
dim committed rS353942: Vendor import of stripped clang trunk r375505, the last commit before.
Vendor import of stripped clang trunk r375505, the last commit before
Oct 23 2019, 5:55 PM
dim committed rS353944: Vendor import of stripped compiler-rt trunk r375505, the last commit.
Vendor import of stripped compiler-rt trunk r375505, the last commit
Oct 23 2019, 5:55 PM
dim committed rS353940: Vendor import of stripped llvm trunk r375505, the last commit before the.
Vendor import of stripped llvm trunk r375505, the last commit before the
Oct 23 2019, 5:55 PM
dim committed rS353951: Tag stripped lld trunk r375505, the last commit before the upstream.
Tag stripped lld trunk r375505, the last commit before the upstream
Oct 23 2019, 5:55 PM
dim committed rS353947: Tag stripped libc++ trunk r375505, the last commit before the upstream.
Tag stripped libc++ trunk r375505, the last commit before the upstream
Oct 23 2019, 5:55 PM
dim committed rS353955: Tag stripped LLVM openmp trunk r375505, the last commit before the.
Tag stripped LLVM openmp trunk r375505, the last commit before the
Oct 23 2019, 5:55 PM
dim committed rS353949: Tag stripped LLVM libunwind trunk r375505, the last commit before the.
Tag stripped LLVM libunwind trunk r375505, the last commit before the
Oct 23 2019, 5:54 PM
dim committed rS353946: Vendor import of stripped libc++ trunk r375505, the last commit before.
Vendor import of stripped libc++ trunk r375505, the last commit before
Oct 23 2019, 5:54 PM
dim committed rS353948: Vendor import of stripped LLVM libunwind trunk r375505, the last commit.
Vendor import of stripped LLVM libunwind trunk r375505, the last commit
Oct 23 2019, 5:54 PM
dim committed rS353937: Build toolchain components as dynamically linked executables by default.
Build toolchain components as dynamically linked executables by default
Oct 23 2019, 5:03 PM
dim closed D22061: Build toolchain components as dynamically linked executables by default.
Oct 23 2019, 5:03 PM
dim committed rS353936: Bump clang's default target CPU for the i386 architecture (aka "x86") to.
Bump clang's default target CPU for the i386 architecture (aka "x86") to
Oct 23 2019, 4:57 PM
dim committed rS353933: Slightly expand description of WITH_SHARED_TOOLCHAIN, add a.
Slightly expand description of WITH_SHARED_TOOLCHAIN, add a
Oct 23 2019, 4:48 PM

Oct 21 2019

dim committed rS353801: Partially MFC r339524 (by imp):.
Partially MFC r339524 (by imp):
Oct 21 2019, 5:55 PM
dim committed rS353800: MFC r339524 (by imp):.
MFC r339524 (by imp):
Oct 21 2019, 5:45 PM

Oct 20 2019

dim committed rS353776: Follow up on r351916 by also bumping the version suffix to 12.1 in.
Follow up on r351916 by also bumping the version suffix to 12.1 in
Oct 20 2019, 2:45 PM

Oct 19 2019

dim committed rS353765: MFC r353655:.
MFC r353655:
Oct 19 2019, 3:58 PM

Oct 18 2019

dim committed rS353739: Pull in r374154 from upstream clang trunk (by Simon Atanasyan):.
Pull in r374154 from upstream clang trunk (by Simon Atanasyan):
Oct 18 2019, 8:05 PM
dim committed rS353738: Pull in r372651 from upstream lld trunk (by Simon Atanasyan):.
Pull in r372651 from upstream lld trunk (by Simon Atanasyan):
Oct 18 2019, 8:02 PM
dim committed rS353737: Provide a src.conf(5) description for the new WITHOUT_CAROOT option, and.
Provide a src.conf(5) description for the new WITHOUT_CAROOT option, and
Oct 18 2019, 7:30 PM
dim added a comment to D22061: Build toolchain components as dynamically linked executables by default.
In D22061#482304, @greg_unrelenting.technology wrote:

Maybe at some point they can even become PIE executables by default! :)

What's holding this up btw? Is there any actual reason why we have any non-PIE executables at all on aarch64 and amd64?

Oct 18 2019, 12:07 PM

Oct 16 2019

dim created D22061: Build toolchain components as dynamically linked executables by default.
Oct 16 2019, 8:34 PM
dim committed rS353655: Ensure lld respects the WITH/WITHOUT_SHARED_TOOLCHAIN option.
Ensure lld respects the WITH/WITHOUT_SHARED_TOOLCHAIN option
Oct 16 2019, 5:11 PM
dim accepted D21963: llvm: Add missing RISC-V source to Makefile.

Ah sorry, totally forgot about this. LGTM :)

Oct 16 2019, 5:08 AM

Oct 15 2019

dim accepted D22034: Use __FreeBSD_version to determine if gets() has been removed..

Ah, I now realized that <osreldate.h> is a very minimal header, I was thinking that it would pull in lots of pollution, like <sys/param.h>... In that case it is probably the least ugly solution.

Oct 15 2019, 4:25 PM
dim added a comment to D22034: Use __FreeBSD_version to determine if gets() has been removed..

Hmm, I had explicitly avoided to add any #include statements, due to there being very few of them in this header (it is included by literally everything in libc++). I would rather fix the external toolchains instead, to return the correct version of FreeBSD. But if people feel this is the right way to solve the issue, so be it. But maybe we should not send this upstream.

Oct 15 2019, 5:40 AM

Oct 10 2019

dim committed rS353416: Pull in r374444 from upstream lldb trunk (by me):.
Pull in r374444 from upstream lldb trunk (by me):
Oct 10 2019, 8:34 PM
dim committed rS353415: Revert r353363 in preparation for applying upstream fix:.
Revert r353363 in preparation for applying upstream fix:
Oct 10 2019, 8:31 PM

Oct 9 2019

dim committed rS353363: Put in a band-aid fix for lldb 9 exiting with "Expected<T> must be.
Put in a band-aid fix for lldb 9 exiting with "Expected<T> must be
Oct 9 2019, 7:52 PM
dim committed rS353358: Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp.
Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp
Oct 9 2019, 5:12 PM
dim committed rS353352: Fixup mergeinfo on contrib/llvm which Subversion managed to mess up..
Fixup mergeinfo on contrib/llvm which Subversion managed to mess up.
Oct 9 2019, 4:43 PM
dim committed rS353351: Merge ^/head r353316 through r353350..
Merge ^/head r353316 through r353350.
Oct 9 2019, 4:40 PM

Oct 8 2019

dim committed rS353318: Prepare for merging back to head:.
Prepare for merging back to head:
Oct 8 2019, 6:21 PM
dim committed rS353316: Merge ^/head r352764 through r353315..
Merge ^/head r352764 through r353315.
Oct 8 2019, 6:19 PM
dim accepted D21913: msun: Silence new harmless -Wimplicit-int-float-conversion warnings.

LGTM. I guess we could also define DYPE_MIN and DTYPE_MAX themselves to have the casts, but that looks like more churn.

Oct 8 2019, 5:58 PM

Oct 3 2019

dim committed rS353053: Merge r353031 from stable/12:.
Merge r353031 from stable/12:
Oct 3 2019, 4:23 PM
dim committed rS353031: MFC r352915:.
MFC r352915:
Oct 3 2019, 6:08 AM

Oct 1 2019

dim added reviewers for D21800: fix emulation name passed to linker when cross compiling: imp, bdrewery.

Adding imp and bdrewery for some more sanity checking. I know almost nothing about meta mode. :)

Oct 1 2019, 5:30 PM · PowerPC
dim updated the diff for D21800: fix emulation name passed to linker when cross compiling.

A few minor changes.

Oct 1 2019, 5:30 PM · PowerPC
dim committed rP513456: MFH: r512436.
MFH: r512436
Oct 1 2019, 6:01 AM

Sep 30 2019

dim committed rS352915: Pull in r357528 from upstream llvm trunk (by Craig Topper):.
Pull in r357528 from upstream llvm trunk (by Craig Topper):
Sep 30 2019, 7:24 PM
dim committed rS352889: MFC r352804:.
MFC r352804:
Sep 30 2019, 6:09 AM

Sep 28 2019

dim committed rS352835: MFC r352710:.
MFC r352710:
Sep 28 2019, 8:57 AM
dim committed rS352834: MFC r352699:.
MFC r352699:
Sep 28 2019, 8:54 AM

Sep 27 2019

dim committed rS352819: Allow entering fractional delays in top(1) interactive mode..
Allow entering fractional delays in top(1) interactive mode.
Sep 27 2019, 8:53 PM