Page MenuHomeFreeBSD

dim (Dimitry Andric)
User

Projects

User Details

User Since
Jan 7 2014, 10:13 PM (378 w, 4 d)

Recent Activity

Yesterday

dim committed R10:bae9fd0b3346: Only use -fp-exception-behavior=maytrap on x86, for now (authored by dim).
Only use -fp-exception-behavior=maytrap on x86, for now
Sat, Apr 10, 2:05 PM
dim committed R10:3b00222f156d: Avoid raising unexpected floating point exceptions in libm (authored by dim).
Avoid raising unexpected floating point exceptions in libm
Sat, Apr 10, 12:03 PM
dim closed D29686: Avoid raising unexpected floating point exceptions in libm.
Sat, Apr 10, 12:02 PM
dim committed R10:44faff9f4a0f: Adjust .arcconfig to land onto 'main' by default (authored by dim).
Adjust .arcconfig to land onto 'main' by default
Sat, Apr 10, 11:54 AM

Fri, Apr 9

dim added a comment to D29686: Avoid raising unexpected floating point exceptions in libm.

Note that we could also apply this flag *only* to lib/msun/src/s_ctanhf.c optionally, as this is the only case we know for certain that has issues with these spurious exceptions.

Fri, Apr 9, 11:14 PM
dim requested review of D29686: Avoid raising unexpected floating point exceptions in libm.
Fri, Apr 9, 11:09 PM

Thu, Apr 8

dim accepted D29649: relnotes: note the updated LLVM version.

LGTM

Thu, Apr 8, 5:13 PM
dim added inline comments to D29649: relnotes: note the updated LLVM version.
Thu, Apr 8, 4:35 PM
dim committed R10:7702d940ec9a: Avoid -pedantic warnings about using _Generic in __fp_type_select (authored by dim).
Avoid -pedantic warnings about using _Generic in __fp_type_select
Thu, Apr 8, 4:32 PM

Fri, Mar 26

dim committed R10:dacfb3a1c427: Remove more terminfo entries after 16d3faad099a (authored by dim).
Remove more terminfo entries after 16d3faad099a
Fri, Mar 26, 9:24 PM
dim closed D29355: Remove more terminfo entries after 16d3faad099a.
Fri, Mar 26, 9:24 PM
dim updated the diff for D29355: Remove more terminfo entries after 16d3faad099a.

Rebase

Fri, Mar 26, 9:21 PM

Sat, Mar 20

dim committed R10:15deee52d6d5: Move GH_BC ObsoleteFiles.inc section to OptionalObsoleteFiles.inc (authored by dim).
Move GH_BC ObsoleteFiles.inc section to OptionalObsoleteFiles.inc
Sat, Mar 20, 10:16 PM
dim requested review of D29355: Remove more terminfo entries after 16d3faad099a.
Sat, Mar 20, 10:09 PM
dim accepted D29352: elftoolchain: Support building on Arm-based Macs.

LGTM.

Sat, Mar 20, 5:37 PM

Sat, Mar 13

dim committed R10:0b45290603b9: Partially revert libcxxrt changes to avoid _Unwind_Exception change (authored by dim).
Partially revert libcxxrt changes to avoid _Unwind_Exception change
Sat, Mar 13, 1:55 PM
dim committed R10:9097e3cbcac4: Partially revert libcxxrt changes to avoid _Unwind_Exception change (authored by dim).
Partially revert libcxxrt changes to avoid _Unwind_Exception change
Sat, Mar 13, 1:55 PM

Mar 10 2021

dim committed R10:3a5074327da0: Partially revert libcxxrt changes to avoid _Unwind_Exception change (authored by dim).
Partially revert libcxxrt changes to avoid _Unwind_Exception change
Mar 10 2021, 9:53 PM
dim committed R10:3ef7b71f3b77: Partially revert libcxxrt changes to avoid _Unwind_Exception change (authored by dim).
Partially revert libcxxrt changes to avoid _Unwind_Exception change
Mar 10 2021, 9:51 PM

Mar 9 2021

dim committed R10:64b30c36712e: Add a few missed files to libclang_rt.profile-<arch>.a (authored by dim).
Add a few missed files to libclang_rt.profile-<arch>.a
Mar 9 2021, 9:00 PM
dim committed R10:3f684107ef6e: Add a few missed files to libclang_rt.profile-<arch>.a (authored by dim).
Add a few missed files to libclang_rt.profile-<arch>.a
Mar 9 2021, 8:26 PM
dim committed R10:7ee9798bad0b: Build lib/msun tests with compiler builtins disabled (authored by dim).
Build lib/msun tests with compiler builtins disabled
Mar 9 2021, 8:24 PM
dim committed R10:e91ff79b2811: Build lib/msun tests with compiler builtins disabled (authored by dim).
Build lib/msun tests with compiler builtins disabled
Mar 9 2021, 8:23 PM
dim committed R10:27e68baf24f1: Build lib/msun tests with compiler builtins disabled (authored by dim).
Build lib/msun tests with compiler builtins disabled
Mar 9 2021, 8:23 PM

Mar 5 2021

dim accepted D28786: lib/msun: Avoid FE_INEXACT for x86 log2l/log10l.

Although the original authors seem to dislike constant folding by the compiler, it is a good idea here. :)

Mar 5 2021, 8:48 PM
dim accepted D28787: printf: Avoid setting FE_INEXACT in printf().

If this also works for softfloat now, please go ahead.

Mar 5 2021, 8:46 PM
dim accepted D29095: lib/msun/tests: Skip fenv_test:masking if exceptions can't be trapped.

Looks like a good idea to me.

Mar 5 2021, 8:45 PM
dim accepted D29091: Improve test messages for msun tests.

Yes, I like this. It's always annoyed me that the failing values weren't printed, and that a lot of code was repeated.

Mar 5 2021, 8:44 PM
dim accepted D28852: Allow using sanitizers for ssp tests with out-of-tree compiler.

I don't like it too much, but it seems to be necessary to be able to build world with sanitizers later, so let's go for it. :)

Mar 5 2021, 8:40 PM
dim committed R10:772c631af81a: Add a few missed files to libclang_rt.profile-<arch>.a (authored by dim).
Add a few missed files to libclang_rt.profile-<arch>.a
Mar 5 2021, 8:08 PM

Mar 3 2021

dim accepted D28651: elfcopy: stop leaving temporary files on error.

Ah sorry, totally forgotten about this. It seems to be fine, let's get it in then.

Mar 3 2021, 4:42 PM
dim accepted D29028: clang: Fix -gz=zlib options for linker.

LGTM

Mar 3 2021, 11:11 AM

Mar 1 2021

dim accepted D28994: riscv: Add a soft-float implementation of fabs().

LGTM

Mar 1 2021, 11:32 AM

Feb 28 2021

dim committed rP566802: Fix run-depends check for py-llfuse after shared libs naming change.
Fix run-depends check for py-llfuse after shared libs naming change
Feb 28 2021, 7:51 PM
dim committed rP566760: net/py-wsdd: uppercase LOGIN provision in BEFORE line in rc script.
net/py-wsdd: uppercase LOGIN provision in BEFORE line in rc script
Feb 28 2021, 1:02 PM

Feb 24 2021

dim committed R10:696961f67c5e: Fix possibly unitialized variables in __cxa_demangle_gnu3() (authored by dim).
Fix possibly unitialized variables in __cxa_demangle_gnu3()
Feb 24 2021, 7:42 PM
dim committed R10:64809c763b0c: Fix possibly unitialized variables in __cxa_demangle_gnu3() (authored by dim).
Fix possibly unitialized variables in __cxa_demangle_gnu3()
Feb 24 2021, 7:42 PM
dim committed R10:1c1460747efd: Fix possibly unitialized variables in __cxa_demangle_gnu3() (authored by dim).
Fix possibly unitialized variables in __cxa_demangle_gnu3()
Feb 24 2021, 7:41 PM

Feb 23 2021

dim accepted D28787: printf: Avoid setting FE_INEXACT in printf().
In D28787#646949, @dim wrote:

Hm, wouldn't it be better to fix this in gdtoa() instead? Then it would be solved for all gdtoa() consumers. That said, I've understood that the gdtoa code is very impenetrable...

I had a brief look at modifying the gdtoa code, but it seemed to be quite akward so I chose to change the wrapper instead.

Feb 23 2021, 8:28 PM
dim accepted D28872: Update scalbn* functions to the musl versions.

It's rather huge, and I'm unsure if the new implementation is much clearer than the old one, with all the magic numbers.... But it passes all current tests, and looks about one or two levels less scary. :)

Feb 23 2021, 8:25 PM
dim added a comment to D28787: printf: Avoid setting FE_INEXACT in printf().

Hm, wouldn't it be better to fix this in gdtoa() instead? Then it would be solved for all gdtoa() consumers. That said, I've understood that the gdtoa code is very impenetrable...

Feb 23 2021, 8:19 PM
dim requested changes to D28852: Allow using sanitizers for ssp tests with out-of-tree compiler.

Though I dislike this all getting so complex, I guess there is no good alternative way to get the required information. At some point using an external toolchain will become the default, and then it'd better work... :)

Feb 23 2021, 8:16 PM
dim closed D28577: While building libm, turn off any math-related compiler builtins.
Feb 23 2021, 8:11 PM
dim committed R10:cf97d2a1dab8: Build lib/msun tests with compiler builtins disabled (authored by dim).
Build lib/msun tests with compiler builtins disabled
Feb 23 2021, 8:11 PM

Feb 22 2021

dim committed R10:d149877758f1: Fix possibly unitialized variables in __cxa_demangle_gnu3() (authored by dim).
Fix possibly unitialized variables in __cxa_demangle_gnu3()
Feb 22 2021, 8:08 PM

Feb 21 2021

dim added a reverting change for R10:3c4fd2463bb2: libcxxrt: add padding in __cxa_allocate_* to fix alignment: R10:0aa8c6552ff5: Merge libcxxrt master 8049924686b8414d8e652cbd2a52c763b48e8456.
Feb 21 2021, 12:03 PM
dim added a reverting change for R10:3c4fd2463bb2: libcxxrt: add padding in __cxa_allocate_* to fix alignment: R10:72b20d2aa973: Merge libcxxrt master 8049924686b8414d8e652cbd2a52c763b48e8456.
Feb 21 2021, 12:03 PM
dim committed R10:0aa8c6552ff5: Merge libcxxrt master 8049924686b8414d8e652cbd2a52c763b48e8456 (authored by dim).
Merge libcxxrt master 8049924686b8414d8e652cbd2a52c763b48e8456
Feb 21 2021, 12:03 PM
dim committed R10:72b20d2aa973: Merge libcxxrt master 8049924686b8414d8e652cbd2a52c763b48e8456 (authored by dim).
Merge libcxxrt master 8049924686b8414d8e652cbd2a52c763b48e8456
Feb 21 2021, 12:02 PM
dim added a reverting change for R10:3c4fd2463bb2: libcxxrt: add padding in __cxa_allocate_* to fix alignment: R10:d4a0c102a237: Merge libcxxrt master 8049924686b8414d8e652cbd2a52c763b48e8456.
Feb 21 2021, 12:02 PM
dim committed R10:d4a0c102a237: Merge libcxxrt master 8049924686b8414d8e652cbd2a52c763b48e8456 (authored by dim).
Merge libcxxrt master 8049924686b8414d8e652cbd2a52c763b48e8456
Feb 21 2021, 12:02 PM

Feb 20 2021

dim added a reverting change for R10:3c4fd2463bb2: libcxxrt: add padding in __cxa_allocate_* to fix alignment: R10:9418450e056f: Revert "Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way".
Feb 20 2021, 8:46 PM
dim added a reverting change for R10:3c4fd2463bb2: libcxxrt: add padding in __cxa_allocate_* to fix alignment: R10:780a76a6ec21: Revert "Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way".
Feb 20 2021, 8:45 PM
dim added a reverting change for R10:49e7d3fee6ac: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way: R10:9418450e056f: Revert "Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way".
Feb 20 2021, 8:45 PM
dim committed R10:9418450e056f: Revert "Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way" (authored by dim).
Revert "Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way"
Feb 20 2021, 8:45 PM
dim added a reverting change for D28799: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way: R10:9418450e056f: Revert "Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way".
Feb 20 2021, 8:45 PM
dim added a reverting change for R10:3c4fd2463bb2: libcxxrt: add padding in __cxa_allocate_* to fix alignment: R10:6af57633d7a0: Revert "Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way".
Feb 20 2021, 8:45 PM
dim added a reverting change for R10:9e86d1669765: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way: R10:780a76a6ec21: Revert "Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way".
Feb 20 2021, 8:45 PM
dim committed R10:780a76a6ec21: Revert "Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way" (authored by dim).
Revert "Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way"
Feb 20 2021, 8:45 PM
dim added a reverting change for R10:aeb00dca0d03: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way: R10:6af57633d7a0: Revert "Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way".
Feb 20 2021, 8:44 PM
dim added a reverting change for D28799: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way: R10:780a76a6ec21: Revert "Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way".
Feb 20 2021, 8:44 PM
dim committed R10:6af57633d7a0: Revert "Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way" (authored by dim).
Revert "Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way"
Feb 20 2021, 8:44 PM
dim added a reverting change for D28799: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way: R10:6af57633d7a0: Revert "Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way".
Feb 20 2021, 8:44 PM
dim added a reverting change for R10:3c4fd2463bb2: libcxxrt: add padding in __cxa_allocate_* to fix alignment: R10:49e7d3fee6ac: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way.
Feb 20 2021, 8:05 PM
dim added a reverting change for R10:3c4fd2463bb2: libcxxrt: add padding in __cxa_allocate_* to fix alignment: R10:9e86d1669765: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way.
Feb 20 2021, 8:04 PM
dim committed R10:49e7d3fee6ac: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way (authored by dim).
Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way
Feb 20 2021, 8:04 PM
dim added a reverting change for R10:3c4fd2463bb2: libcxxrt: add padding in __cxa_allocate_* to fix alignment: R10:aeb00dca0d03: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way.
Feb 20 2021, 8:04 PM
dim committed R10:9e86d1669765: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way (authored by dim).
Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way
Feb 20 2021, 8:04 PM
dim committed R10:aeb00dca0d03: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way (authored by dim).
Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way
Feb 20 2021, 8:03 PM

Feb 19 2021

dim added a reverting change for R10:3c4fd2463bb2: libcxxrt: add padding in __cxa_allocate_* to fix alignment: R10:d2b3fadf2db5: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way.
Feb 19 2021, 9:19 PM
dim committed R10:d2b3fadf2db5: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way (authored by dim).
Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way
Feb 19 2021, 9:19 PM
dim closed D28799: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way.
Feb 19 2021, 9:18 PM
dim added a comment to D28799: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way.

The real problem is IMO that there are three subtly incompatible definitions of struct _Unwind_Exception: include/unwind.h, contrib/llvm/libunwind and contrib/libcxxrt. This also caused issues in CheriBSD.

Feb 19 2021, 8:49 PM
dim requested review of D28799: Revert 3c4fd2463bb2 since upstream libcxxrt fixed it in another way.
Feb 19 2021, 6:26 PM

Feb 18 2021

dim committed R10:0ee0dbfb0d26: Merge libcxxrt master 8049924686b8414d8e652cbd2a52c763b48e8456 (authored by dim).
Merge libcxxrt master 8049924686b8414d8e652cbd2a52c763b48e8456
Feb 18 2021, 9:31 PM
dim committed R10:3f8a54b20893: Import libcxxrt master 8049924686b8414d8e652cbd2a52c763b48e8456 (authored by dim).
Import libcxxrt master 8049924686b8414d8e652cbd2a52c763b48e8456
Feb 18 2021, 9:09 PM
dim committed R10:7799e59719e4: Update Subversion to 1.14.1 LTS. See contrib/subversion/CHANGES for a (authored by dim).
Update Subversion to 1.14.1 LTS. See contrib/subversion/CHANGES for a
Feb 18 2021, 8:06 PM
dim committed R10:b6f78045a61e: Update Subversion to 1.14.1 LTS. See contrib/subversion/CHANGES for a (authored by dim).
Update Subversion to 1.14.1 LTS. See contrib/subversion/CHANGES for a
Feb 18 2021, 8:06 PM
dim committed R10:83b1614a2e39: Update Subversion to 1.14.1 LTS. See contrib/subversion/CHANGES for a (authored by dim).
Update Subversion to 1.14.1 LTS. See contrib/subversion/CHANGES for a
Feb 18 2021, 8:06 PM
dim committed R10:6287b5978c5f: Fix incorrect hypotl(3) result with subnormal numbers (authored by dim).
Fix incorrect hypotl(3) result with subnormal numbers
Feb 18 2021, 6:14 PM
dim committed R10:be49cd3ec6a5: Fix incorrect hypotl(3) result with subnormal numbers (authored by dim).
Fix incorrect hypotl(3) result with subnormal numbers
Feb 18 2021, 6:14 PM
dim committed R10:97232b0dc031: Fix incorrect hypotl(3) result with subnormal numbers (authored by dim).
Fix incorrect hypotl(3) result with subnormal numbers
Feb 18 2021, 6:13 PM

Feb 16 2021

dim added a comment to D28690: Export various 128 bit long double functions from libgcc_s.so.1.
In D28690#642826, @jhb wrote:

Don't the symbol map entries just get ignored if the symbols aren't present, so it would be ok to have these in the MI Symbol.map?

Feb 16 2021, 9:00 PM
dim committed R10:9f93bc8bfd26: Vendor import of llvm-project branch release/12.x (authored by dim).
Vendor import of llvm-project branch release/12.x
Feb 16 2021, 8:41 PM
dim committed R10:b60736ec1405: Vendor import of llvm-project main 8e464dd76bef, the last commit before (authored by dim).
Vendor import of llvm-project main 8e464dd76bef, the last commit before
Feb 16 2021, 8:21 PM

Feb 15 2021

dim accepted D28578: msun: ctanh/ctanhf: Import fix from MUSL.

LGTM, I ran make check (with LD_LIBRARY_PATH set :) ) and it worked.

Feb 15 2021, 8:53 PM
dim updated the diff for D28577: While building libm, turn off any math-related compiler builtins.

Remove the list of math builtins, and only pass -fno-builtin while
building tests for now.

Feb 15 2021, 8:44 PM
dim added a comment to D28577: While building libm, turn off any math-related compiler builtins.

Doing so for tests makes sense, but why libm itself?

This is because libm has many functions which are implemented in terms of other math functions. For instance, many functions which handle complex arguments are implemented in terms of calling the non-complex variants. E.g. csinh() calls sinh(), cosh(), sin() and cos(). In all these cases, unexpected outcomes could occur if the compiler deciders to shortcut the logic by inserting its own builtins at those call sites.

But that's legal, and if the function has different semantics than C says it should then you shouldn't be calling it that (and how is it ok to use that in the system's standard library implementation)? This feels to me like fixing the wrong problem.

I have seen some LLVM tests fail because the constant folding of math calls produces different floating point constants when the buildbot runs on different operating systems. This is unlikely to happen here, but if it does and you are compiling with a buggy host libm, you might end up creating a broken target libm.

Feb 15 2021, 8:36 PM
dim closed D11482: Make compiler-rt's quad-math routines available to libgcc_s.

Closing this in favor of D28690.

Feb 15 2021, 7:57 PM
dim requested review of D28690: Export various 128 bit long double functions from libgcc_s.so.1.
Feb 15 2021, 7:56 PM
dim committed R10:182881658138: Fix incorrect powf(3) result with x near 1 and |y| much larger than 1 (authored by Steve Kargl <sgk@troutmask.apl.washington.edu>).
Fix incorrect powf(3) result with x near 1 and |y| much larger than 1
Feb 15 2021, 6:16 PM
dim committed R10:cedb8de26ccc: Fix incorrect powf(3) result with x near 1 and |y| much larger than 1 (authored by Steve Kargl <sgk@troutmask.apl.washington.edu>).
Fix incorrect powf(3) result with x near 1 and |y| much larger than 1
Feb 15 2021, 6:14 PM
dim committed R10:720600023287: Fix incorrect powf(3) result with x near 1 and |y| much larger than 1 (authored by Steve Kargl <sgk@troutmask.apl.washington.edu>).
Fix incorrect powf(3) result with x near 1 and |y| much larger than 1
Feb 15 2021, 6:14 PM

Feb 13 2021

dim committed R10:0ff101494489: Update Subversion to 1.14.1 LTS. See contrib/subversion/CHANGES for a (authored by dim).
Update Subversion to 1.14.1 LTS. See contrib/subversion/CHANGES for a
Feb 13 2021, 1:41 PM
dim committed R10:8f67d37de16f: Vendor import svn-1.14.1. (authored by dim).
Vendor import svn-1.14.1.
Feb 13 2021, 1:05 PM

Feb 12 2021

dim committed R10:ca9df934a552: test_inf_inputs: Use atf_tc_expect_fail() instead of atf_tc_skip() (authored by arichardson).
test_inf_inputs: Use atf_tc_expect_fail() instead of atf_tc_skip()
Feb 12 2021, 8:58 PM
dim committed R10:f2a88e744701: test_inf_inputs: Use atf_tc_expect_fail() instead of atf_tc_skip() (authored by arichardson).
test_inf_inputs: Use atf_tc_expect_fail() instead of atf_tc_skip()
Feb 12 2021, 8:57 PM
dim committed R10:5bc11b95b87c: test_inf_inputs: Use atf_tc_expect_fail() instead of atf_tc_skip() (authored by dim).
test_inf_inputs: Use atf_tc_expect_fail() instead of atf_tc_skip()
Feb 12 2021, 8:57 PM

Feb 11 2021

dim committed R10:251206622844: Fix lib/msun/test builds on platforms without 80-bit long doubles (authored by dim).
Fix lib/msun/test builds on platforms without 80-bit long doubles
Feb 11 2021, 11:03 AM

Feb 10 2021

dim committed R10:d3338f3355a6: Fix incorrect hypotl(3) result with subnormal numbers (authored by dim).
Fix incorrect hypotl(3) result with subnormal numbers
Feb 10 2021, 10:31 PM