Page MenuHomeFreeBSD

dim (Dimitry Andric)
User

Projects (2)

User Details

User Since
Jan 7 2014, 10:13 PM (668 w, 6 d)

Recent Activity

Thu, Oct 29

dim committed rG6a936d939b88: Merge commit 4d7292e58078 from llvm-project (by Minsoo Choo):.
Thu, Oct 29, 8:48 AM
dim committed rG28ec7cb8712f: Merge commit fd4113508a64 from llvm-project (by Minsoo Choo):.
Thu, Oct 29, 8:48 AM

Sat, Oct 17

dim committed rG025393b094fd: Merge commit a5fa4dba6e2e from llvm-project (by PiJoules):.
Sat, Oct 17, 10:22 AM
dim committed rG1abf88da874c: Merge commit 681c2ee4dfbf from llvm-project (by Justin King):.
Sat, Oct 17, 10:22 AM
dim committed rGaabb358e779c: compiler-rt: enable use of .preinit_array after ef758b59a44e.
Sat, Oct 17, 10:22 AM
dim committed rGd526521ef519: Merge commit a5fa4dba6e2e from llvm-project (by PiJoules):.
Sat, Oct 17, 10:22 AM
dim committed rG4192a88ff521: Merge commit 681c2ee4dfbf from llvm-project (by Justin King):.
Sat, Oct 17, 10:22 AM
dim committed rG37eb7f26891b: compiler-rt: enable use of .preinit_array after ef758b59a44e.
Sat, Oct 17, 10:22 AM

Thu, Oct 15

dim accepted D60747: lldb: Allow building on riscv.

LGTM

Thu, Oct 15, 4:26 PM

Sat, Oct 10

dim committed rG000856156745: compiler-rt: enable use of .preinit_array after ef758b59a44e.
Sat, Oct 10, 10:45 PM
dim committed rGa3fbf20c0558: Merge commit a5fa4dba6e2e from llvm-project (by PiJoules):.
Sat, Oct 10, 10:45 PM
dim committed rG6b0f64133cd9: Merge commit 681c2ee4dfbf from llvm-project (by Justin King):.
Sat, Oct 10, 10:45 PM
dim accepted D60588: rtld: release rtld_bind_lock around calls to .preinit_array initializers.

LGTM, thanks!

Sat, Oct 10, 4:43 PM

Wed, Oct 7

dim committed rGb259c7f6e9ec: Merge commit c52392a6f464 from llvm-project (by ShengYi Hung):.
Wed, Oct 7, 5:21 PM
dim committed rGb9180c09cb19: Merge commit c52392a6f464 from llvm-project (by ShengYi Hung):.
Wed, Oct 7, 5:21 PM

Tue, Oct 6

dim committed rGbceab8be408d: llvm: add LoongArch target support, not enabled by default (authored by zhaoxiaoqiang007_gmail.com).
Tue, Oct 6, 4:40 PM
dim committed rGfb099c133cae: Merge commit c4ce37507537 from llvm-project (by ShengYi Hung):.
Tue, Oct 6, 4:39 PM
dim committed rG3108ab674752: Merge commit 80e8c0a59189 from llvm-project (by ShengYi Hung):.
Tue, Oct 6, 4:39 PM
dim committed rG0c409a56237a: Merge commit c4ce37507537 from llvm-project (by ShengYi Hung):.
Tue, Oct 6, 4:39 PM
dim committed rG8b754816e803: llvm: add LoongArch target support, not enabled by default (authored by zhaoxiaoqiang007_gmail.com).
Tue, Oct 6, 4:39 PM
dim committed rGafc8c5f9fd73: Merge commit 80e8c0a59189 from llvm-project (by ShengYi Hung):.
Tue, Oct 6, 4:39 PM

Oct 3 2026

dim committed rGfe9c7137871e: Merge commit c4ce37507537 from llvm-project (by ShengYi Hung):.
Oct 3 2026, 11:38 AM

Oct 1 2026

dim committed rG74152f84fa4c: llvm: remove Mips target support.
Oct 1 2026, 6:31 PM
dim committed rGc93b5126130a: llvm: remove Mips target support.
Oct 1 2026, 6:28 PM
dim committed rG37c9eba1644b: Merge commit 80e8c0a59189 from llvm-project (by ShengYi Hung):.
Oct 1 2026, 12:32 PM

Sep 30 2026

dim committed rGca3747034ef4: Merge commit c52392a6f464 from llvm-project (by ShengYi Hung):.
Sep 30 2026, 4:33 PM

Sep 28 2026

dim committed rG2f49e40a684a: llvm: add LoongArch target support, not enabled by default (authored by zhaoxiaoqiang007_gmail.com).
Sep 28 2026, 4:14 PM
dim closed D59899: clang: enable the LoongArch target in in-tree llvm builds.
Sep 28 2026, 4:13 PM
dim accepted D59899: clang: enable the LoongArch target in in-tree llvm builds.

I will commit this with a few small changes.

Sep 28 2026, 3:15 PM

Sep 24 2026

dim added a comment to D59899: clang: enable the LoongArch target in in-tree llvm builds.

I just removed the remnants of the Mips target in rGb5d1e0c5a4929e2be3bc58aad8e5b707860ec0fd, please rebase.

Sep 24 2026, 2:10 PM
dim committed rGb5d1e0c5a492: llvm: remove Mips target support.
Sep 24 2026, 12:51 PM

Sep 23 2026

dim committed rG26e90d2d2892: Fix statement with no effect in linuxkpi's xarray.h.
Sep 23 2026, 10:25 AM
dim committed rG82d6bd170fa5: Fix statement with no effect in linuxkpi's xarray.h.
Sep 23 2026, 10:24 AM

Sep 22 2026

dim added a comment to D59899: clang: enable the LoongArch target in in-tree llvm builds.

I'm generally fine with this, but it is there a concrete plan to add LoongArch support for the base system? Otherwise I would advise to use one of the llvm ports for bringup first.

Sep 22 2026, 3:36 PM

Sep 20 2026

dim added inline comments to D56616: Add ipfw 32-bit KBI detection via ophandler version .
Sep 20 2026, 7:35 PM
dim added inline comments to D56616: Add ipfw 32-bit KBI detection via ophandler version .
Sep 20 2026, 7:34 PM
dim added a comment to D59838: amd64/*sigtramp.S: re-enable some cfi annotations for special registers.
In D59838#1373575, @kib wrote:

...

This is unfortunate. But do we need to care about so old llvms? llvm15 sounds esp. odd, I suspect that the web page is quite outdated.

From what I see in Github workflows, we use clang15 for Ubuntu 22.04 cross compilation, so this will break CI without retiring clang15 workflow beforehand. I think we should ask srcmgr@ to approve removing llvm15 support first.

Sep 20 2026, 7:10 PM
dim committed rGa0bb961dde2f: kern.mk: make clang 23 -Wunused-but-set-global non-fatal.
Sep 20 2026, 7:05 AM
dim committed rG6fa06708dee9: bsd.sys.mk: make clang 23 -Wunused-but-set-global non-fatal.
Sep 20 2026, 7:05 AM
dim committed rG1aea303cc2e8: Merge commit 1f332ae4f1b3 from llvm-project (by Alexander Kornienko):.
Sep 20 2026, 7:05 AM
dim committed rGecf568607e91: kern.mk: make clang 23 -Wunused-but-set-global non-fatal.
Sep 20 2026, 7:05 AM
dim committed rG4cff1ab17352: bsd.sys.mk: make clang 23 -Wunused-but-set-global non-fatal.
Sep 20 2026, 7:05 AM
dim committed rG672f2c50d516: Merge commit 1f332ae4f1b3 from llvm-project (by Alexander Kornienko):.
Sep 20 2026, 7:05 AM
dim closed D59787: Fix statement with no effect in linuxkpi's xarray.h.
Sep 20 2026, 7:03 AM
dim committed rGaca53fc2a687: Fix statement with no effect in linuxkpi's xarray.h.
Sep 20 2026, 7:03 AM

Sep 18 2026

dim added reviewers for D59787: Fix statement with no effect in linuxkpi's xarray.h: dumbbell, jhb, imp, wulf.
Sep 18 2026, 7:21 AM
dim requested review of D59787: Fix statement with no effect in linuxkpi's xarray.h.
Sep 18 2026, 7:20 AM

Sep 17 2026

dim committed rGbcd0d76d4882: kern.mk: make clang 23 -Wunused-but-set-global non-fatal.
Sep 17 2026, 7:38 PM
dim committed rGd577b4ed588c: bsd.sys.mk: make clang 23 -Wunused-but-set-global non-fatal.
Sep 17 2026, 7:37 PM
dim committed rG8a8c14464dd3: Merge commit 1f332ae4f1b3 from llvm-project (by Alexander Kornienko):.
Sep 17 2026, 7:37 PM

Aug 31 2026

dim committed R11:bdc97c5f533d: converters/dos2unix: update to 7.5.7.
Aug 31 2026, 10:33 AM
dim committed R11:aa43c8aa348c: converters/dos2unix: update to 7.5.7.
Aug 31 2026, 10:32 AM
dim added a comment to D59277: inetd: only declare and use the mapped-address netconfig under INET6.

How did you produce the warning? I don't see it when building inetd. In any case, I think it would be better to only declare and use nbuf2 and netid2 if INET6 is defined. This way you can avoid the warning, and no unused data is allocated or used.

Aug 31 2026, 8:02 AM · Contributor Reviews (src)

Aug 22 2026

dim committed R11:15b81f75efd6: lang/gcc17-devel: fix build after base d08296c7ab0d.
Aug 22 2026, 10:26 PM
dim committed R11:1821f6c6af02: lang/gcc16-devel: fix build after base d08296c7ab0d.
Aug 22 2026, 10:26 PM
dim committed R11:e0d140aa6bc2: lang/gcc16: fix build after base d08296c7ab0d.
Aug 22 2026, 10:26 PM
dim committed R11:97556512d21c: lang/gcc15-devel: fix build after base d08296c7ab0d.
Aug 22 2026, 10:26 PM
dim committed R11:096369a791fb: lang/gcc17-devel: fix build after base d08296c7ab0d.
Aug 22 2026, 10:24 PM
dim committed R11:4e5276e13473: lang/gcc16-devel: fix build after base d08296c7ab0d.
Aug 22 2026, 10:24 PM
dim committed R11:19c6e313dc8d: lang/gcc16: fix build after base d08296c7ab0d.
Aug 22 2026, 10:24 PM
dim committed R11:da442d3a3e2b: lang/gcc15-devel: fix build after base d08296c7ab0d.
Aug 22 2026, 10:23 PM

Aug 18 2026

dim accepted D58911: libc: Restore prior C23 include guards.

LGTM, thanks!

Aug 18 2026, 5:54 PM

Aug 17 2026

dim committed R11:6b50d7083e32: lang/gcc15: fix build after base d08296c7ab0d.
Aug 17 2026, 7:45 PM
dim committed R11:955eda5e75ec: lang/gcc15: fix build after base d08296c7ab0d.
Aug 17 2026, 7:42 PM
dim committed R11:011dee72e13f: math/gmp: fix build after base cd0727ec709b.
Aug 17 2026, 7:41 PM
dim committed R11:03ce372d3e18: math/gmp: fix build after base cd0727ec709b.
Aug 17 2026, 7:40 PM

Aug 14 2026

dim updated subscribers of D58824: ossl: fix OPENSSL_ia32cap_P size mismatch on i386/amd64.

Ok, the original ossl.c with this OPENSSL_ia32cap_P definition was added by @jhb in rGba610be90a7cb6d851e0e0e6d7612769352a3c0c. This was in 2020, so maybe OPENSSL_ia32cap_P was indeed 4. The code in ossl_cpuid() only accesses OPENSSL_ia32cap_P[0] through OPENSSL_ia32cap_P[3], not anything beyond it.

Aug 14 2026, 7:34 PM

Aug 13 2026

dim updated subscribers of D58824: ossl: fix OPENSSL_ia32cap_P size mismatch on i386/amd64.

The code in sys/crypto/openssl/ossl_x86.c got moved around by @mhorne in rGfd86ae6800383dabe050e22176783857895800e3, maybe Mitchell has opinions about this too.

Aug 13 2026, 6:38 PM
dim added a comment to D58824: ossl: fix OPENSSL_ia32cap_P size mismatch on i386/amd64.

Indeed, the assembly in crypto/openssl/crypto/x86_64cpuid.pl has:

Aug 13 2026, 6:36 PM

Jul 28 2026

dim accepted D58494: m4: Const correctness for C23.

LGTM

Jul 28 2026, 5:25 PM
dim accepted D58497: libelftc: Const correctness for C23.

LGTM

Jul 28 2026, 5:25 PM
dim added a reverting change for rG33175a505997: Add a few missed files to ObsoleteFiles.inc: rG470238401081: Revert "Add a few missed files to ObsoleteFiles.inc".
Jul 28 2026, 1:07 PM
dim committed rG470238401081: Revert "Add a few missed files to ObsoleteFiles.inc".
Jul 28 2026, 1:07 PM
dim added a reverting change for rG2e089a89812b: Add a few missed files to ObsoleteFiles.inc: rGd4b36d6b1838: Revert "Add a few missed files to ObsoleteFiles.inc".
Jul 28 2026, 1:07 PM
dim committed rGd4b36d6b1838: Revert "Add a few missed files to ObsoleteFiles.inc".
Jul 28 2026, 1:07 PM

Jul 16 2026

dim committed rG33175a505997: Add a few missed files to ObsoleteFiles.inc.
Jul 16 2026, 8:04 PM
dim committed rG2e089a89812b: Add a few missed files to ObsoleteFiles.inc.
Jul 16 2026, 6:33 PM

Jul 13 2026

dim committed R11:9a9a55ba2be8: devel/cvise: make it build with DEFAULT_VERSIONS+=llvm=22.
Jul 13 2026, 6:15 PM
dim committed R11:358f3c706f39: devel/cvise: make it build with DEFAULT_VERSIONS+=llvm=22.
Jul 13 2026, 6:12 PM

Jul 12 2026

dim committed rGf72cfefae99b: Add a few missed files to ObsoleteFiles.inc.
Jul 12 2026, 2:16 PM

Jul 10 2026

dim accepted D58155: build: Retire LLVM_COV src.conf knob.

LGTM. Good riddance. :)

Jul 10 2026, 3:11 PM

Jul 6 2026

dim accepted D58044: libllvmminimal: Fix building with LLVM < 21 on riscv64.

LGTM

Jul 6 2026, 6:47 AM

Jun 24 2026

dim accepted D57822: libcxxrt: Fix diagnostics for derived classes.

Hm, I remember something similar occurring when I was attempting to debug that std::ios ABI issue. This would also throw some exceptions during initialization, and it resulted in strange messages from libcxxrt. I didn't have the time then to investigate, but it could very well have been this issue.!

Jun 24 2026, 5:01 PM

Jun 21 2026

dim added a comment to D57721: zfs: drop duplicate vfs.zfs.metaslab.condense_pct sysctl.

Hm, I thought this was fixed by @mm's rGb1b4871f373e9f2a5defdc1242543be291f5e9d9, but apparently not:

Jun 21 2026, 11:53 AM

Jun 16 2026

dim committed rGf81c82a9db12: Merge commit 93a67259cf23 from llvm git (by ShengYi Hung):.
Jun 16 2026, 5:02 PM
dim committed rG8d0154e64186: Merge commit 93a67259cf23 from llvm git (by ShengYi Hung):.
Jun 16 2026, 5:02 PM

Jun 13 2026

dim committed rG2b619b7c7b53: Merge commit 93a67259cf23 from llvm git (by ShengYi Hung):.
Jun 13 2026, 10:06 AM
dim accepted D57549: rtld parse_integer(): support octal and hex C notations.

LGTM.

Jun 13 2026, 9:28 AM

Jun 4 2026

dim committed rG2cdb0c07e25b: Merge commit 63c29df8eceb from llvm git (by Dmitry Polukhin):.
Jun 4 2026, 8:21 AM
dim committed rGa8e709c66769: Merge commit 63c29df8eceb from llvm git (by Dmitry Polukhin):.
Jun 4 2026, 8:21 AM

Jun 3 2026

dim committed R11:fc2af4915915: converters/dos2unix: update to 7.5.6.
Jun 3 2026, 6:34 PM
dim committed R11:edd93c216d8d: converters/dos2unix: update to 7.5.6.
Jun 3 2026, 6:32 PM

Jun 1 2026

dim added a comment to D57388: powerpc64le: switch long double to IEEE binary128.

I think it would be useful if you could upstream the clang and compiler-rt parts of this. Otherwise it becomes a bit of a drag when updating to new versions.

Jun 1 2026, 7:27 PM
dim committed rG86326398b73b: Merge commit 63c29df8eceb from llvm git (by Dmitry Polukhin):.
Jun 1 2026, 5:14 PM

May 31 2026

dim committed R11:8d45f0429eb4: graphics/mesa-dri: fix builds against llvm 20 and 21.
May 31 2026, 2:50 PM
dim committed R11:e45b1bd3027b: graphics/mesa-dri: fix builds against llvm 20 and 21.
May 31 2026, 2:49 PM

May 30 2026

dim committed rG7f421c7c9c1a: bsd.sys.mk: also suppress gcc -Wc++1[47]-extensions warnings for >= 12.
May 30 2026, 4:06 PM

May 29 2026

dim committed R9:c02973272812: Document __FreeBSD_version values 1404500, 1404501, 1501500, and 1501501..
May 29 2026, 11:21 PM
dim added a reverting change for rG00bee6fcd77f: Partially revert libc++ commit aa7f377c965c, restoring stdint.h: rG8bf73434e81c: Revert 00bee6fcd77f, which partially reverted libc++ commit aa7f377c965c.
May 29 2026, 11:13 PM
dim committed rGec6797818bf2: Fix up builds on Linux hosts after llvm 21.1.8 merge.
May 29 2026, 11:13 PM