Page MenuHomeFreeBSD

dim (Dimitry Andric)
User

Projects

User Details

User Since
Jan 7 2014, 10:13 PM (360 w, 1 d)

Recent Activity

Yesterday

dim committed rS368286: MFC r367809:.
MFC r367809:
Wed, Dec 2, 9:44 PM
dim committed rS368285: MFC r367304:.
MFC r367304:
Wed, Dec 2, 9:40 PM

Mon, Nov 30

dim committed rS368192: Add a few missed entries to ObsoleteFiles.inc:.
Add a few missed entries to ObsoleteFiles.inc:
Mon, Nov 30, 7:19 PM

Wed, Nov 25

dim accepted D27366: clang: allow -fstack-clash-protection on FreeBSD.

Yeah, that seems perfectly OK to me.

Wed, Nov 25, 12:58 PM

Wed, Nov 18

dim committed rS367815: For llvm's internal function which retrieves the number of available.
For llvm's internal function which retrieves the number of available
Wed, Nov 18, 7:55 PM
dim committed rS367809: When elftoolchain's objcopy (or strip) is rewriting a file in-place,.
When elftoolchain's objcopy (or strip) is rewriting a file in-place,
Wed, Nov 18, 6:41 PM

Tue, Nov 17

dim added a comment to D27240: [zfs] Fix LZ4 function definitions to not trip up the compile.

Apparently for me, _FAKE_KERNEL just never gets defined, so that part of the code never gets compiled. I have no idea where that define comes from. In the preprocessed lz4.i I simply do not see the offending code fragment at all.

Tue, Nov 17, 6:11 PM
dim added a comment to D27240: [zfs] Fix LZ4 function definitions to not trip up the compile.

How did this work for anyone? I tripped on it in CheriBSD on aarch64 just now (this is with llvm ~11.0.0).

Tue, Nov 17, 6:02 PM

Sun, Nov 15

dim committed rS367712: Ensure make delete-old does not unlink the llvm-cxxfilt and its manpage,.
Ensure make delete-old does not unlink the llvm-cxxfilt and its manpage,
Sun, Nov 15, 10:50 PM
dim committed rS367704: MFC r367623:.
MFC r367623:
Sun, Nov 15, 11:28 AM

Thu, Nov 12

dim committed rS367623: Merge commit 8df4e6094 from llvm git (by Fangrui Song):.
Merge commit 8df4e6094 from llvm git (by Fangrui Song):
Thu, Nov 12, 7:25 PM

Wed, Nov 11

dim committed rS367603: MFC r367485:.
MFC r367485:
Wed, Nov 11, 10:18 PM
dim committed rS367602: MFC r366683:.
MFC r366683:
Wed, Nov 11, 10:16 PM

Sun, Nov 8

dim committed rS367485: Merge commit 354d3106c from llvm git (by Kai Luo):.
Merge commit 354d3106c from llvm git (by Kai Luo):
Sun, Nov 8, 2:49 PM
dim committed rS367467: MFC r367323:.
MFC r367323:
Sun, Nov 8, 12:01 AM

Sat, Nov 7

dim committed rS367466: Sync up elftoolchain with head, except for the capsicum-related commits,.
Sync up elftoolchain with head, except for the capsicum-related commits,
Sat, Nov 7, 11:58 PM
dim committed rS367463: MFC r367323:.
MFC r367323:
Sat, Nov 7, 7:57 PM
dim committed rS367462: Sync up elftoolchain with head, except for the capsicum-related commits,.
Sync up elftoolchain with head, except for the capsicum-related commits,
Sat, Nov 7, 7:55 PM
dim committed rS367458: MFC r340385 (by emaste):.
MFC r340385 (by emaste):
Sat, Nov 7, 6:15 PM
dim committed rS367457: MFC r344855 (by jhb):.
MFC r344855 (by jhb):
Sat, Nov 7, 6:12 PM
dim accepted D27134: makeman: Don't require filemon with MK_DIRDEPS_BUILD..

I've been using this for a while already, since otherwise makeman fails for me. :)

Sat, Nov 7, 5:31 PM

Thu, Nov 5

dim committed rP554138: MFH: r554081.
MFH: r554081
Thu, Nov 5, 4:19 PM

Wed, Nov 4

dim committed rS367337: Make vector-related functions in libcxxrt's demangler static.
Make vector-related functions in libcxxrt's demangler static
Wed, Nov 4, 5:52 PM
dim committed rP554081: devel/binutils: Apply upstream patch to fix "undefined symbol:.
devel/binutils: Apply upstream patch to fix "undefined symbol:
Wed, Nov 4, 2:21 PM
dim committed rS367324: Turn on WITH_LLVM_CXXFILT by default.
Turn on WITH_LLVM_CXXFILT by default
Wed, Nov 4, 11:23 AM
dim committed rS367323: Update libcxxrt's private copy of elftoolchain demangler.
Update libcxxrt's private copy of elftoolchain demangler
Wed, Nov 4, 11:13 AM
dim abandoned D27058: Improve libelftc's C++ demangler robustness.
Wed, Nov 4, 11:09 AM
dim committed rS367322: Merge elftoolchain r3877 (by jkoshy):.
Merge elftoolchain r3877 (by jkoshy):
Wed, Nov 4, 11:02 AM

Tue, Nov 3

dim closed D27071: Add WITH_LLVM_CXXFILT option to install llvm-cxxfilt as c++filt.
Tue, Nov 3, 7:57 PM
dim committed rS367304: Add WITH_LLVM_CXXFILT option to install llvm-cxxfilt as c++filt.
Add WITH_LLVM_CXXFILT option to install llvm-cxxfilt as c++filt
Tue, Nov 3, 7:57 PM

Nov 2 2020

dim added a comment to D27071: Add WITH_LLVM_CXXFILT option to install llvm-cxxfilt as c++filt.
In D27071#604022, @yuri wrote:

Should `MK_LLVM_CXXFILT``` be made a default since it leads to a more stable c++filt?

Nov 2 2020, 10:03 PM
dim requested review of D27071: Add WITH_LLVM_CXXFILT option to install llvm-cxxfilt as c++filt.
Nov 2 2020, 9:28 PM
dim requested review of D27059: Sync libcxxrt demangler with libelftc plus fixes.
Nov 2 2020, 6:30 PM
dim requested review of D27058: Improve libelftc's C++ demangler robustness.
Nov 2 2020, 6:12 PM

Oct 31 2020

dim committed rS367228: MFC r364480:.
MFC r364480:
Oct 31 2020, 6:42 PM

Oct 25 2020

dim added inline comments to D26942: Replace literal uses of /usr/local with a macro defined in paths.h.
Oct 25 2020, 1:49 PM

Oct 22 2020

dim accepted D26902: Key decleration of union semun on src version.

Yes, I agree. __FreeBSD__ is mostly to be used for "am I on FreeBSD at all" checks, that it has a major version in it is maybe a little misleading. The only disadvantage of __FreeBSD_version is that you have to include <osreldate.h> at least.

Oct 22 2020, 8:12 PM
dim added a comment to D26902: Key decleration of union semun on src version.

This could also be fixed by consistently setting the -target flag when building sources. For instance, on stable/12 the default (x86_64-unknown-freebsd12.2 in my case) gives:

Oct 22 2020, 6:19 PM

Oct 19 2020

dim accepted D26751: Significantly reduce compile time for googletest internal tests.

Might as well go full -O0. :)

Oct 19 2020, 7:17 PM

Oct 16 2020

dim accepted D26817: cdefs.h: remove intel_compiler support.

While the Intel compiler support was an interesting addition in the past, it is long overdue to clean it up. Less code in cdefs.h is better! :)

Oct 16 2020, 10:51 PM
dim accepted D26774: [llvm] Use 32 bit atomic on freebsd mips.

I think this is fine for now. Upstream will want to centralize the define somewhere in __config, but we can take that discussion there.

Oct 16 2020, 6:58 PM

Oct 13 2020

dim committed rS366683: Merge commit 35ecc7fe4 from llvm git (by Hubert Tong):.
Merge commit 35ecc7fe4 from llvm git (by Hubert Tong):
Oct 13 2020, 7:43 PM

Oct 12 2020

dim committed rS366654: Tag llvm-project branch release/11.x llvmorg-11.0.0-0-g176249bd673 (aka.
Tag llvm-project branch release/11.x llvmorg-11.0.0-0-g176249bd673 (aka
Oct 12 2020, 9:37 PM
dim committed rS366655: Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp.
Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp
Oct 12 2020, 9:36 PM
dim committed rS366653: Vendor import of llvm-project branch release/11.x.
Vendor import of llvm-project branch release/11.x
Oct 12 2020, 9:31 PM
dim accepted D26623: Enable SUBDIR_PARELLEL in lib/libclang_rt.

Ah yes, this is OK. There's probably some more optimization possible, since these libraries build lots of duplicated object files, but I haven't had the time to look at that yet.

Oct 12 2020, 10:39 AM

Oct 8 2020

dim committed rP551735: MFH: r551655.
MFH: r551655
Oct 8 2020, 9:35 PM

Oct 7 2020

dim committed rP551655: Create dedicated sandbox user for wsdd service.
Create dedicated sandbox user for wsdd service
Oct 7 2020, 5:14 PM

Oct 5 2020

dim committed rS366452: Merge commit 0fac1c191 from llvm git (by Craig Topper):.
Merge commit 0fac1c191 from llvm git (by Craig Topper):
Oct 5 2020, 6:09 PM

Oct 1 2020

dim committed rS366339: Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp.
Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp
Oct 1 2020, 7:06 PM
dim committed rS366334: Tag llvm-project branch release/11.x llvmorg-11.0.0-rc5-0-g60a25202a7d..
Tag llvm-project branch release/11.x llvmorg-11.0.0-rc5-0-g60a25202a7d.
Oct 1 2020, 5:59 PM
dim committed rS366333: Vendor import of llvm-project branch release/11.x.
Vendor import of llvm-project branch release/11.x
Oct 1 2020, 5:48 PM

Sep 17 2020

dim committed rS365849: Merge commit 46673763f from llvm git (by Craig Topper):.
Merge commit 46673763f from llvm git (by Craig Topper):
Sep 17 2020, 7:48 PM
dim committed rS365848: Merge commit e09107ab8 from llvm git (by Raul Tambre):.
Merge commit e09107ab8 from llvm git (by Raul Tambre):
Sep 17 2020, 7:43 PM

Sep 16 2020

dim committed rS365807: Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp.
Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp
Sep 16 2020, 4:59 PM

Sep 15 2020

dim committed rS365758: Tag llvm-project branch release/11.x llvmorg-11.0.0-rc2-91-g6e042866c30..
Tag llvm-project branch release/11.x llvmorg-11.0.0-rc2-91-g6e042866c30.
Sep 15 2020, 7:04 PM
dim committed rD54496: Replace accidentally double pasted 'after'..
Replace accidentally double pasted 'after'.
Sep 15 2020, 7:02 PM
dim committed rS365757: Vendor import of llvm-project branch release/11.x.
Vendor import of llvm-project branch release/11.x
Sep 15 2020, 6:56 PM

Sep 14 2020

dim committed rS365722: MF12 r365662:.
MF12 r365662:
Sep 14 2020, 2:53 PM
dim committed rS365721: MF12 r365661:.
MF12 r365661:
Sep 14 2020, 2:52 PM

Sep 12 2020

dim committed rS365672: Follow-up r365662 (MFC of r365371 and r365373) by also removing the.
Follow-up r365662 (MFC of r365371 and r365373) by also removing the
Sep 12 2020, 8:21 PM
dim committed rS365671: Follow-up r365662 (MFC of r365371 and r365373) by correctly setting.
Follow-up r365662 (MFC of r365371 and r365373) by correctly setting
Sep 12 2020, 7:40 PM
dim committed rS365662: MFC r365371:.
MFC r365371:
Sep 12 2020, 4:50 PM
dim committed rS365661: MFC r364753:.
MFC r364753:
Sep 12 2020, 4:33 PM

Sep 10 2020

dim committed rS365588: Follow-up r364753 by only using arm's stdatomic.c implementation, as it.
Follow-up r364753 by only using arm's stdatomic.c implementation, as it
Sep 10 2020, 4:47 PM

Sep 9 2020

dim committed rS365509: Follow-up r364753 by enabling compiler-rt's atomic implementation only.
Follow-up r364753 by enabling compiler-rt's atomic implementation only
Sep 9 2020, 8:49 PM
dim committed rS365507: Merge commit e6bb4c8e7 from llvm git (by Craig Topper):.
Merge commit e6bb4c8e7 from llvm git (by Craig Topper):
Sep 9 2020, 6:11 PM
dim added a comment to D26044: Stop using lorder and ranlib when building libraries.

@arichardson I'm not sure that is enough, there might be ports that include bsd.lib.mk from Makefiles in their respective tarballs.

The number of ports affected might be smaller than I thought though, I thought this was used for basically anything that's being linked on FreeBSD, but bsd.lib.mk isn't used in the ports infra (in ports/Mk/), which I thought was the case.

Sep 9 2020, 11:41 AM

Sep 8 2020

dim committed rS365472: Revert r365471 as it is breaking with old gcc on various arches:.
Revert r365471 as it is breaking with old gcc on various arches:
Sep 8 2020, 8:28 PM
dim committed rD54470: Document __FreeBSD_version values 1104505, 1104506, 1201523, 1201524,.
Document __FreeBSD_version values 1104505, 1104506, 1201523, 1201524,
Sep 8 2020, 8:18 PM
dim committed rS365471: MFC r364753:.
MFC r364753:
Sep 8 2020, 8:02 PM

Sep 7 2020

dim committed rS365430: MFC r365429:.
MFC r365429:
Sep 7 2020, 8:17 PM
dim committed rS365429: Merge commit 47b0262d3 from llvm git (by me):.
Merge commit 47b0262d3 from llvm git (by me):
Sep 7 2020, 8:10 PM
dim committed rS365427: MFC r364732:.
MFC r364732:
Sep 7 2020, 7:35 PM
dim committed rS365426: MFC r364081:.
MFC r364081:
Sep 7 2020, 7:29 PM
dim accepted D26339: imgact_elf.c: unify check for phdr fitting into the first page.
Sep 7 2020, 7:06 PM
dim accepted D26351: rtld: pass argc/argv/env to dso inits..

LGTM, I don't see any downsides. I sort of feel like it's asymmetric that the arguments aren't passed to the fini functions, but glibc also doesn't do that. :)

Sep 7 2020, 6:49 PM

Sep 6 2020

dim committed rS365373: Follow-up r365371 by removing sentences which indicate the state of the.
Follow-up r365371 by removing sentences which indicate the state of the
Sep 6 2020, 9:08 AM

Sep 5 2020

dim committed rS365371: Turn MALLOC_PRODUCTION into a regular src.conf(5) option.
Turn MALLOC_PRODUCTION into a regular src.conf(5) option
Sep 5 2020, 11:30 PM
dim closed D26337: Turn MALLOC_PRODUCTION into a regular src.conf(5) option.
Sep 5 2020, 11:30 PM
dim accepted D26339: imgact_elf.c: unify check for phdr fitting into the first page.

LGTM, nice catch!

Sep 5 2020, 7:16 PM
dim requested review of D26337: Turn MALLOC_PRODUCTION into a regular src.conf(5) option.
Sep 5 2020, 3:49 PM
dim accepted D26044: Stop using lorder and ranlib when building libraries.

LGTM. We can even MFC this.

Sep 5 2020, 2:56 PM

Sep 4 2020

dim added inline comments to D26323: rtld: Handle ELF dso with program headers outside the first page..
Sep 4 2020, 10:28 PM
dim added inline comments to D26323: rtld: Handle ELF dso with program headers outside the first page..
Sep 4 2020, 9:09 PM
dim accepted D26323: rtld: Handle ELF dso with program headers outside the first page..

LGTM. It works for me with the libwidevinecdm.so from the PR. I tried to generate an .so with weird phdrs using patchelf, but that didn't work. Not sure if there are other such tools...

Sep 4 2020, 8:50 PM

Sep 3 2020

dim committed rS365307: Merge commit f26fc568402f from llvm git (by me):.
Merge commit f26fc568402f from llvm git (by me):
Sep 3 2020, 6:34 PM
dim committed rS365306: Add a few more files to libllvm, which are required when doing sanitized.
Add a few more files to libllvm, which are required when doing sanitized
Sep 3 2020, 6:27 PM
dim committed rS365305: Ensure zpool-features(5) doesn't get removed by make delete-old..
Ensure zpool-features(5) doesn't get removed by make delete-old.
Sep 3 2020, 6:22 PM

Aug 31 2020

dim accepted D26257: Suppress -Wempty-body warnings in GCC 6.x and later..

This is fine. I understood there are some libc++ headers that do just ; as the body for something, and that triggers it.

Aug 31 2020, 9:08 PM

Aug 26 2020

dim updated subscribers of D26199: GCC 9 require builtins from libcompiler_rt for i386 rtld..

Which builtins are those? As far as I know with rtld we should be careful not to just pull in external dependencies. @kib is usually guarding against that sort of stuff. :)

Aug 26 2020, 7:05 PM

Aug 25 2020

dim abandoned D21167: LLVM: Enable OpenMP on aarch64.

Thanks for this review, it's now effectively enabled via rS364732 for the change that went into upstream, and rS364733 to change src.opts.mk.

Aug 25 2020, 8:15 PM · arm64
dim commandeered D21167: LLVM: Enable OpenMP on aarch64.
Aug 25 2020, 8:14 PM · arm64
dim committed rS364784: After r364423, which ensures the callbacks that dl_iterate_phdr(3).
After r364423, which ensures the callbacks that dl_iterate_phdr(3)
Aug 25 2020, 8:07 PM
dim committed rS364782: After r364753, there should be no need to suppress -Watomic-alignment.
After r364753, there should be no need to suppress -Watomic-alignment
Aug 25 2020, 7:59 PM
dim committed rD54438: Document __FreeBSD_version values 1300112 and 1300113..
Document __FreeBSD_version values 1300112 and 1300113.
Aug 25 2020, 11:14 AM
dim added inline comments to rS364753: Add atomic and bswap functions to libcompiler_rt.
Aug 25 2020, 10:15 AM
dim added inline comments to rS364753: Add atomic and bswap functions to libcompiler_rt.
Aug 25 2020, 8:02 AM
dim closed D26159: Add atomic and bswap functions to libcompiler_rt.
Aug 25 2020, 6:49 AM
dim committed rS364753: Add atomic and bswap functions to libcompiler_rt.
Add atomic and bswap functions to libcompiler_rt
Aug 25 2020, 6:49 AM