dim (Dimitry Andric)
User

Projects

User Details

User Since
Jan 7 2014, 10:13 PM (201 w, 4 d)

Recent Activity

Today

dim accepted D13156: Remove hacks to support lint from system headers and MD x86 headers..

LGTM

Sun, Nov 19, 3:32 PM

Mon, Nov 13

dim added a comment to D12912: Don't fail the build due to clang integer constant range warnings.

I wouldn't put it in this place, but a little higher, where the different WARNS levels are handled. For example, you might want to suppress these for WARNS <= 3. E.g., in the block:

.if ${WARNS} <= 3
CWARNFLAGS.clang+=      -Wno-tautological-compare -Wno-unused-value\
                -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion
.if ${COMPILER_TYPE} == "clang" && ${COMPILER_VERSION} >= 30600
CWARNFLAGS.clang+=      -Wno-unused-local-typedef
.endif
.if ${COMPILER_TYPE} == "clang" && ${COMPILER_VERSION} >= 40000
CWARNFLAGS.clang+=      -Wno-address-of-packed-member
.endif
.endif # WARNS <= 3

add a new stanza for 60000 and higher.

Mon, Nov 13, 9:30 PM

Fri, Nov 3

dim added a comment to D10898: Avoid switching to root twice for saving options.
In D10898#268363, @mat wrote:

I've been wondering why this is needed, and then, I saw that in my make.conf, I have:

SU_CMD=/usr/local/bin/sudo -E sh -c
Fri, Nov 3, 12:51 PM

Tue, Oct 31

dim added a comment to D12839: Use relative object directories where possible..

Hmm, I rather liked the absolute paths that ${.OBJDIR} and ${OBJTOP} introduced. I find relative path output during builds a bit obfuscating. How much performance gain does this change deliver, in exchange for more obscurity?

Tue, Oct 31, 8:02 AM

Mon, Oct 30

dim added inline comments to D8188: Introduce lib/libgcc_eh and lib/libgcc_s for LLVM's implementation.
Mon, Oct 30, 10:19 PM

Wed, Oct 25

dim accepted D12792: Prefix {TARGET,BUILD}_TRIPLE with LLVM_ to avoid Makefile.inc1 collision..

LGTM. No problem to MFC this either.

Wed, Oct 25, 4:48 PM

Tue, Oct 24

dim committed rS324946: MFC r324826:.
MFC r324826:
Tue, Oct 24, 6:49 AM

Mon, Oct 23

dim committed rS324938: After jemalloc was updated to version 5.0.0 in r319971, i386 executables.
After jemalloc was updated to version 5.0.0 in r319971, i386 executables
Mon, Oct 23, 9:31 PM

Sat, Oct 21

dim committed rS324826: Pull in r316035 from upstream llvm trunk (by Tim Northover):.
Pull in r316035 from upstream llvm trunk (by Tim Northover):
Sat, Oct 21, 7:14 PM
dim committed rS324825: After the import of libc++ 5.0.0, there is no need to disable building.
After the import of libc++ 5.0.0, there is no need to disable building
Sat, Oct 21, 6:22 PM

Oct 6 2017

dim added a comment to D12298: libc: remove gets.

I take it an exp-run will be done, or has already been done? There's surely some old software in ports that uses this function. :)

Oct 6 2017, 1:47 PM

Oct 4 2017

dim added a comment to D12587: Document __FreeBSD_version 1200049.

Hmm, what happened to the intermediate version numbers 1200044 through 1200047?

Oct 4 2017, 5:04 PM

Sep 29 2017

dim committed rS324110: Belatedely fill in the dates for clang 5.0.0 update in UPDATING and.
Belatedely fill in the dates for clang 5.0.0 update in UPDATING and
Sep 29 2017, 11:06 PM

Sep 28 2017

dim accepted D12533: Fix building the kernel with upstream clang.

LGTM.

Sep 28 2017, 5:16 PM

Sep 26 2017

dim committed rD50938: Document __FreeBSD_version 1101505..
Document __FreeBSD_version 1101505.
Sep 26 2017, 8:00 PM
dim committed rS324023: Merge clang, llvm, lld, lldb, compiler-rt and libc++ 5.0.0 release..
Merge clang, llvm, lld, lldb, compiler-rt and libc++ 5.0.0 release.
Sep 26 2017, 8:00 PM
dim committed rD50926: Document __FreeBSD_version 1101504..
Document __FreeBSD_version 1101504.
Sep 26 2017, 9:12 AM
dim committed rS324006: Synchronize most of libm with head as of r323004. This excludes a few.
Synchronize most of libm with head as of r323004. This excludes a few
Sep 26 2017, 9:02 AM

Sep 6 2017

dim committed rS323245: Upgrade our copies of clang, llvm, lld, lldb, compiler-rt and libc++ to.
Upgrade our copies of clang, llvm, lld, lldb, compiler-rt and libc++ to
Sep 6 2017, 9:21 PM
dim committed rS323238: Tag llvm 5.0.0 release r312559..
Tag llvm 5.0.0 release r312559.
Sep 6 2017, 9:15 PM
dim committed rS323240: Tag clang 5.0.0 release r312559..
Tag clang 5.0.0 release r312559.
Sep 6 2017, 9:12 PM
dim committed rS323244: Tag lldb 5.0.0 release r312559..
Tag lldb 5.0.0 release r312559.
Sep 6 2017, 9:06 PM
dim committed rS323242: Tag libc++ 5.0.0 release r312559..
Tag libc++ 5.0.0 release r312559.
Sep 6 2017, 9:06 PM
dim committed rS323241: Tag compiler-rt 5.0.0 release r312559..
Tag compiler-rt 5.0.0 release r312559.
Sep 6 2017, 9:01 PM
dim committed rS323243: Tag lld 5.0.0 release r312559..
Tag lld 5.0.0 release r312559.
Sep 6 2017, 9:00 PM
dim committed rS323239: Vendor import of clang 5.0.0 release r312559:.
Vendor import of clang 5.0.0 release r312559:
Sep 6 2017, 8:56 PM
dim committed rS323237: Vendor import of llvm 5.0.0 release r312559:.
Vendor import of llvm 5.0.0 release r312559:
Sep 6 2017, 8:52 PM

Sep 5 2017

dim committed rS323190: MFC r323001:.
MFC r323001:
Sep 5 2017, 5:35 PM
dim committed rS323189: MFC r323001:.
MFC r323001:
Sep 5 2017, 5:32 PM
dim committed rS323188: MFC r323014:.
MFC r323014:
Sep 5 2017, 5:12 PM
dim committed rS323187: MFC r323001:.
MFC r323001:
Sep 5 2017, 4:59 PM

Sep 4 2017

dim accepted D12222: gnu binutils: FSGSBASE assembly/disassembly.

LGTM.

Sep 4 2017, 3:48 PM

Sep 1 2017

dim committed rS323112: Upgrade our copies of clang, llvm, lldb and compiler-rt to r312293 from.
Upgrade our copies of clang, llvm, lldb and compiler-rt to r312293 from
Sep 1 2017, 6:53 PM
dim committed rS323089: Tag llvm release_50 branch r312293..
Tag llvm release_50 branch r312293.
Sep 1 2017, 4:52 PM
dim committed rS323091: Tag clang release_50 branch r312293..
Tag clang release_50 branch r312293.
Sep 1 2017, 4:46 PM
dim committed rS323095: Tag libc++ release_50 branch r312293..
Tag libc++ release_50 branch r312293.
Sep 1 2017, 4:39 PM
dim committed rS323099: Tag lldb release_50 branch r312293..
Tag lldb release_50 branch r312293.
Sep 1 2017, 4:38 PM
dim committed rS323093: Tag compiler-rt release_50 branch r312293..
Tag compiler-rt release_50 branch r312293.
Sep 1 2017, 4:33 PM
dim committed rS323097: Tag lld release_50 branch r312293..
Tag lld release_50 branch r312293.
Sep 1 2017, 4:32 PM
dim committed rS323098: Vendor import of lldb release_50 branch r312293:.
Vendor import of lldb release_50 branch r312293:
Sep 1 2017, 4:30 PM
dim committed rS323096: Vendor import of lld release_50 branch r312293:.
Vendor import of lld release_50 branch r312293:
Sep 1 2017, 4:29 PM
dim committed rS323094: Vendor import of libc++ release_50 branch r312293:.
Vendor import of libc++ release_50 branch r312293:
Sep 1 2017, 4:29 PM
dim committed rS323092: Vendor import of compiler-rt release_50 branch r312293:.
Vendor import of compiler-rt release_50 branch r312293:
Sep 1 2017, 4:29 PM
dim committed rS323090: Vendor import of clang release_50 branch r312293:.
Vendor import of clang release_50 branch r312293:
Sep 1 2017, 4:29 PM
dim committed rS323088: Vendor import of llvm release_50 branch r312293:.
Vendor import of llvm release_50 branch r312293:
Sep 1 2017, 4:29 PM

Aug 30 2017

dim committed rS323014: Follow-up to r323001: if the actually selected CPUTYPE is capable of.
Follow-up to r323001: if the actually selected CPUTYPE is capable of
Aug 30 2017, 7:05 AM

Aug 29 2017

dim committed rS323001: In compiler-rt, a few assembler implementations for i386 floating point.
In compiler-rt, a few assembler implementations for i386 floating point
Aug 29 2017, 9:45 PM

Aug 24 2017

dim committed rS322855: Upgrade our copies of clang, llvm, lldb and compiler-rt to r311606 from.
Upgrade our copies of clang, llvm, lldb and compiler-rt to r311606 from
Aug 24 2017, 8:19 PM
dim committed rS322838: Tag llvm release_50 branch r311606..
Tag llvm release_50 branch r311606.
Aug 24 2017, 4:58 PM
dim committed rS322840: Tag clang release_50 branch r311606..
Tag clang release_50 branch r311606.
Aug 24 2017, 4:54 PM
dim committed rS322843: Tag libc++ release_50 branch r311606..
Tag libc++ release_50 branch r311606.
Aug 24 2017, 4:47 PM
dim committed rS322846: Tag lldb release_50 branch r311606..
Tag lldb release_50 branch r311606.
Aug 24 2017, 4:46 PM
dim committed rS322842: Tag compiler-rt release_50 branch r311606..
Tag compiler-rt release_50 branch r311606.
Aug 24 2017, 4:40 PM
dim committed rS322844: Tag lld release_50 branch r311606..
Tag lld release_50 branch r311606.
Aug 24 2017, 4:38 PM
dim committed rS322845: Vendor import of lldb release_50 branch r311606:.
Vendor import of lldb release_50 branch r311606:
Aug 24 2017, 4:36 PM
dim committed rS322841: Vendor import of compiler-rt release_50 branch r311606:.
Vendor import of compiler-rt release_50 branch r311606:
Aug 24 2017, 4:35 PM
dim committed rS322839: Vendor import of clang release_50 branch r311606:.
Vendor import of clang release_50 branch r311606:
Aug 24 2017, 4:35 PM
dim committed rS322837: Vendor import of llvm release_50 branch r311606:.
Vendor import of llvm release_50 branch r311606:
Aug 24 2017, 4:35 PM

Aug 21 2017

dim committed rS322740: Upgrade our copies of clang, llvm, lld and libc++ to r311219 from the.
Upgrade our copies of clang, llvm, lld and libc++ to r311219 from the
Aug 21 2017, 7:03 AM

Aug 20 2017

dim committed rS322728: Tag llvm release_50 branch r311219..
Tag llvm release_50 branch r311219.
Aug 20 2017, 9:28 PM
dim committed rS322730: Tag clang release_50 branch r311219..
Tag clang release_50 branch r311219.
Aug 20 2017, 9:26 PM
dim committed rS322733: Tag libc++ release_50 branch r311219..
Tag libc++ release_50 branch r311219.
Aug 20 2017, 9:17 PM
dim committed rS322736: Tag lldb release_50 branch r311219..
Tag lldb release_50 branch r311219.
Aug 20 2017, 9:16 PM
dim committed rS322731: Tag compiler-rt release_50 branch r311219..
Tag compiler-rt release_50 branch r311219.
Aug 20 2017, 9:11 PM
dim committed rS322735: Tag lld release_50 branch r311219..
Tag lld release_50 branch r311219.
Aug 20 2017, 9:10 PM
dim committed rS322734: Vendor import of lld release_50 branch r311219:.
Vendor import of lld release_50 branch r311219:
Aug 20 2017, 9:06 PM
dim committed rS322732: Vendor import of libc++ release_50 branch r311219:.
Vendor import of libc++ release_50 branch r311219:
Aug 20 2017, 9:06 PM
dim committed rS322729: Vendor import of clang release_50 branch r311219:.
Vendor import of clang release_50 branch r311219:
Aug 20 2017, 9:06 PM
dim committed rS322727: Vendor import of llvm release_50 branch r311219:.
Vendor import of llvm release_50 branch r311219:
Aug 20 2017, 9:03 PM

Aug 18 2017

dim accepted D12072: Set MK_LLD_IS_LD to MK_LLD_BOOTSTRAP for cross-tools.

LGTM, though I wonder why we use a different approach for the MK_CLANG_IS_CC / MK_CLANG_BOOTSTRAP pair...

Aug 18 2017, 2:39 PM

Aug 12 2017

dim committed rS322433: MFC r321684:.
MFC r321684:
Aug 12 2017, 5:50 PM

Aug 9 2017

dim committed rS322320: Upgrade our copies of clang, llvm and libc++ to r310316 from the.
Upgrade our copies of clang, llvm and libc++ to r310316 from the
Aug 9 2017, 5:33 PM
dim added a comment to D11928: i386/boot2: -fno-asynchronous-unwind-tables for gcc.

LGTM.

Aug 9 2017, 10:51 AM

Aug 8 2017

dim committed rS322260: Tag llvm release_50 branch r310316..
Tag llvm release_50 branch r310316.
Aug 8 2017, 5:18 PM
dim committed rS322262: Tag clang release_50 branch r310316..
Tag clang release_50 branch r310316.
Aug 8 2017, 5:13 PM
dim committed rS322265: Tag libc++ release_50 branch r310316..
Tag libc++ release_50 branch r310316.
Aug 8 2017, 5:06 PM
dim committed rS322267: Tag lldb release_50 branch r310316..
Tag lldb release_50 branch r310316.
Aug 8 2017, 5:05 PM
dim committed rS322263: Tag compiler-rt release_50 branch r310316..
Tag compiler-rt release_50 branch r310316.
Aug 8 2017, 4:59 PM
dim committed rS322266: Tag lld release_50 branch r310316..
Tag lld release_50 branch r310316.
Aug 8 2017, 4:58 PM
dim committed rS322264: Vendor import of libc++ release_50 branch r310316:.
Vendor import of libc++ release_50 branch r310316:
Aug 8 2017, 4:53 PM
dim committed rS322261: Vendor import of clang release_50 branch r310316:.
Vendor import of clang release_50 branch r310316:
Aug 8 2017, 4:53 PM
dim committed rS322259: Vendor import of llvm release_50 branch r310316:.
Vendor import of llvm release_50 branch r310316:
Aug 8 2017, 4:53 PM

Aug 7 2017

dim committed rS322170: Follow-up to r321684 (Don't use libc++ when cross-building for gcc.
Follow-up to r321684 (Don't use libc++ when cross-building for gcc
Aug 7 2017, 4:24 PM

Jul 30 2017

dim committed rS321723: Upgrade our copies of clang, llvm, lld and lldb to r309439 from the.
Upgrade our copies of clang, llvm, lld and lldb to r309439 from the
Jul 30 2017, 6:01 PM
dim committed rS321719: Pull in r309503 from upstream clang trunk (by Richard Smith):.
Pull in r309503 from upstream clang trunk (by Richard Smith):
Jul 30 2017, 11:50 AM

Jul 29 2017

dim committed rS321692: Tag llvm release_50 branch r309439..
Tag llvm release_50 branch r309439.
Jul 29 2017, 9:47 PM
dim committed rS321694: Tag clang release_50 branch r309439..
Tag clang release_50 branch r309439.
Jul 29 2017, 9:45 PM
dim committed rS321701: Tag lldb release_50 branch r309439..
Tag lldb release_50 branch r309439.
Jul 29 2017, 9:40 PM
dim committed rS321697: Tag libc++ release_50 branch r309439..
Tag libc++ release_50 branch r309439.
Jul 29 2017, 9:39 PM
dim committed rS321699: Tag lld release_50 branch r309439..
Tag lld release_50 branch r309439.
Jul 29 2017, 9:33 PM
dim committed rS321695: Tag compiler-rt release_50 branch r309439..
Tag compiler-rt release_50 branch r309439.
Jul 29 2017, 9:33 PM
dim committed rS321700: Vendor import of lldb release_50 branch r309439:.
Vendor import of lldb release_50 branch r309439:
Jul 29 2017, 9:32 PM
dim committed rS321698: Vendor import of lld release_50 branch r309439:.
Vendor import of lld release_50 branch r309439:
Jul 29 2017, 9:30 PM
dim committed rS321696: Vendor import of libc++ release_50 branch r309439:.
Vendor import of libc++ release_50 branch r309439:
Jul 29 2017, 9:30 PM
dim committed rS321693: Vendor import of clang release_50 branch r309439:.
Vendor import of clang release_50 branch r309439:
Jul 29 2017, 9:29 PM
dim committed rS321691: Vendor import of llvm release_50 branch r309439:.
Vendor import of llvm release_50 branch r309439:
Jul 29 2017, 9:25 PM
dim committed rS321684: Don't use libc++ when cross-building for gcc arches.
Don't use libc++ when cross-building for gcc arches
Jul 29 2017, 12:22 PM
dim closed D11776: Don't use libc++ when cross-building for gcc arches by committing rS321684: Don't use libc++ when cross-building for gcc arches.
Jul 29 2017, 12:22 PM

Jul 28 2017

dim created D11776: Don't use libc++ when cross-building for gcc arches.
Jul 28 2017, 11:17 PM
dim committed rS321664: Pull in r308891 from upstream llvm trunk (by Benjamin Kramer):.
Pull in r308891 from upstream llvm trunk (by Benjamin Kramer):
Jul 28 2017, 8:13 PM