- User Since
- Jan 7 2014, 10:13 PM (241 w, 9 h)
Sun, Aug 19
Sat, Aug 18
Fri, Aug 17
Oh sorry, I didn't realize that this is needed pretty quickly due to the slush, so then it is probably okay. I'd need some time to look at it and build it for testing, but for now I'll assume you've tested it and it works. :)
I haven't yet had time to look at this, but it should really be suggested and vetted upstream first, before applying it locally.
Thu, Aug 16
LGTM, maybe also rename the arguments of the preceding macro, for consistency?
Sat, Aug 11
Fri, Aug 10
Thu, Aug 9
Sun, Aug 5
Sat, Aug 4
Of course only now I notice that this changes these alignments unconditionally for all platforms, e.g. for Linux too, and that can't be right (at least not without some form of checks by Linux people). For us it doesn't matter, but upstreaming this has just become a little harder.
Fri, Aug 3
Oh btw, this might also need lines in OptionalObsoleteFiles.inc?
Note that it is upstream which places the .so file in /usr/lib/clang/X.Y.Z, supposedly because it is very version-dependent. I'm unsure as to whether there is in any RPATH magic involved. In fact, I have never properly gotten the dynamic ASan lib working, as far as I remember.