Page MenuHomeFreeBSD

dim (Dimitry Andric)
User

Projects

User Details

User Since
Jan 7 2014, 10:13 PM (402 w, 6 d)

Recent Activity

Yesterday

dim committed R11:6bef09666460: lang/python3([6-9]|10): disable detection of multiarch (authored by dim).
lang/python3([6-9]|10): disable detection of multiarch
Mon, Sep 27, 5:57 PM

Sun, Sep 26

dim committed R10:8c15a9ce53da: Spell cloudabi correctly in ObsoleteFiles.inc (authored by dim).
Spell cloudabi correctly in ObsoleteFiles.inc
Sun, Sep 26, 11:27 AM
dim committed R10:3f25e997d96a: Vendor import of llvm-project branch release/13.x llvmorg-13.0.0-rc4-0… (authored by dim).
Vendor import of llvm-project branch release/13.x llvmorg-13.0.0-rc4-0…
Sun, Sep 26, 11:16 AM

Wed, Sep 22

dim accepted D32058: llvm-readobj: Attach to buildsystem.

readelf is just a symlink to readobj, so in order to have a full llvm binutils instead of elftoolchain with WITH_LLVM_BINUTILS we need llvm-readelf.

Wed, Sep 22, 7:24 PM
dim added a comment to D32058: llvm-readobj: Attach to buildsystem.

Hm, one thing is missing: why do we need this tool? :) Last time I looked it was a tool specifically for llvm's regression tests. Do we really want to build this unconditionally?

Wed, Sep 22, 7:09 PM
dim committed R11:f508cdd3cc28: net-mgmt/pmacct: mark unused but set variables with attributes (authored by dim).
net-mgmt/pmacct: mark unused but set variables with attributes
Wed, Sep 22, 6:46 PM

Tue, Sep 21

dim committed R11:adbaad235b4c: net/ifdepd: fix clang 13 warnings and non-static inline functions (authored by dim).
net/ifdepd: fix clang 13 warnings and non-static inline functions
Tue, Sep 21, 6:30 PM
dim committed R10:b2cfac207d60: compiler-rt: add aarch64 init function for LSE atomics (authored by dim).
compiler-rt: add aarch64 init function for LSE atomics
Tue, Sep 21, 6:19 PM

Sun, Sep 19

dim committed R10:392ac508a058: Vendor import of llvm-project branch release/13.x llvmorg-13.0.0-rc3-8… (authored by dim).
Vendor import of llvm-project branch release/13.x llvmorg-13.0.0-rc3-8…
Sun, Sep 19, 8:28 AM
dim committed R10:371456b17b0f: Add -Wno-error=unused-but-set-variable when building with Clang 13+ (authored by dim).
Add -Wno-error=unused-but-set-variable when building with Clang 13+
Sun, Sep 19, 8:18 AM
dim committed R10:8e698cd2ab2f: Add -Wno-error=unused-but-set-variable when building with Clang 13+ (authored by dim).
Add -Wno-error=unused-but-set-variable when building with Clang 13+
Sun, Sep 19, 8:18 AM

Fri, Sep 17

dim accepted D31997: libgcc_s: Export 64-bit int to 128-bit float functions.

LGTM, thanks!

Fri, Sep 17, 9:17 PM

Wed, Sep 15

dim committed R10:8e732dbd37ff: i386 loaders: avoid lld 13 garbage collecting linker sets (authored by dim).
i386 loaders: avoid lld 13 garbage collecting linker sets
Wed, Sep 15, 10:33 AM
dim committed R10:6d8f2277dee6: i386 loaders: avoid lld 13 garbage collecting linker sets (authored by dim).
i386 loaders: avoid lld 13 garbage collecting linker sets
Wed, Sep 15, 10:32 AM
dim committed R11:9a10eff03e91: misc/rump: fix or suppress clang 13 warnings (authored by dim).
misc/rump: fix or suppress clang 13 warnings
Wed, Sep 15, 7:55 AM
dim committed R11:9118b8848d5a: devel/frink: fix unused but set variables (authored by dim).
devel/frink: fix unused but set variables
Wed, Sep 15, 7:48 AM

Mon, Sep 13

dim committed R10:45feade38ec3: Add -Wno-error=unused-but-set-variable when building with Clang 13+ (authored by dim).
Add -Wno-error=unused-but-set-variable when building with Clang 13+
Mon, Sep 13, 4:07 PM
dim closed D31927: Add -Wno-error=unused-but-set-variable when building with Clang 13+.
Mon, Sep 13, 4:07 PM
dim commandeered D31927: Add -Wno-error=unused-but-set-variable when building with Clang 13+.
Mon, Sep 13, 4:02 PM
dim added a comment to D31927: Add -Wno-error=unused-but-set-variable when building with Clang 13+.

I did this slightly differently in https://github.com/DimitryAndric/freebsd-src/commit/73a8f96dc7c12ebf76f5a40a7f1208c11f75741f, and I put it in another if block. It would be nice to choose either my version or yours, and integrate it right away, so I don't get needless merge conflicts the next time I sync up the llvm-13-update branch with main.

Mon, Sep 13, 12:55 PM

Thu, Sep 9

dim committed R10:f9ef3ff6e2ee: Vendor import of llvm-project branch release/13.x llvmorg-13.0.0-rc2-43… (authored by dim).
Vendor import of llvm-project branch release/13.x llvmorg-13.0.0-rc2-43…
Thu, Sep 9, 9:05 AM

Wed, Sep 8

dim committed R10:c90cab0d668a: i386 loaders: avoid lld 13 garbage collecting linker sets (authored by dim).
i386 loaders: avoid lld 13 garbage collecting linker sets
Wed, Sep 8, 12:05 PM

Mon, Sep 6

dim committed R10:efe67f33c322: compiler-rt: add aarch64 init function for LSE atomics (authored by dim).
compiler-rt: add aarch64 init function for LSE atomics
Mon, Sep 6, 7:25 PM

Fri, Sep 3

dim added a reverting change for R10:2ebf10e7a1ce: Revert part of r360964: R10:edc7b289b2b2: Revert the changes that removed support for old gcc, as stable/12 still.
Fri, Sep 3, 5:05 PM
dim added a reverting change for R10:a606cb388f97: Remove tests for obsolete compilers in the build system: R10:edc7b289b2b2: Revert the changes that removed support for old gcc, as stable/12 still.
Fri, Sep 3, 5:05 PM
dim committed R10:edc7b289b2b2: Revert the changes that removed support for old gcc, as stable/12 still (authored by dim).
Revert the changes that removed support for old gcc, as stable/12 still
Fri, Sep 3, 5:05 PM
dim added a reverting change for D24802: Remove tests for obsolete compilers in the build system: R10:edc7b289b2b2: Revert the changes that removed support for old gcc, as stable/12 still.
Fri, Sep 3, 5:05 PM
dim committed R10:cc110974c4ed: xen: Fix warning by adding KERNBASE to modlist_paddr before casting (authored by dim).
xen: Fix warning by adding KERNBASE to modlist_paddr before casting
Fri, Sep 3, 12:00 AM
dim committed R10:461cfd4192d2: Fix acpica macros that subtract null pointers (authored by dim).
Fix acpica macros that subtract null pointers
Fri, Sep 3, 12:00 AM
dim committed R10:4409857538fc: Remove -simplifycfg-dup-ret from CLANG_OPT_SMALL flags for clang 13 (authored by dim).
Remove -simplifycfg-dup-ret from CLANG_OPT_SMALL flags for clang 13
Fri, Sep 3, 12:00 AM
dim committed R10:f4fed768bba4: Don't error out on unused but set variables with clang 13 (authored by dim).
Don't error out on unused but set variables with clang 13
Fri, Sep 3, 12:00 AM
dim committed R10:5fd3c9a1f67a: Suppress -Wempty-body warnings in GCC 6.x and later. (authored by jhb).
Suppress -Wempty-body warnings in GCC 6.x and later.
Fri, Sep 3, 12:00 AM
dim committed R10:c7bb9802495a: Disable errors for -Wredundant-decls for GCC 6+. (authored by jhb).
Disable errors for -Wredundant-decls for GCC 6+.
Fri, Sep 3, 12:00 AM
dim committed R10:8fce2bfdfc6f: Turn off errors for -Wmaybe-uninitialized in GCC 6+. (authored by jhb).
Turn off errors for -Wmaybe-uninitialized in GCC 6+.
Fri, Sep 3, 12:00 AM
dim committed R10:2ebf10e7a1ce: Revert part of r360964 (authored by vangyzen).
Revert part of r360964
Fri, Sep 3, 12:00 AM
dim committed R10:a606cb388f97: Remove tests for obsolete compilers in the build system (authored by vangyzen).
Remove tests for obsolete compilers in the build system
Fri, Sep 3, 12:00 AM
dim committed R10:06d66775fc65: gcc9: quiet Waddress-of-packed-member for user build (authored by rlibby).
gcc9: quiet Waddress-of-packed-member for user build
Fri, Sep 3, 12:00 AM
dim committed R10:783c47d7cb3f: Remove obsolete, non-use of CLANG_NO_IAS. (authored by brooks).
Remove obsolete, non-use of CLANG_NO_IAS.
Fri, Sep 3, 12:00 AM
dim committed R10:95ce44457bf2: Remove CLANG_NO_IAS definition (authored by emaste).
Remove CLANG_NO_IAS definition
Fri, Sep 3, 12:00 AM
dim committed R10:cfd9d82ed8a6: gptzfsboot: remove CLANG_NO_IAS (authored by emaste).
gptzfsboot: remove CLANG_NO_IAS
Fri, Sep 3, 12:00 AM
dim committed R10:dc5259b56722: stand: remove CLANG_NO_IAS from pxeldr (authored by emaste).
stand: remove CLANG_NO_IAS from pxeldr
Fri, Sep 3, 12:00 AM

Thu, Sep 2

dim committed R10:baeb0b2fb4d0: stand: remove CLANG_NO_IAS from cdboot (authored by emaste).
stand: remove CLANG_NO_IAS from cdboot
Thu, Sep 2, 11:59 PM
dim committed R10:8b2de9110244: stand: remove CLANG_NO_IAS from boot2 (authored by emaste).
stand: remove CLANG_NO_IAS from boot2
Thu, Sep 2, 11:59 PM
dim committed R10:dd76aa32815e: stand: remove CLANG_NO_IAS from zfsldr (authored by emaste).
stand: remove CLANG_NO_IAS from zfsldr
Thu, Sep 2, 11:59 PM
dim committed R10:76a6b4ad3519: stand: remove CLANG_NO_IAS from btx and gptboot (authored by emaste).
stand: remove CLANG_NO_IAS from btx and gptboot
Thu, Sep 2, 11:59 PM
dim committed R10:2abf37d5cecb: Retire CLANG_NO_IAS34 (authored by emaste).
Retire CLANG_NO_IAS34
Thu, Sep 2, 11:59 PM
dim committed R10:7dfb8e02e357: Fix acpica macros that subtract null pointers (authored by dim).
Fix acpica macros that subtract null pointers
Thu, Sep 2, 9:54 PM
dim committed R10:d01fe93c3dc9: Don't error out on unused but set variables with clang 13 (authored by dim).
Don't error out on unused but set variables with clang 13
Thu, Sep 2, 9:54 PM
dim committed R10:87addf66101d: Remove -simplifycfg-dup-ret from CLANG_OPT_SMALL flags for clang 13 (authored by dim).
Remove -simplifycfg-dup-ret from CLANG_OPT_SMALL flags for clang 13
Thu, Sep 2, 9:54 PM
dim committed R10:7756b8f25e64: xen: Fix warning by adding KERNBASE to modlist_paddr before casting (authored by dim).
xen: Fix warning by adding KERNBASE to modlist_paddr before casting
Thu, Sep 2, 9:54 PM
dim accepted D31804: llvm: fix/workaround liblzma incorrect compress/uncompress.

Let's do this for now to get the PowerPC builds working again. But also be aware that the bisected upstream commit is only exposing an underlying issue: most likely the root cause is in the PowerPC backend.

Thu, Sep 2, 9:26 PM · PowerPC

Tue, Aug 31

dim committed R10:1aaf3bbc74ce: fwohci: Cast bitfield to uint32_t before passing it to roundup2(). (authored by jhb).
fwohci: Cast bitfield to uint32_t before passing it to roundup2().
Tue, Aug 31, 7:58 PM
dim committed R10:3b2ae1c2bbfb: Expose clang's alignment builtins and use them for roundup2/rounddown2 (authored by arichardson).
Expose clang's alignment builtins and use them for roundup2/rounddown2
Tue, Aug 31, 7:27 PM
dim committed R10:a2ddb544867a: Fix null pointer subtraction in mergesort() (authored by dim).
Fix null pointer subtraction in mergesort()
Tue, Aug 31, 7:12 PM
dim committed R10:fe61b012dcae: Silence more gtest warnings, now in fusefs tests (authored by dim).
Silence more gtest warnings, now in fusefs tests
Tue, Aug 31, 7:12 PM
dim committed R10:4eb23465de9d: Explicitly link zfsd with libspl to avoid undefined references (authored by dim).
Explicitly link zfsd with libspl to avoid undefined references
Tue, Aug 31, 7:07 PM
dim committed R10:e9dbd59b309f: Silence more gtest warnings, now in fusefs tests (authored by dim).
Silence more gtest warnings, now in fusefs tests
Tue, Aug 31, 7:07 PM
dim committed R10:ef314cd4bae2: Fix null pointer subtraction in mergesort() (authored by dim).
Fix null pointer subtraction in mergesort()
Tue, Aug 31, 7:07 PM
dim added a comment to D31711: xen: Fix warning by adding KERNBASE to vm_paddr_t before casting.

No, then you would be doing arithmetic on a void pointer, which isn't officially legal (size of void being undefined). Better to do the math on integers and cast to the correct type.

It's a GNU C extension which I thought was fine to be used, as we already use other GNU C extensions I think.

Tue, Aug 31, 5:17 PM

Mon, Aug 30

dim closed D31710: Fix acpica macros that subtract null pointers.
Mon, Aug 30, 7:35 PM
dim committed R10:130a690ae16e: Fix acpica macros that subtract null pointers (authored by dim).
Fix acpica macros that subtract null pointers
Mon, Aug 30, 7:35 PM

Sun, Aug 29

dim updated the diff for D31710: Fix acpica macros that subtract null pointers.

Use conditional FreeBSD block, and our own __offsetof().

Sun, Aug 29, 5:50 PM
dim committed R10:8e3c56d6b676: xen: Fix warning by adding KERNBASE to modlist_paddr before casting (authored by dim).
xen: Fix warning by adding KERNBASE to modlist_paddr before casting
Sun, Aug 29, 5:45 PM
dim closed D31711: xen: Fix warning by adding KERNBASE to vm_paddr_t before casting.
Sun, Aug 29, 5:45 PM

Aug 29 2021

dim committed R10:5b8f07b12f84: Fix -Wformat errors in pfctl on 32-bit architectures (authored by dim).
Fix -Wformat errors in pfctl on 32-bit architectures
Aug 29 2021, 3:32 PM
dim added a comment to D31711: xen: Fix warning by adding KERNBASE to vm_paddr_t before casting.

I think you can also remove the cast to vm_paddr_t while there, the field is declared as uint64_t.

Aug 29 2021, 2:56 PM
dim requested review of D31711: xen: Fix warning by adding KERNBASE to vm_paddr_t before casting.
Aug 29 2021, 2:04 PM
dim committed R10:22b8ab15c41a: Remove -simplifycfg-dup-ret from CLANG_OPT_SMALL flags for clang 13 (authored by dim).
Remove -simplifycfg-dup-ret from CLANG_OPT_SMALL flags for clang 13
Aug 29 2021, 1:54 PM
dim committed R10:395d46caaed7: Don't error out on unused but set variables with clang 13 (authored by dim).
Don't error out on unused but set variables with clang 13
Aug 29 2021, 1:54 PM
dim added a reverting change for R10:befc47822966: Do a sweep and remove most WARNS=6 settings: R10:e92630fc6829: Revert "Do a sweep and remove most WARNS=6 settings".
Aug 29 2021, 1:33 PM
dim committed R10:e92630fc6829: Revert "Do a sweep and remove most WARNS=6 settings" (authored by dim).
Revert "Do a sweep and remove most WARNS=6 settings"
Aug 29 2021, 1:33 PM
dim requested review of D31710: Fix acpica macros that subtract null pointers.
Aug 29 2021, 11:16 AM
dim committed R10:729a19f2cd01: Cleanup compiler warning flags in lib/libefivar/Makefile (authored by dim).
Cleanup compiler warning flags in lib/libefivar/Makefile
Aug 29 2021, 10:52 AM
dim committed R10:7f14439a3a78: googletest: Silence warnings about deprecated implicit copy constructors (authored by dim).
googletest: Silence warnings about deprecated implicit copy constructors
Aug 29 2021, 10:52 AM
dim committed R10:befc47822966: Do a sweep and remove most WARNS=6 settings (authored by kevans).
Do a sweep and remove most WARNS=6 settings
Aug 29 2021, 10:52 AM
dim committed R10:ab18f56db464: Cleanup compiler warning flags in lib/libefivar/Makefile (authored by dim).
Cleanup compiler warning flags in lib/libefivar/Makefile
Aug 29 2021, 10:31 AM
dim committed R10:38a2bbfa12b5: googletest: Silence warnings about deprecated implicit copy constructors (authored by dim).
googletest: Silence warnings about deprecated implicit copy constructors
Aug 29 2021, 10:31 AM

Aug 28 2021

dim added a comment to D31708: ldd: Remove non-functional -v option.
In D31708#715404, @dim wrote:

Hmm the whole vflag handling seems to have been a no-op? I wonder when it disappeared, probably when a.out support was deleted from this code?

Aug 28 2021, 6:49 PM
dim accepted D31708: ldd: Remove non-functional -v option.

Hmm the whole vflag handling seems to have been a no-op? I wonder when it disappeared, probably when a.out support was deleted from this code?

Aug 28 2021, 6:45 PM
dim committed R10:9fae47666957: Explicitly link zfsd with libspl to avoid undefined references (authored by dim).
Explicitly link zfsd with libspl to avoid undefined references
Aug 28 2021, 6:24 PM
dim committed R10:4544929cb55e: Silence unused parameter warnings in fspacectl(2) bootstrap stub (authored by dim).
Silence unused parameter warnings in fspacectl(2) bootstrap stub
Aug 28 2021, 1:39 PM

Aug 27 2021

dim committed R10:5a3a8cb01ab8: Silence more gtest warnings, now in fusefs tests (authored by dim).
Silence more gtest warnings, now in fusefs tests
Aug 27 2021, 9:40 PM
dim committed R10:4e5d32a445f9: Fix null pointer subtraction in mergesort() (authored by dim).
Fix null pointer subtraction in mergesort()
Aug 27 2021, 5:47 PM

Aug 26 2021

dim committed R10:d396c67f26b0: googletest: Silence warnings about deprecated implicit copy constructors (authored by dim).
googletest: Silence warnings about deprecated implicit copy constructors
Aug 26 2021, 8:10 PM
dim accepted D31698: powerpc64*: fix for broken binaries generated by llvm12.

I wouldn't say "reverts LLVM commit 2518433f861fcb877d0a7bdd9aec1aec1f77505a", but something like "amends LLVM commit 2518433f861fcb877d0a7bdd9aec1aec1f77505a", as we're adding code here. But otherwise, LGTM!

Aug 26 2021, 7:48 PM · PowerPC
dim committed R10:f643997a1761: Cleanup compiler warning flags in lib/libefivar/Makefile (authored by dim).
Cleanup compiler warning flags in lib/libefivar/Makefile
Aug 26 2021, 6:54 PM
dim committed R10:9e1de6e82503: Apply clang fix for assertion failure compiling multimedia/minitube (authored by dim).
Apply clang fix for assertion failure compiling multimedia/minitube
Aug 26 2021, 6:11 PM
dim committed R10:d7d2f810f8a9: Apply clang fix for assertion failure compiling multimedia/minitube (authored by dim).
Apply clang fix for assertion failure compiling multimedia/minitube
Aug 26 2021, 6:10 PM
dim committed R10:5e9c2a6a9023: Apply clang fix for assertion failure compiling multimedia/minitube (authored by dim).
Apply clang fix for assertion failure compiling multimedia/minitube
Aug 26 2021, 6:10 PM

Aug 21 2021

dim committed R10:d545c2ce5ad1: Vendor import of llvm-project branch release/13.x llvmorg-13.0.0-rc1-97… (authored by dim).
Vendor import of llvm-project branch release/13.x llvmorg-13.0.0-rc1-97…
Aug 21 2021, 9:28 PM
dim committed R10:9cb5bdb8b26e: Vendor import of llvm-project branch release/13.x llvmorg-13.0.0-rc1-0… (authored by dim).
Vendor import of llvm-project branch release/13.x llvmorg-13.0.0-rc1-0…
Aug 21 2021, 9:27 PM
dim committed R10:efa485d5c390: Apply clang fix for assertion failure compiling multimedia/minitube (authored by dim).
Apply clang fix for assertion failure compiling multimedia/minitube
Aug 21 2021, 9:04 PM
dim committed R10:d5c7f929b50d: Apply upstream clang fix for assertion failure compiling devel/capnproto (authored by dim).
Apply upstream clang fix for assertion failure compiling devel/capnproto
Aug 21 2021, 3:15 PM
dim committed R10:b65d87e5d7b5: Apply upstream clang fix for assertion failure compiling devel/capnproto (authored by dim).
Apply upstream clang fix for assertion failure compiling devel/capnproto
Aug 21 2021, 3:15 PM

Aug 20 2021

dim committed R10:a949c6a0d6c8: Apply upstream lldb fix for unhandled Error causing abort (authored by dim).
Apply upstream lldb fix for unhandled Error causing abort
Aug 20 2021, 4:22 PM

Aug 18 2021

dim added a comment to D31603: [libc][NFC] Add restrict, pure, and malloc_like qualifiers to string functions.
In D31603#712550, @dim wrote:

I know that when glibc changed something in this area they got complaints about programs breaking, if those should not have done the overlapping memcpy's.

Aug 18 2021, 7:23 PM
dim added a comment to D31603: [libc][NFC] Add restrict, pure, and malloc_like qualifiers to string functions.

Before this could be accepted I'd at least expect a full ports exp-run, and quite a bit of testing on the resulting packages, as changing the behavior of memcpy() as above will very likely lead to some failures. Strictly speaking you should never call memcpy() with overlapping arguments, but our traditional implementation has always allowed it. So how much fallout would this give? I know that when glibc changed something in this area they got complaints about programs breaking, if those should not have done the overlapping memcpy's.

Aug 18 2021, 6:55 PM

Aug 16 2021

dim committed R10:c1a540709a83: Apply upstream lldb fix for unhandled Error causing abort (authored by dim).
Apply upstream lldb fix for unhandled Error causing abort
Aug 16 2021, 5:02 PM

Aug 14 2021

dim committed R10:2b53701772f0: Add ElfW() macro for compatibility with Linux (authored by dim).
Add ElfW() macro for compatibility with Linux
Aug 14 2021, 1:05 PM
dim committed R10:b58a13b94c99: Add ElfW() macro for compatibility with Linux (authored by dim).
Add ElfW() macro for compatibility with Linux
Aug 14 2021, 1:05 PM