Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (347 w, 3 d)

Recent Activity

Thu, Feb 18

brooks updated subscribers of D28765: RFC: Use file-prefix-map to lie about kernel build paths.
Thu, Feb 18, 4:59 PM
brooks updated subscribers of D28764: RFC: Use file-prefix-map to lie about build paths.
Thu, Feb 18, 4:58 PM
brooks added inline comments to D28764: RFC: Use file-prefix-map to lie about build paths.
Thu, Feb 18, 4:58 PM
brooks added a comment to D28764: RFC: Use file-prefix-map to lie about build paths.

I think this is like to need a ports exp-run.

Thu, Feb 18, 12:47 AM
brooks added a comment to D28632: Add fileprefixmap compiler feature.

Thanks for the gitlab reference, being able to cherry-pick the commit and preserve author data was helpful.

Thu, Feb 18, 12:12 AM

Wed, Feb 17

brooks closed D28632: Add fileprefixmap compiler feature.
Wed, Feb 17, 10:28 PM
brooks committed R10:d616ae46b484: Add fileprefixmap compiler feature (authored by dan.mcgregor_usask.ca).
Add fileprefixmap compiler feature
Wed, Feb 17, 10:28 PM

Mon, Feb 15

brooks accepted D28632: Add fileprefixmap compiler feature.

This seems reasonable. Adding Alex in case he's interested (we might want to use this in cheribuild to match src paths match smbfs mounts).

Mon, Feb 15, 6:51 PM

Wed, Feb 10

brooks accepted D28573: fmtree: prepare for removal.

It seems worth adding a reference to mtree.

Wed, Feb 10, 9:59 PM

Tue, Feb 2

brooks accepted D28332: Expose clang's alignment builtins and use them for roundup2/rounddown2.
Tue, Feb 2, 7:16 PM
brooks accepted D28414: atf: Fix ATF_BUILD_* values when not using the bootstrap compiler.

IMO these tests are extremely dubious and fragile. Embedding cc/c++/cpp seems most likely to work at all. I think I've proposed something like this in the past.

Tue, Feb 2, 6:35 PM

Jan 26 2021

brooks committed R10:d89c1c461ce3: Reserve gaps in syscall numbers for local use (authored by brooks).
Reserve gaps in syscall numbers for local use
Jan 26 2021, 6:29 PM
brooks committed R10:119fa6ee8a80: syscalls.master: Add a new syscall type: RESERVED (authored by brooks).
syscalls.master: Add a new syscall type: RESERVED
Jan 26 2021, 6:29 PM
brooks closed D27988: Reserve gaps in syscall numbers for local use.
Jan 26 2021, 6:29 PM
brooks committed R10:65a524b499ae: Remove documentation of unimplemented syscalls (authored by brooks).
Remove documentation of unimplemented syscalls
Jan 26 2021, 6:29 PM
brooks added a comment to D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..

The syscalls.master bits look fine.

Jan 26 2021, 5:51 PM

Jan 25 2021

brooks committed R10:7baf7a453859: ndis: Per user request, delay removal to 14 (authored by brooks).
ndis: Per user request, delay removal to 14
Jan 25 2021, 10:18 PM
brooks committed R10:2a0be7b0331c: VFS_QUOTACTL: Remove needless casts of arg (authored by brooks).
VFS_QUOTACTL: Remove needless casts of arg
Jan 25 2021, 10:17 PM
brooks accepted D28315: bsd.compiler.mk: Detect distribution-provided GCC when executed as cc.
Jan 25 2021, 10:08 PM
brooks closed D27609: ndis(4): remove as previous announced.

Committed in R10:bfc99943b04b46a6c1c885ce7bcc6f235b7422aa

Jan 25 2021, 10:03 PM
brooks committed R10:7a1591c1b625: Rename kern_mmap_req to kern_mmap (authored by brooks).
Rename kern_mmap_req to kern_mmap
Jan 25 2021, 9:59 PM
brooks closed D28292: Replace all uses of kern_mmap with kern_mmap_req.
Jan 25 2021, 9:59 PM
brooks committed R10:bfc99943b04b: ndis(4): remove as previous announced (authored by brooks).
ndis(4): remove as previous announced
Jan 25 2021, 9:46 PM
brooks accepted D28311: vm_map_protect.9: update after code changes.
Jan 25 2021, 9:29 PM
brooks updated the diff for D28292: Replace all uses of kern_mmap with kern_mmap_req.
  • Rebase
  • Use a slightly more compact style
Jan 25 2021, 9:24 PM
brooks updated the diff for D27988: Reserve gaps in syscall numbers for local use.
  • Rebase
  • s/rsrvd/reserved in makesyscalls.lua
Jan 25 2021, 8:49 PM
brooks added inline comments to D27988: Reserve gaps in syscall numbers for local use.
Jan 25 2021, 8:46 PM
brooks added a reviewer for D27988: Reserve gaps in syscall numbers for local use: kevans.
Jan 25 2021, 7:49 PM
brooks added a comment to D27988: Reserve gaps in syscall numbers for local use.

I've updated the diff (it's three commits). I ended up using RESERVED since the only thing a long name causes issues with is alignment of the comment at the top of syscalls.master.

Jan 25 2021, 7:49 PM
brooks updated the diff for D27988: Reserve gaps in syscall numbers for local use.
  • Update comment saying to add syscalls at the bottom
Jan 25 2021, 7:45 PM
brooks updated the diff for D27988: Reserve gaps in syscall numbers for local use.
  • syscalls.master: Add a new syscall type: RESERVED
  • Reserve gaps in syscall numbers for local use
Jan 25 2021, 7:44 PM
brooks added a comment to D27988: Reserve gaps in syscall numbers for local use.
In D27988#633155, @kib wrote:

Again, why not push cleanup separately.

Jan 25 2021, 6:54 PM

Jan 23 2021

brooks added inline comments to D27988: Reserve gaps in syscall numbers for local use.
Jan 23 2021, 12:53 AM
brooks updated the diff for D27988: Reserve gaps in syscall numbers for local use.
  • Rebase and split into two commits
    • Remove documentation of unimplemented syscalls
    • Reserve gaps in syscall numbers for local use
Jan 23 2021, 12:53 AM
brooks added a comment to D28292: Replace all uses of kern_mmap with kern_mmap_req.

I've done this cleanup in CheriBSD on the path to some local cleanups.

Jan 23 2021, 12:33 AM
brooks updated the diff for D28292: Replace all uses of kern_mmap with kern_mmap_req.
  • Whitespace fix.
Jan 23 2021, 12:33 AM
brooks requested review of D28292: Replace all uses of kern_mmap with kern_mmap_req.
Jan 23 2021, 12:25 AM

Jan 21 2021

brooks accepted D28263: build: remove LIBPTHREAD/LIBTHR build options.
Jan 21 2021, 5:15 PM
brooks accepted D28120: compiler.mk: Update clang dependency from v6 to v10, clean up duplication.
Jan 21 2021, 5:11 PM

Jan 20 2021

brooks added inline comments to D28120: compiler.mk: Update clang dependency from v6 to v10, clean up duplication.
Jan 20 2021, 7:28 PM
brooks accepted D28253: Remove all current uses of build-tools during buildworld.

I really like this. It's cleaner and eliminates a tree walk.

Jan 20 2021, 7:24 PM

Jan 15 2021

brooks added inline comments to D28120: compiler.mk: Update clang dependency from v6 to v10, clean up duplication.
Jan 15 2021, 6:03 PM

Jan 14 2021

brooks added inline comments to D28120: compiler.mk: Update clang dependency from v6 to v10, clean up duplication.
Jan 14 2021, 12:28 AM

Jan 13 2021

brooks accepted D28122: [mips] revert r366664 - flip mips back from -O2 to -O.
Jan 13 2021, 9:05 PM

Jan 12 2021

brooks added a comment to D28122: [mips] revert r366664 - flip mips back from -O2 to -O.

Please only do this for GCC if only GCC is broken.

Jan 12 2021, 9:22 PM
brooks accepted D28117: vm_map_protect: allow to set prot and max_prot in one go..
Jan 12 2021, 9:01 PM

Jan 11 2021

brooks committed rP561287: llvm10: Avoid untracked ncurses depend.
llvm10: Avoid untracked ncurses depend
Jan 11 2021, 11:47 PM
brooks closed D28049: ndis: Per user request, delay removal to 14.
Jan 11 2021, 6:13 PM
brooks committed R10:d7a7d6a7c3c6: ndis: Per user request, delay removal to 14 (authored by brooks).
ndis: Per user request, delay removal to 14
Jan 11 2021, 6:13 PM

Jan 8 2021

brooks updated the diff for D28049: ndis: Per user request, delay removal to 14.
  • Update manpage
Jan 8 2021, 11:33 PM
brooks requested review of D28049: ndis: Per user request, delay removal to 14.
Jan 8 2021, 10:46 PM
brooks committed rP560814: llvm11: Update to 11.0.1 release.
llvm11: Update to 11.0.1 release
Jan 8 2021, 10:26 PM
brooks accepted D28045: build: `make check`: use a PATH search instead for Kyua.
Jan 8 2021, 10:19 PM

Jan 7 2021

brooks accepted D27997: Reallocate syscall numbers for aio_writev and aio_readv.

Thank you!

Jan 7 2021, 11:01 PM
brooks added a comment to D27988: Reserve gaps in syscall numbers for local use.
In D27988#625257, @kib wrote:

Can we split the cleanup of unimplemented syscalls entries and policy statement? I have no objections against former, but IMO the new policy is somewhat wide open and strange. Lets discuss it separately, not blocking the good cleanup.

Jan 7 2021, 9:44 PM

Jan 6 2021

brooks updated the diff for D27988: Reserve gaps in syscall numbers for local use.
  • Reclaim never-implemented or foreign syscalls
Jan 6 2021, 12:18 AM
brooks requested review of D27988: Reserve gaps in syscall numbers for local use.
Jan 6 2021, 12:17 AM

Dec 23 2020

brooks accepted D27699: Fix the types in some Linux syscall definitions.
Dec 23 2020, 12:05 AM

Dec 22 2020

brooks accepted D27732: Retire gnugrep and libgnuregex.
Dec 22 2020, 11:29 PM

Dec 18 2020

brooks added a comment to D27648: bsd.compat.mk: Allow finding non-internal libraries.

@brooks made some changes for CheriBSD to use a merged sysroot for compat and normal libraries. I wonder if we should be upstreaming that change instead?

Dec 18 2020, 5:48 PM

Dec 17 2020

brooks closed D27093: VFS_QUOTACTL: Remove needless casts of arg argument.
Dec 17 2020, 9:58 PM
brooks committed rS368744: VFS_QUOTACTL: Remove needless casts of arg.
VFS_QUOTACTL: Remove needless casts of arg
Dec 17 2020, 9:58 PM
brooks closed D27646: newvers.sh: Speed up git_tree_modified.
Dec 17 2020, 12:00 AM
brooks committed rS368709: newvers.sh: Speed up git_tree_modified.
newvers.sh: Speed up git_tree_modified
Dec 17 2020, 12:00 AM

Dec 16 2020

brooks added a comment to D27646: newvers.sh: Speed up git_tree_modified.

CI run https://cirrus-ci.com/task/5615131910471680

Dec 16 2020, 11:00 PM
brooks requested review of D27646: newvers.sh: Speed up git_tree_modified.
Dec 16 2020, 9:22 PM
brooks accepted D27638: kyua: Only install examples if requested.

Seems fine to me.

Dec 16 2020, 9:10 PM

Dec 15 2020

brooks committed rS368672: Release jrtc27 from mentorship.
Release jrtc27 from mentorship
Dec 15 2020, 6:52 PM
brooks updated the diff for D27609: ndis(4): remove as previous announced.
  • Remove Doxyfile
Dec 15 2020, 6:49 PM
brooks committed rS368671: hme(4): remove stray directories.
hme(4): remove stray directories
Dec 15 2020, 6:46 PM
brooks committed rS368670: Remove Doxyfiles for removed drivers.
Remove Doxyfiles for removed drivers
Dec 15 2020, 6:45 PM
brooks committed rP558115: Update to a new snapshot.
Update to a new snapshot
Dec 15 2020, 12:24 AM

Dec 14 2020

brooks committed rS368650: MFC r368561:.
MFC r368561:
Dec 14 2020, 10:53 PM
brooks committed rS368646: MFC r368561:.
MFC r368561:
Dec 14 2020, 10:08 PM
brooks committed rS368645: MFC r368543:.
MFC r368543:
Dec 14 2020, 10:03 PM
brooks committed rS368644: MFC r368543:.
MFC r368543:
Dec 14 2020, 9:56 PM
brooks accepted D27601: Rename NO_WERROR -> MK_WERROR=no.

MK_WERROR.clang=no is a bit weird, but it's not going to fit easily no matter what so using an odd spelling is probably for the best.

Dec 14 2020, 7:08 PM
brooks accepted D27602: Add mkimg to the list of bootstrap tools.
Dec 14 2020, 7:03 PM
brooks accepted D27598: Stop passing MK_WARNS=no for bootstrap tools.
Dec 14 2020, 6:45 PM
brooks requested review of D27609: ndis(4): remove as previous announced.
Dec 14 2020, 4:59 PM

Dec 13 2020

brooks committed R9:631ca6acca4d: Traditional first commit. Add self to developers section (authored by brooks).
Traditional first commit. Add self to developers section
Dec 13 2020, 7:35 PM
brooks committed R9:ee7cf2b080f5: Add my new committer entry. (authored by brooks).
Add my new committer entry.
Dec 13 2020, 7:35 PM
brooks committed R9:bc13973c72be: Put my entry in the correct location. (authored by brooks).
Put my entry in the correct location.
Dec 13 2020, 7:35 PM
brooks committed R9:6ffafca60ae3: Add my PGP key. (authored by brooks).
Add my PGP key.
Dec 13 2020, 7:27 PM
brooks committed R9:d7c39b4f07cd: Document the if_xname version bump. (authored by brooks).
Document the if_xname version bump.
Dec 13 2020, 6:56 PM
brooks committed R9:774460e760b1: Update my key to the unexired one and add more signatures. (authored by brooks).
Update my key to the unexired one and add more signatures.
Dec 13 2020, 6:51 PM
brooks committed R9:a47142019f21: Update my key again. This time hopefully without any expired subkeys. (authored by brooks).
Update my key again. This time hopefully without any expired subkeys.
Dec 13 2020, 6:50 PM
brooks committed R9:97156bfe533b: Reserve UID/GID 102 for the sysutils/ganglia-monitor-core port. (authored by brooks).
Reserve UID/GID 102 for the sysutils/ganglia-monitor-core port.
Dec 13 2020, 6:48 PM
brooks committed R9:5f26509af8b4: Reserve UID/GID 104 for audio/slimserver port. (authored by brooks).
Reserve UID/GID 104 for audio/slimserver port.
Dec 13 2020, 6:48 PM
brooks committed R9:de75dabbf028: Document __FreeBSD_version bump for network interface cloning API change. (authored by brooks).
Document __FreeBSD_version bump for network interface cloning API change.
Dec 13 2020, 6:45 PM
brooks committed R9:4d158d5c474f: Document __FreeBSD_version 600002 and 600003. Both are additions of (authored by brooks).
Document __FreeBSD_version 600002 and 600003. Both are additions of
Dec 13 2020, 6:40 PM
brooks committed R9:d3b7df951112: Begin documenting the limitations of some popular disk partitioning (authored by brooks).
Begin documenting the limitations of some popular disk partitioning
Dec 13 2020, 6:40 PM
brooks committed R9:427995e7a030: Document that __FreeBSD_version 600005 marks the addition of the "-d (authored by brooks).
Document that __FreeBSD_version 600005 marks the addition of the "-d
Dec 13 2020, 6:39 PM
brooks committed R9:625c3ac1c265: Add a few more items to the list. (authored by brooks).
Add a few more items to the list.
Dec 13 2020, 6:37 PM
brooks committed R9:91bda648ef0f: Move a couple comments from the task column to the nodes column. (authored by brooks).
Move a couple comments from the task column to the nodes column.
Dec 13 2020, 6:36 PM
brooks committed R9:e7304e751539: Stop scaring people with impossibly vague comments about lack of (authored by brooks).
Stop scaring people with impossibly vague comments about lack of
Dec 13 2020, 6:35 PM
brooks committed R9:448b5e363aca: Record desire for modern, Atheros based, PCI wireless card for testing. (authored by brooks).
Record desire for modern, Atheros based, PCI wireless card for testing.
Dec 13 2020, 6:34 PM
brooks committed R9:facd4f1e9bee: Daniel Seuffert funded my purchase of a D-Link DWL-AG530 for testing. (authored by brooks).
Daniel Seuffert funded my purchase of a D-Link DWL-AG530 for testing.
Dec 13 2020, 6:34 PM
brooks committed R9:7a10417ab5ee: Document the version bumps related to the change of ifi_epoch from wall (authored by brooks).
Document the version bumps related to the change of ifi_epoch from wall
Dec 13 2020, 6:33 PM
brooks committed R9:7bddbcaa08e7: Add performance tracking, web100, and if_var.h cleanup projects. (authored by brooks).
Add performance tracking, web100, and if_var.h cleanup projects.
Dec 13 2020, 6:29 PM