Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (309 w, 3 d)

Recent Activity

Yesterday

brooks accepted D25132: virtio: Support non-legacy network device and queue.
Fri, Jun 5, 4:53 PM
brooks accepted D25131: virtio_mmio: Negotiate the upper half of the feature bits too.

This seems reasonable.

Fri, Jun 5, 4:48 PM

Wed, Jun 3

brooks committed rP537629: Update to a more recent snapshot..
Update to a more recent snapshot.
Wed, Jun 3, 5:58 PM

Thu, May 28

brooks added reviewers for D25040: [mips] fix up the assembly generation of unaligned exception loads: jhb, arichardson.
Thu, May 28, 8:57 PM
brooks accepted D24949: add syscall for the nfs-over-tls daemons to use.
Thu, May 28, 6:16 PM

Wed, May 27

brooks added a comment to D24949: add syscall for the nfs-over-tls daemons to use.

Oops, forgot to "make sysent" before testing the last one.
Since the entry on compat/freebsd32/syscalls.master is NOSTD,
I needed to prepend "freebsd_" to the prototype name to
avoid a conflict.

Wed, May 27, 11:48 PM

Fri, May 22

brooks added a comment to D24949: add syscall for the nfs-over-tls daemons to use.

The key things I watch for in syscalls.master changes look fine.

Fri, May 22, 5:57 PM
brooks closed D24932: Support METALOG when calling certctl in installworld.
Fri, May 22, 5:45 PM
brooks committed rS361397: Add an unprivileged mode where calls to install are passed appropriate.
Add an unprivileged mode where calls to install are passed appropriate
Fri, May 22, 5:45 PM

Thu, May 21

brooks added a comment to D24932: Support METALOG when calling certctl in installworld.

I've added documentation. While the backlist command does support the new flags I've not documented it because I'm not convinced it makes sense and unblacklist doesn't support them.

Thu, May 21, 11:38 PM
brooks updated the diff for D24932: Support METALOG when calling certctl in installworld.
  • certctl: handle METALOG like install(1) does
  • Support NO_ROOT when calling certctl.
Thu, May 21, 11:37 PM
brooks added a comment to D24932: Support METALOG when calling certctl in installworld.

Given rS361149, I'll convert this review to one of the certctl changes and add docs.

Thu, May 21, 3:33 PM

Wed, May 20

brooks accepted D24936: Print CPU informtion later in boot..
Wed, May 20, 8:57 PM
brooks accepted D24928: Remove copyinfrom() and copyinstrfrom()..
Wed, May 20, 8:51 PM
brooks retitled D24932: Support METALOG when calling certctl in installworld from Support METALOG when calling certctl in installworld This is a pair of commits for conceptual review and is missing documentation and usage() updates to certctl. ---- certctl: handle METALOG like install(1) does to Support METALOG when calling certctl in installworld.
Wed, May 20, 8:41 PM
brooks accepted D24931: Simplify hot-patching cpu_switch() for lack of UserLocal register..
Wed, May 20, 6:34 PM
brooks accepted D24930: Merge freebsd32_exec_setregs() into exec_setregs() on MIPS..
Wed, May 20, 6:31 PM
brooks requested review of D24932: Support METALOG when calling certctl in installworld.
Wed, May 20, 6:19 PM

Wed, May 13

brooks updated the test plan for D24827: riscv: Fix pmap_protect for superpages.
Wed, May 13, 4:51 PM

Tue, May 12

brooks accepted D24785: Avoid using non-portable dd status=none flag.
Tue, May 12, 5:58 PM

May 6 2020

brooks committed rS360695: MFC r359974:.
MFC r359974:
May 6 2020, 5:42 PM
brooks committed rS360693: MFC r359974:.
MFC r359974:
May 6 2020, 5:12 PM
brooks accepted D24730: virtio: Support MMIO bus for all devices.
May 6 2020, 5:08 PM
brooks accepted D24681: virtio_mmio: Support non-transitional version 2 devices.
May 6 2020, 5:07 PM

May 4 2020

brooks added reviewers for D24681: virtio_mmio: Support non-transitional version 2 devices: andrew, kp.

Looks good at a glance. Adding a couple more potential reviewers.

May 4 2020, 8:31 PM
brooks committed rS360635: Set LG_VADDR to 48 on RISC-V..
Set LG_VADDR to 48 on RISC-V.
May 4 2020, 5:16 PM

May 1 2020

brooks added a comment to D24658: Set LG_VADDR to 48 on RISC-V..

There should likely be a corresponding change to the configure script upstream (probably duplicating the arm64 case).

May 1 2020, 10:12 PM
brooks added a reviewer for D24658: Set LG_VADDR to 48 on RISC-V.: mhorne.
May 1 2020, 10:11 PM

Apr 28 2020

brooks committed rS360451: MFC r359937:.
MFC r359937:
Apr 28 2020, 8:15 PM
brooks committed rS360446: MFC r359937:.
MFC r359937:
Apr 28 2020, 6:00 PM

Apr 27 2020

brooks committed rS360415: MFC r359978:.
MFC r359978:
Apr 27 2020, 11:49 PM
brooks committed rS360414: MFC r359978:.
MFC r359978:
Apr 27 2020, 11:48 PM
brooks accepted D24567: Don't run strcmp() against strings stored in user memory..
Apr 27 2020, 5:18 PM

Apr 24 2020

brooks accepted D24562: Don't indirect user pointers directly in two 802.11s ioctls..

sigh

Apr 24 2020, 8:41 PM

Apr 23 2020

brooks committed rS360225: MFC r359938:.
MFC r359938:
Apr 23 2020, 5:46 PM

Apr 22 2020

brooks committed rP532493: Create and use a tests group for the tests user..
Create and use a tests group for the tests user.
Apr 22 2020, 6:01 PM
brooks committed rS360200: MFC r359938:.
MFC r359938:
Apr 22 2020, 5:14 PM

Apr 21 2020

brooks added a comment to D24018: fix debug.kdb.enter=1 with dtrace-enabled kernel.

Any reason not to land this?

Apr 21 2020, 5:13 PM

Apr 20 2020

brooks accepted D24489: Don't pass a user buffer pointer as the data pointer in a CCB..

Modulo accepting or rejecting @imp's suggestion this looks good.

Apr 20 2020, 5:08 PM

Apr 16 2020

brooks accepted D24457: Use the right type for 64-bit coprocessor registers..
Apr 16 2020, 11:39 PM
brooks committed rS360024: Convert canary, execpathp, and pagesizes to pointers..
Convert canary, execpathp, and pagesizes to pointers.
Apr 16 2020, 9:53 PM
brooks closed D24446: Convert canary, execpathp, and pagesizes to pointers..
Apr 16 2020, 9:53 PM
brooks added a comment to D24446: Convert canary, execpathp, and pagesizes to pointers..

Successful CI run https://cirrus-ci.com/task/4829231964225536

Apr 16 2020, 9:49 PM
brooks created D24446: Convert canary, execpathp, and pagesizes to pointers..
Apr 16 2020, 6:07 PM
brooks committed rS360015: style(9): end continued line with operator..
style(9): end continued line with operator.
Apr 16 2020, 5:24 PM
brooks added a comment to D24407: Export argc, argv, envc, envv, and ps_strings in auxargs..

How does this relate to D16111?

Apr 16 2020, 3:58 PM

Apr 15 2020

brooks committed rS359991: Attempt to use AT_PS_STRINGS to get the ps_strings pointer..
Attempt to use AT_PS_STRINGS to get the ps_strings pointer.
Apr 15 2020, 8:28 PM
brooks committed rS359990: Support AT_PS_STRINGS in _elf_aux_info()..
Support AT_PS_STRINGS in _elf_aux_info().
Apr 15 2020, 8:26 PM
brooks committed rS359989: Add procstat support for AT_ flags added in r359988..
Add procstat support for AT_ flags added in r359988.
Apr 15 2020, 8:25 PM
brooks committed rS359988: Export argc, argv, envc, envv, and ps_strings in auxargs..
Export argc, argv, envc, envv, and ps_strings in auxargs.
Apr 15 2020, 8:24 PM
brooks closed D24407: Export argc, argv, envc, envv, and ps_strings in auxargs..
Apr 15 2020, 8:24 PM
brooks committed rS359987: Make ps_strings in struct image_params into a pointer..
Make ps_strings in struct image_params into a pointer.
Apr 15 2020, 8:21 PM
brooks committed rS359986: Introduce an AUXARGS_ENTRY_PTR() macro..
Introduce an AUXARGS_ENTRY_PTR() macro.
Apr 15 2020, 8:20 PM
brooks committed rS359978: Fix -Wvoid-pointer-to-enum-cast warnings..
Fix -Wvoid-pointer-to-enum-cast warnings.
Apr 15 2020, 6:16 PM
brooks closed D24425: Fix -Wvoid-pointer-to-enum-cast warnings..
Apr 15 2020, 6:16 PM
brooks added a comment to D24410: Don't directly access userspace memory..
In D24410#537510, @imp wrote:

Yikes!

Apr 15 2020, 4:36 PM
brooks committed rS359974: Don't directly access userspace memory..
Don't directly access userspace memory.
Apr 15 2020, 4:33 PM
brooks closed D24410: Don't directly access userspace memory..
Apr 15 2020, 4:33 PM

Apr 14 2020

brooks created D24425: Fix -Wvoid-pointer-to-enum-cast warnings..
Apr 14 2020, 10:21 PM
brooks accepted D24420: devel/llvm90: backport --target fix for libc++.

I usually strip the tests part of patches since we don't do anything with them, but this is fine.

Apr 14 2020, 9:41 PM
brooks closed D24409: Remove bogus use of useracc() in (clock_)nanosleep..
Apr 14 2020, 8:53 PM
brooks committed rS359938: Remove bogus use of useracc() in (clock_)nanosleep..
Remove bogus use of useracc() in (clock_)nanosleep.
Apr 14 2020, 8:53 PM
brooks committed rS359937: Centralize compatability translation macros..
Centralize compatability translation macros.
Apr 14 2020, 8:31 PM
brooks closed D24275: Centralize compatability translation macros..
Apr 14 2020, 8:31 PM
brooks added a comment to D24409: Remove bogus use of useracc() in (clock_)nanosleep..

CI run https://cirrus-ci.com/task/6577255742701568

Apr 14 2020, 4:11 PM
brooks added a comment to D24407: Export argc, argv, envc, envv, and ps_strings in auxargs..

Successful amd64 CI build https://cirrus-ci.com/task/5249932466585600

Apr 14 2020, 3:56 PM
brooks added a comment to D24407: Export argc, argv, envc, envv, and ps_strings in auxargs..
In D24407#536889, @kib wrote:

Could you please extract two changes into separate commits:

  1. change of the impg ps_strings type
  2. addition of AUXARGS_ENTRY_PTR

Then the rest would be much cleaner.

Apr 14 2020, 3:41 PM

Apr 13 2020

brooks accepted D24405: Allow kernel modules to build with a compiler that defaults to -fno-common.
Apr 13 2020, 11:57 PM
brooks created D24410: Don't directly access userspace memory..
Apr 13 2020, 11:56 PM
brooks created D24409: Remove bogus use of useracc() in (clock_)nanosleep..
Apr 13 2020, 11:10 PM
brooks added a comment to D24407: Export argc, argv, envc, envv, and ps_strings in auxargs..

Note that this will be committed in five commits (change ps_strings type, add and export new values, procstat support, _elf_aux_info, setproctitle).

Apr 13 2020, 11:00 PM
brooks retitled D24407: Export argc, argv, envc, envv, and ps_strings in auxargs. from Make ps_strings in struct image_params into a pointer. to Export argc, argv, envc, envv, and ps_strings in auxargs..
Apr 13 2020, 10:57 PM
brooks created D24407: Export argc, argv, envc, envv, and ps_strings in auxargs..
Apr 13 2020, 10:56 PM
brooks committed rP531618: MFH: r531333.
MFH: r531333
Apr 13 2020, 5:07 PM

Apr 10 2020

brooks accepted D24368: Export a sysctl count of RX FIFO overrun events..
Apr 10 2020, 8:09 PM
brooks added inline comments to D24368: Export a sysctl count of RX FIFO overrun events..
Apr 10 2020, 5:24 PM
brooks committed rP531333: Fix bitrotted code..
Fix bitrotted code.
Apr 10 2020, 4:55 PM

Apr 9 2020

brooks abandoned D20552: Correct the type of the func argument of zk_thread_create()..

OpenZFS will arrive and fix this soon enough

Apr 9 2020, 10:31 PM

Apr 8 2020

brooks updated the diff for D24275: Centralize compatability translation macros..
  • Use a less generic name for the header (abi_compat.h).
Apr 8 2020, 8:43 PM
brooks added a comment to D24275: Centralize compatability translation macros..
In D24275#535453, @cem wrote:

For the generic CP() type copy operations, I'd suggest _Static_assert size checks. Exceptions can have an exceptional copy mechanism (maybe provided here).

Apr 8 2020, 8:39 PM
brooks updated the diff for D24275: Centralize compatability translation macros..
  • Improve whitespace and use a consistant style.
Apr 8 2020, 8:33 PM

Apr 7 2020

brooks committed rP531039: Revert upstream 18bfb3a..
Revert upstream 18bfb3a.
Apr 7 2020, 10:00 PM
brooks committed rS359691: Allow the kernel to build with a compiler that sets -fno-common..
Allow the kernel to build with a compiler that sets -fno-common.
Apr 7 2020, 3:32 PM
brooks closed D24322: Allow the kernel to build with a compiler that sets -fno-common..
Apr 7 2020, 3:32 PM

Apr 6 2020

brooks closed D17002: Fix compilation with upstream clang builtin headers.
Apr 6 2020, 11:38 PM
brooks committed rS359681: Fix compilation with upstream clang builtin headers..
Fix compilation with upstream clang builtin headers.
Apr 6 2020, 11:38 PM
brooks added a comment to D24322: Allow the kernel to build with a compiler that sets -fno-common..

The values are also quite different if you diff the nm output. I think this whole thing will need to be rethought eventually, but removing -fcommon is probably a long ways off.

Apr 6 2020, 10:40 PM
brooks created D24322: Allow the kernel to build with a compiler that sets -fno-common..
Apr 6 2020, 10:35 PM
brooks added a comment to D24275: Centralize compatability translation macros..

Current version passes universe (except for an unrelated config error on riscv).

Apr 6 2020, 3:45 PM

Apr 3 2020

brooks added a comment to D24275: Centralize compatability translation macros..

CI run without the last mps fix: https://cirrus-ci.com/task/5297194320265216

Apr 3 2020, 11:53 PM
brooks updated the diff for D24275: Centralize compatability translation macros..

unfoobar diff after arc malfunction.

Apr 3 2020, 11:49 PM
brooks updated the diff for D24275: Centralize compatability translation macros..
  • mpr: we need PTRIN unconditionally
Apr 3 2020, 11:48 PM
brooks created D24275: Centralize compatability translation macros..
Apr 3 2020, 9:42 PM
brooks updated the diff for D24246: Add a timeline for unmentoring..
  • Another typo fix.
Apr 3 2020, 4:28 PM
brooks committed rS359603: Pass the real value of MK_TESTS_SUPPORT to distribution..
Pass the real value of MK_TESTS_SUPPORT to distribution.
Apr 3 2020, 4:19 PM
brooks closed D24268: Pass the real value of MK_TESTS_SUPPORT to distribution..
Apr 3 2020, 4:19 PM
brooks committed rS359601: pmc: diable position-independent builds, they fail to link on amd64.
pmc: diable position-independent builds, they fail to link on amd64
Apr 3 2020, 4:11 PM
brooks added a reviewer for D24268: Pass the real value of MK_TESTS_SUPPORT to distribution.: arichardson.
Apr 3 2020, 3:48 PM
brooks committed rS359598: Install a kyua.conf based on the one in devel/kyua..
Install a kyua.conf based on the one in devel/kyua.
Apr 3 2020, 3:47 PM
brooks closed D24267: Install a kyua.conf based on the one in devel/kyua..
Apr 3 2020, 3:47 PM