brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (199 w, 1 d)

Recent Activity

Today

brooks committed rS332997: Translate 32-bit ifmedia requests into native ones..
Translate 32-bit ifmedia requests into native ones.
Wed, Apr 25, 3:31 PM
brooks closed D14996: Translate 32-bit ifmedia requests into native ones..
Wed, Apr 25, 3:31 PM

Yesterday

brooks accepted D15182: Add deprecation notice for lmc(4).

Looks good to me.

Tue, Apr 24, 3:50 PM

Mon, Apr 23

brooks committed rS332895: Finish removing FDDI and tokenring media support..
Finish removing FDDI and tokenring media support.
Mon, Apr 23, 9:10 PM
brooks closed D15170: Finish removing FDDI and tokenring media support..
Mon, Apr 23, 9:10 PM
brooks added reviewers for D15170: Finish removing FDDI and tokenring media support.: emaste, kib.
Mon, Apr 23, 6:48 PM
brooks updated the summary of D15170: Finish removing FDDI and tokenring media support..
Mon, Apr 23, 6:35 PM
brooks updated the summary of D15170: Finish removing FDDI and tokenring media support..
Mon, Apr 23, 6:33 PM
brooks created D15170: Finish removing FDDI and tokenring media support..
Mon, Apr 23, 3:34 PM

Fri, Apr 20

brooks committed rP467849: Merge r332833 from FreeBSD HEAD..
Merge r332833 from FreeBSD HEAD.
Fri, Apr 20, 10:46 PM

Thu, Apr 19

brooks added a comment to D14996: Translate 32-bit ifmedia requests into native ones..

I've retested the revised version of this change and it's working fine.

Thu, Apr 19, 10:40 PM
brooks committed rS332796: Add sortbench..
Add sortbench.
Thu, Apr 19, 9:54 PM
brooks closed D12677: Add sortbench..
Thu, Apr 19, 9:54 PM
brooks committed rS332792: Replace SOFTFLOAT with __riscv_float_abi_*..
Replace SOFTFLOAT with __riscv_float_abi_*.
Thu, Apr 19, 8:36 PM
brooks closed D10039: Replace SOFTFLOAT with __riscv_float_abi_*..
Thu, Apr 19, 8:36 PM
brooks committed rP467792: Update to a new snapshot with support for new instructions..
Update to a new snapshot with support for new instructions.
Thu, Apr 19, 5:43 PM
brooks committed rP467789: Remove a needless include of vm/pmap.h which broke the i386 build with.
Remove a needless include of vm/pmap.h which broke the i386 build with
Thu, Apr 19, 5:02 PM
brooks committed rP467786: Remove a needless include of vm/pmap.h which broke the i386 build with.
Remove a needless include of vm/pmap.h which broke the i386 build with
Thu, Apr 19, 4:54 PM

Wed, Apr 18

brooks updated the diff for D10039: Replace SOFTFLOAT with __riscv_float_abi_*..
  • Rebase.
  • Remove another instance of SOFTFLOAT.
Wed, Apr 18, 9:14 PM
brooks committed rP467737: Remove a needless include of vm/pmap.h which broke the i386 build with.
Remove a needless include of vm/pmap.h which broke the i386 build with
Wed, Apr 18, 9:06 PM

Tue, Apr 17

brooks committed rS332660: Remove references to fs_nofault_intr_begin/end..
Remove references to fs_nofault_intr_begin/end.
Tue, Apr 17, 10:30 PM
brooks updated the diff for D14996: Translate 32-bit ifmedia requests into native ones..
  • Fix !COMPAT_FREEBSD32 builds post rebase.
Tue, Apr 17, 9:36 PM
brooks added a comment to D10039: Replace SOFTFLOAT with __riscv_float_abi_*..

@br is this change sensible or should I abandon it?

Tue, Apr 17, 8:41 PM
brooks updated the diff for D14996: Translate 32-bit ifmedia requests into native ones..
  • Rebase.
Tue, Apr 17, 6:47 PM
brooks committed rS332656: Remove the unused fuwintr() and suiwintr() functions..
Remove the unused fuwintr() and suiwintr() functions.
Tue, Apr 17, 6:04 PM
brooks closed D15102: Remove the unused fuwintr() and suiwintr() functions..
Tue, Apr 17, 6:04 PM
brooks updated the summary of D15102: Remove the unused fuwintr() and suiwintr() functions..
Tue, Apr 17, 6:03 PM
brooks committed rS332654: Remove unused implementations of copyoutstr()..
Remove unused implementations of copyoutstr().
Tue, Apr 17, 5:20 PM
brooks closed D15108: Remove unused implementations of copyoutstr..
Tue, Apr 17, 5:20 PM
brooks retitled D15108: Remove unused implementations of copyoutstr. from Remove the two implementations of copyoutstr. to Remove unused implementations of copyoutstr..
Tue, Apr 17, 4:38 PM
brooks committed rS332650: Stop using fuswintr() and suswintr() in the profiler..
Stop using fuswintr() and suswintr() in the profiler.
Tue, Apr 17, 4:37 PM
brooks closed D15101: Stop using fuswintr() and suswintr() in the profiler..
Tue, Apr 17, 4:37 PM
brooks retitled D15101: Stop using fuswintr() and suswintr() in the profiler. from Stop using fuswintr() and suswintr(). to Stop using fuswintr() and suswintr() in the profiler..
Tue, Apr 17, 4:09 PM
brooks updated the diff for D15102: Remove the unused fuwintr() and suiwintr() functions..
  • Add MLINKS to OLD_FILES.
Tue, Apr 17, 3:39 PM

Mon, Apr 16

brooks added a comment to D15108: Remove unused implementations of copyoutstr..

Did we come by that as a NetBSDism? Looks good to me.

Mon, Apr 16, 10:18 PM
brooks created D15108: Remove unused implementations of copyoutstr..
Mon, Apr 16, 10:04 PM
brooks updated the diff for D15101: Stop using fuswintr() and suswintr() in the profiler..
  • Don't compute things that aren't used in addupc_intr().
  • Update commment on addupc_task().
Mon, Apr 16, 9:39 PM
brooks committed rP467533: Update to a new snapshot..
Update to a new snapshot.
Mon, Apr 16, 8:57 PM
brooks committed rS332630: Remove support for FDDI and token ring media types in userland utilities..
Remove support for FDDI and token ring media types in userland utilities.
Mon, Apr 16, 6:08 PM
brooks closed D15077: Remove support for FDDI and token ring media types in userland utilities..
Mon, Apr 16, 6:08 PM
brooks created D15102: Remove the unused fuwintr() and suiwintr() functions..
Mon, Apr 16, 5:56 PM
brooks created D15101: Stop using fuswintr() and suswintr() in the profiler..
Mon, Apr 16, 5:53 PM
brooks committed rS332629: Remove unused badaddr() function..
Remove unused badaddr() function.
Mon, Apr 16, 5:43 PM
brooks closed D15078: Remove unused badaddr() function..
Mon, Apr 16, 5:43 PM

Sun, Apr 15

brooks created D15078: Remove unused badaddr() function..
Sun, Apr 15, 5:21 PM
brooks created D15077: Remove support for FDDI and token ring media types in userland utilities..
Sun, Apr 15, 5:16 PM
brooks committed rS332490: Remove support for the Arcnet protocol..
Remove support for the Arcnet protocol.
Sun, Apr 15, 3:47 PM
brooks closed D15057: Remove support for the Arcnet protocol..
Sun, Apr 15, 3:46 PM
brooks added 1 commit(s) for D15057: Remove support for the Arcnet protocol.: rS332514: Manpages are .gz files..
Sun, Apr 15, 3:45 PM
brooks added an edge to rS332514: Manpages are .gz files.: D15057: Remove support for the Arcnet protocol..
Sun, Apr 15, 3:45 PM
brooks added an edge to rS332500: sys: remove 'cm' from notes: D15057: Remove support for the Arcnet protocol..
Sun, Apr 15, 3:45 PM
brooks added 2 commit(s) for D15057: Remove support for the Arcnet protocol.: rS332500: sys: remove 'cm' from notes, rS332512: Remove device cm which was removed in r332490..
Sun, Apr 15, 3:45 PM
brooks added an edge to rS332512: Remove device cm which was removed in r332490.: D15057: Remove support for the Arcnet protocol..
Sun, Apr 15, 3:45 PM
brooks added a comment to D15057: Remove support for the Arcnet protocol..

Committed in rS332490, followups in rS332500, rS332512 , and rS332514.

Sun, Apr 15, 3:43 PM
brooks committed rS332514: Manpages are .gz files..
Manpages are .gz files.
Sun, Apr 15, 3:24 PM
brooks closed D15074: Remove cm(4) following r332490 and r332500.
Sun, Apr 15, 3:14 PM
brooks accepted D15074: Remove cm(4) following r332490 and r332500.

Committed independently in rS332512.

Sun, Apr 15, 3:14 PM
brooks committed rS332512: Remove device cm which was removed in r332490..
Remove device cm which was removed in r332490.
Sun, Apr 15, 3:06 PM

Fri, Apr 13

brooks committed rS332493: MFC r332088:.
MFC r332088:
Fri, Apr 13, 10:32 PM
brooks added a comment to D15057: Remove support for the Arcnet protocol..

tinderbox passes (excluding arches that have been broken for a while)

Fri, Apr 13, 7:45 PM
brooks committed rS332488: Fix build on 32-bit systems..
Fix build on 32-bit systems.
Fri, Apr 13, 7:43 PM
brooks updated the summary of D15057: Remove support for the Arcnet protocol..
Fri, Apr 13, 5:55 PM
brooks created D15057: Remove support for the Arcnet protocol..
Fri, Apr 13, 3:16 PM
brooks committed rS332412: Remove support for FDDI networks..
Remove support for FDDI networks.
Fri, Apr 13, 12:25 AM
brooks closed D15017: Remove support for FDDI networks..

Committed in rS332412.

Fri, Apr 13, 12:22 AM

Thu, Apr 12

brooks committed rS332445: Add fpa.4.gz missing in the removal of FDDI in r332412..
Add fpa.4.gz missing in the removal of FDDI in r332412.
Thu, Apr 12, 6:26 PM
brooks committed rS332444: Allow -DNO_CLEAN builds across r332443..
Allow -DNO_CLEAN builds across r332443.
Thu, Apr 12, 6:24 PM
brooks committed rS332443: Replace MD assembly exect() with a portable version..
Replace MD assembly exect() with a portable version.
Thu, Apr 12, 6:23 PM
brooks closed D14989: Replace exect() with a portable version.
Thu, Apr 12, 6:23 PM
brooks accepted D14989: Replace exect() with a portable version.
Thu, Apr 12, 5:25 PM
brooks accepted D14989: Replace exect() with a portable version.

I believe this won't apply due to my removal of the arch specific setlogin.S files. If you don't get to it by the time I look at it tomorrow, I'll fix it up when I commit.

Thu, Apr 12, 12:00 AM

Wed, Apr 11

brooks added inline comments to D14989: Replace exect() with a portable version.
Wed, Apr 11, 8:10 PM
brooks updated the diff for D14996: Translate 32-bit ifmedia requests into native ones..
  • Only use extra storage in compat mode and use the stack for the temporary.
Wed, Apr 11, 8:05 PM

Mon, Apr 9

brooks committed rS332343: Refactor PCIOCGETCONF for improved readability..
Refactor PCIOCGETCONF for improved readability.
Mon, Apr 9, 10:59 PM
brooks closed D14978: Refactor PCIOCGETCONF for improved readability..
Mon, Apr 9, 10:59 PM
brooks added reviewers for D15017: Remove support for FDDI networks.: kib, jhb, imp.

Tinderbox builds (to the extent that it currently builds) so this is ready for review.

Mon, Apr 9, 10:15 PM
brooks updated the diff for D15017: Remove support for FDDI networks..
  • Rebase.
  • Add a proto UPDATING message.
Mon, Apr 9, 10:14 PM
brooks added reviewers for D14996: Translate 32-bit ifmedia requests into native ones.: kib, jhb.

This version works with an i386 ifconfig binary and is ready for review.

Mon, Apr 9, 10:11 PM
brooks updated the diff for D14996: Translate 32-bit ifmedia requests into native ones..
  • Always exit via the same path so we can re-convert ifmediareqs.
Mon, Apr 9, 6:42 PM
brooks committed rS332332: MFC r332151:.
MFC r332151:
Mon, Apr 9, 4:33 PM
brooks committed rS332331: Fix wl(4) after r332288..
Fix wl(4) after r332288.
Mon, Apr 9, 4:18 PM
brooks committed rS332329: MFC r332151:.
MFC r332151:
Mon, Apr 9, 3:22 PM

Sun, Apr 8

brooks committed rS332295: MFC r332087:.
MFC r332087:
Sun, Apr 8, 5:23 PM
brooks committed rS332294: MFC r332087:.
MFC r332087:
Sun, Apr 8, 5:19 PM
brooks committed rS332293: Fix LINT (and static COMPAT_LINUX32) after r332122..
Fix LINT (and static COMPAT_LINUX32) after r332122.
Sun, Apr 8, 5:10 PM
brooks committed rS332291: MFC r331737:.
MFC r331737:
Sun, Apr 8, 5:03 PM
brooks committed rS332290: GC never enabled support for SIOCGADDRROM and SIOCGCHIPID..
GC never enabled support for SIOCGADDRROM and SIOCGCHIPID.
Sun, Apr 8, 4:59 PM
brooks committed rS332288: MFC r331797:.
MFC r331797:
Sun, Apr 8, 4:54 PM
brooks updated the diff for D14978: Refactor PCIOCGETCONF for improved readability..
  • Expand CASE_PCIOCGETCONF inplace and remove the defintion.
Sun, Apr 8, 4:30 PM
brooks committed rS332281: MFC r331641, r331644, r332158.
MFC r331641, r331644, r332158
Sun, Apr 8, 3:52 PM
brooks created D15017: Remove support for FDDI networks..
Sun, Apr 8, 3:50 PM
brooks committed rS332280: MFC r331654, r331869.
MFC r331654, r331869
Sun, Apr 8, 3:36 PM
brooks committed rS332279: MFC r331654, r331869.
MFC r331654, r331869
Sun, Apr 8, 3:31 PM

Sat, Apr 7

brooks committed rS332161: MFC r331651-r331653.
MFC r331651-r331653
Sat, Apr 7, 12:24 AM
brooks created D14996: Translate 32-bit ifmedia requests into native ones..
Sat, Apr 7, 12:07 AM
brooks committed rS332160: MFC r331648:.
MFC r331648:
Sat, Apr 7, 12:04 AM

Fri, Apr 6

brooks committed rS332159: MFC r331648:.
MFC r331648:
Fri, Apr 6, 11:32 PM
brooks committed rS332158: Remove the thread argument from ifr_buffer_*() accessors..
Remove the thread argument from ifr_buffer_*() accessors.
Fri, Apr 6, 11:26 PM
brooks added a comment to D14989: Replace exect() with a portable version.

Well I made a few test cases to verify to myself all the differences and it turns out exect() doesn't even work on 11. It generates a trace fault in the original image and then stops generating faults in the new image.

exec_setregs() zeros out the registers then tries to maintain the value of regs->tf_eflags. Nothing in eflags appears to be preserved.
https://github.com/freebsd/freebsd/blob/master/sys/amd64/amd64/machdep.c#L596
https://github.com/freebsd/freebsd/blob/master/sys/i386/i386/machdep.c#L1130

https://svnweb.freebsd.org/base/head/sys/i386/i386/machdep.c?r1=4193&r2=4201

Unless something else has changed it seems we have a 23 year old regression?

Should I remove the dead kernel code as part of this change?

Fri, Apr 6, 10:18 PM
brooks added a comment to D14989: Replace exect() with a portable version.

Could it be this works on i386 only?

Fri, Apr 6, 10:08 PM