Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (294 w, 16 h)

Recent Activity

Yesterday

brooks created D23748: Define SCTL_MASK32 when COMPAT_FREEBSD32 is defined..
Tue, Feb 18, 10:05 PM
brooks committed rS358084: MFC r357788:.
MFC r357788:
Tue, Feb 18, 9:37 PM

Mon, Feb 17

brooks committed rP526436: Update to rc2..
Update to rc2.
Mon, Feb 17, 11:30 PM

Wed, Feb 12

brooks committed rP525984: Replace /usr/local with ${LOCALBASE}.
Replace /usr/local with ${LOCALBASE}
Wed, Feb 12, 11:31 PM
brooks committed rS357837: MFC r356942:.
MFC r356942:
Wed, Feb 12, 6:49 PM
brooks committed rS357836: MFC r356942:.
MFC r356942:
Wed, Feb 12, 6:40 PM
brooks committed rS357834: Make the warning for deprecated NO_ variables an error..
Make the warning for deprecated NO_ variables an error.
Wed, Feb 12, 6:09 PM
brooks committed rS357788: Mark hme(4) as deprecated..
Mark hme(4) as deprecated.
Wed, Feb 12, 12:58 AM

Tue, Feb 11

brooks committed rP525893: Restore the clang EXTRAS option..
Restore the clang EXTRAS option.
Tue, Feb 11, 11:52 PM
brooks closed D23583: Fix build for LLVM 10.0.0rc1 extras.
Tue, Feb 11, 11:52 PM · Contributor Reviewers (ports)
brooks accepted D23583: Fix build for LLVM 10.0.0rc1 extras.

Thanks for the submission, I'll commit shortly (with a small tweak to the lua bits).

Tue, Feb 11, 11:47 PM · Contributor Reviewers (ports)

Fri, Feb 7

brooks added inline comments to D23574: vfs: add realpath(2).
Fri, Feb 7, 7:41 PM
brooks added inline comments to D23574: vfs: add realpath(2).
Fri, Feb 7, 7:31 PM

Wed, Feb 5

brooks added a comment to D23527: Remove elf2aout.

It seems like there's a missing change to usr.bin/Makefile.

Wed, Feb 5, 11:40 PM

Mon, Feb 3

brooks committed rP525098: Fix: files/lld directory was removed due to a commit hook..
Fix: files/lld directory was removed due to a commit hook.
Mon, Feb 3, 9:39 PM

Sat, Feb 1

brooks committed rP524748: Add LLVM 10.0.0rc1.
Add LLVM 10.0.0rc1
Sat, Feb 1, 1:05 AM

Fri, Jan 31

brooks added a comment to D23124: 2020-02-29 rm GCC 4.2.1 build infrastructure.

Won't that completely stop working the moment we remove gcc 4.2.1?

Fri, Jan 31, 12:47 AM
brooks added a comment to D23124: 2020-02-29 rm GCC 4.2.1 build infrastructure.
In D23124#514059, @imp wrote:
In D23124#514030, @jhb wrote:

So one question I have is if 'make xdev' makes sense in a clang world? clang is already a cross-compiler via -target. Probably not for this change, but if 'make xdev' is now obsolete it might be nice to GC those bits as a followup.

It's used in package building. There, cc needs to generate the target's binaries w/o a lot of ability to intercept. We'd have to rework that stuff to be a series of shell scripts to be a drop in. This is in the context of the arm jail on a amd64 host. We drop the amd64 binaries into that for better performance. so definitely not for this change.

Fri, Jan 31, 12:41 AM

Thu, Jan 30

brooks committed rS357303: Fix an indentation bug in r357169..
Fix an indentation bug in r357169.
Thu, Jan 30, 6:34 PM

Wed, Jan 29

brooks committed rP524562: Fix plist that I somehow botched in the last merge..
Fix plist that I somehow botched in the last merge.
Wed, Jan 29, 6:16 PM

Thu, Jan 23

brooks committed rS357037: Enable commit access for James Clarke (jrtc27)..
Enable commit access for James Clarke (jrtc27).
Thu, Jan 23, 8:45 AM

Wed, Jan 22

brooks created D23314: Remove chat(8)..
Wed, Jan 22, 12:07 PM

Tue, Jan 21

brooks committed rS356942: Correct a misleading indent..
Correct a misleading indent.
Tue, Jan 21, 4:31 PM
brooks committed rP523714: MFH: r523228 r523234 r523575.
MFH: r523228 r523234 r523575
Tue, Jan 21, 10:54 AM
brooks added a comment to D23280: Fix nmtree crashing with duplicate items.

You seem to be manually uploading diffs rather than using arcanist and the diff is now against your previous version not against the freebsd tree...

Tue, Jan 21, 8:05 AM

Mon, Jan 20

brooks added a comment to D23280: Fix nmtree crashing with duplicate items.

This should be submitted to NetBSD so we don't have to maintain a local diff.

Mon, Jan 20, 5:27 PM

Jan 19 2020

brooks committed rP523575: Update to a new snapshot (welcome to LLVM 11)..
Update to a new snapshot (welcome to LLVM 11).
Jan 19 2020, 1:55 PM
brooks abandoned D23251: Correct the default initial thread stack size..

Bah, I did indeed misread the code.

Jan 19 2020, 8:49 AM

Jan 18 2020

brooks added reviewers for D23251: Correct the default initial thread stack size.: kib, markj.
Jan 18 2020, 8:59 PM
brooks created D23251: Correct the default initial thread stack size..
Jan 18 2020, 7:36 PM
brooks accepted D23197: sysent targets: further cleanup and deduplication.

Looks great

Jan 18 2020, 5:28 PM

Jan 17 2020

brooks added reviewers for D23164: Introduce kern_mmap_req().: kevans, jhb.

I've done limited testing (booted an amd64) system with this patch. I chose to remove kern_mmap_fpcheck entirely, but could restore it if that feels like a cleaner option.

Jan 17 2020, 1:55 PM
brooks accepted D23229: Build hard-float lib32 for mips64hf/mips64elhf.

LGTM

Jan 17 2020, 11:50 AM
brooks added a comment to D23197: sysent targets: further cleanup and deduplication.

I see that cheri also has a clean target in ^/sys/compat/cheriabi/Makefile; would it make sense to go ahead and add one to this common Makefile while I'm at it? It doesn't feel generally useful, but it also isn't harmful and the target would effectively just be rm -f ${GENERATED} at this point, and that Makefile could also probably use a similar (edit: cleanup, like these) with GENERATED_PREFIX=cheriabi_. (Even if it doesn't, I note that the sysent target is missing dependency on cheriabi_syscalls.c, not that it matters all that much)

Jan 17 2020, 7:54 AM

Jan 16 2020

brooks committed rP523228: Attempt to fix build on 11 (i386 and amd64) and 12 (i386)..
Attempt to fix build on 11 (i386 and amd64) and 12 (i386).
Jan 16 2020, 1:09 PM
brooks accepted D23204: Use clang and lld as the default toolchain for MIPS..

This seems fine. I don't think there's much evidence that anyone currently cares about n32.

Jan 16 2020, 12:44 PM
brooks accepted D23202: Allow bootstrapping mkimg on macOS/Linux.
Jan 16 2020, 11:03 AM
brooks accepted D23201: Allow bootstrapping makefs on older FreeBSD hosts and Linux/mac.
Jan 16 2020, 11:01 AM
brooks accepted D23197: sysent targets: further cleanup and deduplication.

Very nice cleanup.

Jan 16 2020, 9:14 AM

Jan 14 2020

brooks added inline comments to D23164: Introduce kern_mmap_req()..
Jan 14 2020, 5:29 AM
brooks added a comment to D23164: Introduce kern_mmap_req()..

Compiles, but needs testing.

Jan 14 2020, 5:22 AM
brooks updated the summary of D23164: Introduce kern_mmap_req()..
Jan 14 2020, 5:21 AM
brooks created D23164: Introduce kern_mmap_req()..
Jan 14 2020, 5:19 AM
brooks accepted D23059: Preserve the inherited value of the status register in cpu_set_upcall()..

This seems sensible.

Jan 14 2020, 4:28 AM
brooks accepted D23124: 2020-02-29 rm GCC 4.2.1 build infrastructure.
Jan 14 2020, 4:27 AM

Jan 10 2020

brooks added inline comments to D23124: 2020-02-29 rm GCC 4.2.1 build infrastructure.
Jan 10 2020, 10:23 PM
brooks accepted D23123: retire LLVM_LIBUNWIND option.
Jan 10 2020, 10:13 PM
brooks accepted D23122: retire BSD_CRTBEGIN option.

LGTM

Jan 10 2020, 10:08 PM
brooks added inline comments to D23096: [PowerPC] libc backwards compatibility shim for auxv change.
Jan 10 2020, 5:49 PM · PowerPC

Jan 9 2020

brooks added a comment to D23114: Document two new conventions:.

I'd rather see use switch to static_assert since that's in C11 and C++11. It's a bit unfortunate that only C++17 has the single argument version though.

Jan 9 2020, 10:57 PM
brooks accepted D23099: Set .ORDER for makesyscalls generated files.
Jan 9 2020, 6:47 PM
brooks added a comment to D23099: Set .ORDER for makesyscalls generated files.

Looks fine, I agree with the comment on irc/slack that centralizing this in a .mk file likely makes sense. It's no much code, but it's a lot of duplication.

Jan 9 2020, 6:47 PM
brooks accepted D23098: makesyscalls.lua: generate all files in /tmp, write into place at the end.

This seems fine and won't be hard to merge with our local changes.

Jan 9 2020, 6:44 PM
brooks added a comment to D23096: [PowerPC] libc backwards compatibility shim for auxv change.

I'm wondering what happens with libc's use of elf_aux_info...

Jan 9 2020, 6:42 PM · PowerPC

Jan 8 2020

brooks accepted D23083: rtld: clean up Makefile..

Looks good to me other than the minor issue on sparc64.

Jan 8 2020, 11:16 PM
brooks added inline comments to D23083: rtld: clean up Makefile..
Jan 8 2020, 6:57 PM

Jan 6 2020

brooks added a comment to D22960: New ports for WebAssembly System Interface (WASI) libc and clang builtins (compiler-rt).

The missing std*.h files are due to our inability to build FreeBSD when they are installed. We really need to land D17002 and MFC it so we can eventually start installing them.

Jan 6 2020, 6:51 PM
brooks accepted D13939: Allow building bin/cat on non-FreeBSD systems.

This seems fine.

Jan 6 2020, 5:58 PM

Jan 4 2020

brooks accepted D23029: Use the freebsd-gcc6 toolchains instead of powerpc64-xtoolchain-gcc..
Jan 4 2020, 12:34 AM
brooks accepted D23013: Simplify arguments to signal handlers on mips..
Jan 4 2020, 12:24 AM

Jan 3 2020

brooks committed rP521963: Update to 9.0.1 release..
Update to 9.0.1 release.
Jan 3 2020, 9:46 PM
brooks committed rP521953: Update to a new snapshot..
Update to a new snapshot.
Jan 3 2020, 6:56 PM

Dec 20 2019

brooks committed rP520531: Additional builds with with src r354909 applied..
Additional builds with with src r354909 applied.
Dec 20 2019, 11:24 PM
brooks committed rD53701: Use "^" refer to the base URL of the SVN repository..
Use "^" refer to the base URL of the SVN repository.
Dec 20 2019, 10:22 PM
brooks closed D21949: Use "^" refer to the base URL of the SVN repository..
Dec 20 2019, 10:22 PM
brooks committed rS355965: MFC r355830:.
MFC r355830:
Dec 20 2019, 10:12 PM
brooks committed rS355964: MFC r355830:.
MFC r355830:
Dec 20 2019, 10:07 PM
brooks committed rP520528: Correct plist when OPENMP is disabled..
Correct plist when OPENMP is disabled.
Dec 20 2019, 9:52 PM
brooks added inline comments to D12773: Manage thread signal mask using a shared word, instead of syscall..
Dec 20 2019, 7:59 PM

Dec 19 2019

brooks added a reviewer for D21949: Use "^" refer to the base URL of the SVN repository.: bcr.
Dec 19 2019, 11:01 PM

Dec 18 2019

brooks committed rP520408: Update to a new snapshot..
Update to a new snapshot.
Dec 18 2019, 11:14 PM
brooks closed D22869: devel/llvm-devel: fix llvm-devel.mk vars.
Dec 18 2019, 11:14 PM
brooks accepted D22869: devel/llvm-devel: fix llvm-devel.mk vars.

LGTM. I'll commit along with and update of the snapshot shortly

Dec 18 2019, 9:46 PM

Dec 17 2019

brooks added inline comments to D12773: Manage thread signal mask using a shared word, instead of syscall..
Dec 17 2019, 10:00 PM
brooks closed D22845: Avoid a tautological bitwise compare..
Dec 17 2019, 12:10 AM
brooks committed rS355830: Avoid a tautological bitwise compare..
Avoid a tautological bitwise compare.
Dec 17 2019, 12:10 AM

Dec 16 2019

brooks created D22845: Avoid a tautological bitwise compare..
Dec 16 2019, 11:09 PM
brooks added inline comments to D12773: Manage thread signal mask using a shared word, instead of syscall..
Dec 16 2019, 7:31 PM

Dec 13 2019

brooks accepted D22800: Better copyright advice.
Dec 13 2019, 9:45 PM

Dec 12 2019

brooks committed rP519848: Update to fresh qemu-cheri and llvm-cheri snapshots..
Update to fresh qemu-cheri and llvm-cheri snapshots.
Dec 12 2019, 12:02 AM

Dec 9 2019

brooks accepted D22735: Correctly check for C++17 and higher when declaring timespec_get().
Dec 9 2019, 7:02 PM

Dec 6 2019

brooks closed D22714: sysent: Reduce duplication and improve readability..
Dec 6 2019, 11:59 PM
brooks committed rS355473: sysent: Reduce duplication and improve readability..
sysent: Reduce duplication and improve readability.
Dec 6 2019, 11:59 PM
brooks updated the diff for D22714: sysent: Reduce duplication and improve readability..
  • Improve whitespace consistency.
Dec 6 2019, 10:53 PM
brooks updated the diff for D22714: sysent: Reduce duplication and improve readability..
  • Add missing dependency
Dec 6 2019, 10:49 PM
brooks accepted D22698: makesyscalls.lua: improve config processing.

This seems like a reasonable approach.

Dec 6 2019, 10:41 PM
brooks created D22714: sysent: Reduce duplication and improve readability..
Dec 6 2019, 10:17 PM
brooks committed rS355454: MFC r355139:.
MFC r355139:
Dec 6 2019, 6:15 PM
brooks committed rS355453: MFC r355139:.
MFC r355139:
Dec 6 2019, 5:58 PM

Nov 27 2019

brooks committed rS355139: Fix a logic bug when "mask" contains a ?: operator..
Fix a logic bug when "mask" contains a ?: operator.
Nov 27 2019, 8:01 PM
brooks closed D22573: Fix a logic bug when "mask: contains a ?: operator..
Nov 27 2019, 8:01 PM
brooks created D22573: Fix a logic bug when "mask: contains a ?: operator..
Nov 27 2019, 5:38 PM

Nov 25 2019

brooks committed rP518434: Fix build with src r354909 applied..
Fix build with src r354909 applied.
Nov 25 2019, 11:26 PM
brooks committed rP518431: Restore RUN_DEPENDS on devel/git accidentally removed in r518154.
Restore RUN_DEPENDS on devel/git accidentally removed in r518154
Nov 25 2019, 10:14 PM
brooks committed rP518412: Correct the PYCLANG pattern..
Correct the PYCLANG pattern.
Nov 25 2019, 6:09 PM

Nov 22 2019

brooks committed rP518160: Fix build with src r354909 applied..
Fix build with src r354909 applied.
Nov 22 2019, 7:45 PM
brooks committed rS355011: Revert r354909: Make the warning for deprecated NO_ variables an error..
Revert r354909: Make the warning for deprecated NO_ variables an error.
Nov 22 2019, 6:41 PM
brooks closed D22496: Enable subversion support by default to remove git-subversion..

Committed in rP518154 and rP518155

Nov 22 2019, 5:44 PM
brooks committed rP518155: Actually remove devel/git-subversion as advertised in r518154..
Actually remove devel/git-subversion as advertised in r518154.
Nov 22 2019, 5:26 PM
brooks committed rP518154: Enable subversion support by default and remove git-subversion..
Enable subversion support by default and remove git-subversion.
Nov 22 2019, 5:25 PM