Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (267 w, 5 d)

Recent Activity

Today

brooks updated the summary of D21296: Remove some compatability with Seventh Edition UNIX realloc()..
Mon, Aug 19, 10:16 AM
D21296: Remove some compatability with Seventh Edition UNIX realloc(). now requires review to proceed.
  • Always follow the allocated path, don't free prematurely.
Mon, Aug 19, 10:13 AM

Sat, Aug 17

brooks created D21296: Remove some compatability with Seventh Edition UNIX realloc()..
Sat, Aug 17, 12:01 AM

Fri, Aug 16

brooks committed rS351132: md(4): remove the unused and unusable MDIOCLIST ioctl..
md(4): remove the unused and unusable MDIOCLIST ioctl.
Fri, Aug 16, 6:57 PM
brooks closed D18936: Remove the unused and unusable MDIOCLIST ioctl..
Fri, Aug 16, 6:57 PM

Thu, Aug 15

brooks committed rP509054: Update to 9.0.0rc2..
Update to 9.0.0rc2.
Thu, Aug 15, 8:37 PM

Fri, Aug 9

brooks committed rS350827: Don't add -Wno-class-memaccess with older gcc..
Don't add -Wno-class-memaccess with older gcc.
Fri, Aug 9, 11:51 PM
Owners added a reviewer for D21195: Don't add -Wno-class-memaccess with older gcc.: Restricted Owners Package.
Fri, Aug 9, 11:51 PM
brooks retitled D21195: Don't add -Wno-class-memaccess with older gcc. from Don't add -Wno-class-memaccess with modern gcc. to Don't add -Wno-class-memaccess with older gcc..
Fri, Aug 9, 8:38 PM
brooks added a comment to D21195: Don't add -Wno-class-memaccess with older gcc..

I've fixed the expression to exclude gcc < 8 and tested on amd64 and riscv.

Fri, Aug 9, 8:36 PM
brooks added a comment to D21195: Don't add -Wno-class-memaccess with older gcc..
  • Use the correct expression to add -Wno-class-memaccess.
Fri, Aug 9, 8:35 PM
brooks added a comment to D21195: Don't add -Wno-class-memaccess with older gcc..

I completely misunderstood what was going on. The in .. excludes gcc 4.2.1 and this is a gcc 8.0+ warning. The incorrect copy and paste meant it worked by accident for 6.4. I'm testing a new version now...

Fri, Aug 9, 3:56 PM

Thu, Aug 8

brooks added a comment to D21195: Don't add -Wno-class-memaccess with older gcc..

This is breaking the xtoolchain CI jobs https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/10997/

Thu, Aug 8, 11:33 PM
brooks added a reviewer for D21195: Don't add -Wno-class-memaccess with older gcc.: asomers.
Thu, Aug 8, 11:33 PM
brooks created D21195: Don't add -Wno-class-memaccess with older gcc..
Thu, Aug 8, 11:30 PM

Wed, Aug 7

brooks committed rP508349: Assorted minor improvements:.
Assorted minor improvements:
Wed, Aug 7, 7:53 PM

Mon, Aug 5

brooks committed rP508191: Allow builds with a default python version on 3.7..
Allow builds with a default python version on 3.7.
Mon, Aug 5, 4:15 PM
brooks committed rP508190: Welcome LLVM 9.0.0rc1 to the tree..
Welcome LLVM 9.0.0rc1 to the tree.
Mon, Aug 5, 4:10 PM

Fri, Aug 2

brooks committed rS350545: MFC r350228:.
MFC r350228:
Fri, Aug 2, 10:34 PM
brooks committed rS350543: MFC r350228:.
MFC r350228:
Fri, Aug 2, 8:31 PM
brooks committed rS350542: MFC r350218:.
MFC r350218:
Fri, Aug 2, 8:24 PM
brooks committed rS350539: MFC r350160:.
MFC r350160:
Fri, Aug 2, 4:05 PM

Thu, Aug 1

brooks committed rS350526: MFC r350160:.
MFC r350160:
Thu, Aug 1, 11:29 PM
brooks committed rP507836: Address a code generation bug that could allow the ARM stack protector.
Address a code generation bug that could allow the ARM stack protector
Thu, Aug 1, 11:27 PM

Wed, Jul 31

brooks committed rS350476: MFC r350159:.
MFC r350159:
Wed, Jul 31, 6:40 PM
brooks committed rS350475: MFC r350158:.
MFC r350158:
Wed, Jul 31, 6:26 PM
brooks committed rS350474: MFC r350157:.
MFC r350157:
Wed, Jul 31, 6:11 PM
brooks committed rS350473: MFC r350157:.
MFC r350157:
Wed, Jul 31, 5:56 PM
brooks committed rS350470: MFC r350143, r350148.
MFC r350143, r350148
Wed, Jul 31, 5:29 PM
brooks committed rS350469: MFC r350143, r350148.
MFC r350143, r350148
Wed, Jul 31, 5:01 PM

Tue, Jul 30

D21092: freebsd32 shims for copy_file_range(2) is now accepted and ready to land.

LGTM

Tue, Jul 30, 10:16 PM

Mon, Jul 29

brooks added a comment to D21092: freebsd32 shims for copy_file_range(2).

Why is a shim required? All arguments are extended to 64-bits as part of the combat layer. There would be an issue if len were an off_t, but it's a size_t. The only pointers point to off_t's which are always 64-bit and thus require no special handling.

Mon, Jul 29, 6:09 PM

Fri, Jul 26

brooks committed rS350345: MFC r316803,320033,338277,350098,350100-350101.
MFC r316803,320033,338277,350098,350100-350101
Fri, Jul 26, 2:50 AM
Herald updated subscribers of D10995: tcp: tcpdchk & tcpdmatch: warning fixes.
Fri, Jul 26, 2:49 AM

Thu, Jul 25

brooks committed rS350334: MFC r350117:.
MFC r350117:
Thu, Jul 25, 8:35 PM
brooks committed rS350332: MFC r350117:.
MFC r350117:
Thu, Jul 25, 8:01 PM
brooks committed rS350330: MFC r350116:.
MFC r350116:
Thu, Jul 25, 6:16 PM
brooks committed rS350329: MFC r350116:.
MFC r350116:
Thu, Jul 25, 5:33 PM
brooks committed rS350328: MFC r350067:.
MFC r350067:
Thu, Jul 25, 5:30 PM

Wed, Jul 24

brooks committed rS350305: MFC r350102:.
MFC r350102:
Wed, Jul 24, 9:40 PM
brooks committed rS350304: MFC r350067:.
MFC r350067:
Wed, Jul 24, 9:39 PM
brooks committed rS350300: MFC r350049:.
MFC r350049:
Wed, Jul 24, 8:18 PM
brooks committed rS350299: MFC r350102:.
MFC r350102:
Wed, Jul 24, 7:57 PM
brooks committed rS350296: MFC r350098, r350100-r350101.
MFC r350098, r350100-r350101
Wed, Jul 24, 7:16 PM
brooks updated the summary of D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..
Wed, Jul 24, 5:25 PM
brooks added a comment to D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..

This looks like it provides a viable update path. As you say, libc may have some edge case issues, but it does look like it does the job of letting people upgrade without a reinstall from media. What do you think about about timing this change? It seems like it should happen close to the ELFv2 switch so people get the whole thing out of the way at once.

Wed, Jul 24, 5:07 PM
brooks added a comment to D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..
  • Detect old auxargs constant and translate them (from bdragon@).
  • Put freebsd_fixup_old_auxargs under #ifdef powerpc.
Wed, Jul 24, 5:02 PM

Tue, Jul 23

brooks added a comment to D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..

OK, I wasn't sure exactly how the bits in rtld were going to go. It doesn't look like this is going to be as much help as I'd hoped.

Tue, Jul 23, 10:27 PM
brooks added inline comments to D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..
Tue, Jul 23, 2:57 AM
brooks added a comment to D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..
  • Use the correct AT_COUNT value, not the CheriBSD one.
Tue, Jul 23, 2:56 AM
brooks added inline comments to D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..
Tue, Jul 23, 2:47 AM

Mon, Jul 22

brooks committed rP507178: Update to LLVM 8.0.1..
Update to LLVM 8.0.1.
Mon, Jul 22, 10:42 PM
brooks added inline comments to D21031: Add mkostempsat(3)..
Mon, Jul 22, 10:23 PM
brooks closed D21002: ata_xpt: Use the correct union member when accessing valid.
Mon, Jul 22, 9:08 PM
brooks committed rS350228: ata_xpt: Use the correct union member when accessing valid..
ata_xpt: Use the correct union member when accessing valid.
Mon, Jul 22, 9:08 PM
brooks committed rS350218: Be consistent about temporary variable use in adjacent loops..
Be consistent about temporary variable use in adjacent loops.
Mon, Jul 22, 6:27 PM
brooks added a comment to D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..

Did you apply a manual bump of __FreeBSD_version and P_OSREL_POWERPC_NEW_AUX_ARGS? That part of the patch is now out of date.

Mon, Jul 22, 6:06 PM

Jul 19 2019

brooks committed rS350160: Avoid copying too much from the input string..
Avoid copying too much from the input string.
Jul 19 2019, 11:58 PM
brooks closed D21004: Avoid copying too much from the input string..
Jul 19 2019, 11:58 PM
brooks committed rS350159: Make setting mips endian and ABI less verbose..
Make setting mips endian and ABI less verbose.
Jul 19 2019, 11:39 PM
brooks closed D21001: Make setting mips endian and ABI less verbose..
Jul 19 2019, 11:39 PM
brooks updated the summary of D21004: Avoid copying too much from the input string..
Jul 19 2019, 11:15 PM
brooks committed rS350158: Remove an unneeded temporary variable in two functions..
Remove an unneeded temporary variable in two functions.
Jul 19 2019, 11:10 PM
brooks committed rS350157: Use the __DECONST macro rather than hand rolling it..
Use the __DECONST macro rather than hand rolling it.
Jul 19 2019, 10:54 PM
brooks created D21004: Avoid copying too much from the input string..
Jul 19 2019, 10:47 PM
brooks added a comment to D21002: ata_xpt: Use the correct union member when accessing valid.

I found this in our CheriBSD diffs. I'm not sure how @arichardson ran into it.

Jul 19 2019, 10:30 PM
brooks created D21002: ata_xpt: Use the correct union member when accessing valid.
Jul 19 2019, 10:29 PM
brooks created D21001: Make setting mips endian and ABI less verbose..
Jul 19 2019, 9:38 PM
brooks committed rS350148: Restore WARNS?=1 here. I missed that libexec/bootpd/bootpgw existed..
Restore WARNS?=1 here. I missed that libexec/bootpd/bootpgw existed.
Jul 19 2019, 6:47 PM
brooks committed rS350143: Chain Makefile.inc's so default are inherited as expected..
Chain Makefile.inc's so default are inherited as expected.
Jul 19 2019, 5:52 PM

Jul 18 2019

brooks closed D20989: Include a mode when creating files with openat()..
Jul 18 2019, 9:38 PM
brooks committed rS350117: Include a mode when creating files with openat()..
Include a mode when creating files with openat().
Jul 18 2019, 9:38 PM
Herald added a reviewer for D20982: Document that setmode(3) is not thread safe.: manpages.
Jul 18 2019, 9:34 PM
brooks committed rS350116: Document that setmode(3) is not thread safe..
Document that setmode(3) is not thread safe.
Jul 18 2019, 9:34 PM
brooks created D20989: Include a mode when creating files with openat()..
Jul 18 2019, 9:32 PM

Jul 17 2019

brooks created D20982: Document that setmode(3) is not thread safe..
Jul 17 2019, 11:53 PM
brooks committed rS350102: Remove redundent decleration of __elf_phdr_match_addr()..
Remove redundent decleration of __elf_phdr_match_addr().
Jul 17 2019, 11:47 PM
brooks committed rS350101: Remove a duplicate global (rfc931_timeout)..
Remove a duplicate global (rfc931_timeout).
Jul 17 2019, 11:43 PM
brooks committed rS350100: Use headers instead of manual declerations of standard functions and.
Use headers instead of manual declerations of standard functions and
Jul 17 2019, 11:36 PM
brooks committed rS350098: Use ANSI C function definitions and declerations..
Use ANSI C function definitions and declerations.
Jul 17 2019, 11:10 PM

Jul 16 2019

brooks committed rS350067: Add missing mode in open(2) calls with O_CREAT..
Add missing mode in open(2) calls with O_CREAT.
Jul 16 2019, 10:28 PM
brooks closed D20972: Add missing permissions in open(2) calls with O_CREAT..
Jul 16 2019, 10:28 PM
brooks added a comment to D20972: Add missing permissions in open(2) calls with O_CREAT..

NetBSD just committed these changes and some others just now. I'm waiting for cvsweb to update so I can check what was actually committed.

Jul 16 2019, 6:16 PM
brooks committed rP506765: Pin the python version to 3.6 to fix builds with 2.7 as the default..
Pin the python version to 3.6 to fix builds with 2.7 as the default.
Jul 16 2019, 4:40 PM
brooks added a comment to D20972: Add missing permissions in open(2) calls with O_CREAT..

Submitted upstream: http://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=54382

Jul 16 2019, 4:35 PM
brooks created D20972: Add missing permissions in open(2) calls with O_CREAT..
Jul 16 2019, 4:34 PM
brooks closed D20964: Fix two mismatches between function declaration and definition..
Jul 16 2019, 4:03 PM
brooks committed rS350049: Fix two mismatches between function declaration and definition..
Fix two mismatches between function declaration and definition.
Jul 16 2019, 4:03 PM
brooks retitled D20964: Fix two mismatches between function declaration and definition. from Fix two mismatches between function decleration and definition. to Fix two mismatches between function declaration and definition..
Jul 16 2019, 4:02 PM

Jul 15 2019

brooks added a comment to D20964: Fix two mismatches between function declaration and definition..

While we should probably just do in amd, these are easy fixes and there's no upstream conflicts to worry about (last am-utils release in 2014 and their git server don't seem to host a repo.

Jul 15 2019, 10:47 PM
brooks created D20964: Fix two mismatches between function declaration and definition..
Jul 15 2019, 10:44 PM
brooks committed rP506706: Upgrade to a newer snapshot..
Upgrade to a newer snapshot.
Jul 15 2019, 7:50 PM

Jul 11 2019

brooks committed rP506416: Update to a new snapshot..
Update to a new snapshot.
Jul 11 2019, 4:59 PM

Jul 9 2019

brooks added a comment to D20864: Let linuxulator mprotect mask unsupported bits before calling kern_mprotect.

It seems deeply weird that a program would set these flags with mprotect, but this change seems fine (modulo changing the error to EINVAL).

Jul 9 2019, 6:31 PM

Jul 3 2019

brooks committed rP505794: Add missed patch in previous commit to allow LLDB docs to build with the.
Add missed patch in previous commit to allow LLDB docs to build with the
Jul 3 2019, 8:46 PM

Jul 2 2019

brooks added a comment to D20716: Replace mount(2) calls to in-tree filesystems will nmount(2)..
  • Call __sys_nmount from the mount wrapper.
Jul 2 2019, 6:06 PM
brooks committed rP505690: Update to a fresh (2019-07-01) snapshot..
Update to a fresh (2019-07-01) snapshot.
Jul 2 2019, 5:05 PM
brooks added inline comments to D20795: Control implicit PROT_MAX() using proccontrol(1) and the FreeBSD note feature bit..
Jul 2 2019, 4:23 PM

Jun 28 2019

D20800: Use a consistent snapshot of the fd's rights in fget_mmap(). is now accepted and ready to land.

LGTM

Jun 28 2019, 10:23 PM
brooks created D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..
Jun 28 2019, 8:35 PM