Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (275 w, 5 d)

Recent Activity

Fri, Oct 11

brooks committed rS353449: Centralize adding OBJCOPY=${XOBJCOPY} to LIB32WMAKEFLAGS..
Centralize adding OBJCOPY=${XOBJCOPY} to LIB32WMAKEFLAGS.
Fri, Oct 11, 9:28 PM
brooks closed D21983: Centralize adding OBJCOPY=${XOBJCOPY} to LIB32WMAKEFLAGS..
Fri, Oct 11, 9:28 PM
brooks created D21983: Centralize adding OBJCOPY=${XOBJCOPY} to LIB32WMAKEFLAGS..
Fri, Oct 11, 5:55 PM

Thu, Oct 10

brooks added a comment to D21971: rpcgen: make compiler arglist allocation dynamic.

I wish the C standard library had some kind of dynamic array so that this is not reimplement in every program...
I wonder if we could use something like the utarray.h macros from uthash?
Could we import the five headers that https://github.com/troydhanson/uthash into contrib and use utarray instead? I know the library is not that efficient since it uses strdup() for all strings that you insert but at least it means not reinventing the wheel.
We already have two copies of uthash.h in the source tree and elftoolchain also includes with utarray.h.

Thu, Oct 10, 9:24 PM
brooks created D21971: rpcgen: make compiler arglist allocation dynamic.
Thu, Oct 10, 4:37 PM
brooks committed rS353408: Fix -DNO_CLEAN build across r353340 and r353381.
Fix -DNO_CLEAN build across r353340 and r353381
Thu, Oct 10, 4:29 PM

Wed, Oct 9

brooks committed rP514196: Update CHERI LLVM and Qemu to fresh snapshots..
Update CHERI LLVM and Qemu to fresh snapshots.
Wed, Oct 9, 9:59 PM
brooks committed rP514194: Rollup of fixes since the 9.0.0 release..
Rollup of fixes since the 9.0.0 release.
Wed, Oct 9, 8:36 PM
brooks committed rP514175: ttempt to work around a problem with binutils not liking the armv6 code.
ttempt to work around a problem with binutils not liking the armv6 code
Wed, Oct 9, 5:41 PM

Tue, Oct 8

brooks created D21949: Use "^" refer to the base URL of the SVN repository..
Tue, Oct 8, 10:19 PM
brooks committed rS353329: msun: Silence new harmless -Wimplicit-int-float-conversion warnings.
msun: Silence new harmless -Wimplicit-int-float-conversion warnings
Tue, Oct 8, 9:40 PM
brooks closed D21913: msun: Silence new harmless -Wimplicit-int-float-conversion warnings.
Tue, Oct 8, 9:40 PM
brooks added inline comments to D21945: kvm: fix types for `kvm_walk_pages`.
Tue, Oct 8, 9:26 PM
brooks committed rS353326: Fix various -Wpointer-compare warnings.
Fix various -Wpointer-compare warnings
Tue, Oct 8, 9:14 PM
brooks closed D21914: Fix various -Wpointer-compare warnings.
Tue, Oct 8, 9:14 PM
brooks added a comment to D21914: Fix various -Wpointer-compare warnings.

I've merged the tcsh changes in via an update to tcsh 6.21.00 in rS353325.

Tue, Oct 8, 9:00 PM
brooks committed rS353325: Update tcsh to 6.21.00..
Update tcsh to 6.21.00.
Tue, Oct 8, 8:59 PM
brooks accepted D21942: Don't compile old gcc 4.2.1 archs by default in universe/tinderbox..

LGTM.

Tue, Oct 8, 8:53 PM
brooks committed rS353324: Allow -DNO_CLEAN build across r352689..
Allow -DNO_CLEAN build across r352689.
Tue, Oct 8, 8:27 PM
brooks committed rS353319: Tag 6.21.00 import..
Tag 6.21.00 import.
Tue, Oct 8, 6:22 PM
brooks committed rS353317: Import 6.21.00..
Import 6.21.00.
Tue, Oct 8, 6:20 PM
brooks committed rS353315: MFC r352919:.
MFC r352919:
Tue, Oct 8, 6:06 PM
brooks added a reviewer for D21913: msun: Silence new harmless -Wimplicit-int-float-conversion warnings: dim.
Tue, Oct 8, 5:37 PM
brooks added inline comments to D21942: Don't compile old gcc 4.2.1 archs by default in universe/tinderbox..
Tue, Oct 8, 4:49 PM

Thu, Oct 3

brooks committed rS353067: MFC r352918:.
MFC r352918:
Thu, Oct 3, 8:09 PM
brooks committed rS353061: MFC r352917:.
MFC r352917:
Thu, Oct 3, 6:51 PM
brooks committed rS353055: MFC r352220:.
MFC r352220:
Thu, Oct 3, 5:41 PM

Tue, Oct 1

brooks committed rP513490: Fix build with EXTRAS disabled..
Fix build with EXTRAS disabled.
Tue, Oct 1, 4:01 PM

Mon, Sep 30

brooks committed rS352919: Update cloudabi(32|64) sysents with "make sysent"..
Update cloudabi(32|64) sysents with "make sysent".
Mon, Sep 30, 9:14 PM
brooks committed rS352918: Regen after r347228 and r352693..
Regen after r347228 and r352693.
Mon, Sep 30, 9:00 PM
brooks committed rS352917: Restore the ability to set capenabled directly in syscalls.conf..
Restore the ability to set capenabled directly in syscalls.conf.
Mon, Sep 30, 8:58 PM
brooks closed D21821: Restore the ability to set capenabled directly in syscalls.conf..
Mon, Sep 30, 8:58 PM
brooks added a comment to D21821: Restore the ability to set capenabled directly in syscalls.conf..

Ouch, command substitution in syscalls.conf

Yeah, that will be a little more interesting for non-sh parsers :)

Yeah... Luckily this isn't too bad and I've got it working locally in the lua world, but we really should document what's ok and not ok in these .conf files based on how they're currently done to the best of our knowledge.
One of my new pet peeves after lualoader is giving something a fairly innocuous looking extension that's actually fully flavored and not well-documented as such.
OTOH, I don't know where documentation for this in particular would live unless we started an informational syscall manpage with content like the AddingSyscalls wiki page.

Mon, Sep 30, 8:53 PM

Fri, Sep 27

brooks created D21821: Restore the ability to set capenabled directly in syscalls.conf..
Fri, Sep 27, 3:06 PM

Wed, Sep 25

brooks committed rP512799: Update to 9.0.0 release..
Update to 9.0.0 release.
Wed, Sep 25, 5:20 PM

Sat, Sep 21

brooks added a comment to D21718: makesyscalls.sh: generate boilerplate for standard COMPAT* options.

This is rather clever, but I don't like this direction. I'd like to remove the embedding of awk in sh that currently exists and this makes it much harder.

Sat, Sep 21, 1:00 PM

Thu, Sep 19

brooks added a comment to D21680: devel/xtoolchain-llvm-devel: Fix plist when NO_LLD_LINK defined.

Sorry about this. Fixed in rP512326

Thu, Sep 19, 12:51 PM
brooks accepted D21676: makesyscalls.sh: Add COMPAT12 support.

See also D21366 which includes an identical review diff. I didn't commit it at the time as my initial deprecation target didn't immediately make sense.

Thu, Sep 19, 12:34 PM
brooks committed rP512330: Fix plist..
Fix plist.
Thu, Sep 19, 11:10 AM
brooks committed rP512326: Fix plist for the no-ld-link case..
Fix plist for the no-ld-link case.
Thu, Sep 19, 9:56 AM

Sep 13 2019

brooks committed rP511972: Update to a new snapshot..
Update to a new snapshot.
Sep 13 2019, 2:33 PM

Sep 12 2019

brooks accepted D21618: SIOCSIFNAME: Do nothing if we're not actually changing.

LGTM.

Sep 12 2019, 3:21 PM
brooks committed rP511878: llvm90:.
llvm90:
Sep 12 2019, 12:50 PM

Sep 11 2019

brooks closed D21605: Avoid the use of the non-portable -D argument to ls..
Sep 11 2019, 5:01 PM
brooks committed rS352220: Avoid the use of the non-portable -D argument to ls..
Avoid the use of the non-portable -D argument to ls.
Sep 11 2019, 5:01 PM
brooks created D21605: Avoid the use of the non-portable -D argument to ls..
Sep 11 2019, 12:04 PM
brooks committed rP511801: Fix linkage with non-default python port options..
Fix linkage with non-default python port options.
Sep 11 2019, 8:30 AM
brooks committed rP511800: Update to 9.0.0rc4..
Update to 9.0.0rc4.
Sep 11 2019, 8:29 AM

Sep 9 2019

brooks accepted D21492: Make linux_common depend on pty..

LGTM

Sep 9 2019, 1:57 PM
brooks added inline comments to D21492: Make linux_common depend on pty..
Sep 9 2019, 1:27 PM

Sep 6 2019

brooks committed rP511300: Assorted build improvements:.
Assorted build improvements:
Sep 6 2019, 11:05 AM

Sep 3 2019

brooks added inline comments to D20687: Fix execution of linux binaries with glibc>=2.24.
Sep 3 2019, 11:41 AM

Sep 2 2019

brooks added a comment to D20687: Fix execution of linux binaries with glibc>=2.24.

I suspect I know what's going on. If vectp % 16 == 8 then when long argc is stuck in front of it per the ABI requirements, the stack is aligned to 16 bytes. I suspect a change was made to require 16-byte alignment as recommend by Intel. A possibly relevant thread (I've only skimmed it) https://lore.kernel.org/patchwork/patch/749568/

Sep 2 2019, 7:21 PM
brooks accepted D17282: new syscall: __sysctlbyname.

LGTM

Sep 2 2019, 2:04 PM
brooks added a comment to D17282: new syscall: __sysctlbyname.

sys/compat/freebsd32/syscalls.master seems to be missing now...

Sep 2 2019, 1:43 PM
brooks accepted D21445: library should not modify global process state by calling sigaction(2).

LGTM

Sep 2 2019, 1:41 PM
brooks committed rS351690: Remove remnants of optimization for > pagesize allocations..
Remove remnants of optimization for > pagesize allocations.
Sep 2 2019, 8:03 AM
brooks closed D21453: Remove remnants of optimization for > pagesize allocations..
Sep 2 2019, 8:03 AM
brooks committed rP510767: Update to 9.0.0rc3..
Update to 9.0.0rc3.
Sep 2 2019, 7:22 AM

Aug 30 2019

brooks added a comment to D21453: Remove remnants of optimization for > pagesize allocations..
  • Remove dead check.
  • Return immediatly from the loop if bucket gets to big.
Aug 30 2019, 7:58 AM

Aug 29 2019

brooks added reviewers for D21453: Remove remnants of optimization for > pagesize allocations.: kib, imp, jhb.

I've now booted on amd64 in addition to CheriBSD.

Aug 29 2019, 8:45 AM

Aug 28 2019

brooks created D21453: Remove remnants of optimization for > pagesize allocations..
Aug 28 2019, 3:44 PM
brooks committed rS351568: MFC r351389:.
MFC r351389:
Aug 28 2019, 8:11 AM
brooks committed rS351567: MFC r348446:.
MFC r348446:
Aug 28 2019, 8:05 AM
brooks committed rS351566: MFC r340424:.
MFC r340424:
Aug 28 2019, 7:53 AM
brooks committed rS351565: Regenerate to add @generated tag in generated files..
Regenerate to add @generated tag in generated files.
Aug 28 2019, 7:44 AM
brooks committed rS351564: MFC r339624:.
MFC r339624:
Aug 28 2019, 7:37 AM

Aug 27 2019

brooks added inline comments to D21393: [3/3] Add linux-compatible memfd_create.
Aug 27 2019, 4:22 PM
brooks added inline comments to D21393: [3/3] Add linux-compatible memfd_create.
Aug 27 2019, 12:06 PM

Aug 23 2019

brooks committed rP509638: New option PYCLANG to add python binding for clang..
New option PYCLANG to add python binding for clang.
Aug 23 2019, 10:06 AM

Aug 22 2019

brooks created D21366: Add COMPAT12 support to makesyscalls.sh..
Aug 22 2019, 2:16 PM
brooks committed rP509597: Update to a new snapshot..
Update to a new snapshot.
Aug 22 2019, 12:43 PM
brooks committed rS351389: Reorganise conditionals to reduce duplication..
Reorganise conditionals to reduce duplication.
Aug 22 2019, 10:21 AM

Aug 21 2019

D17282: new syscall: __sysctlbyname now requires changes to proceed.

It would be helpful to generate this diff against HEAD. That would exclude the generated files and the freebsd32 capabilities.conf entry.

Aug 21 2019, 9:16 AM

Aug 20 2019

brooks committed rS351251: Remove some compatability with Seventh Edition UNIX realloc()..
Remove some compatability with Seventh Edition UNIX realloc().
Aug 20 2019, 4:07 PM
brooks closed D21296: Remove some compatability with Seventh Edition UNIX realloc()..
Aug 20 2019, 4:07 PM

Aug 19 2019

brooks updated the summary of D21296: Remove some compatability with Seventh Edition UNIX realloc()..
Aug 19 2019, 10:16 AM
D21296: Remove some compatability with Seventh Edition UNIX realloc(). now requires review to proceed.
  • Always follow the allocated path, don't free prematurely.
Aug 19 2019, 10:13 AM

Aug 17 2019

brooks created D21296: Remove some compatability with Seventh Edition UNIX realloc()..
Aug 17 2019, 12:01 AM

Aug 16 2019

brooks committed rS351132: md(4): remove the unused and unusable MDIOCLIST ioctl..
md(4): remove the unused and unusable MDIOCLIST ioctl.
Aug 16 2019, 6:57 PM
brooks closed D18936: Remove the unused and unusable MDIOCLIST ioctl..
Aug 16 2019, 6:57 PM

Aug 15 2019

brooks committed rP509054: Update to 9.0.0rc2..
Update to 9.0.0rc2.
Aug 15 2019, 8:37 PM

Aug 9 2019

brooks committed rS350827: Don't add -Wno-class-memaccess with older gcc..
Don't add -Wno-class-memaccess with older gcc.
Aug 9 2019, 11:51 PM
Owners added a reviewer for D21195: Don't add -Wno-class-memaccess with older gcc.: Restricted Owners Package.
Aug 9 2019, 11:51 PM
brooks retitled D21195: Don't add -Wno-class-memaccess with older gcc. from Don't add -Wno-class-memaccess with modern gcc. to Don't add -Wno-class-memaccess with older gcc..
Aug 9 2019, 8:38 PM
brooks added a comment to D21195: Don't add -Wno-class-memaccess with older gcc..

I've fixed the expression to exclude gcc < 8 and tested on amd64 and riscv.

Aug 9 2019, 8:36 PM
brooks added a comment to D21195: Don't add -Wno-class-memaccess with older gcc..
  • Use the correct expression to add -Wno-class-memaccess.
Aug 9 2019, 8:35 PM
brooks added a comment to D21195: Don't add -Wno-class-memaccess with older gcc..

I completely misunderstood what was going on. The in .. excludes gcc 4.2.1 and this is a gcc 8.0+ warning. The incorrect copy and paste meant it worked by accident for 6.4. I'm testing a new version now...

Aug 9 2019, 3:56 PM

Aug 8 2019

brooks added a comment to D21195: Don't add -Wno-class-memaccess with older gcc..

This is breaking the xtoolchain CI jobs https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/10997/

Aug 8 2019, 11:33 PM
brooks added a reviewer for D21195: Don't add -Wno-class-memaccess with older gcc.: asomers.
Aug 8 2019, 11:33 PM
brooks created D21195: Don't add -Wno-class-memaccess with older gcc..
Aug 8 2019, 11:30 PM

Aug 7 2019

brooks committed rP508349: Assorted minor improvements:.
Assorted minor improvements:
Aug 7 2019, 7:53 PM

Aug 5 2019

brooks committed rP508191: Allow builds with a default python version on 3.7..
Allow builds with a default python version on 3.7.
Aug 5 2019, 4:15 PM
brooks committed rP508190: Welcome LLVM 9.0.0rc1 to the tree..
Welcome LLVM 9.0.0rc1 to the tree.
Aug 5 2019, 4:10 PM

Aug 2 2019

brooks committed rS350545: MFC r350228:.
MFC r350228:
Aug 2 2019, 10:34 PM
brooks committed rS350543: MFC r350228:.
MFC r350228:
Aug 2 2019, 8:31 PM
brooks committed rS350542: MFC r350218:.
MFC r350218:
Aug 2 2019, 8:24 PM
brooks committed rS350539: MFC r350160:.
MFC r350160:
Aug 2 2019, 4:05 PM

Aug 1 2019

brooks committed rS350526: MFC r350160:.
MFC r350160:
Aug 1 2019, 11:29 PM
brooks committed rP507836: Address a code generation bug that could allow the ARM stack protector.
Address a code generation bug that could allow the ARM stack protector
Aug 1 2019, 11:27 PM