Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (283 w, 6 d)

Recent Activity

Today

brooks accepted D22735: Correctly check for C++17 and higher when declaring timespec_get().
Mon, Dec 9, 7:02 PM

Fri, Dec 6

brooks closed D22714: sysent: Reduce duplication and improve readability..
Fri, Dec 6, 11:59 PM
brooks committed rS355473: sysent: Reduce duplication and improve readability..
sysent: Reduce duplication and improve readability.
Fri, Dec 6, 11:59 PM
brooks updated the diff for D22714: sysent: Reduce duplication and improve readability..
  • Improve whitespace consistency.
Fri, Dec 6, 10:53 PM
brooks updated the diff for D22714: sysent: Reduce duplication and improve readability..
  • Add missing dependency
Fri, Dec 6, 10:49 PM
brooks accepted D22698: makesyscalls.lua: improve config processing.

This seems like a reasonable approach.

Fri, Dec 6, 10:41 PM
brooks created D22714: sysent: Reduce duplication and improve readability..
Fri, Dec 6, 10:17 PM
brooks committed rS355454: MFC r355139:.
MFC r355139:
Fri, Dec 6, 6:15 PM
brooks committed rS355453: MFC r355139:.
MFC r355139:
Fri, Dec 6, 5:58 PM

Wed, Nov 27

brooks committed rS355139: Fix a logic bug when "mask" contains a ?: operator..
Fix a logic bug when "mask" contains a ?: operator.
Wed, Nov 27, 8:01 PM
brooks closed D22573: Fix a logic bug when "mask: contains a ?: operator..
Wed, Nov 27, 8:01 PM
brooks created D22573: Fix a logic bug when "mask: contains a ?: operator..
Wed, Nov 27, 5:38 PM

Mon, Nov 25

brooks committed rP518434: Fix build with src r354909 applied..
Fix build with src r354909 applied.
Mon, Nov 25, 11:26 PM
brooks committed rP518431: Restore RUN_DEPENDS on devel/git accidentally removed in r518154.
Restore RUN_DEPENDS on devel/git accidentally removed in r518154
Mon, Nov 25, 10:14 PM
brooks committed rP518412: Correct the PYCLANG pattern..
Correct the PYCLANG pattern.
Mon, Nov 25, 6:09 PM

Fri, Nov 22

brooks committed rP518160: Fix build with src r354909 applied..
Fix build with src r354909 applied.
Fri, Nov 22, 7:45 PM
brooks committed rS355011: Revert r354909: Make the warning for deprecated NO_ variables an error..
Revert r354909: Make the warning for deprecated NO_ variables an error.
Fri, Nov 22, 6:41 PM
brooks closed D22496: Enable subversion support by default to remove git-subversion..

Committed in rP518154 and rP518155

Fri, Nov 22, 5:44 PM
brooks committed rP518155: Actually remove devel/git-subversion as advertised in r518154..
Actually remove devel/git-subversion as advertised in r518154.
Fri, Nov 22, 5:26 PM
brooks committed rP518154: Enable subversion support by default and remove git-subversion..
Enable subversion support by default and remove git-subversion.
Fri, Nov 22, 5:25 PM
brooks added a reviewer for D22496: Enable subversion support by default to remove git-subversion.: emaste.

This review is born out of frustration with having to manually build git on our systems where we need git-subversion and prefer to use pkg in general.

Fri, Nov 22, 12:56 AM
brooks created D22496: Enable subversion support by default to remove git-subversion..
Fri, Nov 22, 12:44 AM

Thu, Nov 21

brooks committed rP518112: Fix build on HEAD..
Fix build on HEAD.
Thu, Nov 21, 8:52 PM
brooks committed rS354928: MFC r354694, r354699.
MFC r354694, r354699
Thu, Nov 21, 12:40 AM

Wed, Nov 20

brooks committed rS354921: MFC r354688:.
MFC r354688:
Wed, Nov 20, 11:09 PM
brooks accepted D22468: Add csprng to approvers for PRNG code.
Wed, Nov 20, 9:41 PM
brooks accepted D22466: add deprecation warning to amd.

LGTM

Wed, Nov 20, 7:47 PM
brooks accepted D22464: Makefile.inc1: push /usr/libexec into the BPATH/TMPPATH .

LTGM. Adding Alex in case he has concerns about bootstrapping on MacOS/Linux.

Wed, Nov 20, 7:39 PM
brooks closed D22448: Make the warning for deprecated NO_ variables an error..
Wed, Nov 20, 6:37 PM
brooks committed rS354909: Make the warning for deprecated NO_ variables an error..
Make the warning for deprecated NO_ variables an error.
Wed, Nov 20, 6:37 PM
brooks added a comment to D22448: Make the warning for deprecated NO_ variables an error..

Passed tinderbox (sans mips and sparc64) overnight.

Wed, Nov 20, 6:34 PM

Tue, Nov 19

brooks updated the diff for D22448: Make the warning for deprecated NO_ variables an error..

Fix typo.

Tue, Nov 19, 11:21 PM
brooks created D22448: Make the warning for deprecated NO_ variables an error..
Tue, Nov 19, 11:20 PM

Sat, Nov 16

brooks accepted D22401: Check for errors from copyout() and suword*() in sv_copyout_args/strings..

LGTM

Sat, Nov 16, 1:02 AM

Fri, Nov 15

brooks committed rP517707: Update to a new snapshot and migrate to the llvm monorepo..
Update to a new snapshot and migrate to the llvm monorepo.
Fri, Nov 15, 11:14 PM
brooks added a comment to D17002: Fix compilation with upstream clang builtin headers.

This change is required to build with an unmodified upstream LLVM since the default upstream clang builtin headers are incompatible with the ones in /usr/bin/include (see my earlier comments in this review).
--sysroot only affects the normal include paths, but does not change the search path for compiler-provided headers.
SYSTEM_COMPILER compiler should not make any difference here and will work as expected with /usr/bin/cc:

/usr/bin/cc -print-resource-dir
/usr/lib/clang/6.0.1

/usr/lib/clang/6.0.1/include contains all the necessary compiler-builtin headers (but we don't install the stddef.h/etc. headers that are incompatible)

Fri, Nov 15, 9:09 PM
brooks accepted D22357: Combine ELF sysvecs for MIPS to reduce code duplication..

It's probably worth making elf_freebsd_sysvec static, but this is fine.

Fri, Nov 15, 6:14 PM
brooks accepted D22382: Fix build race in bsd.files.mk.

LGTM

Fri, Nov 15, 6:08 PM
brooks accepted D22380: Document required size of buffer for elf_aux_info(3)..

It's probably too late, but it would have been nice to pick one of long or int for the integer arguments...

Fri, Nov 15, 5:06 PM

Thu, Nov 14

brooks accepted D22371: Add sync_file_range(2) to linux(4)..

The syscalls.master bits look correct now.

Thu, Nov 14, 10:05 PM
brooks accepted D22147: Add freebsd-gcc6 port..

I think this is ready to go as is. PLIST cleanups can wait IMO.

Thu, Nov 14, 9:59 PM
brooks abandoned D2549: Add missing pieces for mips32 gcc-4.9 kernel build!.
Thu, Nov 14, 7:45 PM
brooks commandeered D2549: Add missing pieces for mips32 gcc-4.9 kernel build!.

This revision is long OBE. Commandeer so I can abandon it.

Thu, Nov 14, 7:45 PM
brooks accepted D21894: Convert in-tree sysent targets to use new makesyscalls.lua.
Thu, Nov 14, 7:17 PM
brooks accepted D21893: Add flua to the base system, install to /usr/libexec.

Works for me.

Thu, Nov 14, 7:16 PM
brooks accepted D21775: (WIP) Rewrite makesyscalls.sh in Lua.

Over all this is a massive improvement. I was able to port a number of local changes quickly.

Thu, Nov 14, 7:13 PM
brooks committed rS354711: Tidy syscall declerations..
Tidy syscall declerations.
Thu, Nov 14, 5:12 PM
brooks closed D22373: Tidy syscall declerations..
Thu, Nov 14, 5:11 PM
brooks added inline comments to D22371: Add sync_file_range(2) to linux(4)..
Thu, Nov 14, 5:00 PM
brooks created D22373: Tidy syscall declerations..
Thu, Nov 14, 4:55 PM
brooks accepted D18613: Add driver for the VMware Paravirtual SCSI (pvscsi) controller.
Thu, Nov 14, 4:35 PM

Wed, Nov 13

brooks committed rS354699: Improve the description of AT_EXECPATH availability..
Improve the description of AT_EXECPATH availability.
Wed, Nov 13, 11:31 PM
brooks committed rS354698: MFC r353871.
MFC r353871
Wed, Nov 13, 11:26 PM
brooks added inline comments to D22357: Combine ELF sysvecs for MIPS to reduce code duplication..
Wed, Nov 13, 11:24 PM
brooks accepted D22355: Add a sv_copyout_auxargs() hook in sysentvec..

LGTM. This makes much more sense.

Wed, Nov 13, 11:19 PM
brooks committed rS354695: MFC r354420:.
MFC r354420:
Wed, Nov 13, 10:26 PM
brooks accepted D22322: Conduct/reporting split.

The concept seems fine with me and IIRC no one objected at the last core meeting.

Wed, Nov 13, 10:12 PM
brooks committed rS354694: elf_aux_info: Add support for AT_EXECPATH..
elf_aux_info: Add support for AT_EXECPATH.
Wed, Nov 13, 9:52 PM
brooks closed D22353: elf_aux_info: Add support for AT_EXECPATH..
Wed, Nov 13, 9:52 PM
brooks added a comment to D22353: elf_aux_info: Add support for AT_EXECPATH..

`

Wed, Nov 13, 9:40 PM
brooks created D22353: elf_aux_info: Add support for AT_EXECPATH..
Wed, Nov 13, 9:28 PM
brooks closed D22338: Fix a typo in the PMAP_PTE_SET_CACHE_BITS macro..
Wed, Nov 13, 6:11 PM
brooks committed rS354688: Fix a typo in the PMAP_PTE_SET_CACHE_BITS macro..
Fix a typo in the PMAP_PTE_SET_CACHE_BITS macro.
Wed, Nov 13, 6:11 PM
brooks created D22338: Fix a typo in the PMAP_PTE_SET_CACHE_BITS macro..
Wed, Nov 13, 12:07 AM

Tue, Nov 12

brooks committed rS354663: libcompat: Correct rtld MLINKS.
libcompat: Correct rtld MLINKS
Tue, Nov 12, 10:32 PM

Nov 8 2019

brooks committed rS354523: Turn the error about a lack of LIBCOMPAT into a warning..
Turn the error about a lack of LIBCOMPAT into a warning.
Nov 8 2019, 3:14 AM

Nov 7 2019

brooks committed rS354519: Revert r354518 and commit the intented fix rather than the diagnostic.
Revert r354518 and commit the intented fix rather than the diagnostic
Nov 7 2019, 11:55 PM
brooks committed rS354518: Fix the ARCH check for LIB32 from Makefile.inc1..
Fix the ARCH check for LIB32 from Makefile.inc1.
Nov 7 2019, 11:50 PM
brooks committed rS354491: libcompat: build 32-bit rtld and ldd as part of "everything".
libcompat: build 32-bit rtld and ldd as part of "everything"
Nov 7 2019, 10:58 PM
brooks accepted D22271: Create /etc/os-release file..
Nov 7 2019, 10:20 PM
brooks committed rS354467: Fix declaration of S1 by swapping misplaced ',' and ';'..
Fix declaration of S1 by swapping misplaced ',' and ';'.
Nov 7 2019, 7:32 PM
brooks committed rS354466: Revert change accidentally included in r354465..
Revert change accidentally included in r354465.
Nov 7 2019, 7:28 PM
brooks committed rS354465: Revert r354449: libcompat: build 32-bit rtld and ldd as part of "everything".
Revert r354449: libcompat: build 32-bit rtld and ldd as part of "everything"
Nov 7 2019, 7:23 PM
brooks added inline comments to D22271: Create /etc/os-release file..
Nov 7 2019, 6:42 PM
brooks added a comment to D22147: Add freebsd-gcc6 port..
In D22147#486635, @jhb wrote:
In D22147#486621, @imp wrote:

Nothing caught my eye, though the PLIST is getting to be rather long and a bit of a PITA to deal with :(

What I would really like is to have a shared pkg-plist and separate pkg-plist.${TARGETARCH} files. There doesn't seem to be an easy way to do this currently.

Nov 7 2019, 6:10 PM
brooks committed rS354449: libcompat: build 32-bit rtld and ldd as part of "everything".
libcompat: build 32-bit rtld and ldd as part of "everything"
Nov 7 2019, 5:10 PM
brooks closed D22251: libcompat: build 32-bit rtld and ldd as part of "everything".
Nov 7 2019, 5:10 PM
brooks updated the summary of D22251: libcompat: build 32-bit rtld and ldd as part of "everything".
Nov 7 2019, 4:42 PM
brooks added a comment to D22251: libcompat: build 32-bit rtld and ldd as part of "everything".

link command:

cc -target x86_64-unknown-freebsd13.0 --sysroot=/home/bed22/obj/home/bed22/git/freebsd/amd64.amd64/tmp -B/home/bed22/obj/home/bed22/git/freebsd/amd64.amd64/tmp/usr/bin -O2 -pipe -DCOMPAT_32BIT -march=i686 -mmmx -msse -msse2 -target x86_64-unknown-freebsd13.0 -m32 -L/home/bed22/obj/home/bed22/git/freebsd/amd64.amd64/obj-lib32/tmp/usr/lib32 --sysroot=/home/bed22/obj/home/bed22/git/freebsd/amd64.amd64/obj-lib32/tmp -B/home/bed22/obj/home/bed22/git/freebsd/amd64.amd64/obj-lib32/tmp/usr/lib32 -Wall -DFREEBSD_ELF -DIN_RTLD -ffreestanding -I/home/bed22/git/freebsd/lib/csu/common -I/home/bed22/git/freebsd/libexec/rtld-elf/i386 -I/home/bed22/git/freebsd/libexec/rtld-elf -fpic -DPIC -fvisibility=hidden -I/home/bed22/git/freebsd/libexec/rtld-elf/rtld-libc -mno-mmx -mno-sse -mno-avx -mno-avx2 -msoft-float -g -std=gnu99 -Wno-format-zero-length -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wformat=2 -Wno-format-extra-args -Werror -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments  -nostdlib -e .rtld_start -shared -Wl,-Bsymbolic -Wl,-z,defs -Wl,--version-script=Version.map   -o ld-elf32.so.1.full rtld_start.o reloc.o rtld.o rtld_lock.o rtld_malloc.o rtld_printf.o map_object.o xmalloc.o debug.o libmap.o opendir.o closedir.o readdir.o telldir.o rtld_libc.o reallocf.o realpath.o getenv.o merge.o reallocarray.o errlst.o getcwd.o getprogname.o raise.o sigsetops.o sysctlnametomib.o __xuname.o  /home/bed22/obj/home/bed22/git/freebsd/amd64.amd64/libexec/rtld-elf32/rtld_libc.a

file output:

~/git/freebsd/libexec/rtld-elf32 buildenv> file `make -V .OBJDIR`/ld-elf32.so.1
/home/bed22/obj/home/bed22/git/freebsd/amd64.amd64/libexec/rtld-elf32/ld-elf32.so.1: ELF 32-bit LSB shared object, Intel 80386, version 1 (FreeBSD), dynamically linked, not stripped
Nov 7 2019, 4:15 PM
brooks committed rP516936: Update to a more recent snapshot..
Update to a more recent snapshot.
Nov 7 2019, 12:59 AM
brooks committed rS354420: Fix the alignment of struct xunpcb on systems with >64-bit pointers..
Fix the alignment of struct xunpcb on systems with >64-bit pointers.
Nov 7 2019, 12:08 AM
brooks closed D22268: Fix the alignment of struct xunpcb on systems with >64-bit pointers..
Nov 7 2019, 12:08 AM

Nov 6 2019

brooks updated the diff for D22251: libcompat: build 32-bit rtld and ldd as part of "everything".
  • Default LIB32 to on where supported and mark broken elsewhere.
Nov 6 2019, 11:07 PM
brooks created D22268: Fix the alignment of struct xunpcb on systems with >64-bit pointers..
Nov 6 2019, 10:57 PM
brooks added a comment to D22147: Add freebsd-gcc6 port..
In D22147#486624, @jhb wrote:

@brooks suggested he would consider merging the llvm-xtoolchain ports into the llvm ports as well. I think it is nice that you can 'pkg install <foo>' to get the bits for 'make CROSS_TOOLCHAIN=<foo>'

Nov 6 2019, 10:48 PM
brooks added a comment to D22251: libcompat: build 32-bit rtld and ldd as part of "everything".
In D22251#486697, @jhb wrote:

If this permits easily doing something like 'make buildenv; cd rtld-elf32; make' then this really will be nicer than our current approach.

Nov 6 2019, 10:11 PM
brooks added a comment to D22251: libcompat: build 32-bit rtld and ldd as part of "everything".
In D22251#486698, @kib wrote:

I do not quite understand how even ld-elf32.so.1 can be built during non-compat build, not to mention normal binaries. For rtld, we need some object files from libc build. For binaries, we need libc.so.7 to link with. So how this stuff would work now ?

Nov 6 2019, 10:09 PM
brooks closed D22188: libstats: Fix ABI assertion..
Nov 6 2019, 7:45 PM
brooks committed rS354409: libstats: Improve ABI assertion..
libstats: Improve ABI assertion.
Nov 6 2019, 7:45 PM
brooks added a reviewer for D22251: libcompat: build 32-bit rtld and ldd as part of "everything": jhb.
Nov 6 2019, 7:38 PM
brooks added reviewers for D22251: libcompat: build 32-bit rtld and ldd as part of "everything": imp, bdrewery, kib.

I've now testing this in an amd64 VM with i386 binaries so it's ready for review.

Nov 6 2019, 7:28 PM
brooks created D22251: libcompat: build 32-bit rtld and ldd as part of "everything".
Nov 6 2019, 12:38 AM

Nov 5 2019

brooks updated the summary of D22188: libstats: Fix ABI assertion..
Nov 5 2019, 5:44 PM

Nov 4 2019

brooks committed rS354340: Remove an outdated assertion..
Remove an outdated assertion.
Nov 4 2019, 9:06 PM

Oct 31 2019

brooks committed rS354232: truss: centralize pointer-constructing casts..
truss: centralize pointer-constructing casts.
Oct 31 2019, 10:29 PM
brooks closed D22212: truss: centralize pointer-constructing casts..
Oct 31 2019, 10:29 PM
brooks added a comment to D22212: truss: centralize pointer-constructing casts..

For the records, the CheriBSD commit is: https://github.com/CTSRD-CHERI/cheribsd/commit/805aa75408d105dd2c069c04e3b551caae24c558

Oct 31 2019, 10:28 PM
brooks added a comment to D22212: truss: centralize pointer-constructing casts..

This is extracted from CheriBSD. I'm not 100% it's something we want, but figure we should either upstream it (so I don't have compile errors every time a call to get_struct() is added) or remove it.

Oct 31 2019, 9:55 PM
brooks created D22212: truss: centralize pointer-constructing casts..
Oct 31 2019, 9:54 PM
brooks abandoned D22211: libstats: Fix ABI assertion..

ARG, this was forked form the wrong branch. Will redo

Oct 31 2019, 9:53 PM