- User Since
- Jul 1 2014, 6:02 PM (185 w, 5 d)
Fri, Jan 19
Seems to be unnecessary. I don't like the way some defaults work out, but *shrug*.
Wed, Jan 17
Mon, Jan 15
Add people who have touched pw as possible reviewers.
- Tweak wording as suggested by @bcr.
Wed, Jan 10
Tue, Jan 9
Sat, Jan 6
Fri, Jan 5
This seems reasonable to me. I'd prefer /etc/wpa_supplicant.d/em0.conf in place of /etc/wpa_supplicant.conf.em0.
Dec 22 2017
Dec 19 2017
See also https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224443. After I deal with ports I plan to abandon this revision and split the changes that are viable up into individual diffs.
Dec 14 2017
- Rename struct mymsg to testmsg to avoid FreeBSD's misdecleration.
Dec 13 2017
First the overall alignment is computed:
maxalign = MAX(tcbalign, tls_init_align);
and then tls_block_size is computed with all the assorted padding and without relation to tcbalign.
The whole allocation is then aligned to maxalign with:
tls_block = malloc_aligned(tls_block_size, maxalign);
However, if tcbalign is > tls_block_size the TLS segment will be aligned to tls_block_size not maxalign. As a practical matter I'm not sure this can happen, but this code is confusing enough that I really don't want to have to read through multiple codepaths and traverser weak symbols to convince myself it won't. We should either honor all reasonable values for tcbalign is document our assumptions about them clearly.
Dec 12 2017
This is technically an information disclosure, but in practice is quite small and unlikely to be a serious issue in the current world order.
Dec 7 2017
This code generally seem like an improvement for code where there are hidden alignment requirements in the binary, but it isn't complete. If you do something like:
extern __thread char array_16k; __attribute__((__aligned__(16384))) __thread char array_16k;
Then it will only reliably be aligned to 8k. On at least mips64 this will be a regression.
Nov 30 2017
LGTM, but I'd wait for @emaste to take a look as he's been working on makefs.
Over all the approach seems fine.
I'd guess the upstream version used struct __sFILE to avoid header pollution somewhere, but this seems perfectly fine here.
Nov 29 2017
Nov 28 2017
Nov 27 2017
Nov 23 2017
Nov 22 2017
Nov 20 2017
Nov 17 2017
You shouldn't need to change the size or roundup2 the syscall argument. With the change in rS325364 the TLS allocation should be properly aligned so long as the PT_TLS segment has the right alignment. You could change the definition of TLS_TCB_ALIGN to be 16 for mips like it is on amd64, but we should be setting the alignment of the TLS segment correctly and fix it if we aren't.
Is this needed at all after rS325364? We should now be respecting the alignment of the PT_TLS section. If the PT_TLS section isn't correctly aligned then fixing that is the right answer rather than trashing the ABI.
Why not just nuke TLS_TCB_SIZE32?
Nov 16 2017
Nov 13 2017
Nov 12 2017
xlint has been useless for years and has some of the worst code quality in the base system. Its removal is long overdue.
Nov 2 2017
Looks good to me. We should probably make similar changes to Variant II.
Oct 31 2017
Oct 30 2017
Oct 18 2017
- Add Copyright blocks (manual merge)
Oct 15 2017
Oct 14 2017
I've posted an updated diff in D12677
Miles, I've extracted this from your GitHub repo and made a few changes to the Makefile and would like to commit this soon. One thing that is missing is appropriate BSD copyright blocks on bench.py and sort_bench.c. I can't commit without them. Please provide me with your preferred Copyright line and acknowledge that these are to be available under the standard FreeBSD license (https://www.freebsd.org/copyright/freebsd-license.html).
Thank you for doing this work! Sorry it took me so long to commit it.
Merge to FreeBSD head prior to commit to SVN.
Oct 13 2017
Oct 12 2017
Oct 11 2017
Oct 6 2017
Dag-Erling should probably weigh in as this is a pam change.
I like this a lot. It should help users of llvm-config since they can link llvm-config## in as llvm-config. I suspect this will spawn many USES flags.
Oct 5 2017
I'm confused as to how the rcp directory doesn't end up /usr/test/bin/, but can confirm that it doesn't in a VM with the test suite installed.
Oct 4 2017
Small missing bit: etc/mtree/BSD.tests.dist contains a rcp directory. There are presumably missing ObsoleteFiles.inc entries for tests as well. Otherwise looks good to me.