brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (169 w, 3 h)

Recent Activity

Fri, Sep 22

brooks committed rP450418: Add xtoolchain port for llvm50..
Add xtoolchain port for llvm50.
Fri, Sep 22, 10:03 PM

Thu, Sep 21

brooks committed rP450313: Remove bogus plist entry..
Remove bogus plist entry.
Thu, Sep 21, 11:46 PM

Wed, Sep 20

brooks committed rP450206: Spell PORTREVISION correctly..
Spell PORTREVISION correctly.
Wed, Sep 20, 4:06 PM
brooks committed rP450183: Don't install a wrapper for the not installed pp-trace program..
Don't install a wrapper for the not installed pp-trace program.
Wed, Sep 20, 1:34 AM
brooks committed rP450182: Update to a new snapshot..
Update to a new snapshot.
Wed, Sep 20, 1:09 AM

Tue, Sep 19

brooks committed rP450176: Disable LLDB builds on 10.x as they don't link..
Disable LLDB builds on 10.x as they don't link.
Tue, Sep 19, 11:44 PM

Mon, Sep 18

brooks committed rP450073: Fix builds without COMPILER_RT..
Fix builds without COMPILER_RT.
Mon, Sep 18, 7:24 PM

Fri, Sep 15

brooks committed rP449939: Upgrade to a new snapshot. Now named 6.0..
Upgrade to a new snapshot. Now named 6.0.
Fri, Sep 15, 11:22 PM

Thu, Sep 14

brooks committed rP449851: Add a port of LLVM 5.0.0 release..
Add a port of LLVM 5.0.0 release.
Thu, Sep 14, 7:30 PM

Mon, Sep 11

brooks added a comment to D12301: Enhance mdmfs(8) to work with tmpfs(5).

This seems like a clean solution. The only downside I see is that you'd always need mdmfs(8) around.

Mon, Sep 11, 4:22 PM

Mon, Aug 28

brooks accepted D12036: Add basic tests generated via automation tool [1].

These look good to me.

Mon, Aug 28, 11:45 PM

Aug 24 2017

brooks added a comment to D11646: Mergesort Benchmark.

I'd suggest adding a README file describing what the tests do and what the script's expected outputs are.

Aug 24 2017, 6:10 PM
brooks added inline comments to D11646: Mergesort Benchmark.
Aug 24 2017, 6:09 PM
brooks added inline comments to D11646: Mergesort Benchmark.
Aug 24 2017, 5:49 PM

Aug 4 2017

brooks added a comment to D11621: Mergesort Tests.

@ngie I think I had a misunderstanding with what these diff's should represent. I had been updating the page with diff's against the previous commits I had posted, for review purposes. Is the standard protocol for this page to host a diff against freebsd head such that it could be directly applied?

Aug 4 2017, 12:50 PM

Jul 28 2017

brooks committed rP446856: Update to a July 20th snapshot including 128-bit correctness fixes and.
Update to a July 20th snapshot including 128-bit correctness fixes and
Jul 28 2017, 10:00 PM
brooks accepted D11465: Upgrade GDB to 8.0..

LGTM

Jul 28 2017, 6:53 PM
brooks added a comment to D11646: Mergesort Benchmark.

If you can create a Makefile for this I'll look to get it committed soon (I'll be heading to the UK next Sunday, but will be doing FreeBSD things during the week so helpful I'll be able to get this committed.)

Jul 28 2017, 5:51 PM

Jul 24 2017

brooks added a comment to D11598: Wikisort.

A general question. How much do these files differ from the upstream version? Did you need to make any structural changes? I both ask to help be review this work and to figure out how we should integrate it into FreeBSD.

Jul 24 2017, 10:07 PM

Jul 21 2017

brooks added a comment to D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.

Arg. I was ready to go, but ran into conflicts with a change to usage() by @ngie. I'm not sure how best to blend the result. If we add that expansion to the subcommands the result will got from unwieldy to incomprehensible (not to mention not fitting on an 80 column display).

Jul 21 2017, 10:23 PM
brooks updated subscribers of D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.

Arg. I was ready to go, but ran into conflicts with a change to usage() by @ngie. I'm not sure how best to blend the result. If we add that expansion to the subcommands the result will got from unwieldy to incomprehensible (not to mention not fitting on an 80 column display).

Jul 21 2017, 10:21 PM
brooks accepted D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.

Great! This looks ready to go. I'll apply to a tree and commit shortly.

Jul 21 2017, 9:41 PM
brooks added a comment to D11646: Mergesort Benchmark.

This is looking good so far. You may want a macro to disable wikisort support so we can commit the benchmark on it's own.

Jul 21 2017, 9:15 PM
brooks added a comment to D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.
  • Add ``#!/bin/sh'' to the test script
Jul 21 2017, 8:56 PM

Jul 19 2017

brooks added a comment to D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.

Sorry for letting this sit so long. I'm finally getting back to this now that I can run FreeBSD 12 binaries on my build systems.

Jul 19 2017, 10:38 PM
brooks committed rS321256: Include ARCH_FLAGS in CFLAGS when building modules..
Include ARCH_FLAGS in CFLAGS when building modules.
Jul 19 2017, 10:06 PM
brooks closed D11633: Include ARCH_FLAGS in CFLAGS when building modules. by committing rS321256: Include ARCH_FLAGS in CFLAGS when building modules..
Jul 19 2017, 10:06 PM
brooks added a comment to D11633: Include ARCH_FLAGS in CFLAGS when building modules..

It looks like ARCH_FLAGS is used only on MIPS? I'm missing something here since it seems the default MIPS ARCH_FLAGS is set in sys/conf/Makefile.mips, which has CFLAGS+=${EXTRA_FLAGS} $(ARCH_FLAGS)

Jul 19 2017, 3:57 PM
brooks added inline comments to D11621: Mergesort Tests.
Jul 19 2017, 3:50 PM

Jul 18 2017

brooks added a comment to D11646: Mergesort Benchmark.

This benchmark is my initial design without full understanding of statistical validity. Is it at all still usable or it better to just pull out the relevant bits that run the sorting code into separate files and then attempt to bench them with ministat and multiple trials. Is shell a better medium for this?

Jul 18 2017, 10:54 PM
brooks created D11633: Include ARCH_FLAGS in CFLAGS when building modules..
Jul 18 2017, 12:39 AM

Jul 14 2017

brooks committed rS320999: Add 32-bit compat for kinfo_proc's ki_tdaddr..
Add 32-bit compat for kinfo_proc's ki_tdaddr.
Jul 14 2017, 9:13 PM
brooks closed D11521: Add 32-bit compat for kinfo_proc's ki_tdaddr. by committing rS320999: Add 32-bit compat for kinfo_proc's ki_tdaddr..
Jul 14 2017, 9:13 PM

Jul 7 2017

brooks created D11521: Add 32-bit compat for kinfo_proc's ki_tdaddr..
Jul 7 2017, 5:29 PM

Jun 23 2017

brooks committed rP444184: Upgrade to 4.0.1 release..
Upgrade to 4.0.1 release.
Jun 23 2017, 5:39 PM

Jun 20 2017

brooks updated the diff for D11231: Correct link metadata created when installing with -DNO_ROOT..
  • More cleanups of link permissions.
  • The geom classes build libraries, but install links to programs so
Jun 20 2017, 10:44 PM
brooks added a comment to D11231: Correct link metadata created when installing with -DNO_ROOT..

I'll submit a revised version shortly. I think I've got a test plan for release tar balls so I'll be trying that as well.

Jun 20 2017, 10:39 PM
brooks committed rS320169: MFC r318968:.
MFC r318968:
Jun 20 2017, 8:20 PM
brooks committed rP443917: Fix build with CLANG disabled..
Fix build with CLANG disabled.
Jun 20 2017, 12:11 AM

Jun 17 2017

brooks added a comment to D11231: Correct link metadata created when installing with -DNO_ROOT..
  • Add an INSTALL_MLINK to install manpage links.
Jun 17 2017, 12:11 AM
brooks updated the diff for D11231: Correct link metadata created when installing with -DNO_ROOT..
  • Add an INSTALL_MLINK to install manpage links.
Jun 17 2017, 12:10 AM

Jun 16 2017

brooks accepted D11025: Extend struct kevent fields and add absolute timers..
Jun 16 2017, 6:43 PM

Jun 15 2017

brooks created D11231: Correct link metadata created when installing with -DNO_ROOT..
Jun 15 2017, 11:02 PM
brooks accepted D11106: Use tmpfs in rc.initdiskless.

This seems like a fine modernization. Probably should not be MFC'd due to POLA with custom kernels.

Jun 15 2017, 5:44 PM

Jun 14 2017

brooks added a reviewer for D11154: Don't print all timezones during installworld: gjb.

I wonder if the -print was intentionally left for debugging purposes. I'm adding Glen who touched this line last.

Jun 14 2017, 6:09 PM

Jun 3 2017

brooks added inline comments to D11025: Extend struct kevent fields and add absolute timers..
Jun 3 2017, 12:06 AM

Jun 2 2017

brooks added inline comments to D11025: Extend struct kevent fields and add absolute timers..
Jun 2 2017, 11:35 PM
brooks added a comment to D11025: Extend struct kevent fields and add absolute timers..

I like the change of types for ident and data. intptr_t was defiantly the wrong type for data.

Jun 2 2017, 2:18 PM

Jun 1 2017

brooks added a comment to D11020: Add test cases for cat(1).

Why have your copied this files that are already in the source tree?

Jun 1 2017, 9:32 PM
brooks added inline comments to D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.
Jun 1 2017, 3:06 PM

May 30 2017

brooks committed rP442109: Apply ino64 patches..
Apply ino64 patches.
May 30 2017, 6:14 PM

May 26 2017

brooks committed rS318968: Add missing usage and getopt(3) options.
Add missing usage and getopt(3) options
May 26 2017, 9:10 PM
brooks closed D10915: usr.bin/procstat: Add missing usage and getopt(3) options by committing rS318968: Add missing usage and getopt(3) options.
May 26 2017, 9:10 PM
brooks accepted D10915: usr.bin/procstat: Add missing usage and getopt(3) options.

Looks good to me. I'll commit shortly.

May 26 2017, 7:50 PM
brooks added inline comments to D10915: usr.bin/procstat: Add missing usage and getopt(3) options.
May 26 2017, 4:07 PM

May 25 2017

brooks added reviewers for D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs: allanjude, rwatson.

Note to other reviewers. This change is at my suggestion and it's from the ideas page (https://wiki.freebsd.org/IdeasPage?highlight=%28procstat%29#Switch_procstat_from_subcommand_flags_to_verbs). The motivation to switch to subcommands comes from conflict after conflict with CheriBSD additions to procstat. It's also more natural for the various exclusive modes to be subcommands and the vastly larger namespace of whole words make more room for expansion vs single character flags.

May 25 2017, 11:29 PM
brooks committed rP441708: Disable LLDB on FreeBSD 10..
Disable LLDB on FreeBSD 10.
May 25 2017, 6:34 PM

May 24 2017

brooks committed rP441627: Adapt to ino64 changes.[0].
Adapt to ino64 changes.[0]
May 24 2017, 11:15 PM
brooks closed D10796: lang/llvm39: Update for ino64 by committing rP441627: Adapt to ino64 changes.[0].
May 24 2017, 11:15 PM
brooks added a comment to D10797: lang/llvm40: Update for ino64.
In D10797#225646, @jkim wrote:

PORTREVISION went backwards. :-(

May 24 2017, 10:43 PM
brooks committed rP441626: Bump rather than decrement PORTREVISION..
Bump rather than decrement PORTREVISION.
May 24 2017, 10:42 PM
brooks committed rP441623: Adapt to ino64 changes.[0].
Adapt to ino64 changes.[0]
May 24 2017, 10:14 PM
brooks closed D10797: lang/llvm40: Update for ino64 by committing rP441623: Adapt to ino64 changes.[0].
May 24 2017, 10:14 PM
brooks added a comment to D10797: lang/llvm40: Update for ino64.

I'm going to commit this with the diff split in two as I expect it to land upstream in two parts.

May 24 2017, 10:13 PM
brooks committed rP441622: Correct __FreeBSD_version value for ino64..
Correct __FreeBSD_version value for ino64.
May 24 2017, 10:09 PM
brooks committed rP441621: Update to a new snapshot..
Update to a new snapshot.
May 24 2017, 9:39 PM

May 22 2017

brooks accepted D10859: Fix build with LOCALBASE is not /usr/local..

Do we need a version bump or are people with non-default PREFIX values on their own?

May 22 2017, 5:34 PM

May 18 2017

brooks accepted D10796: lang/llvm39: Update for ino64.

LGTM.

May 18 2017, 9:49 PM
brooks accepted D10797: lang/llvm40: Update for ino64.

This is fine for the moment. Hopefully someone with an llvm commit bit can upstream these two pieces.

May 18 2017, 9:47 PM
brooks added inline comments to D10797: lang/llvm40: Update for ino64.
May 18 2017, 7:13 PM
brooks committed rP441125: Update to new snapshot..
Update to new snapshot.
May 18 2017, 1:00 AM

May 17 2017

brooks accepted D10775: Fix shebangs in devel/tesla.

LGTM. Feel free to commit or I can do it.

May 17 2017, 5:13 PM

May 15 2017

brooks committed rS318327: MFC r317660, r317710.
MFC r317660, r317710
May 15 2017, 11:14 PM
brooks committed rS318323: MFC r317845-r317846.
MFC r317845-r317846
May 15 2017, 10:51 PM
brooks committed rS318322: MFC r317660, r317710.
MFC r317660, r317710
May 15 2017, 10:41 PM
brooks added a reviewer for D10695: Enable shared page support on mips.: imp.
May 15 2017, 7:24 PM
brooks updated the diff for D10695: Enable shared page support on mips..
  • Make MIPS shared page support optional.
  • Shared page support works fine on QEMU MALTA so enable there.
May 15 2017, 7:21 PM
brooks added inline comments to D6362: Use llvm openmp on amd64 when the compiler chosen is clang.
May 15 2017, 6:32 PM

May 13 2017

brooks created D10695: Enable shared page support on mips..
May 13 2017, 12:17 AM

May 12 2017

brooks committed rS318244: MFC r317845-r317846.
MFC r317845-r317846
May 12 2017, 5:40 PM
brooks accepted D9030: Create new fexecve() variant with explicit interpreter.

FWIW, I'm not a fan of the NULL terminated argv and envv arguments as they make argument validation in CheriABI harder, but I mostly think that ship has sailed. If I were to fix it I'd make the syscall a into a __ffexecve() that takes lengths and have ffexecve() be a user space wrapper that counts the lengths of the vectors and passes them down.

May 12 2017, 4:51 PM

May 10 2017

brooks accepted D10665: Skip the 'status_coredump' test if coredumps are disabled via kern.coredump..

LGTM

May 10 2017, 11:06 PM

May 9 2017

brooks committed rS318030: MFC r317707:.
MFC r317707:
May 9 2017, 4:29 PM
brooks committed rS318029: MFC r317707:.
MFC r317707:
May 9 2017, 4:27 PM
brooks committed rS317997: MFC r317706:.
MFC r317706:
May 9 2017, 1:09 AM

May 8 2017

brooks closed D10630: Fix build of devel/llvm40 on powerpc by committing rP440459: Upgrade to 4.0.1rc1..
May 8 2017, 8:32 PM
brooks committed rP440459: Upgrade to 4.0.1rc1..
Upgrade to 4.0.1rc1.
May 8 2017, 8:32 PM
brooks accepted D10630: Fix build of devel/llvm40 on powerpc.

The patch applies and doesn't break amd64. As an unconditional patch-* file it would break builds without the LLDB option enabled. I'll fix that in my commit shortly.

May 8 2017, 8:30 PM

May 5 2017

brooks added inline comments to D10609: Persistently store NIC's hardware MAC address, and add a way to retrive it.
May 5 2017, 10:07 PM
brooks added inline comments to D10609: Persistently store NIC's hardware MAC address, and add a way to retrive it.
May 5 2017, 9:52 PM
brooks committed rS317846: Regent post r317845..
Regent post r317845.
May 5 2017, 6:50 PM
brooks committed rS317845: Provide a freebsd32 implementation of sigqueue().
Provide a freebsd32 implementation of sigqueue()
May 5 2017, 6:49 PM
brooks closed D10605: Provide a freebsd32 implementation of sigqueue(). by committing rS317845: Provide a freebsd32 implementation of sigqueue().
May 5 2017, 6:49 PM
brooks updated the diff for D10605: Provide a freebsd32 implementation of sigqueue()..
  • Zero union sigval sv.
May 5 2017, 6:26 PM
brooks added inline comments to D10605: Provide a freebsd32 implementation of sigqueue()..
May 5 2017, 6:25 PM
brooks updated the diff for D10605: Provide a freebsd32 implementation of sigqueue()..
  • Adopt improvements to manpage from wblock.
  • Fix from kib.
  • Split a kern_sigqueue() out of sys_sigqeueu().
  • Reimplement freebsd32_sigqueue in terms of kern_sigqueue.
May 5 2017, 5:51 PM
brooks committed rS317841: MFC r317388:.
MFC r317388:
May 5 2017, 5:29 PM
brooks added a comment to D10605: Provide a freebsd32 implementation of sigqueue()..
In D10605#220076, @kib wrote:

More important, I do not think that the implementation is good: why not do it in a way similar to other shims ? I mean, create kern_sigqueue() which takes either native-ABI union or just void * for arg, and which does everything that sys_sigqueue() does now. Then freebsd32_sigqueue() becomes PTRIN() + kern_sigqueue, instead of being a literal copy of sys_sigqueue().

If you do not want to code this, I will provide the patch. The man page update is good, it should go in independently then.

May 5 2017, 4:54 PM
brooks committed rS317834: MFC r317566:.
MFC r317566:
May 5 2017, 4:24 PM
brooks committed rS317831: MFC r317566:.
MFC r317566:
May 5 2017, 3:15 PM