Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (224 w, 4 d)

Recent Activity

Thu, Oct 18

brooks closed D17476: Don't include the broken riscv64sf TARGET_ARCH in universe..

Committed in rS339272

Thu, Oct 18, 5:54 PM

Mon, Oct 15

brooks created D17574: Remove __restrict qualifiers from syscalls.master..
Mon, Oct 15, 8:28 PM
brooks updated the diff for D17488: Remove the need for backslashes in syscalls.master..
  • Allow both types of joins to be mixed. This makes it easier to semi-programatically convert files where alternative names are wrapped with backslashes.
Mon, Oct 15, 8:07 PM

Wed, Oct 10

brooks updated the summary of D17488: Remove the need for backslashes in syscalls.master..
Wed, Oct 10, 3:47 PM
brooks added a comment to D17488: Remove the need for backslashes in syscalls.master..
  • Join without spaceso (previous behavior).

I didn't have a strong opinion on this either way, just wanted to make sure it was an intentional change.

Wed, Oct 10, 3:43 PM
brooks added a comment to D17488: Remove the need for backslashes in syscalls.master..
In D17488#373351, @kib wrote:

Might be it is a good idea to check that there is no nesting '(' or unbalanced ')' ?

Wed, Oct 10, 3:42 PM
brooks updated the diff for D17488: Remove the need for backslashes in syscalls.master..
  • Join without spaceso (previous behavior).
Wed, Oct 10, 3:25 PM

Tue, Oct 9

brooks committed rS339272: Don't include the broken riscv64sf TARGET_ARCH in universe..
Don't include the broken riscv64sf TARGET_ARCH in universe.
Tue, Oct 9, 10:22 PM
brooks added a reviewer for D17488: Remove the need for backslashes in syscalls.master.: imp.
Tue, Oct 9, 10:05 PM
brooks created D17488: Remove the need for backslashes in syscalls.master..
Tue, Oct 9, 10:04 PM
brooks committed rS339269: Regenerated assorted syscall related files after:.
Regenerated assorted syscall related files after:
Tue, Oct 9, 8:42 PM
brooks accepted D17046: Only compute the X_COMPILER_*/X_LINKER_* variables when needed.

LGTM

Tue, Oct 9, 3:28 PM

Mon, Oct 8

brooks committed rS339245: MFC r338925:.
MFC r338925:
Mon, Oct 8, 10:38 PM
brooks added a reviewer for D17397: Consolidate identical ELF auxargs type defintions.: jhibbits.
Mon, Oct 8, 8:59 PM
brooks updated the diff for D17475: Move 32-bit compat support for FIODGNAME to the right place..
  • style(9) as pointed out by @kib
Mon, Oct 8, 8:36 PM
brooks added a comment to D17397: Consolidate identical ELF auxargs type defintions..

Universe builds except for the perennially broken riscv64sf. Tested amd64 with new and old user land and kernel in all parings (new, old; old, new; new, new).

Mon, Oct 8, 8:17 PM
brooks created D17476: Don't include the broken riscv64sf TARGET_ARCH in universe..
Mon, Oct 8, 8:04 PM
brooks created D17475: Move 32-bit compat support for FIODGNAME to the right place..
Mon, Oct 8, 7:59 PM
brooks added inline comments to D17438: Add NT_FREEBSD_FEATURE_CTL ELF note to csu.
Mon, Oct 8, 5:48 PM

Thu, Oct 4

brooks committed rS339186: Revert r339174: Move 32-bit compat support for FIODGNAME to the right place..
Revert r339174: Move 32-bit compat support for FIODGNAME to the right place.
Thu, Oct 4, 11:55 PM
brooks committed rS339184: Reduce NL_ARGMAX to 4096 to match Linux..
Reduce NL_ARGMAX to 4096 to match Linux.
Thu, Oct 4, 9:56 PM
brooks closed D17387: Reduce NL_ARGMAX to 4096 to match Linux..
Thu, Oct 4, 9:56 PM
brooks added a comment to D15971: elfdump: Add -E to test if a file is an ELF binary..

bump

Thu, Oct 4, 9:32 PM
brooks added a reviewer for D15816: Normalize COMPAT_43 syscall declerations.: jhb.
Thu, Oct 4, 9:23 PM
brooks updated the summary of D17397: Consolidate identical ELF auxargs type defintions..
Thu, Oct 4, 8:33 PM
brooks updated the summary of D17397: Consolidate identical ELF auxargs type defintions..
Thu, Oct 4, 8:27 PM
brooks updated the diff for D17397: Consolidate identical ELF auxargs type defintions..
  • Move all of AT_* to sys/elf_common.h with powerpc ifdefs.
Thu, Oct 4, 8:26 PM
brooks updated the summary of D17387: Reduce NL_ARGMAX to 4096 to match Linux..
Thu, Oct 4, 8:10 PM

Wed, Oct 3

brooks closed D17388: Move 32-bit compat support for FIODGNAME to the right place..

Committed in rS339174

Wed, Oct 3, 11:45 PM
brooks created D17397: Consolidate identical ELF auxargs type defintions..
Wed, Oct 3, 11:27 PM
brooks committed rS339174: Move 32-bit compat support for FIODGNAME to the right place..
Move 32-bit compat support for FIODGNAME to the right place.
Wed, Oct 3, 8:40 PM
brooks committed rP481176: Fix plist on i386..
Fix plist on i386.
Wed, Oct 3, 6:15 PM
brooks closed D17378: Move 32-bit compat support for CDIOREADTOCENTRYS to the right place..

Committed in rS339101

Wed, Oct 3, 5:37 PM
brooks updated the diff for D17388: Move 32-bit compat support for FIODGNAME to the right place..
  • Switch on the actual command not the size per kib.
Wed, Oct 3, 5:35 PM
brooks added inline comments to D17388: Move 32-bit compat support for FIODGNAME to the right place..
Wed, Oct 3, 3:22 PM

Tue, Oct 2

brooks created D17388: Move 32-bit compat support for FIODGNAME to the right place..
Tue, Oct 2, 11:51 PM
brooks committed rS339101: Move 32-bit compat support for CDIOREADTOCENTRYS to the right place..
Move 32-bit compat support for CDIOREADTOCENTRYS to the right place.
Tue, Oct 2, 11:24 PM
brooks added a comment to D8286: printf: Validate argument index is >0.

I've created D17387 with a trivial patch to switch to 4096.

Tue, Oct 2, 11:04 PM
brooks created D17387: Reduce NL_ARGMAX to 4096 to match Linux..
Tue, Oct 2, 11:03 PM
brooks added a comment to D8286: printf: Validate argument index is >0.

That being said, if I'm reading the grok results (https://grok.dragonflybsd.org/search?project=dports&q=NL_ARGMAX&defs=&refs=&path=&hist=&type=&si=q&n=25)correctly this is kind of an own-goal on PostgreSQL's part due to their insistence on rolling their own versions of all sorts of things. We need to work with them, but part of that should probably be trying to convince them to pick up modern versions of things like snprintf.

Tue, Oct 2, 9:07 PM
brooks added a comment to D8286: printf: Validate argument index is >0.

It seems like cutting NL_ARGMAX back to 1024 or even reverting to 99 makes sense. You're doing some pretty weird macro meta-programming to get to a 100 argument printf.

Tue, Oct 2, 9:04 PM
brooks committed rP481132: Fix build on non-clang systems.[0].
Fix build on non-clang systems.[0]
Tue, Oct 2, 8:12 PM
brooks committed rP481120: Update to a new snapshot..
Update to a new snapshot.
Tue, Oct 2, 4:45 PM

Mon, Oct 1

brooks updated the diff for D17378: Move 32-bit compat support for CDIOREADTOCENTRYS to the right place..
  • Use sizeof(union->struct) consistantly.
Mon, Oct 1, 10:15 PM
brooks added inline comments to D17378: Move 32-bit compat support for CDIOREADTOCENTRYS to the right place..
Mon, Oct 1, 10:08 PM
brooks updated the diff for D17378: Move 32-bit compat support for CDIOREADTOCENTRYS to the right place..
  • Pass cmd to te_data_get_ptr and switch on the size rather than SV_ILP32.
Mon, Oct 1, 10:07 PM
brooks created D17378: Move 32-bit compat support for CDIOREADTOCENTRYS to the right place..
Mon, Oct 1, 6:08 PM

Sat, Sep 29

brooks updated the diff for D17349: GC unused and undocumented copyout_(un)map() interfaces..
  • Add a vm_mmap_object.9 and add removed code as examples.
Sat, Sep 29, 12:12 AM

Fri, Sep 28

brooks planned changes to D17349: GC unused and undocumented copyout_(un)map() interfaces..

Those are good points and an argument for a vm_mmap_object.9 which contains these functions as an example. I'll look into that.

Fri, Sep 28, 7:17 PM
brooks added a comment to D17349: GC unused and undocumented copyout_(un)map() interfaces..

It's not referenced anywhere in the tree, the code is trivial, and it will always be there in svn if someone wants it back.

Fri, Sep 28, 5:00 PM
brooks created D17349: GC unused and undocumented copyout_(un)map() interfaces..
Fri, Sep 28, 4:16 PM
brooks accepted D17344: Mark various removed system calls as OBSOL instead of UNIMPL..
Fri, Sep 28, 3:25 PM

Thu, Sep 27

brooks accepted D17342: Run 32-bit compat ldconfig on mips64..
Thu, Sep 27, 9:19 PM
brooks committed rS338990: Centralize compat support for PCIOCGETCONF..
Centralize compat support for PCIOCGETCONF.
Thu, Sep 27, 9:08 PM
brooks closed D17324: Centralize compat support for PCIOCGETCONF..
Thu, Sep 27, 9:08 PM

Wed, Sep 26

brooks accepted D17331: Remove -m (update) from ldconfig -32 invocation on startup..

This seems to make sense.

Wed, Sep 26, 10:07 PM
brooks committed rP480741: Update Objective-C LLVM version to 6.0..
Update Objective-C LLVM version to 6.0.
Wed, Sep 26, 3:24 PM
brooks added a comment to D17324: Centralize compat support for PCIOCGETCONF..
In D17324#369437, @kib wrote:

Why did you moved everything but pci bar mmap case ?

Wed, Sep 26, 3:12 PM

Tue, Sep 25

brooks created D17324: Centralize compat support for PCIOCGETCONF..
Tue, Sep 25, 10:32 PM
brooks committed rP480702: bump llvm depend for 10.x to llvm60..
bump llvm depend for 10.x to llvm60.
Tue, Sep 25, 10:14 PM
brooks committed rP480701: Update dependency on llvm40 to llvm60 and constrain to FreeBSD 10.x..
Update dependency on llvm40 to llvm60 and constrain to FreeBSD 10.x.
Tue, Sep 25, 10:10 PM
brooks committed rP480700: Update 10.x build depend on clang to llvm60..
Update 10.x build depend on clang to llvm60.
Tue, Sep 25, 10:05 PM
brooks committed rP480686: Update to a more recent snapshot..
Update to a more recent snapshot.
Tue, Sep 25, 5:57 PM
brooks committed rS338925: Don't override LDFLAGS set in bsd.cpu.mk..
Don't override LDFLAGS set in bsd.cpu.mk.
Tue, Sep 25, 3:25 PM

Mon, Sep 24

brooks added a comment to D14609: Split libc into libc and libsys.

Rebuilding with a clean objdir seems to have worked. We're probably going to want to find the root cause there so we can add workarounds to Makefile.inc1.

Mon, Sep 24, 11:41 PM

Fri, Sep 21

brooks committed rS338860: Disable sbrk() use in GNU tools..
Disable sbrk() use in GNU tools.
Fri, Sep 21, 5:44 PM
brooks closed D16141: Disable sbrk() use in GNU tools..
Fri, Sep 21, 5:44 PM

Sep 20 2018

brooks committed rP480180: Add xtoolchain-llvm70..
Add xtoolchain-llvm70.
Sep 20 2018, 2:48 PM
brooks committed rP480151: Update to LLVM 7.0.0 Release..
Update to LLVM 7.0.0 Release.
Sep 20 2018, 2:47 AM

Sep 18 2018

brooks updated the diff for D16141: Disable sbrk() use in GNU tools..
  • Rebase
  • Add /* #undef HAVE_SBRK */ comments.
Sep 18 2018, 10:02 PM
brooks added a comment to D16141: Disable sbrk() use in GNU tools..

I've finally done a tinderbox run on this with make tinderbox UNIVERSE_TARGET=toolchain JFLAG=-j16. All targets built and compiled things so I think we're ready to go.

Sep 18 2018, 9:50 PM
brooks committed rS338753: Regen after r338752..
Regen after r338752.
Sep 18 2018, 4:17 PM
brooks committed rS338752: Only enable HyperV support by default on x86..
Only enable HyperV support by default on x86.
Sep 18 2018, 4:06 PM
brooks closed D17211: Only enable HyperV support by default on x86..
Sep 18 2018, 4:06 PM
brooks closed D17174: Put guards around timespec_get() decleration..
Sep 18 2018, 3:31 PM
brooks committed rS338751: Fix C11 and POSIX 1003.1b-1993 compliance in time.h.
Fix C11 and POSIX 1003.1b-1993 compliance in time.h
Sep 18 2018, 3:31 PM

Sep 17 2018

brooks created D17211: Only enable HyperV support by default on x86..
Sep 17 2018, 11:17 PM
brooks updated the diff for D17174: Put guards around timespec_get() decleration..
  • Check __ISO_C_VISIBLE unconditionally and rewrap.
Sep 17 2018, 10:19 PM
brooks updated the diff for D17174: Put guards around timespec_get() decleration..
  • Use ISO_C_VISIBLE and BSD_VISIBLE per @kib's suggestion.
Sep 17 2018, 8:53 PM
brooks added a comment to D14609: Split libc into libc and libsys.

Sorry for the delay in dealing with this...

Sep 17 2018, 3:24 PM

Sep 14 2018

brooks added a comment to D17174: Put guards around timespec_get() decleration..

This block of include/time.h at line 76:

#if __POSIX_VISIBLE >= 199309
/*
 * New in POSIX 1003.1b-1993.
 */
#ifndef _CLOCKID_T_DECLARED
typedef __clockid_t     clockid_t;
#define _CLOCKID_T_DECLARED
#endif
Sep 14 2018, 9:25 PM
brooks added a comment to D17174: Put guards around timespec_get() decleration..

Timespec defined by the include of sys/timespec.h IFF:

Sep 14 2018, 8:30 PM
brooks added a comment to D17174: Put guards around timespec_get() decleration..

In CheriBSD, we have a copy of libpng in base that compiled with a low enough C standard that time.h breaks without this. I'm quite surprised the original change doesn't break some ports.

Sep 14 2018, 7:05 PM
brooks created D17174: Put guards around timespec_get() decleration..
Sep 14 2018, 7:04 PM

Sep 13 2018

brooks committed rP479687: Update to a new snapshot..
Update to a new snapshot.
Sep 13 2018, 6:45 PM
brooks committed rP479683: Update to release candidate 3..
Update to release candidate 3.
Sep 13 2018, 5:37 PM
brooks accepted D17117: rtld: set obj->textsize correctly.

LGTM

Sep 13 2018, 4:21 PM
brooks accepted D17154: rtld-elf: fix more warnings to allow compiling with WARNS=6.

LGTM

Sep 13 2018, 4:17 PM
brooks accepted D17153: rtld-elf: fix WANRS=4 warnings other than -Wcast-align.

Module to style issues kib points out, this looks good to me.

Sep 13 2018, 4:16 PM
brooks accepted D17150: rtld-elf: make it compile with WARNS=3.

LGTM

Sep 13 2018, 3:42 PM

Sep 12 2018

brooks committed rP479612: Update llvm dependency (for 10.x support) to llvm60..
Update llvm dependency (for 10.x support) to llvm60.
Sep 12 2018, 4:01 PM

Sep 7 2018

brooks accepted D17067: procstat(1): Properly display AT_EHDRFLAGS.

LGTM.

Sep 7 2018, 3:23 PM

Sep 6 2018

brooks committed rS338486: Rework rtld's TLS Variant I implementation to match r326794.
Rework rtld's TLS Variant I implementation to match r326794
Sep 6 2018, 12:26 PM

Aug 28 2018

brooks committed rP478325: Update to 7.0.0rc2..
Update to 7.0.0rc2.
Aug 28 2018, 4:37 PM

Aug 24 2018

brooks committed rP477965: Fix build when the default python version isn't 2.7..
Fix build when the default python version isn't 2.7.
Aug 24 2018, 3:53 PM

Aug 23 2018

brooks accepted D16867: Fix ncurses fallback.c build with a strict build shell.

LGTM

Aug 23 2018, 8:43 PM
brooks updated the diff for D16730: Committers Guide: Add a section encouraging pre-commit review..
  • Don't allow timeouts. (Discussion still pending...)
Aug 23 2018, 5:06 PM
brooks updated the diff for D16730: Committers Guide: Add a section encouraging pre-commit review..
  • Accept some suggestions from @jhb.
Aug 23 2018, 5:00 PM
brooks added inline comments to D16867: Fix ncurses fallback.c build with a strict build shell.
Aug 23 2018, 3:59 PM

Aug 22 2018

brooks updated the diff for D16730: Committers Guide: Add a section encouraging pre-commit review..
  • Rebase
  • Clarify that these are most specific to src.
  • Provide an out for changes where there isn't an expert available.
Aug 22 2018, 7:01 PM