Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (567 w, 3 d)

Recent Activity

Yesterday

brooks accepted D50362: SPDX: Tag BSD-4.3TAHOE.

Seems correct at a glance, but maybe let @imp weight in before committing.

Fri, May 16, 12:58 AM

Tue, May 13

brooks accepted D50254: release: Use "debug info" in dist set descriptions.
Tue, May 13, 4:05 PM
brooks accepted D50262: release: Exclude release/obj from the src tarball.
Tue, May 13, 4:04 PM

Mon, May 12

brooks committed R11:a19a05201688: devel/llvm-cheriot: break up with devel/llvm-cheri (authored by brooks).
devel/llvm-cheriot: break up with devel/llvm-cheri
Mon, May 12, 3:21 AM
brooks committed R11:c874c5fbe5cf: devel/llvm-cheriot: New LLVM 20.1.3 based snapshot (authored by brooks).
devel/llvm-cheriot: New LLVM 20.1.3 based snapshot
Mon, May 12, 3:20 AM

Sun, May 11

brooks accepted D50269: release: Use NO_ROOT mode for dvd1.iso.

Does pig-state eventually lose the -N argument entirely?

Sun, May 11, 11:12 PM
brooks accepted D50268: release: Pass -N to pkg-stage if NO_ROOT set.
Sun, May 11, 11:11 PM

Thu, May 8

brooks added inline comments to D50173: release/pkg-stage: Support non-root release artifact builds.
Thu, May 8, 6:22 PM

Wed, May 7

brooks accepted D50173: release/pkg-stage: Support non-root release artifact builds.
Wed, May 7, 6:20 PM
brooks accepted D50179: release: Use unprivileged mode for disc1 and memstick.
Wed, May 7, 6:12 PM
brooks accepted D50242: mbuf: Allow clusters to fill an entire jumbo page..

Seems reasonable. Sorry I missed that MCLBYTES is something people adjust upward.

Wed, May 7, 6:10 PM

Mon, May 5

brooks accepted D50084: strings: Unconditionally install ELF Tool Chain's strings.
Mon, May 5, 6:42 PM
brooks committed R11:cbd8b0bff52e: devel/llvm20: 20.1.4 release (authored by brooks).
devel/llvm20: 20.1.4 release
Mon, May 5, 6:37 PM
brooks added a comment to D50126: UPDATING: Strengthen recommendations.

A level 0 dump is like dd. It gets absolutely everything, unlike a boot environment. I'll work on that after I merge this one.

Mon, May 5, 6:25 PM

Fri, May 2

brooks added a comment to D50126: UPDATING: Strengthen recommendations.

To fix an a separate commit: the foot note ordering is quite jarring.

Fri, May 2, 10:18 PM

Thu, May 1

brooks committed rGf383cfc03bbf: sys.mk: Improve ports compatibility hack guard (authored by brooks).
sys.mk: Improve ports compatibility hack guard
Thu, May 1, 8:15 PM

Tue, Apr 29

brooks committed rG6c3a4b5f9b7b: alloca.3: move to share/man/man3 (authored by brooks).
alloca.3: move to share/man/man3
Tue, Apr 29, 5:19 PM
brooks committed rG64b9e40dc5ba: release: style: prefer `-n` over `! -z` (authored by brooks).
release: style: prefer `-n` over `! -z`
Tue, Apr 29, 5:19 PM
brooks closed D50055: alloca.3: move to share/man/man3.
Tue, Apr 29, 5:19 PM
brooks closed D50056: release: style: prefer `-n` over `! -z`.
Tue, Apr 29, 5:19 PM
brooks added a comment to D50054: armv7: drop alloca from libc.

If this were i386 or amd64 then yes, but armv7 is a tier-2 architecture so we can break the ABI contract in ways that are harmless. IMO there's lots of value in making lower tier platforms less weird.

Tue, Apr 29, 5:08 PM

Mon, Apr 28

brooks requested review of D50056: release: style: prefer `-n` over `! -z`.
Mon, Apr 28, 9:17 PM
brooks requested review of D50055: alloca.3: move to share/man/man3.
Mon, Apr 28, 9:06 PM
brooks requested review of D50054: armv7: drop alloca from libc.
Mon, Apr 28, 9:06 PM
brooks accepted D49954: <net/if_strings.h>: Conditionally export table of bit names.
Mon, Apr 28, 3:58 PM
brooks accepted D49955: <net/sff8472.h>: Conditionally export table of ID names.
Mon, Apr 28, 3:58 PM
brooks added a comment to D49955: <net/sff8472.h>: Conditionally export table of ID names.

There's an argument there should be a DECLARE_SFF_8024_ID macro that consumers add to their .c file, but is easy and has precedent.

Mon, Apr 28, 3:58 PM

Fri, Apr 25

brooks committed rG5fa183f02845: mountd: use free_iovec for build_iovec cleanup (authored by brooks).
mountd: use free_iovec for build_iovec cleanup
Fri, Apr 25, 3:58 PM
brooks closed D49953: mountd: use free_iovec for build_iovec cleanup.
Fri, Apr 25, 3:58 PM

Tue, Apr 22

brooks accepted D49965: Move extra suffix-transformation rules into bsd.suffixes-extra.mk.
Tue, Apr 22, 11:11 PM
brooks committed rGcda23fc36d22: Move mntopts(3) suppport into libutil (authored by brooks).
Move mntopts(3) suppport into libutil
Tue, Apr 22, 9:52 PM
brooks committed rGa123502ef781: Search for mntopts.h globally, not locally (authored by brooks).
Search for mntopts.h globally, not locally
Tue, Apr 22, 9:52 PM
brooks closed D49951: Move mntopts(3) suppport into libutil.
Tue, Apr 22, 9:52 PM
brooks closed D49952: Search for mntopts.h globally, not locally.
Tue, Apr 22, 9:52 PM
brooks updated the summary of D49951: Move mntopts(3) suppport into libutil.
Tue, Apr 22, 6:32 PM
brooks updated the diff for D49951: Move mntopts(3) suppport into libutil.

Use Nm to render libutil in HISTORY

Tue, Apr 22, 6:28 PM
brooks updated the diff for D49951: Move mntopts(3) suppport into libutil.

getmntopts.c -> mntopts.c to match header and manpage.

Tue, Apr 22, 6:26 PM
brooks added inline comments to D49951: Move mntopts(3) suppport into libutil.
Tue, Apr 22, 6:14 PM
brooks updated the summary of D49951: Move mntopts(3) suppport into libutil.
Tue, Apr 22, 6:13 PM
brooks updated the diff for D49951: Move mntopts(3) suppport into libutil.
  • actually install the manpage
  • add guards to header
Tue, Apr 22, 5:58 PM
brooks added a reviewer for D49951: Move mntopts(3) suppport into libutil: dim.
Tue, Apr 22, 4:46 PM
brooks added inline comments to D49733: libc: add execvpe to weak symbol as gnu libc does.
Tue, Apr 22, 4:35 PM
brooks accepted D49733: libc: add execvpe to weak symbol as gnu libc does.
Tue, Apr 22, 4:32 PM
brooks added a comment to D49733: libc: add execvpe to weak symbol as gnu libc does.

Sorry for the churn, but I think @kib is right and this should be declared in libc_private.h and not namespaced.

Tue, Apr 22, 4:16 PM
brooks accepted D49960: Makefile.inc1: Let the buildetc target run outside of etc.
Tue, Apr 22, 4:14 PM
brooks added a comment to D49958: Move mount related functions into libmount.

Sorry, I should have added you to D49951 and D49952 which this duplicates. I don't think a new library is warranted and if it is, it should probably be libmntopts or the like not something as generic as libmount.

Tue, Apr 22, 3:47 PM

Mon, Apr 21

brooks requested review of D49953: mountd: use free_iovec for build_iovec cleanup.
Mon, Apr 21, 10:21 PM
brooks requested review of D49952: Search for mntopts.h globally, not locally.
Mon, Apr 21, 10:18 PM
brooks requested review of D49951: Move mntopts(3) suppport into libutil.
Mon, Apr 21, 10:18 PM

Fri, Apr 18

brooks committed rGa60615d5be83: csu: drop support for GCJ (authored by brooks).
csu: drop support for GCJ
Fri, Apr 18, 7:00 PM
brooks closed D49882: csu: drop support for GCJ.
Fri, Apr 18, 7:00 PM

Thu, Apr 17

brooks added a comment to D49882: csu: drop support for GCJ.

This came in with D17587 for compatibility with old object files. It was roughly contemporaneous with GCC 6.5, the last release with GCJ support.

Thu, Apr 17, 11:06 PM
brooks requested review of D49882: csu: drop support for GCJ.
Thu, Apr 17, 11:04 PM
brooks committed R11:48d6a8562965: devel/llvm20: 20.1.3 release (authored by brooks).
devel/llvm20: 20.1.3 release
Thu, Apr 17, 8:05 PM
brooks committed R11:cbb0094aa11d: devel/llvm-{cheri,morello}: allow non-triple targets (authored by brooks).
devel/llvm-{cheri,morello}: allow non-triple targets
Thu, Apr 17, 8:05 PM
brooks accepted D49733: libc: add execvpe to weak symbol as gnu libc does.

This seems alright.

Thu, Apr 17, 4:47 PM

Apr 11 2025

brooks accepted D49784: elfcopy: Restore upstream name.

This should be less confusing.

Apr 11 2025, 7:02 PM
brooks added a comment to D49733: libc: add execvpe to weak symbol as gnu libc does.

You still need to add a an #undef execvpe line to un-namespace.h and then you shouldn't need the libc_private.h entry. The point of namespace.h/un-namespace.h is that the declarations are impacted by the macro so the execvpe declaration in unistd.h becomes an __libc_execvpe declaration which you can then use.

Apr 11 2025, 6:57 PM
brooks requested changes to D49733: libc: add execvpe to weak symbol as gnu libc does.

I think you need to bring the __weak_reference line back from the original change.

Apr 11 2025, 2:53 AM

Apr 10 2025

brooks accepted D49738: release: Let basic VM images be built with NO_ROOT.
Apr 10 2025, 2:34 PM

Apr 8 2025

brooks added inline comments to D49666: release/vm: finish fixing WITHOUT_QEMU.
Apr 8 2025, 6:32 PM

Apr 7 2025

brooks committed rG75ae454d5814: release/vm: finish fixing WITHOUT_QEMU (authored by brooks).
release/vm: finish fixing WITHOUT_QEMU
Apr 7 2025, 1:27 AM
brooks closed D49666: release/vm: finish fixing WITHOUT_QEMU.
Apr 7 2025, 1:26 AM
brooks added a comment to D49666: release/vm: finish fixing WITHOUT_QEMU.

Is f3a73a7055a8 the right hash -- maybe e6e5cd297ab4cae4995895b99c713df9cf6e8c0f? Change lgtm.

Apr 7 2025, 1:25 AM

Apr 4 2025

brooks committed R11:7c433c2684e1: devel/llvm-devel: new sanpshot (authored by brooks).
devel/llvm-devel: new sanpshot
Apr 4 2025, 10:59 PM
brooks requested review of D49666: release/vm: finish fixing WITHOUT_QEMU.
Apr 4 2025, 6:04 PM

Apr 3 2025

brooks committed R11:ed3db3089894: devel/llvm20: 20.1.2 release (authored by brooks).
devel/llvm20: 20.1.2 release
Apr 3 2025, 5:24 PM

Mar 31 2025

brooks committed R11:408f11de0282: devel/llvm-morello: new snapshot (authored by brooks).
devel/llvm-morello: new snapshot
Mar 31 2025, 7:10 PM

Mar 28 2025

brooks accepted D49528: release/azure: Update instruction of publishing to Azure Marketplace.
Mar 28 2025, 3:54 PM

Mar 27 2025

brooks committed rGe6e5cd297ab4: release/vm: fix setting NO_ROOT and WITHOUT_QEMU (authored by brooks).
release/vm: fix setting NO_ROOT and WITHOUT_QEMU
Mar 27 2025, 11:53 PM
brooks closed D49544: release/vm: fix setting NO_ROOT and WITHOUT_QEMU.
Mar 27 2025, 11:53 PM
brooks requested review of D49544: release/vm: fix setting NO_ROOT and WITHOUT_QEMU.
Mar 27 2025, 11:24 PM
brooks accepted D49493: Makefile.inc1: Rework ELF Tool Chain bootstrapping.

Seems fine conceptually, a couple comments.

Mar 27 2025, 4:31 PM
brooks committed rG9eb6cdafe5e2: release/vm: empty sh functions are disallowed (authored by brooks).
release/vm: empty sh functions are disallowed
Mar 27 2025, 4:04 PM
brooks closed D49526: release/vm: empty sh functions are disallowed.
Mar 27 2025, 4:04 PM
brooks abandoned D49527: release/vm: only include Makefile.azure if used.
Mar 27 2025, 4:01 PM

Mar 26 2025

brooks updated the diff for D49527: release/vm: only include Makefile.azure if used.

fix typo pointed out by @emaste

Mar 26 2025, 7:42 PM
brooks requested review of D49527: release/vm: only include Makefile.azure if used.
Mar 26 2025, 6:58 PM
brooks requested review of D49526: release/vm: empty sh functions are disallowed.
Mar 26 2025, 6:57 PM
brooks committed R11:3a3f702fad8d: devel/llvm-morello: new snapshot (authored by brooks).
devel/llvm-morello: new snapshot
Mar 26 2025, 4:18 PM
brooks committed R11:f769ee17868a: devel/llvm20: 20.1.1 release (authored by brooks).
devel/llvm20: 20.1.1 release
Mar 26 2025, 4:18 PM

Mar 24 2025

brooks accepted D49351: sysctl: Panic on OID reuse.
Mar 24 2025, 7:43 PM

Mar 21 2025

brooks closed D49429: committers guide: permit key words more than once.
Mar 21 2025, 5:07 PM
brooks committed R9:4ccefaf81a2e: committers guide: permit key words more than once (authored by brooks).
committers guide: permit key words more than once
Mar 21 2025, 5:07 PM

Mar 20 2025

brooks updated the diff for D49429: committers guide: permit key words more than once.
  • s/answers answers/values/ as pointed out by @jbo
Mar 20 2025, 10:01 PM
brooks requested review of D49429: committers guide: permit key words more than once.
Mar 20 2025, 9:56 PM
brooks accepted D49425: usr.bin/Makefile: always build ELF Tool Chain strings.
Mar 20 2025, 5:51 PM

Mar 17 2025

brooks committed R11:003492f69b68: emulators/qemu-user-static: fix build on main (authored by brooks).
emulators/qemu-user-static: fix build on main
Mar 17 2025, 6:38 PM
brooks committed R11:48d88a1daa6b: devel/llvm18: backport llvm19 fixes (authored by brooks).
devel/llvm18: backport llvm19 fixes
Mar 17 2025, 6:38 PM
brooks committed R11:4a13ba037fcd: devel/llvm16: backport flang fixes for llvm19 (authored by brooks).
devel/llvm16: backport flang fixes for llvm19
Mar 17 2025, 6:38 PM
brooks committed R11:670a29d46198: devel/llvm15: fix backport of llvm19 fixes (authored by brooks).
devel/llvm15: fix backport of llvm19 fixes
Mar 17 2025, 6:38 PM
brooks committed R11:ade92d9844b2: devel/llvm16: fix backport of llvm19 fixes (authored by brooks).
devel/llvm16: fix backport of llvm19 fixes
Mar 17 2025, 6:38 PM
brooks committed R11:8c9c675ac883: devel/llvm17: backport flang fixes for llvm19 (authored by brooks).
devel/llvm17: backport flang fixes for llvm19
Mar 17 2025, 6:38 PM
brooks committed R11:2d9bf097b052: devel/llvm18: Fix !CLANG plist (authored by brooks).
devel/llvm18: Fix !CLANG plist
Mar 17 2025, 6:38 PM
brooks committed R11:67703efddb53: devel/llvm-devel: Fix !CLANG plist (authored by brooks).
devel/llvm-devel: Fix !CLANG plist
Mar 17 2025, 6:38 PM
brooks committed R11:86029af6c255: devel/llvm15: backport flang fixes for llvm19 (authored by brooks).
devel/llvm15: backport flang fixes for llvm19
Mar 17 2025, 6:38 PM
brooks committed R11:0a48be315458: devel/llvm17: Fix !CLANG plist (authored by brooks).
devel/llvm17: Fix !CLANG plist
Mar 17 2025, 6:38 PM
brooks committed R11:d0561bf5e5b4: devel/llvm16: Fix !CLANG plist (authored by brooks).
devel/llvm16: Fix !CLANG plist
Mar 17 2025, 6:38 PM
brooks committed R11:9dadd6e15966: devel/llvm15: whitespace [NFC] (authored by brooks).
devel/llvm15: whitespace [NFC]
Mar 17 2025, 6:38 PM

Mar 14 2025

brooks committed R11:092b9a234522: devel/llvm18: backport llvm19 fixes (authored by brooks).
devel/llvm18: backport llvm19 fixes
Mar 14 2025, 12:57 AM