brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (211 w, 1 d)

Recent Activity

Mon, Jul 16

brooks committed rS336340: MFC r336238:.
MFC r336238:
Mon, Jul 16, 2:17 PM
brooks accepted D16245: Fix buildworld on FreeBSD 10.

LGTM

Mon, Jul 16, 7:59 AM

Fri, Jul 13

brooks committed rS336238: Round down the location of execpathp to slightly improve copyout speed..
Round down the location of execpathp to slightly improve copyout speed.
Fri, Jul 13, 11:32 AM

Tue, Jul 10

brooks accepted D16142: Get rid of some remnants of the old numa..

Looks good to me. Some may complain about the Xr references to the removed numa_getaffinity(2) and numa_setaffinity(2) in numa(4), but I think it's fine given that they are removed from the SEE ALSO.

Tue, Jul 10, 2:08 PM
brooks committed rS336172: Regen after r336171..
Regen after r336171.
Tue, Jul 10, 2:05 PM
brooks committed rS336171: Get rid of netbsd_lchown and netbsd_msync syscall entries..
Get rid of netbsd_lchown and netbsd_msync syscall entries.
Tue, Jul 10, 1:32 PM
brooks closed D16193: Get rid of netbsd_lchown and netbsd_msync syscall entries..
Tue, Jul 10, 1:32 PM

Mon, Jul 9

brooks created D16193: Get rid of netbsd_lchown and netbsd_msync syscall entries..
Mon, Jul 9, 9:26 AM
brooks accepted D16187: No longer install sys/nv.h and sys/cnv.h in lib/libnv/Makefile.

LGTM

Mon, Jul 9, 9:19 AM

Fri, Jul 6

brooks committed rS336033: One more 32-bit fix for r335979..
One more 32-bit fix for r335979.
Fri, Jul 6, 1:35 PM
brooks committed rS336023: Correct breakage on 32-bit platforms from r335979..
Correct breakage on 32-bit platforms from r335979.
Fri, Jul 6, 10:03 AM

Thu, Jul 5

brooks committed rS336002: Work around lame warnings in ancient gcc on 32-bit platforms..
Work around lame warnings in ancient gcc on 32-bit platforms.
Thu, Jul 5, 5:02 PM
brooks committed rS335990: Revert r335983..
Revert r335983.
Thu, Jul 5, 4:03 PM
brooks added a comment to D16142: Get rid of some remnants of the old numa..

It looks like usr.bin/Makefile also needs an update to unhook the removed numactl.

Thu, Jul 5, 3:12 PM
brooks added a comment to D16141: Disable sbrk() use in GNU tools..

Although we still need to make sure that everything still works with this change.

Thu, Jul 5, 3:06 PM
brooks added inline comments to D16141: Disable sbrk() use in GNU tools..
Thu, Jul 5, 2:43 PM
brooks created D16141: Disable sbrk() use in GNU tools..
Thu, Jul 5, 2:36 PM
brooks committed rS335983: Get rid of netbsd_lchown and netbsd_msync syscall entries..
Get rid of netbsd_lchown and netbsd_msync syscall entries.
Thu, Jul 5, 2:13 PM
brooks closed D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
Thu, Jul 5, 2:13 PM
brooks committed rD51966: Document 1200072..
Document 1200072.
Thu, Jul 5, 2:05 PM
brooks closed D15386: Improve portability of structs xinpcb and friends..
Thu, Jul 5, 1:14 PM
brooks committed rS335979: Make struct xinpcb and friends word-size independent..
Make struct xinpcb and friends word-size independent.
Thu, Jul 5, 1:14 PM
brooks added a comment to D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
readelf -a libc.so.7.full | grep netbsd
   905: 000000000008cf10    11 FUNC    GLOBAL DEFAULT   12 netbsd_msync@FBSD_1.0 (2)
  3141: 000000000008cf10    11 FUNC    GLOBAL DEFAULT   12 netbsd_lchown@FBSD_1.0 (2)
   165: 000000000008c0a0    17 FUNC    LOCAL  DEFAULT   12 __sys_netbsd_msync
   166: 000000000008c0a0    17 FUNC    LOCAL  DEFAULT   12 _netbsd_msync
   167: 000000000008c0a0    17 FUNC    LOCAL  DEFAULT   12 netbsd_msync
   168: 000000000008c0e0    17 FUNC    LOCAL  DEFAULT   12 __sys_netbsd_lchown
   169: 000000000008c0e0    17 FUNC    LOCAL  DEFAULT   12 _netbsd_lchown
   170: 000000000008c0e0    17 FUNC    LOCAL  DEFAULT   12 netbsd_lchown
  2040: 000000000008cf10    11 FUNC    GLOBAL DEFAULT   12 netbsd_lchown
  2041: 000000000008cf10    11 FUNC    GLOBAL DEFAULT   12 netbsd_msync
Thu, Jul 5, 7:28 AM
brooks updated the diff for D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
  • Export under the correct versions.
  • Spell enosys consistantly.
Thu, Jul 5, 7:27 AM

Wed, Jul 4

brooks added a comment to D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..

I don't understand why there isn't an exported symbol. I've got a:

Wed, Jul 4, 9:21 AM

Fri, Jun 29

brooks added a comment to D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
$readelf -a ~/obj/home/bed22/git/freebsd/amd64.amd64/lib/libc/libc.so.7 | grep netbsd_lchown
   168: 000000000008c0e0    17 FUNC    LOCAL  DEFAULT   12 __sys_netbsd_lchown
   169: 000000000008c0e0    17 FUNC    LOCAL  DEFAULT   12 _netbsd_lchown
   170: 000000000008c0e0    17 FUNC    LOCAL  DEFAULT   12 netbsd_lchown
Fri, Jun 29, 10:32 PM
brooks updated the diff for D15386: Improve portability of structs xinpcb and friends..
  • Fix a botched kptr_t change.
  • Make kvaddr_t unsigned to match the defintion in kvm.h and remove the
Fri, Jun 29, 8:52 PM
brooks closed D11231: Correct link metadata created when installing with -DNO_ROOT..
Fri, Jun 29, 4:08 PM
brooks committed rS335797: Correct link metadata created when installing with -DNO_ROOT..
Correct link metadata created when installing with -DNO_ROOT.
Fri, Jun 29, 4:08 PM

Thu, Jun 28

brooks updated the diff for D11231: Correct link metadata created when installing with -DNO_ROOT..
  • Rebase.
Thu, Jun 28, 10:43 PM
brooks added a comment to D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
In D15814#338187, @kib wrote:
In D15814#337257, @kib wrote:

You can create symbols which are exported but not linkable, since they do not provide a default version. Such symbol can be only created by asm '@' syntax, it should be removed from the version map. Also I do not see a sense in leaving the private symbols around.

Is there an example of this?

https://reviews.freebsd.org/D12298

Thu, Jun 28, 9:44 PM
brooks abandoned D15935: Fix a stack overflow in mount_smbfs when hostname is too long..

This is a duplicate of D15936.

Thu, Jun 28, 9:36 PM
brooks committed rS335781: MFC r335641:.
MFC r335641:
Thu, Jun 28, 9:23 PM
brooks committed rS335774: MFC r335641:.
MFC r335641:
Thu, Jun 28, 8:33 PM

Wed, Jun 27

brooks committed rP473455: Update to LLVM 6.0.1 release..
Update to LLVM 6.0.1 release.
Wed, Jun 27, 8:18 PM
brooks added a comment to D16019: Split kern_break from sys_break and use it in linuxulator.

I wonder if we also want to restore ibcs2's int return value?

Would that be implementing a ibcs2-specific wrapper? I suspect it's not worth it.

Wed, Jun 27, 4:03 PM

Tue, Jun 26

brooks accepted D16019: Split kern_break from sys_break and use it in linuxulator.
Tue, Jun 26, 10:46 PM
brooks added a comment to D16019: Split kern_break from sys_break and use it in linuxulator.

Looks good to me. I wonder if we also want to restore ibcs2's int return value?

Tue, Jun 26, 10:46 PM
brooks added a comment to D15687: libssp is part of GCC, not an independent library..
Tue, Jun 26, 3:13 PM
brooks accepted D15687: libssp is part of GCC, not an independent library..
Tue, Jun 26, 3:00 PM
brooks added a comment to D15687: libssp is part of GCC, not an independent library..

That makes sense. If in fact nothing ever linked to it then we should just relegate it to the compat11 port and kill it along with gcc.

Tue, Jun 26, 3:00 PM
brooks added a comment to D15687: libssp is part of GCC, not an independent library..

In terms of exposed symbols (see objdump -T), libssp definitely is a FORTIFY_SOURCE implementation. I've not looked at the code to avoid contamination in case we need a cleanroom one.

Tue, Jun 26, 2:49 PM

Mon, Jun 25

brooks committed rS335645: Normalize the g(eom,cache,part,...) build..
Normalize the g(eom,cache,part,...) build.
Mon, Jun 25, 7:55 PM
brooks closed D15360: Normalize the g(eom,cache,part,...) build..
Mon, Jun 25, 7:55 PM
brooks accepted D15953: Kernel environments: use any and all provided environments, evict hintmode and envmode.
Mon, Jun 25, 6:54 PM
brooks added a comment to D15953: Kernel environments: use any and all provided environments, evict hintmode and envmode.

I don't see anything that's going to cause us obvious problems on BERI.

Mon, Jun 25, 6:00 PM
brooks committed rS335641: Fix a stack overflow in mount_smbfs when hostname is too long..
Fix a stack overflow in mount_smbfs when hostname is too long.
Mon, Jun 25, 4:43 PM
brooks closed D15936: Fix a stack overflow in mount_smbfs when hostname is too long..
Mon, Jun 25, 4:43 PM

Fri, Jun 22

brooks added a comment to D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
In D15814#337257, @kib wrote:

You can create symbols which are exported but not linkable, since they do not provide a default version. Such symbol can be only created by asm '@' syntax, it should be removed from the version map. Also I do not see a sense in leaving the private symbols around.

Fri, Jun 22, 10:34 PM
brooks created D15971: elfdump: Add -E to test if a file is an ELF binary..
Fri, Jun 22, 9:16 PM

Wed, Jun 20

brooks added a comment to D15936: Fix a stack overflow in mount_smbfs when hostname is too long..

I'm not sure what the consequences of returning an error here are versus silently truncating. Before this change you'd have hostname "longerthan16chars.local" and it would get passed through as "longerthan16cha" but now mount_smbfs would fail with an error? If that assertion is true maybe it would be better just to copy and truncate at 16 than to return an error.

Wed, Jun 20, 9:03 PM
brooks updated the diff for D15936: Fix a stack overflow in mount_smbfs when hostname is too long..
  • Per discussion in the PR, truncate the host name to 15 bytes.
Wed, Jun 20, 8:59 PM
brooks created D15936: Fix a stack overflow in mount_smbfs when hostname is too long..
Wed, Jun 20, 8:29 PM
brooks created D15935: Fix a stack overflow in mount_smbfs when hostname is too long..
Wed, Jun 20, 8:25 PM
brooks updated the diff for D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
  • Add the version of the compat stubs I ment to add.
Wed, Jun 20, 8:14 PM
brooks updated the diff for D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
  • Add compat symbols returning ENOSYS.
Wed, Jun 20, 8:13 PM

Jun 18 2018

brooks committed rP472718: Update CHERI LLVM and QEMU to new snapshots..
Update CHERI LLVM and QEMU to new snapshots.
Jun 18 2018, 9:31 PM
brooks updated the summary of D15816: Normalize COMPAT_43 syscall declerations..
Jun 18 2018, 4:54 PM
brooks added a comment to D15816: Normalize COMPAT_43 syscall declerations..
In D15816#334486, @kib wrote:

Remove SYSPROTO for them all, instead of patching ? It is not useful for current syscalls, and obviously even less so for compat.

Jun 18 2018, 4:52 PM
brooks updated the diff for D15386: Improve portability of structs xinpcb and friends..
  • s/kptr_t/kvaddr_t/
Jun 18 2018, 3:18 PM
brooks added a comment to D15386: Improve portability of structs xinpcb and friends..
  • Use new ksize_t and kptr_t instead of (u)int64_t.
  • Adjust some padding.

Hmm. This is the problem with thinking overnight on things. Do you think it should be kvaddr_t rather than kptr_t?

Jun 18 2018, 3:14 PM

Jun 17 2018

brooks updated the diff for D15386: Improve portability of structs xinpcb and friends..
  • Use new ksize_t and kptr_t instead of (u)int64_t.
  • Adjust some padding.
Jun 17 2018, 6:58 PM
brooks added a comment to D15468: Add helper functions to copy strings into struct image_args..

I think I've addressed @jhb's feedback now.

Jun 17 2018, 5:59 PM
brooks updated the diff for D15468: Add helper functions to copy strings into struct image_args..
  • Remove/cleanup casts.
  • Spelling.
  • Remove code subsumed by exec_args_adjust_args. (needs further testing)
Jun 17 2018, 4:31 PM

Jun 15 2018

brooks accepted D15827: Remove obsolete asf(8).

LGTM. Doing the deprecation notice in the manpage seems like a good idea, but won't effect this review.

Jun 15 2018, 5:26 PM
brooks added a comment to D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..

I just discover that libc exported these syscalls. Technically this change is an impermissible ABI break, but there isn't any valid way to the the published API to link to those symbols so I think that's ok. If it's not, I can add trivial stubs for netbsd_lchown() and netbsd_msync() that just call the respective __sys_*.

Jun 15 2018, 12:19 AM
brooks updated the diff for D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
  • Don't export *netbsd_* symbols.
  • Use AUE_NULL for removed netbsd syscalls.
Jun 15 2018, 12:18 AM
brooks created D15816: Normalize COMPAT_43 syscall declerations..
Jun 15 2018, 12:11 AM

Jun 14 2018

brooks created D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
Jun 14 2018, 10:49 PM
brooks updated the summary of D15637: Regularize the decleration of the exit syscall..
Jun 14 2018, 9:35 PM
brooks updated the diff for D15386: Improve portability of structs xinpcb and friends..
  • Fix typo.
  • Update UPDATING date and __FreeBSD_version
Jun 14 2018, 9:32 PM
brooks committed rS335178: Regen after 335177 (rename sys_obreak to sys_break)..
Regen after 335177 (rename sys_obreak to sys_break).
Jun 14 2018, 9:29 PM
brooks committed rS335177: Name the implementation of brk and sbrk sys_break()..
Name the implementation of brk and sbrk sys_break().
Jun 14 2018, 9:27 PM
brooks closed D15638: Name the implementation of brk and sbrk sys_break()..
Jun 14 2018, 9:27 PM
brooks updated the summary of D15638: Name the implementation of brk and sbrk sys_break()..
Jun 14 2018, 8:56 PM
brooks updated the summary of D15468: Add helper functions to copy strings into struct image_args..
Jun 14 2018, 8:45 PM
brooks updated the diff for D15638: Name the implementation of brk and sbrk sys_break()..
  • GC a pointless printf.
Jun 14 2018, 8:38 PM

Jun 12 2018

brooks added a comment to rS335020: Fix number of auxargs entries to copy out for 32-bit Linuxulator..

Thanks for the fix!

Jun 12 2018, 11:51 PM

Jun 10 2018

brooks added a comment to D15714: libc qsort: stop aliasing.
In D15714#332308, @kib wrote:

This looks fine for FreeBSD.

The current implementation will break CheriBSD, but it's easy enough to fix on our end.

What do you plan to do to fix it ? I tried to provide some way to not loose the optimization of doing the word swaps, but cannot imagine how to do it without introducing MD primitive.
But for the cheri fix it should be something sufficiently close to that ?

Jun 10 2018, 2:43 PM

Jun 9 2018

brooks added a comment to D15714: libc qsort: stop aliasing.
In D15714#332308, @kib wrote:

This looks fine for FreeBSD.

The current implementation will break CheriBSD, but it's easy enough to fix on our end.

What do you plan to do to fix it ? I tried to provide some way to not loose the optimization of doing the word swaps, but cannot imagine how to do it without introducing MD primitive.
But for the cheri fix it should be something sufficiently close to that ?

Jun 9 2018, 6:58 PM
brooks accepted D15714: libc qsort: stop aliasing.
Jun 9 2018, 5:54 PM
brooks added a comment to D15714: libc qsort: stop aliasing.

This looks fine for FreeBSD.

Jun 9 2018, 5:54 PM

Jun 8 2018

brooks updated the diff for D15638: Name the implementation of brk and sbrk sys_break()..
  • Rebase on top of new return.
Jun 8 2018, 1:45 PM

Jun 5 2018

brooks accepted D15665: Fix missing files in METALOG with -DNO_ROOT.

LGTM

Jun 5 2018, 2:14 PM

Jun 1 2018

brooks committed rS334500: Remove support for SYS_sys_exit in favor of SYS_exit..
Remove support for SYS_sys_exit in favor of SYS_exit.
Jun 1 2018, 10:09 PM
brooks updated the diff for D15637: Regularize the decleration of the exit syscall..
  • Don't export unused __sys_exit symbol.
  • Update compat/freebsd32/capabilities.conf.
Jun 1 2018, 5:11 PM
brooks updated the diff for D15638: Name the implementation of brk and sbrk sys_break()..
  • Update capabilities.conf.
  • Use sys_break in linux compat.
  • Handle freebsd32 and ibcs.
Jun 1 2018, 5:04 PM

May 31 2018

brooks created D15638: Name the implementation of brk and sbrk sys_break()..
May 31 2018, 11:28 PM
brooks added a comment to D15637: Regularize the decleration of the exit syscall..

This effectively reverts rS63986 and rS64001 which were obsoleted by rS225617.

May 31 2018, 10:59 PM
brooks updated the summary of D15637: Regularize the decleration of the exit syscall..
May 31 2018, 10:51 PM
brooks added a comment to D15637: Regularize the decleration of the exit syscall..
In D15637#330341, @kib wrote:

The syscall is _exit or _Exit, not exit.

May 31 2018, 9:34 PM
brooks added a reviewer for D15637: Regularize the decleration of the exit syscall.: imp.
May 31 2018, 6:46 PM
brooks added a comment to D15637: Regularize the decleration of the exit syscall..

I'm starting a sweep through syscalls.master and attempting to reduce the use of alternative function and argument names as well as return types. My hope is to eliminate the need for them, but I'm working on it as a background task so doing them one at a time.

May 31 2018, 6:45 PM
brooks created D15637: Regularize the decleration of the exit syscall..
May 31 2018, 6:41 PM
brooks committed rS334440: MFC r292268, r334176.
MFC r292268, r334176
May 31 2018, 4:11 PM
brooks committed rS334439: MFC r334176:.
MFC r334176:
May 31 2018, 4:01 PM

May 30 2018

brooks committed rS334405: Remove alternative names that are identical to the default..
Remove alternative names that are identical to the default.
May 30 2018, 10:23 PM
brooks updated the summary of D15468: Add helper functions to copy strings into struct image_args..
May 30 2018, 9:45 PM
brooks updated the diff for D15468: Add helper functions to copy strings into struct image_args..
  • Remove a nonsensical assert.
May 30 2018, 9:40 PM
brooks added a comment to D15386: Improve portability of structs xinpcb and friends..

Anyone on transport care about this?

May 30 2018, 9:02 PM