Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (241 w, 3 d)

Recent Activity

Thu, Feb 14

brooks committed rP492961: Upgrade to 8.0.0rc2..
Upgrade to 8.0.0rc2.
Thu, Feb 14, 11:22 PM

Tue, Feb 12

brooks committed rD52815: Committers Guide: Add a section encouraging pre-commit review..
Committers Guide: Add a section encouraging pre-commit review.
Tue, Feb 12, 10:49 PM
brooks closed D16730: Committers Guide: Add a section encouraging pre-commit review..
Tue, Feb 12, 10:49 PM
brooks updated the diff for D16730: Committers Guide: Add a section encouraging pre-commit review..
  • Fix typo.
Tue, Feb 12, 7:00 PM
brooks updated the summary of D16730: Committers Guide: Add a section encouraging pre-commit review..
Tue, Feb 12, 7:00 PM
brooks updated the diff for D16730: Committers Guide: Add a section encouraging pre-commit review..
  • Rebase
  • Reduce the scope of these guidelines to cover only head.
Tue, Feb 12, 6:51 PM
brooks updated the summary of D16730: Committers Guide: Add a section encouraging pre-commit review..
Tue, Feb 12, 6:28 PM

Mon, Feb 11

brooks accepted D19147: Reserve next `NT_FREEBSD_FEATURE_CTL` bits.

I'm fine with this as is or with the _ENABLE removed.

Mon, Feb 11, 10:24 PM
brooks committed rS344023: mdmfs: Fix many bugs in automatic md(4) creation..
mdmfs: Fix many bugs in automatic md(4) creation.
Mon, Feb 11, 9:31 PM
brooks closed D19122: mdmfs: Fix many bugs in automatic md(4) creation..
Mon, Feb 11, 9:31 PM
brooks updated the diff for D19122: mdmfs: Fix many bugs in automatic md(4) creation..
  • Remove obsolete and always true assert.
  • Remove pointless close(). fclose() closes the descriptor.
Mon, Feb 11, 7:05 PM
brooks updated the summary of D19122: mdmfs: Fix many bugs in automatic md(4) creation..
Mon, Feb 11, 7:04 PM
brooks updated the summary of D19122: mdmfs: Fix many bugs in automatic md(4) creation..
Mon, Feb 11, 7:02 PM

Fri, Feb 8

brooks updated the diff for D19122: mdmfs: Fix many bugs in automatic md(4) creation..
  • Make sure there's at least space for one digit of a unit number.
Fri, Feb 8, 10:06 PM
brooks committed rP492463: Fix a misspelling of elif and match all powerpc ARCHs..
Fix a misspelling of elif and match all powerpc ARCHs.
Fri, Feb 8, 9:50 PM
brooks created D19122: mdmfs: Fix many bugs in automatic md(4) creation..
Fri, Feb 8, 6:13 PM

Thu, Feb 7

brooks committed rP492401: Add support for reducing the number of LLVM backends built..
Add support for reducing the number of LLVM backends built.
Thu, Feb 7, 11:51 PM
brooks committed rS343884: GC a historical artifact..
GC a historical artifact.
Thu, Feb 7, 11:17 PM

Wed, Feb 6

brooks added a comment to D18622: Import GoogleTest 1.8.1 into the vendor tree under `^/google/googletest/dist`.

@imp, @brooks you seem to be possible curators of contrib/; does google/googletest/ seem like the right location? Seems sensible to me.

Wed, Feb 6, 9:00 PM
brooks committed rP492319: Attempt to work around a problem with binutils not liking the armv6 code.
Attempt to work around a problem with binutils not liking the armv6 code
Wed, Feb 6, 7:01 PM

Mon, Feb 4

brooks committed rS343756: MFC r343587:.
MFC r343587:
Mon, Feb 4, 10:38 PM

Fri, Feb 1

brooks accepted D19053: readelf: use table-based DT_FLAGS and DT_FLAGS_1 decoding.

LGTM

Fri, Feb 1, 6:18 PM
brooks accepted D19054: readelf: decode FreeBSD note types.

LGTM

Fri, Feb 1, 6:15 PM

Thu, Jan 31

brooks committed rS343632: Remove iBCS2: also remove xenix syscall function support..
Remove iBCS2: also remove xenix syscall function support.
Thu, Jan 31, 11:01 PM
brooks committed rS343630: Regen after r342190..
Regen after r342190.
Thu, Jan 31, 10:58 PM

Wed, Jan 30

brooks committed rS343597: Regen after r343596: enable ppoll in capability mode..
Regen after r343596: enable ppoll in capability mode.
Wed, Jan 30, 11:48 PM
brooks committed rS343596: MFC r340129, r340195, r340198.
MFC r340129, r340195, r340198
Wed, Jan 30, 11:47 PM
brooks committed rS343595: MFC r340242:.
MFC r340242:
Wed, Jan 30, 11:39 PM
brooks committed rS343594: MFC r340242:.
MFC r340242:
Wed, Jan 30, 11:36 PM
brooks committed rP491658: Fix DOCS build..
Fix DOCS build.
Wed, Jan 30, 9:20 PM
brooks committed rS343587: Add a simple port filter to SIFTR..
Add a simple port filter to SIFTR.
Wed, Jan 30, 5:44 PM
brooks closed D18897: Add a simple port filter to SIFTR.
Wed, Jan 30, 5:44 PM

Tue, Jan 29

brooks closed D8286: printf: Validate argument index is >0.
Tue, Jan 29, 7:34 PM
brooks accepted D8286: printf: Validate argument index is >0.
Tue, Jan 29, 7:33 PM
brooks commandeered D8286: printf: Validate argument index is >0.

This was committed and should have auto-closed. Commandeer so I can close it.

Tue, Jan 29, 7:33 PM
brooks added inline comments to D18897: Add a simple port filter to SIFTR.
Tue, Jan 29, 7:30 PM
brooks committed rS343558: MFC r343366:.
MFC r343366:
Tue, Jan 29, 6:14 PM
brooks committed rS343557: MFC r343366:.
MFC r343366:
Tue, Jan 29, 6:08 PM
brooks committed rS343556: MFC r343305:.
MFC r343305:
Tue, Jan 29, 6:06 PM

Mon, Jan 28

brooks committed rP491522: Update to a new shpashot matching our upcoming paper..
Update to a new shpashot matching our upcoming paper.
Mon, Jan 28, 11:33 PM
brooks committed rP491521: Update to a new snapshot matching our upcoming paper..
Update to a new snapshot matching our upcoming paper.
Mon, Jan 28, 11:33 PM
brooks committed rP491520: Update to a new snapshow matching our upcoming paper..
Update to a new snapshow matching our upcoming paper.
Mon, Jan 28, 11:32 PM

Fri, Jan 25

brooks committed rP491125: Fix packaging..
Fix packaging.
Fri, Jan 25, 12:57 AM

Thu, Jan 24

brooks committed rP491121: Welcome LLVM (clang, lld, lldb, etc) 8.0.0.rc1..
Welcome LLVM (clang, lld, lldb, etc) 8.0.0.rc1.
Thu, Jan 24, 9:55 PM
brooks added a comment to D18936: Remove the unused and unusable MDIOCLIST ioctl..
In D18936#404680, @kib wrote:

Does the removal mean that we are unable to build some old releases in chroot ?

Thu, Jan 24, 4:28 PM
brooks added a comment to D18936: Remove the unused and unusable MDIOCLIST ioctl..

A search of dports for MDIOCLIST shows only on result (in a duplicate header) so I don't think an exp-run is required here https://grok.dragonflybsd.org/search?q=MDIOCLIST&defs=&refs=&path=&hist=&type=

Thu, Jan 24, 4:21 PM
brooks created D18936: Remove the unused and unusable MDIOCLIST ioctl..
Thu, Jan 24, 12:13 AM

Wed, Jan 23

brooks committed rS343366: Remove documentation for the nonexistant cred_update_thread(9)..
Remove documentation for the nonexistant cred_update_thread(9).
Wed, Jan 23, 11:26 PM
brooks added inline comments to D18930: Per-thread credentials.
Wed, Jan 23, 11:17 PM

Tue, Jan 22

brooks committed rS343305: Rework CASE_IOC_IFGROUPREQ() to require a case before the macro..
Rework CASE_IOC_IFGROUPREQ() to require a case before the macro.
Tue, Jan 22, 5:39 PM
brooks closed D18442: Rework CASE_IOC_IFGROUPREQ() to require a case before it..
Tue, Jan 22, 5:39 PM
brooks updated the diff for D18880: Extend mmap(2) API to specify the max page protections..
  • Fix build and remove _PROT_ALL from namespace.
Tue, Jan 22, 5:29 PM

Mon, Jan 21

brooks committed rS343273: MFC r343162:.
MFC r343162:
Mon, Jan 21, 7:33 PM
brooks committed rS343272: MFC r343162:.
MFC r343162:
Mon, Jan 21, 7:22 PM

Sat, Jan 19

brooks committed rP490683: Update to a new version (LLVM HEAD is now 9.0.0)..
Update to a new version (LLVM HEAD is now 9.0.0).
Sat, Jan 19, 12:05 AM
brooks closed D18879: remove clang headers conflicting with FreeBSD headers.
Sat, Jan 19, 12:05 AM
brooks accepted D18879: remove clang headers conflicting with FreeBSD headers.

I'll commit shortly

Sat, Jan 19, 12:02 AM

Fri, Jan 18

brooks committed rP490680: Remove obsolete conflicts entries referencing clang-devel..
Remove obsolete conflicts entries referencing clang-devel.
Fri, Jan 18, 10:57 PM
brooks committed rP490677: Remove metaport for clang-devel..
Remove metaport for clang-devel.
Fri, Jan 18, 10:42 PM
brooks committed rP490675: Remove obsolete and unmaintained clang 3.5..
Remove obsolete and unmaintained clang 3.5.
Fri, Jan 18, 10:34 PM
brooks added inline comments to D18897: Add a simple port filter to SIFTR.
Fri, Jan 18, 9:49 PM
brooks closed D18885: Make SIFTR work again.
Fri, Jan 18, 9:46 PM
brooks committed rS343162: Make SIFTR work again after r342125 (D18443)..
Make SIFTR work again after r342125 (D18443).
Fri, Jan 18, 9:46 PM
brooks committed rS343161: Use a private definition of osockaddr rather then relying on type.
Use a private definition of osockaddr rather then relying on type
Fri, Jan 18, 9:30 PM
brooks closed D14505: Use a private definition of osockaddr rather then relying on type namespace polution in sys/socket.h..
Fri, Jan 18, 9:30 PM
op awarded D18880: Extend mmap(2) API to specify the max page protections. a Like token.
Fri, Jan 18, 9:15 PM
brooks updated the diff for D18880: Extend mmap(2) API to specify the max page protections..
  • Remove CheriBSD specific userspace diffs.
  • Guard new macros with __BSD_VISIBLE
Fri, Jan 18, 7:49 PM
brooks accepted D18885: Make SIFTR work again.

Looks good to me. I'd like to get one more +1 and then I'm happy to commit it (or see it committed).

Fri, Jan 18, 7:47 PM
brooks added a comment to D18885: Make SIFTR work again.

Shall I split off the port filter into a seperate Diff?

Fri, Jan 18, 6:50 PM
brooks added inline comments to D18885: Make SIFTR work again.
Fri, Jan 18, 6:49 PM
brooks added a comment to D18885: Make SIFTR work again.

I agree with @imp that the stack change shouldn't be there. I'm not super happy about mixing new features with bug fixes.

Fri, Jan 18, 6:07 PM

Thu, Jan 17

brooks committed rP490610: More throughly disable assertions. This works around USES=cmake.
More throughly disable assertions. This works around USES=cmake
Thu, Jan 17, 11:29 PM
brooks closed D17990: Avoid realpath(3) if not needed..
Thu, Jan 17, 11:29 PM
brooks committed rS343126: MFC r342398:.
MFC r342398:
Thu, Jan 17, 11:23 PM
brooks added a comment to D18880: Extend mmap(2) API to specify the max page protections..

Note: this isn't at all commit ready. It's just a simple extraction of what's in CheriBSD so people can look at it.

Thu, Jan 17, 10:04 PM
brooks created D18880: Extend mmap(2) API to specify the max page protections..
Thu, Jan 17, 9:55 PM
brooks added a comment to D18879: remove clang headers conflicting with FreeBSD headers.

What version of FreeBSD is your system running? I'm happy to commit this, but want to make sure I understand the issue fully.

Thu, Jan 17, 8:30 PM

Jan 15 2019

brooks committed rP490385: Update to a new snapshot..
Update to a new snapshot.
Jan 15 2019, 4:19 PM

Jan 9 2019

brooks committed rP489840: Upgrade to a new snapshot..
Upgrade to a new snapshot.
Jan 9 2019, 11:06 PM
brooks committed rS342889: style(9): fix the indent of a return..
style(9): fix the indent of a return.
Jan 9 2019, 5:24 PM

Jan 4 2019

brooks added a comment to D18696: sysctlmibinfo(3).

This looks like a neat library. I've made a few comments based on a casual review.

Jan 4 2019, 6:07 PM
brooks committed rP489257: MFH: r489195 (reliability fix blanket).
MFH: r489195 (reliability fix blanket)
Jan 4 2019, 4:16 PM

Jan 3 2019

brooks committed rP489225: Add a patch files for stable/12 r342281, which corresponds to the.
Add a patch files for stable/12 r342281, which corresponds to the
Jan 3 2019, 9:17 PM
brooks closed D18699: devel/llvm60: Add patch for stable/12 rS342281.
Jan 3 2019, 9:17 PM
brooks closed D18691: devel/llvm70: Add patches for head rS342592 and rS342593.

Committed in rP489195

Jan 3 2019, 7:18 PM
brooks accepted D18691: devel/llvm70: Add patches for head rS342592 and rS342593.
Jan 3 2019, 7:18 PM
brooks committed rP489195: Backport two Objective-C bug fixes (D18672).
Backport two Objective-C bug fixes (D18672)
Jan 3 2019, 6:10 PM
brooks closed D18672: Backport two Objective-C bug fixes to devel/llvm70.
Jan 3 2019, 6:10 PM

Dec 20 2018

brooks added a comment to D18603: Fix compile warning in if_fxp(4)..

Thanks for chasing this down. This was quite the abomination...

Dec 20 2018, 5:28 PM

Dec 18 2018

brooks committed rS342190: const poison the `new` pointer of __sysctl..
const poison the `new` pointer of __sysctl.
Dec 18 2018, 12:45 PM
brooks closed D18444: const poison the `new` pointer of __sysctl..
Dec 18 2018, 12:45 PM
brooks committed rS342189: Partial MFC of r342125:.
Partial MFC of r342125:
Dec 18 2018, 9:16 AM
brooks committed rS342188: MFC r342125:.
MFC r342125:
Dec 18 2018, 9:14 AM

Dec 15 2018

brooks committed rP487524: Upgrade to LLVM 7.0.1 Release..
Upgrade to LLVM 7.0.1 Release.
Dec 15 2018, 3:22 PM
brooks closed D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
Dec 15 2018, 3:06 PM
brooks committed rS342125: Fix bugs in plugable CC algorithm and siftr sysctls..
Fix bugs in plugable CC algorithm and siftr sysctls.
Dec 15 2018, 3:06 PM

Dec 14 2018

brooks accepted D18543: Planned obsolete mips support removal.

Looks good to me. This is a well reasoned list to remove in order to make sure we can support the remaining platforms.

Dec 14 2018, 6:42 AM

Dec 6 2018

brooks updated subscribers of D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
Dec 6 2018, 6:45 PM
brooks added 1 blocking reviewer(s) for D18443: Fix bugs in plugable CC algorithm and siftr sysctls.: transport.

@thj requested transport review before commit so make the them blocking so I don't forget.

Dec 6 2018, 6:38 PM
brooks updated the summary of D15637: Regularize the declaration of the exit syscall..
Dec 6 2018, 6:02 PM