Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (258 w, 6 d)

Recent Activity

Today

brooks updated the summary of D18880: Extend mmap/mprotect API to specify the max page protections..
Mon, Jun 17, 6:13 PM
brooks added inline comments to D18880: Extend mmap/mprotect API to specify the max page protections..
Mon, Jun 17, 4:14 PM
brooks added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..
  • Fix cut-n-pasto
  • Add a check that no invalid prot flags have been passed.
Mon, Jun 17, 4:12 PM
brooks added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..
*** Check failed: /root/freebsd/tests/sys/vm/mmap_test.c:107: MAP_ANON with extra PROT flags succeeded
*** Check failed: /root/freebsd/tests/sys/vm/mmap_test.c:107: shm fd with garbage PROT succeeded

I'll start on updating the tests for this change, but as it is initially disabled by default (after correcting the copy-pasteo, at least) IMO it can go in now.

Mon, Jun 17, 3:43 PM

Fri, Jun 14

brooks updated the diff for D18880: Extend mmap/mprotect API to specify the max page protections..
  • Fix a typo resulting in unbootable systems.
  • Don't imply max_prot when prot is PROT_NONE.
Fri, Jun 14, 11:35 PM

Wed, Jun 12

brooks retitled D18880: Extend mmap/mprotect API to specify the max page protections. from Extend mmap(2) API to specify the max page protections. to Extend mmap/mprotect API to specify the max page protections..
Wed, Jun 12, 11:52 PM
brooks updated the diff for D18880: Extend mmap/mprotect API to specify the max page protections..
  • Add some minimal docs for PROT_MAX.
Wed, Jun 12, 11:33 PM
brooks added inline comments to D18880: Extend mmap/mprotect API to specify the max page protections..
Wed, Jun 12, 9:35 PM
brooks updated the diff for D18880: Extend mmap/mprotect API to specify the max page protections..
  • Simplify setting initial max_prot.
  • style(9): spaces around '|'s.
Wed, Jun 12, 9:34 PM
brooks added inline comments to D20584: add a linux compatible copy_file_range(2) syscall.
Wed, Jun 12, 8:12 PM
brooks committed rP504035: Correct plist file..
Correct plist file.
Wed, Jun 12, 7:57 PM

Fri, Jun 7

brooks edited reviewers for D18880: Extend mmap/mprotect API to specify the max page protections., added: emaste, markj; removed: bhyve.

The latest diff simplifies the whole change to add a sysctl to enable implying PROT_MAX system wide. I've also added mprotect() support. The current code compiles, but is untested.

Fri, Jun 7, 10:17 PM
brooks updated the diff for D18880: Extend mmap/mprotect API to specify the max page protections..
  • Move the EXTRACT macros into the PROT_ namespace.
  • Make implying PROT_MAX values conditional on a sysctl.
  • Allow mprotect() to set maximum protections.
Fri, Jun 7, 10:13 PM
brooks created D20552: Correct the type of the func argument of zk_thread_create()..
Fri, Jun 7, 5:04 PM
brooks committed rP503636: Add an expiration date now that devel/llvm40 has not dependencies..
Add an expiration date now that devel/llvm40 has not dependencies.
Fri, Jun 7, 4:15 PM

Thu, Jun 6

brooks committed rP503602: Update to POCL 1.3..
Update to POCL 1.3.
Thu, Jun 6, 9:07 PM

Thu, May 30

brooks committed rS348446: makesyscalls.sh: always use absolute path for syscalls.conf.
makesyscalls.sh: always use absolute path for syscalls.conf
Thu, May 30, 8:56 PM
brooks closed D20476: makesyscalls.sh: always use absolute path for syscalls.conf.
Thu, May 30, 8:56 PM
brooks retitled D20476: makesyscalls.sh: always use absolute path for syscalls.conf from makesyscalls.sh: always use relative path for syscalls.conf to makesyscalls.sh: always use absolute path for syscalls.conf.
Thu, May 30, 8:54 PM
brooks updated the diff for D20476: makesyscalls.sh: always use absolute path for syscalls.conf.
  • Use ${.CURDIR} instead of ".".
Thu, May 30, 8:47 PM
brooks created D20476: makesyscalls.sh: always use absolute path for syscalls.conf.
Thu, May 30, 8:34 PM

Wed, May 22

brooks accepted D20351: ObsoleteFiles: Manuals are generally .gz.

One commit is fine. Any revert except of the xe(4) removal will conflict on this file anyway.

Wed, May 22, 4:40 PM

Tue, May 21

brooks added a comment to D19504: devel/pmdk: update to 1.5.1.

It looks like there's a missing pkg-plist update. When I build under poudriere I get:

Tue, May 21, 11:58 PM
brooks committed rS348055: Revert r348012, MFC r347963..
Revert r348012, MFC r347963.
Tue, May 21, 4:36 PM

Mon, May 20

brooks committed rS348012: MFC r347963:.
MFC r347963:
Mon, May 20, 9:33 PM
brooks committed rP502172: Update to a newer snapshot 9.0.d20190510..
Update to a newer snapshot 9.0.d20190510.
Mon, May 20, 9:16 PM

Sat, May 18

brooks committed rS347963: Change ed(4), ep(4), and fxp(4) examples to em(4)..
Change ed(4), ep(4), and fxp(4) examples to em(4).
Sat, May 18, 9:02 PM
brooks closed D20311: Change ed(4), ep(4), and fxp(4) examples to em(4)..
Sat, May 18, 9:02 PM
brooks committed rS347962: MFC r339703, r347365, r347703, r347940.
MFC r339703, r347365, r347703, r347940
Sat, May 18, 8:43 PM
brooks added a comment to D20311: Change ed(4), ep(4), and fxp(4) examples to em(4)..

There are some other mentions, but most seem to be docs that haven't been updated in some time.

Sat, May 18, 8:32 PM
brooks created D20311: Change ed(4), ep(4), and fxp(4) examples to em(4)..
Sat, May 18, 8:05 PM

May 18 2019

brooks committed rS347959: MFC r347940.
MFC r347940
May 18 2019, 5:30 PM

May 17 2019

brooks committed rS347940: Remove the notice that ae(4) will be removed in FreeBSD 13..
Remove the notice that ae(4) will be removed in FreeBSD 13.
May 17 2019, 6:17 PM
brooks committed rD53040: Document __FreeBSD_version values 1300026-1300028..
Document __FreeBSD_version values 1300026-1300028.
May 17 2019, 5:02 PM
brooks closed D20292: Document __FreeBSD_version values 1300026-1300028..
May 17 2019, 5:02 PM
brooks created D20292: Document __FreeBSD_version values 1300026-1300028..
May 17 2019, 3:53 PM
brooks committed rS347926: FCP-101: correct date of device driver removal..
FCP-101: correct date of device driver removal.
May 17 2019, 3:44 PM
brooks committed rS347925: FCP-101: Bump __FreeBSD_version for device removal..
FCP-101: Bump __FreeBSD_version for device removal.
May 17 2019, 3:31 PM
brooks committed rS347924: FCP-101: Bump __FreeBSD_version for driver removal..
FCP-101: Bump __FreeBSD_version for driver removal.
May 17 2019, 3:25 PM
brooks committed rS347923: FCP-101: Remove xe(4).
FCP-101: Remove xe(4)
May 17 2019, 3:24 PM
brooks committed rS347922: FCP-101: Remove wb(4).
FCP-101: Remove wb(4)
May 17 2019, 3:24 PM
brooks committed rS347921: FCP-101: Remove vx(4)..
FCP-101: Remove vx(4).
May 17 2019, 3:24 PM
brooks committed rS347920: FCP-101: Remove txp(4)..
FCP-101: Remove txp(4).
May 17 2019, 3:24 PM
brooks committed rS347919: FCP-101: Remove tx(4)..
FCP-101: Remove tx(4).
May 17 2019, 3:24 PM
brooks committed rS347918: FCP-101: Remove tl(4)..
FCP-101: Remove tl(4).
May 17 2019, 3:24 PM
brooks committed rS347917: FCP-101: Remove sn(4)..
FCP-101: Remove sn(4).
May 17 2019, 3:24 PM
brooks committed rS347916: FCP-101: Remove sf(4)..
FCP-101: Remove sf(4).
May 17 2019, 3:23 PM
brooks committed rS347915: FCP-101: Remove pcn(4)..
FCP-101: Remove pcn(4).
May 17 2019, 3:23 PM
brooks committed rS347914: FCP-101: Remove fe(4)..
FCP-101: Remove fe(4).
May 17 2019, 3:23 PM
brooks committed rS347913: FCP-101: Remove ex(4)..
FCP-101: Remove ex(4).
May 17 2019, 3:23 PM
brooks committed rS347912: FCP-101: Remove ep(4)..
FCP-101: Remove ep(4).
May 17 2019, 3:23 PM
brooks committed rS347911: FCP-101: Remove ed(4)..
FCP-101: Remove ed(4).
May 17 2019, 3:23 PM
brooks committed rS347910: FCP-101: Remove de(4)..
FCP-101: Remove de(4).
May 17 2019, 3:23 PM
brooks committed rS347909: FCP-101: Remove cs(4)..
FCP-101: Remove cs(4).
May 17 2019, 3:23 PM
brooks committed rS347908: FCP-101: Remove bm(4)..
FCP-101: Remove bm(4).
May 17 2019, 3:21 PM
brooks closed D20230: Remove obsolete 10 and 10/100 Ethernet NIC drivers per fcp-0101..
May 17 2019, 3:19 PM
brooks committed rS347907: FCP-101: remove obsolete 10 and 10/100 Ethernet drivers..
FCP-101: remove obsolete 10 and 10/100 Ethernet drivers.
May 17 2019, 3:19 PM
brooks added a comment to D20230: Remove obsolete 10 and 10/100 Ethernet NIC drivers per fcp-0101..

The pull request has been updated to not remove ae(4).

May 17 2019, 2:36 PM

May 16 2019

brooks committed rS347848: MFC r347365, r347703.
MFC r347365, r347703
May 16 2019, 6:00 PM
brooks committed rS347703: FCP-101: ae(4) is sufficently popular to be moved to the keep list..
FCP-101: ae(4) is sufficently popular to be moved to the keep list.
May 16 2019, 3:22 PM

May 15 2019

brooks committed rP501709: Use GCC 7 instead of GCC 5 when the base system doesn't have libc++..
Use GCC 7 instead of GCC 5 when the base system doesn't have libc++.
May 15 2019, 2:17 PM

May 10 2019

brooks added a comment to D20230: Remove obsolete 10 and 10/100 Ethernet NIC drivers per fcp-0101..
In D20230#435945, @jhb wrote:

Just don't forget 'Relnotes: yes' on each commit? (I assume you were planning to do that but didn't see it in my spot check of a GitHub commit log)

May 10 2019, 9:51 PM
brooks added a comment to D20230: Remove obsolete 10 and 10/100 Ethernet NIC drivers per fcp-0101..

universe kernel's build (except for a few with unrelated errors) and amd64, i386, and powerpc universe builds.

May 10 2019, 8:20 PM
brooks added reviewers for D20230: Remove obsolete 10 and 10/100 Ethernet NIC drivers per fcp-0101.: imp, jhb.
May 10 2019, 6:15 PM
brooks created D20230: Remove obsolete 10 and 10/100 Ethernet NIC drivers per fcp-0101..
May 10 2019, 6:13 PM

May 8 2019

brooks committed rS347365: Update dme(4) to reflect that it will not be removed due to FCP-101..
Update dme(4) to reflect that it will not be removed due to FCP-101.
May 8 2019, 7:06 PM

May 7 2019

brooks accepted D20189: [new port] devel/git-subrepo, a Git command for managing subrepositories..

LGTM

May 7 2019, 11:31 PM

May 1 2019

brooks added a comment to D7972: Linux ARM v2 3/9.

Since this is a new file, you might want to consider formatting it in the new, more readable style used in sys/kern/syscalls.master.

May 1 2019, 5:45 PM · Linux Emulation, ARM

Apr 30 2019

brooks committed rP500571: Remove LLVM 5.0 as it has no remaining dependencies and has expired..
Remove LLVM 5.0 as it has no remaining dependencies and has expired.
Apr 30 2019, 10:32 PM

Apr 26 2019

brooks committed rP500146: Switch to LLVM_DEFAULT for the LLVM dependency..
Switch to LLVM_DEFAULT for the LLVM dependency.
Apr 26 2019, 8:47 PM

Apr 17 2019

brooks committed rP499184: Fix the installation of llvm-lit's "cat" utility..
Fix the installation of llvm-lit's "cat" utility.
Apr 17 2019, 4:20 PM

Apr 16 2019

brooks added a comment to D19917: Implement linux_sendfile for the linuxulator.

This generally looks good to me.

Apr 16 2019, 7:25 PM

Apr 12 2019

brooks committed rP498732: Apply a manually updated version of FreeBSD HEAD r338297 as required to.
Apply a manually updated version of FreeBSD HEAD r338297 as required to
Apr 12 2019, 5:23 PM

Apr 3 2019

brooks committed rP497743: Fix broken plist..
Fix broken plist.
Apr 3 2019, 6:36 PM

Apr 1 2019

brooks accepted D19778: Reap idle src bits.
Apr 1 2019, 9:44 PM
brooks accepted D19778: Reap idle src bits.
Apr 1 2019, 9:33 PM
brooks accepted D19782: jhb@ will take over as mentor to anish@.
Apr 1 2019, 9:31 PM
brooks committed rP497499: Update to a new snapshot..
Update to a new snapshot.
Apr 1 2019, 6:00 PM
brooks committed rP497498: Remove LLVM 3.8.x..
Remove LLVM 3.8.x.
Apr 1 2019, 5:50 PM

Mar 27 2019

brooks added a comment to D19722: lang/ghc: remove ghc-8.4.x support on arm.

We can certainly delay removal if this is a significant loss. I didn't see this one since it's hard to see dependencies on platforms I don't run.

Mar 27 2019, 7:26 PM

Mar 25 2019

brooks committed rP496861: Deprecate and slap an expiriation date on llvm50..
Deprecate and slap an expiriation date on llvm50.
Mar 25 2019, 11:59 PM
brooks committed rP496860: Remove dependency on llvm50..
Remove dependency on llvm50.
Mar 25 2019, 11:45 PM
brooks committed rP496859: Remove dependency on llvm50.
Remove dependency on llvm50
Mar 25 2019, 11:43 PM

Mar 20 2019

brooks committed rP496395: Set an expiration date somewhat after the 5th anniversary of this port's.
Set an expiration date somewhat after the 5th anniversary of this port's
Mar 20 2019, 11:19 PM
brooks committed rP496394: Set an expiration date of next Saturday..
Set an expiration date of next Saturday.
Mar 20 2019, 11:09 PM
brooks committed rP496392: Correct distinfo after a last minute update of the llvm version..
Correct distinfo after a last minute update of the llvm version.
Mar 20 2019, 10:52 PM
brooks committed rP496388: Switch to LLVM_DEFAULT from an hardcoded llvm40..
Switch to LLVM_DEFAULT from an hardcoded llvm40.
Mar 20 2019, 9:40 PM
brooks committed rP496386: Update to 8.0.0 Release..
Update to 8.0.0 Release.
Mar 20 2019, 8:19 PM

Mar 19 2019

brooks committed rP496274: Upgrade to a new LLVM 9-pre based snapshot..
Upgrade to a new LLVM 9-pre based snapshot.
Mar 19 2019, 4:53 PM

Mar 14 2019

brooks accepted D19584: mips: remove dead comment and definitions..

I confirm that I see no uses.

Mar 14 2019, 6:15 PM
brooks committed rS345136: Style(9): add a missing space between argument declerations..
Style(9): add a missing space between argument declerations.
Mar 14 2019, 3:56 PM
brooks committed rS345135: Remove an unused struct proc *p1 in cpu_fork()..
Remove an unused struct proc *p1 in cpu_fork().
Mar 14 2019, 3:55 PM
brooks closed D16226: [MIPS]: reap unused struct proc *p1;.
Mar 14 2019, 3:55 PM
brooks accepted D16226: [MIPS]: reap unused struct proc *p1;.

LGTM. Sorry I missed this before, I'll commit in a moment with a comment tweak.

Mar 14 2019, 3:53 PM
brooks committed rP495721: Use LLVM_DEFAULT rather than hardcoding a version..
Use LLVM_DEFAULT rather than hardcoding a version.
Mar 14 2019, 3:35 PM

Mar 13 2019

brooks committed rP495613: Update to 8.0.0rc5..
Update to 8.0.0rc5.
Mar 13 2019, 4:35 PM

Mar 12 2019

brooks closed D19515: Direct readers to the license policy. Encourage questions..
Mar 12 2019, 5:42 PM
brooks committed rD52861: Refer to the license policy document as the source of truth..
Refer to the license policy document as the source of truth.
Mar 12 2019, 5:42 PM
brooks committed rP495460: Upgrade to the latest version on github..
Upgrade to the latest version on github.
Mar 12 2019, 3:34 PM

Mar 11 2019

brooks accepted D19550: Kill tz_minuteswest and tz_dsttime..

Looks good to me.

Mar 11 2019, 10:12 PM