Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (363 w, 13 h)

Recent Activity

Yesterday

brooks accepted D30772: kdump: use VIS_NOLOCALE when printing output.

This makes sense to me. You probably might as well fix the bogus extra space in front of vis while you're here.

Tue, Jun 15, 6:24 PM

Wed, Jun 9

brooks added inline comments to D30442: mprotect.2: Update text for largepages.
Wed, Jun 9, 8:52 PM
brooks retitled D14338: Register a syscall for pmc(3). from Register a syscall for pmc(4). to Register a syscall for pmc(3)..
Wed, Jun 9, 4:13 PM

Tue, Jun 8

brooks updated the diff for D14338: Register a syscall for pmc(3)..
  • rebase, regen generated files
Tue, Jun 8, 10:05 PM
brooks updated the diff for D30442: mprotect.2: Update text for largepages.

s/allocation/page/

Tue, Jun 8, 9:27 PM
brooks added a comment to D30442: mprotect.2: Update text for largepages.

I've to update the description to match what I believe is currently implemented. I've not mentioned largepages by name because I can find no documentation of them to reference. I've also attempted to improve the description of prot (that will be a separate commit).

Tue, Jun 8, 7:44 PM
brooks retitled D30442: mprotect.2: Update text for largepages from mprotect.2: Remove legacy BSD text to mprotect.2: Update text for largepages.
Tue, Jun 8, 7:39 PM
brooks updated the diff for D30442: mprotect.2: Update text for largepages.
  • mprotect.2: Update text for largepages
  • mprotect.2: Improve the description of prot
Tue, Jun 8, 7:38 PM

Tue, May 25

brooks accepted D30452: elfctl: avoid touching file if no change.

I briefly considered the possibility that there might want to be some sort of force flag, but I don't see a lot of value.

Tue, May 25, 8:41 PM

Mon, May 24

brooks added a comment to D30442: mprotect.2: Update text for largepages.
In D30442#683682, @kib wrote:

It was completely wrong before adding largepage support, but now it is closer to being correct than not. I propose to remove the second sentence from your diff, and change 'an entire region' to 'an entire large page'.

Mon, May 24, 10:01 PM
brooks added a comment to D30399: Fix LLD_LINK descriptions.

Thanks for the better wording. As you noticed, LLD_LINK doesn't do anything in llvm10 and later (the link is made unconditionally). I think I'd like to go ahead and commit the change to llvm90 immediately because I don't think it will trigger rebuilds, but check that there aren't other changes I should be making to 11-12 before deleting the options since that definitely triggers a rebuild in poudriere.

Mon, May 24, 9:44 PM
brooks requested review of D30442: mprotect.2: Update text for largepages.
Mon, May 24, 8:47 PM

Thu, May 20

brooks committed R11:72f87a53eddf: devel/llvm*: Fix BE_NATIVE on aarch64 (authored by brooks).
devel/llvm*: Fix BE_NATIVE on aarch64
Thu, May 20, 11:34 PM
brooks committed R11:a459b93bae5a: devel/llvm-devel: new snapshot 2021-05-18 (authored by brooks).
devel/llvm-devel: new snapshot 2021-05-18
Thu, May 20, 9:47 PM

May 13 2021

brooks added a comment to D30254: style: tweak tab after #define advice.

Can we please encourage per-file or per-group consistency? Patches are annoying to read when the a group of #defines randomly switches between styles.

May 13 2021, 10:04 PM
brooks added inline comments to D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..
May 13 2021, 5:55 PM
brooks accepted D30235: makesyscalls.lua: improve generated file style(9) compliance.
May 13 2021, 5:43 PM

May 10 2021

brooks accepted D30197: Remove a write-only variable..
May 10 2021, 8:41 PM

May 3 2021

brooks committed R11:6354328d5f77: devel/llvm12: address build issues in some configs (authored by brooks).
devel/llvm12: address build issues in some configs
May 3 2021, 5:39 PM

Apr 23 2021

brooks committed R9:b5e5960090da: Bump PGP key expiration (authored by brooks).
Bump PGP key expiration
Apr 23 2021, 10:54 PM

Apr 21 2021

brooks accepted D29902: headers: Implement _ISOC11_SOURCES macro when __POSIX_C_SOURCE defined.

"definfed" in the title line.

Apr 21 2021, 11:41 PM
brooks committed R11:95d9554b594c: devel/llvm12: Update to 12.0.0 release (authored by brooks).
devel/llvm12: Update to 12.0.0 release
Apr 21 2021, 10:04 PM
brooks added inline comments to D29895: Reduce code duplication in machine/_types.h.
Apr 21 2021, 9:33 PM
brooks accepted D29894: Group all compat shim structures together to consolidate #ifdef's..
Apr 21 2021, 8:59 PM
brooks accepted D29893: Use thunks for compat ioctls using struct ifgroupreq..
Apr 21 2021, 8:58 PM
brooks accepted D29892: Add freebsd32 compat shims for SIOC[GS]DRVSPEC..
Apr 21 2021, 8:42 PM
brooks accepted D29891: Rework compat shims in ifioctl()..
Apr 21 2021, 8:39 PM
brooks added a comment to D29236: Don't override CC with cmake and CROSS_TOOLCHAIN.

We could also do something gross like adding an && !defined(DONT_OVERRIDE_TOOLCHAIN_FOR_CROSS_TOOLCHAIN). At the moment, I just want something that works since the current code makes it impossible to cross build cmake ports.

Apr 21 2021, 6:23 PM
brooks added a comment to D29236: Don't override CC with cmake and CROSS_TOOLCHAIN.
In D29236#669332, @bapt wrote:

Doing this we might miss cases where the cmake uses is inherited from a USES (which does not exist in the ports tree - yet ? but is a valid usage)

Apr 21 2021, 6:11 PM

Apr 13 2021

brooks abandoned D29237: Add SUB_FILES_EARLY.

Superseded by D29742

Apr 13 2021, 4:20 PM
brooks added a comment to D29742: Run apply-slist earlier..

I'd assumed slist-apply was late because if it's just doing things like generating a file to install, it's annoying to have to re-run the whole build to test it (consider llvm-wrapper.sh in all the llvm ports). If moving it early is fine then I'm happy with that.

Apr 13 2021, 4:15 PM

Apr 12 2021

brooks updated the diff for D14338: Register a syscall for pmc(3)..
  • pmc_op: Add freebsd32 stub
Apr 12 2021, 11:40 PM
brooks updated the diff for D14338: Register a syscall for pmc(3)..
  • Rename syscall to pmc_op
  • libpmc: Call pmc_op directly
Apr 12 2021, 11:23 PM
brooks added a comment to D29236: Don't override CC with cmake and CROSS_TOOLCHAIN.

ping

Apr 12 2021, 10:49 PM
brooks updated the diff for D29237: Add SUB_FILES_EARLY.
  • Move apply-slist-early slightly later...
Apr 12 2021, 10:45 PM
brooks committed R11:5253f1d0832b: devel/llvm-devel: Disable FLANG on i386 (authored by brooks).
devel/llvm-devel: Disable FLANG on i386
Apr 12 2021, 10:42 PM
brooks committed R11:f8a01bcaaf9d: devel/llvm-devel: add a lite flavor (authored by brooks).
devel/llvm-devel: add a lite flavor
Apr 12 2021, 10:42 PM

Apr 9 2021

brooks updated the diff for D14338: Register a syscall for pmc(3)..
  • Rebase
Apr 9 2021, 9:17 PM

Apr 8 2021

brooks added a comment to D29237: Add SUB_FILES_EARLY.

I've moved apply-slist-early to configure and put it before create-binary-wrappers on the grounds that you might well want to perform substitutions in a wrapper script.

Apr 8 2021, 3:52 PM
brooks updated the diff for D29237: Add SUB_FILES_EARLY.
  • Move apply-slist-early to configure stage
Apr 8 2021, 3:51 PM

Apr 6 2021

brooks added inline comments to D29543: license: Create a license guideline document.
Apr 6 2021, 5:17 PM

Apr 5 2021

brooks added inline comments to D29543: license: Create a license guideline document.
Apr 5 2021, 4:12 PM

Apr 2 2021

brooks added a comment to D29237: Add SUB_FILES_EARLY.
In D29237#662456, @mat wrote:

Mmmm, if the idea is to have the files available for configure and build, please hook them up when they are needed, in the configure stage, between configure-message and pre-configure runs, not in the extract phase.

Apr 2 2021, 9:08 PM

Mar 29 2021

brooks added a comment to D29237: Add SUB_FILES_EARLY.

With this change, the following (modulo cut and paste damage) lets me cross build llvm-devel:

@@ -60,6 +63,20 @@
                -DPYTHON_INCLUDE_DIR=${PYTHON_INCLUDEDIR} \
                -DPYTHON_LIBRARY=${LOCALBASE}/lib/lib${PYTHON_VERSION}m.so
Mar 29 2021, 9:52 PM

Mar 23 2021

brooks accepted D29384: makefs: Ignore the "tags" keyword.

Seems sensible to me. I'm not entirely sure we shouldn't just silently ignore unknown tags unless some sort of --picky option is specified.

Mar 23 2021, 5:53 PM

Mar 12 2021

brooks committed rP568206: llvm-devel: make portlint slightly happier.
llvm-devel: make portlint slightly happier
Mar 12 2021, 10:28 PM
brooks committed rP568205: llvm-devel: Handle unsupported options centrally.
llvm-devel: Handle unsupported options centrally
Mar 12 2021, 10:05 PM
brooks added a comment to D29237: Add SUB_FILES_EARLY.

I'm using this to populate a CMake toolchain file for cross building. It's tidier than doing a manual SED doing the same thing.

Mar 12 2021, 7:50 PM
brooks requested review of D29237: Add SUB_FILES_EARLY.
Mar 12 2021, 7:49 PM
brooks added a comment to D29236: Don't override CC with cmake and CROSS_TOOLCHAIN.

With this I've been able to construct a set of changes to llvm-devel to allow it to cross build a dependency-free version of clang which is most of the way to having base/llvm* ports suitable for use with a root fs containing no compiler.

Mar 12 2021, 7:46 PM
brooks requested review of D29236: Don't override CC with cmake and CROSS_TOOLCHAIN.
Mar 12 2021, 7:43 PM

Mar 8 2021

brooks committed rP567872: Update to a new snapshot (now on the 13.0.0 line)..
Update to a new snapshot (now on the 13.0.0 line).
Mar 8 2021, 9:01 PM

Mar 5 2021

brooks committed rP567355: Welcome LLVM 12 (12.0.0rc2) to the tree.
Welcome LLVM 12 (12.0.0rc2) to the tree
Mar 5 2021, 1:47 AM

Mar 2 2021

brooks added a comment to D29007: address a performance problem w/ partial sscanf on long strings....

Small nit in commit message: Missing ( in the second paragraph.

Mar 2 2021, 12:19 AM

Feb 18 2021

brooks updated subscribers of D28765: RFC: Use file-prefix-map to lie about kernel build paths.
Feb 18 2021, 4:59 PM
brooks updated subscribers of D28764: RFC: Use file-prefix-map to lie about build paths.
Feb 18 2021, 4:58 PM
brooks added inline comments to D28764: RFC: Use file-prefix-map to lie about build paths.
Feb 18 2021, 4:58 PM
brooks added a comment to D28764: RFC: Use file-prefix-map to lie about build paths.

I think this is like to need a ports exp-run.

Feb 18 2021, 12:47 AM
brooks added a comment to D28632: Add fileprefixmap compiler feature.

Thanks for the gitlab reference, being able to cherry-pick the commit and preserve author data was helpful.

Feb 18 2021, 12:12 AM

Feb 17 2021

brooks closed D28632: Add fileprefixmap compiler feature.
Feb 17 2021, 10:28 PM
brooks committed R10:d616ae46b484: Add fileprefixmap compiler feature (authored by dan.mcgregor_usask.ca).
Add fileprefixmap compiler feature
Feb 17 2021, 10:28 PM

Feb 15 2021

brooks accepted D28632: Add fileprefixmap compiler feature.

This seems reasonable. Adding Alex in case he's interested (we might want to use this in cheribuild to match src paths match smbfs mounts).

Feb 15 2021, 6:51 PM

Feb 10 2021

brooks accepted D28573: fmtree: prepare for removal.

It seems worth adding a reference to mtree.

Feb 10 2021, 9:59 PM

Feb 2 2021

brooks accepted D28332: Expose clang's alignment builtins and use them for roundup2/rounddown2.
Feb 2 2021, 7:16 PM
brooks accepted D28414: atf: Fix ATF_BUILD_* values when not using the bootstrap compiler.

IMO these tests are extremely dubious and fragile. Embedding cc/c++/cpp seems most likely to work at all. I think I've proposed something like this in the past.

Feb 2 2021, 6:35 PM

Jan 26 2021

brooks committed R10:d89c1c461ce3: Reserve gaps in syscall numbers for local use (authored by brooks).
Reserve gaps in syscall numbers for local use
Jan 26 2021, 6:29 PM
brooks committed R10:119fa6ee8a80: syscalls.master: Add a new syscall type: RESERVED (authored by brooks).
syscalls.master: Add a new syscall type: RESERVED
Jan 26 2021, 6:29 PM
brooks closed D27988: Reserve gaps in syscall numbers for local use.
Jan 26 2021, 6:29 PM
brooks committed R10:65a524b499ae: Remove documentation of unimplemented syscalls (authored by brooks).
Remove documentation of unimplemented syscalls
Jan 26 2021, 6:29 PM
brooks added a comment to D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..

The syscalls.master bits look fine.

Jan 26 2021, 5:51 PM

Jan 25 2021

brooks committed R10:7baf7a453859: ndis: Per user request, delay removal to 14 (authored by brooks).
ndis: Per user request, delay removal to 14
Jan 25 2021, 10:18 PM
brooks committed R10:2a0be7b0331c: VFS_QUOTACTL: Remove needless casts of arg (authored by brooks).
VFS_QUOTACTL: Remove needless casts of arg
Jan 25 2021, 10:17 PM
brooks accepted D28315: bsd.compiler.mk: Detect distribution-provided GCC when executed as cc.
Jan 25 2021, 10:08 PM
brooks closed D27609: ndis(4): remove as previous announced.

Committed in R10:bfc99943b04b46a6c1c885ce7bcc6f235b7422aa

Jan 25 2021, 10:03 PM
brooks committed R10:7a1591c1b625: Rename kern_mmap_req to kern_mmap (authored by brooks).
Rename kern_mmap_req to kern_mmap
Jan 25 2021, 9:59 PM
brooks closed D28292: Replace all uses of kern_mmap with kern_mmap_req.
Jan 25 2021, 9:59 PM
brooks committed R10:bfc99943b04b: ndis(4): remove as previous announced (authored by brooks).
ndis(4): remove as previous announced
Jan 25 2021, 9:46 PM
brooks accepted D28311: vm_map_protect.9: update after code changes.
Jan 25 2021, 9:29 PM
brooks updated the diff for D28292: Replace all uses of kern_mmap with kern_mmap_req.
  • Rebase
  • Use a slightly more compact style
Jan 25 2021, 9:24 PM
brooks updated the diff for D27988: Reserve gaps in syscall numbers for local use.
  • Rebase
  • s/rsrvd/reserved in makesyscalls.lua
Jan 25 2021, 8:49 PM
brooks added inline comments to D27988: Reserve gaps in syscall numbers for local use.
Jan 25 2021, 8:46 PM
brooks added a reviewer for D27988: Reserve gaps in syscall numbers for local use: kevans.
Jan 25 2021, 7:49 PM
brooks added a comment to D27988: Reserve gaps in syscall numbers for local use.

I've updated the diff (it's three commits). I ended up using RESERVED since the only thing a long name causes issues with is alignment of the comment at the top of syscalls.master.

Jan 25 2021, 7:49 PM
brooks updated the diff for D27988: Reserve gaps in syscall numbers for local use.
  • Update comment saying to add syscalls at the bottom
Jan 25 2021, 7:45 PM
brooks updated the diff for D27988: Reserve gaps in syscall numbers for local use.
  • syscalls.master: Add a new syscall type: RESERVED
  • Reserve gaps in syscall numbers for local use
Jan 25 2021, 7:44 PM
brooks added a comment to D27988: Reserve gaps in syscall numbers for local use.
In D27988#633155, @kib wrote:

Again, why not push cleanup separately.

Jan 25 2021, 6:54 PM

Jan 23 2021

brooks added inline comments to D27988: Reserve gaps in syscall numbers for local use.
Jan 23 2021, 12:53 AM
brooks updated the diff for D27988: Reserve gaps in syscall numbers for local use.
  • Rebase and split into two commits
    • Remove documentation of unimplemented syscalls
    • Reserve gaps in syscall numbers for local use
Jan 23 2021, 12:53 AM
brooks added a comment to D28292: Replace all uses of kern_mmap with kern_mmap_req.

I've done this cleanup in CheriBSD on the path to some local cleanups.

Jan 23 2021, 12:33 AM
brooks updated the diff for D28292: Replace all uses of kern_mmap with kern_mmap_req.
  • Whitespace fix.
Jan 23 2021, 12:33 AM
brooks requested review of D28292: Replace all uses of kern_mmap with kern_mmap_req.
Jan 23 2021, 12:25 AM

Jan 21 2021

brooks accepted D28263: build: remove LIBPTHREAD/LIBTHR build options.
Jan 21 2021, 5:15 PM
brooks accepted D28120: compiler.mk: Update clang dependency from v6 to v10, clean up duplication.
Jan 21 2021, 5:11 PM

Jan 20 2021

brooks added inline comments to D28120: compiler.mk: Update clang dependency from v6 to v10, clean up duplication.
Jan 20 2021, 7:28 PM
brooks accepted D28253: Remove all current uses of build-tools during buildworld.

I really like this. It's cleaner and eliminates a tree walk.

Jan 20 2021, 7:24 PM

Jan 15 2021

brooks added inline comments to D28120: compiler.mk: Update clang dependency from v6 to v10, clean up duplication.
Jan 15 2021, 6:03 PM

Jan 14 2021

brooks added inline comments to D28120: compiler.mk: Update clang dependency from v6 to v10, clean up duplication.
Jan 14 2021, 12:28 AM

Jan 13 2021

brooks accepted D28122: [mips] revert r366664 - flip mips back from -O2 to -O.
Jan 13 2021, 9:05 PM

Jan 12 2021

brooks added a comment to D28122: [mips] revert r366664 - flip mips back from -O2 to -O.

Please only do this for GCC if only GCC is broken.

Jan 12 2021, 9:22 PM
brooks accepted D28117: vm_map_protect: allow to set prot and max_prot in one go..
Jan 12 2021, 9:01 PM