brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (176 w, 5 d)

Recent Activity

Fri, Nov 17

brooks added a comment to D13134: [mips32/tls] change TCB size from 8 to 16 to be aligned with r324938 & r325364.

You shouldn't need to change the size or roundup2 the syscall argument. With the change in rS325364 the TLS allocation should be properly aligned so long as the PT_TLS segment has the right alignment. You could change the definition of TLS_TCB_ALIGN to be 16 for mips like it is on amd64, but we should be setting the alignment of the TLS segment correctly and fix it if we aren't.

Fri, Nov 17, 10:17 PM
brooks added a comment to D13134: [mips32/tls] change TCB size from 8 to 16 to be aligned with r324938 & r325364.

Is this needed at all after rS325364? We should now be respecting the alignment of the PT_TLS section. If the PT_TLS section isn't correctly aligned then fixing that is the right answer rather than trashing the ABI.

Fri, Nov 17, 4:54 PM
brooks added a comment to D13134: [mips32/tls] change TCB size from 8 to 16 to be aligned with r324938 & r325364.

Why not just nuke TLS_TCB_SIZE32?

Fri, Nov 17, 4:34 PM

Thu, Nov 16

brooks committed rP454342: Update to a new snapshot and apply the patch for posix_fallocate().
Update to a new snapshot and apply the patch for posix_fallocate()
Thu, Nov 16, 9:44 PM

Mon, Nov 13

brooks committed rP454097: Update to a new snapshot..
Update to a new snapshot.
Mon, Nov 13, 2:48 AM
brooks committed rP454093: Merge from src and upstream LLVM:.
Merge from src and upstream LLVM:
Mon, Nov 13, 1:45 AM

Sun, Nov 12

brooks committed rP454025: Merge from src:.
Merge from src:
Sun, Nov 12, 9:09 AM
brooks accepted D13015: Axe xlint..

xlint has been useless for years and has some of the worst code quality in the base system. Its removal is long overdue.

Sun, Nov 12, 7:12 AM
brooks accepted D12962: Convert BERI to use ofw_parse_bootargs().

LGTM

Sun, Nov 12, 3:55 AM

Thu, Nov 2

brooks added inline comments to D12907: Add alignment support to __libc_allocate_tls()..
Thu, Nov 2, 12:31 PM
brooks accepted D11925: Export std::get_new_handler() from libcxxrt.so.

LGTM

Thu, Nov 2, 12:06 PM
brooks accepted D12907: Add alignment support to __libc_allocate_tls()..

Looks good to me. We should probably make similar changes to Variant II.

Thu, Nov 2, 8:18 AM

Tue, Oct 31

brooks committed rP453221: Update to a new snapshot correcting 128-bit support..
Update to a new snapshot correcting 128-bit support.
Tue, Oct 31, 10:05 AM

Mon, Oct 30

brooks committed rP453171: Update to a new snapshot. This version supports new and improved.
Update to a new snapshot. This version supports new and improved
Mon, Oct 30, 12:42 PM
brooks committed rP453163: Update to an October 23rd snapshot..
Update to an October 23rd snapshot.
Mon, Oct 30, 10:20 AM

Oct 18 2017

brooks updated the diff for D12677: Add sortbench..
  • Add Copyright blocks (manual merge)
Oct 18 2017, 6:04 PM
brooks updated the diff for D12677: Add sortbench..

Revert botched merge

Oct 18 2017, 6:00 PM
brooks updated the diff for D12677: Add sortbench..
  • Add licenses from Miles.
Oct 18 2017, 5:58 PM
brooks committed rS324710: Remove mbpool(9) now that it has no consumers..
Remove mbpool(9) now that it has no consumers.
Oct 18 2017, 12:18 AM
brooks closed D10513: Remove mbpool(9) now that it has no consumers..
Oct 18 2017, 12:18 AM

Oct 15 2017

brooks committed rS324643: MFC r321256:.
MFC r321256:
Oct 15 2017, 10:45 PM
brooks committed rS324642: MFC r321256:.
MFC r321256:
Oct 15 2017, 10:44 PM
brooks committed rS324641: MFC r320999:.
MFC r320999:
Oct 15 2017, 10:39 PM
brooks committed rS324640: MFC r320999:.
MFC r320999:
Oct 15 2017, 10:34 PM
brooks committed rP452160: Fix hardcoded version in clang-format. [0].
Fix hardcoded version in clang-format. [0]
Oct 15 2017, 6:26 PM

Oct 14 2017

brooks committed rP452094: Put openmp in the right place so it is built and installed..
Put openmp in the right place so it is built and installed.
Oct 14 2017, 11:38 PM
brooks added a comment to D11646: Mergesort Benchmark.

I've posted an updated diff in D12677

Oct 14 2017, 9:55 PM
brooks added a reviewer for D12677: Add sortbench.: milesfertel_college.harvard.edu.

Miles, I've extracted this from your GitHub repo and made a few changes to the Makefile and would like to commit this soon. One thing that is missing is appropriate BSD copyright blocks on bench.py and sort_bench.c. I can't commit without them. Please provide me with your preferred Copyright line and acknowledge that these are to be available under the standard FreeBSD license (https://www.freebsd.org/copyright/freebsd-license.html).

Oct 14 2017, 9:54 PM
brooks created D12677: Add sortbench..
Oct 14 2017, 9:49 PM
brooks committed rP452079: Fix build without EXTRAS (clangd is part of EXTRAS, not CLANG). [0].
Fix build without EXTRAS (clangd is part of EXTRAS, not CLANG). [0]
Oct 14 2017, 6:55 PM
brooks added a comment to D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.

Thank you for doing this work! Sorry it took me so long to commit it.

Oct 14 2017, 6:42 PM
brooks committed rS324619: Switch procstat from subcommand flags to verbs.
Switch procstat from subcommand flags to verbs
Oct 14 2017, 6:38 PM
brooks closed D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.
Oct 14 2017, 6:38 PM
brooks accepted D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.
Oct 14 2017, 6:35 PM
brooks updated the diff for D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.

Merge to FreeBSD head prior to commit to SVN.

Oct 14 2017, 6:32 PM
brooks committed rS324617: MFC r324243:.
MFC r324243:
Oct 14 2017, 4:49 PM
brooks committed rS324616: MFC r324243:.
MFC r324243:
Oct 14 2017, 4:23 PM
brooks committed rP452037: Remove forced clang34 dependency. The port builds on 10.3 (which has.
Remove forced clang34 dependency. The port builds on 10.3 (which has
Oct 14 2017, 12:11 AM

Oct 13 2017

brooks committed rP451941: Update to a new snapshot..
Update to a new snapshot.
Oct 13 2017, 1:25 AM

Oct 12 2017

brooks committed rP451923: - add support for ARMv7.
- add support for ARMv7
Oct 12 2017, 6:17 PM
brooks committed rP451914: Update a new shapshot..
Update a new shapshot.
Oct 12 2017, 5:14 PM

Oct 11 2017

brooks committed rP451764: - add support for ARMv7.
- add support for ARMv7
Oct 11 2017, 5:15 PM

Oct 6 2017

brooks added a reviewer for D12607: Remove redundant pam_rhosts: des.

Dag-Erling should probably weigh in as this is a pam change.

Oct 6 2017, 5:59 PM
brooks requested changes to D12607: Remove redundant pam_rhosts.
Oct 6 2017, 5:58 PM
brooks added a comment to D12603: Add a mechanism to allow having binary found first in the path.

I like this a lot. It should help users of llvm-config since they can link llvm-config## in as llvm-config. I suspect this will spawn many USES flags.

Oct 6 2017, 5:43 PM

Oct 5 2017

brooks accepted D12573: Remove rcmds from the base system..

I'm confused as to how the rcp directory doesn't end up /usr/test/bin/, but can confirm that it doesn't in a VM with the test suite installed.

Oct 5 2017, 11:45 PM

Oct 4 2017

brooks requested changes to D12573: Remove rcmds from the base system..

Small missing bit: etc/mtree/BSD.tests.dist contains a rcp directory. There are presumably missing ObsoleteFiles.inc entries for tests as well. Otherwise looks good to me.

Oct 4 2017, 3:21 PM

Oct 3 2017

brooks closed D12547: Remove an unneeded and incorrect memset()..
Oct 3 2017, 10:57 PM
brooks committed rS324243: Remove an unneeded and incorrect memset()..
Remove an unneeded and incorrect memset().
Oct 3 2017, 10:57 PM

Sep 29 2017

brooks added a reviewer for D12547: Remove an unneeded and incorrect memset().: andrew.
Sep 29 2017, 9:23 PM
brooks added reviewers for D12547: Remove an unneeded and incorrect memset().: secteam, kib, dfr, jhb.
Sep 29 2017, 9:00 PM
brooks created D12547: Remove an unneeded and incorrect memset()..
Sep 29 2017, 8:59 PM

Sep 22 2017

brooks committed rP450418: Add xtoolchain port for llvm50..
Add xtoolchain port for llvm50.
Sep 22 2017, 10:03 PM

Sep 21 2017

brooks committed rP450313: Remove bogus plist entry..
Remove bogus plist entry.
Sep 21 2017, 11:46 PM

Sep 20 2017

brooks committed rP450206: Spell PORTREVISION correctly..
Spell PORTREVISION correctly.
Sep 20 2017, 4:06 PM
brooks committed rP450183: Don't install a wrapper for the not installed pp-trace program..
Don't install a wrapper for the not installed pp-trace program.
Sep 20 2017, 1:34 AM
brooks committed rP450182: Update to a new snapshot..
Update to a new snapshot.
Sep 20 2017, 1:09 AM

Sep 19 2017

brooks committed rP450176: Disable LLDB builds on 10.x as they don't link..
Disable LLDB builds on 10.x as they don't link.
Sep 19 2017, 11:44 PM

Sep 18 2017

brooks committed rP450073: Fix builds without COMPILER_RT..
Fix builds without COMPILER_RT.
Sep 18 2017, 7:24 PM

Sep 15 2017

brooks committed rP449939: Upgrade to a new snapshot. Now named 6.0..
Upgrade to a new snapshot. Now named 6.0.
Sep 15 2017, 11:22 PM

Sep 14 2017

brooks committed rP449851: Add a port of LLVM 5.0.0 release..
Add a port of LLVM 5.0.0 release.
Sep 14 2017, 7:30 PM

Sep 11 2017

brooks added a comment to D12301: Enhance mdmfs(8) to work with tmpfs(5).

This seems like a clean solution. The only downside I see is that you'd always need mdmfs(8) around.

Sep 11 2017, 4:22 PM

Aug 28 2017

brooks accepted D12036: Add basic tests generated via automation tool [1].

These look good to me.

Aug 28 2017, 11:45 PM

Aug 24 2017

brooks added a comment to D11646: Mergesort Benchmark.

I'd suggest adding a README file describing what the tests do and what the script's expected outputs are.

Aug 24 2017, 6:10 PM
brooks added inline comments to D11646: Mergesort Benchmark.
Aug 24 2017, 6:09 PM
brooks added inline comments to D11646: Mergesort Benchmark.
Aug 24 2017, 5:49 PM

Aug 4 2017

brooks added a comment to D11621: Mergesort Tests.

@ngie I think I had a misunderstanding with what these diff's should represent. I had been updating the page with diff's against the previous commits I had posted, for review purposes. Is the standard protocol for this page to host a diff against freebsd head such that it could be directly applied?

Aug 4 2017, 12:50 PM

Jul 28 2017

brooks committed rP446856: Update to a July 20th snapshot including 128-bit correctness fixes and.
Update to a July 20th snapshot including 128-bit correctness fixes and
Jul 28 2017, 10:00 PM
brooks accepted D11465: Upgrade GDB to 8.0..

LGTM

Jul 28 2017, 6:53 PM
brooks added a comment to D11646: Mergesort Benchmark.

If you can create a Makefile for this I'll look to get it committed soon (I'll be heading to the UK next Sunday, but will be doing FreeBSD things during the week so helpful I'll be able to get this committed.)

Jul 28 2017, 5:51 PM

Jul 24 2017

brooks added a comment to D11598: Wikisort.

A general question. How much do these files differ from the upstream version? Did you need to make any structural changes? I both ask to help be review this work and to figure out how we should integrate it into FreeBSD.

Jul 24 2017, 10:07 PM

Jul 21 2017

brooks added a comment to D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.

Arg. I was ready to go, but ran into conflicts with a change to usage() by @ngie. I'm not sure how best to blend the result. If we add that expansion to the subcommands the result will got from unwieldy to incomprehensible (not to mention not fitting on an 80 column display).

Jul 21 2017, 10:23 PM
brooks updated subscribers of D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.

Arg. I was ready to go, but ran into conflicts with a change to usage() by @ngie. I'm not sure how best to blend the result. If we add that expansion to the subcommands the result will got from unwieldy to incomprehensible (not to mention not fitting on an 80 column display).

Jul 21 2017, 10:21 PM
brooks accepted D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.

Great! This looks ready to go. I'll apply to a tree and commit shortly.

Jul 21 2017, 9:41 PM
brooks added a comment to D11646: Mergesort Benchmark.

This is looking good so far. You may want a macro to disable wikisort support so we can commit the benchmark on it's own.

Jul 21 2017, 9:15 PM
brooks added a comment to D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.
  • Add ``#!/bin/sh'' to the test script
Jul 21 2017, 8:56 PM

Jul 19 2017

brooks added a comment to D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.

Sorry for letting this sit so long. I'm finally getting back to this now that I can run FreeBSD 12 binaries on my build systems.

Jul 19 2017, 10:38 PM
brooks committed rS321256: Include ARCH_FLAGS in CFLAGS when building modules..
Include ARCH_FLAGS in CFLAGS when building modules.
Jul 19 2017, 10:06 PM
brooks closed D11633: Include ARCH_FLAGS in CFLAGS when building modules. by committing rS321256: Include ARCH_FLAGS in CFLAGS when building modules..
Jul 19 2017, 10:06 PM
brooks added a comment to D11633: Include ARCH_FLAGS in CFLAGS when building modules..

It looks like ARCH_FLAGS is used only on MIPS? I'm missing something here since it seems the default MIPS ARCH_FLAGS is set in sys/conf/Makefile.mips, which has CFLAGS+=${EXTRA_FLAGS} $(ARCH_FLAGS)

Jul 19 2017, 3:57 PM
brooks added inline comments to D11621: Mergesort Tests.
Jul 19 2017, 3:50 PM

Jul 18 2017

brooks added a comment to D11646: Mergesort Benchmark.

This benchmark is my initial design without full understanding of statistical validity. Is it at all still usable or it better to just pull out the relevant bits that run the sorting code into separate files and then attempt to bench them with ministat and multiple trials. Is shell a better medium for this?

Jul 18 2017, 10:54 PM
brooks created D11633: Include ARCH_FLAGS in CFLAGS when building modules..
Jul 18 2017, 12:39 AM

Jul 14 2017

brooks committed rS320999: Add 32-bit compat for kinfo_proc's ki_tdaddr..
Add 32-bit compat for kinfo_proc's ki_tdaddr.
Jul 14 2017, 9:13 PM
brooks closed D11521: Add 32-bit compat for kinfo_proc's ki_tdaddr. by committing rS320999: Add 32-bit compat for kinfo_proc's ki_tdaddr..
Jul 14 2017, 9:13 PM

Jul 7 2017

brooks created D11521: Add 32-bit compat for kinfo_proc's ki_tdaddr..
Jul 7 2017, 5:29 PM

Jun 23 2017

brooks committed rP444184: Upgrade to 4.0.1 release..
Upgrade to 4.0.1 release.
Jun 23 2017, 5:39 PM

Jun 20 2017

brooks updated the diff for D11231: Correct link metadata created when installing with -DNO_ROOT..
  • More cleanups of link permissions.
  • The geom classes build libraries, but install links to programs so
Jun 20 2017, 10:44 PM
brooks added a comment to D11231: Correct link metadata created when installing with -DNO_ROOT..

I'll submit a revised version shortly. I think I've got a test plan for release tar balls so I'll be trying that as well.

Jun 20 2017, 10:39 PM
brooks committed rS320169: MFC r318968:.
MFC r318968:
Jun 20 2017, 8:20 PM
brooks committed rP443917: Fix build with CLANG disabled..
Fix build with CLANG disabled.
Jun 20 2017, 12:11 AM

Jun 17 2017

brooks added a comment to D11231: Correct link metadata created when installing with -DNO_ROOT..
  • Add an INSTALL_MLINK to install manpage links.
Jun 17 2017, 12:11 AM
brooks updated the diff for D11231: Correct link metadata created when installing with -DNO_ROOT..
  • Add an INSTALL_MLINK to install manpage links.
Jun 17 2017, 12:10 AM

Jun 16 2017

brooks accepted D11025: Extend struct kevent fields and add absolute timers..
Jun 16 2017, 6:43 PM

Jun 15 2017

brooks created D11231: Correct link metadata created when installing with -DNO_ROOT..
Jun 15 2017, 11:02 PM
brooks accepted D11106: Use tmpfs in rc.initdiskless.

This seems like a fine modernization. Probably should not be MFC'd due to POLA with custom kernels.

Jun 15 2017, 5:44 PM

Jun 14 2017

brooks added a reviewer for D11154: Don't print all timezones during installworld: gjb.

I wonder if the -print was intentionally left for debugging purposes. I'm adding Glen who touched this line last.

Jun 14 2017, 6:09 PM

Jun 3 2017

brooks added inline comments to D11025: Extend struct kevent fields and add absolute timers..
Jun 3 2017, 12:06 AM

Jun 2 2017

brooks added inline comments to D11025: Extend struct kevent fields and add absolute timers..
Jun 2 2017, 11:35 PM
brooks added a comment to D11025: Extend struct kevent fields and add absolute timers..

I like the change of types for ident and data. intptr_t was defiantly the wrong type for data.

Jun 2 2017, 2:18 PM