Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (232 w, 3 d)

Recent Activity

Yesterday

brooks accepted D18543: Planned obsolete mips support removal.

Looks good to me. This is a well reasoned list to remove in order to make sure we can support the remaining platforms.

Fri, Dec 14, 6:42 AM

Thu, Dec 6

brooks updated subscribers of D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
Thu, Dec 6, 6:45 PM
brooks added 1 blocking reviewer(s) for D18443: Fix bugs in plugable CC algorithm and siftr sysctls.: transport.

@tj requested transport review before commit so make the them blocking so I don't forget.

Thu, Dec 6, 6:38 PM
brooks updated the summary of D15637: Regularize the declaration of the exit syscall..
Thu, Dec 6, 6:02 PM
brooks added inline comments to D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
Thu, Dec 6, 4:54 PM
brooks updated the diff for D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
  • Be more consistant in checking for valid values.
Thu, Dec 6, 4:54 PM
brooks updated the summary of D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
Thu, Dec 6, 4:20 PM
brooks added a reviewer for D18443: Fix bugs in plugable CC algorithm and siftr sysctls.: transport.
Thu, Dec 6, 4:18 PM
brooks updated the diff for D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
  • Remove comment resulting from mis-reading code.
Thu, Dec 6, 4:14 PM
brooks added inline comments to D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
Thu, Dec 6, 4:25 AM
brooks created D18444: const poison the `new` pointer of __sysctl..
Thu, Dec 6, 1:00 AM
brooks added a child revision for D18443: Fix bugs in plugable CC algorithm and siftr sysctls.: D18444: const poison the `new` pointer of __sysctl..
Thu, Dec 6, 1:00 AM
brooks added inline comments to D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
Thu, Dec 6, 12:38 AM
brooks created D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
Thu, Dec 6, 12:28 AM

Wed, Dec 5

brooks created D18442: Rework CASE_IOC_IFGROUPREQ() to require a case before it..
Wed, Dec 5, 8:42 PM
brooks committed rS341604: Further simplify arguments to init..
Further simplify arguments to init.
Wed, Dec 5, 7:18 PM
brooks closed D18441: Further simplify arguments to init..
Wed, Dec 5, 7:18 PM
brooks added inline comments to D15637: Regularize the declaration of the exit syscall..
Wed, Dec 5, 6:54 PM
brooks updated the diff for D15637: Regularize the declaration of the exit syscall..
  • Pretend we return an int (we don't return).
Wed, Dec 5, 6:54 PM
brooks created D18441: Further simplify arguments to init..
Wed, Dec 5, 6:40 PM
brooks retitled D15637: Regularize the declaration of the exit syscall. from Regularize the decleration of the exit syscall. to Regularize the declaration of the exit syscall..
Wed, Dec 5, 6:22 PM
brooks updated the diff for D14488: Remove gratuitous copyouts of unchanged struct mac..
  • Rebase
Wed, Dec 5, 6:01 PM
brooks updated the diff for D15637: Regularize the declaration of the exit syscall..
  • Rebase
Wed, Dec 5, 5:58 PM
brooks committed rS341600: Remove never enabled support for "fastboot"..
Remove never enabled support for "fastboot".
Wed, Dec 5, 5:37 PM
brooks closed D18431: Remove ifdef BOOTCDROM option to start init..
Wed, Dec 5, 5:30 PM
brooks committed rS341599: Remove ifdef BOOTCDROM option to start init..
Remove ifdef BOOTCDROM option to start init.
Wed, Dec 5, 5:30 PM
brooks updated the summary of D18431: Remove ifdef BOOTCDROM option to start init..
Wed, Dec 5, 5:05 PM
brooks committed rS341509: Remove MD __sys_* private symbols..
Remove MD __sys_* private symbols.
Wed, Dec 5, 12:46 AM
brooks closed D18425: Remove MD __sys_* private symbols..
Wed, Dec 5, 12:46 AM
brooks added a comment to D18425: Remove MD __sys_* private symbols..

make tinderbox passed for me.

Wed, Dec 5, 12:46 AM

Tue, Dec 4

brooks created D18431: Remove ifdef BOOTCDROM option to start init..
Tue, Dec 4, 10:37 PM
brooks committed rS341496: Regen after r341495: Remove NOARGS from oaccept..
Regen after r341495: Remove NOARGS from oaccept.
Tue, Dec 4, 9:57 PM
brooks committed rS341495: Remove NOARGS from oaccept..
Remove NOARGS from oaccept.
Tue, Dec 4, 9:57 PM
brooks committed rS341475: Regen after r341474: Normalize COMPAT_43 syscall declarations..
Regen after r341474: Normalize COMPAT_43 syscall declarations.
Tue, Dec 4, 4:52 PM
brooks committed rS341474: Normalize COMPAT_43 syscall declarations..
Normalize COMPAT_43 syscall declarations.
Tue, Dec 4, 4:51 PM
brooks closed D15816: Normalize COMPAT_43 syscall declarations..
Tue, Dec 4, 4:51 PM
brooks retitled D15816: Normalize COMPAT_43 syscall declarations. from Normalize COMPAT_43 syscall declerations. to Normalize COMPAT_43 syscall declarations..
Tue, Dec 4, 4:31 PM
brooks updated the diff for D15816: Normalize COMPAT_43 syscall declarations..
  • Rebase
  • GC duplicate, documentary definitions of _args structs.
Tue, Dec 4, 1:08 AM
brooks committed rS341450: Remove test for KSE (removed in 2008)..
Remove test for KSE (removed in 2008).
Tue, Dec 4, 12:23 AM
brooks committed rS341449: Remove a needlessly clever hack to start init with sys_exec()..
Remove a needlessly clever hack to start init with sys_exec().
Tue, Dec 4, 12:16 AM
brooks closed D15469: Remove a needlessly clever hack to start init with sys_exec()..
Tue, Dec 4, 12:16 AM
brooks updated the summary of D15469: Remove a needlessly clever hack to start init with sys_exec()..
Tue, Dec 4, 12:04 AM
brooks added a comment to D18425: Remove MD __sys_* private symbols..
In D18425#392258, @kib wrote:

I think that our private export is too large. Ideally it would be trimmed down to the symbols used by libthr.

Tue, Dec 4, 12:01 AM

Mon, Dec 3

brooks created D18425: Remove MD __sys_* private symbols..
Mon, Dec 3, 11:42 PM
brooks updated the diff for D15469: Remove a needlessly clever hack to start init with sys_exec()..
  • Remove redundent check (too much copy-and-paste).
  • Fix typo.
Mon, Dec 3, 11:22 PM
brooks added inline comments to D15469: Remove a needlessly clever hack to start init with sys_exec()..
Mon, Dec 3, 10:51 PM
brooks closed D18424: Remove declarations of syscalls not used in libthr..

Committed in rS341445.

Mon, Dec 3, 10:13 PM
brooks committed rS341445: Remove declarations of syscalls not used in libthr..
Remove declarations of syscalls not used in libthr.
Mon, Dec 3, 10:09 PM
brooks updated the diff for D15469: Remove a needlessly clever hack to start init with sys_exec()..
  • Rebase
  • Reduce diffs to master by retaining option handling order.
  • Free vmspace reference and clear TDP_EXECVMSPC after kern_execve().
Mon, Dec 3, 10:09 PM
brooks created D18424: Remove declarations of syscalls not used in libthr..
Mon, Dec 3, 9:25 PM

Sun, Dec 2

brooks added a comment to D15469: Remove a needlessly clever hack to start init with sys_exec()..
In D15469#391506, @kib wrote:
In D15469#391417, @kib wrote:

Not calling pre/post leave a stray reference on vmspace0. I do not claim that this is important, but it is certainly something to consider and at least comment about. Might be the stray TDP_EXECVMSPC on thread0 is worse.

Hmm, I'll look into this more closely on Monday. It's not particularly hard to call them.

No, I think that calling them on proc0 would have too much undesirable effects, we do not want to stop almost all kernel threads. You would need to open-code clearing of the flag and possible dereference of vmspace0.

Sun, Dec 2, 11:04 PM

Sat, Dec 1

brooks added a comment to D15469: Remove a needlessly clever hack to start init with sys_exec()..
In D15469#391417, @kib wrote:

Not calling pre/post leave a stray reference on vmspace0. I do not claim that this is important, but it is certainly something to consider and at least comment about. Might be the stray TDP_EXECVMSPC on thread0 is worse.

Sat, Dec 1, 12:52 AM
brooks added inline comments to D15469: Remove a needlessly clever hack to start init with sys_exec()..
Sat, Dec 1, 12:49 AM

Fri, Nov 30

brooks added reviewers for D15469: Remove a needlessly clever hack to start init with sys_exec().: kib, jhb.
Fri, Nov 30, 11:22 PM
brooks updated the summary of D15469: Remove a needlessly clever hack to start init with sys_exec()..
Fri, Nov 30, 11:22 PM
brooks added a comment to D16457: Subpackages. (deal with it.).

This looks like it will work well with the llvm ports. I'll mostly need to tweak my plist-generator a bit.

Fri, Nov 30, 5:40 PM

Thu, Nov 29

brooks updated the diff for D15469: Remove a needlessly clever hack to start init with sys_exec()..
  • Rebase
  • Catch up with changes in rS341263.
Thu, Nov 29, 11:38 PM
brooks updated the diff for D16730: Committers Guide: Add a section encouraging pre-commit review..
  • Rebase
  • Address some suggestions from jhb.
Thu, Nov 29, 11:24 PM
brooks committed rS341263: Add helper functions to copy strings into struct image_args..
Add helper functions to copy strings into struct image_args.
Thu, Nov 29, 9:02 PM
brooks closed D15468: Add helper functions to copy strings into struct image_args..
Thu, Nov 29, 9:02 PM
brooks added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Thu, Nov 29, 5:33 PM · manpages

Tue, Nov 27

brooks added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

A bunch of style things, but it generally looks fine. I've not looked deeply at the implementations of the kern_ functions.

Tue, Nov 27, 5:04 PM · manpages

Mon, Nov 26

brooks committed rS341000: Record r340273, r340275, r340295, r340303 as merged..
Record r340273, r340275, r340295, r340303 as merged.
Mon, Nov 26, 10:21 PM
brooks accepted D14244: crossbuild: Allow bootstrapping libopenbsd on Linux.

This seems fine, especially since libopenbsd is an INTERNALLIB.

Mon, Nov 26, 7:43 PM

Wed, Nov 21

brooks added inline comments to D15468: Add helper functions to copy strings into struct image_args..
Wed, Nov 21, 7:26 PM

Tue, Nov 20

brooks committed rS340657: MFS r340643:.
MFS r340643:
Tue, Nov 20, 12:43 AM

Mon, Nov 19

brooks committed rS340643: MFC r340489-r340490.
MFC r340489-r340490
Mon, Nov 19, 6:26 PM

Sat, Nov 17

brooks updated the diff for D15468: Add helper functions to copy strings into struct image_args..
  • Use a comment rather than reserved identifier.
Sat, Nov 17, 12:36 AM
brooks committed rS340490: Fix stray tab..
Fix stray tab.
Sat, Nov 17, 12:03 AM

Fri, Nov 16

brooks committed rS340489: Fix freebsd32 support for PCIOCGETCONF..
Fix freebsd32 support for PCIOCGETCONF.
Fri, Nov 16, 11:59 PM
brooks closed D18011: Add missing cases for PCIOCGETCONF32..
Fri, Nov 16, 11:59 PM
brooks created D18011: Add missing cases for PCIOCGETCONF32..
Fri, Nov 16, 11:27 PM
brooks added a reviewer for D2549: Add missing pieces for mips32 gcc-4.9 kernel build!: jhb.

Adding John who's been working on this with an actually modern gcc

Fri, Nov 16, 9:50 PM
brooks added inline comments to D15468: Add helper functions to copy strings into struct image_args..
Fri, Nov 16, 4:20 PM

Thu, Nov 15

brooks added inline comments to D15468: Add helper functions to copy strings into struct image_args..
Thu, Nov 15, 6:30 PM
brooks updated the diff for D15468: Add helper functions to copy strings into struct image_args..
  • Remove unneeded temporaries to follow the pattern in freebsd32.
  • Const poision arguments.
  • Remove extra parens.
  • Document the argument array size with an assert rather than a comment.
Thu, Nov 15, 6:29 PM
brooks updated the diff for D15468: Add helper functions to copy strings into struct image_args..
  • Rebase
Thu, Nov 15, 12:46 AM
brooks abandoned D17349: GC unused and undocumented copyout_(un)map() interfaces..
Thu, Nov 15, 12:42 AM
brooks accepted D17990: Avoid realpath(3) if not needed..

Oh right, of course that works. Things called from $PATH are run with a full path in $0.

Thu, Nov 15, 12:18 AM

Nov 14 2018

brooks committed rP484948: Update to a new snapshot..
Update to a new snapshot.
Nov 14 2018, 9:41 PM
brooks added a comment to D17990: Avoid realpath(3) if not needed..

I don't understand how this can work is the working directory isn't /usr/local/bin.

Nov 14 2018, 9:28 PM
brooks accepted D17984: Update secteam. Promote remko to Deputy. Update core team liason to reflect brooks taking the job..
Nov 14 2018, 5:55 PM
brooks closed D17932: Allow the location of capabilities.conf to be configured..
Nov 14 2018, 12:46 AM
brooks committed rS340424: Use the main capabilities.conf for freebsd32..
Use the main capabilities.conf for freebsd32.
Nov 14 2018, 12:46 AM

Nov 12 2018

brooks committed rS340389: Regen after r340388: MFC r340302: Fix freebsd32 mknod(at)..
Regen after r340388: MFC r340302: Fix freebsd32 mknod(at).
Nov 12 2018, 9:54 PM
brooks committed rS340388: MFC r340302:.
MFC r340302:
Nov 12 2018, 9:52 PM
brooks committed rS340379: Regen after r340377: MFC r340272, r340274, r340294.
Regen after r340377: MFC r340272, r340274, r340294
Nov 12 2018, 6:24 PM
brooks committed rS340378: MFC r340272, r340274, r340294.
MFC r340272, r340274, r340294
Nov 12 2018, 6:21 PM
brooks added a comment to D14567: Introduce fdunlinkat..

@cem, @kib, @emaste, @jilles I would like to commit it as-it-is but pjd suggested to change the name to funlinkat? After some thoughts I also think that funlinkat is a bether name 'fd' suggests that it's working on 'FILE *'. Do you agree?

Nov 12 2018, 6:15 PM
brooks added inline comments to D14567: Introduce fdunlinkat..
Nov 12 2018, 6:11 PM
brooks committed rS340371: Use ...-freebsd13.0 in -target strings..
Use ...-freebsd13.0 in -target strings.
Nov 12 2018, 4:55 PM
brooks added a comment to D17932: Allow the location of capabilities.conf to be configured..
In D17932#383019, @kib wrote:

Does it mean that if we have both foo and freebsd32_foo, then we cannot selectively enable only one of them for cap mode ?

Yes. I can't imagine a situation where we'd want to do that.

Nov 12 2018, 4:49 PM
brooks added a comment to D17932: Allow the location of capabilities.conf to be configured..
In D17932#383019, @kib wrote:

Does it mean that if we have both foo and freebsd32_foo, then we cannot selectively enable only one of them for cap mode ?

I think that's probably fine, although maybe we should generate a warning or error if both exist?

Nov 12 2018, 4:46 PM
brooks added a comment to D17932: Allow the location of capabilities.conf to be configured..
In D17932#383019, @kib wrote:

Does it mean that if we have both foo and freebsd32_foo, then we cannot selectively enable only one of them for cap mode ?

Nov 12 2018, 4:46 PM

Nov 9 2018

brooks updated the summary of D17932: Allow the location of capabilities.conf to be configured..
Nov 9 2018, 9:39 PM
brooks added a comment to D17932: Allow the location of capabilities.conf to be configured..

Note, with rS340294 already applied make sysent makes no changes after this change.

Nov 9 2018, 9:20 PM
brooks created D17932: Allow the location of capabilities.conf to be configured..
Nov 9 2018, 9:19 PM
brooks committed rS340303: Regen after r340302: Fix freebsd32 mknod(at)..
Regen after r340302: Fix freebsd32 mknod(at).
Nov 9 2018, 9:02 PM
brooks committed rS340302: Fix freebsd32 mknod(at)..
Fix freebsd32 mknod(at).
Nov 9 2018, 9:01 PM
brooks closed D17928: Fix freebsd32 mknod(at)..
Nov 9 2018, 9:01 PM