Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (329 w, 3 d)

Recent Activity

Yesterday

brooks closed D26903: Only use ASAN when using the in-tree compiler.
Fri, Oct 23, 10:28 PM
brooks committed rS366981: Only use ASAN when using the in-tree compiler.
Only use ASAN when using the in-tree compiler
Fri, Oct 23, 10:28 PM

Thu, Oct 22

brooks added a comment to D26902: Key decleration of union semun on src version.

Technically speaking this code is broken on FreeBSD <2 (see the code right above this), but I can't bring myself to do the reshuffling to fix that...

Thu, Oct 22, 10:41 PM
brooks added a comment to D26902: Key decleration of union semun on src version.

The check is also just plain wrong. The question isn't "what version of FreeBSD is the compiler targeting?" It's "what version of FreeBSD is providing the headers?" Obviously they should match, but checking the right thing means I don't have to dig into libcompat build bits on 11.

Thu, Oct 22, 7:53 PM
brooks committed rS366940: MFC r366671:.
MFC r366671:
Thu, Oct 22, 4:41 PM
brooks committed rS366939: MFC r366731:.
MFC r366731:
Thu, Oct 22, 4:29 PM
brooks committed rS366938: MFC r366731:.
MFC r366731:
Thu, Oct 22, 4:27 PM
brooks added a comment to D26903: Only use ASAN when using the in-tree compiler.

I couldn't find an easier way to determine if the compiler was suitable. It might be that we want to skip these tests entirely instead, but then we're voting to make them dead code in the long term.

Thu, Oct 22, 4:21 PM
brooks requested review of D26903: Only use ASAN when using the in-tree compiler.
Thu, Oct 22, 4:18 PM
brooks requested review of D26902: Key decleration of union semun on src version.
Thu, Oct 22, 4:11 PM

Wed, Oct 21

brooks committed rS366912: MFC r366671:.
MFC r366671:
Wed, Oct 21, 4:05 PM
brooks closed D26784: vmapbuf: don't smuggle user address via b_data.
Wed, Oct 21, 4:00 PM
brooks committed rS366911: vmapbuf: don't smuggle address or length in buf.
vmapbuf: don't smuggle address or length in buf
Wed, Oct 21, 4:00 PM

Mon, Oct 19

brooks committed rP552775: New snapshot and infrastructure updates.
New snapshot and infrastructure updates
Mon, Oct 19, 11:06 PM
brooks updated the diff for D26784: vmapbuf: don't smuggle user address via b_data.
  • GC a dead check.
Mon, Oct 19, 9:06 PM
brooks added a comment to D26784: vmapbuf: don't smuggle user address via b_data.

https://cirrus-ci.com/task/5974398819631104

Mon, Oct 19, 5:21 PM
brooks updated the diff for D26784: vmapbuf: don't smuggle user address via b_data.
  • Pass size rather than smuggling via b_bufsize.
Mon, Oct 19, 3:09 PM

Thu, Oct 15

brooks added a comment to D26784: vmapbuf: don't smuggle user address via b_data.

CI run: https://cirrus-ci.com/task/5059292485124096

Thu, Oct 15, 5:35 PM
brooks closed D26783: physio: Don't store user addresses in bio_data.
Thu, Oct 15, 5:05 PM
brooks committed rS366731: physio: Don't store user addresses in bio_data.
physio: Don't store user addresses in bio_data
Thu, Oct 15, 5:05 PM

Wed, Oct 14

brooks requested review of D26784: vmapbuf: don't smuggle user address via b_data.
Wed, Oct 14, 11:53 PM
brooks added a comment to D26783: physio: Don't store user addresses in bio_data.

I needed this change in CheriBSD because we can't store user pointers in bio_data due to a type mismatch and we need to pass the pointer (rather than an address) to vm_fault_quick_hold_pages.

Wed, Oct 14, 10:04 PM
brooks added a comment to D26783: physio: Don't store user addresses in bio_data.

Cirrus-CI run https://cirrus-ci.com/task/5195860164214784

Wed, Oct 14, 10:02 PM
brooks requested review of D26783: physio: Don't store user addresses in bio_data.
Wed, Oct 14, 10:01 PM
brooks created P439 so many stack traces....
Wed, Oct 14, 6:34 PM
brooks created P438 panic shortly after mount root .
Wed, Oct 14, 5:59 PM
brooks accepted D26776: Skip make includes for (most) directories without includes.

This looks like a nice improvement and the error/warning bits resolve my initial concern about maintenance.

Wed, Oct 14, 5:08 PM
brooks added a comment to D26668: Add native system call for eventfd.

Ooh I just had a galaxy brain idea. What if we introduce one syscall, specialfd with args being an int for the type constant and a void* that points to per-type args structs. (Maybe also len to allow extending structs while keeping the same type.) This way, one syscall would allow adding more similar facilities later (like timerfd or something completely new.. and e.g. shm_open2 could have been this) without having a new syscall-worthiness debate each time!

Wed, Oct 14, 4:52 PM · Linux Emulation

Tue, Oct 13

brooks committed rP552284: Resurrect devel/llvm-cheri and update.
Resurrect devel/llvm-cheri and update
Tue, Oct 13, 9:10 PM
brooks committed rS366684: Remove --ld-path=* from _LDFLAGS.
Remove --ld-path=* from _LDFLAGS
Tue, Oct 13, 8:04 PM
brooks closed D26592: libgssapi: modernize static string array use.
Tue, Oct 13, 5:14 PM
brooks committed rS366671: libgssapi: modernize static string array use.
libgssapi: modernize static string array use
Tue, Oct 13, 5:14 PM

Mon, Oct 12

brooks committed rP552154: Welcome 11.0.0 release..
Welcome 11.0.0 release.
Mon, Oct 12, 10:31 PM

Mon, Oct 5

brooks committed rP551536: Update to 11.0.0rc5..
Update to 11.0.0rc5.
Mon, Oct 5, 7:04 PM

Wed, Sep 30

brooks accepted D26618: Don't use install(1) for the library symlinks in the build directory.

It might be worth a comment making clear this is in objdir since bare use of ln is almost always a bug.

Wed, Sep 30, 10:21 PM
brooks accepted D26619: Remove 'struct trapframe' from mips64's 'struct syscall_args'.
Wed, Sep 30, 10:19 PM
brooks committed rP550752: Update to 11.0.0rc4..
Update to 11.0.0rc4.
Wed, Sep 30, 9:37 PM

Tue, Sep 29

brooks committed rS366273: Hoist comment on fixup of ld path.
Hoist comment on fixup of ld path
Tue, Sep 29, 11:48 PM
brooks committed rS366270: Prefer --ld-path=/path/to/ld on clang >= 12.
Prefer --ld-path=/path/to/ld on clang >= 12
Tue, Sep 29, 10:30 PM
brooks closed D26591: Prefer --ld-path=/path/to/ld on clang >= 12..
Tue, Sep 29, 10:30 PM
brooks accepted D26473: Significantly speed up libthr/mutex_test and make more reliable.
Tue, Sep 29, 10:11 PM
brooks accepted D26594: Makefile.inc1: sysent: allow subordinate sysent targets to run in parallel.
Tue, Sep 29, 10:09 PM
brooks added a comment to D26593: Passify a new clang warning.

I've submitted here because upstream seems to want me to do that (and also to document the issue if someone else tries building FreeBSD with an up-to-date llvm.

Tue, Sep 29, 8:39 PM
brooks requested review of D26593: Passify a new clang warning.
Tue, Sep 29, 8:24 PM
brooks requested review of D26592: libgssapi: modernize static string array use.
Tue, Sep 29, 8:21 PM
brooks requested review of D26591: Prefer --ld-path=/path/to/ld on clang >= 12..
Tue, Sep 29, 8:14 PM
brooks committed rP550531: Update to a new snapshot..
Update to a new snapshot.
Tue, Sep 29, 4:37 PM

Fri, Sep 25

brooks accepted D26556: Fix compat32 on mips64.
Fri, Sep 25, 4:58 PM

Sep 23 2020

brooks added inline comments to D26530: Make makesyscalls.lua initialize 'struct sysent' entries using c99 designated identifiers.
Sep 23 2020, 5:42 PM
brooks accepted D26530: Make makesyscalls.lua initialize 'struct sysent' entries using c99 designated identifiers.

Seems sensible. Those are going to be some long lines, but they aren't really meant to be read.

Sep 23 2020, 4:55 PM

Sep 17 2020

brooks committed rS365864: MFC r365284:.
MFC r365284:
Sep 17 2020, 11:14 PM

Sep 14 2020

brooks committed rP548682: Fix build with clang 11/gcc 10..
Fix build with clang 11/gcc 10.
Sep 14 2020, 8:34 PM

Sep 10 2020

brooks accepted D26397: build: provide a default WARNS for src builds.

Seems sensible. I guess it's good that most of the issues are in tests or GPL code we're deleting soon?

Sep 10 2020, 7:07 PM
brooks committed rP548211: Express LICENSE_PERMS correction..
Express LICENSE_PERMS correction.
Sep 10 2020, 5:26 PM

Sep 9 2020

brooks closed D26371: graphics/pgplot: Fix duplicate source file.
Sep 9 2020, 11:38 PM
brooks committed rP548168: graphics/pgplot: Fix duplicate source file.
graphics/pgplot: Fix duplicate source file
Sep 9 2020, 11:38 PM
brooks committed rS365545: MFC r365284:.
MFC r365284:
Sep 9 2020, 11:12 PM
brooks committed rS365534: MFC r365279:.
MFC r365279:
Sep 9 2020, 10:40 PM
brooks added a reverting change for rS6: Beta release of device driver for SMC/WD80x3 and 3C503 ethernet boards.: rS365534: MFC r365279:.
Sep 9 2020, 10:40 PM
brooks committed rS365519: MFC r365279:.
MFC r365279:
Sep 9 2020, 9:58 PM
brooks added a reverting change for rS6: Beta release of device driver for SMC/WD80x3 and 3C503 ethernet boards.: rS365519: MFC r365279:.
Sep 9 2020, 9:58 PM
brooks accepted D26370: Use MACHINE_CPUARCH when checking for arm64.

Seems fine to me, but tagging @imp for further review.

Sep 9 2020, 5:44 PM

Sep 4 2020

brooks closed D26328: Round TF_SIZE up to the stack alignment (16-bytes)..
Sep 4 2020, 9:55 PM
brooks committed rS365344: Round TF_SIZE up to the stack alignment (16-bytes)..
Round TF_SIZE up to the stack alignment (16-bytes).
Sep 4 2020, 9:55 PM
brooks added inline comments to D26328: Round TF_SIZE up to the stack alignment (16-bytes)..
Sep 4 2020, 9:55 PM
brooks closed D26327: Maintain a stack alignment of 16-bytes..
Sep 4 2020, 9:46 PM
brooks committed rS365342: Maintain a stack alignment of 16-bytes..
Maintain a stack alignment of 16-bytes.
Sep 4 2020, 9:46 PM
brooks requested review of D26328: Round TF_SIZE up to the stack alignment (16-bytes)..
Sep 4 2020, 5:58 PM
brooks requested review of D26327: Maintain a stack alignment of 16-bytes..
Sep 4 2020, 5:55 PM

Sep 2 2020

brooks closed D26288: Log ENOSYS in init.
Sep 2 2020, 11:17 PM
brooks committed rS365284: Always report ENOSYS in init.
Always report ENOSYS in init
Sep 2 2020, 11:17 PM
brooks updated the diff for D26288: Log ENOSYS in init.
  • Honor kern.lognosys if non-zero.
Sep 2 2020, 10:17 PM
brooks committed rP547390: Garbage collect xtoolchain-(llvm60|llvm70).
Garbage collect xtoolchain-(llvm60|llvm70)
Sep 2 2020, 9:44 PM
brooks committed rS365279: Remove risky compatability with old kernels.
Remove risky compatability with old kernels
Sep 2 2020, 9:14 PM
brooks added a reverting change for rS6: Beta release of device driver for SMC/WD80x3 and 3C503 ethernet boards.: rS365279: Remove risky compatability with old kernels.
Sep 2 2020, 9:14 PM
brooks closed D26289: Remove risky compatability with old kernels..
Sep 2 2020, 9:14 PM

Sep 1 2020

brooks added a comment to D26289: Remove risky compatability with old kernels..

I found this when discussing the implications of D26288.

Sep 1 2020, 10:29 PM
brooks added a comment to D26289: Remove risky compatability with old kernels..

For reverence the original commit is https://svnweb.freebsd.org/csrg?view=revision&revision=58422

Sep 1 2020, 10:27 PM
brooks requested review of D26289: Remove risky compatability with old kernels..
Sep 1 2020, 10:26 PM
brooks added a comment to D26288: Log ENOSYS in init.

I ran into this on a CHERI system where we've added new revocation related system calls used in malloc. Unfortunately, we call malloc in strdup even before the (rather questionable) badsys hander is installed. Due to someone changing the kernel configs and me not noticing I lost a half day to not having those syscalls...

Sep 1 2020, 9:03 PM
brooks requested review of D26288: Log ENOSYS in init.
Sep 1 2020, 8:58 PM
brooks accepted D26281: Pass a valid mode with O_CREATE to open(2)..
Sep 1 2020, 5:49 PM
brooks accepted D26279: Don't assume objects in program sections have a size of a pointer..
Sep 1 2020, 4:56 PM
brooks added inline comments to D26278: Various fixes to the load() function..
Sep 1 2020, 4:55 PM

Aug 26 2020

brooks committed rP546302: Upgrade to 11.0.0.rc2..
Upgrade to 11.0.0.rc2.
Aug 26 2020, 10:27 PM
brooks accepted D26197: Fix a buffer overrun..
Aug 26 2020, 5:54 PM

Aug 18 2020

brooks accepted D26095: Tag pccard drivers with gone in 13..
Aug 18 2020, 8:58 PM

Aug 14 2020

brooks accepted D25998: Correctly determine the real executable in crunched binaries.
Aug 14 2020, 11:44 PM
brooks committed rP544895: Update to a new snapshot and add FLANG and MLIR options.
Update to a new snapshot and add FLANG and MLIR options
Aug 14 2020, 6:36 PM

Aug 13 2020

brooks accepted D26055: Pass -fuse-ld=/path/to/ld if ${LD} != "ld".
Aug 13 2020, 10:32 PM
brooks added reviewers for D26041: install(1): Avoid unncessary fstatfs() calls and use mmap() based on size: markj, jhb.

Add a couple people to potentially comment on what the max size to mmap should actually be.

Aug 13 2020, 10:27 PM
brooks accepted D26039: Use bootstrapped install(1) install of tools/install.sh in world stage.
Aug 13 2020, 10:18 PM
brooks accepted D25992: Add necessary Makefile.inc1 infrastructure for building on non-FreeBSD.
Aug 13 2020, 10:17 PM
brooks accepted D25978: Add missing FreeBSD functions to -legacy when building on macOS/Linux.
Aug 13 2020, 10:06 PM
brooks accepted D25986: Avoid recomputing COMPILER_/LINKER_ variables when set explicitly.
Aug 13 2020, 10:06 PM
brooks added inline comments to D25998: Correctly determine the real executable in crunched binaries.
Aug 13 2020, 6:10 PM
brooks accepted D16762: Don't delete the source file when installing links on case-insensitive file systems.

Given that few changes are required to support a case-insensitive FS I think it's worth doing.

Aug 13 2020, 5:46 PM
brooks accepted D26038: Pass the installworld install(1) flags to make buildenv.
Aug 13 2020, 4:30 PM

Aug 11 2020

brooks accepted D25978: Add missing FreeBSD functions to -legacy when building on macOS/Linux.
Aug 11 2020, 8:44 PM
brooks accepted D14316: Add Linux/macOS compatibility system headers to tools/build/cross-build.
Aug 11 2020, 8:42 PM