brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (185 w, 5 d)

Recent Activity

Fri, Jan 19

brooks committed rP459485: Fix python dependency: restrict to python 2.7..
Fix python dependency: restrict to python 2.7.
Fri, Jan 19, 11:38 PM
brooks abandoned D13801: Reject the absurd user and group names "." and ".."..

Seems to be unnecessary. I don't like the way some defaults work out, but *shrug*.

Fri, Jan 19, 11:32 PM
brooks committed rP459483: Update to a new snapshot, now on the 7.0 line. [0].
Update to a new snapshot, now on the 7.0 line. [0]
Fri, Jan 19, 11:30 PM

Wed, Jan 17

brooks accepted D13306: Allow compiling usr.bin/find on Linux and Mac.

LGTM

Wed, Jan 17, 8:23 PM

Mon, Jan 15

brooks added reviewers for D13801: Reject the absurd user and group names "." and "..".: eugen_grosbein.net, asomers, bapt.

Add people who have touched pw as possible reviewers.

Mon, Jan 15, 5:19 PM
brooks updated the diff for D13801: Reject the absurd user and group names "." and ".."..
  • Tweak wording as suggested by @bcr.
Mon, Jan 15, 5:17 PM

Wed, Jan 10

brooks committed rP458680: Upgrade to 5.0.1..
Upgrade to 5.0.1.
Wed, Jan 10, 7:22 PM
brooks accepted D13827: Enable ld.lld as bootstrap linker by default on amd64.

LGTM

Wed, Jan 10, 5:55 PM
brooks committed rP458596: Correct llvm-config40 output with shared libraries..
Correct llvm-config40 output with shared libraries.
Wed, Jan 10, 4:03 AM
brooks committed rP458590: Upgrade to 5.0.1..
Upgrade to 5.0.1.
Wed, Jan 10, 1:43 AM

Tue, Jan 9

brooks added a reviewer for D13801: Reject the absurd user and group names "." and "..".: emaste.
Tue, Jan 9, 1:14 AM
brooks created D13801: Reject the absurd user and group names "." and ".."..
Tue, Jan 9, 1:12 AM

Sat, Jan 6

brooks added a reviewer for D13779: Don't escape '?'s in protocol output.: manpages.
Sat, Jan 6, 9:30 PM

Fri, Jan 5

brooks created D13779: Don't escape '?'s in protocol output..
Fri, Jan 5, 11:46 PM
brooks added a comment to D13587: Allow to have per-interface wpa_supplicant.conf (wpa_supplicant.conf.${ifname}).

This seems reasonable to me. I'd prefer /etc/wpa_supplicant.d/em0.conf in place of /etc/wpa_supplicant.conf.em0.

Fri, Jan 5, 4:17 PM

Dec 22 2017

brooks accepted D13433: Introduce daemonfd..
Dec 22 2017, 6:19 PM
brooks added a comment to D13433: Introduce daemonfd..

This looks good to me.

Dec 22 2017, 6:19 PM

Dec 19 2017

brooks added a comment to D13538: SysV IPC API cleanup.

See also https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224443. After I deal with ports I plan to abandon this revision and split the changes that are viable up into individual diffs.

Dec 19 2017, 3:00 AM
brooks created D13538: SysV IPC API cleanup.
Dec 19 2017, 2:55 AM
brooks committed rP456697: Fix build on 10.3..
Fix build on 10.3.
Dec 19 2017, 12:32 AM

Dec 14 2017

brooks updated the diff for D13471: Fix and enable SysV IPC tests..
  • Rename struct mymsg to testmsg to avoid FreeBSD's misdecleration.
Dec 14 2017, 1:01 AM

Dec 13 2017

brooks added a comment to D13378: Rework alignment handling in __libc_allocate_tls() for Variant I of TLS layout..

First the overall alignment is computed:

maxalign = MAX(tcbalign, tls_init_align);

and then tls_block_size is computed with all the assorted padding and without relation to tcbalign.
The whole allocation is then aligned to maxalign with:

tls_block = malloc_aligned(tls_block_size, maxalign);

However, if tcbalign is > tls_block_size the TLS segment will be aligned to tls_block_size not maxalign. As a practical matter I'm not sure this can happen, but this code is confusing enough that I really don't want to have to read through multiple codepaths and traverser weak symbols to convince myself it won't. We should either honor all reasonable values for tcbalign is document our assumptions about them clearly.

Dec 13 2017, 11:14 PM
brooks created D13471: Fix and enable SysV IPC tests..
Dec 13 2017, 1:14 AM

Dec 12 2017

brooks added a reviewer for D13459: kern.ipc.{msqids,semsegs,sema} sysctls for FreeBSD32.: secteam.

This is technically an information disclosure, but in practice is quite small and unlikely to be a serious issue in the current world order.

Dec 12 2017, 2:34 AM
brooks created D13459: kern.ipc.{msqids,semsegs,sema} sysctls for FreeBSD32..
Dec 12 2017, 2:33 AM

Dec 7 2017

brooks committed rP455764: Update llvm-cheri to a new snapshot..
Update llvm-cheri to a new snapshot.
Dec 7 2017, 11:49 PM
brooks added a comment to D13378: Rework alignment handling in __libc_allocate_tls() for Variant I of TLS layout..

This code generally seem like an improvement for code where there are hidden alignment requirements in the binary, but it isn't complete. If you do something like:

extern __thread char array_16k[16384];
__attribute__((__aligned__(16384)))
__thread char array_16k[16384];

Then it will only reliably be aligned to 8k. On at least mips64 this will be a regression.

Dec 7 2017, 11:19 PM
brooks committed rP455746: Update to a new snapshot..
Update to a new snapshot.
Dec 7 2017, 6:08 PM

Nov 30 2017

brooks committed rP455226: Update to a fresh snapshot..
Update to a fresh snapshot.
Nov 30 2017, 8:56 PM
brooks accepted D13307: Allow xinstall and makefs to be crossbuilt on Linux and Mac.

LGTM, but I'd wait for @emaste to take a look as he's been working on makefs.

Nov 30 2017, 7:38 PM
brooks accepted D13306: Allow compiling usr.bin/find on Linux and Mac.

Over all the approach seems fine.

Nov 30 2017, 7:34 PM
brooks accepted D13305: libnetbsd: Make the function declaration of efopen() match the definition.

I'd guess the upstream version used struct __sFILE to avoid header pollution somewhere, but this seems perfectly fine here.

Nov 30 2017, 7:26 PM

Nov 29 2017

brooks committed rP455158: Enable RTTI to allow ports that need it to work..
Enable RTTI to allow ports that need it to work.
Nov 29 2017, 11:40 PM

Nov 28 2017

brooks closed D13213: Disable vim syntax highlighting..

Committed in rS326333

Nov 28 2017, 6:23 PM
brooks committed rS326333: Disable vim syntax highlighting..
Disable vim syntax highlighting.
Nov 28 2017, 6:23 PM
brooks committed rS326324: MFC r301679 (partial), r309626, r326307.
MFC r301679 (partial), r309626, r326307
Nov 28 2017, 5:21 PM
brooks committed rP455066: Enable RTTI to allow ports such as `graphics/openshadinglanguage' and.
Enable RTTI to allow ports such as `graphics/openshadinglanguage' and
Nov 28 2017, 5:13 PM
brooks committed rS326320: MFC r326307:.
MFC r326307:
Nov 28 2017, 4:49 PM
brooks committed rS326307: Update vis(3) the latest from NetBSD..
Update vis(3) the latest from NetBSD.
Nov 28 2017, 1:35 AM

Nov 27 2017

brooks committed rS326296: Tag 2017-11-27 import of NetBSD's (un)vis(3).
Tag 2017-11-27 import of NetBSD's (un)vis(3)
Nov 27 2017, 11:48 PM
brooks committed rS326295: Vendor import of NetBSD's (un)vis(3) at 2017-11-27.
Vendor import of NetBSD's (un)vis(3) at 2017-11-27
Nov 27 2017, 11:48 PM

Nov 23 2017

brooks created D13213: Disable vim syntax highlighting..
Nov 23 2017, 4:42 PM

Nov 22 2017

brooks accepted D13135: Fix fabs() for MIPS when used on -0.0.

LGTM

Nov 22 2017, 4:28 PM
brooks added a member for MIPS: brooks.
Nov 22 2017, 4:28 PM

Nov 20 2017

brooks committed rS326035: Remove a couple variables that are unused after r325790..
Remove a couple variables that are unused after r325790.
Nov 20 2017, 10:18 PM

Nov 17 2017

brooks added a comment to D13134: [mips32/tls] change TCB size from 8 to 16 to be aligned with r324938 & r325364.

You shouldn't need to change the size or roundup2 the syscall argument. With the change in rS325364 the TLS allocation should be properly aligned so long as the PT_TLS segment has the right alignment. You could change the definition of TLS_TCB_ALIGN to be 16 for mips like it is on amd64, but we should be setting the alignment of the TLS segment correctly and fix it if we aren't.

Nov 17 2017, 10:17 PM
brooks added a comment to D13134: [mips32/tls] change TCB size from 8 to 16 to be aligned with r324938 & r325364.

Is this needed at all after rS325364? We should now be respecting the alignment of the PT_TLS section. If the PT_TLS section isn't correctly aligned then fixing that is the right answer rather than trashing the ABI.

Nov 17 2017, 4:54 PM
brooks added a comment to D13134: [mips32/tls] change TCB size from 8 to 16 to be aligned with r324938 & r325364.

Why not just nuke TLS_TCB_SIZE32?

Nov 17 2017, 4:34 PM

Nov 16 2017

brooks committed rP454342: Update to a new snapshot and apply the patch for posix_fallocate().
Update to a new snapshot and apply the patch for posix_fallocate()
Nov 16 2017, 9:44 PM

Nov 13 2017

brooks committed rP454097: Update to a new snapshot..
Update to a new snapshot.
Nov 13 2017, 2:48 AM
brooks committed rP454093: Merge from src and upstream LLVM:.
Merge from src and upstream LLVM:
Nov 13 2017, 1:45 AM

Nov 12 2017

brooks committed rP454025: Merge from src:.
Merge from src:
Nov 12 2017, 9:09 AM
brooks accepted D13015: Axe xlint..

xlint has been useless for years and has some of the worst code quality in the base system. Its removal is long overdue.

Nov 12 2017, 7:12 AM
brooks accepted D12962: Convert BERI to use ofw_parse_bootargs().

LGTM

Nov 12 2017, 3:55 AM

Nov 2 2017

brooks added inline comments to D12907: Add alignment support to __libc_allocate_tls()..
Nov 2 2017, 12:31 PM
brooks accepted D11925: Export std::get_new_handler() from libcxxrt.so.

LGTM

Nov 2 2017, 12:06 PM
brooks accepted D12907: Add alignment support to __libc_allocate_tls()..

Looks good to me. We should probably make similar changes to Variant II.

Nov 2 2017, 8:18 AM

Oct 31 2017

brooks committed rP453221: Update to a new snapshot correcting 128-bit support..
Update to a new snapshot correcting 128-bit support.
Oct 31 2017, 10:05 AM

Oct 30 2017

brooks committed rP453171: Update to a new snapshot. This version supports new and improved.
Update to a new snapshot. This version supports new and improved
Oct 30 2017, 12:42 PM
brooks committed rP453163: Update to an October 23rd snapshot..
Update to an October 23rd snapshot.
Oct 30 2017, 10:20 AM

Oct 18 2017

brooks updated the diff for D12677: Add sortbench..
  • Add Copyright blocks (manual merge)
Oct 18 2017, 6:04 PM
brooks updated the diff for D12677: Add sortbench..

Revert botched merge

Oct 18 2017, 6:00 PM
brooks updated the diff for D12677: Add sortbench..
  • Add licenses from Miles.
Oct 18 2017, 5:58 PM
brooks committed rS324710: Remove mbpool(9) now that it has no consumers..
Remove mbpool(9) now that it has no consumers.
Oct 18 2017, 12:18 AM
brooks closed D10513: Remove mbpool(9) now that it has no consumers..
Oct 18 2017, 12:18 AM

Oct 15 2017

brooks committed rS324643: MFC r321256:.
MFC r321256:
Oct 15 2017, 10:45 PM
brooks committed rS324642: MFC r321256:.
MFC r321256:
Oct 15 2017, 10:44 PM
brooks committed rS324641: MFC r320999:.
MFC r320999:
Oct 15 2017, 10:39 PM
brooks committed rS324640: MFC r320999:.
MFC r320999:
Oct 15 2017, 10:34 PM
brooks committed rP452160: Fix hardcoded version in clang-format. [0].
Fix hardcoded version in clang-format. [0]
Oct 15 2017, 6:26 PM

Oct 14 2017

brooks committed rP452094: Put openmp in the right place so it is built and installed..
Put openmp in the right place so it is built and installed.
Oct 14 2017, 11:38 PM
brooks added a comment to D11646: Mergesort Benchmark.

I've posted an updated diff in D12677

Oct 14 2017, 9:55 PM
brooks added a reviewer for D12677: Add sortbench.: milesfertel_college.harvard.edu.

Miles, I've extracted this from your GitHub repo and made a few changes to the Makefile and would like to commit this soon. One thing that is missing is appropriate BSD copyright blocks on bench.py and sort_bench.c. I can't commit without them. Please provide me with your preferred Copyright line and acknowledge that these are to be available under the standard FreeBSD license (https://www.freebsd.org/copyright/freebsd-license.html).

Oct 14 2017, 9:54 PM
brooks created D12677: Add sortbench..
Oct 14 2017, 9:49 PM
brooks committed rP452079: Fix build without EXTRAS (clangd is part of EXTRAS, not CLANG). [0].
Fix build without EXTRAS (clangd is part of EXTRAS, not CLANG). [0]
Oct 14 2017, 6:55 PM
brooks added a comment to D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.

Thank you for doing this work! Sorry it took me so long to commit it.

Oct 14 2017, 6:42 PM
brooks committed rS324619: Switch procstat from subcommand flags to verbs.
Switch procstat from subcommand flags to verbs
Oct 14 2017, 6:38 PM
brooks closed D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.
Oct 14 2017, 6:38 PM
brooks accepted D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.
Oct 14 2017, 6:35 PM
brooks updated the diff for D10916: usr.bin/procstat: Switch procstat from subcommand flags to verbs.

Merge to FreeBSD head prior to commit to SVN.

Oct 14 2017, 6:32 PM
brooks committed rS324617: MFC r324243:.
MFC r324243:
Oct 14 2017, 4:49 PM
brooks committed rS324616: MFC r324243:.
MFC r324243:
Oct 14 2017, 4:23 PM
brooks committed rP452037: Remove forced clang34 dependency. The port builds on 10.3 (which has.
Remove forced clang34 dependency. The port builds on 10.3 (which has
Oct 14 2017, 12:11 AM

Oct 13 2017

brooks committed rP451941: Update to a new snapshot..
Update to a new snapshot.
Oct 13 2017, 1:25 AM

Oct 12 2017

brooks committed rP451923: - add support for ARMv7.
- add support for ARMv7
Oct 12 2017, 6:17 PM
brooks committed rP451914: Update a new shapshot..
Update a new shapshot.
Oct 12 2017, 5:14 PM

Oct 11 2017

brooks committed rP451764: - add support for ARMv7.
- add support for ARMv7
Oct 11 2017, 5:15 PM

Oct 6 2017

brooks added a reviewer for D12607: Remove redundant pam_rhosts: des.

Dag-Erling should probably weigh in as this is a pam change.

Oct 6 2017, 5:59 PM
brooks requested changes to D12607: Remove redundant pam_rhosts.
Oct 6 2017, 5:58 PM
brooks added a comment to D12603: Add a mechanism to allow having binary found first in the path.

I like this a lot. It should help users of llvm-config since they can link llvm-config## in as llvm-config. I suspect this will spawn many USES flags.

Oct 6 2017, 5:43 PM

Oct 5 2017

brooks accepted D12573: Remove rcmds from the base system..

I'm confused as to how the rcp directory doesn't end up /usr/test/bin/, but can confirm that it doesn't in a VM with the test suite installed.

Oct 5 2017, 11:45 PM

Oct 4 2017

brooks requested changes to D12573: Remove rcmds from the base system..

Small missing bit: etc/mtree/BSD.tests.dist contains a rcp directory. There are presumably missing ObsoleteFiles.inc entries for tests as well. Otherwise looks good to me.

Oct 4 2017, 3:21 PM

Oct 3 2017

brooks closed D12547: Remove an unneeded and incorrect memset()..
Oct 3 2017, 10:57 PM
brooks committed rS324243: Remove an unneeded and incorrect memset()..
Remove an unneeded and incorrect memset().
Oct 3 2017, 10:57 PM

Sep 29 2017

brooks added a reviewer for D12547: Remove an unneeded and incorrect memset().: andrew.
Sep 29 2017, 9:23 PM
brooks added reviewers for D12547: Remove an unneeded and incorrect memset().: secteam, kib, dfr, jhb.
Sep 29 2017, 9:00 PM
brooks created D12547: Remove an unneeded and incorrect memset()..
Sep 29 2017, 8:59 PM

Sep 22 2017

brooks committed rP450418: Add xtoolchain port for llvm50..
Add xtoolchain port for llvm50.
Sep 22 2017, 10:03 PM

Sep 21 2017

brooks committed rP450313: Remove bogus plist entry..
Remove bogus plist entry.
Sep 21 2017, 11:46 PM

Sep 20 2017

brooks committed rP450206: Spell PORTREVISION correctly..
Spell PORTREVISION correctly.
Sep 20 2017, 4:06 PM