- User Since
- Jul 1 2014, 6:02 PM (176 w, 5 d)
Fri, Nov 17
You shouldn't need to change the size or roundup2 the syscall argument. With the change in rS325364 the TLS allocation should be properly aligned so long as the PT_TLS segment has the right alignment. You could change the definition of TLS_TCB_ALIGN to be 16 for mips like it is on amd64, but we should be setting the alignment of the TLS segment correctly and fix it if we aren't.
Is this needed at all after rS325364? We should now be respecting the alignment of the PT_TLS section. If the PT_TLS section isn't correctly aligned then fixing that is the right answer rather than trashing the ABI.
Why not just nuke TLS_TCB_SIZE32?
Thu, Nov 16
Mon, Nov 13
Sun, Nov 12
xlint has been useless for years and has some of the worst code quality in the base system. Its removal is long overdue.
Thu, Nov 2
Looks good to me. We should probably make similar changes to Variant II.
Tue, Oct 31
Mon, Oct 30
Oct 18 2017
- Add Copyright blocks (manual merge)
Oct 15 2017
Oct 14 2017
I've posted an updated diff in D12677
Miles, I've extracted this from your GitHub repo and made a few changes to the Makefile and would like to commit this soon. One thing that is missing is appropriate BSD copyright blocks on bench.py and sort_bench.c. I can't commit without them. Please provide me with your preferred Copyright line and acknowledge that these are to be available under the standard FreeBSD license (https://www.freebsd.org/copyright/freebsd-license.html).
Thank you for doing this work! Sorry it took me so long to commit it.
Merge to FreeBSD head prior to commit to SVN.
Oct 13 2017
Oct 12 2017
Oct 11 2017
Oct 6 2017
Dag-Erling should probably weigh in as this is a pam change.
I like this a lot. It should help users of llvm-config since they can link llvm-config## in as llvm-config. I suspect this will spawn many USES flags.
Oct 5 2017
I'm confused as to how the rcp directory doesn't end up /usr/test/bin/, but can confirm that it doesn't in a VM with the test suite installed.
Oct 4 2017
Small missing bit: etc/mtree/BSD.tests.dist contains a rcp directory. There are presumably missing ObsoleteFiles.inc entries for tests as well. Otherwise looks good to me.
Oct 3 2017
Sep 29 2017
Sep 22 2017
Sep 21 2017
Sep 20 2017
Sep 19 2017
Sep 18 2017
Sep 15 2017
Sep 14 2017
Sep 11 2017
This seems like a clean solution. The only downside I see is that you'd always need mdmfs(8) around.
Aug 28 2017
These look good to me.
Aug 24 2017
I'd suggest adding a README file describing what the tests do and what the script's expected outputs are.
Aug 4 2017
Jul 28 2017
If you can create a Makefile for this I'll look to get it committed soon (I'll be heading to the UK next Sunday, but will be doing FreeBSD things during the week so helpful I'll be able to get this committed.)
Jul 24 2017
A general question. How much do these files differ from the upstream version? Did you need to make any structural changes? I both ask to help be review this work and to figure out how we should integrate it into FreeBSD.
Jul 21 2017
Arg. I was ready to go, but ran into conflicts with a change to usage() by @ngie. I'm not sure how best to blend the result. If we add that expansion to the subcommands the result will got from unwieldy to incomprehensible (not to mention not fitting on an 80 column display).
Great! This looks ready to go. I'll apply to a tree and commit shortly.
This is looking good so far. You may want a macro to disable wikisort support so we can commit the benchmark on it's own.
Jul 19 2017
Sorry for letting this sit so long. I'm finally getting back to this now that I can run FreeBSD 12 binaries on my build systems.
Jul 18 2017
Jul 14 2017
Jul 7 2017
Jun 23 2017
Jun 20 2017
- More cleanups of link permissions.
- The geom classes build libraries, but install links to programs so
I'll submit a revised version shortly. I think I've got a test plan for release tar balls so I'll be trying that as well.
Jun 17 2017
- Add an INSTALL_MLINK to install manpage links.
Jun 16 2017
Jun 15 2017
This seems like a fine modernization. Probably should not be MFC'd due to POLA with custom kernels.
Jun 14 2017
I wonder if the -print was intentionally left for debugging purposes. I'm adding Glen who touched this line last.
Jun 3 2017
Jun 2 2017
I like the change of types for ident and data. intptr_t was defiantly the wrong type for data.