Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (627 w, 6 d)

Recent Activity

Mon, Jul 6

brooks added inline comments to D58056: exterr: allow exterr to fit pointers on CHERI targets.
Mon, Jul 6, 4:13 PM
brooks added a comment to D58059: runtime: add uexterr_set(3) to set errors in userspace.

The big thing that needs to be dealt with for this to make sense is to have a way to specify the filename that isn't a table embedded in libc. A first cut could be a special index that means no-file and perhaps using -1 as the line, but without that, we can't scale beyond files in the base system. (This also poses a problem for out of tree kernel modules.) We might also want macros like the kernel, but I'm less sure of that.

Mon, Jul 6, 4:11 PM
brooks requested review of D58060: exterr(9): add a few tests of new message formats.
Mon, Jul 6, 4:06 PM
brooks requested review of D58059: runtime: add uexterr_set(3) to set errors in userspace.
Mon, Jul 6, 4:06 PM
brooks requested review of D58058: exterr: relax format restrictions.
Mon, Jul 6, 4:06 PM
brooks requested review of D58057: exterr: clear tags from arguments on CHERI targets.
Mon, Jul 6, 4:06 PM
brooks requested review of D58056: exterr: allow exterr to fit pointers on CHERI targets.
Mon, Jul 6, 4:05 PM
brooks requested review of D58055: exterrctl(2): add kern_exterrctl.
Mon, Jul 6, 4:05 PM

Wed, Jul 1

brooks committed rG524fb0444f3a: fetch.9: fix a typo (authored by brooks).
fetch.9: fix a typo
Wed, Jul 1, 2:11 PM
brooks added a comment to D57662: CHERI: add mem{cpy,move}_data.

I ended up pulling the implementations out of the commit I merged because their dependencies (kernel option for sys/conf/files and cheri headers aren't available yet.)

Wed, Jul 1, 12:35 PM
brooks committed rG17602eb3eae9: CHERI: make mem{cpy,move}(9) CHERI compatible (authored by brooks).
CHERI: make mem{cpy,move}(9) CHERI compatible
Wed, Jul 1, 11:50 AM
brooks committed rGf14bdfefa41c: CHERI: add sooptcopyinptr to preserve pointer provenance (authored by brooks).
CHERI: add sooptcopyinptr to preserve pointer provenance
Wed, Jul 1, 11:50 AM
brooks committed rG7f55dbe6ae89: CHERI: declare mem{cpy,move}_data (authored by brooks).
CHERI: declare mem{cpy,move}_data
Wed, Jul 1, 11:50 AM
brooks closed D57965: CHERI: make mem{cpy,move}(9) CHERI compatible.
Wed, Jul 1, 11:49 AM
brooks closed D57665: CHERI: add sooptcopyinptr to preserve pointer provenance.
Wed, Jul 1, 11:49 AM
brooks closed D57662: CHERI: add mem{cpy,move}_data.
Wed, Jul 1, 11:49 AM
brooks added inline comments to D55956: arm64: Add PROT_MTE to mmap.
Wed, Jul 1, 11:31 AM

Tue, Jun 30

brooks added a comment to D33964: proc: Use more appropriate types for KERN_PROC_VM_LAYOUT.

An old diff. Is ptraddr_t the right type here?

If you used ptraddr_t you'd have to restore the compat32 support since it is in practice size_t. This seems like a good use of kvaddr_t.

kib already pointed out that kvaddr_t seems like the wrong type since the sysctl is exporting user addresses.

Tue, Jun 30, 7:39 PM
brooks added a comment to D33964: proc: Use more appropriate types for KERN_PROC_VM_LAYOUT.

An old diff. Is ptraddr_t the right type here?

If you used ptraddr_t you'd have to restore the compat32 support since it is in practice size_t. This seems like a good use of kvaddr_t.

Tue, Jun 30, 4:38 PM
brooks added a comment to D33964: proc: Use more appropriate types for KERN_PROC_VM_LAYOUT.

An old diff. Is ptraddr_t the right type here?

Tue, Jun 30, 4:36 PM
brooks updated the diff for D57662: CHERI: add mem{cpy,move}_data.

Move _data implementation to libkern/memcpy_data. Move cherification of memmove to D57965.

Tue, Jun 30, 1:39 PM
brooks requested review of D57965: CHERI: make mem{cpy,move}(9) CHERI compatible.
Tue, Jun 30, 1:38 PM
brooks added a comment to D57662: CHERI: add mem{cpy,move}_data.

I'm going to further decompose this review to pull the cherification of memmove into it's own commit.

Tue, Jun 30, 12:19 PM

Mon, Jun 29

brooks added inline comments to D57662: CHERI: add mem{cpy,move}_data.
Mon, Jun 29, 4:28 PM
brooks committed rGa1c52e05f571: CHERI: declare fueptr and suptr (authored by brooks).
CHERI: declare fueptr and suptr
Mon, Jun 29, 1:02 PM
brooks committed rGb517edb8deed: CHERI: declare copy{in,out}ptr{,_nofault} (authored by brooks).
CHERI: declare copy{in,out}ptr{,_nofault}
Mon, Jun 29, 1:02 PM
brooks closed D57664: CHERI: declare fueptr and suptr.
Mon, Jun 29, 1:02 PM
brooks closed D57663: CHERI: declare copy{in,out}ptr{,_nofault}.
Mon, Jun 29, 1:02 PM
brooks updated the diff for D57662: CHERI: add mem{cpy,move}_data.

Clarify which pointers provenance is preserved

Mon, Jun 29, 12:33 PM
brooks updated the diff for D57662: CHERI: add mem{cpy,move}_data.

Simplify C implementation of mem{cpy,move}.

Mon, Jun 29, 12:32 PM

Fri, Jun 26

brooks committed rGb207b1562a2f: sys/systm.h: use __nodiscard consistently and correctly (authored by brooks).
sys/systm.h: use __nodiscard consistently and correctly
Fri, Jun 26, 4:49 PM
brooks committed rG2515e3f6776a: cdefs(9): encourage __nodiscard over __result_use_check (authored by brooks).
cdefs(9): encourage __nodiscard over __result_use_check
Fri, Jun 26, 4:49 PM
brooks closed D57881: cdefs(9): encourage __nodiscard over __result_use_check.
Fri, Jun 26, 4:48 PM
brooks closed D57882: sys/systm.h: use __nodiscard consistently and correctly.
Fri, Jun 26, 4:48 PM
brooks updated the diff for D57663: CHERI: declare copy{in,out}ptr{,_nofault}.

Use __nodiscard

Fri, Jun 26, 12:57 PM
brooks updated the diff for D57881: cdefs(9): encourage __nodiscard over __result_use_check.

Fix typo

Fri, Jun 26, 12:21 PM
brooks updated the diff for D57664: CHERI: declare fueptr and suptr.

Use __nodiscard

Fri, Jun 26, 12:18 PM
brooks requested review of D57882: sys/systm.h: use __nodiscard consistently and correctly.
Fri, Jun 26, 12:16 PM
brooks requested review of D57881: cdefs(9): encourage __nodiscard over __result_use_check.
Fri, Jun 26, 12:16 PM
brooks committed rG1366a87c9cb5: memory_model(7): create and document pointer provenance (authored by brooks).
memory_model(7): create and document pointer provenance
Fri, Jun 26, 11:26 AM
brooks closed D57812: memory_model(7): create and document pointer provenance.
Fri, Jun 26, 11:26 AM

Thu, Jun 25

brooks added inline comments to D57812: memory_model(7): create and document pointer provenance.
Thu, Jun 25, 4:59 PM
brooks updated the diff for D57812: memory_model(7): create and document pointer provenance.

Fix headers. Mention that one past the end is permitted.

Thu, Jun 25, 4:44 PM
brooks abandoned D57849: memory_model(7): create and document pointer provenance.

Created by accident. I blame the heat

Thu, Jun 25, 4:43 PM
brooks requested review of D57849: memory_model(7): create and document pointer provenance.
Thu, Jun 25, 4:42 PM
brooks updated the diff for D57662: CHERI: add mem{cpy,move}_data.

fix typo

Thu, Jun 25, 3:17 PM
brooks updated the diff for D57665: CHERI: add sooptcopyinptr to preserve pointer provenance.

Be clear that sooptcopyoutptr is missing because it makes no sense

Thu, Jun 25, 10:48 AM
brooks updated the diff for D57664: CHERI: declare fueptr and suptr.

Fix some manpage nits

Thu, Jun 25, 10:41 AM
brooks updated subscribers of D57663: CHERI: declare copy{in,out}ptr{,_nofault}.
Thu, Jun 25, 10:38 AM
brooks updated the diff for D57663: CHERI: declare copy{in,out}ptr{,_nofault}.

Doc fixes. Add copyinptr_nofault

Thu, Jun 25, 10:36 AM
brooks retitled D57663: CHERI: declare copy{in,out}ptr{,_nofault} from CHERI: declare copy{in,out}ptr and copyoutptr_nofault to CHERI: declare copy{in,out}ptr{,_nofault}.
Thu, Jun 25, 10:36 AM
brooks added inline comments to D57662: CHERI: add mem{cpy,move}_data.
Thu, Jun 25, 10:22 AM
brooks updated the diff for D57662: CHERI: add mem{cpy,move}_data.

Address feedback, switch references to memory_model.7

Thu, Jun 25, 10:22 AM
brooks updated the diff for D57812: memory_model(7): create and document pointer provenance.

Move contents to a new memory_model.7

Thu, Jun 25, 10:19 AM
brooks retitled D57812: memory_model(7): create and document pointer provenance from arch.7: discuss pointer provenance to memory_model(7): create and document pointer provenance.
Thu, Jun 25, 10:17 AM
brooks committed rGb94f43890645: Add kernel manpages for bcopy, memcpy, and memmove (authored by brooks).
Add kernel manpages for bcopy, memcpy, and memmove
Thu, Jun 25, 10:09 AM
brooks committed rG00b0ea95dfb3: arch.7: used title case for .Ss headings (authored by brooks).
arch.7: used title case for .Ss headings
Thu, Jun 25, 10:08 AM
brooks closed D57661: Add kernel manpages for bcopy, memcpy, and memmove.
Thu, Jun 25, 10:08 AM
brooks closed D57820: arch.7: used title case for .Ss headings.
Thu, Jun 25, 10:08 AM
brooks updated the diff for D57812: memory_model(7): create and document pointer provenance.

Rework intro text.

Thu, Jun 25, 10:07 AM

Wed, Jun 24

brooks added a comment to D57661: Add kernel manpages for bcopy, memcpy, and memmove.

Could we also put some sbom tags?

Wed, Jun 24, 8:16 PM
brooks added inline comments to D57812: memory_model(7): create and document pointer provenance.
Wed, Jun 24, 2:53 PM
brooks updated the diff for D57812: memory_model(7): create and document pointer provenance.

Use title case, rebase on D57820

Wed, Jun 24, 2:51 PM
brooks requested review of D57820: arch.7: used title case for .Ss headings.
Wed, Jun 24, 2:51 PM
brooks updated the diff for D57812: memory_model(7): create and document pointer provenance.

Clarify alignment requirement somewhat

Wed, Jun 24, 2:16 PM
brooks added inline comments to D57812: memory_model(7): create and document pointer provenance.
Wed, Jun 24, 2:13 PM
brooks updated the diff for D57812: memory_model(7): create and document pointer provenance.

Fix more typos

Wed, Jun 24, 12:53 PM
brooks added inline comments to D57812: memory_model(7): create and document pointer provenance.
Wed, Jun 24, 12:31 PM
brooks updated the diff for D57812: memory_model(7): create and document pointer provenance.

Address feedback from @emaste

Wed, Jun 24, 12:28 PM
brooks added inline comments to D57662: CHERI: add mem{cpy,move}_data.
Wed, Jun 24, 10:10 AM
brooks updated the diff for D57665: CHERI: add sooptcopyinptr to preserve pointer provenance.

Link manpages to the description of pointer provenance in arch(7)

Wed, Jun 24, 10:09 AM
brooks updated the diff for D57664: CHERI: declare fueptr and suptr.

Document and link manpages to the description of pointer provenacne in arch(7)

Wed, Jun 24, 10:08 AM
brooks updated the diff for D57663: CHERI: declare copy{in,out}ptr{,_nofault}.

Link manpages to the description of pointer provenacne in arch(7)

Wed, Jun 24, 10:08 AM
brooks updated the diff for D57662: CHERI: add mem{cpy,move}_data.

Link manpages to the description of pointer provenacne in arch(7)

Wed, Jun 24, 10:08 AM
brooks requested review of D57812: memory_model(7): create and document pointer provenance.
Wed, Jun 24, 10:07 AM

Tue, Jun 23

brooks accepted D57726: sys: use curthread_pflags_set/restore to manage TDP_DEADLKTREAT for uio.

Sorry about missing the label in i386.

Tue, Jun 23, 2:24 PM

Sun, Jun 21

brooks closed D57687: pmap: prefer memcpy over bcopy.

For some reason this failed to auto close. I've manually linked rG2ee2ef607f60.

Sun, Jun 21, 5:27 PM
brooks updated the diff for D57661: Add kernel manpages for bcopy, memcpy, and memmove.

Discourage use of bcopy

Sun, Jun 21, 5:26 PM
brooks committed rG015b890e28b8: mem*.3: stop refering to strings (authored by brooks).
mem*.3: stop refering to strings
Sun, Jun 21, 4:50 PM
brooks closed D57680: mem*.3: stop refering to strings.
Sun, Jun 21, 4:50 PM
brooks committed rG8b47939b9522: uipc_socket: prefer memcpy to bcopy (authored by brooks).
uipc_socket: prefer memcpy to bcopy
Sun, Jun 21, 4:15 PM
brooks committed rGfc9b28879e89: uiomove_*: centralize the copy function selection (authored by brooks).
uiomove_*: centralize the copy function selection
Sun, Jun 21, 4:15 PM
brooks committed rG2ee2ef607f60: pmap: prefer memcpy over bcopy (authored by brooks).
pmap: prefer memcpy over bcopy
Sun, Jun 21, 4:15 PM
brooks closed D57689: uipc_socket: prefer memcpy to bcopy.
Sun, Jun 21, 4:15 PM
brooks closed D57688: uiomove_*: centralize the copy function selection.
Sun, Jun 21, 4:15 PM

Sat, Jun 20

brooks updated the diff for D57688: uiomove_*: centralize the copy function selection.

Drop gotos.

Sat, Jun 20, 8:33 PM
brooks updated the diff for D57688: uiomove_*: centralize the copy function selection.

Fix sfbuf and transient map leaks

Sat, Jun 20, 7:44 PM
brooks updated the diff for D57665: CHERI: add sooptcopyinptr to preserve pointer provenance.

use memcpy_data

Sat, Jun 20, 5:12 PM
brooks retitled D57662: CHERI: add mem{cpy,move}_data from CHERI: add mem{cpy,move}_data and bcopy_data to CHERI: add mem{cpy,move}_data.
Sat, Jun 20, 5:07 PM
brooks updated the diff for D57662: CHERI: add mem{cpy,move}_data.

Drop bcopy_data

Sat, Jun 20, 3:43 PM
brooks updated the diff for D57688: uiomove_*: centralize the copy function selection.
  • Rename to uiomove_step to move to subr_uio.c
  • Pass struct uio * as the last argument (similar to other functions) instead of separate segflg and rw arguments
Sat, Jun 20, 2:18 PM
brooks added a comment to D57687: pmap: prefer memcpy over bcopy.
In D57687#1322718, @kib wrote:

amd64 is fine, but there are tons of bcopy use in amd64/amd64/*.c. Why is it fine for them to stay with bcopy? Or put it differently, why amd64 is affected at all?

Sat, Jun 20, 1:44 PM

Fri, Jun 19

brooks added a comment to D57688: uiomove_*: centralize the copy function selection.

With CHERI we'll be adding to variants of UIO_READ/UIO_WRITE that preserved pointer provenance and centralizing the definitions will make adding that a lot cleaner.

Fri, Jun 19, 9:31 PM
brooks requested review of D57689: uipc_socket: prefer memcpy to bcopy.
Fri, Jun 19, 9:28 PM
brooks requested review of D57688: uiomove_*: centralize the copy function selection.
Fri, Jun 19, 9:27 PM
brooks requested review of D57687: pmap: prefer memcpy over bcopy.
Fri, Jun 19, 9:27 PM
brooks added a reviewer for D57680: mem*.3: stop refering to strings: manpages.
Fri, Jun 19, 7:57 PM
brooks updated the summary of D57680: mem*.3: stop refering to strings.
Fri, Jun 19, 7:57 PM
brooks added a comment to D57661: Add kernel manpages for bcopy, memcpy, and memmove.

Created D57680 to follow POSIX/C's lead and stop talking about strings in mem* functions.

Fri, Jun 19, 7:29 PM
brooks updated the diff for D57662: CHERI: add mem{cpy,move}_data.

Rebase after removing references to strings in base manpages

Fri, Jun 19, 7:27 PM