Page MenuHomeFreeBSD

brooks (Brooks Davis)
User

Projects

User Details

User Since
Jul 1 2014, 6:02 PM (439 w, 2 d)

Recent Activity

Today

brooks committed R11:bae4ebdcf9c2: llvm-{cheri,morello}: don't install std*.h (authored by brooks).
llvm-{cheri,morello}: don't install std*.h
Fri, Dec 2, 12:39 AM
brooks committed R11:0fcc3df567bf: devel/llvm15: Update to 15.0.6 (authored by brooks).
devel/llvm15: Update to 15.0.6
Fri, Dec 2, 12:39 AM

Tue, Nov 29

brooks added a comment to D37540: rpcgen: Don't free() a pointer after realloc()..

I wonder how this ever worked.

Maybe in practice the first allocation setting argmax to 32 ends up being sufficient?

Tue, Nov 29, 9:11 PM
brooks accepted D37540: rpcgen: Don't free() a pointer after realloc()..
Tue, Nov 29, 7:57 PM
brooks accepted D37531: Explicitly set CXXSTD to c++11 for old C++ code using std::auto_ptr<>..
Tue, Nov 29, 7:56 PM
brooks committed R11:8fc9ee02cc73: devel/llvm-devel: fix packaging without FLANG option (authored by brooks).
devel/llvm-devel: fix packaging without FLANG option
Tue, Nov 29, 7:00 PM
brooks accepted D37499: csh: install hard link with same mode as target.

I do wonder if /.cshrc should survive the pkgbase transition.

Tue, Nov 29, 6:21 PM

Mon, Nov 28

brooks committed R11:70f69fa039be: devel/llvm-devel: update to a new snapshot (authored by brooks).
devel/llvm-devel: update to a new snapshot
Mon, Nov 28, 11:28 PM

Mon, Nov 21

brooks accepted D37456: Move obj-tools and obj-kernel-tools up one level.

I like the idea of moving in this direction.

Mon, Nov 21, 9:11 PM

Wed, Nov 16

brooks accepted D37413: libcompat: avoid installing include files.

Seems reasonable. I'd probably put the addition on a separate line.

Wed, Nov 16, 10:29 PM
brooks committed R11:ed493ba103f8: devel/llvm15: Update to 15.0.5 (authored by brooks).
devel/llvm15: Update to 15.0.5
Wed, Nov 16, 7:52 PM
brooks committed rG61b146ba43cd: Check alignment of fp in unwind_frame (authored by Dapeng Gao <dapeng@dpgao.cn>).
Check alignment of fp in unwind_frame
Wed, Nov 16, 6:32 PM
brooks closed D34646: Check alignment of `fp` in `unwind_frame`.
Wed, Nov 16, 6:31 PM

Tue, Nov 15

brooks closed D34646: Check alignment of `fp` in `unwind_frame`.
Tue, Nov 15, 12:26 AM
brooks committed rG40e0fa10f58d: Check alignment of fp in unwind_frame (authored by Dapeng Gao <dapeng@dpgao.cn>).
Check alignment of fp in unwind_frame
Tue, Nov 15, 12:26 AM

Mon, Nov 14

brooks committed R11:8fc659e4124b: devel/llvm-devel: fix plist w/o FLANG option (authored by brooks).
devel/llvm-devel: fix plist w/o FLANG option
Mon, Nov 14, 6:42 PM

Wed, Nov 9

brooks committed R11:f9809df4c15f: devel/ksh93: remove sbrk() use (authored by brooks).
devel/ksh93: remove sbrk() use
Wed, Nov 9, 9:27 PM
brooks closed D37312: devel/ksh93: remove sbrk() use.
Wed, Nov 9, 9:27 PM
brooks committed R11:1b29ddc70408: devel/llvm-devel: update to a new snapshot (authored by brooks).
devel/llvm-devel: update to a new snapshot
Wed, Nov 9, 9:27 PM
brooks added a comment to D37312: devel/ksh93: remove sbrk() use.

@brooks Submit it upstream if applicable?

Wed, Nov 9, 5:06 PM
brooks added a comment to D37312: devel/ksh93: remove sbrk() use.

I've tested this as far as running the built ksh trivially and aarch64. Unfortunately make test blew up with a mktemp usage error that I've not dug into yet.

Wed, Nov 9, 12:00 AM

Tue, Nov 8

brooks requested review of D37312: devel/ksh93: remove sbrk() use.
Tue, Nov 8, 11:58 PM

Mon, Nov 7

brooks committed R11:4a1ebb41252c: devel/llvm-cheri: update to a new snapshot (authored by brooks).
devel/llvm-cheri: update to a new snapshot
Mon, Nov 7, 7:18 PM
brooks committed R11:d13060b3844d: devel/llvm-morello: Update to a new snapshot (authored by brooks).
devel/llvm-morello: Update to a new snapshot
Mon, Nov 7, 7:18 PM
brooks committed R11:6530eff00d19: devel/llvm15: update to 15.0.4 (authored by brooks).
devel/llvm15: update to 15.0.4
Mon, Nov 7, 7:18 PM

Oct 25 2022

brooks accepted D37111: Use `rm -fv` for BATCH_DELETE_OLD_FILES.

Seems generally reasonable. Do we need to check afterwards to warn if they were not deleted?

Oct 25 2022, 2:54 AM

Oct 18 2022

brooks accepted D37036: libc: Make elf_aux_info() return an error if AT_USRSTACK* is undefined.
Oct 18 2022, 8:59 PM
brooks committed R11:c908e85a9031: devel/llvm15: Update to 15.0.3 (authored by brooks).
devel/llvm15: Update to 15.0.3
Oct 18 2022, 8:38 PM

Oct 5 2022

brooks accepted D36830: rs: Fix various harmless warnings..
Oct 5 2022, 6:02 PM
brooks committed rGc3fb59ed5c5f: libc: Include quad support on long32 ABIs (authored by brooks).
libc: Include quad support on long32 ABIs
Oct 5 2022, 4:30 PM
brooks committed rG426fc376afaf: bsd.cpu.mk: Introduce MACHINE_ABI (authored by brooks).
bsd.cpu.mk: Introduce MACHINE_ABI
Oct 5 2022, 4:30 PM
brooks committed rG77becb932575: Rename MACHINE_ABI and TARGET_ABI (authored by brooks).
Rename MACHINE_ABI and TARGET_ABI
Oct 5 2022, 4:30 PM
brooks committed rGd701f45aba19: Remove telnetd sources (authored by brooks).
Remove telnetd sources
Oct 5 2022, 4:30 PM
brooks closed D36422: libc: Include quad support on long32 ABIs.
Oct 5 2022, 4:30 PM
brooks closed D36421: Introduce MACHINE_ABI as a list of ABI properties.
Oct 5 2022, 4:30 PM
brooks closed D36420: Rename MACHINE_ABI and TARGET_ABI.
Oct 5 2022, 4:30 PM
brooks closed D36621: Remove telnetd sources.
Oct 5 2022, 4:29 PM
brooks committed R11:2cbfc9c923be: devel/llvm15: Update to 15.0.2 release (authored by brooks).
devel/llvm15: Update to 15.0.2 release
Oct 5 2022, 3:39 AM

Oct 3 2022

brooks added a comment to D36525: Add git-blame ignore file.

I think I lean toward "add them when their absence is annoying" as an initial policy. It might be worth some experiments to see if the result of adding all whitespace-only commits is measurable though.

Oct 3 2022, 9:49 PM
brooks committed R11:8116e50f1de0: devel/llvm-morello: 2022-10-03 snapshot (authored by brooks).
devel/llvm-morello: 2022-10-03 snapshot
Oct 3 2022, 9:31 PM
brooks committed R11:d2c4dc699434: devel/llvm-cheri: 2022-10-03 snapshot (authored by brooks).
devel/llvm-cheri: 2022-10-03 snapshot
Oct 3 2022, 9:31 PM
brooks committed rG0a1a1699c361: bsdbox: remove previously broken telnet(d) support (authored by brooks).
bsdbox: remove previously broken telnet(d) support
Oct 3 2022, 5:26 PM
brooks committed rGf6ce8414ebdd: bsdbox: remove previously broken telnet(d) support (authored by brooks).
bsdbox: remove previously broken telnet(d) support
Oct 3 2022, 5:26 PM

Sep 30 2022

brooks closed D36620: Remove telnetd.

Committed in rG0eea46fb1f83f. It's unclear to me why this didn't close...

Sep 30 2022, 9:01 PM
brooks added a comment to D36620: Remove telnetd.

Could you list deprecation/removal here please: https://wiki.freebsd.org/DeprecationPlan

Sep 30 2022, 8:59 PM

Sep 29 2022

brooks accepted D36835: rs: Test actual output in the tests..

This change is what was supposed to happen with the generated smoke test. Too bad it's the first case I can think of in about 5 years...

Sep 29 2022, 11:31 PM
brooks accepted D36834: rs: Use getopt() and strtol() instead of mannual parsing..
Sep 29 2022, 11:27 PM
brooks accepted D36833: rs: Convert to C++ to convert elem to a std::vector<char *>..
Sep 29 2022, 11:20 PM
brooks accepted D36832: rs: Fix some pointer arith UB..
Sep 29 2022, 11:06 PM
brooks accepted D36831: rs: Fix a use after free..

The "you can't even do math" thing always seems excessive, but if gcc is going to warn on it then at least it will clean up all the CHERI realloc issues.

Sep 29 2022, 10:57 PM
brooks added inline comments to D36830: rs: Fix various harmless warnings..
Sep 29 2022, 10:53 PM
brooks committed R11:547397723678: devel/llvm-devel: new snapshot (authored by brooks).
devel/llvm-devel: new snapshot
Sep 29 2022, 10:49 PM
brooks committed R11:4ca5c8c042c7: devel/llvm-devel: rename ignorelist dir variable (NFC) (authored by brooks).
devel/llvm-devel: rename ignorelist dir variable (NFC)
Sep 29 2022, 10:48 PM
brooks committed R11:bf050595e31d: devel/llvm-devel: deduplicate information (NFC) (authored by brooks).
devel/llvm-devel: deduplicate information (NFC)
Sep 29 2022, 10:48 PM
brooks committed R11:a3c9588e81dd: devel/llvm-devel: simplify option declerations (NFC) (authored by brooks).
devel/llvm-devel: simplify option declerations (NFC)
Sep 29 2022, 10:48 PM
brooks committed R11:38c131e44225: devel/llvm-devel: use PLIST_FILES for GOLD (NFC) (authored by brooks).
devel/llvm-devel: use PLIST_FILES for GOLD (NFC)
Sep 29 2022, 10:48 PM
brooks committed rGf2aa49e7fda5: telnetd: fix two-byte input crash (authored by brooks).
telnetd: fix two-byte input crash
Sep 29 2022, 10:37 PM
brooks committed rG6abdfd389044: telnetd: fix two-byte input crash (authored by brooks).
telnetd: fix two-byte input crash
Sep 29 2022, 10:36 PM
brooks accepted D36805: bsdinstall release: Start installer on multiple consoles.
Sep 29 2022, 10:28 PM
brooks accepted D36803: bsdinstall release: Move code to a new startbsdinstall wrapper.
Sep 29 2022, 10:26 PM
brooks accepted D36587: release: Remove remnants of pc98 support.
Sep 29 2022, 10:20 PM
brooks accepted D36804: bsdinstall: Add a new runconsoles helper binary.

Not sure I've followed all the signal details, but I understand the basic design and it makes sense to me.

Sep 29 2022, 10:20 PM
brooks committed rGb4cfdbfed2c8: manpages: Remove telnetd references (authored by brooks).
manpages: Remove telnetd references
Sep 29 2022, 4:57 PM
brooks committed rG76aebeab7c04: targets: libexec/telnetd no longer exists (authored by brooks).
targets: libexec/telnetd no longer exists
Sep 29 2022, 4:57 PM
brooks committed rG75c2975ac48e: release: the telnet package contains the client (authored by brooks).
release: the telnet package contains the client
Sep 29 2022, 4:57 PM
brooks committed rGc0f94ccbb241: bsdbox: remove previously broken telnet(d) support (authored by brooks).
bsdbox: remove previously broken telnet(d) support
Sep 29 2022, 4:57 PM
brooks committed rGedb522624887: inetd.conf: update telnetd paths (authored by brooks).
inetd.conf: update telnetd paths
Sep 29 2022, 4:57 PM
brooks closed D36785: manpages: Remove telnetd references.
Sep 29 2022, 4:57 PM
brooks closed D36784: release: the telnet package contains the client.
Sep 29 2022, 4:57 PM
brooks closed D36783: inetd.conf: update telnetd paths.
Sep 29 2022, 4:57 PM
brooks closed D36782: bsdbox: remove previously broken telnetd support.
Sep 29 2022, 4:57 PM
brooks added inline comments to D36785: manpages: Remove telnetd references.
Sep 29 2022, 4:53 PM

Sep 28 2022

brooks retitled D36785: manpages: Remove telnetd references from manpges: Remove telnetd references to manpages: Remove telnetd references.
Sep 28 2022, 11:09 PM
brooks updated the diff for D36785: manpages: Remove telnetd references.

Restore a couple more important references adding a reference to the
port. This follows existing inetd.8 practice.

Sep 28 2022, 11:09 PM
brooks requested review of D36785: manpages: Remove telnetd references.
Sep 28 2022, 9:52 PM
brooks requested review of D36784: release: the telnet package contains the client.
Sep 28 2022, 9:52 PM
brooks requested review of D36783: inetd.conf: update telnetd paths.
Sep 28 2022, 9:52 PM
brooks requested review of D36782: bsdbox: remove previously broken telnetd support.
Sep 28 2022, 9:51 PM
brooks committed rG9bbed3f615f1: Mention telnetd removal (authored by brooks).
Mention telnetd removal
Sep 28 2022, 7:08 PM
brooks committed rG0eea46fb1f83: Remove telnetd (authored by brooks).
Remove telnetd
Sep 28 2022, 6:54 PM
brooks committed R11:549225619e86: devel/llvm15: Fix plist without EXTRAS (authored by brooks).
devel/llvm15: Fix plist without EXTRAS
Sep 28 2022, 5:38 PM

Sep 27 2022

brooks updated the diff for D36420: Rename MACHINE_ABI and TARGET_ABI.
  • Drop UPDATING entry
Sep 27 2022, 11:49 PM
brooks updated the diff for D36421: Introduce MACHINE_ABI as a list of ABI properties.

Add missing guard on CPUTYPE

Sep 27 2022, 6:24 PM
brooks updated the diff for D36421: Introduce MACHINE_ABI as a list of ABI properties.
  • Add endian
Sep 27 2022, 5:52 PM

Sep 26 2022

brooks committed rG327705fbba74: cpuset(9): Refer to CPU_SETSIZE not MAXCPU (authored by brooks).
cpuset(9): Refer to CPU_SETSIZE not MAXCPU
Sep 26 2022, 6:16 PM
brooks committed rG616b1b813891: Deprecate telnet daemon (authored by brooks).
Deprecate telnet daemon
Sep 26 2022, 6:16 PM
brooks committed rG87767249233f: cpuset(9): Refer to CPU_SETSIZE not MAXCPU (authored by brooks).
cpuset(9): Refer to CPU_SETSIZE not MAXCPU
Sep 26 2022, 6:13 PM
brooks committed rG99b5212a2ff8: Deprecate telnet daemon (authored by brooks).
Deprecate telnet daemon
Sep 26 2022, 6:13 PM
brooks closed D36680: telnetd: fix two-byte input crash.
Sep 26 2022, 5:58 PM
brooks committed rG6914ffef4e23: telnetd: fix two-byte input crash (authored by brooks).
telnetd: fix two-byte input crash
Sep 26 2022, 5:58 PM
brooks added a comment to D36680: telnetd: fix two-byte input crash.
In D36680#832953, @cy wrote:

Next question. I maintain the extract of the FreeBSD telnet/telnetd on GH, of which telnetd is a port while telnet is in the repo should we choose to remove it as well. I've been toying with the idea of telnet and telnetd ports based on NetBSD. They will probably pay more attention to it than we might. Thoughts?

Sep 26 2022, 5:01 PM
brooks added a comment to D36680: telnetd: fix two-byte input crash.
In D36680#832950, @cy wrote:

There's also a fix for CVE-2020-10188 (https://github.com/cschuber/freebsd-telnet/commit/e76b51e91f6d9aa7b72ee6624c29b46ddce2a406). Do you want to commit that or should I?

Sep 26 2022, 4:58 PM

Sep 23 2022

brooks committed rG8232a1eddadd: cpuset(9): Refer to CPU_SETSIZE not MAXCPU (authored by brooks).
cpuset(9): Refer to CPU_SETSIZE not MAXCPU
Sep 23 2022, 8:21 PM
brooks closed D36679: cpuset(9): Refer to CPU_SETSIZE not MAXCPU.
Sep 23 2022, 8:21 PM
brooks requested review of D36680: telnetd: fix two-byte input crash.
Sep 23 2022, 6:05 PM
brooks requested review of D36679: cpuset(9): Refer to CPU_SETSIZE not MAXCPU.
Sep 23 2022, 6:01 PM

Sep 22 2022

brooks accepted D36668: Track removal of Tokenring and FDDI media types from devd.cc..

Oops. Thanks for the fix. I'll try to remember to remove ATM when I finish removing the (useless) support.

Sep 22 2022, 9:35 PM

Sep 21 2022

brooks committed R11:91c455fae14e: devel/llvm-devel: update to a new version (authored by brooks).
devel/llvm-devel: update to a new version
Sep 21 2022, 9:03 PM
brooks committed R11:70ba510bcb2a: devel/llvm-devel: enable COMPILER_RT on aarch64 (authored by brooks).
devel/llvm-devel: enable COMPILER_RT on aarch64
Sep 21 2022, 9:03 PM
brooks committed rG24e1824e4646: Deprecate telnet daemon (authored by brooks).
Deprecate telnet daemon
Sep 21 2022, 3:18 PM