Page MenuHomeFreeBSD
Differential D55307

stddef.h: centralize definition of offsetof()
ClosedPublic
Actions

Authored by brooks on Mon, Feb 16, 1:49 PM.
Tags
None
Referenced Files
F147307522: D55307.diff
Mon, Mar 9, 8:25 PM
Unknown Object (File)
Sat, Mar 7, 10:01 PM
Unknown Object (File)
Thu, Mar 5, 3:43 AM
Unknown Object (File)
Wed, Mar 4, 10:23 AM
Unknown Object (File)
Wed, Mar 4, 10:23 AM
Unknown Object (File)
Mon, Mar 2, 12:06 PM
Unknown Object (File)
Mon, Mar 2, 10:46 AM
Unknown Object (File)
Mon, Mar 2, 10:27 AM
View All 17 Files
Subscribers
imp

Details

Reviewers
kib
imp
Group Reviewers
cheri
Commits
rG2adc3f0db187: stddef.h: centralize definition of offsetof()
Summary

Move to sys/_offsetof.h and use builtin_offsetof() instead of
offsetof to avoid reintroducing sys/cdefs.h polution in stddef.h.




This has the side effect of allowing sys/stddef.h to be included after

stddef.h which can happen in compatability headers.



Effort:         CHERI upstreaming

Sponsored by:   DARPA, AFRL
Diff Detail
Repository 
rG FreeBSD src repository 
Lint 
Lint Not Applicable
 
Unit 
Tests Not Applicable
 
Event Timeline
brooks created this revision.Mon, Feb 16, 1:49 PM
Herald added a subscriber: imp.  ·  View Herald TranscriptMon, Feb 16, 1:49 PM
brooks requested review of this revision.Mon, Feb 16, 1:49 PM
brooks added a child revision: D55308: build: add stddef.h to define ptraddr_t as required.
Harbormaster completed remote builds in B70696: Diff 171969.Mon, Feb 16, 1:50 PM
brooks added a parent revision: D55305: stddef.h: add ptraddr_t.Mon, Feb 16, 1:50 PM
kib accepted this revision.Mon, Feb 16, 2:32 PM
The change by itself is fine.



This is a related comment.  sys/stddef.h definition for offsetof() uses offsetof() instead of builtin_offsetof().  Then, should we have e.g. sys/_offsetof.h with include guard, then this issue would be handled automatically?
This revision is now accepted and ready to land.Mon, Feb 16, 2:32 PM
brooks retitled this revision from sys/stddef.h: guard offsetof definition to stddef.h: centralize definition of offsetof().Wed, Feb 18, 2:39 PM
brooks edited the summary of this revision. (Show Details)
Herald added a reviewer: cheri.  ·  View Herald TranscriptWed, Feb 18, 2:39 PM
brooks updated this revision to Diff 172151.Wed, Feb 18, 2:40 PM
centralize definition
This revision now requires review to proceed.Wed, Feb 18, 2:40 PM
Harbormaster completed remote builds in B70749: Diff 172151.Wed, Feb 18, 2:40 PM
kib accepted this revision.Wed, Feb 18, 2:58 PM
This revision is now accepted and ready to land.Wed, Feb 18, 2:58 PM
imp accepted this revision.Wed, Feb 18, 4:34 PM
Closed by commit rG2adc3f0db187: stddef.h: centralize definition of offsetof() (authored by brooks).  ·  Explain WhyThu, Feb 19, 3:11 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG2adc3f0db187: stddef.h: centralize definition of offsetof().
Revision Contents
Changeset List
PathSize
include/
5 lines
sys/
sys/
19 lines
3 lines
Diff 172237
View Options
include/stddef.h
Loading...
View Options
sys/sys/_offsetof.h
Loading...
View Options
sys/sys/stddef.h
Loading...