sys/stddef.h: guard offsetof definition
AcceptedPublic
Actions

Authored by brooks on Mon, Feb 16, 1:49 PM.

Details

Reviewers

Summary

Without this, including sys/stddef.h after stddef.h can trigger a
warning which may become an error. This isn't something FreeBSD code
should do, but it does happen sometimes with compatibility headers so
support it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 70696
Build 67579: arc lint + arc unit

Event Timeline

brooks created this revision.Mon, Feb 16, 1:49 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Feb 16, 1:49 PM

brooks requested review of this revision.Mon, Feb 16, 1:49 PM

brooks added a child revision: D55308: build: add stddef.h to define ptraddr_t as required.

Harbormaster completed remote builds in B70696: Diff 171969.Mon, Feb 16, 1:50 PM

brooks added a parent revision: D55305: stddef.h: add ptraddr_t.Mon, Feb 16, 1:50 PM

The change by itself is fine.

This is a related comment. sys/stddef.h definition for offsetof() uses offsetof() instead of builtin_offsetof(). Then, should we have e.g. sys/_offsetof.h with include guard, then this issue would be handled automatically?

This revision is now accepted and ready to land.Mon, Feb 16, 2:32 PM

Revision Contents
Changeset List

Path

Size

sys/

stddef.h

2 lines

Diff 171969

View Options

sys/stddef.h: guard offsetof definitionAcceptedPublicActions