Page MenuHomeFreeBSD

jrtc27 (Jessica Clarke)
User

Projects

User Details

User Since
Jul 4 2018, 7:23 PM (221 w, 6 d)

Recent Activity

Today

jrtc27 requested review of D36879: bsdinstall: Fix race condition when shutting down after installation.
Wed, Oct 5, 2:29 AM

Yesterday

jrtc27 added a comment to D36876: riscv: handle misaligned address exceptions.

In theory these should be impossible[1] because firmware is meant to emulate them when not supported. There's nothing wrong with being prepared to handle cases where they aren't emulated but I'm curious in what situations they occur. Maybe misaligned atomics, which can't be safely emulated?

Tue, Oct 4, 4:26 PM

Mon, Oct 3

jrtc27 closed D36845: etcupdate: Fix -N support for build command.
Mon, Oct 3, 4:17 PM
jrtc27 committed rGe571b0f8f8c1: etcupdate: Fix -N support for build command (authored by jrtc27).
etcupdate: Fix -N support for build command
Mon, Oct 3, 4:17 PM
jrtc27 committed rGa09af1b7fd95: bsdinstall release: Start installer on multiple consoles (authored by jrtc27).
bsdinstall release: Start installer on multiple consoles
Mon, Oct 3, 4:10 PM
jrtc27 committed rGd577d6178bde: bsdinstall release: Move code to a new startbsdinstall wrapper (authored by jrtc27).
bsdinstall release: Move code to a new startbsdinstall wrapper
Mon, Oct 3, 4:10 PM
jrtc27 committed rGa2464ee12761: bsdinstall: Add a new runconsoles helper binary (authored by jrtc27).
bsdinstall: Add a new runconsoles helper binary
Mon, Oct 3, 4:10 PM
jrtc27 committed rGf334df76004d: release: Remove remnants of pc98 support (authored by jrtc27).
release: Remove remnants of pc98 support
Mon, Oct 3, 4:10 PM
jrtc27 closed D36805: bsdinstall release: Start installer on multiple consoles.
Mon, Oct 3, 4:10 PM
jrtc27 closed D36803: bsdinstall release: Move code to a new startbsdinstall wrapper.
Mon, Oct 3, 4:10 PM
jrtc27 closed D36804: bsdinstall: Add a new runconsoles helper binary.
Mon, Oct 3, 4:10 PM
jrtc27 closed D36587: release: Remove remnants of pc98 support.
Mon, Oct 3, 4:10 PM

Fri, Sep 30

jrtc27 requested review of D36845: etcupdate: Fix -N support for build command.
Fri, Sep 30, 7:53 PM
jrtc27 added a comment to D36804: bsdinstall: Add a new runconsoles helper binary.

So we run multiple copies of the installer, and kill all of them when one finishes? I'd have a slight worry about someone "starting over" on a different tty than the one they started on, but I'd still think this is a usability improvement over the status quo

Fri, Sep 30, 4:16 PM
jrtc27 updated the diff for D36805: bsdinstall release: Start installer on multiple consoles.

BSD-2-Clause not -FreeBSD, despite ~everything in the tree getting this wrong

Fri, Sep 30, 1:18 AM
jrtc27 updated the diff for D36804: bsdinstall: Add a new runconsoles helper binary.

BSD-2-Clause not -FreeBSD, despite ~everything in the tree getting this wrong

Fri, Sep 30, 1:17 AM
jrtc27 added inline comments to D36804: bsdinstall: Add a new runconsoles helper binary.
Fri, Sep 30, 1:13 AM
jrtc27 added inline comments to D36804: bsdinstall: Add a new runconsoles helper binary.
Fri, Sep 30, 12:14 AM

Thu, Sep 29

jrtc27 added inline comments to D36504: arm,arm64: Save TLS register in mcontext_t..
Thu, Sep 29, 10:03 PM
jrtc27 requested review of D36805: bsdinstall release: Start installer on multiple consoles.
Thu, Sep 29, 9:06 PM
jrtc27 requested review of D36804: bsdinstall: Add a new runconsoles helper binary.
Thu, Sep 29, 9:05 PM
jrtc27 requested review of D36803: bsdinstall release: Move code to a new startbsdinstall wrapper.
Thu, Sep 29, 9:05 PM

Tue, Sep 27

jrtc27 added inline comments to D36504: arm,arm64: Save TLS register in mcontext_t..
Tue, Sep 27, 11:05 PM

Fri, Sep 23

jrtc27 accepted D36682: arm64: don't loop forever if first option in kern.cfg.order not available.

Ah yes I remember this issue

Fri, Sep 23, 9:04 PM

Wed, Sep 21

jrtc27 added a comment to D35901: riscv: Convert local interrupt controller to a newbus PIC.

Hi, thanks for your patience while I've been away. This series improves a lot.

Can you explain a bit further the design/organization of components after all these changes? Such as the PIC and newbus hierarchies, and how the interrupt drivers we have now will be extended or replaced by the newer ACLINT, APLIC, AMSIC, etc. I do find it a little counter-intuitive that the intc becomes the root PIC, so I'd like to understand that more.

Wed, Sep 21, 11:47 PM
jrtc27 closed D36556: sysutils/u-boot-sifive-fu740: Add upstream DTS patch for DA9063 RTC support.
Wed, Sep 21, 10:19 PM
jrtc27 committed R11:5549bc63f6aa: sysutils/u-boot-sifive-fu740: Add upstream DTS patch for DA9063 RTC support (authored by jrtc27).
sysutils/u-boot-sifive-fu740: Add upstream DTS patch for DA9063 RTC support
Wed, Sep 21, 10:19 PM

Tue, Sep 20

jrtc27 added a comment to D36635: release: Use standard mount points for arm MBR boot images.

Isn't the point that it's not just EFI, because all the MBR images are ones that have RPI firmware files?

Tue, Sep 20, 4:38 PM

Fri, Sep 16

jrtc27 added a comment to D36601: riscv: handle newer riscv,isa property strings.

The underscore isn't required before the first multi-character extension, and in fact the canonical form drops it (e.g. rv64iafdcxcheri, what we use for CheriBSD, is valid).

Okay, where can one learn the exact rules for how this ISA string is to be formatted? The device tree document Bindings/riscv/cpus.yaml is notably lacking in detail here.

Fri, Sep 16, 3:53 PM
jrtc27 added a comment to D36601: riscv: handle newer riscv,isa property strings.

i.e. probably this should also stop at [sxz] to handle the multi-letter extensions, though there's a wrinkle that older QEMU bogusly treated S and U as single-letter extensions indicating the presence of those modes. Linux has a hack to spot that specific case (if -1 isn't _ and +1 is u).

Fri, Sep 16, 3:47 PM
jrtc27 added a comment to D36601: riscv: handle newer riscv,isa property strings.

The underscore isn't required before the first multi-character extension, and in fact the canonical form drops it (e.g. rv64iafdcxcheri, what we use for CheriBSD, is valid).

Fri, Sep 16, 3:44 PM

Thu, Sep 15

jrtc27 added a comment to D36554: freebsd32: Make sendmsg match native ABI for unpadded final control message.

The API says that CMSG_SPACE should be used for msg_controllen

The example in CMSG_DATA.3 uses CMSG_LEN(). :(

Thu, Sep 15, 4:18 PM
jrtc27 committed rG7b673a2c73d0: freebsd32: Make sendmsg match native ABI for unpadded final control message (authored by jrtc27).
freebsd32: Make sendmsg match native ABI for unpadded final control message
Thu, Sep 15, 4:17 PM
jrtc27 closed D36554: freebsd32: Make sendmsg match native ABI for unpadded final control message.
Thu, Sep 15, 4:17 PM

Wed, Sep 14

jrtc27 requested review of D36587: release: Remove remnants of pc98 support.
Wed, Sep 14, 10:04 PM
jrtc27 accepted D36565: riscv: decode syscall in ddb backtrace.

Didn't know we even had this, normally not very useful as the function (or a related user/kern_foo) appears in the stack trace but I can see cases where it's not totally clear or unambiguous. Please commit the MI move separately from the riscv change though.

Wed, Sep 14, 3:21 PM
jrtc27 added a comment to D36563: riscv: handle existing mapping in pmap_enter_l2().

What if the permissions are different? Won't this still do the same? From what I can tell arm64 and x86 just add an additional bunch of conditions to the NOREPLACE check and will break+remake the mapping?

Wed, Sep 14, 2:32 PM
jrtc27 added inline comments to D36562: riscv: better CTR messages in pmap_enter_l2().
Wed, Sep 14, 2:26 PM
jrtc27 requested review of D36556: sysutils/u-boot-sifive-fu740: Add upstream DTS patch for DA9063 RTC support.
Wed, Sep 14, 1:55 AM

Tue, Sep 13

jrtc27 requested review of D36554: freebsd32: Make sendmsg match native ABI for unpadded final control message.
Tue, Sep 13, 11:19 PM
jrtc27 committed rG100f79569dbc: riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES (authored by jrtc27).
riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES
Tue, Sep 13, 4:47 PM
jrtc27 committed rG129028c79c6c: da9063_rtc: Add new driver for the Dialog Semiconductor DA9063 RTC (authored by jrtc27).
da9063_rtc: Add new driver for the Dialog Semiconductor DA9063 RTC
Tue, Sep 13, 4:47 PM
jrtc27 committed rG80466455adca: da9063_iic: Add new driver for the Dialog Semiconductor DA9063 PMIC (authored by jrtc27).
da9063_iic: Add new driver for the Dialog Semiconductor DA9063 PMIC
Tue, Sep 13, 4:47 PM
jrtc27 closed D36200: da9063_rtc: Add new driver for the Dialog Semiconductor DA9063 RTC.
Tue, Sep 13, 4:47 PM
jrtc27 closed D36201: riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES.
Tue, Sep 13, 4:47 PM
jrtc27 closed D36199: da9063_iic: Add new driver for the Dialog Semiconductor DA9063 PMIC.
Tue, Sep 13, 4:47 PM

Mon, Sep 12

jrtc27 added inline comments to D36541: stand: Remove dead store to bi_kernelname.
Mon, Sep 12, 9:58 PM
jrtc27 added inline comments to D36541: stand: Remove dead store to bi_kernelname.
Mon, Sep 12, 9:34 PM

Sep 2 2022

jrtc27 committed rG2a90c47af158: release: Set loader_menu_multi_user_prompt to "Installer" for installer (authored by jrtc27).
release: Set loader_menu_multi_user_prompt to "Installer" for installer
Sep 2 2022, 7:37 PM
jrtc27 committed rG9b17aa27406f: lualoader: Add loader_menu_multi_user_prompt config variable (authored by jrtc27).
lualoader: Add loader_menu_multi_user_prompt config variable
Sep 2 2022, 7:37 PM
jrtc27 closed D36419: release: Set loader_menu_multi_user_prompt to "Installer" for installer.
Sep 2 2022, 7:37 PM
jrtc27 closed D36418: lualoader: Add loader_menu_multi_user_prompt config variable.
Sep 2 2022, 7:37 PM

Sep 1 2022

jrtc27 added inline comments to D36421: Introduce MACHINE_ABI as a list of ABI properties.
Sep 1 2022, 10:48 PM
jrtc27 added a comment to D36418: lualoader: Add loader_menu_multi_user_prompt config variable.
In D36418#827224, @imp wrote:

I'd think that the loader_ prefix is a bit much...

Sep 1 2022, 10:44 PM
jrtc27 added inline comments to D36421: Introduce MACHINE_ABI as a list of ABI properties.
Sep 1 2022, 10:42 PM
jrtc27 added a comment to D36421: Introduce MACHINE_ABI as a list of ABI properties.

For example, i386 targets will be:
MACHINE_ARCH= hard-float long32 ptr62 time32

Sep 1 2022, 10:30 PM
jrtc27 added a comment to D36420: Rename MACHINE_ABI and TARGET_ABI.

They're not exported so they can't be being used elsewhere

Sep 1 2022, 10:29 PM
jrtc27 added a reviewer for D36418: lualoader: Add loader_menu_multi_user_prompt config variable: rpokala.
Sep 1 2022, 10:28 PM
jrtc27 requested review of D36419: release: Set loader_menu_multi_user_prompt to "Installer" for installer.
Sep 1 2022, 10:18 PM
jrtc27 requested review of D36418: lualoader: Add loader_menu_multi_user_prompt config variable.
Sep 1 2022, 10:17 PM

Aug 31 2022

jrtc27 added inline comments to D36401: libpmc: pmc_init() should avoid overflowing pmc_class_table.
Aug 31 2022, 2:39 PM

Aug 30 2022

jrtc27 added a comment to D36394: Include USB mouse driver.

I was under the impression from what you'd said it was in amd64's GENERIC but not arm64's, but that's not the case. It seems a little odd to care about a single-file USB driver that most people using their computer as a proper computer rather than a development board will want, but if it's loaded as a module on amd64 then it should be too on arm64 (or compiled in for both). It was not at all clear your problem was that you were missing modules / had incompatible ones, it sounded like your problem was that ums really needed to be in the kernel.

Aug 30 2022, 10:51 PM

Aug 22 2022

jrtc27 committed rGfba998a3d897: tools/build: Unbreak bmake bootstrap on Linux (authored by jrtc27).
tools/build: Unbreak bmake bootstrap on Linux
Aug 22 2022, 9:03 PM
jrtc27 retitled D36201: riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES from riscv: Add da9063 and da9063_rtc to GENERIC and NOTES to riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES.
Aug 22 2022, 7:28 PM
jrtc27 updated the summary of D36200: da9063_rtc: Add new driver for the Dialog Semiconductor DA9063 RTC.
Aug 22 2022, 7:28 PM
jrtc27 updated the summary of D36199: da9063_iic: Add new driver for the Dialog Semiconductor DA9063 PMIC.
Aug 22 2022, 7:28 PM
jrtc27 updated the diff for D36201: riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES.

Renamed da9063 to da9063_pmic

Aug 22 2022, 7:27 PM
jrtc27 updated the diff for D36200: da9063_rtc: Add new driver for the Dialog Semiconductor DA9063 RTC.

Renamed da9063 to da9063_pmic

Aug 22 2022, 7:27 PM
jrtc27 updated the diff for D36199: da9063_iic: Add new driver for the Dialog Semiconductor DA9063 PMIC.

Renamed da9063 to da9063_pmic and added comment header to kobj interface file

Aug 22 2022, 7:27 PM

Aug 19 2022

jrtc27 added a comment to D36184: ns8250_drain: Drain without DELAY first.

Hm, doesn't this change behaviour in the case LSR_RXRDY isn't asserted the first time round the loop? Previously we would skip the entire loop, but now you go through the delay-and-check-it's-really-zero path.

Good catch. Does it matter? I can change this but it makes the code uglier...

Aug 19 2022, 1:32 AM

Aug 18 2022

jrtc27 added inline comments to D36200: da9063_rtc: Add new driver for the Dialog Semiconductor DA9063 RTC.
Aug 18 2022, 9:29 PM
jrtc27 committed rG548f8a657bc1: tools/build: Provide fls* when cross-building on Linux (authored by jrtc27).
tools/build: Provide fls* when cross-building on Linux
Aug 18 2022, 1:47 AM
jrtc27 committed rGc6890399fc00: makefs: Fix issues building as a cross-tool on non-FreeBSD (authored by jrtc27).
makefs: Fix issues building as a cross-tool on non-FreeBSD
Aug 18 2022, 1:47 AM
jrtc27 committed rG92fc50b496ee: sys: Extract __bitcount* from sys/types.h to new sys/bitcount.h (authored by jrtc27).
sys: Extract __bitcount* from sys/types.h to new sys/bitcount.h
Aug 18 2022, 1:47 AM
jrtc27 committed rGe9ba1fd5eda2: tools/build: Provide FreeBSD's bitstring API when cross-building (authored by jrtc27).
tools/build: Provide FreeBSD's bitstring API when cross-building
Aug 18 2022, 1:47 AM
jrtc27 committed rGb0ce7dfc5e28: makefs: Fix 32-bit issues in ZFS time attributes setting (authored by jrtc27).
makefs: Fix 32-bit issues in ZFS time attributes setting
Aug 18 2022, 1:47 AM
jrtc27 closed D36134: tools/build: Provide fls* when cross-building on Linux.
Aug 18 2022, 1:47 AM
jrtc27 closed D36135: makefs: Fix issues building as a cross-tool on non-FreeBSD.
Aug 18 2022, 1:47 AM
jrtc27 closed D36132: sys: Extract __bitcount* from sys/types.h to new sys/bitcount.h.
Aug 18 2022, 1:47 AM
jrtc27 closed D36133: tools/build: Provide FreeBSD's bitstring API when cross-building.
Aug 18 2022, 1:47 AM
jrtc27 closed D36131: makefs: Fix 32-bit issues in ZFS time attributes setting.
Aug 18 2022, 1:47 AM
jrtc27 added a comment to D36201: riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES.
In D36201#821947, @imp wrote:

I'd prefer if you called it da9063_pm instead of the named name da9063. It's generally preferable that device class names end in a letter.
Though maybe it's already that way in the tree

Aug 18 2022, 1:16 AM

Aug 17 2022

jrtc27 added a comment to D36184: ns8250_drain: Drain without DELAY first.

Hm, doesn't this change behaviour in the case LSR_RXRDY isn't asserted the first time round the loop? Previously we would skip the entire loop, but now you go through the delay-and-check-it's-really-zero path.

Aug 17 2022, 12:33 AM

Aug 15 2022

jrtc27 added a comment to D36199: da9063_iic: Add new driver for the Dialog Semiconductor DA9063 PMIC.
In D36199#821842, @manu wrote:

Just wondering about the path, we don't do per-vendor directory.
We have sys/dev/iicbus/pmic, maybe da9063_iic.c should be there and the rest in a new sys/dev/pmic/dialog directory ?

Aug 15 2022, 1:04 PM

Aug 14 2022

jrtc27 committed rG762dcf106412: goldfish_rtc: Fix handling a local time RTC (authored by jrtc27).
goldfish_rtc: Fix handling a local time RTC
Aug 14 2022, 6:51 PM
jrtc27 added a comment to D36132: sys: Extract __bitcount* from sys/types.h to new sys/bitcount.h.

If it's going to take a while to figure out what a more precise copyright statement would be, can I please get this committed so we can fix building makefs as a bootstrap tool on non-FreeBSD, with the copyright adjusted as deemed fit post-commit? This is currently preventing cheribuild freebsd-<arch> from working on non-FreeBSD.

Aug 14 2022, 6:06 PM
jrtc27 updated the diff for D36200: da9063_rtc: Add new driver for the Dialog Semiconductor DA9063 RTC.

Add missing utc_offset call for the local time RTC case

Aug 14 2022, 5:56 PM
jrtc27 requested review of D36201: riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES.
Aug 14 2022, 5:34 PM
jrtc27 requested review of D36200: da9063_rtc: Add new driver for the Dialog Semiconductor DA9063 RTC.
Aug 14 2022, 5:33 PM
jrtc27 requested review of D36199: da9063_iic: Add new driver for the Dialog Semiconductor DA9063 PMIC.
Aug 14 2022, 5:33 PM
jrtc27 accepted D36198: rtld: fix display of the mapbase for the traced objects.
Aug 14 2022, 3:07 PM

Aug 13 2022

jrtc27 committed rG3179bb273749: stand: Fix a couple of comment typos in f8a199f28f9d (authored by jrtc27).
stand: Fix a couple of comment typos in f8a199f28f9d
Aug 13 2022, 7:51 PM
jrtc27 added a comment to D36189: virtio_mmio: Support command-line parameters.

But then how do you decide when to add it? Surely it then needs an identify method still? Admittedly you can then move some of the logic out, but still.

Aug 13 2022, 3:40 PM
jrtc27 added a comment to D36189: virtio_mmio: Support command-line parameters.

Which probe would you hook and where would you attach them other then nexus? There isn’t an acpi or ofwbus to hang them off in this case…

Aug 13 2022, 3:27 PM
jrtc27 added inline comments to D36189: virtio_mmio: Support command-line parameters.
Aug 13 2022, 1:25 AM
jrtc27 added inline comments to D36184: ns8250_drain: Drain without DELAY first.
Aug 13 2022, 12:18 AM

Aug 11 2022

jrtc27 updated the summary of D36131: makefs: Fix 32-bit issues in ZFS time attributes setting.
Aug 11 2022, 12:50 AM
jrtc27 added a comment to D36131: makefs: Fix 32-bit issues in ZFS time attributes setting.

Thanks!

Fix this all by marshalling via a real uint64_t pair like is done by the real ZFS_ENCODE_TIME.

What is ZFS_ENCODE_TIME? I can't find that identifier.

Aug 11 2022, 12:50 AM
jrtc27 added inline comments to D36132: sys: Extract __bitcount* from sys/types.h to new sys/bitcount.h.
Aug 11 2022, 12:12 AM
jrtc27 requested review of D36135: makefs: Fix issues building as a cross-tool on non-FreeBSD.
Aug 11 2022, 12:03 AM