Page MenuHomeFreeBSD

jrtc27 (Jessica Clarke)
User

Projects

User Details

User Since
Jul 4 2018, 7:23 PM (315 w, 2 d)

Recent Activity

Thu, Jul 18

jrtc27 committed rGe1d442a6db14: Retire unused non-PCI_RES_BUS code (authored by jrtc27).
Retire unused non-PCI_RES_BUS code
Thu, Jul 18, 5:57 PM
jrtc27 committed rG8415a654d02e: Retire non-NEW_PCIB code and remove config option (authored by jrtc27).
Retire non-NEW_PCIB code and remove config option
Thu, Jul 18, 5:56 PM
jrtc27 closed D32955: Retire unused non-PCI_RES_BUS code.
Thu, Jul 18, 5:56 PM
jrtc27 closed D32954: Retire non-NEW_PCIB code and remove config option.
Thu, Jul 18, 5:56 PM

Wed, Jul 17

jrtc27 updated the summary of D32954: Retire non-NEW_PCIB code and remove config option.
Wed, Jul 17, 11:16 PM
jrtc27 updated the summary of D32955: Retire unused non-PCI_RES_BUS code.
Wed, Jul 17, 3:54 PM
jrtc27 updated the diff for D32955: Retire unused non-PCI_RES_BUS code.

Rebased

Wed, Jul 17, 3:53 PM
jrtc27 committed rGac0c8c1186f7: dts: Fix arm/qcom-ipq4018-rt-ac58u.dts for recent device-tree versions (authored by jrtc27).
dts: Fix arm/qcom-ipq4018-rt-ac58u.dts for recent device-tree versions
Wed, Jul 17, 1:00 PM
jrtc27 committed rGc24e5fcca9c2: mvs: Fix to use rman_get_rid rather than non-existent rid argument (authored by jrtc27).
mvs: Fix to use rman_get_rid rather than non-existent rid argument
Wed, Jul 17, 1:00 PM
jrtc27 committed rGe21e8c918086: tools/build: Unbreak cross build by providing stub ssp/ssp.h (authored by jrtc27).
tools/build: Unbreak cross build by providing stub ssp/ssp.h
Wed, Jul 17, 12:44 PM
jrtc27 added a comment to D45981: sys: Stop requiring nested parentheses for KASSERT.
In D45981#1048615, @jhb wrote:
In D45981#1048465, @jhb wrote:

Doesn't the use of _KASSERT_MACRO artificially limit the number of printf arguments, including format string, to 11 (possibly off by one)? Whilst parenthesising in that case is fine for now, I don't think we want to have that limitation long-term, especially once the parenthesised form is gone...

It does, though if we need more arguments in the future we can expand the macro to work. I just chose 10 as a SWAG for the max arguments for now. If we didn't care about the single argument version we could eventually drop _KASSERT_MACRO entirely, but if we want the single argument version to work we are stuck with it I think.

Given that not giving a message is lazy and bad practice that should not be encouraged, I'm loathe to add such hacks and restrictions just to support it. There's always MPASS if you really want it, or we can add a KASSERT1, but it's worth pointing out that MPASS at least gives you the file and line number when there's no message, unlike KASSERT which will just print the condition with no context other than what DDB can infer.

Err, I made KASSERT() match MPASS() in its output when used with a single argument.

Wed, Jul 17, 12:30 PM
jrtc27 updated the summary of D32954: Retire non-NEW_PCIB code and remove config option.
Wed, Jul 17, 11:35 AM
jrtc27 updated the diff for D32954: Retire non-NEW_PCIB code and remove config option.

Rebased

Wed, Jul 17, 11:35 AM

Tue, Jul 16

jrtc27 added a comment to D45981: sys: Stop requiring nested parentheses for KASSERT.
In D45981#1048465, @jhb wrote:

Doesn't the use of _KASSERT_MACRO artificially limit the number of printf arguments, including format string, to 11 (possibly off by one)? Whilst parenthesising in that case is fine for now, I don't think we want to have that limitation long-term, especially once the parenthesised form is gone...

It does, though if we need more arguments in the future we can expand the macro to work. I just chose 10 as a SWAG for the max arguments for now. If we didn't care about the single argument version we could eventually drop _KASSERT_MACRO entirely, but if we want the single argument version to work we are stuck with it I think.

Tue, Jul 16, 6:19 PM

Mon, Jul 15

jrtc27 added a comment to D45981: sys: Stop requiring nested parentheses for KASSERT.

Doesn't the use of _KASSERT_MACRO artificially limit the number of printf arguments, including format string, to 11 (possibly off by one)? Whilst parenthesising in that case is fine for now, I don't think we want to have that limitation long-term, especially once the parenthesised form is gone...

Mon, Jul 15, 9:44 PM
jrtc27 added inline comments to D45512: bhyve/riscv userspace part.
Mon, Jul 15, 9:32 PM

Thu, Jul 4

jrtc27 added a comment to D45866: if_urndis: Organize buffer layouts more naturally.

on CHERI platforms, the compiler will set bounds as intended

Thu, Jul 4, 9:03 AM

Tue, Jul 2

jrtc27 added inline comments to D45836: cdefs.h: Add back fallback define for __printf0like.
Tue, Jul 2, 6:01 PM

Mon, Jul 1

jrtc27 accepted D45825: cdefs.h __generic: avoid gcc -Wunused-value.
Mon, Jul 1, 5:28 PM

Sat, Jun 22

jrtc27 added inline comments to D45697: riscv: add FPE code.
Sat, Jun 22, 6:52 PM
jrtc27 added inline comments to D45697: riscv: add FPE code.
Sat, Jun 22, 6:49 PM

Jun 19 2024

jrtc27 added a comment to D45650: cdefs.h: Don't define _Static_assert helper in C++ < C++11.

_Static_assert is in the implementation namespace (_[A-Z]-prefixed), so we are within our right to define this. Whatever libc++ is doing should be made to be compatible; it looks like it's assuming things about the implementation that aren't true.

Jun 19 2024, 11:54 PM

Jun 11 2024

jrtc27 committed rG703768a23590: mx25l.4: Document the correct disk device path (authored by jrtc27).
mx25l.4: Document the correct disk device path
Jun 11 2024, 4:44 PM

Jun 10 2024

jrtc27 added a comment to D45553: bhyve/riscv kernel part.

Without wanting to give a detailed review of the whole thing, I will say that implementing SBI should be done in userspace, it doesn't need to be in the kernel (and really needs to be in userspace to be able to handle the console I/O calls), just like arm64 has PSCI in userspace. You want to just have it send up a VM_EXITCODE_ECALL.

Jun 10 2024, 9:17 PM

Jun 5 2024

jrtc27 committed rG98200077809a: rtld-elf: Use a proper struct type for tlsdesc entries (authored by jrtc27).
rtld-elf: Use a proper struct type for tlsdesc entries
Jun 5 2024, 4:42 PM
jrtc27 closed D45143: rtld-elf: Use a proper struct type for tlsdesc entries.
Jun 5 2024, 4:42 PM
jrtc27 requested changes to D45497: riscv: include AHCI.

Please use conventional RISC-V IP. For the UART the platform standards want an 8250, and that’s what QEMU’s virt machine provides. For the RTC the goldfish RTC is simple to emulate and what its virt machine uses. If an OS boots on QEMU it should boot on bhyve.

Jun 5 2024, 3:44 PM

Jun 4 2024

jrtc27 added a comment to D45481: riscv stage2 pmap support.

The rest of page table system (including PTE format) is identical.

Jun 4 2024, 11:32 PM
jrtc27 added inline comments to D45000: release: create a bootable image with the graphical installer.
Jun 4 2024, 6:41 PM
jrtc27 added a comment to D45000: release: create a bootable image with the graphical installer.

I feel like if you restructure things you should just be able to use the existing mkisoimages.sh:

Jun 4 2024, 6:36 PM
jrtc27 committed rG9712479723b6: ObsoleteFiles.inc: Add missed riscv64 file for LLVM 17 (authored by jrtc27).
ObsoleteFiles.inc: Add missed riscv64 file for LLVM 17
Jun 4 2024, 5:08 PM

Jun 3 2024

jrtc27 committed rGfbfdf57d65be: Fix off-by-one bug in btpand (authored by dg612_cam.ac.uk).
Fix off-by-one bug in btpand
Jun 3 2024, 7:32 PM
jrtc27 closed D45463: Fix off-by-one bug in btpand.
Jun 3 2024, 7:31 PM
jrtc27 accepted D45463: Fix off-by-one bug in btpand.
Jun 3 2024, 7:19 PM
jrtc27 added inline comments to D45471: riscv: Svpbmt extension support.
Jun 3 2024, 7:00 PM

Jun 2 2024

jrtc27 added a reverting change for rG2b7c1402f96b: src.sys.obj.mk: Export OBJTOP: rG3cc91b77514d: Revert "src.sys.obj.mk: Export OBJTOP".
Jun 2 2024, 11:37 PM
jrtc27 committed rG3cc91b77514d: Revert "src.sys.obj.mk: Export OBJTOP" (authored by jrtc27).
Revert "src.sys.obj.mk: Export OBJTOP"
Jun 2 2024, 11:37 PM
jrtc27 committed rGa20a903b167c: Makefile.inc1: Allow showconfig and test-system-* if (X)CC is GCC (authored by jrtc27).
Makefile.inc1: Allow showconfig and test-system-* if (X)CC is GCC
Jun 2 2024, 11:37 PM
jrtc27 committed rG25a33bfe9ce2: ee: Fix use of uninitialised pointer in ispell_op (authored by jrtc27).
ee: Fix use of uninitialised pointer in ispell_op
Jun 2 2024, 10:56 PM
jrtc27 added a reviewer for D45463: Fix off-by-one bug in btpand: jrtc27.
Jun 2 2024, 9:39 PM
jrtc27 added a comment to D45463: Fix off-by-one bug in btpand.

Please follow the wiki instructions and be sure to upload full context: https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface

Jun 2 2024, 9:37 PM
jrtc27 committed rG28aaa58fa64e: fu740_pci_dw: Fix PERST delay and keep asserted for rest of reset sequence (authored by jrtc27).
fu740_pci_dw: Fix PERST delay and keep asserted for rest of reset sequence
Jun 2 2024, 8:44 PM

Jun 1 2024

jrtc27 added inline comments to D45422: iovec: macros to manipulate len and base together.
Jun 1 2024, 8:24 PM

May 31 2024

jrtc27 committed rGfe2b60f87e1e: openzfs: Fix mismerge breaking macOS bootstrap (authored by jrtc27).
openzfs: Fix mismerge breaking macOS bootstrap
May 31 2024, 9:14 PM
jrtc27 committed rGa5ae2d2ab409: mitigations.7: Document riscv's SM[AE]P equivalents (authored by jrtc27).
mitigations.7: Document riscv's SM[AE]P equivalents
May 31 2024, 7:59 PM
jrtc27 added inline comments to D45422: iovec: macros to manipulate len and base together.
May 31 2024, 7:47 PM
jrtc27 added a comment to D45422: iovec: macros to manipulate len and base together.

I don't think any of these need to be __extension__({ ... }), you're not using them as an expression, you're using them as a statement, so do { ... } while (0) is perfectly fine.

May 31 2024, 6:36 PM
jrtc27 added inline comments to D45422: iovec: macros to manipulate len and base together.
May 31 2024, 6:30 PM

May 28 2024

jrtc27 added inline comments to D45387: runq: API rationalization, code factorization, revised implementation.
May 28 2024, 1:25 AM

May 26 2024

jrtc27 added inline comments to D45355: cross-build: This is not glibc specific, but Linux specific.
May 26 2024, 6:31 PM
jrtc27 added inline comments to D45351: build: Include sys/cdefs.h in our fcntl.h shim.
May 26 2024, 6:30 PM
jrtc27 added inline comments to D45351: build: Include sys/cdefs.h in our fcntl.h shim.
May 26 2024, 6:30 PM
jrtc27 added inline comments to D45355: cross-build: This is not glibc specific, but Linux specific.
May 26 2024, 6:11 PM
jrtc27 added inline comments to D45351: build: Include sys/cdefs.h in our fcntl.h shim.
May 26 2024, 6:10 PM

May 24 2024

jrtc27 added a comment to D45344: bsdinstall: Fix wpa_suppicant PSK configuration.

Improved commit message

May 24 2024, 5:44 PM
jrtc27 added a comment to D45344: bsdinstall: Fix wpa_suppicant PSK configuration.

I don’t understand how this diff relates to the commit message. Whether PASS contains a space or not, using its expansion and deleting its first line are two quite different things.

May 24 2024, 4:55 PM
jrtc27 accepted D45329: cross: Move Solaris API64 defines to common.

Though please mention that it's needed for musl in the commit message, otherwise it's not clear why we've been fine without this diff for years

May 24 2024, 1:40 AM

May 23 2024

jrtc27 accepted D45306: nextboot: Permit ZFS boot filesystems mounted at the pool's root.
May 23 2024, 4:15 AM

May 21 2024

jrtc27 added a comment to D45291: ftpd: stop using -g flag for /bin/ls.

Oh and MFC after?

May 21 2024, 10:47 PM
jrtc27 accepted D45291: ftpd: stop using -g flag for /bin/ls.

Though please change your Fixes to be 3bfbb521fef5 ("ls: Improve POSIX compatibility for -g and -n.")

May 21 2024, 10:47 PM

May 20 2024

jrtc27 added a comment to D45268: libgcc_s: Add a linker script to link to libgcc.

This seems to match what GCC does, though I'm not sure why either need it. Both drivers pass both of -lgcc and -lgcc_s, whether building an executable or shared library (well, testing with GCC 13.2 on arm64 Linux, as that's easily to hand). Can you elaborate on the exact issue you're seeing without this?

May 20 2024, 5:48 PM
jrtc27 accepted D45259: csu: Find the main pointer through the GOT.

It surprises me that GNU ld doesn't want to create canonical PLTs, but avoiding them is reasonable; they are to functions what copy relocations are to data.

May 20 2024, 5:32 PM

May 15 2024

jrtc27 committed rGfc59fc3c1f63: uart: Honour clock-frequency in FDT for UART_FDT_CLASS if present (authored by jrtc27).
uart: Honour clock-frequency in FDT for UART_FDT_CLASS if present
May 15 2024, 3:54 PM
jrtc27 closed D45159: uart: Honour clock-frequency in FDT for UART_FDT_CLASS if present.
May 15 2024, 3:54 PM
jrtc27 accepted D45210: riscv: fix L0 PTE setup (Sv48).
May 15 2024, 3:52 PM

May 11 2024

jrtc27 added a comment to D45159: uart: Honour clock-frequency in FDT for UART_FDT_CLASS if present.

It's hard to tell if this was a deliberate design choice or just not thought to be needed when the current UART_FDT_CLASS(_AND_DEVICE) framework was added, but I don't see a good alternative to this. Note that snps and tegra_uart are the only in-tree UART_FDT_CLASS users, and both wrap ns8250.

May 11 2024, 12:36 AM
jrtc27 requested review of D45159: uart: Honour clock-frequency in FDT for UART_FDT_CLASS if present.
May 11 2024, 12:34 AM

May 9 2024

jrtc27 added a comment to D45142: uio: Use switch statements when handling UIO_READ vs UIO_WRITE.
In D45142#1029592, @jhb wrote:

Drop md.c change

May 9 2024, 8:03 PM
jrtc27 requested review of D45143: rtld-elf: Use a proper struct type for tlsdesc entries.
May 9 2024, 6:53 PM

May 3 2024

jrtc27 added inline comments to D45089: aarch64: disable LIB32 with gcc.
May 3 2024, 10:33 PM

May 2 2024

jrtc27 committed rGf16e205c6fb9: jevents: fix bootstrapping on Linux with Clang 16 (authored by arichardson).
jevents: fix bootstrapping on Linux with Clang 16
May 2 2024, 8:13 PM
jrtc27 committed rGdbbbe6f393dd: mandoc: fix bootstrapping on Linux with Clang 16 (authored by arichardson).
mandoc: fix bootstrapping on Linux with Clang 16
May 2 2024, 8:13 PM
jrtc27 committed rG91e0b44c159f: kldxref: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15 (authored by jrtc27).
kldxref: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15
May 2 2024, 8:12 PM
jrtc27 committed rG89342dba7dbe: jevents: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15 (authored by jrtc27).
jevents: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15
May 2 2024, 8:12 PM
jrtc27 committed rG2714c4d3280b: mandoc: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15 (authored by jrtc27).
mandoc: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15
May 2 2024, 8:12 PM
jrtc27 committed rG8cb8aca83f6c: jevents: fix bootstrapping on Linux with Clang 16 (authored by arichardson).
jevents: fix bootstrapping on Linux with Clang 16
May 2 2024, 8:12 PM
jrtc27 committed rG9bfc9ea2e18e: mandoc: fix bootstrapping on Linux with Clang 16 (authored by arichardson).
mandoc: fix bootstrapping on Linux with Clang 16
May 2 2024, 8:12 PM
jrtc27 committed rGb2d59a3afb7c: kldxref: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15 (authored by jrtc27).
kldxref: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15
May 2 2024, 8:12 PM
jrtc27 committed rG9019baf667c7: jevents: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15 (authored by jrtc27).
jevents: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15
May 2 2024, 8:12 PM
jrtc27 committed rGef6935581e62: mandoc: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15 (authored by jrtc27).
mandoc: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15
May 2 2024, 8:11 PM

May 1 2024

jrtc27 added a comment to D45049: bhyve: Let the guest enable PCI BARs on arm64.
In D45049#1027191, @jhb wrote:

My mental model of what is safe is that it's allowed to move BARs around so long as you disable decoding while you do so, and I'm pretty sure we already do that now to handle FreeBSD kernels (and other OS kernels) that rewrite BARs to size them during boot. We have to avoid trying to register/unregister them while rewriting, and I thought that was driven by if the I/O space was enabled. (See how update_bar_address makes the register_bar call conditional on encoding being enabled.) It sounds like u-boot is just buggy here in that it isn't disabling decoding while it messes with the BARs. This idea is ok though. I wonder if FreeBSD/amd64 boots with this set to true. :)

May 1 2024, 10:29 PM
jrtc27 added a comment to D45049: bhyve: Let the guest enable PCI BARs on arm64.

I believe it's also legal to go and map two BARs to overlap so long as you don't try to access the overlapping range when that's the case? QEMU just maintains a list of PCI BARs and goes for the first one in the list that matches. Allocating the big chunk of MMIO memory statically at the start and just maintaining the list layered on top in PCI code as you mess with BARs seems like it would be a simple, more general fix, and should perform just fine? (Though passthrough may well be "fun" as you mention)

May 1 2024, 4:58 PM

Apr 25 2024

jrtc27 accepted D44946: bsdinstall: update comment related to pkg.
Apr 25 2024, 2:54 PM
jrtc27 added a comment to D27176: Discourage the use of sysexits(3) in new code.

My opinion is that, whilst they are by no means completely unambiguous and fully descriptive, picking a value that's close to right so the user has some idea what the error was even in the absence of error messages is better than just using a hard-coded wholly-meaningless 1 everywhere, as will inevitably happen (and already does when not using sysexits) as a result of this.

Apr 25 2024, 2:50 PM

Apr 24 2024

jrtc27 added inline comments to D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.
Apr 24 2024, 2:13 AM

Apr 19 2024

jrtc27 added a comment to D44883: lib{c,sys}: .note.GNU-stack in syscall stubs.
In D44883#1023197, @kib wrote:

Does it matter/used on arm64 and risc-v? I remember that psABIs require nx stack always for them. It might be that some (old ?) linker complained about the note on these arches.

Apr 19 2024, 11:15 PM

Apr 8 2024

jrtc27 added inline comments to D44679: sys/queue.h: Add {LIST,TAILQ}_REPLACE()..
Apr 8 2024, 4:09 PM

Apr 7 2024

jrtc27 added a comment to D44670: bsdinstall: implement timezone with bsddialog.

Why do we need a copy of this code rather than just tweaking bsdconfig to support this?

Apr 7 2024, 5:52 PM

Mar 27 2024

jrtc27 committed rGd5aead83dfa8: arm64: Delete stale comment (authored by jrtc27).
arm64: Delete stale comment
Mar 27 2024, 7:45 PM

Mar 22 2024

jrtc27 added inline comments to D37899: ddb: Add basic CTF support [2/2].
Mar 22 2024, 8:05 AM

Mar 18 2024

jrtc27 accepted D44419: kldxref: Properly handle reading strings near the end of an ELF file.
Mar 18 2024, 11:45 PM

Mar 16 2024

jrtc27 committed rG75464941dc17: kldxref: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15 (authored by jrtc27).
kldxref: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15
Mar 16 2024, 1:51 AM
jrtc27 committed rGd8c84215d767: jevents: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15 (authored by jrtc27).
jevents: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15
Mar 16 2024, 1:51 AM
jrtc27 committed rGce312ef72d91: mandoc: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15 (authored by jrtc27).
mandoc: Fix bootstrapping on macOS with Clang 16 / Apple Clang 15
Mar 16 2024, 1:51 AM

Mar 13 2024

jrtc27 added a comment to D44317: Changed order of arm64 events such that TSLOG-enabled kernels are able to boot.

(The problem this fixes was introduced by me adding profiling to the linker in link_elf_ireloc.)

Mar 13 2024, 7:39 PM

Mar 12 2024

jrtc27 added inline comments to D44334: riscv: remove more riscv64sf support.
Mar 12 2024, 11:23 PM
jrtc27 added a comment to D44333: msun/riscv: expose fe{disable,enable}except.

By ABI break you mean for riscv64sf getting the old symbol versions? That architecture is dead, we should just delete the dead code in the header.

Mar 12 2024, 10:51 PM
jrtc27 added a comment to D44331: msun/riscv: limit exposure of fegetexcept.

Oh I had it as an in-progress patch to make these *not* inline-only. I don't think it's a bug that they're only inline, but every other architecture exposes them as actual symbols too and GCC at least relies on that. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272759 (comment 5 in particular) and https://cgit.freebsd.org/src/commit/?id=448c505c33cc334193590f3844406d6a74f26e2a.

Ah, I'll grab that and apply it.

Mar 12 2024, 10:36 PM
jrtc27 added a comment to D44331: msun/riscv: limit exposure of fegetexcept.

Oh I had it as an in-progress patch to make these *not* inline-only. I don't think it's a bug that they're only inline, but every other architecture exposes them as actual symbols too and GCC at least relies on that. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272759 (comment 5 in particular) and https://cgit.freebsd.org/src/commit/?id=448c505c33cc334193590f3844406d6a74f26e2a.

Mar 12 2024, 9:53 PM

Mar 7 2024

jrtc27 added a comment to D44270: starfive: add a syscon driver.

I considered extending the existing riscv_syscon for this purpose, but
it seems better to keep the StarFive/JH7110-specific drivers properly
separated.

Mar 7 2024, 7:53 PM