Page MenuHomeFreeBSD

jrtc27 (Jessica Clarke)
User

Projects

User Details

User Since
Jul 4 2018, 7:23 PM (168 w, 4 h)

Recent Activity

Mon, Sep 20

jrtc27 added inline comments to D31954: amd64: stop using top of the thread' kernel stack for FPU user save area.
Mon, Sep 20, 6:51 PM

Sat, Sep 18

jrtc27 added a comment to D32013: virtqueue: add virtqueue_poll_timeout().
In D32013#722385, @cem wrote:

I don’t think this is a great mitigation for random - the pending request will still be written in guest memory, and we need the queue completion to know when we can free the memory.

I think we should really try to scale down our “fast source” entropy collection instead. 2kB/s is pretty ridiculous. I really think we could just collect 256 bits x2 into the zero pool per reseed (64B) and maybe change the fortuna minimum reseed interval to 1s (from 100ms).

Also - I believe the fX random design reseeds much less frequently. I haven’t looked at it’s “fast source” consumption recently, but it may be a lot lower.

Sat, Sep 18, 6:19 PM
jrtc27 added inline comments to D32013: virtqueue: add virtqueue_poll_timeout().
Sat, Sep 18, 3:37 PM

Fri, Sep 17

jrtc27 requested review of D32011: pci_pci: Support growing bus ranges in bus_adjust_resource for NEW_PCIB.
Fri, Sep 17, 10:27 PM
jrtc27 requested review of D32001: riscv: Add vt and kbdmux to GENERIC for video console support.
Fri, Sep 17, 3:40 AM
jrtc27 updated the diff for D31996: riscv: Add a stub pmap_change_attr implementation.

Handle L1 pages as those are uesd for the direct map

Fri, Sep 17, 2:51 AM
jrtc27 requested review of D31999: LinuxKPI: Add more #ifdef VM_MEMATTR_WRITE_COMBINING guards.
Fri, Sep 17, 12:12 AM

Thu, Sep 16

jrtc27 updated the summary of D31996: riscv: Add a stub pmap_change_attr implementation.
Thu, Sep 16, 11:53 PM
jrtc27 requested review of D31997: libgcc_s: Export 64-bit int to 128-bit float functions.
Thu, Sep 16, 11:52 PM
jrtc27 requested review of D31996: riscv: Add a stub pmap_change_attr implementation.
Thu, Sep 16, 11:31 PM

Wed, Sep 15

jrtc27 closed D31972: Sync 13-STABLE and 14-CURRENT images links with reality.
Wed, Sep 15, 6:42 PM
jrtc27 committed R9:79acd015e3ca: Sync 13-STABLE and 14-CURRENT images links with reality (authored by jrtc27).
Sync 13-STABLE and 14-CURRENT images links with reality
Wed, Sep 15, 6:42 PM
jrtc27 updated the summary of D31972: Sync 13-STABLE and 14-CURRENT images links with reality.
Wed, Sep 15, 6:37 PM
jrtc27 requested review of D31972: Sync 13-STABLE and 14-CURRENT images links with reality.
Wed, Sep 15, 6:24 PM
jrtc27 added inline comments to D31945: libmd: Only define SHA256_Transform_c when using the ARM64 ifunc..
Wed, Sep 15, 4:06 PM
jrtc27 added inline comments to D31945: libmd: Only define SHA256_Transform_c when using the ARM64 ifunc..
Wed, Sep 15, 4:04 PM

Mon, Sep 13

jrtc27 committed R10:f28c1d0c5c6c: llvm-objcopy: Install llvm-strip, and optionally strip, links (authored by jrtc27).
llvm-objcopy: Install llvm-strip, and optionally strip, links
Mon, Sep 13, 8:54 PM
jrtc27 added a comment to D31945: libmd: Only define SHA256_Transform_c when using the ARM64 ifunc..

I don't think I understand the problem. SHA256_Transform is static, it should never be visible outside the object.

Mon, Sep 13, 6:42 PM

Sun, Sep 12

jrtc27 added a comment to D28212: linux: implement PTRACE_GET_SYSCALL_INFO.

There's still one problem: the #ifdef _KERNEL breaks world build (lib/libsysdecode/tables.h:406:13: error: use of undeclared identifier 'PT_GET_SC_ARGS_ALL'). Is there already some #define to allow libsysdecode to use kernel includes, or is there a different way?

Sun, Sep 12, 8:45 PM

Fri, Sep 10

jrtc27 committed R10:877175a17a0a: libc: Fix build on case-insensitive file systems (authored by jrtc27).
libc: Fix build on case-insensitive file systems
Fri, Sep 10, 12:20 AM
jrtc27 closed D31895: libc: Fix build on case-insensitive file systems.
Fri, Sep 10, 12:20 AM
jrtc27 updated the diff for D31895: libc: Fix build on case-insensitive file systems.

Just rename the file rather than adding a symlink at build time

Fri, Sep 10, 12:08 AM
jrtc27 added a comment to D31895: libc: Fix build on case-insensitive file systems.
In D31895#719630, @kib wrote:

Please just rename _Fork.c to something else, if it makes an issue. Next people to complain would be somebody without symlinks, like new and improved MacOSX users.

Fri, Sep 10, 12:05 AM
jrtc27 requested review of D31895: libc: Fix build on case-insensitive file systems.
Fri, Sep 10, 12:00 AM

Tue, Sep 7

jrtc27 accepted D31874: cdefs.h: Remove redundant #ifdefs.

Yeah these changes are pretty clearly fine :)

Tue, Sep 7, 3:46 PM
jrtc27 committed R10:01aedb837b60: RELNOTES: Add entry for just-MFC'ed HiFive Unmatched support (authored by jrtc27).
RELNOTES: Add entry for just-MFC'ed HiFive Unmatched support
Tue, Sep 7, 12:16 PM
jrtc27 committed R10:01ecff28ad50: mx25l: Add support for Integrated Silicon Solution is25wp256 (authored by skibo).
mx25l: Add support for Integrated Silicon Solution is25wp256
Tue, Sep 7, 12:12 PM
jrtc27 committed R10:c108f304472e: sifive_spi: Add missing case for SPIBUS_MODE_NONE (authored by skibo).
sifive_spi: Add missing case for SPIBUS_MODE_NONE
Tue, Sep 7, 12:12 PM
jrtc27 added a reverting change for R10:d9f25575a29f: Mark LLDB/CLANG_BOOTSTRAP/LLD_BOOTSTRAP as broken on non-FreeBSD for now: R10:712920c3c780: Revert "Mark LLDB/CLANG_BOOTSTRAP/LLD_BOOTSTRAP as broken on non-FreeBSD for….
Tue, Sep 7, 12:12 PM
jrtc27 committed R10:712920c3c780: Revert "Mark LLDB/CLANG_BOOTSTRAP/LLD_BOOTSTRAP as broken on non-FreeBSD for… (authored by jrtc27).
Revert "Mark LLDB/CLANG_BOOTSTRAP/LLD_BOOTSTRAP as broken on non-FreeBSD for…
Tue, Sep 7, 12:12 PM
jrtc27 committed R10:b20eb96fe818: clang: Build with -fno-strict-aliasing when using GCC (authored by jrtc27).
clang: Build with -fno-strict-aliasing when using GCC
Tue, Sep 7, 12:12 PM
jrtc27 committed R10:523f2486d54a: clang: Support building with GCC and DEBUG_FILES disabled (authored by jrtc27).
clang: Support building with GCC and DEBUG_FILES disabled
Tue, Sep 7, 12:12 PM
jrtc27 committed R10:5ef9ae5c6d4f: clang: Fix inverted condition in llvm.build.mk (authored by jrtc27).
clang: Fix inverted condition in llvm.build.mk
Tue, Sep 7, 12:12 PM
jrtc27 committed R10:e515dd81ff4f: Fix bootstrapping to actually build lldb-tblgen for later use (authored by jrtc27).
Fix bootstrapping to actually build lldb-tblgen for later use
Tue, Sep 7, 12:12 PM
jrtc27 committed R10:92f73068bf69: Makefile.inc1: Make sure sub-makes see MK_CLANG_BOOTSTRAP=no when XCC is a path (authored by jrtc27).
Makefile.inc1: Make sure sub-makes see MK_CLANG_BOOTSTRAP=no when XCC is a path
Tue, Sep 7, 12:12 PM
jrtc27 committed R10:572a78599d59: tools/build/cross-build: Fix building libllvmminimal on Linux (authored by jrtc27).
tools/build/cross-build: Fix building libllvmminimal on Linux
Tue, Sep 7, 12:12 PM
jrtc27 committed R10:23181404aad8: riscv: Fix pmap_alloc_l2 when it should allocate a new L1 entry (authored by jrtc27).
riscv: Fix pmap_alloc_l2 when it should allocate a new L1 entry
Tue, Sep 7, 12:12 PM
jrtc27 committed R10:796e16798d28: riscv: Sync NOTES with GENERIC changes (authored by jrtc27).
riscv: Sync NOTES with GENERIC changes
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:206bb484f531: riscv: Add hwreset to NOTES to fix LINT build (authored by jrtc27).
riscv: Add hwreset to NOTES to fix LINT build
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:a06f7ad58487: fu740_pci_dw: Add SiFive FU740 PCIe controller driver (authored by jrtc27).
fu740_pci_dw: Add SiFive FU740 PCIe controller driver
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:902a992ffaac: gpio.4: Mention new sifive_gpio driver (authored by jrtc27).
gpio.4: Mention new sifive_gpio driver
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:3c7b6c729d1b: riscv: Add NVMe, USB and HID support to GENERIC (authored by jrtc27).
riscv: Add NVMe, USB and HID support to GENERIC
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:3b30406bff66: pci_dw: Drop unconditional explicit DEBUG define (authored by jrtc27).
pci_dw: Drop unconditional explicit DEBUG define
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:c263c4c52aaa: fu540_spi: Rename to sifive_spi (authored by jrtc27).
fu540_spi: Rename to sifive_spi
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:8fdfe5e724e6: sifive_gpio: Add SiFive GPIO controller driver (authored by jrtc27).
sifive_gpio: Add SiFive GPIO controller driver
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:276455b32167: sifive_prci: Delay attachment until after clk_fixed (authored by jrtc27).
sifive_prci: Delay attachment until after clk_fixed
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:f240b19abf0b: sifive_prci: Add reset support for the FU540 and FU740 (authored by jrtc27).
sifive_prci: Add reset support for the FU540 and FU740
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:7f59cce2d43d: sifive_prci: Add support for the FU740 PRCI (authored by jrtc27).
sifive_prci: Add support for the FU740 PRCI
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:1577a4b1eb34: fu540_prci: Rename to sifive_prci and use ocd_data for FU540 specificity (authored by jrtc27).
fu540_prci: Rename to sifive_prci and use ocd_data for FU540 specificity
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:215db69fbcb0: pci_dw: Trim ATU windows bigger than 4GB (authored by wma).
pci_dw: Trim ATU windows bigger than 4GB
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:2e3c6024a476: riscv: Fix pmap_kextract racing with concurrent superpage promotion/demotion (authored by jrtc27).
riscv: Fix pmap_kextract racing with concurrent superpage promotion/demotion
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:0e948ed6d668: pci_dw: fix outbound I/O window configuration (authored by mw).
pci_dw: fix outbound I/O window configuration
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:b2ea668b8f72: Fix native-xtools build (authored by bdrewery).
Fix native-xtools build
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:0889033d2820: pci_dw: Detect number of outbound regions automatically (authored by jrtc27).
pci_dw: Detect number of outbound regions automatically
Tue, Sep 7, 12:11 PM
jrtc27 committed R10:16ee8fe56b8b: riscv: Include spibus and spigen in GENERIC (authored by jrtc27).
riscv: Include spibus and spigen in GENERIC
Tue, Sep 7, 12:10 PM
jrtc27 committed R10:982d709cdc25: pci_dw: Support multiple memory windows (authored by jrtc27).
pci_dw: Support multiple memory windows
Tue, Sep 7, 12:10 PM
jrtc27 committed R10:15a5871387ca: pci_dw: Support modern "unroll" iATU mode (authored by jrtc27).
pci_dw: Support modern "unroll" iATU mode
Tue, Sep 7, 12:10 PM
jrtc27 committed R10:d2c77ce6f332: makefs: Cast daddr_t to off_t before multiplication (authored by nwf20_cl.cam.ac.uk).
makefs: Cast daddr_t to off_t before multiplication
Tue, Sep 7, 12:10 PM
jrtc27 committed R10:502fa11ee8ee: Makefile: Fix MAKEOBJDIRPREFIX command-line variable check for bmake (authored by jrtc27).
Makefile: Fix MAKEOBJDIRPREFIX command-line variable check for bmake
Tue, Sep 7, 12:10 PM
jrtc27 committed R10:3ac63c72714c: riscv: Fix pindex level confusion (authored by jrtc27).
riscv: Fix pindex level confusion
Tue, Sep 7, 12:10 PM
jrtc27 committed R10:2427c885744d: cgem: Add support for the SiFive FU740 (authored by jrtc27).
cgem: Add support for the SiFive FU740
Tue, Sep 7, 12:10 PM
jrtc27 committed R10:67961fec0754: sifive_uart: Fix input character dropping in ddb and at a mountroot prompt (authored by jrtc27).
sifive_uart: Fix input character dropping in ddb and at a mountroot prompt
Tue, Sep 7, 12:10 PM
jrtc27 committed R10:92bdef84de8c: riscv: Implement missing nexus methods (authored by jrtc27).
riscv: Implement missing nexus methods
Tue, Sep 7, 12:10 PM
jrtc27 committed R10:c69a739379be: riscv: Implement non-stub __vdso_gettc and __vdso_gettimekeep (authored by jrtc27).
riscv: Implement non-stub __vdso_gettc and __vdso_gettimekeep
Tue, Sep 7, 12:10 PM

Mon, Aug 30

jrtc27 committed R10:416ac155bb75: mx25l: Add support for Integrated Silicon Solution is25wp256 (authored by skibo).
mx25l: Add support for Integrated Silicon Solution is25wp256
Mon, Aug 30, 10:39 PM
jrtc27 committed R10:f5d78bea1f69: sifive_spi: Add missing case for SPIBUS_MODE_NONE (authored by skibo).
sifive_spi: Add missing case for SPIBUS_MODE_NONE
Mon, Aug 30, 10:39 PM
jrtc27 closed D31562: Add support for spi flash on SiFive Unmatched..
Mon, Aug 30, 10:39 PM

Thu, Aug 26

jrtc27 accepted D31693: pcib(4): write window after resource adjustment.

Yep that's another good observation... any more bugs you can think of with my original code? :)

Thu, Aug 26, 10:08 PM · PCI
jrtc27 accepted D31693: pcib(4): write window after resource adjustment.

Still an accept with the context added :)

Thu, Aug 26, 6:13 PM · PCI
jrtc27 accepted D31693: pcib(4): write window after resource adjustment.

Given pcib_grow_window also rounds requests it seems sensible to be consistent and do so here too. Not writing the updated window is indeed a silly oversight and explains why clear_pcib wasn't working for me on my board, stopping enumeration early. But best wait for John to check there isn't something I'm overlooking here.

Thu, Aug 26, 5:32 PM · PCI

Wed, Aug 25

jrtc27 added inline comments to D30545: diff(1): Add --color support.
Wed, Aug 25, 8:03 PM

Tue, Aug 24

jrtc27 added inline comments to D31638: [libc] Optimize swab so that it can handle any ssize_t value.
Tue, Aug 24, 9:57 PM
jrtc27 added inline comments to D31638: [libc] Optimize swab so that it can handle any ssize_t value.
Tue, Aug 24, 9:53 PM
jrtc27 added inline comments to D31663: [libsa][NFC] ANSI libsa functions.
Tue, Aug 24, 7:37 PM
jrtc27 added a comment to D31668: Convert hw_tls to bool since it is used as one.

Your description says you did one thing. You in fact did two things, each in a different file.

Tue, Aug 24, 7:19 PM
jrtc27 added inline comments to D31638: [libc] Optimize swab so that it can handle any ssize_t value.
Tue, Aug 24, 7:17 PM
jrtc27 added a comment to D31603: [libc][NFC] Add restrict, pure, and malloc_like qualifiers to string functions.

Addressed all issues!

Tue, Aug 24, 7:17 PM
jrtc27 added a comment to D31669: [NFC] Use C++ features and headers in C++ code instead of C.

It's written this way because our C++ is deliberately very C-like. And it avoids all the std:: everywhere that's just a mess. Are there any useful changes you're making here other than changing it to match your personal views on style? The only somewhat useful thing I can see is changing some ints to bools, but even then it's all in tests so I really don't care all that much about a tiny increase in memory footprint.

Tue, Aug 24, 7:13 PM
jrtc27 added a comment to D31670: Switch to -O3 flags.
  • -O3 often bloats code
  • Much of -O3's advantage, at least with GCC, is from autovectorisation, which is useless in the kernel as we turn off vectors due to the high context-switch overhead
  • -O3 is underused and historically has come with more compiler bugs
Tue, Aug 24, 7:07 PM
jrtc27 added a comment to D31603: [libc][NFC] Add restrict, pure, and malloc_like qualifiers to string functions.

Your description still completely ignores a large chunk of the unrelated changes you're making

Tue, Aug 24, 6:59 PM
jrtc27 added inline comments to D31638: [libc] Optimize swab so that it can handle any ssize_t value.
Tue, Aug 24, 6:55 PM
jrtc27 added a comment to D31667: [fgetstr] Handle case if len is negative.

This is now harder to read. If the input size is between INT_MIN (exclusive) and 0 (inclusive) you still overflow buf. If the input is exactly INT_MIN you still have signed integer overflow. This therefore adds nothing of value.

Tue, Aug 24, 6:50 PM
jrtc27 added a comment to D31666: Remove compiler hacks.

Yet again so much noise I'm not even bothering to give individual comments for

Tue, Aug 24, 6:47 PM
jrtc27 added a comment to D31664: [libc][NFC] Split definitions of memcpy and memmove.

Your description is not what this does for userspace. It is what it does for the kernel but that is bad, now we have two copies of basically the same thing in one file.

Tue, Aug 24, 6:39 PM
jrtc27 added a comment to D31637: [crypto][NFC] Fix compiler warnings about variable types in libcrypt.

Most of these changes have nothing to do with what your summary says

Tue, Aug 24, 6:38 PM
jrtc27 added a comment to D31663: [libsa][NFC] ANSI libsa functions.

ANSIfying definitions has some value, but everything else seems like a complete waste of time to me...

Tue, Aug 24, 6:29 PM
jrtc27 added a reverting change for R10:d9f25575a29f: Mark LLDB/CLANG_BOOTSTRAP/LLD_BOOTSTRAP as broken on non-FreeBSD for now: R10:83ec48b79275: Revert "Mark LLDB/CLANG_BOOTSTRAP/LLD_BOOTSTRAP as broken on non-FreeBSD for….
Tue, Aug 24, 2:09 PM
jrtc27 added a comment to D31562: Add support for spi flash on SiFive Unmatched..

Please elaborate on "Fix a bug in sifive_spi.c." when committing, and please mark for MFC (I have yet to do the big batch of MFCs for the other commits to stable/13 but will get round to it soon).

Tue, Aug 24, 2:08 PM
jrtc27 committed R10:83ec48b79275: Revert "Mark LLDB/CLANG_BOOTSTRAP/LLD_BOOTSTRAP as broken on non-FreeBSD for… (authored by jrtc27).
Revert "Mark LLDB/CLANG_BOOTSTRAP/LLD_BOOTSTRAP as broken on non-FreeBSD for…
Tue, Aug 24, 2:08 PM
jrtc27 closed D31533: clang: Build with -fno-strict-aliasing when using GCC.
Tue, Aug 24, 2:08 PM
jrtc27 committed R10:c1f7d8dd23db: clang: Build with -fno-strict-aliasing when using GCC (authored by jrtc27).
clang: Build with -fno-strict-aliasing when using GCC
Tue, Aug 24, 2:08 PM
jrtc27 closed D31532: clang: Support building with GCC and DEBUG_FILES disabled.
Tue, Aug 24, 2:07 PM
jrtc27 accepted D31562: Add support for spi flash on SiFive Unmatched..
Tue, Aug 24, 2:07 PM
jrtc27 committed R10:c8edd0542647: clang: Support building with GCC and DEBUG_FILES disabled (authored by jrtc27).
clang: Support building with GCC and DEBUG_FILES disabled
Tue, Aug 24, 2:07 PM
jrtc27 closed D31531: Fix bootstrapping to actually build lldb-tblgen for later use.
Tue, Aug 24, 2:07 PM
jrtc27 committed R10:1e4c802913af: Fix bootstrapping to actually build lldb-tblgen for later use (authored by jrtc27).
Fix bootstrapping to actually build lldb-tblgen for later use
Tue, Aug 24, 2:07 PM
jrtc27 closed D31529: Makefile.inc1: Make sure sub-makes see MK_CLANG_BOOTSTRAP=no when XCC is a path.
Tue, Aug 24, 2:06 PM
jrtc27 committed R10:ab3a18095fae: Makefile.inc1: Make sure sub-makes see MK_CLANG_BOOTSTRAP=no when XCC is a path (authored by jrtc27).
Makefile.inc1: Make sure sub-makes see MK_CLANG_BOOTSTRAP=no when XCC is a path
Tue, Aug 24, 2:06 PM

Aug 20 2021

jrtc27 added a comment to D31616: intel ethernet: Use ether_gen_addr.

@jrtc27 is there any issue to CHERI with the ether_addr cast like this? It is __packed.

Aug 20 2021, 5:13 PM
jrtc27 added inline comments to D31603: [libc][NFC] Add restrict, pure, and malloc_like qualifiers to string functions.
Aug 20 2021, 2:15 AM