Page MenuHomeFreeBSD

jrtc27 (Jessica Clarke)
User

Projects

User Details

User Since
Jul 4 2018, 7:23 PM (295 w, 1 d)

Recent Activity

Tue, Feb 27

jrtc27 added inline comments to D44132: pci_host_generic: Enumerate resource ranges under bootverbose.
Tue, Feb 27, 11:21 PM
jrtc27 added inline comments to D44103: conf: deduplicate dwc config logic.
Tue, Feb 27, 6:11 PM
jrtc27 added inline comments to D44104: conf: deduplicate dwmmc config logic.
Tue, Feb 27, 6:04 PM
jrtc27 added inline comments to D44103: conf: deduplicate dwc config logic.
Tue, Feb 27, 6:03 PM
jrtc27 accepted D44105: riscv: add starfive kernelconf template.
Tue, Feb 27, 6:02 PM

Sat, Feb 24

jrtc27 accepted D43918: netlink: Don't use a zero-length array.
Sat, Feb 24, 7:15 PM

Fri, Feb 23

jrtc27 added inline comments to D44042: libsys: fix sleep(3)/usleep(3) cancel behavior.
Fri, Feb 23, 6:06 PM
jrtc27 committed rG09cb8031b43c: efibootmgr: Simplify make_next_boot_var_name and fix cnt == 0 case (authored by jrtc27).
efibootmgr: Simplify make_next_boot_var_name and fix cnt == 0 case
Fri, Feb 23, 2:37 AM
jrtc27 closed D44029: efibootmgr: Simplify make_next_boot_var_name and fix cnt == 0 case.
Fri, Feb 23, 2:37 AM

Thu, Feb 22

jrtc27 requested review of D44029: efibootmgr: Simplify make_next_boot_var_name and fix cnt == 0 case.
Thu, Feb 22, 11:49 PM
jrtc27 added a comment to D44027: libsys: link symbolic.

To confirm I understand this:

Thu, Feb 22, 10:00 PM
jrtc27 added a comment to D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.

Initial review comments. Not exhaustive, hard to be for large diffs like this where there are quite a few comments to make, but hopefully I didn't miss anything too fundamental.

Thu, Feb 22, 9:53 PM
jrtc27 added a reverting change for rG5fead429ebb3: Avoid referencing private lib names directly.: rGff6b71c2b214: rescue: Stop using LDADD_zstd.
Thu, Feb 22, 8:57 PM
jrtc27 committed rGff6b71c2b214: rescue: Stop using LDADD_zstd (authored by jrtc27).
rescue: Stop using LDADD_zstd
Thu, Feb 22, 8:56 PM
jrtc27 committed rG121be555997b: arm: Set NEW_PCIB in DEFAULTS rather than a subset of kernel configs (authored by jrtc27).
arm: Set NEW_PCIB in DEFAULTS rather than a subset of kernel configs
Thu, Feb 22, 6:29 PM
jrtc27 closed D43806: arm: Set NEW_PCIB in DEFAULTS rather than a subset of kernel configs.
Thu, Feb 22, 6:29 PM

Fri, Feb 16

jrtc27 added a comment to D43922: pcib: Assume a window where both the base and limit are 0 is uninitialized.

Ok, I went and found a copy of the PCI-PCI bridge spec (v1.1), which has this to say:

Fri, Feb 16, 8:54 PM
jrtc27 added inline comments to D43910: lib{c,sys}: move auxargs more firmly into libsys.
Fri, Feb 16, 8:31 PM

Thu, Feb 15

jrtc27 accepted D43860: reboot: Use posix_spawn instead of system.
Thu, Feb 15, 11:17 PM
jrtc27 added a comment to D43922: pcib: Assume a window where both the base and limit are 0 is uninitialized.
diff --git a/sys/riscv/sifive/fu740_pci_dw.c b/sys/riscv/sifive/fu740_pci_dw.c
index 13937e283042..d0490d6548f2 100644
--- a/sys/riscv/sifive/fu740_pci_dw.c
+++ b/sys/riscv/sifive/fu740_pci_dw.c
@@ -215,12 +215,6 @@ fupci_phy_init(struct fupci_softc *sc)
                return (error);
        }
Thu, Feb 15, 10:55 PM
jrtc27 added a comment to D40474: intrng: call pic_init_secondary on all registered PICs.

@jrtc27 not being on intimate terms with the GICv3 implementation and lacking hardware to confirm how things work, I've got no idea what to do. What I do know is the extra PIC for this device never gets into sc->gic_children and therefore the loop in gic_v3_init_secondary() doesn't work for this device.

Thu, Feb 15, 10:52 PM
jrtc27 added a comment to D43922: pcib: Assume a window where both the base and limit are 0 is uninitialized.

Well, I isolated it down to a single bootverbose that makes it work, but this just tells me it's almost certainly just because of the delay:

Thu, Feb 15, 8:44 PM
jrtc27 added a comment to D43922: pcib: Assume a window where both the base and limit are 0 is uninitialized.

Perhaps worth mentioning HiFive Unmatched somewhere in the description so there's a breadcrumb to follow for where this came from in the first place?

Thu, Feb 15, 7:17 PM
jrtc27 added a comment to D43922: pcib: Assume a window where both the base and limit are 0 is uninitialized.

s/VAR/BAR/ in the message.

Thu, Feb 15, 5:59 PM
jrtc27 added inline comments to D43918: netlink: Don't use a zero-length array.
Thu, Feb 15, 12:31 AM

Tue, Feb 13

jrtc27 added inline comments to D43860: reboot: Use posix_spawn instead of system.
Tue, Feb 13, 6:55 PM

Mon, Feb 12

jrtc27 added a comment to D43849: riscv: add firmware partitions to GENERICSD.conf.

Doing this for the Unmatched doesn’t seem very useful when we can’t use the SD card for our rootfs due to driver limitations. I’ve generally taken the view that the “correct” way to treat all these dev boards so far is to treat firmware as distinct, whether that means using on-board flash (and a normally-partitioned drive in any form) or a dedicated firmware SD card (and a normally-partitioned drive that’s not the same SD card). The Arm world is a mess with all the special firmware you need, and we should be pushing for standard EFI boot flows where the firmware is part of the board rather than the OS (even if we ship updates to it for convenience).

I really don't have the Unmatched in mind here; on that board it is easiest to use the memstick installer on a USB, and that's what I recommended in the wiki instructions. In other words, driver issues notwithstanding, I still wouldn't recommend GENERICSD for that board.

The problem I am trying to solve here is more related to the VF2, and conceivably other smaller SBCs where root-and-firmware-on-SD is desirable/common. Even in this development stage, trying to prep an SD card for this board is non-trivial. If I dd the GENERICSD image, I then need to rewrite the partition table in order to insert the firmware partitions at the correct indices (gpart cannot modify a partition's index). So, reserving these partitions is a pragmatic choice aiming to reduce the number of user-required steps to install with GENERICSD.

Btw, the choice to use hifive-fsbl and hifive-bbl as the default types is somewhat arbitrary. gpart has these type aliases, and the Unleashed came first of all, so it seems a fine choice.

Mon, Feb 12, 7:37 PM
jrtc27 added a comment to D43849: riscv: add firmware partitions to GENERICSD.conf.

Doing this for the Unmatched doesn’t seem very useful when we can’t use the SD card for our rootfs due to driver limitations.

Which driver ? ours ?

Mon, Feb 12, 7:31 PM
jrtc27 added a comment to D43849: riscv: add firmware partitions to GENERICSD.conf.

Doing this for the Unmatched doesn’t seem very useful when we can’t use the SD card for our rootfs due to driver limitations. I’ve generally taken the view that the “correct” way to treat all these dev boards so far is to treat firmware as distinct, whether that means using on-board flash (and a normally-partitioned drive in any form) or a dedicated firmware SD card (and a normally-partitioned drive that’s not the same SD card). The Arm world is a mess with all the special firmware you need, and we should be pushing for standard EFI boot flows where the firmware is part of the board rather than the OS (even if we ship updates to it for convenience).

Mon, Feb 12, 6:32 PM

Sat, Feb 10

jrtc27 updated the summary of D43806: arm: Set NEW_PCIB in DEFAULTS rather than a subset of kernel configs.
Sat, Feb 10, 7:09 PM
jrtc27 added a comment to D43806: arm: Set NEW_PCIB in DEFAULTS rather than a subset of kernel configs.
In D43806#999575, @jhb wrote:

s/SYS_RES_BUS/PCI_RES_BUS/ in commit log

Sat, Feb 10, 7:09 PM
jrtc27 committed rG89c3cc20d643: committers-src: Extremely belatedly add myself (authored by jrtc27).
committers-src: Extremely belatedly add myself
Sat, Feb 10, 6:08 AM
jrtc27 committed R9:07b41775923e: shared: Extremely belatedly add myself to committers list (authored by jrtc27).
shared: Extremely belatedly add myself to committers list
Sat, Feb 10, 5:51 AM

Fri, Feb 9

jrtc27 requested review of D43806: arm: Set NEW_PCIB in DEFAULTS rather than a subset of kernel configs.
Fri, Feb 9, 7:31 PM
jrtc27 committed rGc994f226bbd3: bsdinstall: Add new Auto option to netconfig interface selection dialog (authored by jrtc27).
bsdinstall: Add new Auto option to netconfig interface selection dialog
Fri, Feb 9, 6:26 PM
jrtc27 closed D43731: bsdinstall: Add new Auto option to netconfig interface selection dialog.
Fri, Feb 9, 6:25 PM

Wed, Feb 7

jrtc27 closed D43785: sysutils/u-boot-bhyve-arm64: Enable MBR and ISO9660 partition support.

Landed in ba5777140ec41aae909456f6da77e1b336f52fcb

Wed, Feb 7, 11:30 PM
jrtc27 added a comment to D43784: sysutils/u-boot-bhyve-arm64: Fix after the 2024.01 import.

I suspect this isn't the right approach long-term, but this works in my local testing. This will need U_BOOT_SLAVE_PORTREVISION_2024.01 to be set, but perhaps best to batch that with the patch I have and was trying to test when I encountered this regression?

FYI this is https://reviews.freebsd.org/D43785. I don't mind bumping the version again, but it does seem a little silly.

Oh, yes. Would you like to merge the patches and push? If not I'll take care of it now.

Wed, Feb 7, 5:21 PM
jrtc27 added a comment to D43784: sysutils/u-boot-bhyve-arm64: Fix after the 2024.01 import.

I suspect this isn't the right approach long-term, but this works in my local testing. This will need U_BOOT_SLAVE_PORTREVISION_2024.01 to be set, but perhaps best to batch that with the patch I have and was trying to test when I encountered this regression?

Wed, Feb 7, 5:04 PM
jrtc27 requested review of D43785: sysutils/u-boot-bhyve-arm64: Enable MBR and ISO9660 partition support.
Wed, Feb 7, 5:03 PM
jrtc27 accepted D43784: sysutils/u-boot-bhyve-arm64: Fix after the 2024.01 import.

I suspect this isn't the right approach long-term, but this works in my local testing. This will need U_BOOT_SLAVE_PORTREVISION_2024.01 to be set, but perhaps best to batch that with the patch I have and was trying to test when I encountered this regression?

Wed, Feb 7, 4:54 PM
jrtc27 committed rGb8afdda360e5: gicv3_its: Drop a couple of redundant vm_offset_t casts (authored by jrtc27).
gicv3_its: Drop a couple of redundant vm_offset_t casts
Wed, Feb 7, 4:40 PM

Tue, Feb 6

jrtc27 added a comment to D40474: intrng: call pic_init_secondary on all registered PICs.

@jrtc27 I was hoping for an answer to my question before doing anything.

I lack appropriate hardware to confirm this, but I suspect gic_v3_init_secondary() was already being called a second time for systems with both a normal PIC and a MSI PIC. As long as both were GICv3 implementations and one was a direct child of the other, the loop at the end of gic_v3_init_secondary() was doing this.

Tue, Feb 6, 8:16 PM

Mon, Feb 5

jrtc27 requested changes to D43755: bsdinstall: separate out dist selection in prep for pkgbase support.

I've tried to give this a more thorough review and found some issues. Please test it more thoroughly for the various different cases that arise.

Mon, Feb 5, 10:57 PM

Sun, Feb 4

jrtc27 added a comment to D43743: ctf*: exit with error upon terminate().

(and please also note in the commit message that #ifdef __FreeBSD__ for behavioural changes like this in bootstrap tools is incorrect now that we have cross-building from non-FreeBSD, i.e. that cross-building from macOS and Linux can currently fail when FreeBSD ignores the error)

Sun, Feb 4, 10:05 PM
jrtc27 added a comment to D43743: ctf*: exit with error upon terminate().

This is long overdue! Though terminate_cleanup needs unifdef'ing (introduced in the import itself in https://cgit.freebsd.org/src/tree/cddl/contrib/opensolaris/tools/ctf/cvt/ctfconvert.c?id=4cc75139b96639698b4e96da3b60cd3d81e9a959). Note this code itself came into the tree in https://cgit.freebsd.org/src/commit/?id=c01977ed3b6d325bae5de5025eb0c6357ee73be5, which is similarly undocumented in the commit message.

Sun, Feb 4, 10:03 PM
jrtc27 added a reviewer for D43731: bsdinstall: Add new Auto option to netconfig interface selection dialog: jhb.
Sun, Feb 4, 1:43 AM
jrtc27 requested review of D43731: bsdinstall: Add new Auto option to netconfig interface selection dialog.
Sun, Feb 4, 1:39 AM

Sat, Feb 3

jrtc27 committed rG1e75e61d5c2c: bsdinstall: Fix broken netconfig persistence for installed system (authored by jrtc27).
bsdinstall: Fix broken netconfig persistence for installed system
Sat, Feb 3, 11:12 PM
jrtc27 added inline comments to D43293: RISCV: Introduce support for APLIC interrupt controller.
Sat, Feb 3, 10:04 AM · riscv
jrtc27 committed rG7414d14bd51d: bsdinstall: Drop Error from title in netconfig no interfaces dialog (authored by jrtc27).
bsdinstall: Drop Error from title in netconfig no interfaces dialog
Sat, Feb 3, 2:01 AM
jrtc27 committed rGb809c7d6a269: bsdinstall: Fix netconfig script when no interfaces are present (authored by jrtc27).
bsdinstall: Fix netconfig script when no interfaces are present
Sat, Feb 3, 2:01 AM
jrtc27 added a reverting change for rG009d3f66cb5f: bsdinstall: separate out dist selection in prep for pkgbase support: rG7143521f4cbc: Revert "bsdinstall: separate out dist selection in prep for pkgbase support".
Sat, Feb 3, 1:32 AM
jrtc27 committed rG7143521f4cbc: Revert "bsdinstall: separate out dist selection in prep for pkgbase support" (authored by jrtc27).
Revert "bsdinstall: separate out dist selection in prep for pkgbase support"
Sat, Feb 3, 1:32 AM
jrtc27 added a reverting change for D43621: bsdinstall: separate out dist selection in prep for pkgbase support: rG7143521f4cbc: Revert "bsdinstall: separate out dist selection in prep for pkgbase support".
Sat, Feb 3, 1:32 AM

Fri, Feb 2

jrtc27 added inline comments to D43293: RISCV: Introduce support for APLIC interrupt controller.
Fri, Feb 2, 10:26 PM · riscv
jrtc27 added a reverting change for rGcd19ecdbdc87: Similar to r296013 for NO_ROOT, force SUBDIR_PARALLEL for buildworld WORLDTMP…: rGfbae308319b7: bsd.subdir.mk: Drop broken optimisation for realinstall parallelisation.
Fri, Feb 2, 9:19 PM
jrtc27 closed D43705: bsd.subdir.mk: Drop broken optimisation for realinstall parallelisation.
Fri, Feb 2, 9:18 PM
jrtc27 committed rGfbae308319b7: bsd.subdir.mk: Drop broken optimisation for realinstall parallelisation (authored by jrtc27).
bsd.subdir.mk: Drop broken optimisation for realinstall parallelisation
Fri, Feb 2, 9:18 PM
jrtc27 added a reverting change for rGcd19ecdbdc87: Similar to r296013 for NO_ROOT, force SUBDIR_PARALLEL for buildworld WORLDTMP…: D43705: bsd.subdir.mk: Drop broken optimisation for realinstall parallelisation.
Fri, Feb 2, 1:41 AM
jrtc27 requested review of D43705: bsd.subdir.mk: Drop broken optimisation for realinstall parallelisation.
Fri, Feb 2, 1:41 AM

Thu, Feb 1

jrtc27 added inline comments to D43293: RISCV: Introduce support for APLIC interrupt controller.
Thu, Feb 1, 11:28 AM · riscv
jrtc27 added inline comments to D32955: Retire unused non-PCI_RES_BUS code.
Thu, Feb 1, 1:29 AM

Wed, Jan 31

jrtc27 committed rGb771d5705fc9: tools/build/make.py: Avoid Python 3.7+ subprocess.run capture_output (authored by jrtc27).
tools/build/make.py: Avoid Python 3.7+ subprocess.run capture_output
Wed, Jan 31, 7:51 PM
jrtc27 added inline comments to D43293: RISCV: Introduce support for APLIC interrupt controller.
Wed, Jan 31, 7:13 PM · riscv
jrtc27 requested changes to D43293: RISCV: Introduce support for APLIC interrupt controller.
Wed, Jan 31, 7:13 PM · riscv
jrtc27 added inline comments to D43666: bhyve: Add support for XML register definitions.
Wed, Jan 31, 6:34 PM
jrtc27 added inline comments to D43666: bhyve: Add support for XML register definitions.
Wed, Jan 31, 6:33 PM
jrtc27 added inline comments to D43666: bhyve: Add support for XML register definitions.
Wed, Jan 31, 6:31 PM

Jan 30 2024

jrtc27 committed rG41eb4a4ca299: share/man: Add mandoc.db files to METALOG (authored by jrtc27).
share/man: Add mandoc.db files to METALOG
Jan 30 2024, 10:19 PM
jrtc27 committed rGce047ebf4848: etc: Set DISTBASE during distribute for sub-makes (authored by jrtc27).
etc: Set DISTBASE during distribute for sub-makes
Jan 30 2024, 10:19 PM
jrtc27 closed D43676: share/man: Add mandoc.db files to METALOG.
Jan 30 2024, 10:19 PM
jrtc27 closed D43675: etc: Set DISTBASE during distribute for sub-makes.
Jan 30 2024, 10:19 PM
jrtc27 added a comment to D42968: freebsd-update: Mention upgrading packages, not just ports.

Ping?

Jan 30 2024, 9:23 PM
jrtc27 requested review of D43676: share/man: Add mandoc.db files to METALOG.
Jan 30 2024, 9:22 PM
jrtc27 requested review of D43675: etc: Set DISTBASE during distribute for sub-makes.
Jan 30 2024, 9:22 PM
jrtc27 committed rG722b40377198: riscv: Remove the unused riscv64_cpu driver (authored by jrtc27).
riscv: Remove the unused riscv64_cpu driver
Jan 30 2024, 8:34 PM
jrtc27 closed D43672: riscv: Remove the unused riscv64_cpu driver.
Jan 30 2024, 8:34 PM
jrtc27 requested review of D43672: riscv: Remove the unused riscv64_cpu driver.
Jan 30 2024, 8:01 PM
jrtc27 added inline comments to D43621: bsdinstall: separate out dist selection in prep for pkgbase support.
Jan 30 2024, 7:27 PM
jrtc27 added inline comments to D43621: bsdinstall: separate out dist selection in prep for pkgbase support.
Jan 30 2024, 6:00 PM
jrtc27 requested changes to D43660: Replace boolean_t with bool.

This kind of diff is way too big to review, it needs to be broken up. It's easy to mass rename like this but a lot harder to verify that you've actually done the right thing. The second file I picked to look at the diff at was clearly not correct (see the comment linked to this), so that doesn't bode well for the rest of the diff. Also some of the NIC drivers in the tree are really vendor imports, so any changes like this that get made to them should make their way upstream, otherwise there is a risk they got lost. I have not checked if that applies here or not.

Jan 30 2024, 5:23 AM · Contributor Reviews (src)

Jan 29 2024

jrtc27 requested changes to D43254: libc: Remove support for pre-C11 C standards.
Jan 29 2024, 9:12 PM · Contributor Reviews (src)
jrtc27 added inline comments to D43621: bsdinstall: separate out dist selection in prep for pkgbase support.
Jan 29 2024, 2:55 AM

Jan 26 2024

jrtc27 updated the diff for D32955: Retire unused non-PCI_RES_BUS code.

Rebased. Build-tested with tinderbox -DWITHOUT_WORLDS -DMAKE_ALL_KERNELS.

Jan 26 2024, 2:02 AM
jrtc27 updated the diff for D32954: Retire non-NEW_PCIB code and remove config option.

Rebased. Build-tested with tinderbox -DWITHOUT_WORLDS -DMAKE_ALL_KERNELS.

Jan 26 2024, 1:24 AM
jrtc27 added inline comments to D43390: Add openat2 system call.
Jan 26 2024, 12:59 AM
jrtc27 closed D43066: ldscript.powerpc*: Only put .dynamic in PT_DYNAMIC.
Jan 26 2024, 12:19 AM
jrtc27 committed rG3896a6cc0a8e: ldscript.powerpc*: Only put .dynamic in PT_DYNAMIC (authored by jrtc27).
ldscript.powerpc*: Only put .dynamic in PT_DYNAMIC
Jan 26 2024, 12:19 AM

Jan 24 2024

jrtc27 committed rG6ec8bf9f3d17: riscv: Convert local interrupt controller to a newbus PIC (authored by jrtc27).
riscv: Convert local interrupt controller to a newbus PIC
Jan 24 2024, 11:52 PM
jrtc27 committed rGc55272fdf857: riscv: Create a newbus device for the SBI driver (authored by jrtc27).
riscv: Create a newbus device for the SBI driver
Jan 24 2024, 11:51 PM
jrtc27 closed D35901: riscv: Convert local interrupt controller to a newbus PIC.
Jan 24 2024, 11:51 PM
jrtc27 closed D35900: riscv: Create a newbus device for the SBI driver.
Jan 24 2024, 11:51 PM
jrtc27 closed D35899: intrng: Allow alternative IPI PICs to be registered and used.
Jan 24 2024, 11:51 PM
jrtc27 committed rG103d39efe0c6: intrng: Allow alternative IPI PICs to be registered and used (authored by jrtc27).
intrng: Allow alternative IPI PICs to be registered and used
Jan 24 2024, 11:51 PM
jrtc27 committed rGfae8755f16ff: intrng: Extract arm/arm64 IPI->PIC glue code (authored by jrtc27).
intrng: Extract arm/arm64 IPI->PIC glue code
Jan 24 2024, 11:51 PM
jrtc27 closed D35898: intrng: Extract arm/arm64 IPI->PIC glue code.
Jan 24 2024, 11:51 PM
jrtc27 closed D35897: intrng: Remove irq_root_ipicount and corresponding intr_pic_claim_root arg.
Jan 24 2024, 11:50 PM
jrtc27 committed rGe06afdb28569: intrng: Remove irq_root_ipicount and corresponding intr_pic_claim_root arg (authored by jrtc27).
intrng: Remove irq_root_ipicount and corresponding intr_pic_claim_root arg
Jan 24 2024, 11:50 PM

Jan 23 2024

jrtc27 added a comment to D43417: csu: add crtbrand.o dependency on sys/param.h.

What about if you just add the various .o files to DEPENDOBJS, to deal with the fact that doesn't happen automatically for FILES?

Jan 23 2024, 4:12 PM