Page MenuHomeFreeBSD
Differential D56865

Fix cross installworld with MK_LLVM_BINUTILS_BOOTSTRAP=no
Needs ReviewPublic
Actions

Authored by arichardson on Thu, May 7, 5:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 18, 6:52 AM
Unknown Object (File)
Sun, May 17, 8:55 AM
Unknown Object (File)
Sat, May 16, 8:13 PM
Unknown Object (File)
Thu, May 14, 12:17 AM
Unknown Object (File)
Wed, May 13, 6:42 PM
Unknown Object (File)
Tue, May 12, 2:45 PM
Unknown Object (File)
Tue, May 12, 2:32 PM
Unknown Object (File)
Mon, May 11, 4:25 PM
View All 14 Files
Subscribers
imp

Details

Reviewers
emaste
jrtc27
Summary

If we did not build a bootstrap strip binary installworld will fail to
link strip to the temporary directory since WORLDTMP does not contain it.
We could link all the XBINUTILS to WORLDTMP so that this works, but since
we only need strip during installworld this approach seemed simpler.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 72870
Build 69753: arc lint + arc unit

Event Timeline

arichardson created this revision.Thu, May 7, 5:05 AM
Herald added a subscriber: imp. · View Herald TranscriptThu, May 7, 5:05 AM
Harbormaster completed remote builds in B72870: Diff 177350.Thu, May 7, 5:05 AM
arichardson requested review of this revision.Thu, May 7, 5:05 AM
jrtc27 added a comment.Thu, May 7, 9:09 AM

But won’t we have built elftoolchain strip in that case?

arichardson added a comment.Thu, May 7, 5:15 PM
In D56865#1302516, @jrtc27 wrote:

But won’t we have built elftoolchain strip in that case?

Seems like we didn't in my case, let me check if that is an explicit disable or the default. Or maybe we don't add the links anymore?

Revision Contents
Changeset List

PathSize
9 lines

Diff 177350

View Options

Makefile.inc1

Loading...