Fix cross installworld with MK_LLVM_BINUTILS_BOOTSTRAP=no

[arichardson]

Summary

If we did not build a bootstrap strip binary installworld will fail to
link strip to the temporary directory since WORLDTMP does not contain it.
We could link all the XBINUTILS to WORLDTMP so that this works, but since
we only need strip during installworld this approach seemed simpler.

[jrtc27]

But won’t we have built elftoolchain strip in that case?

[arichardson]

In D56865#1302516, @jrtc27 wrote:

But won’t we have built elftoolchain strip in that case?

Seems like we didn't in my case, let me check if that is an explicit disable or the default. Or maybe we don't add the links anymore?

[arichardson]

In D56865#1302643, @arichardson wrote:

In D56865#1302516, @jrtc27 wrote:

But won’t we have built elftoolchain strip in that case?

Seems like we didn't in my case, let me check if that is an explicit disable or the default. Or maybe we don't add the links anymore?

I get this error even with an explicit WITH_ELFTOOLCHAIN_BOOTSTRAP. Because I am also building with MK_LLVM_BINUTILS=no. So it sounds like either usr.bin/elfcopy needs another check for BOOTSTRAPPING, or we use this change (or possibly both fixes)? @emaste what do you think?

[arichardson]

Fix elfcopy install condition

[jrtc27]

In D56865#1312084, @arichardson wrote:

In D56865#1302643, @arichardson wrote:

In D56865#1302516, @jrtc27 wrote:

But won’t we have built elftoolchain strip in that case?

Seems like we didn't in my case, let me check if that is an explicit disable or the default. Or maybe we don't add the links anymore?

I get this error even with an explicit WITH_ELFTOOLCHAIN_BOOTSTRAP. Because I am also building with MK_LLVM_BINUTILS=no. So it sounds like either usr.bin/elfcopy needs another check for BOOTSTRAPPING, or we use this change (or possibly both fixes)? @emaste what do you think?

I don't see how sentence two implies sentence one. What is your exact config, between command-line arguments, environment variables, and /etc/{src,src-env,make}.conf?

[jrtc27]

usr.bin/elfcopy/Makefile

16

This bit makes sense to me, I'll have to try and reproduce that, should be easy with BUILD_WITH_STRICT_TMPPATH