LGTM, thanks!

In D56591#1296034, @khorben wrote:

In D56591#1295928, @khorben wrote:

The latest update (with WARNS?=3) built correctly with clang; I am still testing with GCC 14.

It built correctly with GCC 14 as well.

Reverted the copyright to myself, and the license to ISC.

In D56589#1296262, @ngie wrote:

In D56589#1296252, @khorben wrote:

I gave the copyright back to pkgconf, as the comment and description primarily come from the pkgconf project.

While there, I also updated the SPDX-License-Identifier to pkgconf, as per the discussion here, and confirmed at https://spdx.org/licenses/pkgconf.html.

Does that mean that you need to credit DuckDuckGo or Google whenever you find a result?

I gave the copyright back to pkgconf, as the comment and description primarily come from the pkgconf project.

Updated the copyright, license text, and added the licenses = [ "pkgconf" ] as per ngie's advice; thank you!

In D56591#1295928, @khorben wrote:

The latest update (with WARNS?=3) built correctly with clang; I am still testing with GCC 14.

This is already in D56589; which version is best?

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=294724 confirms this patch to be fixing the build issue.

The latest update (with WARNS?=3) built correctly with clang; I am still testing with GCC 14.

Disable stricter warnings for the moment for libpkgconf, bomtool(1), and pkgconf(1) as suggested by ngie. Thanks!

This should address feedback from ivy:

Imported in 6294b6ab217a2d5f1d2bc23a64505a228294c508.

This addresses feedback from ivy, moving /usr/include/pkgconf into the pkgconf-dev package.
It also adds the files in /usr/include/pkgconf to the list of obsolete files when disabling the pkgconf option.

This update addresses feedback from bapt, more precisely:

In D56373#1291176, @bapt wrote:

I don't understand the point of merging both version why not only the latest ?

This patch adds /usr/local/etc/pkgconfig/personality.d to -DPERSONALITY_PATH in lib/libpkgconfig/Makefile, as requested by bapt at https://ron-dev.freebsd.org/FreeBSD/src/pulls/9.

This depends on the vendor import from D56373.

See also https://github.com/freebsd/freebsd-src/pull/1994 for a more complete draft pull-request and discussion around this project, together with a preview of the "finished product".
There is also a newer branch implementing the same on a more recent main, at https://github.com/khorben/freebsd-src/tree/khorben/spdxtool2.

This seems to do the trick for me too, testing on macOS/amd64; it does not seem to harm FreeBSD/amd64.

I offered the same patch in D51897, with:

Should we involve secteam@ regarding the extra algorithms enabled?
I am not aware of any security concern there as of today, but I think we had stuck with OpenSSL's own list of default algorithms so far for the base system.

In D51897#1186369, @ngie wrote:

This is sort of what the SRCS should be in libcrypto.so: https://gist.github.com/ngie-eign/e3fb2de6dc32bdfddb9be119058c4792 (it's not a complete picture, but it's a start).

In D51897#1186364, @ngie wrote:

params_idx.c is missing from secure/lib/libcrypto/Makefile. That's where the source should be plugged in (not the legacy provider).

Committed as e7be843b4a162e68651d3911f0357ed464915629 and 4757b351ea9d59d71d4a38b82506d2d16fcd560d.

Note that I have reservations about the part adding params_idx.c to the list of files built: from what I can tell, OpenSSL expects this to be available from libcrypto.so, instead of a copy inside the legacy provider module.
I suspect the more correct fix is to add the ossl_param_find_pidx to secure/lib/libcrypto/Version.map instead - which also kinda feels wrong.

In D47933#1185773, @carlavilla wrote:

@khorben_defora.org can I commit this?
For me is ok

Got 32-bit PowerPC to build.

I am now trying to build 32-bit PowerPC with this set in secure/lib/libcrypto/Makefile.common:

In D51613#1178895, @philip wrote:

I don't think PowerPC 32 failing is a blocker for main or stable/15: we're ending support for 32 bit platforms. Do we ever plan to merge this to stable/14 though?

I think this diff should also update secure/lib/libcrypto/Makefile.inc with the corresponding OPENSSL_VER and OPENSSL_DATE.

Even though I have the approval of my mentor, it would be great to have approval from the installer group for this change before I proceed with the commit.
Please let me know!

I have managed to rebase the diff, and tested both jail and auto with bsdinstall.
This also simplifies the save/restore functions as suggested.

• Re-indented the case statement
• Added a check for empty passwords
• Reworked error management

I have added everyone on the de-facto installer group that met on Monday; sorry for the noise.
(Should we create a Phabricator group for us? Apologies if I did not find it)

Also noteworthy in terms of UX:

• With bsddialog, the <TAB> key will go straight from the first input field to the [ OK ] button; the "arrow down" key should be used instead.
• Entering a mismatching password resets both password fields. (Like the passwd(8) command)
• This does not allow setting an empty password; it then fails with error Incorrect input data. (This is unlike the passwd(8) command)

This could be frustrating to some users.

I am revisiting this revision for the following reasons:

Since I am not a doc committer, I have pushed a copy of this commit at https://github.com/khorben/freebsd-doc/tree/khorben/new-committer for convenience.

Reflect the new expiration date for the PGP/GPG key, after passing the documentation/tools/checkkey.sh test.

Thanks Tom for the patch! I have managed to test it on top of ecb3a7d43dd6: