Thanks Tom for the patch! I have managed to test it on top of ecb3a7d43dd6:

In D49085#1123179, @jrm wrote:

It fails to build. Do you need a dependency on multimedia/v4l_compat?

Register missing dependency on multimedia/v4l_compat.

Also include the distinfo file; thanks for the heads up!

You are right, the old scheme is less confusing.
The changes proposed here look correct to me.

Updated to compile and work with the new ifabi changes.

Thanks for the heads up! Looking into it...

Integrate suggestions from Zhenlei Huang (zlei@); thank you!

In D48167#1103394, @ziaee wrote:

I'm so excited to test this driver this weekend! Thank you so much for submitting this! All of the suggestions I made are to bring it into alignment with the rest of the freebsd manual and are specified in the manual page style guide, style.mdoc(5). Sorry I'm so late.

This change applies the rest of the changes suggested to the manual pages.

This update to the diff brings:

In D48167#1103157, @khorben_defora.org wrote:

I am currently looking into adding the SPDX license identifier, but it can also be done in a separate review.

In D48167#1103156, @adrian wrote:

I think it's fine as-is to go in the tree, it's been two years and I'd like to see this in before -15.

Address feedback from lwhsu@; thanks!

In D47933#1093012, @concussious.bugzilla_runbox.com wrote:

Oops! You're right. I don't think the field descriptions help it though, the fields are very self explanatory but the comments adds bikeshedable language? This is really an architectural decision for secteam, will certainly result in increased spam, but maybe helpful. So, I'll bow out now.

Also note that the contents of this file can be signed with an OpenPGP clear-text signature by the security team, in order to clearly authenticate it as legitimate.

Add descriptions of the fields used, as per the example from securitytxt.org.

In D47933#1092988, @concussious.bugzilla_runbox.com wrote:

I really like this concept.
Why are there two policy lines?

Removed the (optional) links for "any security-related job openings in your organisation."

Moved the sanity check for len to the beginning of pci_vtcon_control_send().

In D45401#1053575, @corvink wrote:

What's CID: 1521334?

In D42146#1052635, @imp wrote:

So now that we build a smaller loader in general, do we need to build another loader for this?

Would it be more clear or accurate to mention the "Pentium MMX" instead or in addition to the Pentium Pro?
It was much more common and known to the public than the Pentium Pro.

This avoids an issue with makefs(8) when building without a manifest file. (e.g., when building as root)
Consequently it should work both when using a manifest file as well as without, although it still requires root privileges in both cases, for e.g., chroot(8) and mount(8).

In D44670#1018389, @jrtc27 wrote:

Why do we need a copy of this code rather than just tweaking bsdconfig to support this?

Also updated bin/freebsd-version/freebsd-version.1.

In D42433#968563, @imp wrote:

remove /sys

Focus on D42146 instead.

This updated diff:

Should I rebase this patch since D42194 is already merged?

I rebased and updated the commit with the full message at https://github.com/khorben/freebsd-src/tree/khorben/tzsetup-extra.

Thanks; this is now ready to merge from https://github.com/khorben/freebsd-src/tree/khorben/bsdinstall.

(I did not mean to remove any reviewer, I guess I re-used an old browser tab without refreshing)

This is in the khorben/bsdinstall-netconfig branch at https://github.com/khorben/freebsd-src/.

This is in the khorben/bsdinstall-netconfig branch at https://github.com/khorben/freebsd-src/.

This is also related to #192194.

(If you don't mind)

Imported in 315108b81694de474bbc273c0050b195047f5eed.

• This now uses break to be more future-proof
• The commit message now mentions the change in behaviour when selecting unknown actions

• Made "Finish" the default action
• Renamed the "OK" button to "Select"

In D42047#959636, @jrtc27 wrote:

Every additional keypress required, especially ones for navigating to the right option, makes an already user-hostile installer have even more friction. I am very strongly opposed to not being able to quickly skip through screens that 99.999999% of users do not need.

In D42047#958942, @jrtc27 wrote:

Is the new Finish button selected by default?

Replaced by D42046 and D42047.

In D41945#958461, @emaste wrote:

test for existence of file before removing

to avoid spurious errors

Looks good to me.

Sounds good to me then!

I found information confirming my doubts about the keccak code.

Can you review the comment I added about crypto/sha/asm/keccak1600-armv8.pl?

We may also want to consider 40c24d74deaad8a0ad7566a68ea5ea757bc3ccef as well, from OpenSSL's Git repository: