In D45401#1053575, @corvink wrote:What's CID: 1521334?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Sun, Sep 8
Sun, Sep 8
Aug 2 2024
Aug 2 2024
Aug 1 2024
Aug 1 2024
In D42146#1052635, @imp wrote:So now that we build a smaller loader in general, do we need to build another loader for this?
Jun 25 2024
Jun 25 2024
khorben_defora.org added a comment to D45734: platforms/i386: report Pentium Pro as minimum supported x86 processor.
Would it be more clear or accurate to mention the "Pentium MMX" instead or in addition to the Pentium Pro?
It was much more common and known to the public than the Pentium Pro.
Jun 14 2024
Jun 14 2024
Jun 4 2024
Jun 4 2024
khorben_defora.org updated the diff for D45000: release: create a bootable image with the graphical installer.
This avoids an issue with makefs(8) when building without a manifest file. (e.g., when building as root)
Consequently it should work both when using a manifest file as well as without, although it still requires root privileges in both cases, for e.g., chroot(8) and mount(8).
May 29 2024
May 29 2024
May 16 2024
May 16 2024
Apr 29 2024
Apr 29 2024
khorben_defora.org requested review of D45000: release: create a bootable image with the graphical installer.
Apr 7 2024
Apr 7 2024
In D44670#1018389, @jrtc27 wrote:Why do we need a copy of this code rather than just tweaking bsdconfig to support this?
khorben_defora.org requested review of D44671: bsdinstall: allow forcing a specific partitioning mode.
Mar 8 2024
Mar 8 2024
Dec 29 2023
Dec 29 2023
Also updated bin/freebsd-version/freebsd-version.1.
Dec 13 2023
Dec 13 2023
khorben_defora.org added inline comments to D43009: kerberos: Fix numerous segfaults when using weak crypto.
Nov 2 2023
Nov 2 2023
In D42433#968563, @imp wrote:remove /sys
Oct 27 2023
Oct 27 2023
Focus on D42146 instead.
khorben_defora.org retitled D42281: bsdinstall: restore the environment when restarting from bsdinstall: reset the environment when restarting to bsdinstall: restore the environment when restarting.
khorben_defora.org updated the diff for D42281: bsdinstall: restore the environment when restarting.
This updated diff:
Oct 19 2023
Oct 19 2023
khorben_defora.org added a reviewer for D42281: bsdinstall: restore the environment when restarting: jrtc27.
Should I rebase this patch since D42194 is already merged?
Oct 18 2023
Oct 18 2023
khorben_defora.org updated the summary of D42281: bsdinstall: restore the environment when restarting.
khorben_defora.org added a reviewer for D42281: bsdinstall: restore the environment when restarting: bapt.
Oct 13 2023
Oct 13 2023
I rebased and updated the commit with the full message at https://github.com/khorben/freebsd-src/tree/khorben/tzsetup-extra.
Thanks; this is now ready to merge from https://github.com/khorben/freebsd-src/tree/khorben/bsdinstall.
(I did not mean to remove any reviewer, I guess I re-used an old browser tab without refreshing)
khorben_defora.org added a comment to D42194: [PATCH 2/2] netconfig: avoid duplicate entries in rc.conf.
This is in the khorben/bsdinstall-netconfig branch at https://github.com/khorben/freebsd-src/.
This is in the khorben/bsdinstall-netconfig branch at https://github.com/khorben/freebsd-src/.
khorben_defora.org removed a reviewer for D42183: bsdinstall: reset the mirror when restarting: bapt.
This is also related to #192194.
khorben_defora.org requested review of D42194: [PATCH 2/2] netconfig: avoid duplicate entries in rc.conf.
khorben_defora.org requested review of D42193: [PATCH 1/2] netconfig: report configuration failures.
Oct 12 2023
Oct 12 2023
khorben_defora.org added a reviewer for D41306: tzsetup: add support for countries in two continents: bapt.
khorben_defora.org added a reviewer for D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step: bapt.
khorben_defora.org added a reviewer for D42046: [PATCH 1/2] bsdinstall: revisit the finalconfig step: bapt.
Oct 10 2023
Oct 10 2023
Oct 8 2023
Oct 8 2023
khorben_defora.org added a reviewer for D41250: hardening: remember the answers to each item: jrtc27.
(If you don't mind)
Imported in 315108b81694de474bbc273c0050b195047f5eed.
khorben_defora.org updated the diff for D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step.
- This now uses break to be more future-proof
- The commit message now mentions the change in behaviour when selecting unknown actions
khorben_defora.org added inline comments to D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step.
Oct 4 2023
Oct 4 2023
khorben_defora.org updated the diff for D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step.
- Made "Finish" the default action
- Renamed the "OK" button to "Select"
In D42047#959636, @jrtc27 wrote:Every additional keypress required, especially ones for navigating to the right option, makes an already user-hostile installer have even more friction. I am very strongly opposed to not being able to quickly skip through screens that 99.999999% of users do not need.
In D42047#958942, @jrtc27 wrote:Is the new Finish button selected by default?
Oct 2 2023
Oct 2 2023
khorben_defora.org requested review of D42047: [PATCH 2/2] bsdinstall: revisit the finalconfig step.
khorben_defora.org updated the summary of D42046: [PATCH 1/2] bsdinstall: revisit the finalconfig step.
khorben_defora.org requested review of D42046: [PATCH 1/2] bsdinstall: revisit the finalconfig step.
khorben_defora.org added inline comments to D41945: freebsd-update: handle directories changing to files, too.
khorben_defora.org added inline comments to D42033: freebsd-update: recreate /var/db/freebsd-update if missing.
khorben_defora.org added a comment to D41945: freebsd-update: handle directories changing to files, too.
In D41945#958461, @emaste wrote:test for existence of file before removing
to avoid spurious errors
khorben_defora.org added inline comments to D41945: freebsd-update: handle directories changing to files, too.
Sep 22 2023
Sep 22 2023
Looks good to me.
Sounds good to me then!
khorben_defora.org added a comment to D41940: aarch64: support BTI and pointer authentication in assembly.
I found information confirming my doubts about the keccak code.
khorben_defora.org requested changes to D41940: aarch64: support BTI and pointer authentication in assembly.
Can you review the comment I added about crypto/sha/asm/keccak1600-armv8.pl?
khorben_defora.org added a comment to D41940: aarch64: support BTI and pointer authentication in assembly.
We may also want to consider 40c24d74deaad8a0ad7566a68ea5ea757bc3ccef as well, from OpenSSL's Git repository:
khorben_defora.org added a comment to D41940: aarch64: support BTI and pointer authentication in assembly.
FWIW this patch does not conflict with the import of OpenSSL 3.0.11 that I am currently preparing (vendor import in D41943).
Sep 18 2023
Sep 18 2023
I have the impression that with these changes, pxeldr will fail to build if MK_LOADER_LUA is not enabled. I am preparing a new patch where SUBDIR_DEPEND_pxeldr+= loader_lua_nozfs is protected by .if ${MK_LOADER_LUA} != "no", but then pxeldr is still hard-coded to L=loader_lua_nozfs; that feels wrong.
Sep 15 2023
Sep 15 2023
khorben_defora.org requested review of D41879: libcrypto: link engines and the legacy provider to libcrypto.
Sep 14 2023
Sep 14 2023
Also build aes-586.S for i386.
Sep 13 2023
Sep 13 2023
- Created a single new loader variant, loader_lua_nozfs
- Hard-coded the PXE loader to use loader_lua_nozfs instead of loader_${LOADER_INTERP}
Sep 6 2023
Sep 6 2023
Sep 4 2023
Sep 4 2023
Submitted again after rebase on -CURRENT.
Sep 1 2023
Sep 1 2023
khorben_defora.org abandoned D41668: libcrypto: Further improve Makefile.asm to avoid temporary files.
You are right, with a better look I also see differences with the SHA512 files.
Aug 31 2023
Aug 31 2023
khorben_defora.org added reviewers for D41668: libcrypto: Further improve Makefile.asm to avoid temporary files: jhb, emaste.
khorben_defora.org updated the summary of D41668: libcrypto: Further improve Makefile.asm to avoid temporary files.
khorben_defora.org updated the diff for D41306: tzsetup: add support for countries in two continents.
khorben_defora.org updated the diff for D41306: tzsetup: add support for countries in two continents.
- Renamed the new member of struct country
- Use a switch/case for pass 1 to 3
Aug 29 2023
Aug 29 2023
khorben_defora.org requested changes to D41589: libcrypto: Refactor Makefile.asm so it can be run outside of buildenv.
In my tests the output is identical with and without this revision, except for avoiding the generation of temporary files on i386.
ISTM that the same optimization is possible on arm64, arm, and powerpc{,64,64le} as well by the way; would you consider applying it there as well?
Here is how I test locally: (from secure/lib/libcrypto)
#!/bin/sh
khorben_defora.org accepted D41588: Makefile.asm: Simplify variable expansions in generated headers.
To me this looks tidier and also more sensible than before; indeed, why did it set the suffix to .pl only to remove it and add it again?
Aug 7 2023
Aug 7 2023
khorben_defora.org added a reviewer for D41250: hardening: remember the answers to each item: emaste.
khorben_defora.org added a reviewer for D41306: tzsetup: add support for countries in two continents: emaste.
In D41298#940467, @jrtc27 wrote:If you're moving code around and modifying it at the same time, please make two commits / revisions so it's much easier to review what's going on. Otherwise you have to flick back and forth between files.
Aug 3 2023
Aug 3 2023
khorben_defora.org updated the test plan for D41306: tzsetup: add support for countries in two continents.
khorben_defora.org requested review of D41306: tzsetup: add support for countries in two continents.
Re-upload with arc this time (for context)
In D41250#939437, @khorben_defora.org wrote:In D41250#939432, @mhorne wrote:FYI: D40142
I do not know what the hesitation is there, but I know several people would prefer to see this menu disappear completely.
Thanks, I wasn't aware of this proposal. I can probably improve this patch some more, so that the default settings from the current installation are reflected.
Respect the original copyright for the "finalconfig" code.