Page MenuHomeFreeBSD

bsdinstall: reset the mirror when restarting
ClosedPublic

Authored by khorben_defora.org on Oct 12 2023, 9:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 17, 6:36 PM
Unknown Object (File)
Fri, Jun 14, 12:24 PM
Unknown Object (File)
May 3 2024, 8:34 AM
Unknown Object (File)
May 3 2024, 8:34 AM
Unknown Object (File)
May 1 2024, 11:35 AM
Unknown Object (File)
Apr 27 2024, 10:37 PM
Unknown Object (File)
Apr 27 2024, 10:14 PM
Unknown Object (File)
Apr 27 2024, 7:40 PM
Subscribers

Details

Summary

It is possible to restart the installation process upon errors, when installing normally through the auto script, or when setting up a jail with the jail script. However, some values obtained interactively from the user or guessed by some scripts are kept in the environment when restarting the process; this makes it impossible to run some steps as expected after the restart.

For instance, if a bad choice of mirror was made in the mirrorselect phase, restarting the installer remembers the choice made, and will never prompt for a different one. Rebooting is then the only easy way out of this situation.

This change only affects the jail script for now, as otherwise there is no way to tell if the value had been specifically set by the user before starting bsdinstall.

Test Plan
# bsdinstall jail
[...]
[choose a mirror that doesn't work]
[...]
[choose restart]
[loop straight back into the abort dialog]

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Oct 12 2023, 9:15 PM
This revision now requires review to proceed.Oct 13 2023, 4:01 PM

(I did not mean to remove any reviewer, I guess I re-used an old browser tab without refreshing)

This revision was not accepted when it landed; it landed in state Needs Review.Oct 13 2023, 4:33 PM
This revision was automatically updated to reflect the committed changes.