User Details
- User Since
- Mar 22 2019, 4:46 AM (320 w, 4 d)
Yesterday
LGTM with one tweak.
Approved.
Tue, May 6
Thanks.
Mon, May 5
Fri, May 2
Thanks all for the input. Let us proceed here. Having spoken with the interested parties, I plan to handle the follow-up change describing the driver provenance.
Thu, May 1
Wed, Apr 30
Add #ifdef FDT conditionals around mii_fdt.h inclusion and the call to mcommphy_yt8531_setup_delay().
Tue, Apr 29
@jsihv_gmx.com you might have seen, I merged this functionality but had to revert as it broke the build on amd64 (!FDT). Here is an updated version which addresses this.
Thanks, this is great.
Mon, Apr 28
Commit LGTM, if someone confirms the factual accuracy.
Thu, Apr 24
Approved.
Apr 3 2025
Apr 2 2025
Apr 1 2025
Okay, I looked through the code again in detail and things seem good to me.
Mar 29 2025
Mar 28 2025
Indeed, I did not read it closely enough :)
Aside from the warning, this should be a no-op, as the only thing gated behind this knob on the kernel side is sys/modules/efirt, which still has an additional MACHINE_CPUARCH check around it.
IMO it is logically preferable to exhaust all unique/unused IDs before issuing one that was previously assigned, then freed. This is how the current code behaves.
Mar 25 2025
FYI, it is difficult to review a change that reorders and rewords a list of entries, at the same time. In the future such a thing should be split.
git -C /usr/src pull, as you say in the title.
Mar 24 2025
Mar 21 2025
"show two examples in PORTS_MODULES so it's obvious that they're space separated", can you note something like this in the commit message?
LGTM, and Approved.
Mar 19 2025
I ask once again to be mindful of your use of the commit trailers here... The commit does not require "approval" from @shurd, but as the author of the man page (its de-facto maintainer), his "Reviewed by" is meaningful.
Mar 18 2025
Superseded by aaf0a7302d10.
Superseded by c0bed9bd0bda.
Superseded by c0bed9bd0bda.
Superseded by c0bed9bd0bda .
Mar 17 2025
Mar 12 2025
Mar 4 2025
Mar 3 2025
Feb 25 2025
Simplify license text (use SPDX/remove boilerplate).
Can you confirm the git author field?