Page MenuHomeFreeBSD

mhorne (Mitchell Horne)
User

Projects

User Details

User Since
Mar 22 2019, 4:46 AM (165 w, 12 h)

Recent Activity

Wed, May 18

mhorne added a comment to D35222: Add kern.reboot_on_halt sysctl.

I guess you were burnt by this problem @trasz? ;)

Wed, May 18, 2:31 PM

Mon, May 16

mhorne committed R10:65c10f12df1c: vt: use TERMINAL_DECLARE_EARLY() macro (authored by mhorne).
vt: use TERMINAL_DECLARE_EARLY() macro
Mon, May 16, 1:53 PM
mhorne committed R10:e22111893089: aw_wdog: support Allwinner D1 watchdog (authored by julien.cassette_gmail.com).
aw_wdog: support Allwinner D1 watchdog
Mon, May 16, 1:53 PM
mhorne committed R10:13033a1549e0: riscv: add iicbus and iicoc to GENERIC (authored by philip).
riscv: add iicbus and iicoc to GENERIC
Mon, May 16, 1:53 PM
mhorne committed R10:fe1c0e6d2af0: cgem: support SGMII PHY connection mode (authored by bsd_dino.sk).
cgem: support SGMII PHY connection mode
Mon, May 16, 1:53 PM
mhorne committed R10:a1785a30090c: cgem: rework hardware quirk detection (authored by bsd_dino.sk).
cgem: rework hardware quirk detection
Mon, May 16, 1:53 PM
mhorne committed R10:0decce4326ec: savecore: factor out info file handling (authored by mhorne).
savecore: factor out info file handling
Mon, May 16, 1:52 PM
mhorne committed R10:274e8fff3162: savecore: decrease filename buffer sizes (authored by mhorne).
savecore: decrease filename buffer sizes
Mon, May 16, 1:52 PM
mhorne committed R10:1961b4605913: savecore: fold maxdumps check into getbounds() (authored by mhorne).
savecore: fold maxdumps check into getbounds()
Mon, May 16, 1:51 PM

Sat, May 14

mhorne committed R10:6543fa5a5c47: dumpon: warn if the configured netdump link is down (authored by mhorne).
dumpon: warn if the configured netdump link is down
Sat, May 14, 1:29 PM
mhorne committed R10:a84bf5eaa10c: debugnet: fix an errant assertion (authored by mhorne).
debugnet: fix an errant assertion
Sat, May 14, 1:29 PM
mhorne committed R10:38a36057ae56: netdump: check the support status of the interface (authored by mhorne).
netdump: check the support status of the interface
Sat, May 14, 1:29 PM
mhorne closed D35196: dumpon: warn if the configured netdump link is down.
Sat, May 14, 1:28 PM
mhorne closed D35179: debugnet: fix an errant assertion.
Sat, May 14, 1:28 PM
mhorne closed D35180: netdump: check the support status of the interface.
Sat, May 14, 1:28 PM

Fri, May 13

mhorne requested review of D35196: dumpon: warn if the configured netdump link is down.
Fri, May 13, 5:02 PM
mhorne added a comment to D35180: netdump: check the support status of the interface.

Hmmm I note that dumpon(8) also expects to receive ENXIO if the interface is not up, so we could add that check here too.

Where do we do that today? I see the ENXIO check in dumpon but can't see the corresponding IFF_UP check in the kernel.

Fri, May 13, 1:55 PM
mhorne committed R10:db71383b8836: kerneldump: remove physical from dump routines (authored by mhorne).
kerneldump: remove physical from dump routines
Fri, May 13, 1:45 PM
mhorne committed R10:489ba2223676: kerneldump: remove physical argument from d_dumper (authored by mhorne).
kerneldump: remove physical argument from d_dumper
Fri, May 13, 1:45 PM
mhorne committed R10:0f50da2e09b7: Drop d_dump from struct cdevsw (authored by mhorne).
Drop d_dump from struct cdevsw
Fri, May 13, 1:45 PM
mhorne closed D35174: kerneldump: remove physical from dump routines.
Fri, May 13, 1:45 PM
mhorne closed D35173: kerneldump: remove physical argument from d_dumper.
Fri, May 13, 1:45 PM
mhorne closed D35172: Drop d_dump from struct cdevsw.
Fri, May 13, 1:45 PM

Thu, May 12

mhorne added a comment to D35180: netdump: check the support status of the interface.

Hmmm I note that dumpon(8) also expects to receive ENXIO if the interface is not up, so we could add that check here too.

Thu, May 12, 8:27 PM
mhorne updated the test plan for D35180: netdump: check the support status of the interface.
Thu, May 12, 3:48 PM
mhorne requested review of D35180: netdump: check the support status of the interface.
Thu, May 12, 3:47 PM
mhorne requested review of D35179: debugnet: fix an errant assertion.
Thu, May 12, 3:47 PM

Wed, May 11

mhorne closed D35171: sysutils/u-boot-sifive-fu740: add new port.
Wed, May 11, 5:43 PM
mhorne committed R11:14d576f78a29: sysutils/u-boot-sifive-fu740: add new port (authored by mhorne).
sysutils/u-boot-sifive-fu740: add new port
Wed, May 11, 5:43 PM
mhorne updated the test plan for D35174: kerneldump: remove physical from dump routines.
Wed, May 11, 5:30 PM
mhorne requested review of D35174: kerneldump: remove physical from dump routines.
Wed, May 11, 5:29 PM
mhorne requested review of D35173: kerneldump: remove physical argument from d_dumper.
Wed, May 11, 5:29 PM
mhorne updated the diff for D35172: Drop d_dump from struct cdevsw.

Fix a typo: void ** -> void *

Wed, May 11, 3:13 PM
mhorne requested review of D35172: Drop d_dump from struct cdevsw.
Wed, May 11, 3:10 PM
mhorne requested review of D35171: sysutils/u-boot-sifive-fu740: add new port.
Wed, May 11, 2:25 PM

Fri, May 6

mhorne closed D34820: vt: use TERMINAL_DECLARE_EARLY() macro.
Fri, May 6, 5:28 PM
mhorne committed R10:ff1c8af8c349: vt: use TERMINAL_DECLARE_EARLY() macro (authored by mhorne).
vt: use TERMINAL_DECLARE_EARLY() macro
Fri, May 6, 5:28 PM

Wed, Apr 27

mhorne added a comment to D35074: Add MODULE_PNP_INFO() to rtsx.

Nice to see this. Perhaps a follow-up change removing rtsx from amd64/i386 GENERIC configs would be appropriate?

Wed, Apr 27, 3:02 PM

Apr 18 2022

mhorne committed R10:0a5c04a8926e: savecore: add an option to save a live minidump (authored by mhorne).
savecore: add an option to save a live minidump
Apr 18 2022, 3:57 PM
mhorne committed R10:cf02cf8dbfe7: savecore: factor out info file handling (authored by mhorne).
savecore: factor out info file handling
Apr 18 2022, 3:57 PM
mhorne committed R10:fafeb5342b64: savecore: decrease filename buffer sizes (authored by mhorne).
savecore: decrease filename buffer sizes
Apr 18 2022, 3:57 PM
mhorne committed R10:4243d307d397: savecore: fold maxdumps check into getbounds() (authored by mhorne).
savecore: fold maxdumps check into getbounds()
Apr 18 2022, 3:57 PM
mhorne closed D34347: savecore: add an option to save a live minidump.
Apr 18 2022, 3:57 PM
mhorne closed D34822: savecore: factor out info file handling.
Apr 18 2022, 3:57 PM
mhorne closed D34821: savecore: decrease filename buffer sizes.
Apr 18 2022, 3:57 PM
mhorne closed D34783: savecore: fold maxdumps check into getbounds().
Apr 18 2022, 3:57 PM
mhorne committed R10:d15267582d6e: Remove 11.x ABI compat for kernel dump ioctls (authored by mhorne).
Remove 11.x ABI compat for kernel dump ioctls
Apr 18 2022, 3:04 PM

Apr 15 2022

mhorne added a comment to D34820: vt: use TERMINAL_DECLARE_EARLY() macro.

Does this seem okay @emaste? This was a drive-by cleanup I made a while ago when reading some code; I found it on a stale local branch but there's no larger motivation.

Apr 15 2022, 7:45 PM
mhorne committed R10:0a90043e63d3: Remove 12.x ABI compat for kernel dump ioctls (authored by mhorne).
Remove 12.x ABI compat for kernel dump ioctls
Apr 15 2022, 3:06 PM
mhorne committed R10:9c90bfcd319c: Remove 11.x ABI compat for kernel dump ioctls (authored by mhorne).
Remove 11.x ABI compat for kernel dump ioctls
Apr 15 2022, 3:06 PM
mhorne closed D34914: Remove 12.x ABI compat for kernel dump ioctls.
Apr 15 2022, 3:06 PM
mhorne closed D34913: Remove 11.x ABI compat for kernel dump ioctls.
Apr 15 2022, 3:06 PM

Apr 14 2022

mhorne added inline comments to D34347: savecore: add an option to save a live minidump.
Apr 14 2022, 9:37 PM
mhorne added inline comments to D34913: Remove 11.x ABI compat for kernel dump ioctls.
Apr 14 2022, 7:36 PM
mhorne added a comment to D34914: Remove 12.x ABI compat for kernel dump ioctls.
In D34914#791369, @imp wrote:

This too can be removed...
(1) They aren't part of a long-term standard ABI, but a rather specialized FreeBSD tool and the kernel
(2) they don't need to work in a jail because this ioctl doesn't make sense from jail.
(3) There's no upgrade / failed-upgrade scenarios we need to worry about with this.

There's just barely a scenario to keep these, and it likely isn't worth supporting: If I ran a 12 userland with a 14 kernel, I wouldn't be able to capture panics with this. However, one can selectively copy over a statically linked dumpon(8) to work around this should even that unlikely scenario arise. And I'm not sure how well the other administrative tools would cope anyway, so maybe that's no longer possible...

Apr 14 2022, 5:30 PM
mhorne requested review of D34914: Remove 12.x ABI compat for kernel dump ioctls.
Apr 14 2022, 5:06 PM
mhorne requested review of D34913: Remove 11.x ABI compat for kernel dump ioctls.
Apr 14 2022, 5:06 PM

Apr 12 2022

mhorne added a comment to D34750: riscv: support Allwinner D1 interrupt controllers.

I guess this commit gives a little more context. So because the device tree declares &intc to be the interrupt parent for several peripherals, we need this stub driver in order to properly route things back to the PLIC, is that right?

Apr 12 2022, 10:56 PM
mhorne committed R10:3a6f0bb25f06: aw_wdog: support Allwinner D1 watchdog (authored by julien.cassette_gmail.com).
aw_wdog: support Allwinner D1 watchdog
Apr 12 2022, 10:53 PM
mhorne committed R10:34f4c17a2b3d: cgem: support SGMII PHY connection mode (authored by bsd_dino.sk).
cgem: support SGMII PHY connection mode
Apr 12 2022, 10:53 PM
mhorne committed R10:66cc0c61b023: cgem: rework hardware quirk detection (authored by bsd_dino.sk).
cgem: rework hardware quirk detection
Apr 12 2022, 10:53 PM
mhorne closed D34749: aw_wdog: support Allwinner D1 watchdog.
Apr 12 2022, 10:52 PM
mhorne closed D34764: Enhance if_cgem (add SGMII connection type, rewrite errata logic, fix typo).
Apr 12 2022, 10:52 PM

Apr 11 2022

mhorne added a reverting change for R10:b9ec0b7e86ac: mii: include missing sources in loadable module: R10:62c0ba91c78f: Revert "mii: include missing sources in loadable module".
Apr 11 2022, 5:56 PM
mhorne added a reverting change for D34256: Make miibus.ko module on par with using 'device miibus' in kernel config: R10:62c0ba91c78f: Revert "mii: include missing sources in loadable module".
Apr 11 2022, 5:56 PM
mhorne committed R10:62c0ba91c78f: Revert "mii: include missing sources in loadable module" (authored by mhorne).
Revert "mii: include missing sources in loadable module"
Apr 11 2022, 5:56 PM
mhorne committed R10:b9ec0b7e86ac: mii: include missing sources in loadable module (authored by bsd_dino.sk).
mii: include missing sources in loadable module
Apr 11 2022, 2:06 PM
mhorne committed R10:49f55cdfd80a: cgem: Support building as a loadable kernel module (authored by bsd_dino.sk).
cgem: Support building as a loadable kernel module
Apr 11 2022, 2:06 PM
mhorne committed R10:aec1262c5ef0: riscv: eliminate physmap global (authored by mhorne).
riscv: eliminate physmap global
Apr 11 2022, 2:05 PM
mhorne committed R10:3a64c08ceb85: savecore: include '-u' flag in usage message (authored by mhorne).
savecore: include '-u' flag in usage message
Apr 11 2022, 2:05 PM
mhorne committed R10:678b6696734e: mem(4): Improve ioctl section formatting (authored by mhorne).
mem(4): Improve ioctl section formatting
Apr 11 2022, 2:05 PM

Apr 7 2022

mhorne committed R10:628a6b0a0613: kern_linker.c: sort includes (authored by mhorne).
kern_linker.c: sort includes
Apr 7 2022, 6:13 PM
mhorne committed R10:73ea4e8c0d8f: init_main.c: sort includes (authored by mhorne).
init_main.c: sort includes
Apr 7 2022, 6:13 PM
mhorne committed R10:8a0339e679aa: riscv: eliminate physmap global (authored by mhorne).
riscv: eliminate physmap global
Apr 7 2022, 3:28 PM
mhorne closed D34778: riscv: eliminate physmap global.
Apr 7 2022, 3:27 PM
mhorne added inline comments to D34821: savecore: decrease filename buffer sizes.
Apr 7 2022, 3:10 PM
mhorne added inline comments to D34347: savecore: add an option to save a live minidump.
Apr 7 2022, 3:08 PM
mhorne updated the diff for D34347: savecore: add an option to save a live minidump.

Handle review comments from markj. Move the ftruncate() call earlier in the routine (before file rename).

Apr 7 2022, 3:06 PM
mhorne requested review of D34822: savecore: factor out info file handling.
Apr 7 2022, 3:04 PM
mhorne requested review of D34821: savecore: decrease filename buffer sizes.
Apr 7 2022, 3:04 PM
mhorne added a comment to D34820: vt: use TERMINAL_DECLARE_EARLY() macro.

For reference:

#define	TERMINAL_DECLARE_EARLY(name, class, softc)			\
	static struct terminal name = {					\
		.tm_class = &class,					\
		.tm_softc = softc,					\
		.tm_flags = TF_CONS,					\
	};								\
	CONSOLE_DEVICE(name ## _consdev, termcn_cnops, &name)
#define	CONSOLE_DEVICE(name, ops, arg)					\
	static struct consdev name = {					\
		.cn_ops = &ops,						\
		.cn_arg = (arg),					\
	};								\
	DATA_SET(cons_set, name)
Apr 7 2022, 1:08 PM
mhorne updated the test plan for D34820: vt: use TERMINAL_DECLARE_EARLY() macro.
Apr 7 2022, 1:08 PM
mhorne requested review of D34820: vt: use TERMINAL_DECLARE_EARLY() macro.
Apr 7 2022, 1:05 PM

Apr 6 2022

mhorne added inline comments to D34778: riscv: eliminate physmap global.
Apr 6 2022, 6:06 PM
mhorne added inline comments to D34778: riscv: eliminate physmap global.
Apr 6 2022, 4:37 PM
mhorne added inline comments to D34778: riscv: eliminate physmap global.
Apr 6 2022, 4:36 PM
mhorne added inline comments to D34347: savecore: add an option to save a live minidump.
Apr 6 2022, 4:21 PM
mhorne awarded D34784: suppress set but not used warnings for kernel builds a Like token.
Apr 6 2022, 12:17 AM

Apr 5 2022

mhorne committed R10:173fc6f4562e: savecore: include '-u' flag in usage message (authored by mhorne).
savecore: include '-u' flag in usage message
Apr 5 2022, 7:27 PM
mhorne added inline comments to D34347: savecore: add an option to save a live minidump.
Apr 5 2022, 6:57 PM
mhorne committed R10:c9114f9f86f9: Add new vnode dumper to support live minidumps (authored by mhorne).
Add new vnode dumper to support live minidumps
Apr 5 2022, 6:35 PM
mhorne committed R10:eb9d205fa691: livedump: add event handler hooks (authored by mhorne).
livedump: add event handler hooks
Apr 5 2022, 6:35 PM
mhorne committed R10:071b78ce8fec: mem(4): Improve ioctl section formatting (authored by mhorne).
mem(4): Improve ioctl section formatting
Apr 5 2022, 6:35 PM
mhorne committed R10:59c27ea18c32: Split out dumper allocation from list insertion (authored by mhorne).
Split out dumper allocation from list insertion
Apr 5 2022, 6:35 PM
mhorne closed D33813: Add new vnode dumper to support live minidumps.
Apr 5 2022, 6:35 PM
mhorne closed D34067: livedump: add event handler hooks.
Apr 5 2022, 6:35 PM
mhorne closed D34068: Split out dumper allocation from list insertion.
Apr 5 2022, 6:35 PM
mhorne closed D34574: mem(4): Improve ioctl section formatting.
Apr 5 2022, 6:35 PM
mhorne added inline comments to D34347: savecore: add an option to save a live minidump.
Apr 5 2022, 2:50 PM

Apr 4 2022

mhorne updated the summary of D34783: savecore: fold maxdumps check into getbounds().
Apr 4 2022, 11:36 PM