Page MenuHomeFreeBSD

mhorne (Mitchell Horne)
User

Projects

User Details

User Since
Mar 22 2019, 4:46 AM (79 w, 18 h)

Recent Activity

Yesterday

mhorne added inline comments to D26540: Eliminate building LINT makefiles.
Thu, Sep 24, 1:52 PM

Wed, Sep 23

mhorne added inline comments to D26540: Eliminate building LINT makefiles.
Wed, Sep 23, 11:31 PM
mhorne added a comment to D26540: Eliminate building LINT makefiles.

I rebased D26502 on top of this and it builds fine.

Wed, Sep 23, 11:09 PM
mhorne updated the diff for D26502: RISC-V LINT kernel config.

Rebase on top of D26540.

Wed, Sep 23, 11:08 PM
mhorne committed rD54517: Handbook: list freebsd-riscv mailing list.
Handbook: list freebsd-riscv mailing list
Wed, Sep 23, 5:37 PM
mhorne closed D26408: Handbook: list freebsd-riscv mailing list.
Wed, Sep 23, 5:37 PM

Tue, Sep 22

mhorne committed rS365999: Add some missing mergeinfo.
Add some missing mergeinfo
Tue, Sep 22, 2:30 PM
mhorne committed rS365996: MFC r365304, r365459.
MFC r365304, r365459
Tue, Sep 22, 2:15 PM
mhorne committed rS365995: RISC-V: build SiFive drivers and DTB in GENERIC.
RISC-V: build SiFive drivers and DTB in GENERIC
Tue, Sep 22, 1:00 PM
mhorne closed D26501: RISC-V: build SiFive drivers and DTB in GENERIC.
Tue, Sep 22, 1:00 PM

Mon, Sep 21

mhorne updated the diff for D26501: RISC-V: build SiFive drivers and DTB in GENERIC.

Remove fe310 always-on device.

Mon, Sep 21, 10:43 PM
mhorne added a comment to D26514: Add compile_commands*.json to .gitignore.

Just curious, what tool did you use to generate the compile commands database for FreeBSD? I have a vim linter plugin that is kind of useless for FreeBSD code without one.

Mon, Sep 21, 10:39 PM
mhorne committed rS365955: Hide tunable definitions behind _KERNEL.
Hide tunable definitions behind _KERNEL
Mon, Sep 21, 5:43 PM
mhorne committed rS365947: Use getenv_is_true() in init_static_kenv().
Use getenv_is_true() in init_static_kenv()
Mon, Sep 21, 3:44 PM
mhorne closed D26271: Use getenv_is_true() in kern_environment.c.
Mon, Sep 21, 3:44 PM
mhorne committed rS365945: Add getenv(9) boolean parsing functions.
Add getenv(9) boolean parsing functions
Mon, Sep 21, 3:25 PM
mhorne closed D26270: Add getenv_is_true() and getenv_is_false().
Mon, Sep 21, 3:25 PM

Sun, Sep 20

mhorne added inline comments to D26502: RISC-V LINT kernel config.
Sun, Sep 20, 11:34 PM
mhorne requested review of D26502: RISC-V LINT kernel config.
Sun, Sep 20, 11:33 PM
mhorne requested review of D26501: RISC-V: build SiFive drivers and DTB in GENERIC.
Sun, Sep 20, 11:29 PM
mhorne accepted D26500: atomic_common.h: Fix the volatile qualifier placement in atomic_load_ptr.

Looks good, thank you Jess. I gave it a quick compile to be sure.

Sun, Sep 20, 11:13 PM
mhorne abandoned D26498: Fix an occasional hang in smp_after_idle_runnable.

Abandoned in favor of D26500.

Sun, Sep 20, 10:53 PM
mhorne requested review of D26498: Fix an occasional hang in smp_after_idle_runnable.
Sun, Sep 20, 10:13 PM

Fri, Sep 18

mhorne updated the diff for D26271: Use getenv_is_true() in kern_environment.c.

Fix the logic for the loader_env.disabled check... whoops.

Fri, Sep 18, 7:10 PM
mhorne committed rS365884: arm64: generate ISO release images.
arm64: generate ISO release images
Fri, Sep 18, 2:40 PM
mhorne closed D26452: arm64: generate ISO release images.
Fri, Sep 18, 2:40 PM
mhorne added a comment to D26452: arm64: generate ISO release images.

Relnotes: yes I presume?

Fri, Sep 18, 2:34 PM
mhorne updated the summary of D26452: arm64: generate ISO release images.
Fri, Sep 18, 2:34 PM
mhorne closed D26454: Initialize some local variables earlier.
Fri, Sep 18, 2:01 PM
mhorne committed rS365881: Initialize some local variables earlier.
Initialize some local variables earlier
Fri, Sep 18, 2:01 PM
mhorne updated the diff for D26452: arm64: generate ISO release images.

Make use of "efi" system type in makefs.

Fri, Sep 18, 1:22 PM

Thu, Sep 17

mhorne committed rS365835: Add dtb/sifive module.
Add dtb/sifive module
Thu, Sep 17, 2:58 PM
mhorne closed D26459: Add dtb/sifive module.
Thu, Sep 17, 2:58 PM
mhorne added inline comments to D26454: Initialize some local variables earlier.
Thu, Sep 17, 1:30 PM
mhorne updated the diff for D26454: Initialize some local variables earlier.

Address melifaro's comment.

Thu, Sep 17, 1:30 PM
mhorne requested review of D26459: Add dtb/sifive module.
Thu, Sep 17, 12:58 PM

Wed, Sep 16

mhorne updated the diff for D26270: Add getenv_is_true() and getenv_is_false().

Update manpage bits.

Wed, Sep 16, 6:05 PM
mhorne requested review of D26454: Initialize some local variables earlier.
Wed, Sep 16, 4:31 PM
mhorne committed rS365801: if_media: definitions for 40GE LM4 ethernet media type.
if_media: definitions for 40GE LM4 ethernet media type
Wed, Sep 16, 2:45 PM
mhorne closed D26276: Add definitions for the Finisar 40GE LM4 transceiver.
Wed, Sep 16, 2:45 PM
mhorne added a comment to D26276: Add definitions for the Finisar 40GE LM4 transceiver.
In D26276#587298, @erj wrote:

Yeah, I think the rest of this looks good.

Do you know if there is anything else that can recognize LM4 and use this patch?

Wed, Sep 16, 1:39 PM
mhorne added a comment to D26452: arm64: generate ISO release images.

So far the images generated are bootable, but the bootable image header is incorrectly labeled "BIOS", rather than "UEFI" which may be causing the images to be unrecognized on certain firmware. I'm not sure yet if there is a bug in makefs.

Wed, Sep 16, 1:16 PM
mhorne requested review of D26452: arm64: generate ISO release images.
Wed, Sep 16, 1:09 PM

Fri, Sep 11

mhorne added a comment to D26408: Handbook: list freebsd-riscv mailing list.

This will also trigger an update to https://docs.freebsd.org/mail/ correct?

Fri, Sep 11, 9:12 PM
mhorne requested review of D26408: Handbook: list freebsd-riscv mailing list.
Fri, Sep 11, 9:10 PM
mhorne updated the diff for D26270: Add getenv_is_true() and getenv_is_false().

Remove unneeded static from getenv_bool.

Fri, Sep 11, 6:21 PM
mhorne updated the diff for D26270: Add getenv_is_true() and getenv_is_false().

Here's a version that also provides getenv_bool/TUNABLE_BOOL.

Fri, Sep 11, 6:03 PM
mhorne added a comment to D26393: Simplify linux_exec_setregs.

Seems that this could be done in linux32_sysvec.c as well using ia32_setregs().

Fri, Sep 11, 5:11 PM
mhorne added a comment to D26276: Add definitions for the Finisar 40GE LM4 transceiver.

@erj any opposition to these definitions?

Fri, Sep 11, 4:39 PM

Tue, Sep 8

mhorne committed rD54469: Document OSVERSION 1300114..
Document OSVERSION 1300114.
Tue, Sep 8, 6:23 PM
mhorne committed rS365461: arm64: check for CRC32 support via HWCAP.
arm64: check for CRC32 support via HWCAP
Tue, Sep 8, 3:39 PM
mhorne closed D26032: arm64: check for CRC32 support via HWCAP.
Tue, Sep 8, 3:39 PM
mhorne committed rS365460: arm64: export new HWCAP features.
arm64: export new HWCAP features
Tue, Sep 8, 3:37 PM
mhorne closed D26031: arm64: export new HWCAP features.
Tue, Sep 8, 3:36 PM
mhorne committed rS365459: arm64: fix incorrect HWCAP definitions.
arm64: fix incorrect HWCAP definitions
Tue, Sep 8, 3:08 PM
mhorne closed D26329: arm64: fix incorrect HWCAP definitions.
Tue, Sep 8, 3:08 PM
mhorne committed rS365456: RISC-V: enable MK_FORMAT_EXTENSIONS.
RISC-V: enable MK_FORMAT_EXTENSIONS
Tue, Sep 8, 1:25 PM
mhorne closed D26320: RISC-V: enable MK_FORMAT_EXTENSIONS.
Tue, Sep 8, 1:25 PM
mhorne committed rS365455: RISC-V: fix some mismatched format specifiers.
RISC-V: fix some mismatched format specifiers
Tue, Sep 8, 1:21 PM
mhorne closed D26319: RISC-V: fix some mismatched format specifiers.
Tue, Sep 8, 1:21 PM

Sat, Sep 5

mhorne added a comment to D26329: arm64: fix incorrect HWCAP definitions.

Should I try to get this included in 12.2? The branch is set to happen on the 11th (6 days from now).

Sat, Sep 5, 8:36 PM

Fri, Sep 4

mhorne retitled D26276: Add definitions for the Finisar 40GE LM4 transceiver from ixl: add support for the Finisar 40GE LM4 transceiver to Add definitions for the Finisar 40GE LM4 transceiver.
Fri, Sep 4, 8:35 PM
mhorne updated the diff for D26276: Add definitions for the Finisar 40GE LM4 transceiver.

Remove ixl(4) portion.

Fri, Sep 4, 8:35 PM
mhorne added inline comments to D26276: Add definitions for the Finisar 40GE LM4 transceiver.
Fri, Sep 4, 8:25 PM
mhorne accepted D26327: Maintain a stack alignment of 16-bytes..

I'm not very familiar with rtld, but this seems correct.

Fri, Sep 4, 6:47 PM
mhorne accepted D26328: Round TF_SIZE up to the stack alignment (16-bytes)..
Fri, Sep 4, 6:43 PM
mhorne added inline comments to D26329: arm64: fix incorrect HWCAP definitions.
Fri, Sep 4, 6:14 PM
mhorne requested review of D26329: arm64: fix incorrect HWCAP definitions.
Fri, Sep 4, 6:11 PM
mhorne updated the summary of D26319: RISC-V: fix some mismatched format specifiers.
Fri, Sep 4, 2:00 PM
mhorne updated the diff for D26319: RISC-V: fix some mismatched format specifiers.

Address @arichardson's comment. Fix one additional instance in a riscv-specific driver.

Fri, Sep 4, 1:57 PM
mhorne added inline comments to D26319: RISC-V: fix some mismatched format specifiers.
Fri, Sep 4, 1:44 PM
mhorne requested review of D26320: RISC-V: enable MK_FORMAT_EXTENSIONS.
Fri, Sep 4, 12:27 AM
mhorne requested review of D26319: RISC-V: fix some mismatched format specifiers.
Fri, Sep 4, 12:24 AM

Thu, Sep 3

mhorne committed rS365317: MFC r364193:.
MFC r364193:
Thu, Sep 3, 11:17 PM
mhorne committed rS365316: Remove a duplicate declaration.
Remove a duplicate declaration
Thu, Sep 3, 10:41 PM
mhorne committed rS365304: arm64: update the set of HWCAP definitions.
arm64: update the set of HWCAP definitions
Thu, Sep 3, 5:08 PM
mhorne closed D26030: arm64: update the set of HWCAP definitions.
Thu, Sep 3, 5:08 PM
mhorne added a comment to D26031: arm64: export new HWCAP features.

Do any of the new caps require kernel support before they can be used? If so we shouldn't report them to the user until that support is in place.

Not as far as I know, most simply indicate the presence of instructions. I need to do a second reading to be sure before committing.

Thu, Sep 3, 3:53 PM
mhorne updated the diff for D26031: arm64: export new HWCAP features.

Expose SSBS in user_cpu_desc. Annotate elf_hwcap and elf_hwcap2 as __read_frequently.

Thu, Sep 3, 3:47 PM

Wed, Sep 2

mhorne added inline comments to D26030: arm64: update the set of HWCAP definitions.
Wed, Sep 2, 5:25 PM
mhorne added inline comments to D26030: arm64: update the set of HWCAP definitions.
Wed, Sep 2, 3:02 PM
mhorne added inline comments to D26276: Add definitions for the Finisar 40GE LM4 transceiver.
Wed, Sep 2, 2:02 PM
mhorne added a comment to D26270: Add getenv_is_true() and getenv_is_false().
In D26270#584275, @jhb wrote:

This is probably fine as-is. Having a getenv_bool means you could report EINVAL errors for unrecognized string values, but adds more work to callers. It would perhaps be nice to structure the wrapper routines as as wrappers around a getenv_bool and have the wrapper routines complain for EINVAL errors ("Environment variable %s has a non-boolean value %s" or the like).

Wed, Sep 2, 1:56 PM

Tue, Sep 1

mhorne added reviewers for D26276: Add definitions for the Finisar 40GE LM4 transceiver: jeffrey.e.pieper_intel.com, krzysztof.galazka_intel.com, jacob.e.keller_intel.com.

Hi, adding some Intel folks who have appeared on recent ixl(4) reviews/submissions.

Tue, Sep 1, 3:16 PM
mhorne requested review of D26276: Add definitions for the Finisar 40GE LM4 transceiver.
Tue, Sep 1, 3:12 PM
mhorne added inline comments to D26270: Add getenv_is_true() and getenv_is_false().
Tue, Sep 1, 12:44 PM
mhorne added a reviewer for D26270: Add getenv_is_true() and getenv_is_false(): manpages.
Tue, Sep 1, 12:42 PM
mhorne requested review of D26271: Use getenv_is_true() in kern_environment.c.
Tue, Sep 1, 12:41 PM
mhorne requested review of D26270: Add getenv_is_true() and getenv_is_false().
Tue, Sep 1, 12:40 PM

Aug 15 2020

mhorne committed rS364256: RISC-V: copy kernelname from the environment.
RISC-V: copy kernelname from the environment
Aug 15 2020, 4:16 PM
mhorne closed D26069: arm64: parse HWCAP values using user_cpu_desc.
Aug 15 2020, 3:06 PM
mhorne committed rS364255: arm64: parse HWCAP values using user_cpu_desc.
arm64: parse HWCAP values using user_cpu_desc
Aug 15 2020, 3:06 PM
mhorne committed rS364254: arm64: update instruction set attribute register definitions.
arm64: update instruction set attribute register definitions
Aug 15 2020, 2:58 PM
mhorne closed D26029: arm64: update instruction set attribute register definitions.
Aug 15 2020, 2:58 PM

Aug 14 2020

mhorne added a comment to D26031: arm64: export new HWCAP features.

Do any of the new caps require kernel support before they can be used? If so we shouldn't report them to the user until that support is in place.

Aug 14 2020, 9:14 PM
mhorne updated the diff for D26031: arm64: export new HWCAP features.

Update post D26069.

Aug 14 2020, 9:06 PM
mhorne requested review of D26069: arm64: parse HWCAP values using user_cpu_desc.
Aug 14 2020, 9:04 PM
mhorne updated the diff for D26029: arm64: update instruction set attribute register definitions.

Use MRS_LOWER for the new aa64isar1 fields. We want to expose them to userspace.

Aug 14 2020, 9:02 PM

Aug 13 2020

mhorne committed rS364193: Enable interrupts while handling traps.
Enable interrupts while handling traps
Aug 13 2020, 2:21 PM
mhorne closed D26017: Enable interrupts while handling traps.
Aug 13 2020, 2:21 PM