Page MenuHomeFreeBSD
People mhorne

mhorne (Mitchell Horne)
User

Projects

User Details

User Since
Mar 22 2019, 4:46 AM (389 w, 3 d)

Recent Activity
View All

Thu, Sep 3

mhorne committed rG22e27e307f8d: pmc_exterr_test: add MACHINE_ARCH check (authored by mhorne).
pmc_exterr_test: add MACHINE_ARCH check
Thu, Sep 3, 5:47 PM
mhorne committed rGe555692d1bbb: hwpmc: Add ATF regression tests for hwpmc EXTERROR diagnostics (authored by afscoelho_gmail.com).
hwpmc: Add ATF regression tests for hwpmc EXTERROR diagnostics
Thu, Sep 3, 5:18 PM
mhorne committed rG261d58969487: g_eli: disambiguate CPU-bound worker creation (authored by mhorne).
g_eli: disambiguate CPU-bound worker creation
Thu, Sep 3, 4:37 PM
mhorne committed rG10ebbeb4d78c: subr_physmem_test: add tests for two edge-cases (authored by mhorne).
subr_physmem_test: add tests for two edge-cases
Thu, Sep 3, 4:37 PM
mhorne committed rG64dd924bf771: sched/lapic: remove sched_do_timer_accounting() (authored by mhorne).
sched/lapic: remove sched_do_timer_accounting()
Thu, Sep 3, 4:37 PM
mhorne committed rG5ed83588dac8: g_eli: better handling of absent/disabled CPUs (authored by mhorne).
g_eli: better handling of absent/disabled CPUs
Thu, Sep 3, 4:37 PM
mhorne committed rGce2e423045c2: smp: remove unused hlt_cpus_mask (authored by mhorne).
smp: remove unused hlt_cpus_mask
Thu, Sep 3, 4:37 PM
Herald added a reviewer for D58159: sched/lapic: remove sched_do_timer_accounting(): scheduler.
Thu, Sep 3, 4:37 PM
mhorne committed rGa722716674ba: jh7110_gpio: driver enhancements (authored by bscott_bunyatech.com.au).
jh7110_gpio: driver enhancements
Thu, Sep 3, 4:30 PM
mhorne committed rG84b241f1cc12: hwpmc: fix false callchain assertion on the PMC_UR ring (authored by afscoelho_gmail.com).
hwpmc: fix false callchain assertion on the PMC_UR ring
Thu, Sep 3, 4:30 PM
mhorne committed rG92cf9e36ecf9: hwpmc: fix false runcount assertion in user callchain capture (authored by afscoelho_gmail.com).
hwpmc: fix false runcount assertion in user callchain capture
Thu, Sep 3, 4:30 PM
mhorne committed rG3ef9ef5147d2: libkern.h: remove HAVE_INLINE_* macros (authored by mhorne).
libkern.h: remove HAVE_INLINE_* macros
Thu, Sep 3, 4:30 PM
mhorne committed rG24db9837bee5: jh7110_gpio: remove unneeded cleanup (authored by mhorne).
jh7110_gpio: remove unneeded cleanup
Thu, Sep 3, 4:30 PM
mhorne committed rG66fb43c26b3b: jh7110_gpio: style (authored by mhorne).
jh7110_gpio: style
Thu, Sep 3, 4:30 PM
mhorne committed rG55e62f1eadae: release/riscv: tweak GENERICSD partition placement (authored by mhorne).
release/riscv: tweak GENERICSD partition placement
Thu, Sep 3, 4:30 PM
mhorne committed rG431545476078: cdefs(9): document __nonstring (authored by mhorne).
cdefs(9): document __nonstring
Thu, Sep 3, 4:30 PM
mhorne committed rG83b88ea4761e: vfs_unmountall.9: Fix an outdated .Xr to boot(9) (authored by temcbun_gmail.com).
vfs_unmountall.9: Fix an outdated .Xr to boot(9)
Thu, Sep 3, 4:24 PM
mhorne committed rGf19f44634afd: pmc: Add support for AMD UMC counters (authored by ali_mashtizadeh.com).
pmc: Add support for AMD UMC counters
Thu, Sep 3, 4:05 PM
mhorne abandoned D40290: hwpmc: Improve re-attachment logic in pmc_process_exec().

No longer relevant.

Thu, Sep 3, 2:08 PM

Wed, Sep 2

mhorne committed rG1db0c9fa7a32: hwpmc(4): stop overwalking past _start on amd64 user callchains (authored by nickbanks_netflix.com).
hwpmc(4): stop overwalking past _start on amd64 user callchains
Wed, Sep 2, 2:31 PM
mhorne closed D59229: hwpmc(4): stop overwalking past _start on amd64 user callchains.
Wed, Sep 2, 2:30 PM
mhorne accepted D59229: hwpmc(4): stop overwalking past _start on amd64 user callchains.
Wed, Sep 2, 2:28 PM

Tue, Sep 1

mhorne updated the diff for D59049: riscv: mark kernel page table entries as global.

Apply pte_g in _pmap_alloc_l3() as well.

Tue, Sep 1, 6:48 PM
mhorne added inline comments to D59048: riscv, pmap: extend the set of TLB management functions.
Tue, Sep 1, 2:42 PM
mhorne added inline comments to D59049: riscv: mark kernel page table entries as global.
Tue, Sep 1, 2:16 PM

Mon, Aug 31

mhorne added a member for manpages: mhorne.
Mon, Aug 31, 4:08 PM
mhorne added a member for docs: mhorne.
Mon, Aug 31, 4:08 PM
mhorne removed a member for manpages: mhorne.
Mon, Aug 31, 4:07 PM
mhorne removed a member for docs: mhorne.
Mon, Aug 31, 4:07 PM

Tue, Aug 25

mhorne committed rGac15e5619d1b: crashinfo: Create core.txt.last symlink (authored by rbranco_suse.com).
crashinfo: Create core.txt.last symlink
Tue, Aug 25, 5:46 PM
mhorne committed rG179d779c6427: g_part,mkimg: Add additional GPT partition types (authored by bscott_bunyatech.com.au).
g_part,mkimg: Add additional GPT partition types
Tue, Aug 25, 5:46 PM
mhorne committed rGe6a2ee407207: cpufreq_dt: fix attach for single CPU (authored by mhorne).
cpufreq_dt: fix attach for single CPU
Tue, Aug 25, 5:46 PM
mhorne committed rG68da0d6e6086: generic_ehci_fdt: fix driver softc size (authored by mhorne).
generic_ehci_fdt: fix driver softc size
Tue, Aug 25, 5:46 PM

Fri, Aug 21

mhorne committed rG76f14217f605: libkern.h: remove HAVE_INLINE_* macros (authored by mhorne).
libkern.h: remove HAVE_INLINE_* macros
Fri, Aug 21, 4:59 PM
mhorne closed D55201: libkern.h: remove HAVE_INLINE_* macros.
Fri, Aug 21, 4:59 PM
mhorne committed rG3d20f8a02243: jh7110_gpio: driver enhancements (authored by bscott_bunyatech.com.au).
jh7110_gpio: driver enhancements
Fri, Aug 21, 4:56 PM
mhorne committed rG2af2ec524957: jh7110_gpio: remove unneeded cleanup (authored by mhorne).
jh7110_gpio: remove unneeded cleanup
Fri, Aug 21, 4:56 PM
mhorne committed rG72216145d3e4: jh7110_gpio: style (authored by mhorne).
jh7110_gpio: style
Fri, Aug 21, 4:56 PM
mhorne closed D58693: riscv jh7110 gpio driver enhancements.
Fri, Aug 21, 4:55 PM · riscv
mhorne added inline comments to D58693: riscv jh7110 gpio driver enhancements.
Fri, Aug 21, 4:36 PM · riscv
mhorne accepted D58693: riscv jh7110 gpio driver enhancements.

LGTM! Thanks for your work. I will make the necessary style tweaks before committing (I noted a couple).

Fri, Aug 21, 4:35 PM · riscv
mhorne abandoned D27719: arm64: don't pass user trapframe to kdb_trap().

This got committed. Closing.

Fri, Aug 21, 3:54 PM
mhorne abandoned D51134: sys: harmonize FDT/DTS include paths.

Not very important.

Fri, Aug 21, 3:52 PM
mhorne added a comment to D55201: libkern.h: remove HAVE_INLINE_* macros.

@mav I found this review again. Seems the removal made it to the 2.3 release branch. Shall I proceed here?

Fri, Aug 21, 3:51 PM

Thu, Aug 20

mhorne updated the test plan for D59050: sifive: handle sfence.vma errata.
Thu, Aug 20, 3:04 PM
mhorne requested review of D59050: sifive: handle sfence.vma errata.
Thu, Aug 20, 3:01 PM
mhorne requested review of D59049: riscv: mark kernel page table entries as global.
Thu, Aug 20, 3:01 PM
mhorne requested review of D59048: riscv, pmap: extend the set of TLB management functions.
Thu, Aug 20, 3:01 PM
mhorne requested review of D59047: riscv: eliminate duplicate load in pmap_growkernel().
Thu, Aug 20, 3:01 PM

Fri, Aug 14

mhorne added a comment to D58824: ossl: fix OPENSSL_ia32cap_P size mismatch on i386/amd64.
In D58824#1349990, @dim wrote:

The code in sys/crypto/openssl/ossl_x86.c got moved around by @mhorne in rGfd86ae6800383dabe050e22176783857895800e3, maybe Mitchell has opinions about this too.

Fri, Aug 14, 5:01 PM
mhorne committed rG8822ef05e61e: clknode_if.m: fix two typos (authored by mhorne).
clknode_if.m: fix two typos
Fri, Aug 14, 3:24 PM

Thu, Aug 13

mhorne committed rG49749f21284d: release/riscv: tweak GENERICSD partition placement (authored by mhorne).
release/riscv: tweak GENERICSD partition placement
Thu, Aug 13, 3:40 PM
mhorne committed rG2ea905c875b6: cdefs(9): document __nonstring (authored by mhorne).
cdefs(9): document __nonstring
Thu, Aug 13, 1:48 PM
mhorne closed D58804: cdefs(9): document __nonstring.
Thu, Aug 13, 1:48 PM
mhorne added a comment to D58804: cdefs(9): document __nonstring.
In D58804#1349329, @emaste wrote:

Oops, clicking accept crossed paths with the update.

I'm fine with the current version (.Dv NUL terminator) if that's what you want to go with, but I think that "does not require a null terminator" or "is not a null-terminated string" is preferable.

Thu, Aug 13, 1:45 PM

Wed, Aug 12

mhorne added a comment to D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.

Generally looks fine.

Wed, Aug 12, 7:38 PM
mhorne added inline comments to D58804: cdefs(9): document __nonstring.
Wed, Aug 12, 7:02 PM
mhorne updated the diff for D58804: cdefs(9): document __nonstring.

Prefer .Dv NUL and bump .Dd.

Wed, Aug 12, 7:02 PM
mhorne requested review of D58804: cdefs(9): document __nonstring.
Wed, Aug 12, 6:51 PM
mhorne abandoned D53582: mutex: add missing checks for SCHEDULER_STOPPED().

Likely unnecessary.

Wed, Aug 12, 4:58 PM
mhorne abandoned D38591: Remove libmchain man pages.

Closing some old reviews. I won't be pursuing this.

Wed, Aug 12, 4:37 PM
mhorne abandoned D38590: netsmb: absorb libmchain module.

Closing some old reviews. I won't be pursuing this.

Wed, Aug 12, 4:37 PM

Tue, Aug 11

mhorne committed rGaf3929c5152b: hwpmc: fix false callchain assertion on the PMC_UR ring (authored by afscoelho_gmail.com).
hwpmc: fix false callchain assertion on the PMC_UR ring
Tue, Aug 11, 4:23 PM
mhorne committed rG66118c3f1011: hwpmc: fix false runcount assertion in user callchain capture (authored by afscoelho_gmail.com).
hwpmc: fix false runcount assertion in user callchain capture
Tue, Aug 11, 4:23 PM
mhorne closed D58572: hwpmc: fix false callchain assertion on the PMC_UR ring.
Tue, Aug 11, 4:23 PM
mhorne closed D58571: hwpmc: fix false runcount assertion in user callchain capture.
Tue, Aug 11, 4:23 PM
mhorne added a comment to D58693: riscv jh7110 gpio driver enhancements.

Hi, thanks for this submission.

Tue, Aug 11, 4:14 PM · riscv
mhorne added a comment to D58715: pmc(8): handle AMD Zen3-B0 IBS errata in the frontend view.

I did not review in detail.

Tue, Aug 11, 2:44 PM
mhorne added a reviewer for D58736: acl(9): expound on NFSv4 constants' meanings: rmacklem.
Tue, Aug 11, 2:35 PM
mhorne accepted D57381: riscv: add KASAN support.
In D57381#1348763, @markj wrote:

Looks good! Thanks for your patience with getting the atomics sorted out.

@mhorne will you land this? I'm happy to if you're busy.

Tue, Aug 11, 2:31 PM

Sun, Aug 9

mhorne committed rGd38b3a5ead0d: libpmc: Fix AMD L3 counter parameter parsing (authored by ali_mashtizadeh.com).
libpmc: Fix AMD L3 counter parameter parsing
Sun, Aug 9, 7:18 PM
mhorne accepted D58680: riscv/atomic: Provide some additional aliases.
Sun, Aug 9, 7:14 PM
mhorne added a comment to D58534: dev/hwpmc: Add interrupt callback for arm64.

On arm64, the hwpmc interrupt (arm64_intr()) is dispatched from the PMU driver: pmu_intr() in sys/arm/arm/pmu.c.

Sun, Aug 9, 7:13 PM

Aug 5 2026

mhorne accepted D58572: hwpmc: fix false callchain assertion on the PMC_UR ring.

Seems fine.

Aug 5 2026, 5:08 PM
mhorne accepted D58571: hwpmc: fix false runcount assertion in user callchain capture.

spinlock_enter() is weird, and a somewhat confusing name. I believe it is the disabling of interrupts that really prevents hardclock() from interfering. It is somewhat misleading to say that pm->pm_runcount is "protected" by a spinlock.

Aug 5 2026, 4:58 PM

Jul 28 2026

mhorne committed rG3fdd05c61216: libpmc: userland support and pmc.rapl.3 for the RAPL class (authored by afscoelho_gmail.com).
libpmc: userland support and pmc.rapl.3 for the RAPL class
Jul 28 2026, 3:03 PM
mhorne added a comment to D58027: x86: add AMD RAPL MSR definitions to specialreg.h.
In D58027#1342622, @afscoelho_gmail.com wrote:
In D58027#1342399, @aokblast wrote:

Ok! I would like to confirm something with you before committing:

  1. Author info: Andre Silva <andasilv@amd.com>
  2. Sponsored by: Advanced Micro Devices (AMD)

Are the both desired information you expected?

Yes, they are. Thanks!

Jul 28 2026, 3:03 PM
mhorne committed rGa99d04f39dab: hwpmc: add RAPL energy-counter class (AMD + Intel) (authored by afscoelho_gmail.com).
hwpmc: add RAPL energy-counter class (AMD + Intel)
Jul 28 2026, 3:03 PM
mhorne closed D58029: libpmc: userland support and pmc.rapl.3 for the RAPL class.
Jul 28 2026, 3:02 PM
mhorne committed rG53187a3665e5: pmc_dmc620: drop unneeded includes (authored by mhorne).
pmc_dmc620: drop unneeded includes
Jul 28 2026, 3:02 PM
mhorne closed D58028: hwpmc: add RAPL energy-counter class (AMD + Intel).
Jul 28 2026, 3:02 PM
mhorne committed rG77404ee1e99d: x86: add AMD RAPL MSR definitions to specialreg.h (authored by afscoelho_gmail.com).
x86: add AMD RAPL MSR definitions to specialreg.h
Jul 28 2026, 3:02 PM
mhorne closed D58027: x86: add AMD RAPL MSR definitions to specialreg.h.
Jul 28 2026, 3:02 PM
mhorne committed rGcac0eab342c7: sys/modules/hwpmc/Makefile: tidy up (authored by mhorne).
sys/modules/hwpmc/Makefile: tidy up
Jul 28 2026, 3:02 PM
mhorne committed rGd6dcd8d2c3ef: libsysdecode: fix nlm_flag regex in mktables (authored by mhorne).
libsysdecode: fix nlm_flag regex in mktables
Jul 28 2026, 2:31 PM

Jul 27 2026

mhorne accepted D58468: hwpmc: fix event allocation on pre-Zen AMD CPUs.

Thanks. I was considering removing all this code, but it was premature. I am happy to keep it if it is useful.

Jul 27 2026, 2:40 PM
mhorne added reviewers for D58468: hwpmc: fix event allocation on pre-Zen AMD CPUs: pmc, adrian.
Jul 27 2026, 2:39 PM

Jul 21 2026

mhorne committed rG8c4d5701924f: hwpmc: Add EXTERROR diagnostics to the AMD and IBS allocators (authored by afscoelho_gmail.com).
hwpmc: Add EXTERROR diagnostics to the AMD and IBS allocators
Jul 21 2026, 5:17 PM
mhorne committed rGc185935b0d52: hwpmc: Add EXTERROR diagnostics to the hwpmc syscall path (authored by afscoelho_gmail.com).
hwpmc: Add EXTERROR diagnostics to the hwpmc syscall path
Jul 21 2026, 5:17 PM

Jul 20 2026

mhorne committed rG5b7d6a128bef: vfs_unmountall.9: Fix an outdated .Xr to boot(9) (authored by temcbun_gmail.com).
vfs_unmountall.9: Fix an outdated .Xr to boot(9)
Jul 20 2026, 5:33 PM
mhorne closed D58350: vfs_unmountall.9: Fix an outdated .Xr to boot(9).
Jul 20 2026, 5:33 PM · Contributor Reviews (src), manpages, docs
mhorne accepted D58350: vfs_unmountall.9: Fix an outdated .Xr to boot(9).
Jul 20 2026, 5:29 PM · Contributor Reviews (src), manpages, docs

Jul 17 2026

mhorne accepted D58027: x86: add AMD RAPL MSR definitions to specialreg.h.
Jul 17 2026, 5:19 PM

Jul 16 2026

mhorne added a comment to D58256: hwpmc/amd: add PerfMonV2 global-control path.

Seems sensible as a starting point.

Jul 16 2026, 6:39 PM
mhorne accepted D58029: libpmc: userland support and pmc.rapl.3 for the RAPL class.
Jul 16 2026, 6:21 PM
mhorne accepted D58028: hwpmc: add RAPL energy-counter class (AMD + Intel).
Jul 16 2026, 6:18 PM
mhorne abandoned D58227: rk_gpio: improve EOI handling.

Per the replies in https://github.com/freebsd/freebsd-src/pull/2245, this ends up having no functional impact. Closing.

Jul 16 2026, 2:57 PM

Jul 14 2026

mhorne added a comment to D58227: rk_gpio: improve EOI handling.

So, this applies the EOI handling scheme preferred by many drivers, and endorsed by mmel@.

Jul 14 2026, 4:11 PM
mhorne requested review of D58227: rk_gpio: improve EOI handling.
Jul 14 2026, 3:41 PM
mhorne added a reverting change for rG8ffb400bfd64: rk_gpio: defer level-IRQ EOI until source line is driven low: rG1aeb9d782ea1: Revert "rk_gpio: defer level-IRQ EOI until source line is driven low".
Jul 14 2026, 3:07 PM