Page MenuHomeFreeBSD

mhorne (Mitchell Horne)
User

Projects

User Details

User Since
Mar 22 2019, 4:46 AM (320 w, 4 d)

Recent Activity

Yesterday

mhorne added inline comments to D50318: build.7: Document pkgbase PKG_FORMAT variable.
Mon, May 12, 11:45 PM
mhorne accepted D50307: arm: Make the pmap_kenter signature like arm64.
Mon, May 12, 6:38 PM
mhorne accepted D50274: cdboot.8: Initial manual page.

Approved.

Mon, May 12, 4:05 PM
mhorne accepted D50309: subr_devmap: Implement pmap_mapdev with pmap_mapdev_attr.
Mon, May 12, 4:03 PM
mhorne accepted D50308: subr_devmap: Add the function name to KASSERT.
Mon, May 12, 4:01 PM
mhorne accepted D50307: arm: Make the pmap_kenter signature like arm64.

LGTM with one tweak.

Mon, May 12, 4:01 PM
mhorne added a reviewer for D50303: HW Relnotes: Add a section for Etherswitch: adrian.
Mon, May 12, 3:53 PM
mhorne accepted D50293: e6000sw.4: Initial manual page.

Approved.

Mon, May 12, 3:44 PM
mhorne added a comment to D50301: umb.4: add "cellular modem driver" to title.

Approved.

Mon, May 12, 3:35 PM

Tue, May 6

mhorne added a comment to D49768: stand: Enable Spleen 32x64 font in the bootloader.

Approved; with @imp and @tsoome's review I think you can proceed.

Tue, May 6, 3:19 PM
mhorne accepted D50191: mccomphy: Guard the definition of mcommphy_yt8531_setup_delay().

Thanks.

Tue, May 6, 3:06 PM

Mon, May 5

mhorne accepted D50126: UPDATING: Strengthen recommendations.
Mon, May 5, 3:03 PM

Fri, May 2

mhorne accepted D50119: HW Relnotes: Add iwx(4) to Wireless Networks.
Fri, May 2, 7:49 PM
mhorne added a comment to D49687: iwx.4: Initial manual page.

Is that sufficient for me to merge this?

Fri, May 2, 7:08 PM
mhorne accepted D49687: iwx.4: Initial manual page.
Fri, May 2, 7:03 PM
mhorne added inline comments to D49687: iwx.4: Initial manual page.
Fri, May 2, 6:53 PM
mhorne accepted D49687: iwx.4: Initial manual page.

Thanks all for the input. Let us proceed here. Having spoken with the interested parties, I plan to handle the follow-up change describing the driver provenance.

Fri, May 2, 5:55 PM

Thu, May 1

mhorne closed D50074: mccomphy: add support for YT8531.
Thu, May 1, 3:02 PM
mhorne committed rGa592b5fd9d9c: mccomphy: add support for YT8531 (authored by jsihv_gmx.com).
mccomphy: add support for YT8531
Thu, May 1, 3:02 PM

Wed, Apr 30

mhorne accepted D49671: mount(8): Mention -o rw, polish, sync usage.

Approved.

Wed, Apr 30, 6:41 PM
mhorne updated the diff for D50074: mccomphy: add support for YT8531.

Add #ifdef FDT conditionals around mii_fdt.h inclusion and the call to mcommphy_yt8531_setup_delay().

Wed, Apr 30, 4:36 PM
mhorne added inline comments to D50074: mccomphy: add support for YT8531.
Wed, Apr 30, 4:35 PM
mhorne accepted D50016: subr_devmap: Reduce the use of the static devmap.
Wed, Apr 30, 12:18 PM

Tue, Apr 29

mhorne added inline comments to D50074: mccomphy: add support for YT8531.
Tue, Apr 29, 4:39 PM
mhorne added a comment to D50074: mccomphy: add support for YT8531.

@jsihv_gmx.com you might have seen, I merged this functionality but had to revert as it broke the build on amd64 (!FDT). Here is an updated version which addresses this.

Tue, Apr 29, 4:37 PM
mhorne requested review of D50074: mccomphy: add support for YT8531.
Tue, Apr 29, 4:30 PM
mhorne accepted D50017: sys: Reduce where we include sys/devmap.h.
Tue, Apr 29, 2:07 PM
mhorne accepted D50016: subr_devmap: Reduce the use of the static devmap.

Thanks, this is great.

Tue, Apr 29, 2:07 PM

Mon, Apr 28

mhorne accepted D50015: subr_devmap: Make devmap_ptov static.
Mon, Apr 28, 4:11 PM
mhorne accepted D50014: arm/freescale: Stop using devmap_ptov.
Mon, Apr 28, 4:09 PM
mhorne accepted D50013: subr_devmap: Use the arm L1_S macro.
Mon, Apr 28, 4:05 PM
mhorne accepted D49937: iwlwifi.4: Update modes for recent 802.11ac.

Commit LGTM, if someone confirms the factual accuracy.

Mon, Apr 28, 4:01 PM
mhorne accepted D49762: networking.7: Clarifications.

Approved.

Mon, Apr 28, 4:00 PM

Thu, Apr 24

mhorne accepted D49988: mount.8: Add a single example for single user mode.

Approved.

Thu, Apr 24, 4:18 PM

Apr 3 2025

mhorne added a reverting change for rGe69623451ea6: mccomphy: add support for YT8531: rGb847e406e1df: Revert "mccomphy: add support for YT8531".
Apr 3 2025, 2:28 AM
mhorne committed rGb847e406e1df: Revert "mccomphy: add support for YT8531" (authored by mhorne).
Revert "mccomphy: add support for YT8531"
Apr 3 2025, 2:27 AM
mhorne added a reverting change for D45600: Add StarFive JH7110's Ethernet (eqos & mcommphy modifications, a new board specific file): rGb847e406e1df: Revert "mccomphy: add support for YT8531".
Apr 3 2025, 2:27 AM

Apr 2 2025

mhorne committed rGe69623451ea6: mccomphy: add support for YT8531 (authored by jsihv_gmx.com).
mccomphy: add support for YT8531
Apr 2 2025, 4:58 PM
mhorne committed rGcd92dd23241e: eqos: Add StarFive JH7110 variant (authored by jsihv_gmx.com).
eqos: Add StarFive JH7110 variant
Apr 2 2025, 4:58 PM
mhorne closed D45600: Add StarFive JH7110's Ethernet (eqos & mcommphy modifications, a new board specific file).
Apr 2 2025, 4:57 PM

Apr 1 2025

mhorne accepted D45600: Add StarFive JH7110's Ethernet (eqos & mcommphy modifications, a new board specific file).

Okay, I looked through the code again in detail and things seem good to me.

Apr 1 2025, 1:08 AM

Mar 29 2025

mhorne committed rGd2859cd9e33c: uefisign.8: fix indent (authored by mhorne).
uefisign.8: fix indent
Mar 29 2025, 8:48 PM

Mar 28 2025

mhorne accepted D49543: Correctly track index of first free irq map entry.

The one user-visible difference is that if we avoid reusing freed IDs then we can quickly hit PCI_INVALID_IRQ and get a panic. If we reuse freed IDs then we only hit that panic when we leak an IRQ (which is a separate issue I'm talking to @jhb about).

If someone can figure out how to resolve the "returning PCI_INVALID_IRQ from intr_map_irq makes bad things happen" issue then I agree there will be no functional difference.

Never mind, once the bogus PCI IRQ allocation is gone (D49560) there's no panic because intr_map_irq isn't returning into the PCI code.

So no user-visible difference here.

Mar 28 2025, 6:57 PM
mhorne accepted D49515: top: Sync usage and synopsis.
Mar 28 2025, 5:30 PM
mhorne added a comment to D49522: ps.1: Use ISO/IEC byte units.

Approved.

Mar 28 2025, 5:15 PM
mhorne accepted D49523: hier.7: Storage partitions are not filesystems.

Indeed, I did not read it closely enough :)

Mar 28 2025, 5:13 PM
mhorne accepted D49549: kern.opts.mk: Remove EFI from riscv BROKEN OPTIONS.

Aside from the warning, this should be a no-op, as the only thing gated behind this knob on the kernel side is sys/modules/efirt, which still has an additional MACHINE_CPUARCH check around it.

Mar 28 2025, 5:11 PM
mhorne added a comment to D49543: Correctly track index of first free irq map entry.

IMO it is logically preferable to exhaust all unique/unused IDs before issuing one that was previously assigned, then freed. This is how the current code behaves.

Mar 28 2025, 5:04 PM

Mar 25 2025

mhorne accepted D49462: top: Polish key bindings in usage and manual.

FYI, it is difficult to review a change that reorders and rewords a list of entries, at the same time. In the future such a thing should be split.

Mar 25 2025, 9:32 PM
mhorne added a comment to D49494: Handbook 26.6.1 examples should be git -C /usr/src pull.

I verified that there are no other instances of git -C with git grep and tested the command. @mhorne should I merge this?

Mar 25 2025, 9:21 PM
mhorne accepted D49494: Handbook 26.6.1 examples should be git -C /usr/src pull.
Mar 25 2025, 5:02 PM
mhorne requested changes to D49494: Handbook 26.6.1 examples should be git -C /usr/src pull.

git -C /usr/src pull, as you say in the title.

Mar 25 2025, 3:08 PM

Mar 24 2025

mhorne accepted D49487: riscv timer: fix interrupt handing.
Mar 24 2025, 5:34 PM

Mar 21 2025

mhorne accepted D49204: ports.7: Update dialog4ports to portconfig.

Approved.

Mar 21 2025, 5:48 PM
mhorne accepted D48342: UPDATING: Show plural syntax for PORTS_MODULES.

"show two examples in PORTS_MODULES so it's obvious that they're space separated", can you note something like this in the commit message?

Mar 21 2025, 2:59 PM
mhorne accepted D48343: style.mdoc: HARDWARE generates Release Notes.

LGTM, and Approved.

Mar 21 2025, 2:57 PM
mhorne accepted D48513: etdump.1: Polish + xref cd9660(4).

Approved.

Mar 21 2025, 2:55 PM
mhorne added inline comments to D49204: ports.7: Update dialog4ports to portconfig.
Mar 21 2025, 2:46 PM

Mar 19 2025

mhorne added a comment to D49408: rk_grf_gpio.4: Minor polish.

Thank you, I thought it does need it because I'm proposing changing the copyright header?

Mar 19 2025, 4:40 PM
mhorne accepted D49408: rk_grf_gpio.4: Minor polish.

I ask once again to be mindful of your use of the commit trailers here... The commit does not require "approval" from @shurd, but as the author of the man page (its de-facto maintainer), his "Reviewed by" is meaningful.

Mar 19 2025, 2:48 PM

Mar 18 2025

mhorne accepted D49404: Fix commit date for HPS In Memoriam entry.
Mar 18 2025, 5:28 PM
mhorne abandoned D48849: sdhci: refine locking in sdhci_card_task().

Superseded by aaf0a7302d10.

Mar 18 2025, 1:40 PM
mhorne abandoned D48848: aw_mmc: refine locking in aw_mmc_helper_cd_handler().
Mar 18 2025, 1:39 PM
mhorne added a comment to D48848: aw_mmc: refine locking in aw_mmc_helper_cd_handler().

Superseded by c0bed9bd0bda.

Mar 18 2025, 1:39 PM
mhorne abandoned D48851: dwmmc: refine locking in dwmmc_card_task().

Superseded by c0bed9bd0bda.

Mar 18 2025, 1:39 PM
mhorne abandoned D48846: sdhci: split sdhci_card_task().
Mar 18 2025, 1:38 PM
mhorne abandoned D48847: rtsx: clean up rtsx_card_task().
Mar 18 2025, 1:38 PM
mhorne abandoned D48850: rtsx: refine locking in rtsx_card_task().

Superseded by c0bed9bd0bda .

Mar 18 2025, 1:38 PM

Mar 17 2025

mhorne added a comment to D49215: In Memoriam: Hans Petter Selasky.

@gallatin, sir sorry to trouble you, if this memoriam is acceptable to you, with the permission of my mentors I will merge this.

Mar 17 2025, 5:59 PM

Mar 12 2025

mhorne accepted D49228: pmc: add emerald rapids model.
Mar 12 2025, 2:50 PM
mhorne accepted D49229: pmc: add alderlaken model.
Mar 12 2025, 2:47 PM
mhorne accepted D49255: pmc: add alderlake model.
Mar 12 2025, 2:47 PM
mhorne accepted D49323: ObsoleteFiles: Remove if_rtwn.4 removal.

Approved.

Mar 12 2025, 1:12 PM

Mar 4 2025

mhorne added a reverting change for rG9ddd516b8862: riscv: enable allwinner RTC: rG3816452ecac6: Revert "riscv: enable allwinner RTC".
Mar 4 2025, 3:26 PM
mhorne committed rG3816452ecac6: Revert "riscv: enable allwinner RTC" (authored by mhorne).
Revert "riscv: enable allwinner RTC"
Mar 4 2025, 3:26 PM
mhorne added a reverting change for D47514: riscv: enable allwinner RTC: rG3816452ecac6: Revert "riscv: enable allwinner RTC".
Mar 4 2025, 3:26 PM
mhorne added a comment to D47514: riscv: enable allwinner RTC.

Unfortunately, the assumption about "In all the devices we currently support, the clock names in the "clock-output-names" property" is clearly incorrect. The documented binding for the A10/A20 does not allow any of these clocks. so this breaks every single A10/A20 board...

Additionally, the required and maximum number of items in the clock-output names depends on the platform, so comparing fixed to 3 doesn't look right either.

Mar 4 2025, 3:18 PM
mhorne committed rGd09ec2eeb0d8: armada38x: implement gateclk clkdev methods (authored by mhorne).
armada38x: implement gateclk clkdev methods
Mar 4 2025, 3:14 PM

Mar 3 2025

mhorne committed rGe2a08ac9ce42: riscv: enable EFI framebuffer (authored by mhorne).
riscv: enable EFI framebuffer
Mar 3 2025, 4:13 PM
mhorne committed rG62c0997d4317: efiprot.h: add definitions for RISCV_EFI_BOOT_PROTOCOL (authored by mhorne).
efiprot.h: add definitions for RISCV_EFI_BOOT_PROTOCOL
Mar 3 2025, 4:13 PM
mhorne committed rG04a812ae94e4: riscv/stand: pass boot hart in loader metadata (authored by mhorne).
riscv/stand: pass boot hart in loader metadata
Mar 3 2025, 4:13 PM
mhorne committed rGa2e2178402af: riscv: parse memory regions from EFI map header (authored by mhorne).
riscv: parse memory regions from EFI map header
Mar 3 2025, 4:13 PM
mhorne committed rG8bfd5cefbc71: arm: switch to subr_efi_map.c (authored by mhorne).
arm: switch to subr_efi_map.c
Mar 3 2025, 4:13 PM
mhorne closed D48887: riscv/stand: pass boot hart in loader metadata.
Mar 3 2025, 4:13 PM
mhorne committed rGcb0fb2812914: exclude_efi_memreserve(): use the right type (authored by mhorne).
exclude_efi_memreserve(): use the right type
Mar 3 2025, 4:13 PM
mhorne closed D48885: efiprot.h: add definitions for RISCV_EFI_BOOT_PROTOCOL.
Mar 3 2025, 4:13 PM
mhorne committed rG125877c92d16: arm64: Split EFI map parsing code to a common file (authored by mhorne).
arm64: Split EFI map parsing code to a common file
Mar 3 2025, 4:13 PM
mhorne closed D48884: riscv: enable EFI framebuffer.
Mar 3 2025, 4:12 PM
mhorne closed D49131: riscv: parse memory regions from EFI map header.
Mar 3 2025, 4:12 PM
mhorne closed D49132: arm: switch to subr_efi_map.c.
Mar 3 2025, 4:12 PM
mhorne closed D47746: arm64: Split EFI map parsing code to a common file.
Mar 3 2025, 4:12 PM

Feb 25 2025

mhorne updated the test plan for D49132: arm: switch to subr_efi_map.c.
Feb 25 2025, 6:12 PM
mhorne requested review of D49132: arm: switch to subr_efi_map.c.
Feb 25 2025, 6:11 PM
mhorne requested review of D49131: riscv: parse memory regions from EFI map header.
Feb 25 2025, 6:10 PM
mhorne retitled D47746: arm64: Split EFI map parsing code to a common file from [RFC] Split EFI map parsing code to a common file to arm64: Split EFI map parsing code to a common file.
Feb 25 2025, 6:10 PM
mhorne updated the diff for D47746: arm64: Split EFI map parsing code to a common file.

Simplify license text (use SPDX/remove boilerplate).

Feb 25 2025, 6:09 PM
mhorne committed rG601925180df4: libpmc: add more alderlake models (authored by acazuc <acazuc@acazuc.fr>).
libpmc: add more alderlake models
Feb 25 2025, 3:37 PM
mhorne closed D49126: libpmc: add more alderlake models.
Feb 25 2025, 3:37 PM
mhorne added a comment to D49126: libpmc: add more alderlake models.

Can you confirm the git author field?

Feb 25 2025, 3:27 PM

Feb 24 2025

mhorne committed R11:1ebf5e656c9f: sysutils/opensbi: update to v1.6 (authored by mhorne).
sysutils/opensbi: update to v1.6
Feb 24 2025, 9:18 PM