- User Since
- Mar 22 2019, 4:46 AM (112 w, 2 d)
Fri, May 14
Seems fine, given the child revisions. Perhaps these changes can all be squashed for the final commit?
Thu, May 13
Tue, May 11
Mon, May 10
Thu, May 6
Wed, May 5
This looks fine to me, thanks for fixing this.
Thu, Apr 29
Tue, Apr 27
Sat, Apr 24
Agreed with @royger, this appears to be an indirect way of achieving the same behaviour.
Looks fine to me. I was wondering if __max_nr_grant_frames() would be evaluated twice, but it seems not as min() is a static inline function, unlike the macro MIN().
So, these files still contain references to definitions provided by intr_machdep.h? Do you know which ones/how many?
Thu, Apr 22
Wed, Apr 21
Looks good. Just curious, does the issue manifest in practice or was it caught by inspection?
Fri, Apr 16
Apr 14 2021
Thanks for catching this. I believe we generally prefer one block checking the supported MACHINE_CPUARCH values, like the _cgem.4 example below. Both styles are imperfect however.
Apr 13 2021
Apr 12 2021
Also clear in freebsd32_setregs(). Add a local pcb pointer instead of using td->pcb repeatedly.
Also handle linux_exec_setregs().
Apr 9 2021
Apr 8 2021
Address review comments.
Handle jhb's comments.