Page MenuHomeFreeBSD

mhorne (Mitchell Horne)
User

Projects

User Details

User Since
Mar 22 2019, 4:46 AM (130 w, 11 h)

Recent Activity

Today

mhorne accepted D31995: xen/intr: add check for intr_register_source() errors.

Looks fine to me. I would suggest keeping the KASSERT though, it is free and makes the point of failure more obvious if this condition did occur.

Fri, Sep 17, 12:27 PM

Yesterday

mhorne added inline comments to D31993: Allow minidumps to be performed on the live system.
Thu, Sep 16, 7:30 PM
mhorne added inline comments to D31990: minidump: reduce the amount direct accesses to page tables.
Thu, Sep 16, 6:59 PM
mhorne added a reviewer for D31992: minidump: Use the provided dump bitset: luporl.

This is mostly mechanical. state->dump_bitset should be used inside each minidump_machdep.c, and vm_page_dump everywhere else. The one exception to this is powerpc's dumpsys_scan_pmap() method, which is extended to also accept a bitset argument.

Thu, Sep 16, 6:51 PM
mhorne updated the test plan for D31990: minidump: reduce the amount direct accesses to page tables.
Thu, Sep 16, 6:47 PM
mhorne added reviewers for D31993: Allow minidumps to be performed on the live system: markj, kib, jhb, stevek.
Thu, Sep 16, 6:45 PM
mhorne added reviewers for D31992: minidump: Use the provided dump bitset: markj, kib, jhb, stevek.
Thu, Sep 16, 6:44 PM
mhorne added reviewers for D31991: minidump: Use provided msgbuf pointer: markj, kib, jhb, stevek.
Thu, Sep 16, 6:43 PM
mhorne added reviewers for D31990: minidump: reduce the amount direct accesses to page tables: markj, kib, jhb, stevek.
Thu, Sep 16, 6:42 PM
mhorne added reviewers for D31989: minidump: Parameterize minidumpsys(): markj, kib, jhb, stevek.
Thu, Sep 16, 6:41 PM
mhorne requested review of D31993: Allow minidumps to be performed on the live system.
Thu, Sep 16, 6:41 PM
mhorne requested review of D31992: minidump: Use the provided dump bitset.
Thu, Sep 16, 6:40 PM
mhorne requested review of D31991: minidump: Use provided msgbuf pointer.
Thu, Sep 16, 6:40 PM
mhorne requested review of D31990: minidump: reduce the amount direct accesses to page tables.
Thu, Sep 16, 6:40 PM
mhorne requested review of D31989: minidump: Parameterize minidumpsys().
Thu, Sep 16, 6:40 PM

Wed, Sep 15

mhorne added a comment to D31955: sys: unify boot/firmware variables.

This is confusing two mostly independent concepts. One is the firmware type. On arm64 it is almost always UEFI, however it could also boot via the same ABI as a Linux kernel. The other is the hardware description method.

Yes, they are somewhat independent, but they are interrelated and strongly correlate.

Of the spots touched by this they all appear to ask one of two questions:

  1. Use OpenFirmware device-tree or ACPI table?
  2. Are UEFI runtime services available?

I'm under the impression using device-trees pretty well excludes full UEFI runtime services. The only case where these mix at all is U-Boot's UEFI support, which mostly appears to be good enough for bootloader use and only minimally implement the UEFI spec.
As such this seems to be a spectrum with device-trees on one end and full UEFI the other.

Wed, Sep 15, 8:59 PM
mhorne accepted D31969: arm64, riscv: Fix TRAF_PC() to return the PC, not the return address..

Seems correct.

Wed, Sep 15, 4:18 PM

Tue, Sep 14

mhorne added inline comments to D31954: amd64: stop using top of the thread' kernel stack for FPU user save area.
Tue, Sep 14, 1:59 PM

Mon, Sep 13

mhorne added inline comments to D31929: boottrace(1): small wrapper utility.
Mon, Sep 13, 5:34 PM
mhorne requested review of D31930: boottrace: rc annotations.
Mon, Sep 13, 3:19 PM
mhorne requested review of D31929: boottrace(1): small wrapper utility.
Mon, Sep 13, 3:17 PM
mhorne requested review of D31928: boottrace: annotate init and shutdown utilities.
Mon, Sep 13, 3:16 PM

Fri, Sep 10

mhorne added inline comments to D31885: minidump: De-duplicate the progress bar.
Fri, Sep 10, 8:37 PM
mhorne updated the diff for D31885: minidump: De-duplicate the progress bar.

Rename functions to have a dumpsys_ prefix.

Fri, Sep 10, 8:29 PM
mhorne updated the summary of D31893: bcm2835_sdhci: don't use DMA for kernel dumps.
Fri, Sep 10, 3:43 PM

Thu, Sep 9

mhorne added a comment to D31893: bcm2835_sdhci: don't use DMA for kernel dumps.

It is possible that this check would be better placed in the sdhci driver itself, where SDHCI_WILL_HANDLE_TRANSFER() is actually called. This is the only driver that implements this method, however.

Thu, Sep 9, 6:32 PM
mhorne updated the test plan for D31893: bcm2835_sdhci: don't use DMA for kernel dumps.
Thu, Sep 9, 6:32 PM
mhorne requested review of D31893: bcm2835_sdhci: don't use DMA for kernel dumps.
Thu, Sep 9, 6:29 PM
mhorne updated the diff for D31884: minidump: De-duplicate is_dumpable().

Drop include of vm_phys.h from vm_dumpset.h. Include it where it is needed instead.

Thu, Sep 9, 2:51 PM

Wed, Sep 8

mhorne requested review of D31885: minidump: De-duplicate the progress bar.
Wed, Sep 8, 9:01 PM
mhorne added a comment to D31884: minidump: De-duplicate is_dumpable().

This is a good cleanup. I don't really like the header pollution. We are already assuming that consumers have included vm_page.h (to check m->flags & PG_NODUMP), so why not vm_phys.h as well? Alternately we could have the implementation live in vm_phys.c and call it vm_phys_is_dumpable() or so.

Wed, Sep 8, 7:32 PM
mhorne updated the test plan for D31884: minidump: De-duplicate is_dumpable().
Wed, Sep 8, 7:02 PM
mhorne requested review of D31884: minidump: De-duplicate is_dumpable().
Wed, Sep 8, 6:51 PM

Mon, Aug 30

mhorne committed R10:0e78510b7549: hwpmc: don't validate capabilities in allocation method (authored by mhorne).
hwpmc: don't validate capabilities in allocation method
Mon, Aug 30, 7:16 PM
mhorne committed R10:315cd55dba61: hwpmc: consistently validate PMC class in allocation method (authored by mhorne).
hwpmc: consistently validate PMC class in allocation method
Mon, Aug 30, 7:16 PM
mhorne closed D31388: hwpmc: don't validate capabilities in allocation method.
Mon, Aug 30, 7:16 PM
mhorne closed D31387: hwpmc: consistently validate PMC class in allocation method.
Mon, Aug 30, 7:16 PM
mhorne added a comment to D31387: hwpmc: consistently validate PMC class in allocation method.

Worked fine on POWER9.
For PowerPC, without these changes the allocation of more programmable counters than available already failed, because of the check for the counter number in allocate. But, as you said, it is always a good idea to validate the PMC class too.

Mon, Aug 30, 7:12 PM
mhorne added a comment to D31283: Measure latency of PMC interruptions.
In D31283#714889, @wma wrote:

Any further comments?

Mon, Aug 30, 5:18 PM
mhorne committed R10:fb886a18a0eb: kdb: Handle process enumeration before procinit() (authored by mhorne).
kdb: Handle process enumeration before procinit()
Mon, Aug 30, 4:02 PM
mhorne committed R10:3d51152bfe83: pmc(3): remove Pentium-related man pages and references (authored by mhorne).
pmc(3): remove Pentium-related man pages and references
Mon, Aug 30, 4:01 PM
mhorne committed R10:706df48aeda9: arm: enable stack-smashing protection (authored by mhorne).
arm: enable stack-smashing protection
Mon, Aug 30, 4:01 PM
mhorne committed R10:4d0dc60f1401: xinstall: fix invocation of llvm-strip (authored by mhorne).
xinstall: fix invocation of llvm-strip
Mon, Aug 30, 2:57 PM
mhorne closed D30614: xinstall: fix invocation of llvm-strip.
Mon, Aug 30, 2:57 PM

Aug 11 2021

mhorne closed D31423: pmc(3): remove Pentium-related man pages and references.

Weird, this didn't get auto-closed.

Aug 11 2021, 6:35 PM
mhorne committed R10:4ccaa87f695c: kdb: Handle process enumeration before procinit() (authored by mhorne).
kdb: Handle process enumeration before procinit()
Aug 11 2021, 5:45 PM
mhorne closed D31495: kdb: Handle process enumeration before procinit().
Aug 11 2021, 5:45 PM
mhorne committed R10:62bee146aa42: Prefer MK_SSP=no to SSP_CFLAGS= (authored by mhorne).
Prefer MK_SSP=no to SSP_CFLAGS=
Aug 11 2021, 5:26 PM
mhorne committed R10:db26d3ca59a9: mk: format some option lists (authored by mhorne).
mk: format some option lists
Aug 11 2021, 5:25 PM
mhorne committed R10:88ef00584bc7: hwpmc: disable uncore class on Sandy Bridge and newer (authored by mhorne).
hwpmc: disable uncore class on Sandy Bridge and newer
Aug 11 2021, 5:25 PM
mhorne committed R10:2e50ba70742b: hwpmc: disable uncore class on Sandy Bridge and newer (authored by mhorne).
hwpmc: disable uncore class on Sandy Bridge and newer
Aug 11 2021, 5:25 PM
mhorne committed R10:19cbaf34a3e4: mk: format some option lists (authored by mhorne).
mk: format some option lists
Aug 11 2021, 5:25 PM
mhorne committed R10:952226eedb0b: Prefer MK_SSP=no to SSP_CFLAGS= (authored by mhorne).
Prefer MK_SSP=no to SSP_CFLAGS=
Aug 11 2021, 5:25 PM
mhorne added a comment to D31387: hwpmc: consistently validate PMC class in allocation method.

Ping.

Aug 11 2021, 4:44 PM
mhorne retitled D31388: hwpmc: don't validate capabilities in allocation method from hwpmc: consistently validate capabilities in pcd_allocate_pmc() to hwpmc: don't validate capabilities in allocation method.
Aug 11 2021, 4:43 PM
mhorne updated the diff for D31388: hwpmc: don't validate capabilities in allocation method.

Switch to just removing the existing redundant capability checks.

Aug 11 2021, 4:42 PM
mhorne updated the diff for D31495: kdb: Handle process enumeration before procinit().

Also give pidhashtbl a specific initial value of NULL. NFC, but semantically correct.

Aug 11 2021, 3:08 PM
mhorne updated the diff for D31495: kdb: Handle process enumeration before procinit().

Update with markj's feedback. Keep the allproc initialization bit, as it may be checked early by db_ps().

Aug 11 2021, 3:04 PM
mhorne accepted D31477: Enable SError exceptions in the kernel.
Aug 11 2021, 2:57 PM
mhorne added inline comments to D31495: kdb: Handle process enumeration before procinit().
Aug 11 2021, 2:27 PM

Aug 10 2021

mhorne requested review of D31495: kdb: Handle process enumeration before procinit().
Aug 10 2021, 11:11 PM
mhorne added reviewers for D31494: developers-handbook: update the section on Remote GDB: docs, jhb.
Aug 10 2021, 11:10 PM
mhorne requested review of D31494: developers-handbook: update the section on Remote GDB.
Aug 10 2021, 11:06 PM
mhorne committed R10:d78896e46f1d: pmc(3): remove Pentium-related man pages and references (authored by mhorne).
pmc(3): remove Pentium-related man pages and references
Aug 10 2021, 8:21 PM

Aug 9 2021

mhorne added inline comments to D31477: Enable SError exceptions in the kernel.
Aug 9 2021, 5:46 PM
mhorne accepted D31460: riscv: Fix pmap_alloc_l2 when it should allocate a new L1 entry.
Aug 9 2021, 3:53 PM

Aug 6 2021

mhorne accepted D31033: fu740_pci_dw: Add SiFive FU740 PCIe controller driver.

While I did not go over every line in detail, I don't see anything objectionable. The PCIe chapter in the FU740 manual is particularly lacking.

I've lightly tested this series on my board, root on USB and NVMe both appear to be working. My remaining concern is that I see messages about failed PCI resource allocation in the boot log, see P514. Is this expected? The kernel I've tested here is based on your unmatched branch (b96c50e2fad) + one unrelated commit of mine.

Yes, those are harmless, when resetting the controller all the windows change to 4K open windows at a low address (either 0 or 4K, I forget) that FreeBSD initially interprets as being configured by firmware and thus tries to preserve them, but fails to (since they're not within the controller's static address ranges). I'd like to find a way to silence those somehow (clear_pcib exists but for some reason doesn't seem to quite work, enumeration stops after the first bridge), but that'd be a future patch as it's not causing any functional issues.

Aug 6 2021, 5:39 PM
mhorne added a comment to D31033: fu740_pci_dw: Add SiFive FU740 PCIe controller driver.

While I did not go over every line in detail, I don't see anything objectionable. The PCIe chapter in the FU740 manual is particularly lacking.

Aug 6 2021, 2:19 PM
mhorne created P514 unmatched dmesg.
Aug 6 2021, 2:13 PM

Aug 5 2021

mhorne accepted D31031: sifive_gpio: Add SiFive GPIO controller driver.

Forgot to hit accept :)

Aug 5 2021, 8:29 PM
mhorne added a comment to D31031: sifive_gpio: Add SiFive GPIO controller driver.

There is a list of gpio drivers in the gpiobus(4) man page. It is not up to date, but you should add an entry for this driver.

Aug 5 2021, 8:28 PM
mhorne added a member for pmc: mhorne.
Aug 5 2021, 2:11 PM
mhorne requested review of D31423: pmc(3): remove Pentium-related man pages and references.
Aug 5 2021, 2:10 PM

Aug 4 2021

mhorne committed R10:61ed578ee666: Prefer MK_SSP=no to SSP_CFLAGS= (authored by mhorne).
Prefer MK_SSP=no to SSP_CFLAGS=
Aug 4 2021, 6:25 PM
mhorne committed R10:1b8db4b4e361: arm: enable stack-smashing protection (authored by mhorne).
arm: enable stack-smashing protection
Aug 4 2021, 6:25 PM
mhorne committed R10:bcd2f41f7d22: mk: format some option lists (authored by mhorne).
mk: format some option lists
Aug 4 2021, 6:25 PM
mhorne committed R10:8399d923a569: hwpmc_intel: assert for correct nclasses value (authored by mhorne).
hwpmc_intel: assert for correct nclasses value
Aug 4 2021, 6:25 PM
mhorne committed R10:4f35e8cba232: hwpmc: disable uncore class on Sandy Bridge and newer (authored by mhorne).
hwpmc: disable uncore class on Sandy Bridge and newer
Aug 4 2021, 6:25 PM
mhorne closed D31401: Prefer MK_SSP=no to SSP_CFLAGS=.
Aug 4 2021, 6:25 PM
mhorne closed D31400: arm: enable ssp.
Aug 4 2021, 6:25 PM
mhorne closed D31399: mk: format some option lists.
Aug 4 2021, 6:25 PM
mhorne closed D31389: hwpmc: disable uncore class on Sandy Bridge and newer.
Aug 4 2021, 6:24 PM
mhorne added a comment to D31388: hwpmc: don't validate capabilities in allocation method.

Some existing cases returned EPERM for the != caps cases?

Aug 4 2021, 5:27 PM
mhorne accepted D31022: sifive_prci: Add support for the FU740 PRCI.
Aug 4 2021, 2:54 PM
mhorne accepted D31023: sifive_prci: Delay attachment until after clk_fixed.
Aug 4 2021, 2:53 PM

Aug 3 2021

mhorne added inline comments to D31401: Prefer MK_SSP=no to SSP_CFLAGS=.
Aug 3 2021, 6:24 PM
mhorne requested review of D31401: Prefer MK_SSP=no to SSP_CFLAGS=.
Aug 3 2021, 6:21 PM
mhorne requested review of D31400: arm: enable ssp.
Aug 3 2021, 6:20 PM
mhorne requested review of D31399: mk: format some option lists.
Aug 3 2021, 6:18 PM
mhorne abandoned D29651: relnotes: add a section with some RISC-V changes.

Unfortunately, I ran out of steam for this ahead of the release, and the moment has passed.

Aug 3 2021, 4:05 PM

Aug 2 2021

mhorne requested review of D31389: hwpmc: disable uncore class on Sandy Bridge and newer.
Aug 2 2021, 9:23 PM
mhorne updated the test plan for D31388: hwpmc: don't validate capabilities in allocation method.
Aug 2 2021, 9:11 PM
mhorne requested review of D31388: hwpmc: don't validate capabilities in allocation method.
Aug 2 2021, 9:09 PM
mhorne updated the test plan for D31387: hwpmc: consistently validate PMC class in allocation method.
Aug 2 2021, 9:07 PM
mhorne updated the test plan for D31387: hwpmc: consistently validate PMC class in allocation method.
Aug 2 2021, 9:07 PM
mhorne requested review of D31387: hwpmc: consistently validate PMC class in allocation method.
Aug 2 2021, 9:04 PM

Jul 30 2021

mhorne added inline comments to D31312: kern/rman: warn/KASSERT() on garbled reservations.
Jul 30 2021, 12:40 PM

Jul 29 2021

mhorne added inline comments to D31022: sifive_prci: Add support for the FU740 PRCI.
Jul 29 2021, 6:53 PM
mhorne added inline comments to D31031: sifive_gpio: Add SiFive GPIO controller driver.
Jul 29 2021, 3:43 PM
mhorne committed R10:28ff0070f7c8: libpmc: Import AMD Zen 3 PMU events (authored by greg_unrelenting.technology).
libpmc: Import AMD Zen 3 PMU events
Jul 29 2021, 3:28 PM