Page MenuHomeFreeBSD

mhorne (Mitchell Horne)
User

Projects

User Details

User Since
Mar 22 2019, 4:46 AM (279 w, 1 d)

Recent Activity

Thu, Jul 18

mhorne committed rGf38669ef6d6a: tarfs.4: update title after move to section four (authored by concussious.bugzilla_runbox.com).
tarfs.4: update title after move to section four
Thu, Jul 18, 6:33 PM
mhorne updated the diff for D45961: dev-handbook: Split x86 assembly chapter into new article.

Complete the change by removing the content from the developers-handbook.

Thu, Jul 18, 4:17 PM
mhorne accepted D45998: pmap_growkernel: Use VM_ALLOC_NOFREE when allocating pagetable pages.

Nice. The flag acts as a meaningful annotation, regardless of any effects on fragmentation.

Thu, Jul 18, 4:11 PM

Wed, Jul 17

mhorne added a comment to D45981: sys: Stop requiring nested parentheses for KASSERT.
In D45981#1048758, @jhb wrote:

I'd kind of wanted to kill MPASS eventually since I have used it for all sorts of assertions that have nothing to do with SMP, and other assertions in the language permit 1 argument variants (assert() and static_assert()). However, it is simpler to not have the single arg version and it does mean _KASSERT_MACRO would be temporary. We could always add a single arg variant later if we wanted.

Wed, Jul 17, 5:09 PM

Fri, Jul 12

mhorne added a reviewer for D45961: dev-handbook: Split x86 assembly chapter into new article: doceng.
Fri, Jul 12, 5:02 PM
mhorne requested review of D45963: x86-assembly: fix broken links.
Fri, Jul 12, 5:01 PM
mhorne requested review of D45962: x86-assembly: update the article a bit.
Fri, Jul 12, 5:01 PM
mhorne requested review of D45961: dev-handbook: Split x86 assembly chapter into new article.
Fri, Jul 12, 5:01 PM
mhorne closed D45948: Status/2024q2/riscv.adoc: Add report.
Fri, Jul 12, 2:29 PM
mhorne committed R9:6f80e223c1fc: Status/2024q2/riscv.adoc: Add report (authored by mhorne).
Status/2024q2/riscv.adoc: Add report
Fri, Jul 12, 2:29 PM
mhorne committed rGcb18ba9df52d: time.1: minor cleanup (alignment/macro/spdx) (authored by concussious.bugzilla_runbox.com).
time.1: minor cleanup (alignment/macro/spdx)
Fri, Jul 12, 2:18 PM

Wed, Jul 10

mhorne requested review of D45948: Status/2024q2/riscv.adoc: Add report.
Wed, Jul 10, 7:56 PM
mhorne committed rG7339a7bd9739: plic: add thead,c900-plic compatible (authored by mhorne).
plic: add thead,c900-plic compatible
Wed, Jul 10, 5:10 PM

Tue, Jul 9

mhorne closed D45920: amd64: use pc_is_full() helper function.
Tue, Jul 9, 6:49 PM
mhorne committed rGe7f849e25bbc: amd64: use pc_is_full() helper function (authored by mhorne).
amd64: use pc_is_full() helper function
Tue, Jul 9, 6:49 PM
mhorne committed rGae4c7e6aa036: riscv: fix pv_chunk check in pmap_pv_demote_l2() (authored by Wuyang Chung <wy-chung@outlook.com>).
riscv: fix pv_chunk check in pmap_pv_demote_l2()
Tue, Jul 9, 6:49 PM

Mon, Jul 8

mhorne requested review of D45920: amd64: use pc_is_full() helper function.
Mon, Jul 8, 4:08 PM
mhorne added a comment to D45915: License Guide: Recommend SPDX Identifier come before copyright.

Note the duplicated info at https://www.freebsd.org/internal/software-license/

Mon, Jul 8, 3:48 PM
mhorne committed rGbdf2c8fff9ce: riscv: Don't need to check the return value with NULL (authored by wy-chung <wy-chung@outlook.com>).
riscv: Don't need to check the return value with NULL
Mon, Jul 8, 3:44 PM
mhorne requested review of D45914: subr_physmem_test: add tests for two edge-cases.
Mon, Jul 8, 3:23 PM
mhorne closed D45759: arm64: simplify physmap usage in pmap_bootstrap().
Mon, Jul 8, 2:55 PM
mhorne committed rGb426b8b3b000: arm64: simplify physmap usage in pmap_bootstrap() (authored by mhorne).
arm64: simplify physmap usage in pmap_bootstrap()
Mon, Jul 8, 2:55 PM
mhorne committed rG558c1b37334c: busdma: avoid buflen underflow (authored by mhorne).
busdma: avoid buflen underflow
Mon, Jul 8, 2:53 PM
mhorne closed D45760: riscv: include PV chunks in kernel dump.
Mon, Jul 8, 2:53 PM
mhorne closed D45732: busdma: avoid buflen underflow.
Mon, Jul 8, 2:53 PM
mhorne committed rG4e148a7baa1c: riscv: include PV chunks in kernel dump (authored by mhorne).
riscv: include PV chunks in kernel dump
Mon, Jul 8, 2:53 PM
mhorne committed rG88d81453b115: riscv: support PV_STATS pmap option (authored by mhorne).
riscv: support PV_STATS pmap option
Mon, Jul 8, 2:53 PM
mhorne closed D45475: riscv: support PV_STATS pmap option.
Mon, Jul 8, 2:52 PM

Thu, Jul 4

mhorne added a comment to D45761: riscv: use counter(9) for pmap counters.
In D45761#1044584, @alc wrote:

I was about to comment that other pmaps still use atomics for these counters, but it seems that amd64's also been using counter(9) for a while. I'm a bit skeptical that that's really necessary (except perhaps for p_failures), but it doesn't have much downside either. It would be nice to make at least arm64 consistent.

I share your skepticism for the L2 counters, but I see no real harm in this change. Similarly, I would have no objections to making the same change on arm64. On arm64, we are using counter(9) for 64KB pages, where the counts are typically two orders of magnitude larger.

Thu, Jul 4, 1:58 PM
mhorne committed rG08b083932c6f: wpa_cli.8: describe better + tag spdx + linter nit (authored by concussious.bugzilla_runbox.com).
wpa_cli.8: describe better + tag spdx + linter nit
Thu, Jul 4, 1:33 PM
mhorne committed rG8daa60945080: if_genet: don't load DMA mapping when tx_queue is full (authored by mhorne).
if_genet: don't load DMA mapping when tx_queue is full
Thu, Jul 4, 1:32 PM

Fri, Jun 28

mhorne committed rG2eb64df7f53d: riscv: remove a redundant check on PGA_WRITEABLE (authored by wy-chung <wy-chung@outlook.com>).
riscv: remove a redundant check on PGA_WRITEABLE
Fri, Jun 28, 2:14 PM

Thu, Jun 27

mhorne updated the diff for D45759: arm64: simplify physmap usage in pmap_bootstrap().

Rebase after 32d2a1de3d64.

Thu, Jun 27, 7:34 PM
mhorne committed rG32d2a1de3d64: arm64: correct physmap bounds in pmap_bootstrap() (authored by mhorne).
arm64: correct physmap bounds in pmap_bootstrap()
Thu, Jun 27, 7:33 PM
mhorne added inline comments to D45472: [DRAFT/RFC] riscv: T-HEAD PBMT support.
Thu, Jun 27, 6:48 PM
mhorne updated the diff for D45472: [DRAFT/RFC] riscv: T-HEAD PBMT support.

Update according to C910 specification.

Thu, Jun 27, 6:39 PM
mhorne updated the summary of D45761: riscv: use counter(9) for pmap counters.
Thu, Jun 27, 6:34 PM
mhorne added inline comments to D45759: arm64: simplify physmap usage in pmap_bootstrap().
Thu, Jun 27, 6:33 PM
mhorne requested review of D45760: riscv: include PV chunks in kernel dump.
Thu, Jun 27, 6:30 PM
mhorne requested review of D45761: riscv: use counter(9) for pmap counters.
Thu, Jun 27, 6:30 PM
mhorne updated the diff for D45475: riscv: support PV_STATS pmap option.

Flesh out the missing stat calls.

Thu, Jun 27, 6:29 PM
mhorne requested review of D45759: arm64: simplify physmap usage in pmap_bootstrap().
Thu, Jun 27, 6:29 PM
mhorne committed rG9a53391b601d: riscv: adjust physmem reservation (authored by mhorne).
riscv: adjust physmem reservation
Thu, Jun 27, 5:57 PM
mhorne committed rG53a64a093824: rk_pinctrl: fix error check (authored by John F. Carr <jfc@mit.edu>).
rk_pinctrl: fix error check
Thu, Jun 27, 5:57 PM
mhorne committed rGa35f66510917: if_genet: don't load DMA mapping when tx_queue is full (authored by mhorne).
if_genet: don't load DMA mapping when tx_queue is full
Thu, Jun 27, 5:45 PM
mhorne committed rG18a27dd64129: wpa_cli.8: describe better + tag spdx + linter nit (authored by concussious.bugzilla_runbox.com).
wpa_cli.8: describe better + tag spdx + linter nit
Thu, Jun 27, 2:57 PM

Jun 26 2024

mhorne accepted D45730: libc: scalar memset() in RISC-V assembly.
Jun 26 2024, 3:57 PM
mhorne accepted D45693: libc: scalar strlen() in RISC-V assembly.

Thanks a lot!

Jun 26 2024, 3:54 PM
mhorne committed rG609cdb12b962: ofw: convert boolean_t to bool (authored by mhorne).
ofw: convert boolean_t to bool
Jun 26 2024, 2:16 PM
mhorne closed D45733: ofw: convert boolean_t to bool.
Jun 26 2024, 2:16 PM

Jun 25 2024

mhorne requested review of D45733: ofw: convert boolean_t to bool.
Jun 25 2024, 5:59 PM
mhorne added a comment to D45732: busdma: avoid buflen underflow.

I could apply the same guard to bounce_bus_dmamap_load_phys() methods, but in those functions it is easier to see that underflow is not possible, so I haven't yet.

Jun 25 2024, 5:09 PM
mhorne requested review of D45732: busdma: avoid buflen underflow.
Jun 25 2024, 5:05 PM
mhorne added inline comments to D45693: libc: scalar strlen() in RISC-V assembly.
Jun 25 2024, 2:44 PM
mhorne requested changes to D45693: libc: scalar strlen() in RISC-V assembly.

The new .S file needs a license.

Jun 25 2024, 2:29 PM

Jun 24 2024

mhorne accepted D45696: riscv: add SBI implementation IDs.
Jun 24 2024, 6:57 PM
mhorne accepted D45697: riscv: add FPE code.

Thanks for this. One tweak required.

Jun 24 2024, 6:55 PM

Jun 21 2024

mhorne updated the diff for D45471: riscv: Svpbmt extension support.

Apply memattr bits to mappings created at the end of pmap_bootstrap() (this was missed).

Jun 21 2024, 2:39 PM
mhorne updated the diff for D45628: riscv: implement pmap_demote_l1().

Handle feedback; mainly, update the assertions.

Jun 21 2024, 2:37 PM
mhorne accepted D45630: Remove SacBLUG from the NA section.
Jun 21 2024, 1:43 PM
mhorne accepted D45527: hwpmc/arm64: Support the kernel booting to VHE.
Jun 21 2024, 1:42 PM
mhorne accepted D45526: hwpmc/arm64: fix the type for pm_arm64_evsel.
Jun 21 2024, 1:41 PM
mhorne added inline comments to D45553: bhyve/riscv kernel part.
Jun 21 2024, 1:40 PM
mhorne added a comment to D45553: bhyve/riscv kernel part.

Hi, just a preliminary look, much of the vmm code is beyond me. I hope to test this stuff in a couple weeks!

Jun 21 2024, 1:36 PM
mhorne committed rG1b8d4c8496cf: build.7: +freebsd to description, link development (authored by concussious.bugzilla_runbox.com).
build.7: +freebsd to description, link development
Jun 21 2024, 1:09 PM
mhorne committed rGb8f2781b4623: build.7: update cross-compile example (authored by mhorne).
build.7: update cross-compile example
Jun 21 2024, 1:09 PM
mhorne committed rG6d87472f3234: build.7: nit section order, tag spdx (authored by concussious.bugzilla_runbox.com).
build.7: nit section order, tag spdx
Jun 21 2024, 1:09 PM
mhorne committed rGa3e8efd45a42: git-arc.1: list width typo (authored by concussious.bugzilla_runbox.com).
git-arc.1: list width typo
Jun 21 2024, 1:08 PM

Jun 20 2024

mhorne committed rG18051cc694be: riscv: drop l1pt argument from pmap_bootstrap() (authored by mhorne).
riscv: drop l1pt argument from pmap_bootstrap()
Jun 20 2024, 7:01 PM
mhorne committed rG762a3224cde6: riscv: smarter DMAP construction (authored by mhorne).
riscv: smarter DMAP construction
Jun 20 2024, 7:01 PM
mhorne committed rGde09dcebd720: riscv: rework page table bootstrap (authored by mhorne).
riscv: rework page table bootstrap
Jun 20 2024, 7:01 PM
mhorne committed rGbfb857546984: riscv: Construct an identity map in locore.S (authored by mhorne).
riscv: Construct an identity map in locore.S
Jun 20 2024, 7:01 PM
mhorne closed D45470: riscv: drop l1pt argument from pmap_bootstrap().
Jun 20 2024, 7:00 PM
mhorne closed D45328: riscv: smarter DMAP construction.
Jun 20 2024, 7:00 PM
mhorne closed D45327: riscv: rework page table bootstrap.
Jun 20 2024, 7:00 PM
mhorne closed D45324: riscv: Construct an identity map in locore.S.
Jun 20 2024, 7:00 PM
mhorne added inline comments to D45628: riscv: implement pmap_demote_l1().
Jun 20 2024, 4:51 PM

Jun 18 2024

mhorne added inline comments to D45628: riscv: implement pmap_demote_l1().
Jun 18 2024, 6:22 PM
mhorne added inline comments to D45471: riscv: Svpbmt extension support.
Jun 18 2024, 6:18 PM
mhorne retitled D45471: riscv: Svpbmt extension support from [DRAFT/RFC] riscv: Svpbmt extension support to riscv: Svpbmt extension support.
Jun 18 2024, 6:15 PM
mhorne updated the diff for D45471: riscv: Svpbmt extension support.

Finish implementation of pmap_change_attr_locked().

Jun 18 2024, 6:10 PM
mhorne requested review of D45628: riscv: implement pmap_demote_l1().
Jun 18 2024, 6:07 PM

Jun 14 2024

mhorne committed rG134f7b5fa91f: riscv: improve commentary around initial stvec (authored by mhorne).
riscv: improve commentary around initial stvec
Jun 14 2024, 6:03 PM
mhorne committed rG3ff981587ff8: riscv: Don't handle missing kernel L3 pages (authored by mhorne).
riscv: Don't handle missing kernel L3 pages
Jun 14 2024, 6:03 PM
mhorne committed rG0e4e77072f65: riscv: adjust physmem reservation (authored by mhorne).
riscv: adjust physmem reservation
Jun 14 2024, 6:03 PM
mhorne closed D45474: riscv: improve commentary around initial stvec.
Jun 14 2024, 6:02 PM
mhorne closed D45326: riscv: Don't handle missing kernel L3 pages.
Jun 14 2024, 6:02 PM
mhorne closed D45325: riscv: adjust physmem reservation.
Jun 14 2024, 6:02 PM
mhorne added inline comments to D45328: riscv: smarter DMAP construction.
Jun 14 2024, 5:52 PM
mhorne updated the diff for D45328: riscv: smarter DMAP construction.

Drop unneeded warning print.

Jun 14 2024, 5:51 PM
mhorne added inline comments to D45327: riscv: rework page table bootstrap.
Jun 14 2024, 5:48 PM
mhorne updated the diff for D45327: riscv: rework page table bootstrap.

Handle comment from markj.

Jun 14 2024, 5:46 PM
mhorne committed rG97ab935d566c: rk_pinctrl: fix error check (authored by John F. Carr <jfc@mit.edu>).
rk_pinctrl: fix error check
Jun 14 2024, 4:43 PM

Jun 7 2024

mhorne accepted D45497: riscv: include AHCI.
Jun 7 2024, 4:14 PM
mhorne planned changes to D45475: riscv: support PV_STATS pmap option.

There is actually more to be done here...

Jun 7 2024, 4:14 PM

Jun 6 2024

mhorne committed rG8490d5ec8e0e: Adjust comments referencing vm_mem_init() (authored by mhorne).
Adjust comments referencing vm_mem_init()
Jun 6 2024, 3:55 PM
mhorne committed rGf8b05837c606: arm64, riscv: removed unused struct pv_addr (authored by mhorne).
arm64, riscv: removed unused struct pv_addr
Jun 6 2024, 3:55 PM
mhorne committed rG84e95f36f600: arm64, riscv: remove unused declaration (authored by mhorne).
arm64, riscv: remove unused declaration
Jun 6 2024, 3:55 PM
mhorne committed rG4fa9eee03abd: ieee80211_vap(9): fix the title (authored by mhorne).
ieee80211_vap(9): fix the title
Jun 6 2024, 3:55 PM
mhorne added a comment to D43251: Update riscv-isa-sim to 2024-05-31 snapshot.

Just a question, how you test on kernel, I use spike --kernel /path/to/kernel /path/to/sbi. It give me invalid address error even after I add -m0x1000000,0x2000.

Jun 6 2024, 3:11 PM