Page MenuHomeFreeBSD

mhorne (Mitchell Horne)
User

Projects

User Details

User Since
Mar 22 2019, 4:46 AM (112 w, 2 d)

Recent Activity

Yesterday

mhorne committed R10:7fbc0c98a8ef: build(7): use a more relevant example for PORTS_MODULES (authored by mhorne).
build(7): use a more relevant example for PORTS_MODULES
Sat, May 15, 2:16 PM
mhorne closed D30261: build(7): use a more relevant example for PORTS_MODULES.
Sat, May 15, 2:16 PM

Fri, May 14

mhorne closed D30262: git-arc(1): fix usage formatting for stage command.
Fri, May 14, 8:35 PM
mhorne committed R10:cf653b7abea3: git-arc(1): fix usage formatting for stage command (authored by mhorne).
git-arc(1): fix usage formatting for stage command
Fri, May 14, 8:35 PM
mhorne requested review of D30262: git-arc(1): fix usage formatting for stage command.
Fri, May 14, 4:28 PM
mhorne requested review of D30261: build(7): use a more relevant example for PORTS_MODULES.
Fri, May 14, 4:26 PM
mhorne accepted D29811: xen/xen-os: move inclusion of machine/xen-os.h later.

Seems fine, given the child revisions. Perhaps these changes can all be squashed for the final commit?

Fri, May 14, 1:42 PM
mhorne accepted D29402: xen: introduce xen_support_evtchn_bind().
Fri, May 14, 1:32 PM

Thu, May 13

mhorne committed R10:f59127dac5ca: hwpmc: fix PMC_CPU_LAST (authored by mhorne).
hwpmc: fix PMC_CPU_LAST
Thu, May 13, 7:06 PM
mhorne closed D30216: libpmc: fall-back to kernel tables if pmu-events fails.
Thu, May 13, 7:06 PM
mhorne committed R10:dfdc57e8aa8b: libpmc: fall-back to kernel tables if pmu-events fails (authored by mhorne).
libpmc: fall-back to kernel tables if pmu-events fails
Thu, May 13, 7:06 PM
mhorne closed D30196: libpmc: remove PMC_MDEP_TABLE logic.
Thu, May 13, 7:06 PM
mhorne committed R10:da13ef6aa056: libpmc: remove PMC_MDEP_TABLE logic (authored by mhorne).
libpmc: remove PMC_MDEP_TABLE logic
Thu, May 13, 7:06 PM
mhorne closed D30195: libpmc: remove unused PMC_MDEP_INIT_INTEL_V2.
Thu, May 13, 7:05 PM
mhorne committed R10:4d8d74a4f52e: libpmc: remove unused PMC_MDEP_INIT_INTEL_V2 (authored by mhorne).
libpmc: remove unused PMC_MDEP_INIT_INTEL_V2
Thu, May 13, 7:05 PM

Tue, May 11

mhorne added a comment to D30219: generate pmc.soft(3) page fault events on !x86.
In D30219#678555, @kib wrote:

Why not move this to vm_fault_trap()?

Tue, May 11, 9:31 PM
mhorne updated the test plan for D30219: generate pmc.soft(3) page fault events on !x86.
Tue, May 11, 8:51 PM
mhorne added inline comments to D30219: generate pmc.soft(3) page fault events on !x86.
Tue, May 11, 8:48 PM
mhorne requested review of D30219: generate pmc.soft(3) page fault events on !x86.
Tue, May 11, 8:46 PM
mhorne added a comment to D29923: arm: add a release conf for distribution files.
In D29923#671549, @gjb wrote:

I think it might be a bit more complicated than this configuration file suggests, but please go ahead and commit it, and we'll work out the edge cases (if any) as they occur.

Tue, May 11, 7:57 PM
mhorne requested review of D30216: libpmc: fall-back to kernel tables if pmu-events fails.
Tue, May 11, 5:33 PM

Mon, May 10

mhorne added a comment to D30196: libpmc: remove PMC_MDEP_TABLE logic.

So in effect this basically just repeated existing tests that exist elsewhere?

Mon, May 10, 8:30 PM
mhorne requested review of D30196: libpmc: remove PMC_MDEP_TABLE logic.
Mon, May 10, 8:14 PM
mhorne requested review of D30195: libpmc: remove unused PMC_MDEP_INIT_INTEL_V2.
Mon, May 10, 8:14 PM
mhorne updated the summary of D30184: boottrace: a simple boot and shutdown-time tracing facility.
Mon, May 10, 3:55 PM
mhorne updated the summary of D30184: boottrace: a simple boot and shutdown-time tracing facility.
Mon, May 10, 3:19 PM
mhorne requested review of D30187: boottrace: trace annotations for startup and shutdown.
Mon, May 10, 3:14 PM
mhorne requested review of D30186: init_main.c: sort includes.
Mon, May 10, 3:14 PM
mhorne requested review of D30185: kern_linker.c: sort includes.
Mon, May 10, 3:14 PM
mhorne requested review of D30184: boottrace: a simple boot and shutdown-time tracing facility.
Mon, May 10, 3:14 PM

Thu, May 6

mhorne added a comment to D28982: xen: move common variables and code off of sys/x86/xen/hvm.c.

Thing is my goal is to get Xen/ARM working. If removing PVHv1 support made that noticeably easier, I would be for that. Yet here it makes minimal difference to simply leave it alone and removing it would require me to check I hadn't broken anything.

Thu, May 6, 8:46 PM

Wed, May 5

mhorne accepted D30047: hwpmc: Move 4 bits of mode to extend class size to 8..
Wed, May 5, 3:23 PM · pmc
mhorne accepted D30047: hwpmc: Move 4 bits of mode to extend class size to 8..

This looks fine to me, thanks for fixing this.

Wed, May 5, 2:29 PM · pmc

Thu, Apr 29

mhorne committed R10:d87ee7b97fe8: pmcstat: fix the usage message for -t (authored by mhorne).
pmcstat: fix the usage message for -t
Thu, Apr 29, 1:39 PM
mhorne committed R10:e0ae2b39aa3e: pmc_allocate(3): document the count argument (authored by mhorne).
pmc_allocate(3): document the count argument
Thu, Apr 29, 1:39 PM
mhorne committed R10:112e30301846: pmcstat: set initial counter value to zero (authored by mhorne).
pmcstat: set initial counter value to zero
Thu, Apr 29, 1:39 PM
mhorne committed R10:ac099daf6742: arm: add a release conf for distribution files (authored by mhorne).
arm: add a release conf for distribution files
Thu, Apr 29, 1:10 PM
mhorne closed D29923: arm: add a release conf for distribution files.
Thu, Apr 29, 1:10 PM

Tue, Apr 27

mhorne accepted D30011: riscv: Remove old qemu compatibility code.
Tue, Apr 27, 5:44 PM · riscv

Sat, Apr 24

mhorne requested changes to D29404: xen: introduce cpu_to_vcpu_id().

Agreed with @royger, this appears to be an indirect way of achieving the same behaviour.

Sat, Apr 24, 8:15 PM
mhorne accepted D29599: xen/control: print warning on call of xctrl_suspend().
Sat, Apr 24, 8:13 PM
mhorne added inline comments to D29875: xen/arm64: add handling of Xen device-tree.
Sat, Apr 24, 7:43 PM
mhorne accepted D29840: xen/grant_table: cleanup max_nr_grant_frames().

Looks fine to me. I was wondering if __max_nr_grant_frames() would be evaluated twice, but it seems not as min() is a static inline function, unlike the macro MIN().

Sat, Apr 24, 6:15 PM
mhorne added a comment to D29959: xen/devices: purge uses of intr_machdep.h.

So, these files still contain references to definitions provided by intr_machdep.h? Do you know which ones/how many?

Sat, Apr 24, 5:49 PM

Thu, Apr 22

mhorne requested review of D29923: arm: add a release conf for distribution files.
Thu, Apr 22, 1:39 PM

Wed, Apr 21

mhorne committed R10:c4473add1d3d: pmcstat: fix the usage message for -t (authored by mhorne).
pmcstat: fix the usage message for -t
Wed, Apr 21, 8:48 PM
mhorne committed R10:edcf9e59c356: pmcstat: set initial counter value to zero (authored by mhorne).
pmcstat: set initial counter value to zero
Wed, Apr 21, 8:35 PM
mhorne committed R10:50f6c1399700: pmc_allocate(3): document the count argument (authored by mhorne).
pmc_allocate(3): document the count argument
Wed, Apr 21, 8:35 PM
mhorne closed D29887: pmcstat: set initial counter value to zero.
Wed, Apr 21, 8:35 PM
mhorne closed D29885: pmc_allocate(3): document the count argument.
Wed, Apr 21, 8:35 PM
mhorne added inline comments to D29895: Reduce code duplication in machine/_types.h.
Wed, Apr 21, 6:18 PM
mhorne accepted D29764: riscv: Assert that SUM is not set in SSTATUS for exceptions..
Wed, Apr 21, 4:47 PM
mhorne requested review of D29887: pmcstat: set initial counter value to zero.
Wed, Apr 21, 4:43 PM
mhorne requested review of D29885: pmc_allocate(3): document the count argument.
Wed, Apr 21, 4:43 PM
mhorne accepted D29763: riscv: Clear SUM in SSTATUS for supervisor mode exceptions..

Looks good. Just curious, does the issue manifest in practice or was it caught by inspection?

Wed, Apr 21, 4:12 PM
mhorne committed R10:e21ed730a558: gdb: report specific stop reason for watchpoints (authored by mhorne).
gdb: report specific stop reason for watchpoints
Wed, Apr 21, 2:33 PM
mhorne committed R10:123578f890ee: gdb: allow setting/removing hardware watchpoints (authored by mhorne).
gdb: allow setting/removing hardware watchpoints
Wed, Apr 21, 2:32 PM
mhorne committed R10:ea2f252e9768: ddb: replace watchpoint set/clear functions (authored by mhorne).
ddb: replace watchpoint set/clear functions
Wed, Apr 21, 2:32 PM
mhorne committed R10:2d0ad402a075: arm: implement kdb watchpoint functions (authored by mhorne).
arm: implement kdb watchpoint functions
Wed, Apr 21, 2:32 PM
mhorne committed R10:08ce99c3f1b8: arm64: implement kdb watchpoint functions (authored by mhorne).
arm64: implement kdb watchpoint functions
Wed, Apr 21, 2:32 PM
mhorne committed R10:20e6d79f433b: x86: implement kdb watchpoint functions (authored by mhorne).
x86: implement kdb watchpoint functions
Wed, Apr 21, 2:32 PM
mhorne committed R10:45af63e5f893: Introduce kdb-level watchpoint functions (authored by mhorne).
Introduce kdb-level watchpoint functions
Wed, Apr 21, 2:32 PM
mhorne committed R10:47301dfb9abd: x86: consolidate hw watchpoint logic into new file (authored by mhorne).
x86: consolidate hw watchpoint logic into new file
Wed, Apr 21, 2:31 PM

Fri, Apr 16

mhorne committed R10:67bf33e04652: rmlock(9): add an RM_DUPOK flag (authored by mhorne).
rmlock(9): add an RM_DUPOK flag
Fri, Apr 16, 2:23 PM
mhorne committed R10:dbc54475c142: arm64: adjust comments in dbg_monitor_exit() (authored by mhorne).
arm64: adjust comments in dbg_monitor_exit()
Fri, Apr 16, 1:55 PM
mhorne committed R10:c0422e6c365e: arm64: clear debug registers after execve(2) (authored by mhorne).
arm64: clear debug registers after execve(2)
Fri, Apr 16, 1:54 PM
mhorne committed R10:6fa1d613a825: rmlock(9): add an RM_DUPOK flag (authored by mhorne).
rmlock(9): add an RM_DUPOK flag
Fri, Apr 16, 1:54 PM
mhorne committed R10:17b0a38d96fe: arm64: clear debug register state on fork (authored by mhorne).
arm64: clear debug register state on fork
Fri, Apr 16, 1:54 PM

Apr 14 2021

mhorne accepted D29762: ossl(4): Install the man page also for arm64.
Apr 14 2021, 4:16 PM
mhorne added a comment to D29762: ossl(4): Install the man page also for arm64.
In D29762#667531, @gbe wrote:

Thanks for catching this. I believe we generally prefer one block checking the supported MACHINE_CPUARCH values, like the _cgem.4 example below. Both styles are imperfect however.

I would have reused this block, but ossl(4) doesn't support arm or riscv. If this doesn't matter, I could adapt the differential.

Apr 14 2021, 3:51 PM
mhorne added a comment to D29762: ossl(4): Install the man page also for arm64.

Thanks for catching this. I believe we generally prefer one block checking the supported MACHINE_CPUARCH values, like the _cgem.4 example below. Both styles are imperfect however.

Apr 14 2021, 3:42 PM

Apr 13 2021

mhorne committed R10:5742f2d89c03: arm64: adjust comments in dbg_monitor_exit() (authored by mhorne).
arm64: adjust comments in dbg_monitor_exit()
Apr 13 2021, 5:47 PM
mhorne committed R10:a2a8b582bdc1: arm64: clear debug registers after execve(2) (authored by mhorne).
arm64: clear debug registers after execve(2)
Apr 13 2021, 5:47 PM
mhorne closed D29672: arm64: clear debug registers in exec_setregs().
Apr 13 2021, 5:47 PM
mhorne added a comment to D29672: arm64: clear debug registers in exec_setregs().
In D29672#667075, @kib wrote:

The debug registers are not directly accessible at EL0, and set_dbregs32() is a stub. Perhaps it is more precise to say that setting them is not supported, than disallowed.

But can 64bit debugger modify dbregs for 32bit target?

Apr 13 2021, 2:16 PM
mhorne closed D29683: rmlock(9): add an RM_DUPOK flag.
Apr 13 2021, 1:22 PM
mhorne added a comment to D29672: arm64: clear debug registers in exec_setregs().
In D29672#666998, @kib wrote:
In D29672#666686, @kib wrote:

Should you do the same in freebsd32_setregs(), then?

It is not required since we do not allow setting user dbregs for 32-bit processes.

I am curious how this is arranged. Could you please point me?

Apr 13 2021, 1:21 PM

Apr 12 2021

mhorne updated the diff for D29672: arm64: clear debug registers in exec_setregs().

Also clear in freebsd32_setregs(). Add a local pcb pointer instead of using td->pcb repeatedly.

Apr 12 2021, 8:42 PM
mhorne added a comment to D29672: arm64: clear debug registers in exec_setregs().
In D29672#666686, @kib wrote:

Should you do the same in freebsd32_setregs(), then?

Apr 12 2021, 5:50 PM
mhorne closed D29654: relnotes: add some kernel/driver additions.
Apr 12 2021, 3:15 PM
mhorne committed R9:d3aea8d97308: relnotes: add some kernel/driver additions (authored by mhorne).
relnotes: add some kernel/driver additions
Apr 12 2021, 3:15 PM
mhorne closed D29653: relnotes: note some more kernel/driver removals.
Apr 12 2021, 3:15 PM
mhorne committed R9:67e5e554ec0b: relnotes: note some more kernel/driver removals (authored by mhorne).
relnotes: note some more kernel/driver removals
Apr 12 2021, 3:15 PM
mhorne closed D29652: relnotes: note some more userland removals.
Apr 12 2021, 3:15 PM
mhorne closed D29650: relnotes: add a section with some arm64 changes.
Apr 12 2021, 3:15 PM
mhorne committed R9:279491de4595: relnotes: note some more userland removals (authored by mhorne).
relnotes: note some more userland removals
Apr 12 2021, 3:15 PM
mhorne committed R9:2c286f74405c: relnotes: add some more arm64 changes (authored by mhorne).
relnotes: add some more arm64 changes
Apr 12 2021, 3:15 PM
mhorne updated the diff for D29672: arm64: clear debug registers in exec_setregs().

Also handle linux_exec_setregs().

Apr 12 2021, 3:04 PM
mhorne committed R10:2816bd8442bc: rmlock(9): add an RM_DUPOK flag (authored by mhorne).
rmlock(9): add an RM_DUPOK flag
Apr 12 2021, 2:43 PM

Apr 9 2021

mhorne requested review of D29683: rmlock(9): add an RM_DUPOK flag.
Apr 9 2021, 6:38 PM
mhorne requested review of D29672: arm64: clear debug registers in exec_setregs().
Apr 9 2021, 2:18 PM

Apr 8 2021

mhorne added inline comments to D29652: relnotes: note some more userland removals.
Apr 8 2021, 9:28 PM
mhorne updated the diff for D29652: relnotes: note some more userland removals.

Address review comments.

Apr 8 2021, 9:26 PM
mhorne updated the diff for D29653: relnotes: note some more kernel/driver removals.

Handle jhb's comments.

Apr 8 2021, 8:11 PM
mhorne added inline comments to D29653: relnotes: note some more kernel/driver removals.
Apr 8 2021, 8:09 PM
mhorne added inline comments to D29648: relnotes: fix-up some section oddities.
Apr 8 2021, 7:58 PM
mhorne added a comment to D29651: relnotes: add a section with some RISC-V changes.
In D29651#664923, @jhb wrote:

Note that the notes only document changes from the most recent release (in this case 12.2) to 13.0, not 12.0 to 13.0, so some of these aren't relevant. I wonder if the OpenSBI support made it into 12.2? If not, it warrants a mention I think. Hmm, 12.2 did include support for booting via OpenSBI v0.7.

Apr 8 2021, 7:37 PM
mhorne added inline comments to D29648: relnotes: fix-up some section oddities.
Apr 8 2021, 7:24 PM
mhorne closed D29649: relnotes: note the updated LLVM version.
Apr 8 2021, 6:58 PM
mhorne committed R9:ffe526a580db: relnotes: note the updated LLVM version (authored by mhorne).
relnotes: note the updated LLVM version
Apr 8 2021, 6:58 PM