- User Since
- Mar 22 2019, 4:46 AM (95 w, 2 d)
Fri, Jan 15
Note that partedit_riscv.c is practically identical to partedit_arm64.c. We could merge the two, I'm just not sure what it ought to be called.
Thu, Jan 14
Hi, there is an open review in D28054, discussing the issues with this function (and included build fix).
Looking at other implementations, I believe oldfp should be updated on each loop iteration.
Wed, Jan 13
A couple of small nitpicks, otherwise LGTM.
Tue, Jan 12
Add asserts to pmap_page_test_mappings() and pmap_page_wired_mappings().
Mon, Jan 11
Thanks for catching this!
Would there be any benefit (or risk) to enabling ossl(4) by default as well?
I see options GDB in the common NOTES already.
Note that I have D28047 uncommitted for cscope files, but am happy to abandon that in favor of this. I also don't see a need for ?cscope.out.
Sun, Jan 10
Sat, Jan 9
Fri, Jan 8
Use the full month.
@khng300_gmail.com am I right in thinking you have one or two outstanding .gitignore reviews?
Makefile update looks good to me! You might want to bump .Dd when you commit.
See also, the analogous commit for riscv: rS367138.
Thu, Jan 7
Hi @skibo , is there any remaining work to be done on this patch? It appears to be ready to go, other than one small nitpick. It would be nice to see it committed before stable/13 branches later this month.
Remove duplicate function prototypes. Small changes to formatting and comments.
Reorder SRCS blocks in ipmi/Makefile. Set _ipmi in arm64/amd64/i386 block (powerpc64 block untouched).
Wed, Jan 6
Tue, Jan 5
Remove the tf_elr manipulation.
Mon, Jan 4
I'm looking at D21017, which adds AES-XTS support to armv8_crypto, and has been sitting in review for some time.
Fix typo, kdb_frame -> kdb_thread. Make it a little clearer that this is the
previous trapframe and not necissarily the user trapframe.
Sat, Jan 2
Wed, Dec 23
Tue, Dec 22
On a second look, I found that gdb_cpu_signal() only returns standard POSIX signals, meaning that at present no mapping is required between FreeBSD and GDB signals. PowerPC is the slight exception to this, which might return a trap vector instead of a signal, and will be addressed.
Don't transmit "ok" for the error case.
I was able to rebase this patch with some very minor tweaks, and verify the results using both cryptocheck and cryptotest.py.
I will be on holiday for the next couple weeks, but posting this now in case anyone wants to look it over during that time. No rush to review.
Mon, Dec 21
Fri, Dec 18
Dec 18 2020
Dec 17 2020
Fix typo, GDB_REG_RIP -> GDB_REG_PC.
Update to use two switch statements. This version fits vertically on a single screen, and more closely matches the formatting of gdb_cpu_setreg().