Page MenuHomeFreeBSD

mhorne (Mitchell Horne)
User

Projects

User Details

User Since
Mar 22 2019, 4:46 AM (273 w, 3 d)

Recent Activity

Fri, Jun 14

mhorne committed rG134f7b5fa91f: riscv: improve commentary around initial stvec (authored by mhorne).
riscv: improve commentary around initial stvec
Fri, Jun 14, 6:03 PM
mhorne committed rG3ff981587ff8: riscv: Don't handle missing kernel L3 pages (authored by mhorne).
riscv: Don't handle missing kernel L3 pages
Fri, Jun 14, 6:03 PM
mhorne committed rG0e4e77072f65: riscv: adjust physmem reservation (authored by mhorne).
riscv: adjust physmem reservation
Fri, Jun 14, 6:03 PM
mhorne closed D45474: riscv: improve commentary around initial stvec.
Fri, Jun 14, 6:02 PM
mhorne closed D45326: riscv: Don't handle missing kernel L3 pages.
Fri, Jun 14, 6:02 PM
mhorne closed D45325: riscv: adjust physmem reservation.
Fri, Jun 14, 6:02 PM
mhorne added inline comments to D45328: riscv: smarter DMAP construction.
Fri, Jun 14, 5:52 PM
mhorne updated the diff for D45328: riscv: smarter DMAP construction.

Drop unneeded warning print.

Fri, Jun 14, 5:51 PM
mhorne added inline comments to D45327: riscv: rework page table bootstrap.
Fri, Jun 14, 5:48 PM
mhorne updated the diff for D45327: riscv: rework page table bootstrap.

Handle comment from markj.

Fri, Jun 14, 5:46 PM
mhorne committed rG97ab935d566c: rk_pinctrl: fix error check (authored by John F. Carr <jfc@mit.edu>).
rk_pinctrl: fix error check
Fri, Jun 14, 4:43 PM

Fri, Jun 7

mhorne accepted D45497: riscv: include AHCI.
Fri, Jun 7, 4:14 PM
mhorne planned changes to D45475: riscv: support PV_STATS pmap option.

There is actually more to be done here...

Fri, Jun 7, 4:14 PM

Thu, Jun 6

mhorne committed rG8490d5ec8e0e: Adjust comments referencing vm_mem_init() (authored by mhorne).
Adjust comments referencing vm_mem_init()
Thu, Jun 6, 3:55 PM
mhorne committed rGf8b05837c606: arm64, riscv: removed unused struct pv_addr (authored by mhorne).
arm64, riscv: removed unused struct pv_addr
Thu, Jun 6, 3:55 PM
mhorne committed rG84e95f36f600: arm64, riscv: remove unused declaration (authored by mhorne).
arm64, riscv: remove unused declaration
Thu, Jun 6, 3:55 PM
mhorne committed rG4fa9eee03abd: ieee80211_vap(9): fix the title (authored by mhorne).
ieee80211_vap(9): fix the title
Thu, Jun 6, 3:55 PM
mhorne added a comment to D43251: Update riscv-isa-sim to 2024-05-31 snapshot.

Just a question, how you test on kernel, I use spike --kernel /path/to/kernel /path/to/sbi. It give me invalid address error even after I add -m0x1000000,0x2000.

Thu, Jun 6, 3:11 PM
mhorne accepted D43251: Update riscv-isa-sim to 2024-05-31 snapshot.

Thanks. I tested booting a FreeBSD kernel. For some reason it doesn't work with the stripped OpenSBI ELF provided by sysutils/opensbi, but that is a separate issue.

Thu, Jun 6, 3:01 PM
mhorne committed rG030596bfe4d3: kern: Remove leftover saf1761otg bits (authored by Joshua Kinard <freebsd@kumba.dev>).
kern: Remove leftover saf1761otg bits
Thu, Jun 6, 2:25 PM
mhorne committed rG227b486de44d: Adjust comments referencing vm_mem_init() (authored by mhorne).
Adjust comments referencing vm_mem_init()
Thu, Jun 6, 2:25 PM

Wed, Jun 5

mhorne accepted D45481: riscv stage2 pmap support.
In D45481#1037849, @br wrote:

The rest of page table system (including PTE format) is identical.

That's not entirely true; the G bit exists but is reserved. Having said that I don't think we currently set it? (Though there is code to inspect and preserve it in places)

right, we will need to support hypervisor memory-management fence instructions (and manage address space/VM IDs etc). I will put this into TODO list.

Wed, Jun 5, 12:50 PM

Tue, Jun 4

mhorne accepted D45481: riscv stage2 pmap support.

No objection if you want to commit this now. I agree it is unimportant to support the full address space, at present.

Tue, Jun 4, 11:26 PM
mhorne committed rG191bf63da255: riscv: Move sigcode out of locore.S (authored by mhorne).
riscv: Move sigcode out of locore.S
Tue, Jun 4, 11:20 PM
mhorne committed rG65a33120c3d5: riscv: fix vm.pmap.kernel_maps with Sv48 (authored by mhorne).
riscv: fix vm.pmap.kernel_maps with Sv48
Tue, Jun 4, 11:20 PM
mhorne closed D45473: riscv: fix vm.pmap.kernel_maps with Sv48.
Tue, Jun 4, 11:20 PM
mhorne committed rG5df74441b35f: devmap: eliminate unused arguments (authored by mhorne).
devmap: eliminate unused arguments
Tue, Jun 4, 11:20 PM
mhorne closed D45320: riscv: Move sigcode out of locore.S.
Tue, Jun 4, 11:20 PM
mhorne committed rG191e6a604938: physmem: zero entire array (authored by mhorne).
physmem: zero entire array
Tue, Jun 4, 11:20 PM
mhorne closed D45319: devmap: eliminate unused arguments.
Tue, Jun 4, 11:20 PM
mhorne closed D45318: physmem: zero entire array.
Tue, Jun 4, 11:20 PM
mhorne committed rGa8a2d5ef126f: build.7: +freebsd to description, link development (authored by concussious.bugzilla_runbox.com).
build.7: +freebsd to description, link development
Tue, Jun 4, 6:28 PM
mhorne committed rG8327796cc873: build.7: nit section order, tag spdx (authored by concussious.bugzilla_runbox.com).
build.7: nit section order, tag spdx
Tue, Jun 4, 6:28 PM
mhorne committed rGafa166be99fc: build.7: update cross-compile example (authored by mhorne).
build.7: update cross-compile example
Tue, Jun 4, 6:28 PM
mhorne committed rG41d6858ebd6a: git-arc.1: list width typo (authored by concussious.bugzilla_runbox.com).
git-arc.1: list width typo
Tue, Jun 4, 5:49 PM
mhorne retitled D45319: devmap: eliminate unused arguments from devmap: eliminate useless argument to devmap: eliminate unused arguments.
Tue, Jun 4, 5:27 PM
mhorne updated the diff for D45319: devmap: eliminate unused arguments.

Remove the table argument too; this is a legacy interface that is now unused.

Tue, Jun 4, 5:17 PM
mhorne updated the diff for D45318: physmem: zero entire array.

Remove now-redundant calls to bzero().

Tue, Jun 4, 5:14 PM
mhorne closed D45482: 14.1 relnotes: fix networking(7) link.
Tue, Jun 4, 4:43 PM · docs
mhorne committed R9:788109b4b721: 14.1 relnotes: fix networking(7) link (authored by concussious.bugzilla_runbox.com).
14.1 relnotes: fix networking(7) link
Tue, Jun 4, 4:43 PM
mhorne added a member for docs: mhorne.
Tue, Jun 4, 3:09 PM
mhorne accepted D45482: 14.1 relnotes: fix networking(7) link.
Tue, Jun 4, 3:09 PM · docs

Mon, Jun 3

mhorne added inline comments to D45471: [DRAFT/RFC] riscv: Svpbmt extension support.
Mon, Jun 3, 7:04 PM
mhorne updated the diff for D45475: riscv: support PV_STATS pmap option.

Include opt_pmap.h, and drop sys/cdefs.h include while here.

Mon, Jun 3, 6:59 PM
mhorne added a reviewer for D45472: [DRAFT/RFC] riscv: T-HEAD PBMT support: jhb.
Mon, Jun 3, 6:52 PM
mhorne added a reviewer for D45471: [DRAFT/RFC] riscv: Svpbmt extension support: jhb.
Mon, Jun 3, 6:52 PM
mhorne requested review of D45475: riscv: support PV_STATS pmap option.
Mon, Jun 3, 6:52 PM
mhorne requested review of D45473: riscv: fix vm.pmap.kernel_maps with Sv48.
Mon, Jun 3, 6:52 PM
mhorne requested review of D45474: riscv: improve commentary around initial stvec.
Mon, Jun 3, 6:51 PM
mhorne requested review of D45472: [DRAFT/RFC] riscv: T-HEAD PBMT support.
Mon, Jun 3, 6:51 PM
mhorne requested review of D45471: [DRAFT/RFC] riscv: Svpbmt extension support.
Mon, Jun 3, 6:51 PM
mhorne requested review of D45470: riscv: drop l1pt argument from pmap_bootstrap().
Mon, Jun 3, 6:50 PM
mhorne updated the diff for D45328: riscv: smarter DMAP construction.

Handle feedback from markj.

Mon, Jun 3, 6:44 PM
mhorne retitled D45324: riscv: Construct an identity map in locore.S from Construct an identity map in locore.S to riscv: Construct an identity map in locore.S.
Mon, Jun 3, 6:41 PM
mhorne updated the diff for D45327: riscv: rework page table bootstrap.

Handle feedback from markj.

Mon, Jun 3, 6:39 PM
mhorne updated the diff for D45324: riscv: Construct an identity map in locore.S.

Add assembly commentary here, not in the later patch.

Mon, Jun 3, 6:39 PM
mhorne committed rG80828c6fab02: kern: Remove leftover saf1761otg bits (authored by Joshua Kinard <freebsd@kumba.dev>).
kern: Remove leftover saf1761otg bits
Mon, Jun 3, 3:53 PM

Wed, May 29

mhorne closed D45383: Adjust comments referencing vm_mem_init().
Wed, May 29, 5:36 PM

Mon, May 27

mhorne committed rGdeab57178f0b: Adjust comments referencing vm_mem_init() (authored by mhorne).
Adjust comments referencing vm_mem_init()
Mon, May 27, 9:39 PM
mhorne added inline comments to D45383: Adjust comments referencing vm_mem_init().
Mon, May 27, 4:19 PM
mhorne requested review of D45383: Adjust comments referencing vm_mem_init().
Mon, May 27, 4:18 PM
mhorne added inline comments to D45327: riscv: rework page table bootstrap.
Mon, May 27, 4:13 PM
mhorne added inline comments to D45328: riscv: smarter DMAP construction.
Mon, May 27, 3:17 PM
mhorne updated the test plan for D45328: riscv: smarter DMAP construction.
Mon, May 27, 3:15 PM
mhorne added inline comments to D45324: riscv: Construct an identity map in locore.S.
Mon, May 27, 2:50 PM
mhorne committed rG1b1c7e088c58: arm64, riscv: removed unused struct pv_addr (authored by mhorne).
arm64, riscv: removed unused struct pv_addr
Mon, May 27, 2:45 PM
mhorne committed rGbdfd8f68faaa: arm64, riscv: remove unused declaration (authored by mhorne).
arm64, riscv: remove unused declaration
Mon, May 27, 2:45 PM
mhorne committed rGed10a9398d05: riscv: fix L0 PTE setup (Sv48) (authored by mhorne).
riscv: fix L0 PTE setup (Sv48)
Mon, May 27, 2:45 PM

Fri, May 24

mhorne committed rGb5e17840de65: arm64, riscv: removed unused struct pv_addr (authored by mhorne).
arm64, riscv: removed unused struct pv_addr
Fri, May 24, 1:56 PM
mhorne committed rG1d3c23676de3: arm64, riscv: remove unused declaration (authored by mhorne).
arm64, riscv: remove unused declaration
Fri, May 24, 1:56 PM
mhorne closed D45323: arm64, riscv: remove unused declaration.
Fri, May 24, 1:56 PM
mhorne closed D45322: arm64, riscv: removed unused struct pv_addr.
Fri, May 24, 1:56 PM
mhorne abandoned D45321: pmap_is_valid_memattr: drop unused 'pmap' argument.
In D45321#1034234, @kib wrote:

Logically, it doesn't make sense that this result would differ per-pmap.

...

While there's currently no difference between pmap types in the handling of memattrs, it's not obvious to me that that'll always be true. In other words, I don't really agree with the premise of the patch. Maybe I'm missing some reason that my concern is invalid.

There is already a PAT mode (UC-) which cannot be represented in EPT. Although the mode is a hack to fix broken sofware (I believe), it is still a demonstration of the issue.

Fri, May 24, 1:33 PM

Thu, May 23

mhorne requested review of D45328: riscv: smarter DMAP construction.
Thu, May 23, 7:53 PM
mhorne requested review of D45327: riscv: rework page table bootstrap.
Thu, May 23, 7:53 PM
mhorne requested review of D45326: riscv: Don't handle missing kernel L3 pages.
Thu, May 23, 7:53 PM
mhorne requested review of D45325: riscv: adjust physmem reservation.
Thu, May 23, 7:53 PM
mhorne requested review of D45324: riscv: Construct an identity map in locore.S.
Thu, May 23, 7:52 PM
mhorne added a reviewer for D45321: pmap_is_valid_memattr: drop unused 'pmap' argument: kib.
Thu, May 23, 7:25 PM
mhorne requested review of D45323: arm64, riscv: remove unused declaration.
Thu, May 23, 7:17 PM
mhorne requested review of D45322: arm64, riscv: removed unused struct pv_addr.
Thu, May 23, 7:16 PM
mhorne requested review of D45321: pmap_is_valid_memattr: drop unused 'pmap' argument.
Thu, May 23, 7:16 PM
mhorne requested review of D45320: riscv: Move sigcode out of locore.S.
Thu, May 23, 7:15 PM
mhorne requested review of D45319: devmap: eliminate unused arguments.
Thu, May 23, 7:15 PM
mhorne requested review of D45318: physmem: zero entire array.
Thu, May 23, 7:14 PM

Wed, May 22

mhorne accepted D45228: Implement atomic_load_acq_16.
Wed, May 22, 1:53 PM
mhorne accepted D45226: Fix SSTC extension support.
Wed, May 22, 1:48 PM

May 17 2024

mhorne added inline comments to D45228: Implement atomic_load_acq_16.
May 17 2024, 2:25 PM
mhorne accepted D45226: Fix SSTC extension support.
May 17 2024, 2:19 PM

May 16 2024

mhorne committed rG8930e7d8ea4d: save-entropy: Add manual page (authored by fernape).
save-entropy: Add manual page
May 16 2024, 5:26 PM
mhorne added inline comments to D45213: vm: pair up conversion macros.
May 16 2024, 1:51 PM
mhorne accepted D45170: libkern: add ilog2 helpers.

LGTM

May 16 2024, 1:46 PM

May 15 2024

mhorne committed rGd7adf3b47a05: riscv: fix L0 PTE setup (Sv48) (authored by mhorne).
riscv: fix L0 PTE setup (Sv48)
May 15 2024, 5:10 PM
mhorne closed D45210: riscv: fix L0 PTE setup (Sv48).
May 15 2024, 5:10 PM
mhorne requested review of D45210: riscv: fix L0 PTE setup (Sv48).
May 15 2024, 3:49 PM
mhorne added inline comments to D45170: libkern: add ilog2 helpers.
May 15 2024, 3:26 PM

May 14 2024

mhorne accepted D45159: uart: Honour clock-frequency in FDT for UART_FDT_CLASS if present.

Thank you for finding the proper fix! Working fine on my end.

May 14 2024, 2:53 PM

May 9 2024

mhorne accepted D45085: vm: simplify conditional for dumping startup pages.
May 9 2024, 5:07 PM

May 7 2024

mhorne committed rG0612538e3ac9: jh7110: Add StarFive JH7110 clock/reset generator drivers (authored by jsihv_gmx.com).
jh7110: Add StarFive JH7110 clock/reset generator drivers
May 7 2024, 4:09 PM
mhorne added a reverting change for rG5d6d6278979b: jh7110: Add StarFive JH7110 clock/reset generator drivers: rG6ea05fce8e2e: Revert "jh7110: Add StarFive JH7110 clock/reset generator drivers".
May 7 2024, 4:08 PM