User Details
- User Since
- Mar 22 2019, 4:46 AM (399 w, 3 d)
Today
I'm sorry, I don't understand the problem being addressed. It seems like "once per-CPU". Does some kind of mismatch occur between start/stop invocations?
How does this relate to your recent addition of pmc_unload()? In particular, should that function attempt to drain samples, or would it not help anything?
Following the location of the KASSERT, there is a noted TODO:
Fri, Nov 13
Thanks, my apologies it took so long to address. I merged the fix from the other review!
I am totally unfamiliar with this API until today. It seems like a big hammer, but maybe this is unavoidable for this destructive operation.
Thu, Nov 12
I agree with the premise of the fix, but the implementation does not seem right.
LGTM!
Tue, Nov 10
Marking the status: outstanding feedback.
For future reference: the request about preferred license format applies to all new files, not only the particular header I commented on. Here I will fix them up to move forward with merge, but please be mindful of this!
LGTM, I will try to merge today.
I think I'm getting a sense for how this will work.
Mon, Nov 9
Sun, Nov 8
I don't trust this fully.
This new array allocation is not necessary.
Please see my previous comment.
Fri, Nov 6
Nice stuff! Two comments, neither blocking at all.
Very nice.
What is the consequence here, can the unload race cause a panic or memory leak? Or is it purely functional (lost samples)?
Thu, Nov 5
LGTM. Please allow @afscoelho_gmail.com to confirm.
Wed, Nov 4
A couple cosmetic notes only.