Page MenuHomeFreeBSD

mhorne (Mitchell Horne)
User

Projects

User Details

User Since
Mar 22 2019, 4:46 AM (383 w, 5 d)

Recent Activity

Yesterday

mhorne committed rG3fdd05c61216: libpmc: userland support and pmc.rapl.3 for the RAPL class (authored by afscoelho_gmail.com).
libpmc: userland support and pmc.rapl.3 for the RAPL class
Tue, Jul 28, 3:03 PM
mhorne added a comment to D58027: x86: add AMD RAPL MSR definitions to specialreg.h.

Ok! I would like to confirm something with you before committing:

  1. Author info: Andre Silva <andasilv@amd.com>
  2. Sponsored by: Advanced Micro Devices (AMD)

Are the both desired information you expected?

Yes, they are. Thanks!

Tue, Jul 28, 3:03 PM
mhorne committed rGa99d04f39dab: hwpmc: add RAPL energy-counter class (AMD + Intel) (authored by afscoelho_gmail.com).
hwpmc: add RAPL energy-counter class (AMD + Intel)
Tue, Jul 28, 3:03 PM
mhorne closed D58029: libpmc: userland support and pmc.rapl.3 for the RAPL class.
Tue, Jul 28, 3:02 PM
mhorne committed rG53187a3665e5: pmc_dmc620: drop unneeded includes (authored by mhorne).
pmc_dmc620: drop unneeded includes
Tue, Jul 28, 3:02 PM
mhorne closed D58028: hwpmc: add RAPL energy-counter class (AMD + Intel).
Tue, Jul 28, 3:02 PM
mhorne committed rG77404ee1e99d: x86: add AMD RAPL MSR definitions to specialreg.h (authored by afscoelho_gmail.com).
x86: add AMD RAPL MSR definitions to specialreg.h
Tue, Jul 28, 3:02 PM
mhorne closed D58027: x86: add AMD RAPL MSR definitions to specialreg.h.
Tue, Jul 28, 3:02 PM
mhorne committed rGcac0eab342c7: sys/modules/hwpmc/Makefile: tidy up (authored by mhorne).
sys/modules/hwpmc/Makefile: tidy up
Tue, Jul 28, 3:02 PM
mhorne committed rGd6dcd8d2c3ef: libsysdecode: fix nlm_flag regex in mktables (authored by mhorne).
libsysdecode: fix nlm_flag regex in mktables
Tue, Jul 28, 2:31 PM

Mon, Jul 27

mhorne accepted D58468: hwpmc: fix event allocation on pre-Zen AMD CPUs.

Thanks. I was considering removing all this code, but it was premature. I am happy to keep it if it is useful.

Mon, Jul 27, 2:40 PM
mhorne added reviewers for D58468: hwpmc: fix event allocation on pre-Zen AMD CPUs: pmc, adrian.
Mon, Jul 27, 2:39 PM

Tue, Jul 21

mhorne committed rG8c4d5701924f: hwpmc: Add EXTERROR diagnostics to the AMD and IBS allocators (authored by afscoelho_gmail.com).
hwpmc: Add EXTERROR diagnostics to the AMD and IBS allocators
Tue, Jul 21, 5:17 PM
mhorne committed rGc185935b0d52: hwpmc: Add EXTERROR diagnostics to the hwpmc syscall path (authored by afscoelho_gmail.com).
hwpmc: Add EXTERROR diagnostics to the hwpmc syscall path
Tue, Jul 21, 5:17 PM

Mon, Jul 20

mhorne committed rG5b7d6a128bef: vfs_unmountall.9: Fix an outdated .Xr to boot(9) (authored by temcbun_gmail.com).
vfs_unmountall.9: Fix an outdated .Xr to boot(9)
Mon, Jul 20, 5:33 PM
mhorne closed D58350: vfs_unmountall.9: Fix an outdated .Xr to boot(9).
Mon, Jul 20, 5:33 PM · Contributor Reviews (src), manpages, docs
mhorne accepted D58350: vfs_unmountall.9: Fix an outdated .Xr to boot(9).
Mon, Jul 20, 5:29 PM · Contributor Reviews (src), manpages, docs

Fri, Jul 17

mhorne accepted D58027: x86: add AMD RAPL MSR definitions to specialreg.h.
Fri, Jul 17, 5:19 PM

Thu, Jul 16

mhorne added a comment to D58256: hwpmc/amd: add PerfMonV2 global-control path.

Seems sensible as a starting point.

Thu, Jul 16, 6:39 PM
mhorne accepted D58029: libpmc: userland support and pmc.rapl.3 for the RAPL class.
Thu, Jul 16, 6:21 PM
mhorne accepted D58028: hwpmc: add RAPL energy-counter class (AMD + Intel).
Thu, Jul 16, 6:18 PM
mhorne abandoned D58227: rk_gpio: improve EOI handling.

Per the replies in https://github.com/freebsd/freebsd-src/pull/2245, this ends up having no functional impact. Closing.

Thu, Jul 16, 2:57 PM

Tue, Jul 14

mhorne added a comment to D58227: rk_gpio: improve EOI handling.

So, this applies the EOI handling scheme preferred by many drivers, and endorsed by mmel@.

Tue, Jul 14, 4:11 PM
mhorne requested review of D58227: rk_gpio: improve EOI handling.
Tue, Jul 14, 3:41 PM
mhorne added a reverting change for rG8ffb400bfd64: rk_gpio: defer level-IRQ EOI until source line is driven low: rG1aeb9d782ea1: Revert "rk_gpio: defer level-IRQ EOI until source line is driven low".
Tue, Jul 14, 3:07 PM
mhorne committed rG1aeb9d782ea1: Revert "rk_gpio: defer level-IRQ EOI until source line is driven low" (authored by mhorne).
Revert "rk_gpio: defer level-IRQ EOI until source line is driven low"
Tue, Jul 14, 3:06 PM

Mon, Jul 13

mhorne committed rG1b5ec2e466ee: subr_physmem_test: add tests for two edge-cases (authored by mhorne).
subr_physmem_test: add tests for two edge-cases
Mon, Jul 13, 7:54 PM
mhorne closed D45914: subr_physmem_test: add tests for two edge-cases.
Mon, Jul 13, 7:54 PM
mhorne added a comment to D45914: subr_physmem_test: add tests for two edge-cases.

Rather late, but the patch seems fine to me.

Mon, Jul 13, 7:51 PM
mhorne committed rG185039d27252: g_eli: disambiguate CPU-bound worker creation (authored by mhorne).
g_eli: disambiguate CPU-bound worker creation
Mon, Jul 13, 7:41 PM
mhorne committed rG01f165c68103: sched/lapic: remove sched_do_timer_accounting() (authored by mhorne).
sched/lapic: remove sched_do_timer_accounting()
Mon, Jul 13, 7:41 PM
mhorne committed rGdf0aca0d7306: smp: remove unused hlt_cpus_mask (authored by mhorne).
smp: remove unused hlt_cpus_mask
Mon, Jul 13, 7:41 PM
mhorne committed rG63d4f044225d: g_eli: better handling of absent/disabled CPUs (authored by mhorne).
g_eli: better handling of absent/disabled CPUs
Mon, Jul 13, 7:41 PM
mhorne closed D58214: g_eli: disambiguate CPU-bound worker creation.
Mon, Jul 13, 7:41 PM
mhorne closed D58159: sched/lapic: remove sched_do_timer_accounting().
Mon, Jul 13, 7:41 PM
mhorne closed D58158: smp: remove unused hlt_cpus_mask.
Mon, Jul 13, 7:41 PM
mhorne closed D58157: g_eli: better handling of absent/disabled CPUs.
Mon, Jul 13, 7:41 PM
mhorne committed rG8ffb400bfd64: rk_gpio: defer level-IRQ EOI until source line is driven low (authored by b1nc0d3x_gmail.com).
rk_gpio: defer level-IRQ EOI until source line is driven low
Mon, Jul 13, 7:14 PM
mhorne updated the diff for D58214: g_eli: disambiguate CPU-bound worker creation.

Obtain mutex around sc_workers list.

Mon, Jul 13, 6:55 PM
mhorne added inline comments to D58214: g_eli: disambiguate CPU-bound worker creation.
Mon, Jul 13, 4:57 PM
mhorne requested review of D58214: g_eli: disambiguate CPU-bound worker creation.
Mon, Jul 13, 2:41 PM
mhorne added inline comments to D58157: g_eli: better handling of absent/disabled CPUs.
Mon, Jul 13, 1:36 PM

Sun, Jul 12

mhorne added inline comments to D58158: smp: remove unused hlt_cpus_mask.
Sun, Jul 12, 7:43 PM
mhorne added inline comments to D58157: g_eli: better handling of absent/disabled CPUs.
Sun, Jul 12, 7:26 PM

Fri, Jul 10

mhorne requested review of D58159: sched/lapic: remove sched_do_timer_accounting().
Fri, Jul 10, 5:32 PM
mhorne requested review of D58158: smp: remove unused hlt_cpus_mask.
Fri, Jul 10, 5:31 PM
mhorne requested review of D58157: g_eli: better handling of absent/disabled CPUs.
Fri, Jul 10, 5:31 PM
mhorne accepted D58029: libpmc: userland support and pmc.rapl.3 for the RAPL class.
Fri, Jul 10, 4:48 PM
mhorne committed rGfb6c19bcba0c: kern/sched_shims.c: back to ifunc (authored by kib).
kern/sched_shims.c: back to ifunc
Fri, Jul 10, 3:45 PM
mhorne committed rG4fde25a4b239: build: Stop testing LINKER_FEATURES for ifunc and build-id (authored by emaste).
build: Stop testing LINKER_FEATURES for ifunc and build-id
Fri, Jul 10, 3:44 PM
mhorne committed rG17d7b3d6af94: arm: Implement kernel ifunc (authored by mmel).
arm: Implement kernel ifunc
Fri, Jul 10, 3:44 PM
mhorne committed rG825c14016f8c: DEFINE_IFUNC.9: update NOTES (authored by mhorne).
DEFINE_IFUNC.9: update NOTES
Fri, Jul 10, 3:44 PM
mhorne committed rG7be4e2826bf8: sched_shim: Drop the no-ifunc case (authored by mhorne).
sched_shim: Drop the no-ifunc case
Fri, Jul 10, 3:44 PM
mhorne committed rG08b56f2b173f: riscv: implement kernel ifunc resolution (authored by mhorne).
riscv: implement kernel ifunc resolution
Fri, Jul 10, 3:44 PM
mhorne committed rGf014c3f0d7ed: rk_gpio: implement PIC masking methods and mask unhandled IRQs (authored by b1nc0d3x_gmail.com).
rk_gpio: implement PIC masking methods and mask unhandled IRQs
Fri, Jul 10, 3:29 PM
mhorne committed rGc794fe2a9462: crashinfo: Create core.txt.last symlink (authored by rbranco_suse.com).
crashinfo: Create core.txt.last symlink
Fri, Jul 10, 3:29 PM
mhorne committed rGa854d977c39a: hwpmc_amd: Avoid using PMCs if in use by firmware (authored by ali_mashtizadeh.com).
hwpmc_amd: Avoid using PMCs if in use by firmware
Fri, Jul 10, 3:29 PM
mhorne committed rG620bca5338ab: hwpmc: Disable AMD PMCs if in an unsupported VM (authored by ali_mashtizadeh.com).
hwpmc: Disable AMD PMCs if in an unsupported VM
Fri, Jul 10, 3:29 PM
mhorne committed rG067755c74a3d: hwpmc_amd: fix amd_get_msr() MSR offset for newer counter bases (authored by paulo_nlink.com.br).
hwpmc_amd: fix amd_get_msr() MSR offset for newer counter bases
Fri, Jul 10, 3:29 PM
mhorne committed rGd74dae909b26: hwpmc_amd: Add support for additional counters. (authored by ali_mashtizadeh.com).
hwpmc_amd: Add support for additional counters.
Fri, Jul 10, 3:29 PM
mhorne committed rG57b8e38a231d: hwpmc: Fix PMC flags for AMD Zen cores (authored by Ali Mashtizadeh <mashti@uwaterloo.ca>).
hwpmc: Fix PMC flags for AMD Zen cores
Fri, Jul 10, 3:28 PM
mhorne added a comment to D58028: hwpmc: add RAPL energy-counter class (AMD + Intel).

LGTM. Ali, I will follow your lead that this is the most useful way to expose these counters.

Fri, Jul 10, 2:56 PM
mhorne accepted D58104: FDT: implement fdt_ether_get_addr().

LGTM. There was a recent addition to if_eqos_starfive to handle "local-mac-address", but it will be better to use this. Thanks.

Fri, Jul 10, 2:33 PM

Thu, Jul 9

mhorne committed R11:9f022e1fca5f: sysutils/opensbi: update to v1.9 (authored by mhorne).
sysutils/opensbi: update to v1.9
Thu, Jul 9, 5:55 PM
mhorne committed rG712623ab14b9: generic_ehci_fdt: fix driver softc size (authored by mhorne).
generic_ehci_fdt: fix driver softc size
Thu, Jul 9, 5:50 PM
mhorne committed rG745c0ea79057: stand/libofw: make OF_hasprop() part of the library (authored by mhorne).
stand/libofw: make OF_hasprop() part of the library
Thu, Jul 9, 5:50 PM
mhorne committed rGb17f8fdcc51b: raspberry_virtgpio: fix OF_hasprop() usage (authored by mhorne).
raspberry_virtgpio: fix OF_hasprop() usage
Thu, Jul 9, 5:50 PM
mhorne committed rG7411d0167174: OF_getprop.9: update OF_hasprop() signature (authored by mhorne).
OF_getprop.9: update OF_hasprop() signature
Thu, Jul 9, 5:50 PM
mhorne committed rG2e56e447ca70: clk_fixed: quiet a warning message (authored by mhorne).
clk_fixed: quiet a warning message
Thu, Jul 9, 5:50 PM
mhorne committed rG64f6ab4a39f9: ofw: bool-ify OF_hasprop() (authored by mhorne).
ofw: bool-ify OF_hasprop()
Thu, Jul 9, 5:50 PM
mhorne accepted D57624: riscv/pmap.c: Add an Svinval-aware variant of pmap_invalidate_range.
Thu, Jul 9, 5:21 PM

Tue, Jun 30

mhorne added a reviewer for D57637: pmcstat(8): add -b batch-grouping flag: pmc.
Tue, Jun 30, 3:21 PM
mhorne added a reviewer for D57636: libpmcstat: parse {a,b,c} brace-list event group syntax: pmc.
Tue, Jun 30, 3:21 PM
mhorne added a reviewer for D57635: libpmc: group allocation/commit API and scaled read: pmc.
Tue, Jun 30, 3:20 PM
mhorne added a reviewer for D57634: hwpmc: build hwpmc_pmu.c and hwpmc_assign.c: pmc.
Tue, Jun 30, 3:20 PM
mhorne added a reviewer for D57633: hwpmc: PMC group syscalls, attach hook, and process-exit drain: pmc.
Tue, Jun 30, 3:20 PM
mhorne added a reviewer for D57632: hwpmc: add PMU assigner and AMD Zen constraint provider: pmc.
Tue, Jun 30, 3:19 PM
mhorne added a reviewer for D57631: hwpmc: add PMU event/group structures and rotation runtime: pmc.
Tue, Jun 30, 3:18 PM
mhorne added a reviewer for D57630: sys: hwpmc PMU group/multiplex ABI additions: pmc.
Tue, Jun 30, 3:17 PM
mhorne added a reviewer for D57779: pmc: pmc frontend stall analysis based on IBS: pmc.
Tue, Jun 30, 3:16 PM
mhorne added a reviewer for D57778: pmc: pmc info command: pmc.
Tue, Jun 30, 3:16 PM
mhorne added a reviewer for D57777: pmc: pmc record command: pmc.
Tue, Jun 30, 3:15 PM
mhorne added a reviewer for D57776: pmc: new pmc log processing framework: pmc.
Tue, Jun 30, 3:15 PM
mhorne added a reviewer for D57775: pmc: console configuration and table rendering for new PMC tools: pmc.
Tue, Jun 30, 3:15 PM
mhorne updated subscribers of D57780: pmc: enable the new pmc commands.

Hi, commenting here. From a high-level perspective this seems like a good move; this pmc(8) utility is open to improvements and seems like it never got past a beta phase.
It is good to be thoughtful about the old commands, but as you note they are broken and the tool as a whole is undocumented. So I do not think we are burdened with supporting them indefinitely.

Tue, Jun 30, 3:14 PM
mhorne added reviewers for D57780: pmc: enable the new pmc commands: pmc, adrian.
Tue, Jun 30, 3:05 PM
mhorne committed rGd5332d3a9042: generic_ehci_fdt: fix driver softc size (authored by mhorne).
generic_ehci_fdt: fix driver softc size
Tue, Jun 30, 3:00 PM
mhorne closed D57951: generic_ehci_fdt: fix driver softc size.
Tue, Jun 30, 3:00 PM

Jun 29 2026

mhorne added a comment to D57381: riscv: add KASAN support.

I tested in QEMU (both Sv39 and Sv48 mode), and on the VisionFive v2 and Allwinner D1 hardware. In fact, it detected a real bug on the latter!

Jun 29 2026, 6:17 PM
mhorne updated the test plan for D57951: generic_ehci_fdt: fix driver softc size.
Jun 29 2026, 6:16 PM
mhorne requested review of D57951: generic_ehci_fdt: fix driver softc size.
Jun 29 2026, 6:12 PM
mhorne added a comment to D57381: riscv: add KASAN support.

Hi. This is in great shape.

Jun 29 2026, 5:40 PM

Jun 24 2026

mhorne added inline comments to D57624: riscv/pmap.c: Add an Svinval-aware variant of pmap_invalidate_range.
Jun 24 2026, 2:06 PM
mhorne accepted D57624: riscv/pmap.c: Add an Svinval-aware variant of pmap_invalidate_range.
Jun 24 2026, 2:03 PM
mhorne accepted D57623: riscv: Add support for the Svinval extension.

Is this implemented on the Spacemit K1 ?

Jun 24 2026, 1:50 PM
mhorne accepted D56925: riscv/pmap.c: Avoid spurious kernel page faults when inserting new PTEs.
Jun 24 2026, 1:44 PM

Jun 23 2026

mhorne committed rGed4f5e590ee6: hwpmc_ibs: Add more IBS register definitions (authored by ali_mashtizadeh.com).
hwpmc_ibs: Add more IBS register definitions
Jun 23 2026, 4:39 PM
mhorne committed rGcf469ab83012: hwpmc_amd: Avoid using PMCs if in use by firmware (authored by ali_mashtizadeh.com).
hwpmc_amd: Avoid using PMCs if in use by firmware
Jun 23 2026, 4:39 PM

Jun 11 2026

mhorne committed rG3fbdaeeed45c: bcm2835_sdhci: Clean up DMA resources on attach failure (authored by Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>).
bcm2835_sdhci: Clean up DMA resources on attach failure
Jun 11 2026, 5:12 PM
mhorne committed rG6d526fa72b72: linux/io: handle memtype_wc mapping for !DMAP range (authored by mhorne).
linux/io: handle memtype_wc mapping for !DMAP range
Jun 11 2026, 5:12 PM