Page MenuHomeFreeBSD

mhorne (Mitchell Horne)
User

Projects

User Details

User Since
Mar 22 2019, 4:46 AM (218 w, 6 d)

Recent Activity

Tue, May 30

mhorne planned changes to D40290: hwpmc: Improve re-attachment logic in pmc_process_exec().

Ugh, I did not test it properly, and I think this version is totally broken...

Tue, May 30, 4:53 PM
mhorne added inline comments to D40290: hwpmc: Improve re-attachment logic in pmc_process_exec().
Tue, May 30, 4:48 PM
mhorne added a comment to D40335: dtrace: deduplicate some RISC-V functions.

In the future, please leave the revision open long enough for reviewers to have a chance to look at it. Even though the change is straightforward, and it was accepted by Mark, maybe I would have seen something that he didn't. For me, the change came and went completely before I got back from lunch. Thanks!

Tue, May 30, 3:56 PM
mhorne added inline comments to D40289: hwpmc: style(9) pass of hwpmc_mod.c.
Tue, May 30, 2:55 PM
mhorne requested review of D40334: libpmc: expand PMC_OP* defines.
Tue, May 30, 2:52 PM
mhorne added inline comments to D40290: hwpmc: Improve re-attachment logic in pmc_process_exec().
Tue, May 30, 2:50 PM
mhorne retitled D40290: hwpmc: Improve re-attachment logic in pmc_process_exec() from hwpmc: fix sense of pmc_can_attach() to hwpmc: Improve re-attachment logic in pmc_process_exec().
Tue, May 30, 2:47 PM
mhorne updated the diff for D40290: hwpmc: Improve re-attachment logic in pmc_process_exec().

Rework the change; remove pmc_can_attach() entirely in favor of p_candebug().

Tue, May 30, 2:45 PM
mhorne requested review of D40333: hwpmc: split out PMC_FN_PROCESS_EXEC.
Tue, May 30, 2:44 PM
mhorne updated the diff for D40289: hwpmc: style(9) pass of hwpmc_mod.c.

Add few more tweaks. Remove the type changes.

Tue, May 30, 2:43 PM

Mon, May 29

mhorne committed rG9d35469e9a68: bcm2835_gpio: Handle BCM2711 pin configuration (authored by t_uemura_macome.co.jp).
bcm2835_gpio: Handle BCM2711 pin configuration
Mon, May 29, 6:48 PM

Sat, May 27

mhorne planned changes to D40290: hwpmc: Improve re-attachment logic in pmc_process_exec().

There are further improvements to be made here, will update after some investigation.

Sat, May 27, 5:57 PM

Fri, May 26

mhorne added a comment to D40291: hwpmc: split out PMC_OP_PMCATTACH/PMC_OP_PMCDETACH.

Once I've landed the first few of these I will handle the remaining ops.

Fri, May 26, 6:44 PM
mhorne requested review of D40294: hwpmc: split out PMC_OP_PMCRW.
Fri, May 26, 6:40 PM
mhorne requested review of D40293: hwpmc: split out PMC_OP_PMCRELEASE.
Fri, May 26, 6:40 PM
mhorne requested review of D40292: hwpmc: split out PMC_OP_PMCALLOCATE.
Fri, May 26, 6:39 PM
mhorne requested review of D40291: hwpmc: split out PMC_OP_PMCATTACH/PMC_OP_PMCDETACH.
Fri, May 26, 6:39 PM
mhorne requested review of D40290: hwpmc: Improve re-attachment logic in pmc_process_exec().
Fri, May 26, 6:39 PM
mhorne requested review of D40288: hpwmc: add __pmcdbg_used annotation.
Fri, May 26, 6:39 PM
mhorne requested review of D40289: hwpmc: style(9) pass of hwpmc_mod.c.
Fri, May 26, 6:39 PM

Thu, May 25

mhorne closed D40241: riscv timer: use stimecmp CSR when available.
Thu, May 25, 5:12 PM
mhorne committed rGcadaabcc720b: riscv timer: use stimecmp CSR when available (authored by mhorne).
riscv timer: use stimecmp CSR when available
Thu, May 25, 5:12 PM
mhorne closed D40240: riscv: S-mode extension parsing.
Thu, May 25, 5:12 PM
mhorne committed rG8bebb786820f: riscv: S-mode extension parsing (authored by mhorne).
riscv: S-mode extension parsing
Thu, May 25, 5:12 PM
mhorne committed rGef0a711fd5d0: riscv: Use PMAP_MAPDEV_EARLY_SIZE in locore and pmap_bootstrap (authored by alfredo.mazzinghi_cl.cam.ac.uk).
riscv: Use PMAP_MAPDEV_EARLY_SIZE in locore and pmap_bootstrap
Thu, May 25, 5:07 PM
mhorne committed rGffa75b573f04: arm64/disassem.c: Add shifted register instruction definitions (authored by koliagogsadze_gmail.com).
arm64/disassem.c: Add shifted register instruction definitions
Thu, May 25, 5:07 PM
mhorne committed rG8a852d3e9ff7: arm64/disassem.c: Make output lowercase (authored by koliagogsadze_gmail.com).
arm64/disassem.c: Make output lowercase
Thu, May 25, 5:07 PM
mhorne closed D40110: riscv: Fix size reserved for the devmap region in pmap_bootstrap..
Thu, May 25, 5:06 PM
mhorne closed D40006: arm64/disassem.c: Add support insts of shifted register with rsv option.
Thu, May 25, 5:06 PM
mhorne closed D39820: arm64/disassem.c: make output in lowercase register to consistency.
Thu, May 25, 5:06 PM
mhorne accepted D40110: riscv: Fix size reserved for the devmap region in pmap_bootstrap..

LGTM, thanks. I can push this to the main branch.

Thu, May 25, 2:25 PM

Wed, May 24

mhorne committed rG08637d5d1580: ofw_cpu: quiet secondary CPU devices (authored by mhorne).
ofw_cpu: quiet secondary CPU devices
Wed, May 24, 1:29 PM
mhorne committed rG5edffecc4b4e: ofw_cpu: whitespace cleanup (authored by mhorne).
ofw_cpu: whitespace cleanup
Wed, May 24, 1:29 PM
mhorne closed D40243: ofw_cpu: quiet secondary CPU devices.
Wed, May 24, 1:29 PM
mhorne closed D40242: ofw_cpu: whitespace cleanup.
Wed, May 24, 1:29 PM
mhorne closed D40232: developers-handbook: Remove source code layout.
Wed, May 24, 12:04 PM
mhorne committed R9:367a5737c1e8: developers-handbook: Remove source code layout (authored by mhorne).
developers-handbook: Remove source code layout
Wed, May 24, 12:04 PM
mhorne committed R9:82a06c65d256: website: Update Software License Policy examples (authored by mhorne).
website: Update Software License Policy examples
Wed, May 24, 12:04 PM
mhorne closed D40233: website: Update Software License Policy examples.
Wed, May 24, 12:04 PM

Tue, May 23

mhorne updated the test plan for D40243: ofw_cpu: quiet secondary CPU devices.
Tue, May 23, 5:51 PM
mhorne requested review of D40243: ofw_cpu: quiet secondary CPU devices.
Tue, May 23, 5:51 PM
mhorne requested review of D40242: ofw_cpu: whitespace cleanup.
Tue, May 23, 5:51 PM
mhorne updated the diff for D40232: developers-handbook: Remove source code layout.

Link to the root of the src repo.

Tue, May 23, 5:25 PM
mhorne requested review of D40241: riscv timer: use stimecmp CSR when available.
Tue, May 23, 5:16 PM
mhorne requested review of D40240: riscv: S-mode extension parsing.
Tue, May 23, 5:16 PM
mhorne requested review of D40233: website: Update Software License Policy examples.
Tue, May 23, 2:45 PM
mhorne added a comment to D40232: developers-handbook: Remove source code layout.

I forgot to submit this a while ago when I purged this info from hier(7).

Tue, May 23, 2:45 PM
mhorne requested review of D40232: developers-handbook: Remove source code layout.
Tue, May 23, 2:43 PM
mhorne committed rG7245ffd10eda: riscv: MMU detection (authored by mhorne).
riscv: MMU detection
Tue, May 23, 1:24 PM
mhorne committed rG940e6d36de1e: riscv: Print less CPU info (authored by mhorne).
riscv: Print less CPU info
Tue, May 23, 1:24 PM
mhorne committed rG78a3420c20e0: riscv: Print ISA extensions (authored by mhorne).
riscv: Print ISA extensions
Tue, May 23, 1:24 PM
mhorne committed rGb37dc0903332: riscv: Rework CPU identification (second part) (authored by mhorne).
riscv: Rework CPU identification (second part)
Tue, May 23, 1:24 PM
mhorne committed rG88b4d124efc5: riscv: Rework CPU identification (first part) (authored by mhorne).
riscv: Rework CPU identification (first part)
Tue, May 23, 1:24 PM
mhorne committed rGb0d45b023e8c: riscv: Call identify_cpu() earlier for CPU 0 (authored by mhorne).
riscv: Call identify_cpu() earlier for CPU 0
Tue, May 23, 1:24 PM
mhorne closed D40024: riscv: rework CPU identification [7/7].
Tue, May 23, 1:24 PM
mhorne closed D39814: riscv: rework CPU identification [6/6].
Tue, May 23, 1:24 PM
mhorne closed D39813: riscv: rework CPU identification [5/6].
Tue, May 23, 1:23 PM
mhorne closed D39811: riscv: rework CPU identification [3/6].
Tue, May 23, 1:23 PM
mhorne closed D39810: riscv: rework CPU identification [2/6].
Tue, May 23, 1:23 PM
mhorne closed D39809: riscv: rework CPU identification [1/6].
Tue, May 23, 1:23 PM

Mon, May 22

mhorne added inline comments to D39811: riscv: rework CPU identification [3/6].
Mon, May 22, 4:54 PM
mhorne accepted D40203: hier.7: update /home.

Thanks! ...especially for the ordering fix :)

Mon, May 22, 2:26 PM
mhorne accepted D40006: arm64/disassem.c: Add support insts of shifted register with rsv option.

Thanks. I will commit this and D39820 today or tomorrow.

Mon, May 22, 1:14 PM
mhorne accepted D40165: arm64: use PSR_DAIF instead of each individual flag.
Mon, May 22, 1:13 PM
mhorne added a comment to D40161: arm64/intrng: add support for FIQs.

I am having difficulty trying to rationalize the acronym "FIQ" 🤔 😆

Mon, May 22, 12:59 PM

Sat, May 20

mhorne added a comment to D40006: arm64/disassem.c: Add support insts of shifted register with rsv option.

Looks good, one thing to fix.

Sat, May 20, 11:59 AM

Fri, May 19

mhorne added a comment to D40110: riscv: Fix size reserved for the devmap region in pmap_bootstrap..

@mhorne I'm not sure how this currently is supposed to work, because the PMAP_MAPDEV_EARLY_SIZE constant is already larger than L2_SIZE in vmparam.h. So what we really want is also the DTB to be mapped at VM_EARLY_DTB_ADDRESS, which currently seems to be assumed to correspond to the second-to-last L2 entry in the devmap table. Is the PMAP_MAPDEV_EARLY_SIZE constant supposed to contain VM_EARLY_DTB_ADDRESS?

Fri, May 19, 5:05 PM
mhorne added inline comments to D40006: arm64/disassem.c: Add support insts of shifted register with rsv option.
Fri, May 19, 4:09 PM

Tue, May 16

mhorne updated the summary of D39811: riscv: rework CPU identification [3/6].
Tue, May 16, 6:13 PM
mhorne abandoned D39812: riscv: rework CPU identification [4/6].

Absorbed by D39811.

Tue, May 16, 6:10 PM
mhorne updated the diff for D39814: riscv: rework CPU identification [6/6].

Rebase.

Tue, May 16, 6:09 PM
mhorne updated the diff for D39813: riscv: rework CPU identification [5/6].

Rebase. This patch becomes much simpler.

Tue, May 16, 6:09 PM
mhorne updated the diff for D39811: riscv: rework CPU identification [3/6].

Rethink the series again; third time's the charm.

Tue, May 16, 6:09 PM

Mon, May 15

mhorne requested changes to D40110: riscv: Fix size reserved for the devmap region in pmap_bootstrap..

In order for this to work, you will need to fix the assembly in locore.S where we actually create the devmap mapping. There, we create it as a single 2MiB page beginning at (VM_MAX_KERNEL_ADDRESS - L2_SIZE).

Mon, May 15, 3:50 PM
mhorne added a comment to D40085: pw: do not move /home/$user to /usr/home.

Thanks for your work in handling this, @karels. The pw(8) changes, and tests, make sense to me, but it's not really my code to accept.

Mon, May 15, 3:08 PM
mhorne added inline comments to D40006: arm64/disassem.c: Add support insts of shifted register with rsv option.
Mon, May 15, 2:12 PM

Fri, May 12

mhorne added inline comments to D40006: arm64/disassem.c: Add support insts of shifted register with rsv option.
Fri, May 12, 1:02 PM
mhorne added a comment to D40006: arm64/disassem.c: Add support insts of shifted register with rsv option.

The wording used by the docs is confusing, but it is actually saying that disassemblers should output the aliases when possible.

Fri, May 12, 11:41 AM
mhorne accepted D39820: arm64/disassem.c: make output in lowercase register to consistency.
Fri, May 12, 11:39 AM

Thu, May 11

mhorne accepted D40050: pmc: Bump major version for just-committed breaking changes.

I think the major version bump for 14.0 is a good thing, after going unchanged for a long while. I am certain that backwards compatibility has not been tested thoroughly in the last couple of years, and there are probably some subtle edge cases in which it has broken (for all I know I could be the culprit). This gives us a new baseline.

Thu, May 11, 6:28 PM
mhorne accepted D40049: pmc: Initialise and check the pm_flags field for CONFIGURELOG.

It is annoying, but this represents a new distinct error return from the syscall, and should be added to the ERRORS list in hwpmc(4).

Thu, May 11, 6:19 PM
mhorne accepted D40048: pmc: Provide full path to modules from kernel linker.

The resulting cleanup is excellent.

Thu, May 11, 6:18 PM
mhorne added inline comments to D39811: riscv: rework CPU identification [3/6].
Thu, May 11, 5:38 PM
mhorne added inline comments to D39811: riscv: rework CPU identification [3/6].
Thu, May 11, 4:42 PM

Wed, May 10

mhorne committed rG031049cf3262: hier(7): fix a couple mandoc warnings (authored by mhorne).
hier(7): fix a couple mandoc warnings
Wed, May 10, 1:28 PM
mhorne committed rG36db6b04962a: hier(7): document /home/ and /usr/home/ (authored by mhorne).
hier(7): document /home/ and /usr/home/
Wed, May 10, 1:28 PM
mhorne committed rG1bc55f58393f: hier(7): drop list of /usr/share/doc subdirectories (authored by mhorne).
hier(7): drop list of /usr/share/doc subdirectories
Wed, May 10, 1:28 PM
mhorne committed rGc3b611e153e0: hier(7): drop list of /usr/include subdirectories (authored by mhorne).
hier(7): drop list of /usr/include subdirectories
Wed, May 10, 1:28 PM
mhorne closed D40002: hier(7): document /home/ and /usr/home/.
Wed, May 10, 1:28 PM
mhorne closed D40001: hier(7): drop list of /usr/share/doc subdirectories.
Wed, May 10, 1:28 PM
mhorne closed D40000: hier(7): drop list of /usr/include subdirectories.
Wed, May 10, 1:28 PM

Tue, May 9

mhorne requested review of D40024: riscv: rework CPU identification [7/7].
Tue, May 9, 5:16 PM
mhorne updated the diff for D39810: riscv: rework CPU identification [2/6].

Rebase and rename to printcpuinfo().

Tue, May 9, 5:11 PM
mhorne updated the test plan for D39809: riscv: rework CPU identification [1/6].
Tue, May 9, 5:09 PM
mhorne updated the diff for D39809: riscv: rework CPU identification [1/6].

Rework the change a bit based on review comments.

Tue, May 9, 5:08 PM
mhorne added a comment to D40021: loader: install help files only once.

This is simple, and makes sense to me. I think you should be consistent about which interpreter variant is the "yes" one; for efi and userboot it is "simp" but for i386 it is "4th".

Tue, May 9, 1:11 PM

Mon, May 8

mhorne added a comment to D40000: hier(7): drop list of /usr/include subdirectories.

Maybe refer to https://bugs.freebsd.org/261349 when committing. Thanks.

Mon, May 8, 4:38 PM
mhorne committed rGa89f1ce51b6d: riscv: remove unused string from swtch.S (authored by mhorne).
riscv: remove unused string from swtch.S
Mon, May 8, 4:35 PM
mhorne added inline comments to D40001: hier(7): drop list of /usr/share/doc subdirectories.
Mon, May 8, 2:44 PM
mhorne added a reviewer for D40000: hier(7): drop list of /usr/include subdirectories: imp.
Mon, May 8, 2:37 PM