Page MenuHomeFreeBSD

x86-assembly: update the article a bit
AcceptedPublic

Authored by mhorne on Jul 12 2024, 5:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 5:07 PM
Unknown Object (File)
Sat, Jan 18, 9:16 PM
Unknown Object (File)
Sat, Jan 11, 11:20 AM
Unknown Object (File)
Jan 2 2025, 6:21 PM
Unknown Object (File)
Jan 2 2025, 6:02 AM
Unknown Object (File)
Nov 21 2024, 9:27 AM
Unknown Object (File)
Oct 21 2024, 5:02 PM
Unknown Object (File)
Oct 19 2024, 2:45 PM
Subscribers
None

Details

Reviewers
0mp
emaste
Summary

Minor tweaks for consistency/readability. Actual content is not touched.

  • Replace references to "chapter" with "article".
  • Add a NOTE of the historical nature of the document.
  • Clarify assemblers available on FreeBSD.
  • List the trademarks used in the article, and reduce the (R) symbol usage. Per the Doc Primer, it only needs to be emitted with the first usage of the trademark.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58626
Build 55514: arc lint + arc unit

Event Timeline

mhorne created this revision.
emaste added inline comments.
documentation/content/en/articles/x86-assembly/_index.adoc
49

The comment in the first review states that it is "is still accurate" so I assume this chapter has some purpose still, and is not kept only for history. Should we expand this note somewhat to clarify the state/intent of this info?

85

There are a lot of potential updates you could make and I'm not going to suggest spending the effort on those extensive changes, but at least mentioning yasm would make sense to me.

314

not really true but reasonable to leave outside of the scope of your changes

This revision is now accepted and ready to land.Jul 14 2024, 12:24 AM

LGTM. Next time let's keep simple changes like s/(R)//g in s separate commit. It's easier to review.