Page MenuHomeFreeBSD

x86-assembly: update the article a bit
ClosedPublic

Authored by mhorne on Jul 12 2024, 5:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 23, 10:58 PM
Unknown Object (File)
Thu, May 21, 6:04 PM
Unknown Object (File)
Thu, May 21, 1:13 PM
Unknown Object (File)
Sat, May 16, 1:15 PM
Unknown Object (File)
Fri, May 15, 9:15 AM
Unknown Object (File)
Fri, May 15, 6:39 AM
Unknown Object (File)
Fri, May 15, 5:07 AM
Unknown Object (File)
Fri, May 15, 4:43 AM
Subscribers
None

Details

Summary

Minor tweaks for consistency/readability. Actual content is not touched.

  • Replace references to "chapter" with "article".
  • Add a NOTE of the historical nature of the document.
  • Clarify assemblers available on FreeBSD.
  • List the trademarks used in the article, and reduce the (R) symbol usage. Per the Doc Primer, it only needs to be emitted with the first usage of the trademark.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.
emaste added inline comments.
documentation/content/en/articles/x86-assembly/_index.adoc
49

The comment in the first review states that it is "is still accurate" so I assume this chapter has some purpose still, and is not kept only for history. Should we expand this note somewhat to clarify the state/intent of this info?

85–87

There are a lot of potential updates you could make and I'm not going to suggest spending the effort on those extensive changes, but at least mentioning yasm would make sense to me.

314

not really true but reasonable to leave outside of the scope of your changes

This revision is now accepted and ready to land.Jul 14 2024, 12:24 AM

LGTM. Next time let's keep simple changes like s/(R)//g in s separate commit. It's easier to review.

This revision now requires review to proceed.Apr 16 2026, 6:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, May 19, 2:26 PM
This revision was automatically updated to reflect the committed changes.