In D28051#627023, @nc wrote:

This port is not in 2021Q1, so it's not affected by this bug.

OK from manpages.

Note: if this runtime bug got into 2021Q1 then we should MFH. Let me know if that's the case.

RELNOTES: yes?

OK form manpages.

Ach, that's what I thought. Thanks for linting the file.

My comments seem to be addressed at this point. Approved.

If you are sure that no dependencies changed (so distinfo is largely the same), then feel free to commit.

Seems fine.

Note: please check bugzilla if there are any bugs or updates for this port. Perhaps we can close some problem reports.

See if the file produces sensible outputs now (dot -T png -o file.png committers-ports.dot).

It worked. That's very interesting... Anyway, thanks for the patch!

Very nice port, thanks a lot. Approved.

Approved!

In D27987#625321, @nc wrote:

@0mp, I forgot to mention you are my mentor in the commit message for this, sorry.

Thanks for the patch.

You've got my approval to commit, @nc!

Seems fine! Thanks a lot!

Thanks!

Just one last typo...

Thanks!

Two minor issues left. Otherwise, seems pretty solid! :)

As I mentioned in the other comment it would be great if you mention in the description of the patch / in the comments if you run a poudriere testport or an equivalent. This might help detect regressions like pkg-plist issues early on. It's also a sign for me that you've tested the update before the commit.

Thanks for testing the update so thoroughly! :) Approved!

In D27975#624858, @nc wrote:

For release notes, I have them here: https://github.com/denverquane/automuteus/releases/tag/6.7.2

Since the "gaming PC" I have is actually my Ports development box, I tested the port by making sure unit tests pass.

the patch seems alright. Before I give you an approval to commit, could you let me know how did you test the port? That would give me an good overview of what has been tested so far.

I've run a poudriere testport on 12.2-RELEASE amd64 and it seems to work just fine.

Two questions:

Let's go!

In D27957#624548, @neel_neelc.org wrote:

I;ll use this:

Add committer entries for Neel Chauhan <nc>

Steps 1-4 from the Committer's guide:
  - Add entries for Neel Chauhan <nc>
  - Add GPG key

Reviewed by:            0mp
Approved by:            0mp
Differential Revision:  https://reviews.freebsd.org/D27957

I think that the doc: could be dropped. Also, (mentor) can be removed from the Reviewed by entry in my opinion. Otherwise, seems pretty nice!

Seems fine. Please, before you commit,

BTW, could you try to submit future patches with context? The easiest way is to configure arcanist (https://www.freshports.org/devel/arcanist/). It makes reviewing a bit easier. Thank you :)

Just a couple of minor errors. Otherwise, amazing job, Fernando!

In D27733#619922, @rmacklem wrote:

Made the recommended changes.
I'll admit I started with .Ar and then changed to .Dq
because a plain text screen like I use does not mark
.Ar in any way.

However, you are correct that it should be .Ar name.

A couple of mdoc suggestions. Otherwise, it seems fine!

• Use pid_t
• Use err() instead of perror

Thanks!

Use open() instead of pipe().