In D21450#533281, @crees wrote:

This needs some heavy testing, for which I'm afraid I just don't have the capacity for at the moment. I've been bitten quite hard recently by a 'simple' rc change recently so I'm reluctant to put my stamp on it!
It also needs approval from a src developer- perhaps try asking on -rc? Male sure you detail the testing done.
Sorry.

Is it ready?

@emaste, could you take a look?

I'm looking for a review of 1 thing, really: is it beneficial to actually create those MLINKS.

In D24196#532232, @debdrup wrote:

According to mdoc(7), the .Li macro is deprecated - should Ql be used instead?

Oh, that's new! Thank you

• Add EXAMPLES
• Rewrite description

In D23982#532450, @emaste wrote:

@0mp should the struct elements instead be .Va? That's what's used in stat(2) for the definition of struct stat.

@emaste, I've uploaded a (hopefully) improved patch here: https://people.freebsd.org/~0mp/elf.5.patch

Rebase

Rebase

Thanks, @asomers!

In D24104#531131, @salvadore wrote:

By the way, I just realized that up to now we have indeed distributed through binary packages the modified rc script, without any declaration on copyrights and license for these modifications. And we regularly do that in the ports tree for any port that patches the files it fetches. I guess then that it would be fine to just continue doing that?

@netchild, nevermind, I juts updated the pkg-message :)

In D24127#531097, @netchild wrote:

Hmmm... didn't you forgot to mention to change the user in the new pkg-message? Not sure if it is mandatory, and you point out to read-up about how to configure, but as you mention the FreeBSD team I would also mention to change the user. But as already told, I don't see a big showstopper, that's a detail which can be improved as time permits.

When it comes to the script, none of my comments were essential to the proper functioning of the script. They were more about style and future maintenance.

Thanks, everyone!

Could you ask on the freebsd-ports@ mailing list for a final round of reviews? This looks like a nice addition to the PH. Let's see if the community has any feedback on that.

• Change user description in UIDs
• List LICENSE_PERMS explicitly
• Do not install desktop files: the web viewer is broken at the moment and causes an flood of errors in the logs of the service
• Add LEGAL_TEXT
• Set ETCDIR and DOCSDIR properly
• Improve the service file (I confirm that all commands like status, start, stop, poll, and a custom one called "log" work)
• Rewrite pkg-message

BTW, shouldn't all the configuration files in ETCDIR be prefixed with @sample in pkg-plist?

• Resurect biology/linux-foldingathome
• Use dos2unix on the config file

• Move the port to the biology category (more specific than science)

• Add pkg-message to SUB_FILES
• Improve pkg-descr

• Add $FreeBSD$ to the service file

• Fix style issues (thanks @bcr).

BTW, the modified section renders like this: