Page MenuHomeFreeBSD

0mp (Mateusz Piotrowski)
User

Projects (8)

User Details

User Since
Apr 1 2018, 2:39 PM (380 w, 2 d)

Recent Activity

Today

0mp closed D50922: dtrace_fbt.4: Document the DTrace fbt provider.

Closed via 9388c2887817d7162ebb356b39aa9b4ab67a8c00.

Wed, Jul 16, 10:31 AM · DTrace
0mp committed rG9388c2887817: dtrace_fbt.4: Document the DTrace fbt provider (authored by 0mp).
dtrace_fbt.4: Document the DTrace fbt provider
Wed, Jul 16, 10:30 AM
0mp committed R11:d2cc3925e9dc: sysutils/powerdxx: Add extra patch to fix powerdxx_enable (authored by 0mp).
sysutils/powerdxx: Add extra patch to fix powerdxx_enable
Wed, Jul 16, 10:15 AM
0mp added inline comments to D51317: dtrace_vfs.4: Document the DTrace vfs provider.
Wed, Jul 16, 12:13 AM

Yesterday

0mp added a comment to D51315: vfs_cache: Fix the SDT definition of vfs:fplookup:lookup:done.

Thanks, Mark!

Tue, Jul 15, 9:19 PM · DTrace
0mp committed rG6567623f831d: vfs_cache: Fix the SDT definition of vfs:fplookup:lookup:done (authored by 0mp).
vfs_cache: Fix the SDT definition of vfs:fplookup:lookup:done
Tue, Jul 15, 9:08 PM
0mp closed D51315: vfs_cache: Fix the SDT definition of vfs:fplookup:lookup:done.
Tue, Jul 15, 9:08 PM · DTrace
0mp updated the diff for D51315: vfs_cache: Fix the SDT definition of vfs:fplookup:lookup:done.
  • Add the enum to the definition
Tue, Jul 15, 8:24 PM · DTrace
0mp abandoned D51328: libdtrace: Add vfs.d and define enum cache_fpl_status values there.

Great! Thanks for explaining, Mark :)

Tue, Jul 15, 3:43 PM · DTrace
0mp added a comment to D51315: vfs_cache: Fix the SDT definition of vfs:fplookup:lookup:done.

Alternatively, I've opened another revision that adds the enum to libdtrace/vfs.d, but I suspect that this is not the right fix based on Mark's last comment.

Tue, Jul 15, 3:30 PM · DTrace
0mp added a comment to D51315: vfs_cache: Fix the SDT definition of vfs:fplookup:lookup:done.

Another side note: wouldn't it be nice to create a vfs.d in /usr/lib/dtrace so that we could use the actual enum for arg2 instead of integers? The enum would be:

Just change the type from int to enum cache_fpl_status in the probe definition, and it'll work. dtrace knows about enum names since they're encoded in CTF info.

Tue, Jul 15, 3:29 PM · DTrace
0mp updated the test plan for D51328: libdtrace: Add vfs.d and define enum cache_fpl_status values there.
Tue, Jul 15, 3:25 PM · DTrace
0mp requested review of D51328: libdtrace: Add vfs.d and define enum cache_fpl_status values there.
Tue, Jul 15, 3:24 PM · DTrace
0mp edited reviewers for D51315: vfs_cache: Fix the SDT definition of vfs:fplookup:lookup:done, added: christos; removed: chris_cretaforce.gr.
Tue, Jul 15, 3:03 PM · DTrace
0mp updated the test plan for D51315: vfs_cache: Fix the SDT definition of vfs:fplookup:lookup:done.
Tue, Jul 15, 3:03 PM · DTrace
0mp committed rGcdd5fece162b: rc.subr: Fix a typo in check_jail()'s description (authored by 0mp).
rc.subr: Fix a typo in check_jail()'s description
Tue, Jul 15, 12:25 AM
0mp committed rGf668b5a413d9: rc.subr: Fix a typo in check_jail()'s description (authored by 0mp).
rc.subr: Fix a typo in check_jail()'s description
Tue, Jul 15, 12:24 AM
0mp updated the diff for D50922: dtrace_fbt.4: Document the DTrace fbt provider.
  • Pet mdoc linters
Tue, Jul 15, 12:13 AM · DTrace
0mp retitled D51318: dtrace_fbt.4: Document the DTrace fbt provider (WIP, git-arc mistake) from dtrace_fbt.4: Document the DTrace fbt provider to dtrace_fbt.4: Document the DTrace fbt provider (WIP, git-arc mistake).
Tue, Jul 15, 12:12 AM
0mp abandoned D51318: dtrace_fbt.4: Document the DTrace fbt provider (WIP, git-arc mistake).

That was an git arc mistake. Disregard.

Tue, Jul 15, 12:12 AM
0mp requested review of D51318: dtrace_fbt.4: Document the DTrace fbt provider (WIP, git-arc mistake).
Tue, Jul 15, 12:11 AM
0mp added inline comments to D50922: dtrace_fbt.4: Document the DTrace fbt provider.
Tue, Jul 15, 12:09 AM · DTrace
0mp updated the diff for D50922: dtrace_fbt.4: Document the DTrace fbt provider.
  • Address Christos' feedback
Tue, Jul 15, 12:09 AM · DTrace

Mon, Jul 14

0mp updated the diff for D51317: dtrace_vfs.4: Document the DTrace vfs provider.
  • Reference the DTrace book
Mon, Jul 14, 11:57 PM
0mp committed rG0abee387e1df: vnode.9: Fix a typo in sys/tools/vnode_if.awk path name (authored by 0mp).
vnode.9: Fix a typo in sys/tools/vnode_if.awk path name
Mon, Jul 14, 11:46 PM
0mp requested review of D51317: dtrace_vfs.4: Document the DTrace vfs provider.
Mon, Jul 14, 11:39 PM
0mp requested review of D51315: vfs_cache: Fix the SDT definition of vfs:fplookup:lookup:done.
Mon, Jul 14, 11:14 PM · DTrace
0mp committed R11:6494691876c0: net/samba420: Fix pkg-plist for bundled talloc (authored by Michael Proto <mike@jellydonut.org>).
net/samba420: Fix pkg-plist for bundled talloc
Mon, Jul 14, 9:30 PM
0mp committed R11:f8730e99e640: Wrappers/gm4: Quote $@ correctly (authored by 0mp).
Wrappers/gm4: Quote $@ correctly
Mon, Jul 14, 9:30 PM
0mp committed rGbdb44a47b71e: d.7: Refrain from unnecessary time travel (authored by 0mp).
d.7: Refrain from unnecessary time travel
Mon, Jul 14, 6:34 PM
0mp planned changes to D50922: dtrace_fbt.4: Document the DTrace fbt provider.
Mon, Jul 14, 5:01 PM · DTrace
0mp committed rG1fe7af063581: dtrace.1: Document evaltime (authored by 0mp).
dtrace.1: Document evaltime
Mon, Jul 14, 4:40 PM
0mp closed D51301: dtrace.1: Document evaltime.
Mon, Jul 14, 4:40 PM
0mp committed rG46efd2ceca73: dtrace_profile.4: Document the DTrace profile provider (authored by 0mp).
dtrace_profile.4: Document the DTrace profile provider
Mon, Jul 14, 4:37 PM
0mp closed D51278: dtrace_profile.4: Document the DTrace profile provider.
Mon, Jul 14, 4:36 PM
0mp added inline comments to D51301: dtrace.1: Document evaltime.
Mon, Jul 14, 4:33 PM
0mp updated the diff for D51278: dtrace_profile.4: Document the DTrace profile provider.
  • Address feedback
Mon, Jul 14, 3:41 PM
0mp added inline comments to D51301: dtrace.1: Document evaltime.
Mon, Jul 14, 3:36 PM
0mp updated the diff for D51301: dtrace.1: Document evaltime.
  • Address feedback
Mon, Jul 14, 3:36 PM
0mp added a comment to D51301: dtrace.1: Document evaltime.

In the first paragraph it is not immediately clear (to me at least) what this variable actually does. I especially get quite confused with what "newly started child process" means. Does it refer to the command defined in -c cmd? Or is it something else? I think the wording needs some improvement there.

Mon, Jul 14, 3:18 PM
0mp updated the diff for D51301: dtrace.1: Document evaltime.
  • Address feedback
  • Turn the process create mode list into a table. Looks better and is a bit more concise.
Mon, Jul 14, 3:18 PM
0mp added inline comments to D51301: dtrace.1: Document evaltime.
Mon, Jul 14, 2:54 PM
0mp added reviewers for D51301: dtrace.1: Document evaltime: christos, markj, dteske.
Mon, Jul 14, 2:53 PM
0mp requested review of D51301: dtrace.1: Document evaltime.
Mon, Jul 14, 2:52 PM
0mp committed rG193f2289fc9a: d.7: Document the DTrace scripting language (authored by 0mp).
d.7: Document the DTrace scripting language
Mon, Jul 14, 1:02 PM
0mp closed D51268: d.7: Document the DTrace scripting language.
Mon, Jul 14, 1:02 PM · docs, DTrace
0mp added a comment to D51268: d.7: Document the DTrace scripting language.

Thanks!

Mon, Jul 14, 1:02 PM · docs, DTrace
0mp added inline comments to D51268: d.7: Document the DTrace scripting language.
Mon, Jul 14, 12:21 PM · docs, DTrace
0mp updated the diff for D51268: d.7: Document the DTrace scripting language.
  • Capitalize descriptions of aggregation functions
Mon, Jul 14, 12:21 PM · docs, DTrace
0mp committed rGc2b1623bb97e: truss.1: Reference sysdecode(3) (authored by 0mp).
truss.1: Reference sysdecode(3)
Mon, Jul 14, 12:19 PM
0mp committed rGa487606afd9b: dtrace_dtrace.4: Document the DTrace dtrace provider (authored by 0mp).
dtrace_dtrace.4: Document the DTrace dtrace provider
Mon, Jul 14, 12:19 PM
0mp closed D51267: dtrace_dtrace.4: Document the DTrace dtrace provider.
Mon, Jul 14, 12:19 PM · docs, DTrace
0mp added a comment to D51268: d.7: Document the DTrace scripting language.

@ziaee, could you check the apropos(1) compliance? ;)

Mon, Jul 14, 12:12 PM · docs, DTrace
0mp updated the diff for D51268: d.7: Document the DTrace scripting language.
  • Address feedback
Mon, Jul 14, 12:11 PM · docs, DTrace

Sun, Jul 13

0mp added a comment to D51267: dtrace_dtrace.4: Document the DTrace dtrace provider.

Thanks!

Sun, Jul 13, 4:27 PM · docs, DTrace
0mp updated the diff for D51267: dtrace_dtrace.4: Document the DTrace dtrace provider.
  • Address feedback
Sun, Jul 13, 4:27 PM · docs, DTrace
0mp updated the diff for D51267: dtrace_dtrace.4: Document the DTrace dtrace provider.
  • Address bcr's comments
Sun, Jul 13, 4:24 PM · docs, DTrace
0mp updated the diff for D51268: d.7: Document the DTrace scripting language.
  • Add bcr's comments
Sun, Jul 13, 4:12 PM · docs, DTrace
0mp updated the diff for D50922: dtrace_fbt.4: Document the DTrace fbt provider.
  • Apply bcr's comments
Sun, Jul 13, 3:58 PM · DTrace
0mp abandoned D27176: Discourage the use of sysexits(3) in new code.

I'm closing this one then.

Sun, Jul 13, 3:38 PM
0mp committed rG10d336114d48: tracing(7): Add hwt(4) (authored by 0mp).
tracing(7): Add hwt(4)
Sun, Jul 13, 3:36 PM
0mp closed D51276: tracing(7): Add hwt(4).
Sun, Jul 13, 3:36 PM
0mp accepted D51264: man4: Use arch specifier of Dt consistently.

Thanks!

How did you identify the amd64 ones in man4?

From reading man4/Makefile

Sun, Jul 13, 3:35 PM
0mp accepted D51284: tracing.7: Shorten doc description for apropos.

I wasn't planning to MFC tracing(7). I don't remember if there is anything in the manual that is 15-specific though

Sun, Jul 13, 3:34 PM
0mp added a reviewer for D18768: Describe FreeBSD's virtual memory in memory(7): bnovkov.
Sun, Jul 13, 3:30 PM
0mp updated the diff for D18768: Describe FreeBSD's virtual memory in memory(7).

Thanks to @kib for posing a lot of comments about the VM subsystem. There is clearly a lot to be done before this manual page lands in the base system.

Sun, Jul 13, 3:30 PM
0mp updated the diff for D50922: dtrace_fbt.4: Document the DTrace fbt provider.
  • Fix a typo in Example 1
Sun, Jul 13, 2:20 PM · DTrace
0mp updated the summary of D51287: dtrace_pid.4: Document the DTrace PID provider.
Sun, Jul 13, 2:17 PM · manpages, DTrace
0mp requested review of D51287: dtrace_pid.4: Document the DTrace PID provider.
Sun, Jul 13, 2:16 PM · manpages, DTrace
0mp requested changes to D51052: Remove BUGS from aio_write(2).

Actually, I'm not sure if this section should be removed. I posted a comment in Bugzilla about it.

Sun, Jul 13, 12:08 PM
0mp accepted D51052: Remove BUGS from aio_write(2).

Seems OK.

Sun, Jul 13, 11:43 AM
0mp added a comment to D51264: man4: Use arch specifier of Dt consistently.

The man.<arch> manuals are easy.

Sun, Jul 13, 10:18 AM
0mp updated the diff for D51267: dtrace_dtrace.4: Document the DTrace dtrace provider.
  • Fix ERROR's args (arg0 should not be documented; real arguments are arg1-arg5)
  • Expand example 2
Sun, Jul 13, 10:08 AM · docs, DTrace
0mp added a comment to D27722: bsd.port.mk: Remove confusing double "/" from _DISTDIR.

Landed! Thanks!

Sun, Jul 13, 9:33 AM
0mp closed D27722: bsd.port.mk: Remove confusing double "/" from _DISTDIR.
Sun, Jul 13, 9:33 AM
0mp committed R11:3fc4fad26362: Mk/bsd.port.mk: Remove confusing double "/" from _DISTDIR (authored by 0mp).
Mk/bsd.port.mk: Remove confusing double "/" from _DISTDIR
Sun, Jul 13, 9:33 AM
0mp updated the diff for D27722: bsd.port.mk: Remove confusing double "/" from _DISTDIR.
  • Use mat's implementation
Sun, Jul 13, 9:26 AM

Sat, Jul 12

0mp committed rG5d5258653ba4: rc.subr: Fix a typo in check_jail()'s description (authored by 0mp).
rc.subr: Fix a typo in check_jail()'s description
Sat, Jul 12, 4:25 PM
0mp committed rG46f18ecf8d3c: rc: Use check_jail to check values of security.jail MIBs (authored by 0mp).
rc: Use check_jail to check values of security.jail MIBs
Sat, Jul 12, 4:25 PM
0mp closed D47329: rc: Use check_jail to check values of security.jail MIBs.
Sat, Jul 12, 4:24 PM · rc
0mp added a comment to D47329: rc: Use check_jail to check values of security.jail MIBs.

Thanks!

Sat, Jul 12, 4:24 PM · rc
0mp committed rG47ffc24fbb64: tracing.7: Aproposify (authored by 0mp).
tracing.7: Aproposify
Sat, Jul 12, 4:03 PM
0mp added inline comments to D51276: tracing(7): Add hwt(4).
Sat, Jul 12, 4:02 PM
0mp updated the diff for D51268: d.7: Document the DTrace scripting language.
  • Document execargs
  • Add a note what execname is.
Sat, Jul 12, 3:46 PM · docs, DTrace
0mp committed R11:f8cddea9c798: sysutils/dtrace-toolkit: Fix manuals and wordsmith pkg-message (authored by 0mp).
sysutils/dtrace-toolkit: Fix manuals and wordsmith pkg-message
Sat, Jul 12, 3:27 PM
0mp updated the diff for D51268: d.7: Document the DTrace scripting language.
  • Move cwd to BUGS and mention that it is not supported at the moment.
Sat, Jul 12, 3:09 PM · docs, DTrace
0mp closed D47482: docs(handbook/dtrace): Update DTrace guide link.

I've committed a similar patch earlier today. I've just stumbled upon this patch now as I was looking at DTrace-related submissions.

Sat, Jul 12, 2:39 PM
0mp committed R11:366c8eff8a4e: sysutils/dtrace-toolkit: Register ksh93 as the run dependency (authored by 0mp).
sysutils/dtrace-toolkit: Register ksh93 as the run dependency
Sat, Jul 12, 2:33 PM
0mp updated the diff for D51268: d.7: Document the DTrace scripting language.
  • Address bcr's feedback
  • Reference ddb(4) as the kernel debugger, not kgdb
Sat, Jul 12, 2:18 PM · docs, DTrace
0mp added a project to D51267: dtrace_dtrace.4: Document the DTrace dtrace provider: docs.
Sat, Jul 12, 2:10 PM · docs, DTrace
0mp added a comment to D51276: tracing(7): Add hwt(4).

Thanks, Bojan!

Sat, Jul 12, 2:10 PM
0mp updated the diff for D51276: tracing(7): Add hwt(4).
  • Address feedback
Sat, Jul 12, 2:09 PM
0mp requested review of D51278: dtrace_profile.4: Document the DTrace profile provider.
Sat, Jul 12, 1:52 PM
0mp updated the summary of D51268: d.7: Document the DTrace scripting language.
Sat, Jul 12, 1:51 PM · docs, DTrace
0mp committed rGc479d2b29fc9: tracing.7: Pet linters (authored by 0mp).
tracing.7: Pet linters
Sat, Jul 12, 9:54 AM
0mp added reviewers for D51276: tracing(7): Add hwt(4): bnovkov, br, zachary.leaf_arm.com.
Sat, Jul 12, 9:43 AM
0mp requested review of D51276: tracing(7): Add hwt(4).
Sat, Jul 12, 9:43 AM
0mp committed rG98a1084001d4: dtrace.1: Reference dwatch(1) and tracing(7) (authored by 0mp).
dtrace.1: Reference dwatch(1) and tracing(7)
Sat, Jul 12, 9:36 AM
0mp updated the diff for D51267: dtrace_dtrace.4: Document the DTrace dtrace provider.
  • Use SPDX
Sat, Jul 12, 9:27 AM · docs, DTrace
0mp updated the diff for D51268: d.7: Document the DTrace scripting language.

Finish the first draft.

Sat, Jul 12, 9:22 AM · docs, DTrace