- User Since
- Apr 1 2018, 2:39 PM (145 w, 5 d)
Thu, Jan 14
Wed, Jan 13
Tue, Jan 12
Mon, Jan 11
Sat, Jan 9
Note: if this runtime bug got into 2021Q1 then we should MFH. Let me know if that's the case.
Fri, Jan 8
OK form manpages.
Ach, that's what I thought. Thanks for linting the file.
My comments seem to be addressed at this point. Approved.
If you are sure that no dependencies changed (so distinfo is largely the same), then feel free to commit.
Thu, Jan 7
Note: please check bugzilla if there are any bugs or updates for this port. Perhaps we can close some problem reports.
See if the file produces sensible outputs now (dot -T png -o file.png committers-ports.dot).
It worked. That's very interesting... Anyway, thanks for the patch!
Very nice port, thanks a lot. Approved.
Wed, Jan 6
Thanks for the patch.
You've got my approval to commit, @nc!
Seems fine! Thanks a lot!
Tue, Jan 5
Just one last typo...
Two minor issues left. Otherwise, seems pretty solid! :)
As I mentioned in the other comment it would be great if you mention in the description of the patch / in the comments if you run a poudriere testport or an equivalent. This might help detect regressions like pkg-plist issues early on. It's also a sign for me that you've tested the update before the commit.
Thanks for testing the update so thoroughly! :) Approved!
the patch seems alright. Before I give you an approval to commit, could you let me know how did you test the port? That would give me an good overview of what has been tested so far.
I've run a poudriere testport on 12.2-RELEASE amd64 and it seems to work just fine.
Mon, Jan 4
I think that the doc: could be dropped. Also, (mentor) can be removed from the Reviewed by entry in my opinion. Otherwise, seems pretty nice!
Seems fine. Please, before you commit,
BTW, could you try to submit future patches with context? The easiest way is to configure arcanist (https://www.freshports.org/devel/arcanist/). It makes reviewing a bit easier. Thank you :)
Just a couple of minor errors. Otherwise, amazing job, Fernando!
Thu, Dec 31
Wed, Dec 30
Mon, Dec 28
Sun, Dec 27
Wed, Dec 23
Tue, Dec 22
A couple of mdoc suggestions. Otherwise, it seems fine!
Thu, Dec 17
- Use pid_t
- Use err() instead of perror