Page MenuHomeFreeBSD

0mp (Mateusz Piotrowski)
User

Projects (7)

User Details

User Since
Apr 1 2018, 2:39 PM (191 w, 3 d)

Recent Activity

Today

0mp added a reviewer for D33233: sync.8: Document that the "sync dance" is not a thing: imp.
Thu, Dec 2, 1:46 PM
0mp committed R10:156fbc648579: git hooks: Remove MFH (authored by 0mp).
git hooks: Remove MFH
Thu, Dec 2, 12:27 PM
0mp closed D29860: git hooks: Remove MFH.
Thu, Dec 2, 12:26 PM
0mp requested review of D33233: sync.8: Document that the "sync dance" is not a thing.
Thu, Dec 2, 12:12 PM
0mp requested review of D33232: style.mdoc: Prefer Ql to Dq Li for literal display.
Thu, Dec 2, 11:41 AM
0mp added a comment to D33201: security/p5-Crypt-JWT: Update to 0.034.

Great work with the MFH (MFC is for src)!

Thu, Dec 2, 11:02 AM
0mp added inline comments to D33168: gpart: add options to move the primary and secondary GPT partition tables.
Thu, Dec 2, 10:54 AM
0mp accepted D33200: devel/goreleaser: Update to 1.1.0.

Thank you!

Thu, Dec 2, 10:44 AM
0mp requested review of D33230: rc: Hook zfskeys to the build.
Thu, Dec 2, 9:20 AM

Mon, Nov 29

0mp accepted D33164: sysutils/bfs: Update to 2.3.
Mon, Nov 29, 4:34 PM
0mp committed R10:5d21348dfd95: rc.subr.8: Document changes to load_rc_config (authored by 0mp).
rc.subr.8: Document changes to load_rc_config
Mon, Nov 29, 3:10 PM
0mp committed R10:aa798fc2f17e: apic.4: Fix a typo (authored by 0mp).
apic.4: Fix a typo
Mon, Nov 29, 3:10 PM
0mp committed R11:fea4eb6bd661: graphics/nsxiv: Recalculate distinfo (authored by 0mp).
graphics/nsxiv: Recalculate distinfo
Mon, Nov 29, 12:56 PM
0mp committed R11:45adb0cd9578: converters/yj-bruceadams: Fix CONFLICTS_INSTALL (authored by 0mp).
converters/yj-bruceadams: Fix CONFLICTS_INSTALL
Mon, Nov 29, 12:55 PM
0mp committed R11:93401381ce04: graphics/nsxiv: Recalculate distinfo (authored by 0mp).
graphics/nsxiv: Recalculate distinfo
Mon, Nov 29, 12:55 PM
0mp accepted D33160: security/p5-openxpki*: General cleanup.

Thanks!

Mon, Nov 29, 11:31 AM

Sun, Nov 28

0mp added inline comments to D30184: boottrace: a simple boot and shutdown-time tracing facility.
Sun, Nov 28, 9:51 PM
0mp added inline comments to D31929: boottrace(1): small wrapper utility.
Sun, Nov 28, 9:24 PM
0mp accepted D19976: bhyve: Support a _VARS.fd file for bootrom.

Just one more issue with the manual page.

Sun, Nov 28, 7:50 PM
0mp accepted D33150: security/p5-openxpki-i18n: Update to 3.16.0.
Sun, Nov 28, 7:21 PM
0mp accepted D33137: net-mgmt/py-opn-cli: Update to 0.8.1.

Thanks!

Sun, Nov 28, 7:19 PM
0mp accepted D33149: security/p5-openxpki: Update to 3.16.0.
Sun, Nov 28, 7:19 PM
0mp added a comment to D33137: net-mgmt/py-opn-cli: Update to 0.8.1.

Base >= on setup.py upstream. Poudriere testport still looks good.

Sun, Nov 28, 5:59 PM
0mp requested changes to D19976: bhyve: Support a _VARS.fd file for bootrom.
Sun, Nov 28, 5:57 PM
0mp committed R10:2b890871f7d1: style.Makefile.5: Do not require $FreeBSD$ SCM IDs (authored by 0mp).
style.Makefile.5: Do not require $FreeBSD$ SCM IDs
Sun, Nov 28, 4:47 PM
0mp committed R10:900ca3c03a4e: style.Makefile.5: Do not require $FreeBSD$ SCM IDs (authored by 0mp).
style.Makefile.5: Do not require $FreeBSD$ SCM IDs
Sun, Nov 28, 4:47 PM
0mp committed R10:98ddcae346db: os-release.5: Fix quoting of dots (authored by 0mp).
os-release.5: Fix quoting of dots
Sun, Nov 28, 4:45 PM
0mp committed R10:8fff4d48d881: os-release.5: Fix quoting of dots (authored by 0mp).
os-release.5: Fix quoting of dots
Sun, Nov 28, 4:43 PM
0mp committed R11:cef379429ccb: ftp/curlie: Update to 1.6.7 (authored by 0mp).
ftp/curlie: Update to 1.6.7
Sun, Nov 28, 3:23 PM
0mp committed R11:25c51bf3c4d4: x11-fonts/iosevka: Update to 11.1.1 (authored by 0mp).
x11-fonts/iosevka: Update to 11.1.1
Sun, Nov 28, 3:17 PM

Sat, Nov 27

0mp committed R11:1867c6e684f9: */yj*: Add CONFLICTS_INSTALL (authored by 0mp).
*/yj*: Add CONFLICTS_INSTALL
Sat, Nov 27, 7:08 PM
0mp committed R11:7bdaf82dfdd2: converters/yj-bruceadams: Add new port (authored by 0mp).
converters/yj-bruceadams: Add new port
Sat, Nov 27, 7:08 PM
0mp accepted D33137: net-mgmt/py-opn-cli: Update to 0.8.1.

Assuming that the versions for RUN_DEPENDS come from the port's setup.py or an equivalent, I think that this change looks great.

Sat, Nov 27, 3:48 PM
0mp accepted D33135: devel/py-jsonpath-ng: New port.

Thanks!

Sat, Nov 27, 3:44 PM

Fri, Nov 26

0mp requested changes to D33135: devel/py-jsonpath-ng: New port.
Fri, Nov 26, 6:44 PM
0mp committed R11:06b23f86f362: textproc/write-good: Add a new port (authored by 0mp).
textproc/write-good: Add a new port
Fri, Nov 26, 6:37 PM

Thu, Nov 25

0mp added a comment to D33105: security/py-vpn-slice: Add NO_ARCH.
In D33105#748417, @0mp wrote:

Personally, I'd skip it. :)

^^ So to be clear: you would skip bumping PORTREVISION? Right? (like sunpoet's commit)

Thu, Nov 25, 9:24 PM
0mp added a comment to D33105: security/py-vpn-slice: Add NO_ARCH.

Personally, I'd skip it. :)

Thu, Nov 25, 3:50 PM
0mp committed R11:e35ce3b3a6b3: java/bouncycastle15: Install bcutil.jar and bcjmail.jar (authored by 0mp).
java/bouncycastle15: Install bcutil.jar and bcjmail.jar
Thu, Nov 25, 2:48 PM
0mp committed R11:a7d056709d46: java/bouncycastle15: Simplify install target for ZIPSRC (authored by 0mp).
java/bouncycastle15: Simplify install target for ZIPSRC
Thu, Nov 25, 2:48 PM
0mp committed R11:349163141848: java/bouncycastle15: Refresh pkg-descr and update license info (authored by 0mp).
java/bouncycastle15: Refresh pkg-descr and update license info
Thu, Nov 25, 2:48 PM
0mp committed R11:3f4897050843: java/bouncycastle15: Pet portfmt and portclippy (authored by 0mp).
java/bouncycastle15: Pet portfmt and portclippy
Thu, Nov 25, 2:48 PM
0mp committed R11:a1d339358646: security/vuxml: Mark java/bouncycastle as vulnerable where applicable (authored by 0mp).
security/vuxml: Mark java/bouncycastle as vulnerable where applicable
Thu, Nov 25, 1:55 AM
0mp committed R11:9e1bda400030: java/bouncycastle15: Make sure we don't miss jars with future updates (authored by 0mp).
java/bouncycastle15: Make sure we don't miss jars with future updates
Thu, Nov 25, 1:02 AM
0mp committed R11:f9cf7de02f43: java/bouncycastle15: Install bcutil.jar and bcjmail.jar (authored by 0mp).
java/bouncycastle15: Install bcutil.jar and bcjmail.jar
Thu, Nov 25, 1:02 AM
0mp committed R11:71a10a9b37b9: java/bouncycastle15: Simplify install target for ZIPSRC (authored by 0mp).
java/bouncycastle15: Simplify install target for ZIPSRC
Thu, Nov 25, 1:02 AM
0mp committed R11:e82d4ec5e029: java/bouncycastle15: Refresh pkg-descr and update license info (authored by 0mp).
java/bouncycastle15: Refresh pkg-descr and update license info
Thu, Nov 25, 1:02 AM
0mp committed R11:374e9ed352b3: java/bouncycastle15: Pet portfmt and portclippy (authored by 0mp).
java/bouncycastle15: Pet portfmt and portclippy
Thu, Nov 25, 1:02 AM

Wed, Nov 24

0mp accepted D33105: security/py-vpn-slice: Add NO_ARCH.

Just a note: sometimes people don't bump portrevision when adding NO_ARCH (e.g., https://github.com/freebsd/freebsd-ports/commit/8918d79d4efdaf2ed1ac659d51e77913f439da7f). The reason is that this is not an important change from the user perspective and perhaps it's not necessary to trigger a package rebuild. However, according to PHB, PORTREVISION must be bumped whenever the contents of the final package change AFAIR. When in doubt, ask fellow committers. As always, if you are unsure about some part of the change, note it in the commit message.

Wed, Nov 24, 10:25 PM
0mp accepted D33106: x11-wm/i3-gaps: Update to 4.20.1.

The change looks fine. We need the maintainer's approval to commit this update (or a maintainer timeout). Not everyone is checking phabricator notifications regularly, so it maybe a good idea to create a PR on bugzilla and point to this patch. Then the maintainer will get an email and if they don't respond in 2 weeks, you'll be able to proceed with the commit. In theory, if you know that the maintainer is responsive, then you can ask for an approval via a private email. Again, keep in mind that there is no other way to reach the "maintainer timeout" without a ticket on bugzilla.

Wed, Nov 24, 10:20 PM
0mp accepted D33090: Ports that depend on youtube-dl: Switch to yt-dlp.
Wed, Nov 24, 5:09 PM
0mp committed R10:cf1f1f91e914: top.1: Use the Dq macros instead of \*lq and \*rq (authored by 0mp).
top.1: Use the Dq macros instead of \*lq and \*rq
Wed, Nov 24, 4:14 PM
0mp committed R10:4614bc803462: top.1: Improve description of -m (authored by 0mp).
top.1: Improve description of -m
Wed, Nov 24, 4:14 PM
0mp committed R10:14454e662a6b: top.1: Fix a typo in description of H interactive command (authored by 0mp).
top.1: Fix a typo in description of H interactive command
Wed, Nov 24, 4:13 PM
0mp committed R10:a9bfcefbdb6b: top.1: Sort options alphabetically (authored by 0mp).
top.1: Sort options alphabetically
Wed, Nov 24, 4:13 PM
0mp committed R10:51f4d6a6bcf9: top.1: Use the Dq macros instead of \*lq and \*rq (authored by 0mp).
top.1: Use the Dq macros instead of \*lq and \*rq
Wed, Nov 24, 4:13 PM
0mp committed R10:745ffe0ee867: top.1: Improve description of -m (authored by 0mp).
top.1: Improve description of -m
Wed, Nov 24, 4:12 PM
0mp committed R10:5f3b6ce64f99: top.1: Fix a typo in description of H interactive command (authored by 0mp).
top.1: Fix a typo in description of H interactive command
Wed, Nov 24, 4:12 PM
0mp committed R10:cd66a1b1c8c5: top.1: Sort options alphabetically (authored by 0mp).
top.1: Sort options alphabetically
Wed, Nov 24, 4:12 PM
0mp committed R10:6d20d6e5d887: top: Sort flags in usage message (authored by 0mp).
top: Sort flags in usage message
Wed, Nov 24, 4:05 PM
0mp committed R10:615b3385c990: top: Sort flags in usage message (authored by 0mp).
top: Sort flags in usage message
Wed, Nov 24, 4:05 PM
0mp closed D33092: os-release: Quote variables as documented in the manual.
Wed, Nov 24, 3:31 PM
0mp added a comment to D33092: os-release: Quote variables as documented in the manual.

Thank you for the review! I committed the patch in https://cgit.freebsd.org/src/commit/?id=169e06fa7852810f4ced2cce7a3c14ca9443bf39.

Wed, Nov 24, 3:30 PM
0mp committed R10:169e06fa7852: os-release: Quote variables as documented in the manual (authored by 0mp).
os-release: Quote variables as documented in the manual
Wed, Nov 24, 3:29 PM
0mp added a comment to D33092: os-release: Quote variables as documented in the manual.
In D33092#747700, @imp wrote:

From the standard:

The application shall quote the following characters if they are to represent themselves:

& ; < > ( ) $ ` \ " ' <space> <tab> <newline>

and the following may need to be quoted under certain circumstances. That is, these characters may be special depending on conditions described elsewhere in this volume of POSIX.1-2017:

  • ? [ # ˜ = %

None of these are possible with the freebsd-version -u output. A number of other things break if people use 'custom' release names with spaces in them...
I'm OK with this change, but the need to do it seems quite low and edge-casey.

Wed, Nov 24, 3:01 PM
0mp added inline comments to D33074: security/py-vpn-slice: New port.
Wed, Nov 24, 2:56 PM

Tue, Nov 23

0mp committed R11:92872c9c50b3: x11-fonts/iosevka: Update to 11.1.0 (authored by 0mp).
x11-fonts/iosevka: Update to 11.1.0
Tue, Nov 23, 11:13 AM
0mp committed R10:ee7485bef53d: os-release.5: Fix quoting of dots (authored by 0mp).
os-release.5: Fix quoting of dots
Tue, Nov 23, 10:40 AM
0mp updated the summary of D33092: os-release: Quote variables as documented in the manual.
Tue, Nov 23, 10:30 AM
0mp requested review of D33092: os-release: Quote variables as documented in the manual.
Tue, Nov 23, 10:29 AM

Fri, Nov 19

0mp accepted D32171: devmatch: Allow devmatch_blocklist to be set in kenv too.

Just one minor nit. Otherwise looks nice.

Fri, Nov 19, 9:09 AM

Thu, Nov 18

0mp committed R10:1ac5586c6d86: style.Makefile.5: Do not require $FreeBSD$ SCM IDs (authored by 0mp).
style.Makefile.5: Do not require $FreeBSD$ SCM IDs
Thu, Nov 18, 9:04 PM
0mp committed R10:01e3140571ba: top.1: Use the Dq macros instead of \*lq and \*rq (authored by 0mp).
top.1: Use the Dq macros instead of \*lq and \*rq
Thu, Nov 18, 2:59 PM
0mp committed R10:c947fc5fae31: top.1: Improve description of -m (authored by 0mp).
top.1: Improve description of -m
Thu, Nov 18, 2:58 PM
0mp committed R10:82d0f865ee9a: top: Sort flags in usage message (authored by 0mp).
top: Sort flags in usage message
Thu, Nov 18, 2:58 PM
0mp committed R10:112539041590: top.1: Sort options alphabetically (authored by 0mp).
top.1: Sort options alphabetically
Thu, Nov 18, 2:58 PM
0mp committed R10:b8135ed67ce8: top.1: Fix a typo in description of H interactive command (authored by 0mp).
top.1: Fix a typo in description of H interactive command
Thu, Nov 18, 2:57 PM
0mp committed R10:c6d3831e5492: bsdinstall: Fix mirror selection (authored by 0mp).
bsdinstall: Fix mirror selection
Thu, Nov 18, 7:10 AM
0mp committed R10:05514f66684c: bsdinstall: Fix mirror selection (authored by 0mp).
bsdinstall: Fix mirror selection
Thu, Nov 18, 6:48 AM

Wed, Nov 17

0mp added a comment to D32463: rc.d/linux: Attempt to mount only if necessary.

I'll see to it when I have some time. If anyone wants to MFC that earlier than let me know or just commandeer it straight away.

Wed, Nov 17, 4:38 PM
0mp added a comment to D32985: New manual page for vmrun.sh.

Here is a new version based on all the feedback from everyone, keep the good comments coming please!

Wed, Nov 17, 4:35 PM · bhyve

Tue, Nov 16

0mp added a comment to D31929: boottrace(1): small wrapper utility.

It would be nice to have some sort of man page, even a short one to briefly describe the purpose of this utility.

Tue, Nov 16, 9:11 PM
0mp accepted D32997: add a nfs_server_maxio rc variable to set vfs.nfsd.srvmaxio.

Well, the change seems alright. Assuming that the default value for nfs_server_maxio makes sense and that sysctl vfs.nfsd.srvmaxio=${nfs_server_maxio} is useful for nfsd.

Tue, Nov 16, 8:08 PM
0mp accepted D32998: lang/mono6.8: Fix version in CONFLICTS_INSTALL.
Tue, Nov 16, 8:03 PM
0mp accepted D33000: net-p2p/lidarr: Switch to mono 6.8.

Hmm, if the maintainer says it helps the port to use a newer version of mono because of it having less bugs it's probably the way to go...

Tue, Nov 16, 8:01 PM
0mp committed R11:ea3c65d985a5: net/dictd: Do not mention net/dictd-database in pkg-message (authored by 0mp).
net/dictd: Do not mention net/dictd-database in pkg-message
Tue, Nov 16, 10:47 AM
0mp requested changes to D32976: Initial clean up the language in the manual pages..
Tue, Nov 16, 8:49 AM
0mp accepted D32996: net-mgmt/netdata-go: Update to v0.31.0.
Tue, Nov 16, 8:38 AM

Mon, Nov 15

0mp added a comment to D32997: add a nfs_server_maxio rc variable to set vfs.nfsd.srvmaxio.

It would be great to also document this variable in rc.conf.5.

Mon, Nov 15, 10:39 PM
0mp accepted D32998: lang/mono6.8: Fix version in CONFLICTS_INSTALL.
  1. If it changes the contents of the package and fixes some bug, then bumping PORTREVISION is needed.
  2. This port is maintained by mono@. Usually, it is necessary to get approval to modify ports maintained by someone else. In this case, however, I'd say it's fine to use Approved by: portmgr (blanket).
Mon, Nov 15, 10:30 PM
0mp accepted D33000: net-p2p/lidarr: Switch to mono 6.8.

In terms of maintainer approval, is it typically the e-mail address or the full or first name that is used in the "Approved by"?

Mon, Nov 15, 10:25 PM
0mp committed R11:e33e8a2421fc: sysutils/terraform: Update to 1.0.11 (authored by 0mp).
sysutils/terraform: Update to 1.0.11
Mon, Nov 15, 10:44 AM
0mp requested changes to D32985: New manual page for vmrun.sh.

That's definitely a nice addition. Thanks for working on that.

Mon, Nov 15, 10:07 AM · bhyve

Sun, Nov 14

0mp accepted D32987: ps(1): Add '&' flag for linux(4) processes.

The manual page change seems fine. Please remember to bump the date when committing.

Sun, Nov 14, 6:01 PM
0mp added a reviewer for D32985: New manual page for vmrun.sh: 0mp.
Sun, Nov 14, 4:44 PM · bhyve

Sat, Nov 13

0mp added a comment to D32463: rc.d/linux: Attempt to mount only if necessary.

BTW, should we MFC this?

Sat, Nov 13, 3:20 PM
0mp committed R10:5690261858b6: rc.d/linux: Attempt to mount only if necessary (authored by 0mp).
rc.d/linux: Attempt to mount only if necessary
Sat, Nov 13, 3:17 PM
0mp closed D32463: rc.d/linux: Attempt to mount only if necessary.
Sat, Nov 13, 3:17 PM
0mp added a comment to D32463: rc.d/linux: Attempt to mount only if necessary.

There is a somewhat related issue in https://reviews.freebsd.org/D26240. Do you think you could fix it as well, by throwing in an mkdir(1) somewhere in linux_mount?

Sat, Nov 13, 3:11 PM

Fri, Nov 12

0mp requested changes to D32976: Initial clean up the language in the manual pages..
Fri, Nov 12, 11:05 PM