- User Since
- Apr 1 2018, 2:39 PM (295 w, 5 d)
Thu, Nov 30
Tue, Nov 28
Wed, Nov 22
It seems like the commit message should contain "Reported by". The reference to "the original patch" is a bit unclear as well. It took me a moment to figure out that this is pointing at the patch from the PR.
LGTM. The tests look good and the new logic of handling fdlock mode is also OK. I only have some feedback regarding documentation and error messages.