It would be good to ask on the -ports mailing list about some extra review. Installing software via Python virtual environments is unprecedented in the ports tree I think. Or at least not well established. That is why additional review would be beneficial.

BTW, did you develop this patch yourself or is it someone's work from the PR?

One more question before we land it :)

Seems good to go! Thank you

Looks solid and the maintainer has approved the change. Ship it!

Cool, thanks for the updates. Let's wait for @joneum.

Note: security/sudo: Remove dependency on security/sssd is not a bad title either.

Otherwise, the commit looks good. Ping me again for the final review when you get the approval of the maintainer (or a timeout).

Suggestions for the commit message:

Thank you, kiwi@! The patch is ready to land.

Could you update the commit message as noted here?

Please make sure to add PR: 283364 to the commit message.

Regarding the commit message:

I've got some suggestions for the commit message:

Regarding the commit message, I'd suggest something along the lines of:

Notes:

• There is no need to mention in the commit message that the patch has been tested with poudriere. It's still a very valuable comment to add to the description on Bugzilla or Phabricator :)

LGTM, let's wait for the maintainers before committing.

Could you add the whole, final commit message to the description here on Phab? I'd like to make sure you don't miss anything (please include Approved by: 0mp (mentor) but do not push the change upstream yet).

The change looks pretty good.

I've left a question in a comment but it's not blocking. I'm just curious :)

Thank you all for feedback! :)

• Add UPDATING entry
• Fix typos in rc.subr.8 and do some extra wordsmithing there

Considering that git-arc is now more portable thanks to the patches by @jlduran_gmail.com, I'm closing this revision. If we decide to start quoting variables in git-arc for the sake of defensive programming, we should review the whole file instead of just the echo cases.

I'm closing this revision as I landed @jlduran_gmail.com's patches instead:

I'll commit it soon.

In D47274#1077940, @jlduran_gmail.com wrote:

Thank you for making this tool more portable. This is a cousin commit of D46781 and D46767. I agree, echo (without -n is portable) and IMO, more readable than printf, because there is no need to add a new line at the end. The issue is only with echo -n.

I've got some reports from the NetBSD community that setting rc_fast_and_loose on NetBSD booting on vax simh makes rc finish in 109 seconds instead of 183 seconds (https://mastodon.sdf.org/@mrgtwentythree/113364676304360235).

In D26484#1004695, @unitrunker_gmail.com wrote:

This question terrifies me to even ask.

Are there rc scripts that make use of "breadcrumbs"? By breadcrumb, I mean an earlier script sets a variable that a later script uses.

In D47264#1077729, @markj wrote:

Approved.

This probably deserves an entry in UPDATING as well as the relnotes tag, since it breaks backward compatibility and applies to those who track main as well as release users.

Update docs and remove an unused boottrace function

Reviewed by: samba (0mp)

Thanks!

I'll set MFC to 2 weeks so that it does not land in 14.2.

Set exit status by calling exit in a subshell.

I opened a PR for investigating the rc_fast_and_loose support: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282255

The patch seems OK. Also, the release notes do not mention any breaking changes.

I opened a PR on Bugzilla for the community to have an easier way tracking this update: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282254

Check all invocations.

In D46862#1076197, @gshapiro wrote:

This is an improvement over the current functionality, but I think we would want all invocations to be checked. I wonder if it would be better to separate these into separate rc scripts instead of using one for four possible different daemons. That shouldn't prevent this change from going forward while alternatives are formulated.

If the port builds, I see no reason to prevent this updated from landing.