User Details
- User Since
- Jan 29 2022, 5:50 PM (250 w, 2 d)
Wed, Nov 11
Wed, Nov 4
Tue, Nov 3
The way random_source_read_t interface is laid out is really unfortunate, I'm not sure why it doesn't take a device_t argument.
Mon, Nov 2
I'll land this tomorrow if there are no additional objections.
LGTM, I'll test and land this tomorrow, provided there are no further objections.
Wed, Oct 21
Address @kib's comments
Mon, Oct 19
LGTM.
In the future please upload the diff with full context and please don't remove the group reviewers automatically added by the system.
Oct 16 2026
Oct 15 2026
Oct 12 2026
Oct 10 2026
I agree, by using hart IDs we've internalized an SBI implementation detail which is not ideal.
LGTM, one minor comment aside.
Oct 6 2026
Could you please rebase the patch to a recent main? I can't cleanly apply the patch for testing.
Oct 2 2026
LGTM, one minor inline comment aside.
LGTM (one minor suggestion inline), I'll wait for @jhb 's comments before accepting.
Sep 29 2026
Generally LGTM, two nits aside. I'll test this a bit more in the coming days and land it if nothing obvious pops up.
Sep 27 2026
Sep 23 2026
LGTM (just the sdiff.c bits).
Sep 22 2026
Sep 21 2026
Sep 20 2026
Sep 19 2026
LGTM, I'll give the patch a spin tomorrow before landing it. Have you tested this change somehow already?
One minor comment, LGTM otherwise.
Sep 18 2026
Sep 17 2026
Address @markj's comments
Sep 16 2026
Sep 15 2026
Thank you for working on this, this is a useful feature.
Aside from the inline comments, I have one remark regarding config_schema_merge_options.
Hoist 'splitnum' check
Sep 14 2026
Sep 11 2026
Sep 10 2026
Looks good now, thanks! I only have one minor inline comment.
Sep 9 2026
Thanks, LGTM now. I won't be able to test the patch series on a non- SiFive FU74 board until EuroBSDCon finishes, I'll let you know if anything comes up during testing.
Aug 31 2026
Aug 28 2026
Propagate error from bounds checking instead of aborting
Aug 27 2026
Aug 25 2026
Address @kp 's comments
Aug 23 2026
This is a good feature, but I don't think that this is the correct approach design-wise. Adding an ioctl handler to just to fetch a VM's PID is overkill IMO, new ioctl commands should only be added when there's no other way to obtain the needed information (e.g., fetching memsegs and other metadata that is stored in the vmm module).
