User Details
- User Since
- Jan 29 2022, 5:50 PM (116 w, 6 d)
Wed, Apr 10
Mon, Apr 8
As promised, I've removed some redundant bits from the patch, it should be a bit clearer now.
Regenerate and simplify patch.
Sun, Apr 7
Thu, Apr 4
Address @markj 's comments and fix a couple of issues:
- Certain kstack KVA chunks were released back to the parent arena with improper alignment, causing vmem_xfree to panic
Wed, Apr 3
Sorry for the delay, @markj reported a panic when booting this patch on a NUMA machine and it took me a while to set up a NUMA environment and properly fix the issue.
Update patch to track and properly release kstacks to domain arenas, address @kib 's comments.
Tue, Apr 2
You're right, the primary goal was to have a way of faking NUMA topologies in a guest for kernel testing purposes. I did consider the second goal but ultimately decided to focus on the "fake" bits first and implement the rest in a separate patch.
I'll rework the patch so that it covers both goals.
It also appears to assume that each domain can be described with a single PA range, and I don't really understand why vmm needs to know the CPU affinity of each domain.
I'm not that happy about directly specifying PA ranges directly. The only other thing I could think of is to let the user specify the amount of memory per-domain and let bhyve deal with PA ranges, do you think that this is a more sane approach?
As for the CPU affinities, these are needed for SRAT but that can be done purely from userspace. I've kept them in vmm in case we might want to get NUMA topology info using bhyvectl, but I guess that information can be obtained from the guest itself. I'll remove the cpusets.
Sat, Mar 30
Fri, Mar 29
Thu, Mar 28
Mar 22 2024
Address @kib 's comments.
Mar 21 2024
Remove commented lines.
Mar 15 2024
Apologies for the delayed response.
@markj and I will go through the patch once more during next week, so it should get commited soon.
Feb 19 2024
Committed in R9:607c4b857a65b68289e9d7f86a8855def93c09f0.
Feb 18 2024
Feb 3 2024
Address @kib 's comments.
Jan 26 2024
Jan 6 2024
Aside from the issue @markj pointed out, LGTM.
Dec 12 2023
Address @jhb 's comments.
Nov 30 2023
Address @jhb 's comments.
Nov 29 2023
Address @markj 's comments:
- multiline comment style fixes
- use old mapping scheme on 32-bit systems
Nov 27 2023
Address @alc 's comments.
Nov 13 2023
Upload diff with full context.
Nov 8 2023
Nov 7 2023
Rebased the patch.
Oct 30 2023
Address @corvink 's comments.
Address @corvink 's comments.
Oct 26 2023
Oct 19 2023
Oct 12 2023
Oct 11 2023
Fix formatting for multiline comment in teken_utf8_bytes_to_codepoint.
Address @christos 's comments.
- Add more detailed explanation of the use of __builtin_clz
Other fixes:
- Codepoint calculation for two-byte sequences was missing one bit in the mask used for the leading character, fixed now
- ttydisc_rubchar now falls back to non-UTF8 behaviour if teken_wcwidth returns an error
Oct 10 2023
Oct 7 2023
I've updated the manpages for stty and termios and moved IUTF8 behind __BSD_VISIBLE.
Oct 6 2023
Quick update: I've tested the patch with different numbers of kstack guard pages (1-4) and encountered no issues.
Each run consisted of running the test suite and a rebuild of the whole kernel.
I have, there are no duplicates for 1-4 guard pages.
I also think that duplicates are mathematically impossible in this case, since this function is bijective for each value in its domain.
Its domain, however is not contiguous.
I've whipped up a quick graph for the first few kvas {F68913014}.
Oct 5 2023
Address @christos 's comments - properly handle zero width characters.
Oct 3 2023
Oct 1 2023
@markj I tried the new mlock superpage test case, the patch didn't cause a panic.
I've updated the diff to work with an arbitrary number of guard pages but I didn't have time to test this with different guard page configurations - I'll do this in the coming days and report back.
The formula has been slightly reworked to account for the direction of stack growth (+ 1 to the result of lin_pindex(kva) / kstack_size and different condition for detecting guard pages).
Sep 27 2023
Address @alc 's comments.
Sep 22 2023
Sep 20 2023
Address @alc 's comments.