Differential D44739

arm64/vmm: Add breakpoint and single-stepping support
ClosedPublic
Actions

Authored by markj on Apr 10 2024, 4:07 PM.

Tags

None

Referenced Files

	F168001249: D44739.id136866.diff
	Tue, Aug 25, 8:47 PM

	F167911285: D44739.id.diff
	Tue, Aug 25, 9:44 AM

	Unknown Object (File)
	Tue, Aug 25, 1:06 AM

	Unknown Object (File)
	Fri, Aug 14, 10:42 AM

	Unknown Object (File)
	Wed, Aug 12, 11:57 PM

	Unknown Object (File)
	Wed, Aug 12, 9:49 PM

	Unknown Object (File)
	Tue, Aug 11, 6:16 PM

	Unknown Object (File)
	Tue, Aug 11, 1:57 PM

Subscribers

Details

Reviewers

jhb
andrew
manu
bnovkov

Commits

rG75cb949228bb: arm64/vmm: Add breakpoint and single-stepping support

Summary

This will be used to implement parts of bhyve's gdb stub.

Sponsored by: Innovate UK

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Apr 10 2024, 4:07 PM

Herald added a reviewer: manu. · View Herald TranscriptApr 10 2024, 4:07 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

Harbormaster completed remote builds in B57029: Diff 136866.Apr 10 2024, 4:07 PM

markj requested review of this revision.Apr 10 2024, 4:07 PM

markj added a child revision: D44740: bhyve: Add arm64 support to the gdb stub.

Use a bitmask to record which capabilities are enabled. This is closer to what amd64 does.
Disable hardware interrupts when enabling single-stepping. Otherwise we take a timer interrupt before single-stepping the target and don't make progress.

Harbormaster completed remote builds in B57714: Diff 138574.May 15 2024, 3:21 PM

bnovkov added a subscriber: bnovkov.May 25 2024, 9:20 PM

Looks good!

This revision is now accepted and ready to land.May 25 2024, 9:48 PM

andrew accepted this revision.Jun 4 2024, 9:30 AM

Closed by commit rG75cb949228bb: arm64/vmm: Add breakpoint and single-stepping support (authored by markj). · Explain WhyJun 4 2024, 8:07 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG75cb949228bb: arm64/vmm: Add breakpoint and single-stepping support.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

include/

6 lines

vmm/

9 lines

79 lines

2 lines

2 lines

Diff 139469

sys/arm64/include/vmm.h

Loading...

sys/arm64/vmm/arm64.h

Loading...

sys/arm64/vmm/vmm_arm64.c

Loading...

sys/arm64/vmm/vmm_stat.h

Loading...

sys/arm64/vmm/vmm_stat.c

Loading...