Page MenuHomeFreeBSD

sarah.walker2_arm.com (Sarah Walker)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 14 2025, 3:07 PM (17 w, 6 d)

Recent Activity

Yesterday

sarah.walker2_arm.com updated the diff for D54959: virtio: Use bus_dma for ring and indirect buffer allocations.

Remove superfluous mb() calls.

Mon, Feb 16, 3:36 PM
sarah.walker2_arm.com updated the diff for D54960: virtio_blk: Use bus_dma for command/ack buffer allocations.

Fix DMAT used for vbr_hdr.

Mon, Feb 16, 3:28 PM
sarah.walker2_arm.com updated the diff for D54960: virtio_blk: Use bus_dma for command/ack buffer allocations.

Fix DMAT used for vbr_ack

Mon, Feb 16, 2:35 PM

Tue, Feb 10

sarah.walker2_arm.com updated the diff for D55051: arm64: Add MOPS implementations of memset(), memcpy() and memmove().

KASAN fixes.

Tue, Feb 10, 9:58 AM

Mon, Feb 9

sarah.walker2_arm.com updated the diff for D54947: arm64: Add MOPS implementations of copyin/copyout.

Remove mops_supported.

Mon, Feb 9, 11:52 AM
sarah.walker2_arm.com updated the diff for D54946: arm64: Add MOPS implementation of pagezero().

Remove mops_supported.

Mon, Feb 9, 11:52 AM
sarah.walker2_arm.com updated the diff for D55051: arm64: Add MOPS implementations of memset(), memcpy() and memmove().

Remove mops_supported.

Mon, Feb 9, 11:52 AM
sarah.walker2_arm.com updated the diff for D54943: arm64: Enable MOPS usage in the kernel.

Remove mops_supported.

Mon, Feb 9, 11:52 AM

Mon, Feb 2

sarah.walker2_arm.com added a comment to D54943: arm64: Enable MOPS usage in the kernel.

Can you split out enabling MOPS & using it into separate changes? There is a risk one of the mem*_early changes is missing & it would be easier to revert a change to add them rather than everything that depends on MOPS.

Mon, Feb 2, 10:02 AM
sarah.walker2_arm.com requested review of D55051: arm64: Add MOPS implementations of memset(), memcpy() and memmove().
Mon, Feb 2, 10:02 AM
sarah.walker2_arm.com updated the diff for D54947: arm64: Add MOPS implementations of copyin/copyout.

Address review comments.

Mon, Feb 2, 10:01 AM
sarah.walker2_arm.com updated the diff for D54946: arm64: Add MOPS implementation of pagezero().

Address review comments.

Mon, Feb 2, 10:01 AM
sarah.walker2_arm.com updated the diff for D54943: arm64: Enable MOPS usage in the kernel.

Split into two changes.

Mon, Feb 2, 10:01 AM

Fri, Jan 30

sarah.walker2_arm.com updated the diff for D54947: arm64: Add MOPS implementations of copyin/copyout.

Address review comments.

Fri, Jan 30, 12:27 PM
sarah.walker2_arm.com updated the diff for D54946: arm64: Add MOPS implementation of pagezero().

Address review comments.

Fri, Jan 30, 12:26 PM
sarah.walker2_arm.com requested review of D54960: virtio_blk: Use bus_dma for command/ack buffer allocations.
Fri, Jan 30, 11:14 AM
sarah.walker2_arm.com requested review of D54959: virtio: Use bus_dma for ring and indirect buffer allocations.
Fri, Jan 30, 11:14 AM

Thu, Jan 29

sarah.walker2_arm.com requested review of D54947: arm64: Add MOPS implementations of copyin/copyout.
Thu, Jan 29, 6:26 PM
sarah.walker2_arm.com requested review of D54946: arm64: Add MOPS implementation of pagezero().
Thu, Jan 29, 6:25 PM
sarah.walker2_arm.com updated the diff for D54943: arm64: Enable MOPS usage in the kernel.

Handle kernel MOE exceptions.

Thu, Jan 29, 6:14 PM
sarah.walker2_arm.com requested review of D54943: arm64: Enable MOPS usage in the kernel.
Thu, Jan 29, 3:47 PM

Wed, Jan 21

sarah.walker2_arm.com added a comment to D54560: libc/aarch64: Use MOPS implementations of memcpy/memmove/memset where availble.
In D54560#1252311, @fuz wrote:

Please document these changes in share/man/man7/simd.7 as requested earlier. Add a new key (say M) for "MOPS" and perhaps explain what that is.

Wed, Jan 21, 3:32 PM
sarah.walker2_arm.com requested review of D54812: simd.7: Add Arm MOPS memcpy(), memmove() and memset() to manpage.
Wed, Jan 21, 3:32 PM

Jan 14 2026

sarah.walker2_arm.com updated the diff for D54560: libc/aarch64: Use MOPS implementations of memcpy/memmove/memset where availble.

Add missing license information to resolver files.

Jan 14 2026, 12:49 AM
sarah.walker2_arm.com updated the diff for D54560: libc/aarch64: Use MOPS implementations of memcpy/memmove/memset where availble.

Add license info to memmove_resolver.c

Jan 14 2026, 12:49 AM

Jan 12 2026

sarah.walker2_arm.com updated the diff for D54598: arm64: Provide ifunc HWCAP structure definitions.

Indentation fixes.

Jan 12 2026, 2:32 PM
sarah.walker2_arm.com updated the diff for D54599: libc/csu: Pass HWCAP flags to ifunc resolver functions.

Make ifunc_arg argument const.

Jan 12 2026, 9:43 AM
sarah.walker2_arm.com updated the diff for D54559: rtld-elf: Pass HWCAP flags to ifunc resolver functions.

Move ifunc_arg from private namespace and fix const-ness.

Jan 12 2026, 9:43 AM
sarah.walker2_arm.com updated the diff for D54598: arm64: Provide ifunc HWCAP structure definitions.

Make ifunc_arg argument const.

Jan 12 2026, 9:42 AM

Jan 9 2026

sarah.walker2_arm.com added a comment to D54560: libc/aarch64: Use MOPS implementations of memcpy/memmove/memset where availble.
In D54560#1247986, @fuz wrote:

This doesn't build for me:

lib/libc/aarch64/string/memcpy_resolver.c:11:6: error: use of undeclared identifier 'ifunc_arg'
   11 |         if (ifunc_arg->_hwcap2 & HWCAP2_MOPS)
      |             ^
1 error generated.
*** Error code 1
Jan 9 2026, 4:57 PM
sarah.walker2_arm.com updated the diff for D54559: rtld-elf: Pass HWCAP flags to ifunc resolver functions.

Fix indentation issues.

Jan 9 2026, 4:19 PM
sarah.walker2_arm.com updated the diff for D54560: libc/aarch64: Use MOPS implementations of memcpy/memmove/memset where availble.

Address review comments. Rework ifunc resolvers to remove ARCHLEVEL leftovers.

Jan 9 2026, 4:11 PM
sarah.walker2_arm.com updated the diff for D54599: libc/csu: Pass HWCAP flags to ifunc resolver functions.

Address style issues.

Jan 9 2026, 4:05 PM
sarah.walker2_arm.com updated the diff for D54559: rtld-elf: Pass HWCAP flags to ifunc resolver functions.

Address style issues.

Jan 9 2026, 4:03 PM
sarah.walker2_arm.com updated the diff for D54598: arm64: Provide ifunc HWCAP structure definitions.

Address review comments.

Jan 9 2026, 4:03 PM
sarah.walker2_arm.com updated the diff for D54558: arm64: Enable MOPS in userspace.

Address review comments.

Jan 9 2026, 4:03 PM

Jan 8 2026

sarah.walker2_arm.com added inline comments to D54598: arm64: Provide ifunc HWCAP structure definitions.
Jan 8 2026, 4:28 PM
sarah.walker2_arm.com added a comment to D54559: rtld-elf: Pass HWCAP flags to ifunc resolver functions.

Will you also be implementing this for csu for static binaries (often forgotten, including by me in the past)?

Jan 8 2026, 12:06 PM
sarah.walker2_arm.com updated the diff for D54559: rtld-elf: Pass HWCAP flags to ifunc resolver functions.

Address review comments.

Jan 8 2026, 11:57 AM
sarah.walker2_arm.com added a comment to D54559: rtld-elf: Pass HWCAP flags to ifunc resolver functions.

There should be a followup change to sys/arm64/include/ifunc.h to update DEFINE_UIFUNC. We can also use this to simplify the ifunc handlers in sys/crypto/sha2/sha512c.c and sys/crypto/sha2/sha256c.c

Can you give more detail on what you want here please?

ifunc.h has the DEFINE_UIFUNC macro where the first two arguments in the generated function signature will need an update. The other two files use DEFINE_UIFUNC and call elf_aux_info to read the HWCAPs, but could be updated after this change (and a similar change for static binaries)

Jan 8 2026, 10:56 AM
sarah.walker2_arm.com requested review of D54600: crypto: Update sha256 and sha512 ifuncs to use passed HWCAP flags.
Jan 8 2026, 10:54 AM
sarah.walker2_arm.com updated the diff for D54560: libc/aarch64: Use MOPS implementations of memcpy/memmove/memset where availble.

Address review comments.

Jan 8 2026, 10:53 AM
sarah.walker2_arm.com requested review of D54599: libc/csu: Pass HWCAP flags to ifunc resolver functions.
Jan 8 2026, 10:52 AM
sarah.walker2_arm.com updated the diff for D54559: rtld-elf: Pass HWCAP flags to ifunc resolver functions.

Address review comments.

Jan 8 2026, 10:52 AM
sarah.walker2_arm.com requested review of D54598: arm64: Provide ifunc HWCAP structure definitions.
Jan 8 2026, 10:51 AM
sarah.walker2_arm.com updated the diff for D54558: arm64: Enable MOPS in userspace.

Address review comments.

Jan 8 2026, 10:51 AM
sarah.walker2_arm.com updated the diff for D54558: arm64: Enable MOPS in userspace.

Address review comments. Update SHA IFUNC usage.

Jan 8 2026, 10:50 AM

Jan 6 2026

sarah.walker2_arm.com added a comment to D54559: rtld-elf: Pass HWCAP flags to ifunc resolver functions.

There should be a followup change to sys/arm64/include/ifunc.h to update DEFINE_UIFUNC. We can also use this to simplify the ifunc handlers in sys/crypto/sha2/sha512c.c and sys/crypto/sha2/sha256c.c

Jan 6 2026, 4:29 PM
sarah.walker2_arm.com requested review of D54560: libc/aarch64: Use MOPS implementations of memcpy/memmove/memset where availble.
Jan 6 2026, 3:41 PM
sarah.walker2_arm.com requested review of D54559: rtld-elf: Pass HWCAP flags to ifunc resolver functions.
Jan 6 2026, 3:41 PM
sarah.walker2_arm.com requested review of D54558: arm64: Enable MOPS in userspace.
Jan 6 2026, 3:41 PM

Nov 19 2025

sarah.walker2_arm.com updated the diff for D53738: arm64: Add Arm SPE thread mode support.

Fix spe_info indexing in threading mode

Nov 19 2025, 11:58 AM
sarah.walker2_arm.com added inline comments to D53738: arm64: Add Arm SPE thread mode support.
Nov 19 2025, 11:43 AM
sarah.walker2_arm.com added inline comments to D53738: arm64: Add Arm SPE thread mode support.
Nov 19 2025, 11:24 AM
sarah.walker2_arm.com updated the diff for D53738: arm64: Add Arm SPE thread mode support.

Address review comments

Nov 19 2025, 11:20 AM

Nov 18 2025

sarah.walker2_arm.com added a comment to D53738: arm64: Add Arm SPE thread mode support.

How does the buffering work in threading mode on SMP? It looks like there is still a per-CPU buffer for SPE to write to where I would expect it to be per-thread. e.g. If userspace maps the CPU0 buffer, then the thread migrates to CPU1 would userspace still get SPE data?

Nov 18 2025, 12:11 PM

Nov 13 2025

sarah.walker2_arm.com requested review of D53738: arm64: Add Arm SPE thread mode support.
Nov 13 2025, 3:31 PM

Nov 5 2025

sarah.walker2_arm.com updated the diff for D46241: HWT: Arm Statistical Profiling Extension (SPE) support.

Remove dead code

Nov 5 2025, 2:15 PM
sarah.walker2_arm.com updated the diff for D46241: HWT: Arm Statistical Profiling Extension (SPE) support.

Address style issues

Nov 5 2025, 12:00 PM

Oct 24 2025

sarah.walker2_arm.com updated the diff for D46241: HWT: Arm Statistical Profiling Extension (SPE) support.

Fix off-by-one error with CPU_FFS()

Oct 24 2025, 1:02 PM

Oct 21 2025

sarah.walker2_arm.com updated the diff for D46241: HWT: Arm Statistical Profiling Extension (SPE) support.

Rebase & address review comments

Oct 21 2025, 3:57 PM
sarah.walker2_arm.com commandeered D46241: HWT: Arm Statistical Profiling Extension (SPE) support.
Oct 21 2025, 3:46 PM

Oct 16 2025

sarah.walker2_arm.com updated the diff for D53112: arm64: Move BP hardening and SSBD workaround to CPU_FEAT framework.

Address review comments

Oct 16 2025, 2:22 PM

Oct 15 2025

sarah.walker2_arm.com requested review of D53112: arm64: Move BP hardening and SSBD workaround to CPU_FEAT framework.
Oct 15 2025, 12:35 PM