Page MenuHomeFreeBSD
Differential D44739

arm64/vmm: Add breakpoint and single-stepping support
ClosedPublic
Actions

Authored by markj on Apr 10 2024, 4:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 12, 1:50 PM
Unknown Object (File)
Mon, Oct 12, 1:49 PM
Unknown Object (File)
Mon, Oct 12, 1:47 PM
Unknown Object (File)
Mon, Oct 12, 1:31 PM
Unknown Object (File)
Sun, Oct 4, 9:48 PM
Unknown Object (File)
Sun, Oct 4, 9:47 PM
Unknown Object (File)
Sun, Oct 4, 9:44 PM
Unknown Object (File)
Sun, Oct 4, 3:50 PM
View All Files
Subscribers
bnovkov
emaste
imp

Details

Reviewers
jhb
andrew
manu
bnovkov
Commits
rG75cb949228bb: arm64/vmm: Add breakpoint and single-stepping support
Summary

This will be used to implement parts of bhyve's gdb stub.

Sponsored by: Innovate UK

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57714
Build 54602: arc lint + arc unit

Event Timeline

markj created this revision.Apr 10 2024, 4:07 PM
Herald added a reviewer: manu. · View Herald TranscriptApr 10 2024, 4:07 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
Harbormaster completed remote builds in B57029: Diff 136866.Apr 10 2024, 4:07 PM
markj requested review of this revision.Apr 10 2024, 4:07 PM
markj added a child revision: D44740: bhyve: Add arm64 support to the gdb stub.
markj updated this revision to Diff 138574.May 15 2024, 3:21 PM
  • Use a bitmask to record which capabilities are enabled. This is closer to what amd64 does.
  • Disable hardware interrupts when enabling single-stepping. Otherwise we take a timer interrupt before single-stepping the target and don't make progress.
Harbormaster completed remote builds in B57714: Diff 138574.May 15 2024, 3:21 PM
bnovkov added a subscriber: bnovkov.May 25 2024, 9:20 PM
bnovkov accepted this revision.May 25 2024, 9:48 PM

Looks good!

This revision is now accepted and ready to land.May 25 2024, 9:48 PM
andrew accepted this revision.Jun 4 2024, 9:30 AM
Closed by commit rG75cb949228bb: arm64/vmm: Add breakpoint and single-stepping support (authored by markj). · Explain WhyJun 4 2024, 8:07 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG75cb949228bb: arm64/vmm: Add breakpoint and single-stepping support.

Revision Contents
Changeset List

PathSize
sys/
arm64/
include/
6 lines
vmm/
9 lines
79 lines
2 lines
2 lines

Diff 138574

View Options

sys/arm64/include/vmm.h

Loading...
View Options

sys/arm64/vmm/arm64.h

Loading...
View Options

sys/arm64/vmm/vmm_arm64.c

Loading...
View Options

sys/arm64/vmm/vmm_stat.h

Loading...
View Options

sys/arm64/vmm/vmm_stat.c

Loading...