Thu, Feb 21
Thanks for the feedback! Will work on this shortly, travel and work have kept me busy.
Mon, Feb 18
Thu, Feb 14
Wed, Feb 13
Thanks for the patch. After you resubmit, I'd like to try it on the Clearfog board as well.
Fri, Feb 8
Added some comments.
Keep up the good work :)
Thu, Feb 7
I also have these changes up on Github at: https://github.com/freebsd/freebsd/compare/master...theasylum:fix/e6000sw-fdt if it is easier to review there due to more context. I did re-create the diff as requested by @manu with -U999, so hopefully that helps.
Updated to match style(9) thanks to @dteske's comment.
Try to get ahold of mw@ and loos@ to review
Tue, Feb 5
Mon, Feb 4
Thu, Jan 31
Wed, Jan 30
Dec 12 2018
Dec 8 2018
Dec 7 2018
Dec 5 2018
markj: Regarding the question on pxm prefix. I used the convention starting with the filename. I kind of settled for acpi_pxm since I could not think of a better filename and prefix (which covers SRAT for resource affinity and SLIT for locality).
Dec 4 2018
markj: please see the inline comment, and let me know if think there is further changes needed. Thanks.
Dec 3 2018
This mostly LGTM, a couple of nits inline.
Dec 1 2018
Nov 30 2018
Nov 29 2018
There is also problem with the pinctrl (I have this mostly worked out now).
I2C doesn't work (doesn't know why for now).
Some clocks IDs aren't correct.
I honestly don't know how this was tested.
Nov 28 2018
Only ppll is in pmucru.. you mean it has different rates?
This doesn't work.
The PLL in the pmucru are wait different.
Currently building world for my rockpro64, will test and commit after.
Nov 23 2018
Nov 19 2018
Addressed comments from jhb's review:
- fixed comment stye & reworded as suggested.
- removed 'id' field until it is needed (in a later patch)
Nov 16 2018
Thanks for the review, will update the diff with the changes (and a fix related use of max).
Nov 15 2018
Nov 14 2018
looks good to me. thanks.