Page MenuHomeFreeBSD

ray (Aleksandr Rybalko)
User

Projects (6)

User Details

User Since
May 12 2014, 10:17 AM (437 w, 5 d)

Recent Activity

Dec 19 2021

ray added a comment to D32316: Support of optional PMC classes..

@ray I assume you can go ahead with committing this one?

Dec 19 2021, 3:27 PM · pmc
ray added a comment to D32335: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page..
In D32335#747099, @gbe wrote:

Could you ran 'mandoc -Tlint' over the man page. There are plenty of warnings, which could easily be fixed, like 'new sentence, new line' and so on. It would be nice if you could also add the author of the man page.

And you have to include this man page in the makefile of the directory.

Dec 19 2021, 3:20 PM
ray updated the diff for D32335: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page..

Fix formating according to mandoc lint hints.

Dec 19 2021, 3:18 PM
ray added a comment to D32669: Add pmc.dmc-620(3) man page..

Fixed. Thanks for review!

Dec 19 2021, 12:44 PM
ray updated the diff for D32669: Add pmc.dmc-620(3) man page..

Review fixes.

Dec 19 2021, 12:41 PM
ray added a comment to D32670: The Arm CoreLink DMC-620 Dynamic Memory Controller PMU driver.

All fixed. Thanks for review, Mitchell!

Dec 19 2021, 12:01 PM
ray updated the diff for D32670: The Arm CoreLink DMC-620 Dynamic Memory Controller PMU driver.

style(9) changes.

Dec 19 2021, 11:57 AM

Nov 23 2021

ray added a comment to D32670: The Arm CoreLink DMC-620 Dynamic Memory Controller PMU driver.

Oh yes, and one question. Should sys/dev/hwpmc/pmu_dmc620.c be located elsewhere, similar to sys/arm64/arm64/cmn600.c? To me, it does not seem to belong in the hwpmc sub-directory.

Nov 23 2021, 5:15 PM

Nov 11 2021

ray accepted D32905: Add ETHER_ALIGN support to ng_device(4)..
Nov 11 2021, 8:47 AM

Oct 28 2021

ray updated the diff for D32670: The Arm CoreLink DMC-620 Dynamic Memory Controller PMU driver.

Cleanup.

Oct 28 2021, 10:45 PM
ray updated the diff for D32670: The Arm CoreLink DMC-620 Dynamic Memory Controller PMU driver.

Remove debug leftover.

Oct 28 2021, 10:41 PM
ray added a reviewer for D32670: The Arm CoreLink DMC-620 Dynamic Memory Controller PMU driver: pmc.
Oct 28 2021, 10:37 PM
ray added inline comments to D32321: Add support of ARM CMN-600 controller, PMU access functions only. Add support of PMU counters of ARM CMN-600 controller..
Oct 28 2021, 10:35 PM
ray added inline comments to D32321: Add support of ARM CMN-600 controller, PMU access functions only. Add support of PMU counters of ARM CMN-600 controller..
Oct 28 2021, 10:29 PM
ray updated the diff for D32321: Add support of ARM CMN-600 controller, PMU access functions only. Add support of PMU counters of ARM CMN-600 controller..

Done comments.

Oct 28 2021, 10:25 PM

Oct 27 2021

ray added a comment to D32316: Support of optional PMC classes..

It seems to me that only the changes to pmc_arm64_initialize() should be necessary, because it handles optional classes in the same way that pmc_intel_initialize() does, by passing the correct nclasses value to pmc_mdep_alloc().

Oct 27 2021, 3:12 PM · pmc

Oct 26 2021

ray updated the diff for D32316: Support of optional PMC classes..

Update classes base ri to handle optional classes out of order.

Oct 26 2021, 1:01 PM · pmc
ray retitled D32670: The Arm CoreLink DMC-620 Dynamic Memory Controller PMU driver from the Arm CoreLink DMC-620 Dynamic Memory Controller PMU driver to The Arm CoreLink DMC-620 Dynamic Memory Controller PMU driver.
Oct 26 2021, 12:57 PM
ray requested review of D32670: The Arm CoreLink DMC-620 Dynamic Memory Controller PMU driver.
Oct 26 2021, 12:55 PM
ray requested review of D32669: Add pmc.dmc-620(3) man page..
Oct 26 2021, 12:52 PM

Oct 6 2021

ray added reviewers for D32335: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page.: emaste, andrew.
Oct 6 2021, 12:35 PM
ray added reviewers for D32319: System wide and NUMA domain wide counters support. PMC classes for ARM DMC-620 and CMN-600.: emaste, andrew.
Oct 6 2021, 12:33 PM
ray added reviewers for D32316: Support of optional PMC classes.: emaste, andrew.
Oct 6 2021, 12:33 PM · pmc
ray updated the summary of D32335: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page..
Oct 6 2021, 11:37 AM
ray requested review of D32335: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page..
Oct 6 2021, 9:28 AM

Oct 5 2021

ray updated the summary of D32321: Add support of ARM CMN-600 controller, PMU access functions only. Add support of PMU counters of ARM CMN-600 controller..
Oct 5 2021, 3:12 PM
ray requested review of D32321: Add support of ARM CMN-600 controller, PMU access functions only. Add support of PMU counters of ARM CMN-600 controller..
Oct 5 2021, 3:11 PM
ray updated the summary of D32320: Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by DMC-620 and CMN-600 controllers PMU..
Oct 5 2021, 3:06 PM
ray requested review of D32320: Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by DMC-620 and CMN-600 controllers PMU..
Oct 5 2021, 3:04 PM
ray updated the summary of D32319: System wide and NUMA domain wide counters support. PMC classes for ARM DMC-620 and CMN-600..
Oct 5 2021, 2:52 PM
ray requested review of D32319: System wide and NUMA domain wide counters support. PMC classes for ARM DMC-620 and CMN-600..
Oct 5 2021, 2:51 PM
ray abandoned D32317: o Add support for system wide and NUMA domain wide counters support. o Add 3 new PMC classes for ARM DMC-620 and CMN-600 controllers PMU..
Oct 5 2021, 2:25 PM
ray retitled D32316: Support of optional PMC classes. from Support of optional classes. to Support of optional PMC classes..
Oct 5 2021, 2:23 PM · pmc
ray requested review of D32317: o Add support for system wide and NUMA domain wide counters support. o Add 3 new PMC classes for ARM DMC-620 and CMN-600 controllers PMU..
Oct 5 2021, 2:09 PM
ray requested review of D32316: Support of optional PMC classes..
Oct 5 2021, 2:08 PM · pmc

Aug 17 2021

ray accepted D31387: hwpmc: consistently validate PMC class in allocation method.
Aug 17 2021, 11:21 AM

Aug 2 2021

ray committed rGaed2afeb51e4: Ignore ResourceProducer flag for: (authored by ray).
Ignore ResourceProducer flag for:
Aug 2 2021, 11:12 AM

Jul 21 2021

ray accepted D31221: Fix various issues with commit 28dd6730a5d6, 8cc3815f02be.
Jul 21 2021, 1:02 AM

Jun 23 2021

ray accepted D30602: hwpmc_arm64: accept raw event codes for PMC_OP_PMCALLOCATE.
Jun 23 2021, 9:28 PM
ray accepted D30603: libpmc: enable pmu_utils on arm64.
Jun 23 2021, 9:28 PM

Jun 2 2021

ray accepted D30603: libpmc: enable pmu_utils on arm64.
Jun 2 2021, 8:10 AM
ray added inline comments to D30602: hwpmc_arm64: accept raw event codes for PMC_OP_PMCALLOCATE.
Jun 2 2021, 8:08 AM

May 28 2021

ray accepted D30527: libpmc: fix Intel "instructions" alias.
May 28 2021, 10:39 PM
ray accepted D30531: libpmc: always generate libpmc_events.c.
May 28 2021, 10:37 PM
ray accepted D30526: pmccontrol: improve -L with pmu-events.
May 28 2021, 10:33 PM
ray accepted D30532: libpmc: make libpmc_pmu_utils.c more amenable to porting.

LGTM
Thanks!

May 28 2021, 10:31 PM

May 11 2021

ray accepted D30196: libpmc: remove PMC_MDEP_TABLE logic.

I like it.
Thanks!

May 11 2021, 9:34 AM
ray accepted D30195: libpmc: remove unused PMC_MDEP_INIT_INTEL_V2.

LGTM
Thanks!

May 11 2021, 9:14 AM

May 5 2021

ray updated the diff for D30047: hwpmc: Move 4 bits of mode to extend class size to 8..

Squash commits.

May 5 2021, 2:57 PM · pmc
ray updated the diff for D30047: hwpmc: Move 4 bits of mode to extend class size to 8..

Fix comment.

May 5 2021, 2:51 PM · pmc
ray added inline comments to D30047: hwpmc: Move 4 bits of mode to extend class size to 8..
May 5 2021, 2:43 PM · pmc
ray added a comment to D30047: hwpmc: Move 4 bits of mode to extend class size to 8..

This looks fine to me, thanks for fixing this.

It seems that pmc_id_t should be an opaque type for consumers of libpmc? I.e. the only userspace consumer of these bit macros should be libpmc itself.

If that is the case, then this change should be okay without a PMC_VERSION bump. There are no uses of PMC_ID_TO_MODE or PMC_ID_MAKE_ID in libpmc. However, I did not check if this was true for older releases.

May 5 2021, 2:43 PM · pmc

May 3 2021

ray added a reviewer for D30047: hwpmc: Move 4 bits of mode to extend class size to 8.: pmc.
May 3 2021, 11:48 AM · pmc
ray added a member for pmc: ray.
May 3 2021, 11:47 AM

Apr 30 2021

ray updated the summary of D30047: hwpmc: Move 4 bits of mode to extend class size to 8..
Apr 30 2021, 3:00 PM · pmc
ray requested review of D30047: hwpmc: Move 4 bits of mode to extend class size to 8..
Apr 30 2021, 2:57 PM · pmc

Apr 7 2021

ray accepted D29600: arm64: Fix finding the pmc event ID.

Looks fine.
Thanks!

Apr 7 2021, 1:11 PM

Nov 7 2020

ray accepted D27110: vt: fix window switching w.r.t. cngrab/cnungrab.

Looks good to me.
Thanks!

Nov 7 2020, 12:37 PM

Dec 25 2019

ray committed rS356083: MFC r352878:.
MFC r352878:
Dec 25 2019, 10:19 PM
ray committed rS356082: MFC r352875:.
MFC r352875:
Dec 25 2019, 10:07 PM
ray added inline comments to D22891: Add support for i2c bus mux hardware..
Dec 25 2019, 11:22 AM

Dec 1 2019

ray accepted D22618: RT2880 and RT3883 gigabit ethernet interface support.

Looks good to me. Thanks.

Dec 1 2019, 7:10 PM

Nov 13 2019

ray accepted D22352: armv6-soft build fixed.

Thanks, Hiroki san!

Nov 13 2019, 10:11 PM

Oct 1 2019

ray updated the diff for D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..

Handle PCI_RES_BUS special way.

Oct 1 2019, 10:36 AM
ray added a comment to D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..

While working on a separate change (GitHub/bsdjhb/freebsd/tree/bus_map_resource_more) I remembered more of why PCI_RES_BUS is special. It's presence indicates to MI code (e.g. sys/dev/pci/pci_pci.c) that the MD host-PCI bridge drivers support managing bus numbers and so bus ranges should be allocated via bus_alloc_resource(). After the bus_map_resource_more branch lands, it will be possible to rework the one gross hack in pci_pci.c (where it calls bus_activate_resource to "map" child resources but asking the parent to do so) and then NEW_PCIB will be able to be turned on by default for all archs. However, the PCI_RES_BUS bits still need to be conditional to platforms that support PCI_RES_BUS. This is generally managed in the host-PCI bridge drivers rather than in the nexus. So in practice the '#ifdef NEW_PCIB' in the new header is in fact wrong. The real test is something more complex like this:

#if ((defined(i386) || defined(amd64)) && defined(NEW_PCIB)
#define PCI_RES_BUS 5
#endif

Except you need more convoluted expressions to handle other architectures. For x86 the rules is that bus numbers are only supported in host-PCI bridge drivers if NEW_PCIB is defined. It seems that only riscv, powerpc, and sparc64 don't already define PCI_RES_BUS, so perhaps a negative architecture list is shorter than a positive one.

Oct 1 2019, 10:35 AM

Sep 29 2019

ray committed rS352878: Initialize baseaddr to suppres warning..
Initialize baseaddr to suppres warning.
Sep 29 2019, 11:47 PM
ray closed D21827: Put sections into expected offset in binary format..
Sep 29 2019, 10:34 PM
ray committed rS352875: ections into expected offset in binary format..
ections into expected offset in binary format.
Sep 29 2019, 10:34 PM
ray added inline comments to D21827: Put sections into expected offset in binary format..
Sep 29 2019, 9:25 PM
ray updated the diff for D21827: Put sections into expected offset in binary format..

Rename base to baseoff. Fix comment.

Sep 29 2019, 9:17 PM

Sep 28 2019

ray updated the summary of D21827: Put sections into expected offset in binary format..
Sep 28 2019, 7:55 AM
ray added a comment to D21827: Put sections into expected offset in binary format..

Can you show the readelf -S output for the input file where this change matters? The change looks ok to me, but I do not understand why it is useful.

Sep 28 2019, 1:42 AM

Sep 27 2019

ray added inline comments to D21827: Put sections into expected offset in binary format..
Sep 27 2019, 11:23 PM
ray added inline comments to D21827: Put sections into expected offset in binary format..
Sep 27 2019, 10:21 PM
ray updated the summary of D21827: Put sections into expected offset in binary format..
Sep 27 2019, 10:11 PM
ray created D21827: Put sections into expected offset in binary format..
Sep 27 2019, 10:09 PM
ray added a comment to D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..
In D21703#476461, @jhb wrote:

Some places use whether or not PCI_RES_BUS is defined to decide if they should handle PCI bus numbers. BTW, I called it PCI_RES_BUS instead of SYS_RES_* because it isn't a bus-independent "system" resource (like memory or I/O ports or DMA channels), but instead is specific to a PCI bus (and in a multi-segment/domain system you would have duplicates even).

Sep 27 2019, 7:47 PM

Sep 26 2019

ray added a comment to D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..
In D21703#475791, @kib wrote:
In D21703#475705, @ray wrote:

Return back #ifdef NEW_PCIB, @jhb not sure it is safe to omit.

Can you explain why ?

Sep 26 2019, 6:11 AM

Sep 25 2019

ray added a reviewer for D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR.: nwhitehorn.
Sep 25 2019, 10:36 PM
ray updated the diff for D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..

Return back #ifdef NEW_PCIB, @jhb not sure it is safe to omit.

Sep 25 2019, 9:17 PM
ray accepted D21789: snd_hda: Add Intel Cannon Lake support.

Nice, that it works.

Sep 25 2019, 7:01 PM · multimedia
ray abandoned D21742: Align .data segment with DATA_SEGMENT_ALIGN(0x1000, 0x1000) instead ofALIGN(0x1000) + (. & (0x1000 - 1))..

It is wrong way to fix elfcopy bug.
Thanks to @strejda for pointing that.

Sep 25 2019, 12:40 PM

Sep 21 2019

ray retitled D21742: Align .data segment with DATA_SEGMENT_ALIGN(0x1000, 0x1000) instead ofALIGN(0x1000) + (. & (0x1000 - 1)). from Align .data segment with DATA_SEGMENT_ALIGN(0x1000, 0x1000) instead of ALIGN(0x1000) + (. & (0x1000 - 1)). to Align .data segment with DATA_SEGMENT_ALIGN(0x1000, 0x1000) instead ofALIGN(0x1000) + (. & (0x1000 - 1))..
Sep 21 2019, 9:10 PM
ray created D21742: Align .data segment with DATA_SEGMENT_ALIGN(0x1000, 0x1000) instead ofALIGN(0x1000) + (. & (0x1000 - 1))..
Sep 21 2019, 9:09 PM

Sep 19 2019

ray added a comment to D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..
In D21703#473617, @kib wrote:

This looks fine to me, but I have no idea why John put PCI_RES_BUS under #ifdef NEW_PCIB instead of defining it always.

I will wait for @jhb input about that. But everything I found PCI_RES_BUS were checked together w/ NEW_PCIB. And I didn't found any place where defined PCI_RES_BUS can break anything.

Sep 19 2019, 7:16 AM
ray added inline comments to D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..
Sep 19 2019, 7:07 AM
ray updated the diff for D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..

o Do not copyright "empty files"
o Give old owner (i386) old number (PCI_RES_BUS to 5)

Sep 19 2019, 7:02 AM

Sep 18 2019

ray accepted D21704: vt: fix problems with trying to switch to a closed VT.

Looks good. Thanks.

Sep 18 2019, 7:08 PM
ray retitled D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR. from o Unify all <machine>/resource.h and unhide PCI_RES_BUS. to o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..
Sep 18 2019, 10:45 AM
ray created D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..
Sep 18 2019, 10:43 AM

Sep 17 2019

ray committed rS352442: MFC r351649 Check for region dups..
MFC r351649 Check for region dups.
Sep 17 2019, 11:21 AM

Sep 11 2019

ray accepted D21604: [Bug 240473] add support of Ralink RT5390R Wireless Card.
Sep 11 2019, 10:29 AM

Sep 7 2019

ray added a comment to D21478: Automatic dependency tracking for FDT/OFW..

I have pretty mixed feelings about this approach. It only works for ofwbus children, not simplebus children, and canonicalizes a bunch of behaviors that I don't believe are standards (I'm in an airport departure lounge and don't have the spec handy). I'm also not really sure how it interacts with multipass etc. Could you elaborate a little more on the mechanism?

Sep 7 2019, 8:41 AM

Sep 4 2019

ray added reviewers for D21478: Automatic dependency tracking for FDT/OFW.: ARM, arm64, MIPS, PowerPC.
Sep 4 2019, 9:49 PM
ray added a member for Src Committers: ray.
Sep 4 2019, 9:06 PM
ray added a member for MIPS: ray.
Sep 4 2019, 9:05 PM
ray added a member for arm64: ray.
Sep 4 2019, 9:05 PM
ray added a member for ARM: ray.
Sep 4 2019, 9:04 PM
ray accepted D21328: [jail] removal by jid doesn't trigger pre/post stop scripts.

Like it. Thanks!

Sep 4 2019, 8:45 PM
ray committed rS351827: MFC r351213: assert that td_lk_slocks is not leaked upon return from kernel.
MFC r351213: assert that td_lk_slocks is not leaked upon return from kernel
Sep 4 2019, 7:33 PM