Page MenuHomeFreeBSD

ray (Aleksandr Rybalko)
User

Projects

User Details

User Since
May 12 2014, 10:17 AM (283 w, 5 d)

Recent Activity

Tue, Oct 1

ray updated the diff for D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..

Handle PCI_RES_BUS special way.

Tue, Oct 1, 10:36 AM
ray added a comment to D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..

While working on a separate change (GitHub/bsdjhb/freebsd/tree/bus_map_resource_more) I remembered more of why PCI_RES_BUS is special. It's presence indicates to MI code (e.g. sys/dev/pci/pci_pci.c) that the MD host-PCI bridge drivers support managing bus numbers and so bus ranges should be allocated via bus_alloc_resource(). After the bus_map_resource_more branch lands, it will be possible to rework the one gross hack in pci_pci.c (where it calls bus_activate_resource to "map" child resources but asking the parent to do so) and then NEW_PCIB will be able to be turned on by default for all archs. However, the PCI_RES_BUS bits still need to be conditional to platforms that support PCI_RES_BUS. This is generally managed in the host-PCI bridge drivers rather than in the nexus. So in practice the '#ifdef NEW_PCIB' in the new header is in fact wrong. The real test is something more complex like this:
#if ((defined(i386) || defined(amd64)) && defined(NEW_PCIB)
#define PCI_RES_BUS 5
#endif
Except you need more convoluted expressions to handle other architectures. For x86 the rules is that bus numbers are only supported in host-PCI bridge drivers if NEW_PCIB is defined. It seems that only riscv, powerpc, and sparc64 don't already define PCI_RES_BUS, so perhaps a negative architecture list is shorter than a positive one.

Tue, Oct 1, 10:35 AM

Sun, Sep 29

ray committed rS352878: Initialize baseaddr to suppres warning..
Initialize baseaddr to suppres warning.
Sun, Sep 29, 11:47 PM
ray closed D21827: Put sections into expected offset in binary format..
Sun, Sep 29, 10:34 PM
ray committed rS352875: ections into expected offset in binary format..
ections into expected offset in binary format.
Sun, Sep 29, 10:34 PM
ray added inline comments to D21827: Put sections into expected offset in binary format..
Sun, Sep 29, 9:25 PM
ray updated the diff for D21827: Put sections into expected offset in binary format..

Rename base to baseoff. Fix comment.

Sun, Sep 29, 9:17 PM

Sat, Sep 28

ray updated the summary of D21827: Put sections into expected offset in binary format..
Sat, Sep 28, 7:55 AM
ray added a comment to D21827: Put sections into expected offset in binary format..

Can you show the readelf -S output for the input file where this change matters? The change looks ok to me, but I do not understand why it is useful.

Sat, Sep 28, 1:42 AM

Fri, Sep 27

ray added inline comments to D21827: Put sections into expected offset in binary format..
Fri, Sep 27, 11:23 PM
ray added inline comments to D21827: Put sections into expected offset in binary format..
Fri, Sep 27, 10:21 PM
ray updated the summary of D21827: Put sections into expected offset in binary format..
Fri, Sep 27, 10:11 PM
ray created D21827: Put sections into expected offset in binary format..
Fri, Sep 27, 10:09 PM
ray added a comment to D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..
In D21703#476461, @jhb wrote:

Some places use whether or not PCI_RES_BUS is defined to decide if they should handle PCI bus numbers. BTW, I called it PCI_RES_BUS instead of SYS_RES_* because it isn't a bus-independent "system" resource (like memory or I/O ports or DMA channels), but instead is specific to a PCI bus (and in a multi-segment/domain system you would have duplicates even).

Fri, Sep 27, 7:47 PM

Thu, Sep 26

ray added a comment to D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..
In D21703#475791, @kib wrote:
In D21703#475705, @ray wrote:

Return back #ifdef NEW_PCIB, @jhb not sure it is safe to omit.

Can you explain why ?

Thu, Sep 26, 6:11 AM

Wed, Sep 25

ray added a reviewer for D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR.: nwhitehorn.
Wed, Sep 25, 10:36 PM
ray updated the diff for D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..

Return back #ifdef NEW_PCIB, @jhb not sure it is safe to omit.

Wed, Sep 25, 9:17 PM
ray accepted D21789: snd_hda: Add Intel Cannon Lake support.

Nice, that it works.

Wed, Sep 25, 7:01 PM · multimedia
ray abandoned D21742: Align .data segment with DATA_SEGMENT_ALIGN(0x1000, 0x1000) instead ofALIGN(0x1000) + (. & (0x1000 - 1))..

It is wrong way to fix elfcopy bug.
Thanks to @strejda for pointing that.

Wed, Sep 25, 12:40 PM

Sat, Sep 21

ray retitled D21742: Align .data segment with DATA_SEGMENT_ALIGN(0x1000, 0x1000) instead ofALIGN(0x1000) + (. & (0x1000 - 1)). from Align .data segment with DATA_SEGMENT_ALIGN(0x1000, 0x1000) instead of ALIGN(0x1000) + (. & (0x1000 - 1)). to Align .data segment with DATA_SEGMENT_ALIGN(0x1000, 0x1000) instead ofALIGN(0x1000) + (. & (0x1000 - 1))..
Sat, Sep 21, 9:10 PM
ray created D21742: Align .data segment with DATA_SEGMENT_ALIGN(0x1000, 0x1000) instead ofALIGN(0x1000) + (. & (0x1000 - 1))..
Sat, Sep 21, 9:09 PM

Sep 19 2019

ray added a comment to D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..
In D21703#473617, @kib wrote:

This looks fine to me, but I have no idea why John put PCI_RES_BUS under #ifdef NEW_PCIB instead of defining it always.

I will wait for @jhb input about that. But everything I found PCI_RES_BUS were checked together w/ NEW_PCIB. And I didn't found any place where defined PCI_RES_BUS can break anything.

Sep 19 2019, 7:16 AM
ray added inline comments to D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..
Sep 19 2019, 7:07 AM
ray updated the diff for D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..

o Do not copyright "empty files"
o Give old owner (i386) old number (PCI_RES_BUS to 5)

Sep 19 2019, 7:02 AM

Sep 18 2019

ray accepted D21704: vt: fix problems with trying to switch to a closed VT.

Looks good. Thanks.

Sep 18 2019, 7:08 PM
ray retitled D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR. from o Unify all <machine>/resource.h and unhide PCI_RES_BUS. to o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..
Sep 18 2019, 10:45 AM
ray created D21703: o Unify all <machine>/resource.h, unhide PCI_RES_BUS, add CLK and PWR..
Sep 18 2019, 10:43 AM

Sep 17 2019

ray committed rS352442: MFC r351649 Check for region dups..
MFC r351649 Check for region dups.
Sep 17 2019, 11:21 AM

Sep 11 2019

ray accepted D21604: [Bug 240473] add support of Ralink RT5390R Wireless Card.
Sep 11 2019, 10:29 AM

Sep 7 2019

ray added a comment to D21478: Automatic dependency tracking for FDT/OFW..

I have pretty mixed feelings about this approach. It only works for ofwbus children, not simplebus children, and canonicalizes a bunch of behaviors that I don't believe are standards (I'm in an airport departure lounge and don't have the spec handy). I'm also not really sure how it interacts with multipass etc. Could you elaborate a little more on the mechanism?

Sep 7 2019, 8:41 AM

Sep 4 2019

ray added reviewers for D21478: Automatic dependency tracking for FDT/OFW.: ARM, arm64, MIPS, PowerPC.
Sep 4 2019, 9:49 PM
ray added a member for Src Committers: ray.
Sep 4 2019, 9:06 PM
ray added a member for MIPS: ray.
Sep 4 2019, 9:05 PM
ray added a member for arm64: ray.
Sep 4 2019, 9:05 PM
ray added a member for ARM: ray.
Sep 4 2019, 9:04 PM
ray accepted D21328: [jail] removal by jid doesn't trigger pre/post stop scripts.

Like it. Thanks!

Sep 4 2019, 8:45 PM
ray committed rS351827: MFC r351213: assert that td_lk_slocks is not leaked upon return from kernel.
MFC r351213: assert that td_lk_slocks is not leaked upon return from kernel
Sep 4 2019, 7:33 PM
ray committed rS351826: MFC r351213: assert that td_lk_slocks is not leaked upon return from kernel.
MFC r351213: assert that td_lk_slocks is not leaked upon return from kernel
Sep 4 2019, 7:31 PM

Aug 31 2019

ray committed rS351649: ARM kernel can get RAM regions three ways:.
ARM kernel can get RAM regions three ways:
Aug 31 2019, 9:28 PM

Aug 30 2019

ray added a comment to D21478: Automatic dependency tracking for FDT/OFW..

s/Firware/Firmware/

Aug 30 2019, 11:09 PM
ray added a reviewer for D21478: Automatic dependency tracking for FDT/OFW.: manu.
Aug 30 2019, 11:01 PM
ray updated the summary of D21478: Automatic dependency tracking for FDT/OFW..
Aug 30 2019, 10:54 PM
ray created D21478: Automatic dependency tracking for FDT/OFW..
Aug 30 2019, 10:47 PM

Aug 21 2019

ray added a comment to D15229: Allow run-time delayed attachment of devices.

Nice to have feature, to allow to wait for required drivers to attach.

Aug 21 2019, 10:21 PM

Aug 16 2019

ray committed rS351133: Check paddr for overflow..
Check paddr for overflow.
Aug 16 2019, 7:27 PM
ray closed D21272: Fix 'lock "vm reserv" already initialized' panic..
Aug 16 2019, 7:27 PM
ray added a comment to D21272: Fix 'lock "vm reserv" already initialized' panic..

Check paddr for overflow.

Aug 16 2019, 11:38 AM
ray added a comment to D21272: Fix 'lock "vm reserv" already initialized' panic..

Check paddr for overflow.

Aug 16 2019, 11:24 AM
ray added a comment to D21272: Fix 'lock "vm reserv" already initialized' panic..
In D21272#462874, @kib wrote:

Can't we simply test paddr < rounddown2(seg->end, VM_LEVEL_0_SIZE)?

Is seg->end 0xffffffff or 0 for the problematic case ?

No, it is 0xfff00000. But problem with paddr, which is 32bits and paddr + 0x100000 will be 0x00000000.
It satisfy check:
0xffe00000 <= 0xfff00000 - true
0xfff00000 <= 0xfff00000 - true
0x00000000 <= 0xfff00000 - true

Aug 16 2019, 10:11 AM

Aug 15 2019

ray added a comment to D21272: Fix 'lock "vm reserv" already initialized' panic..

Or even (intmax_t), for this code not to make problems 10-20 years later :)

Aug 15 2019, 7:13 PM
ray added a comment to D21272: Fix 'lock "vm reserv" already initialized' panic..

What about that version? :)

Aug 15 2019, 6:50 PM
ray added a comment to D21272: Fix 'lock "vm reserv" already initialized' panic..

Simplify patch.

Aug 15 2019, 6:50 PM
ray added a comment to D21272: Fix 'lock "vm reserv" already initialized' panic..
In D21272#462545, @ray wrote:

Don't we then have the same problem if seg->end < VM_LEVEL_0_SIZE?

only if you want to add some really small seg at 0x00000000 :)

Why does it have to be at 0x00000000? With the segment below we will test 0x100000 <= 0x9d000 - 0x100000, and the variables are unsigned.

SEGMENT 0:  
start:     0x10000                 
end:       0x9d000
domain:    0                       
free list: 0xffffffff81233cb0
Aug 15 2019, 3:21 PM
ray added a comment to D21272: Fix 'lock "vm reserv" already initialized' panic..

Don't we then have the same problem if seg->end < VM_LEVEL_0_SIZE?

Aug 15 2019, 3:02 PM
ray added inline comments to D21272: Fix 'lock "vm reserv" already initialized' panic..
Aug 15 2019, 2:32 PM
D21272: Fix 'lock "vm reserv" already initialized' panic. now requires review to proceed.

Remove extra parentheses.

Aug 15 2019, 2:31 PM
ray updated subscribers of D21272: Fix 'lock "vm reserv" already initialized' panic..

Add Michal, to have one more test.

Aug 15 2019, 1:39 PM
ray created D21272: Fix 'lock "vm reserv" already initialized' panic..
Aug 15 2019, 1:32 PM

Mar 20 2019

ray accepted D19535: Support device-independent labels for geom_flashmap slices..
Mar 20 2019, 10:06 PM

Feb 23 2019

ray accepted D19266: Modularize xz..
Feb 23 2019, 10:48 PM

Feb 21 2019

ray accepted D19266: Modularize xz..
Feb 21 2019, 2:46 PM

Feb 20 2019

ray accepted D19266: Modularize xz..

Thanks!

Feb 20 2019, 1:27 PM
ray added a comment to D19266: Modularize xz..
In D19266#412263, @kib wrote:
In D19266#412252, @ray wrote:

Looks fine!
Cosmetic: why not to name it just "xz" instead of "xz_embedded"?

Both module, module build directory, and linker file are named xz. What part name don't you like ?

Feb 20 2019, 12:28 PM
ray accepted D19266: Modularize xz..

Looks fine!
Cosmetic: why not to name it just "xz" instead of "xz_embedded"?

Feb 20 2019, 10:56 AM

Aug 17 2018

ray accepted D14290: gpiospi no delay support.
Aug 17 2018, 2:14 PM

Jun 21 2018

ray accepted D15940: subr_hints: simplify a little bit.

Looks good.
Thank you!

Jun 21 2018, 6:48 AM

Dec 27 2017

ray accepted D13645: Make vt(4) palette configurable.

Looks cute :)

Dec 27 2017, 8:47 AM

Dec 5 2017

ray accepted D13331: Allow custom overrides of mmap attribute for VT framebuffer.
Dec 5 2017, 11:06 PM
ray accepted D13332: Use unsigned intptr_t type for framebuffer addresses.

Correct. Thank you!

Dec 5 2017, 11:03 PM

Aug 4 2017

ray added a comment to D11866: Allow vt_timer() callout to run during mountroot input loop in vt(4).

Sorry, I don't feel myself enough knowledgeable to give sane answer here :)

Aug 4 2017, 6:46 PM

Aug 2 2017

ray accepted D11814: Implement "vidcontrol -h <history_size>" for vt(4).

Looks good. Thanks.

Aug 2 2017, 9:32 AM

Jul 28 2017

ray accepted D11753: Implement "vidcontrol -c <normal|blink|destructive>" for vt(4).

style(9) issues still here (but in different functions), but there is a lot from very first vt project release.

Jul 28 2017, 11:03 PM

Feb 22 2017

ray accepted D9709: Fix locking on the vt driver's data structures..

Looks good. Thank you, Jonathan!

Feb 22 2017, 7:14 AM

Feb 10 2017

ray committed rS313547: o Reset mouse selection when new lines reach selection lines..
o Reset mouse selection when new lines reach selection lines.
Feb 10 2017, 1:28 PM

Dec 13 2016

ray accepted D8749: Delete gpio flags because of not support device. This is same as gpioiic. Add spi clock low delay. Reformat message. ar5315_spi.c spibus minor number fix..
Dec 13 2016, 8:08 AM
ray added a comment to D8749: Delete gpio flags because of not support device. This is same as gpioiic. Add spi clock low delay. Reformat message. ar5315_spi.c spibus minor number fix..

Thanks a lot, guys!

Dec 13 2016, 8:07 AM

Dec 11 2016

ray added a comment to D8749: Delete gpio flags because of not support device. This is same as gpioiic. Add spi clock low delay. Reformat message. ar5315_spi.c spibus minor number fix..

gpiobus_pin_setflags() in gpibus.c have check gpio_check_flags(). This code check pin capabirity. If low driver not support GPIO_PIN_PULLUP/GPIO_PIN_PULLDOWN return EINVAL.

Dec 11 2016, 11:00 PM
ray added inline comments to D8749: Delete gpio flags because of not support device. This is same as gpioiic. Add spi clock low delay. Reformat message. ar5315_spi.c spibus minor number fix..
Dec 11 2016, 8:32 PM

Sep 29 2016

ray accepted D8064: Allow framebuffer driver control memory mapping type for mmap(2) call.

Cool! Thank you Oleksandr!

Sep 29 2016, 6:45 AM

Sep 4 2016

ray accepted D7781: [BHND/USB] Port of EHCI/OHCI support from ZRouter.
Sep 4 2016, 9:21 PM

Jun 23 2016

ray accepted D6907: [MIPS/DDB] (fix) backtrace: incorrect MIPS32 reg values & truncated backtrace on MipsKernGenException inside short function.

Now, looks fine.

Jun 23 2016, 10:17 PM

Jun 10 2016

ray requested changes to D6796: Add RTL8366SR support at etherswitch driver.
Jun 10 2016, 6:53 AM

May 27 2016

ray accepted D6513: [nvram2env] split implementation into generic & MIPS-based code.

Now, looks fine.

May 27 2016, 8:50 AM
ray added a comment to D5674: [dev/cfi] add support for flashes with different bus-vs-device address width.

I'm afraid JEDEC CFI standard do not allow simple omit of upper byte(s), you have to try bus and chip data width and get temporary configuration, til required data read from chip.

May 27 2016, 6:55 AM

May 23 2016

ray added a comment to D6513: [nvram2env] split implementation into generic & MIPS-based code.

Only one comment left.

May 23 2016, 10:31 PM

Apr 6 2016

ray accepted D5864: Update if_rt to support more SoCs via both FDT and non-FDT.

Looks good to me too. Thanks Stanislav.

Apr 6 2016, 6:52 PM

Sep 14 2015

ray committed rS287782: MFC: r272715.
MFC: r272715
Sep 14 2015, 2:42 PM

Apr 23 2015

ray accepted D2356: vt(4): Simplify mouse area detection.

I like it

Apr 23 2015, 5:33 PM

Dec 19 2014

ray added a comment to D1291: vt: register the memory regions used by the vt drivers.
In D1291#20, @royger wrote:

I'm not sure I'm following, AFAICT nexus doesn't know anything about the FB, how is it supposed to claim the memory regions?

Dec 19 2014, 2:33 PM
ray added a comment to D1291: vt: register the memory regions used by the vt drivers.
In D1291#18, @emaste wrote:
In D1291#15, @ray wrote:

Possible, resource can be busy (by parent who setup FB), so if resource busy we have not to panic.

I think we can require the parent setting up the FB to alloc the resource, no?

Dec 19 2014, 1:57 PM
ray accepted D1291: vt: register the memory regions used by the vt drivers.

I like it.
Good idea Roger. Thank you for that!

Dec 19 2014, 1:38 PM

Oct 24 2014

ray accepted D1005: vt(4): Enable vt(4) by default.

At least vt(4) currently less problematic than syscons(4) :-D

Oct 24 2014, 12:49 PM

Oct 21 2014

ray added a comment to D971: vt(4): Allow to restore default font.

There is several ways:

  1. You can change ABI, but not merge that changes to older releases.
  2. Or keep ABI, and merge whatever you need

:-D

Oct 21 2014, 9:37 PM
ray accepted D971: vt(4): Allow to restore default font.

Looks fine.
But I did not able to test it :) (at least now)

Oct 21 2014, 12:43 PM
ray accepted D981: Coverity CID 1248848 - Leaked Storage Variable..

Yup, that one looks correct.

Oct 21 2014, 12:36 PM

Oct 17 2014

ray accepted D954: Do nothing in vt_upgrade if no driver is available.

Thanks Ed!

Oct 17 2014, 12:15 PM

Sep 24 2014

ray accepted D821: Keep keyboard mode and state and restore it when switching window.

That is what I have to done while ago :)
One comment - there is last `kbdd_ioctl(...KDSKBMODE...) in the vtterm_cngetc, so looks like grab/ungrab have to save/restore kbdstate of current window too. (I'm not sure)

Sep 24 2014, 9:32 PM

Sep 15 2014

ray accepted D785: vt(4): Fix a LOR in vt_allocate().

Looks good.

Sep 15 2014, 1:38 PM

Sep 12 2014

ray closed D755: Switch vt(4) to traditional behaviour with copy-paste..

Committed 271464, 271465, 271466.

Sep 12 2014, 2:18 PM

Sep 11 2014

ray updated the diff for D755: Switch vt(4) to traditional behaviour with copy-paste..

Fix stray char on paste.

Sep 11 2014, 5:48 PM