ray (Aleksandr Rybalko)
User

Projects

User Details

User Since
May 12 2014, 10:17 AM (214 w, 1 d)

Recent Activity

Dec 27 2017

ray accepted D13645: Make vt(4) palette configurable.

Looks cute :)

Dec 27 2017, 8:47 AM

Dec 5 2017

ray accepted D13331: Allow custom overrides of mmap attribute for VT framebuffer.
Dec 5 2017, 11:06 PM
ray accepted D13332: Use unsigned intptr_t type for framebuffer addresses.

Correct. Thank you!

Dec 5 2017, 11:03 PM

Aug 4 2017

ray added a comment to D11866: Allow vt_timer() callout to run during mountroot input loop in vt(4).

Sorry, I don't feel myself enough knowledgeable to give sane answer here :)

Aug 4 2017, 6:46 PM

Aug 2 2017

ray accepted D11814: Implement "vidcontrol -h <history_size>" for vt(4).

Looks good. Thanks.

Aug 2 2017, 9:32 AM

Jul 28 2017

ray accepted D11753: Implement "vidcontrol -c <normal|blink|destructive>" for vt(4).

style(9) issues still here (but in different functions), but there is a lot from very first vt project release.

Jul 28 2017, 11:03 PM

Feb 22 2017

ray accepted D9709: Fix locking on the vt driver's data structures..

Looks good. Thank you, Jonathan!

Feb 22 2017, 7:14 AM

Feb 10 2017

ray committed rS313547: o Reset mouse selection when new lines reach selection lines..
o Reset mouse selection when new lines reach selection lines.
Feb 10 2017, 1:28 PM

Dec 13 2016

ray accepted D8749: Delete gpio flags because of not support device. This is same as gpioiic. Add spi clock low delay. Reformat message. ar5315_spi.c spibus minor number fix..
Dec 13 2016, 8:08 AM
ray added a comment to D8749: Delete gpio flags because of not support device. This is same as gpioiic. Add spi clock low delay. Reformat message. ar5315_spi.c spibus minor number fix..

Thanks a lot, guys!

Dec 13 2016, 8:07 AM

Dec 11 2016

ray added a comment to D8749: Delete gpio flags because of not support device. This is same as gpioiic. Add spi clock low delay. Reformat message. ar5315_spi.c spibus minor number fix..

gpiobus_pin_setflags() in gpibus.c have check gpio_check_flags(). This code check pin capabirity. If low driver not support GPIO_PIN_PULLUP/GPIO_PIN_PULLDOWN return EINVAL.

Dec 11 2016, 11:00 PM
ray added inline comments to D8749: Delete gpio flags because of not support device. This is same as gpioiic. Add spi clock low delay. Reformat message. ar5315_spi.c spibus minor number fix..
Dec 11 2016, 8:32 PM

Sep 29 2016

ray accepted D8064: Allow framebuffer driver control memory mapping type for mmap(2) call.

Cool! Thank you Oleksandr!

Sep 29 2016, 6:45 AM

Sep 4 2016

ray accepted D7781: [BHND/USB] Port of EHCI/OHCI support from ZRouter.
Sep 4 2016, 9:21 PM

Jun 23 2016

ray accepted D6907: [MIPS/DDB] (fix) backtrace: incorrect MIPS32 reg values & truncated backtrace on MipsKernGenException inside short function.

Now, looks fine.

Jun 23 2016, 10:17 PM

Jun 10 2016

ray requested changes to D6796: Add RTL8366SR support at etherswitch driver.
Jun 10 2016, 6:53 AM

May 27 2016

ray accepted D6513: [nvram2env] split implementation into generic & MIPS-based code.

Now, looks fine.

May 27 2016, 8:50 AM
ray added a comment to D5674: [dev/cfi] add support for flashes with different bus-vs-device address width.

I'm afraid JEDEC CFI standard do not allow simple omit of upper byte(s), you have to try bus and chip data width and get temporary configuration, til required data read from chip.

May 27 2016, 6:55 AM

May 23 2016

ray added a comment to D6513: [nvram2env] split implementation into generic & MIPS-based code.

Only one comment left.

May 23 2016, 10:31 PM

Apr 6 2016

ray accepted D5864: Update if_rt to support more SoCs via both FDT and non-FDT.

Looks good to me too. Thanks Stanislav.

Apr 6 2016, 6:52 PM

Sep 14 2015

ray committed rS287782: MFC: r272715.
MFC: r272715
Sep 14 2015, 2:42 PM

Apr 23 2015

ray accepted D2356: vt(4): Simplify mouse area detection.

I like it

Apr 23 2015, 5:33 PM

Dec 19 2014

ray added a comment to D1291: vt: register the memory regions used by the vt drivers.
In D1291#20, @royger wrote:

I'm not sure I'm following, AFAICT nexus doesn't know anything about the FB, how is it supposed to claim the memory regions?

Dec 19 2014, 2:33 PM
ray added a comment to D1291: vt: register the memory regions used by the vt drivers.
In D1291#18, @emaste wrote:
In D1291#15, @ray wrote:

Possible, resource can be busy (by parent who setup FB), so if resource busy we have not to panic.

I think we can require the parent setting up the FB to alloc the resource, no?

Dec 19 2014, 1:57 PM
ray accepted D1291: vt: register the memory regions used by the vt drivers.

I like it.
Good idea Roger. Thank you for that!

Dec 19 2014, 1:38 PM

Oct 24 2014

ray accepted D1005: vt(4): Enable vt(4) by default.

At least vt(4) currently less problematic than syscons(4) :-D

Oct 24 2014, 12:49 PM

Oct 21 2014

ray added a comment to D971: vt(4): Allow to restore default font.

There is several ways:

  1. You can change ABI, but not merge that changes to older releases.
  2. Or keep ABI, and merge whatever you need

:-D

Oct 21 2014, 9:37 PM
ray accepted D971: vt(4): Allow to restore default font.

Looks fine.
But I did not able to test it :) (at least now)

Oct 21 2014, 12:43 PM
ray accepted D981: Coverity CID 1248848 - Leaked Storage Variable..

Yup, that one looks correct.

Oct 21 2014, 12:36 PM

Oct 17 2014

ray accepted D954: Do nothing in vt_upgrade if no driver is available.

Thanks Ed!

Oct 17 2014, 12:15 PM

Sep 24 2014

ray accepted D821: Keep keyboard mode and state and restore it when switching window.

That is what I have to done while ago :)
One comment - there is last `kbdd_ioctl(...KDSKBMODE...) in the vtterm_cngetc, so looks like grab/ungrab have to save/restore kbdstate of current window too. (I'm not sure)

Sep 24 2014, 9:32 PM

Sep 15 2014

ray accepted D785: vt(4): Fix a LOR in vt_allocate().

Looks good.

Sep 15 2014, 1:38 PM

Sep 12 2014

ray closed D755: Switch vt(4) to traditional behaviour with copy-paste..

Committed 271464, 271465, 271466.

Sep 12 2014, 2:18 PM

Sep 11 2014

ray updated the diff for D755: Switch vt(4) to traditional behaviour with copy-paste..

Fix stray char on paste.

Sep 11 2014, 5:48 PM

Sep 10 2014

ray updated the diff for D755: Switch vt(4) to traditional behaviour with copy-paste..

Copy data only on BUTTON-UP events.

Sep 10 2014, 2:40 PM
ray retitled D755: Switch vt(4) to traditional behaviour with copy-paste. from to Switch vt(4) to traditional behaviour with copy-paste..
Sep 10 2014, 2:05 PM
ray closed D747: Allow enable/disable some keyboard combinations..

Committed as r271381.
Thank you guys!

Sep 10 2014, 12:40 PM
ray added a comment to D747: Allow enable/disable some keyboard combinations..

btw, anybody know where to get scancodes without making experiments? :)

Sep 10 2014, 10:39 AM
ray updated the diff for D747: Allow enable/disable some keyboard combinations..

Lets look it from other point of view:
o Implement all special combinations that syscons(4) have.
o Point to kbdmap(5) for reference.

Sep 10 2014, 10:37 AM

Sep 9 2014

ray added a comment to D747: Allow enable/disable some keyboard combinations..

Guys,
how is it looks now? :)

Sep 9 2014, 10:18 PM
ray updated the diff for D747: Allow enable/disable some keyboard combinations..

o Extend descriptions for reboot and debug.
o Use RB_AUTOBOOT.

Sep 9 2014, 10:15 PM
ray retitled D747: Allow enable/disable some keyboard combinations. from to Allow enable/disable some keyboard combinations..
Sep 9 2014, 2:22 PM

Aug 26 2014

ray accepted D683: vt(4): Run vt_timer only when there's something to draw.

Looks good!

Aug 26 2014, 12:03 PM
ray accepted D682: vt(4): Switch window when entering ddb or a panic occurs.

Looks good!

Aug 26 2014, 12:02 PM
ray added a comment to D683: vt(4): Run vt_timer only when there's something to draw.

Agree, too.
Save world using less electric power :)

Aug 26 2014, 11:28 AM
ray added a comment to D682: vt(4): Switch window when entering ddb or a panic occurs.

Yeah, it is right thing.
Please do!

Aug 26 2014, 11:25 AM

Aug 12 2014

ray added a comment to D568: Add terasic_mtl vt(4) framebuffer driver.
In D568#5, @emaste wrote:

Actually it's an endianness issue, which I did not notice until r269783 went in
http://svnweb.freebsd.org/changeset/base/269783

It's actually an ARGB little-endian framebuffer, or BGRA when viewed as big-endian data.

canonical source:

inline u_int32_t
fb_colour(int r, int g, int b)
{
  return ((r&0xff)<<8) | ((g&0xff)<<16) | ((b&0xff)<<24);
}
Aug 12 2014, 11:00 AM

Aug 8 2014

ray added a comment to D568: Add terasic_mtl vt(4) framebuffer driver.

Patch looks good to me (only OF_getpropenc to look).

Aug 8 2014, 9:23 PM

Jun 5 2014

ray accepted D183: vt fontcvt: move to usr.bin/vtfontcvt.

Looks good to me.

Jun 5 2014, 9:29 PM