Page MenuHomeFreeBSD
Differential D57503

install: drop obsolete file size limit for -C
ClosedPublic
Actions

Authored by ray on Mon, Jun 8, 2:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 12, 7:45 AM
Unknown Object (File)
Thu, Jun 11, 9:07 PM
Unknown Object (File)
Thu, Jun 11, 9:07 PM
Unknown Object (File)
Thu, Jun 11, 4:18 AM
Unknown Object (File)
Thu, Jun 11, 2:20 AM
Unknown Object (File)
Mon, Jun 8, 2:51 PM
Subscribers
ziaee

Details

Reviewers
bdrewery
imp
glebius
ziaee
Commits
rG9d10b4d2c9e8: install: drop obsolete file size limit for -C
Summary

Removes the file size limit for -C comparisons. The limit was
meant to prevent oversized mmap allocations, which is no longer relevant
as mmap is no longer used here. Credit to bdrewery.
See: https://reviews.freebsd.org/D57230

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ray created this revision.Mon, Jun 8, 2:44 PM
Herald added a subscriber: ziaee. · View Herald TranscriptMon, Jun 8, 2:44 PM
ray requested review of this revision.Mon, Jun 8, 2:44 PM
Harbormaster completed remote builds in B73742: Diff 179387.Mon, Jun 8, 2:44 PM
ray updated this revision to Diff 179389.Mon, Jun 8, 2:49 PM

Update message.

Harbormaster completed remote builds in B73743: Diff 179389.Mon, Jun 8, 2:49 PM
ray edited the summary of this revision. (Show Details)Mon, Jun 8, 2:53 PM
ray mentioned this in D57230: install: add -z <max_cmp_size> option.Mon, Jun 8, 2:55 PM
glebius accepted this revision.Mon, Jun 8, 5:57 PM

Makes sense to mention the commit that had removed mmap() in the commit message.

No longer since XXXXXXX as mmap is removed
This revision is now accepted and ready to land.Mon, Jun 8, 5:57 PM
bdrewery accepted this revision.Wed, Jun 10, 4:16 PM

Thank you

ziaee accepted this revision.Wed, Jun 10, 6:07 PM

lgtm from manpages

Closed by commit rG9d10b4d2c9e8: install: drop obsolete file size limit for -C (authored by ray). · Explain WhyThu, Jun 11, 1:53 AM
This revision was automatically updated to reflect the committed changes.
ray added a commit: rG9d10b4d2c9e8: install: drop obsolete file size limit for -C.

Revision Contents
Changeset List

PathSize
usr.bin/
xinstall/
2 lines
13 lines
103 lines

Diff 179593

View Options

usr.bin/xinstall/Makefile

Loading...
View Options

usr.bin/xinstall/install.1

Loading...
View Options

usr.bin/xinstall/xinstall.c

Loading...