Page MenuHomeFreeBSD

manpagesUmbrella
ActivePublic

Recent Activity

Jan 3 2019

romain closed D18725: Add man page for dlvsym(3).
Jan 3 2019, 9:31 PM · manpages
0mp accepted D18725: Add man page for dlvsym(3).

Second OK from manpages. ;)

Jan 3 2019, 4:48 PM · manpages
markj accepted D18725: Add man page for dlvsym(3).

Looks fine to me.

Jan 3 2019, 4:47 PM · manpages
bcr accepted D18725: Add man page for dlvsym(3).

OK from manpages. Thank you!

Jan 3 2019, 8:18 AM · manpages
danger added a member for manpages: danger.
Jan 3 2019, 8:09 AM
romain created D18725: Add man page for dlvsym(3).
Jan 3 2019, 4:08 AM · manpages

Dec 7 2018

kib closed D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Dec 7 2018, 3:18 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Dec 7 2018, 12:29 PM · manpages
kib added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Dec 7 2018, 11:30 AM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Dec 7 2018, 9:49 AM · manpages

Dec 6 2018

kib added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Dec 6 2018, 9:07 PM · manpages
pho added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

I have run all of the stress2 tests with D18359.id51596.diff without seeing any problems.

Dec 6 2018, 8:42 PM · manpages

Dec 5 2018

jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Dec 5 2018, 9:33 AM · manpages

Dec 4 2018

markj added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Dec 4 2018, 5:02 PM · manpages
kib added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

Peter. could you please take the diff and run it through stress2 ?

Dec 4 2018, 3:45 PM · manpages
kib updated subscribers of D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Dec 4 2018, 3:42 PM · manpages
kib accepted D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Dec 4 2018, 3:42 PM · manpages
jack_gandi.net added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Dec 4 2018, 3:35 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Dec 4 2018, 3:31 PM · manpages

Dec 3 2018

kib added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Dec 3 2018, 3:25 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

No more locks, no more leaks as far as I can tell

Dec 3 2018, 9:34 AM · manpages

Nov 30 2018

jack_gandi.net added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
In D18359#391303, @kib wrote:

I was able to reproduce the lock recursion in the case where the source fhp points to the same object as the destination link. It turns ou the link(2) doesn't lock the source node which seems acceptable. So I changed fhlinkat_kern to only LK_SHARED on the source node, therefore the kern_linkat_vp doesn't need the bool locked anymore because all the callers have the same input locking state.

LK_SHARED is still locking the vnode, although in the shared mode. So from the brief look at the updated patch, you are leaking the vnode locks.

Do you run the tests with WITNESS + DEBUG_VFS_LOCKS kernel options ?

Nov 30 2018, 3:55 PM · manpages
kib added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

I was able to reproduce the lock recursion in the case where the source fhp points to the same object as the destination link. It turns ou the link(2) doesn't lock the source node which seems acceptable. So I changed fhlinkat_kern to only LK_SHARED on the source node, therefore the kern_linkat_vp doesn't need the bool locked anymore because all the callers have the same input locking state.

Nov 30 2018, 3:45 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 30 2018, 3:04 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

I was able to reproduce the lock recursion in the case where the source fhp points to the same object as the destination link. It turns ou the link(2) doesn't lock the source node which seems acceptable. So I changed fhlinkat_kern to only LK_SHARED on the source node, therefore the kern_linkat_vp doesn't need the bool locked anymore because all the callers have the same input locking state.

Nov 30 2018, 3:00 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 30 2018, 2:53 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

temporary pathc, I'm still looking into the lock recursion that @kib has mentionned.

Nov 30 2018, 1:36 PM · manpages
jack_gandi.net added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 30 2018, 10:34 AM · manpages
kib added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 30 2018, 10:09 AM · manpages
jack_gandi.net added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 30 2018, 10:06 AM · manpages
jack_gandi.net added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 30 2018, 10:03 AM · manpages
jack_gandi.net added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 30 2018, 9:45 AM · manpages

Nov 29 2018

brooks added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 29 2018, 5:33 PM · manpages
kib added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 29 2018, 5:13 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 29 2018, 4:21 PM · manpages
jack_gandi.net added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 29 2018, 4:19 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

In this diff there is no more code duplication. also I forgot to include the two new manpages in the previous versions (fhlink.2 and fhreadlink.2).

Nov 29 2018, 4:18 PM · manpages

Nov 28 2018

kib added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 28 2018, 2:42 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 28 2018, 10:07 AM · manpages
jack_gandi.net added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 28 2018, 10:04 AM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 28 2018, 10:00 AM · manpages
jack_gandi.net added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

Here's some more context to the diff. I wasn't aware of style(9), will check that before submitting in the future.

Nov 28 2018, 9:57 AM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 28 2018, 9:50 AM · manpages
kib added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

(I did not repeated the style notes, please look at the style violations mentioned through the whole patch).

Nov 28 2018, 9:50 AM · manpages
bapt added reviewers for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls: kib, markj, emaste.
Nov 28 2018, 9:05 AM · manpages

Nov 27 2018

brooks added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

A bunch of style things, but it generally looks fine. I've not looked deeply at the implementations of the kern_ functions.

Nov 27 2018, 5:04 PM · manpages
jack_gandi.net created D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 27 2018, 4:19 PM · manpages

Nov 14 2018

se closed D17969: Prepare for removal of CTM from FreeBSD-13.
Nov 14 2018, 8:46 AM · manpages
se added a comment to D17969: Prepare for removal of CTM from FreeBSD-13.
In D17969#383877, @bcr wrote:

Can you bump the .Dd of ctm.1 for this content change? The rest of the man page looks fine, thanks!

Nov 14 2018, 8:25 AM · manpages
se updated the diff for D17969: Prepare for removal of CTM from FreeBSD-13.

Apply suggestions regarding textual changes in ctm.c, ctm.1, and UPDATING.
This version is about to be committed.

Nov 14 2018, 8:24 AM · manpages