Page MenuHomeFreeBSD

manpagesUmbrella
ActivePublic

Recent Activity

Fri, Dec 7

kib closed D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Fri, Dec 7, 3:18 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Fri, Dec 7, 12:29 PM · manpages
kib added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Fri, Dec 7, 11:30 AM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Fri, Dec 7, 9:49 AM · manpages

Thu, Dec 6

kib added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Thu, Dec 6, 9:07 PM · manpages
pho added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

I have run all of the stress2 tests with D18359.id51596.diff without seeing any problems.

Thu, Dec 6, 8:42 PM · manpages

Wed, Dec 5

jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Wed, Dec 5, 9:33 AM · manpages

Tue, Dec 4

markj added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Tue, Dec 4, 5:02 PM · manpages
kib added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

Peter. could you please take the diff and run it through stress2 ?

Tue, Dec 4, 3:45 PM · manpages
kib updated subscribers of D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Tue, Dec 4, 3:42 PM · manpages
kib accepted D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Tue, Dec 4, 3:42 PM · manpages
jack_gandi.net added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Tue, Dec 4, 3:35 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Tue, Dec 4, 3:31 PM · manpages

Mon, Dec 3

kib added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Mon, Dec 3, 3:25 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

No more locks, no more leaks as far as I can tell

Mon, Dec 3, 9:34 AM · manpages

Fri, Nov 30

jack_gandi.net added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
In D18359#391303, @kib wrote:

I was able to reproduce the lock recursion in the case where the source fhp points to the same object as the destination link. It turns ou the link(2) doesn't lock the source node which seems acceptable. So I changed fhlinkat_kern to only LK_SHARED on the source node, therefore the kern_linkat_vp doesn't need the bool locked anymore because all the callers have the same input locking state.

LK_SHARED is still locking the vnode, although in the shared mode. So from the brief look at the updated patch, you are leaking the vnode locks.

Do you run the tests with WITNESS + DEBUG_VFS_LOCKS kernel options ?

Fri, Nov 30, 3:55 PM · manpages
kib added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

I was able to reproduce the lock recursion in the case where the source fhp points to the same object as the destination link. It turns ou the link(2) doesn't lock the source node which seems acceptable. So I changed fhlinkat_kern to only LK_SHARED on the source node, therefore the kern_linkat_vp doesn't need the bool locked anymore because all the callers have the same input locking state.

Fri, Nov 30, 3:45 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Fri, Nov 30, 3:04 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

I was able to reproduce the lock recursion in the case where the source fhp points to the same object as the destination link. It turns ou the link(2) doesn't lock the source node which seems acceptable. So I changed fhlinkat_kern to only LK_SHARED on the source node, therefore the kern_linkat_vp doesn't need the bool locked anymore because all the callers have the same input locking state.

Fri, Nov 30, 3:00 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Fri, Nov 30, 2:53 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

temporary pathc, I'm still looking into the lock recursion that @kib has mentionned.

Fri, Nov 30, 1:36 PM · manpages
jack_gandi.net added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Fri, Nov 30, 10:34 AM · manpages
kib added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Fri, Nov 30, 10:09 AM · manpages
jack_gandi.net added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Fri, Nov 30, 10:06 AM · manpages
jack_gandi.net added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Fri, Nov 30, 10:03 AM · manpages
jack_gandi.net added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Fri, Nov 30, 9:45 AM · manpages

Thu, Nov 29

brooks added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Thu, Nov 29, 5:33 PM · manpages
kib added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Thu, Nov 29, 5:13 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Thu, Nov 29, 4:21 PM · manpages
jack_gandi.net added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Thu, Nov 29, 4:19 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

In this diff there is no more code duplication. also I forgot to include the two new manpages in the previous versions (fhlink.2 and fhreadlink.2).

Thu, Nov 29, 4:18 PM · manpages

Wed, Nov 28

kib added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Wed, Nov 28, 2:42 PM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Wed, Nov 28, 10:07 AM · manpages
jack_gandi.net added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Wed, Nov 28, 10:04 AM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Wed, Nov 28, 10:00 AM · manpages
jack_gandi.net added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

Here's some more context to the diff. I wasn't aware of style(9), will check that before submitting in the future.

Wed, Nov 28, 9:57 AM · manpages
jack_gandi.net updated the diff for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Wed, Nov 28, 9:50 AM · manpages
kib added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

(I did not repeated the style notes, please look at the style violations mentioned through the whole patch).

Wed, Nov 28, 9:50 AM · manpages
bapt added reviewers for D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls: kib, markj, emaste.
Wed, Nov 28, 9:05 AM · manpages

Tue, Nov 27

brooks added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

A bunch of style things, but it generally looks fine. I've not looked deeply at the implementations of the kern_ functions.

Tue, Nov 27, 5:04 PM · manpages
jack_gandi.net created D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Tue, Nov 27, 4:19 PM · manpages

Nov 14 2018

se closed D17969: Prepare for removal of CTM from FreeBSD-13.
Nov 14 2018, 8:46 AM · manpages
se added a comment to D17969: Prepare for removal of CTM from FreeBSD-13.
In D17969#383877, @bcr wrote:

Can you bump the .Dd of ctm.1 for this content change? The rest of the man page looks fine, thanks!

Nov 14 2018, 8:25 AM · manpages
se updated the diff for D17969: Prepare for removal of CTM from FreeBSD-13.

Apply suggestions regarding textual changes in ctm.c, ctm.1, and UPDATING.
This version is about to be committed.

Nov 14 2018, 8:24 AM · manpages

Nov 13 2018

rgrimes accepted D17969: Prepare for removal of CTM from FreeBSD-13.

I like imp@'s revisions. I am accepting either version though.

Nov 13 2018, 4:01 PM · manpages
imp accepted D17969: Prepare for removal of CTM from FreeBSD-13.

Looks good. I have a couple of suggested tweaks that make things better imho, but if you don't like one or the other, you can ignore.
I trust whatever you decide, so I'm clicking 'accept' to not hold things up.

Nov 13 2018, 2:51 PM · manpages
se updated the diff for D17969: Prepare for removal of CTM from FreeBSD-13.

Bump .Dd date in man-page as requested by bcr (Benedict Reuschling) and use the same date in UPDATING.
The date will be adjusted in both files, if the commit is delayed beyond Nov. 15.

Nov 13 2018, 1:33 PM · manpages
bcr added a comment to D17969: Prepare for removal of CTM from FreeBSD-13.

Can you bump the .Dd of ctm.1 for this content change? The rest of the man page looks fine, thanks!

Nov 13 2018, 7:50 AM · manpages

Nov 12 2018

se added a child revision for D17969: Prepare for removal of CTM from FreeBSD-13: D17935: Remove CTM from 13-CURRENT.
Nov 12 2018, 11:03 PM · manpages
se created D17969: Prepare for removal of CTM from FreeBSD-13.
Nov 12 2018, 11:00 PM · manpages