Fri, Dec 7
Thu, Dec 6
I have run all of the stress2 tests with D18359.id51596.diff without seeing any problems.
Wed, Dec 5
Tue, Dec 4
Peter. could you please take the diff and run it through stress2 ?
Mon, Dec 3
No more locks, no more leaks as far as I can tell
Fri, Nov 30
I was able to reproduce the lock recursion in the case where the source fhp points to the same object as the destination link. It turns ou the link(2) doesn't lock the source node which seems acceptable. So I changed fhlinkat_kern to only LK_SHARED on the source node, therefore the kern_linkat_vp doesn't need the bool locked anymore because all the callers have the same input locking state.
temporary pathc, I'm still looking into the lock recursion that @kib has mentionned.
Thu, Nov 29
In this diff there is no more code duplication. also I forgot to include the two new manpages in the previous versions (fhlink.2 and fhreadlink.2).
Wed, Nov 28
Here's some more context to the diff. I wasn't aware of style(9), will check that before submitting in the future.
(I did not repeated the style notes, please look at the style violations mentioned through the whole patch).
Tue, Nov 27
A bunch of style things, but it generally looks fine. I've not looked deeply at the implementations of the kern_ functions.
Nov 14 2018
Apply suggestions regarding textual changes in ctm.c, ctm.1, and UPDATING.
This version is about to be committed.
Nov 13 2018
I like imp@'s revisions. I am accepting either version though.
Looks good. I have a couple of suggested tweaks that make things better imho, but if you don't like one or the other, you can ignore.
I trust whatever you decide, so I'm clicking 'accept' to not hold things up.
Bump .Dd date in man-page as requested by bcr (Benedict Reuschling) and use the same date in UPDATING.
The date will be adjusted in both files, if the commit is delayed beyond Nov. 15.
Can you bump the .Dd of ctm.1 for this content change? The rest of the man page looks fine, thanks!