Sat, Jun 10
Wed, May 31
Catch up with the latest review.
manpages here, just a couple grammar nits.
Tue, May 30
OK, so I guess we'd need another review from manpages now...
May 26 2017
May 25 2017
OK, let's see if I understood you correctly this time Warner. make(1) is indeed apparently setting MACHINE and MACHINE_ARCH globally.
May 16 2017
May 15 2017
Strictly speaking, you are correct, but man pages often have references elsewhere, and having it here wouldn't be terrible.
So, shall we proceed with this? Still pending review from manpages...
May 11 2017
Apr 25 2017
Guys, I don't entirely understand how TARGET/MACHINE and/or TARGET/MACHINE_ARCH come into play here: this patch is about uname(1) only; these variables are not referenced anywhere in its sources, and are partially (?) documented in build(7). Can you elaborate a bit?
If "platform" (-m) and "processor architecture" (-p) are the same as the TARGET and TARGET_ARCH, then it would be great to include that too.
Apr 16 2017
Mar 10 2017
Fix bcr@'s request.
Mar 6 2017
Don't forget to bump the document date.
Mar 5 2017
Jan 17 2017
Dec 5 2016
Continue the review in D8691
Dec 2 2016
Added D8691 with an updated patch
Nov 21 2016
Nov 20 2016
I'd prefer to not see more \fB and \fR escapes going in; we should use the richer mdoc macros.
Oct 8 2016
Oct 7 2016
Oct 5 2016
Oct 2 2016
Approved. Make sure to bump .Dd before committing.
Approved. Make sure to reference all PRs you might have already opened for the individual man page.
Good catch. Make sure to bump the .Dd to today before committing to head. Is there a PR for it? If so, then reference it in the PR: line.