I like it, lets give it a few days to see if anyone else has any suggestions to improve it further.

Ping.

Ping.

Ping.

In D58457#1342400, @ziaee wrote:

This line was forgotten to be updated when information about st_birthtime was first added into the manual page.

Nice, so we want to find that commit and put it at the bottom of the commit message like Fixes: <shorthash> ("Commit title").

In D58476#1342416, @ziaee wrote:

So we've been trying to standardize this language, here's the draft: https://reviews.freebsd.org/D57690

Use standardized formulation.

So we've been trying to standardize this language, here's the draft: https://reviews.freebsd.org/D57690

Hey Artem, thanks for the patch.

In D58329#1338905, @temcbun_gmail.com wrote:

Document descriptions should not have crossreferences especially, but really any child macros.
Manpage compiler upstream has said (quite strongly and hilariously actually) it's wrong.

But where exactly does it say this?

Get rid of .Xr in .Nd and make the .Nd itself more informative.

Thank you for the review!

I have not reviewed this because all I know about colors is how to turn them off, drives me crazy. Maybe... @dteske might know?

In D55333#1338496, @temcbun_gmail.com wrote:

@jilles Could you please accept this revision once again, just to move it into 'ready to land' category?

That is not necessary.

1. We do not really have tooling around that, so it does not make it any more discoverable.
2. Whoever lands it is responsible for handling the judgement. So, jilles approval stands unless he rescinds it or a change is made which we would deem requires his re-review per the context.
3. Someone might do that as a form of ping, since it sends out an email.

For example, since jilles is reviewing it in the context of being the lead shell maintainer, we could still make mechanical changes at this stage like fixing a typo or improving text alignment. However a content change that changes the meaning would, to me, invalidate his previous approval and require his re-review.

Thank you both, I think this is a great new feature for the sh manual and I am so excited to land this now!

@jilles Could you please accept this revision once again, just to move it into 'ready to land' category?

Ping.

Rebase the patch and bump .Dd.

Ping.

Ping.

Ping.

In D57720#1331295, @temcbun_gmail.com wrote:

@ziaee Could you please MFC this commit (I see the commit message says it is to be MFCed after 3 days, but it's still not).

@ziaee Could you please MFC this commit (I see the commit message says it is to be MFCed after 3 days, but it's still not).

In D58038#1331015, @olce wrote:

Removing the hyphen in the first line is fine, but then that should be mentioned in the commit message. I can add a sentence to that effect myself.

Removing the hyphen in the first line is fine, but then that should be mentioned in the commit message. I can add a sentence to that effect myself. Which mail do you want to use? The one that can be inferred from your Phabricator login? I also see a mail at "zohomail" in the tree that could match. If you have to disclose the full name and don't want to do that here, then please mail it to me (olce@).

Remove hyphen from the first comment line. Thanks @ziaee!

Ping for review.

I will since as the reviewer I was supposed to prevent these typos. Thanks guys!