Disclaimer: didn't read the review. However, read the diff at EuroBSDCon together with Alexander.

I missed these omitted .Dd bumps before

forgot a stray "type"

In D59643#1370258, @ziaee wrote:

"ng_ip_input(4) -- IPv4 input netgraph node"?

"ng_ip_input(4) -- IPv4 input netgraph node"?

In D58328#1365066, @ziaee wrote:

Thanks for the ping. So I dug in a little further. The existing description is actually aligned with a library, mktemp.3 which has the same description. It can make not only directories, but pipes and fifos and... (etc) which are all normalized to files. Further, mktemp was written by Todd C Miller and even has a website https://www.mktemp.org/ and seems to have the same Nd in every single OS because we're all using the same implementation. So, we should not change it. In fact perhaps it should be in contrib/ to make that more obvious but I do not want to grind that axe.

Thanks for the ping. So I dug in a little further. The existing description is actually aligned with a library, mktemp.3 which has the same description. It can make not only directories, but pipes and fifos and... (etc) which are all normalized to files. Further, mktemp was written by Todd C Miller and even has a website https://www.mktemp.org/ and seems to have the same Nd in every single OS because we're all using the same implementation. So, we should not change it. In fact perhaps it should be in contrib/ to make that more obvious but I do not want to grind that axe.

Ping.

Ping.

Thanks all for the review.

In D59438#1363257, @rmacklem wrote:

Looks good, but I'm no shell script guy, so hopefully
someone else can review it.

Thanks for doing this, rick

Manpage looks great, thanks for tagging me!

OK for the man page part.

Looks good, but I'm no shell script guy, so hopefully
someone else can review it.

I like it, lets give it a few days to see if anyone else has any suggestions to improve it further.

Ping.

Ping.

Ping.

In D58457#1342400, @ziaee wrote:

This line was forgotten to be updated when information about st_birthtime was first added into the manual page.

Nice, so we want to find that commit and put it at the bottom of the commit message like Fixes: <shorthash> ("Commit title").

In D58476#1342416, @ziaee wrote:

So we've been trying to standardize this language, here's the draft: https://reviews.freebsd.org/D57690

Use standardized formulation.

So we've been trying to standardize this language, here's the draft: https://reviews.freebsd.org/D57690

Hey Artem, thanks for the patch.

In D58329#1338905, @temcbun_gmail.com wrote:

Document descriptions should not have crossreferences especially, but really any child macros.
Manpage compiler upstream has said (quite strongly and hilariously actually) it's wrong.

But where exactly does it say this?

Get rid of .Xr in .Nd and make the .Nd itself more informative.

Thank you for the review!

I have not reviewed this because all I know about colors is how to turn them off, drives me crazy. Maybe... @dteske might know?