thanks for the feedback!

That's the way how DragonFlyBSD devs solved the problem
https://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/451640b7cf6bcf7826b901ac9a51647442adb96b

Corrected line break.

Correcting section reference to Sx instead of Cm.

Resigning from this; I tried to provide feedback over IRC, but that was seemingly not well-received (and questions unanswered) and I'm not interested in reviewing this as-is. I'd much prefer splitting it into two scripts, one with, e.g., verbs, that manages wireguard interfaces and then the rc script that simply drives that in an obvious way. The last objection I heard was that there's too much state to pass around, but it's not at all clear why unless this is trying to mix way too much rc.conf configuration in with wg config.

In D41318#980524, @pauamma_gundo.com wrote:

No manual page to review, yet manpages is a group reviewer. Did a file get accidentally left out?

No manual page to review, yet manpages is a group reviewer. Did a file get accidentally left out?

This is my first review here, I hope to not be stepping on any toes. If I have, please correct me so I might do better next time. Overall your wireguard startup mechanism looks good and my suggestions are strictly cosmetic in nature. I would not be at all disappointed if this patch were committed unaltered.

address @yurpv's feedback.

LGTM but I would like to know the opinion of an src committer before this lands.

i think this is ready to land now.

add more reviewers

address review from @andrew_tao173.riddles.org.uk

thank you for the review @pstef!
This update addresses your comments.

In D41617#949568, @kib wrote:

Please _mail_ me the proper patch, github provides something broken like From: =?UTF-8?q?Mina=20Gali=C4=87?= <freebsd@igalic.co>.
Also there needs to be 'Differential revision' and 'MFC' taglines.

Please _mail_ me the proper patch, github provides something broken like From: =?UTF-8?q?Mina=20Gali=C4=87?= <freebsd@igalic.co>.
Also there needs to be 'Differential revision' and 'MFC' taglines.

In D41617#949559, @kib wrote:

In D41617#949552, @freebsd_igalic.co wrote:

note that i don't have commit, so i can't commit / MFC this.

Then send me the proper git patch, with all the metadata set.

In D41617#949552, @freebsd_igalic.co wrote:

note that i don't have commit, so i can't commit / MFC this.

note that i don't have commit, so i can't commit / MFC this.