Details
- Reviewers
ziaee bapt - Group Reviewers
docs manpages Contributor Reviews (src)
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| usr.sbin/pw/pw.conf.5 | ||
|---|---|---|
| 30–31 |
How's this? It follows more closely the description set by pw(8) so there will be a narrative consistency and it will show up in more of the same searches like "group". | |
Thank you for the review!
Document descriptions should not have crossreferences especially, but really any child macros.
Oh, yeah, I found a warning about it in mdoc(7) (though it says that child macros are technically not wrong):
The Nd macro technically accepts child macros and terminates with a subsequent Sh invocation. Do not assume this behaviour: some whatis(1) database generators are not smart enough to parse more than the line arguments and will display macros verbatim.
Manpage compiler upstream has said (quite strongly and hilariously actually) it's wrong.
But where exactly does it say this? I tried to lint the page with mandoc(1), but I see no errors or warnings regarding .Nd:
$ mandoc -T lint usr.sbin/pw/pw.conf.5 mandoc: usr.sbin/pw/pw.conf.5:70:2: STYLE: useless macro: Tn mandoc: usr.sbin/pw/pw.conf.5:162:2: STYLE: useless macro: Tn
How's this? It follows more closely the description set by pw(8) so there will be a narrative consistency and it will show up in more of the same searches like "group".
Your variant looks good to me, I will now update the revision.