In D25380#1028541, @emaste wrote:

Do you intend to proceed with this?

Do you intend to proceed with this?

Chris, rather than overwrite your review, I rebased your work on top of the latest of the main branch and created new review in https://reviews.freebsd.org/D44977. The commit message is based on your summary in D43940. If everything looks good to you there, I'll commit.

Would it be possible to update the patch so it applies in recent current?
There were some changes in the manual page on February.

Fixed line breaks. Thanks for the feedback!

Aaand I missed the other two changes. Now added those as well.

Thanks for the reminder and for the feedback. I've fixed the trailing whitespace now.

thanks for the feedback!

That's the way how DragonFlyBSD devs solved the problem
https://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/451640b7cf6bcf7826b901ac9a51647442adb96b

Corrected line break.

Correcting section reference to Sx instead of Cm.

Resigning from this; I tried to provide feedback over IRC, but that was seemingly not well-received (and questions unanswered) and I'm not interested in reviewing this as-is. I'd much prefer splitting it into two scripts, one with, e.g., verbs, that manages wireguard interfaces and then the rc script that simply drives that in an obvious way. The last objection I heard was that there's too much state to pass around, but it's not at all clear why unless this is trying to mix way too much rc.conf configuration in with wg config.

In D41318#980524, @pauamma_gundo.com wrote:

No manual page to review, yet manpages is a group reviewer. Did a file get accidentally left out?

No manual page to review, yet manpages is a group reviewer. Did a file get accidentally left out?

This is my first review here, I hope to not be stepping on any toes. If I have, please correct me so I might do better next time. Overall your wireguard startup mechanism looks good and my suggestions are strictly cosmetic in nature. I would not be at all disappointed if this patch were committed unaltered.

address @yurpv's feedback.

LGTM but I would like to know the opinion of an src committer before this lands.

i think this is ready to land now.

add more reviewers

address review from @andrew_tao173.riddles.org.uk

thank you for the review @pstef!
This update addresses your comments.

In D41617#949568, @kib wrote:

Please _mail_ me the proper patch, github provides something broken like From: =?UTF-8?q?Mina=20Gali=C4=87?= <freebsd@igalic.co>.
Also there needs to be 'Differential revision' and 'MFC' taglines.

Please _mail_ me the proper patch, github provides something broken like From: =?UTF-8?q?Mina=20Gali=C4=87?= <freebsd@igalic.co>.
Also there needs to be 'Differential revision' and 'MFC' taglines.

In D41617#949559, @kib wrote:

In D41617#949552, @freebsd_igalic.co wrote:

note that i don't have commit, so i can't commit / MFC this.

Then send me the proper git patch, with all the metadata set.

In D41617#949552, @freebsd_igalic.co wrote:

note that i don't have commit, so i can't commit / MFC this.

note that i don't have commit, so i can't commit / MFC this.

Looks good to my eye. Looks like all the comments have been addressed.

Address @grahamperrin's comments.

The interface name restriction function is a judgment call restricting users from creating problematic (for shell scripts) interface names. Applying the same restrictions to existing services like netif and routing could break (partly) working configurations.

once again, i have broken a revision by trying to update it.

address @pauamma_gundo.com comments

Manual page English LGTM.

first pass…

In our repo this is two separate commits, one for adding the enum and a second for the -r option. Anyone who wants to commit this, I'd be happy to provide git format-patch format.

Restructured to use an enum for output formats rather than a bool, making it easier to change the defaults or add additional formats in the future. This was rebased onto 13.2 as a part of our migration; I haven't checked whether it still applies to 14-current.

I rewrote this to use an enum for the format type rather than a boolean, making it more flexible in the future. Will re-upload some day.

Fix formatting in HISTORY section thanks to @gbe.

Just a little style for the mail addresses in the HISTORY section, otherwise LGTM. Can't speak for the technical details.

I don't know the technology for this change, but the wording is good now.

address @grahamperrin's review

arc swallowed my previous commit

address @debdrup's review

I only spotted a minor nit.

Minor nits, fixable on commit if nothing else requires another round.

Upated ipfw.8, fix some mandoc -T lint warnings.