- User Since
- Dec 1 2019, 8:31 PM (94 w, 6 h)
Sat, Sep 4
Taking a break before tackling the wall of text, but splitting lines into sentences first would make needed edits easier to spot. Pretty please?
Fri, Sep 3
Hoping to finish reviewing it tonight. 4 installments is pushing it.
Wed, Sep 1
Taking me longer than i thought (when doesn't it for anyone?) but getting there.
Mon, Aug 30
Second installment. (Let me know if I'm too nitpicky or overwhelming.)
Sun, Aug 29
Past 80 comments and I'm losing focus. Submitting what I have, will continue later.
Aug 18 2021
Spelling and grammar look good to me.
Aug 11 2021
I can't speak about the actual content, but no typo, grammar nit, or awkward wording jumps out to me.
Aug 4 2021
Jul 27 2021
Jul 22 2021
Jul 19 2021
Jul 18 2021
Note: I don't know what the current policy and practice are, so I can't comment on how accurately the change reflects them.
Jul 17 2021
Jun 29 2021
Jun 13 2021
Jun 12 2021
Ooops, forgot it was still open. Thanks for the reminder.
Jun 11 2021
May 27 2021
May 25 2021
May 24 2021
May 18 2021
Language LGTM. Whether what this says is correct is beyond my ken.
Apr 11 2021
Mar 27 2021
I look forward to it being fleshed out. (Not that I can do much more than copyedit anyway.)
Mar 18 2021
Mar 14 2021
Latest version looks OK to me after a semi-cursory 3rd read.
A few nits and typos I spotted in my first readthrough, plus some questions.
Mar 5 2021
Feb 8 2021
Grammar and spelling look fine to me at a glance.
Jan 26 2021
Jan 20 2021
Haven't run it through xmllint or igor yet, I first wanted to get a substantive review on my first draft. I will do so before submitting a 2nd draft, although perhaps I should wait to hear from Carlavilla before doing that. What's their username here?
Jan 17 2021
Jan 16 2021
Jan 15 2021
This looks good to me now.
This looks good to me now.
To my shame, I missed some during my previous passes.
Jan 13 2021
Jan 8 2021
Dec 23 2020
I can't vouch for the technical accuracy of this, not having the required knowledge of ZFS and OpenZFS, but other than that and a few nits, this looks fine.
Dec 3 2020
Reminder if needed: I'm not a committer, so one will have to take care of this.
Nov 26 2020
- This should address all comments so far.
Nov 25 2020
Nov 24 2020
Nov 23 2020
Aug 31 2020
Remindr if needed: I'm not a committer
Aug 10 2020
Jul 30 2020
- Split sentence per bcr's comment and change some of the too many "it"s in these sentences to more explicit phrases.
- Address cperciva's review comments.
Jul 29 2020
- s/fetch update/auto/ at bcr's request.
Jul 26 2020
Jul 25 2020
Jul 24 2020
- Change mask from 6 to 12 per zeising's request.
Jul 23 2020
Jul 17 2020
Jul 13 2020
Jul 5 2020
Jun 14 2020
- Address bcr's and debdrup's comments on second draft.
Jun 9 2020
Address most changes requested by debdrup, bcr, and emaste.
Jun 8 2020
Bah. Phabricator ate my inline replies the first time.
Thanks all for reviewing my first draft. I'll try to submit a second draft later tonight or tomorrow.
Jun 6 2020
Jun 5 2020
Jun 4 2020
Apr 30 2020
Can a committer take care of it? I'm not one. (Also, reminder: the PR# is 241814 - I forgot it in the initial summary.)
Apr 28 2020
Apr 20 2020
Thanks for reviewing it. Can a docs committer (I'm not one) take care of it?
This should address all of markj's comments.
Apr 18 2020
Apr 10 2020
Address changes requested by debdrup and bcr.
Apr 6 2020
Ooops, forgot the Bugzilla PR #: 241814
Feb 5 2020
Reminder if needed: I'm not a committer, so someone else will have to take care of this.
Jan 21 2020
Dec 25 2019
Well since I submitted this (and before I added you as a reviewer on this, sorry - I think I didn't make the connection at the time), https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242300#c1 happened, so I think we can close this without action. (Is that what "Abandon revision" is for?)