Note that it makes sense to test this patch stack in combination with D50178 so that all the components which are available offline can actually be selected/installed.

Git branch: https://github.com/ifreund/freebsd-src/tree/bsdinstall-offline-pkgbase

Git branch: https://github.com/ifreund/freebsd-src/tree/bsdinstall-offline-pkgbase

Hide components with no available packages in the menu

Aha! The thing I was seeing happened again and I think I understand it now, submitted D50344.

Uh I'm not sure how I messed up my testing but this patch is incorrect, everything works fine since pkg interprets the METALOG option relative to the rootdir option.

Save errno before calling lua functions, fix comment style

In D50176#1147472, @emaste wrote:

As an aside while MFCing some flua work I (re)discovered 1f31e00e19f9e24d4c891a24973e08a027c4f71c

Use new enforce_max_args() function from D50273

Use new enforce_max_args() function from D50273

My git branch for this patch stack is here: https://github.com/ifreund/freebsd-src/commits/bsdinstall-pkgbase-components/

Add comments to aid review

Move all enforce_max_args() calls to start of function

Add more comments, adjust wording to match D50254

Extract component selection to a separate function

Git branch: https://github.com/ifreund/freebsd-src/tree/pkg-ignore-unknown

Thanks for the review, my git branch is here: https://github.com/ifreund/freebsd-src/tree/pkg-arg-parse

I don't think this is necessary, pkg(7) reads the ASSUME_ALWAYS_YES environment variable and should never ask for user confirmation if it is set.

Thanks for the review!

Here's my git branch with this commit: https://github.com/ifreund/freebsd-src/tree/install-media-pkg

Git branch: https://github.com/ifreund/freebsd-src/tree/pkg-man-fix

In D49822#1139251, @emaste wrote:

I took a look at my WIP tree and seems like I tried this out:

# Install packages onto release media.
        ${PKG_INSTALL} wifi-firmware-kmod-release || true
# Install pkg for installing pkgbase
#       ${PKG_INSTALL} pkg || true
        ${PKG_CLEAN} || true

Maybe it's sufficient

In D49822#1139248, @manu wrote:

For graphical installer and wifi/drm firmwares we will need full pkg and the pkgs on media, maybe @bz started something on this ?

Tweak wording to match changes in D49823

Thanks for the review @jhb!

Tweak wording based on jhb review, simplify logic

In D49822#1138083, @emaste wrote:

I built a disc1.iso with these changes and the installation failed after the root password prompt.

LGTM, Thanks!

Fix formatting in bsdinstall.8

This is a very nice improvement over not having a flua man page!

Reword prompt

Use bsdinstall pkgbase --no-kernel, reword prompt

Rework based on review feedback

Thanks for the in-depth review @jrtc27! I'll get to work on a revised version of this patch shortly.

Tweak networking dialog wording

I believe all review comments so far have now been satisfactorily resolved, thank for the reviews!

Make luacheck happy, .Xr pkg 8 in man page

Slight race condition, I didn't see your replies before pushing that update.

Changes based on ziaee review

Thanks for the comments on the man pages, I'll push an updated version in a minute.

The git branch for this patch stack is available here if that's useful for anyone: https://github.com/ifreund/freebsd-src/tree/bsdinstall-pkgbase

In D47025#1072111, @emaste wrote:

I wonder if we can have bsd.test.mk set PACKAGE?= tests before .include <bsd.init.mk>, which would let us drop the Makefile changes. I'm fine with either version so will see if @bapt has a comment.