User Details
- User Since
- Apr 1 2021, 3:21 AM (140 w, 3 d)
Fri, Dec 8
Thu, Dec 7
Fri, Dec 1
Thu, Nov 30
Looks good to me.
It is user visible change. I think it can NOT be MFCed unless it is treated as debugging purpose only knob.
Wed, Nov 29
Agreed.
Indeed only network devices need this. I had an idea that checks class of device before set vnet0 but that seems to be layer violation, and also CURVNET_SET_QUIET can not be simply wrapped around by if condition.
Tue, Nov 28
Look good to me.
Mon, Nov 27
Ping @jhb .
Fri, Nov 24
FreeBSD does not use GNU assembler in its base system. llvm-as(1) is now in the base system
llvm-as is in ports. It is not in base system.
zlei@:~ % freebsd-version -ku 14.0-RELEASE 14.0-RELEASE zlei@:~ % which llvm-as llvm-as: Command not found.
Interface name of usb ethernet is ue%u , and the MIB is net.ue.<unit>. It is different from that of PCI ethernet interfaces.
# sysctl net.ue.0 net.ue.0.%parent: ure0
Thu, Nov 23
Back to the report by @freebsd_igalic.co :
but we don't know what it was renamed from, and this only works for *real* interfaces, not for cloned devices, or epairs.
Either one should be OK. I would treat -v as an option for debugging purpose.
- With -v only (I'm not fond of this one)
- Anytime the driver name is different than the interface name (including the outliers Kristof mentioned)
- Always (I considered this. and hopefully scripts wouldn't break. but ...)
I'd prefer Always. Just keep it simple. Do not be too smart.
Sorry this is an excessive late response .
Mon, Nov 20
Sun, Nov 19
Sat, Nov 18
For average user EINVAL usually means that their input isn't correct. It is equally misleading as ENOENT. For more experienced user (I speculate) it is known that "file not found" actually means "entity no found".
Generally speaking, a more precise error number is valuable. But I think it is case by case.
Looks good to me.
Fri, Nov 17
Thu, Nov 16
During boot-up (or shutdown), when eventd/syslogd is not up, some conditional messages are too expensive to send to console by default
Do you have a measure how will this change improve?
Wed, Nov 15
Mon, Nov 13
Fri, Nov 10
I tested FreeBSD-11.4-RELEASE-amd64-bootonly.iso which does not have d9ce8a41eac9 ,:
# kldunload kernel kldunload: can't unload file: Device busy
There is also log kldunload: attempt to unload file that was loaded by the kernel from dmesg.
Nov 10 2023
I was about to commit this I found that prior to d9ce8a41eac9 (kern_linker: Handle module-loading failures in preloaded .ko files) the kernel can not be unloaded.
Nov 9 2023
Looks good to me.
Nov 8 2023
Nov 7 2023
Nov 6 2023
Nov 5 2023
Nov 3 2023
Nov 2 2023
Ping @whu .
Address @whu 's comment.
Nov 1 2023
It is definitely the right fix.
A friendly ping before committing this.
From the review D41728 I guess on x86 there should have hardware coherency.
Oct 31 2023
Address @ken 's comments.
Oct 30 2023
Looks good to me.
Oct 28 2023
This is a breaking change. 3rd party drivers should take care of it.