Page MenuHomeFreeBSD

zlei (Zhenlei Huang)
User

Projects

User Details

User Since
Apr 1 2021, 3:21 AM (140 w, 3 d)

Recent Activity

Fri, Dec 8

zlei added inline comments to D42893: pkgbase: treat all the kernel packages the same way.
Fri, Dec 8, 4:06 AM

Thu, Dec 7

zlei accepted D42927: vnet: (read) lock the vnet list while iterating it.
Thu, Dec 7, 1:50 AM

Fri, Dec 1

zlei added inline comments to D42694: sockets: don't malloc/free sockaddr memory on getpeername/getsockname.
Fri, Dec 1, 1:47 AM

Thu, Nov 30

zlei added inline comments to D42694: sockets: don't malloc/free sockaddr memory on getpeername/getsockname.
Thu, Nov 30, 4:43 PM
zlei added inline comments to D42463: Teach if_smsc to get MAC from bootargs..
Thu, Nov 30, 2:58 PM
zlei accepted D42845: tcp: enable LRD by default and move sysctl from tcp.do_lrd tp tcp.sack.lrd.

Looks good to me.

Thu, Nov 30, 2:43 PM
zlei added a comment to D42845: tcp: enable LRD by default and move sysctl from tcp.do_lrd tp tcp.sack.lrd.

Question: can the moving of the sysctl variable be MFCed? Enabling the feature can, of course.

It is user visible change. I think it can NOT be MFCed unless it is treated as debugging purpose only knob.

Thu, Nov 30, 10:23 AM
zlei added inline comments to D42463: Teach if_smsc to get MAC from bootargs..
Thu, Nov 30, 1:10 AM

Wed, Nov 29

zlei added a comment to D42678: bus: Properly set virtual network stack before trying to attach devices.
In D42678#976149, @jhb wrote:

I suspect we need this more broadly. Several places in here can call attach. That said, I wonder if the better fix is that ether_ifattach needs to set a default vnet if one is not already set.
Oddly, both if_alloc and if_attach set if_vnet which seems buggy. if_detach sets the current vnet to if_vnet before doing the meat of the work. I do think this should be managed down in the ifnet layer and not up here in devctl.

Agreed.
Indeed only network devices need this. I had an idea that checks class of device before set vnet0 but that seems to be layer violation, and also CURVNET_SET_QUIET can not be simply wrapped around by if condition.

Wed, Nov 29, 2:00 AM

Tue, Nov 28

zlei accepted D42721: ifconfig: add -D option to print driver name for interface.

Look good to me.

Tue, Nov 28, 10:19 AM

Mon, Nov 27

zlei added a comment to D42678: bus: Properly set virtual network stack before trying to attach devices.

Ping @jhb .

Mon, Nov 27, 5:23 PM
zlei updated the summary of D42678: bus: Properly set virtual network stack before trying to attach devices.
Mon, Nov 27, 5:22 PM

Fri, Nov 24

zlei added a comment to D42744: Replace GNU assembler with llvm-as(1).

FreeBSD does not use GNU assembler in its base system. llvm-as(1) is now in the base system

llvm-as is in ports. It is not in base system.

zlei@:~ % freebsd-version -ku
14.0-RELEASE
14.0-RELEASE
zlei@:~ % which llvm-as
llvm-as: Command not found.
Fri, Nov 24, 10:11 AM · docs
zlei updated subscribers of D42746: kern: bootverbose around printfs.
Fri, Nov 24, 10:03 AM
zlei added a comment to D42721: ifconfig: add -D option to print driver name for interface.
In D42721#974725, @zlei wrote:

Back to the report by @freebsd_igalic.co :

but we don't know what it was renamed from, and this only works for *real* interfaces, not for cloned devices, or epairs.

And by @kevans

Just last week I found this quite a pain as well; once an interface has been renamed, if it's not a pseudo-interface with an obvious group there's no clear way, AFAICT, to determine which driver created it without perusing pciconf output or whatnot and hopefully being able to associate the NICs listed with the new names (easier when there's only one NIC, of course). Kind of a pain when you're working on a remote machine that you're not at all familiar with.

I would summarize as following:

  1. For physical interfaces, it is absolutely necessary to get its driver name and driver unit. Also sysctl dev.<name>.<unit> would give us additional useful info.

Interface name of usb ethernet is ue%u , and the MIB is net.ue.<unit>. It is different from that of PCI ethernet interfaces.

# sysctl net.ue.0
net.ue.0.%parent: ure0
Fri, Nov 24, 6:27 AM

Thu, Nov 23

zlei updated subscribers of D42721: ifconfig: add -D option to print driver name for interface.

Back to the report by @freebsd_igalic.co :

but we don't know what it was renamed from, and this only works for *real* interfaces, not for cloned devices, or epairs.

Thu, Nov 23, 10:20 AM
zlei added a comment to D42721: ifconfig: add -D option to print driver name for interface.

There seems to be an unanswered question. Should the driver name be printed

  1. With -D only (as now)
  2. With -D or -v (so verbose is fully verbose)

Either one should be OK. I would treat -v as an option for debugging purpose.

  1. With -v only (I'm not fond of this one)
  2. Anytime the driver name is different than the interface name (including the outliers Kristof mentioned)
  3. Always (I considered this. and hopefully scripts wouldn't break. but ...)

I'd prefer Always. Just keep it simple. Do not be too smart.

Thu, Nov 23, 8:26 AM
zlei added a comment to D28247: Introduce SIOCGIFDNAME to get the interface device name.

Sorry this is an excessive late response .

Thu, Nov 23, 7:50 AM

Mon, Nov 20

zlei added inline comments to D42670: jail(8) option to cleanup after dead jails.
Mon, Nov 20, 2:24 PM
zlei requested review of D42678: bus: Properly set virtual network stack before trying to attach devices.
Mon, Nov 20, 10:12 AM
zlei added reviewers for D42489: Add kern.console_log_level for console log level: bdrewery, ken, phk.
Mon, Nov 20, 2:33 AM

Sun, Nov 19

zlei added inline comments to D42635: sockets: don't malloc/free sockaddr memory on accept(2).
Sun, Nov 19, 5:37 PM
zlei added inline comments to D42635: sockets: don't malloc/free sockaddr memory on accept(2).
Sun, Nov 19, 3:25 PM
zlei added inline comments to D42635: sockets: don't malloc/free sockaddr memory on accept(2).
Sun, Nov 19, 3:07 PM

Sat, Nov 18

zlei added a comment to D42647: tcp: Prefer EINVAL in case function not found.

For average user EINVAL usually means that their input isn't correct. It is equally misleading as ENOENT. For more experienced user (I speculate) it is known that "file not found" actually means "entity no found".

Generally speaking, a more precise error number is valuable. But I think it is case by case.

Sat, Nov 18, 11:34 AM
zlei added inline comments to D42635: sockets: don't malloc/free sockaddr memory on accept(2).
Sat, Nov 18, 10:57 AM
zlei accepted D42635: sockets: don't malloc/free sockaddr memory on accept(2).

Looks good to me.

Sat, Nov 18, 10:37 AM

Fri, Nov 17

zlei requested review of D42647: tcp: Prefer EINVAL in case function not found.
Fri, Nov 17, 8:44 AM
zlei added inline comments to D42635: sockets: don't malloc/free sockaddr memory on accept(2).
Fri, Nov 17, 4:25 AM

Thu, Nov 16

zlei added a comment to D42489: Add kern.console_log_level for console log level.

During boot-up (or shutdown), when eventd/syslogd is not up, some conditional messages are too expensive to send to console by default

Do you have a measure how will this change improve?

Thu, Nov 16, 3:48 AM

Wed, Nov 15

zlei added inline comments to D42463: Teach if_smsc to get MAC from bootargs..
Wed, Nov 15, 7:42 AM
zlei added inline comments to D42463: Teach if_smsc to get MAC from bootargs..
Wed, Nov 15, 4:02 AM
zlei added inline comments to D42463: Teach if_smsc to get MAC from bootargs..
Wed, Nov 15, 3:36 AM
zlei accepted D42463: Teach if_smsc to get MAC from bootargs..

Looks good to me.

Wed, Nov 15, 2:20 AM

Mon, Nov 13

zlei committed rG281f61d211b3: bpf: Make dead_bpf_if const (authored by zlei).
bpf: Make dead_bpf_if const
Mon, Nov 13, 10:25 AM
zlei committed rG1e147980497b: bpf: Make dead_bpf_if const (authored by zlei).
bpf: Make dead_bpf_if const
Mon, Nov 13, 3:59 AM
zlei committed rGb388201875bf: veriexec: Simplify the initialization of loader tunable (authored by zlei).
veriexec: Simplify the initialization of loader tunable
Mon, Nov 13, 3:58 AM
zlei committed rG5d031613affa: bpf: Make dead_bpf_if const (authored by zlei).
bpf: Make dead_bpf_if const
Mon, Nov 13, 3:58 AM

Fri, Nov 10

zlei added a comment to D42530: kern linker: Do not try to unload kernel.

I tested FreeBSD-11.4-RELEASE-amd64-bootonly.iso which does not have d9ce8a41eac9 ,:

# kldunload kernel
kldunload: can't unload file: Device busy

There is also log kldunload: attempt to unload file that was loaded by the kernel from dmesg.

Fri, Nov 10, 7:17 PM

Nov 10 2023

zlei added a comment to D42530: kern linker: Do not try to unload kernel.

I was about to commit this I found that prior to d9ce8a41eac9 (kern_linker: Handle module-loading failures in preloaded .ko files) the kernel can not be unloaded.

Nov 10 2023, 9:32 AM
zlei added a reviewer for D42530: kern linker: Do not try to unload kernel: cem.
Nov 10 2023, 9:25 AM

Nov 9 2023

zlei requested review of D42530: kern linker: Do not try to unload kernel.
Nov 9 2023, 3:43 PM
zlei requested review of D42527: kern linker: Do not try to unload module if it has dependants.
Nov 9 2023, 10:06 AM
zlei added a comment to D42453: ibcore: Add dependency on "netstack".

There's no "netstack" module in the FreeBSD kernel. I think a DECLARE_MODULE needs added, probably to sys/net/if.c, before this works.

Nov 9 2023, 8:25 AM
zlei accepted D42477: if_tuntap: add support for receive side checksum offloading.

Looks good to me.

Nov 9 2023, 1:06 AM

Nov 8 2023

zlei added inline comments to D42477: if_tuntap: add support for receive side checksum offloading.
Nov 8 2023, 12:57 PM

Nov 7 2023

zlei added inline comments to D42477: if_tuntap: add support for receive side checksum offloading.
Nov 7 2023, 2:13 PM
zlei added inline comments to D42477: if_tuntap: add support for receive side checksum offloading.
Nov 7 2023, 9:42 AM
zlei added inline comments to D42477: if_tuntap: add support for receive side checksum offloading.
Nov 7 2023, 9:25 AM
zlei closed D42474: kern linker: Do not retry loading modules on EEXIST.
Nov 7 2023, 4:49 AM
zlei committed rGecf710f0e04e: kern linker: Do not retry loading modules on EEXIST (authored by zlei).
kern linker: Do not retry loading modules on EEXIST
Nov 7 2023, 4:49 AM
zlei added a comment to D42402: cam/ata: Postpone removal of two compat sysctl until 15.

Is there enough space in the message to help users by giving them a reference to the new interface to express the same configuration and what form of reference would work well for this?

Nov 7 2023, 1:00 AM

Nov 6 2023

zlei requested review of D42474: kern linker: Do not retry loading modules on EEXIST.
Nov 6 2023, 9:53 AM

Nov 5 2023

zlei added inline comments to D42463: Teach if_smsc to get MAC from bootargs..
Nov 5 2023, 3:02 AM
zlei added a reviewer for D42463: Teach if_smsc to get MAC from bootargs.: network.
Nov 5 2023, 2:58 AM

Nov 3 2023

zlei added a comment to D39695: freebsd-update: Add check for kernel modules.

Xref https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273907

Nov 3 2023, 1:20 PM
zlei committed rGbb8d4411e0c6: veriexec: Simplify the initialization of loader tunable (authored by zlei).
veriexec: Simplify the initialization of loader tunable
Nov 3 2023, 4:10 AM
zlei closed D42132: veriexec: Simplify the initialization of loader tunable.
Nov 3 2023, 4:10 AM

Nov 2 2023

zlei committed rG52dbe7401fba: Hyper-V: vmbus: Add NULL check for vmbus_res (authored by zlei).
Hyper-V: vmbus: Add NULL check for vmbus_res
Nov 2 2023, 9:17 AM
zlei committed rG1969d82fcf62: Hyper-V: vmbus: Add NULL check for vmbus_res (authored by zlei).
Hyper-V: vmbus: Add NULL check for vmbus_res
Nov 2 2023, 9:12 AM
zlei committed rG63bf943d4af1: Hyper-V: vmbus: Add NULL check for vmbus_res (authored by zlei).
Hyper-V: vmbus: Add NULL check for vmbus_res
Nov 2 2023, 9:10 AM
zlei closed D42414: Hyper-V: vmbus: Add NULL check for vmbus_res.
Nov 2 2023, 9:09 AM
zlei added inline comments to D42431: 14.0 relnotes: more additions and cleanups.
Nov 2 2023, 7:48 AM
zlei added a comment to D42414: Hyper-V: vmbus: Add NULL check for vmbus_res.

Ping @whu .

Nov 2 2023, 7:21 AM
zlei updated the summary of D42414: Hyper-V: vmbus: Add NULL check for vmbus_res.
Nov 2 2023, 7:20 AM
zlei updated the diff for D42414: Hyper-V: vmbus: Add NULL check for vmbus_res.

Address @whu 's comment.

Nov 2 2023, 6:36 AM
zlei committed rGd9e6e99a8525: cam/ata: Postpone removal of two compat sysctls until 15 (authored by zlei).
cam/ata: Postpone removal of two compat sysctls until 15
Nov 2 2023, 5:26 AM
zlei committed rG6c7ddf2c1437: cam/ata: Postpone removal of two compat sysctls until 15 (authored by zlei).
cam/ata: Postpone removal of two compat sysctls until 15
Nov 2 2023, 5:24 AM
zlei committed rGfb288d493989: cam/ata: Postpone removal of two compat sysctls until 15 (authored by zlei).
cam/ata: Postpone removal of two compat sysctls until 15
Nov 2 2023, 5:22 AM
zlei committed rGd24729b2fd66: cam/ata: Postpone removal of two compat sysctls until 15 (authored by zlei).
cam/ata: Postpone removal of two compat sysctls until 15
Nov 2 2023, 5:18 AM
zlei closed D42402: cam/ata: Postpone removal of two compat sysctl until 15.
Nov 2 2023, 5:18 AM
zlei committed rG2dedf41fde95: Giant: Postpone removal of Giant-locked drivers until 15 (authored by zlei).
Giant: Postpone removal of Giant-locked drivers until 15
Nov 2 2023, 4:33 AM
zlei committed rG326adc0726cf: isa: Postpone removal of the non-PNP driver until 15 (authored by zlei).
isa: Postpone removal of the non-PNP driver until 15
Nov 2 2023, 4:33 AM
zlei added a comment to D42414: Hyper-V: vmbus: Add NULL check for vmbus_res.
In D42414#968057, @zlei wrote:

@schakrabarti_microsoft.com @andrew

From the review D41728 I guess on x86 there should have hardware coherency.

I might get wrong place but did not find any useful information about "Coherency" or "vmbus_res" or "_CCA" from the public document [1].
So is the "Coherency attribute" is ARM64 specific ?
Then we may want coherent default to true on x86 and false on ARM64.

  1. https://github.com/MicrosoftDocs/Virtualization-Documentation

It does not exactly answer the question, but the BUS_DMA_COHERENT flag has no effect on the x86 busdma implementation.

Nov 2 2023, 3:08 AM
zlei added inline comments to D42414: Hyper-V: vmbus: Add NULL check for vmbus_res.
Nov 2 2023, 3:01 AM
zlei updated subscribers of D42414: Hyper-V: vmbus: Add NULL check for vmbus_res.
Nov 2 2023, 1:08 AM

Nov 1 2023

zlei added a reviewer for D42429: Kernel crash on nd6_dad_timer: network.
Nov 1 2023, 4:42 PM
zlei accepted D42386: tcp rack: remove references to rb trees.

It is definitely the right fix.

Nov 1 2023, 4:39 PM
zlei committed rGe9ad6b456b02: Giant: Postpone removal of Giant-locked drivers until 15 (authored by zlei).
Giant: Postpone removal of Giant-locked drivers until 15
Nov 1 2023, 4:26 PM
zlei committed rG5019a5acc5b0: Giant: Postpone removal of Giant-locked drivers until 15 (authored by zlei).
Giant: Postpone removal of Giant-locked drivers until 15
Nov 1 2023, 4:24 PM
zlei added a comment to D42402: cam/ata: Postpone removal of two compat sysctl until 15.

A friendly ping before committing this.

Nov 1 2023, 4:16 PM
zlei updated subscribers of D42414: Hyper-V: vmbus: Add NULL check for vmbus_res.

From the review D41728 I guess on x86 there should have hardware coherency.

Nov 1 2023, 9:33 AM

Oct 31 2023

zlei retitled D42402: cam/ata: Postpone removal of two compat sysctl until 15 from cam/ata: Postpone removal of two sysctl knobs until 15 to cam/ata: Postpone removal of two compat sysctl until 15.
Oct 31 2023, 2:47 PM
zlei added inline comments to D42402: cam/ata: Postpone removal of two compat sysctl until 15.
Oct 31 2023, 2:46 PM
zlei updated the summary of D42414: Hyper-V: vmbus: Add NULL check for vmbus_res.
Oct 31 2023, 2:03 PM
zlei requested review of D42414: Hyper-V: vmbus: Add NULL check for vmbus_res.
Oct 31 2023, 2:01 PM
zlei added a comment to D42402: cam/ata: Postpone removal of two compat sysctl until 15.

Address @ken 's comments.

Oct 31 2023, 1:21 PM
zlei updated the diff for D42402: cam/ata: Postpone removal of two compat sysctl until 15.
Oct 31 2023, 1:19 PM
zlei committed rGa8bd34bfc0db: Giant: Postpone removal of Giant-locked drivers until 15 (authored by zlei).
Giant: Postpone removal of Giant-locked drivers until 15
Oct 31 2023, 12:49 PM
zlei closed D42401: Giant: Postpone removal of Giant until 15.
Oct 31 2023, 12:49 PM
zlei added a comment to D42402: cam/ata: Postpone removal of two compat sysctl until 15.
In D42402#967566, @ken wrote:

This makes it sound like unmapped I/O and rotating media support will be removed in FreeBSD 15.

From the context, I think you just mean that the separate sysctl variables to control those settings will be removed, not the underlying support. Is that correct?

Oct 31 2023, 3:54 AM

Oct 30 2023

zlei added inline comments to D38425: bridge: Further decompose GRAB_OUR_PACKETS.
Oct 30 2023, 2:05 PM
zlei accepted D42392: libpfctl: be more tolerant of kernel extensions.

Looks good to me.

Oct 30 2023, 1:57 PM
zlei requested review of D42402: cam/ata: Postpone removal of two compat sysctl until 15.
Oct 30 2023, 8:43 AM
zlei requested review of D42401: Giant: Postpone removal of Giant until 15.
Oct 30 2023, 8:34 AM
zlei committed rGac34d3cd6840: isa: Postpone removal of the non-PNP driver until 15 (authored by zlei).
isa: Postpone removal of the non-PNP driver until 15
Oct 30 2023, 12:58 AM
zlei committed rG699526792d2f: isa: Postpone removal of the non-PNP driver until 15 (authored by zlei).
isa: Postpone removal of the non-PNP driver until 15
Oct 30 2023, 12:56 AM

Oct 28 2023

zlei added a comment to D42391: ethernet: Remove FCS bit.

This is a breaking change. 3rd party drivers should take care of it.

Oct 28 2023, 8:42 PM
zlei retitled D42391: ethernet: Remove FCS bit from ethernet: Remove FCS check to ethernet: Remove FCS bit.
Oct 28 2023, 8:39 PM
zlei requested review of D42391: ethernet: Remove FCS bit.
Oct 28 2023, 8:39 PM