Page MenuHomeFreeBSD

zlei (Zhenlei Huang)
User

Projects

User Details

User Since
Apr 1 2021, 3:21 AM (223 w, 6 d)

Recent Activity

Yesterday

zlei updated the summary of D51295: qlnxe: Fix build with INET.
Wed, Jul 16, 4:45 PM
zlei requested review of D51351: qlnxe: Fix SIOCGI2C ioctl.
Wed, Jul 16, 4:45 PM

Tue, Jul 15

zlei closed D50947: ethernet: Move the assertion of ether header sizes back into ethernet.h.
Tue, Jul 15, 3:33 PM
zlei committed rGdb8296ff38cd: ethernet: Move the assertion of ether header sizes back into ethernet.h (authored by zlei).
ethernet: Move the assertion of ether header sizes back into ethernet.h
Tue, Jul 15, 3:33 PM
zlei added a comment to D50947: ethernet: Move the assertion of ether header sizes back into ethernet.h.

P.S. Why do you want to merge that to a stable branch?

The structs has __packed attribute so it is unlikely to have wrong size. Well I'm a little paranoiac that may happen in some way :)

It is not about observing a different size, but about the _Static_assert() not being support by some compiler with some flags. The risk is low of course. But practical benefits of having change in STABLE are also very low.

Tue, Jul 15, 3:17 PM
zlei added a comment to D50947: ethernet: Move the assertion of ether header sizes back into ethernet.h.

Please include the link to the exp-run bugzilla into the commit message.

P.S. Why do you want to merge that to a stable branch?

Tue, Jul 15, 2:54 AM

Mon, Jul 14

zlei added a comment to D50947: ethernet: Move the assertion of ether header sizes back into ethernet.h.

The exp-run looks good. Any objections ?

Mon, Jul 14, 10:39 AM
zlei added a comment to D51297: if_gif(4): Support the NOCLAMP flag to change the MTU handling for IPv6.

I like the word noclamp. Well, there're other tunneling interfaces such as if_gre, if_vxlan and if_wg. Will we introduce too many XX_NOCLAP flags for other types of tunneling interfaces?

Mon, Jul 14, 10:34 AM
zlei requested review of D51295: qlnxe: Fix build with INET.
Mon, Jul 14, 3:39 AM

Sat, Jul 12

zlei accepted D51245: tests/sys/net/if_bridge_test: fix MTU test.

Looks good to me.

Sat, Jul 12, 2:39 PM

Tue, Jul 8

zlei committed rG0a5e8108bf20: pfsync: Allocate and initialize buckets before attaching the interface (authored by zlei).
pfsync: Allocate and initialize buckets before attaching the interface
Tue, Jul 8, 10:06 AM
zlei committed rG9d53e7eaab9e: pfsync: Destroy buckets mutexes on clone destroying interface (authored by zlei).
pfsync: Destroy buckets mutexes on clone destroying interface
Tue, Jul 8, 10:06 AM
zlei committed rG2db01aea744f: pfsync: Remove a redundant assignment of if_type (authored by zlei).
pfsync: Remove a redundant assignment of if_type
Tue, Jul 8, 10:06 AM
zlei committed rG12a1baa42bd0: bridge: Remove a redundant assignment of if_type (authored by zlei).
bridge: Remove a redundant assignment of if_type
Tue, Jul 8, 10:06 AM
zlei committed rG56a81f37332a: ng_iface(4): Remove a redundant assignment of if_type (authored by zlei).
ng_iface(4): Remove a redundant assignment of if_type
Tue, Jul 8, 10:06 AM
zlei committed rGe59f60d3c08c: if_vlan: Fix up if_type before attaching the interface (authored by zlei).
if_vlan: Fix up if_type before attaching the interface
Tue, Jul 8, 10:06 AM
zlei committed rGafaa32661b48: axgbe: Fix setting promisc mode (authored by zlei).
axgbe: Fix setting promisc mode
Tue, Jul 8, 10:06 AM

Mon, Jul 7

zlei committed rG8cc376735c65: pfsync: Allocate and initialize buckets before attaching the interface (authored by zlei).
pfsync: Allocate and initialize buckets before attaching the interface
Mon, Jul 7, 10:10 AM
zlei committed rGefbaf14c5b68: pfsync: Destroy buckets mutexes on clone destroying interface (authored by zlei).
pfsync: Destroy buckets mutexes on clone destroying interface
Mon, Jul 7, 10:10 AM
zlei committed rGff54b680383b: if_vlan: Fix up if_type before attaching the interface (authored by zlei).
if_vlan: Fix up if_type before attaching the interface
Mon, Jul 7, 10:10 AM
zlei committed rG99d4e2870c03: ifnet: Eliminate unnecessary synchronization of the interface index in the link… (authored by zlei).
ifnet: Eliminate unnecessary synchronization of the interface index in the link…
Mon, Jul 7, 10:10 AM
zlei committed rG3bb09e6b1930: ethernet: Set maximum Ethernet header length based on the capability… (authored by zlei).
ethernet: Set maximum Ethernet header length based on the capability…
Mon, Jul 7, 10:09 AM
zlei committed rG193f0bde3b04: bridge: Remove a redundant assignment of if_type (authored by zlei).
bridge: Remove a redundant assignment of if_type
Mon, Jul 7, 10:09 AM
zlei committed rG082a6da890f3: pfsync: Remove a redundant assignment of if_type (authored by zlei).
pfsync: Remove a redundant assignment of if_type
Mon, Jul 7, 10:09 AM
zlei committed rG3da0853d7119: ng_iface(4): Remove a redundant assignment of if_type (authored by zlei).
ng_iface(4): Remove a redundant assignment of if_type
Mon, Jul 7, 10:09 AM
zlei committed rG1ddf7942c331: git-blame-ignore-revs: iflib style(9) tweaks (authored by zlei).
git-blame-ignore-revs: iflib style(9) tweaks
Mon, Jul 7, 10:09 AM
zlei committed rGa2989d11eabe: iflib: Some style(9) tweaks (authored by zlei).
iflib: Some style(9) tweaks
Mon, Jul 7, 10:09 AM
zlei committed rG3bc1aea4cc8a: if_firewire: Make firewire_broadcastaddr static const (authored by zlei).
if_firewire: Make firewire_broadcastaddr static const
Mon, Jul 7, 10:09 AM
zlei committed rG2466a1871154: ifnet: Initialize the address family dependent data region earlier (authored by zlei).
ifnet: Initialize the address family dependent data region earlier
Mon, Jul 7, 10:09 AM
zlei committed rG077895676d3b: UPDATING: Add an entry for the removal of in6_maxmtu (authored by zlei).
UPDATING: Add an entry for the removal of in6_maxmtu
Mon, Jul 7, 10:08 AM
zlei committed rGf5195b1a63df: netinet6: Remove a set but not used global variable in6_maxmtu (authored by zlei).
netinet6: Remove a set but not used global variable in6_maxmtu
Mon, Jul 7, 10:08 AM
zlei committed rG839b9596b35d: axgbe: Fix setting promisc mode (authored by zlei).
axgbe: Fix setting promisc mode
Mon, Jul 7, 10:08 AM
zlei committed rG8ba6d328fdf8: git-blame-ignore-revs: sys/sys/kernel.h: Various whitespace fixes (authored by zlei).
git-blame-ignore-revs: sys/sys/kernel.h: Various whitespace fixes
Mon, Jul 7, 10:08 AM
zlei committed rGf0931a31f536: git-blame-ignore-revs: iflib: Many style fixes (authored by zlei).
git-blame-ignore-revs: iflib: Many style fixes
Mon, Jul 7, 10:07 AM
zlei committed rG72652c93e396: git-blame-ignore-revs: bpf: Some style and white space cleanup (authored by zlei).
git-blame-ignore-revs: bpf: Some style and white space cleanup
Mon, Jul 7, 10:07 AM

Sat, Jul 5

zlei added a comment to D51157: if_epair(4): use ether_gen_addr(9) for stable MAC address.

For hardware interfaces, the hardware address is a nature of the interface, regardless of its name or host uuid or jail name.

Sat, Jul 5, 2:44 AM

Thu, Jul 3

zlei added inline comments to D51139: Clarify the purpose of interface groups in ifconfig(8).
Thu, Jul 3, 7:03 AM

Tue, Jul 1

zlei accepted D50241: Teach ngctl to attach and run itself in a jail..
Tue, Jul 1, 12:58 AM

Sat, Jun 28

zlei committed rGedc307eca9a9: pfsync: Allocate and initialize buckets before attaching the interface (authored by zlei).
pfsync: Allocate and initialize buckets before attaching the interface
Sat, Jun 28, 3:49 PM
zlei committed rG8213c07c2058: pfsync: Destroy buckets mutexes on clone destroying interface (authored by zlei).
pfsync: Destroy buckets mutexes on clone destroying interface
Sat, Jun 28, 3:49 PM
zlei closed D51064: pfsync: Allocate and initialize buckets before attaching the interface.
Sat, Jun 28, 3:49 PM
zlei closed D51063: pfsync: Destroy mutexes on clone destroying interface.
Sat, Jun 28, 3:49 PM

Fri, Jun 27

zlei added a comment to D51067: (draft) if: Ensure additions to groups are visible to readers.

That fence should be too much, and CK_STAILQ_INSERT_TAIL() is supposed to insert a proper store to store barrier, so this is probably a mistake, but if possible I'd like to know if that changes something in practice.

Fri, Jun 27, 3:07 AM

Thu, Jun 26

zlei closed D50914: if_vlan: Fix up the if_type prior to attaching the interface.
Thu, Jun 26, 4:41 PM
zlei committed rGa19b353d354d: if_vlan: Fix up if_type before attaching the interface (authored by zlei).
if_vlan: Fix up if_type before attaching the interface
Thu, Jun 26, 4:41 PM
zlei requested review of D51064: pfsync: Allocate and initialize buckets before attaching the interface.
Thu, Jun 26, 2:04 PM
zlei requested review of D51063: pfsync: Destroy mutexes on clone destroying interface.
Thu, Jun 26, 2:02 PM

Wed, Jun 25

zlei accepted D50505: bridge.4: clarify vlan support status.
Wed, Jun 25, 10:01 AM
zlei accepted D50504: allow vlan(4) interfaces to be created on a bridge(4).

Generally looks good to me.

Wed, Jun 25, 10:00 AM

Tue, Jun 24

zlei closed D50975: ifnet: Eliminate unnecessary synchronization of the interface index in the link layer address.
Tue, Jun 24, 10:02 AM
zlei committed rG0b4c4833ee3e: ifnet: Eliminate unnecessary synchronization of the interface index in the link… (authored by zlei).
ifnet: Eliminate unnecessary synchronization of the interface index in the link…
Tue, Jun 24, 10:02 AM
zlei added a comment to D50947: ethernet: Move the assertion of ether header sizes back into ethernet.h.

I intended to MFC this to stable/14, but stable/14 still has gnu99 as the default.

But this header is also used outside of the base system, isn't it? This could break applications using ethernet.h compiled with -pedantic -std=c99 -Werror, for instance. I'm not sure if any exist, but an exp-run would be a good idea IMO.

That is exactly what I concerned. Or I push this in main and later do exp-run before the MFCing ?

It would be better to do the exp-run first, I think. There may be enough failures that this change is not worthwhile.

Tue, Jun 24, 9:51 AM

Mon, Jun 23

zlei requested review of D50975: ifnet: Eliminate unnecessary synchronization of the interface index in the link layer address.
Mon, Jun 23, 8:28 AM

Sat, Jun 21

zlei closed D50846: ethernet: Set maximum Ethernet header length based on the capability IFCAP_VLAN_MTU.
Sat, Jun 21, 3:28 PM
zlei committed rG6ce8fd1978a9: ethernet: Set maximum Ethernet header length based on the capability… (authored by zlei).
ethernet: Set maximum Ethernet header length based on the capability…
Sat, Jun 21, 3:28 PM
zlei added a comment to D50947: ethernet: Move the assertion of ether header sizes back into ethernet.h.

I intended to MFC this to stable/14, but stable/14 still has gnu99 as the default.

But this header is also used outside of the base system, isn't it? This could break applications using ethernet.h compiled with -pedantic -std=c99 -Werror, for instance. I'm not sure if any exist, but an exp-run would be a good idea IMO.

Sat, Jun 21, 3:26 PM

Fri, Jun 20

zlei added a comment to D50947: ethernet: Move the assertion of ether header sizes back into ethernet.h.

I intended to MFC this to stable/14, but stable/14 still has gnu99 as the default. Modern compilers used by FreeBSD support _Static_assert so for in-tree consumes the MFC should be safe, then how about the out-of-tree consumes ?

Fri, Jun 20, 5:30 AM
zlei requested review of D50947: ethernet: Move the assertion of ether header sizes back into ethernet.h.
Fri, Jun 20, 5:19 AM

Wed, Jun 18

zlei requested review of D50914: if_vlan: Fix up the if_type prior to attaching the interface.
Wed, Jun 18, 4:58 AM

Jun 16 2025

zlei committed rGa07604e6264b: bridge: Remove a redundant assignment of if_type (authored by zlei).
bridge: Remove a redundant assignment of if_type
Jun 16 2025, 2:46 PM
zlei committed rG48af70e7c821: pfsync: Remove a redundant assignment of if_type (authored by zlei).
pfsync: Remove a redundant assignment of if_type
Jun 16 2025, 2:13 PM

Jun 14 2025

zlei updated subscribers of D50846: ethernet: Set maximum Ethernet header length based on the capability IFCAP_VLAN_MTU.
Jun 14 2025, 4:08 PM
zlei added a comment to D50846: ethernet: Set maximum Ethernet header length based on the capability IFCAP_VLAN_MTU.

In-tree drivers will be cleaned up in following up commits. I intended to mention this behavior change in UPDATING, but 3rd party shall not be affected, if they FIX the header length after attaching the interface.

Jun 14 2025, 3:27 PM
zlei requested review of D50846: ethernet: Set maximum Ethernet header length based on the capability IFCAP_VLAN_MTU.
Jun 14 2025, 3:22 PM

Jun 13 2025

zlei committed rGc43d6dadf7e3: ng_iface(4): Remove a redundant assignment of if_type (authored by zlei).
ng_iface(4): Remove a redundant assignment of if_type
Jun 13 2025, 10:14 AM
zlei accepted D50819: qlnx: fix panic at startup.
Jun 13 2025, 3:29 AM

Jun 6 2025

zlei requested review of D50713: iflib: Make iflib_register() return void.
Jun 6 2025, 10:17 AM
zlei added inline comments to D50712: iflib: Set the get counter routine prior to attaching the interface.
Jun 6 2025, 10:16 AM
zlei requested review of D50712: iflib: Set the get counter routine prior to attaching the interface.
Jun 6 2025, 10:14 AM
zlei committed rG898a886b4504: git-blame-ignore-revs: iflib style(9) tweaks (authored by zlei).
git-blame-ignore-revs: iflib style(9) tweaks
Jun 6 2025, 10:08 AM
zlei committed rG721e783a2a33: iflib: Some style(9) tweaks (authored by zlei).
iflib: Some style(9) tweaks
Jun 6 2025, 10:08 AM

Jun 1 2025

zlei committed rGad5eecbfca54: ifnet: Integrate if_unroute() into if_down() (authored by zlei).
ifnet: Integrate if_unroute() into if_down()
Jun 1 2025, 3:41 PM
zlei committed rGc20e7eb53d47: ifnet: Fix a typo in a source code comment (authored by zlei).
ifnet: Fix a typo in a source code comment
Jun 1 2025, 3:41 PM
zlei committed rG517eb20e54e5: if_firewire: Make firewire_broadcastaddr static const (authored by zlei).
if_firewire: Make firewire_broadcastaddr static const
Jun 1 2025, 2:48 PM

May 29 2025

zlei added a comment to D50558: alc(4): always disable MSI-X by default.

i am not 100% convinced this is a hardware problem since Linux appears to enable MSI-X by default, but either way it doesn't work.

May 29 2025, 7:13 AM
zlei added a comment to D50558: alc(4): always disable MSI-X by default.
In D50558#1154278, @ivy wrote:

@ivy Any details which parts have the same problem ?

it was reported on AR8171:

alc0@pci0:3:0:0: class=0x020000 rev=0x10 hdr=0x00 vendor=0x1969 device=0x10a1 subvendor=0x1849 subdevice=0x10a1
vendor = 'Qualcomm Atheros'
device = 'QCA8171 Gigabit Ethernet'
class = network
subclass = ethernet

i am not 100% convinced this is a hardware problem since Linux appears to enable MSI-X by default, but either way it doesn't work. (i spent a long time looking at this originally and could not work out what Linux was doing differently, and hardware documentation seems to be unavailable.)

May 29 2025, 7:05 AM
zlei accepted D50567: if_vlan: add a prototype for vlan_input_p.

Looks good to me.

May 29 2025, 4:53 AM
zlei added inline comments to D50241: Teach ngctl to attach and run itself in a jail..
May 29 2025, 3:33 AM

May 28 2025

zlei added a comment to D50558: alc(4): always disable MSI-X by default.

User reports indicate that at least some other AR81xx parts have the same problem

May 28 2025, 4:00 AM

May 24 2025

zlei added a reviewer for D50491: bnxt: Fix the request length specified in bnxt_hwrm_func_backing_store_cfg: sumit.saxena_broadcom.com.
May 24 2025, 2:18 AM
zlei added a comment to D50491: bnxt: Fix the request length specified in bnxt_hwrm_func_backing_store_cfg.

I do not have any hardware to test this change, but it appear to be a regression by mistake.

May 24 2025, 2:17 AM

May 22 2025

zlei accepted D50241: Teach ngctl to attach and run itself in a jail..

Generally looks good to me, despite the order of the new option -j jail.

May 22 2025, 3:23 PM
zlei added a comment to D50241: Teach ngctl to attach and run itself in a jail..

Also add @dfr as reviewer. I guess he will be interested with this feature :)

May 22 2025, 3:18 PM
zlei added a reviewer for D50241: Teach ngctl to attach and run itself in a jail.: dfr.
May 22 2025, 3:17 PM
zlei closed D49358: ifnet: Initialize address family dependent data region earlier.
May 22 2025, 3:02 PM
zlei committed rG098b5d4dc744: ifnet: Initialize the address family dependent data region earlier (authored by zlei).
ifnet: Initialize the address family dependent data region earlier
May 22 2025, 3:02 PM
zlei accepted D50461: icmp6: zero out pad space.

Looks good to me.

May 22 2025, 2:24 PM
zlei added a comment to D50460: icmp6: fix use-after-reference-release.

I think this change is not necessary, but the comment should be revised instead. Is there any issue caused by referencing a released ifa ?

May 22 2025, 2:18 PM

May 21 2025

zlei accepted D50455: carp: fix mbuf_tag usage in carp_macmatch6.

Looks good to me.

May 21 2025, 2:00 PM
zlei committed rGc485a58f5160: UPDATING: Add an entry for the removal of in6_maxmtu (authored by zlei).
UPDATING: Add an entry for the removal of in6_maxmtu
May 21 2025, 10:13 AM
zlei closed D49357: netinet6: Remove set but not used global variable in6_maxmtu.
May 21 2025, 10:13 AM
zlei committed rGe64fe5ad3a23: netinet6: Remove a set but not used global variable in6_maxmtu (authored by zlei).
netinet6: Remove a set but not used global variable in6_maxmtu
May 21 2025, 10:13 AM
zlei added a comment to D49358: ifnet: Initialize address family dependent data region earlier.

This looks correct to me.
Does it fix any uninitialized af_data races? If it does, that is a strong MFC candidate.

May 21 2025, 10:04 AM
zlei accepted D50413: ifconfig: reject netmask and broadcast for inet6.
May 21 2025, 3:31 AM

May 20 2025

zlei committed rG0693c3f7cb3d: ifnet: Integrate if_unroute() into if_down() (authored by zlei).
ifnet: Integrate if_unroute() into if_down()
May 20 2025, 3:47 PM
zlei closed D49356: ifnet: Integrate if_unroute() into if_down().
May 20 2025, 3:47 PM
zlei added inline comments to D50413: ifconfig: reject netmask and broadcast for inet6.
May 20 2025, 9:10 AM

May 19 2025

zlei accepted D50413: ifconfig: reject netmask and broadcast for inet6.

Generally looks good to me.

May 19 2025, 10:08 AM
zlei committed rGad2d7e594f6d: ifnet: Fix a typo in a source code comment (authored by zlei).
ifnet: Fix a typo in a source code comment
May 19 2025, 4:37 AM

May 12 2025

zlei added a comment to D50303: HW Relnotes: Add a section for Etherswitch.

I think that is a good approach. I have ever ( about 2020 ) tried to find ethernet switches supported by FreeBSD and finally found them in the src. It will be better to have them mentioned in the website.

May 12 2025, 7:15 AM