iflib: Set the get counter routine prior to attaching the interface
ClosedPublic
Actions

Authored by zlei on Jun 6 2025, 10:14 AM.

Details

Reviewers

shurd
kbowling
kgalazka

Group Reviewers

iflib

Commits

rG04741ceafa2c: iflib: Set the get counter routine prior to attaching the interface
rGae7f8da8bf6e: iflib: Set the get counter routine prior to attaching the interface

Summary

This ensures other threads see the correct counter routine once the interface has been attached.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Jun 6 2025, 10:14 AM

Herald added 1 blocking reviewer(s): iflib. · View Herald TranscriptJun 6 2025, 10:14 AM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald Transcript

zlei requested review of this revision.Jun 6 2025, 10:14 AM

zlei added inline comments.

sys/net/iflib.c
5363	This was changed in 23ac9029f96b2 , but without a clue why that is required.

@zlei do you know if all the consumer ifdi_get_counter implementations will still have been initialized correctly, for instance not making invalid references? It seems fine as long as there are no implicit initialization issues that relied on the current behavior.

In D50712#1191825, @kbowling wrote:

@zlei do you know if all the consumer ifdi_get_counter implementations will still have been initialized correctly, for instance not making invalid references? It seems fine as long as there are no implicit initialization issues that relied on the current behavior.

The ifdi_get_counter will only be invoked after the interface been attached. At that point the ifdi_get_counter implementations should see already initialized softc and ifnet. So I believe there is no initialization issues right now.

kbowling accepted this revision.Aug 27 2025, 3:52 AM

This revision is now accepted and ready to land.Aug 27 2025, 3:52 AM

PS: This fix is part of my overhauling of the interface attaching / detaching process. But I think I can be a standalone fixed.

kgalazka accepted this revision.Aug 27 2025, 9:10 AM

Closed by commit rGae7f8da8bf6e: iflib: Set the get counter routine prior to attaching the interface (authored by zlei). · Explain WhyAug 30 2025, 3:25 PM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rGae7f8da8bf6e: iflib: Set the get counter routine prior to attaching the interface.

zlei added a commit: rG04741ceafa2c: iflib: Set the get counter routine prior to attaching the interface.Sat, Sep 27, 3:14 PM