Page MenuHomeFreeBSD

kgalazka (Krzysztof Galazka)
User

Projects (3)

User Details

User Since
Jan 4 2016, 7:08 PM (567 w, 3 d)

Recent Activity

Wed, Nov 18

kgalazka accepted D61453: ixgbe: Apply EEE policy through serialized initialization.

I'm sorry for keeping you waiting. Let's go with current version to get the lock issue fixed. Any changes resulting from the UX and firmware link-management discussion can be handled in a follow-up patch.

Wed, Nov 18, 5:15 PM

Thu, Nov 12

kgalazka requested changes to D61453: ixgbe: Apply EEE policy through serialized initialization.
Thu, Nov 12, 10:23 AM

Tue, Nov 10

kgalazka accepted D61279: iflib: simplify TXQ_AVAIL.

LGTM assuming commit message is fixed, as pointed out by kbowling.

Tue, Nov 10, 1:44 PM

Mon, Nov 9

kgalazka added a comment to D61109: ice: Apply DCB queue mappings inside normal initialization.

instead of:

Mon, Nov 9, 1:58 PM

Fri, Nov 6

kgalazka accepted D60965: ice: Hash UDP and SCTP across the receive queues.

Thank you for looking into this! In general it looks good to me. I'm only wondering if tunneled packets are handled correctly. With ICE_RSS_ANY_HEADERS set HW uses inner header fields for hash calculation, but ice_ptype_to_hash uses outer ip_ver and inner protocol so e.g for IPv6 --> GRE/NAT -> IPv4 -> UDP we will get M_HASHTYPE_RSS_IPV6. Does it make sense?

Fri, Nov 6, 10:21 AM

Thu, Nov 5

kgalazka committed rGae65253312b0: ice(4): Do not leave device non-functional if Tx scheduler config fails (authored by pawel.sobczyk_intel.com).
Thu, Nov 5, 3:13 PM

Tue, Nov 3

kgalazka added a reviewer for D58325: irdma: improve validation checks further: bartosz.sobczak_intel.com.
Tue, Nov 3, 9:59 PM
kgalazka accepted D61144: ixgbe: Guard E610 ldo function.

Ouch :( my apologies for this oversight. ixgbe_apply_ldo_link_state is guarded by !sc->ldo_valid so it should be fine.

Tue, Nov 3, 9:17 PM

Mon, Nov 2

kgalazka committed rG7868958f5c79: ix(4): Support Total Port Shutdown on E610.
Mon, Nov 2, 11:20 AM
kgalazka closed D60643: ix(4): Support Total Port Shutdown on E610.
Mon, Nov 2, 11:20 AM
kgalazka committed rG013f1779f634: ice(4): Do not leave device non-functional if Tx scheduler config fails (authored by pawel.sobczyk_intel.com).
Mon, Nov 2, 7:35 AM
kgalazka closed D60168: ice(4): Do not leave device non-functional if Tx scheduler config fails.
Mon, Nov 2, 7:35 AM

Fri, Oct 30

kgalazka added a reviewer for D60405: ibcore: Avoid quadratic uverbs ID allocation: slavash.
Fri, Oct 30, 9:55 AM
kgalazka added reviewers for D60405: ibcore: Avoid quadratic uverbs ID allocation: jhb, kib.
Fri, Oct 30, 9:53 AM

Thu, Oct 29

kgalazka committed rG8b5c666591ae: ice(4): Support Total Port Shutdown on E830 devices (authored by pawel.sobczyk_intel.com).
Thu, Oct 29, 8:45 AM
kgalazka committed rG2b6479e5b5c7: ice(4): Fix link bringup on driver load.
Thu, Oct 29, 8:45 AM
kgalazka committed rG8e55febde6b5: ixl(4): Fix NVM update API.
Thu, Oct 29, 8:42 AM

Wed, Oct 21

kgalazka added inline comments to D60175: iflib: Use a single tx dma map.
Wed, Oct 21, 7:18 PM

Oct 15 2026

kgalazka added a comment to D60175: iflib: Use a single tx dma map.

The ICE version of the sparse check does the right thing. Both the X700 and E800 generations of adapters have the same limits: a header can span at most three descriptors, and a single frame can span up to eight. I guess this wasn't backported from ICE to IXL (and IAVF?) due to my oversight.

Oct 15 2026, 8:33 PM

Oct 12 2026

kgalazka requested review of D60643: ix(4): Support Total Port Shutdown on E610.
Oct 12 2026, 12:28 PM
kgalazka added a comment to D60638: iflib: Keep queue interrupt filters safe across detach.

I'm seeing this kernel panic when unloading IAVF. A queue interrupt firing after iflib_stop() shouldn't be possible, so I'm investigating the issue in the driver itself. However, I think this patch makes sense on its own.

Oct 12 2026, 9:43 AM
kgalazka requested review of D60638: iflib: Keep queue interrupt filters safe across detach.
Oct 12 2026, 9:31 AM

Oct 6 2026

kgalazka updated the diff for D60368: whereis(1): Fix sourcedirs array size calculation.
  • Implement fernape@ suggestion.
Oct 6 2026, 4:49 PM
kgalazka updated the diff for D60368: whereis(1): Fix sourcedirs array size calculation.
  • Revert the sizeof change as new version was less readable.
Oct 6 2026, 8:17 AM

Oct 5 2026

kgalazka added inline comments to D60371: iflib: Make the deferral test in iflib_txd_db_check() an early return.
Oct 5 2026, 3:36 PM
kgalazka accepted D60290: iflib: Do not ring the transmit doorbell when nothing is pending.
Oct 5 2026, 3:18 PM
kgalazka requested review of D60368: whereis(1): Fix sourcedirs array size calculation.
Oct 5 2026, 2:52 PM

Sep 29 2026

kgalazka committed rG48b29e9e54c5: loader.efi: Retain standalone network configuration.
Sep 29 2026, 7:58 PM
kgalazka closed D59999: loader.efi: Retain standalone network configuration.
Sep 29 2026, 7:57 PM
kgalazka committed rGc4640126f116: loader.efi: Apply command-line DHCP overrides earlier.
Sep 29 2026, 7:56 PM
kgalazka closed D59998: loader.efi: Apply command-line DHCP overrides earlier.
Sep 29 2026, 7:56 PM
kgalazka updated the diff for D59998: loader.efi: Apply command-line DHCP overrides earlier.
  • Collapse the bootp.c TAG_ROOTPATH branch to a plain strlcpy
Sep 29 2026, 2:41 PM

Sep 28 2026

kgalazka added a comment to D59578: ice(4): Fix link bringup on driver load.

Are you waiting for internal validation? I don't like keeping head in a known broken state this long if their findings can be posted as a followup.

Sep 28 2026, 12:08 PM
kgalazka committed rGdcb84ddcfe89: ice(4): Fix link bringup on driver load.
Sep 28 2026, 11:54 AM
kgalazka closed D59578: ice(4): Fix link bringup on driver load.
Sep 28 2026, 11:54 AM

Sep 25 2026

kgalazka updated the diff for D59998: loader.efi: Apply command-line DHCP overrides earlier.
  • Address @imp comment.
Sep 25 2026, 2:02 PM

Sep 24 2026

kgalazka requested review of D59999: loader.efi: Retain standalone network configuration.
Sep 24 2026, 8:48 PM
kgalazka requested review of D59998: loader.efi: Apply command-line DHCP overrides earlier.
Sep 24 2026, 8:48 PM

Sep 18 2026

kgalazka updated the diff for D59578: ice(4): Fix link bringup on driver load.

Address @kbowling comment.

Sep 18 2026, 10:22 AM

Sep 10 2026

kgalazka added a comment to D59300: ice: Refresh link status on first initialization.

@kbowling - This should fix both issues you have found: https://reviews.freebsd.org/D59578

Sep 10 2026, 8:13 PM
kgalazka requested review of D59578: ice(4): Fix link bringup on driver load.
Sep 10 2026, 8:12 PM

Sep 9 2026

kgalazka added a comment to D59300: ice: Refresh link status on first initialization.

The problem comes from https://reviews.freebsd.org/D58149. I don't know how it slipped through internal testing, but I think I found a root cause. I'll submit a fix for review this week.

Sep 9 2026, 6:45 PM

Sep 7 2026

kgalazka added a comment to D59300: ice: Refresh link status on first initialization.

This is odd. I can reproduce this also on E830 QSFP adapters, which I used quite recently without any link issues. I'm looking into which patch might have caused the regression.

Sep 7 2026, 7:43 PM

Sep 2 2026

kgalazka added inline comments to D59321: iflib: update rs_pending based on descriptors consumed by isc_txd_encap.
Sep 2 2026, 7:49 PM

Sep 1 2026

kgalazka accepted D58776: rtnetlink: Add native SR-IOV VF status.

LGTM

Sep 1 2026, 3:13 PM
kgalazka added inline comments to D58778: ifconfig: Add SR-IOV VF status output.
Sep 1 2026, 1:26 PM
kgalazka committed rGe0954f796757: ix(4): Sanitize negative error codes (authored by pawel.sobczyk_intel.com).
Sep 1 2026, 9:21 AM
kgalazka committed rG05ef2394a193: ix(4): Remove workaround for 2.5/5G speeds on E610.
Sep 1 2026, 9:21 AM
kgalazka committed rG12c799e0268c: ice(4): Add two more 4-part IDs for E835 adapters.
Sep 1 2026, 9:21 AM
kgalazka committed rGaa85e7aa36bb: ix(4): Sanitize negative error codes (authored by pawel.sobczyk_intel.com).
Sep 1 2026, 9:05 AM
kgalazka committed rG63e9ab9f31df: ix(4): Remove workaround for 2.5/5G speeds on E610.
Sep 1 2026, 9:04 AM
kgalazka committed rGfd35c63a351e: ice(4): Add two more 4-part IDs for E835 adapters.
Sep 1 2026, 8:54 AM

Aug 21 2026

kgalazka added a comment to D59025: ice: Add VF reset and policy failure injection.

Thanks a lot for all your fixes. I'm building an image for our validation team to run some regression tests. I'll get back to you as soon as I get any feedback.

Aug 21 2026, 8:53 PM

Aug 20 2026

kgalazka abandoned D45198: ixl(4): Don't process admin queue when handling ifmedia request.

D54096 resolves that at iflib level.

Aug 20 2026, 4:46 PM
kgalazka committed rG0011cd9f8863: ice(4): Support Total Port Shutdown on E830 devices (authored by pawel.sobczyk_intel.com).
Aug 20 2026, 4:40 PM
kgalazka closed D58149: ice(4): Support Total Port Shutdown on E830 devices.
Aug 20 2026, 4:40 PM

Aug 18 2026

kgalazka committed rG33e2eac3e3e7: ix(4): Sanitize negative error codes (authored by pawel.sobczyk_intel.com).
Aug 18 2026, 8:25 AM
kgalazka closed D57642: ix(4): Sanitize negative error codes.
Aug 18 2026, 8:25 AM

Aug 17 2026

kgalazka committed rGf370d9e4d584: ice(4): Add two more 4-part IDs for E835 adapters.
Aug 17 2026, 3:47 PM
kgalazka closed D57337: ice(4): Add two more 4-part IDs for E835 adapters.
Aug 17 2026, 3:47 PM
kgalazka committed rG62d5d119ee7d: ix(4): Remove workaround for 2.5/5G speeds on E610.
Aug 17 2026, 9:22 AM
kgalazka closed D57339: ix(4): Remove workaround for 2.5/5G speeds on E610.
Aug 17 2026, 9:22 AM

Aug 12 2026

kgalazka added inline comments to D58721: iflib: Complete registration failure cleanup.
Aug 12 2026, 7:56 PM
kgalazka accepted D58720: iflib: Add an admin task detach fail point.

This is great! Both as a patch and as an advertisement for the fail(9). Thank you!

Aug 12 2026, 5:48 PM

Jul 10 2026

kgalazka committed rG6cd16ef19cd2: ice(4): Add support for 40G maximal PMD speed.
Jul 10 2026, 7:31 PM
kgalazka committed rG15ef9ad2f5f4: ice(4): Fix link speed after changing cable type.
Jul 10 2026, 7:16 PM
kgalazka committed rGf2436514b25c: ice(4): Add support for new E810-XXV-2 adapters.
Jul 10 2026, 7:15 PM
kgalazka committed rG074ff66d7ac4: ice(4): Add support for 40G maximal PMD speed.
Jul 10 2026, 7:14 PM
kgalazka committed rGc27a27f45d86: ix(4): Add support for firmware logging for E610 adapters (authored by Yogesh.Bhosale_intel.com).
Jul 10 2026, 2:33 PM
kgalazka committed rG76597c000c7c: ix(4): Add EEE support for E610 adapters.
Jul 10 2026, 2:32 PM
kgalazka committed rG9e1571c3a127: ice(4): Fix link speed after changing cable type.
Jul 10 2026, 2:20 PM
kgalazka committed rGf7a0e893cf15: ice(4): Add support for new E810-XXV-2 adapters.
Jul 10 2026, 2:19 PM
kgalazka committed rG1c9c1a64b240: vmimage.subr: Add ability to install src in VM image.
Jul 10 2026, 2:18 PM

Jul 2 2026

kgalazka committed rG90130f3b3dde: irdma(4): update irdma to version 1.3.56-k (authored by bartosz.sobczak_intel.com).
Jul 2 2026, 3:11 PM

Jun 29 2026

kgalazka requested review of D57942: ixl(4): Fix NVM update API.
Jun 29 2026, 1:02 PM

Jun 26 2026

kgalazka added a member for Intel Networking: milosz.linkiewicz_intel.com.
Jun 26 2026, 8:56 AM

Jun 24 2026

kgalazka added a comment to D57756: ixgbe: restore missed-packet accounting so input drops are visible.

I'm under impression that we use only TC0, but I need to refresh my memory. Do you actually see non-zero values in registers MPC[1-8]?

Jun 24 2026, 8:17 PM · drivers

Jun 12 2026

kgalazka committed rG4ea4116f8d20: vmimage.subr: Add ability to install src in VM image.
Jun 12 2026, 6:22 PM
kgalazka closed D57143: vmimage.subr: Add ability to install src in VM image.
Jun 12 2026, 6:22 PM
kgalazka added a comment to D57537: iflib: Fix mbufs leaked by 0 len packets emitted from the if driver.

Shouldn't this be actually handled by this condition? (https://cgit.freebsd.org/src/tree/sys/net/iflib.c#n2969)

/* was this only a completion queue message? */
if (__predict_false(ri.iri_nfrags == 0))
	continue;

I mean if a packet is discarded does it need to use any iri_frags?

Jun 12 2026, 5:41 PM · network
kgalazka updated subscribers of D57143: vmimage.subr: Add ability to install src in VM image.

@cperciva Could you please take a look?

Jun 12 2026, 12:41 PM
kgalazka committed rG310145642312: ice(4): Fix link speed after changing cable type.
Jun 12 2026, 12:20 PM
kgalazka closed D53611: ice(4): Fix link speed after changing cable type.
Jun 12 2026, 12:19 PM
kgalazka committed rGbea6f7d02dfb: ice(4): Add support for new E810-XXV-2 adapters.
Jun 12 2026, 11:53 AM
kgalazka closed D54069: ice(4): Add support for new E810-XXV-2 adapters.
Jun 12 2026, 11:53 AM

May 29 2026

kgalazka requested review of D57339: ix(4): Remove workaround for 2.5/5G speeds on E610.
May 29 2026, 5:30 PM
kgalazka requested review of D57337: ice(4): Add two more 4-part IDs for E835 adapters.
May 29 2026, 5:21 PM

May 21 2026

kgalazka added a reviewer for D57143: vmimage.subr: Add ability to install src in VM image: releng.

It's submitted also to Forgejo: https://ron-dev.freebsd.org/FreeBSD/src/pulls/32, but I guess Phabricator is still preferred.

May 21 2026, 8:04 AM
kgalazka requested review of D57143: vmimage.subr: Add ability to install src in VM image.
May 21 2026, 7:58 AM

Apr 21 2026

kgalazka committed rGe9d3512bb587: ix(4): Add support for firmware logging for E610 adapters (authored by Yogesh.Bhosale_intel.com).
Apr 21 2026, 8:33 PM

Apr 9 2026

kgalazka added a comment to D55988: ice(4): Fix traffic distribution on TX queues.

I'm testing that with GENERIC so with no RSS option. Without the patch both locally generated (iperf3) and forwarded (pkt-gen) UDP traffic is send using TX 0. I did a quick run on vanilla CURRENT with RSS enabled and it looks that in that case also only one TX queue is used, though it's not always queue 0. I haven't tried IPv6 yet.

Apr 9 2026, 8:01 PM
kgalazka committed rG6b58d10fc6d5: ix(4): Add support for firmware logging for E610 adapters (authored by Yogesh.Bhosale_intel.com).
Apr 9 2026, 6:48 PM
kgalazka closed D53973: ix(4): Add support for firmware logging for E610 adapters.
Apr 9 2026, 6:47 PM

Mar 27 2026

kgalazka committed rGebe529eedb79: ix(4): Add EEE support for E610 adapters.
Mar 27 2026, 11:46 AM

Mar 25 2026

kgalazka updated the diff for D53973: ix(4): Add support for firmware logging for E610 adapters.
  • Add FW logging to features supported and enabled

on E610 adapters.

Mar 25 2026, 5:29 PM

Mar 20 2026

kgalazka requested review of D55988: ice(4): Fix traffic distribution on TX queues.
Mar 20 2026, 9:40 AM
kgalazka closed D55479: irdma(4): update irdma to version 1.3.56-k.
Mar 20 2026, 1:25 AM

Mar 13 2026

kgalazka committed rG5b7aa6c7bc9d: irdma(4): update irdma to version 1.3.56-k (authored by bartosz.sobczak_intel.com).
Mar 13 2026, 12:17 PM
kgalazka committed rG13ee84c591f8: ix(4): Add EEE support for E610 adapters.
Mar 13 2026, 11:54 AM
kgalazka closed D55304: ix(4): Add EEE support for E610 adapters.
Mar 13 2026, 11:54 AM