Intel NetworkingUmbrella
ActivePublic

Details

Description

This is a reviewers group for the Intel Ethernet drivers. Do not add users willy-nilly.

Recent Activity

Mon, Jun 18

manu removed a watcher for Intel Networking: manu.
Mon, Jun 18, 2:59 PM

Thu, Jun 14

scott_freebsdfoundation.org removed a watcher for Intel Networking: scott_freebsdfoundation.org.
Thu, Jun 14, 3:38 PM

Thu, Jun 7

erj closed D15558: iflib: Record TCP checksum info in iflib for ixl(4).
Thu, Jun 7, 1:09 PM · Intel Networking

Mon, Jun 4

gallatin accepted D15558: iflib: Record TCP checksum info in iflib for ixl(4).

Sure.. Those checks for TCP in the TSO case should probably turn into asserts eventually..

Mon, Jun 4, 8:13 PM · Intel Networking
erj added a comment to D15558: iflib: Record TCP checksum info in iflib for ixl(4).

@gallatin I'm assuming you no longer have any objections to this patch?

Mon, Jun 4, 5:55 PM · Intel Networking
prakashs0234_gmail.com added a watcher for Intel Networking: prakashs0234_gmail.com.
Mon, Jun 4, 5:45 AM

Tue, May 29

shurd accepted D15558: iflib: Record TCP checksum info in iflib for ixl(4).

lgtm

Tue, May 29, 4:42 PM · Intel Networking

Sat, May 26

erj added a dependent revision for D15558: iflib: Record TCP checksum info in iflib for ixl(4): D15577: Update ixl(4) to use iflib..
Sat, May 26, 1:20 AM · Intel Networking

Fri, May 25

erj updated the diff for D15558: iflib: Record TCP checksum info in iflib for ixl(4).
  • iflib: Move stats increment in IPv6 case to match IPv4 case
Fri, May 25, 11:18 PM · Intel Networking
erj added inline comments to D15558: iflib: Record TCP checksum info in iflib for ixl(4).
Fri, May 25, 11:17 PM · Intel Networking
erj updated the diff for D15558: iflib: Record TCP checksum info in iflib for ixl(4).
  • iflib: Remove comment and restore/fix setting CSUM_IP6_TCP flag during TSO6
Fri, May 25, 10:52 PM · Intel Networking
gallatin requested changes to D15558: iflib: Record TCP checksum info in iflib for ixl(4).
Fri, May 25, 8:27 PM · Intel Networking
gallatin added a comment to D15558: iflib: Record TCP checksum info in iflib for ixl(4).

Was this the patch that we discussed on our call? Does this fix your TX checksum problems on IXL?

Yes and Yes.

Unfortunately, I've now proceeded to the "entire box hangs" portion of the game. Even serial console break-to-debugger is ignored. I'm going to try NMIs next..

Fri, May 25, 8:18 PM · Intel Networking
erj added inline comments to D15558: iflib: Record TCP checksum info in iflib for ixl(4).
Fri, May 25, 7:52 PM · Intel Networking
shurd added a comment to D15558: iflib: Record TCP checksum info in iflib for ixl(4).

Looks good, but not forcing CSUM_TCP_IPV6 for TSO6 may need a closer look.

Fri, May 25, 7:34 PM · Intel Networking

May 24 2018

erj updated the diff for D15558: iflib: Record TCP checksum info in iflib for ixl(4).
  • iflib: Fixup changes made to record TCP checksum info in iflib for ixl
May 24 2018, 9:27 PM · Intel Networking
jeffrey.e.pieper_intel.com added a comment to D15558: iflib: Record TCP checksum info in iflib for ixl(4).

Was this the patch that we discussed on our call? Does this fix your TX checksum problems on IXL?

Yes and Yes.

Unfortunately, I've now proceeded to the "entire box hangs" portion of the game. Even serial console break-to-debugger is ignored. I'm going to try NMIs next..

May 24 2018, 7:17 PM · Intel Networking
shurd added inline comments to D15558: iflib: Record TCP checksum info in iflib for ixl(4).
May 24 2018, 7:13 PM · Intel Networking
erj updated the summary of D15558: iflib: Record TCP checksum info in iflib for ixl(4).
May 24 2018, 6:30 PM · Intel Networking
gallatin added a comment to D15558: iflib: Record TCP checksum info in iflib for ixl(4).

Was this the patch that we discussed on our call? Does this fix your TX checksum problems on IXL?

May 24 2018, 6:20 PM · Intel Networking
erj added 1 blocking reviewer(s) for D15558: iflib: Record TCP checksum info in iflib for ixl(4): shurd.
May 24 2018, 6:20 PM · Intel Networking
sbruno added a comment to D15558: iflib: Record TCP checksum info in iflib for ixl(4).

Was this the patch that we discussed on our call? Does this fix your TX checksum problems on IXL?

May 24 2018, 6:17 PM · Intel Networking
erj created D15558: iflib: Record TCP checksum info in iflib for ixl(4).
May 24 2018, 6:16 PM · Intel Networking

Feb 7 2018

erj added a member for Intel Networking: jeb.
Feb 7 2018, 11:07 PM

Jan 3 2018

erj abandoned D7802: ixl(4)/ixlv(4): MFC 1.4.27-k and fixes to stable/10.

@erj Do you want to abandon this review in light of your work on newer releases?

Jan 3 2018, 9:22 PM · Intel Networking

Dec 24 2017

kbowling added a watcher for Intel Networking: kbowling.
Dec 24 2017, 6:21 AM

Dec 22 2017

sbruno added a comment to D7802: ixl(4)/ixlv(4): MFC 1.4.27-k and fixes to stable/10.

@erj Do you want to abandon this review in light of your work on newer releases?

Dec 22 2017, 8:05 PM · Intel Networking

Nov 16 2017

sbruno closed D12180: sysutils/intel-nvmupdate: Update to 6.01.
Nov 16 2017, 9:54 PM · Intel Networking
sbruno closed D12179: net/intel-ixl-kmod: Update to 1.8.1.
Nov 16 2017, 9:52 PM · Intel Networking
sbruno closed D13085: sysutils/intel-qcu: Update to 2.30.16.8.
Nov 16 2017, 9:48 PM · Intel Networking
sbruno accepted D12180: sysutils/intel-nvmupdate: Update to 6.01.

Yep, looks good. Thanks!

Nov 16 2017, 7:22 PM · Intel Networking
kozlov.sergey.404_gmail.com added inline comments to D12180: sysutils/intel-nvmupdate: Update to 6.01.
Nov 16 2017, 6:04 PM · Intel Networking
swills accepted D12180: sysutils/intel-nvmupdate: Update to 6.01.

LGTM

Nov 16 2017, 4:50 PM · Intel Networking
swills accepted D12179: net/intel-ixl-kmod: Update to 1.8.1.

Looks fine to me.

Nov 16 2017, 4:42 PM · Intel Networking

Nov 15 2017

kozlov.sergey.404_gmail.com updated the diff for D12180: sysutils/intel-nvmupdate: Update to 6.01.

This seems ugly to me, but that's the only way it works. ${CHMOD} -R doesn't do the right thing on 10.

Nov 15 2017, 4:48 PM · Intel Networking
kozlov.sergey.404_gmail.com planned changes to D12180: sysutils/intel-nvmupdate: Update to 6.01.

I was able to reproduce the build issue as well using poudriere 3.2.
The inconsistency in behavior is caused by this commit, which is in 11, but not in 10: https://svnweb.freebsd.org/base?view=revision&revision=283997
After the distfile is unpacked - extract-fixup-modes target from bsd.port.mk tries to fix the permissions on the directories, but on 10 it does that only for the top level directory, so it can't look into the inner one.

Nov 15 2017, 1:05 PM · Intel Networking

Nov 14 2017

jeffrey.e.pieper_intel.com added a comment to D12180: sysutils/intel-nvmupdate: Update to 6.01.

looking at the packages from Intel Download Center, I think this is a tool build issue. It looks like file permissions changed between 5.05 and 6.01. In 5.05 the directory structure for nvmupdate is 755, but in 6.01 it is 644, which for some reason 10 doesn't like.

Nov 14 2017, 8:24 PM · Intel Networking
sbruno accepted D13085: sysutils/intel-qcu: Update to 2.30.16.8.

Builds. Untested at this time.

Nov 14 2017, 7:43 PM · Intel Networking
sbruno added a reviewer for D13085: sysutils/intel-qcu: Update to 2.30.16.8: swills.
Nov 14 2017, 7:40 PM · Intel Networking
sbruno accepted D12179: net/intel-ixl-kmod: Update to 1.8.1.
Nov 14 2017, 7:39 PM · Intel Networking
sbruno added a reviewer for D12179: net/intel-ixl-kmod: Update to 1.8.1: swills.
Nov 14 2017, 7:39 PM · Intel Networking
sbruno added a comment to D12180: sysutils/intel-nvmupdate: Update to 6.01.

Odd, I get a wierd chmod error on FreeBSD 10 when building this port. On 11/12 it builds fine:

Nov 14 2017, 7:38 PM · Intel Networking
sbruno added a reviewer for D12180: sysutils/intel-nvmupdate: Update to 6.01: swills.
Nov 14 2017, 7:37 PM · Intel Networking
kozlov.sergey.404_gmail.com added a reviewer for D13085: sysutils/intel-qcu: Update to 2.30.16.8: Intel Networking.
Nov 14 2017, 3:01 PM · Intel Networking
kozlov.sergey.404_gmail.com added a reviewer for D12180: sysutils/intel-nvmupdate: Update to 6.01: Intel Networking.
Nov 14 2017, 3:01 PM · Intel Networking
kozlov.sergey.404_gmail.com added a reviewer for D12179: net/intel-ixl-kmod: Update to 1.8.1: Intel Networking.
Nov 14 2017, 3:01 PM · Intel Networking
kozlov.sergey.404_gmail.com created D13085: sysutils/intel-qcu: Update to 2.30.16.8.
Nov 14 2017, 2:48 PM · Intel Networking

Nov 13 2017

kozlov.sergey.404_gmail.com updated the diff for D12180: sysutils/intel-nvmupdate: Update to 6.01.

Updated to a newer, silently updated version. Ready for review.

Nov 13 2017, 3:20 PM · Intel Networking
kozlov.sergey.404_gmail.com updated the diff for D12179: net/intel-ixl-kmod: Update to 1.8.1.

Updated to 1.8.1, unbroken. Ready for review.

Nov 13 2017, 3:17 PM · Intel Networking
kozlov.sergey.404_gmail.com retitled D12179: net/intel-ixl-kmod: Update to 1.8.1 from net/intel-ixl-kmod: Update to 1.7.12.1 to net/intel-ixl-kmod: Update to 1.8.1.
Nov 13 2017, 3:16 PM · Intel Networking