Page MenuHomeFreeBSD

Intel NetworkingUmbrella
ActivePublic

Details

Description

This is a reviewers group for the Intel Ethernet drivers. Do not add users willy-nilly.

Recent Activity

Thu, Sep 20

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Fix filter handling when SR-IOV is enabled
  • Revert "iflib: Free RX queue TCP LRO memory on unload"
Thu, Sep 20, 5:40 PM · Intel Networking

Thu, Sep 13

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Fix compile error introduced by previous commit
Thu, Sep 13, 11:10 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Configure promiscuous mode during driver init
Thu, Sep 13, 11:00 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Disable queues before initialization.
Thu, Sep 13, 6:00 PM · Intel Networking

Wed, Sep 12

erj added a comment to D16428: iflib: Changes for ixlv(4) update.

I'm confused; this is just doing a normal store / load for the in detach - you need a lock to serialize reading it with other operations.

Wed, Sep 12, 9:42 PM · Intel Networking

Tue, Sep 11

erj closed D17061: ix(4), ixv(4): Add VLAN tag strip check when receiving packets; ixv(4): Fix support for VLAN_HWTAGGING and VLAN_HWFILTER flags.
Tue, Sep 11, 6:33 PM · Intel Networking
jeffrey.e.pieper_intel.com accepted D17061: ix(4), ixv(4): Add VLAN tag strip check when receiving packets; ixv(4): Fix support for VLAN_HWTAGGING and VLAN_HWFILTER flags.

Tested with a RHEL7.4 host w/ KVM using both port and host-based VLANs w/ 9710 MTU.

Tue, Sep 11, 1:19 PM · Intel Networking

Fri, Sep 7

cperciva accepted D17061: ix(4), ixv(4): Add VLAN tag strip check when receiving packets; ixv(4): Fix support for VLAN_HWTAGGING and VLAN_HWFILTER flags.

Works in all of my testing. Please commit!

Fri, Sep 7, 6:32 PM · Intel Networking

Thu, Sep 6

piotr.pietruszewski_intel.com added a reviewer for D17061: ix(4), ixv(4): Add VLAN tag strip check when receiving packets; ixv(4): Fix support for VLAN_HWTAGGING and VLAN_HWFILTER flags: cperciva.
Thu, Sep 6, 1:58 PM · Intel Networking
piotr.pietruszewski_intel.com added reviewers for D17061: ix(4), ixv(4): Add VLAN tag strip check when receiving packets; ixv(4): Fix support for VLAN_HWTAGGING and VLAN_HWFILTER flags: Intel Networking, lukasz.szczepaniak_intel.com.
Thu, Sep 6, 1:19 PM · Intel Networking

Tue, Sep 4

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Swap MALLOC_DEFINE/DECLARE statements
  • ixlv(4): Remove commented out code
  • ixlv(4): Check return value of ixlv_add_mac_filter when adding MC addresses
  • ixlv(4): Update some debug printf()'s to use newer debug functions
  • ixlv(4): malloc() the correct size for the heads of the MAC/vlan filter lists
Tue, Sep 4, 11:33 PM · Intel Networking

Fri, Aug 31

erj updated the diff for D16428: iflib: Changes for ixlv(4) update.
  • iflib: Destroy state lock at end of iflib_device_deregister()
  • iflib: Move ifc_in_detach variable to flag in if_ctx_t's ifc_flags, and lock around it
Fri, Aug 31, 12:05 AM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • iflib: Destroy state lock at end of iflib_device_deregister()
  • iflib: Move ifc_in_detach variable to flag in if_ctx_t's ifc_flags, and lock around it
  • ixl(4): Fix kernel panic during init() when Admin Queue is not alive
Fri, Aug 31, 12:01 AM · Intel Networking

Mon, Aug 27

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl/ixlv Missing semicolon in DWB fix
Mon, Aug 27, 3:43 PM · Intel Networking

Aug 25 2018

mmacy added a comment to D16428: iflib: Changes for ixlv(4) update.

I'm confused; this is just doing a normal store / load for the in detach - you need a lock to serialize reading it with other operations.

Aug 25 2018, 7:11 PM · Intel Networking

Aug 23 2018

erj added inline comments to D16428: iflib: Changes for ixlv(4) update.
Aug 23 2018, 11:55 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Fix memory leak when head writeback is disabled
Aug 23 2018, 9:22 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl/ixlv(4): Fix TXD credits update for DWB mode
Aug 23 2018, 5:56 PM · Intel Networking

Aug 22 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Make ixlv_if_init() and ixlv_stop() wait for ENABLE/DISABLE queue command completion
  • ixl(4): Cosmetic change to message PF sends in reply to VF promiscuous config message
Aug 22 2018, 12:48 AM · Intel Networking

Aug 21 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Fix RX MDD event display
  • ixl/ixlv(4): Add more MPASS statements to TX path
Aug 21 2018, 12:42 AM · Intel Networking

Aug 17 2018

gallatin added inline comments to D16429: ixlv(4): Update to use iflib.
Aug 17 2018, 7:35 PM · Intel Networking

Aug 16 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Enhance Malicious Driver Detection messages with VF information
  • ixl(4): Print out additional event information when a LAN Overflow Event occurs
  • ixl/ixlv(4): Add additional MPASS() asserts to the driver TX path
Aug 16 2018, 11:45 PM · Intel Networking

Aug 14 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Change remaining M_DEVBUF malloc types to M_IXLV
  • ixlv(4): Fix a memory leak when interrupt setup fails
  • ixlv(4): Convert some malloc()'s to M_WAITOK from M_NOWAIT
  • ixlv(4): Remove comments and commented out code
  • ixlv(4): Remove list of media types displayed in "ifconfig -m"
Aug 14 2018, 12:03 AM · Intel Networking
erj updated the diff for D16428: iflib: Changes for ixlv(4) update.
  • iflib: Free remaining interrupt resources on failure in iflib_device_register()
  • iflib: Free RX queue TCP LRO memory on unload
Aug 14 2018, 12:02 AM · Intel Networking

Aug 10 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl/ixlv(4): Fix panic when receiving jumbo frame (>4k mtu) traffic
Aug 10 2018, 5:37 PM · Intel Networking
jeffrey.e.pieper_intel.com requested changes to D16429: ixlv(4): Update to use iflib.

Several outstanding issues:

Aug 10 2018, 4:20 PM · Intel Networking
gallatin accepted D16429: ixlv(4): Update to use iflib.
Aug 10 2018, 3:41 PM · Intel Networking

Aug 9 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Fix compile error when PCI_IOV isn't defined
Aug 9 2018, 10:24 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.

Changes from D16428:

  • iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach
  • iflib: Add STATE_LOCK() around flag setting in iflib_request_reset()

New changes for D16429:

  • ixl(4): Add tunable to enable VF loopback; enable by default
  • ixl/ixlv(4): Fix dev.ixl/v.#.vsi.rxq#.bytes sysctl not incrementing
Aug 9 2018, 6:41 PM · Intel Networking
erj updated the diff for D16428: iflib: Changes for ixlv(4) update.
  • iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach
  • iflib: Add STATE_LOCK() around flag setting in iflib_request_reset()
Aug 9 2018, 6:39 PM · Intel Networking

Aug 3 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Lie to the VF about configuring promiscuous mode if VF isn't allowed to configure it
Aug 3 2018, 6:33 PM · Intel Networking

Aug 2 2018

erj added a comment to D16429: ixlv(4): Update to use iflib.

@gallatin, I address your specific comments, but I would need to look through ixlvc.c some more to find more code that can be shared. There is almost certainly some in there that can be shared between the PF/VF drivers.

Aug 2 2018, 8:48 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Combine PF-only/VF-only ixl_disable_rings() in PF driver into one function.
  • Remove a space
Aug 2 2018, 8:47 PM · Intel Networking
erj planned changes to D16428: iflib: Changes for ixlv(4) update.

I need to add the state lock to iflib_request_reset

Aug 2 2018, 5:08 PM · Intel Networking

Jul 30 2018

gallatin added a comment to D16429: ixlv(4): Update to use iflib.

In general, I looked around at ixlv.c, and it looks like there are many functions for the main pf which are identical, or nearly identical for the VF. Can we please work on collapsing them down to common code?

Jul 30 2018, 4:32 PM · Intel Networking

Jul 27 2018

skozlov added a member for Intel Networking: lukasz.szczepaniak_intel.com.
Jul 27 2018, 8:22 AM

Jul 26 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Fix module Makefile when PCI_IOV is enabled
Jul 26 2018, 9:08 PM · Intel Networking

Jul 25 2018

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Use same TX DMA seg sizes as the ones in ixl(4)
  • ixl/ixlv(4): Preserve code removal done in r336313
Jul 25 2018, 7:59 PM · Intel Networking
sbruno accepted D16428: iflib: Changes for ixlv(4) update.
Jul 25 2018, 6:16 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Remove old/dead code
Jul 25 2018, 6:02 PM · Intel Networking
erj added a reviewer for D16429: ixlv(4): Update to use iflib: gallatin.
Jul 25 2018, 4:25 PM · Intel Networking
erj added a reviewer for D16428: iflib: Changes for ixlv(4) update: mmacy.
Jul 25 2018, 4:25 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Re-add driver to GENERIC and build files
  • ixl/ixlv(4): Fix module Makefiles
Jul 25 2018, 4:22 PM · Intel Networking

Jul 24 2018

erj updated the summary of D16429: ixlv(4): Update to use iflib.
Jul 24 2018, 6:38 PM · Intel Networking
erj created D16429: ixlv(4): Update to use iflib.
Jul 24 2018, 6:37 PM · Intel Networking
erj created D16428: iflib: Changes for ixlv(4) update.
Jul 24 2018, 6:34 PM · Intel Networking

Jun 18 2018

manu removed a watcher for Intel Networking: manu.
Jun 18 2018, 2:59 PM

Jun 14 2018

scott_freebsdfoundation.org removed a watcher for Intel Networking: scott_freebsdfoundation.org.
Jun 14 2018, 3:38 PM

Jun 7 2018

erj closed D15558: iflib: Record TCP checksum info in iflib for ixl(4).
Jun 7 2018, 1:09 PM · Intel Networking

Jun 4 2018

gallatin accepted D15558: iflib: Record TCP checksum info in iflib for ixl(4).

Sure.. Those checks for TCP in the TSO case should probably turn into asserts eventually..

Jun 4 2018, 8:13 PM · Intel Networking